Builder mac-views-rel
Build 14081
Results:
Internal Failure
Trigger Info:
Project | chromium |
Revision | 15f7cf85bc1fb76e51e58cea68e6fc183aa5fbde |
Execution:
- Source: Task 4297e7b45b4e1810
- Recipe: chromium
Build Properties:
Name | Value | Source |
---|
Blamelist:
- David Jean (djeanohnoyoudont@google.com)
- edchin (edchinohnoyoudont@chromium.org)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
- Mike Dougherty (michaeldoohnoyoudont@chromium.org)
- Wez (wezohnoyoudont@chromium.org)
- Lei Zhang (thestigohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Mingyun Li (mekialiohnoyoudont@google.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Yao Xiao (yaoxiaohnoyoudont@chromium.org)
- Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
- Christopher Cameron (ccameronohnoyoudont@chromium.org)
- Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
- Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Tsuyoshi Horo (horoohnoyoudont@chromium.org)
- Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
- Ken Rockot (rockotohnoyoudont@google.com)
- Lei Zhang (thestigohnoyoudont@chromium.org)
- Zhenyao Mo (zmoohnoyoudont@chromium.org)
- Seth Hampson (shampsonohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- CJ DiMeglio (lethalantidoteohnoyoudont@chromium.org)
- Tommy Steimel (steimelohnoyoudont@chromium.org)
- Jarryd (jarrydgohnoyoudont@chromium.org)
- Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
- Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
- Renjie (renjietangohnoyoudont@chromium.org)
- dpapad (dpapadohnoyoudont@chromium.org)
- Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
- Nick Harper (nharperohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Albert J. Wong (ajwongohnoyoudont@chromium.org)
- David Staessens (dstaessensohnoyoudont@chromium.org)
- Christopher Cameron (ccameronohnoyoudont@chromium.org)
- Tsuyoshi Horo (horoohnoyoudont@chromium.org)
- Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
- David Schinazi (dschinaziohnoyoudont@chromium.org)
- Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Piotr Bialecki (bialpioohnoyoudont@chromium.org)
- rbpotter (rbpotterohnoyoudont@chromium.org)
- Seth Hampson (shampsonohnoyoudont@chromium.org)
- Chris Harrelson (chrishtrohnoyoudont@chromium.org)
- Martin Kreichgauer (martinkrohnoyoudont@google.com)
- Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
- Manu Cornet (manucornetohnoyoudont@chromium.org)
- Takuto Ikuta (tikutaohnoyoudont@chromium.org)
- Chris Blume (cblumeohnoyoudont@chromium.org)
- Madeleine Barowsky (mbarowskyohnoyoudont@chromium.org)
- Fabrice de Gans-Riberi (fdegansohnoyoudont@chromium.org)
- Karan Bhatia (karandeepbohnoyoudont@chromium.org)
- Ken Rockot (rockotohnoyoudont@google.com)
- Joel Einbinder (einbinderohnoyoudont@chromium.org)
- Kentaro Hara (harakenohnoyoudont@chromium.org)
- Alexey Baskakov (loysoohnoyoudont@chromium.org)
- Timothy Loh (timlohohnoyoudont@chromium.org)
- Timothy Loh (timlohohnoyoudont@chromium.org)
- Sam McNally (sammcohnoyoudont@chromium.org)
- Alexey Baskakov (loysoohnoyoudont@chromium.org)
- Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
- Timothy Loh (timlohohnoyoudont@chromium.org)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Jamie Madill (jmadillohnoyoudont@chromium.org)
- Luciano Pacheco (lucmultohnoyoudont@chromium.org)
- Chris Mumford (cmumfordohnoyoudont@google.com)
- Kristi Park (kristiparkohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Jun Mukai (mukaiohnoyoudont@chromium.org)
- Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
- Aaron Colwell (acolwellohnoyoudont@google.com)
- Alexey Baskakov (loysoohnoyoudont@chromium.org)
- Hadi Moshayedi (moshayediohnoyoudont@chromium.org)
- Karan Bhatia (karandeepbohnoyoudont@chromium.org)
- chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
- Michael Martis (martisohnoyoudont@chromium.org)
- Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
- Eliot Courtney (edcourtneyohnoyoudont@google.com)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Mehran Mahmoudi (mahmoudiohnoyoudont@google.com)
- Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
- Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
- James Cook (jamescookohnoyoudont@chromium.org)
- Sky Malice (skymohnoyoudont@chromium.org)
- Stuart Langley (slangleyohnoyoudont@google.com)
- David Staessens (dstaessensohnoyoudont@chromium.org)
- Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
- David Staessens (dstaessensohnoyoudont@chromium.org)
- Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
- Kelvin Jiang (kelvinjiangohnoyoudont@chromium.org)
- Scott Violet (skyohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Stephen Martinis (martinissohnoyoudont@chromium.org)
- danakj (danakjohnoyoudont@chromium.org)
- Seth Hampson (shampsonohnoyoudont@chromium.org)
- Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
- Peter Boström (pbosohnoyoudont@chromium.org)
- <blame list capped at 100 commits> ()
Timing:
Create | Thursday, 24-Jan-19 08:59:45 UTC |
Start | N/A |
End | Thursday, 24-Jan-19 08:59:46 UTC |
Pending | 967 ms |
Execution | N/A |
All Changes:
-
[ios] disable manual fallback in incognito mode
Changed by David Jean - djeanohnoyoudont@google.com Changed at Thursday, 24-Jan-19 08:58:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 15f7cf85bc1fb76e51e58cea68e6fc183aa5fbde Comments
[ios] disable manual fallback in incognito mode Right now two formInputAccessoryViews are (lazily) created for normal and incognito, and the second one created (in this case incognito) remains on top when going back to the other mode. This CL disables the incognito one until it can be fixed properly. Bug: 923857 Change-Id: I97e56dffe66a1864aad028df28870948c9f28874 Reviewed-on: https://chromium-review.googlesource.com/c/1429041 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#625567}
Changed files
- ios/chrome/browser/ui/main/browser_coordinator.mm
-
[ios] #include base/logging.h
Changed by edchin - edchinohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 08:55:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e4862f5e3eef7c451bdc6a7d69e0ceb0dfe9ce56 Comments
[ios] #include base/logging.h All code outside of ios/ uses #include for base/logging.h. While our style guide allows for both #include and #import in ios/, consistency with all other platforms should take precedence. To be consistent with other platforms, #include should be used for base/logging.h, even in the ios\ folder. Bug: 923973 Change-Id: I51172b7450215a53a0d693f6d9c9f9f6e6ef1bff Reviewed-on: https://chromium-review.googlesource.com/c/1429241 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625566}
Changed files
- ios/chrome/browser/find_in_page/find_in_page_controller.mm
- ios/chrome/browser/ui/UIView+SizeClassSupport.mm
- ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm
- ios/chrome/browser/ui/broadcaster/chrome_broadcaster.mm
- ios/chrome/browser/ui/browser_container/browser_container_coordinator.mm
- ios/chrome/browser/ui/collection_view/cells/collection_view_item.mm
- ios/chrome/browser/ui/download/download_manager_coordinator.mm
- ios/chrome/browser/ui/list_model/list_item.mm
- ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm
- ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm
- ios/chrome/browser/ui/safe_mode/safe_mode_coordinator.mm
- ios/chrome/browser/ui/settings/reauthentication_module.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_cell.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_item.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
- ios/chrome/browser/ui/tab_grid/tab_grid_adaptor.mm
- ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm
- ios/chrome/browser/ui/table_view/cells/table_view_header_footer_item.mm
- ios/chrome/browser/ui/table_view/cells/table_view_item.mm
- ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller.mm
- ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm
- ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm
- ios/chrome/browser/ui/toolbar_container/toolbar_height_range.mm
- ios/chrome/browser/ui/translate/language_selection_coordinator.mm
- ios/chrome/browser/ui/translate/language_selection_view_controller.mm
- ios/chrome/browser/ui/util/property_animator_group.mm
- ios/chrome/browser/ui/util/transparent_link_button.mm
- ios/showcase/common/protocol_alerter.mm
- ios/showcase/core/showcase_view_controller.mm
- ios/showcase/test/showcase_test_case.mm
-
Update V8 to version 7.3.493.
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 08:47:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 45187b538b738100de99b1efa48639edff830228 Comments
Update V8 to version 7.3.493. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9df9418e..12af2fff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2a5b1f8c6b8085f81fcf227eb4637a48b87c5bad Reviewed-on: https://chromium-review.googlesource.com/c/1432938 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625565}
Changed files
- DEPS
-
Worker: Determine "destination" for worker main script fetch based on global scope type
Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 08:46:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9db00863ed5767f024035de5e83ab6a801ed8ca1 Comments
Worker: Determine "destination" for worker main script fetch based on global scope type Before this CL, "destination" for worker main script fetch is hard-coded as WORKER (dedicated workers) in WorkerGlobalScope::ImportClassicScript(). This has correctly been worked because the function is called only for off-the-main-thread dedicated worker script fetch. However, to implement off-the-main-thread shared/service worker script fetch, "destination" should be determined based on the global scope type. Specifically, the function should specify SHARED_WORKER for shared workers and SERVICE_WORKER for service workers. To achieve it, this CL introduces GetDestinationForMainScript() in WorkerOrWorkletGlobalScope as a pure virtual function. Each descendant of the class is required to return an appropriate destination for its main script fetch. Bug: 924041, 924043 Change-Id: Icd7ddd8cda72ed0b6babe665f685ce1f6aba1833 Reviewed-on: https://chromium-review.googlesource.com/c/1433334 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625564}
Changed files
- third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
- third_party/blink/renderer/core/workers/dedicated_worker_global_scope.h
- third_party/blink/renderer/core/workers/experimental/thread_pool_thread.cc
- third_party/blink/renderer/core/workers/shared_worker_global_scope.cc
- third_party/blink/renderer/core/workers/shared_worker_global_scope.h
- third_party/blink/renderer/core/workers/worker_global_scope.cc
- third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
- third_party/blink/renderer/core/workers/worker_thread_test_helper.h
- third_party/blink/renderer/core/workers/worklet_global_scope.cc
- third_party/blink/renderer/core/workers/worklet_global_scope.h
- third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
- third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
-
Clear chrome://inspect logs for closed tabs.
Changed by Mike Dougherty - michaeldoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 08:40:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8b53ddaf9d7da2e5278d02a550791cd297789602 Comments
Clear chrome://inspect logs for closed tabs. It may be unexpected that urls and logs remain on the chrome://inspect page after the associated tab has been closed. This change removes that information on tab closure which should more closely resemble user expectations. Bug: 922243 Change-Id: Ia0740decb41e7ea004bb31f4cbc0bd7aa144d79d Reviewed-on: https://chromium-review.googlesource.com/c/1433138 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#625563}
Changed files
- ios/chrome/app/resources/inspect/inspect.js
- ios/chrome/browser/ui/webui/inspect/inspect_ui.mm
- ios/chrome/browser/ui/webui/inspect/inspect_ui_egtest.mm
-
[Fuchsia] Remove stale entries from content_unittests filter.
Changed by Wez - wezohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 08:38:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d94e9386463943a140422e40fca32abd2c6cde9c Comments
[Fuchsia] Remove stale entries from content_unittests filter. These tests have moved into components_unittests, so remove them from the content_unittests filter file. Bug: 759853 Change-Id: I3630c2157d83ebc19092b715b408b72bb3d8963e Reviewed-on: https://chromium-review.googlesource.com/c/1424160 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625562}
Changed files
- testing/buildbot/filters/fuchsia.content_unittests.filter
-
Call PrinterQuery::StopWorker() on the right thread.
Changed by Lei Zhang - thestigohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 08:38:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bac6a6cd27a8ba1f1e974d8a954f188b225c1ff0 Comments
Call PrinterQuery::StopWorker() on the right thread. PrinterQuery mostly lives on the IO thread and most StopWorker() callers are on the IO thread. The one place that calls StopWorker() from the UI thread is PrintViewManagerBase::OnPrintSettingsDone(). Change it to use PostTask() to call StopWorker() on the IO thread. Change-Id: I7e4fbfe39260836eaa5cda3db6e044e4c10490bf Reviewed-on: https://chromium-review.googlesource.com/c/1432477 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625561}
Changed files
- chrome/browser/printing/print_view_manager_base.cc
-
Roll src/third_party/skia a6ab2bdd8cd3..094ab18b457e (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 08:35:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e48fac60f1f88cb64f22718e78800937ace89a17 Comments
Roll src/third_party/skia a6ab2bdd8cd3..094ab18b457e (1 commits) https://skia.googlesource.com/skia.git/+log/a6ab2bdd8cd3..094ab18b457e git log a6ab2bdd8cd3..094ab18b457e --date=short --no-merges --format='%ad %ae %s' 2019-01-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@094ab18b457e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I8288d4d215601f277f5efa2dbc148b866ee674dd Reviewed-on: https://chromium-review.googlesource.com/c/1433437 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625560}
Changed files
- DEPS
-
Add |bounces| to cwv_scroll_view.
Changed by Mingyun Li - mekialiohnoyoudont@google.com Changed at Thursday, 24-Jan-19 08:32:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b14f0f84bd190ac7e45ddb052140b1bbd613757b Comments
Add |bounces| to cwv_scroll_view. The corresponding property is alaready in crw_web_view_scroll_view_proxy. Change-Id: I7cec0ea741b9a0c8415f8a5dcc86e3ec1b800d9b Reviewed-on: https://chromium-review.googlesource.com/c/1433260 Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Mingyun Li <mekiali@google.com> Cr-Commit-Position: refs/heads/master@{#625559}
Changed files
- ios/web_view/internal/cwv_scroll_view.mm
- ios/web_view/public/cwv_scroll_view.h
-
Roll AFDO from 73.0.3681.0_rc-r1 to 73.0.3682.0_rc-r1
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 08:19:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fa4589b13c508cd2b85c0991bb07af09033f0153 Comments
Roll AFDO from 73.0.3681.0_rc-r1 to 73.0.3682.0_rc-r1 This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I5382c1a7b79ee58181bc7c2b78934e11482287f1 Reviewed-on: https://chromium-review.googlesource.com/c/1433441 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625558}
Changed files
- chrome/android/profiles/newest.txt
-
Fixed the download intervention in sandbox for RemoteFrame::Navigate path.
Changed by Yao Xiao - yaoxiaohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 08:09:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4d572e9d38fa4366aefa2f357eb699df7b600fc6 Comments
Fixed the download intervention in sandbox for RemoteFrame::Navigate path. Also, fixed test assertions that verify download is not happening: previously we check the UMA too soon before download decision is made, which may give us false negatives. The fix is to explicitly wait for OnDidFinishSubFrameNavigation(), and check the UMA after the waiting. Bug: 539938 Change-Id: Ib1a829420d68969877454413d0e2c7390a323b21 Reviewed-on: https://chromium-review.googlesource.com/c/1406153 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#625557}
Changed files
- chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
- chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc
- chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h
- content/renderer/render_frame_proxy.cc
- content/renderer/render_frame_proxy.h
- third_party/blink/public/web/web_remote_frame_client.h
- third_party/blink/renderer/core/exported/web_frame_test.cc
- third_party/blink/renderer/core/frame/remote_frame.cc
- third_party/blink/renderer/core/frame/remote_frame_client.h
- third_party/blink/renderer/core/frame/remote_frame_client_impl.cc
- third_party/blink/renderer/core/frame/remote_frame_client_impl.h
- third_party/blink/renderer/core/loader/empty_clients.h
-
[content-service] Fix local view scrolling issue
Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 08:06:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3813e5d355f3720d350a2de6e80e2fd3aefb68cc Comments
[content-service] Fix local view scrolling issue Ensure the embedded window has the same size of owner rather than the same bounds. Bug: b/123097868 Change-Id: I853d9e915f9b798295a5ca83225fb7c38a44bc38 Reviewed-on: https://chromium-review.googlesource.com/c/1432395 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625556}
Changed files
- services/content/public/cpp/navigable_contents_view.cc
-
MacPWAs: Don't create hidden app bundles
Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 08:04:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2b1296b50728325effd1b47d07ffa2bcc7c58666 Comments
MacPWAs: Don't create hidden app bundles PWAs create app bundles in two locations * ~/Application/ * ~/Library/Application\ Support/ The first location is user-visible, and shows up in Launchpad and Spotlight Searches. The ~/Library location is used: * For applications that are created with the option APP_MENU_LOCATION_HIDDEN. * When apps that have been deleted in Finder are launched in Chrome. Neither of these uses belong anymore: * The option APP_MENU_LOCATION_HIDDEN is never specified on macOS. * If the user is launching an app from Chrome, that is indicating that they want to use the app, so we should re-create the shim in ~/Applications. Remove creation, use, deletion, and updating of application shortcuts in Stop using ~/Library. Rename some enums to make behavior more clear. Change-Id: Ide389f81f4f7ea26432b7cd08c4485f79f965825 Reviewed-on: https://chromium-review.googlesource.com/c/1432912 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#625555}
Changed files
- chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
- chrome/browser/web_applications/components/web_app_shortcut_mac.h
- chrome/browser/web_applications/components/web_app_shortcut_mac.mm
- chrome/browser/web_applications/components/web_app_shortcut_mac_unittest.mm
- chrome/browser/web_applications/extensions/web_app_extension_shortcut_mac.mm
-
Revert "Add a base::Feature for Mojo dispatch change"
Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:57:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a1712789c9b2f74d9f43d6dd93ab805b63cf8311 Comments
Revert "Add a base::Feature for Mojo dispatch change" This reverts commit b9991b861d14bb879d0ae47bccbd5781e1a0f27e. Reason for revert: Suspected that this brought race in TSan test MediaSessionImplVisibilityBrowserTestInstances/MediaSessionImplVisibilityBrowserTest.TestEntryPoint/2 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8923473781703816992/+/steps/content_browsertests/0/logs/MediaSessionImplVisibilityBrowserTestInstances__x2f_MediaSessionImplVisibilityBrowserTest.TestEntryPoint__x2f_2__status_FAILURE_ON_EXIT_/0 Original change's description: > Add a base::Feature for Mojo dispatch change > > Adds a new base::Feature to control whether or not Mojo uses the more > granular task-per-message dispatch policy as opposed to the old batch > dispatch behavior. > > This is disabled by default until M73 branch. > > TBR=jam@chromium.org > > Bug: 866708 > Change-Id: I138a66c0d65106f44f153e02c1cf92d71c27d14d > Reviewed-on: https://chromium-review.googlesource.com/c/1433139 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#625514} TBR=jam@chromium.org,rockot@google.com Change-Id: I4b269bf0cd82bd1af68a4ce1f81465c8328fbb32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866708 Reviewed-on: https://chromium-review.googlesource.com/c/1433655 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625554}
Changed files
- mojo/public/cpp/bindings/BUILD.gn
- mojo/public/cpp/bindings/connector.h
- mojo/public/cpp/bindings/features.cc
- mojo/public/cpp/bindings/features.h
- mojo/public/cpp/bindings/lib/connector.cc
-
Import wpt@ef625c6ac28d0ac07ef0c62a6f22c10d14a2623a
Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 07:56:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fb62310cad347d6de4bd32aa6525a456b981bc92 Comments
Import wpt@ef625c6ac28d0ac07ef0c62a6f22c10d14a2623a Using wpt-import in Chromium b39a531368bd6c81b239a05abeea8e0d6642a4c3. With Chromium commits locally applied on WPT: 1061788dd2 "Reland "Add quota usage details tests for all other storage backends."" bcd3934d05 "Add a test for ServiceWorker and AppCache interaction with claim()" 8e4e5d7297 "Fix preload tests failing on wpt.fyi dashboard" f643497e6b "[resource-timing] Modify is_secure_context_ based on resource" 20defaa46c "[LayoutNG] ComputeReplacedSize min/max width/height fix" 05cdb4d1d9 "Add tentative WPT tests for stale while revalidate handling." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I37ab2e74102751cd2a8f6176b893612f646df084 Reviewed-on: https://chromium-review.googlesource.com/c/1432935 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625553}
Changed files
- third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
- third_party/blink/web_tests/external/wpt/payment-request/MerchantValidationEvent/constructor.https.html
- third_party/blink/web_tests/external/wpt/payment-request/PaymentRequestUpdateEvent/constructor.https.html
- third_party/blink/web_tests/external/wpt/payment-request/PaymentRequestUpdateEvent/updateWith-call-immediate-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/PaymentRequestUpdateEvent/updateWith-duplicate-shipping-options-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/PaymentRequestUpdateEvent/updateWith-incremental-update-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/PaymentRequestUpdateEvent/updateWith-method-abort-update-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/PaymentRequestUpdateEvent/updateWith-state-checks-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/PaymentRequestUpdateEvent/updatewith-method.https.html
- third_party/blink/web_tests/external/wpt/payment-request/algorithms-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/billing-address-changed-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/change-shipping-option-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/change-shipping-option-select-last-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/onmerchantvalidation-attribute.https.html
- third_party/blink/web_tests/external/wpt/payment-request/onpaymentmenthodchange-attribute.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-request-abort-method.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-request-canmakepayment-method-protection.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-request-canmakepayment-method.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-request-constructor-crash.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-request-onshippingaddresschange-attribute.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-request-onshippingoptionchange-attribute.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-request-shippingType-attribute.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-request-show-method.https.html
- third_party/blink/web_tests/external/wpt/payment-request/payment-response/helpers.js
- third_party/blink/web_tests/external/wpt/payment-request/payment-response/rejects_if_not_active-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/rejects_if_not_active.https.html
- third_party/blink/web_tests/external/wpt/payment-request/shipping-address-changed-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/show-method-optional-promise-rejects-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/show-method-optional-promise-resolves-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/show-method-postmessage-iframe.html
- third_party/blink/web_tests/external/wpt/payment-request/show-method-postmessage-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/updateWith-method-pmi-handling-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/user-abort-algorithm-manual.https.html
- third_party/blink/web_tests/external/wpt/payment-request/user-accepts-payment-request-algo-manual.https.html
- third_party/blink/web_tests/external/wpt/web-locks/signal.tentative.https.any.js
-
Split sxg-referrer.tentative.https.html
Changed by Tsuyoshi Horo - horoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:48:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fe2a6a46ae4a571a71192ced9ac114012e413f4a Comments
Split sxg-referrer.tentative.https.html This test is too big. So sometimes timeouts on bots. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=sxg-referrer.tentative.https.html Bug: 924752 Change-Id: I3c1df411fadef9f9d67aa41bdf7231aed11f1497 Reviewed-on: https://chromium-review.googlesource.com/c/1433257 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#625552}
Changed files
- third_party/blink/web_tests/TestExpectations
- third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg-util.js
- third_party/blink/web_tests/external/wpt/signed-exchange/sxg-referrer-policy-header.tentative.https.html
- third_party/blink/web_tests/external/wpt/signed-exchange/sxg-referrer-remote-physical-remote-logical.tentative.https.html
- third_party/blink/web_tests/external/wpt/signed-exchange/sxg-referrer-remote-physical-same-logical.tentative.https.html
- third_party/blink/web_tests/external/wpt/signed-exchange/sxg-referrer-same-physical-remote-logical.tentative.https.html
- third_party/blink/web_tests/external/wpt/signed-exchange/sxg-referrer-same-physical-same-logical.tentative.https.html
- third_party/blink/web_tests/external/wpt/signed-exchange/sxg-referrer.tentative.https.html
-
Notify user of HTML validation error messages
Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:46:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 50f6ce8b3cb184f8309545eca3dfb9841c1b04a8 Comments
Notify user of HTML validation error messages Make HTML native validation of form controls accessible A simple example is @required on a form control. Blink provides a helpful message box if the user attempts to submit a form with a required field left empty. The control is also focused. This CL produces an accessible alert for the notification when it appears. Bug: 897039 Change-Id: Ib78ce09821d794c8b35ca151c1f6a153adff9414 Reviewed-on: https://chromium-review.googlesource.com/c/1403980 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#625551}
Changed files
- chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
- content/browser/accessibility/dump_accessibility_events_browsertest.cc
- content/browser/accessibility/dump_accessibility_tree_browsertest.cc
- content/renderer/accessibility/blink_ax_tree_source.cc
- content/test/data/accessibility/aria/aria-alert-expected-mac.txt
- content/test/data/accessibility/aria/aria-alert.html
- content/test/data/accessibility/event/report-validity-invalid-field-expected-mac.txt
- content/test/data/accessibility/event/report-validity-invalid-field-expected-win.txt
- content/test/data/accessibility/event/report-validity-invalid-field.html
- content/test/data/accessibility/html/form-validation-message-expected-blink.txt
- content/test/data/accessibility/html/form-validation-message-expected-mac.txt
- content/test/data/accessibility/html/form-validation-message-expected-win.txt
- content/test/data/accessibility/html/form-validation-message.html
- third_party/blink/public/web/web_ax_object.h
- third_party/blink/renderer/core/accessibility/ax_object_cache.h
- third_party/blink/renderer/core/page/validation_message_client_impl.cc
- third_party/blink/renderer/core/page/validation_message_client_impl.h
- third_party/blink/renderer/modules/accessibility/BUILD.gn
- third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
- third_party/blink/renderer/modules/accessibility/ax_layout_object.h
- third_party/blink/renderer/modules/accessibility/ax_object.h
- third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
- third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
- third_party/blink/renderer/modules/accessibility/ax_validation_message.cc
- third_party/blink/renderer/modules/accessibility/ax_validation_message.h
- third_party/blink/renderer/modules/exported/web_ax_object.cc
-
Revert "Move NoTouchActivity to touchless package"
Changed by Ken Rockot - rockotohnoyoudont@google.com Changed at Thursday, 24-Jan-19 07:41:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3344a6df199b5d0861d46a5d88c8583cbde41a93 Comments
Revert "Move NoTouchActivity to touchless package" This reverts commit 0ebabc86af52b18004b8feb1639ac2d9b07c8c31. Reason for revert: Speculative revert as I'm reasonably sure this made the android-binary-size CQ builder red for almost all builds (it's complaining about AndroidManifest changes and the failures coincide precisely with this CL landing). https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size?cursor=Ci0SJ2oQc35jci1idWlsZGJ1Y2tldHITCxIFQnVpbGQY0P3fi_a2pOt7DBgAIAA%3D&limit=200 Original change's description: > Move NoTouchActivity to touchless package > > Move the NoTouchActivity to the newly created touchless sub-package in order to > declutter and tidy up the browser package. > > Bug: 922047 > Change-Id: Ib7d9df3c89295e9e675b35a05e3613b390fbae5e > Reviewed-on: https://chromium-review.googlesource.com/c/1432473 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Mehran Mahmoudi <mahmoudi@google.com> > Cr-Commit-Position: refs/heads/master@{#625487} TBR=mthiesse@chromium.org,tedchoc@chromium.org,mahmoudi@google.com Change-Id: I93a20aeb64bb61fe798cf56118c1bb9e4b43e17a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922047 Reviewed-on: https://chromium-review.googlesource.com/c/1433597 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#625550}
Changed files
- chrome/android/java/AndroidManifest.xml
- chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
- chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
- chrome/android/java/src/org/chromium/chrome/browser/NoTouchActivity.java
- chrome/android/java_sources.gni
- chrome/android/javatests/src/org/chromium/chrome/browser/NoTouchActivityTest.java
-
Fix a TypeError is pdf_viewer.js.
Changed by Lei Zhang - thestigohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:36:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8d3d8ad36010f3d3050c5b06775ab16418cccda0 Comments
Fix a TypeError is pdf_viewer.js. The object in question is a PromiseResolver, not a function. So it should not be called. Change-Id: Ie9da140e402b844dd39b33ee228008ae363dd2c8 Reviewed-on: https://chromium-review.googlesource.com/c/1433115 Reviewed-by: dstockwell <dstockwell@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625549}
Changed files
- chrome/browser/resources/pdf/pdf_viewer.js
-
Prepare video pixel tests for trace tests.
Changed by Zhenyao Mo - zmoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:35:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cfbc80d5a1746e333f0dc42e4d880addc41cff9d Comments
Prepare video pixel tests for trace tests. Use constant frame four-color video instead. This is because if we want to play the video and do screen capture, it will be flaky if colors vary from frame to frame. Also, wait until video's current time > 0 to do screen capture or other verification, and hopefully this gets rid of flakiness. BUG=867136,869677,774809,716564,921279,860548 TEST=gpu bots R=piman@chromium.org,magchen@chromium.org,dalecurtis@chromium.org Change-Id: I809b433cf5a83b597781dc1d79c944cd88dbf22f Reviewed-on: https://chromium-review.googlesource.com/c/1431392 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Maggie Chen <magchen@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#625548}
Changed files
- chrome/test/BUILD.gn
- content/test/data/gpu/pixel_video_complex_overlays.html
- content/test/data/gpu/pixel_video_mp4.html
- content/test/data/gpu/pixel_video_mp4_four_colors_aspect_4x3.html
- content/test/data/gpu/pixel_video_mp4_four_colors_rot_180.html
- content/test/data/gpu/pixel_video_mp4_four_colors_rot_270.html
- content/test/data/gpu/pixel_video_mp4_four_colors_rot_90.html
- content/test/data/gpu/pixel_video_nonroot.html
- content/test/data/gpu/pixel_video_test.js
- content/test/data/gpu/pixel_video_underlay.html
- content/test/data/gpu/pixel_video_vp9.html
- content/test/gpu/gpu_tests/pixel_expectations.py
- content/test/gpu/gpu_tests/pixel_test_pages.py
- media/test/data/README.md
- media/test/data/four-colors-vp9.webm
-
Configures origin trial for RTCQuicTransport.
Changed by Seth Hampson - shampsonohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:34:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c91aee8268699ae58e391c9f520d6a8b98007643 Comments
Configures origin trial for RTCQuicTransport. Updates to include the RTCQuicTransport and RTCIceTransport in the origin trial. Intent to experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/xXf23VY_8uM/lDBcbf8KAgAJ Bug: 874296 Change-Id: I8b1c41f59a32c37ef1a1dc95ca1e74cfa7c17acb Reviewed-on: https://chromium-review.googlesource.com/c/1430745 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Auto-Submit: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625547}
Changed files
- third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_event.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
- third_party/blink/renderer/platform/runtime_enabled_features.json5
- third_party/blink/web_tests/http/tests/origin_trials/webexposed/rtc-quic-transport-origin-trial-interfaces.html
-
Roll src/third_party/pdfium 3e873fa0184f..b2bab1fee534 (5 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 07:30:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ca1a001a0c3dbf235e727e0e17f246a14f39b486 Comments
Roll src/third_party/pdfium 3e873fa0184f..b2bab1fee534 (5 commits) https://pdfium.googlesource.com/pdfium.git/+log/3e873fa0184f..b2bab1fee534 git log 3e873fa0184f..b2bab1fee534 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 thestig@chromium.org Avoid a crash in CFXJSE_Value::ToString(). 2019-01-23 tsepez@chromium.org [XFA] Apply dynamic type checks to JSE method invocation. 2019-01-23 tsepez@chromium.org Don't trust CJX_Objects handed back from JavaScript. 2019-01-23 tsepez@chromium.org Add CFXJSE_Value::IsEmpty() and use it in SetArray() 2019-01-23 thestig@chromium.org Fix some nits in CFXJSE_Engine. Created with: gclient setdep -r src/third_party/pdfium@b2bab1fee534 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:922864 TBR=dsinclair@chromium.org Change-Id: I15cd1a5e13928f49b3993763667358a1164b0a62 Reviewed-on: https://chromium-review.googlesource.com/c/1432872 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625546}
Changed files
- DEPS
-
Reland "Updates time values to use aria attributes."
Changed by CJ DiMeglio - lethalantidoteohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:28:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a864ff8a387eb55175e655202ba68f7749b1acb7 Comments
Reland "Updates time values to use aria attributes." This is a reland of 61348b6f02c3a00699cc39b0a85005fc876fcf7f Updates tests expectations to wait for volume slider element. Original change's description: > Updates time values to use aria attributes. > > This CL changes the TimeRemaining and TimeElapsed values to use aria > attributes directly instead of explicitly creating accessibility nodes. > > Bug: 836549 > Change-Id: I7036d9e0a2b8f956f3c88bc9e838e2001830400b > Reviewed-on: https://chromium-review.googlesource.com/c/1393843 > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624397} TBR= steimel@chromium.org, alexmos@chromium.org, dmazzoni@chromium.org Bug: 923887 Change-Id: I5d27f072b96e5c15063f71b8d953b415dff87bfa Reviewed-on: https://chromium-review.googlesource.com/c/1431334 Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#625545}
Changed files
- content/app/strings/content_strings.grd
- content/test/data/accessibility/html/audio-expected-auralinux.txt
- content/test/data/accessibility/html/audio.html
- third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_current_time_display_element.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
- third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.h
- third_party/blink/web_tests/media/controls/accessibility-time-element.html
- third_party/blink/web_tests/media/media-controls.js
-
[Global Media Controls] Add MediaKeysListenerManager
Changed by Tommy Steimel - steimelohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:27:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 561c68b1daef2c67896eb9bb464593f01af446b6 Comments
[Global Media Controls] Add MediaKeysListenerManager This CL adds a MediaKeysListenerManager that uses a global MediaKeysListener to receive media key events and then selectively propagates those to registered delegates. In particular, it owns a HardwareKeyMediaController that uses media key events to control the active media session. GlobalShortcutListenerWin is updated to use MediaKeysListenerManager to receive media key events, which allows extensions to prevent the HardwareKeyMediaController from receiving media key events. This CL also makes a slight change to the MediaKeysListener API to allow delegates to know if a key fails to register. Bug: 915420 Change-Id: I6b6111a41c66cf522ffa3ed9f66d90d06b916430 Reviewed-on: https://chromium-review.googlesource.com/c/1379180 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#625544}
Changed files
- chrome/browser/extensions/extension_keybinding_registry.cc
- chrome/browser/extensions/extension_keybinding_registry.h
- chrome/browser/extensions/global_shortcut_listener_win.cc
- chrome/browser/extensions/global_shortcut_listener_win.h
- content/browser/BUILD.gn
- content/browser/browser_main_loop.cc
- content/browser/browser_main_loop.h
- content/browser/media/hardware_key_media_controller.cc
- content/browser/media/hardware_key_media_controller.h
- content/browser/media/media_keys_listener_manager_impl.cc
- content/browser/media/media_keys_listener_manager_impl.h
- content/browser/media/media_keys_listener_manager_impl_browsertest.cc
- content/public/browser/BUILD.gn
- content/public/browser/media_keys_listener_manager.cc
- content/public/browser/media_keys_listener_manager.h
- content/test/BUILD.gn
- ui/base/accelerators/global_media_keys_listener_win.cc
- ui/base/accelerators/global_media_keys_listener_win.h
- ui/base/accelerators/media_keys_listener.h
- ui/base/accelerators/media_keys_listener_mac.mm
-
Quota: Add experimental logic for quota pool size expansion.
Changed by Jarryd - jarrydgohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:26:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7a79f066985af8b740ec5def2552ad42a90c17a7 Comments
Quota: Add experimental logic for quota pool size expansion. Bug: 919693 Change-Id: I99bebbbccf7d57a711e4305faa5a57c01a1e39f5 Reviewed-on: https://chromium-review.googlesource.com/c/1401568 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#625543}
Changed files
- storage/browser/BUILD.gn
- storage/browser/quota/quota_features.cc
- storage/browser/quota/quota_features.h
- storage/browser/quota/quota_settings.cc
- testing/variations/fieldtrial_testing_config.json
-
Add switch to configure gpu memory limit
Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:25:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b03357d74f93f0754b49e91ca71c2bdacafed7ec Comments
Add switch to configure gpu memory limit Bug: 923141 Test: None Change-Id: I0c53c2272eda161a1d2d6ac16b66f260bd72dfd1 Reviewed-on: https://chromium-review.googlesource.com/c/1431133 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#625542}
Changed files
- ui/compositor/compositor.cc
- ui/compositor/compositor_switches.cc
- ui/compositor/compositor_switches.h
-
v8binding: Use the incumbent realm instead of the current realm (Location)
Changed by Yuki Shiino - yukishiinoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:24:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c8f0858abc79b52bfeda23b27d03001a3c89d448 Comments
v8binding: Use the incumbent realm instead of the current realm (Location) Blink has been using the current realm as an approximation to the incumbent realm. Now the incumbent realm is almost ready for real use, so this patch switches to use the incumbent realm. This patch updates Location IDL interface. Bug: 761755 Change-Id: I2070f46a3a86aa02950dd4ca45e6cb0b47f4326a Reviewed-on: https://chromium-review.googlesource.com/c/1425854 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#625541}
Changed files
- third_party/blink/renderer/bindings/IDLExtendedAttributes.txt
- third_party/blink/renderer/core/frame/location.cc
- third_party/blink/renderer/core/frame/location.h
- third_party/blink/renderer/core/frame/location.idl
- third_party/blink/web_tests/external/wpt/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt
- third_party/blink/web_tests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt
- third_party/blink/web_tests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html
- third_party/blink/web_tests/http/tests/security/cross-frame-access-location-get-expected.txt
- third_party/blink/web_tests/http/tests/security/cross-frame-access-location-get-override-expected.txt
- third_party/blink/web_tests/http/tests/security/cross-frame-access-location-get-override.html
- third_party/blink/web_tests/http/tests/security/cross-frame-access-location-get.html
- third_party/blink/web_tests/http/tests/security/cross-frame-access-location-put-expected.txt
-
Landing Recent QUIC changes until 7:50 PM, Jan 18, 2019 UTC-4
Changed by Renjie - renjietangohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:24:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 90e808eea11b79d8794fe4af05a1c5929b7eeaf5 Comments
Landing Recent QUIC changes until 7:50 PM, Jan 18, 2019 UTC-4 log more cert subject name if it has empty SCT list when QUIC uses it to build REJ. Protected by default true flag FLAGS_quic_reloadable_flag_quic_log_cert_name_for_empty_sct. Before logging, leaf cert is parsed to extract subject name, which is new behavior. But it should have been parsed already while processing CHLO. So it's safe to parse again with a default true flag. Merge internal change: 229967221 https://chromium-review.googlesource.com/c/chromium/src/+/1431614 Refactor QuicFramer BuildConnectivityProbingPacket, BuildPaddedPathChallengePacket and BuildPathResponsePacket for v99. Refactoring, only changes QUIC v99, not flag protected. This change is required for further work on adding the IETF QUIC long header length field. Merge internal change: 229784385 https://chromium-review.googlesource.com/c/chromium/src/+/1429220 Bring Http/3 frames up to date with draft 17. Merge internal change: 229783354 https://chromium-review.googlesource.com/c/chromium/src/+/1429119 In QUIC, making sure PacketNumberQueue and PacketNumberIndexedQueue deal with packet number 0 gracefully. Not protected. In our current implementation, we reject packet number 0, no functional change expected from this change. Merge internal change: 229746145 https://chromium-review.googlesource.com/c/chromium/src/+/1429039 Disable source token validation in quic for Quartc. When 0-rtt will be used in Quartc, the source token will not be provided by the client in the 0-rtt full CHLO. Instead, Quartc will tunnel QUIC through ICE, guaranteeing provenance of the packet. Merge internal change: 229739207 https://chromium-review.googlesource.com/c/chromium/src/+/1428900 In QUIC, close connection with QUIC_INVALID_ACK_DATA if receiving an ack which acks packet 0. Protected by ENABLED FLAGS_quic_reloadable_flag_quic_disallow_peer_ack_0. Merge internal change: 229734932 https://chromium-review.googlesource.com/c/chromium/src/+/1428779 Add setting to disable source token verification. When 0-rtt is used in Quartc, the source token will not be provided by the client in the 0-rtt full CHLO. Instead, Quartc will tunnel QUIC through ICE, guaranteeing provenance of the packet. Because of the above, we'd like the ability to disable source token verification. Add setting to disable source token verification. Merge internal change: 229637229 https://chromium-review.googlesource.com/c/chromium/src/+/1428481 In QUIC, when a packet is received, populate the header->packet_number field only if the full packet number is not 0. No functional change expected, not protected. Merge internal change: 229597882 https://chromium-review.googlesource.com/c/chromium/src/+/1428679 Deprecate gfe2_restart_flag_quic_use_async_key_exchange Merge internal change: 229596530 https://chromium-review.googlesource.com/c/chromium/src/+/1428580 Disable padding during crypto handshake in Quartc. RTP does not pad packets and doesn't check what's the largest packet it sends. It also doesn't pad handshake, which results in a faster handshake. Padding is not always desirable: on slow connections it sends extra data during handshake, which slows down a handshake. (on 50kbps connection by about 150ms per one message). Merge internal change: 229559845 https://chromium-review.googlesource.com/c/chromium/src/+/1428479 Add test for SpdyUtils::GetPromisedUrlFromHeaders to verify that userinfo is ignored and that the path starts with /. More comprehensive tests exist for SpdyUtils::GetPushPromiseUrl, which GetPromisedUrlFromHeaders delegates to. Motivated by crbug.com/801831 Merge internal change: 229443812 https://chromium-review.googlesource.com/c/chromium/src/+/1427251 Add a DCHECK making sure an endpoint does not send a stop waiting frame with least_unacked = 0. Merge internal change: 229438050 https://chromium-review.googlesource.com/c/chromium/src/+/1428400 In QUIC, add kFirstSendingPacketNumber to represent the first sending packet of a connection. Cleanup misusage of QuicPacketNumber, QuicPacketCount and uint64_t. No functional change expected, not protected. Merge internal change: 229418838 https://chromium-review.googlesource.com/c/chromium/src/+/1428094 In QUIC, change tests functions to take uint64_t instead of QuicPacketNumber to make the transition cleaner. Merge internal change: 229408324 https://chromium-review.googlesource.com/c/chromium/src/+/1428091 More error details about QUIC_STREAM_LENGTH_OVERFLOW while receiving stream frame. Error message changes only, not flag protected. Merge internal change: 229402859 https://chromium-review.googlesource.com/c/chromium/src/+/1428086 Add option to disable padding during crypto handshake. Padding is not always desirable: on slow connections it sends extra data during handshake, which slows down a handshake. (on 50kbps connection by about 150ms per one message). In Quartc we always have ice enabled when we make a call, and we only enable the server when we start the call. ICE will only accept data from endpoints negotiated in STUN pings. Add ability to disable padding during crypto handshake, for Quartc. Merge internal change: 229314318 https://chromium-review.googlesource.com/c/chromium/src/+/1427982 Use 1-rtt setup for Quartc client instead of 2-rtt. Currently client waits for the SHLO to start sending media. This is unnecessary, client can start sending media right after sending full CHLO. This cuts the send time to 1-rtt for the client (server still waits 1.5 rtt to start sending data). We should use 0-rtt setup in quic to start sending media from client after 0-rtt, and after 0.5rtt from the server. Merge internal change: 229313999 https://chromium-review.googlesource.com/c/chromium/src/+/1428039 Add a DCHECK to make sure an endpoint does not send an empty ack frame. Merge internal change: 229244057 https://chromium-review.googlesource.com/c/chromium/src/+/1427929 Remove set_minimum_size in crypto client handshaker. This branch is no longer needed, plus it's redundant. (we set minimum_size inside FillInchoateHello. Also, padding is now done in packet generator). Remove set_minimum_size in crypto client handshaker. Merge internal change: 229231874 https://chromium-review.googlesource.com/c/chromium/src/+/1427319 Change-Id: I973b7d0e9e346ae648a0e525d37f6cbb876de5b4 Reviewed-on: https://chromium-review.googlesource.com/c/1432183 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625540}
Changed files
- net/BUILD.gn
- net/quic/bidirectional_stream_quic_impl_unittest.cc
- net/quic/quic_flags_list.h
- net/quic/quic_http_stream_test.cc
- net/third_party/quic/core/congestion_control/bbr_sender.h
- net/third_party/quic/core/congestion_control/general_loss_algorithm_test.cc
- net/third_party/quic/core/congestion_control/tcp_cubic_sender_bytes_test.cc
- net/third_party/quic/core/crypto/aead_base_decrypter.cc
- net/third_party/quic/core/crypto/aead_base_decrypter.h
- net/third_party/quic/core/crypto/aead_base_encrypter.cc
- net/third_party/quic/core/crypto/aead_base_encrypter.h
- net/third_party/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc
- net/third_party/quic/core/crypto/aes_128_gcm_encrypter_test.cc
- net/third_party/quic/core/crypto/chacha20_poly1305_decrypter_test.cc
- net/third_party/quic/core/crypto/chacha20_poly1305_encrypter_test.cc
- net/third_party/quic/core/crypto/chacha20_poly1305_tls_encrypter_test.cc
- net/third_party/quic/core/crypto/crypto_server_test.cc
- net/third_party/quic/core/crypto/null_decrypter.cc
- net/third_party/quic/core/crypto/null_decrypter.h
- net/third_party/quic/core/crypto/null_encrypter.cc
- net/third_party/quic/core/crypto/null_encrypter.h
- net/third_party/quic/core/crypto/quic_crypto_client_config.cc
- net/third_party/quic/core/crypto/quic_crypto_client_config.h
- net/third_party/quic/core/crypto/quic_crypto_client_config_test.cc
- net/third_party/quic/core/crypto/quic_crypto_server_config.cc
- net/third_party/quic/core/crypto/quic_crypto_server_config.h
- net/third_party/quic/core/crypto/quic_decrypter.h
- net/third_party/quic/core/crypto/quic_encrypter.h
- net/third_party/quic/core/frames/quic_ack_frame.cc
- net/third_party/quic/core/frames/quic_ack_frame.h
- net/third_party/quic/core/frames/quic_frames_test.cc
- net/third_party/quic/core/http/http_decoder.cc
- net/third_party/quic/core/http/http_decoder.h
- net/third_party/quic/core/http/http_decoder_test.cc
- net/third_party/quic/core/http/http_encoder.cc
- net/third_party/quic/core/http/http_encoder.h
- net/third_party/quic/core/http/http_encoder_test.cc
- net/third_party/quic/core/http/http_frames.h
- net/third_party/quic/core/http/quic_server_session_base.h
- net/third_party/quic/core/http/quic_spdy_stream.cc
- net/third_party/quic/core/http/spdy_utils_test.cc
- net/third_party/quic/core/packet_number_indexed_queue.h
- net/third_party/quic/core/quic_connection.cc
- net/third_party/quic/core/quic_connection.h
- net/third_party/quic/core/quic_connection_stats.h
- net/third_party/quic/core/quic_connection_test.cc
- net/third_party/quic/core/quic_constants.h
- net/third_party/quic/core/quic_crypto_client_handshaker.cc
- net/third_party/quic/core/quic_crypto_client_handshaker_test.cc
- net/third_party/quic/core/quic_crypto_server_handshaker.cc
- net/third_party/quic/core/quic_dispatcher_test.cc
- net/third_party/quic/core/quic_framer.cc
- net/third_party/quic/core/quic_framer.h
- net/third_party/quic/core/quic_framer_test.cc
- net/third_party/quic/core/quic_packet_creator.cc
- net/third_party/quic/core/quic_packet_creator_test.cc
- net/third_party/quic/core/quic_packet_generator.cc
- net/third_party/quic/core/quic_packet_generator.h
- net/third_party/quic/core/quic_packet_generator_test.cc
- net/third_party/quic/core/quic_sent_packet_manager_test.cc
- net/third_party/quic/core/quic_stream.cc
- net/third_party/quic/core/quic_stream_sequencer_buffer.cc
- net/third_party/quic/core/quic_stream_test.cc
- net/third_party/quic/core/quic_unacked_packet_map.cc
- net/third_party/quic/core/quic_unacked_packet_map_test.cc
- net/third_party/quic/platform/api/quic_cert_utils.h
- net/third_party/quic/platform/impl/quic_cert_utils_impl.h
- net/third_party/quic/quartc/quartc_session.cc
- net/third_party/quic/quartc/quartc_session.h
- net/third_party/quic/quartc/quartc_session_test.cc
- net/third_party/quic/test_tools/quic_framer_peer.cc
- net/third_party/quic/test_tools/quic_framer_peer.h
- net/third_party/quic/test_tools/quic_test_utils.cc
- net/third_party/quic/test_tools/quic_test_utils.h
-
WebUI cleanup: Specify a CustomEvent type parameter, part1.
Changed by dpapad - dpapadohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:11:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b9a403c799528c7f55cfddf21774353c27568ba3 Comments
WebUI cleanup: Specify a CustomEvent type parameter, part1. Stop type-casting event.detail to a type, instead update the @param annotation. Bug: 924733 Change-Id: Ic6fa51f558daef8b26c3b90f9f21ecbee228f867 Reviewed-on: https://chromium-review.googlesource.com/c/1432453 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625539}
Changed files
- chrome/browser/resources/bookmarks/toolbar.js
- chrome/browser/resources/md_extensions/manager.js
- chrome/browser/resources/md_extensions/toolbar.js
- chrome/browser/resources/print_preview/new/app.js
- chrome/browser/resources/print_preview/new/destination_dialog.js
- chrome/browser/resources/print_preview/new/margin_control_container.js
- chrome/browser/resources/print_preview/new/number_settings_section.js
- chrome/browser/resources/print_preview/new/pages_settings.js
- chrome/browser/resources/print_preview/new/preview_area.js
- chrome/browser/resources/settings/a11y_page/manage_a11y_page.js
- chrome/browser/resources/settings/controls/settings_toggle_button.js
- chrome/browser/resources/settings/languages_page/add_languages_dialog.js
- chrome/browser/resources/settings/settings_ui/settings_ui.js
- ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
-
Worker: Replace entries in TestExpectations with *-expected.txt files
Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:10:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f0c148280a16cc134b38e4dae91df86d662c1fff Comments
Worker: Replace entries in TestExpectations with *-expected.txt files Currently, multiple worker projects are on-going (e.g., off-the-main-thread worker script loading and PlzWorker), and each project has its own runtime flag. That has been bloating up the combinations of virtual test settings, and making it cumbersome to maintain test expectations. To mitigate the burden, this CL replaces entries in TestExpectations with *-expected.txt files. Bug: n/a Change-Id: I4d82ecfa2d98ea0f2bd942a705477b2850aa6400 Reviewed-on: https://chromium-review.googlesource.com/c/1433344 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#625538}
Changed files
- third_party/blink/web_tests/TestExpectations
- third_party/blink/web_tests/external/wpt/workers/constructors/SharedWorker/connect-event-expected.txt
- third_party/blink/web_tests/external/wpt/workers/constructors/SharedWorker/interface-objects-expected.txt
- third_party/blink/web_tests/external/wpt/workers/constructors/SharedWorker/setting-port-members-expected.txt
- third_party/blink/web_tests/external/wpt/workers/constructors/SharedWorker/undefined-arguments-expected.txt
- third_party/blink/web_tests/external/wpt/workers/constructors/SharedWorker/unresolvable-url-expected.txt
- third_party/blink/web_tests/external/wpt/workers/constructors/Worker/unresolvable-url-expected.txt
- third_party/blink/web_tests/external/wpt/workers/interfaces/SharedWorkerGlobalScope/onconnect-expected.txt
- third_party/blink/web_tests/external/wpt/workers/semantics/run-a-worker/003-expected.txt
-
Remove Channel ID databases from user profiles
Changed by Nick Harper - nharperohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 07:09:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d5c529872829be5bb487c57eac0e79b8d48c4606 Comments
Remove Channel ID databases from user profiles Bug: 903642 Change-Id: I7b3b552a7be4cea4c2568ea01c4bf049b6e08c1b Reviewed-on: https://chromium-review.googlesource.com/c/1405547 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625537}
Changed files
- chrome/browser/net/profile_network_context_service.cc
- components/safe_browsing/browser/safe_browsing_network_context.cc
- tools/metrics/histograms/histograms.xml
-
Roll src-internal 80e56cb3f138..2ecc36e23912 (2 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 07:01:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 57baf9bd9b3df5759e6da5c853f354e58de22a3f Comments
Roll src-internal 80e56cb3f138..2ecc36e23912 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80e56cb3f138..2ecc36e23912 Created with: gclient setdep -r src-internal@2ecc36e23912 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313 TBR=mmoss@chromium.org Change-Id: I6eec7158b062e738064e608a41749b1f5095193e Reviewed-on: https://chromium-review.googlesource.com/c/1432778 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625536}
Changed files
- DEPS
-
More distinct start/end market for task backtrace.
Changed by Albert J. Wong - ajwongohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:52:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c499c82fe065b5b577ee8628c4c94918acf8f00a Comments
More distinct start/end market for task backtrace. The previous fill of 0xfe and 0xef ran into problems in server-side processing as minidump generation uses that pattern is a "unreadable memory" fill causing lots of false-positives. Bug: none Change-Id: Icf6aa04304394ffef673fe5721c6ec291e5b38d4 Reviewed-on: https://chromium-review.googlesource.com/c/1405454 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#625535}
Changed files
- base/debug/task_annotator.cc
-
media/gpu/test: Move frame validation in VD tests to a separate thread.
Changed by David Staessens - dstaessensohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:49:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a2ef35d385f8412488674f2a2d70325f5338c56c Comments
media/gpu/test: Move frame validation in VD tests to a separate thread. This speeds up the new video decoder tests a bit, since we don't have to block on validation before scheduling the next decode operation. TEST=ran new VDA tests on nocturne BUG=879065 Change-Id: Ie1d94647b376234c59ee9900673e295f09ac711a Reviewed-on: https://chromium-review.googlesource.com/c/1420477 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625534}
Changed files
- media/gpu/test/video_frame_helpers.h
- media/gpu/test/video_frame_validator.cc
- media/gpu/test/video_frame_validator.h
- media/gpu/test/video_player/video_decoder_client.cc
- media/gpu/video_decode_accelerator_tests.cc
- media/gpu/video_decode_accelerator_unittest.cc
-
MacPWAs: Add callback for shim process termination
Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:42:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e10571be54281bc4b80a00628a5c3c983889d94c Comments
MacPWAs: Add callback for shim process termination Add plumbing for a callback to be made when the shim process terminates. Don't actually use this plumbing yet. Bug: 924482 Change-Id: I5deb7e2d6205d615da456129e3ddb3830dc653a0 Reviewed-on: https://chromium-review.googlesource.com/c/1433500 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#625533}
Changed files
- chrome/browser/apps/app_shim/app_shim_handler_mac.h
- chrome/browser/apps/app_shim/app_shim_host_mac.cc
- chrome/browser/apps/app_shim/app_shim_host_mac.h
- chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
- chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
- chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
- chrome/browser/apps/app_shim/apps_page_shim_handler.h
- chrome/browser/apps/app_shim/apps_page_shim_handler.mm
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc
- chrome/browser/web_applications/components/web_app_shortcut_mac.h
- chrome/browser/web_applications/components/web_app_shortcut_mac.mm
- chrome/browser/web_applications/extensions/web_app_extension_shortcut_mac.mm
-
Mark sxg-referrer.tentative.https.html [ Timeout Pass ]
Changed by Tsuyoshi Horo - horoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:37:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e2c30a2f5ae6421fdf891142ffb209da34fda71f Comments
Mark sxg-referrer.tentative.https.html [ Timeout Pass ] Bug: 924752 Change-Id: I3723a05aa2e62c379c862dea44b16270c6652cbd Reviewed-on: https://chromium-review.googlesource.com/c/1433391 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#625532}
Changed files
- third_party/blink/web_tests/TestExpectations
-
[Fuchsia] Enable H264 video decoder unittests
Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:29:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a19d20847cc0582be9eeb3c946946e40ca19ff6b Comments
[Fuchsia] Enable H264 video decoder unittests mediacodec now supports SW video decoding for H264, so now it's possible to run FuchsiaVideoDecoder unittests on the buts. This change also fixes two issues: 1. CodecBuffer.buffer_index was not set. 2. YV12 output format was not supported. Bug: 921085 Change-Id: I5cee20dfc6571a2d117e8ba0c09a3ed6cefc260d Reviewed-on: https://chromium-review.googlesource.com/c/1429280 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625531}
Changed files
- media/filters/fuchsia/fuchsia_video_decoder.cc
- media/filters/fuchsia/fuchsia_video_decoder.h
- media/filters/fuchsia/fuchsia_video_decoder_unittest.cc
-
Enable QuicConnectionId variable length flags
Changed by David Schinazi - dschinaziohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:14:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c828105765844b300ae881bd90fb3f765116bd74 Comments
Enable QuicConnectionId variable length flags This change reenables the QuicConnectionId variable length flags (which makes QuicConnectionId be represented in memory in network byte order) and fixes chromium-specific behavior that used to rely on the connection IDs being 64 bits. Bug: b/123008920 Change-Id: I9497c516a8612be3c0aaddd152825f559a9086f3 Reviewed-on: https://chromium-review.googlesource.com/c/1418632 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#625530}
Changed files
- net/http/http_proxy_client_socket_wrapper_unittest.cc
- net/http/http_stream_factory_job_controller_unittest.cc
- net/http/http_stream_factory_unittest.cc
- net/quic/bidirectional_stream_quic_impl_unittest.cc
- net/quic/quic_chromium_client_session.cc
- net/quic/quic_chromium_client_session_test.cc
- net/quic/quic_connection_logger.cc
- net/quic/quic_flags_list.h
- net/quic/quic_http_stream_test.cc
- net/quic/quic_network_transaction_unittest.cc
- net/quic/quic_proxy_client_socket_unittest.cc
- net/quic/quic_stream_factory.cc
- net/quic/quic_stream_factory_test.cc
- net/third_party/quic/quartc/quartc_stream_test.cc
- net/tools/quic/quic_http_proxy_backend_stream_test.cc
- net/tools/quic/quic_http_proxy_backend_test.cc
- net/tools/quic/quic_simple_server_session_helper.cc
- net/tools/quic/quic_simple_server_session_helper_test.cc
- third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
-
Revert "Re-implement CrOS merge session throttle in the network service."
Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:11:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c0d24a87f706a0627c1f540f8c8e8c6750c675a7 Comments
Revert "Re-implement CrOS merge session throttle in the network service." This reverts commit 4e6965956ec5ecbfdace5eb4989609f4887c632c. Reason for revert: Suspected to cause crashes on these tests: CastSessionBrowserTest.CreateAndDestroy InstantProcessNavigationTest.ForkForNavigationsToNewTabURLs Both crashing on ChromeRenderThreadObserver Received signal 11 SEGV_MAPERR 000000000000 #0 0x55de2b025d59 base::debug::CollectStackTrace() #1 0x55de2af9a183 base::debug::StackTrace::StackTrace() #2 0x55de2b0258e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f5b34da4330 <unknown> #4 0x55de2b44a78b ChromeRenderThreadObserver::ChromeRenderThreadObserver() #5 0x55de2b441dc4 ChromeContentRendererClient::RenderThreadStarted() Original change's description: > Re-implement CrOS merge session throttle in the network service. > > This change re-implements the resource load throttle that waits for the > Chrome OS merge session to complete (or timeout) before allowing resource > loads. This implementation is compatible with the network service. Previously > this was implemented by the MergeSessionResourceThrottle class, but is > now implemented by MergeSessionLoaderThrottle. > > Bug: 897986 > Change-Id: I0a4d2e1961504bd1a979a1d964d62f9ec17b8b33 > Reviewed-on: https://chromium-review.googlesource.com/c/1318412 > Commit-Queue: Chris Mumford <cmumford@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625501} TBR=xiyuan@chromium.org,kenrb@chromium.org,jam@chromium.org,cmumford@google.com Change-Id: Ibffe2a34608db94c7d86c9b16bcd037a2c23fad6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897986 Reviewed-on: https://chromium-review.googlesource.com/c/1433389 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625529}
Changed files
- chrome/browser/chrome_content_browser_client.cc
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/login/signin/merge_session_navigation_throttle_unittest.cc
- chrome/browser/chromeos/login/signin/merge_session_resource_throttle.cc
- chrome/browser/chromeos/login/signin/merge_session_resource_throttle.h
- chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h
- chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc
- chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.h
- chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
- chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
- chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
- chrome/browser/profiles/renderer_updater.cc
- chrome/browser/profiles/renderer_updater.h
- chrome/common/chrome_switches.cc
- chrome/common/chrome_switches.h
- chrome/common/renderer_configuration.mojom
- chrome/renderer/BUILD.gn
- chrome/renderer/chrome_content_renderer_client.cc
- chrome/renderer/chrome_content_renderer_client.h
- chrome/renderer/chrome_render_thread_observer.cc
- chrome/renderer/chrome_render_thread_observer.h
- chrome/renderer/chromeos_delayed_callback_group.cc
- chrome/renderer/chromeos_delayed_callback_group.h
- chrome/renderer/chromeos_delayed_callback_group_unittest.cc
- chrome/renderer/chromeos_merge_session_loader_throttle.cc
- chrome/renderer/chromeos_merge_session_loader_throttle.h
- chrome/renderer/url_loader_throttle_provider_impl.cc
- chrome/test/BUILD.gn
- chrome/test/data/extensions/api_test/merge_session/background.js
- testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
-
Roll src/third_party/skia beaae554418b..a6ab2bdd8cd3 (4 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 06:10:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 08b80f14e0050152ddc5936327e9ad1041440b31 Comments
Roll src/third_party/skia beaae554418b..a6ab2bdd8cd3 (4 commits) https://skia.googlesource.com/skia.git/+log/beaae554418b..a6ab2bdd8cd3 git log beaae554418b..a6ab2bdd8cd3 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2019-01-23 rmistry@google.com Fix spreadsheets page set for RecreateSKPs bot 2019-01-23 csmartdalton@google.com Implement XP factory dumping 2019-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2d4f839f26f7..9d803dd280d8 (457 commits) Created with: gclient setdep -r src/third_party/skia@a6ab2bdd8cd3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ief8411fb8caa054e067141b15569e1818db71e80 Reviewed-on: https://chromium-review.googlesource.com/c/1433434 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625528}
Changed files
- DEPS
-
WebUI Dark Mode: update .svg icons with embedded fill
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:07:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8d13a0e1389fb42eeab6d9d2b01ed1ea1b5e2773 Comments
WebUI Dark Mode: update .svg icons with embedded fill This CL duplicates and updates the light mode .svg icons from cr_icons_css.html to dark-specific equivalents. This was done semi-mechanically with a bunch of sed hacking to copy and change the fill color. I also updated .md-select's icon as well. I also renamed some icons that seemed to be overly presentation in their naming (i.e. -white), changed the default --iron-icon-fill-color for settings, deleted some unused shared variables, and added an error color for settings. Screenshots: https://imgur.com/a/MyI725P Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c485b44#slide=id.g364d7f9db1_0_0 R=aee@chromium.org BUG=883049 Change-Id: I7709044a360a2e78136c2123dbe17ea0de662e37 Reviewed-on: https://chromium-review.googlesource.com/c/1431916 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625527}
Changed files
- chrome/browser/resources/settings/settings_vars_css.html
- ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html
- ui/webui/resources/cr_elements/cr_icons_css.html
- ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
- ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
- ui/webui/resources/cr_elements_images.grdp
- ui/webui/resources/html/md_select_css.html
- ui/webui/resources/images/dark/arrow_down.svg
- ui/webui/resources/images/dark/arrow_right.svg
- ui/webui/resources/images/dark/icon_arrow_back.svg
- ui/webui/resources/images/dark/icon_arrow_dropdown.svg
- ui/webui/resources/images/dark/icon_cancel.svg
- ui/webui/resources/images/dark/icon_clear.svg
- ui/webui/resources/images/dark/icon_delete_gray.svg
- ui/webui/resources/images/dark/icon_expand_less.svg
- ui/webui/resources/images/dark/icon_expand_more.svg
- ui/webui/resources/images/dark/icon_more_vert.svg
- ui/webui/resources/images/dark/icon_picture_delete.svg
- ui/webui/resources/images/dark/icon_refresh.svg
- ui/webui/resources/images/dark/icon_search.svg
- ui/webui/resources/images/dark/icon_settings.svg
- ui/webui/resources/images/dark/icon_toolbar_cancel.svg
- ui/webui/resources/images/dark/icon_toolbar_menu.svg
- ui/webui/resources/images/dark/icon_visibility.svg
- ui/webui/resources/images/dark/icon_visibility_off.svg
- ui/webui/resources/images/icon_picture_delete.svg
- ui/webui/resources/images/icon_toolbar_cancel.svg
- ui/webui/resources/images/icon_toolbar_menu.svg
-
ARCore: Address feedback from old CL
Changed by Piotr Bialecki - bialpioohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:06:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a4b651b2c7f1d9e7f98e38bd691b2cc1f22fd92c Comments
ARCore: Address feedback from old CL This CL addresses most of the remaining feedback present on https://crrev.com/c/1341025 Bug: 852607 Change-Id: Ic31bd19adfbd26da523a9d97ba9ee2dbe06f3651 Reviewed-on: https://chromium-review.googlesource.com/c/1391714 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625526}
Changed files
- chrome/browser/android/vr/arcore_device/arcore_device_provider.cc
- chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
- chrome/browser/android/vr/arcore_device/arcore_shim.cc
- chrome/browser/android/vr/arcore_device/arcore_shim.h
- third_party/blink/renderer/modules/xr/xr.cc
-
Print Preview: Fix destinations dropdown for RTL
Changed by rbpotter - rbpotterohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:01:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2140f9a6b5fb977a8ff07f3c033cd2a936a2745c Comments
Print Preview: Fix destinations dropdown for RTL Bug: 924428 Change-Id: I40c18c1a32980371eb44d8cce437805822c5db96 Reviewed-on: https://chromium-review.googlesource.com/c/1432334 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625525}
Changed files
- chrome/browser/resources/print_preview/new/destination_select.html
-
Adds getStats() method to RTCQuicTransport.
Changed by Seth Hampson - shampsonohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:01:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0bc24b649c8d060cd7d41e406571c662db1638cf Comments
Adds getStats() method to RTCQuicTransport. getStats() returns a promise that resolves with a dictionary of stats defined in the RTCQuicTransportStats dictionary. Bug: 874296 Change-Id: I907e529ebf074842c6702df7d90349515c48a5ba Reviewed-on: https://chromium-review.googlesource.com/c/1430599 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625524}
Changed files
- third_party/blink/renderer/modules/modules_idl_files.gni
- third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
- third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.h
- third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
- third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.h
- third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_stats.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc
- third_party/blink/web_tests/external/wpt/webrtc-quic/RTCQuicTransport.https.html
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
-
[PE] Optimize SetNeedsOverflowRecalc to avoid PaintingLayer.
Changed by Chris Harrelson - chrishtrohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:54:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 958c583e7e46899fa4bb9650acdf6688aa725181 Comments
[PE] Optimize SetNeedsOverflowRecalc to avoid PaintingLayer. PaintingLayer() is expensive, because it walks up the containing block chain. Instead, change the code to take advantage of the existing walk up the containing block chain in MarkContainerChainForOverflowRecalcIfNeeded. Bug: 918598 Change-Id: I1888db820929a8a345a7d1f9341e0eaa52d826bc Reviewed-on: https://chromium-review.googlesource.com/c/1432234 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#625523}
Changed files
- third_party/blink/renderer/core/layout/layout_embedded_object.cc
- third_party/blink/renderer/core/layout/layout_object.cc
- third_party/blink/renderer/core/layout/svg/layout_svg_root.cc
- third_party/blink/renderer/core/layout/svg/layout_svg_text.cc
- third_party/blink/web_tests/platform/linux/paint/invalidation/overflow/overflow-delete-line-expected.txt
-
fido: reintroduce the WebAuthn caBLE feature and UI flag
Changed by Martin Kreichgauer - martinkrohnoyoudont@google.com Changed at Thursday, 24-Jan-19 05:52:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cd786f640655d6b44b16b3a572dcd37dbc36dee7 Comments
fido: reintroduce the WebAuthn caBLE feature and UI flag This adds the WebAuthenticationCable feature flag and related enable-web-authentication-cable-support UI flag. These flags were previously removed in 800d018cf6d2a00c4d03ce57ed12f1debe06bc2d, but we are anticipating having to disable caBLE on some OSes in the future based on user feedback. Also clean up some ununsed flag_descriptions entries and a dangling declaration of the WebAuthenticationCableWin flag. Bug: 924800 Change-Id: I08623b19c62b894391e903f7dfce30f0aa00b7f2 Reviewed-on: https://chromium-review.googlesource.com/c/1433133 Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#625522}
Changed files
- chrome/browser/about_flags.cc
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
- content/browser/webauth/authenticator_impl.cc
- content/browser/webauth/authenticator_impl_unittest.cc
- content/public/common/content_features.cc
- content/public/common/content_features.h
-
ws: Make EnsureClientHasDrawnWindow retry capturing
Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:40:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 71e8cf2805c42843aa426be48d8cbb2f04324875 Comments
ws: Make EnsureClientHasDrawnWindow retry capturing WindowServerTestImpl::EnsureClientHasDrawnWindow could capture window contents too early and end up with false positives. Retry 3 times with 1 seconds apart to make it more reliable. Bug: 923406 Change-Id: I5f09106c29c105348e421dded1727d1873cd06fa Reviewed-on: https://chromium-review.googlesource.com/c/1432452 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625521}
Changed files
- services/ws/window_server_test_impl.cc
- services/ws/window_server_test_impl.h
-
CrOS Shelf: Let the tooltip manager handle key events
Changed by Manu Cornet - manucornetohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:39:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2491dd10914e961e9b5a8a186b05cd7b22f85702 Comments
CrOS Shelf: Let the tooltip manager handle key events This fixes a bug where a bubble (namely a hover preview bubble) could be dismissed with a keystroke without giving the tooltip manager a chance to do the necessary cleanup. We'll likely need to expand this in the future to handle keyboard navigation within the hover preview bubbles, but for now closing any shown bubble with any key event avoids a nasty crash. Bug: 902539 Change-Id: Ib642496f2ca1657189d0b3b9471ce2619c218b40 Reviewed-on: https://chromium-review.googlesource.com/c/1420817 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#625520}
Changed files
- ash/shelf/shelf_tooltip_manager.cc
- ash/shelf/shelf_tooltip_manager.h
- ash/shelf/shelf_tooltip_manager_unittest.cc
-
Reland "[mojo] move definition of operator<< for enum to mojom-shared.cc"
Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:37:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 55f5c137b3c6fe9316be38dc8349a97f23e2d56d Comments
Reland "[mojo] move definition of operator<< for enum to mojom-shared.cc" This is a reland of d51ebd693a614093b052b6273a48f2058f35d922 I removed unnecessary public_deps from //ui/accessibility:ax_enums_mojo to fix link failure on lib fuzzer builder. Original change's description: > [mojo] move definition of operator<< for enum to mojom-shared.cc > > This is to make mojo header file smaller for the file having many enum values. > e.g. > https://cs.chromium.org/chromium/src/out/Debug/gen/third_party/blink/public/platform/web_feature.mojom-shared.h > > This reduced total size of *.mojom-shared.h when building chrome on linux > from 10099430 bytes to 9510524 bytes. > > Bug: 922875 > Change-Id: I3183b184102cbbe3b5a971660f046e784ff1b771 > Reviewed-on: https://chromium-review.googlesource.com/c/1415246 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624012} Bug: 922875, 924140 Change-Id: Idee3a045b08dd011fae7a26bb3d25377bdeb59a7 Reviewed-on: https://chromium-review.googlesource.com/c/1433372 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#625519}
Changed files
- content/public/common/BUILD.gn
- mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl
- mojo/public/tools/bindings/generators/cpp_templates/module-shared.cc.tmpl
- mojo/public/tools/bindings/generators/cpp_templates/module-shared.h.tmpl
- third_party/blink/public/BUILD.gn
- third_party/blink/public/mojom/BUILD.gn
- ui/accessibility/BUILD.gn
- ui/base/ime/chromeos/public/interfaces/BUILD.gn
-
Use SharedImages in GlRenderer
Changed by Chris Blume - cblumeohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:34:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 764cb23f7b1790a35b3720c73fa8db94c70ca830 Comments
Use SharedImages in GlRenderer To ease transition of WebView using a Vulkan functor, we want to isolate each step and make sure that step works on its own. One step is to use SharedImages in GlRenderer. This CL updates GlRenderer to use SharedImages. BUG=922834 Change-Id: I94678e92881f1d974034f3fc1e43a5d39fa932dc Reviewed-on: https://chromium-review.googlesource.com/c/1428739 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#625518}
Changed files
- components/viz/service/display/display_resource_provider.cc
-
Re-enable MipsAddedWhileOriginalInUse test since Windows OOM bug fixed
Changed by Madeleine Barowsky - mbarowskyohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:30:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1d9b36dff73a0034ddf9f0a2d2b4ded380a065bc Comments
Re-enable MipsAddedWhileOriginalInUse test since Windows OOM bug fixed Bug: 867468 Change-Id: I5302cf831d40867c4b43864146ac38537adc4cf1 Reviewed-on: https://chromium-review.googlesource.com/c/1427099 Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625517}
Changed files
- cc/tiles/gpu_image_decode_cache_unittest.cc
-
[Fuchsia] Rename //fuchsia/app to //fuchsia/runners.
Changed by Fabrice de Gans-Riberi - fdegansohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:27:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 683a9d9d691c06dcda735637a4f0d85c4f6f3c55 Comments
[Fuchsia] Rename //fuchsia/app to //fuchsia/runners. This CL also removes all C++ namespace in this part of the //fuchsia directory as this code is not called anywhere else. This CL also adds a build file specifically for the //fuchsia/runners targets, cleaning up the target names and setting the proper visibility for targets in the process. TBR=jbudorick@chromium.org Bug: 922635 Change-Id: I2279903b9a8c5ac7e11f05427113945264616807 Reviewed-on: https://chromium-review.googlesource.com/c/1423557 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625516}
Changed files
- BUILD.gn
- fuchsia/BUILD.gn
- fuchsia/runners/BUILD.gn
- fuchsia/runners/cast/bindings/cast_channel.cc
- fuchsia/runners/cast/bindings/cast_channel.h
- fuchsia/runners/cast/bindings/cast_channel.js
- fuchsia/runners/cast/bindings/cast_channel_browsertest.cc
- fuchsia/runners/cast/cast_runner.cc
- fuchsia/runners/cast/cast_runner.h
- fuchsia/runners/cast/cast_runner_integration_test.cc
- fuchsia/runners/cast/cast_runner_unittest.cc
- fuchsia/runners/cast/fake_application_config_manager.cc
- fuchsia/runners/cast/fake_application_config_manager.h
- fuchsia/runners/cast/main.cc
- fuchsia/runners/cast/sandbox_policy
- fuchsia/runners/cast/test_common.cc
- fuchsia/runners/cast/test_common.h
- fuchsia/runners/cast/testdata/cast_channel.html
- fuchsia/runners/cast/testdata/cast_channel_reconnect.html
- fuchsia/runners/common/web_component.cc
- fuchsia/runners/common/web_component.h
- fuchsia/runners/common/web_content_runner.cc
- fuchsia/runners/common/web_content_runner.h
- fuchsia/runners/web/main.cc
- fuchsia/runners/web/sandbox_policy
- fuchsia/runners/web/web_runner_smoke_test.cc
- testing/buildbot/chromium.fyi.json
- testing/buildbot/chromium.linux.json
- testing/buildbot/gn_isolate_map.pyl
- testing/buildbot/test_suite_exceptions.pyl
- testing/buildbot/test_suites.pyl
-
Extensions: Restrict mv3 extensions to use "content_security_policy" as dictionary.
Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:25:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 75d36ac0c81c3e319652ab4de6297ff84fa0f09f Comments
Extensions: Restrict mv3 extensions to use "content_security_policy" as dictionary. This CL fixes an existing TODO and restricts manifest v3 extensions such that they always use "content_security_policy" manifest key as a dictionary. BUG=914224 Change-Id: I4b7be7cd9edf64a016d343660e11e4a197c5b409 Reviewed-on: https://chromium-review.googlesource.com/c/1423744 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625515}
Changed files
- extensions/common/manifest_handlers/csp_info.cc
- extensions/common/manifest_handlers/csp_info_unittest.cc
- extensions/test/data/manifest_tests/csp_dictionary_empty_v3.json
- extensions/test/data/manifest_tests/csp_dictionary_missing_v3.json
- extensions/test/data/manifest_tests/csp_invalid_type_v3.json
-
Add a base::Feature for Mojo dispatch change
Changed by Ken Rockot - rockotohnoyoudont@google.com Changed at Thursday, 24-Jan-19 05:20:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b9991b861d14bb879d0ae47bccbd5781e1a0f27e Comments
Add a base::Feature for Mojo dispatch change Adds a new base::Feature to control whether or not Mojo uses the more granular task-per-message dispatch policy as opposed to the old batch dispatch behavior. This is disabled by default until M73 branch. TBR=jam@chromium.org Bug: 866708 Change-Id: I138a66c0d65106f44f153e02c1cf92d71c27d14d Reviewed-on: https://chromium-review.googlesource.com/c/1433139 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#625514}
Changed files
- mojo/public/cpp/bindings/BUILD.gn
- mojo/public/cpp/bindings/connector.h
- mojo/public/cpp/bindings/features.cc
- mojo/public/cpp/bindings/features.h
- mojo/public/cpp/bindings/lib/connector.cc
-
DevTools: Convert to Shadow DOM and Custom Elements v1
Changed by Joel Einbinder - einbinderohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:19:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b00e6ea1c9b4db5d743c7c204b1f63abf89e0398 Comments
DevTools: Convert to Shadow DOM and Custom Elements v1 Bug: 685385 Change-Id: I027e84d8003b7799492211d5fcf8348cd91fd799 Reviewed-on: https://chromium-review.googlesource.com/c/1422962 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#625513}
Changed files
- third_party/blink/renderer/devtools/front_end/accessibility/AXBreadcrumbsPane.js
- third_party/blink/renderer/devtools/front_end/accessibility/AccessibilityNodeView.js
- third_party/blink/renderer/devtools/front_end/accessibility/accessibilityNode.css
- third_party/blink/renderer/devtools/front_end/changes/changesView.css
- third_party/blink/renderer/devtools/front_end/console/ConsoleViewMessage.js
- third_party/blink/renderer/devtools/front_end/console_counters/WarningErrorCounter.js
- third_party/blink/renderer/devtools/front_end/console_counters/errorWarningCounter.css
- third_party/blink/renderer/devtools/front_end/dom_extension/DOMExtension.js
- third_party/blink/renderer/devtools/front_end/elements/ElementsSidebarPane.js
- third_party/blink/renderer/devtools/front_end/elements/StylesSidebarPane.js
- third_party/blink/renderer/devtools/front_end/elements/classesPaneWidget.css
- third_party/blink/renderer/devtools/front_end/emulation/DeviceModeView.js
- third_party/blink/renderer/devtools/front_end/emulation/sensors.css
- third_party/blink/renderer/devtools/front_end/inline_editor/CSSShadowEditor.js
- third_party/blink/renderer/devtools/front_end/inline_editor/ColorSwatch.js
- third_party/blink/renderer/devtools/front_end/inspector_main/renderingOptions.css
- third_party/blink/renderer/devtools/front_end/layers_test_runner/LayersTestRunner.js
- third_party/blink/renderer/devtools/front_end/network/RequestHeadersView.js
- third_party/blink/renderer/devtools/front_end/network/networkConfigView.css
- third_party/blink/renderer/devtools/front_end/network/networkLogView.css
- third_party/blink/renderer/devtools/front_end/object_ui/ObjectPropertiesSection.js
- third_party/blink/renderer/devtools/front_end/object_ui/objectPropertiesSection.css
- third_party/blink/renderer/devtools/front_end/profiler/profilesPanel.css
- third_party/blink/renderer/devtools/front_end/resources/ApplicationCacheItemsView.js
- third_party/blink/renderer/devtools/front_end/security/SecurityPanel.js
- third_party/blink/renderer/devtools/front_end/settings/settingsScreen.css
- third_party/blink/renderer/devtools/front_end/sources/UISourceCodeFrame.js
- third_party/blink/renderer/devtools/front_end/sources/sourcesPanel.css
- third_party/blink/renderer/devtools/front_end/timeline/TimelineHistoryManager.js
- third_party/blink/renderer/devtools/front_end/timeline/historyToolbarButton.css
- third_party/blink/renderer/devtools/front_end/ui/HistoryInput.js
- third_party/blink/renderer/devtools/front_end/ui/Icon.js
- third_party/blink/renderer/devtools/front_end/ui/ListWidget.js
- third_party/blink/renderer/devtools/front_end/ui/SearchableView.js
- third_party/blink/renderer/devtools/front_end/ui/SoftDropDown.js
- third_party/blink/renderer/devtools/front_end/ui/SplitWidget.js
- third_party/blink/renderer/devtools/front_end/ui/TabbedPane.js
- third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
- third_party/blink/renderer/devtools/front_end/ui/Tooltip.js
- third_party/blink/renderer/devtools/front_end/ui/UIUtils.js
- third_party/blink/renderer/devtools/front_end/ui/View.js
- third_party/blink/renderer/devtools/front_end/ui/Widget.js
- third_party/blink/renderer/devtools/front_end/ui/filter.css
- third_party/blink/renderer/devtools/front_end/ui/inspectorCommon.css
- third_party/blink/renderer/devtools/front_end/ui/radioButton.css
- third_party/blink/renderer/devtools/front_end/ui/softDropDownButton.css
- third_party/blink/web_tests/http/tests/devtools/components/dom-extension-expected.txt
- third_party/blink/web_tests/http/tests/devtools/components/dom-extension.js
- third_party/blink/web_tests/http/tests/devtools/elements/styles-1/color-swatch.js
- third_party/blink/web_tests/http/tests/devtools/extensions/extensions-panel.js
- third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/failed-request-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/interstitial-sidebar-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/main-origin-assigned-despite-request-missing-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/security-unknown-resource-expected.txt
-
Revert "Reland "[NTP] Cap search suggestion impressions""
Changed by Kentaro Hara - harakenohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:17:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ae7ac0aaa631435d6e8cb4fc6e049b045c3a2a61 Comments
Revert "Reland "[NTP] Cap search suggestion impressions"" This reverts commit 5d52425f8fe923f16feb6a9759baf0a5b20e758d. Reason for revert: Broke Linux MSan tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/14510 Original change's description: > Reland "[NTP] Cap search suggestion impressions" > > This is a reland of 41e54be1d923353f72490f19a15e73eb09248a38 > > One of the checks is converting the times from ms->s. In practice > seconds is plenty precise but in the test 800ms ended up being 0, > so increase it to 1000ms (similar to ImpressionCountResetsAfterTimeout > which was not flaky). > > Original change's description: > > [NTP] Cap search suggestion impressions > > > > The parameters for capping suggestions impressions are provided as part > > of the update proto. Read and update the local pref on each fetch. Use > > these prefs to determine if the impression cap has been reach or if > > fetching is frozen due to an empty response. > > > > Bug: 904565 > > Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1395188 > > Commit-Queue: Kyle Milka <kmilka@chromium.org> > > Reviewed-by: Kristi Park <kristipark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#624994} > > Bug: 904565 > Change-Id: I424cb51d2a9c1738c0e5168f58ef52b73ed4b223 > Reviewed-on: https://chromium-review.googlesource.com/c/1431472 > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625437} TBR=kristipark@chromium.org,kmilka@chromium.org Change-Id: Ic784efb02c206edd40a878aacae3852e34f6176a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904565 Reviewed-on: https://chromium-review.googlesource.com/c/1433342 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#625512}
Changed files
- chrome/browser/search/local_ntp_source.cc
- chrome/browser/search/search_suggest/search_suggest_data.cc
- chrome/browser/search/search_suggest/search_suggest_data.h
- chrome/browser/search/search_suggest/search_suggest_loader.h
- chrome/browser/search/search_suggest/search_suggest_loader_impl.cc
- chrome/browser/search/search_suggest/search_suggest_loader_impl_unittest.cc
- chrome/browser/search/search_suggest/search_suggest_service.cc
- chrome/browser/search/search_suggest/search_suggest_service.h
- chrome/browser/search/search_suggest/search_suggest_service_unittest.cc
- chrome/common/pref_names.cc
- chrome/common/pref_names.h
-
TestingProfile: Fix CreateGuestProfile and IsSystemProfile.
Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:14:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6ef1bc6fc58fb9c8e982f49c5a2e0f9508034735 Comments
TestingProfile: Fix CreateGuestProfile and IsSystemProfile. Make those profile properties exactly the same as in production code. See go/chromium-profile-types. This change unblocks unit tests in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1415054 Bug: 277296 Change-Id: I00a7e673b6cd751fad7744b9199919239ba376d9 Reviewed-on: https://chromium-review.googlesource.com/c/1429314 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625511}
Changed files
- chrome/test/base/testing_profile.cc
- chrome/test/base/testing_profile_manager.cc
-
Revert "Use focus ring for views button on all platforms"
Changed by Timothy Loh - timlohohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:12:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2658fa5e7573b9ad6982bafd5c8872511be7ed05 Comments
Revert "Use focus ring for views button on all platforms" This reverts commit f1e1cf79ce1aa12db141ed6f0060fc2db4322bb7. Reason for revert: Appears to be causing lots of failures on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10433 Original change's description: > Use focus ring for views button on all platforms > > On platforms other than Mac, ink drop highlight was used to indicate > focus. This has some shortcomings such as possible low contrast, > inconsistency across platforms or even across other UI components. > This CL changes views button to use focus ring for keyboard focus > on all platforms. > > BUG=864642,924232 > > Change-Id: I31b3f2aa78259e6ae365bfde6687b92314e233e9 > Reviewed-on: https://chromium-review.googlesource.com/c/1429239 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Wei Li <weili@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625459} TBR=sky@chromium.org,weili@chromium.org Change-Id: I7b288d364f768f225e803d9a2f50845ed7ab976e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864642, 924232 Reviewed-on: https://chromium-review.googlesource.com/c/1433383 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625510}
Changed files
- chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
- ui/views/controls/button/button.cc
- ui/views/style/platform_style.cc
- ui/views/style/platform_style.h
- ui/views/style/platform_style_mac.mm
-
Revert "Remove explict focus ring install for button subclasses"
Changed by Timothy Loh - timlohohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:11:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c645dafdab2505f4955a545a76bf5f5543726c7e Comments
Revert "Remove explict focus ring install for button subclasses" This reverts commit f4a56fe8033e92669a8e2fb2855c01a3a003259f. Reason for revert: Appears to be causing lots of failures on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10433 Original change's description: > Remove explict focus ring install for button subclasses > > Since views button installs focus ring by deafult to show on keyboard > focus, this CL refactors all its subclasses to remove explicit > installation of focus ring. Only subclasses that need to override to > remove focus ring installation need to call > SetInstallFocusRingOnFocus(false) explicitly. > > BUG=924232 > > Change-Id: Ia5bfce1fca6aaca16ae7e39106737de976e191fc > Reviewed-on: https://chromium-review.googlesource.com/c/1432252 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Wei Li <weili@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625464} TBR=sky@chromium.org,weili@chromium.org Change-Id: I9d46f13e5c95190108ce19c09d1a170c978b6d8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924232 Reviewed-on: https://chromium-review.googlesource.com/c/1433382 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625509}
Changed files
- ash/shelf/login_shelf_view.cc
- ash/system/tray/tray_background_view.cc
- chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc
- chrome/browser/ui/views/overlay/back_to_tab_image_button.cc
- chrome/browser/ui/views/overlay/close_image_button.cc
- chrome/browser/ui/views/overlay/overlay_window_views.cc
- chrome/browser/ui/views/overlay/playback_image_button.cc
- chrome/browser/ui/views/overlay/resize_handle_button.cc
- chrome/browser/ui/views/overlay/skip_ad_label_button.cc
- chrome/browser/ui/views/passwords/password_pending_view.cc
- chrome/browser/ui/views/tabs/new_tab_button.cc
- chrome/browser/ui/views/tabs/tab_close_button.cc
- ui/views/controls/button/checkbox.cc
- ui/views/controls/button/md_text_button.cc
-
Migrate Files app from i18n-content and i18n-values to $i18n{}.
Changed by Sam McNally - sammcohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:59:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d84f3314b6f43055efdcd156ec5e6cffd0146af8 Comments
Migrate Files app from i18n-content and i18n-values to $i18n{}. Move setting of WebUI load-time data (language, textdirection) into the common GetFileManagerStrings() since those are used at serving time. Remove uses of i18nTemplate.process() from the Files app since these are no longer necessary. Bug: 923206 Change-Id: I977bece21cec3d2f777c08833b9376f25b3979a7 Reviewed-on: https://chromium-review.googlesource.com/c/1426338 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#625508}
Changed files
- chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
- chrome/browser/chromeos/file_manager/file_manager_string_util.cc
- ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
- ui/file_manager/file_manager/foreground/elements/files_quick_view.html
- ui/file_manager/file_manager/foreground/js/file_manager.js
- ui/file_manager/file_manager/foreground/js/main_scripts.js
- ui/file_manager/file_manager/foreground/js/quick_view_controller.js
- ui/file_manager/file_manager/foreground/js/ui/BUILD.gn
- ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
- ui/file_manager/file_manager/main.html
-
Tests: Do not turn a normal profile into an incognito profile dynamically.
Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:55:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8e9014770695ac1949fa11429e81f4ee61106492 Comments
Tests: Do not turn a normal profile into an incognito profile dynamically. Use incognito WebContents created for profile()->GetOffTheRecordProfile() which is exactly as in production code. Bug: 277296 Change-Id: I68481cf25cba2eeecd8eef318d08e1f3aa75570d Reviewed-on: https://chromium-review.googlesource.com/c/1424101 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#625507}
Changed files
- chrome/browser/safe_browsing/client_side_detection_host.h
- chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
-
Revert "Remove conditional use of LayerTreeView from RenderWidget."
Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:53:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bef2b64696776bdac2ea14124da97a7e3b2c91da Comments
Revert "Remove conditional use of LayerTreeView from RenderWidget." This reverts commit 2ae8e4805cf3528619e05806e836a78d2c740e0b. Reason for revert: some layout tests started to crash on CHECK(closing_) https://test-results.appspot.com/data/layout_results/Mac10_13_Tests/9201/webkit_layout_tests/layout-test-results/results.html external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html external/wpt/url/failure.html Original change's description: > Remove conditional use of LayerTreeView from RenderWidget. > > The LayerTreeView is always present since we always composite > RenderWidgets now (for many years ^_^). > > However, the LayerTreeView *is* removed during shutdown. Most places > will not need to worry about this because OnClose() drops the IPC > channel and most uses of LayerTreeView are in response to other IPCs. > > However a few cases involve calls from Blink which could still be > active in between OnClose() and tearing down the RenderWidget+Blink, > so in these cases early out if |closing_| which represents better > conceptually what we're testing. > > TBR=avi@chromium.org > > Change-Id: Iff9133d9c69b327495f9290afcb471739124018b > Bug: 912193 > Reviewed-on: https://chromium-review.googlesource.com/c/1432132 > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625473} TBR=avi@chromium.org,ajwong@chromium.org,danakj@chromium.org Change-Id: Ide47f156f8f5d2af32f7442bb659599356c3f6c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1433379 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625506}
Changed files
- content/renderer/render_widget.cc
-
Disable flaky test VideoPlayerBrowserTest.NativeMediaKey
Changed by Timothy Loh - timlohohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:46:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9e63550ba4334706ad0f466f14f0593cc819a470 Comments
Disable flaky test VideoPlayerBrowserTest.NativeMediaKey https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=VideoPlayerBrowserTest.NativeMediaKey https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=single_process_mash_browser_tests&tests=VideoPlayerBrowserTest.NativeMediaKey TBR=beccahughes,fukino Bug: 921418 Change-Id: Ia81a955b1ac41ff4a2c49514bad8ae6be59f0ec8 Reviewed-on: https://chromium-review.googlesource.com/c/1433378 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625505}
Changed files
- chrome/browser/chromeos/file_manager/video_player_browsertest.cc
-
Premount preconfigured shares in SmbService
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Thursday, 24-Jan-19 04:46:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bd9852872cd2eb7d74a4f7fb97c91fbbb86a5663 Comments
Premount preconfigured shares in SmbService - This CL activates preconfigured shares to be premounted. - Premount is dependent on host discovery to be done, similar to Remount. Bug: chromium:878502 Test: unit tests, end to end Change-Id: Iac18e522f124086047e0ffdcd4b7a5d66c72b6cd Reviewed-on: https://chromium-review.googlesource.com/c/1407662 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#625504}
Changed files
- chrome/browser/chromeos/smb_client/smb_service.cc
- chrome/browser/chromeos/smb_client/smb_service.h
-
Roll src/third_party/glslang/src/ 0ac199df3..493096468 (73 commits)
Changed by Jamie Madill - jmadillohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:44:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2df361c88eb985f687df5d2a9b92ba9a5ebb4ede Comments
Roll src/third_party/glslang/src/ 0ac199df3..493096468 (73 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0ac199df3268..493096468316 $ git log 0ac199df3..493096468 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 sparmar Add extension checks for NV block member builtins 2019-01-23 jmadill Suppress inconsistent override warning in GN. 2019-01-22 brooke.hodgman HLSL: Protect against some crashes 2019-01-20 jbolz More precisely check for the qualifiers that enable the vulkan memory model for buffer references. 2019-01-18 jmadill Fix a few GN build issues. 2019-01-16 dneto HLSL: Avoid leaking a shadow sampler struct 2019-01-16 dneto Avoid leaking name for counter buffer 2019-01-16 cepheus HLSL: Fix #1655; use "" for nullptr file names. Needs test cases. 2019-01-16 cepheus Build: fix warnings. Fixes #1653. 2019-01-14 rex.xu Fix xfb_stride incorrectness(#1654) 2019-01-11 cepheus Bump revision. 2019-01-09 dneto Update SPIRV-Tools known good: relax Uconvert check 2018-12-11 cepheus Infrastructure: Generalize and broaden per-variable extension checking. 2019-01-08 dneto Parenthesize to avoid GCC warning 2019-01-07 pdaniell Don't output duplicate TypeAccelerationStructureNV declarations 2019-01-06 jbolz GL_EXT_buffer_reference 2019-01-07 cepheus SPV: Move to the latest header. 2019-01-07 dj2 Make sure source strings are terminated (#1641) 2019-01-03 dneto Mark spv.int16.amd.frag.out as failing validation 2019-01-03 gleese Work around a CMake cross-compilation issue 2018-12-06 greg Create separate OpSource for each included file 2018-12-18 rverschelde CMake: Fix linking pthread of CMake < 3.1 2018-12-17 alanbaker Move memory model scope tests to Vulkan 1.1 batch 2018-12-17 cepheus Build: Make calling argument types match declared parameter types. 2018-11-28 greg Add passes to legalization to preserve source line info when generated. 2018-12-14 jbolz Fix bug where shaderRecordNV buffers were using StorageBuffer storage class 2018-12-14 cepheus Licensing. Fixes #958. Add licenes file and update copyrights. 2018-12-13 cepheus Build: Reduce warnings. 2018-12-13 cepheus GLSL/SPV: XFB: No streams on types, but support them on built-in blocks. 2018-12-11 jbolz Update to newest SPIRV-Tools. It checks the Vulkan rule that all resources must have a set and binding decoration, which many tests fail. So add code to set a default value of zero. Also disable PCH for Ninja builds. 2018-12-10 cepheus Infrastructure: Fix .gitattributes typo eof -> eol. Also update README 2018-12-10 rverschelde CMake: Link OSDependent with Threads::Threads 2018-12-10 rverschelde Remove Unix executable permission from text files 2018-12-07 cepheus Manually merge ClemensRognerSD-dx9-sampler and resolve conflicts. 2018-12-07 greg SPV: Fix #1575, fix #1593: Support HLSL #line 2018-12-04 alanbaker Modify testing to only record validation pass/fail 2018-12-03 alexander.galazin Rename GL_KHX_shader_explicit_arithmetic_types to GL_EXT_shader_explicit_arithmetic_types 2018-10-25 apinheiro GlslangToSpv: prevent add XfbStride twice 2018-11-29 cepheus Bump version. 2018-11-28 cepheus SPV: For GLSL only, bitcast OpArrayLength result back to int. 2018-11-27 cepheus SPV: Generate OpArrayLength with no signedness. 2018-11-26 dj2 Add NDK build files 2018-11-27 cepheus Build: Fix build warnings introduced by 2173c6. 2018-11-26 alanbaker Update known good SPIRV tools and headers 2018-11-26 dkoch Implement GL_EXT_fragment_invocation_density 2018-11-26 cepheus SPV: non-functional: update to latest headers. 2018-11-26 neil.henning Add conversion folding when the source is a constant. 2018-11-21 cepheus GLSL: Fix #1591: Require the id in subgroupBroadcast to be constant. 2018-11-16 dneto Update to newer SPIRV-Tools, including VK_EXT_scalar_block_layout 2018-11-16 cepheus Bump minor version. 2018-11-15 cepheus Move to next SPIRV-Tools known good. 2018-11-15 cepheus GLSL: Increase supported sizes of XBF strides and offsets. 2018-11-15 cepheus Bump revision. 2018-11-15 cepheus Update to latest SPIR-V Tools. 2018-11-15 t.jung [HLSL/Spir-V] fix for incorrect spir-v on int dot(int, int) 2018-11-14 jbolz Implement GL_EXT_scalar_block_layout 2018-11-14 t.jung HLSL: fix invalid spir-v vector * scalar for float1 2018-11-14 t.jung HLSL: implemented c register handling 2018-11-13 t.jung Updated type conversion rules for HLSL frontend 2018-11-13 dsinclair Review feedback 2018-11-12 dneto PCH filename depends on current binary dir 2018-11-12 dsinclair Handle potentially uninitialized result 2018-11-12 rex.xu Fix parser issue: redeclare gl_FragStencilRefARB is not supported 2018-10-23 apinheiro ParseHelper: assign global XfbBuffer to a block missing it 2018-11-08 greg Add DeadBranchElim before MergeReturn in legalization. 2018-11-07 cepheus Fix #1563: Corrupt token when an object macro miscalls a function macro 2018-11-07 cepheus PP: More clearly distinguish funtion-like and object-like macros 2018-11-07 jbolz Rename PCH macro to glslang_pch (to avoid name collision) and update to latest spirv-tools 2018-11-06 cepheus Tests: Add test for ways of calling no-argument macro with (). 2018-10-29 grigoryj Add names for composite constants in SPIR-V 2018-10-31 jbolz Use precompiled headers for some glslang projects 2018-10-22 alele Multiple features and misc fixes for final raytracing non experimental version. 2018-10-26 apinheiro ParseHelper: assign xfb_offset for struct members too Created with: roll-dep src/third_party/glslang/src Tbr: geofflang@chromium.org Bug: angleproject:3088 Change-Id: Idb622a1824cec6c6d470b86d795f6060754240bb Reviewed-on: https://chromium-review.googlesource.com/c/1433135 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#625503}
Changed files
- DEPS
-
[Files app] Refactor PathUtil unittest
Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:44:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 292bca531077f816a7759cf4f9f55ca62c84c756 Comments
[Files app] Refactor PathUtil unittest GetDefaultDownloadDirectory() can return value from the MyFiles/Downloads mount point, so if a test mounts it can interfere with other tests. Refactor the test to have a common profile for most of the tests and unmount MyFiles/Downloads. No change in behaviour for users. Change-Id: Idd6c0c461687feb7cfb12adbff7f5a960f03be82 Reviewed-on: https://chromium-review.googlesource.com/c/1433373 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#625502}
Changed files
- chrome/browser/chromeos/file_manager/path_util_unittest.cc
-
Re-implement CrOS merge session throttle in the network service.
Changed by Chris Mumford - cmumfordohnoyoudont@google.com Changed at Thursday, 24-Jan-19 04:43:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4e6965956ec5ecbfdace5eb4989609f4887c632c Comments
Re-implement CrOS merge session throttle in the network service. This change re-implements the resource load throttle that waits for the Chrome OS merge session to complete (or timeout) before allowing resource loads. This implementation is compatible with the network service. Previously this was implemented by the MergeSessionResourceThrottle class, but is now implemented by MergeSessionLoaderThrottle. Bug: 897986 Change-Id: I0a4d2e1961504bd1a979a1d964d62f9ec17b8b33 Reviewed-on: https://chromium-review.googlesource.com/c/1318412 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625501}
Changed files
- chrome/browser/chrome_content_browser_client.cc
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/login/signin/merge_session_navigation_throttle_unittest.cc
- chrome/browser/chromeos/login/signin/merge_session_resource_throttle.cc
- chrome/browser/chromeos/login/signin/merge_session_resource_throttle.h
- chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h
- chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc
- chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.h
- chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
- chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
- chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
- chrome/browser/profiles/renderer_updater.cc
- chrome/browser/profiles/renderer_updater.h
- chrome/common/chrome_switches.cc
- chrome/common/chrome_switches.h
- chrome/common/renderer_configuration.mojom
- chrome/renderer/BUILD.gn
- chrome/renderer/chrome_content_renderer_client.cc
- chrome/renderer/chrome_content_renderer_client.h
- chrome/renderer/chrome_render_thread_observer.cc
- chrome/renderer/chrome_render_thread_observer.h
- chrome/renderer/chromeos_delayed_callback_group.cc
- chrome/renderer/chromeos_delayed_callback_group.h
- chrome/renderer/chromeos_delayed_callback_group_unittest.cc
- chrome/renderer/chromeos_merge_session_loader_throttle.cc
- chrome/renderer/chromeos_merge_session_loader_throttle.h
- chrome/renderer/url_loader_throttle_provider_impl.cc
- chrome/test/BUILD.gn
- chrome/test/data/extensions/api_test/merge_session/background.js
- testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
-
[NTP] Add dark mode support for voice search
Changed by Kristi Park - kristiparkohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:40:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0e33dd50d487f137f791006705234ec879d3ed1f Comments
[NTP] Add dark mode support for voice search Screenshots: https://screenshot.googleplex.com/z6J7kQ1cYHL.png https://screenshot.googleplex.com/F66Gz7Y1nMm.png https://screenshot.googleplex.com/5YkSLd94b6H.png https://screenshot.googleplex.com/BwFN2Pt82EJ.png Bug: 919961 Change-Id: I1375c0ca7da12918e759e5e9d88cfbe4749e8923 Reviewed-on: https://chromium-review.googlesource.com/c/1432877 Reviewed-by: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#625500}
Changed files
- chrome/browser/resources/local_ntp/voice.css
-
Roll src/third_party/chromite cec40a962e60..947f4685c628 (24 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 04:38:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3796e935dc18cb60f047e2e756ff4b000e065ec3 Comments
Roll src/third_party/chromite cec40a962e60..947f4685c628 (24 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/cec40a962e60..947f4685c628 git log cec40a962e60..947f4685c628 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 tbegin@google.com sludge: add experimental builders for sludge VM 2019-01-23 ahassani@chromium.org paygen: improve GenrateStatefulPayload's implementation 2019-01-23 ahassani@chromium.org cros_generate_stateful_update_payload: Move to paygen 2019-01-23 cjmcdonald@chromium.org RunCommand: Set environment variable LC_MESSAGES=C by default 2019-01-22 dgarrett@google.com workspace_stages: Add unittests for new stage classes. 2019-01-22 dgarrett@google.com workspace_builders: Add unittests for new builder classes. 2019-01-22 manojgupta@google.com chromeos_config: Change kevin64 builders for TestSimpleChromeWorkFlow. 2019-01-21 paulhsia@google.com moblab-generic-vm: mark as experimental 2019-01-20 mikenichols@chromium.org Remove lakitu from experimental 2019-01-20 nmasti@google.com group_baseline: set uid and gid to be identical 2019-01-19 dburger@chromium.org Remove deprecated KAYLE from site params 2019-01-19 saklein@chromium.org build api: Simplify BuildTarget proto 2019-01-19 dburger@chromium.org Remove weave from SiteParams 2019-01-19 dhanyaganesh@chromium.org TriageRelevantChanges: Use buildstore instead of cidb handle 2019-01-19 saklein@chromium.org cros_build_lib: sudo preserve-env option 2019-01-19 dhanyaganesh@chromium.org BuildStore: Redirect UpdateMetadata function through BuildStore. 2019-01-19 dburger@chromium.org Remove GOB_HOST from config_lib.GetSiteParams() 2019-01-19 evanhernandez@chromium.org cros branch: Completely repair manifest. 2019-01-19 evanhernandez@chromium.org repo_manifest: _ManifestElement supports del. 2019-01-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-01-18 manojgupta@google.com chromeos_config: Add amd64-generic-msan-fuzzer builder. 2019-01-18 lamontjones@chromium.org portage_util: Add more information to log on failure of chromeos-version.sh 2019-01-18 zhihongyu@chromium.org Add mistral usergroup_baseline 2019-01-18 gbiv@google.com SimpleChrome: forcibly turn lld off in external builds Created with: gclient setdep -r src/third_party/chromite@947f4685c628 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibb63b893e6b8d927cd8695bc43977178813d2554 Reviewed-on: https://chromium-review.googlesource.com/c/1433012 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625499}
Changed files
- DEPS
-
Suport of window move for picture-in-picture windows
Changed by Jun Mukai - mukaiohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:36:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 85fad3815b310752dfe1fbc54944b3c333dc8cec Comments
Suport of window move for picture-in-picture windows This CL adds a new class ClientSideWindowMoveHandler which observes the mouse/touch events and initiates PerformWindowMove in the window tree client; this is the case for both browser windows and picture-in-picture windows. Rather than implementing similar logic, the new class can handle them uniformly. This also offloads some logic of gesture-transferring and release capture in DesktopWindowTreeHostMus to share the logic. Still there's a TODO for resizing. That needs to be done in another CL. Bug: 921156 Test: manually Change-Id: I8556f1b1a03b26e8b5e63a2a35a199a70ec181b9 Reviewed-on: https://chromium-review.googlesource.com/c/1423341 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625498}
Changed files
- chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
- chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
- ui/aura/BUILD.gn
- ui/aura/mus/client_side_window_move_handler.cc
- ui/aura/mus/client_side_window_move_handler.h
- ui/aura/mus/window_tree_client.cc
- ui/aura/mus/window_tree_client.h
- ui/aura/mus/window_tree_client_unittest.cc
- ui/aura/mus/window_tree_host_mus.cc
- ui/aura/mus/window_tree_host_mus.h
- ui/aura/mus/window_tree_host_mus_delegate.h
- ui/aura/window_event_dispatcher_unittest.cc
- ui/views/mus/desktop_window_tree_host_mus.cc
-
Revert "Add tentative WPT tests for stale while revalidate handling."
Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com Changed at Thursday, 24-Jan-19 04:34:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 875e732fa22af1e2c1a8019e1cd235b83131f168 Comments
Revert "Add tentative WPT tests for stale while revalidate handling." This reverts commit 05cdb4d1d9cdaa2df3d91cd9dc150eda903fe35b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625228 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDVjZGI0ZDFkOWNkYWEyZGYzZDkxY2Q5ZGMxNTBlZGE5MDNmZTM1Ygw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/77482 Sample Failed Step: webkit_layout_tests Sample Flaky Test: virtual/outofblink-cors-ns/external/wpt/fetch/stale-while-revalidate/stale-script.tentative.html Original change's description: > Add tentative WPT tests for stale while revalidate handling. > > Add test to ensure that handling the fetch doesn't trigger stale > while revalidate loading. > > Add test to ensure that scripts loaded trigger a stale while revalidate > cache hit and resource timing entries are correct. > > The PR for the spec changes is here: > https://github.com/whatwg/fetch/pull/853 > > BUG=348877 > > Change-Id: Ib07b98d0d2595b6b99857161f830343bf7516518 > Reviewed-on: https://chromium-review.googlesource.com/c/1383297 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625228} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=348877 Change-Id: Ie11ef55a64fcf3e39781666b65a47bbd157f04a2 Reviewed-on: https://chromium-review.googlesource.com/c/1432937 Cr-Commit-Position: refs/heads/master@{#625497}
Changed files
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/fetch.tentative.html
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/stale-image.py
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/stale-image.tentative.html
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/stale-script.py
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/stale-script.tentative.html
-
Remove SecurityState on IO thread instead of posting back to UI thread.
Changed by Aaron Colwell - acolwellohnoyoudont@google.com Changed at Thursday, 24-Jan-19 04:31:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 529eb6e986ed61abeac60f1d9f53f1cb006855cb Comments
Remove SecurityState on IO thread instead of posting back to UI thread. This change attempts to remove the extra task posted to the UI thread to remove the SecurityState object. The original crashes this extra task was intended to fix did not pan out and were fixed another way. This change tries to see if the simpler case of removing on the IO thread can be used. - Removes SecurityState from pending_remove_state_ in IO thread task. - CanAccessDataForOrigin() no longer preserves pre-Remove() state on UI thread. Always returns false after Remove() returns. - CanAccessDataForOrigin() preserves pre-Remove() state on IO thread until the task that Remove() posted runs. Bug: 915203, 923053 Change-Id: I5eef23ad3003a0dc2b8419aca0be29fc9f9202bf Reviewed-on: https://chromium-review.googlesource.com/c/1432572 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#625496}
Changed files
- content/browser/child_process_security_policy_impl.cc
- content/browser/child_process_security_policy_impl.h
- content/browser/child_process_security_policy_unittest.cc
-
Tests: Do not turn a normal profile into an incognito profile dynamically.
Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:29:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 58084ae9f2eb5f7d44c3fa9cf90d4766d1865465 Comments
Tests: Do not turn a normal profile into an incognito profile dynamically. Use incognito WebContents created for profile()->GetOffTheRecordProfile() which is exactly as in production code. Bug: 277296 Change-Id: Iee78c3ae9635195301f384d92454680ae61b0021 Reviewed-on: https://chromium-review.googlesource.com/c/1424627 Reviewed-by: Nathan Parker <nparker@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625495}
Changed files
- chrome/browser/safe_browsing/safe_browsing_blocking_page.h
- chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
- chrome/browser/safe_browsing/safe_browsing_service.h
-
Fix a typo in chromeos_strings.grdp
Changed by Hadi Moshayedi - moshayediohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:28:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 681f2c61e8941421c786e49497d9276c14e80388 Comments
Fix a typo in chromeos_strings.grdp Bug: NONE Change-Id: Ia2ffcc1241a76c903591856d03e38451feec2558 Reviewed-on: https://chromium-review.googlesource.com/c/1424698 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Commit-Queue: Hadi Moshayedi <moshayedi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625494}
Changed files
- chrome/app/chromeos_strings.grdp
-
Extensions: Implement "content_security_policy.isolated_world" manifest key.
Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:28:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 11c67e5998f4dbb2d04b3e149c83e3f585846f2a Comments
Extensions: Implement "content_security_policy.isolated_world" manifest key. This CL implements the "content_security_policy.isolated_world" manifest key. In a later CL, the parsed CSP will be plumbed to the renderer. BUG=914224 Change-Id: Ia13904d760c40b20a3309c521d44666c2dfbc0c7 Reviewed-on: https://chromium-review.googlesource.com/c/1406233 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625493}
Changed files
- chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc
- chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
- extensions/common/csp_validator.cc
- extensions/common/csp_validator.h
- extensions/common/csp_validator_unittest.cc
- extensions/common/manifest_constants.cc
- extensions/common/manifest_constants.h
- extensions/common/manifest_handlers/csp_info.cc
- extensions/common/manifest_handlers/csp_info.h
- extensions/common/manifest_handlers/csp_info_unittest.cc
- extensions/test/data/manifest_tests/isolated_world_csp_dictionary_default_v2.json
- extensions/test/data/manifest_tests/isolated_world_csp_dictionary_default_v3.json
- extensions/test/data/manifest_tests/isolated_world_csp_insecure_src.json
- extensions/test/data/manifest_tests/isolated_world_csp_invalid_type.json
- extensions/test/data/manifest_tests/isolated_world_csp_missing_src.json
- extensions/test/data/manifest_tests/isolated_world_csp_no_dictionary_default_v2.json
- extensions/test/data/manifest_tests/isolated_world_csp_no_dictionary_default_v3.json
- extensions/test/data/manifest_tests/isolated_world_csp_valid.json
-
Updating trunk VERSION from 3682.0 to 3683.0
Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:09:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 74d5ea8ee88452765aba220083439b4bfcaeeacd Comments
Updating trunk VERSION from 3682.0 to 3683.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ia5829f2fd735a16bcebf7b0d85fcccb1a07b546f Reviewed-on: https://chromium-review.googlesource.com/c/1433354 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#625492}
Changed files
- chrome/VERSION
-
Image annotation: added annotation methods to the page annotator.
Changed by Michael Martis - martisohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:07:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b39a531368bd6c81b239a05abeea8e0d6642a4c3 Comments
Image annotation: added annotation methods to the page annotator. This CL implements the client logic needed to interact with the image annotation service. Specifically, this entails: - Accepting a ptr to the main service interface, and - Providing a "proxy" AnnotateImage method that sends page images (i.e. by accepting a node ID) for to the service for annotation. Bug: crbug.com/916363 Change-Id: I6d65c4223c001b06579940161d889962ba19aa43 Reviewed-on: https://chromium-review.googlesource.com/c/1424625 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Charles . <charleszhao@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#625491}
Changed files
- components/page_image_annotation/DEPS
- components/page_image_annotation/content/renderer/BUILD.gn
- components/page_image_annotation/content/renderer/content_page_annotator_driver.cc
- components/page_image_annotation/core/page_annotator.cc
- components/page_image_annotation/core/page_annotator.h
- components/page_image_annotation/core/page_annotator_unittest.cc
-
Android: Fix a bug of UI going reverse
Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 03:59:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 162164e1d255563eab61ee8b8d5874c6bfaf3a38 Comments
Android: Fix a bug of UI going reverse SideSlideLayout handles both back/forward directional UI by taking an absolute value of dragging offset. It should have ignored the negative offset against the intended direction, but the absolute value was being taken for the offset for the intended direction, therefore caused the reported bug. This CL rectifies it by discarding the offset in the reverse direction. Bug: 923927 Change-Id: I26977276940374d77ced33f30c7d2c559b00ea25 Reviewed-on: https://chromium-review.googlesource.com/c/1429361 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#625490}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/gesturenav/SideSlideLayout.java
-
Flag off PIP rounded corners by default.
Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com Changed at Thursday, 24-Jan-19 03:56:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 493df9a93b888c7fab9b9310df507d96d8e02eb5 Comments
Flag off PIP rounded corners by default. Bug: 923812 Test: Rounded corners no longer used for PIP windows. Change-Id: Id2a09865d05ed1f51fb5a1ee6645db0bcf59f4e4 Reviewed-on: https://chromium-review.googlesource.com/c/1424107 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#625489}
Changed files
- ash/public/cpp/ash_features.cc
-
Add Premount to SmbService
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Thursday, 24-Jan-19 03:45:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e0b6bab06364507f79f4d0c544bf89dd57d22d65 Comments
Add Premount to SmbService - Adds Premount method in SmbService in anticipation of SmbProviderClient::Premount's implementation. - Adds reponse callback method to connect MountOptions of the preconfigured share to the FileSystem. Bug: chromium:878502 Test: compiles Change-Id: I0c9af981d0cd1f2fd57c5a5ecfec4feef6c127de Reviewed-on: https://chromium-review.googlesource.com/c/1407660 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#625488}
Changed files
- chrome/browser/chromeos/smb_client/smb_service.cc
- chrome/browser/chromeos/smb_client/smb_service.h
-
Move NoTouchActivity to touchless package
Changed by Mehran Mahmoudi - mahmoudiohnoyoudont@google.com Changed at Thursday, 24-Jan-19 03:43:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0ebabc86af52b18004b8feb1639ac2d9b07c8c31 Comments
Move NoTouchActivity to touchless package Move the NoTouchActivity to the newly created touchless sub-package in order to declutter and tidy up the browser package. Bug: 922047 Change-Id: Ib7d9df3c89295e9e675b35a05e3613b390fbae5e Reviewed-on: https://chromium-review.googlesource.com/c/1432473 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@google.com> Cr-Commit-Position: refs/heads/master@{#625487}
Changed files
- chrome/android/java/AndroidManifest.xml
- chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
- chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
- chrome/android/java/src/org/chromium/chrome/browser/touchless/NoTouchActivity.java
- chrome/android/java_sources.gni
- chrome/android/javatests/src/org/chromium/chrome/browser/touchless/NoTouchActivityTest.java
-
s13n: Replace use of AccountTrackerService in advanced_protection_status_manager.cc/h
Changed by Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com Changed at Thursday, 24-Jan-19 03:37:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 923016306b416e430bf8eb25a6a36c703e836e0b Comments
s13n: Replace use of AccountTrackerService in advanced_protection_status_manager.cc/h As a step to use IdentityManager, this CL makes AdvancedProtectionStatusManager implement IdentityManager::Observer instead of AccountTrackerService::Observer. Besides, AccountTrackerService::SetIsAdvancedProtectionAccount is also replaced by AccountMutator::UpdateAccountInfo Bug: 922761, 922762 Change-Id: Ia223d792f745e4d0057eb1426389645ec9083aee Reviewed-on: https://chromium-review.googlesource.com/c/1426503 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625486}
Changed files
- chrome/browser/safe_browsing/advanced_protection_status_manager.cc
- chrome/browser/safe_browsing/advanced_protection_status_manager.h
-
[Android Webapp] Remove unneeded SameActivityWebappSplashDelegate#mInitializedLayout 7/9
Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 03:33:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 660cf035fc75e55a6e8fe6b2a9ac104581ee9cab Comments
[Android Webapp] Remove unneeded SameActivityWebappSplashDelegate#mInitializedLayout 7/9 BUG=918459 Change-Id: I6d374062b3ffe3d8aaed825531fd121b731bbbb6 Reviewed-on: https://chromium-review.googlesource.com/c/1425560 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#625485}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/webapps/SameActivityWebappSplashDelegate.java
-
cros: Clean up filenames in //ash/system/date
Changed by James Cook - jamescookohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:35:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3f2f7a96e751f558cc8dd812fd6b9ee37204804d Comments
cros: Clean up filenames in //ash/system/date * TimeView only displays the time, so move into //ash/system/time * Move ClockObserver to //ash/system/model to be next to clock_model.cc * Make the filenames match the class names. * Fix some includes. Bug: 924744 Test: ash_unittests Change-Id: I9dbcc157146c8fff019da7c169f00427f32f76ae Reviewed-on: https://chromium-review.googlesource.com/c/1432612 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#625484}
Changed files
- ash/BUILD.gn
- ash/system/model/clock_model.cc
- ash/system/model/clock_observer.h
- ash/system/power/tray_power.cc
- ash/system/time/time_tray_item_view.cc
- ash/system/time/time_tray_item_view.h
- ash/system/time/time_view.cc
- ash/system/time/time_view.h
- ash/system/time/time_view_unittest.cc
- ash/system/unified/unified_system_info_view.cc
- ash/system/unified/unified_system_tray.cc
- ash/system/unified/unified_system_tray_test_api.cc
-
[Feed] Switch to using onClearAllWithRefresh.
Changed by Sky Malice - skymohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:28:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 881f038dd7b969c5ff9fa11f4b946de2141a75e5 Comments
[Feed] Switch to using onClearAllWithRefresh. The Feed has requested that when we wipe out suggestions and then fetch new articles, instead of sequentially calling onClearAll and triggerRefresh, instead we just call onClearAllWithRefresh. This will let them handle these operations more gracefully and avoid races. The host classes were not initially structured to facilitate this. The scheduler, which must decide if we want to trigger a refresh or not, is not the same host that has access to the AppLifecycleListener which is what has the onClearAllWithRefresh method. This change plums a boolean back up from the scheduler to the FeedAppLifecycle so that we can decide if onClearAllWithRefresh or onClearAll should be called after an event occurs that wipes out all articles. Bug: 919901, 913874 Change-Id: I7684673a6367ba4aa90390ef98f8da938ac14c71 Reviewed-on: https://chromium-review.googlesource.com/c/1409479 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#625483}
Changed files
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedAppLifecycle.java
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
- chrome/android/javatests/src/org/chromium/chrome/browser/feed/FeedAppLifecycleTest.java
- chrome/browser/android/feed/feed_scheduler_bridge.cc
- chrome/browser/android/feed/feed_scheduler_bridge.h
- components/feed/core/feed_scheduler_host.cc
- components/feed/core/feed_scheduler_host.h
- components/feed/core/feed_scheduler_host_unittest.cc
-
Remove the 100GB drive promotional offer banner from file manager.
Changed by Stuart Langley - slangleyohnoyoudont@google.com Changed at Thursday, 24-Jan-19 02:20:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3f712760fd6fc7a2e52830486ac34a21b4e9ef56 Comments
Remove the 100GB drive promotional offer banner from file manager. The offer is moving to a chrome os offers website, and is no longer needed in the file manager. Bug: 922326 Change-Id: Id2d8077501bf6e1e80d2eb453fa95fc5346dcf3f Reviewed-on: https://chromium-review.googlesource.com/c/1426246 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#625482}
Changed files
- chrome/app/file_manager_strings.grdp
- chrome/browser/chromeos/file_manager/file_manager_string_util.cc
- ui/file_manager/file_manager/foreground/js/ui/banners.js
-
media/gpu/test: Adapt VideoFrameProcessor interface to pass const VideoFrame.
Changed by David Staessens - dstaessensohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:11:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8c12e83427de541b8aece0566c1cb4cbef51fa5d Comments
media/gpu/test: Adapt VideoFrameProcessor interface to pass const VideoFrame. This CL makes sure that a test VideoFrameProcessor can't modify a video frame. TEST=ran new VDA tests on nocturne BUG=879065 Change-Id: I1448c07fd64de8a4d933fc18d0a091b606cc9f56 Reviewed-on: https://chromium-review.googlesource.com/c/1428630 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#625481}
Changed files
- media/gpu/test/generic_dmabuf_video_frame_mapper.cc
- media/gpu/test/generic_dmabuf_video_frame_mapper.h
- media/gpu/test/vaapi_dmabuf_video_frame_mapper.cc
- media/gpu/test/vaapi_dmabuf_video_frame_mapper.h
- media/gpu/test/video_frame_helpers.h
- media/gpu/test/video_frame_mapper.h
- media/gpu/test/video_frame_validator.cc
- media/gpu/test/video_frame_validator.h
-
Make sure to create a WindowState when added to a parent.
Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:08:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c11049d2d9e21b6f055a24bc23905b1a638bdbe2 Comments
Make sure to create a WindowState when added to a parent. Bug: 924305 Test: Covered by unittest Change-Id: I1711ac65735beabd178acfb55212051668becc4d Reviewed-on: https://chromium-review.googlesource.com/c/1430853 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#625480}
Changed files
- ash/wm/window_properties.cc
- ash/wm/window_properties.h
- ash/wm/workspace/workspace_layout_manager.cc
- ash/wm/workspace/workspace_layout_manager_unittest.cc
-
media/gpu/test: Add new VDA test to reset after the first config info.
Changed by David Staessens - dstaessensohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:08:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 61dbf0cfb0c1c6166fc3050edeece52fd9ef9247 Comments
media/gpu/test: Add new VDA test to reset after the first config info. This CL adds a test that triggers a reset operation immediately after the first config info has been encountered in a H.264 stream. TEST=ran new VDA tests on nocturne BUG=905953 Change-Id: I0bb158ea9250ce726bd862707604be6252ea26b5 Reviewed-on: https://chromium-review.googlesource.com/c/1426501 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#625479}
Changed files
- media/gpu/test/video_player/video_decoder_client.cc
- media/gpu/test/video_player/video_decoder_client.h
- media/gpu/test/video_player/video_player.cc
- media/gpu/test/video_player/video_player.h
- media/gpu/video_decode_accelerator_tests.cc
-
Ensure cc::PictureLayer's client is cleared
Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:43:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5a90bca48f73b8d82fdbbce3ad938ffb430c6f36 Comments
Ensure cc::PictureLayer's client is cleared cc::PictureLayer is ref counted, so it can live longer than the client, so for safety, the client should call ClearClient() of the layer when the client is destructed or is no longer the client of the layer. Bug: 913464 Change-Id: Id9093a8fba371e3773dd0ae292a0f855ce4f100a Reviewed-on: https://chromium-review.googlesource.com/c/1427447 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625478}
Changed files
- content/renderer/child_frame_compositing_helper.cc
- content/renderer/child_frame_compositing_helper.h
- third_party/blink/renderer/core/paint/link_highlight_impl.cc
- third_party/blink/renderer/core/paint/link_highlight_impl.h
- third_party/blink/renderer/platform/graphics/compositing/content_layer_client_impl.cc
- third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
- ui/compositor/layer.cc
-
[Extensions] Enable onExtensionActivity if there are listeners
Changed by Kelvin Jiang - kelvinjiangohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:35:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b3dbf220651689808bbf443e7f7a44308d8c835e Comments
[Extensions] Enable onExtensionActivity if there are listeners Enable the broadcasting of onExtensionActivity events if a listener was added from chrome.activityLogPrivate. Previously, this was enabled only for whitelisted extensions. We also block activity logging from the browser itself/webUI (indicated by an empty extension id) as it can lead to an infinite loop of invoking an event listener callback, then logging that invocation as an activity. This quickly causes an OOM. Blocking is only done for the browser/whitelisted extensions for now as chrome.activityLogPrivate is only enabled for them. Bug: 832354 Change-Id: Ic86c8ec28bfbf797d6f2d3605c47ef2d8579234c Reviewed-on: https://chromium-review.googlesource.com/c/1419319 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625477}
Changed files
- chrome/browser/extensions/activity_log/activity_log.cc
- chrome/browser/extensions/activity_log/activity_log.h
- chrome/browser/extensions/activity_log/activity_log_unittest.cc
- chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
- chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
- chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
-
aura: move ownership of LocalSurfaceId to a separate class
Changed by Scott Violet - skyohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:35:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 590c820c3b7b0d312d6d040bbc0f133eae9aa7d8 Comments
aura: move ownership of LocalSurfaceId to a separate class At times WindowPortMus may act as either a parent allocator or a child allocator. Moving allocation to a separate class should make it clearer. BUG=922201,921129 Change-Id: I8853d3f657e1f0872bf06f46f29cf59ea628c91f Reviewed-on: https://chromium-review.googlesource.com/c/1424301 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625476}
Changed files
- content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
- ui/aura/BUILD.gn
- ui/aura/mus/mus_lsi_allocator.cc
- ui/aura/mus/mus_lsi_allocator.h
- ui/aura/mus/window_mus.h
- ui/aura/mus/window_port_mus.cc
- ui/aura/mus/window_port_mus.h
- ui/aura/mus/window_port_mus_unittest.cc
- ui/aura/mus/window_tree_client.cc
- ui/aura/mus/window_tree_client.h
- ui/aura/mus/window_tree_client_unittest.cc
- ui/aura/test/mus/window_port_mus_test_helper.cc
- ui/aura/test/mus/window_port_mus_test_helper.h
- ui/aura/window_unittest.cc
-
Roll src/third_party/skia 114b5af0e8cc..beaae554418b (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 01:34:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ff0f4f06c4a2d7ba223208116595ce9fad1cfe10 Comments
Roll src/third_party/skia 114b5af0e8cc..beaae554418b (1 commits) https://skia.googlesource.com/skia.git/+log/114b5af0e8cc..beaae554418b git log 114b5af0e8cc..beaae554418b --date=short --no-merges --format='%ad %ae %s' 2019-01-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@beaae554418b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I6501759f3e09e9b20bb2dffe61d34c901f83d2e6 Reviewed-on: https://chromium-review.googlesource.com/c/1431835 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625475}
Changed files
- DEPS
-
Switch CQ bot names
Changed by Stephen Martinis - martinissohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:34:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 059963f194d6006fdc26cb1db8b2656c1251c69a Comments
Switch CQ bot names Bug: 888810 Change-Id: I5eefa83167a21db8bf447583deb58b38b2dc13ff Reviewed-on: https://chromium-review.googlesource.com/c/1428720 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#625474}
Changed files
- docs/infra/cq_builders.md
- infra/config/branch/cq.cfg
-
Remove conditional use of LayerTreeView from RenderWidget.
Changed by danakj - danakjohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:32:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2ae8e4805cf3528619e05806e836a78d2c740e0b Comments
Remove conditional use of LayerTreeView from RenderWidget. The LayerTreeView is always present since we always composite RenderWidgets now (for many years ^_^). However, the LayerTreeView *is* removed during shutdown. Most places will not need to worry about this because OnClose() drops the IPC channel and most uses of LayerTreeView are in response to other IPCs. However a few cases involve calls from Blink which could still be active in between OnClose() and tearing down the RenderWidget+Blink, so in these cases early out if |closing_| which represents better conceptually what we're testing. TBR=avi@chromium.org Change-Id: Iff9133d9c69b327495f9290afcb471739124018b Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1432132 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625473}
Changed files
- content/renderer/render_widget.cc
-
RTCQuicTransport & RTCIceTransport - SecureContext
Changed by Seth Hampson - shampsonohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:29:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1a70719973246f3ac5c388a7be2b9a571f2da313 Comments
RTCQuicTransport & RTCIceTransport - SecureContext Updates the RTCQuicTransport and RTCIceTransport idl files to restrict the APIs to secure contexts only. Bug: 874296 Change-Id: Ib669480ea323df8e8856e38ff3f3798afb78c606 Reviewed-on: https://chromium-review.googlesource.com/c/1430432 Commit-Queue: Seth Hampson <shampson@chromium.org> Auto-Submit: Seth Hampson <shampson@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#625472}
Changed files
- third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
-
[s13n] Move ChildAccountService away from using AccountTrackerService
Changed by Julie Jeongeun Kim - jkimohnoyoudont@igalia.com Changed at Thursday, 24-Jan-19 01:27:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 09e01dc238c428894c25104ba00601e2d3863850 Comments
[s13n] Move ChildAccountService away from using AccountTrackerService This CL removes AccountTrackerService from ChildAccountService and uses IdentityManager instead of it. Bug: 922779, 922778 Change-Id: I2ee93fad73d56901bbd3db8b02db044a5ff8ccdd Reviewed-on: https://chromium-review.googlesource.com/c/1429821 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#625471}
Changed files
- chrome/browser/supervised_user/child_accounts/child_account_service.cc
- chrome/browser/supervised_user/child_accounts/child_account_service.h
-
wtf/win: Remove more redundant flags.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:18:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f2d516607181592608dc27199bee2745dcc28c0c Comments
wtf/win: Remove more redundant flags. The defines are already there globally from //build/config/win:runtime_library, the /wd flag from //build/config/compiler:default_warnings. No behavior change. Bug: none Change-Id: Ib24fb4723d5e4070b70c9aeef17e5a785cd134c3 Reviewed-on: https://chromium-review.googlesource.com/c/1429079 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#625470}
Changed files
- third_party/blink/renderer/platform/wtf/BUILD.gn
-
SignedExchange: Remove the Request Method field
Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:18:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a583aac50c48df257ff435da9af8792e227fe884 Comments
SignedExchange: Remove the Request Method field Signed Exchange version b3 doesn't have a request method. Since we have dropped support for b2, we can remove it from our codebase. Bug: 919424 Change-Id: Ia8a522a658b64c0aebc974ad7ea35b45e3298a60 Reviewed-on: https://chromium-review.googlesource.com/c/1429899 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625469}
Changed files
- content/browser/devtools/protocol/network_handler.cc
- content/browser/web_package/mock_signed_exchange_handler.cc
- content/browser/web_package/signed_exchange_envelope.cc
- content/browser/web_package/signed_exchange_envelope.h
- content/browser/web_package/signed_exchange_envelope_unittest.cc
- content/browser/web_package/signed_exchange_handler.cc
- content/browser/web_package/signed_exchange_handler.h
- content/browser/web_package/signed_exchange_handler_unittest.cc
- content/browser/web_package/signed_exchange_loader.cc
- content/browser/web_package/signed_exchange_loader.h
- content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
- third_party/blink/renderer/core/inspector/browser_protocol.pdl
- third_party/blink/renderer/devtools/front_end/network/SignedExchangeInfoView.js
-
Fix icon bounds with new-tab-icon animation
Changed by Peter Boström - pbosohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:17:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 52572713bfe2437e1bac822a2399b695a06f0643 Comments
Fix icon bounds with new-tab-icon animation The initial version of the new animation did not account for the larger icon area, so items inside the tab have shifted with 2dp. Bug: chromium:923179 Change-Id: I55c5994c58dbf25e0d0df9ac2eb4c8688e04a09b Reviewed-on: https://chromium-review.googlesource.com/c/1427467 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#625468}
Changed files
- chrome/browser/ui/views/tabs/tab.cc
-
<blame list capped at 100 commits>
Changed by <blame list capped at 100 commits> - Changed at N/A Repository Branch Revision Comments
<blame list capped at 100 commits>