Builder mac-views-rel
Build 14056
Results:
Internal Failure
Trigger Info:
Project | chromium |
Revision | c499c82fe065b5b577ee8628c4c94918acf8f00a |
Execution:
- Source: Task 429773d892964d10
- Recipe: chromium
Build Properties:
Name | Value | Source |
---|
Blamelist:
- Albert J. Wong (ajwongohnoyoudont@chromium.org)
- David Staessens (dstaessensohnoyoudont@chromium.org)
- Christopher Cameron (ccameronohnoyoudont@chromium.org)
- Tsuyoshi Horo (horoohnoyoudont@chromium.org)
- Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
- David Schinazi (dschinaziohnoyoudont@chromium.org)
- Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Piotr Bialecki (bialpioohnoyoudont@chromium.org)
- rbpotter (rbpotterohnoyoudont@chromium.org)
- Seth Hampson (shampsonohnoyoudont@chromium.org)
- Chris Harrelson (chrishtrohnoyoudont@chromium.org)
- Martin Kreichgauer (martinkrohnoyoudont@google.com)
- Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
- Manu Cornet (manucornetohnoyoudont@chromium.org)
- Takuto Ikuta (tikutaohnoyoudont@chromium.org)
- Chris Blume (cblumeohnoyoudont@chromium.org)
- Madeleine Barowsky (mbarowskyohnoyoudont@chromium.org)
- Fabrice de Gans-Riberi (fdegansohnoyoudont@chromium.org)
- Karan Bhatia (karandeepbohnoyoudont@chromium.org)
- Ken Rockot (rockotohnoyoudont@google.com)
- Joel Einbinder (einbinderohnoyoudont@chromium.org)
- Kentaro Hara (harakenohnoyoudont@chromium.org)
- Alexey Baskakov (loysoohnoyoudont@chromium.org)
- Timothy Loh (timlohohnoyoudont@chromium.org)
- Timothy Loh (timlohohnoyoudont@chromium.org)
- Sam McNally (sammcohnoyoudont@chromium.org)
- Alexey Baskakov (loysoohnoyoudont@chromium.org)
- Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
- Timothy Loh (timlohohnoyoudont@chromium.org)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Jamie Madill (jmadillohnoyoudont@chromium.org)
- Luciano Pacheco (lucmultohnoyoudont@chromium.org)
- Chris Mumford (cmumfordohnoyoudont@google.com)
- Kristi Park (kristiparkohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Jun Mukai (mukaiohnoyoudont@chromium.org)
- Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
- Aaron Colwell (acolwellohnoyoudont@google.com)
- Alexey Baskakov (loysoohnoyoudont@chromium.org)
- Hadi Moshayedi (moshayediohnoyoudont@chromium.org)
- Karan Bhatia (karandeepbohnoyoudont@chromium.org)
- chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
- Michael Martis (martisohnoyoudont@chromium.org)
- Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
- Eliot Courtney (edcourtneyohnoyoudont@google.com)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Mehran Mahmoudi (mahmoudiohnoyoudont@google.com)
- Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
- Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
- James Cook (jamescookohnoyoudont@chromium.org)
- Sky Malice (skymohnoyoudont@chromium.org)
- Stuart Langley (slangleyohnoyoudont@google.com)
- David Staessens (dstaessensohnoyoudont@chromium.org)
- Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
- David Staessens (dstaessensohnoyoudont@chromium.org)
- Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
- Kelvin Jiang (kelvinjiangohnoyoudont@chromium.org)
- Scott Violet (skyohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Stephen Martinis (martinissohnoyoudont@chromium.org)
- danakj (danakjohnoyoudont@chromium.org)
- Seth Hampson (shampsonohnoyoudont@chromium.org)
- Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
- Peter Boström (pbosohnoyoudont@chromium.org)
- Lily Chen (chlilyohnoyoudont@chromium.org)
- Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
- Christian Fremerey (chfremerohnoyoudont@chromium.org)
- Wei Li (weiliohnoyoudont@chromium.org)
- James Cook (jamescookohnoyoudont@chromium.org)
- Takuto Ikuta (tikutaohnoyoudont@chromium.org)
- Scott Violet (skyohnoyoudont@chromium.org)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Wei Li (weiliohnoyoudont@chromium.org)
- Hans Wennborg (hansohnoyoudont@chromium.org)
- Aidan Wolter (awolterohnoyoudont@chromium.org)
- Michael Martis (martisohnoyoudont@chromium.org)
- Maggie Cai (mxcaiohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
- Aran Gilman (gilmanmhohnoyoudont@google.com)
- Livvie Lin (livvielinohnoyoudont@chromium.org)
- Scott Violet (skyohnoyoudont@chromium.org)
- dpapad (dpapadohnoyoudont@chromium.org)
- Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
- Jeffrey Cohen (jeffreycohenohnoyoudont@chromium.org)
- khachatryan (khachatryanohnoyoudont@chromium.org)
- Darren Shen (shendohnoyoudont@chromium.org)
- Tomasz Wiszkowski (enderohnoyoudont@google.com)
- Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
- Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
- Brandon Wylie (wyliebohnoyoudont@chromium.org)
- Etienne Pierre-doray (etiennepohnoyoudont@chromium.org)
- Quinten Yearsley (qyearsleyohnoyoudont@chromium.org)
- Egor Pasko (paskoohnoyoudont@chromium.org)
- Kyle Milka (kmilkaohnoyoudont@chromium.org)
- Aran Gilman (gilmanmhohnoyoudont@google.com)
- <blame list capped at 100 commits> ()
Timing:
Create | Thursday, 24-Jan-19 06:53:12 UTC |
Start | N/A |
End | Thursday, 24-Jan-19 06:53:13 UTC |
Pending | 246 ms |
Execution | N/A |
All Changes:
-
More distinct start/end market for task backtrace.
Changed by Albert J. Wong - ajwongohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:52:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c499c82fe065b5b577ee8628c4c94918acf8f00a Comments
More distinct start/end market for task backtrace. The previous fill of 0xfe and 0xef ran into problems in server-side processing as minidump generation uses that pattern is a "unreadable memory" fill causing lots of false-positives. Bug: none Change-Id: Icf6aa04304394ffef673fe5721c6ec291e5b38d4 Reviewed-on: https://chromium-review.googlesource.com/c/1405454 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#625535}
Changed files
- base/debug/task_annotator.cc
-
media/gpu/test: Move frame validation in VD tests to a separate thread.
Changed by David Staessens - dstaessensohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:49:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a2ef35d385f8412488674f2a2d70325f5338c56c Comments
media/gpu/test: Move frame validation in VD tests to a separate thread. This speeds up the new video decoder tests a bit, since we don't have to block on validation before scheduling the next decode operation. TEST=ran new VDA tests on nocturne BUG=879065 Change-Id: Ie1d94647b376234c59ee9900673e295f09ac711a Reviewed-on: https://chromium-review.googlesource.com/c/1420477 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625534}
Changed files
- media/gpu/test/video_frame_helpers.h
- media/gpu/test/video_frame_validator.cc
- media/gpu/test/video_frame_validator.h
- media/gpu/test/video_player/video_decoder_client.cc
- media/gpu/video_decode_accelerator_tests.cc
- media/gpu/video_decode_accelerator_unittest.cc
-
MacPWAs: Add callback for shim process termination
Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:42:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e10571be54281bc4b80a00628a5c3c983889d94c Comments
MacPWAs: Add callback for shim process termination Add plumbing for a callback to be made when the shim process terminates. Don't actually use this plumbing yet. Bug: 924482 Change-Id: I5deb7e2d6205d615da456129e3ddb3830dc653a0 Reviewed-on: https://chromium-review.googlesource.com/c/1433500 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#625533}
Changed files
- chrome/browser/apps/app_shim/app_shim_handler_mac.h
- chrome/browser/apps/app_shim/app_shim_host_mac.cc
- chrome/browser/apps/app_shim/app_shim_host_mac.h
- chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
- chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
- chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
- chrome/browser/apps/app_shim/apps_page_shim_handler.h
- chrome/browser/apps/app_shim/apps_page_shim_handler.mm
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc
- chrome/browser/web_applications/components/web_app_shortcut_mac.h
- chrome/browser/web_applications/components/web_app_shortcut_mac.mm
- chrome/browser/web_applications/extensions/web_app_extension_shortcut_mac.mm
-
Mark sxg-referrer.tentative.https.html [ Timeout Pass ]
Changed by Tsuyoshi Horo - horoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:37:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e2c30a2f5ae6421fdf891142ffb209da34fda71f Comments
Mark sxg-referrer.tentative.https.html [ Timeout Pass ] Bug: 924752 Change-Id: I3723a05aa2e62c379c862dea44b16270c6652cbd Reviewed-on: https://chromium-review.googlesource.com/c/1433391 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#625532}
Changed files
- third_party/blink/web_tests/TestExpectations
-
[Fuchsia] Enable H264 video decoder unittests
Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:29:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a19d20847cc0582be9eeb3c946946e40ca19ff6b Comments
[Fuchsia] Enable H264 video decoder unittests mediacodec now supports SW video decoding for H264, so now it's possible to run FuchsiaVideoDecoder unittests on the buts. This change also fixes two issues: 1. CodecBuffer.buffer_index was not set. 2. YV12 output format was not supported. Bug: 921085 Change-Id: I5cee20dfc6571a2d117e8ba0c09a3ed6cefc260d Reviewed-on: https://chromium-review.googlesource.com/c/1429280 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625531}
Changed files
- media/filters/fuchsia/fuchsia_video_decoder.cc
- media/filters/fuchsia/fuchsia_video_decoder.h
- media/filters/fuchsia/fuchsia_video_decoder_unittest.cc
-
Enable QuicConnectionId variable length flags
Changed by David Schinazi - dschinaziohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:14:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c828105765844b300ae881bd90fb3f765116bd74 Comments
Enable QuicConnectionId variable length flags This change reenables the QuicConnectionId variable length flags (which makes QuicConnectionId be represented in memory in network byte order) and fixes chromium-specific behavior that used to rely on the connection IDs being 64 bits. Bug: b/123008920 Change-Id: I9497c516a8612be3c0aaddd152825f559a9086f3 Reviewed-on: https://chromium-review.googlesource.com/c/1418632 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#625530}
Changed files
- net/http/http_proxy_client_socket_wrapper_unittest.cc
- net/http/http_stream_factory_job_controller_unittest.cc
- net/http/http_stream_factory_unittest.cc
- net/quic/bidirectional_stream_quic_impl_unittest.cc
- net/quic/quic_chromium_client_session.cc
- net/quic/quic_chromium_client_session_test.cc
- net/quic/quic_connection_logger.cc
- net/quic/quic_flags_list.h
- net/quic/quic_http_stream_test.cc
- net/quic/quic_network_transaction_unittest.cc
- net/quic/quic_proxy_client_socket_unittest.cc
- net/quic/quic_stream_factory.cc
- net/quic/quic_stream_factory_test.cc
- net/third_party/quic/quartc/quartc_stream_test.cc
- net/tools/quic/quic_http_proxy_backend_stream_test.cc
- net/tools/quic/quic_http_proxy_backend_test.cc
- net/tools/quic/quic_simple_server_session_helper.cc
- net/tools/quic/quic_simple_server_session_helper_test.cc
- third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
-
Revert "Re-implement CrOS merge session throttle in the network service."
Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:11:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c0d24a87f706a0627c1f540f8c8e8c6750c675a7 Comments
Revert "Re-implement CrOS merge session throttle in the network service." This reverts commit 4e6965956ec5ecbfdace5eb4989609f4887c632c. Reason for revert: Suspected to cause crashes on these tests: CastSessionBrowserTest.CreateAndDestroy InstantProcessNavigationTest.ForkForNavigationsToNewTabURLs Both crashing on ChromeRenderThreadObserver Received signal 11 SEGV_MAPERR 000000000000 #0 0x55de2b025d59 base::debug::CollectStackTrace() #1 0x55de2af9a183 base::debug::StackTrace::StackTrace() #2 0x55de2b0258e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f5b34da4330 <unknown> #4 0x55de2b44a78b ChromeRenderThreadObserver::ChromeRenderThreadObserver() #5 0x55de2b441dc4 ChromeContentRendererClient::RenderThreadStarted() Original change's description: > Re-implement CrOS merge session throttle in the network service. > > This change re-implements the resource load throttle that waits for the > Chrome OS merge session to complete (or timeout) before allowing resource > loads. This implementation is compatible with the network service. Previously > this was implemented by the MergeSessionResourceThrottle class, but is > now implemented by MergeSessionLoaderThrottle. > > Bug: 897986 > Change-Id: I0a4d2e1961504bd1a979a1d964d62f9ec17b8b33 > Reviewed-on: https://chromium-review.googlesource.com/c/1318412 > Commit-Queue: Chris Mumford <cmumford@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625501} TBR=xiyuan@chromium.org,kenrb@chromium.org,jam@chromium.org,cmumford@google.com Change-Id: Ibffe2a34608db94c7d86c9b16bcd037a2c23fad6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897986 Reviewed-on: https://chromium-review.googlesource.com/c/1433389 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625529}
Changed files
- chrome/browser/chrome_content_browser_client.cc
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/login/signin/merge_session_navigation_throttle_unittest.cc
- chrome/browser/chromeos/login/signin/merge_session_resource_throttle.cc
- chrome/browser/chromeos/login/signin/merge_session_resource_throttle.h
- chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h
- chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc
- chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.h
- chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
- chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
- chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
- chrome/browser/profiles/renderer_updater.cc
- chrome/browser/profiles/renderer_updater.h
- chrome/common/chrome_switches.cc
- chrome/common/chrome_switches.h
- chrome/common/renderer_configuration.mojom
- chrome/renderer/BUILD.gn
- chrome/renderer/chrome_content_renderer_client.cc
- chrome/renderer/chrome_content_renderer_client.h
- chrome/renderer/chrome_render_thread_observer.cc
- chrome/renderer/chrome_render_thread_observer.h
- chrome/renderer/chromeos_delayed_callback_group.cc
- chrome/renderer/chromeos_delayed_callback_group.h
- chrome/renderer/chromeos_delayed_callback_group_unittest.cc
- chrome/renderer/chromeos_merge_session_loader_throttle.cc
- chrome/renderer/chromeos_merge_session_loader_throttle.h
- chrome/renderer/url_loader_throttle_provider_impl.cc
- chrome/test/BUILD.gn
- chrome/test/data/extensions/api_test/merge_session/background.js
- testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
-
Roll src/third_party/skia beaae554418b..a6ab2bdd8cd3 (4 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 06:10:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 08b80f14e0050152ddc5936327e9ad1041440b31 Comments
Roll src/third_party/skia beaae554418b..a6ab2bdd8cd3 (4 commits) https://skia.googlesource.com/skia.git/+log/beaae554418b..a6ab2bdd8cd3 git log beaae554418b..a6ab2bdd8cd3 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2019-01-23 rmistry@google.com Fix spreadsheets page set for RecreateSKPs bot 2019-01-23 csmartdalton@google.com Implement XP factory dumping 2019-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2d4f839f26f7..9d803dd280d8 (457 commits) Created with: gclient setdep -r src/third_party/skia@a6ab2bdd8cd3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ief8411fb8caa054e067141b15569e1818db71e80 Reviewed-on: https://chromium-review.googlesource.com/c/1433434 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625528}
Changed files
- DEPS
-
WebUI Dark Mode: update .svg icons with embedded fill
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:07:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8d13a0e1389fb42eeab6d9d2b01ed1ea1b5e2773 Comments
WebUI Dark Mode: update .svg icons with embedded fill This CL duplicates and updates the light mode .svg icons from cr_icons_css.html to dark-specific equivalents. This was done semi-mechanically with a bunch of sed hacking to copy and change the fill color. I also updated .md-select's icon as well. I also renamed some icons that seemed to be overly presentation in their naming (i.e. -white), changed the default --iron-icon-fill-color for settings, deleted some unused shared variables, and added an error color for settings. Screenshots: https://imgur.com/a/MyI725P Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c485b44#slide=id.g364d7f9db1_0_0 R=aee@chromium.org BUG=883049 Change-Id: I7709044a360a2e78136c2123dbe17ea0de662e37 Reviewed-on: https://chromium-review.googlesource.com/c/1431916 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625527}
Changed files
- chrome/browser/resources/settings/settings_vars_css.html
- ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.html
- ui/webui/resources/cr_elements/cr_icons_css.html
- ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
- ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
- ui/webui/resources/cr_elements_images.grdp
- ui/webui/resources/html/md_select_css.html
- ui/webui/resources/images/dark/arrow_down.svg
- ui/webui/resources/images/dark/arrow_right.svg
- ui/webui/resources/images/dark/icon_arrow_back.svg
- ui/webui/resources/images/dark/icon_arrow_dropdown.svg
- ui/webui/resources/images/dark/icon_cancel.svg
- ui/webui/resources/images/dark/icon_clear.svg
- ui/webui/resources/images/dark/icon_delete_gray.svg
- ui/webui/resources/images/dark/icon_expand_less.svg
- ui/webui/resources/images/dark/icon_expand_more.svg
- ui/webui/resources/images/dark/icon_more_vert.svg
- ui/webui/resources/images/dark/icon_picture_delete.svg
- ui/webui/resources/images/dark/icon_refresh.svg
- ui/webui/resources/images/dark/icon_search.svg
- ui/webui/resources/images/dark/icon_settings.svg
- ui/webui/resources/images/dark/icon_toolbar_cancel.svg
- ui/webui/resources/images/dark/icon_toolbar_menu.svg
- ui/webui/resources/images/dark/icon_visibility.svg
- ui/webui/resources/images/dark/icon_visibility_off.svg
- ui/webui/resources/images/icon_picture_delete.svg
- ui/webui/resources/images/icon_toolbar_cancel.svg
- ui/webui/resources/images/icon_toolbar_menu.svg
-
ARCore: Address feedback from old CL
Changed by Piotr Bialecki - bialpioohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:06:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a4b651b2c7f1d9e7f98e38bd691b2cc1f22fd92c Comments
ARCore: Address feedback from old CL This CL addresses most of the remaining feedback present on https://crrev.com/c/1341025 Bug: 852607 Change-Id: Ic31bd19adfbd26da523a9d97ba9ee2dbe06f3651 Reviewed-on: https://chromium-review.googlesource.com/c/1391714 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625526}
Changed files
- chrome/browser/android/vr/arcore_device/arcore_device_provider.cc
- chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
- chrome/browser/android/vr/arcore_device/arcore_shim.cc
- chrome/browser/android/vr/arcore_device/arcore_shim.h
- third_party/blink/renderer/modules/xr/xr.cc
-
Print Preview: Fix destinations dropdown for RTL
Changed by rbpotter - rbpotterohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:01:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2140f9a6b5fb977a8ff07f3c033cd2a936a2745c Comments
Print Preview: Fix destinations dropdown for RTL Bug: 924428 Change-Id: I40c18c1a32980371eb44d8cce437805822c5db96 Reviewed-on: https://chromium-review.googlesource.com/c/1432334 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625525}
Changed files
- chrome/browser/resources/print_preview/new/destination_select.html
-
Adds getStats() method to RTCQuicTransport.
Changed by Seth Hampson - shampsonohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 06:01:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0bc24b649c8d060cd7d41e406571c662db1638cf Comments
Adds getStats() method to RTCQuicTransport. getStats() returns a promise that resolves with a dictionary of stats defined in the RTCQuicTransportStats dictionary. Bug: 874296 Change-Id: I907e529ebf074842c6702df7d90349515c48a5ba Reviewed-on: https://chromium-review.googlesource.com/c/1430599 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625524}
Changed files
- third_party/blink/renderer/modules/modules_idl_files.gni
- third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
- third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.h
- third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
- third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.h
- third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_stats.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc
- third_party/blink/web_tests/external/wpt/webrtc-quic/RTCQuicTransport.https.html
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
-
[PE] Optimize SetNeedsOverflowRecalc to avoid PaintingLayer.
Changed by Chris Harrelson - chrishtrohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:54:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 958c583e7e46899fa4bb9650acdf6688aa725181 Comments
[PE] Optimize SetNeedsOverflowRecalc to avoid PaintingLayer. PaintingLayer() is expensive, because it walks up the containing block chain. Instead, change the code to take advantage of the existing walk up the containing block chain in MarkContainerChainForOverflowRecalcIfNeeded. Bug: 918598 Change-Id: I1888db820929a8a345a7d1f9341e0eaa52d826bc Reviewed-on: https://chromium-review.googlesource.com/c/1432234 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#625523}
Changed files
- third_party/blink/renderer/core/layout/layout_embedded_object.cc
- third_party/blink/renderer/core/layout/layout_object.cc
- third_party/blink/renderer/core/layout/svg/layout_svg_root.cc
- third_party/blink/renderer/core/layout/svg/layout_svg_text.cc
- third_party/blink/web_tests/platform/linux/paint/invalidation/overflow/overflow-delete-line-expected.txt
-
fido: reintroduce the WebAuthn caBLE feature and UI flag
Changed by Martin Kreichgauer - martinkrohnoyoudont@google.com Changed at Thursday, 24-Jan-19 05:52:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cd786f640655d6b44b16b3a572dcd37dbc36dee7 Comments
fido: reintroduce the WebAuthn caBLE feature and UI flag This adds the WebAuthenticationCable feature flag and related enable-web-authentication-cable-support UI flag. These flags were previously removed in 800d018cf6d2a00c4d03ce57ed12f1debe06bc2d, but we are anticipating having to disable caBLE on some OSes in the future based on user feedback. Also clean up some ununsed flag_descriptions entries and a dangling declaration of the WebAuthenticationCableWin flag. Bug: 924800 Change-Id: I08623b19c62b894391e903f7dfce30f0aa00b7f2 Reviewed-on: https://chromium-review.googlesource.com/c/1433133 Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#625522}
Changed files
- chrome/browser/about_flags.cc
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
- content/browser/webauth/authenticator_impl.cc
- content/browser/webauth/authenticator_impl_unittest.cc
- content/public/common/content_features.cc
- content/public/common/content_features.h
-
ws: Make EnsureClientHasDrawnWindow retry capturing
Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:40:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 71e8cf2805c42843aa426be48d8cbb2f04324875 Comments
ws: Make EnsureClientHasDrawnWindow retry capturing WindowServerTestImpl::EnsureClientHasDrawnWindow could capture window contents too early and end up with false positives. Retry 3 times with 1 seconds apart to make it more reliable. Bug: 923406 Change-Id: I5f09106c29c105348e421dded1727d1873cd06fa Reviewed-on: https://chromium-review.googlesource.com/c/1432452 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625521}
Changed files
- services/ws/window_server_test_impl.cc
- services/ws/window_server_test_impl.h
-
CrOS Shelf: Let the tooltip manager handle key events
Changed by Manu Cornet - manucornetohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:39:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2491dd10914e961e9b5a8a186b05cd7b22f85702 Comments
CrOS Shelf: Let the tooltip manager handle key events This fixes a bug where a bubble (namely a hover preview bubble) could be dismissed with a keystroke without giving the tooltip manager a chance to do the necessary cleanup. We'll likely need to expand this in the future to handle keyboard navigation within the hover preview bubbles, but for now closing any shown bubble with any key event avoids a nasty crash. Bug: 902539 Change-Id: Ib642496f2ca1657189d0b3b9471ce2619c218b40 Reviewed-on: https://chromium-review.googlesource.com/c/1420817 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#625520}
Changed files
- ash/shelf/shelf_tooltip_manager.cc
- ash/shelf/shelf_tooltip_manager.h
- ash/shelf/shelf_tooltip_manager_unittest.cc
-
Reland "[mojo] move definition of operator<< for enum to mojom-shared.cc"
Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:37:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 55f5c137b3c6fe9316be38dc8349a97f23e2d56d Comments
Reland "[mojo] move definition of operator<< for enum to mojom-shared.cc" This is a reland of d51ebd693a614093b052b6273a48f2058f35d922 I removed unnecessary public_deps from //ui/accessibility:ax_enums_mojo to fix link failure on lib fuzzer builder. Original change's description: > [mojo] move definition of operator<< for enum to mojom-shared.cc > > This is to make mojo header file smaller for the file having many enum values. > e.g. > https://cs.chromium.org/chromium/src/out/Debug/gen/third_party/blink/public/platform/web_feature.mojom-shared.h > > This reduced total size of *.mojom-shared.h when building chrome on linux > from 10099430 bytes to 9510524 bytes. > > Bug: 922875 > Change-Id: I3183b184102cbbe3b5a971660f046e784ff1b771 > Reviewed-on: https://chromium-review.googlesource.com/c/1415246 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624012} Bug: 922875, 924140 Change-Id: Idee3a045b08dd011fae7a26bb3d25377bdeb59a7 Reviewed-on: https://chromium-review.googlesource.com/c/1433372 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#625519}
Changed files
- content/public/common/BUILD.gn
- mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl
- mojo/public/tools/bindings/generators/cpp_templates/module-shared.cc.tmpl
- mojo/public/tools/bindings/generators/cpp_templates/module-shared.h.tmpl
- third_party/blink/public/BUILD.gn
- third_party/blink/public/mojom/BUILD.gn
- ui/accessibility/BUILD.gn
- ui/base/ime/chromeos/public/interfaces/BUILD.gn
-
Use SharedImages in GlRenderer
Changed by Chris Blume - cblumeohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:34:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 764cb23f7b1790a35b3720c73fa8db94c70ca830 Comments
Use SharedImages in GlRenderer To ease transition of WebView using a Vulkan functor, we want to isolate each step and make sure that step works on its own. One step is to use SharedImages in GlRenderer. This CL updates GlRenderer to use SharedImages. BUG=922834 Change-Id: I94678e92881f1d974034f3fc1e43a5d39fa932dc Reviewed-on: https://chromium-review.googlesource.com/c/1428739 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#625518}
Changed files
- components/viz/service/display/display_resource_provider.cc
-
Re-enable MipsAddedWhileOriginalInUse test since Windows OOM bug fixed
Changed by Madeleine Barowsky - mbarowskyohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:30:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1d9b36dff73a0034ddf9f0a2d2b4ded380a065bc Comments
Re-enable MipsAddedWhileOriginalInUse test since Windows OOM bug fixed Bug: 867468 Change-Id: I5302cf831d40867c4b43864146ac38537adc4cf1 Reviewed-on: https://chromium-review.googlesource.com/c/1427099 Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625517}
Changed files
- cc/tiles/gpu_image_decode_cache_unittest.cc
-
[Fuchsia] Rename //fuchsia/app to //fuchsia/runners.
Changed by Fabrice de Gans-Riberi - fdegansohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:27:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 683a9d9d691c06dcda735637a4f0d85c4f6f3c55 Comments
[Fuchsia] Rename //fuchsia/app to //fuchsia/runners. This CL also removes all C++ namespace in this part of the //fuchsia directory as this code is not called anywhere else. This CL also adds a build file specifically for the //fuchsia/runners targets, cleaning up the target names and setting the proper visibility for targets in the process. TBR=jbudorick@chromium.org Bug: 922635 Change-Id: I2279903b9a8c5ac7e11f05427113945264616807 Reviewed-on: https://chromium-review.googlesource.com/c/1423557 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625516}
Changed files
- BUILD.gn
- fuchsia/BUILD.gn
- fuchsia/runners/BUILD.gn
- fuchsia/runners/cast/bindings/cast_channel.cc
- fuchsia/runners/cast/bindings/cast_channel.h
- fuchsia/runners/cast/bindings/cast_channel.js
- fuchsia/runners/cast/bindings/cast_channel_browsertest.cc
- fuchsia/runners/cast/cast_runner.cc
- fuchsia/runners/cast/cast_runner.h
- fuchsia/runners/cast/cast_runner_integration_test.cc
- fuchsia/runners/cast/cast_runner_unittest.cc
- fuchsia/runners/cast/fake_application_config_manager.cc
- fuchsia/runners/cast/fake_application_config_manager.h
- fuchsia/runners/cast/main.cc
- fuchsia/runners/cast/sandbox_policy
- fuchsia/runners/cast/test_common.cc
- fuchsia/runners/cast/test_common.h
- fuchsia/runners/cast/testdata/cast_channel.html
- fuchsia/runners/cast/testdata/cast_channel_reconnect.html
- fuchsia/runners/common/web_component.cc
- fuchsia/runners/common/web_component.h
- fuchsia/runners/common/web_content_runner.cc
- fuchsia/runners/common/web_content_runner.h
- fuchsia/runners/web/main.cc
- fuchsia/runners/web/sandbox_policy
- fuchsia/runners/web/web_runner_smoke_test.cc
- testing/buildbot/chromium.fyi.json
- testing/buildbot/chromium.linux.json
- testing/buildbot/gn_isolate_map.pyl
- testing/buildbot/test_suite_exceptions.pyl
- testing/buildbot/test_suites.pyl
-
Extensions: Restrict mv3 extensions to use "content_security_policy" as dictionary.
Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:25:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 75d36ac0c81c3e319652ab4de6297ff84fa0f09f Comments
Extensions: Restrict mv3 extensions to use "content_security_policy" as dictionary. This CL fixes an existing TODO and restricts manifest v3 extensions such that they always use "content_security_policy" manifest key as a dictionary. BUG=914224 Change-Id: I4b7be7cd9edf64a016d343660e11e4a197c5b409 Reviewed-on: https://chromium-review.googlesource.com/c/1423744 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625515}
Changed files
- extensions/common/manifest_handlers/csp_info.cc
- extensions/common/manifest_handlers/csp_info_unittest.cc
- extensions/test/data/manifest_tests/csp_dictionary_empty_v3.json
- extensions/test/data/manifest_tests/csp_dictionary_missing_v3.json
- extensions/test/data/manifest_tests/csp_invalid_type_v3.json
-
Add a base::Feature for Mojo dispatch change
Changed by Ken Rockot - rockotohnoyoudont@google.com Changed at Thursday, 24-Jan-19 05:20:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b9991b861d14bb879d0ae47bccbd5781e1a0f27e Comments
Add a base::Feature for Mojo dispatch change Adds a new base::Feature to control whether or not Mojo uses the more granular task-per-message dispatch policy as opposed to the old batch dispatch behavior. This is disabled by default until M73 branch. TBR=jam@chromium.org Bug: 866708 Change-Id: I138a66c0d65106f44f153e02c1cf92d71c27d14d Reviewed-on: https://chromium-review.googlesource.com/c/1433139 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#625514}
Changed files
- mojo/public/cpp/bindings/BUILD.gn
- mojo/public/cpp/bindings/connector.h
- mojo/public/cpp/bindings/features.cc
- mojo/public/cpp/bindings/features.h
- mojo/public/cpp/bindings/lib/connector.cc
-
DevTools: Convert to Shadow DOM and Custom Elements v1
Changed by Joel Einbinder - einbinderohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:19:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b00e6ea1c9b4db5d743c7c204b1f63abf89e0398 Comments
DevTools: Convert to Shadow DOM and Custom Elements v1 Bug: 685385 Change-Id: I027e84d8003b7799492211d5fcf8348cd91fd799 Reviewed-on: https://chromium-review.googlesource.com/c/1422962 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#625513}
Changed files
- third_party/blink/renderer/devtools/front_end/accessibility/AXBreadcrumbsPane.js
- third_party/blink/renderer/devtools/front_end/accessibility/AccessibilityNodeView.js
- third_party/blink/renderer/devtools/front_end/accessibility/accessibilityNode.css
- third_party/blink/renderer/devtools/front_end/changes/changesView.css
- third_party/blink/renderer/devtools/front_end/console/ConsoleViewMessage.js
- third_party/blink/renderer/devtools/front_end/console_counters/WarningErrorCounter.js
- third_party/blink/renderer/devtools/front_end/console_counters/errorWarningCounter.css
- third_party/blink/renderer/devtools/front_end/dom_extension/DOMExtension.js
- third_party/blink/renderer/devtools/front_end/elements/ElementsSidebarPane.js
- third_party/blink/renderer/devtools/front_end/elements/StylesSidebarPane.js
- third_party/blink/renderer/devtools/front_end/elements/classesPaneWidget.css
- third_party/blink/renderer/devtools/front_end/emulation/DeviceModeView.js
- third_party/blink/renderer/devtools/front_end/emulation/sensors.css
- third_party/blink/renderer/devtools/front_end/inline_editor/CSSShadowEditor.js
- third_party/blink/renderer/devtools/front_end/inline_editor/ColorSwatch.js
- third_party/blink/renderer/devtools/front_end/inspector_main/renderingOptions.css
- third_party/blink/renderer/devtools/front_end/layers_test_runner/LayersTestRunner.js
- third_party/blink/renderer/devtools/front_end/network/RequestHeadersView.js
- third_party/blink/renderer/devtools/front_end/network/networkConfigView.css
- third_party/blink/renderer/devtools/front_end/network/networkLogView.css
- third_party/blink/renderer/devtools/front_end/object_ui/ObjectPropertiesSection.js
- third_party/blink/renderer/devtools/front_end/object_ui/objectPropertiesSection.css
- third_party/blink/renderer/devtools/front_end/profiler/profilesPanel.css
- third_party/blink/renderer/devtools/front_end/resources/ApplicationCacheItemsView.js
- third_party/blink/renderer/devtools/front_end/security/SecurityPanel.js
- third_party/blink/renderer/devtools/front_end/settings/settingsScreen.css
- third_party/blink/renderer/devtools/front_end/sources/UISourceCodeFrame.js
- third_party/blink/renderer/devtools/front_end/sources/sourcesPanel.css
- third_party/blink/renderer/devtools/front_end/timeline/TimelineHistoryManager.js
- third_party/blink/renderer/devtools/front_end/timeline/historyToolbarButton.css
- third_party/blink/renderer/devtools/front_end/ui/HistoryInput.js
- third_party/blink/renderer/devtools/front_end/ui/Icon.js
- third_party/blink/renderer/devtools/front_end/ui/ListWidget.js
- third_party/blink/renderer/devtools/front_end/ui/SearchableView.js
- third_party/blink/renderer/devtools/front_end/ui/SoftDropDown.js
- third_party/blink/renderer/devtools/front_end/ui/SplitWidget.js
- third_party/blink/renderer/devtools/front_end/ui/TabbedPane.js
- third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
- third_party/blink/renderer/devtools/front_end/ui/Tooltip.js
- third_party/blink/renderer/devtools/front_end/ui/UIUtils.js
- third_party/blink/renderer/devtools/front_end/ui/View.js
- third_party/blink/renderer/devtools/front_end/ui/Widget.js
- third_party/blink/renderer/devtools/front_end/ui/filter.css
- third_party/blink/renderer/devtools/front_end/ui/inspectorCommon.css
- third_party/blink/renderer/devtools/front_end/ui/radioButton.css
- third_party/blink/renderer/devtools/front_end/ui/softDropDownButton.css
- third_party/blink/web_tests/http/tests/devtools/components/dom-extension-expected.txt
- third_party/blink/web_tests/http/tests/devtools/components/dom-extension.js
- third_party/blink/web_tests/http/tests/devtools/elements/styles-1/color-swatch.js
- third_party/blink/web_tests/http/tests/devtools/extensions/extensions-panel.js
- third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/failed-request-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/interstitial-sidebar-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/main-origin-assigned-despite-request-missing-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
- third_party/blink/web_tests/http/tests/devtools/security/security-unknown-resource-expected.txt
-
Revert "Reland "[NTP] Cap search suggestion impressions""
Changed by Kentaro Hara - harakenohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:17:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ae7ac0aaa631435d6e8cb4fc6e049b045c3a2a61 Comments
Revert "Reland "[NTP] Cap search suggestion impressions"" This reverts commit 5d52425f8fe923f16feb6a9759baf0a5b20e758d. Reason for revert: Broke Linux MSan tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/14510 Original change's description: > Reland "[NTP] Cap search suggestion impressions" > > This is a reland of 41e54be1d923353f72490f19a15e73eb09248a38 > > One of the checks is converting the times from ms->s. In practice > seconds is plenty precise but in the test 800ms ended up being 0, > so increase it to 1000ms (similar to ImpressionCountResetsAfterTimeout > which was not flaky). > > Original change's description: > > [NTP] Cap search suggestion impressions > > > > The parameters for capping suggestions impressions are provided as part > > of the update proto. Read and update the local pref on each fetch. Use > > these prefs to determine if the impression cap has been reach or if > > fetching is frozen due to an empty response. > > > > Bug: 904565 > > Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1395188 > > Commit-Queue: Kyle Milka <kmilka@chromium.org> > > Reviewed-by: Kristi Park <kristipark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#624994} > > Bug: 904565 > Change-Id: I424cb51d2a9c1738c0e5168f58ef52b73ed4b223 > Reviewed-on: https://chromium-review.googlesource.com/c/1431472 > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625437} TBR=kristipark@chromium.org,kmilka@chromium.org Change-Id: Ic784efb02c206edd40a878aacae3852e34f6176a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904565 Reviewed-on: https://chromium-review.googlesource.com/c/1433342 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#625512}
Changed files
- chrome/browser/search/local_ntp_source.cc
- chrome/browser/search/search_suggest/search_suggest_data.cc
- chrome/browser/search/search_suggest/search_suggest_data.h
- chrome/browser/search/search_suggest/search_suggest_loader.h
- chrome/browser/search/search_suggest/search_suggest_loader_impl.cc
- chrome/browser/search/search_suggest/search_suggest_loader_impl_unittest.cc
- chrome/browser/search/search_suggest/search_suggest_service.cc
- chrome/browser/search/search_suggest/search_suggest_service.h
- chrome/browser/search/search_suggest/search_suggest_service_unittest.cc
- chrome/common/pref_names.cc
- chrome/common/pref_names.h
-
TestingProfile: Fix CreateGuestProfile and IsSystemProfile.
Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:14:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6ef1bc6fc58fb9c8e982f49c5a2e0f9508034735 Comments
TestingProfile: Fix CreateGuestProfile and IsSystemProfile. Make those profile properties exactly the same as in production code. See go/chromium-profile-types. This change unblocks unit tests in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1415054 Bug: 277296 Change-Id: I00a7e673b6cd751fad7744b9199919239ba376d9 Reviewed-on: https://chromium-review.googlesource.com/c/1429314 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625511}
Changed files
- chrome/test/base/testing_profile.cc
- chrome/test/base/testing_profile_manager.cc
-
Revert "Use focus ring for views button on all platforms"
Changed by Timothy Loh - timlohohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:12:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2658fa5e7573b9ad6982bafd5c8872511be7ed05 Comments
Revert "Use focus ring for views button on all platforms" This reverts commit f1e1cf79ce1aa12db141ed6f0060fc2db4322bb7. Reason for revert: Appears to be causing lots of failures on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10433 Original change's description: > Use focus ring for views button on all platforms > > On platforms other than Mac, ink drop highlight was used to indicate > focus. This has some shortcomings such as possible low contrast, > inconsistency across platforms or even across other UI components. > This CL changes views button to use focus ring for keyboard focus > on all platforms. > > BUG=864642,924232 > > Change-Id: I31b3f2aa78259e6ae365bfde6687b92314e233e9 > Reviewed-on: https://chromium-review.googlesource.com/c/1429239 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Wei Li <weili@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625459} TBR=sky@chromium.org,weili@chromium.org Change-Id: I7b288d364f768f225e803d9a2f50845ed7ab976e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864642, 924232 Reviewed-on: https://chromium-review.googlesource.com/c/1433383 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625510}
Changed files
- chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
- ui/views/controls/button/button.cc
- ui/views/style/platform_style.cc
- ui/views/style/platform_style.h
- ui/views/style/platform_style_mac.mm
-
Revert "Remove explict focus ring install for button subclasses"
Changed by Timothy Loh - timlohohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 05:11:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c645dafdab2505f4955a545a76bf5f5543726c7e Comments
Revert "Remove explict focus ring install for button subclasses" This reverts commit f4a56fe8033e92669a8e2fb2855c01a3a003259f. Reason for revert: Appears to be causing lots of failures on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10433 Original change's description: > Remove explict focus ring install for button subclasses > > Since views button installs focus ring by deafult to show on keyboard > focus, this CL refactors all its subclasses to remove explicit > installation of focus ring. Only subclasses that need to override to > remove focus ring installation need to call > SetInstallFocusRingOnFocus(false) explicitly. > > BUG=924232 > > Change-Id: Ia5bfce1fca6aaca16ae7e39106737de976e191fc > Reviewed-on: https://chromium-review.googlesource.com/c/1432252 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Wei Li <weili@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625464} TBR=sky@chromium.org,weili@chromium.org Change-Id: I9d46f13e5c95190108ce19c09d1a170c978b6d8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924232 Reviewed-on: https://chromium-review.googlesource.com/c/1433382 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625509}
Changed files
- ash/shelf/login_shelf_view.cc
- ash/system/tray/tray_background_view.cc
- chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc
- chrome/browser/ui/views/overlay/back_to_tab_image_button.cc
- chrome/browser/ui/views/overlay/close_image_button.cc
- chrome/browser/ui/views/overlay/overlay_window_views.cc
- chrome/browser/ui/views/overlay/playback_image_button.cc
- chrome/browser/ui/views/overlay/resize_handle_button.cc
- chrome/browser/ui/views/overlay/skip_ad_label_button.cc
- chrome/browser/ui/views/passwords/password_pending_view.cc
- chrome/browser/ui/views/tabs/new_tab_button.cc
- chrome/browser/ui/views/tabs/tab_close_button.cc
- ui/views/controls/button/checkbox.cc
- ui/views/controls/button/md_text_button.cc
-
Migrate Files app from i18n-content and i18n-values to $i18n{}.
Changed by Sam McNally - sammcohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:59:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d84f3314b6f43055efdcd156ec5e6cffd0146af8 Comments
Migrate Files app from i18n-content and i18n-values to $i18n{}. Move setting of WebUI load-time data (language, textdirection) into the common GetFileManagerStrings() since those are used at serving time. Remove uses of i18nTemplate.process() from the Files app since these are no longer necessary. Bug: 923206 Change-Id: I977bece21cec3d2f777c08833b9376f25b3979a7 Reviewed-on: https://chromium-review.googlesource.com/c/1426338 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#625508}
Changed files
- chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
- chrome/browser/chromeos/file_manager/file_manager_string_util.cc
- ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
- ui/file_manager/file_manager/foreground/elements/files_quick_view.html
- ui/file_manager/file_manager/foreground/js/file_manager.js
- ui/file_manager/file_manager/foreground/js/main_scripts.js
- ui/file_manager/file_manager/foreground/js/quick_view_controller.js
- ui/file_manager/file_manager/foreground/js/ui/BUILD.gn
- ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
- ui/file_manager/file_manager/main.html
-
Tests: Do not turn a normal profile into an incognito profile dynamically.
Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:55:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8e9014770695ac1949fa11429e81f4ee61106492 Comments
Tests: Do not turn a normal profile into an incognito profile dynamically. Use incognito WebContents created for profile()->GetOffTheRecordProfile() which is exactly as in production code. Bug: 277296 Change-Id: I68481cf25cba2eeecd8eef318d08e1f3aa75570d Reviewed-on: https://chromium-review.googlesource.com/c/1424101 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#625507}
Changed files
- chrome/browser/safe_browsing/client_side_detection_host.h
- chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
-
Revert "Remove conditional use of LayerTreeView from RenderWidget."
Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:53:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bef2b64696776bdac2ea14124da97a7e3b2c91da Comments
Revert "Remove conditional use of LayerTreeView from RenderWidget." This reverts commit 2ae8e4805cf3528619e05806e836a78d2c740e0b. Reason for revert: some layout tests started to crash on CHECK(closing_) https://test-results.appspot.com/data/layout_results/Mac10_13_Tests/9201/webkit_layout_tests/layout-test-results/results.html external/wpt/trusted-types/block-string-assignment-to-Window-open.tentative.html external/wpt/url/failure.html Original change's description: > Remove conditional use of LayerTreeView from RenderWidget. > > The LayerTreeView is always present since we always composite > RenderWidgets now (for many years ^_^). > > However, the LayerTreeView *is* removed during shutdown. Most places > will not need to worry about this because OnClose() drops the IPC > channel and most uses of LayerTreeView are in response to other IPCs. > > However a few cases involve calls from Blink which could still be > active in between OnClose() and tearing down the RenderWidget+Blink, > so in these cases early out if |closing_| which represents better > conceptually what we're testing. > > TBR=avi@chromium.org > > Change-Id: Iff9133d9c69b327495f9290afcb471739124018b > Bug: 912193 > Reviewed-on: https://chromium-review.googlesource.com/c/1432132 > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625473} TBR=avi@chromium.org,ajwong@chromium.org,danakj@chromium.org Change-Id: Ide47f156f8f5d2af32f7442bb659599356c3f6c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1433379 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625506}
Changed files
- content/renderer/render_widget.cc
-
Disable flaky test VideoPlayerBrowserTest.NativeMediaKey
Changed by Timothy Loh - timlohohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:46:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9e63550ba4334706ad0f466f14f0593cc819a470 Comments
Disable flaky test VideoPlayerBrowserTest.NativeMediaKey https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=VideoPlayerBrowserTest.NativeMediaKey https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=single_process_mash_browser_tests&tests=VideoPlayerBrowserTest.NativeMediaKey TBR=beccahughes,fukino Bug: 921418 Change-Id: Ia81a955b1ac41ff4a2c49514bad8ae6be59f0ec8 Reviewed-on: https://chromium-review.googlesource.com/c/1433378 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625505}
Changed files
- chrome/browser/chromeos/file_manager/video_player_browsertest.cc
-
Premount preconfigured shares in SmbService
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Thursday, 24-Jan-19 04:46:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bd9852872cd2eb7d74a4f7fb97c91fbbb86a5663 Comments
Premount preconfigured shares in SmbService - This CL activates preconfigured shares to be premounted. - Premount is dependent on host discovery to be done, similar to Remount. Bug: chromium:878502 Test: unit tests, end to end Change-Id: Iac18e522f124086047e0ffdcd4b7a5d66c72b6cd Reviewed-on: https://chromium-review.googlesource.com/c/1407662 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#625504}
Changed files
- chrome/browser/chromeos/smb_client/smb_service.cc
- chrome/browser/chromeos/smb_client/smb_service.h
-
Roll src/third_party/glslang/src/ 0ac199df3..493096468 (73 commits)
Changed by Jamie Madill - jmadillohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:44:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2df361c88eb985f687df5d2a9b92ba9a5ebb4ede Comments
Roll src/third_party/glslang/src/ 0ac199df3..493096468 (73 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0ac199df3268..493096468316 $ git log 0ac199df3..493096468 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 sparmar Add extension checks for NV block member builtins 2019-01-23 jmadill Suppress inconsistent override warning in GN. 2019-01-22 brooke.hodgman HLSL: Protect against some crashes 2019-01-20 jbolz More precisely check for the qualifiers that enable the vulkan memory model for buffer references. 2019-01-18 jmadill Fix a few GN build issues. 2019-01-16 dneto HLSL: Avoid leaking a shadow sampler struct 2019-01-16 dneto Avoid leaking name for counter buffer 2019-01-16 cepheus HLSL: Fix #1655; use "" for nullptr file names. Needs test cases. 2019-01-16 cepheus Build: fix warnings. Fixes #1653. 2019-01-14 rex.xu Fix xfb_stride incorrectness(#1654) 2019-01-11 cepheus Bump revision. 2019-01-09 dneto Update SPIRV-Tools known good: relax Uconvert check 2018-12-11 cepheus Infrastructure: Generalize and broaden per-variable extension checking. 2019-01-08 dneto Parenthesize to avoid GCC warning 2019-01-07 pdaniell Don't output duplicate TypeAccelerationStructureNV declarations 2019-01-06 jbolz GL_EXT_buffer_reference 2019-01-07 cepheus SPV: Move to the latest header. 2019-01-07 dj2 Make sure source strings are terminated (#1641) 2019-01-03 dneto Mark spv.int16.amd.frag.out as failing validation 2019-01-03 gleese Work around a CMake cross-compilation issue 2018-12-06 greg Create separate OpSource for each included file 2018-12-18 rverschelde CMake: Fix linking pthread of CMake < 3.1 2018-12-17 alanbaker Move memory model scope tests to Vulkan 1.1 batch 2018-12-17 cepheus Build: Make calling argument types match declared parameter types. 2018-11-28 greg Add passes to legalization to preserve source line info when generated. 2018-12-14 jbolz Fix bug where shaderRecordNV buffers were using StorageBuffer storage class 2018-12-14 cepheus Licensing. Fixes #958. Add licenes file and update copyrights. 2018-12-13 cepheus Build: Reduce warnings. 2018-12-13 cepheus GLSL/SPV: XFB: No streams on types, but support them on built-in blocks. 2018-12-11 jbolz Update to newest SPIRV-Tools. It checks the Vulkan rule that all resources must have a set and binding decoration, which many tests fail. So add code to set a default value of zero. Also disable PCH for Ninja builds. 2018-12-10 cepheus Infrastructure: Fix .gitattributes typo eof -> eol. Also update README 2018-12-10 rverschelde CMake: Link OSDependent with Threads::Threads 2018-12-10 rverschelde Remove Unix executable permission from text files 2018-12-07 cepheus Manually merge ClemensRognerSD-dx9-sampler and resolve conflicts. 2018-12-07 greg SPV: Fix #1575, fix #1593: Support HLSL #line 2018-12-04 alanbaker Modify testing to only record validation pass/fail 2018-12-03 alexander.galazin Rename GL_KHX_shader_explicit_arithmetic_types to GL_EXT_shader_explicit_arithmetic_types 2018-10-25 apinheiro GlslangToSpv: prevent add XfbStride twice 2018-11-29 cepheus Bump version. 2018-11-28 cepheus SPV: For GLSL only, bitcast OpArrayLength result back to int. 2018-11-27 cepheus SPV: Generate OpArrayLength with no signedness. 2018-11-26 dj2 Add NDK build files 2018-11-27 cepheus Build: Fix build warnings introduced by 2173c6. 2018-11-26 alanbaker Update known good SPIRV tools and headers 2018-11-26 dkoch Implement GL_EXT_fragment_invocation_density 2018-11-26 cepheus SPV: non-functional: update to latest headers. 2018-11-26 neil.henning Add conversion folding when the source is a constant. 2018-11-21 cepheus GLSL: Fix #1591: Require the id in subgroupBroadcast to be constant. 2018-11-16 dneto Update to newer SPIRV-Tools, including VK_EXT_scalar_block_layout 2018-11-16 cepheus Bump minor version. 2018-11-15 cepheus Move to next SPIRV-Tools known good. 2018-11-15 cepheus GLSL: Increase supported sizes of XBF strides and offsets. 2018-11-15 cepheus Bump revision. 2018-11-15 cepheus Update to latest SPIR-V Tools. 2018-11-15 t.jung [HLSL/Spir-V] fix for incorrect spir-v on int dot(int, int) 2018-11-14 jbolz Implement GL_EXT_scalar_block_layout 2018-11-14 t.jung HLSL: fix invalid spir-v vector * scalar for float1 2018-11-14 t.jung HLSL: implemented c register handling 2018-11-13 t.jung Updated type conversion rules for HLSL frontend 2018-11-13 dsinclair Review feedback 2018-11-12 dneto PCH filename depends on current binary dir 2018-11-12 dsinclair Handle potentially uninitialized result 2018-11-12 rex.xu Fix parser issue: redeclare gl_FragStencilRefARB is not supported 2018-10-23 apinheiro ParseHelper: assign global XfbBuffer to a block missing it 2018-11-08 greg Add DeadBranchElim before MergeReturn in legalization. 2018-11-07 cepheus Fix #1563: Corrupt token when an object macro miscalls a function macro 2018-11-07 cepheus PP: More clearly distinguish funtion-like and object-like macros 2018-11-07 jbolz Rename PCH macro to glslang_pch (to avoid name collision) and update to latest spirv-tools 2018-11-06 cepheus Tests: Add test for ways of calling no-argument macro with (). 2018-10-29 grigoryj Add names for composite constants in SPIR-V 2018-10-31 jbolz Use precompiled headers for some glslang projects 2018-10-22 alele Multiple features and misc fixes for final raytracing non experimental version. 2018-10-26 apinheiro ParseHelper: assign xfb_offset for struct members too Created with: roll-dep src/third_party/glslang/src Tbr: geofflang@chromium.org Bug: angleproject:3088 Change-Id: Idb622a1824cec6c6d470b86d795f6060754240bb Reviewed-on: https://chromium-review.googlesource.com/c/1433135 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#625503}
Changed files
- DEPS
-
[Files app] Refactor PathUtil unittest
Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:44:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 292bca531077f816a7759cf4f9f55ca62c84c756 Comments
[Files app] Refactor PathUtil unittest GetDefaultDownloadDirectory() can return value from the MyFiles/Downloads mount point, so if a test mounts it can interfere with other tests. Refactor the test to have a common profile for most of the tests and unmount MyFiles/Downloads. No change in behaviour for users. Change-Id: Idd6c0c461687feb7cfb12adbff7f5a960f03be82 Reviewed-on: https://chromium-review.googlesource.com/c/1433373 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#625502}
Changed files
- chrome/browser/chromeos/file_manager/path_util_unittest.cc
-
Re-implement CrOS merge session throttle in the network service.
Changed by Chris Mumford - cmumfordohnoyoudont@google.com Changed at Thursday, 24-Jan-19 04:43:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4e6965956ec5ecbfdace5eb4989609f4887c632c Comments
Re-implement CrOS merge session throttle in the network service. This change re-implements the resource load throttle that waits for the Chrome OS merge session to complete (or timeout) before allowing resource loads. This implementation is compatible with the network service. Previously this was implemented by the MergeSessionResourceThrottle class, but is now implemented by MergeSessionLoaderThrottle. Bug: 897986 Change-Id: I0a4d2e1961504bd1a979a1d964d62f9ec17b8b33 Reviewed-on: https://chromium-review.googlesource.com/c/1318412 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625501}
Changed files
- chrome/browser/chrome_content_browser_client.cc
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/login/signin/merge_session_navigation_throttle_unittest.cc
- chrome/browser/chromeos/login/signin/merge_session_resource_throttle.cc
- chrome/browser/chromeos/login/signin/merge_session_resource_throttle.h
- chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h
- chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc
- chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.h
- chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
- chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
- chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
- chrome/browser/profiles/renderer_updater.cc
- chrome/browser/profiles/renderer_updater.h
- chrome/common/chrome_switches.cc
- chrome/common/chrome_switches.h
- chrome/common/renderer_configuration.mojom
- chrome/renderer/BUILD.gn
- chrome/renderer/chrome_content_renderer_client.cc
- chrome/renderer/chrome_content_renderer_client.h
- chrome/renderer/chrome_render_thread_observer.cc
- chrome/renderer/chrome_render_thread_observer.h
- chrome/renderer/chromeos_delayed_callback_group.cc
- chrome/renderer/chromeos_delayed_callback_group.h
- chrome/renderer/chromeos_delayed_callback_group_unittest.cc
- chrome/renderer/chromeos_merge_session_loader_throttle.cc
- chrome/renderer/chromeos_merge_session_loader_throttle.h
- chrome/renderer/url_loader_throttle_provider_impl.cc
- chrome/test/BUILD.gn
- chrome/test/data/extensions/api_test/merge_session/background.js
- testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
-
[NTP] Add dark mode support for voice search
Changed by Kristi Park - kristiparkohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:40:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0e33dd50d487f137f791006705234ec879d3ed1f Comments
[NTP] Add dark mode support for voice search Screenshots: https://screenshot.googleplex.com/z6J7kQ1cYHL.png https://screenshot.googleplex.com/F66Gz7Y1nMm.png https://screenshot.googleplex.com/5YkSLd94b6H.png https://screenshot.googleplex.com/BwFN2Pt82EJ.png Bug: 919961 Change-Id: I1375c0ca7da12918e759e5e9d88cfbe4749e8923 Reviewed-on: https://chromium-review.googlesource.com/c/1432877 Reviewed-by: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#625500}
Changed files
- chrome/browser/resources/local_ntp/voice.css
-
Roll src/third_party/chromite cec40a962e60..947f4685c628 (24 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 04:38:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3796e935dc18cb60f047e2e756ff4b000e065ec3 Comments
Roll src/third_party/chromite cec40a962e60..947f4685c628 (24 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/cec40a962e60..947f4685c628 git log cec40a962e60..947f4685c628 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 tbegin@google.com sludge: add experimental builders for sludge VM 2019-01-23 ahassani@chromium.org paygen: improve GenrateStatefulPayload's implementation 2019-01-23 ahassani@chromium.org cros_generate_stateful_update_payload: Move to paygen 2019-01-23 cjmcdonald@chromium.org RunCommand: Set environment variable LC_MESSAGES=C by default 2019-01-22 dgarrett@google.com workspace_stages: Add unittests for new stage classes. 2019-01-22 dgarrett@google.com workspace_builders: Add unittests for new builder classes. 2019-01-22 manojgupta@google.com chromeos_config: Change kevin64 builders for TestSimpleChromeWorkFlow. 2019-01-21 paulhsia@google.com moblab-generic-vm: mark as experimental 2019-01-20 mikenichols@chromium.org Remove lakitu from experimental 2019-01-20 nmasti@google.com group_baseline: set uid and gid to be identical 2019-01-19 dburger@chromium.org Remove deprecated KAYLE from site params 2019-01-19 saklein@chromium.org build api: Simplify BuildTarget proto 2019-01-19 dburger@chromium.org Remove weave from SiteParams 2019-01-19 dhanyaganesh@chromium.org TriageRelevantChanges: Use buildstore instead of cidb handle 2019-01-19 saklein@chromium.org cros_build_lib: sudo preserve-env option 2019-01-19 dhanyaganesh@chromium.org BuildStore: Redirect UpdateMetadata function through BuildStore. 2019-01-19 dburger@chromium.org Remove GOB_HOST from config_lib.GetSiteParams() 2019-01-19 evanhernandez@chromium.org cros branch: Completely repair manifest. 2019-01-19 evanhernandez@chromium.org repo_manifest: _ManifestElement supports del. 2019-01-18 chrome-bot@chromium.org Update config settings by config-updater. 2019-01-18 manojgupta@google.com chromeos_config: Add amd64-generic-msan-fuzzer builder. 2019-01-18 lamontjones@chromium.org portage_util: Add more information to log on failure of chromeos-version.sh 2019-01-18 zhihongyu@chromium.org Add mistral usergroup_baseline 2019-01-18 gbiv@google.com SimpleChrome: forcibly turn lld off in external builds Created with: gclient setdep -r src/third_party/chromite@947f4685c628 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibb63b893e6b8d927cd8695bc43977178813d2554 Reviewed-on: https://chromium-review.googlesource.com/c/1433012 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625499}
Changed files
- DEPS
-
Suport of window move for picture-in-picture windows
Changed by Jun Mukai - mukaiohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:36:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 85fad3815b310752dfe1fbc54944b3c333dc8cec Comments
Suport of window move for picture-in-picture windows This CL adds a new class ClientSideWindowMoveHandler which observes the mouse/touch events and initiates PerformWindowMove in the window tree client; this is the case for both browser windows and picture-in-picture windows. Rather than implementing similar logic, the new class can handle them uniformly. This also offloads some logic of gesture-transferring and release capture in DesktopWindowTreeHostMus to share the logic. Still there's a TODO for resizing. That needs to be done in another CL. Bug: 921156 Test: manually Change-Id: I8556f1b1a03b26e8b5e63a2a35a199a70ec181b9 Reviewed-on: https://chromium-review.googlesource.com/c/1423341 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625498}
Changed files
- chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
- chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
- ui/aura/BUILD.gn
- ui/aura/mus/client_side_window_move_handler.cc
- ui/aura/mus/client_side_window_move_handler.h
- ui/aura/mus/window_tree_client.cc
- ui/aura/mus/window_tree_client.h
- ui/aura/mus/window_tree_client_unittest.cc
- ui/aura/mus/window_tree_host_mus.cc
- ui/aura/mus/window_tree_host_mus.h
- ui/aura/mus/window_tree_host_mus_delegate.h
- ui/aura/window_event_dispatcher_unittest.cc
- ui/views/mus/desktop_window_tree_host_mus.cc
-
Revert "Add tentative WPT tests for stale while revalidate handling."
Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com Changed at Thursday, 24-Jan-19 04:34:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 875e732fa22af1e2c1a8019e1cd235b83131f168 Comments
Revert "Add tentative WPT tests for stale while revalidate handling." This reverts commit 05cdb4d1d9cdaa2df3d91cd9dc150eda903fe35b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625228 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDVjZGI0ZDFkOWNkYWEyZGYzZDkxY2Q5ZGMxNTBlZGE5MDNmZTM1Ygw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/77482 Sample Failed Step: webkit_layout_tests Sample Flaky Test: virtual/outofblink-cors-ns/external/wpt/fetch/stale-while-revalidate/stale-script.tentative.html Original change's description: > Add tentative WPT tests for stale while revalidate handling. > > Add test to ensure that handling the fetch doesn't trigger stale > while revalidate loading. > > Add test to ensure that scripts loaded trigger a stale while revalidate > cache hit and resource timing entries are correct. > > The PR for the spec changes is here: > https://github.com/whatwg/fetch/pull/853 > > BUG=348877 > > Change-Id: Ib07b98d0d2595b6b99857161f830343bf7516518 > Reviewed-on: https://chromium-review.googlesource.com/c/1383297 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625228} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=348877 Change-Id: Ie11ef55a64fcf3e39781666b65a47bbd157f04a2 Reviewed-on: https://chromium-review.googlesource.com/c/1432937 Cr-Commit-Position: refs/heads/master@{#625497}
Changed files
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/fetch.tentative.html
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/stale-image.py
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/stale-image.tentative.html
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/stale-script.py
- third_party/blink/web_tests/external/wpt/fetch/stale-while-revalidate/stale-script.tentative.html
-
Remove SecurityState on IO thread instead of posting back to UI thread.
Changed by Aaron Colwell - acolwellohnoyoudont@google.com Changed at Thursday, 24-Jan-19 04:31:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 529eb6e986ed61abeac60f1d9f53f1cb006855cb Comments
Remove SecurityState on IO thread instead of posting back to UI thread. This change attempts to remove the extra task posted to the UI thread to remove the SecurityState object. The original crashes this extra task was intended to fix did not pan out and were fixed another way. This change tries to see if the simpler case of removing on the IO thread can be used. - Removes SecurityState from pending_remove_state_ in IO thread task. - CanAccessDataForOrigin() no longer preserves pre-Remove() state on UI thread. Always returns false after Remove() returns. - CanAccessDataForOrigin() preserves pre-Remove() state on IO thread until the task that Remove() posted runs. Bug: 915203, 923053 Change-Id: I5eef23ad3003a0dc2b8419aca0be29fc9f9202bf Reviewed-on: https://chromium-review.googlesource.com/c/1432572 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#625496}
Changed files
- content/browser/child_process_security_policy_impl.cc
- content/browser/child_process_security_policy_impl.h
- content/browser/child_process_security_policy_unittest.cc
-
Tests: Do not turn a normal profile into an incognito profile dynamically.
Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:29:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 58084ae9f2eb5f7d44c3fa9cf90d4766d1865465 Comments
Tests: Do not turn a normal profile into an incognito profile dynamically. Use incognito WebContents created for profile()->GetOffTheRecordProfile() which is exactly as in production code. Bug: 277296 Change-Id: Iee78c3ae9635195301f384d92454680ae61b0021 Reviewed-on: https://chromium-review.googlesource.com/c/1424627 Reviewed-by: Nathan Parker <nparker@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625495}
Changed files
- chrome/browser/safe_browsing/safe_browsing_blocking_page.h
- chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
- chrome/browser/safe_browsing/safe_browsing_service.h
-
Fix a typo in chromeos_strings.grdp
Changed by Hadi Moshayedi - moshayediohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:28:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 681f2c61e8941421c786e49497d9276c14e80388 Comments
Fix a typo in chromeos_strings.grdp Bug: NONE Change-Id: Ia2ffcc1241a76c903591856d03e38451feec2558 Reviewed-on: https://chromium-review.googlesource.com/c/1424698 Reviewed-by: Jay Civelli <jcivelli@chromium.org> Commit-Queue: Hadi Moshayedi <moshayedi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625494}
Changed files
- chrome/app/chromeos_strings.grdp
-
Extensions: Implement "content_security_policy.isolated_world" manifest key.
Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:28:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 11c67e5998f4dbb2d04b3e149c83e3f585846f2a Comments
Extensions: Implement "content_security_policy.isolated_world" manifest key. This CL implements the "content_security_policy.isolated_world" manifest key. In a later CL, the parsed CSP will be plumbed to the renderer. BUG=914224 Change-Id: Ia13904d760c40b20a3309c521d44666c2dfbc0c7 Reviewed-on: https://chromium-review.googlesource.com/c/1406233 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625493}
Changed files
- chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc
- chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
- extensions/common/csp_validator.cc
- extensions/common/csp_validator.h
- extensions/common/csp_validator_unittest.cc
- extensions/common/manifest_constants.cc
- extensions/common/manifest_constants.h
- extensions/common/manifest_handlers/csp_info.cc
- extensions/common/manifest_handlers/csp_info.h
- extensions/common/manifest_handlers/csp_info_unittest.cc
- extensions/test/data/manifest_tests/isolated_world_csp_dictionary_default_v2.json
- extensions/test/data/manifest_tests/isolated_world_csp_dictionary_default_v3.json
- extensions/test/data/manifest_tests/isolated_world_csp_insecure_src.json
- extensions/test/data/manifest_tests/isolated_world_csp_invalid_type.json
- extensions/test/data/manifest_tests/isolated_world_csp_missing_src.json
- extensions/test/data/manifest_tests/isolated_world_csp_no_dictionary_default_v2.json
- extensions/test/data/manifest_tests/isolated_world_csp_no_dictionary_default_v3.json
- extensions/test/data/manifest_tests/isolated_world_csp_valid.json
-
Updating trunk VERSION from 3682.0 to 3683.0
Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:09:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 74d5ea8ee88452765aba220083439b4bfcaeeacd Comments
Updating trunk VERSION from 3682.0 to 3683.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ia5829f2fd735a16bcebf7b0d85fcccb1a07b546f Reviewed-on: https://chromium-review.googlesource.com/c/1433354 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#625492}
Changed files
- chrome/VERSION
-
Image annotation: added annotation methods to the page annotator.
Changed by Michael Martis - martisohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 04:07:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b39a531368bd6c81b239a05abeea8e0d6642a4c3 Comments
Image annotation: added annotation methods to the page annotator. This CL implements the client logic needed to interact with the image annotation service. Specifically, this entails: - Accepting a ptr to the main service interface, and - Providing a "proxy" AnnotateImage method that sends page images (i.e. by accepting a node ID) for to the service for annotation. Bug: crbug.com/916363 Change-Id: I6d65c4223c001b06579940161d889962ba19aa43 Reviewed-on: https://chromium-review.googlesource.com/c/1424625 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Charles . <charleszhao@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#625491}
Changed files
- components/page_image_annotation/DEPS
- components/page_image_annotation/content/renderer/BUILD.gn
- components/page_image_annotation/content/renderer/content_page_annotator_driver.cc
- components/page_image_annotation/core/page_annotator.cc
- components/page_image_annotation/core/page_annotator.h
- components/page_image_annotation/core/page_annotator_unittest.cc
-
Android: Fix a bug of UI going reverse
Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 03:59:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 162164e1d255563eab61ee8b8d5874c6bfaf3a38 Comments
Android: Fix a bug of UI going reverse SideSlideLayout handles both back/forward directional UI by taking an absolute value of dragging offset. It should have ignored the negative offset against the intended direction, but the absolute value was being taken for the offset for the intended direction, therefore caused the reported bug. This CL rectifies it by discarding the offset in the reverse direction. Bug: 923927 Change-Id: I26977276940374d77ced33f30c7d2c559b00ea25 Reviewed-on: https://chromium-review.googlesource.com/c/1429361 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#625490}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/gesturenav/SideSlideLayout.java
-
Flag off PIP rounded corners by default.
Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com Changed at Thursday, 24-Jan-19 03:56:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 493df9a93b888c7fab9b9310df507d96d8e02eb5 Comments
Flag off PIP rounded corners by default. Bug: 923812 Test: Rounded corners no longer used for PIP windows. Change-Id: Id2a09865d05ed1f51fb5a1ee6645db0bcf59f4e4 Reviewed-on: https://chromium-review.googlesource.com/c/1424107 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#625489}
Changed files
- ash/public/cpp/ash_features.cc
-
Add Premount to SmbService
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Thursday, 24-Jan-19 03:45:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e0b6bab06364507f79f4d0c544bf89dd57d22d65 Comments
Add Premount to SmbService - Adds Premount method in SmbService in anticipation of SmbProviderClient::Premount's implementation. - Adds reponse callback method to connect MountOptions of the preconfigured share to the FileSystem. Bug: chromium:878502 Test: compiles Change-Id: I0c9af981d0cd1f2fd57c5a5ecfec4feef6c127de Reviewed-on: https://chromium-review.googlesource.com/c/1407660 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#625488}
Changed files
- chrome/browser/chromeos/smb_client/smb_service.cc
- chrome/browser/chromeos/smb_client/smb_service.h
-
Move NoTouchActivity to touchless package
Changed by Mehran Mahmoudi - mahmoudiohnoyoudont@google.com Changed at Thursday, 24-Jan-19 03:43:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0ebabc86af52b18004b8feb1639ac2d9b07c8c31 Comments
Move NoTouchActivity to touchless package Move the NoTouchActivity to the newly created touchless sub-package in order to declutter and tidy up the browser package. Bug: 922047 Change-Id: Ib7d9df3c89295e9e675b35a05e3613b390fbae5e Reviewed-on: https://chromium-review.googlesource.com/c/1432473 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@google.com> Cr-Commit-Position: refs/heads/master@{#625487}
Changed files
- chrome/android/java/AndroidManifest.xml
- chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
- chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
- chrome/android/java/src/org/chromium/chrome/browser/touchless/NoTouchActivity.java
- chrome/android/java_sources.gni
- chrome/android/javatests/src/org/chromium/chrome/browser/touchless/NoTouchActivityTest.java
-
s13n: Replace use of AccountTrackerService in advanced_protection_status_manager.cc/h
Changed by Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com Changed at Thursday, 24-Jan-19 03:37:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 923016306b416e430bf8eb25a6a36c703e836e0b Comments
s13n: Replace use of AccountTrackerService in advanced_protection_status_manager.cc/h As a step to use IdentityManager, this CL makes AdvancedProtectionStatusManager implement IdentityManager::Observer instead of AccountTrackerService::Observer. Besides, AccountTrackerService::SetIsAdvancedProtectionAccount is also replaced by AccountMutator::UpdateAccountInfo Bug: 922761, 922762 Change-Id: Ia223d792f745e4d0057eb1426389645ec9083aee Reviewed-on: https://chromium-review.googlesource.com/c/1426503 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625486}
Changed files
- chrome/browser/safe_browsing/advanced_protection_status_manager.cc
- chrome/browser/safe_browsing/advanced_protection_status_manager.h
-
[Android Webapp] Remove unneeded SameActivityWebappSplashDelegate#mInitializedLayout 7/9
Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 03:33:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 660cf035fc75e55a6e8fe6b2a9ac104581ee9cab Comments
[Android Webapp] Remove unneeded SameActivityWebappSplashDelegate#mInitializedLayout 7/9 BUG=918459 Change-Id: I6d374062b3ffe3d8aaed825531fd121b731bbbb6 Reviewed-on: https://chromium-review.googlesource.com/c/1425560 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#625485}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/webapps/SameActivityWebappSplashDelegate.java
-
cros: Clean up filenames in //ash/system/date
Changed by James Cook - jamescookohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:35:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3f2f7a96e751f558cc8dd812fd6b9ee37204804d Comments
cros: Clean up filenames in //ash/system/date * TimeView only displays the time, so move into //ash/system/time * Move ClockObserver to //ash/system/model to be next to clock_model.cc * Make the filenames match the class names. * Fix some includes. Bug: 924744 Test: ash_unittests Change-Id: I9dbcc157146c8fff019da7c169f00427f32f76ae Reviewed-on: https://chromium-review.googlesource.com/c/1432612 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#625484}
Changed files
- ash/BUILD.gn
- ash/system/model/clock_model.cc
- ash/system/model/clock_observer.h
- ash/system/power/tray_power.cc
- ash/system/time/time_tray_item_view.cc
- ash/system/time/time_tray_item_view.h
- ash/system/time/time_view.cc
- ash/system/time/time_view.h
- ash/system/time/time_view_unittest.cc
- ash/system/unified/unified_system_info_view.cc
- ash/system/unified/unified_system_tray.cc
- ash/system/unified/unified_system_tray_test_api.cc
-
[Feed] Switch to using onClearAllWithRefresh.
Changed by Sky Malice - skymohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:28:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 881f038dd7b969c5ff9fa11f4b946de2141a75e5 Comments
[Feed] Switch to using onClearAllWithRefresh. The Feed has requested that when we wipe out suggestions and then fetch new articles, instead of sequentially calling onClearAll and triggerRefresh, instead we just call onClearAllWithRefresh. This will let them handle these operations more gracefully and avoid races. The host classes were not initially structured to facilitate this. The scheduler, which must decide if we want to trigger a refresh or not, is not the same host that has access to the AppLifecycleListener which is what has the onClearAllWithRefresh method. This change plums a boolean back up from the scheduler to the FeedAppLifecycle so that we can decide if onClearAllWithRefresh or onClearAll should be called after an event occurs that wipes out all articles. Bug: 919901, 913874 Change-Id: I7684673a6367ba4aa90390ef98f8da938ac14c71 Reviewed-on: https://chromium-review.googlesource.com/c/1409479 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#625483}
Changed files
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedAppLifecycle.java
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
- chrome/android/javatests/src/org/chromium/chrome/browser/feed/FeedAppLifecycleTest.java
- chrome/browser/android/feed/feed_scheduler_bridge.cc
- chrome/browser/android/feed/feed_scheduler_bridge.h
- components/feed/core/feed_scheduler_host.cc
- components/feed/core/feed_scheduler_host.h
- components/feed/core/feed_scheduler_host_unittest.cc
-
Remove the 100GB drive promotional offer banner from file manager.
Changed by Stuart Langley - slangleyohnoyoudont@google.com Changed at Thursday, 24-Jan-19 02:20:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3f712760fd6fc7a2e52830486ac34a21b4e9ef56 Comments
Remove the 100GB drive promotional offer banner from file manager. The offer is moving to a chrome os offers website, and is no longer needed in the file manager. Bug: 922326 Change-Id: Id2d8077501bf6e1e80d2eb453fa95fc5346dcf3f Reviewed-on: https://chromium-review.googlesource.com/c/1426246 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#625482}
Changed files
- chrome/app/file_manager_strings.grdp
- chrome/browser/chromeos/file_manager/file_manager_string_util.cc
- ui/file_manager/file_manager/foreground/js/ui/banners.js
-
media/gpu/test: Adapt VideoFrameProcessor interface to pass const VideoFrame.
Changed by David Staessens - dstaessensohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:11:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8c12e83427de541b8aece0566c1cb4cbef51fa5d Comments
media/gpu/test: Adapt VideoFrameProcessor interface to pass const VideoFrame. This CL makes sure that a test VideoFrameProcessor can't modify a video frame. TEST=ran new VDA tests on nocturne BUG=879065 Change-Id: I1448c07fd64de8a4d933fc18d0a091b606cc9f56 Reviewed-on: https://chromium-review.googlesource.com/c/1428630 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#625481}
Changed files
- media/gpu/test/generic_dmabuf_video_frame_mapper.cc
- media/gpu/test/generic_dmabuf_video_frame_mapper.h
- media/gpu/test/vaapi_dmabuf_video_frame_mapper.cc
- media/gpu/test/vaapi_dmabuf_video_frame_mapper.h
- media/gpu/test/video_frame_helpers.h
- media/gpu/test/video_frame_mapper.h
- media/gpu/test/video_frame_validator.cc
- media/gpu/test/video_frame_validator.h
-
Make sure to create a WindowState when added to a parent.
Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:08:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c11049d2d9e21b6f055a24bc23905b1a638bdbe2 Comments
Make sure to create a WindowState when added to a parent. Bug: 924305 Test: Covered by unittest Change-Id: I1711ac65735beabd178acfb55212051668becc4d Reviewed-on: https://chromium-review.googlesource.com/c/1430853 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#625480}
Changed files
- ash/wm/window_properties.cc
- ash/wm/window_properties.h
- ash/wm/workspace/workspace_layout_manager.cc
- ash/wm/workspace/workspace_layout_manager_unittest.cc
-
media/gpu/test: Add new VDA test to reset after the first config info.
Changed by David Staessens - dstaessensohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:08:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 61dbf0cfb0c1c6166fc3050edeece52fd9ef9247 Comments
media/gpu/test: Add new VDA test to reset after the first config info. This CL adds a test that triggers a reset operation immediately after the first config info has been encountered in a H.264 stream. TEST=ran new VDA tests on nocturne BUG=905953 Change-Id: I0bb158ea9250ce726bd862707604be6252ea26b5 Reviewed-on: https://chromium-review.googlesource.com/c/1426501 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#625479}
Changed files
- media/gpu/test/video_player/video_decoder_client.cc
- media/gpu/test/video_player/video_decoder_client.h
- media/gpu/test/video_player/video_player.cc
- media/gpu/test/video_player/video_player.h
- media/gpu/video_decode_accelerator_tests.cc
-
Ensure cc::PictureLayer's client is cleared
Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:43:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5a90bca48f73b8d82fdbbce3ad938ffb430c6f36 Comments
Ensure cc::PictureLayer's client is cleared cc::PictureLayer is ref counted, so it can live longer than the client, so for safety, the client should call ClearClient() of the layer when the client is destructed or is no longer the client of the layer. Bug: 913464 Change-Id: Id9093a8fba371e3773dd0ae292a0f855ce4f100a Reviewed-on: https://chromium-review.googlesource.com/c/1427447 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625478}
Changed files
- content/renderer/child_frame_compositing_helper.cc
- content/renderer/child_frame_compositing_helper.h
- third_party/blink/renderer/core/paint/link_highlight_impl.cc
- third_party/blink/renderer/core/paint/link_highlight_impl.h
- third_party/blink/renderer/platform/graphics/compositing/content_layer_client_impl.cc
- third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
- ui/compositor/layer.cc
-
[Extensions] Enable onExtensionActivity if there are listeners
Changed by Kelvin Jiang - kelvinjiangohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:35:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b3dbf220651689808bbf443e7f7a44308d8c835e Comments
[Extensions] Enable onExtensionActivity if there are listeners Enable the broadcasting of onExtensionActivity events if a listener was added from chrome.activityLogPrivate. Previously, this was enabled only for whitelisted extensions. We also block activity logging from the browser itself/webUI (indicated by an empty extension id) as it can lead to an infinite loop of invoking an event listener callback, then logging that invocation as an activity. This quickly causes an OOM. Blocking is only done for the browser/whitelisted extensions for now as chrome.activityLogPrivate is only enabled for them. Bug: 832354 Change-Id: Ic86c8ec28bfbf797d6f2d3605c47ef2d8579234c Reviewed-on: https://chromium-review.googlesource.com/c/1419319 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625477}
Changed files
- chrome/browser/extensions/activity_log/activity_log.cc
- chrome/browser/extensions/activity_log/activity_log.h
- chrome/browser/extensions/activity_log/activity_log_unittest.cc
- chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
- chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
- chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
-
aura: move ownership of LocalSurfaceId to a separate class
Changed by Scott Violet - skyohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:35:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 590c820c3b7b0d312d6d040bbc0f133eae9aa7d8 Comments
aura: move ownership of LocalSurfaceId to a separate class At times WindowPortMus may act as either a parent allocator or a child allocator. Moving allocation to a separate class should make it clearer. BUG=922201,921129 Change-Id: I8853d3f657e1f0872bf06f46f29cf59ea628c91f Reviewed-on: https://chromium-review.googlesource.com/c/1424301 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625476}
Changed files
- content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
- ui/aura/BUILD.gn
- ui/aura/mus/mus_lsi_allocator.cc
- ui/aura/mus/mus_lsi_allocator.h
- ui/aura/mus/window_mus.h
- ui/aura/mus/window_port_mus.cc
- ui/aura/mus/window_port_mus.h
- ui/aura/mus/window_port_mus_unittest.cc
- ui/aura/mus/window_tree_client.cc
- ui/aura/mus/window_tree_client.h
- ui/aura/mus/window_tree_client_unittest.cc
- ui/aura/test/mus/window_port_mus_test_helper.cc
- ui/aura/test/mus/window_port_mus_test_helper.h
- ui/aura/window_unittest.cc
-
Roll src/third_party/skia 114b5af0e8cc..beaae554418b (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 01:34:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ff0f4f06c4a2d7ba223208116595ce9fad1cfe10 Comments
Roll src/third_party/skia 114b5af0e8cc..beaae554418b (1 commits) https://skia.googlesource.com/skia.git/+log/114b5af0e8cc..beaae554418b git log 114b5af0e8cc..beaae554418b --date=short --no-merges --format='%ad %ae %s' 2019-01-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@beaae554418b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I6501759f3e09e9b20bb2dffe61d34c901f83d2e6 Reviewed-on: https://chromium-review.googlesource.com/c/1431835 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625475}
Changed files
- DEPS
-
Switch CQ bot names
Changed by Stephen Martinis - martinissohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:34:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 059963f194d6006fdc26cb1db8b2656c1251c69a Comments
Switch CQ bot names Bug: 888810 Change-Id: I5eefa83167a21db8bf447583deb58b38b2dc13ff Reviewed-on: https://chromium-review.googlesource.com/c/1428720 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#625474}
Changed files
- docs/infra/cq_builders.md
- infra/config/branch/cq.cfg
-
Remove conditional use of LayerTreeView from RenderWidget.
Changed by danakj - danakjohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:32:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2ae8e4805cf3528619e05806e836a78d2c740e0b Comments
Remove conditional use of LayerTreeView from RenderWidget. The LayerTreeView is always present since we always composite RenderWidgets now (for many years ^_^). However, the LayerTreeView *is* removed during shutdown. Most places will not need to worry about this because OnClose() drops the IPC channel and most uses of LayerTreeView are in response to other IPCs. However a few cases involve calls from Blink which could still be active in between OnClose() and tearing down the RenderWidget+Blink, so in these cases early out if |closing_| which represents better conceptually what we're testing. TBR=avi@chromium.org Change-Id: Iff9133d9c69b327495f9290afcb471739124018b Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1432132 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625473}
Changed files
- content/renderer/render_widget.cc
-
RTCQuicTransport & RTCIceTransport - SecureContext
Changed by Seth Hampson - shampsonohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:29:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1a70719973246f3ac5c388a7be2b9a571f2da313 Comments
RTCQuicTransport & RTCIceTransport - SecureContext Updates the RTCQuicTransport and RTCIceTransport idl files to restrict the APIs to secure contexts only. Bug: 874296 Change-Id: Ib669480ea323df8e8856e38ff3f3798afb78c606 Reviewed-on: https://chromium-review.googlesource.com/c/1430432 Commit-Queue: Seth Hampson <shampson@chromium.org> Auto-Submit: Seth Hampson <shampson@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#625472}
Changed files
- third_party/blink/renderer/modules/peerconnection/rtc_ice_transport.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.idl
- third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
-
[s13n] Move ChildAccountService away from using AccountTrackerService
Changed by Julie Jeongeun Kim - jkimohnoyoudont@igalia.com Changed at Thursday, 24-Jan-19 01:27:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 09e01dc238c428894c25104ba00601e2d3863850 Comments
[s13n] Move ChildAccountService away from using AccountTrackerService This CL removes AccountTrackerService from ChildAccountService and uses IdentityManager instead of it. Bug: 922779, 922778 Change-Id: I2ee93fad73d56901bbd3db8b02db044a5ff8ccdd Reviewed-on: https://chromium-review.googlesource.com/c/1429821 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#625471}
Changed files
- chrome/browser/supervised_user/child_accounts/child_account_service.cc
- chrome/browser/supervised_user/child_accounts/child_account_service.h
-
wtf/win: Remove more redundant flags.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:18:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f2d516607181592608dc27199bee2745dcc28c0c Comments
wtf/win: Remove more redundant flags. The defines are already there globally from //build/config/win:runtime_library, the /wd flag from //build/config/compiler:default_warnings. No behavior change. Bug: none Change-Id: Ib24fb4723d5e4070b70c9aeef17e5a785cd134c3 Reviewed-on: https://chromium-review.googlesource.com/c/1429079 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#625470}
Changed files
- third_party/blink/renderer/platform/wtf/BUILD.gn
-
SignedExchange: Remove the Request Method field
Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:18:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a583aac50c48df257ff435da9af8792e227fe884 Comments
SignedExchange: Remove the Request Method field Signed Exchange version b3 doesn't have a request method. Since we have dropped support for b2, we can remove it from our codebase. Bug: 919424 Change-Id: Ia8a522a658b64c0aebc974ad7ea35b45e3298a60 Reviewed-on: https://chromium-review.googlesource.com/c/1429899 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625469}
Changed files
- content/browser/devtools/protocol/network_handler.cc
- content/browser/web_package/mock_signed_exchange_handler.cc
- content/browser/web_package/signed_exchange_envelope.cc
- content/browser/web_package/signed_exchange_envelope.h
- content/browser/web_package/signed_exchange_envelope_unittest.cc
- content/browser/web_package/signed_exchange_handler.cc
- content/browser/web_package/signed_exchange_handler.h
- content/browser/web_package/signed_exchange_handler_unittest.cc
- content/browser/web_package/signed_exchange_loader.cc
- content/browser/web_package/signed_exchange_loader.h
- content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
- third_party/blink/renderer/core/inspector/browser_protocol.pdl
- third_party/blink/renderer/devtools/front_end/network/SignedExchangeInfoView.js
-
Fix icon bounds with new-tab-icon animation
Changed by Peter Boström - pbosohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:17:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 52572713bfe2437e1bac822a2399b695a06f0643 Comments
Fix icon bounds with new-tab-icon animation The initial version of the new animation did not account for the larger icon area, so items inside the tab have shifted with 2dp. Bug: chromium:923179 Change-Id: I55c5994c58dbf25e0d0df9ac2eb4c8688e04a09b Reviewed-on: https://chromium-review.googlesource.com/c/1427467 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#625468}
Changed files
- chrome/browser/ui/views/tabs/tab.cc
-
Network Error Logging: Only generate reports for zero or negative values
Changed by Lily Chen - chlilyohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:16:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fec60d91f03c312e3f890a4073ebcc242500b27e Comments
Network Error Logging: Only generate reports for zero or negative values We generate NEL reports in HttpNetworkTransaction::DoCallback(), with the argument to DoCallback() used as the NEL report's error type. This value sometimes represents a net::Error (negative values and zero), and sometimes representes a byte count (positive values and zero), e.g. the number of bytes read from an HttpNetworkTransaction. We were previously generating NEL reports for all values, leading to extraneous reports generated for positive values that did not match any known error type. This CL moves NEL report generation for successes and failures to DoReadHeadersComplete() and DoReadBodyComplete(), so that we only report on failures from DoCallback(). HTTP errors (4xx or 5xx response codes) are reported from DoReadHeadersComplete(), as well as successes where the body will not be read (e.g. HEAD requests). A flag is set when a NEL report is generated, to avoid generating multiple reports for a single request. In addition, elapsed time is calculated from a time stored at the start of the request, since stream_->GetLoadTimingInfo() doesn't provide the proper timing info at the places where GenerateNetworkErrorLoggingReport() is called. Bug: 919115, 917017 Change-Id: I1d59ca7e80d6f2b14339c2f73533e32610b554c1 Reviewed-on: https://chromium-review.googlesource.com/c/1399444 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#625467}
Changed files
- net/http/http_network_transaction.cc
- net/http/http_network_transaction.h
- net/http/http_network_transaction_unittest.cc
- net/url_request/url_request_test_util.cc
- net/url_request/url_request_unittest.cc
-
[CompositeAfterPaint] Add test for crbug.com/921729
Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:16:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f4111e3d84b912ce7c0c92ebd71a3e42004e4ca8 Comments
[CompositeAfterPaint] Add test for crbug.com/921729 Bug: 921729 Change-Id: I735043cbf629e57abcabe53c01a221650ccc0888 Reviewed-on: https://chromium-review.googlesource.com/c/1432378 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625466}
Changed files
- third_party/blink/web_tests/FlagExpectations/enable-blink-features=CompositeAfterPaint
- third_party/blink/web_tests/paint/invalidation/compositing/composited-layer-move-expected.html
- third_party/blink/web_tests/paint/invalidation/compositing/composited-layer-move-expected.txt
- third_party/blink/web_tests/paint/invalidation/compositing/composited-layer-move.html
-
[Video Capture, Android] Re-enable tests involving accelerated jpeg decoding
Changed by Christian Fremerey - chfremerohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:11:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fecb029e6187fbceb05679b0489968532de9ee28 Comments
[Video Capture, Android] Re-enable tests involving accelerated jpeg decoding Re-enable video capture tests involving accelerated jpeg decoding on Android that used to be flaky. There have been a lot of fixes in the video capture pipeline since these test cases were disabled. The tests pass when running locally. It is worth re-enabling. If they turn out to still produce flakiness, we can disable again and use the produced logs to investigate. Bug: 709039 Change-Id: Ib6c8631a2cc178b1c767fb674cae4e52990f4e87 Reviewed-on: https://chromium-review.googlesource.com/c/1422462 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625465}
Changed files
- content/browser/renderer_host/media/video_capture_browsertest.cc
-
Remove explict focus ring install for button subclasses
Changed by Wei Li - weiliohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:10:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f4a56fe8033e92669a8e2fb2855c01a3a003259f Comments
Remove explict focus ring install for button subclasses Since views button installs focus ring by deafult to show on keyboard focus, this CL refactors all its subclasses to remove explicit installation of focus ring. Only subclasses that need to override to remove focus ring installation need to call SetInstallFocusRingOnFocus(false) explicitly. BUG=924232 Change-Id: Ia5bfce1fca6aaca16ae7e39106737de976e191fc Reviewed-on: https://chromium-review.googlesource.com/c/1432252 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#625464}
Changed files
- ash/shelf/login_shelf_view.cc
- ash/system/tray/tray_background_view.cc
- chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc
- chrome/browser/ui/views/overlay/back_to_tab_image_button.cc
- chrome/browser/ui/views/overlay/close_image_button.cc
- chrome/browser/ui/views/overlay/overlay_window_views.cc
- chrome/browser/ui/views/overlay/playback_image_button.cc
- chrome/browser/ui/views/overlay/resize_handle_button.cc
- chrome/browser/ui/views/overlay/skip_ad_label_button.cc
- chrome/browser/ui/views/passwords/password_pending_view.cc
- chrome/browser/ui/views/tabs/new_tab_button.cc
- chrome/browser/ui/views/tabs/tab_close_button.cc
- ui/views/controls/button/checkbox.cc
- ui/views/controls/button/md_text_button.cc
-
cros: Add UI indicators for SingleProcessMash mode
Changed by James Cook - jamescookohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:07:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 633b99d2a472da2eee2453d86a8b4b3069d5e144 Comments
cros: Add UI indicators for SingleProcessMash mode SingleProcessMash changes a large amount of under-the-hood code, so we want to know the status of the feature in bug reports, screen shots, etc. * Remove SingleProcessMash from the desktop wallpaper because it's usually blocked by windows * Add back the login/lock string (which was accidentally removed in http://crrev.com/c/1389498) * Add SingleProcessMash to about:version, so it can be copy/pasted with the OS version info * Add a subtle dash ("-") to the system tray to show up in screen shots The dash will need to be removed before branch. Code in //ash does not know the chrome channel (due to ash being below chrome in the dependency graph) so it's difficult to show the dash just in canary/dev. Bug: 920963, 924734 Change-Id: Ib65fe494381786854cfdc7b98e5b6b8284ae22cf Reviewed-on: https://chromium-review.googlesource.com/c/1431696 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#625463}
Changed files
- ash/login/ui/lock_contents_view.cc
- ash/system/date/date_view.cc
- ash/wallpaper/wallpaper_view.cc
- chrome/browser/ui/webui/version_handler_chromeos.cc
-
[mojo] introduce mojom-test-utils.{h,cc} for interface test helper
Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:04:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8cfb489e75bb00187cf2592e8d59cf354a4b0504 Comments
[mojo] introduce mojom-test-utils.{h,cc} for interface test helper This reduced total size of *.mojom.h after building chrome on linux from 9264703 bytes to 8690120 bytes, reduced to 93.7%. Bug: 922875 Change-Id: Ib019f2059a71a800694804c86bf3ecf605d79d63 Reviewed-on: https://chromium-review.googlesource.com/c/1416802 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#625462}
Changed files
- chrome/browser/android/download/available_offline_content_provider_unittest.cc
- chrome/browser/chrome_security_exploit_browsertest.cc
- chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc
- chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
- chrome/browser/chromeos/first_run/chromeos_first_run_browsertest.cc
- chrome/browser/chromeos/login/lock/screen_locker_tester.cc
- chrome/browser/chromeos/login/login_shelf_test_helper.cc
- chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
- chrome/browser/chromeos/shutdown_policy_browsertest.cc
- chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
- chrome/browser/ui/ash/accelerator_commands_browsertest.cc
- chrome/browser/ui/ash/network/networking_config_chromeos_browsertest.cc
- chrome/browser/ui/ash/shelf_browsertest.cc
- chrome/browser/ui/ash/system_tray_client_browsertest.cc
- chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
- chrome/browser/ui/ash/time_to_first_present_recorder_browsertest.cc
- chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
- chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
- chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
- chrome/browser/ui/webui/chromeos/system_web_dialog_browsertest.cc
- chrome/browser/web_applications/components/web_app_data_retriever_unittest.cc
- chromeos/components/drivefs/drivefs_auth_unittest.cc
- chromeos/components/drivefs/drivefs_bootstrap_unittest.cc
- chromeos/components/drivefs/drivefs_host_unittest.cc
- chromeos/components/drivefs/drivefs_search_unittest.cc
- content/browser/DEPS
- content/browser/frame_host/render_frame_host_impl_browsertest.cc
- content/browser/isolated_origin_browsertest.cc
- content/browser/portal/portal_browsertest.cc
- content/browser/security_exploit_browsertest.cc
- content/browser/site_per_process_hit_test_browsertest.cc
- content/test/did_commit_provisional_load_interceptor.cc
- mojo/public/cpp/bindings/tests/test_helpers_unittest.cc
- mojo/public/tools/bindings/BUILD.gn
- mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl
- mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
- mojo/public/tools/bindings/generators/cpp_templates/module-test-utils.cc.tmpl
- mojo/public/tools/bindings/generators/cpp_templates/module-test-utils.h.tmpl
- mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl
- mojo/public/tools/bindings/generators/mojom_cpp_generator.py
- mojo/public/tools/bindings/mojom.gni
- services/device/bluetooth/bluetooth_system_unittest.cc
- ui/views/mus/desktop_window_tree_host_mus_unittest.cc
-
chromeos: gets ash_shell_with_content working
Changed by Scott Violet - skyohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:03:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b279bae81f90722395637fd3e9caded22840ca0a Comments
chromeos: gets ash_shell_with_content working Service launching was failing because HandleServiceRequest() was always returning false. BUG=none TEST=none Change-Id: I03beaae4a9e52e3beaee8bb21b67abd8eaf3c7ce Reviewed-on: https://chromium-review.googlesource.com/c/1432373 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625461}
Changed files
- ash/BUILD.gn
- ash/shell/content/client/shell_main_delegate.cc
- services/ws/ime/test_ime_driver/test_ime_driver.cc
-
Add Premount to SmbProviderClient
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Thursday, 24-Jan-19 01:02:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aedaf584f537f6b2b9ce2a5aa450c104986b7b29 Comments
Add Premount to SmbProviderClient - Adds Dbus method calls for Premount. - Response from Dbus is logged and handled by the MountCallback. Bug: chromium:878502 Test: end to end Change-Id: Iaabf4457d3b95c0bb0b2e11c7276ea7dc4c54b75 Reviewed-on: https://chromium-review.googlesource.com/c/1407661 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#625460}
Changed files
- chromeos/dbus/fake_smb_provider_client.cc
- chromeos/dbus/fake_smb_provider_client.h
- chromeos/dbus/smb_provider_client.cc
- chromeos/dbus/smb_provider_client.h
-
Use focus ring for views button on all platforms
Changed by Wei Li - weiliohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:01:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f1e1cf79ce1aa12db141ed6f0060fc2db4322bb7 Comments
Use focus ring for views button on all platforms On platforms other than Mac, ink drop highlight was used to indicate focus. This has some shortcomings such as possible low contrast, inconsistency across platforms or even across other UI components. This CL changes views button to use focus ring for keyboard focus on all platforms. BUG=864642,924232 Change-Id: I31b3f2aa78259e6ae365bfde6687b92314e233e9 Reviewed-on: https://chromium-review.googlesource.com/c/1429239 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#625459}
Changed files
- chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
- ui/views/controls/button/button.cc
- ui/views/style/platform_style.cc
- ui/views/style/platform_style.h
- ui/views/style/platform_style_mac.mm
-
Update Windows order files
Changed by Hans Wennborg - hansohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:00:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a098975a3f65e71f1383f61cbc69219b522873ff Comments
Update Windows order files These were created following the instructions from https://chromium.googlesource.com/chromium/src/+/master/docs/win_order_files.md using Chromium #625306. Bug: none Change-Id: I53c7d2d6ad58dfa7142844e2f751a12eda567bb9 Reviewed-on: https://chromium-review.googlesource.com/c/1432154 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#625458}
Changed files
- chrome/build/chrome.x64.orderfile.sha1
- chrome/build/chrome.x86.orderfile.sha1
- chrome/build/chrome_child.x64.orderfile.sha1
- chrome/build/chrome_child.x86.orderfile.sha1
-
[fuchsia] Read the command-line from /data/cast/
Changed by Aidan Wolter - awolterohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 01:00:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c513d32f12bc293c50fe5c09961588c885ebcfc2 Comments
[fuchsia] Read the command-line from /data/cast/ The command-line will now be populated from /data/cast/castagent-command-line. Bug: b/122267826 Test: Add command-line to show verbose logging, cast_shell_unittests Change-Id: I741a1a32e59bea07a2ce857d24df57712cf32761 Reviewed-on: https://chromium-review.googlesource.com/c/1396135 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#625457}
Changed files
- chromecast/app/BUILD.gn
- chromecast/app/android/cast_jni_loader.cc
- chromecast/app/cast_main.cc
- chromecast/app/cast_main_delegate.cc
- chromecast/app/cast_main_delegate.h
- chromecast/app/cast_main_delegate_unittest.cc
- chromecast/app/cast_test_launcher.cc
- chromecast/cast_shell_sandbox_policy
-
Image annotation service: added OWNERS.
Changed by Michael Martis - martisohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:59:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9222b4fc3a236547536fe47e3f18748f8b1b3feb Comments
Image annotation service: added OWNERS. Bug: crbug.com/916420 Change-Id: Ie56c05165aa2398cc10c046923c0799b43fe700c Reviewed-on: https://chromium-review.googlesource.com/c/1432413 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#625456}
Changed files
- services/image_annotation/OWNERS
-
Settings: Get web storage for site details.
Changed by Maggie Cai - mxcaiohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:59:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b2502ccb633ae836f988929672ee87cfc452db4f Comments
Settings: Get web storage for site details. Currently the 'Usage' showing on site details page didn't show all the web storage data. This CL updates the data fetching and clearing to use CookiesTreeModel to show and clear all the storage data for a origin. BUG=922355 Change-Id: Ia06a18d561471f1a0cc1d18d0fc558881f984027 Reviewed-on: https://chromium-review.googlesource.com/c/1424678 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Patti <patricialor@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625455}
Changed files
- chrome/browser/browsing_data/cookies_tree_model.cc
- chrome/browser/browsing_data/cookies_tree_model.h
- chrome/browser/browsing_data/local_data_container.cc
- chrome/browser/resources/settings/site_settings/site_details.html
- chrome/browser/resources/settings/site_settings/site_details.js
- chrome/browser/resources/settings/site_settings/website_usage_private_api.js
- chrome/browser/ui/webui/settings/site_settings_handler.cc
- chrome/browser/ui/webui/settings/site_settings_handler.h
-
Roll src/third_party/spirv-headers/src 79b6681aadcb..f3abb280c2aa (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 24-Jan-19 00:58:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a30a9737fc2fabcb61ba6596054db2b71e6d558a Comments
Roll src/third_party/spirv-headers/src 79b6681aadcb..f3abb280c2aa (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/79b6681aadcb..f3abb280c2aa git log 79b6681aadcb..f3abb280c2aa --date=short --no-merges --format='%ad %ae %s' 2019-01-23 johnkslang@users.noreply.github.com Merge pull request #91 from LukasBanana/master Created with: gclient setdep -r src/third_party/spirv-headers/src@f3abb280c2aa The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3343e5299b98f9615c5a1bf3a483982fb8b30ac6 Reviewed-on: https://chromium-review.googlesource.com/c/1431840 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625454}
Changed files
- DEPS
-
[PE] Don't paint document marker outside of line box
Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:57:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3320a12812dc926780b9565dea33d528d7fc937f Comments
[PE] Don't paint document marker outside of line box We don't consider document markers when calculating visual overflow, so we should not paint outside of the line box. Previously, we painted outside so bad things happened (e.g. under invalidation). Bug: 896985 Change-Id: Id551e501fc273bbcb7c238a8f8c34d5c50fd2e96 Reviewed-on: https://chromium-review.googlesource.com/c/1429625 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625453}
Changed files
- third_party/blink/renderer/core/paint/document_marker_painter.cc
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/markers/markers-zoomed-expected.png
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/markers/vertical-lr-expected.png
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/markers/vertical-rl-expected.png
- third_party/blink/web_tests/paint/markers/document-markers-font-64px.html
- third_party/blink/web_tests/paint/markers/document-markers-font-8px.html
- third_party/blink/web_tests/paint/markers/document-markers-zoom-2000.html
- third_party/blink/web_tests/platform/linux/paint/markers/document-markers-font-64px-expected.png
- third_party/blink/web_tests/platform/linux/paint/markers/document-markers-font-8px-expected.png
- third_party/blink/web_tests/platform/linux/paint/markers/document-markers-zoom-125-expected.png
- third_party/blink/web_tests/platform/linux/paint/markers/document-markers-zoom-200-expected.png
- third_party/blink/web_tests/platform/linux/paint/markers/document-markers-zoom-2000-expected.png
- third_party/blink/web_tests/platform/linux/paint/markers/document-markers-zoom-250-expected.png
- third_party/blink/web_tests/platform/linux/paint/markers/markers-zoomed-expected.png
- third_party/blink/web_tests/platform/linux/paint/markers/vertical-lr-expected.png
- third_party/blink/web_tests/platform/linux/paint/markers/vertical-rl-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/document-markers-font-64px-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/document-markers-font-8px-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/document-markers-zoom-125-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/document-markers-zoom-200-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/document-markers-zoom-2000-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/document-markers-zoom-250-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/markers-zoomed-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/vertical-lr-expected.png
- third_party/blink/web_tests/platform/linux/virtual/stable/paint/markers/vertical-rl-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/document-markers-font-64px-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/document-markers-font-8px-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/document-markers-zoom-2000-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/document-markers-zoom-250-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/ellipsis-ltr-text-in-ltr-flow-with-markers-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/ellipsis-rtl-text-in-rtl-flow-with-markers-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/inline-spelling-markers-hidpi-composited-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/inline-spelling-markers-hidpi-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/inline_spelling_markers-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/markers-zoomed-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/suggestion-marker-basic-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/vertical-lr-expected.png
- third_party/blink/web_tests/platform/mac/paint/markers/vertical-rl-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/document-markers-font-64px-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/document-markers-font-8px-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/document-markers-zoom-125-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/document-markers-zoom-200-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/document-markers-zoom-2000-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/document-markers-zoom-250-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/grammar-markers-hidpi-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/inline-spelling-markers-hidpi-composited-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/inline-spelling-markers-hidpi-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/markers-zoomed-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/vertical-lr-expected.png
- third_party/blink/web_tests/platform/win/paint/markers/vertical-rl-expected.png
-
Clean up dom_distiller::WebContentsMainFrameObserver and its unit test.
Changed by Aran Gilman - gilmanmhohnoyoudont@google.com Changed at Thursday, 24-Jan-19 00:57:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 27080ab60fc1fbab24910cf37ed02190de1c5537 Comments
Clean up dom_distiller::WebContentsMainFrameObserver and its unit test. Specific changes: * Provide constants to use in place of raw bools when calling Navigate() in the unit test. This makes it a bit easier to determine what the call does without scrolling up and looking at the method. * Replace ASSERT_* to EXPECT_*. None of these conditions prevent the test from continuing, so it should be allowed to do so in case it uncovers more errors. * Make getters const. Change-Id: I933daa3820d0b3dc957212a0d2a2fc88251538dc Reviewed-on: https://chromium-review.googlesource.com/c/1419438 Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#625452}
Changed files
- components/dom_distiller/content/browser/web_contents_main_frame_observer.h
- components/dom_distiller/content/browser/web_contents_main_frame_observer_unittest.cc
-
Unelide URLs when specified extension enabled
Changed by Livvie Lin - livvielinohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:56:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dd0a6007609136df1c1c847aaeab42896ad52dff Comments
Unelide URLs when specified extension enabled When go/herd-immunity (Google internal doc) extension is enabled, unelide URLs and turn off Query in Omnibox. We're choosing to hard-code the extension id since only one extension needs this, and we don't need the added complexity of making this an extension API. Bug: 914422 Change-Id: I1c8f3ddd6f236d2812adad6272225aa07d47fb54 Reviewed-on: https://chromium-review.googlesource.com/c/1415751 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#625451}
Changed files
- chrome/browser/ui/toolbar/chrome_location_bar_model_delegate.cc
- chrome/browser/ui/toolbar/chrome_location_bar_model_delegate.h
- components/omnibox/browser/location_bar_model_delegate.cc
- components/omnibox/browser/location_bar_model_delegate.h
- components/omnibox/browser/location_bar_model_impl.cc
- components/omnibox/browser/location_bar_model_impl_unittest.cc
-
compositor: makes all functions of CompositorObserver non-pure virtual
Changed by Scott Violet - skyohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:56:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 068db4110ce3deb05a5ffc18ebc0df537a72958e Comments
compositor: makes all functions of CompositorObserver non-pure virtual BUG=none TEST=none Change-Id: I666ee290ff4182844c2862cd9ae4a2ec6274021f Reviewed-on: https://chromium-review.googlesource.com/c/1432393 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625450}
Changed files
- ash/system/power/power_event_observer.cc
- chrome/browser/chromeos/login/ui/login_display_host_webui.cc
- chrome/browser/metrics/browser_window_histogram_helper.h
- chrome/browser/ui/views/omnibox/omnibox_view_views.cc
- chrome/browser/ui/views/omnibox/omnibox_view_views.h
- content/browser/renderer_host/delegated_frame_host.cc
- content/browser/renderer_host/delegated_frame_host.h
- ui/aura/window_tree_host.cc
- ui/aura/window_tree_host.h
- ui/compositor/compositor_observer.h
- ui/compositor/layer_unittest.cc
- ui/compositor/recyclable_compositor_mac.h
- ui/compositor/test/draw_waiter_for_test.cc
- ui/compositor/test/draw_waiter_for_test.h
- ui/views/controls/scroll_view_unittest.cc
-
WebUI Polymer: Only include iron-validatable-behavior on CrOS.
Changed by dpapad - dpapadohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:55:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f213eb5bc5b468744e0dc4dcd889fc6d64e0ee5b Comments
WebUI Polymer: Only include iron-validatable-behavior on CrOS. This component is only used by iron-input which in turn is only used on CrOS. Bug: 899982 Change-Id: Ib10e1bc77f143591882aefde0e039907cd722568 Reviewed-on: https://chromium-review.googlesource.com/c/1432679 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625449}
Changed files
- ui/webui/resources/polymer_resources.grdp
-
Convert from base::{LazyInstance,Singleton} to base::NoDestructor
Changed by Sylvain Defresne - sdefresneohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:54:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8b09db7a4439e5563ad884ea5c1ddc7ad1a9c9ea Comments
Convert from base::{LazyInstance,Singleton} to base::NoDestructor The class base::NoDestructor is a simpler way to define a static global value (aka a singleton) than base::{LazyInstance,Singleton} and is the recommended pattern to use. The changes were automated using a custom one-shot script, then fine tuned by hand (to remove unnecessary classes, ...). This fixes usages in src/ios/chrome/browser/update_client. This CL was uploaded by git cl split. Bug: none Change-Id: I3eb76f475aa91dd3af90b69c17a1620b5bbbe0cc Reviewed-on: https://chromium-review.googlesource.com/c/1426697 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625448}
Changed files
- ios/chrome/browser/update_client/ios_chrome_update_query_params_delegate.cc
- ios/chrome/browser/update_client/ios_chrome_update_query_params_delegate.h
-
Reland "Add FieldTrial Testing config for Company Name Test in Beta"
Changed by Jeffrey Cohen - jeffreycohenohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:53:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6e4945b079fee57cb750e8f37dfb92455dabbebb Comments
Reland "Add FieldTrial Testing config for Company Name Test in Beta" TBR=mpearson@chromium.org This is a reland of 3244db379ef467bc86230f1c98189aca01bef17c Original change's description: > Add FieldTrial Testing config for Company Name Test in Beta > > > Bug: 890972 > Change-Id: Ib1aad147f260a1fd84df4d6ad9fc761742e16491 > Reviewed-on: https://chromium-review.googlesource.com/c/1385547 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622647} Bug: 890972 Change-Id: I63e7c059bc4d2d3d0cf8ba390a95394566c43a15 Reviewed-on: https://chromium-review.googlesource.com/c/1427101 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625447}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
- chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressWithoutPhoneTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsAndFreeShippingTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressAndOptionTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragmentTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/OWNERS
- testing/variations/fieldtrial_testing_config.json
-
[ChromeDriver] Enable disabled tests on Mac
Changed by khachatryan - khachatryanohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:53:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 335e6b2777bd91a1ac38316bdc6e804e4ef5ac0d Comments
[ChromeDriver] Enable disabled tests on Mac These tests are now passing with the updated Java tests. Bug: chromedriver:2748 Bug: chromedriver:2664 Change-Id: I8dc3885410104c663e99f809de4de47a1c9e1dbc Reviewed-on: https://chromium-review.googlesource.com/c/1432054 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625446}
Changed files
- chrome/test/chromedriver/test/test_expectations
-
[VK] Clean up timing code.
Changed by Darren Shen - shendohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:52:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f3b4fb30c19c37df9189f8c2e1c8d5297ef4dbbb Comments
[VK] Clean up timing code. Bug: 845780 Change-Id: I07e73631ec2ebb363f4ab96d1b6489006692054b Reviewed-on: https://chromium-review.googlesource.com/c/1432412 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#625445}
Changed files
- ui/keyboard/keyboard_controller.cc
-
Styling for new answer layout, part 2.
Changed by Tomasz Wiszkowski - enderohnoyoudont@google.com Changed at Thursday, 24-Jan-19 00:51:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0c3e30621126dfb64b5a4e7b69a711afd6c6766e Comments
Styling for new answer layout, part 2. This provides styling for mathematical equations. Bug: 920396 Change-Id: I7c11f2a55da20d69d4697094072f9596be8d6298 Reviewed-on: https://chromium-review.googlesource.com/c/1422298 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Auto-Submit: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#625444}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java
- chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/AnswerSuggestionProcessor.java
- chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/BasicSuggestionProcessor.java
- chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/SuggestionViewViewBinder.java
- chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionProcessor.java
-
Use SyncService instead of ProfileSyncService when possible
Changed by Sylvain Defresne - sdefresneohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:50:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 780f6874acdc3c5d6b7a752c58b094062a344977 Comments
Use SyncService instead of ProfileSyncService when possible The sync service API is exposed by the syncer::SyncService interface and browser_sync::ProfileSyncService is an implementation of it. The code should prefer to use the abstract interface (for one, testing is easier as the surface to mock is smaller) instead of a particular concrete implementation. This change both factories in src/ios to return a syncer::SyncService and port client code that could not use syncer::SyncService to access the service as browser_sync::ProfileSyncService via dedicated methods. Those methods will eventually be removed once there are alternative way to access the corresponding API (either because it is moved to a separate service, or moved to the syncer::SyncService interface). Bug: 924508 Change-Id: I49db34ea7c79ef7b6165eb6d51f03b0af0394b41 Reviewed-on: https://chromium-review.googlesource.com/c/1429939 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#625443}
Changed files
- ios/chrome/app/DEPS
- ios/chrome/app/spotlight/topsites_spotlight_manager.mm
- ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.mm
- ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc
- ios/chrome/browser/browsing_data/browsing_data_counter_wrapper.cc
- ios/chrome/browser/history/web_history_service_factory.cc
- ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
- ios/chrome/browser/metrics/ios_profile_session_durations_service_factory.mm
- ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
- ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc
- ios/chrome/browser/passwords/password_controller.mm
- ios/chrome/browser/signin/authentication_service.h
- ios/chrome/browser/signin/authentication_service.mm
- ios/chrome/browser/signin/authentication_service_fake.h
- ios/chrome/browser/signin/authentication_service_fake.mm
- ios/chrome/browser/suggestions/suggestions_service_factory.mm
- ios/chrome/browser/sync/glue/sync_start_util.cc
- ios/chrome/browser/sync/ios_chrome_sync_client.mm
- ios/chrome/browser/sync/ios_user_event_service_factory.cc
- ios/chrome/browser/sync/profile_sync_service_factory.cc
- ios/chrome/browser/sync/profile_sync_service_factory.h
- ios/chrome/browser/sync/profile_sync_service_factory_unittest.cc
- ios/chrome/browser/sync/session_sync_service_factory.mm
- ios/chrome/browser/sync/sync_setup_service_factory.cc
- ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
- ios/chrome/browser/ui/bookmarks/synced_bookmarks_bridge.mm
- ios/chrome/browser/ui/history/history_coordinator.mm
- ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator_unittest.mm
- ios/chrome/browser/ui/settings/accounts_table_egtest.mm
- ios/chrome/browser/ui/settings/accounts_table_view_controller.mm
- ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
- ios/chrome/browser/ui/settings/google_services_settings_mediator.h
- ios/chrome/browser/ui/settings/google_services_settings_mediator.mm
- ios/chrome/browser/ui/settings/settings_table_view_controller.mm
- ios/chrome/browser/ui/settings/sync_encryption_passphrase_table_view_controller.mm
- ios/chrome/browser/ui/settings/sync_encryption_table_view_controller.mm
- ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
- ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm
- ios/chrome/browser/ui/settings/sync_utils/sync_error_infobar_delegate.mm
- ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm
- ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
- ios/chrome/browser/unified_consent/unified_consent_service_factory.cc
- ios/chrome/test/app/sync_test_util.mm
- ios/web_view/internal/autofill/cwv_autofill_controller.mm
- ios/web_view/internal/cwv_web_view_configuration.mm
- ios/web_view/internal/passwords/web_view_password_store_factory.mm
- ios/web_view/internal/sync/cwv_sync_controller.mm
- ios/web_view/internal/sync/cwv_sync_controller_internal.h
- ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
- ios/web_view/internal/sync/web_view_profile_sync_service_factory.h
- ios/web_view/internal/sync/web_view_profile_sync_service_factory.mm
-
Try to deflake two http/tests/devtools/layers tests
Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:50:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 977d954ac88bee5b9c259d9ac3b0499729e9ed48 Comments
Try to deflake two http/tests/devtools/layers tests - http/tests/devtools/layers/layer-compositing-reasons.js When it failed, the text difference was: +ERROR: No layer for iframe -Compositing reasons for iframe#iframe: iFrame which means that the iframe is not composited when we dump the compositing reasons. This is probably a synchronization issue, but instead of fixing the issue, I removed the iframe from the test because 1. the other layers already provide enough test coverage of the compositing reasons feature of devtools, 2. whether the iframe is composited is not a matter of the test, but compositing tests to test, and 3. CompositeAfterPaint no longer needs to composite iframes containing composited contents - http/tests/devtools/layers/layer-scroll-rects-get.js When it failed, the touch action rects were missing. Let the page wait one additional frame to ensure the touch action rects are updated. Bug: 794180,859169 Change-Id: I633bc0db1c9ff848d51182b5222fbaf82920250a Reviewed-on: https://chromium-review.googlesource.com/c/1423931 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#625442}
Changed files
- third_party/blink/web_tests/http/tests/devtools/layers/layer-compositing-reasons-expected.txt
- third_party/blink/web_tests/http/tests/devtools/layers/layer-compositing-reasons.js
- third_party/blink/web_tests/http/tests/devtools/layers/layer-scroll-rects-get.js
- third_party/blink/web_tests/http/tests/devtools/layers/resources/compositing-reasons.html
-
[Feed] Enable LevelDB's default histograms for Feed and friends
Changed by Brandon Wylie - wyliebohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:49:37 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5ba80bd41aad1702d4706e72f64f98300d340ed0 Comments
[Feed] Enable LevelDB's default histograms for Feed and friends Bug: 915791 Change-Id: I27bad3cd49bf5c3036a09c73f9139886e3955cdf Reviewed-on: https://chromium-review.googlesource.com/c/1380941 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#625441}
Changed files
- tools/metrics/histograms/histograms.xml
-
[TaskScheduler]: Cleanup ScopedAllowWait.
Changed by Etienne Pierre-doray - etiennepohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:49:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f85e02ae59b813b1de0cbb58e28cd8db398627ab Comments
[TaskScheduler]: Cleanup ScopedAllowWait. Delete deprecated ScopedAllowWait and remove related friendship in ThreadRestrictions. Bug: 766678 Change-Id: I25c33b87150c6dbfb3325c4591d34919b975e59d Reviewed-on: https://chromium-review.googlesource.com/c/1417790 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#625440}
Changed files
- base/threading/thread_restrictions.cc
- base/threading/thread_restrictions.h
- content/public/test/nested_message_pump_android.cc
-
Disable casting warning from cpplint in chromium
Changed by Quinten Yearsley - qyearsleyohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:48:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 98c7fe34e21b2d2bddc3b7729ff3cfcec03ac837 Comments
Disable casting warning from cpplint in chromium This warning is incorrect when cpplint is run on Objective-C headers. This CL also adds an explicit "verbose" config, which shouldn't change behavior, but explicit is better than implicit. Bug: 924509 Change-Id: I39f35926ae799fc1c03947a2320590932757d4bc Reviewed-on: https://chromium-review.googlesource.com/c/1431892 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#625439}
Changed files
- infra/config/global/tricium-prod.cfg
-
Remove DCHECK from GetWindowClientInfoOnUI
Changed by Egor Pasko - paskoohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:47:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9dd721953ed486ad03a0ecb9fe4a0453c661c821 Comments
Remove DCHECK from GetWindowClientInfoOnUI As discussed in the bug, the condition under DCHECK is legitimate, and the existing code does no harm in this case. Bug: 923806 Change-Id: I5c46ac94174ba91184d6a5dad46702899abef95e Reviewed-on: https://chromium-review.googlesource.com/c/1431613 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#625438}
Changed files
- content/browser/service_worker/service_worker_client_utils.cc
-
Reland "[NTP] Cap search suggestion impressions"
Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 00:46:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5d52425f8fe923f16feb6a9759baf0a5b20e758d Comments
Reland "[NTP] Cap search suggestion impressions" This is a reland of 41e54be1d923353f72490f19a15e73eb09248a38 One of the checks is converting the times from ms->s. In practice seconds is plenty precise but in the test 800ms ended up being 0, so increase it to 1000ms (similar to ImpressionCountResetsAfterTimeout which was not flaky). Original change's description: > [NTP] Cap search suggestion impressions > > The parameters for capping suggestions impressions are provided as part > of the update proto. Read and update the local pref on each fetch. Use > these prefs to determine if the impression cap has been reach or if > fetching is frozen due to an empty response. > > Bug: 904565 > Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8 > Reviewed-on: https://chromium-review.googlesource.com/c/1395188 > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624994} Bug: 904565 Change-Id: I424cb51d2a9c1738c0e5168f58ef52b73ed4b223 Reviewed-on: https://chromium-review.googlesource.com/c/1431472 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625437}
Changed files
- chrome/browser/search/local_ntp_source.cc
- chrome/browser/search/search_suggest/search_suggest_data.cc
- chrome/browser/search/search_suggest/search_suggest_data.h
- chrome/browser/search/search_suggest/search_suggest_loader.h
- chrome/browser/search/search_suggest/search_suggest_loader_impl.cc
- chrome/browser/search/search_suggest/search_suggest_loader_impl_unittest.cc
- chrome/browser/search/search_suggest/search_suggest_service.cc
- chrome/browser/search/search_suggest/search_suggest_service.h
- chrome/browser/search/search_suggest/search_suggest_service_unittest.cc
- chrome/common/pref_names.cc
- chrome/common/pref_names.h
-
Clean up distillable_page_utils.h and related files.
Changed by Aran Gilman - gilmanmhohnoyoudont@google.com Changed at Thursday, 24-Jan-19 00:46:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 008a7ae48922ac58e8cf3a807b1c4f026172ed0f Comments
Clean up distillable_page_utils.h and related files. This includes formatting the files with clang-format, adding and rewriting comments to make the code easier to understand, and adding/removing includes. Change-Id: I91395c1974f8ad68a2fd0245c2362fe6d1803ddc Reviewed-on: https://chromium-review.googlesource.com/c/1423091 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#625436}
Changed files
- chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
- components/dom_distiller/content/browser/distillable_page_utils.cc
- components/dom_distiller/content/browser/distillable_page_utils.h
- components/dom_distiller/content/browser/distillable_page_utils_android.cc
-
<blame list capped at 100 commits>
Changed by <blame list capped at 100 commits> - Changed at N/A Repository Branch Revision Comments
<blame list capped at 100 commits>