Builder mac-views-rel
Build 13976
Results:
Internal Failure
Trigger Info:
Project | chromium |
Revision | c54a2a793bc638bc6756ee110d70836e7cdf3a61 |
Execution:
- Source: Task 4295eaa61534d710
- Recipe: chromium
Build Properties:
Name | Value | Source |
---|
Blamelist:
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- bsheedy (bsheedyohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Theresa (twellingtonohnoyoudont@chromium.org)
- Lakshmi Kumar Dabbiru (dlkumarohnoyoudont@google.com)
- rbpotter (rbpotterohnoyoudont@chromium.org)
- Ian Kilpatrick (ikilpatrickohnoyoudont@chromium.org)
- dstockwell (dstockwellohnoyoudont@chromium.org)
- Eric Stevenson (estevensonohnoyoudont@chromium.org)
- Dana Fried (dfriedohnoyoudont@chromium.org)
- Manu Cornet (manucornetohnoyoudont@chromium.org)
- Madeleine Barowsky (mbarowskyohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Ben Pastene (bpasteneohnoyoudont@chromium.org)
- Luciano Pacheco (lucmultohnoyoudont@chromium.org)
- David Bokan (bokanohnoyoudont@chromium.org)
- danakj (danakjohnoyoudont@chromium.org)
- Eugene But (eugenebutohnoyoudont@google.com)
- Victor Costan (pwnallohnoyoudont@chromium.org)
- danakj (danakjohnoyoudont@chromium.org)
- Yann Dago (ydagoohnoyoudont@chromium.org)
- Daniel Rubery (druberyohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Sidney San Martín (sdyohnoyoudont@chromium.org)
- 3su6n15k.default@developer.gserviceaccount.com (3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Xiaohui Chen (xiaohuicohnoyoudont@google.com)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Nicolas Pena (npmohnoyoudont@chromium.org)
- Lei Zhang (thestigohnoyoudont@chromium.org)
- Alexei Svitkine (asvitkineohnoyoudont@chromium.org)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
- Reid Kleckner (rnkohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Matthew Jones (mdjonesohnoyoudont@chromium.org)
- Lakshmi Kumar Dabbiru (dlkumarohnoyoudont@google.com)
- Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
- Jordan Rupprecht (rupprechtohnoyoudont@google.com)
- Sam Maier (smaierohnoyoudont@chromium.org)
- Xing Liu (xingliuohnoyoudont@chromium.org)
- Nate Fischer (ntfschrohnoyoudont@chromium.org)
- Dominic Battre (battreohnoyoudont@chromium.org)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Kristi Park (kristiparkohnoyoudont@chromium.org)
- Parastoo Geranmayeh (parastoogohnoyoudont@google.com)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Steve Kobes (skobesohnoyoudont@chromium.org)
- Anne Lim (annelimohnoyoudont@google.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Kristi Park (kristiparkohnoyoudont@chromium.org)
- Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
- Salvador Guerrero (salgohnoyoudont@google.com)
- Ben Pastene (bpasteneohnoyoudont@chromium.org)
- Jacob Dufault (jdufaultohnoyoudont@google.com)
- Lei Zhang (thestigohnoyoudont@chromium.org)
- Jordan Demeulenaere (jdemeulenaereohnoyoudont@google.com)
- Kurt Horimoto (kkhorimotoohnoyoudont@chromium.org)
- Owen Min (zminohnoyoudont@chromium.org)
- Tommy C. Li (tommycliohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Ken Rockot (rockotohnoyoudont@google.com)
- chuanl (chuanlohnoyoudont@google.com)
- Paul Meyer (paulmeyerohnoyoudont@chromium.org)
- Brian White (bcwhiteohnoyoudont@chromium.org)
- Jered Gray (jegrayohnoyoudont@google.com)
- Xiaohui Chen (xiaohuicohnoyoudont@google.com)
- Caleb Raitto (caraittoohnoyoudont@chromium.org)
- Luke Sorenson (lasorenohnoyoudont@chromium.org)
- Khushal (khushalsagarohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Jonathan Backer (backerohnoyoudont@chromium.org)
- Joshua Bell (jsbellohnoyoudont@chromium.org)
- Jacob Dufault (jdufaultohnoyoudont@google.com)
- Robert Ogden (robertogdenohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Jamie Madill (jmadillohnoyoudont@chromium.org)
- Parastoo Geranmayeh (parastoogohnoyoudont@google.com)
- Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
- Eric Orth (ericorthohnoyoudont@chromium.org)
- Becca Hughes (beccahughesohnoyoudont@chromium.org)
- Xianda Sun (sunxdohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Peter Beverloo (peterohnoyoudont@chromium.org)
- Wez (wezohnoyoudont@chromium.org)
- Robert Liao (robliaoohnoyoudont@chromium.org)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Robert Sesek (rsesekohnoyoudont@chromium.org)
- Weiliang Chen (weiliangcohnoyoudont@chromium.org)
- Nicolas Pena (npmohnoyoudont@chromium.org)
- Christopher Cameron (ccameronohnoyoudont@chromium.org)
- Gary Kacmarcik (garykacohnoyoudont@chromium.org)
- Scott Violet (skyohnoyoudont@chromium.org)
- Xiao Yang (yanxiaoohnoyoudont@google.com)
- Anastasia Helfinstein (anastasiohnoyoudont@google.com)
- Peter Beverloo (peterohnoyoudont@chromium.org)
- Luke Halliwell (halliwellohnoyoudont@chromium.org)
- Pavol Marko (pmarkoohnoyoudont@chromium.org)
- <blame list capped at 100 commits> ()
Timing:
Create | Wednesday, 23-Jan-19 23:43:43 UTC |
Start | N/A |
End | Wednesday, 23-Jan-19 23:43:44 UTC |
Pending | 726 ms |
Execution | N/A |
All Changes:
-
Support premount mode in GetPreconfiguredSharePaths
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 23:40:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c54a2a793bc638bc6756ee110d70836e7cdf3a61 Comments
Support premount mode in GetPreconfiguredSharePaths - Add helper functions to differentiate getting preconfigured share paths for both dropdown and premount modes. Bug: chromium=878502 Test: compiles Change-Id: I62f5811e2f320a54b783abfdb9b0ffd719abc68a Reviewed-on: https://chromium-review.googlesource.com/c/1407658 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#625418}
Changed files
- chrome/browser/chromeos/smb_client/smb_service.cc
- chrome/browser/chromeos/smb_client/smb_service.h
- chromeos/dbus/smb_provider_client.cc
-
Roll src/third_party/pdfium 3dfb55b889fd..3e873fa0184f (3 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 23:40:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6a16498b032b4449bacd72be159a771db9f6ae50 Comments
Roll src/third_party/pdfium 3dfb55b889fd..3e873fa0184f (3 commits) https://pdfium.googlesource.com/pdfium.git/+log/3dfb55b889fd..3e873fa0184f git log 3dfb55b889fd..3e873fa0184f --date=short --no-merges --format='%ad %ae %s' 2019-01-23 thestig@chromium.org Fix a bad memset() in FPDFTextEmbedderTest. 2019-01-23 thestig@chromium.org Wrap a couple CPDFSDK_FormFillEnvironment methods inside ifdefs. 2019-01-23 thestig@chromium.org Fix some g++ -Werror=switch errors. Created with: gclient setdep -r src/third_party/pdfium@3e873fa0184f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib8a1b346103f7d910b3f783c0bcddeb8df670841 Reviewed-on: https://chromium-review.googlesource.com/c/1431834 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625417}
Changed files
- DEPS
-
Fix VrShellDelegate creation on Vega
Changed by bsheedy - bsheedyohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:36:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b83c78cafeda4e363276b3fd53038428ee46cb46 Comments
Fix VrShellDelegate creation on Vega Fixes VR tests failing on Vega due to the special TestVrShellDelegate construction done via reflection on Vega devices not being updated when the TestVrShellDelegate's constructor had an extra parameter added TBR=mthiesse@chromium.org Bug: 924696 Change-Id: Ib48f64609fad549a2af8078d376bab1601c1da13 Reviewed-on: https://chromium-review.googlesource.com/c/1431837 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#625416}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
-
Roll src/third_party/catapult 42be5d65ef03..b9dbf6c17c96 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 23:36:37 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 91433093dd23639a738e1ef7fce196d20b4d3da4 Comments
Roll src/third_party/catapult 42be5d65ef03..b9dbf6c17c96 (1 commits) https://chromium.googlesource.com/catapult.git/+log/42be5d65ef03..b9dbf6c17c96 git log 42be5d65ef03..b9dbf6c17c96 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 aluo@chromium.org Add UseWebViewProvider context manager. Created with: gclient setdep -r src/third_party/catapult@b9dbf6c17c96 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:914553 TBR=sullivan@chromium.org Change-Id: Iba2db89240c9e112fc7f65a33fc57d2609934a40 Reviewed-on: https://chromium-review.googlesource.com/c/1431912 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625415}
Changed files
- DEPS
-
Fix more ToolbarPhone texture capture issues
Changed by Theresa - twellingtonohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:35:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f9a48ec9468fa605b935260cee99077c4f9b7f6e Comments
Fix more ToolbarPhone texture capture issues - postInvalidate after exiting tab switcher. This ensures a new texture is captured immediately. - don't allow a texture to be captured while the NTP is scrolled. BUG=922909,916561 Change-Id: I08de5bd7f6d948c1574ec17e7967fef2dcf5ed06 Reviewed-on: https://chromium-review.googlesource.com/c/1432372 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#625414}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java
-
No fullstop for for Autofil namefix flow tool tip icon message
Changed by Lakshmi Kumar Dabbiru - dlkumarohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 23:34:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 998d4934ac2c5460785a4951cc65a2482237455e Comments
No fullstop for for Autofil namefix flow tool tip icon message As per UX review Bug: 913646 Change-Id: I94977a6e79f4759c56a1f3fa75da549407a63602 Reviewed-on: https://chromium-review.googlesource.com/c/1415257 Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Cr-Commit-Position: refs/heads/master@{#625413}
Changed files
- components/autofill_strings.grdp
-
Print Preview: Do not disable for cloud printer fetch failure
Changed by rbpotter - rbpotterohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:33:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision faa96d093cc4bf3118702fad1641dc2a286e1971 Comments
Print Preview: Do not disable for cloud printer fetch failure It does not make sense to disable the entire preview for a printer fetch failure. Update the cloud print state if there is a 403 error, and otherwise ignore these failures in app.js and let DestinationStore handle them. Bug: 923914 Change-Id: Ie0dc8596c30397ad531354a4a80345a4299c64f8 Reviewed-on: https://chromium-review.googlesource.com/c/1428059 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625412}
Changed files
- chrome/browser/resources/print_preview/data/destination_store.js
- chrome/browser/resources/print_preview/new/app.js
- chrome/test/data/webui/print_preview/cloud_print_interface_stub.js
- chrome/test/data/webui/print_preview/destination_select_test.js
- chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
-
[LayoutNG] Fix crash related to clearance and margin collapsing.
Changed by Ian Kilpatrick - ikilpatrickohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:33:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 54862d1e6119d70179636792f4883cd1095173c4 Comments
[LayoutNG] Fix crash related to clearance and margin collapsing. The root of this bug was that the parent bfc, and child with clearance were fighting as to what the BFC block offset should be. The child was always returning true within: NeedsAbortOnBfcBlockOffsetChange ... as the floats bfc offset was never equal to the child bfc offset, as the child got affected by clearance. This fix is to adjust the FloatsBfcBlockOffset by clearance to check if we need to relayout or not. Additionally we were performing more layouts than we should be, when propagating the BFC block offset up the tree upon an abort. We should be checking if the child got affected by clearance, and if so adjust the resolved BFC offset accordingly. Bug: 923271 Change-Id: Id39905a5445a0fe502c16b956b92d6db13885d36 Reviewed-on: https://chromium-review.googlesource.com/c/1423929 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#625411}
Changed files
- third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
- third_party/blink/renderer/core/layout/ng/ng_layout_result.cc
- third_party/blink/web_tests/external/wpt/css/CSS2/floats-clear/clear-on-child-with-margins-2.html
-
Remove dstockwell from third_party/blink/public OWNERS
Changed by dstockwell - dstockwellohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:31:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4588bfce013c7b1d93bb63580f59be98d89f43dd Comments
Remove dstockwell from third_party/blink/public OWNERS Change-Id: If1acff58705ce3bb7bd07e23a2eb4de24d0dd968 Reviewed-on: https://chromium-review.googlesource.com/c/1432492 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625410}
Changed files
- third_party/blink/public/OWNERS
-
Android: Add golden AndroidManifest files.
Changed by Eric Stevenson - estevensonohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:30:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dd798717e43464cc45ddbf9eb738a8c70194540d Comments
Android: Add golden AndroidManifest files. Purpose is to have manifest changes reviewed so that unexpected changes can't sneak into the merged manifest (ex. adding an aar dep that needs extra permissions). Any deviations from the golden files are printed for release builds and will fail the build if the GN arg check_android_configuration = true. Bug: 882528 Change-Id: I3fee0546004df18ada0fc33077c978edaa64f127 Reviewed-on: https://chromium-review.googlesource.com/c/1409406 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625409}
Changed files
- build/android/gyp/merge_manifest.py
- build/android/gyp/merge_manifest.pydeps
- build/android/gyp/proguard.py
- build/config/android/internal_rules.gni
- build/config/android/rules.gni
- chrome/android/BUILD.gn
- chrome/android/OWNERS
- chrome/android/java/README.md
- chrome/android/java/monochrome_public_apk.AndroidManifest.expected
-
Don't display update prompt for non-update alerts.
Changed by Dana Fried - dfriedohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:30:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d12b4110792b2fae2dfc953354436b8678cc9ad6 Comments
Don't display update prompt for non-update alerts. Previously, if the alert severity was anything other than NONE, the tooltip on the app menu prompted the user that an upgrade was available. But alerts are used for other things too (like an extension that has been disabled) so now we display a generic alert tooltip for non-upgrade situations. Bug: 889779 Change-Id: I952bc7803d09fbd7076b4c0636eb619085aee689 Reviewed-on: https://chromium-review.googlesource.com/c/1431475 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#625408}
Changed files
- chrome/app/chromium_strings.grd
- chrome/app/google_chrome_strings.grd
- chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
-
Revert "CrOS Shelf: Remove overflow shelf clip"
Changed by Manu Cornet - manucornetohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:29:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ec8cc7a14a4705481ec0bab65b6c6de0b5da2484 Comments
Revert "CrOS Shelf: Remove overflow shelf clip" This reverts commit 0cee3055957800b3acd3f458c2972bcce8352db5. Reason for revert: This change makes app icons bleed outside of the overflow when there are too many of them. Original change's description: > CrOS Shelf: Remove overflow shelf clip > > Remove overflow shelf clip so that inkdrop ripples can propagate > outside the overflow bubble. > > The mask isn't really useful in the first place anyway. > > See before/after screenshots here: > > https://bugs.chromium.org/p/chromium/issues/detail?id=631240#c14 > > Bug: 631240 > Change-Id: Iaa1d2f4e2e74bff34a708fa9e2cd7be5ed9a52fa > Reviewed-on: https://chromium-review.googlesource.com/c/1429639 > Auto-Submit: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625234} TBR=xiyuan@chromium.org,manucornet@chromium.org Change-Id: I51a004caf0a1b516fd21251621e9f716a241ca14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 631240 Reviewed-on: https://chromium-review.googlesource.com/c/1432732 Reviewed-by: Manu Cornet <manucornet@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#625407}
Changed files
- ash/shelf/overflow_bubble_view.cc
-
CC: Support YUV images in PaintImage and GpuImageDecodeCache
Changed by Madeleine Barowsky - mbarowskyohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:28:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cb521877bf31b9b6df74d34e01da6e41b0d9b469 Comments
CC: Support YUV images in PaintImage and GpuImageDecodeCache This patch modifies PaintImage to have an interface to indicate that the underlying image is YUV pixel format and adds a corresponding DecodeYuv() method. In GpuImageDecodeCache, this change adds "is YUV" variables/getters to DecodedImageData, UploadedImageData (has_yuv_planes()), and ImageData, as well as base:Optional arrays for the SkImages and GL texture IDs for each Y, U, and V plane in the relevant places. The YUV decoding path will initially be implemented for in-process GPU rasterization and later for OOPR (Out of Process Rasterization). Changes that affect WebP decoding in Blink will be hidden behind a flag called kDecodeLossyWebPImagesToYUV. Finally, because this decides whether to YUV decode based on the result of PaintImageGenerator::QueryYUVA8, we separately modified JPEGImageDecoder::CanDecodeToYUV (crrev.com/c/1400764) and VideoImageGenerator::QueryYUVA8 (crrev.com/c/1418322) to return false in order to avoid prematurely going down the YUV decode path. See bit.ly/webp-decoding-into-yuv for the design document and crrev.com/c/1338461 for a working prototype CL. Bug: 900672 Change-Id: I14f60d83cc2da2382e3da296fab598597b7e8ec8 Reviewed-on: https://chromium-review.googlesource.com/c/1368687 Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625406}
Changed files
- cc/paint/paint_image.cc
- cc/paint/paint_image.h
- cc/tiles/gpu_image_decode_cache.cc
- cc/tiles/gpu_image_decode_cache.h
- third_party/blink/renderer/platform/graphics/decoding_image_generator.cc
- third_party/blink/renderer/platform/graphics/image_frame_generator.cc
-
Roll src/third_party/SPIRV-Tools/src b1be6763f6f3..86d0d9be254a (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 23:27:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2f3863b0e20bd1fc6c7f1961701b96a23758bf05 Comments
Roll src/third_party/SPIRV-Tools/src b1be6763f6f3..86d0d9be254a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b1be6763f6f3..86d0d9be254a git log b1be6763f6f3..86d0d9be254a --date=short --no-merges --format='%ad %ae %s' 2019-01-23 afdx@google.com Refactored reducer so that the 'finding' functionality of a reduction pass are separated from the generic functionality for tracking progress of a pass. With this change, we now have a ReductionOpportunityFinder abstract class, with many subclasses for each type of reduction, and just one ReductionPass class, which has an associated finder. (#2321) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@86d0d9be254a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I58a795f2caba2d6f251c2e15b85b6bc4f692c929 Reviewed-on: https://chromium-review.googlesource.com/c/1431839 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625405}
Changed files
- DEPS
-
Add src-side configs for CI and optional try simplechrome lto bot.
Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:21:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 20e7ca69459a1ba720caf2baa10bef096da7143c Comments
Add src-side configs for CI and optional try simplechrome lto bot. The current amd64-generic builder has thin-lto and cfi disabled by default for build cycle time reasons. Chromeos-chrome ebuilds use them both however, so changes might slip in that break the ebuild but pass on the cq. This will add a CI bot (and an optional trybot) that has them both enabled. Bug: 924192 Change-Id: I371e4c6606c0e2e28112750add47208e9dcfd899 Reviewed-on: https://chromium-review.googlesource.com/c/1431515 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#625404}
Changed files
- infra/config/global/cr-buildbucket.cfg
- infra/config/global/luci-milo.cfg
- infra/config/global/luci-scheduler.cfg
- testing/buildbot/chromium.chromiumos.json
- testing/buildbot/waterfalls.pyl
- tools/mb/mb_config.pyl
-
[Files app] Fix VolumeManager unittests with MyFilesVolume enabled
Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:18:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fcf9301ce8f400fda8cdea18c31f355895a3499d Comments
[Files app] Fix VolumeManager unittests with MyFilesVolume enabled Fix VolumeManager unittest by forcing the flag to be enabled and changing the volume id to the new id. Bug: 873539 Change-Id: Ibb230220486cd6b91eadbe7b7e0b35972a45a695 Reviewed-on: https://chromium-review.googlesource.com/c/1428001 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#625403}
Changed files
- chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
-
Fix script-lifecycle violations with fragment anchors
Changed by David Bokan - bokanohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:16:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 45236fd563e9df53dc45579be1f3d0b4784885a2 Comments
Fix script-lifecycle violations with fragment anchors In https://crrev.com/dbd4eed1920a2aafbc87236db7efb98f108ba063 I moved around some fragment scrolling code to simplify and clean it up. As part of that, I made focusing and scrolling happen at the same time. Unfortunately, as noted in [1], this violates the lifecycle assumptions since focus() can synchronously execute an event handler - script is forbidden in the entire lifecycle, not just within layout. This CL undoes the loosening of the ScriptForbiddenScopes from the CL above. To do that, FragmentAnchor splits up the application of focus from scrolling and tries to apply focus at the time of FragmentAnchor creation (i.e. during parsing/navigation). If we can't apply it then (because rendering is blocked) it'll be applied at BeginFrame time, before rAF callbacks are executed. [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5BJSTl-FMGY Change-Id: If2c4c638f3f0faa7dab23e7e129c196357076fad Bug: 795381 Reviewed-on: https://chromium-review.googlesource.com/c/1408217 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625402}
Changed files
- third_party/blink/renderer/core/BUILD.gn
- third_party/blink/renderer/core/dom/document.cc
- third_party/blink/renderer/core/exported/web_view_impl.cc
- third_party/blink/renderer/core/frame/local_frame_view.cc
- third_party/blink/renderer/core/frame/local_frame_view.h
- third_party/blink/renderer/core/frame/local_frame_view_test.cc
- third_party/blink/renderer/core/loader/frame_loader.cc
- third_party/blink/renderer/core/page/scrolling/fragment_anchor.cc
- third_party/blink/renderer/core/page/scrolling/fragment_anchor.h
- third_party/blink/renderer/core/page/scrolling/fragment_anchor_test.cc
- third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
-
Move page scale factor out of RenderWidget::SynchronizeVisualProperties.
Changed by danakj - danakjohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:12:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0246bba0cd7b7d6616e0aeac4a3f38464e9af232 Comments
Move page scale factor out of RenderWidget::SynchronizeVisualProperties. The SynchronizeVisualProperties() method is called from the IPC handler to apply some of the IPC message. The code for page scale factor is moved out to the IPC handler to act on it directly. It is also called by a number of methods for tests, which apply various properties to the RenderWidget. Page scale is not ever changed by these test methods, so they do not depend on it being inside SynchronizeVisualProperties(). It is also also called from the screen metrics emulator, but since the emulator does not change the page scale factor, it also does not depend on this code being in SynchronizeVisualProperties(). The notification of the page scale factor change to each RenderFrameProxy is dramatically reordered with respect to the other properties of RenderWidget changing. This is okay because the notification is only to pass the value over IPC up to the browser and down to the child RenderWidget, so it does not depend on the ordering. This reduces the test-only method dependency footprint on the VisualProperties structure. Left a TODO about changing the routing of this page scale property to go blink->RenderView->RenderViewHost->{All RenderWidgets} instead of the current blink->RenderView->RenderWidget-> {All RenderFrameProxy->RenderWidgetHost->RenderWidgets} Other page-level properties could benefit from this path as well but are much trickier since they a) do not go through RenderFrameProxy today and instead seem to propagate through the browser code, which is good, except b) are treated identically in child RenderWidgets as in the main frame, whereas the page scale factor has clear behaviour differences for child RenderWidgets. So this could be useful for exploring and establishing this pattern. R=ajwong@chromium.org TBR=avi Change-Id: I4af9b114e729c26e8356e69ecb9569337d653cb3 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1427466 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#625401}
Changed files
- content/renderer/render_widget.cc
- content/renderer/render_widget.h
-
Improve session restore performance.
Changed by Eugene But - eugenebutohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 23:11:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ccf6be4686093ade39c87b4afc36cf95cceabca0 Comments
Improve session restore performance. Session restoration completion code was moved from didCommitNavigation to didStartProvisionalNavigation. This change will allow the user to start interacting with web contents without waiting until the first post-restore navigation is complete. There will be no committed URL until the first post-restore navigation is complete, but user should be able to load new pages and perform back forward navigations. Bug: 877671 Change-Id: Iceeeff857aee36bf4151f247815c0705ac377e73 Reviewed-on: https://chromium-review.googlesource.com/c/1407909 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625400}
Changed files
- ios/web/navigation/legacy_navigation_manager_impl.h
- ios/web/navigation/legacy_navigation_manager_impl.mm
- ios/web/navigation/navigation_manager_impl.h
- ios/web/navigation/navigation_manager_impl.mm
- ios/web/navigation/navigation_manager_impl_unittest.mm
- ios/web/navigation/wk_based_navigation_manager_impl.h
- ios/web/navigation/wk_based_navigation_manager_impl.mm
- ios/web/public/navigation_manager.h
- ios/web/web_state/ui/crw_web_controller.mm
- ios/web/web_state/web_state_unittest.mm
-
appcache: Move AppCacheFrontend from content/common to content/browser.
Changed by Victor Costan - pwnallohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:10:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1255f3c58bfae11962aed0aa9ead7874ae1250cb Comments
appcache: Move AppCacheFrontend from content/common to content/browser. AppCacheFrontend is only used in AppCache's browser-side implementation. Having it in content/common/appcache_interfaces.h is misleading, as it suggests that the class is shared with the renderer. Bug: 611938 Change-Id: I68865d63ee38841d59b61866664716c0ec8c2c39 Reviewed-on: https://chromium-review.googlesource.com/c/1429247 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#625399}
Changed files
- content/browser/BUILD.gn
- content/browser/appcache/appcache_frontend.h
- content/browser/appcache/appcache_frontend_proxy.h
- content/browser/appcache/appcache_group_unittest.cc
- content/browser/appcache/appcache_host.cc
- content/browser/appcache/appcache_host_unittest.cc
- content/browser/appcache/appcache_navigation_handle_core.h
- content/browser/appcache/appcache_request_handler_unittest.cc
- content/browser/appcache/appcache_storage_impl_unittest.cc
- content/browser/appcache/appcache_unittest.cc
- content/browser/appcache/appcache_update_job.cc
- content/browser/appcache/appcache_update_job_unittest.cc
- content/browser/appcache/appcache_url_request_job.cc
- content/browser/service_worker/service_worker_installed_script_loader.h
- content/common/appcache_interfaces.h
-
Remove Redraw call from RenderWidgetScreenMetricsEmulator.
Changed by danakj - danakjohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:10:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 30ad91688b7a9c9976cf00ead80a294157ff1796 Comments
Remove Redraw call from RenderWidgetScreenMetricsEmulator. This redraw used to be if (params.needs_resize_ack) delegate_->Redraw(); Which was there to cause a paint (pre compositing) or a composite (post compositing) in order to send an ack after a resize. We no longer need to make this redraw happen to get the appropriate ACK as 664698a679a27ce4e converted us to ACKing to SynchronizeVisualProperties (which replaced Resize) directly, and now ACKing is tied to surface synchronization and local surface IDs. R=avi@chromium.org Change-Id: Id1c0e3e5534b41767ce36fb2298af56a639fa677 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1431213 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625398}
Changed files
- content/renderer/devtools/render_widget_screen_metrics_emulator.cc
- content/renderer/devtools/render_widget_screen_metrics_emulator_delegate.h
- content/renderer/render_widget.cc
- content/renderer/render_widget.h
-
Added reporting info on chrome://management for desktop
Changed by Yann Dago - ydagoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:04:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ed5d04cf3a36f6956ef9eac17af165d092804c25 Comments
Added reporting info on chrome://management for desktop Message added under Browsing Reporting section on Desktop with "Chrome Reporting Extension (cloud or OnPrem)" installed for each of the following policies: * report_machine_id_data (true for cloud reporting) * report_user_id_data (true for cloud reporting) * report_version_data (true for cloud reporting) * report_policy_data (true for cloud reporting) * report_extensions_data (true for cloud reporting) * report_safe_browsing_data (true for cloud reporting) * report_system_telemetry_data * report_user_browsing_data Bug: 921698 Change-Id: Icccf744acb775be9723e38b61829ffb42fc2053c Reviewed-on: https://chromium-review.googlesource.com/c/1423116 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625397}
Changed files
- chrome/browser/resources/management/management.html
- chrome/browser/resources/management/management.js
- chrome/browser/ui/webui/management_ui.cc
- chrome/browser/ui/webui/management_ui_handler.cc
- chrome/browser/ui/webui/management_ui_handler.h
- components/management_strings.grdp
-
Fix gn check for //chrome/browser/safe_browsing:safe_browsing
Changed by Daniel Rubery - druberyohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:04:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b4754fc159b2454e05de85b33db55f8799731b0c Comments
Fix gn check for //chrome/browser/safe_browsing:safe_browsing This CL adds a number of deps to the target //chrome/browser/safe_browsing:safe_browsing It also adds the safe_browsing target to allow_circular_includes_from for //chrome/browser:browser, since these are tightly coupled. The remaining gn check errors are only due to circular dependencies with: //chrome/browser/ui:ui //chrome/browser/extensions:extensions Both of which will be fixed in future CLs Bug: 919683 Change-Id: Iec1c1737aceef070aca082260b587dc96250bc16 Reviewed-on: https://chromium-review.googlesource.com/c/1428480 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#625396}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/safe_browsing/BUILD.gn
-
Roll src-internal 6aa6bc44417e..5f9f137868bd (2 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 23:02:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fd81d8d0f0c3c04315030485cb8f1efe0ded9614 Comments
Roll src-internal 6aa6bc44417e..5f9f137868bd (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6aa6bc44417e..5f9f137868bd Created with: gclient setdep -r src-internal@5f9f137868bd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icce4c91cf17d385e89919647ab3b5ca4332b44eb Reviewed-on: https://chromium-review.googlesource.com/c/1431832 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625395}
Changed files
- DEPS
-
Re-enable app shim code signature checking with fixes.
Changed by Sidney San Martín - sdyohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 23:00:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2007aaf2b18b3e2a9d1b3233bc89d41b138fba14 Comments
Re-enable app shim code signature checking with fixes. Two changes: - Remove the IS_OFFICIAL_BUILD check (don't require official builds to be signed for app shims to run at all). - Construct a custom designated requirement to verify the app shim, which checks its identifier and that its certificate matches the browser's. For now, keep failures log-only. This reverts commit add2f7a11d13cf857b95ccb575afcd5d66690532. Bug: 913362, 923612 Change-Id: I1c536e2172519dbf8e5b36a2dd9b5f1b26fb8302 Reviewed-on: https://chromium-review.googlesource.com/c/1427385 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Auto-Submit: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#625394}
Changed files
- base/mac/foundation_util.h
- base/mac/foundation_util.mm
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
-
Automated Commit: LKGM 11631.0.0 for chromeos.
Changed by 3su6n15k.default@developer.gserviceaccount.com - 3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com Changed at Wednesday, 23-Jan-19 22:54:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4793abd38544dfc631d694b6eb1a393af15a720c Comments
Automated Commit: LKGM 11631.0.0 for chromeos. BUG=762641 TBR=michaelpg@google.com Change-Id: Ia4ebed15d53163eace05eaa2997a8111e9f0a6ff Reviewed-on: https://chromium-review.googlesource.com/c/1429199 Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#625393}
Changed files
- chromeos/CHROMEOS_LKGM
-
Roll src/third_party/perfetto a824c339c217..3eabfafdae1e (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 22:50:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3a277641d850719d2a6974fad2c55caceb5df546 Comments
Roll src/third_party/perfetto a824c339c217..3eabfafdae1e (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/a824c339c217..3eabfafdae1e git log a824c339c217..3eabfafdae1e --date=short --no-merges --format='%ad %ae %s' 2019-01-23 lalitm@google.com Merge "trace_processor: add support for polled oom_score_adj" 2019-01-23 treehugger-gerrit@google.com Merge "profiling: Log on pipeline stall." Created with: gclient setdep -r src/third_party/perfetto@3eabfafdae1e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1bda3ef94d7f99044c6e5f7116410da7a27d5539 Reviewed-on: https://chromium-review.googlesource.com/c/1431455 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625392}
Changed files
- DEPS
-
assistant: cleanup dead code
Changed by Xiaohui Chen - xiaohuicohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 22:46:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5277f834ea984e102970cf129c0f0152040d185b Comments
assistant: cleanup dead code Bug: None Test: locally build and run Change-Id: Ifdb6e31b926da18c6da47e7a2a5540f58e9fa9a9 Reviewed-on: https://chromium-review.googlesource.com/c/1423620 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#625391}
Changed files
- chrome/browser/resources/settings/google_assistant_page/google_assistant_browser_proxy.js
- chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
- chrome/browser/resources/settings/google_assistant_page/google_assistant_page.js
- chrome/test/data/webui/settings/google_assistant_page_test.js
-
Use FireWebUIListener() a little more
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:45:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 81865e4b44c649a05a0e201acc7c2135e5fd908a Comments
Use FireWebUIListener() a little more FireWebUIListener(name, ...) is essentially an alias for: CallJavascriptFunction("cr.webUIListenerCallback", base::Value(name), ...); Using it reduces the amount of times we paste "cr.webUIListenerCallback" and generally reduces the amount of parallel paths for notifying running web UI pages. R=aee@chromium.org BUG=none Change-Id: Id3ee2622949c0fd1bba9705655de4cb0faf386f4 Reviewed-on: https://chromium-review.googlesource.com/c/1431293 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625390}
Changed files
- chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc
- chrome/browser/ui/webui/settings/font_handler.cc
- chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
- chrome/browser/ui/webui/settings/settings_import_data_handler.cc
- chrome/browser/ui/webui/settings/site_settings_handler.cc
-
Input Delay: Exclude pointerCancel and pointerCausedUaAction
Changed by Nicolas Pena - npmohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:39:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e1d190a1f50525191ee743352fac3a6158389dd6 Comments
Input Delay: Exclude pointerCancel and pointerCausedUaAction This CL resets the pending pointerdown information in InteractiveDetector when a pointerCancel or pointerCausedUaAction are detected because those indicate that scrolls have happened. This CL also changes the UMA and UKM metrics affected by this change by adding a 2 at the end of the histogram names. Bug: 924278 Change-Id: I4b42e9478c74d9ba42b77170800b6267151c91e8 Reviewed-on: https://chromium-review.googlesource.com/c/1427924 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#625389}
Changed files
- chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
- chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
- chrome/browser/page_load_metrics/observers/histogram_suffixes.cc
- chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc
- chrome/browser/page_load_metrics/observers/signed_exchange_page_load_metrics_observer.cc
- chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
- chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
- third_party/blink/renderer/core/exported/web_view_test.cc
- third_party/blink/renderer/core/loader/interactive_detector.cc
- tools/metrics/histograms/histograms.xml
- tools/metrics/ukm/ukm.xml
-
Remove a nullptr check in PrintViewManagerBase::OnPrintSettingsDone().
Changed by Lei Zhang - thestigohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:35:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7cf8040b7cc3c7cb920bce7b634a55472aac0938 Comments
Remove a nullptr check in PrintViewManagerBase::OnPrintSettingsDone(). The PrinterQuery being passed in is never nullptr, since the caller is written as: printer_query->SetSettings(..., printer_query). Change-Id: I97bdd100743e35b967de8b34df6bbfed2bb80216 Reviewed-on: https://chromium-review.googlesource.com/c/1428406 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625388}
Changed files
- chrome/browser/printing/print_view_manager_base.cc
-
Deflake PluginMetricsProviderTest.RecordCurrentStateWithDelay.
Changed by Alexei Svitkine - asvitkineohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:35:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e5e37026866d5b3daf53cb578fba661e893166dd Comments
Deflake PluginMetricsProviderTest.RecordCurrentStateWithDelay. This test is flaky on platforms that where Sleep(delta) isn't guaranteed to be in TimeTicks (e.g. on Mac, it's in base::Time). Use base::test::ScopedTaskEnvironment::MainThreadType::MOCK_TIME instead. Also, cleans up some APIs and adds a comment to the Sleep() API. Bug: 915672 Change-Id: Ib539c0d06a217dfdb9ee6f7411e885d6975438a9 Reviewed-on: https://chromium-review.googlesource.com/c/1427927 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#625387}
Changed files
- base/threading/platform_thread.h
- chrome/browser/metrics/plugin_metrics_provider.cc
- chrome/browser/metrics/plugin_metrics_provider.h
- chrome/browser/metrics/plugin_metrics_provider_unittest.cc
-
WebUI Dark Mode: rework link and error colors on Extensions page
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:28:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a7bc65893d43711ac82aef2b616e02fe1ce73a31 Comments
WebUI Dark Mode: rework link and error colors on Extensions page Pretty much everything should use --cr-link-color, which magically changes based on light/dark mode. There was also just a ton of duplicated a[href] rules, which I instead added to shared_style.html (and verified each place I deleted from used include="shared-style"). Screenshots: https://imgur.com/a/kaT6MJc R=dpapad@chromium.org BUG=883049 Change-Id: I00440e1bcfaae21b31763f51d65385729ba7fab9 Reviewed-on: https://chromium-review.googlesource.com/c/1429379 Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625386}
Changed files
- chrome/browser/resources/md_extensions/detail_view.html
- chrome/browser/resources/md_extensions/error_page.html
- chrome/browser/resources/md_extensions/host_permissions_toggle_list.html
- chrome/browser/resources/md_extensions/item.html
- chrome/browser/resources/md_extensions/runtime_host_permissions.html
- chrome/browser/resources/md_extensions/shared_style.html
- chrome/browser/resources/md_extensions/shared_vars.html
- chrome/browser/resources/md_extensions/sidebar.html
-
Remove --ash-enable-mirrored-screen flag
Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:26:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 43a2708a05613f074859bc2caeabedffda19f7ad Comments
Remove --ash-enable-mirrored-screen flag Bug: 924322 Test: None Change-Id: Ief0e8239031f82984c48f08dbf332584f67c5b48 Reviewed-on: https://chromium-review.googlesource.com/c/1428839 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#625385}
Changed files
- ash/display/root_window_transformers.cc
- ash/public/cpp/ash_switches.cc
- ash/public/cpp/ash_switches.h
- chrome/browser/about_flags.cc
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
-
Revert "Get the CertificateInfo of the current exe from ModuleDatabase"
Changed by Reid Kleckner - rnkohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:24:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e53623ab93faa72f96d18f586be034ed27b89d5d Comments
Revert "Get the CertificateInfo of the current exe from ModuleDatabase" This reverts commit 5a0921ab569ee10d89eca68406bb262f816de7cb. Reason for revert: Seems to cause ThirdPartyConflictsManagerTest.InitializeUpdaters to fail in official builds. Original change's description: > Get the CertificateInfo of the current exe from ModuleDatabase > > The ThirdPartyConflictsManager needs the CertificateInfo of the current > executable to identify third-party DLLs. It used to create it itself, > but that information is already available from the ModuleDatabase. > > Bug: 921746 > Change-Id: I3d57d289f17bac563fed498e59f48c3bbc9f4f64 > Reviewed-on: https://chromium-review.googlesource.com/c/1426061 > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624901} TBR=pmonette@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 921746, 852295 Change-Id: I74a40d6c9af0c41c487e6201581230d537c56daa Reviewed-on: https://chromium-review.googlesource.com/c/1432233 Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#625384}
Changed files
- chrome/browser/conflicts/third_party_conflicts_manager_win.cc
- chrome/browser/conflicts/third_party_conflicts_manager_win.h
-
Roll src/third_party/depot_tools f7971436824d..695e7cf35258 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 22:22:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 55f3798fca9cd6b473a5ca2cdc07c8188cd7d6d9 Comments
Roll src/third_party/depot_tools f7971436824d..695e7cf35258 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f7971436824d..695e7cf35258 git log f7971436824d..695e7cf35258 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@695e7cf35258 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I02676c5883f16255d66f67f76a39ceb0711992c8 Reviewed-on: https://chromium-review.googlesource.com/c/1431454 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625383}
Changed files
- DEPS
-
Update edit-URL suggestion icons from blue to grey
Changed by Matthew Jones - mdjonesohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:20:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ac5d6bc59b8e24f4e6b2a8e3fe16d5fabd04d1ea Comments
Update edit-URL suggestion icons from blue to grey Bug: 901952 Change-Id: If2338a9904c0d0ff5f831769d1549001adcb0b3b Reviewed-on: https://chromium-review.googlesource.com/c/1431112 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#625382}
Changed files
- chrome/android/java/res/values-v17/styles.xml
-
Reduce horizontal padding from 16 to 8
Changed by Lakshmi Kumar Dabbiru - dlkumarohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 22:15:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3a100e8aacb0f48786cad5889b496ed07052c09c Comments
Reduce horizontal padding from 16 to 8 As per UX review Screenshots with change - https://screenshot.googleplex.com/is30KnFrqJv - https://screenshot.googleplex.com/X9RqOSW4PVz Bug: 913646 Change-Id: I052ede08da6aaf7d994e48e69f502e182f71a878 Reviewed-on: https://chromium-review.googlesource.com/c/1427979 Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Cr-Commit-Position: refs/heads/master@{#625381}
Changed files
- chrome/android/java/res/values/dimens.xml
-
mac: bump deployment target to 10.10
Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:10:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bd6d39d548edd2afa4f00d7aed33ce92e8adf13a Comments
mac: bump deployment target to 10.10 This change: 1) Marks uses of launch_data_t as deprecated with no replacement (so ignored); 2) Marks uses of the NSObject accessibility API as deprecated to be replaced (per bug 921109) 3) Replaces one use of CWInterface with a corresponding use of CWWiFiClient, and marks another as ignored for now; 4) Replaces some LaunchServices invocations with their new equivalents; 5) Marks GTM to ignore deprecation warnings, since the GTM dependency will go away soon anyway; 6) Fixes how blink refers to NSCalendarIdentifierGregorian; 7) Replaces some uses of NSRunAlertPanel with explicit constructions of NSAlert; 8) Bumps the deployment target to 10.10 An earlier version of this change attempted to incrementally upgrade, but many of the replacement APIs are themselves only @available on 10.10, so it proved to be significantly uglier. Bug: 841631 Change-Id: Ic6e96efbb84ba0a077eda3528b452137d64f5f02 Reviewed-on: https://chromium-review.googlesource.com/c/1407177 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625380}
Changed files
- base/mac/launchd.cc
- base/mac/mac_util.mm
- base/mac/scoped_launch_data.h
- build/config/mac/mac_sdk.gni
- chrome/browser/app_controller_mac.mm
- chrome/browser/media/router/discovery/discovery_network_list_wifi_mac.mm
- chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
- chrome/browser/shell_integration_mac.mm
- chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.mm
- chrome/browser/web_applications/components/web_app_shortcut_mac.mm
- chrome/common/importer/firefox_importer_utils_mac.mm
- chrome/common/mac/service_management.mm
- components/download/quarantine/common_mac.h
- components/download/quarantine/common_mac.mm
- components/download/quarantine/quarantine_mac.mm
- components/download/quarantine/test_support_mac.mm
- components/storage_monitor/image_capture_device_manager_unittest.mm
- components/wifi/wifi_service_mac.mm
- content/browser/accessibility/accessibility_tree_formatter_mac.mm
- content/browser/accessibility/browser_accessibility_cocoa.mm
- content/browser/accessibility/browser_accessibility_cocoa_browsertest.mm
- content/browser/accessibility/browser_accessibility_mac_unittest.mm
- content/browser/renderer_host/render_widget_host_view_cocoa.mm
- content/browser/web_contents/web_contents_view_mac_unittest.mm
- content/shell/browser/shell_javascript_dialog_mac.mm
- content/shell/browser/shell_login_dialog_mac.mm
- remoting/host/installer/mac/BUILD.gn
- remoting/host/installer/mac/uninstaller/remoting_uninstaller_app.mm
- services/device/geolocation/wifi_data_provider_mac.mm
- testing/iossim/iossim.mm
- third_party/blink/renderer/platform/text/locale_mac.mm
- third_party/breakpad/BUILD.gn
- third_party/google_toolbox_for_mac/BUILD.gn
- third_party/mozilla/NSWorkspace+Utils.h
- third_party/mozilla/NSWorkspace+Utils.m
- third_party/mozilla/README.chromium
- ui/views/controls/tabbed_pane/tabbed_pane_accessibility_mac_unittest.mm
- ui/views/widget/ax_native_widget_mac_unittest.mm
- ui/views/widget/native_widget_mac_unittest.mm
- ui/views_bridge_mac/alert.mm
- ui/views_bridge_mac/bridged_native_widget_impl.mm
-
cpu: replace use of the reserved _xgetbv identifier with xgetbv.
Changed by Jordan Rupprecht - rupprechtohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 22:08:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c8970c8ff8d07e8242f70f9ca72fa0a9f7be879f Comments
cpu: replace use of the reserved _xgetbv identifier with xgetbv. Clang built from trunk now implements _xgetbv, causing errors as it is now redefined. Modeled after https://crrev.com/c/1414858 which is a similar fix to v8. TEST=built locally with clang from trunk Change-Id: Ie1c242ae6b9ae34b695a512991e90a74dfafdedc Reviewed-on: https://chromium-review.googlesource.com/c/1431352 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Jordan Rupprecht <rupprecht@google.com> Cr-Commit-Position: refs/heads/master@{#625379}
Changed files
- base/cpu.cc
-
Fixing use_r8 flag
Changed by Sam Maier - smaierohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:06:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 89481a9c455f362757611b7ad8988486f68625b7 Comments
Fixing use_r8 flag Change-Id: Idc5b8baf277b02a4adf0ff4835f45ea0a7b0f513 Reviewed-on: https://chromium-review.googlesource.com/c/1431233 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#625378}
Changed files
- build/config/android/internal_rules.gni
-
Extend the expiry of several download metrics.
Changed by Xing Liu - xingliuohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 22:04:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dcdf082d22fe38390738c0ed4535d8264b1b7b05 Comments
Extend the expiry of several download metrics. This CL extends expiry of several metrics related to download and media. Useful for implementing new feature: Android.DownloadManager.ViewRetentionTime.Video Android.DownloadManager.ViewRetentionTime.Audio Download.DeleteRetentionTime.Video Download.DeleteRetentionTime.Audio Important system health metrics: Download.ParallelDownloadAddStreamSuccess Download.ParallelDownloadRequestCount Bug: 918380,918378 Change-Id: Id597b9a8ae3ed72f1c0b0cd95ef36df4b5467d8d Reviewed-on: https://chromium-review.googlesource.com/c/1428741 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625377}
Changed files
- tools/metrics/histograms/histograms.xml
-
AW: run_cts auto-determines device arch
Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:59:11 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2b105e4e5d7dafed6bb70861b7eac793d25e0224 Comments
AW: run_cts auto-determines device arch This adds proper logic to run_cts.py to auto-determine the device architecture, and to throw an error if the device architecture is not supported. This also adds unit tests (and configures them to run on presubmit). Although this is not a significant improvement (we still only support "arm64"), this gives fast, clear feedback when the device is unsupported (e.g., emulators), and the logic should generalize as we support more architectures. This also adds logging (which will be visible with --verbose, to aid debugging). This does minor refactoring in the script, to plumb arch where it's used instead of reassigning to args.arch (which should help with testability in the future). R=aluo@chromium.org Bug: 922854 Test: vpython android_webview/tools/run_cts_test.py Test: android_webview/tools/run_cts.py (script still runs) Change-Id: I6528ab836f30b5885ede59853acaeee69de26fa2 Reviewed-on: https://chromium-review.googlesource.com/c/1419840 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625376}
Changed files
- android_webview/tools/PRESUBMIT.py
- android_webview/tools/run_cts.py
- android_webview/tools/run_cts_test.py
-
Reland "Don't record first filling result for sign-in forms"
Changed by Dominic Battre - battreohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:54:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 81e6f26a234074b9fb26044f8a4d21f4b08cbbd0 Comments
Reland "Don't record first filling result for sign-in forms" This reverts commit c13cea62d0816ae1ea2c8184e96f77fd459d478e. Reason for revert: Fixed memory problem Original change's description: > Revert "Don't record first filling result for sign-in forms" > > This reverts commit 34d69265b1f1f5a3c7739827a0b7e05bfc928e08. > > Reason for revert: breaks msan > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/14500 > > Original change's description: > > Don't record first filling result for sign-in forms > > > > The new form parser may decide that a form has no current-password element, but > > only new-password / confirmation elements. In this case, the parser sets the > > unique_renderer_id to 'undefined'. The credentials will be sent to the renderer > > for filling via manual fallback but the renderer won't ever fill (as there is > > no password element defined for filling. > > > > This CL ensures that this case does not get recorded as a failure to fill. This > > is important because we record two metrics about the first fill attempt: > > PasswordManager.FirstWaitForUsernameReason and > > PasswordManager.FirstRendererFillingResult For websites that have a sign-up > > form followed by a sign-in form, we don't want to record the failure to fill on > > the sign-up form. > > > > Bug: 918846 > > Change-Id: I79e9a73ae3573a81e121eaa483e0ecef0889184f > > Reviewed-on: https://chromium-review.googlesource.com/c/1422018 > > Commit-Queue: Dominic Battré <battre@chromium.org> > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#625178} > > TBR=battre@chromium.org,dvadym@chromium.org > > Change-Id: I3c68004b67b5fcc65511c611c2d205297596e782 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 918846 > Reviewed-on: https://chromium-review.googlesource.com/c/1430581 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625227} TBR=dvadym@chromium.org,jam@chromium.org Bug: 918846 Change-Id: I671bc4674f1660920eae0c73d5b1b01b49311383 Reviewed-on: https://chromium-review.googlesource.com/c/1431172 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#625375}
Changed files
- chrome/renderer/autofill/password_autofill_agent_browsertest.cc
- components/autofill/content/renderer/password_autofill_agent.cc
- components/password_manager/core/browser/password_form_filling.cc
- components/password_manager/core/browser/password_form_filling_unittest.cc
-
WebUI Dark Mode: fix settings side bar icon color
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:49:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8d1b2c82abf3e0c65bdd6f3113def751a511dc52 Comments
WebUI Dark Mode: fix settings side bar icon color In dark mode, the *icon* color differs slightly from the *text* color. Screenshots: https://imgur.com/a/asWpYhY Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g48a476f4a5_2_42 R=dpapad@chromium.org BUG=883049 Change-Id: I67521d7505f1b27f212b4813c853074f88c28971 Reviewed-on: https://chromium-review.googlesource.com/c/1429196 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625374}
Changed files
- chrome/browser/resources/settings/settings_menu/settings_menu.html
- chrome/browser/resources/settings/settings_vars_css.html
-
[NTP] Better dark theme detection when dark mode enabled
Changed by Kristi Park - kristiparkohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:43:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e3990ef6428ce19da323d765097b8d8163706034 Comments
[NTP] Better dark theme detection when dark mode enabled https://crrev.com/c/1427543 fixed the case where a custom background is set and dark mode is disabled. However, this does not cover the case where both a custom background and theme are not set. Improve dark theme detection by only checking for dark mode if no custom background or theme is set. Otherwise, default to the regular dark theme detection. Bug: 923797 Change-Id: If4f8863cc2a29ed3f8908bbc9d89a7b5ad92a336 Reviewed-on: https://chromium-review.googlesource.com/c/1428440 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625373}
Changed files
- chrome/browser/resources/local_ntp/local_ntp.js
-
[AF] Fix the ios test fail
Changed by Parastoo Geranmayeh - parastoogohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:42:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f4aa7d6669e5858dc6e8ecece6fe70004b3f8e36 Comments
[AF] Fix the ios test fail Wait for the OnPersonalDataFinishedProfileTasks, rather than OnPersonalDataChanged. Rename the class accordingly. Bug: 919967 Change-Id: I6e1808f67c384d99cb4f88d33f6d5ffb7d83d972 Reviewed-on: https://chromium-review.googlesource.com/c/1427792 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#625372}
Changed files
- ios/chrome/browser/autofill/autofill_controller_unittest.mm
- ios/chrome/browser/ui/settings/BUILD.gn
- ios/chrome/browser/ui/settings/autofill_credit_card_table_view_controller_unittest.mm
- ios/chrome/browser/ui/settings/autofill_profile_edit_table_view_controller_unittest.mm
- ios/chrome/browser/ui/settings/autofill_profile_table_view_controller_unittest.mm
- ios/chrome/browser/ui/settings/personal_data_manager_data_changed_observer.cc
- ios/chrome/browser/ui/settings/personal_data_manager_data_changed_observer.h
- ios/chrome/browser/ui/settings/personal_data_manager_finished_profile_tasks_waiter.cc
- ios/chrome/browser/ui/settings/personal_data_manager_finished_profile_tasks_waiter.h
-
WebUI Dark Mode: fix title text color
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:40:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 79a39f9472afbc8fdad2506bfb426e2c6d06d908 Comments
WebUI Dark Mode: fix title text color This mainly affects section titles and subpage titles in settings. R=dpapad@chromium.org BUG=883049 Change-Id: I614cf44adb70becc5ef00479bd19c5372c4929c4 Reviewed-on: https://chromium-review.googlesource.com/c/1429661 Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625371}
Changed files
- chrome/browser/resources/settings/settings_page/settings_subpage.html
- chrome/browser/resources/settings/settings_shared_css.html
- ui/webui/resources/cr_elements/shared_vars_css.html
-
Ignore fixed and sticky elements in JankTracker.
Changed by Steve Kobes - skobesohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:39:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1e198e79fd1e37f2d1a90b8cde2d2029ccabbeec Comments
Ignore fixed and sticky elements in JankTracker. These were generating spurious janks on scroll, because the visual rect moves. (The old / new rects are mapped into the viewport's coordinate space, but both of these mappings use the updated scroll offset.) This is a temporary fix until we figure out a better way to detect real layout janks in fixed or sticky elements. Bug: 581518 Change-Id: I405c0933eb3cd52c135e97db55cb72c32dedc1a6 Reviewed-on: https://chromium-review.googlesource.com/c/1430589 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#625370}
Changed files
- third_party/blink/renderer/core/layout/jank_tracker.cc
- third_party/blink/renderer/core/layout/jank_tracker_test.cc
-
[Autofill] Added LocalCardMigrationStrikeDB
Changed by Anne Lim - annelimohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:38:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 40fd55335674f9c5232e0905d459d53636dde626 Comments
[Autofill] Added LocalCardMigrationStrikeDB Intruduced LocalCardMigrationStrikeDatabase and added an AddStrikes and RemoveStrikes functions, which allows multiple strikes to be added at once. Bug: 920385 Change-Id: Ifbfad49c9d67570098b0e71d7a3fda1800563413 Reviewed-on: https://chromium-review.googlesource.com/c/1422701 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#625369}
Changed files
- components/autofill/core/browser/BUILD.gn
- components/autofill/core/browser/credit_card_save_strike_database.cc
- components/autofill/core/browser/credit_card_save_strike_database.h
- components/autofill/core/browser/local_card_migration_strike_database.cc
- components/autofill/core/browser/local_card_migration_strike_database.h
- components/autofill/core/browser/local_card_migration_strike_database_unittest.cc
- components/autofill/core/browser/strike_database.cc
- components/autofill/core/browser/strike_database.h
- components/autofill/core/browser/strike_database_integrator_base.cc
- components/autofill/core/browser/strike_database_integrator_base.h
- components/autofill/core/browser/test_local_card_migration_strike_database.cc
- components/autofill/core/browser/test_local_card_migration_strike_database.h
-
Roll src/third_party/skia 08b0b7fd5bd5..114b5af0e8cc (3 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 21:36:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 87f9044e48264094ff77903945f3fafabf77587f Comments
Roll src/third_party/skia 08b0b7fd5bd5..114b5af0e8cc (3 commits) https://skia.googlesource.com/skia.git/+log/08b0b7fd5bd5..114b5af0e8cc git log 08b0b7fd5bd5..114b5af0e8cc --date=short --no-merges --format='%ad %ae %s' 2019-01-23 herb@google.com Fix bookmaker 2019-01-23 michaelludwig@google.com Increase tolerance in rectilinear quad detection 2019-01-23 herb@google.com Add getTypefaceOrDefault and refTypefaceOrDefault Created with: gclient setdep -r src/third_party/skia@114b5af0e8cc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:923946 TBR=djsollen@chromium.org Change-Id: Ie46dc2488dbfaf8cfd2546987c0a1cce374d712d Reviewed-on: https://chromium-review.googlesource.com/c/1431453 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625368}
Changed files
- DEPS
-
[NTP] Support dark mode for add/edit custom link dialog
Changed by Kristi Park - kristiparkohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:35:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 593c1eef6289a83dd768b09e0c1f42c6f38d8863 Comments
[NTP] Support dark mode for add/edit custom link dialog Screenshots: https://screenshot.googleplex.com/FqstoCzbOE2.png https://screenshot.googleplex.com/X0oy2QqeDt9.png https://screenshot.googleplex.com/tH0us5zzBJM.png Bug: 919961, 923988 Change-Id: I00bcf543284fb83a2565e9ff73701a07ac279dca Reviewed-on: https://chromium-review.googlesource.com/c/1428740 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625367}
Changed files
- chrome/browser/resources/local_ntp/custom_backgrounds.css
- chrome/browser/resources/local_ntp/custom_links_edit.css
- chrome/browser/resources/local_ntp/custom_links_edit.js
- chrome/browser/resources/local_ntp/local_ntp.css
- chrome/browser/resources/local_ntp/local_ntp.html
- chrome/browser/resources/local_ntp/local_ntp.js
- chrome/test/data/local_ntp/local_ntp_browsertest.html
-
Remove ash-enable-cursor-motion-blur from about:flags
Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:32:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2b7906e547cab4cd26ec472edb5005e4bf0140df Comments
Remove ash-enable-cursor-motion-blur from about:flags Bug: 924390 Test: None Change-Id: I2aa1f8dc832bfbc1a7ce8ff1154adedac55a2af1 Reviewed-on: https://chromium-review.googlesource.com/c/1429059 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#625366}
Changed files
- chrome/browser/about_flags.cc
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
-
Added finch experiment to control leveldb_proto migration
Changed by Salvador Guerrero - salgohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:31:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7ccefb222a6701f6b0a8925f9442a8c8fc95a8e1 Comments
Added finch experiment to control leveldb_proto migration Modified the SharedProtoDatabaseClientList::ShouldUseSharedDB function to let us migrate each client to SharedProtoDatabase with a finch experiment Bug: 870813 Change-Id: Ife62d81a719387ec8fc0866191b0db5645707728 Reviewed-on: https://chromium-review.googlesource.com/c/1406296 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#625365}
Changed files
- components/leveldb_proto/BUILD.gn
- components/leveldb_proto/internal/leveldb_proto_feature_list.cc
- components/leveldb_proto/internal/leveldb_proto_feature_list.h
- components/leveldb_proto/internal/shared_proto_database_client_list_unittest.cc
- components/leveldb_proto/public/shared_proto_database_client_list.cc
-
Add src-side configs for android-cts network test trybot.
Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:30:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d8e5a29815824030d7ba8a7f2d08bb2cd73b281e Comments
Add src-side configs for android-cts network test trybot. Bug: 907899 Change-Id: Ic300c8d4120a581e2ea756a88b2498e5f861064c Reviewed-on: https://chromium-review.googlesource.com/c/1428819 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#625364}
Changed files
- infra/config/global/cr-buildbucket.cfg
- infra/config/global/luci-milo.cfg
- tools/mb/mb_config.pyl
-
cros: Migrate discover away from prefixed-based JS calls
Changed by Jacob Dufault - jdufaultohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:29:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 25c4a399977bf8c9e0a46d80d6abe7f7845807ce Comments
cros: Migrate discover away from prefixed-based JS calls Bug: 908498 Change-Id: I763088c5a8f6eb065c563ae269e6ec24955aa1fc Reviewed-on: https://chromium-review.googlesource.com/c/1351688 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#625363}
Changed files
- chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
- chrome/browser/ui/webui/chromeos/login/base_webui_handler.h
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
-
Hook up OOPIF printing for Android.
Changed by Lei Zhang - thestigohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:29:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fe436d6b0e81dd79d5e36dc5bfea57172ea5c865 Comments
Hook up OOPIF printing for Android. Initialize printing on Android the same way as other platforms, instead of in TabAndroid::Print(). By calling printing::InitializePrinting() like other platforms, the PDF compositor will be created as needs. Also implement PrintCrossProcessSubframe() in TabWebContentsDelegateAndroid to redirect the subframe print request, since the Browser class does not exist on Android. BUG=890417 Change-Id: I7195cf2afe2560dd56a56b5a769acf9e51bbb41b Reviewed-on: https://chromium-review.googlesource.com/c/1420302 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Wei Li <weili@chromium.org> Reviewed-by: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625362}
Changed files
- chrome/browser/android/tab_android.cc
- chrome/browser/android/tab_web_contents_delegate_android.cc
- chrome/browser/android/tab_web_contents_delegate_android.h
- chrome/browser/ui/tab_helpers.cc
-
[Autofill Assistant] Split DetailsCoordinator into Coordinator + ViewBinder.
Changed by Jordan Demeulenaere - jdemeulenaereohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:27:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 709b1fd9d4a44e69915e67ae4f970d09456744a4 Comments
[Autofill Assistant] Split DetailsCoordinator into Coordinator + ViewBinder. Change-Id: I3e9579e7e0fdf3bb90e1a6d806045a6a1207a230 Reviewed-on: https://chromium-review.googlesource.com/c/1430009 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#625361}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/details/AssistantDetailsCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/details/AssistantDetailsViewBinder.java
- chrome/android/java_sources.gni
-
[iOS] Fix FullscreenModel::UpdateDisabledCounterForContentHeight().
Changed by Kurt Horimoto - kkhorimotoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:27:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f2e0092d2babb1539ab688d0678a3cc509c4b103 Comments
[iOS] Fix FullscreenModel::UpdateDisabledCounterForContentHeight(). This CL updates UpdateDisabledCounterForContentHeight()'s implementation in two ways: - Accounts for the case when the FullscreenProvider is disabled and the scroll view may have been resized to a shorter height despite the content being fully visible on screen. - Updates to a <= check so that fullscreen is disabled when the content fits the scroll view exactly. Bug: 914347 Change-Id: I5d2c6e3ce09d25552de0f1071785d29078162377 Reviewed-on: https://chromium-review.googlesource.com/c/1423092 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625360}
Changed files
- ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
- ios/chrome/browser/ui/fullscreen/fullscreen_model.h
- ios/chrome/browser/ui/fullscreen/fullscreen_model.mm
- ios/chrome/browser/ui/fullscreen/fullscreen_model_unittest.mm
- ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm
-
Update Chrome Cloud Reporting test
Changed by Owen Min - zminohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:26:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a689341a59708267a3ec7e343b1edfe2f95d7995 Comments
Update Chrome Cloud Reporting test 1) Use raw string to avoid multiple escapes. 2) Add tests for plugins and signed in user data. 3) Add slash and quote in the test data to make sure they can be escaped properly by the report helper. Bug: 924645 Change-Id: I00d6166d967d8ebae82ac8bba5cc698b3eb2e418 Reviewed-on: https://chromium-review.googlesource.com/c/1431335 Reviewed-by: Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625359}
Changed files
- chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc
-
Omnibox: Steady State Elisions - Stop abusing user_input_in_progress.
Changed by Tommy C. Li - tommycliohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:25:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 568f2604719ccd32582561b5d08539fcda8fedfe Comments
Omnibox: Steady State Elisions - Stop abusing user_input_in_progress. Currently, when Steady State Elisions is on, and the user unelides the URL, we put the full URL into the user text. This was convenient, but has some unintended consequences. Namely: 1) user_input_in_progress() as a boolean state becomes confusing, as sometimes it means the user has edited the URL, and sometimes it means the the user has merely unelided the URL. 2) Consequently, in many places in the code, we check if user input in progress AND if the user has meaningfully edited the URL away from the full URL text. 3) That's not obvious to non-omnibox owners, so it creates bugs like the one linked below. This CL changes how unelision works so it only updates the View's text and leaves the model's user-text alone. It no longer sets user_input_in_progress to true for mere unelision. This allows us to clean up fair number of callsites and puts the nail in the coffin for the below linked bug too. Bug: 921777 Change-Id: I9d113649f50c0bfafa1d112002add577e05928f7 Reviewed-on: https://chromium-review.googlesource.com/c/1427244 Reviewed-by: manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#625358}
Changed files
- chrome/browser/ui/views/omnibox/omnibox_view_views.cc
- chrome/browser/ui/views/omnibox/omnibox_view_views.h
- chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
- components/omnibox/browser/omnibox_edit_model.cc
- components/omnibox/browser/omnibox_edit_model_unittest.cc
- components/omnibox/browser/test_omnibox_view.cc
-
Roll src/third_party/pdfium 56250c3ee3c0..3dfb55b889fd (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 21:21:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9d803dd280d8e02e9849e80469a12fb5eb883931 Comments
Roll src/third_party/pdfium 56250c3ee3c0..3dfb55b889fd (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/56250c3ee3c0..3dfb55b889fd git log 56250c3ee3c0..3dfb55b889fd --date=short --no-merges --format='%ad %ae %s' 2019-01-23 vmiklos@collabora.co.uk core: use the libjpeg boolean type in the jpeg codec Created with: gclient setdep -r src/third_party/pdfium@3dfb55b889fd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4ab6bd306e1f15d231dffcc8c6e354ad347f9cd6 Reviewed-on: https://chromium-review.googlesource.com/c/1431492 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625357}
Changed files
- DEPS
-
Remove all runtime JSON service manifest parsing
Changed by Ken Rockot - rockotohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:19:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 69aade0ccf3429456f5b03a9aba07eb7280747dc Comments
Remove all runtime JSON service manifest parsing This wipes out the last remaining usage of runtime JSON manifest parsing in favor of using build-time generated C++ manifests. All support code for parsing JSON manifests at runtime is removed as well. Bug: 895616 Change-Id: I35fdc82b719de4fbedb54ba433dda4293fb0f893 Reviewed-on: https://chromium-review.googlesource.com/c/1423354 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#625356}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/browser_resources.grd
- chrome/browser/chrome_content_browser_client.cc
- chrome/browser/chrome_content_browser_client.h
- content/browser/service_manager/service_manager_context.cc
- content/public/browser/content_browser_client.cc
- content/public/browser/content_browser_client.h
- services/service_manager/public/cpp/manifest.cc
- services/service_manager/public/cpp/manifest.h
- services/service_manager/public/cpp/manifest_unittest.cc
-
Enable hiding top bar by setting its height to zero.
Changed by chuanl - chuanlohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:19:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 002c66ed3f7ae594cdedaaf05808064b9f4799eb Comments
Enable hiding top bar by setting its height to zero. Bug: 882404 Change-Id: Iaa93ed3b96a70ba78fff6bc711eb0404b52f179f Reviewed-on: https://chromium-review.googlesource.com/c/1412397 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#625355}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTopBarDelegate.java
- chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/DynamicModuleCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
- chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/dynamicmodule/CustomTabsDynamicModuleUITest.java
-
Remove commented out code in feature_policy_test.cc.
Changed by Paul Meyer - paulmeyerohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:17:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 89c17cb893bce1d65be7df37fa9b996a144c7204 Comments
Remove commented out code in feature_policy_test.cc. TBR: iclelland@chromium.org Change-Id: I70b78d5d9191ad554363ce26c76ba62469900de6 Reviewed-on: https://chromium-review.googlesource.com/c/1431013 Reviewed-by: Paul Meyer <paulmeyer@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#625354}
Changed files
- third_party/blink/renderer/core/feature_policy/feature_policy_test.cc
-
Support 'never' as expiry date.
Changed by Brian White - bcwhiteohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:17:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8ad971db6d8a8a92b59718fd5b1974017ab141f2 Comments
Support 'never' as expiry date. Bug: 923083 Change-Id: I25136857b84832ac896e76f32c182af8eb190e15 Reviewed-on: https://chromium-review.googlesource.com/c/1418517 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#625353}
Changed files
- tools/metrics/histograms/extract_histograms.py
- tools/metrics/histograms/generate_expired_histograms_array.py
-
Reland "Fix flakiness in previews browsertests"
Changed by Jered Gray - jegrayohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:16:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 88574aa1a3aed9924caec756938a6a307e4a006a Comments
Reland "Fix flakiness in previews browsertests" This reverts commit de34f0bdf289e3b788f7a09be8ae97c45d1e9832. Reason for revert: Fixed additional flakiness Original change's description: > Revert "Fix flakiness in previews browsertests" > > This reverts commit ddd4f721f82a2b4065d214eee99e9fe28199ee15. > > Reason for revert: Looks like some tests become flaky (or even flakier?) > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10417 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10418 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10419 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31176 > > Original change's description: > > Fix flakiness in previews browsertests > > > > The previous logic relied upon the hints requested by the store upon a > > navigation to a url being loaded prior to the commit. This was not > > guaranteed to happen when cores were not available on a machine for > > background threads. > > > > The HintCache has been modified so that it now runs the hint loaded > > callback even in the case where no hints are available for the host. > > > > Additionally, a histogram has been added that tracks the loading of > > hints from the hint cache store has in PreviewsOptimizationGuide. The > > tests now run a priming navigation that waits for the hints to be > > loaded. This ensures that the hints are guaranteed to be available > > during the tests. > > > > Bug: 923161 > > Change-Id: I8b09dfc9391164f0a6d424ec0a8ea871334c4c8c > > Reviewed-on: https://chromium-review.googlesource.com/c/1423617 > > Commit-Queue: Jered Gray <jegray@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#625056} Change-Id: I675f7a0b3eb79d468100af8775310bb64531b069 Reviewed-on: https://chromium-review.googlesource.com/c/1431019 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#625352}
Changed files
- chrome/browser/previews/previews_browsertest.cc
- chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
- components/previews/content/hint_cache.cc
- components/previews/content/hint_cache.h
- components/previews/content/previews_optimization_guide.cc
- components/previews/core/previews_constants.cc
- components/previews/core/previews_constants.h
-
assistant: turn on voice match
Changed by Xiaohui Chen - xiaohuicohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:15:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6447cd5b54e34c1c05c272f64004612d02d4f51b Comments
assistant: turn on voice match Bug: 120666177 Test: locally build and see voice model retraining works. Change-Id: Ieaff9f11cb1e879a65064001d5455b6f2d325f22 Reviewed-on: https://chromium-review.googlesource.com/c/1423659 Reviewed-by: Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#625351}
Changed files
- chromeos/services/assistant/public/features.cc
-
[Cronet] Add const and thread annotations to native UrlRequest.
Changed by Caleb Raitto - caraittoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:09:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8d83ac63b851d0606440602fdb75535d5c145904 Comments
[Cronet] Add const and thread annotations to native UrlRequest. Change-Id: Ia56988f41bf11d74be67f0e7876b22c48a6c34d0 Reviewed-on: https://chromium-review.googlesource.com/c/1423619 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625350}
Changed files
- components/cronet/native/url_request.cc
- components/cronet/native/url_request.h
-
Update rtanalytics-* component min env versions for M73.
Changed by Luke Sorenson - lasorenohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:09:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f8f18c62d1b04a6035838c93317754bcc86e344f Comments
Update rtanalytics-* component min env versions for M73. Bug: 924649 Change-Id: I5cf3bc128b5aeafa4dbb2c2ae3df690086a19c26 Reviewed-on: https://chromium-review.googlesource.com/c/1431672 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#625349}
Changed files
- chrome/browser/component_updater/cros_component_installer_chromeos.cc
-
content: Disable SurfaceControl if AImageReader is disabled.
Changed by Khushal - khushalsagarohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:04:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision adcfe85f993f331aa98d1a1442441069f01cb8ba Comments
content: Disable SurfaceControl if AImageReader is disabled. SurfaceControl requires AImageReader to support video overlays. Disable it if AImageReader is disabled. R=piman@chromium.org Bug: 889328 Change-Id: I624f88b3759ce79eff296f75d82ac5a71616837d Reviewed-on: https://chromium-review.googlesource.com/c/1431232 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#625348}
Changed files
- content/public/browser/gpu_utils.cc
-
Roll src-internal d1737fb0576a..6aa6bc44417e (3 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 20:58:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 04b82ad690897e83605382572d0d8abe49683bae Comments
Roll src-internal d1737fb0576a..6aa6bc44417e (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1737fb0576a..6aa6bc44417e Created with: gclient setdep -r src-internal@6aa6bc44417e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:885350 TBR=mmoss@chromium.org Change-Id: If97db92ce6bd622089d2c08a0ac845d9f7fa5515 Reviewed-on: https://chromium-review.googlesource.com/c/1431253 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625347}
Changed files
- DEPS
-
Add premount mode for NetworkFileSharesPreconfiguredShares
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:57:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d7da0526a68bfba9e9d02be8f4922458185f7acb Comments
Add premount mode for NetworkFileSharesPreconfiguredShares - The "premount" mode lets preconfigured shares to be preemtively mounted upon start up of SMB file sharing. Bug: chromium=878502 Test: compiles + PolicyPrefTest unittest Change-Id: I3d53b33bb4687217b537b45d1562c4e4ed1b31b6 Reviewed-on: https://chromium-review.googlesource.com/c/1407655 Reviewed-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#625346}
Changed files
- chrome/test/data/policy/policy_test_cases.json
- components/policy/resources/policy_templates.json
-
Use GrShaderCache with SkiaRenderer
Changed by Jonathan Backer - backerohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:52:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 41d805f72249d2a5fbcf13de8dbdc1bb73745117 Comments
Use GrShaderCache with SkiaRenderer We should use GrShaderCache with SkiaRenderer, even if not using OOP-R. Change-Id: I096cbde69328efb1608232d3685a871c762d13ac Reviewed-on: https://chromium-review.googlesource.com/c/1431020 Auto-Submit: Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625345}
Changed files
- gpu/ipc/service/gpu_channel_manager.cc
-
Browsing Data: Add README.md to explain what "canned" data is
Changed by Joshua Bell - jsbellohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:49:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5e5f22d67f34885bddda9249e22f220eca99af29 Comments
Browsing Data: Add README.md to explain what "canned" data is I can never remember what role the CannedBrowsingDataXYZHelper classes serve when someone asks, so documenting it for posterity. TBR=dullweber@chromium.org,mxcai@chromium.org NOTRY=true Change-Id: Id5853e0baccc2dd1b3649a6398cb3e86e1c1f5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1431234 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625344}
Changed files
- chrome/browser/browsing_data/README.md
-
cros: Eliminate CallJSWithPrefix
Changed by Jacob Dufault - jdufaultohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:47:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 06f705e55e1b9cd5a65bdadc4f47c922618b1d3a Comments
cros: Eliminate CallJSWithPrefix Bug: 908498 Change-Id: I5c3e0376e94f18808041db0371411ae6ec168eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1352355 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#625343}
Changed files
- chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
- chrome/browser/ui/webui/chromeos/login/base_webui_handler.h
- chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
-
Add Lite mode strings for Data Saver rebranding
Changed by Robert Ogden - robertogdenohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:46:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9efff00b89781d9a722262c995f5cf6a928a5d0b Comments
Add Lite mode strings for Data Saver rebranding Data Saver is being rebranded to Lite mode. However, we'd like to programatically roll this out via Finch in M73. We expect that this will require some merges. I'm landing this CL now so that the strings that will be used can be translated and will be available at branch. This CL is based off of https://chromium-review.googlesource.com/c/1354346 In a few places where only the description of the string was changed in that CL, the change was omitted here so that we don't need a whole other string. When Lite mode is launched, I'll come back and clean those up. All new strings are suffixed with _lite_mode, based on their Data Saver counterparts. Bug: 909915 Binary-Size: Increase is due to translations and so cannot be avoided. Change-Id: Ie3511d952c301290de8c404f4677d610767f9355 Reviewed-on: https://chromium-review.googlesource.com/c/1429499 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625342}
Changed files
- build/android/lint/suppressions.xml
- chrome/android/java/strings/android_chrome_strings.grd
- chrome/app/chromeos_strings.grdp
- chrome/app/generated_resources.grd
-
Roll src/third_party/SPIRV-Tools/src 3d7102424810..b1be6763f6f3 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 20:45:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 452cd96d9ba30053bcc3e6279e6f69792dde2084 Comments
Roll src/third_party/SPIRV-Tools/src 3d7102424810..b1be6763f6f3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3d7102424810..b1be6763f6f3 git log 3d7102424810..b1be6763f6f3 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 zoddicus@users.noreply.github.com Add helper for 'is Vulkan or WebGPU' (#2324) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b1be6763f6f3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic9ddcadfcb345088ea44a8dea26264635dc3788d Reviewed-on: https://chromium-review.googlesource.com/c/1431255 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625341}
Changed files
- DEPS
-
Add ANGLE build overrides.
Changed by Jamie Madill - jmadillohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:44:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 27e844933cdcd563923c0eda3b3a8df3b1866bbe Comments
Add ANGLE build overrides. This will allow ANGLE to use Chromium repos for third_party deps. Bug: angleproject:3088 Change-Id: I0d8d4c53df780d59fdc97813fb468d0960b18def Reviewed-on: https://chromium-review.googlesource.com/c/1424397 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#625340}
Changed files
- build_overrides/angle.gni
-
[AF] Reload from database to sort profiles
Changed by Parastoo Geranmayeh - parastoogohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:43:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d8175e6fa720ce1b442e1d88f78493941aa42fdd Comments
[AF] Reload from database to sort profiles Profiles are sorted in the DB and not in the Personal Data Manager, therefore, we need to reload them when the changes are done. => Call Refresh() each times there is no more change in the waiting in the scheduling queue. Bug: 920529 Change-Id: I7bc4337b881bac67185ed9ec279857fa6b207da4 Reviewed-on: https://chromium-review.googlesource.com/c/1406178 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#625339}
Changed files
- chrome/browser/sync/test/integration/autofill_helper.cc
- chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
- chrome/browser/ui/views/payments/payment_request_browsertest_base.h
- chrome/browser/ui/views/payments/payment_request_use_stats_browsertest.cc
- components/autofill/core/browser/autofill_profile.cc
- components/autofill/core/browser/autofill_profile.h
- components/autofill/core/browser/form_data_importer_unittest.cc
- components/autofill/core/browser/personal_data_manager.cc
- components/autofill/core/browser/personal_data_manager.h
- components/autofill/core/browser/personal_data_manager_unittest.cc
-
Remove self from one watchlist.
Changed by Mounir Lamouri - mlamouriohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:40:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 578ca4009263ce0ff859751e73fac85091db06fe Comments
Remove self from one watchlist. Bug: none Change-Id: I52f415f00624a3d160be1212d9317dffac113869 TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1431535 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#625338}
Changed files
- WATCHLISTS
-
Service API for HostResolver MDNS listener
Changed by Eric Orth - ericorthohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:40:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 73db5a5ea91aa0fa2724ec27e8cfcb8bf5e24e43 Comments
Service API for HostResolver MDNS listener Bug: 922161 Change-Id: I33ba427d5449a0e93d36bdd9078d8a9b59b90422 Reviewed-on: https://chromium-review.googlesource.com/c/1413057 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#625337}
Changed files
- services/network/BUILD.gn
- services/network/host_resolver.cc
- services/network/host_resolver.h
- services/network/host_resolver_mdns_listener.cc
- services/network/host_resolver_mdns_listener.h
- services/network/host_resolver_unittest.cc
- services/network/public/cpp/host_resolver.typemap
- services/network/public/cpp/host_resolver_mojom_traits.cc
- services/network/public/cpp/host_resolver_mojom_traits.h
- services/network/public/mojom/host_resolver.mojom
-
Enable hardware key handling on CrOS
Changed by Becca Hughes - beccahughesohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:36:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 35f60266b2b744148f80bba2b7773646aa6d93b4 Comments
Enable hardware key handling on CrOS Enable hardware key handling on CrOS for launch in M73. Also fixes a type for kInternalMediaSession flag. BUG=891401 Change-Id: Ic79a2cb889b5f633ef971f62d67aaaf52b54d715 Reviewed-on: https://chromium-review.googlesource.com/c/1423131 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#625336}
Changed files
- media/base/media_switches.cc
-
Make Layer::ShouldHitTest respect SetHideLayerAndSubtree
Changed by Xianda Sun - sunxdohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:29:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 052ae71abd82e18f19f79138c7b5f9e7e5fc9625 Comments
Make Layer::ShouldHitTest respect SetHideLayerAndSubtree Ui::Layers call SetHideLayerAndSubtree when they become visible or hidden. But a cc::Layer with hide_layer_and_subtree = true still draws its content and is considered hit-testable, though not displayed on the screen. This patch makes cc hit testing respect hide_layer_and_subtree and do not hit test a layer if it's drawn but not displayed on screen. Bug: 901882 Change-Id: I18c9511c18628067dbcb471cd8dfe43a1e3c6426 Reviewed-on: https://chromium-review.googlesource.com/c/1413393 Reviewed-by: weiliangc <weiliangc@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#625335}
Changed files
- cc/layers/layer_impl.cc
- cc/layers/layer_impl.h
- cc/layers/layer_unittest.cc
- cc/trees/layer_tree_host_impl.cc
- cc/trees/layer_tree_impl.cc
- cc/trees/property_tree.cc
- cc/trees/property_tree.h
-
Roll src/third_party/perfetto db9cda8acc38..a824c339c217 (3 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 20:27:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bf764290063665ea0a0e92913826e05fda44fc79 Comments
Roll src/third_party/perfetto db9cda8acc38..a824c339c217 (3 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/db9cda8acc38..a824c339c217 git log db9cda8acc38..a824c339c217 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 lalitm@google.com trace_processor: add mm_event ingestion in trace processor 2019-01-23 lalitm@google.com trace_processor: don't parse sched_switch into raw or ingest args 2019-01-23 fmayer@google.com Merge "Do not require root for heap profiling script." Created with: gclient setdep -r src/third_party/perfetto@a824c339c217 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:118897434,chromium:123252504 TBR=perfetto-bugs@google.com Change-Id: I9b853ce07a6e7ba2165e7ed8eaaec46ac7838fd1 Reviewed-on: https://chromium-review.googlesource.com/c/1431092 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625334}
Changed files
- DEPS
-
Require a user gesture for the Contact API
Changed by Peter Beverloo - peterohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:23:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5d7baf4f6b08380783faae0f39dc7a44ab8290e7 Comments
Require a user gesture for the Contact API Also provide a series of new tests to cover the implementation, particularly this requirement. Bug: 860467 Change-Id: I274e433fadba5228ac5dc0853b5a30354904d43e Reviewed-on: https://chromium-review.googlesource.com/c/1430014 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#625333}
Changed files
- third_party/blink/renderer/modules/contacts_picker/contacts_manager.cc
- third_party/blink/web_tests/http/tests/contacts/idl-NavigatorContacts.html
- third_party/blink/web_tests/http/tests/contacts/select-function.html
-
[Fuchsia] Remove some unnecessary defined(OS_FUCHSIA) conditionals.
Changed by Wez - wezohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:23:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6957c9a71253ecd18cf4791714bc34fcae592367 Comments
[Fuchsia] Remove some unnecessary defined(OS_FUCHSIA) conditionals. Bug: 854721 Change-Id: I0bbad92f6698db479518f268d0ae797a0a3d2d81 Reviewed-on: https://chromium-review.googlesource.com/c/1424598 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625332}
Changed files
- base/allocator/partition_allocator/partition_alloc_unittest.cc
- mojo/core/broker_host.cc
- mojo/core/broker_posix.cc
-
Wire Up Windows Dark Mode to NativeThemeWin
Changed by Robert Liao - robliaoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:20:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 63e92830db63d5b7d03c245dda083cb4e7f33ea8 Comments
Wire Up Windows Dark Mode to NativeThemeWin The Dark/Light mode toggle in System Settings appears to be intended for UWP apps, so this change needs to be slightly more creative about checking this state. This change checks and monitors AppsUseLightTheme in HKCU's theme area, which is not an API guarantee. Future versions of Windows could change the way this is persisted and subsequently break this change. BUG=838670 Change-Id: Ic84341ae69e2bb9cd988f9bea027052033c66360 Reviewed-on: https://chromium-review.googlesource.com/c/1429963 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625331}
Changed files
- ui/native_theme/native_theme_win.cc
- ui/native_theme/native_theme_win.h
-
WebUI Dark Mode: update paper-tabs selection and label colors
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:18:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 08832e65279677ca77b8e187bd7faf938dd22954 Comments
WebUI Dark Mode: update paper-tabs selection and label colors R=dpapad@chromium.org BUG=883049 Change-Id: Ia9977c7eada06142181b2f4bc331c269ba88aeef Reviewed-on: https://chromium-review.googlesource.com/c/1429664 Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625330}
Changed files
- ui/webui/resources/cr_elements/paper_tabs_style_css.html
-
Reland "Mac: Record via metrics the number of open FDs and the soft FD limit."
Changed by Robert Sesek - rsesekohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:16:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3aff3364f597ac6b4b32aae9b140b09153da649b Comments
Reland "Mac: Record via metrics the number of open FDs and the soft FD limit." This is a reland of a72c20e443285e06e064e67ec754d4f60d4e6d22 Fixes ProcessMetricsTest.GetChildOpenFdCount to not close guarded FDs on macOS 10.10 and 10.11. Original change's description: > Mac: Record via metrics the number of open FDs and the soft FD limit. > > The histograms already exist on Linux, CrOS, and Android, so this simply > wires up the values for macOS. > > In addition, this enables the FD count column in the Task Manager, since > the data are now readily available. > > Bug: 714614 > Change-Id: I05f8063e8d89d3c6cdc68062bf4e591d3af9559c > Reviewed-on: https://chromium-review.googlesource.com/c/1423339 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624881} Tbr: thakis@chromium.org Bug: 714614 Change-Id: Icc79aa88826e9079845f06ed6c3f52139713b404 Reviewed-on: https://chromium-review.googlesource.com/c/1430719 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#625329}
Changed files
- base/process/process_metrics.h
- base/process/process_metrics_mac.cc
- base/process/process_metrics_unittest.cc
- chrome/browser/memory_details_mac.cc
- chrome/browser/task_manager/sampling/task_group.cc
- chrome/browser/task_manager/sampling/task_group.h
- chrome/browser/task_manager/sampling/task_group_sampler.cc
- chrome/browser/task_manager/sampling/task_group_sampler.h
- chrome/browser/task_manager/sampling/task_manager_impl.cc
- chrome/browser/task_manager/task_manager_observer.h
- chrome/browser/ui/task_manager/task_manager_columns.cc
- chrome/browser/ui/task_manager/task_manager_table_model.cc
-
viz: Extract Root Color Filter from Filter DAT to Improve Performance
Changed by Weiliang Chen - weiliangcohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:15:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 43b349f6f508142e8cbd1bfff8f83df07a5946a9 Comments
viz: Extract Root Color Filter from Filter DAT to Improve Performance From the DAG of SkImageFilter, extract the root filter out if it is a color filter, and apply that using SkPaint. Bug: 919885, 823182 Change-Id: Ia248d4390eeeba8a6e6581b2eaa800f7262800a9 Reviewed-on: https://chromium-review.googlesource.com/c/1427572 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625328}
Changed files
- components/viz/service/display/skia_renderer.cc
-
[ElementTiming] Only notify paint for loaded resources
Changed by Nicolas Pena - npmohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:14:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8685c94989998067c92fede617b2f3de42190075 Comments
[ElementTiming] Only notify paint for loaded resources This CL adds a check to ensure that an image is loaded before reporting via the Element Timing API. We want to report the first paint but only after the image is loaded. This matters for images that are progressively rendered. Bug: 879270 Change-Id: Ia0bcc68c1050967560103170be28c40238e839d9 Reviewed-on: https://chromium-review.googlesource.com/c/1415716 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625327}
Changed files
- third_party/blink/renderer/core/paint/image_painter.cc
- third_party/blink/web_tests/http/tests/performance-timing/element-timing/progressively-loaded-image.html
- third_party/blink/web_tests/http/tests/resources/progressive-image.php
-
Mac PWAs: Fix drag-drop and visibility
Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:12:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e30928eebe5ee07def107e776927097ab2bb304e Comments
Mac PWAs: Fix drag-drop and visibility Allow the app shim's WebContentsViewCocoa to call back to the browser's WebContentsViewMac via mojo. This fixes window visibility/occlusion and dragging onto web contents (though not dragging from web contents yet). Bug: 898608, 919235 Change-Id: I6b28682b330a234ebe5afb0a6f1d8af821e0c172 Reviewed-on: https://chromium-review.googlesource.com/c/1429760 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625326}
Changed files
- content/browser/web_contents/web_contents_ns_view_bridge.mm
- content/browser/web_contents/web_contents_view_cocoa.h
- content/browser/web_contents/web_contents_view_cocoa.mm
- content/browser/web_contents/web_contents_view_mac.mm
-
[Chromoting] Fix mouse when single display selected in multi-mon
Changed by Gary Kacmarcik - garykacohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:11:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ebe85a812e6971fcc40d081a06ab42f030624963 Comments
[Chromoting] Fix mouse when single display selected in multi-mon Previous code would always translate the mouse coords relative to the upper-left corner of the entire display, instead of relative to the currently selected display. This cl changes the mouse input scaler to be a DesktopRect instead of a DesktopSize because we need to keep track of the origin for proper mouse event scaling. Change-Id: I397c51280187c7a8e023e8a41940b6f37b39eb7f Reviewed-on: https://chromium-review.googlesource.com/c/1429339 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#625325}
Changed files
- remoting/client/chromoting_client.cc
- remoting/client/plugin/chromoting_instance.cc
- remoting/host/client_session.cc
- remoting/host/client_session.h
- remoting/host/client_session_unittest.cc
- remoting/host/desktop_display_info.cc
- remoting/host/desktop_display_info.h
- remoting/proto/control.proto
- remoting/protocol/mouse_input_filter.cc
- remoting/protocol/mouse_input_filter.h
- remoting/protocol/mouse_input_filter_unittest.cc
-
Call function when LayerTreeHostImpl generates a LocalSurfaceId
Changed by Scott Violet - skyohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:11:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7a340f4091c6d1ec256938d3ca9d2d9f6395aacf Comments
Call function when LayerTreeHostImpl generates a LocalSurfaceId This way client code that needs to know when the LocalSurfaceId changes can take action. BUG=922201 TEST=none Change-Id: I5b19a611f673e766757e51301c0e475e5ed5393c Reviewed-on: https://chromium-review.googlesource.com/c/1429623 Reviewed-by: Saman Sami <samans@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625324}
Changed files
- cc/test/fake_layer_tree_host_impl_client.h
- cc/test/layer_tree_test.cc
- cc/test/stub_layer_tree_host_client.h
- cc/trees/layer_tree_host.cc
- cc/trees/layer_tree_host.h
- cc/trees/layer_tree_host_client.h
- cc/trees/layer_tree_host_impl.cc
- cc/trees/layer_tree_host_impl.h
- cc/trees/layer_tree_host_impl_unittest.cc
- cc/trees/proxy_impl.cc
- cc/trees/proxy_impl.h
- cc/trees/proxy_main.cc
- cc/trees/proxy_main.h
- cc/trees/single_thread_proxy.cc
- cc/trees/single_thread_proxy.h
- content/browser/renderer_host/compositor_impl_android.h
- content/renderer/compositor/layer_tree_view.h
- ui/compositor/compositor.cc
- ui/compositor/compositor.h
- ui/compositor/compositor_observer.h
-
Update Assistant checkbox string on Assistant feedback UI
Changed by Xiao Yang - yanxiaoohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:05:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 48d8a282b6ff0e545e638fb19098213200ea55f7 Comments
Update Assistant checkbox string on Assistant feedback UI 1. Update the string from "Include Assistant debug information" to "Info to debug Assistant" Bug: b/121269286 Change-Id: I7f3a7f66be0eba7541437a83ed00699527c6ec7f Reviewed-on: https://chromium-review.googlesource.com/c/1427602 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiao Yang <yanxiao@google.com> Cr-Commit-Position: refs/heads/master@{#625323}
Changed files
- chrome/app/generated_resources.grd
- chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_ASSISTANT_INFORMATION_CHKBOX.png.sha1
-
Update JS code for Switch Access Menu Panel to use ES2016.
Changed by Anastasia Helfinstein - anastasiohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:05:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 50609a53b17fbd2879bfe3947602d131689b604b Comments
Update JS code for Switch Access Menu Panel to use ES2016. This is a pure refactor, with no change to code behavior. Bug: None Change-Id: Ib864a858b2de4aca6619ad8b002d59d075f94fa1 Reviewed-on: https://chromium-review.googlesource.com/c/1428602 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#625322}
Changed files
- chrome/browser/resources/chromeos/switch_access/menu_panel.js
- chrome/browser/resources/chromeos/switch_access/message_handler.js
-
Align the Contact API with the proposal
Changed by Peter Beverloo - peterohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:04:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b19e8afc4339d44d450726cc34c8db710badf5c7 Comments
Align the Contact API with the proposal This implements the following two changes in Blink: https://github.com/beverloo/contact-api/commit/ade45e5 https://github.com/beverloo/contact-api/commit/914261f TBR=haraken@ (moving a file in modules_idl_files.gni) Bug: 860467 Change-Id: I81dde8fdbd06728164a65ea570e7606f97bd9d77 Reviewed-on: https://chromium-review.googlesource.com/c/1430104 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#625321}
Changed files
- third_party/blink/renderer/modules/contacts_picker/BUILD.gn
- third_party/blink/renderer/modules/contacts_picker/contact_info.cc
- third_party/blink/renderer/modules/contacts_picker/contact_info.h
- third_party/blink/renderer/modules/contacts_picker/contact_info.idl
- third_party/blink/renderer/modules/contacts_picker/contacts_manager.cc
- third_party/blink/renderer/modules/contacts_picker/contacts_manager.idl
- third_party/blink/renderer/modules/modules_idl_files.gni
- third_party/blink/web_tests/http/tests/contacts/idl-NavigatorContacts.html
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
-
Add seantopping to some chromecast/ owners files
Changed by Luke Halliwell - halliwellohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:04:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a50c1914f1668cc5fcef4a8e580eab51a28caaa4 Comments
Add seantopping to some chromecast/ owners files Bug: none Change-Id: I33a08288c678b9a3d6d40eecbf5144b049f97cdf Reviewed-on: https://chromium-review.googlesource.com/c/1428719 Reviewed-by: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625320}
Changed files
- chromecast/browser/OWNERS
- chromecast/common/OWNERS
- chromecast/renderer/OWNERS
-
Allow better cert principal patterns for AutoSelectCertificateForUrls policy
Changed by Pavol Marko - pmarkoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:03:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b211ab2d528918666b0684d405e2abc642e67766 Comments
Allow better cert principal patterns for AutoSelectCertificateForUrls policy Allow the AutoSelectCertificateForUrls policy to match CommonName (C), Locality (L), Organization (O), OrganizationUnit (OU) of the ISSUER and SUBJECT of certificate candidates. Move the certificate principal matching code used for ONC network policies from //chromeos/network code to //components/certificate_matching and reuse it for the AutoSelectCertificateForUrls policy and for the existing ONC certificate matching. Bug: 905994 Test: unit tests and browser tests Change-Id: I12ba650741bcfa1a6c35e73443421fdf8fe2e38f Reviewed-on: https://chromium-review.googlesource.com/c/1405011 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#625319}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/chrome_content_browser_client.cc
- chromeos/network/BUILD.gn
- chromeos/network/DEPS
- chromeos/network/certificate_pattern.cc
- chromeos/network/certificate_pattern.h
- chromeos/network/client_cert_resolver.cc
- chromeos/network/client_cert_util.cc
- chromeos/network/client_cert_util.h
- chromeos/network/network_connection_handler.cc
- chromeos/network/network_connection_handler_impl.cc
- chromeos/network/onc/onc_certificate_pattern.cc
- chromeos/network/onc/onc_certificate_pattern.h
- chromeos/network/onc/onc_certificate_pattern_unittest.cc
- components/BUILD.gn
- components/certificate_matching/BUILD.gn
- components/certificate_matching/DEPS
- components/certificate_matching/OWNERS
- components/certificate_matching/certificate_principal_pattern.cc
- components/certificate_matching/certificate_principal_pattern.h
- components/certificate_matching/certificate_principal_pattern_unittest.cc
- components/policy/resources/policy_templates.json
-
<blame list capped at 100 commits>
Changed by <blame list capped at 100 commits> - Changed at N/A Repository Branch Revision Comments
<blame list capped at 100 commits>