Home | Search | chromium - Builders
Login

Builder mac-rel Build 2047 Apple OSX

Results:

Failure preprocess_for_goma Failure Uncaught Exception

Trigger Info:

Projectchromium
Revisionb38c320095ae37996d50a735f7d2690c9e0eed10
Got Revisionb38c320095ae37996d50a735f7d2690c9e0eed10

Execution:

Steps and Logfiles:

Show:
  1. ( 522 ms ) setup_build
    running recipe: "chromium"
  2. ( 3 secs ) report builders
     
    running builder/tester 'mac-rel' on master 'chromium'
  3. ( 15 mins 8 secs ) bot_update
    [54GB/232GB used (23%)]
  4. ( 35 secs ) swarming.py --version
    0.14
  5. ( 555 ms ) clobber
  6. ( 368 ms ) ensure_installed
  7. ( 21 mins 43 secs ) gclient runhooks
  8. ( 308 ms ) read test spec (chromium.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.json
  9. ( 588 ms ) lookup GN args
     
    enable_stripping = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  10. ( 12 secs ) generate_build_files
  11. ( 5 secs ) clang_revision
  12. ( 39 secs ) preprocess_for_goma
    1. ( 18 secs ) start_goma
    2. ( 775 ms ) goma_jsonstatus
  13. ( 2 ms ) Uncaught Exception
    Infra Failure: Step('preprocess_for_goma.start_goma') returned 1

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm260-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544165137553617, "id": "8927819212683077232", "project": "chromium", "tags": ["builder:mac-rel", "buildset:commit/git/b38c320095ae37996d50a735f7d2690c9e0eed10", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b38c320095ae37996d50a735f7d2690c9e0eed10", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093249274855907200", "scheduler_job_id:chromium/mac-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "mac-rel" setup_build
buildnumber 2047 setup_build
mastername "chromium" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "b38c320095ae37996d50a735f7d2690c9e0eed10" setup_build
got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "b38c320095ae37996d50a735f7d2690c9e0eed10" bot_update
got_revision_cp "refs/heads/master@{#614627}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" bot_update
got_v8_revision_cp "refs/heads/7.3.56@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
got_clang_revision "346388-5" clang_revision

Blamelist:

  1. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  2. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. maxmorin (maxmorinohnoyoudont@chromium.org)
  5. Charles Zhao (charleszhaoohnoyoudont@chromium.org)
  6. Alan Cutter (alancutterohnoyoudont@chromium.org)
  7. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  8. Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
  9. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  10. Li Lin (llinohnoyoudont@chromium.org)
  11. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  12. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  13. Sam McNally (sammcohnoyoudont@chromium.org)
  14. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  15. Adam Rice (riceaohnoyoudont@chromium.org)
  16. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  17. Madeleine Barowsky (mbarowskyohnoyoudont@chromium.org)
  18. Aleks Totic (atoticohnoyoudont@chromium.org)
  19. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  20. Justin DeWitt (dewittjohnoyoudont@chromium.org)
  21. Eugene But (eugenebutohnoyoudont@google.com)
  22. rbpotter (rbpotterohnoyoudont@chromium.org)
  23. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create Friday, 07-Dec-18 06:45:37 UTC
Start Friday, 07-Dec-18 06:48:07 UTC
End Friday, 07-Dec-18 07:28:05 UTC
Pending 2 mins 30 secs
Execution 39 mins 57 secs

All Changes:

  1. Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:36:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b38c320095ae37996d50a735f7d2690c9e0eed10

    Comments

    Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720
    
    Using wpt-import in Chromium c71812f1007dae45bce45b451c384bf9c0dbd356.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hbos@chromium.org, hta@chromium.org:
      external/wpt/webrtc
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I379fefc2dcbcf7082675a8eced0893890f23b0ef
    Reviewed-on: https://chromium-review.googlesource.com/c/1367132
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614627}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https-expected.txt
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-addStream.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/no-media-call.html
  2. Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:31:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b9acb3dea58c30c4a4cd8d251938f66a47c1e

    Comments

    Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs
    
    <meta name="timeout"> is prefereable for WPTs:
    https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout
    
    Bug: 912240
    Change-Id: I3c4a9acb1fb070c34d10f59ff9d3fd3d2bd11afb
    Reviewed-on: https://chromium-review.googlesource.com/c/1366469
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614626}

    Changed files

    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/external/wpt/worklets/animation-worklet-csp.https.html
    • third_party/blink/web_tests/external/wpt/worklets/audio-worklet-csp.https.html
  3. Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61e410e3beb88a04880f973dbde7c0099dbdff6

    Comments

    Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5d7bcad36ff4..62ba44ace70c
    
    
    git log 5d7bcad36ff4..62ba44ace70c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 rmhasan@google.com Adds another verification to the Test expectation parser
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@62ba44ace70c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:905426
    TBR=sullivan@chromium.org
    
    Change-Id: Ibda0e80cd77c7ecd1434701f064e2f99db1b8307
    Reviewed-on: https://chromium-review.googlesource.com/c/1367099
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614625}

    Changed files

    • DEPS
  4. Activate audio thread hang monitoring when OOP

    Changed by maxmorin - maxmorinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c67047dd2ff166e62aa72f9d461e3a00baf5e573

    Comments

    Activate audio thread hang monitoring when OOP
    
    Also includes cleaning up the hang monitor:
     * Actually a class!
     * Actually possible to stop the hang monitor!
     * Tests!
     * When OOP, uploads dumps (without crashing). A kill switch is added for this.
     * Switch the UMA enum to kCase, make it a class enum, and use the simpler UMA
       histogram.
     * Switch from "tail posting" the periodic task to using RepeatingTimer.
     * Runs on the task scheduler rather than on the browser IO thread.
     * Some suspend/resume code was simplified.
    
    The hang monitor is now owned by the AudioThread implementation.
    
    Extra functionality (such a nuking the audio process in case of a hang)
    is coming later.
    
    Bug: 866442, 905681
    Change-Id: Icfe83cc3e7626b164648a8b502d13cf2cfc25518
    Reviewed-on: https://chromium-review.googlesource.com/c/1340264
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Max Morin <maxmorin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614624}

    Changed files

    • content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • media/audio/BUILD.gn
    • media/audio/audio_features.cc
    • media/audio/audio_features.h
    • media/audio/audio_manager.cc
    • media/audio/audio_manager.h
    • media/audio/audio_thread.h
    • media/audio/audio_thread_hang_monitor.cc
    • media/audio/audio_thread_hang_monitor.h
    • media/audio/audio_thread_hang_monitor_unittest.cc
    • media/audio/audio_thread_impl.cc
    • media/audio/audio_thread_impl.h
    • media/audio/test_audio_thread.cc
    • media/audio/test_audio_thread.h
    • services/audio/owning_audio_manager_accessor.cc
  5. TabRanker: Fix Query time logging.

    Changed by Charles Zhao - charleszhaoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6378752b810e6122744cefac544c8d84278dcc71

    Comments

    TabRanker: Fix Query time logging.
    
    
    TabRanker query time logging was landed in this cl:
    https://chromium-review.googlesource.com/c/chromium/src/+/1350445
    
    TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to
    TabManager::GetSortedLifecycleUnits()
    
    But this was wrong on two aspects:
    
    (1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(),
        so ChromeOS discards are all skipped.
    
    (2) TabManagerDelegate::Candidate is calling
        lifecycle_unit_->GetSortKey() for inferring sorting,
        Which means TabRanker model won't work for ChromeOS discards.
    
    
    The fix:
    (1) Change TabManager, TabLifecycleUnit back to their previous code,
        which were sorting LifecycleUnits by TabRanker when it's enabled.
    
    (2) Add TabActivityWatcher::LogOldestNTabFeatures() and call this function in
        TabManager::DiscardTab for query time logging.
    
    Bug: 911474
    
    Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1360471
    Reviewed-by: Christopher Morin <cmtm@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Charles . <charleszhao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614623}

    Changed files

    • chrome/browser/resource_coordinator/tab_activity_watcher.cc
    • chrome/browser/resource_coordinator/tab_activity_watcher.h
    • chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
  6. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"
    
    This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.
    
    Reason for revert: Broke compile:
    https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
    ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
    #include "libassistant/shared/internal_api/alarm_timer_types.h"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Original change's description:
    > Timer notification UI improvement:
    > 
    > * Add timer deeplinks for:
    >   - Stop timer
    >   - Add time to timer
    > * Add "add 1 min to timer" button to timer notification.
    > 
    > Using a feature flag to guard the usage of the deeplink as
    > AlarmTimerManager is not fully available yet.
    > 
    > Bug: b:119116816
    > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    > Commit-Queue: Li Lin <llin@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614618}
    
    TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org
    
    Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:119116816
    Reviewed-on: https://chromium-review.googlesource.com/c/1367081
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  7. Report PreviewsEligibilityReason as offline when device is offline

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:11:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1

    Comments

    Report PreviewsEligibilityReason as offline when device is offline
    
    Currently, if the device is offline, PreviewsEligibilityReason
    records the reason for not showing previews as network quality
    unavailable.
    
    This CL changes it to record the reason as device offline.
    Network quality unavailable reason is now used for only the cases where
    NQE (network quality estimator) reports ECT as Unknown.
    
    Bug: 912725
    Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366835
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614621}

    Changed files

    • components/previews/content/previews_decider_impl.cc
    • components/previews/content/previews_decider_impl_unittest.cc
    • components/previews/core/previews_black_list.h
    • components/previews/core/previews_logger.cc
    • tools/metrics/histograms/enums.xml
  8. Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

    Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1eb8373104f00c0ca44780a28d621dd6cf2f603

    Comments

    Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused
    
    This field was added before to keep the copy of the bundle around in
    RFHI but not really used any more.
    
    Bug: N/A
    Change-Id: Ib007ee7dc941b980bab3ad92a1de016ad14d155c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365052
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614620}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
  9. Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e595fa693a4ef17b348340dbb64cf039c765e9c7

    Comments

    Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10e8db47197f..3e90e0805dd5
    
    
    Created with:
      gclient setdep -r src-internal@3e90e0805dd5
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia59b4d7347cb4c123f7e30d889f30af08e8b39f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1367115
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614619}

    Changed files

    • DEPS
  10. Timer notification UI improvement:

    Changed by Li Lin - llinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:41:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d710a7b3ef59302c00c2e3fe1b00c788310801c6

    Comments

    Timer notification UI improvement:
    
    * Add timer deeplinks for:
      - Stop timer
      - Add time to timer
    * Add "add 1 min to timer" button to timer notification.
    
    Using a feature flag to guard the usage of the deeplink as
    AlarmTimerManager is not fully available yet.
    
    Bug: b:119116816
    Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    Commit-Queue: Li Lin <llin@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614618}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  11. Crostini: migrate persisted paths from Downloads to MyFiles

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:38:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa7bc76e086df2f9428a2d583546f84f81c59d16

    Comments

    Crostini: migrate persisted paths from Downloads to MyFiles
    
    When MyFiles is enabled, check persisted paths in prefs
    and convert paths as needed.
    
    Bug: 911946
    Change-Id: I3931d196f89f31fa2ae95f7e02f9241b25d23524
    Reviewed-on: https://chromium-review.googlesource.com/c/1366458
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614617}

    Changed files

    • chrome/browser/chromeos/crostini/crostini_share_path.cc
    • chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
    • chrome/browser/chromeos/file_manager/path_util.cc
    • chrome/browser/chromeos/file_manager/path_util.h
    • chrome/browser/chromeos/file_manager/path_util_unittest.cc
  12. Update V8 to version 7.3.56.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:30:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61841709892ab7b5fc112c935f62851a2d3831e

    Comments

    Update V8 to version 7.3.56.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/2192eb7f..fd3bdfda
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I21cf598a516538376f34825912d8dd575a2ce058
    Reviewed-on: https://chromium-review.googlesource.com/c/1367111
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614616}

    Changed files

    • DEPS
  13. Add support for returning URLs from SelectFileDialogs.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:21:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 53fe68888c1b3e844195142b6ddba163bab85cd9

    Comments

    Add support for returning URLs from SelectFileDialogs.
    
    On ChromeOS, filesystem provider-provided files should be accessed via
    an externalfile URL. Further, hosted gdocs should be redirected to their
    URLs. Currently, this is handled within Browser.
    
    Add a |url| field to SelectedFileInfo to allow communicating these
    values from the dialog to Browser to avoid needing to leak this into
    Browser. Migrate this special-casing into the existing handling of
    SelectFileDialog results on ChromeOS, populating the |url| there.
    
    Bug: 843881
    Change-Id: I9808cdbf38fb4da26b99c8a45f8bda4fd0bee9a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1360812
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614615}

    Changed files

    • chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/fileapi/external_file_url_util.cc
    • chrome/browser/chromeos/fileapi/external_file_url_util.h
    • chrome/browser/ui/browser.cc
    • ui/file_manager/integration_tests/file_manager/file_dialog.js
    • ui/shell_dialogs/BUILD.gn
    • ui/shell_dialogs/selected_file_info.cc
    • ui/shell_dialogs/selected_file_info.h
  14. Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:10:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b87d9e9516460c683b698bb569d85ed8a9fd7348

    Comments

    Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/17af1e818981..8e13fe5e8564
    
    
    git log 17af1e818981..8e13fe5e8564 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jchinlee@chromium.org Surface lxml for use via vpython.
    
    
    Created with:
      gclient setdep -r src/native_client@8e13fe5e8564
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:912379
    TBR=mseaborn@chromium.org
    
    Change-Id: I53ddc48b5935ca8ea3f5bd8a44d39a43341edb2a
    Reviewed-on: https://chromium-review.googlesource.com/c/1366881
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614614}

    Changed files

    • DEPS
  15. Remove EncodingStreams runtime flag

    Changed by Adam Rice - riceaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:10:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fbb267e716151d87e9bb0a394935f6944515700

    Comments

    Remove EncodingStreams runtime flag
    
    TextEncoderStream and TextDecoderStream have shipped. The flag is no
    longer needed. Remove it.
    
    BUG=898158
    
    Change-Id: Ie08d787509f075715b084c7d5e55ad7b2a0e2fb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1364934
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614613}

    Changed files

    • third_party/blink/renderer/modules/encoding/text_decoder_stream.idl
    • third_party/blink/renderer/modules/encoding/text_encoder_stream.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  16. Roll src/third_party/angle 132d15c217e0..c3e3731cd3b2 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:06:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c653611523cbca009b53d250a568e95aacf9c29

    Comments

    Roll src/third_party/angle 132d15c217e0..c3e3731cd3b2 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/132d15c217e0..c3e3731cd3b2
    
    
    git log 132d15c217e0..c3e3731cd3b2 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jmadill@chromium.org Give every validation error a constant.
    2018-12-06 syoussefi@chromium.org Vulkan: Add dynamic vertex buffers to graph
    
    
    Created with:
      gclient setdep -r src/third_party/angle@c3e3731cd3b2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: Iaed9b0cae0e3386ca9836bc3caaf112c87dd8d17
    Reviewed-on: https://chromium-review.googlesource.com/c/1367169
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614612}

    Changed files

    • DEPS
  17. Define libwebp max allocation limit in GN fuzzer targets

    Changed by Madeleine Barowsky - mbarowskyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:49:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d639093c7a8572cdcbec81cc6b28dfb860ce815

    Comments

    Define libwebp max allocation limit in GN fuzzer targets
    
    This upper bound of 800MiB is previously enforced in the oss-fuzz
    targets [1], so we are adding it here too for consistency.
    
    [1]: github.com/google/oss-fuzz/blob/master/projects/libwebp/build.sh#L19
    
    Bug: 901042
    Change-Id: I5d1f3a970340c0c60c39e52ab2f959e0253ff63c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365655
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: James Zern <jzern@google.com>
    Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614611}

    Changed files

    • third_party/libwebp/BUILD.gn
  18. [LayoutNG] DCHECK that inline container is containing block

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:49:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 249af433d7f20d80d1d9cc225333ead0ef67d47f

    Comments

    [LayoutNG] DCHECK that inline container is containing block
    
    Bug: 740993
    Change-Id: Ie8abce134861f5a5a7cf694225da7073c48ae773
    Reviewed-on: https://chromium-review.googlesource.com/c/1321167
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614610}

    Changed files

    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
  19. [DevTools] Do not report worker console messages twice

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e41224229e7a61deb59a2a5d7bf5175cc56bf14c

    Comments

    [DevTools] Do not report worker console messages twice
    
    When the worker is still alive while DevTools is being opened,
    there is a race between console messages coming from page and
    worker target creation.
    
    Bug: 908863
    Change-Id: I9495d4becada0e4f2bd208c0922b2a2a3ea98af9
    Reviewed-on: https://chromium-review.googlesource.com/c/1359039
    Reviewed-by: Joel Einbinder <einbinder@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614609}

    Changed files

    • third_party/blink/renderer/devtools/front_end/browser_sdk/LogManager.js
    • third_party/blink/renderer/devtools/front_end/sdk/ConsoleModel.js
  20. [EoS] Enable re-scrolling on back button.

    Changed by Justin DeWitt - dewittjohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:45:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a94ae3b82c0e840d2eff0a21edb3cc591700f3c

    Comments

    [EoS] Enable re-scrolling on back button.
    
    This utilizes LinearLayoutManager#onSaveInstanceState to provide a
    parcelable.  This is stashed on the NavigationEntry (which is OK since it
    is not persisted in any way.)
    
    Change-Id: I903ef6440d1ef8e3d65d2e3764c2da35201b8b18
    Reviewed-on: https://chromium-review.googlesource.com/c/1362198
    Commit-Queue: Justin DeWitt <dewittj@chromium.org>
    Reviewed-by: Cathy Li <chili@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614608}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPageTest.java
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.initial_layout.Nexus_5-19.png
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.recycler_layout.Nexus_5-19.png
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.recycler_layout_back.Nexus_5-19.png
  21. Create OWNERS file for ios/web_view/internal/passwords.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 04:45:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8cdaa50cfb8075f774149c3b525b37301fc9f62a

    Comments

    Create OWNERS file for ios/web_view/internal/passwords.
    
    jzw@ wrote large portion of this code and ichikawa@ reviewed most of the
    changes. This CL effectively removes eugenebut@, michaeldo@ or rohitrao@
    from ios/web_view/internal/passwords OWNERS, because these engineers are
    not very familiar with the code.
    
    Bug: None
    Change-Id: I9343624316a7fee7376e13f6b942439d22baa8c2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366258
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614607}

    Changed files

    • ios/web_view/internal/passwords/OWNERS
  22. MD History: Make history item use FocusRowBehavior

    Changed by rbpotter - rbpotterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:44:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d890486deef4f4822344fa734cafcc2be778805

    Comments

    MD History: Make history item use FocusRowBehavior
    
    history-item shared a large amount of logic with the settings
    FocusRowBehavior. This CL moves FocusRowBehavior to cr/ui (with
    FocusRow), and makes history item implement it instead of using custom
    logic.
    
    Bug: None
    Change-Id: Id326142bf25a231ef9cbc338c7fe2a3f9551d3f6
    Reviewed-on: https://chromium-review.googlesource.com/c/1345414
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614606}

    Changed files

    • chrome/browser/resources/md_history/BUILD.gn
    • chrome/browser/resources/md_history/history_item.html
    • chrome/browser/resources/md_history/history_item.js
    • chrome/browser/resources/settings/BUILD.gn
    • chrome/browser/resources/settings/autofill_page/BUILD.gn
    • chrome/browser/resources/settings/autofill_page/password_list_item.html
    • chrome/browser/resources/settings/autofill_page/password_list_item.js
    • chrome/browser/resources/settings/focus_row_behavior.html
    • chrome/browser/resources/settings/focus_row_behavior.js
    • chrome/browser/resources/settings/on_startup_page/BUILD.gn
    • chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
    • chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
    • chrome/browser/resources/settings/search_engines_page/BUILD.gn
    • chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
    • chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
    • chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
    • chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
    • chrome/browser/resources/settings/settings_resources.grd
    • chrome/browser/resources/settings/site_settings/BUILD.gn
    • chrome/browser/resources/settings/site_settings/site_data_entry.html
    • chrome/browser/resources/settings/site_settings/site_data_entry.js
    • chrome/browser/resources/settings/site_settings/site_list_entry.html
    • chrome/browser/resources/settings/site_settings/site_list_entry.js
    • chrome/test/data/webui/BUILD.gn
    • chrome/test/data/webui/cr_focus_row_behavior_interactive_test.js
    • chrome/test/data/webui/cr_focus_row_behavior_test.js
    • chrome/test/data/webui/settings/cr_settings_interactive_ui_tests.js
    • ui/webui/resources/html/cr/ui/focus_row_behavior.html
    • ui/webui/resources/js/cr/ui/BUILD.gn
    • ui/webui/resources/js/cr/ui/focus_grid.js
    • ui/webui/resources/js/cr/ui/focus_row.js
    • ui/webui/resources/js/cr/ui/focus_row_behavior.js
    • ui/webui/resources/webui_resources.grd
  23. Roll src/third_party/perfetto f4a214430436..f1a2558c421d (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:44:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab2a18af11b07f338b2b59d493c767d8f1dbdefa

    Comments

    Roll src/third_party/perfetto f4a214430436..f1a2558c421d (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f4a214430436..f1a2558c421d
    
    
    git log f4a214430436..f1a2558c421d --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 primiano@google.com Cache new git deps in Travis
    2018-12-07 primiano@google.com Merge "TraceProcessor: add parsing of oom_score_adj"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f1a2558c421d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I31a16930ff43c4e094d9992352b94c71633957d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1367097
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614605}

    Changed files

    • DEPS