Builder mac-mojo-rel
Build 3590
Results:
Success
Trigger Info:
Project | chromium |
Revision | 30b15dab03cc0048cd1780be12677a592a165011 |
Got Revision | 30b15dab03cc0048cd1780be12677a592a165011 |
Execution:
- Source: Task 42f7f4e821cc9e10
- Bot: build308-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 1 secs ) read test spec (chromium.fyi.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
-
( 415 ms ) lookup GN argsdcheck_always_on = trueis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 1 secs ) [trigger] network_service_components_browsertests on (none) GPU on MacRun on OS: 'Mac-10.13'
-
( 1 secs ) [trigger] network_service_content_browsertests on (none) GPU on MacRun on OS: 'Mac-10.13'
-
( 980 ms ) [trigger] network_service_extensions_browsertests on (none) GPU on MacRun on OS: 'Mac-10.13'
-
( 2 secs ) [trigger] network_service_interactive_ui_tests on (none) GPU on MacRun on OS: 'Mac-10.13'
-
- - no logs -
-
( 1 secs ) network_service_components_browsertests on (none) GPU on MacRun on OS: 'Mac-10.13'Shard duration: 53s
-
( 1 secs ) network_service_extensions_browsertests on (none) GPU on MacRun on OS: 'Mac-10.13'Shard duration: 0:01:53.883677
-
( 1 secs ) network_service_interactive_ui_tests on (none) GPU on MacRun on OS: 'Mac-10.13'Max shard duration: 0:07:26.793552 (shard #0)Min shard duration: 0:06:07.937043 (shard #1)
-
( 2 secs ) network_service_content_browsertests on (none) GPU on MacRun on OS: 'Mac-10.13'Max shard duration: 0:11:46.902902 (shard #0)Min shard duration: 0:10:46.396102 (shard #1)
-
( 1 mins 45 secs ) webkit_layout_tests on (none) GPU on MacRun on OS: 'Mac-10.13'Max shard duration: 0:14:22.372594 (shard #10)Min shard duration: 0:10:17.209218 (shard #6)Total tests: 91524* Passed: 71954 (71855 expected, 99 unexpected)* Skipped: 16570 (16570 expected, 0 unexpected)* Failed: 2855 (2855 expected, 0 unexpected)* Flaky: 145 (145 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (618.2 sec)
- shard #1 isolated out
- shard #1 (695.5 sec)
- shard #2 isolated out
- shard #2 (541.4 sec)
- shard #3 isolated out
- shard #3 (639.2 sec)
- shard #4 isolated out
- shard #4 (577.8 sec)
- shard #5 isolated out
- shard #5 (522.7 sec)
- shard #6 isolated out
- shard #6 (475.0 sec)
- shard #7 isolated out
- shard #7 (504.9 sec)
- shard #8 isolated out
- shard #8 (539.1 sec)
- shard #9 isolated out
- shard #9 (589.7 sec)
- shard #10 isolated out
- shard #10 (721.4 sec)
- shard #11 isolated out
- shard #11 (547.4 sec)
-
( 6 secs ) network_service_browser_tests on (none) GPU on MacRun on OS: 'Mac-10.13'Max shard duration: 0:14:09.089354 (shard #8)Min shard duration: 0:09:04.758901 (shard #4)
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (529.7 sec)
- shard #1 isolated out
- shard #1 (567.8 sec)
- shard #2 isolated out
- shard #2 (624.1 sec)
- shard #3 isolated out
- shard #3 (530.3 sec)
- shard #4 isolated out
- shard #4 (506.1 sec)
- shard #5 isolated out
- shard #5 (700.1 sec)
- shard #6 isolated out
- shard #6 (725.9 sec)
- shard #7 isolated out
- shard #7 (712.8 sec)
- shard #8 isolated out
- shard #8 (807.6 sec)
- shard #9 isolated out
- shard #9 (522.7 sec)
- shard #10 isolated out
- shard #10 (531.5 sec)
- shard #11 isolated out
- shard #11 (800.7 sec)
- shard #12 isolated out
- shard #12 (576.2 sec)
- shard #13 isolated out
- shard #13 (725.6 sec)
- shard #14 isolated out
- shard #14 (585.7 sec)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/buildbucket | {"build": {"builder": {"bucket": "ci", "builder": "mac-mojo-rel", "project": "chromium"}, "createTime": "2019-02-12T00:37:43.692075Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921772362055446448", "infra": {"buildbucket": {"serviceConfigRevision": "ef156230f5cd7f8c23f689fa4dc7f92742cd904d"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "chromium"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "30b15dab03cc0048cd1780be12677a592a165011", "project": "chromium/src", "ref": "refs/heads/master"}}, "number": 3590, "tags": [{"key": "builder", "value": "mac-mojo-rel"}, {"key": "buildset", "value": "commit/git/30b15dab03cc0048cd1780be12677a592a165011"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/chromium/src/+/30b15dab03cc0048cd1780be12677a592a165011"}, {"key": "scheduler_invocation_id", "value": "9087202424287138736"}, {"key": "scheduler_job_id", "value": "chromium/mac-mojo-rel"}, {"key": "user_agent", "value": "luci-scheduler"}]}} | setup_build |
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "build308-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549931863692075, "id": "8921772362055446448", "project": "chromium", "tags": ["build_address:luci.chromium.ci/mac-mojo-rel/3590", "builder:mac-mojo-rel", "buildset:commit/git/30b15dab03cc0048cd1780be12677a592a165011", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/30b15dab03cc0048cd1780be12677a592a165011", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9087202424287138736", "scheduler_job_id:chromium/mac-mojo-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "mac-mojo-rel" | setup_build |
buildnumber | 3590 | setup_build |
mastername | "chromium.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "30b15dab03cc0048cd1780be12677a592a165011" | setup_build |
got_angle_revision | "6b695c3ffb27ad1df71f4f1682dc7a1d8adc9f31" | bot_update |
got_dawn_revision | "62e83971caa1099bdbc334817efa035047c90ddf" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "30b15dab03cc0048cd1780be12677a592a165011" | bot_update |
got_revision_cp | "refs/heads/master@{#631009}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "872455b5fe0cf1f09eb5550fb1e0bdd259523e8b" | bot_update |
got_v8_revision_cp | "refs/heads/7.4.138@{#1}" | bot_update |
got_webrtc_revision | "f13c2cd9ee41f4ca572232a4e397b05449474632" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26626}" | bot_update |
got_clang_revision | "353250-1" | clang_revision |
isolate_server | "https://isolateserver.appspot.com" | isolate tests |
swarm_hashes_refs/heads/master(at){#631009}_without_patch | {"browser_tests": "59ca1c83c560959bcfdd9b200075c2df15f9de3b", "components_browsertests": "5f180a493dbc51fbb2e5ce92969912f135a8d180", "content_browsertests": "715304e33fc9599ced987dd2afa5f417b02c9c1c", "extensions_browsertests": "0f8ea0b611b87a745680e99a532f514de887c680", "interactive_ui_tests": "2c5fc2cfdcee641d273bda8c84c6874c54afb50f", "webkit_layout_tests_exparchive": "cb7b8746b6a6dedc3bff7f57bac65f3293008010"} | isolate tests |
swarm_hashes | {"browser_tests": "59ca1c83c560959bcfdd9b200075c2df15f9de3b", "components_browsertests": "5f180a493dbc51fbb2e5ce92969912f135a8d180", "content_browsertests": "715304e33fc9599ced987dd2afa5f417b02c9c1c", "extensions_browsertests": "0f8ea0b611b87a745680e99a532f514de887c680", "interactive_ui_tests": "2c5fc2cfdcee641d273bda8c84c6874c54afb50f", "webkit_layout_tests_exparchive": "cb7b8746b6a6dedc3bff7f57bac65f3293008010"} | find isolated tests |
Blamelist:
- Jazz Xu (jazzhsuohnoyoudont@chromium.org)
- Ken Rockot (rockotohnoyoudont@google.com)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Andrey Kosyakov (caseqohnoyoudont@chromium.org)
- Peter Mayo (petermayoohnoyoudont@chromium.org)
- Jun Cai (juncaiohnoyoudont@chromium.org)
- Nick Harper (nharperohnoyoudont@chromium.org)
- Dominic Farolino (domfarolinoohnoyoudont@gmail.com)
- Sammie Quon (sammiequonohnoyoudont@google.com)
- Daniel Rubery (druberyohnoyoudont@chromium.org)
- Suman Kancherla (sumankancherlaohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Nate Fischer (ntfschrohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Philip Rogers (pdrohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Becky Zhou (huayinzohnoyoudont@chromium.org)
Timing:
Create | Tuesday, 12-Feb-19 00:37:43 UTC |
Start | Tuesday, 12-Feb-19 00:37:48 UTC |
End | Tuesday, 12-Feb-19 01:45:45 UTC |
Pending | 4 secs |
Execution | 1 hrs 7 mins |
All Changes:
-
[CrOS Video Player] Search subtitle when loading video
Changed by Jazz Xu - jazzhsuohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:36:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 30b15dab03cc0048cd1780be12677a592a165011 Comments
[CrOS Video Player] Search subtitle when loading video Search .vtt subtitle with same name as video source, and attach to video in native controls. Bug: 909963 Change-Id: Ib4431de16e8a7ba78c0d9ea9e880884c5641047e Reviewed-on: https://chromium-review.googlesource.com/c/1418320 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#631009}
Changed files
- chrome/browser/chromeos/file_manager/video_player_browsertest.cc
- chrome/test/data/chromeos/file_manager/video.vtt
- ui/file_manager/integration_tests/test_util.js
- ui/file_manager/integration_tests/video_player/background.js
- ui/file_manager/integration_tests/video_player/open_video_files.js
- ui/file_manager/video_player/js/test_util.js
- ui/file_manager/video_player/js/video_player_native_controls.js
-
[SM] Use maps for Manifest capability data
Changed by Ken Rockot - rockotohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:36:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6cdde4d7f7f512864aa5dabde5327707e9a02bf3 Comments
[SM] Use maps for Manifest capability data This changes the service Manifest type to use maps and sets for underlying capability data storage rather than flat vectors of structures. This makes the type more useful to the Service Manager at runtime, and avoids having to build additional data structures from the manifests. Bug: 895616 Change-Id: I4e9354fd51a3a1e466c26a34b86a3358a31de7ab Reviewed-on: https://chromium-review.googlesource.com/c/1462140 Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#631008}
Changed files
- chrome/app/chrome_content_browser_overlay_manifest.cc
- services/catalog/entry_cache.cc
- services/service_manager/public/cpp/manifest.cc
- services/service_manager/public/cpp/manifest.h
- services/service_manager/public/cpp/manifest_builder.h
- services/service_manager/public/cpp/manifest_unittest.cc
-
Update V8 to version 7.4.138.
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Tuesday, 12-Feb-19 00:35:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a57ea829912da80aa2ad3a6db61c384d7007cf6f Comments
Update V8 to version 7.4.138. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e223be0..872455b5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b3d615fb35fe50e85d1d5af38bc488bee0340bb Reviewed-on: https://chromium-review.googlesource.com/c/1464333 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#631007}
Changed files
- DEPS
-
DevTools: support binary protocol framing
Changed by Andrey Kosyakov - caseqohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:34:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 182039e1f62d2cdbb5ce2afe3fcf98dba20e29a1 Comments
DevTools: support binary protocol framing BUG=929862 This adds an optional parameter to --remote-debugging-pipe that lets caller specify cbor to use CBOR-compatible binary, as opposed to 0-terminated, framing for passing DevTools messages over the pipe. Change-Id: Iedadb66d14bb5e7a2c3cea855d4ff4bf4f5b88be Reviewed-on: https://chromium-review.googlesource.com/c/1460182 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#631006}
Changed files
- content/browser/devtools/devtools_pipe_handler.cc
- content/browser/devtools/devtools_pipe_handler.h
- content/public/common/content_switches.cc
-
[Sheriff] Ignore failing WPT target_blank_implicit_noopener.html
Changed by Peter Mayo - petermayoohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:33:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5c3a4fe24c1a01e8804cfa7024a6b64889000180 Comments
[Sheriff] Ignore failing WPT target_blank_implicit_noopener.html Updated WPT state from roll has different failures and passes from previous expectations TBR=foolip Bug: 930873 Change-Id: I2a5bb4a5c30225b1970c165b5b6e92fb7c9159a0 Reviewed-on: https://chromium-review.googlesource.com/c/1465059 Reviewed-by: Peter Mayo <petermayo@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#631005}
Changed files
- third_party/blink/web_tests/TestExpectations
-
Network Service: Fix linux-perf-fyi perf histogam metrics' name issue
Changed by Jun Cai - juncaiohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:33:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision feeccd78af9d3bb162771ba973868379f64651b0 Comments
Network Service: Fix linux-perf-fyi perf histogam metrics' name issue Currently the histogram metrics' name all start with cold@@ or warm@@, This CL removes these prefixes so that the linux-perf-fyi dashboard can correctly parse these metrics. Bug: 930764 Change-Id: I12e8c14a841f327c0f094988186b5e8c73a73b12 Reviewed-on: https://chromium-review.googlesource.com/c/1464640 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#631004}
Changed files
- tools/perf/contrib/network_service/loading.py
-
Update bulk entries in HSTS preload list
Changed by Nick Harper - nharperohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:30:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 556a4c6185ea6868d054944dac44945db40ffa59 Comments
Update bulk entries in HSTS preload list TBR=bnc@chromium.org Change-Id: I16df7002e113f587d27e71cbd0a5c198976b0bb7 Reviewed-on: https://chromium-review.googlesource.com/c/1464203 Reviewed-by: Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#631003}
Changed files
- net/http/transport_security_state_static.json
-
Implement TextEncoder()'s encodeInto method
Changed by Dominic Farolino - domfarolinoohnoyoudont@gmail.com Changed at Tuesday, 12-Feb-19 00:23:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aeb9424e0834afbd96b136974805e34dc39b1e66 Comments
Implement TextEncoder()'s encodeInto method This CL implements the encodeInto method on the TextEncoder interface, which encodes a string into a given pre-allocated Uint8Array. This CL introduces an EncodeInto() method to TextCodecUTF8, which acts similar to EncodeCommon(), however is bound by a given capacity, and also outputs the number of converted UTF16 code units. EncodeInto() is called via an overloaded TextCodec::Encode() method, which is meant only to be implemented in TextCodecUTF8 (since that is only where EncodeInto() is used). Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/vTNMrsScW1g R=jsbell@chromium.org, kinuko@chromium.org, ricea@chromium.org Bug: 920107 Change-Id: I178f927e837833731049c4867c0eb71e90d369cc Reviewed-on: https://chromium-review.googlesource.com/c/1456637 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#631002}
Changed files
- third_party/blink/public/platform/web_feature.mojom
- third_party/blink/renderer/modules/encoding/text_encoder.cc
- third_party/blink/renderer/modules/encoding/text_encoder.h
- third_party/blink/renderer/modules/encoding/text_encoder.idl
- third_party/blink/renderer/modules/encoding/text_encoder_encode_into_result.idl
- third_party/blink/renderer/modules/modules_idl_files.gni
- third_party/blink/renderer/platform/wtf/text/text_codec.h
- third_party/blink/renderer/platform/wtf/text/text_codec_utf8.cc
- third_party/blink/renderer/platform/wtf/text/text_codec_utf8.h
- third_party/blink/web_tests/external/wpt/encoding/encodeInto.any-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/encodeInto.any.worker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.serviceworker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.sharedworker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.worker-expected.txt
- third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
- tools/metrics/histograms/enums.xml
-
overview: Introduce OverviewObserver.
Changed by Sammie Quon - sammiequonohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:22:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c7d27a2942d2d3d8c018ee254dfb6dd43725a2f5 Comments
overview: Introduce OverviewObserver. Move overview ShellObserver methods to new class OverviewObserver. Test: none Bug: 914147 Change-Id: Ic0290fc9bd7e3144fc6939cc7833e008198a8ec1 Reviewed-on: https://chromium-review.googlesource.com/c/1461678 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#631001}
Changed files
- ash/BUILD.gn
- ash/accelerators/accelerator_unittest.cc
- ash/app_list/app_list_controller_impl.cc
- ash/app_list/app_list_controller_impl.h
- ash/frame/non_client_frame_view_ash.cc
- ash/frame/non_client_frame_view_ash.h
- ash/frame/wide_frame_view.cc
- ash/frame/wide_frame_view.h
- ash/shelf/shelf_layout_manager.cc
- ash/shelf/shelf_layout_manager.h
- ash/shell.cc
- ash/shell.h
- ash/shell_observer.h
- ash/system/overview/overview_button_tray.cc
- ash/system/overview/overview_button_tray.h
- ash/wm/overview/overview_controller.cc
- ash/wm/overview/overview_controller.h
- ash/wm/overview/overview_controller_unittest.cc
- ash/wm/overview/overview_observer.h
- ash/wm/overview/overview_session_unittest.cc
- ash/wm/splitview/split_view_controller.cc
- ash/wm/splitview/split_view_controller.h
- ash/wm/splitview/split_view_controller_unittest.cc
- ash/wm/tablet_mode/tablet_mode_observer.h
- ash/wm/tablet_mode/tablet_mode_window_manager.cc
- ash/wm/tablet_mode/tablet_mode_window_manager.h
- ash/wm/workspace/backdrop_controller.cc
- ash/wm/workspace/backdrop_controller.h
-
Reland "Don't send download pings if the download is cancelled"
Changed by Daniel Rubery - druberyohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:18:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 15338196c4b927b1c6f01f214f27873bbd137040 Comments
Reland "Don't send download pings if the download is cancelled" This reverts commit bb4a37675c5397ed15e27b9e2cafbc4b45e21b96. The previous version had the problem that RunUntilIdle() was running inconsistent amounts of tasks, which led to failed EXPECT_CALLs. I've removed the RunUntilIdle() by ensuring the CheckClientDownload always runs its callback, even when the download is destroyed. This is a minor behavior change, but doesn't seem to break anything (the download code doesn't assume the download item exists, so it handles the download destroyed case correctly). Change-Id: Ic036eefa5e1ad97be7bef72b172296112b077e11 Bug: 930372 Reviewed-on: https://chromium-review.googlesource.com/c/1460177 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#631000}
Changed files
- chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
- chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
-
[ui/vr] Add timeout for in-head permissions prompt.
Changed by Suman Kancherla - sumankancherlaohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:18:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 46e73c59ce5470b3b429f4b1b43376c91d419329 Comments
[ui/vr] Add timeout for in-head permissions prompt. Bug: 912759 Change-Id: I55b69f673d61a0ffa90127ea4e379407a7f9bf87 Reviewed-on: https://chromium-review.googlesource.com/c/1459325 Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630999}
Changed files
- chrome/browser/vr/ui_host/vr_ui_host_impl.cc
- chrome/browser/vr/ui_host/vr_ui_host_impl.h
-
Roll src/third_party/angle 0029dfe28cf4..6b695c3ffb27 (5 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Tuesday, 12-Feb-19 00:14:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e66e9d595149604e44485a1d4a2cd7733dd220ef Comments
Roll src/third_party/angle 0029dfe28cf4..6b695c3ffb27 (5 commits) https://chromium.googlesource.com/angle/angle.git/+log/0029dfe28cf4..6b695c3ffb27 git log 0029dfe28cf4..6b695c3ffb27 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 jmadill@chromium.org Vulkan: Enable WebGLCompatiblityTest. 2019-02-11 jmadill@chromium.org Vulkan: Suppress layer warnings about unbound outputs. 2019-02-11 jmadill@chromium.org Vulkan: Fix UtilsVk invalidating Context descriptors. 2019-02-11 tobine@google.com Vulkan:Adding Cmd Buffer Reset tests 2019-02-11 fjhenigman@chromium.org Vulkan: make GenerateCaps a member of RendererVk. Created with: gclient setdep -r src/third_party/angle@6b695c3ffb27 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie87758a9d8eed72c699134414d036a6c59a8db7b Reviewed-on: https://chromium-review.googlesource.com/c/1464252 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630998}
Changed files
- DEPS
-
AW docs: steps for net debugging
Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:14:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b8762b368898d9401c439988be02779d8f757479 Comments
AW docs: steps for net debugging No change to logic, only docs. This adds public docs for WebView's netlog support. This is mostly a copy of http://go/clank-webview/net-debugging, but with modifications for formatting and to call out particular content. Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I4f140ff6bdefb7a7bc740d7659513b58a43477f1 Reviewed-on: https://chromium-review.googlesource.com/c/1455681 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630997}
Changed files
- android_webview/docs/net-debugging.md
-
Roll src/third_party/swiftshader d9ce258c174b..64c44b0c53c4 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Tuesday, 12-Feb-19 00:11:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 13badb949a051ddc1dba0b987c602b56b095218a Comments
Roll src/third_party/swiftshader d9ce258c174b..64c44b0c53c4 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/d9ce258c174b..64c44b0c53c4 git log d9ce258c174b..64c44b0c53c4 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 chrisforbes@google.com Add assert for broken locations Created with: gclient setdep -r src/third_party/swiftshader@64c44b0c53c4 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I0c7c90fdad6fffceacda50b336ffe26114c78d23 Reviewed-on: https://chromium-review.googlesource.com/c/1464246 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630996}
Changed files
- DEPS
-
Remove unused SVG attribute names
Changed by Philip Rogers - pdrohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:06:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f0f63cf75081fe88ac8713ff32296bdc765bf836 Comments
Remove unused SVG attribute names A recent paint-dev thread[1] asked if svg_attribute_names.json5 represented supported attributes, and in researching I found many of the values were never implemented at all. Most of these date back to at least 2005, from the original import of ksvg2[2]. This patch removes unused svg attribute names. [1] https://groups.google.com/a/chromium.org/d/msg/paint-dev/OMwLHVnOz68/iY6cTlDQGQAJ [2] https://chromium.googlesource.com/chromium/src/+/b92429242b350855e267679d1fa3991ecc413dad/third_party/WebKit/WebCore/ksvg2/svg/svgattrs.in Change-Id: Iff195325d154b3d81ff795e6338247f165d967c3 Reviewed-on: https://chromium-review.googlesource.com/c/1464205 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#630995}
Changed files
- third_party/blink/renderer/core/svg/svg_attribute_names.json5
-
Roll src/third_party/SPIRV-Tools/src 12b3d7e9d661..40a7940e0572 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Tuesday, 12-Feb-19 00:03:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 799f14942ea54550918665b0b3a92cb686d5c830 Comments
Roll src/third_party/SPIRV-Tools/src 12b3d7e9d661..40a7940e0572 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12b3d7e9d661..40a7940e0572 git log 12b3d7e9d661..40a7940e0572 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 paulthomson@users.noreply.github.com Fix merge blocks opportunity to check if still enabled (#2370) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@40a7940e0572 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I71deb982297763501fc996cb28f1f263dd42b93e Reviewed-on: https://chromium-review.googlesource.com/c/1464253 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630994}
Changed files
- DEPS
-
Remove dummy theme
Changed by Becky Zhou - huayinzohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:03:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e0fc9799e3860cddcec4ea78d751f44af7dc88e0 Comments
Remove dummy theme Bug: 925564 Change-Id: I09a8e705f3cb1ba4872933b76912fd4cd069861a Reviewed-on: https://chromium-review.googlesource.com/c/1464658 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#630993}
Changed files
- chrome/android/java/res/values-v17/styles.xml