Home | Search | chromium - Builders
Login

Builder linux-tcmalloc-rel Build 5822 Canonical Ubuntu

Results:

Failure check_static_initializers

Trigger Info:

Projectchromium
Revisionb38c320095ae37996d50a735f7d2690c9e0eed10
Got Revisionb38c320095ae37996d50a735f7d2690c9e0eed10

Execution:

Steps and Logfiles:

Show:
  1. ( 334 ms ) setup_build
    running recipe: "chromium"
  2. ( 577 ms ) report builders
     
    running builder/tester 'linux-tcmalloc-rel' on master 'chromium.fyi'
  3. ( 3 mins 27 secs ) bot_update
    [57GB/295GB used (19%)]
  4. ( 2 secs ) swarming.py --version
    0.14
  5. ( 37 secs ) gclient runhooks
  6. ( 991 ms ) read test spec (chromium.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
  7. ( 531 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    use_new_tcmalloc = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 45 secs ) generate_build_files
  9. ( 2 mins 30 secs ) compile
  10. ( 3 mins 43 secs ) isolate tests
  11. ( 462 ms ) find isolated tests
  12. ( 4 mins 7 secs ) checkdeps
  13. ( 1 mins 9 secs ) checkperms
  14. ( 10 secs ) webkit_lint
  15. ( 1 secs ) wait for tasks
  16. ( 2 secs ) network_service_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:02:39.871543 (shard #0)
    Min shard duration: 0:02:07.257968 (shard #1)
  17. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  18. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  19. ( 1 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  20. ( 1 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  21. ( 1 secs ) network_service_components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  22. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  23. ( 1 secs ) content_shell_crash_test
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
    Total tests: n/a
     
  24. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  25. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  26. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  27. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  28. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  29. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  30. ( 12 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:07.381586
  31. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:02:17.995071 (shard #3)
    Min shard duration: 0:01:59.852375 (shard #1)
  32. ( 8 secs ) network_service_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:04:44.873972 (shard #12)
    Min shard duration: 0:03:32.604631 (shard #9)
  33. ( 1 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  34. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  35. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  36. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  37. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  38. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  39. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  40. ( 1 secs ) metrics_python_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  42. ( 6 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:06:56.259428 (shard #2)
    Min shard duration: 0:04:50.909927 (shard #4)
  43. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  44. ( 2 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  45. ( 1 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  46. ( 1 secs ) headless_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  47. ( 2 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 56s
  48. ( 1 secs ) devtools_eslint
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
    Total tests: n/a
     
  49. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  50. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  51. ( 1 secs ) chromedriver_py_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:35.926482
    Total tests: 148
    * Passed: 148 (148 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  52. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  53. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  54. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  55. ( 1 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  56. ( 1 secs ) telemetry_gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 38s
    Total tests: 38
    * Passed: 38 (38 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  57. ( 1 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 55s
  58. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  59. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  60. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  61. ( 1 secs ) devtools_closure_compile
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 37s
    Total tests: n/a
     
  62. ( 2 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:21.058289
  63. ( 1 secs ) vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  64. ( 1 secs ) vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  65. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  66. ( 2 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  67. ( 5 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 37s
  68. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  69. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  70. ( 1 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:02:48.402939 (shard #0)
    Min shard duration: 0:02:43.400126 (shard #1)
  71. ( 1 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  72. ( 1 secs ) network_service_extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 32s
  73. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  74. ( 1 secs ) views_perftests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
    Total tests: n/a
     
  75. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  76. ( 1 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  77. ( 1 secs ) chromedriver_replay_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
    Total tests: 33
    * Passed: 33 (33 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  78. ( 1 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  79. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 4s
  80. ( 1 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  81. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  82. ( 1 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 50s
  83. ( 4 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  84. ( 1 secs ) cronet_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  85. ( 1 secs ) cronet_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  86. ( 1 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  87. ( 2 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  88. ( 1 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  89. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  90. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  91. ( 1 secs ) headless_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  92. ( 1 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  93. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  94. ( 1 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  95. ( 4 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  96. ( 1 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  97. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  98. ( 2 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  99. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  100. ( 2 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  101. ( 1 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  102. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  103. ( 5 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:10.636868
  104. ( 2 secs ) network_service_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:04:04.674879 (shard #0)
    Min shard duration: 0:03:47.828041 (shard #1)
  105. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  106. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  107. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  108. ( 4 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  109. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  110. ( 2 secs ) webkit_python_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
    Total tests: 1590
    * Passed: 1590 (1590 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  111. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  112. ( 1 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  113. ( 757 ms ) wait for tasks (2)
  114. ( 2 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:07:37.795219
  115. ( 3 mins 32 secs ) webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:07:48.085691 (shard #10)
    Min shard duration: 0:06:15.109109 (shard #2)
    Total tests: 91889
    * Passed: 78728 (78699 expected, 29 unexpected)
    * Skipped: 10464 (10464 expected, 0 unexpected)
    * Failed: 2603 (2603 expected, 0 unexpected)
    * Flaky: 94 (94 expected, 0 unexpected)
     
  116. ( 3 mins 7 secs ) not_site_per_process_webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:08:41.374485 (shard #2)
    Min shard duration: 0:07:01.110450 (shard #8)
    Total tests: 91889
    * Passed: 78744 (78696 expected, 48 unexpected)
    * Skipped: 10464 (10464 expected, 0 unexpected)
    * Failed: 2575 (2575 expected, 0 unexpected)
    * Flaky: 106 (106 expected, 0 unexpected)
     
  117. ( 2 secs ) telemetry_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:06:36.998073 (shard #1)
    Min shard duration: 0:05:58.193553 (shard #0)
    Total tests: 1148
    * Passed: 1080 (1080 expected, 0 unexpected)
    * Skipped: 68 (68 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  118. ( 2 secs ) telemetry_perf_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:08:08.384178 (shard #1)
    Min shard duration: 0:05:10.400611 (shard #0)
    Total tests: 310
    * Passed: 235 (235 expected, 0 unexpected)
    * Skipped: 75 (75 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  119. ( 9 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:08:23.621835
  120. ( 267 ms ) Tests statistics
     
    Stats
    Total shards: 168
    Total runtime: 7:02:01.137472
     
  121. ( 3 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2892-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544165225905474, "id": "8927819120039275552", "project": "chromium", "tags": ["builder:linux-tcmalloc-rel", "buildset:commit/git/b38c320095ae37996d50a735f7d2690c9e0eed10", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b38c320095ae37996d50a735f7d2690c9e0eed10", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093249182150450688", "scheduler_job_id:chromium/linux-tcmalloc-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "linux-tcmalloc-rel" setup_build
buildnumber 5822 setup_build
mastername "chromium.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "b38c320095ae37996d50a735f7d2690c9e0eed10" setup_build
got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "b38c320095ae37996d50a735f7d2690c9e0eed10" bot_update
got_revision_cp "refs/heads/master@{#614627}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" bot_update
got_v8_revision_cp "refs/heads/7.3.56@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes_refs/heads/master(at){#614627}_without_patch {"accessibility_unittests": "d643003d49670d0d46eee7bebdeb03b9bc52312f", "angle_unittests": "6b868f3d0b1bdd6a718745a2c9d2185f141d8b3c", "app_shell_unittests": "13a6df645f1bf5ef5ea9d152784352003950d336", "aura_unittests": "0078bf904e525cf035f08b9d40867dc35db8b40a", "base_unittests": "3dc397fdf07f986fd45da716ec6118d28ff86605", "blink_common_unittests": "7a04324c81be1154842f2d6211aefd1dbc64c492", "blink_fuzzer_unittests": "6e8ba10f08661df37f5c8d8a7665d69129c78fd4", "blink_heap_unittests": "e8a6e9727b7ea8c5a21b0b4aa3eeb0f5f46bc306", "blink_platform_unittests": "5190655dbcafe87802054e7546c6b78d7717c136", "boringssl_crypto_tests": "01af62e0ee5925d5fe232a97dc66849604174918", "boringssl_ssl_tests": "23786239829baa4032547a48beec87548511ff70", "browser_tests": "c1c3248170cec33b57f4f520ba2b7e523afa4965", "cacheinvalidation_unittests": "14947325e1fcbb35ab974d48a7e3214073bccffe", "capture_unittests": "1a438ccaaa5f3532d0069d57bf0f73d16f799dce", "cast_unittests": "f5a32fad5ef5742a6eb0ca3531d654c14997a5f1", "cc_unittests": "f3d346af12eadd599edcdfdd54942ae3856b64b8", "chrome_app_unittests": "eac0a52f716012329712ad0c7a87c35c800e4abe", "chromedriver_py_tests": "32dfe2bc21442ab3e5e9b1f1e2c56abd992ccaf3", "chromedriver_replay_unittests": "2c79475fcfea940e6a9329f898a5d864d316a076", "chromedriver_unittests": "2fad153552385f572341320f7866afcb63888616", "components_browsertests": "91adf9b3e88efab7c833b24eaecfa96da9131b8c", "components_unittests": "4e360ed432622681297b8a897a0d9cf3a69d6d48", "compositor_unittests": "b6944d1289f03b282a3ef42c5d4d3c52bb6e1bf6", "content_browsertests": "8aa963d63412da44767c7f5f972c571e94b9380f", "content_shell_crash_test": "d84c459edb9a54a3005d79af60f77e77eed9234f", "content_unittests": "a20cd0d7d14b3859f2ee743cf12eaf28dee60467", "cronet_tests": "724e9bb508dd198b52640b647abb6470277aadf0", "cronet_unittests": "b891e9241fc8695aada6f3fd76ffb0bc51477261", "crypto_unittests": "cb15f14d6f10ade415c5078406b983b9dc767a86", "dbus_unittests": "4a38ff7d4b7e1edade302ab5aac98276150d2067", "device_unittests": "50d90f3c71999d0d1cdf5a3a955a9b0edc80f778", "devtools_closure_compile": "a846b39a64619978a102d81423a27faca9fac268", "devtools_eslint": "8c106ee1430dbde2097298b4b36c96d4685e5c9a", "display_unittests": "336849d826b2c57807ea694147fe01bd70dd4df1", "events_unittests": "8916b1e67e354ee3e62b79b6bcf633088619651f", "extensions_browsertests": "6eab5d2c66214d273c80f12f40b867ddbbdeada5", "extensions_unittests": "1e25d62f3678d6956b6c5eca5cf412b8d967e9ec", "filesystem_service_unittests": "338bb89ff4831260f146005360c47c36f4fa8434", "gcm_unit_tests": "9c8ad8342a298defdd2bc5d6695a3284357e5a76", "gfx_unittests": "16c8f414a6fb677ad4fd7cd9d99a6a7595901e74", "gin_unittests": "3ce8eec04a74f82607f40bf38eba1e3cf8d68c67", "google_apis_unittests": "7128de617299db4b70531f7613d5cf66f1104944", "gpu_unittests": "37a7111042bc0987c5c25afee9ac1fec72b6a430", "headless_browsertests": "d29881200c2a913011e57d9b6e2f2aa8f50f34bf", "headless_unittests": "bf87b388d775340b0920a8674014327f174bcfb4", "interactive_ui_tests": "208ac9915cbd13bd311c9d4f497154e7e1c1757f", "ipc_tests": "915cb1e756d196748ea87f591ee2ce66264c8c99", "jingle_unittests": "de737fcf1677e2afd366f22a62f1ec9dba4eac66", "latency_unittests": "77beb5e481e7d0620612409fffbb56f11c70800b", "leveldb_service_unittests": "93188c401a4ccb0247afce0a2d989357ffed91d5", "libjingle_xmpp_unittests": "0236fa3358295e9d6dc3808c4fadaeabadda9d2c", "media_blink_unittests": "83f1dbe159b7d2e32d1590402e5c36ba4cbb32b8", "media_service_unittests": "b1bbd21a5bb47cbbcf1573390aa9e4cf54c88dae", "media_unittests": "3decebb2714f210bfdab2a41009b3353e1b1f2f2", "message_center_unittests": "5881007edba860dd6a003727c47372b49da36a0d", "metrics_python_tests": "e46549300a9911607e420060dedc6cd3f029598d", "midi_unittests": "998ff00eed62dfc7ae46e869f86f412e20719aa7", "mojo_core_unittests": "358b5ce1afde3dffac7bbbd475905be9f64ad2f3", "mojo_unittests": "5b29634799d1cf1132b744a06d0ab66bad7e7564", "nacl_helper_nonsfi_unittests": "38303a22d8a3320cd7997a8cbdb181d602825301", "nacl_loader_unittests": "dac837f45359194c73ece9e8b679dfae6e6894fa", "native_theme_unittests": "dab1df46276948467c76e7d89da75df20f184332", "net_unittests": "ca40bb00a2ac4093a4c374b08a4071f271b6c241", "pdf_unittests": "2e80de69322c96d550d4323ec0d4eb873375223a", "ppapi_unittests": "d4abcd11dc407ecfe41a977e3c248ae00f1536f5", "printing_unittests": "cae1920110ed961d866e2925b29ecb3c778d9d12", "remoting_unittests": "579c49944a4ebc0619fdac7d82e1ff5d1db88ade", "sandbox_linux_unittests": "9872337b54d6d7098ea3c862585a7aec468f45e6", "service_manager_unittests": "d7454a814fe9485e988020d5fef7b9c0528ce4de", "services_unittests": "702f59287a3eab694693c87c5a8ea798e0cde42e", "shell_dialogs_unittests": "b5d91191ec81f20bd37a2b2830c892e96364d5a6", "skia_unittests": "5bf0ca8b1cf43118de6413463347f400b9d4a29e", "snapshot_unittests": "66bd76347a44801daa65da70046c0edc0f2ab87f", "sql_unittests": "79aed35a9cb0568a5a338a13a83baf2af48b3aa5", "storage_unittests": "171adc91dd0a38a31a7099f24088950ca4b18b13", "sync_integration_tests": "020cdd2b54865431f755ac7cb1c0a9e4d2f72dcd", "telemetry_gpu_unittests": "1fddcde10503e6b72fe9de2f123161b9208a027d", "telemetry_perf_unittests": "ecc16b8bd9a8bbb7a335c6eb9acda7fc13c6d309", "telemetry_unittests": "133241bb7bd6897d49eb263de43f98976d46b22b", "traffic_annotation_auditor_unittests": "e4f7e075a1282f40f7be2f523b80ffe4ff3f8c4d", "ui_base_unittests": "c980d975ac34608572ce8bf77a5874dc0b1e0b80", "ui_touch_selection_unittests": "df73664afb269ef2fa5da5e39154f03f1f37a442", "unit_tests": "9b64019212cf02bf46affb9f3c8031440f6c3421", "url_unittests": "460ff4709a4015643880c60551866aaa5fd34ed5", "views_perftests": "7653f34e5149dc3a5e5945695fbe636c3350d215", "views_unittests": "cad884f6dee554a97f5e4429900ead0d7da97442", "viz_unittests": "46ef3e6838aa5f97cf0b9f6641095720e0ac3269", "vr_common_unittests": "14f75a79b7562ebb6027f28590213664b4c4b952", "vr_pixeltests": "c5db31e912d67748f22e4be2124af8df21258cd1", "webkit_layout_tests_exparchive": "6fb2dbb28b1d98ee62e56f62ca7a450a4f837f1c", "webkit_python_tests": "13b77983caf8a1e9e615155c156af8a56468501c", "webkit_unit_tests": "83da20133266f4316de6ef1a1d9397b3d6da4c4a", "wm_unittests": "8f2f417de382d9fdd1bf480fdd3ad2600be18f7c", "wtf_unittests": "b9801a90e4fc8d1c3d93304ddec8263ad676124a"} isolate tests
swarm_hashes {"accessibility_unittests": "d643003d49670d0d46eee7bebdeb03b9bc52312f", "angle_unittests": "6b868f3d0b1bdd6a718745a2c9d2185f141d8b3c", "app_shell_unittests": "13a6df645f1bf5ef5ea9d152784352003950d336", "aura_unittests": "0078bf904e525cf035f08b9d40867dc35db8b40a", "base_unittests": "3dc397fdf07f986fd45da716ec6118d28ff86605", "blink_common_unittests": "7a04324c81be1154842f2d6211aefd1dbc64c492", "blink_fuzzer_unittests": "6e8ba10f08661df37f5c8d8a7665d69129c78fd4", "blink_heap_unittests": "e8a6e9727b7ea8c5a21b0b4aa3eeb0f5f46bc306", "blink_platform_unittests": "5190655dbcafe87802054e7546c6b78d7717c136", "boringssl_crypto_tests": "01af62e0ee5925d5fe232a97dc66849604174918", "boringssl_ssl_tests": "23786239829baa4032547a48beec87548511ff70", "browser_tests": "c1c3248170cec33b57f4f520ba2b7e523afa4965", "cacheinvalidation_unittests": "14947325e1fcbb35ab974d48a7e3214073bccffe", "capture_unittests": "1a438ccaaa5f3532d0069d57bf0f73d16f799dce", "cast_unittests": "f5a32fad5ef5742a6eb0ca3531d654c14997a5f1", "cc_unittests": "f3d346af12eadd599edcdfdd54942ae3856b64b8", "chrome_app_unittests": "eac0a52f716012329712ad0c7a87c35c800e4abe", "chromedriver_py_tests": "32dfe2bc21442ab3e5e9b1f1e2c56abd992ccaf3", "chromedriver_replay_unittests": "2c79475fcfea940e6a9329f898a5d864d316a076", "chromedriver_unittests": "2fad153552385f572341320f7866afcb63888616", "components_browsertests": "91adf9b3e88efab7c833b24eaecfa96da9131b8c", "components_unittests": "4e360ed432622681297b8a897a0d9cf3a69d6d48", "compositor_unittests": "b6944d1289f03b282a3ef42c5d4d3c52bb6e1bf6", "content_browsertests": "8aa963d63412da44767c7f5f972c571e94b9380f", "content_shell_crash_test": "d84c459edb9a54a3005d79af60f77e77eed9234f", "content_unittests": "a20cd0d7d14b3859f2ee743cf12eaf28dee60467", "cronet_tests": "724e9bb508dd198b52640b647abb6470277aadf0", "cronet_unittests": "b891e9241fc8695aada6f3fd76ffb0bc51477261", "crypto_unittests": "cb15f14d6f10ade415c5078406b983b9dc767a86", "dbus_unittests": "4a38ff7d4b7e1edade302ab5aac98276150d2067", "device_unittests": "50d90f3c71999d0d1cdf5a3a955a9b0edc80f778", "devtools_closure_compile": "a846b39a64619978a102d81423a27faca9fac268", "devtools_eslint": "8c106ee1430dbde2097298b4b36c96d4685e5c9a", "display_unittests": "336849d826b2c57807ea694147fe01bd70dd4df1", "events_unittests": "8916b1e67e354ee3e62b79b6bcf633088619651f", "extensions_browsertests": "6eab5d2c66214d273c80f12f40b867ddbbdeada5", "extensions_unittests": "1e25d62f3678d6956b6c5eca5cf412b8d967e9ec", "filesystem_service_unittests": "338bb89ff4831260f146005360c47c36f4fa8434", "gcm_unit_tests": "9c8ad8342a298defdd2bc5d6695a3284357e5a76", "gfx_unittests": "16c8f414a6fb677ad4fd7cd9d99a6a7595901e74", "gin_unittests": "3ce8eec04a74f82607f40bf38eba1e3cf8d68c67", "google_apis_unittests": "7128de617299db4b70531f7613d5cf66f1104944", "gpu_unittests": "37a7111042bc0987c5c25afee9ac1fec72b6a430", "headless_browsertests": "d29881200c2a913011e57d9b6e2f2aa8f50f34bf", "headless_unittests": "bf87b388d775340b0920a8674014327f174bcfb4", "interactive_ui_tests": "208ac9915cbd13bd311c9d4f497154e7e1c1757f", "ipc_tests": "915cb1e756d196748ea87f591ee2ce66264c8c99", "jingle_unittests": "de737fcf1677e2afd366f22a62f1ec9dba4eac66", "latency_unittests": "77beb5e481e7d0620612409fffbb56f11c70800b", "leveldb_service_unittests": "93188c401a4ccb0247afce0a2d989357ffed91d5", "libjingle_xmpp_unittests": "0236fa3358295e9d6dc3808c4fadaeabadda9d2c", "media_blink_unittests": "83f1dbe159b7d2e32d1590402e5c36ba4cbb32b8", "media_service_unittests": "b1bbd21a5bb47cbbcf1573390aa9e4cf54c88dae", "media_unittests": "3decebb2714f210bfdab2a41009b3353e1b1f2f2", "message_center_unittests": "5881007edba860dd6a003727c47372b49da36a0d", "metrics_python_tests": "e46549300a9911607e420060dedc6cd3f029598d", "midi_unittests": "998ff00eed62dfc7ae46e869f86f412e20719aa7", "mojo_core_unittests": "358b5ce1afde3dffac7bbbd475905be9f64ad2f3", "mojo_unittests": "5b29634799d1cf1132b744a06d0ab66bad7e7564", "nacl_helper_nonsfi_unittests": "38303a22d8a3320cd7997a8cbdb181d602825301", "nacl_loader_unittests": "dac837f45359194c73ece9e8b679dfae6e6894fa", "native_theme_unittests": "dab1df46276948467c76e7d89da75df20f184332", "net_unittests": "ca40bb00a2ac4093a4c374b08a4071f271b6c241", "pdf_unittests": "2e80de69322c96d550d4323ec0d4eb873375223a", "ppapi_unittests": "d4abcd11dc407ecfe41a977e3c248ae00f1536f5", "printing_unittests": "cae1920110ed961d866e2925b29ecb3c778d9d12", "remoting_unittests": "579c49944a4ebc0619fdac7d82e1ff5d1db88ade", "sandbox_linux_unittests": "9872337b54d6d7098ea3c862585a7aec468f45e6", "service_manager_unittests": "d7454a814fe9485e988020d5fef7b9c0528ce4de", "services_unittests": "702f59287a3eab694693c87c5a8ea798e0cde42e", "shell_dialogs_unittests": "b5d91191ec81f20bd37a2b2830c892e96364d5a6", "skia_unittests": "5bf0ca8b1cf43118de6413463347f400b9d4a29e", "snapshot_unittests": "66bd76347a44801daa65da70046c0edc0f2ab87f", "sql_unittests": "79aed35a9cb0568a5a338a13a83baf2af48b3aa5", "storage_unittests": "171adc91dd0a38a31a7099f24088950ca4b18b13", "sync_integration_tests": "020cdd2b54865431f755ac7cb1c0a9e4d2f72dcd", "telemetry_gpu_unittests": "1fddcde10503e6b72fe9de2f123161b9208a027d", "telemetry_perf_unittests": "ecc16b8bd9a8bbb7a335c6eb9acda7fc13c6d309", "telemetry_unittests": "133241bb7bd6897d49eb263de43f98976d46b22b", "traffic_annotation_auditor_unittests": "e4f7e075a1282f40f7be2f523b80ffe4ff3f8c4d", "ui_base_unittests": "c980d975ac34608572ce8bf77a5874dc0b1e0b80", "ui_touch_selection_unittests": "df73664afb269ef2fa5da5e39154f03f1f37a442", "unit_tests": "9b64019212cf02bf46affb9f3c8031440f6c3421", "url_unittests": "460ff4709a4015643880c60551866aaa5fd34ed5", "views_perftests": "7653f34e5149dc3a5e5945695fbe636c3350d215", "views_unittests": "cad884f6dee554a97f5e4429900ead0d7da97442", "viz_unittests": "46ef3e6838aa5f97cf0b9f6641095720e0ac3269", "vr_common_unittests": "14f75a79b7562ebb6027f28590213664b4c4b952", "vr_pixeltests": "c5db31e912d67748f22e4be2124af8df21258cd1", "webkit_layout_tests_exparchive": "6fb2dbb28b1d98ee62e56f62ca7a450a4f837f1c", "webkit_python_tests": "13b77983caf8a1e9e615155c156af8a56468501c", "webkit_unit_tests": "83da20133266f4316de6ef1a1d9397b3d6da4c4a", "wm_unittests": "8f2f417de382d9fdd1bf480fdd3ad2600be18f7c", "wtf_unittests": "b9801a90e4fc8d1c3d93304ddec8263ad676124a"} find isolated tests

Blamelist:

  1. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  2. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. maxmorin (maxmorinohnoyoudont@chromium.org)
  5. Charles Zhao (charleszhaoohnoyoudont@chromium.org)
  6. Alan Cutter (alancutterohnoyoudont@chromium.org)
  7. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  8. Kinuko Yasuda (kinukoohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 06:47:05 UTC
Start Friday, 07-Dec-18 06:47:42 UTC
End Friday, 07-Dec-18 07:27:57 UTC
Pending 36 secs
Execution 40 mins 14 secs

All Changes:

  1. Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:36:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b38c320095ae37996d50a735f7d2690c9e0eed10

    Comments

    Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720
    
    Using wpt-import in Chromium c71812f1007dae45bce45b451c384bf9c0dbd356.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hbos@chromium.org, hta@chromium.org:
      external/wpt/webrtc
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I379fefc2dcbcf7082675a8eced0893890f23b0ef
    Reviewed-on: https://chromium-review.googlesource.com/c/1367132
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614627}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https-expected.txt
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-addStream.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/no-media-call.html
  2. Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:31:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b9acb3dea58c30c4a4cd8d251938f66a47c1e

    Comments

    Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs
    
    <meta name="timeout"> is prefereable for WPTs:
    https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout
    
    Bug: 912240
    Change-Id: I3c4a9acb1fb070c34d10f59ff9d3fd3d2bd11afb
    Reviewed-on: https://chromium-review.googlesource.com/c/1366469
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614626}

    Changed files

    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/external/wpt/worklets/animation-worklet-csp.https.html
    • third_party/blink/web_tests/external/wpt/worklets/audio-worklet-csp.https.html
  3. Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61e410e3beb88a04880f973dbde7c0099dbdff6

    Comments

    Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5d7bcad36ff4..62ba44ace70c
    
    
    git log 5d7bcad36ff4..62ba44ace70c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 rmhasan@google.com Adds another verification to the Test expectation parser
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@62ba44ace70c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:905426
    TBR=sullivan@chromium.org
    
    Change-Id: Ibda0e80cd77c7ecd1434701f064e2f99db1b8307
    Reviewed-on: https://chromium-review.googlesource.com/c/1367099
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614625}

    Changed files

    • DEPS
  4. Activate audio thread hang monitoring when OOP

    Changed by maxmorin - maxmorinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c67047dd2ff166e62aa72f9d461e3a00baf5e573

    Comments

    Activate audio thread hang monitoring when OOP
    
    Also includes cleaning up the hang monitor:
     * Actually a class!
     * Actually possible to stop the hang monitor!
     * Tests!
     * When OOP, uploads dumps (without crashing). A kill switch is added for this.
     * Switch the UMA enum to kCase, make it a class enum, and use the simpler UMA
       histogram.
     * Switch from "tail posting" the periodic task to using RepeatingTimer.
     * Runs on the task scheduler rather than on the browser IO thread.
     * Some suspend/resume code was simplified.
    
    The hang monitor is now owned by the AudioThread implementation.
    
    Extra functionality (such a nuking the audio process in case of a hang)
    is coming later.
    
    Bug: 866442, 905681
    Change-Id: Icfe83cc3e7626b164648a8b502d13cf2cfc25518
    Reviewed-on: https://chromium-review.googlesource.com/c/1340264
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Max Morin <maxmorin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614624}

    Changed files

    • content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • media/audio/BUILD.gn
    • media/audio/audio_features.cc
    • media/audio/audio_features.h
    • media/audio/audio_manager.cc
    • media/audio/audio_manager.h
    • media/audio/audio_thread.h
    • media/audio/audio_thread_hang_monitor.cc
    • media/audio/audio_thread_hang_monitor.h
    • media/audio/audio_thread_hang_monitor_unittest.cc
    • media/audio/audio_thread_impl.cc
    • media/audio/audio_thread_impl.h
    • media/audio/test_audio_thread.cc
    • media/audio/test_audio_thread.h
    • services/audio/owning_audio_manager_accessor.cc
  5. TabRanker: Fix Query time logging.

    Changed by Charles Zhao - charleszhaoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6378752b810e6122744cefac544c8d84278dcc71

    Comments

    TabRanker: Fix Query time logging.
    
    
    TabRanker query time logging was landed in this cl:
    https://chromium-review.googlesource.com/c/chromium/src/+/1350445
    
    TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to
    TabManager::GetSortedLifecycleUnits()
    
    But this was wrong on two aspects:
    
    (1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(),
        so ChromeOS discards are all skipped.
    
    (2) TabManagerDelegate::Candidate is calling
        lifecycle_unit_->GetSortKey() for inferring sorting,
        Which means TabRanker model won't work for ChromeOS discards.
    
    
    The fix:
    (1) Change TabManager, TabLifecycleUnit back to their previous code,
        which were sorting LifecycleUnits by TabRanker when it's enabled.
    
    (2) Add TabActivityWatcher::LogOldestNTabFeatures() and call this function in
        TabManager::DiscardTab for query time logging.
    
    Bug: 911474
    
    Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1360471
    Reviewed-by: Christopher Morin <cmtm@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Charles . <charleszhao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614623}

    Changed files

    • chrome/browser/resource_coordinator/tab_activity_watcher.cc
    • chrome/browser/resource_coordinator/tab_activity_watcher.h
    • chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
  6. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"
    
    This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.
    
    Reason for revert: Broke compile:
    https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
    ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
    #include "libassistant/shared/internal_api/alarm_timer_types.h"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Original change's description:
    > Timer notification UI improvement:
    > 
    > * Add timer deeplinks for:
    >   - Stop timer
    >   - Add time to timer
    > * Add "add 1 min to timer" button to timer notification.
    > 
    > Using a feature flag to guard the usage of the deeplink as
    > AlarmTimerManager is not fully available yet.
    > 
    > Bug: b:119116816
    > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    > Commit-Queue: Li Lin <llin@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614618}
    
    TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org
    
    Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:119116816
    Reviewed-on: https://chromium-review.googlesource.com/c/1367081
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  7. Report PreviewsEligibilityReason as offline when device is offline

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:11:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1

    Comments

    Report PreviewsEligibilityReason as offline when device is offline
    
    Currently, if the device is offline, PreviewsEligibilityReason
    records the reason for not showing previews as network quality
    unavailable.
    
    This CL changes it to record the reason as device offline.
    Network quality unavailable reason is now used for only the cases where
    NQE (network quality estimator) reports ECT as Unknown.
    
    Bug: 912725
    Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366835
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614621}

    Changed files

    • components/previews/content/previews_decider_impl.cc
    • components/previews/content/previews_decider_impl_unittest.cc
    • components/previews/core/previews_black_list.h
    • components/previews/core/previews_logger.cc
    • tools/metrics/histograms/enums.xml
  8. Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

    Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1eb8373104f00c0ca44780a28d621dd6cf2f603

    Comments

    Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused
    
    This field was added before to keep the copy of the bundle around in
    RFHI but not really used any more.
    
    Bug: N/A
    Change-Id: Ib007ee7dc941b980bab3ad92a1de016ad14d155c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365052
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614620}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h