Home | Search | chromium - Builders
Login

Builder linux-code-coverage Build 1100

Results:

Failure browser_tests Failure network_service_content_browsertests Failure webkit_layout_tests Failure network_service_browser_tests

Trigger Info:

Projectchromium
Revisiond5132268fd2c639e018c94a217f8a1b858d45fac
Got Revisiond5132268fd2c639e018c94a217f8a1b858d45fac

Execution:

Steps and Logfiles:

Show:
  1. ( 305 ms ) setup_build
    running recipe: "chromium"
  2. ( 276 ms ) report builders
     
    running builder/tester 'linux-code-coverage' on master 'chromium.fyi'
  3. ( 1 mins 11 secs ) bot_update
    [174GB/295GB used (58%)]
  4. ( 774 ms ) swarming.py --version
    0.14
  5. ( 14 secs ) gclient runhooks
  6. ( 846 ms ) read test spec (chromium.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
  7. ( 474 ms ) lookup GN args
     
    is_clang = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 0
    use_clang_coverage = true
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  8. ( 17 secs ) generate_build_files
  9. ( 21 mins 48 secs ) compile
  10. ( 2 mins 40 secs ) isolate tests
  11. ( 431 ms ) find isolated tests
  12. ( 2 secs ) wait for tasks
  13. ( 3 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  14. ( 10 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  15. ( 7 secs ) cronet_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  16. ( 12 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 37s
  17. ( 3 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  18. ( 14 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  19. ( 17 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  20. ( 11 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  21. ( 4 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  22. ( 5 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  23. ( 2 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  24. ( 6 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  25. ( 25 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 36s
  26. ( 13 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  27. ( 2 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  28. ( 10 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  29. ( 14 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 42s
  30. ( 9 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  31. ( 19 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 43s
  32. ( 50 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:05.442178
  33. ( 2 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  34. ( 13 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 32s
  35. ( 58 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:43.771178
  36. ( 1 mins 2 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:54.775614
  37. ( 4 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  38. ( 3 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  39. ( 2 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  40. ( 5 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:12.512104
  41. ( 18 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 48s
  42. ( 2 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  43. ( 25 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
  44. ( 7 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  45. ( 14 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
  46. ( 9 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  47. ( 11 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  48. ( 16 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 29s
  49. ( 36 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:51.601417
  50. ( 57 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:32.332144
  51. ( 3 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  52. ( 4 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  53. ( 3 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  54. ( 10 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  55. ( 3 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  56. ( 2 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  57. ( 6 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  58. ( 10 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  59. ( 4 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  60. ( 7 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  61. ( 16 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:00.642457
  62. ( 3 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  63. ( 2 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  64. ( 13 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 29s
  65. ( 13 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  66. ( 2 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  67. ( 44 secs ) headless_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 48s
  68. ( 8 secs ) cronet_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  69. ( 17 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  70. ( 9 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  71. ( 9 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  72. ( 13 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 28s
  73. ( 1 secs ) wait for tasks (2)
  74. ( 17 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 44s
  75. ( 4 mins 57 secs ) webui_polymer2_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:12:04.093005 (shard #2)
    Min shard duration: 0:11:13.175657 (shard #3)
  76. ( 1 mins 6 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:29.487125
  77. ( 1 mins 4 secs ) headless_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:46.940523
  78. ( 19 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
  79. ( 1 mins 24 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:01.101626
  80. ( 1 mins 6 secs ) network_service_extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:06:32.018962
  81. ( 1 mins 3 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:40.261528
  82. ( 1 mins 45 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:14:47.681853
  83. ( 1 mins 2 secs ) vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:57.707406
  84. ( 22 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:25.817717
  85. ( 26 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:02.306141
  86. ( 18 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:54.715403
  87. ( 1 mins 4 secs ) network_service_components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:46.035972
  88. ( 18 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:07:17.634564
  89. ( 1 mins 30 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:41.524399
  90. ( 26 secs ) vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 42s
  91. ( 37 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:46.563798
  92. ( 23 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  93. ( 1 mins 21 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:57.015144
  94. ( 4 mins 21 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:13:15.252185 (shard #2)
    Min shard duration: 0:10:29.633191 (shard #1)
  95. ( 1 mins 24 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:39.006267
  96. ( 1 mins 11 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:36.573669
  97. ( 934 ms ) wait for tasks (3)
  98. ( 6 mins 40 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:36:31.778222 (shard #7)
    Min shard duration: 0:29:06.791065 (shard #8)
  99. ( 1 mins 58 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:20:16.459462
  100. ( 4 mins 27 secs ) network_service_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:18:46.370934 (shard #0)
    Min shard duration: 0:14:47.075402 (shard #1)
  101. ( 1 mins 16 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:40:01.286417
  102. ( 1 mins 36 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:20:23.109389
  103. ( 1 mins 38 secs ) network_service_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:34:27.253424 (shard #1)
    Min shard duration: 0:25:31.708160 (shard #0)
  104. ( 3 mins 54 secs ) webkit_layout_tests
    TEST RESULTS WERE INVALID
  105. ( 7 mins 29 secs ) network_service_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:45:49.270378 (shard #0)
    Min shard duration: 0:28:05.294393 (shard #9)
  106. ( 231 ms ) Tests statistics
     
    Stats
    Total shards: 121
    Total runtime: 18:25:33.785285
     
  107. ( 3 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "gce-trusty-32-ssd-a0be199d-us-east1-b-3ldq" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544113337706816, "id": "8927873528759662304", "project": "chromium", "tags": ["builder:linux-code-coverage", "buildset:commit/git/d5132268fd2c639e018c94a217f8a1b858d45fac", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/d5132268fd2c639e018c94a217f8a1b858d45fac", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093303590769207984", "scheduler_job_id:chromium/linux-code-coverage", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "linux-code-coverage" setup_build
buildnumber 1100 setup_build
mastername "chromium.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "d5132268fd2c639e018c94a217f8a1b858d45fac" setup_build
got_angle_revision "d300548fcc2858fab34b7a744a000c48be845d06" bot_update
got_buildtools_revision "04161ec8d7c781e4498c699254c69ba0dd959fde" bot_update
got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "d5132268fd2c639e018c94a217f8a1b858d45fac" bot_update
got_revision_cp "refs/heads/master@{#614375}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" bot_update
got_v8_revision_cp "refs/heads/7.3.39@{#1}" bot_update
got_webrtc_revision "628f37a6fe24cd7783b3446d40b2e26752cc6ebb" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25915}" bot_update
swarm_hashes_refs/heads/master(at){#614375}_without_patch {"accessibility_unittests": "64d3e2151395de322d73a4af6c37e56c87a56382", "angle_unittests": "acf58e99eb5282e9a927007026a37f3c73a9c293", "app_shell_unittests": "865d570cfe2d1b863d61726272899a7c8f95a1ea", "aura_unittests": "001e26049aa6f6973421486d3e37df02a1ca17f0", "base_unittests": "24beae4e13ceb648a70e03e2ea8cd1c58c0ffe72", "blink_common_unittests": "30d208377b404f10a7301c3abe34571ad772096a", "blink_fuzzer_unittests": "c88a4539266ee123d166c48a7e69bed05cb55c9f", "blink_heap_unittests": "ca6384019fc3104eaea68ce90e488d5a4b76fa5a", "blink_platform_unittests": "a3d8da5efae01be15518fcc927fd60462c9da29e", "boringssl_crypto_tests": "8548baa2a0c8e5927f788068239a60f59ed4c2bb", "boringssl_ssl_tests": "d370906ef3a03e84f2c24b656cceeec49afb2ce2", "browser_tests": "15cde1a89b6a47b1bb884475d79a47cd3bb8ed24", "cacheinvalidation_unittests": "4901527c11dfb813d15dbe63a0c0b7fc4becc541", "capture_unittests": "0cdaa073728e07bbf024b0b18c8323fc6ed58b84", "cast_unittests": "f9d78cd9800d5fb4eb8bd88aa3301eaf8ccc1b34", "cc_unittests": "b7c0bd3e37b3b4fda4b9962d193778af7bcf5a3b", "chrome_app_unittests": "4db29fc49d4c73f59a0c3c1b59391913168d0ee5", "chromedriver_unittests": "da53543354a050933bd9c6f390705c8163e004b0", "components_browsertests": "5c982aa16f13d3c1c73f9a685411732ca3a63710", "components_unittests": "af91d440d526217159c270fe7be8a5815831baf5", "compositor_unittests": "eebd49f6b73d45d60d1503f25395e9fc073ec811", "content_browsertests": "37c54857b067871172fc264645e961faac26fa82", "content_unittests": "d958ae8ba555543764133a038570c7da767e4f54", "cronet_tests": "4e91b0fb986bebad242285d255071138bb7954fb", "cronet_unittests": "cc9cddbdd0761c845592cd1495febc7aae2beebc", "crypto_unittests": "b1001ac19ae57322a8b872a97210124cac6fb0df", "dbus_unittests": "6778ec8ffca086d71be72501a2add6eb48ad6888", "device_unittests": "c9d672ac7db0286ccb4c19f096c255f0dd06fff9", "display_unittests": "e584c1adb10d568d550ffa551da74f56ed63a9af", "events_unittests": "a17934220aed87d664bc64fb767e28c14a0ca0f9", "extensions_browsertests": "5dfa9926914132606cda6ea08a04cb94a5e3ec09", "extensions_unittests": "2bf3f7a4f6f33b9cc8543e924aabfb094b87c694", "filesystem_service_unittests": "a162f6fda07c591a202294036ecbe49dfa144006", "gcm_unit_tests": "6988eacfe010d7b87829b144f4b5281d5bdf24b5", "gfx_unittests": "1577a4701baa231af0016960361262b4bac143c7", "gin_unittests": "2786ab5bcae7d72e0f61be4dc6c686c6a7fe0a45", "google_apis_unittests": "a65e405b47509d509d22417e02e142a7f2caea36", "gpu_unittests": "97551703e73ad452acfe22c8b369ef38c1a62391", "headless_browsertests": "49199a93315e3e7a2a617df300ee4b4ac832cb2d", "headless_unittests": "a742a98e0398351b2ee83f7c429db12ba9da9424", "interactive_ui_tests": "2ed9a617c74092e85e108a65d023d78aad43bfbc", "ipc_tests": "1d0ab244e719a42a3af7bc46bb030abc7c726dc6", "jingle_unittests": "ded12ee5e7ce9c26ed13091412f926b5aa0dc242", "latency_unittests": "8aba489ee35beeb974bbc6648ddd17fb3ca01073", "leveldb_service_unittests": "b5649f8a0e1f2be09c4fb07e052f213f7e4ec0b5", "libjingle_xmpp_unittests": "595d16ab6c2f47e298b5d7604034140052cbc184", "media_blink_unittests": "7b16cd24f7b072e1c4eb23092f5098ac7be21516", "media_service_unittests": "d07b66371fac8b6836159b124c730c0db5e3efe3", "media_unittests": "378e3aac01947fb516f269cb7630eefecef480b9", "message_center_unittests": "23226ebf2b7b261df38d3720cbfd8e1296b56e0d", "midi_unittests": "f7e78bfb21415ce4c10f1701abdecb734b69aeed", "mojo_core_unittests": "c77db417e7f81d20a20b45592fa1cee67ee8ca36", "mojo_unittests": "034f2d34659d631bb7c48e473e20f8702fcd5033", "nacl_helper_nonsfi_unittests": "63e1b972a09fae527b0af139ab66dd0ef78a9dda", "nacl_loader_unittests": "9fb409ee58f8590b3fe029cd5d44360c9acfdbf6", "native_theme_unittests": "8e1c87ecaf89f0cf1cee0c0af6cb07c6b91b1cfd", "net_unittests": "b98b994e1a1ba103cfa6a96ae3a4eb52d3c718ae", "pdf_unittests": "f25c96833eee4baacc779f87d5b3ff2523fc6e1f", "ppapi_unittests": "95617ba40e6e8f59ba2410b53f9e58e97cb9b852", "printing_unittests": "e8ed158efdfbfb2eaec988a2d9407ae8303c231d", "remoting_unittests": "babb72a8d0e1c3cb77241c51d2ffa6c2676adb6b", "sandbox_linux_unittests": "e6eba9a6ff1995fd45430ba04a910a179be793e8", "service_manager_unittests": "5ecc311440a73ed0177a4318f8e7ac28bd76a180", "services_unittests": "098de49bcfdec4dbb10dee964c3723f151f65dbc", "shell_dialogs_unittests": "233cefbb801b4665e5cec762dc2a0952a83dfc8c", "skia_unittests": "09b1640753400c5a064399a6e6e5ddb9583708bc", "snapshot_unittests": "426ec1b56ea915521a57e8a29607736c500055a9", "sql_unittests": "1ed0c46b71eac8d3c268cd992eaf66e2c4a4242f", "storage_unittests": "9f78215c5a23ebd5ef7b060658a1d1d02e3e7b00", "sync_integration_tests": "24e14b5c9c948bc24d59f1293a12df96421f910b", "traffic_annotation_auditor_unittests": "6c1850f7ac403c5cc383eafa5ee9fe7715a80665", "ui_base_unittests": "7e72d71ab050ac59195054c4cce8da329d980bee", "ui_touch_selection_unittests": "cccea4c23be1f45e0738feff459e5bb76618167d", "unit_tests": "3c30ae37c23128a080d7921c621fb024bd522490", "url_unittests": "d9289aa5bd6db7f10a2da5073c997d967891fd9d", "views_unittests": "d60a2d1e9944426d4969afceb034bd8f2e108a59", "viz_unittests": "c68505fb69a5f8c3f65a1ba4e88e92f48a4abdc7", "vr_common_unittests": "568df8dd90c3516652732edeb2d1b99435f77bac", "vr_pixeltests": "946a64006c3f673d4a51d490e250356d0d21dfc6", "webkit_layout_tests_exparchive": "0b9e2d96fd495fc186b928572fd9868c0897d1d7", "webkit_unit_tests": "0eb1e60c56b6c2203879a470a9a3b838eddff2ea", "wm_unittests": "5eb1784c0ab9d2ba39a325c42548e861897fa6a7", "wtf_unittests": "54d31275d9d48752cf1c0ec2eeb9503612eba9ef"} isolate tests
swarm_hashes {"accessibility_unittests": "64d3e2151395de322d73a4af6c37e56c87a56382", "angle_unittests": "acf58e99eb5282e9a927007026a37f3c73a9c293", "app_shell_unittests": "865d570cfe2d1b863d61726272899a7c8f95a1ea", "aura_unittests": "001e26049aa6f6973421486d3e37df02a1ca17f0", "base_unittests": "24beae4e13ceb648a70e03e2ea8cd1c58c0ffe72", "blink_common_unittests": "30d208377b404f10a7301c3abe34571ad772096a", "blink_fuzzer_unittests": "c88a4539266ee123d166c48a7e69bed05cb55c9f", "blink_heap_unittests": "ca6384019fc3104eaea68ce90e488d5a4b76fa5a", "blink_platform_unittests": "a3d8da5efae01be15518fcc927fd60462c9da29e", "boringssl_crypto_tests": "8548baa2a0c8e5927f788068239a60f59ed4c2bb", "boringssl_ssl_tests": "d370906ef3a03e84f2c24b656cceeec49afb2ce2", "browser_tests": "15cde1a89b6a47b1bb884475d79a47cd3bb8ed24", "cacheinvalidation_unittests": "4901527c11dfb813d15dbe63a0c0b7fc4becc541", "capture_unittests": "0cdaa073728e07bbf024b0b18c8323fc6ed58b84", "cast_unittests": "f9d78cd9800d5fb4eb8bd88aa3301eaf8ccc1b34", "cc_unittests": "b7c0bd3e37b3b4fda4b9962d193778af7bcf5a3b", "chrome_app_unittests": "4db29fc49d4c73f59a0c3c1b59391913168d0ee5", "chromedriver_unittests": "da53543354a050933bd9c6f390705c8163e004b0", "components_browsertests": "5c982aa16f13d3c1c73f9a685411732ca3a63710", "components_unittests": "af91d440d526217159c270fe7be8a5815831baf5", "compositor_unittests": "eebd49f6b73d45d60d1503f25395e9fc073ec811", "content_browsertests": "37c54857b067871172fc264645e961faac26fa82", "content_unittests": "d958ae8ba555543764133a038570c7da767e4f54", "cronet_tests": "4e91b0fb986bebad242285d255071138bb7954fb", "cronet_unittests": "cc9cddbdd0761c845592cd1495febc7aae2beebc", "crypto_unittests": "b1001ac19ae57322a8b872a97210124cac6fb0df", "dbus_unittests": "6778ec8ffca086d71be72501a2add6eb48ad6888", "device_unittests": "c9d672ac7db0286ccb4c19f096c255f0dd06fff9", "display_unittests": "e584c1adb10d568d550ffa551da74f56ed63a9af", "events_unittests": "a17934220aed87d664bc64fb767e28c14a0ca0f9", "extensions_browsertests": "5dfa9926914132606cda6ea08a04cb94a5e3ec09", "extensions_unittests": "2bf3f7a4f6f33b9cc8543e924aabfb094b87c694", "filesystem_service_unittests": "a162f6fda07c591a202294036ecbe49dfa144006", "gcm_unit_tests": "6988eacfe010d7b87829b144f4b5281d5bdf24b5", "gfx_unittests": "1577a4701baa231af0016960361262b4bac143c7", "gin_unittests": "2786ab5bcae7d72e0f61be4dc6c686c6a7fe0a45", "google_apis_unittests": "a65e405b47509d509d22417e02e142a7f2caea36", "gpu_unittests": "97551703e73ad452acfe22c8b369ef38c1a62391", "headless_browsertests": "49199a93315e3e7a2a617df300ee4b4ac832cb2d", "headless_unittests": "a742a98e0398351b2ee83f7c429db12ba9da9424", "interactive_ui_tests": "2ed9a617c74092e85e108a65d023d78aad43bfbc", "ipc_tests": "1d0ab244e719a42a3af7bc46bb030abc7c726dc6", "jingle_unittests": "ded12ee5e7ce9c26ed13091412f926b5aa0dc242", "latency_unittests": "8aba489ee35beeb974bbc6648ddd17fb3ca01073", "leveldb_service_unittests": "b5649f8a0e1f2be09c4fb07e052f213f7e4ec0b5", "libjingle_xmpp_unittests": "595d16ab6c2f47e298b5d7604034140052cbc184", "media_blink_unittests": "7b16cd24f7b072e1c4eb23092f5098ac7be21516", "media_service_unittests": "d07b66371fac8b6836159b124c730c0db5e3efe3", "media_unittests": "378e3aac01947fb516f269cb7630eefecef480b9", "message_center_unittests": "23226ebf2b7b261df38d3720cbfd8e1296b56e0d", "midi_unittests": "f7e78bfb21415ce4c10f1701abdecb734b69aeed", "mojo_core_unittests": "c77db417e7f81d20a20b45592fa1cee67ee8ca36", "mojo_unittests": "034f2d34659d631bb7c48e473e20f8702fcd5033", "nacl_helper_nonsfi_unittests": "63e1b972a09fae527b0af139ab66dd0ef78a9dda", "nacl_loader_unittests": "9fb409ee58f8590b3fe029cd5d44360c9acfdbf6", "native_theme_unittests": "8e1c87ecaf89f0cf1cee0c0af6cb07c6b91b1cfd", "net_unittests": "b98b994e1a1ba103cfa6a96ae3a4eb52d3c718ae", "pdf_unittests": "f25c96833eee4baacc779f87d5b3ff2523fc6e1f", "ppapi_unittests": "95617ba40e6e8f59ba2410b53f9e58e97cb9b852", "printing_unittests": "e8ed158efdfbfb2eaec988a2d9407ae8303c231d", "remoting_unittests": "babb72a8d0e1c3cb77241c51d2ffa6c2676adb6b", "sandbox_linux_unittests": "e6eba9a6ff1995fd45430ba04a910a179be793e8", "service_manager_unittests": "5ecc311440a73ed0177a4318f8e7ac28bd76a180", "services_unittests": "098de49bcfdec4dbb10dee964c3723f151f65dbc", "shell_dialogs_unittests": "233cefbb801b4665e5cec762dc2a0952a83dfc8c", "skia_unittests": "09b1640753400c5a064399a6e6e5ddb9583708bc", "snapshot_unittests": "426ec1b56ea915521a57e8a29607736c500055a9", "sql_unittests": "1ed0c46b71eac8d3c268cd992eaf66e2c4a4242f", "storage_unittests": "9f78215c5a23ebd5ef7b060658a1d1d02e3e7b00", "sync_integration_tests": "24e14b5c9c948bc24d59f1293a12df96421f910b", "traffic_annotation_auditor_unittests": "6c1850f7ac403c5cc383eafa5ee9fe7715a80665", "ui_base_unittests": "7e72d71ab050ac59195054c4cce8da329d980bee", "ui_touch_selection_unittests": "cccea4c23be1f45e0738feff459e5bb76618167d", "unit_tests": "3c30ae37c23128a080d7921c621fb024bd522490", "url_unittests": "d9289aa5bd6db7f10a2da5073c997d967891fd9d", "views_unittests": "d60a2d1e9944426d4969afceb034bd8f2e108a59", "viz_unittests": "c68505fb69a5f8c3f65a1ba4e88e92f48a4abdc7", "vr_common_unittests": "568df8dd90c3516652732edeb2d1b99435f77bac", "vr_pixeltests": "946a64006c3f673d4a51d490e250356d0d21dfc6", "webkit_layout_tests_exparchive": "0b9e2d96fd495fc186b928572fd9868c0897d1d7", "webkit_unit_tests": "0eb1e60c56b6c2203879a470a9a3b838eddff2ea", "wm_unittests": "5eb1784c0ab9d2ba39a325c42548e861897fa6a7", "wtf_unittests": "54d31275d9d48752cf1c0ec2eeb9503612eba9ef"} find isolated tests
coverage_gs_bucket "cr-coverage-profile-data" gsutil upload metadata
coverage_metadata_gs_path "postsubmit/chromium.googlesource.com/chromium/src/d5132268fd2c639e018c94a217f8a1b858d45fac/ci/linux-code-coverage/8927873528759662304/metadata" gsutil upload metadata
coverage_source_and_report_gs_path "postsubmit/chromium.googlesource.com/chromium/src/d5132268fd2c639e018c94a217f8a1b858d45fac/ci/linux-code-coverage/8927873528759662304/source_and_report" gsutil upload source and html report files

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Carlos Caballero (carlscabohnoyoudont@google.com)
  3. Vladimir Levin (vmpstrohnoyoudont@chromium.org)
  4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  5. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  6. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  7. Carlos Caballero (carlscabohnoyoudont@google.com)
  8. Carlos Caballero (carlscabohnoyoudont@google.com)
  9. Clemens Arbesser (arbesserohnoyoudont@google.com)
  10. Yi Gu (yiguohnoyoudont@chromium.org)
  11. Peng Huang (penghuangohnoyoudont@chromium.org)
  12. Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
  13. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  14. Noel Gordon (noelohnoyoudont@chromium.org)
  15. Raphael Kubo da Costa (raphael.kubo.da.costaohnoyoudont@intel.com)
  16. Nicolas Pena (npmohnoyoudont@chromium.org)
  17. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  18. Raphael Kubo da Costa (raphael.kubo.da.costaohnoyoudont@intel.com)
  19. Sergey Kuznetsov (kuznetsovsohnoyoudont@yandex-team.ru)
  20. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  21. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  22. Andreea Costinas (acostinasohnoyoudont@google.com)
  23. Yi Su (mrsuyiohnoyoudont@chromium.org)
  24. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  25. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  26. Dominick Ng (dominicknohnoyoudont@chromium.org)
  27. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  28. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  29. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  30. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  31. 3su6n15k.default@developer.gserviceaccount.com (3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com)
  32. chuanl (chuanlohnoyoudont@google.com)
  33. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  34. Carlos Caballero (carlscabohnoyoudont@google.com)
  35. JunHo Seo (junho0924.seoohnoyoudont@lge.com)
  36. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  37. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  38. Friedrich Horschig (fhorschigohnoyoudont@chromium.org)
  39. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  40. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  41. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  42. Kent Tamura (tkentohnoyoudont@chromium.org)
  43. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  44. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  45. erikchen (erikchenohnoyoudont@chromium.org)
  46. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  47. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  48. Mike Reed (reedohnoyoudont@google.com)
  49. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
  50. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  51. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  52. Huanzhong Huang (huanzhongohnoyoudont@google.com)
  53. David Roger (drogerohnoyoudont@chromium.org)
  54. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  55. Carlos Caballero (carlscabohnoyoudont@google.com)
  56. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  57. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  58. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  59. Dániel Bátyai (dbatyaiohnoyoudont@inf.u-szeged.hu)
  60. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  61. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  62. Robbie Gibson (rkgibsonohnoyoudont@google.com)
  63. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  64. Victor Costan (pwnallohnoyoudont@chromium.org)
  65. Huanzhong Huang (huanzhongohnoyoudont@google.com)
  66. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  67. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  68. Karolina Soltys (ksoltohnoyoudont@chromium.org)
  69. Mirta Dvornicic (mirtadohnoyoudont@google.com)
  70. Hans Wennborg (hansohnoyoudont@chromium.org)
  71. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  72. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  73. Jérôme Lebel (jlebelohnoyoudont@chromium.org)
  74. Kent Tamura (tkentohnoyoudont@chromium.org)
  75. Philip Jägenstedt (foolipohnoyoudont@chromium.org)
  76. Clemens Arbesser (arbesserohnoyoudont@google.com)
  77. Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
  78. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  79. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  80. Kent Tamura (tkentohnoyoudont@chromium.org)
  81. Makoto Shimazu (shimazuohnoyoudont@chromium.org)
  82. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  83. Reka Norman (rekanormanohnoyoudont@google.com)
  84. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  85. Fumitoshi Ukai (ukaiohnoyoudont@google.com)
  86. Rakina Zata Amni (rakinaohnoyoudont@chromium.org)
  87. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  88. David Jean (djeanohnoyoudont@google.com)
  89. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  90. dpapad (dpapadohnoyoudont@chromium.org)

Timing:

Create Thursday, 06-Dec-18 16:22:17 UTC
Start Thursday, 06-Dec-18 16:23:10 UTC
End Friday, 07-Dec-18 00:25:29 UTC
Pending 53 secs
Execution 8 hrs 2 mins

All Changes:

  1. Roll src/third_party/perfetto f6a1cb2d8968..06b4f7386a8c (4 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:19:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5132268fd2c639e018c94a217f8a1b858d45fac

    Comments

    Roll src/third_party/perfetto f6a1cb2d8968..06b4f7386a8c (4 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f6a1cb2d8968..06b4f7386a8c
    
    
    git log f6a1cb2d8968..06b4f7386a8c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 primiano@google.com Merge "Implement ftrace flushing"
    2018-12-06 eseckler@google.com Merge "tracing service: Verify target buffers specified in commit requests"
    2018-12-06 eseckler@google.com Merge "trace writer: Register/unregister on writer creation/destruction"
    2018-12-06 eseckler@google.com Merge "trace writer: Set the kChunkNeedsPatching flag when necessary"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@06b4f7386a8c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Idda6e5efcff897194b1a51547934631761a92561
    Reviewed-on: https://chromium-review.googlesource.com/c/1365427
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614375}

    Changed files

    • DEPS
  2. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in unified_consent

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:16:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3860213db9788a157bb1ed7db2b13842aadb3e8

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in unified_consent
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: Icbd30eb1886bb00105cd8ae5a8b158ffa9a397ea
    Reviewed-on: https://chromium-review.googlesource.com/c/1352427
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614374}

    Changed files

    • components/unified_consent/unified_consent_service_unittest.cc
  3. [DL] Don't immediately update the locked element frame rect.

    Changed by Vladimir Levin - vmpstrohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:15:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43a377d1697ac74ec5e45f739ee90becbcf253df

    Comments

    [DL] Don't immediately update the locked element frame rect.
    
    This patch ensures that we do layout in a pending frame rect, which is
    only put in place for children of the locked element during layout.
    
    After the promise is resolved, we put the pending frame rect as the
    active one and ensure that we relayout the previously locked box itself.
    
    This means that if the promise resolution, for example, removed the
    element as is the case in
    https://docs.google.com/document/d/1VrcVA5JyBmYn0Yi4wjPt1l9ce5Mhf-zu6o63p_mt98w/edit
    
    Then we never commit what was a pending layout and never see a flash
    of laid out content.
    
    R=chrishtr@chromium.org, mstensho@chromium.org
    
    Bug: 907613, 882663
    Change-Id: I7d03ae73ea4cb96c17ce8bb4162718155c2072be
    Reviewed-on: https://chromium-review.googlesource.com/c/1358969
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: vmpstr <vmpstr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614373}

    Changed files

    • third_party/blink/renderer/core/display_lock/display_lock_context.cc
    • third_party/blink/renderer/core/display_lock/display_lock_context.h
    • third_party/blink/renderer/core/layout/layout_block.cc
    • third_party/blink/renderer/core/layout/layout_box.h
    • third_party/blink/renderer/core/layout/layout_object.h
    • third_party/blink/web_tests/display-lock/lock-before-append/measure-and-remove-expected.html
    • third_party/blink/web_tests/display-lock/lock-before-append/measure-and-remove.html
  4. Roll src/third_party/dawn bdd887fce76c..5aacd29d5e7e (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:14:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df691e06ba773e8f2bd42f8020a96e303da324d1

    Comments

    Roll src/third_party/dawn bdd887fce76c..5aacd29d5e7e (1 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/bdd887fce76c..5aacd29d5e7e
    
    
    git log bdd887fce76c..5aacd29d5e7e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 cwallez@chromium.org ProcTable: only cast the return value if needed.
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@5aacd29d5e7e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: I629fa6a92ef21293c055a467c0becb4c16cc13bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1365424
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614372}

    Changed files

    • DEPS
  5. Move blink::InstanceCounters to use relaxed std::atomic, and add a warning comment.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:12:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 63ff3ddea380122470a6633bb72be00c1b153e63

    Comments

    Move blink::InstanceCounters to use relaxed std::atomic, and add a warning comment.
    
    The comment is added because it is clearly tempting to rely on these counters
    to provide an accurate count of the number of instances that exist across threads,
    but that is not something that can be computed with atomics (which do not provide
    mutual exclusion).
    
    It doesn't appear that these atomics intend to synchronize any other memory access
    (and in fact in many cases are used only from a single thread).
    
    Bug: 736037
    Change-Id: I2372ae73878361024779aadb39a72983f4faa3bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1355885
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614371}

    Changed files

    • third_party/blink/renderer/platform/instance_counters.cc
    • third_party/blink/renderer/platform/instance_counters.h
  6. Roll src-internal 44685896babc..3803956c4af7 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:10:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fcc9d76b468f3dae15a524e8b049732dde465850

    Comments

    Roll src-internal 44685896babc..3803956c4af7 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44685896babc..3803956c4af7
    
    
    Created with:
      gclient setdep -r src-internal@3803956c4af7
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I62764da8eaf39f1e4804b1100243cd8038fa6046
    Reviewed-on: https://chromium-review.googlesource.com/c/1365426
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614370}

    Changed files

    • DEPS
  7. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in subresource_filter

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:10:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad0f7767c18d3300fe7becde35058c50bf48ffd4

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in subresource_filter
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I3fcddf556b24d65f93a7d575093d89ab45e5e22e
    Reviewed-on: https://chromium-review.googlesource.com/c/1352783
    Reviewed-by: Dominic Battré <battre@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614369}

    Changed files

    • components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc
  8. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in reading_list

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38b88b324987071d63453326c3eff948c64ac80c

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in reading_list
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I4525159fc6e326db0f77bd38a1a8cca63ae9ab28
    Reviewed-on: https://chromium-review.googlesource.com/c/1352764
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614368}

    Changed files

    • components/reading_list/core/reading_list_store_unittest.cc
  9. [Autofill Assistant] Added terms&conditions link to the onboarding.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:01:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd919f3f010e5b6de66e39935e9799217778cd5a

    Comments

    [Autofill Assistant] Added terms&conditions link to the onboarding.
    
    Note that this URL is currently under construction, the corresponding issue is here: b/120547988
    
    Bug: 806868
    Change-Id: Ic7ecf90682c392cbe7762ec451570e651e4f5f79
    Reviewed-on: https://chromium-review.googlesource.com/c/1365446
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#614367}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/FirstRunScreen.java
    • chrome/android/java/strings/android_chrome_strings.grd
  10. [cc] Fix incorrect KeyframeModel::InEffect() calculation on the cc side

    Changed by Yi Gu - yiguohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:01:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f22e0fbd1e6b06ff4d59faf95b2338f750fc0dac

    Comments

    [cc] Fix incorrect KeyframeModel::InEffect() calculation on the cc side
    
    By spec [1], an animation effect is "in effect" if its active time is
    not unresolved. However, if the effect is in the "after phase" and its
    fill mode is neither "forwards" nor "both", its active time should be
    unresolved which makes the effect not "in effect". Our cc logic doesn't
    handle this case correctly.
    
    This bug was not exposed because for regular animations we cancel the
    animation on compositor in such scenario. But for worklet animations
    that's not the case.
    
    This patch adds the logic of calculating phases and the corresponding
    active time based on the spec [2].
    
    [1] https://drafts.csswg.org/web-animations/#in-effect
    [2] https://drafts.csswg.org/web-animations/#active-time
    
    Bug: 906675
    Change-Id: I8872719432ede1eeeb1e7bdcf3b5f0312787c0d7
    Reviewed-on: https://chromium-review.googlesource.com/c/1342598
    Commit-Queue: Yi Gu <yigu@chromium.org>
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614366}

    Changed files

    • cc/animation/keyframe_model.cc
    • cc/animation/keyframe_model.h
    • cc/animation/keyframe_model_unittest.cc
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/animations/animationworklet/worklet-animation-local-time-after-duration.html
  11. Fix SnapshotBrowserTest.AsyncMultiWindowTest for SkiaRenderer + DDL

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:52:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b80c413d66b8cbc37db662ee9b141691b79c0eae

    Comments

    Fix SnapshotBrowserTest.AsyncMultiWindowTest for SkiaRenderer + DDL
    
    Bug: 911793
    Change-Id: I937e902d7e9ff7e046710558e48e4765b3ec06ee
    Reviewed-on: https://chromium-review.googlesource.com/c/1363864
    Reviewed-by: weiliangc <weiliangc@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614365}

    Changed files

    • components/viz/service/display/direct_renderer.cc
    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/skia_renderer.cc
  12. cros: Fix startup page focus

    Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:52:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a66b11ee57844b24718b518f170706bc9242eab

    Comments

    cros: Fix startup page focus
    
    - Move RestoreFocus from BrowserView::Show to OnWidgetActivationChanged
      to do it when the browser window is activated;
    - Remove SetInitialFocus in SessionRestoreImpl::ShowBrowser since
      BrowserView change should do that as part of RestoreFocus;
    - Also remove the debugging code for SetInitialFocus crash
      under SessionRestoreImpl::RestoreTab since ShowBrowser no longer
      calls SetInitialFocus;
    
    Bug: 859257, 850626, 908524
    Change-Id: Ia24e4d68e1386de84765f914bb75319c9887dfd1
    Reviewed-on: https://chromium-review.googlesource.com/c/1313728
    Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614364}

    Changed files

    • chrome/browser/sessions/session_restore.cc
    • chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
    • chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
  13. Roll src/third_party/skia 7b7ab595d908..b45d5124816e (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57fc861db699982ad4c3aa3e0a509a1626cc6146

    Comments

    Roll src/third_party/skia 7b7ab595d908..b45d5124816e (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/7b7ab595d908..b45d5124816e
    
    
    git log 7b7ab595d908..b45d5124816e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 halcanary@google.com bin/sysopen: script moved to bin
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8f1b7a66a5e3..d300548fcc28 (1 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@b45d5124816e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: I3d2ffa675f1a4bc1a9509ab85ecb6c7b974dc5f9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365423
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614363}

    Changed files

    • DEPS
  14. Closure compile list_thumbnail_loader_unittest

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 454a4f0cb9c837740bbb0bb1f07809728f98f4a6

    Comments

    Closure compile list_thumbnail_loader_unittest
    
     - remove list_thumbnail_loader_unittest.html
     - add BUILD rules to auto-generate and compile this unittest
     - add @types to the unittest vars
     - inline the canvas dataURL image creation step in Setup()
     - fix all Closure compiler errors
    
    No change in test behavior, no new tests.
    
    Bug: 912557
    Change-Id: I157b0c1ef56704901e760e6f5125e4e05ea76377
    Reviewed-on: https://chromium-review.googlesource.com/c/1364999
    Commit-Queue: Stuart Langley <slangley@chromium.org>
    Reviewed-by: Stuart Langley <slangley@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614362}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_jstest.cc
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
  15. Mark upcoming WPT media-source test as WontFix

    Changed by Raphael Kubo da Costa - raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 06-Dec-18 15:35:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15bf688046abf6202ae6151e2459409060b9def6

    Comments

    Mark upcoming WPT media-source test as WontFix
    
    This test requires MP4 support in content_shell; that's not enabled by
    default and breaks WPT imports.
    
    TBR=chcunningham@chromium.org, wolenetz@chromium.org
    
    No-Try: true
    Change-Id: I3f176312cec46c8ef03dad5d40106c721b0f9723
    Reviewed-on: https://chromium-review.googlesource.com/c/1365613
    Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#614361}

    Changed files

    • third_party/blink/web_tests/NeverFixTests
  16. [EventTiming] Make PerformanceEventTiming Exposed=Window

    Changed by Nicolas Pena - npmohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:33:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa0f7396931a4b55b3f8aba9de6345817a4fa081

    Comments

    [EventTiming] Make PerformanceEventTiming Exposed=Window
    
    This CL makes PerformanceEventTiming IDL consistent with the spec, after
    https://github.com/WICG/event-timing/pull/16. Note that EventCount is
    not yet implemented.
    
    Bug: 823744
    Change-Id: I01779ed82cba0cfea0542ab74cc95b4e7adc8aac
    Reviewed-on: https://chromium-review.googlesource.com/c/1363961
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614360}

    Changed files

    • third_party/blink/renderer/core/timing/performance_event_timing.idl
  17. [swarming] Remove non CIPD managed luci-go package

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:29:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6

    Comments

    [swarming] Remove non CIPD managed luci-go package
    
    Bug: 851596
    Change-Id: I834ccae440b5590525644e4ad9e9d3c952038547
    Reviewed-on: https://chromium-review.googlesource.com/c/1364976
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614359}

    Changed files

    • DEPS
    • tools/luci-go/.gitignore
    • tools/luci-go/linux64/isolate.sha1
    • tools/luci-go/mac64/isolate.sha1
    • tools/luci-go/win64/isolate.exe.sha1
  18. gpu_init: Stop inlining GpuInit::TakeDefaultOffscreenSurface()

    Changed by Raphael Kubo da Costa - raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 06-Dec-18 15:22:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 763b79a9142f3f063eca4504dc9a45b7e75e252f

    Comments

    gpu_init: Stop inlining GpuInit::TakeDefaultOffscreenSurface()
    
    This fixes the GCC build after commit b6ef3ba2a3 ("Pass GpuPreferences to
    in-process GPU in Mash"):
    
        In file included from ../../content/utility/utility_service_factory.h:12,
                         from ../../content/utility/utility_service_factory.cc:5:
        ../../base/memory/scoped_refptr.h: In instantiation of ‘static void scoped_refptr<T>::Release(T*) [with T = gl::GLSurface]’:
        ../../base/memory/scoped_refptr.h:208:14:   required from ‘scoped_refptr<T>::~scoped_refptr() [with T = gl::GLSurface]’
        ../../gpu/ipc/service/gpu_init.h:70:48:   required from here
        ../../base/memory/scoped_refptr.h:284:8: error: invalid use of incomplete type ‘class gl::GLSurface’
           ptr->Release();
           ~~~~~^~~~~~~
        In file included from ../../services/viz/service.h:8,
                         from ../../content/utility/utility_service_factory.cc:35:
        ../../gpu/ipc/service/gpu_init.h:22:7: note: forward declaration of ‘class gl::GLSurface’
         class GLSurface;
               ^~~~~~~~~
    
    gpu_init.h forward-declares gl::GLSurface but using std::move() with GCC
    seems to require a full declaration for things to work.
    
    Bug: 819294
    Change-Id: Ib22ca2f8af6977869571292acf780042507a8afd
    Reviewed-on: https://chromium-review.googlesource.com/c/1365249
    Reviewed-by: Jonathan Backer <backer@chromium.org>
    Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#614358}

    Changed files

    • gpu/ipc/service/gpu_init.cc
    • gpu/ipc/service/gpu_init.h
  19. Cleanup ContentClient and ContentBrowserClient.

    Changed by Sergey Kuznetsov - kuznetsovsohnoyoudont@yandex-team.ru
    Changed at Thursday, 06-Dec-18 15:14:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6f9ac554c7ac46b1401183b8925ca96327e2cf3

    Comments

    Cleanup ContentClient and ContentBrowserClient.
    
    Otherwise dangling pointers are leave - this can affect other
    tests. For example, if some test uses content::TestBrowserThreadBundle
    and runs after AndroidWebViewStateSerializerTest, this test will fail.
    
    Change-Id: Ic39f5e10a68a232ca2b3d58dcd21dc61bab29e43
    Reviewed-on: https://chromium-review.googlesource.com/c/1354445
    Commit-Queue: Bo <boliu@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614357}

    Changed files

    • android_webview/browser/state_serializer_unittest.cc
  20. Roll src/third_party/SPIRV-Tools/src 03afee3b9081..2e4563d94f9d (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:14:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c5413cf5e311b79d1ba90bb3f69ab0ec5bd52d14

    Comments

    Roll src/third_party/SPIRV-Tools/src 03afee3b9081..2e4563d94f9d (1 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/03afee3b9081..2e4563d94f9d
    
    
    git log 03afee3b9081..2e4563d94f9d --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 stevenperron@google.com Document in the context what happens with id overflow. (#2159)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@2e4563d94f9d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I3d9b965d9a72ca7f3180c5a14e4ed28a7ce905db
    Reviewed-on: https://chromium-review.googlesource.com/c/1365422
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614356}

    Changed files

    • DEPS
  21. Roll src/third_party/perfetto 659c1b009ec3..f6a1cb2d8968 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:12:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc4e8d2d0fefe947d4dd4456a96c76d6dfc0a8ad

    Comments

    Roll src/third_party/perfetto 659c1b009ec3..f6a1cb2d8968 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/659c1b009ec3..f6a1cb2d8968
    
    
    git log 659c1b009ec3..f6a1cb2d8968 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 lalitm@google.com Merge "trace_processor: speed up args table even more"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f6a1cb2d8968
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iefd01cf34bed9c2c688570386aa10a75fdaa45f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1365421
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614355}

    Changed files

    • DEPS
  22. Run tests when policy_test_cases.json changes

    Changed by Andreea Costinas - acostinasohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 15:12:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c940428a52570c147124aed3eb41f080e9a5be6

    Comments

    Run tests when policy_test_cases.json changes
    
    BUG=498579
    
    Change-Id: I0ef207bbcf210de686902b2248f4e0c96453b707
    Reviewed-on: https://chromium-review.googlesource.com/c/1365236
    Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614354}

    Changed files

    • chrome/test/data/policy/PRESUBMIT.py
    • components/policy/resources/PRESUBMIT.py
  23. Remove highlight delay for FindInPage results out of screen.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:10:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40735d1fe4a48f42b6ec7b71dcaa92c3f04a095f

    Comments

    Remove highlight delay for FindInPage results out of screen.
    
    In current implementation of find_in_page.js, when user navigates to a
    match result out of the screen, the orange highlight will be added to it
    with a 250ms delay. In previous version, the callback invoked after
    250ms will always add orange highlight to the current selected match
    result, and the CL(http://crrev/c/1347363) accidently changed the logic
    and created a bug. If user clicks "goNext" fast enough, selected match
    result may get highlighted permanently.
    
    However, after deeper investigation, the delayed highlight seems to be
    buggy from the begining. Navigating backward to a match result that is
    inside the screen will also meets the condition and trigger the delay,
    but the 250ms is just too short to be noticed.
    Besides, why we need the delay is also mysterious, and here is my guess:
    In ancient time the find_in_page.js do two things, first scroll to the
    match result and then do the highlight, and somehow UIWebView requires
    us to add a delay(see the comments in old version code). Then the
    scrolling work moved from Js into OC, so there are two lines about
    scrolling that are commented out.
    
    Since UX has also confirmed that delay on highlight is not necessary, it
    should be removed now.
    
    Bug: 911611
    Change-Id: If0fef219b33954e243e527f3b50dbe836f753ede
    Reviewed-on: https://chromium-review.googlesource.com/c/1365610
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614353}

    Changed files

    • ios/chrome/browser/find_in_page/resources/find_in_page.js
  24. Android: Don't bother creating .srcjar for generated chrome version file

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:07:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a52806d08dd7e18975257e131b8a1528c5a116ba

    Comments

    Android: Don't bother creating .srcjar for generated chrome version file
    
    Bug: 908479
    Change-Id: I6b6d50319143a5b4135c446d7723d6a70fc3fecc
    Reviewed-on: https://chromium-review.googlesource.com/c/1364610
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614352}

    Changed files

    • chrome/android/BUILD.gn
  25. Deflake WebMediaPlayerMSTest.RotationChange

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:05:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbb7308e7bcc0053dca3104f3306ce64a34085a3

    Comments

    Deflake WebMediaPlayerMSTest.RotationChange
    
    This test currently relies upon the exact ordering of RenderFrame,
    InjectFrame and CheckForFrameChanges, which is a mix of delayed and
    immediate tasks. The scheduler doesn't guarantee the exact ordering
    of these which causes this test to flake.  We add some extra
    RunLoop().RunUntilIdle() calls to ensure CheckForFrameChanges has
    a chance to run.
    
    TBR=miu@chromium.org
    
    Bug: 863341, 891670
    Change-Id: I526d6b77f6ce46f04d84584f5daba096ef1a98e5
    Reviewed-on: https://chromium-review.googlesource.com/c/1365248
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Alex Clarke <alexclarke@chromium.org>
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614351}

    Changed files

    • content/renderer/media/stream/webmediaplayer_ms_unittest.cc
  26. Add a debug flag for the WebApkValidator to cut down logcat spam.

    Changed by Dominick Ng - dominicknohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:05:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 39c9b8c6af3aaa4aeb398959f263193b0263f8bf

    Comments

    Add a debug flag for the WebApkValidator to cut down logcat spam.
    
    BUG=None
    
    Change-Id: Ie6bcdd0b88fd32f8416871f58381cd88f2b6e234
    Reviewed-on: https://chromium-review.googlesource.com/c/1364650
    Commit-Queue: Xi Han <hanxi@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614350}

    Changed files

    • chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
  27. [swarming] use var for luci-go CIPD package version

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:58:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 409e0ff6a1064ec2a2784407d6439396729d9ff1

    Comments

    [swarming] use var for luci-go CIPD package version
    
    This is to simplify DEPS and enforce to use the same revision for each luci-go
    client.
    
    Change-Id: Ibb642840e09fe83f8736dbf86ab73f00154b0843
    Reviewed-on: https://chromium-review.googlesource.com/c/1364998
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614349}

    Changed files

    • DEPS
  28. Roll src/third_party/chromite d138913917ce..71928dd258ca (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:57:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b3c027024066455b2eac2cff1e5d970d2bb2fea

    Comments

    Roll src/third_party/chromite d138913917ce..71928dd258ca (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/d138913917ce..71928dd258ca
    
    
    git log d138913917ce..71928dd258ca --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 dhanyaganesh@chromium.org lib/cidb.py: Delete functions used in bad_cl_detector
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@71928dd258ca
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Ice83d4eef69c02fcd84486fabe2d28c58eed7cd7
    Reviewed-on: https://chromium-review.googlesource.com/c/1365419
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614348}

    Changed files

    • DEPS
  29. Worker: Move shared_worker_connector.mojom from content/ to blink/ (Onion Soup)

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:55:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0e677766dedb2399fee8e8f3676eb1b2fc8b8953

    Comments

    Worker: Move shared_worker_connector.mojom from content/ to blink/ (Onion Soup)
    
    Bug: 911415
    Change-Id: Ifab02f8eccba1f2501400150d9aa563e88f44ac8
    Reviewed-on: https://chromium-review.googlesource.com/c/1365105
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614347}

    Changed files

    • content/browser/worker_host/shared_worker_connector_impl.cc
    • content/browser/worker_host/shared_worker_connector_impl.h
    • content/browser/worker_host/shared_worker_service_impl.h
    • content/browser/worker_host/shared_worker_service_impl_unittest.cc
    • content/common/BUILD.gn
    • content/public/app/mojo/content_browser_manifest.json
    • content/renderer/shared_worker/shared_worker_repository.h
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/worker/shared_worker_connector.mojom
    • tools/metrics/histograms/enums.xml
  30. Roll src-internal 8807e6de3a17..44685896babc (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:53:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c97bac91ae2029a5ad29114325f796b7888fdc0

    Comments

    Roll src-internal 8807e6de3a17..44685896babc (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8807e6de3a17..44685896babc
    
    
    Created with:
      gclient setdep -r src-internal@44685896babc
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: If1245f560fc46b4b68ad7243540bdeaaf2b309ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1365420
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614346}

    Changed files

    • DEPS
  31. Automated Commit: LKGM 11355.0.0 for chromeos.

    Changed by 3su6n15k.default@developer.gserviceaccount.com - 3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:52:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 043caffb8b4e36858d3f4da8762f092cec06b3a6

    Comments

    Automated Commit: LKGM 11355.0.0 for chromeos.
    
    BUG=762641
    TBR=stevenjb@chromium.org
    
    Change-Id: I2d05b9f382d1b86bf0aebf1b8418417f062d759e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365550
    Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614345}

    Changed files

    • chromeos/CHROMEOS_LKGM
  32. Add host checking on module-managed URLs again a static host list.

    Changed by chuanl - chuanlohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 14:50:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac56ab76f720b0ed9361f4976e6db1d13fb52853

    Comments

    Add host checking on module-managed URLs again a static host list.
    
    Besides checking hosts and paths against intent extras, this CL
    specifically checks for HTTPS scheme on module-managed URLs.
    CustomTabActivityTest is also updated to use HTTPS test server
    for all tests that are dynamic module related.
    
    This is guarded by the CCTModuleCustomHeader Finch feature.
    
    Bug: 882404
    Change-Id: I24d3e5b16762818ba330ad8f9c0f030eaf9d82e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1361065
    Commit-Queue: John Lin <chuanl@google.com>
    Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614344}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsDynamicModuleTestUtils.java
  33. Roll src/third_party/webrtc fafae11bfc4c..628f37a6fe24 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:46:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7c100291e910c399ebd733edf3b23ba1483c6843

    Comments

    Roll src/third_party/webrtc fafae11bfc4c..628f37a6fe24 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/fafae11bfc4c..628f37a6fe24
    
    
    git log fafae11bfc4c..628f37a6fe24 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 hta@webrtc.org Delete a cricket::DtlsTransport when PC is closed
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@628f37a6fe24
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:907849
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ie1e59d6a33a293fd29401a6f788a14412896c3cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1365418
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614343}

    Changed files

    • DEPS
  34. MockClock for ScopedTaskEnvironment

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 14:45:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6f990329d1059f1ae594ffbe6c70c46c10257a2

    Comments

    MockClock for ScopedTaskEnvironment
    
    Add the option to get a MockClock that is in sync with the underlying
    MockTickClock that ScopedTaskEnvironment uses. Some test need access to
    a base::Clock and ScopedTaskEnvironment currently just provides a
    MockTickClock.
    
    Need for this araised while refactoring
    components/ntp_snippets/breaking_news/breaking_news_gcm_app_handler_unittest.cc
    to use ScopedTaskEnvironment instead of MessageLoop.
    
    Bug: 891670
    Change-Id: I0716dbe2b46e268dfe57bed7c667d275f62519af
    Reviewed-on: https://chromium-review.googlesource.com/c/1356553
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614342}

    Changed files

    • base/test/scoped_task_environment.cc
    • base/test/scoped_task_environment.h
    • base/test/scoped_task_environment_unittest.cc
  35. Snav: Search inside focused scroll containers

    Changed by JunHo Seo - junho0924.seoohnoyoudont@lge.com
    Changed at Thursday, 06-Dec-18 14:43:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d17b741996e047d7aaf439dcb22ef7359e8f52b

    Comments

    Snav: Search inside focused scroll containers
    
    Previously, spatial navigation could not navigate inside a focused
    container. This change makes spatnav first search (or scroll) a
    focused scroll container, before searching outside of it:
    
    (1) Search for focusable elements inside any focused container.
    (2) If step (1) couldn't find a candidate, try to scroll the container.
    (3) If step (2) couldn't scroll, search for focusable elements outside
        the container.
    
    This follows the design document: https://bit.ly/snav2.
    
    Bug: 821297
    Change-Id: I81ab360dac5ee865e34c0f840378c9a637a8fe89
    Reviewed-on: https://chromium-review.googlesource.com/c/960185
    Commit-Queue: JunHo Seo <junho0924.seo@lge.com>
    Reviewed-by: Fredrik Söderquist <fs@opera.com>
    Reviewed-by: Hugo Holgersson <hugoh@vewd.com>
    Cr-Commit-Position: refs/heads/master@{#614341}

    Changed files

    • third_party/blink/renderer/core/page/focus_controller.cc
    • third_party/blink/web_tests/fast/spatial-navigation/resources/snav-testharness.js
    • third_party/blink/web_tests/fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html
    • third_party/blink/web_tests/fast/spatial-navigation/snav-dont-search-focused-offscreen-scroller.html
    • third_party/blink/web_tests/fast/spatial-navigation/snav-search-focused-scroller-first.html
  36. Refactor the "is incremental marking" counter into an "entry flag" class.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:43:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 12ea27e64fc74784c517bc88488503d064204143

    Comments

    Refactor the "is incremental marking" counter into an "entry flag" class.
    
    1. Switch to <atomic>, which is the future of atomics in Blink.
    
    2. Since this logic is subtle, it is factored out into a separate class
       with a verbose comment, explaining why its semantics are correct.
    
    3. Since the load didn't previously synchronize with the store, and the
       only requirement a thread has is that it sees its own writes (and the
       data doesn't become corrupt), std::memory_order_relaxed is used for
       all accesses.
    
    Bug: 736037
    Change-Id: I017da1ebfba3e95e5d0393014dc57fb4958bd6b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1364151
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614340}

    Changed files

    • third_party/blink/renderer/platform/heap/BUILD.gn
    • third_party/blink/renderer/platform/heap/atomic_entry_flag.h
    • third_party/blink/renderer/platform/heap/thread_state.cc
    • third_party/blink/renderer/platform/heap/thread_state.h
  37. Remove FetchContext::recordDataUriWithOctothorpe

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:40:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7969a55cf2c0369dbcc3f409ee2cc5e84139d31

    Comments

    Remove FetchContext::recordDataUriWithOctothorpe
    
    Use FetchCountext::CountUsage instead.
    
    Bug: 123004
    Change-Id: I0809339a59bb6b3e29bf364923502af5c83a5f07
    Reviewed-on: https://chromium-review.googlesource.com/c/1364997
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614339}

    Changed files

    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_context.h
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
  38. [Mfill Android] Wrap AccessorySheetTab data by type

    Changed by Friedrich Horschig - fhorschigohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:36:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb8587a0131ab38c4c17164c60edc2860e5ff063

    Comments

    [Mfill Android] Wrap AccessorySheetTab data by type
    
    This CL adds the new representation for tab data next to the existing
    one. This ensures that the old UI still works and the new UI is
    completely guarded by #autofill-keyboard-accessory-view.
    
    The actual drawing of the elements follows in crrev.com/c/1356547.
    
    Bug: 853772, 911084
    Change-Id: Ia38706aefb687fbe704b62307fa7d793a9b45c36
    Reviewed-on: https://chromium-review.googlesource.com/c/1350875
    Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614338}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetProperties.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java
  39. Android: Set strip_absolute_paths_from_debug_symbols=true by default

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:32:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 028bb8405dfce446318d32755e9649b127359091

    Comments

    Android: Set strip_absolute_paths_from_debug_symbols=true by default
    
    Supposed to improve goma cache hit rate. I found gdb debugging still
    works with it enabled.
    
    Bug: 439949
    Change-Id: Ia78ae57e5eb84fa8fb8bbb3c6bb15ea7814932bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1364692
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614337}

    Changed files

    • build/config/compiler/BUILD.gn
  40. Roll src/third_party/skia 7c4a9b7c7e0e..7b7ab595d908 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:22:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 39e5800574050534d2b70aa6e7da7b010f57dfac

    Comments

    Roll src/third_party/skia 7c4a9b7c7e0e..7b7ab595d908 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/7c4a9b7c7e0e..7b7ab595d908
    
    
    git log 7c4a9b7c7e0e..7b7ab595d908 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 reed@google.com SkRunFont is gone, there is only SkFont
    
    
    Created with:
      gclient setdep -r src/third_party/skia@7b7ab595d908
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Id40b7d9fe6a9513d6352c50b6624fa0e436fa3b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1365417
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614336}

    Changed files

    • DEPS
  41. Deflake RenderWidgetHostViewMacTest.TimerBasedPhaseInfo

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:20:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b9d64e613231dffb7a26caf88dcaa909d0a4407

    Comments

    Deflake RenderWidgetHostViewMacTest.TimerBasedPhaseInfo
    
    This test relies on the ordering of delayed and non-delayed tasks
    which is a mistake. Changeing it to quit after all tasks have
    run makes it reliable.
    
    TBR=asvitkine@chromium.org
    
    Bug: 863341, 891670
    Change-Id: Id8dcbda9359a3adcf9688973457edf146d1d070f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365447
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614335}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
  42. Form-associated custom elements: Fix missing validation bubble

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 14:18:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2e6eb70fa0fe55992e61f7b0dc3179f9cd844193

    Comments

    Form-associated custom elements: Fix missing validation bubble
    
    - Override validationMessage() and ValidationSubMessage() to return
      correct strings
    
    - ValidationMessaeClientImpl doesn't reject display:inline anchor
      elements.
    
    Bug: 905922
    Bug: https://github.com/w3c/webcomponents/issues/187
    Change-Id: Ie743d6018bb38f30db0b8624a6313519dd5737f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1365108
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614334}

    Changed files

    • third_party/blink/renderer/core/html/custom/element_internals.cc
    • third_party/blink/renderer/core/html/custom/element_internals.h
    • third_party/blink/renderer/core/page/validation_message_client_impl.cc
    • third_party/blink/web_tests/custom-elements/form-validation-bubble-appearance-expected.txt
    • third_party/blink/web_tests/custom-elements/form-validation-bubble-appearance.html
    • third_party/blink/web_tests/platform/linux/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.10/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.11/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.12/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/mac/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/win/custom-elements/form-validation-bubble-appearance-expected.png
    • third_party/blink/web_tests/platform/win7/custom-elements/form-validation-bubble-appearance-expected.png
  43. Roll src/third_party/perfetto c30ed73dd52a..659c1b009ec3 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 14:08:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b51a676e5e3d26f8d48ca9e6fb906f6dd88756ce

    Comments

    Roll src/third_party/perfetto c30ed73dd52a..659c1b009ec3 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/c30ed73dd52a..659c1b009ec3
    
    
    git log c30ed73dd52a..659c1b009ec3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 fmayer@google.com Merge "Bump libunwindstack version."
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@659c1b009ec3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I630fd97193f894a0e0cbe60330730e616ab39f65
    Reviewed-on: https://chromium-review.googlesource.com/c/1365415
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614333}

    Changed files

    • DEPS
  44. Roll src-internal eb2f2ad6ffdf..8807e6de3a17 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 13:53:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 37a6700f01fadc319384c011beb86db7515ade14

    Comments

    Roll src-internal eb2f2ad6ffdf..8807e6de3a17 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb2f2ad6ffdf..8807e6de3a17
    
    
    Created with:
      gclient setdep -r src-internal@8807e6de3a17
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia5bde08c98963dcef9b75753e08be31595dac2af
    Reviewed-on: https://chromium-review.googlesource.com/c/1365416
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614332}

    Changed files

    • DEPS
  45. Require that .pak files are successfully loaded.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:26:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a706d62ed54b601a3527b61a7f89b17564c262e0

    Comments

    Require that .pak files are successfully loaded.
    
    Several test suites relied on the common resources .pak being unsuccessfully
    loaded in order to function correctly. On Android, .pak files can leak between
    successive runs of different test suites, which would cause flaky test failures.
    This CL makes it so that failing to load the common resources .pak file will hit
    a DCHECK. This CL fixes several instances where test suites were incorrectly
    trying to load [and failing to load] the common resources .pak file.
    
    Change-Id: I5294f921e42524b699c7019b7a56c0a30106c89c
    Bug: 906587
    Reviewed-on: https://chromium-review.googlesource.com/c/1363447
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614331}

    Changed files

    • components/ntp_tiles/icon_cacher_impl_unittest.cc
    • ui/base/resource/resource_bundle_android.cc
    • ui/base/test/run_all_unittests.cc
  46. SequenceManagerImpl::IsIdleForTesting to match MessageLoop behavior

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:22:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1dc884dc9ff9b74841192d420479197f80c3ac9c

    Comments

    SequenceManagerImpl::IsIdleForTesting to match MessageLoop behavior
    
    The MessageLoop version of IsIdleForTesting does not take Now() into
    account, but the SequenceManager version was.  This is a mistake
    because its flaky when there are delayed tasks that are just about
    to run.
    
    TBR=fdoray@chromium.org
    
    Bug: 910645, 863341, 891670
    Change-Id: Ieaf5e534df0f553046b76fa844f61e4a268082f9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365233
    Reviewed-by: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614330}

    Changed files

    • base/message_loop/message_loop_unittest.cc
    • base/task/sequence_manager/sequence_manager.h
    • base/task/sequence_manager/sequence_manager_impl.cc
  47. Change interleaving of delayed and immediate tasks to match MessageLoop

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:20:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dda57a2c6aa319675172f8558ce8c24d9333f894

    Comments

    Change interleaving of delayed and immediate tasks to match MessageLoop
    
    Previously the TaskQueueSelector would allow up to 3 delayed tasks to
    run for every immediate task if both where ready to run.  This patch
    changes it to a 1:1 ratio like the MessageLoop.  NB neither the
    SequenceManager nor the MessageLoop allow delayed tasks to skip ahead
    of immediate tasks.
    
    In addition I've removed the PrioritizingSelector inner class which makes
    the code a bit more readable.  In addition based on review comments I
    changed the style of functions to return a pointer to the WorkQueue or
    null rather than a bool. This in general improves readability.
    
    Bug: 863341, 891670
    Change-Id: I61d4f118880f109c01ad4a2d5301acc9103b0b35
    Reviewed-on: https://chromium-review.googlesource.com/c/1361103
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614329}

    Changed files

    • base/task/sequence_manager/sequence_manager_impl.cc
    • base/task/sequence_manager/sequence_manager_impl.h
    • base/task/sequence_manager/sequence_manager_impl_unittest.cc
    • base/task/sequence_manager/task_queue_selector.cc
    • base/task/sequence_manager/task_queue_selector.h
    • base/task/sequence_manager/task_queue_selector_unittest.cc
    • base/task/sequence_manager/work_queue_sets.cc
    • base/task/sequence_manager/work_queue_sets.h
    • base/task/sequence_manager/work_queue_sets_unittest.cc
    • base/task/sequence_manager/work_queue_unittest.cc
    • third_party/blink/web_tests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt
  48. use SkFont for measure and break text

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 13:09:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15ec682801537617ba819e09336399a51e45bf82

    Comments

    use SkFont for measure and break text
    
    TBR=
    
    Bug: skia:2664
    Change-Id: Idf2e2d1c4eefd295d4262a0b49542c83119f639f
    Reviewed-on: https://chromium-review.googlesource.com/c/1363212
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614328}

    Changed files

    • cc/layers/heads_up_display_layer_impl.cc
    • media/blink/webmediaplayer_cast_android.cc
  49. [s13n] Convert account_reconcilor_unittest.cc to IdentityManager

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Thursday, 06-Dec-18 13:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d46e46ee383877ad62974bf266d5bbc96c2f056

    Comments

    [s13n] Convert account_reconcilor_unittest.cc to IdentityManager
    
    This CL migrates (most of) account_reconcilor_unittest.cc code
    away from SigninManager and PO2TS.
    Production code was migrated and unit tests were minimally updated
    to keep running in [1].
    
    Remarks:
    - The CL can completely remove SigninManager direct API calls.
    - The CL could not completely remove direct PO2TS API calls, due to two
    missing API: set_all_credentials_loaded_for_testing and LoadCredentials.
    - Given how the test uses gaia_id to manipulate reconciles and how
    IdentityTestEnvironment hides setting the gaia_id from the tests,
    there were some adaptations needed so that the functionalities could
    continue fully tested. For instance, the following methods were added/
    used:
    
    * GaiaIdForAccountKey: Added.
    * identity::GetTestGaiaIdForEmail: Referenced.
    
    [1] https://chromium-review.googlesource.com/c/1330223
    
    BUG=910581
    
    Change-Id: I58db6044caa22b6072cb6d22dd7c97c668c46cd3
    Reviewed-on: https://chromium-review.googlesource.com/c/1357059
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#614327}

    Changed files

    • components/signin/core/browser/account_reconcilor_unittest.cc
  50. Roll src/third_party/webrtc 518add35a8f3..fafae11bfc4c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 13:04:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 345809a783fb9cf763ca8e46c49ff17d9cc56bcf

    Comments

    Roll src/third_party/webrtc 518add35a8f3..fafae11bfc4c (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/518add35a8f3..fafae11bfc4c
    
    
    git log 518add35a8f3..fafae11bfc4c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 terelius@webrtc.org Allow parsing RTC event logs without a transaction ID.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@fafae11bfc4c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I2becf74e5f60f900df64e46c4e9a20b4e5603999
    Reviewed-on: https://chromium-review.googlesource.com/c/1365414
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614326}

    Changed files

    • DEPS
  51. Roll src-internal ddbf9b06e56d..eb2f2ad6ffdf (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 12:49:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6b7b1e666839441d358ae9d6278f1bb51dc6731b

    Comments

    Roll src-internal ddbf9b06e56d..eb2f2ad6ffdf (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddbf9b06e56d..eb2f2ad6ffdf
    
    
    Created with:
      gclient setdep -r src-internal@eb2f2ad6ffdf
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I641322947d4d0b62fb0cf79fc9ae43742fb6b51e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365413
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614325}

    Changed files

    • DEPS
  52. Update description of BrowsingDataCounter's |pref_|

    Changed by Huanzhong Huang - huanzhongohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 12:27:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d45ef23cc4d0ce5a4cba1b1433c55e319cb2222a

    Comments

    Update description of BrowsingDataCounter's |pref_|
    
    Remove part of the description of BrowsingDataCounter's |pref_| that's no longer true and irrelevant.
    
    Bug: none
    Change-Id: Ibfb47522b33b5ca92f9e29191c79b7070d425e38
    Reviewed-on: https://chromium-review.googlesource.com/c/1358459
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614324}

    Changed files

    • components/browsing_data/core/counters/browsing_data_counter.h
  53. [signin] Delete DiceFixAuthErrors

    Changed by David Roger - drogerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 12:22:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 153707e1531f4233168575401a73ad4568ab5caa

    Comments

    [signin] Delete DiceFixAuthErrors
    
    This configuration is no longer enabled on any platforms.
    The code can now be removed.
    
    TBR=sky
    
    Bug: 777774
    Change-Id: Id92ef784e3ae933b21d96f8fd39deba1a4fa67a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1355189
    Commit-Queue: David Roger <droger@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614323}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/extensions/api/identity/identity_api.cc
    • chrome/browser/extensions/api/identity/identity_api_unittest.cc
    • chrome/browser/signin/account_consistency_mode_manager.cc
    • chrome/browser/signin/account_consistency_mode_manager.h
    • chrome/browser/signin/account_consistency_mode_manager_unittest.cc
    • chrome/browser/signin/account_reconcilor_factory.cc
    • chrome/browser/signin/chrome_signin_helper_unittest.cc
    • chrome/browser/signin/dice_browsertest.cc
    • chrome/browser/signin/dice_response_handler.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
    • chrome/browser/signin/process_dice_header_delegate_impl.cc
    • chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
    • chrome/browser/signin/scoped_account_consistency.cc
    • chrome/browser/signin/scoped_account_consistency.h
    • chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc
    • chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
    • chrome/browser/ui/webui/settings/people_handler_unittest.cc
    • components/signin/core/browser/about_signin_internals.cc
    • components/signin/core/browser/account_consistency_method.h
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/dice_account_reconcilor_delegate.cc
    • components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
    • components/signin/core/browser/dice_header_helper.cc
    • components/signin/core/browser/signin_header_helper_unittest.cc
  54. Deflake AddFirstWallpaperAnimationEndCallback test

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 12:18:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82b82a8b8c4115741888bb0dfe3fcd439cff51e5

    Comments

    Deflake AddFirstWallpaperAnimationEndCallback test
    
    This test is currently flaky because it relies upon the ordering
    of delayed and non delayed tasks to quit a run loop before the
    very short (0.01s) animation delay is up. This patch deflakes it by
    temporarily freezing time to prevent the animation from
    completing before the test expects it to.
    
    TBR=wzang@chromium.org
    
    Bug: 863341, 891670, 910493
    Change-Id: I34cf2824c387c380134eb38b3375e6ab79de4be8
    Reviewed-on: https://chromium-review.googlesource.com/c/1365244
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614322}

    Changed files

    • ash/wallpaper/wallpaper_controller_unittest.cc
  55. Fix race in scheduler fuzzer

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 12:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7333851526d00cee593ca114d3394f77236fcaf8

    Comments

    Fix race in scheduler fuzzer
    
    ThreadManager instances are created on the new thread and thus their
    thread_manager_ member might not be initialized when GetThreadManagerFor
    is called.
    
    This patch addresses that issue by having two different containers. One
    to keep track of threads and the other for keeping track of all the
    ThreadManager instances.
    
    This code could use some nice refactoring, this patch just tries to do
    the minimum changes to get rid of the race.
    
    Bug: 906468
    Change-Id: Ie39f5a6a18111248c4f83264f6adcdaef4befa23
    Reviewed-on: https://chromium-review.googlesource.com/c/1365442
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614321}

    Changed files

    • third_party/blink/renderer/platform/scheduler/test/fuzzer/sequence_manager_fuzzer_processor.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/sequence_manager_fuzzer_processor_unittest.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/simple_thread_impl.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/simple_thread_impl.h
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/thread_pool_manager.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/thread_pool_manager.h
  56. Roll src/third_party/catapult 924d5cbc6627..285509d0e41e (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 12:14:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24c8eb2bc2374d9dbcbf8ba39a1ad61cdb2d92e4

    Comments

    Roll src/third_party/catapult 924d5cbc6627..285509d0e41e (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/924d5cbc6627..285509d0e41e
    
    
    git log 924d5cbc6627..285509d0e41e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 dtu@chromium.org [pinpoint] Add cpython to CIPD packages for Swarming tasks.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@285509d0e41e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:911511
    TBR=sullivan@chromium.org
    
    Change-Id: If17883c4c319c61a837806e819bd0b6c4bdbee28
    Reviewed-on: https://chromium-review.googlesource.com/c/1365412
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614320}

    Changed files

    • DEPS
  57. Roll src/third_party/webrtc c60a77731d68..518add35a8f3 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:51:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9578862335ad0c8697867c4e8a3aedce9746bd7d

    Comments

    Roll src/third_party/webrtc c60a77731d68..518add35a8f3 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/c60a77731d68..518add35a8f3
    
    
    git log c60a77731d68..518add35a8f3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 68c6b982a7..d6dec3971c (614157:614285)
    2018-12-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 48afe1fce1..68c6b982a7 (614046:614157)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@518add35a8f3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ie8e88fd34dcfea01fdf9936668312881d8648d7e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365490
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614319}

    Changed files

    • DEPS
  58. Roll src-internal ed9aa80dbd6e..ddbf9b06e56d (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:44:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3ab799cfe5c295341dd092769ec59df1d10b5e2

    Comments

    Roll src-internal ed9aa80dbd6e..ddbf9b06e56d (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed9aa80dbd6e..ddbf9b06e56d
    
    
    Created with:
      gclient setdep -r src-internal@ddbf9b06e56d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib4c1d177947f216078337b7a96776a364e186e1e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365491
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614318}

    Changed files

    • DEPS
  59. Enable gold linker for arm64 linux builds

    Changed by Dániel Bátyai - dbatyaiohnoyoudont@inf.u-szeged.hu
    Changed at Thursday, 06-Dec-18 11:42:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 55fbf5947b5c36906b186bed99b4d029f87d4df3

    Comments

    Enable gold linker for arm64 linux builds
    
    Arm64 builds for chromeos do not currently use gold when linking.
    This change enables gold, which results in smaller binary size.
    
    Bug: 878565
    Change-Id: I70f24490ac010ce58bcc6fd1441ade63288147ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1341913
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Peter Gal <pgal.u-szeged@partner.samsung.com>
    Cr-Commit-Position: refs/heads/master@{#614317}

    Changed files

    • build/config/compiler/compiler.gni
  60. Roll src/third_party/skia 6d59568196c0..7c4a9b7c7e0e (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:34:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e853d5eefbfcfc22851ff8b2f11f669cfa657207

    Comments

    Roll src/third_party/skia 6d59568196c0..7c4a9b7c7e0e (3 commits)
    
    https://skia.googlesource.com/skia.git/+log/6d59568196c0..7c4a9b7c7e0e
    
    
    git log 6d59568196c0..7c4a9b7c7e0e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 96bd8fdf36e5..8f1b7a66a5e3 (3 commits)
    2018-12-06 herb@google.com Embed SkPath in SkGlyph::PathData
    
    
    Created with:
      gclient setdep -r src/third_party/skia@7c4a9b7c7e0e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: I498a50fb1a2fc65424f50214ad9a19d1a004788c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365171
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614316}

    Changed files

    • DEPS
  61. Import wpt@0347da3996b8eb6c4aef1104291efcc5d5356e6d

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:25:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00c7d1a7ee854a01504eff67389ce6bf972fbb5b

    Comments

    Import wpt@0347da3996b8eb6c4aef1104291efcc5d5356e6d
    
    Using wpt-import in Chromium 8fea47aacf80c5e06dc7246a9b3673525cf14b62.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=raphael.kubo.da.costa
    
    No-Export: true
    Change-Id: I1f6ad756eb6eafe1416332c08f6f9edd7b030f93
    Reviewed-on: https://chromium-review.googlesource.com/c/1365077
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614315}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.serviceworker-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.sharedworker-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.worker-expected.txt
    • third_party/blink/web_tests/external/wpt/interfaces/event-timing.idl
  62. [iOS] Disable omnibox drag on iPhone

    Changed by Robbie Gibson - rkgibsonohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 11:14:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b3f8cea2710992c552785fa2a57097576acce3e

    Comments

    [iOS] Disable omnibox drag on iPhone
    
    This CL disables dragging text out of the omnibox on iPhone because
    there is nowhere to drag the text to.
    
    Bug: 834778
    Change-Id: Ic5c731b8c5400c40e7357c5ff25e5a8e45f3e544
    Reviewed-on: https://chromium-review.googlesource.com/c/1363194
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Commit-Queue: Robbie Gibson <rkgibson@google.com>
    Cr-Commit-Position: refs/heads/master@{#614314}

    Changed files

    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
  63. Roll src/third_party/catapult c7cc237f9582..924d5cbc6627 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 10:57:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d63eb573db6815ebb2c6820a45edec85b8da77d

    Comments

    Roll src/third_party/catapult c7cc237f9582..924d5cbc6627 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/c7cc237f9582..924d5cbc6627
    
    
    git log c7cc237f9582..924d5cbc6627 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 benjhayden@chromium.org Add alerts-section for v2spa.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@924d5cbc6627
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: I3ce19b927d52a7efb70f97d51f37cdb8bb4a68d0
    Reviewed-on: https://chromium-review.googlesource.com/c/1365170
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614313}

    Changed files

    • DEPS
  64. sqlite: Upgrade from 3.25.3 to 3.26.0

    Changed by Victor Costan - pwnallohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:57:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c2a181a431696385df115c024debb2ca46bb362

    Comments

    sqlite: Upgrade from 3.25.3 to 3.26.0
    
    This CL removes the following patches:
    
    * patches/0006-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch
      was superseded by https://www.sqlite.org/src/info/6f4b0d0494446d46
    * patches/0009-Fix-ossfuzz.c-to-compile-and-run-with-our-config.patch
      was superseded by https://www.sqlite.org/src/info/d343f7d6b05865c2
    * patches/0010-Backport-Windows-VFS-mmap-fix.patch was a backport of
      3.26.0 change https://sqlite.org/src/info/ffce4aac18dacbf2
    
    This CL adds a workaround to our wrapper for SQLite's main header. The
    workaround is needed by the change at
    https://www.sqlite.org/src/info/d584a0cb51281594 which fixes a bug that
    was preventing us from building the SQLite shell on Windows.
    
    The most attractive feature in this version is the introduction of the
    SQLITE_DBCONFIG_DEFENSIVE config flag [1]. The flag will be enabled in a
    follow-up CL, after the upgrade proves stable.
    
    [1] https://www.sqlite.org/c3ref/c_dbconfig_defensive.html
    
    Bug: 910906
    Change-Id: I046dc5a1419188bb93be24fe0edaf536411d100d
    Reviewed-on: https://chromium-review.googlesource.com/c/1357358
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Chris Mumford <cmumford@google.com>
    Cr-Commit-Position: refs/heads/master@{#614312}

    Changed files

    • third_party/sqlite/README.chromium
    • third_party/sqlite/amalgamation/rename_exports.h
    • third_party/sqlite/amalgamation/shell/shell.c
    • third_party/sqlite/amalgamation/sqlite3.c
    • third_party/sqlite/amalgamation/sqlite3.h
    • third_party/sqlite/patches/0001-test-SQLite-tests-compiling-on-Linux.patch
    • third_party/sqlite/patches/0002-Modify-default-VFS-to-support-WebDatabase.patch
    • third_party/sqlite/patches/0003-Virtual-table-supporting-recovery-of-corrupted-datab.patch
    • third_party/sqlite/patches/0004-Custom-shell.c-helpers-to-load-Chromium-s-ICU-data.patch
    • third_party/sqlite/patches/0005-fts3-Disable-fts3_tokenizer-and-fts4.patch
    • third_party/sqlite/patches/0006-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch
    • third_party/sqlite/patches/0006-fuchsia-Use-dot-file-locking-for-sqlite.patch
    • third_party/sqlite/patches/0008-Fix-ossfuzz.c-to-compile-and-run-with-our-config.patch
    • third_party/sqlite/patches/0009-Backport-Windows-VFS-mmap-fix.patch
    • third_party/sqlite/sqlite3.h
    • third_party/sqlite/src/Makefile.in
    • third_party/sqlite/src/Makefile.msc
    • third_party/sqlite/src/VERSION
    • third_party/sqlite/src/configure
    • third_party/sqlite/src/doc/lemon.html
    • third_party/sqlite/src/ext/expert/sqlite3expert.c
    • third_party/sqlite/src/ext/fts3/fts3.c
    • third_party/sqlite/src/ext/fts3/fts3Int.h
    • third_party/sqlite/src/ext/fts3/fts3_aux.c
    • third_party/sqlite/src/ext/fts3/fts3_term.c
    • third_party/sqlite/src/ext/fts3/fts3_tokenize_vtab.c
    • third_party/sqlite/src/ext/fts5/fts5_index.c
    • third_party/sqlite/src/ext/fts5/fts5_main.c
    • third_party/sqlite/src/ext/fts5/fts5_test_tok.c
    • third_party/sqlite/src/ext/fts5/fts5_vocab.c
    • third_party/sqlite/src/ext/fts5/test/fts5aa.test
    • third_party/sqlite/src/ext/fts5/test/fts5connect.test
    • third_party/sqlite/src/ext/fts5/test/fts5corrupt.test
    • third_party/sqlite/src/ext/fts5/test/fts5corrupt2.test
    • third_party/sqlite/src/ext/fts5/test/fts5corrupt3.test
    • third_party/sqlite/src/ext/fts5/test/fts5first.test
    • third_party/sqlite/src/ext/fts5/test/fts5integrity.test
    • third_party/sqlite/src/ext/fts5/test/fts5rank.test
    • third_party/sqlite/src/ext/fts5/test/fts5rebuild.test
    • third_party/sqlite/src/ext/fts5/test/fts5rowid.test
    • third_party/sqlite/src/ext/fts5/test/fts5version.test
    • third_party/sqlite/src/ext/fts5/test/fts5vocab.test
    • third_party/sqlite/src/ext/fts5/test/fts5vocab2.test
    • third_party/sqlite/src/ext/misc/amatch.c
    • third_party/sqlite/src/ext/misc/btreeinfo.c
    • third_party/sqlite/src/ext/misc/closure.c
    • third_party/sqlite/src/ext/misc/completion.c
    • third_party/sqlite/src/ext/misc/csv.c
    • third_party/sqlite/src/ext/misc/explain.c
    • third_party/sqlite/src/ext/misc/fileio.c
    • third_party/sqlite/src/ext/misc/json1.c
    • third_party/sqlite/src/ext/misc/memstat.c
    • third_party/sqlite/src/ext/misc/series.c
    • third_party/sqlite/src/ext/misc/sha1.c
    • third_party/sqlite/src/ext/misc/shathree.c
    • third_party/sqlite/src/ext/misc/spellfix.c
    • third_party/sqlite/src/ext/misc/stmt.c
    • third_party/sqlite/src/ext/misc/templatevtab.c
    • third_party/sqlite/src/ext/misc/unionvtab.c
    • third_party/sqlite/src/ext/misc/vtablog.c
    • third_party/sqlite/src/ext/misc/zipfile.c
    • third_party/sqlite/src/ext/rbu/rbu1.test
    • third_party/sqlite/src/ext/rbu/rbu10.test
    • third_party/sqlite/src/ext/rbu/rbu11.test
    • third_party/sqlite/src/ext/rbu/rbu12.test
    • third_party/sqlite/src/ext/rbu/rbu13.test
    • third_party/sqlite/src/ext/rbu/rbu14.test
    • third_party/sqlite/src/ext/rbu/rbu3.test
    • third_party/sqlite/src/ext/rbu/rbu5.test
    • third_party/sqlite/src/ext/rbu/rbu6.test
    • third_party/sqlite/src/ext/rbu/rbu7.test
    • third_party/sqlite/src/ext/rbu/rbu8.test
    • third_party/sqlite/src/ext/rbu/rbu9.test
    • third_party/sqlite/src/ext/rbu/rbuA.test
    • third_party/sqlite/src/ext/rbu/rbuB.test
    • third_party/sqlite/src/ext/rbu/rbuC.test
    • third_party/sqlite/src/ext/rbu/rbucollate.test
    • third_party/sqlite/src/ext/rbu/rbucrash.test
    • third_party/sqlite/src/ext/rbu/rbucrash2.test
    • third_party/sqlite/src/ext/rbu/rbudiff.test
    • third_party/sqlite/src/ext/rbu/rbudor.test
    • third_party/sqlite/src/ext/rbu/rbufault.test
    • third_party/sqlite/src/ext/rbu/rbufault2.test
    • third_party/sqlite/src/ext/rbu/rbufault3.test
    • third_party/sqlite/src/ext/rbu/rbufault4.test
    • third_party/sqlite/src/ext/rbu/rbufts.test
    • third_party/sqlite/src/ext/rbu/rbumulti.test
    • third_party/sqlite/src/ext/rbu/rbuprogress.test
    • third_party/sqlite/src/ext/rbu/rburesume.test
    • third_party/sqlite/src/ext/rbu/rbusave.test
    • third_party/sqlite/src/ext/rbu/rbusplit.test
    • third_party/sqlite/src/ext/rbu/rbutemplimit.test
    • third_party/sqlite/src/ext/rbu/rbuvacuum.test
    • third_party/sqlite/src/ext/rbu/rbuvacuum2.test
    • third_party/sqlite/src/ext/rbu/sqlite3rbu.c
    • third_party/sqlite/src/ext/repair/test/checkindex01.test
    • third_party/sqlite/src/ext/rtree/geopoly.c
    • third_party/sqlite/src/ext/rtree/rtree.c
    • third_party/sqlite/src/ext/rtree/rtree8.test
    • third_party/sqlite/src/ext/rtree/rtreeA.test
    • third_party/sqlite/src/ext/rtree/rtreecheck.test
    • third_party/sqlite/src/ext/rtree/sqlite3rtree.h
    • third_party/sqlite/src/ext/rtree/visual01.txt
    • third_party/sqlite/src/ext/session/changesetfuzz.c
    • third_party/sqlite/src/ext/session/changesetfuzz1.test
    • third_party/sqlite/src/ext/session/session1.test
    • third_party/sqlite/src/ext/session/sessionC.test
    • third_party/sqlite/src/ext/session/sessionD.test
    • third_party/sqlite/src/ext/session/sessionE.test
    • third_party/sqlite/src/ext/session/sessionF.test
    • third_party/sqlite/src/ext/session/sessionG.test
    • third_party/sqlite/src/ext/session/sessionH.test
    • third_party/sqlite/src/ext/session/session_common.tcl
    • third_party/sqlite/src/ext/session/sessionfault2.test
    • third_party/sqlite/src/ext/session/sessioninvert.test
    • third_party/sqlite/src/ext/session/sessionrebase.test
    • third_party/sqlite/src/ext/session/sessionstat1.test
    • third_party/sqlite/src/ext/session/sessionwor.test
    • third_party/sqlite/src/ext/session/sqlite3session.c
    • third_party/sqlite/src/ext/session/sqlite3session.h
    • third_party/sqlite/src/ext/session/test_session.c
    • third_party/sqlite/src/main.mk
    • third_party/sqlite/src/manifest
    • third_party/sqlite/src/manifest.uuid
    • third_party/sqlite/src/src/alter.c
    • third_party/sqlite/src/src/attach.c
    • third_party/sqlite/src/src/auth.c
    • third_party/sqlite/src/src/btree.c
    • third_party/sqlite/src/src/build.c
    • third_party/sqlite/src/src/callback.c
    • third_party/sqlite/src/src/ctime.c
    • third_party/sqlite/src/src/dbpage.c
    • third_party/sqlite/src/src/dbstat.c
    • third_party/sqlite/src/src/delete.c
    • third_party/sqlite/src/src/expr.c
    • third_party/sqlite/src/src/fkey.c
    • third_party/sqlite/src/src/global.c
    • third_party/sqlite/src/src/hash.c
    • third_party/sqlite/src/src/insert.c
    • third_party/sqlite/src/src/loadext.c
    • third_party/sqlite/src/src/main.c
    • third_party/sqlite/src/src/os_unix.c
    • third_party/sqlite/src/src/os_win.c
    • third_party/sqlite/src/src/pager.c
    • third_party/sqlite/src/src/pager.h
    • third_party/sqlite/src/src/parse.y
    • third_party/sqlite/src/src/pcache.c
    • third_party/sqlite/src/src/pcache.h
    • third_party/sqlite/src/src/pcache1.c
    • third_party/sqlite/src/src/pragma.c
    • third_party/sqlite/src/src/pragma.h
    • third_party/sqlite/src/src/prepare.c
    • third_party/sqlite/src/src/resolve.c
    • third_party/sqlite/src/src/select.c
    • third_party/sqlite/src/src/shell.c.in
    • third_party/sqlite/src/src/sqlite.h.in
    • third_party/sqlite/src/src/sqlite3ext.h
    • third_party/sqlite/src/src/sqliteInt.h
    • third_party/sqlite/src/src/test1.c
    • third_party/sqlite/src/src/test_config.c
    • third_party/sqlite/src/src/test_intarray.c
    • third_party/sqlite/src/src/test_intarray.h
    • third_party/sqlite/src/src/test_onefile.c
    • third_party/sqlite/src/src/tokenize.c
    • third_party/sqlite/src/src/treeview.c
    • third_party/sqlite/src/src/update.c
    • third_party/sqlite/src/src/vacuum.c
    • third_party/sqlite/src/src/vdbe.c
    • third_party/sqlite/src/src/vdbeInt.h
    • third_party/sqlite/src/src/vdbeapi.c
    • third_party/sqlite/src/src/vdbeaux.c
    • third_party/sqlite/src/src/vdbemem.c
    • third_party/sqlite/src/src/vtab.c
    • third_party/sqlite/src/src/walker.c
    • third_party/sqlite/src/src/where.c
    • third_party/sqlite/src/src/whereInt.h
    • third_party/sqlite/src/src/wherecode.c
    • third_party/sqlite/src/src/whereexpr.c
    • third_party/sqlite/src/src/window.c
    • third_party/sqlite/src/test/alter.test
    • third_party/sqlite/src/test/alter2.test
    • third_party/sqlite/src/test/alterauth2.test
    • third_party/sqlite/src/test/altercol.test
    • third_party/sqlite/src/test/alterlegacy.test
    • third_party/sqlite/src/test/altermalloc.test
    • third_party/sqlite/src/test/altertab.test
    • third_party/sqlite/src/test/altertab2.test
    • third_party/sqlite/src/test/analyze.test
    • third_party/sqlite/src/test/attach.test
    • third_party/sqlite/src/test/attachmalloc.test
    • third_party/sqlite/src/test/autoinc.test
    • third_party/sqlite/src/test/autoindex5.test
    • third_party/sqlite/src/test/bestindex4.test
    • third_party/sqlite/src/test/bestindex5.test
    • third_party/sqlite/src/test/capi3.test
    • third_party/sqlite/src/test/capi3c.test
    • third_party/sqlite/src/test/corrupt.test
    • third_party/sqlite/src/test/corrupt2.test
    • third_party/sqlite/src/test/corrupt5.test
    • third_party/sqlite/src/test/corruptI.test
    • third_party/sqlite/src/test/corruptK.test
    • third_party/sqlite/src/test/countofview.test
    • third_party/sqlite/src/test/crash5.test
    • third_party/sqlite/src/test/csv01.test
    • third_party/sqlite/src/test/dbfuzz2-seed1.db
    • third_party/sqlite/src/test/dbfuzz2.c
    • third_party/sqlite/src/test/dbpage.test
    • third_party/sqlite/src/test/dbstatus.test
    • third_party/sqlite/src/test/default.test
    • third_party/sqlite/src/test/e_fkey.test
    • third_party/sqlite/src/test/e_fts3.test
    • third_party/sqlite/src/test/e_reindex.test
    • third_party/sqlite/src/test/fkey2.test
    • third_party/sqlite/src/test/fts3auto.test
    • third_party/sqlite/src/test/fts3corrupt.test
    • third_party/sqlite/src/test/fts3corrupt2.test
    • third_party/sqlite/src/test/fts3corrupt3.test
    • third_party/sqlite/src/test/fts3corrupt4.test
    • third_party/sqlite/src/test/fts3cov.test
    • third_party/sqlite/src/test/fts3d.test
    • third_party/sqlite/src/test/fts3defer.test
    • third_party/sqlite/src/test/fts3defer2.test
    • third_party/sqlite/src/test/fts3matchinfo.test
    • third_party/sqlite/src/test/fts3misc.test
    • third_party/sqlite/src/test/fts3query.test
    • third_party/sqlite/src/test/fts3snippet.test
    • third_party/sqlite/src/test/fts4check.test
    • third_party/sqlite/src/test/fts4growth.test
    • third_party/sqlite/src/test/fts4merge.test
    • third_party/sqlite/src/test/fts4opt.test
    • third_party/sqlite/src/test/fuzz_malloc.test
    • third_party/sqlite/src/test/fuzzcheck.c
    • third_party/sqlite/src/test/fuzzdata7.db
    • third_party/sqlite/src/test/incrblob_err.test
    • third_party/sqlite/src/test/incrvacuum.test
    • third_party/sqlite/src/test/index.test
    • third_party/sqlite/src/test/index3.test
    • third_party/sqlite/src/test/indexexpr2.test
    • third_party/sqlite/src/test/intarray.test
    • third_party/sqlite/src/test/lemon-test01.y
    • third_party/sqlite/src/test/like3.test
    • third_party/sqlite/src/test/loadext.test
    • third_party/sqlite/src/test/malloctraceviewer.tcl
    • third_party/sqlite/src/test/misc1.test
    • third_party/sqlite/src/test/misc4.test
    • third_party/sqlite/src/test/misc5.test
    • third_party/sqlite/src/test/misc7.test
    • third_party/sqlite/src/test/mjournal.test
    • third_party/sqlite/src/test/normalize.test
    • third_party/sqlite/src/test/notnull.test
    • third_party/sqlite/src/test/ossfuzz.c
    • third_party/sqlite/src/test/pager1.test
    • third_party/sqlite/src/test/parser1.test
    • third_party/sqlite/src/test/permutations.test
    • third_party/sqlite/src/test/pragma.test
    • third_party/sqlite/src/test/pragma3.test
    • third_party/sqlite/src/test/pragma4.test
    • third_party/sqlite/src/test/printf.test
    • third_party/sqlite/src/test/releasetest.tcl
    • third_party/sqlite/src/test/resetdb.test
    • third_party/sqlite/src/test/shared.test
    • third_party/sqlite/src/test/shared8.test
    • third_party/sqlite/src/test/shell1.test
    • third_party/sqlite/src/test/snapshot2.test
    • third_party/sqlite/src/test/snapshot3.test
    • third_party/sqlite/src/test/snapshot4.test
    • third_party/sqlite/src/test/snapshot_up.test
    • third_party/sqlite/src/test/swarmvtab3.test
    • third_party/sqlite/src/test/swarmvtabfault.test
    • third_party/sqlite/src/test/tabfunc01.test
    • third_party/sqlite/src/test/table.test
    • third_party/sqlite/src/test/tableapi.test
    • third_party/sqlite/src/test/tempdb2.test
    • third_party/sqlite/src/test/tester.tcl
    • third_party/sqlite/src/test/trigger7.test
    • third_party/sqlite/src/test/triggerA.test
    • third_party/sqlite/src/test/triggerE.test
    • third_party/sqlite/src/test/unionvtab.test
    • third_party/sqlite/src/test/unionvtabfault.test
    • third_party/sqlite/src/test/vtab1.test
    • third_party/sqlite/src/test/vtab_err.test
    • third_party/sqlite/src/test/wal64k.test
    • third_party/sqlite/src/test/wherelimit2.test
    • third_party/sqlite/src/test/window1.test
    • third_party/sqlite/src/test/window5.test
    • third_party/sqlite/src/test/window6.test
    • third_party/sqlite/src/test/windowfault.test
    • third_party/sqlite/src/test/without_rowid3.test
    • third_party/sqlite/src/test/zipfile.test
    • third_party/sqlite/src/test/zipfile2.test
    • third_party/sqlite/src/tool/genfkey.test
    • third_party/sqlite/src/tool/lempar.c
    • third_party/sqlite/src/tool/mkpragmatab.tcl
    • third_party/sqlite/src/tool/sqldiff.c
    • third_party/sqlite/src/tool/warnings.sh
  65. Add CheckTextButtonCellButtonText() into ChromeTableViewControllerTest

    Changed by Huanzhong Huang - huanzhongohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 10:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c179c83c8fa54f065676aaa8d43a197150cb9e6c

    Comments

    Add CheckTextButtonCellButtonText() into ChromeTableViewControllerTest
    
    To allow checks for |buttonText|.
    
    Change-Id: I367876e36e669b56a2dc4cd436665bd600be398e
    Reviewed-on: https://chromium-review.googlesource.com/c/1356716
    Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614311}

    Changed files

    • ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.h
    • ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm
  66. Worker: Move shared_worker_host.mojom from content/ to blink/ (Onion Soup)

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:55:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 86d9e0e9690613df6b2303795e9366e960e243bd

    Comments

    Worker: Move shared_worker_host.mojom from content/ to blink/ (Onion Soup)
    
    Bug: 911415
    Change-Id: If442d03c009fd934dc4f6700b63dc435af381093
    Reviewed-on: https://chromium-review.googlesource.com/c/1364993
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614310}

    Changed files

    • content/browser/worker_host/mock_shared_worker.cc
    • content/browser/worker_host/mock_shared_worker.h
    • content/browser/worker_host/shared_worker_host.cc
    • content/browser/worker_host/shared_worker_host.h
    • content/browser/worker_host/shared_worker_host_unittest.cc
    • content/browser/worker_host/shared_worker_service_impl_unittest.cc
    • content/common/BUILD.gn
    • content/common/shared_worker/shared_worker_factory.mojom
    • content/renderer/shared_worker/embedded_shared_worker_stub.cc
    • content/renderer/shared_worker/embedded_shared_worker_stub.h
    • content/renderer/shared_worker/shared_worker_factory_impl.cc
    • content/renderer/shared_worker/shared_worker_factory_impl.h
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/worker/shared_worker_host.mojom
  67. Roll src/third_party/dawn e2f948469c66..bdd887fce76c (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 10:45:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c858fb5c4a474f690eb450b923e72c298be5d8a

    Comments

    Roll src/third_party/dawn e2f948469c66..bdd887fce76c (2 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/e2f948469c66..bdd887fce76c
    
    
    git log e2f948469c66..bdd887fce76c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 kainino@chromium.org Revert "Create new src/tests BUILD.gn file."
    2018-12-05 senorblanco@chromium.org Create new src/tests BUILD.gn file.
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@bdd887fce76c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: If083040df65451a828b022bd4e3c95be0c9c3473
    Reviewed-on: https://chromium-review.googlesource.com/c/1365174
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614309}

    Changed files

    • DEPS
  68. [scheduler] Moving the clock parameter to Settings.

    Changed by Karolina Soltys - ksoltohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:41:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afa5205ccbece4cb80c1b8931a4e52fc9bcf4749

    Comments

    [scheduler] Moving the clock parameter to Settings.
    Follow-up to patch 1353921.
    
    Bug: 891670
    Change-Id: Ibae12547f3550debeda11cc400b6cb1b6eabfca9
    Reviewed-on: https://chromium-review.googlesource.com/c/1363206
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Karolina Soltys <ksolt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614308}

    Changed files

    • base/task/sequence_manager/sequence_manager.h
    • base/task/sequence_manager/sequence_manager_impl.cc
    • base/task/sequence_manager/sequence_manager_impl.h
    • base/task/sequence_manager/time_domain_unittest.cc
  69. Add is_hardware_accelerated and has_internal_source to EncoderInfo

    Changed by Mirta Dvornicic - mirtadohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 10:40:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 27c6bb9bd68ef8f1f959a7acf97c92ec5182446c

    Comments

    Add is_hardware_accelerated and has_internal_source to EncoderInfo
    
    webrtc::VideoEncoderFactory::CodecInfo properties are being moved to
    webrtc::VideoEncoder::EncoderInfo, see: https://crbug.com/webrtc/10065.
    
    Bug: webrtc:10065
    Change-Id: Ib74503c5390f4f3c148a8039005a28870733a974
    Reviewed-on: https://chromium-review.googlesource.com/c/1358061
    Commit-Queue: Mirta Dvornicic <mirtad@google.com>
    Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614307}

    Changed files

    • content/renderer/media/webrtc/rtc_video_encoder.cc
    • remoting/protocol/webrtc_dummy_video_encoder.cc
    • remoting/protocol/webrtc_dummy_video_encoder.h
  70. Disable disable_observer_list_unittest.nc

    Changed by Hans Wennborg - hansohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:40:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b8a149309d01fa018dba3f5957be945cb503cbc4

    Comments

    Disable disable_observer_list_unittest.nc
    
    It fails with tip-of-tree Clang because the diagnositics have changed
    slightly. Disable for now and possible re-enable with updated
    expectations after the next Clang roll.
    
    TBR=thakis
    
    Bug: 912021
    Change-Id: Ib0d83178ea5c38fa2d19ada720e8526437c916fd
    Reviewed-on: https://chromium-review.googlesource.com/c/1365434
    Reviewed-by: Hans Wennborg <hans@chromium.org>
    Commit-Queue: Hans Wennborg <hans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614306}

    Changed files

    • base/BUILD.gn
    • base/observer_list_unittest.nc
  71. Fix viewport calculation for Link: header preload

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:30:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad030e8d499b927c623fa2715f95fde38c44cdd8

    Comments

    Fix viewport calculation for Link: header preload
    
    This fixes a bug that viewport width was evaluated to zero
    when evaluating media queries from Link: rel=preload headers, if
    "width=device-width" was specified in <meta name="viewport">.
    
    viewport_description->max_width has type = kDeviceWidth and value = 0
    in such case, so device width must be resolved before overriding
    viewport dimensions.
    
    Note: HTMLPreloadScanner is already doing this, in HandleMetaViewport().
    
    Bug: 590188
    Change-Id: Iffb0e031e0316bd41aaf52014609d5e7d0b32284
    Reviewed-on: https://chromium-review.googlesource.com/c/1360209
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614305}

    Changed files

    • third_party/blink/renderer/core/loader/link_loader.cc
    • third_party/blink/web_tests/http/tests/preload/meta-viewport-device-width-link-headers.html
    • third_party/blink/web_tests/http/tests/preload/resources/media-link-headers-device-width.php
    • third_party/blink/web_tests/http/tests/preload/resources/media-link-headers-imagesrcset.php
  72. Roll src-internal baf62bde47d2..ed9aa80dbd6e (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 10:25:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision daae39a75dd01f787e5176d0fc7494282920909f

    Comments

    Roll src-internal baf62bde47d2..ed9aa80dbd6e (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baf62bde47d2..ed9aa80dbd6e
    
    
    Created with:
      gclient setdep -r src-internal@ed9aa80dbd6e
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iff2613e7527e25d3f2621fb252220a890fc26b8e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365411
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614304}

    Changed files

    • DEPS
  73. Reland "cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz"

    Changed by Jérôme Lebel - jlebelohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:13:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d2a5a88a940d3df25c6a074824adb6a901e099f

    Comments

    Reland "cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz"
    
    This is a reland of 1d497322e9fd8d9ab1da00767e30c618186151c6
    
    This patch also includes implementation for:
    RLZTrackerDelegateImpl::ShouldUpdateExistingAccessPointRlz()
    
    Original change's description:
    > cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz
    >
    > In addition to fixing the DCHECK, this CL contains a speculative fix
    > for flaky test (crbug.com/907379). The guess for the flakiness is
    > (not able to repro the failure locally though):
    >
    > |RecordProductEvent| may fail to acquire the |ScopedRlzValueStoreLock|
    > when recording the CAI event, because the lock is being taken by
    > |UpdateExistingAccessPointRlz|. In tests, the delay for
    > |ScheduleDelayedInit| is set to zero, so it's possible for this race
    > condition to happen. But in production, the delay is non-zero.
    >
    > I don't think we're losing test coverage by disabling
    > |UpdateExistingAccessPointRlz| here because the call is a no-op in
    > tests, and another test (RlzLibTest.UpdateExistingAccessPointRlz) is
    > testing its implementation.
    >
    > Bug: 906293, 907379
    > Change-Id: I208919f22edc09fc1a739a1efe1909a71e5a2730
    > Reviewed-on: https://chromium-review.googlesource.com/c/1353990
    > Reviewed-by: Roger Tawa <rogerta@chromium.org>
    > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#613172}
    
    Bug: 906293, 907379, 911439
    Change-Id: Ic1d9f85bc3714f890d2dc7fcc1d070d0711baec0
    Reviewed-on: https://chromium-review.googlesource.com/c/1360692
    Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614303}

    Changed files

    • chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
    • chrome/browser/rlz/chrome_rlz_tracker_delegate.h
    • components/rlz/rlz_tracker.cc
    • components/rlz/rlz_tracker_delegate.h
    • components/rlz/rlz_tracker_unittest.cc
    • ios/chrome/browser/rlz/rlz_tracker_delegate_impl.cc
    • ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h
  74. Rename MojoLayoutTestHelper to MojoWebTestHelper

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:11:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 860eb4082747c24078c9de9f0ad2150c908db4d0

    Comments

    Rename MojoLayoutTestHelper to MojoWebTestHelper
    
    mojo_layouttest_test.mojom is renamed to
    mojo_web_test_helper_test.mojom. It keeps _test suffix indicating it
    affects only tests.
    
    Bug: 843412
    Change-Id: Iddfdfcbfd87228fb9ee8abd2777f4838c4b66801
    Reviewed-on: https://chromium-review.googlesource.com/c/1362717
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614302}

    Changed files

    • BUILD.gn
    • content/shell/BUILD.gn
    • content/shell/browser/content_shell_browser_manifest_overlay.json
    • content/shell/browser/web_test/mojo_web_test_helper.cc
    • content/shell/browser/web_test/mojo_web_test_helper.h
    • content/shell/browser/web_test/web_test_content_browser_client.cc
    • content/test/BUILD.gn
    • content/test/data/mojo_web_test_helper_test.mojom
    • third_party/blink/web_tests/external/wpt/bluetooth/resources/bluetooth-helpers.js
    • third_party/blink/web_tests/external/wpt/resources/chromium/mojo_layouttest_test.mojom.js
    • third_party/blink/web_tests/external/wpt/resources/chromium/mojo_web_test_helper_test.mojom.js
    • third_party/blink/web_tests/external/wpt/resources/chromium/mojo_web_test_helper_test.mojom.js.headers
    • third_party/blink/web_tests/mojo/bind-interface.html
    • third_party/blink/web_tests/mojo/detached-frame.html
    • third_party/blink/web_tests/mojo/resources/bind-intercepted-interface-in-worker.js
    • third_party/blink/web_tests/mojo/resources/helpers.js
  75. Add a `run_web_tests.py --no-manifest-update` option

    Changed by Philip Jägenstedt - foolipohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:11:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a79321c87f697c14646dbe75c7408c15c52b2f7

    Comments

    Add a `run_web_tests.py --no-manifest-update` option
    
    This is like the `./wpt run --no-manifest-update` in upstream wpt:
    https://github.com/web-platform-tests/wpt/blob/81607985fc9485cbf9f3d0a8ae74359f885eb36b/tools/wptrunner/wptrunner/wptcommandline.py#L52-L53
    
    Because updating the manifest is pretty slow, this reduces the time to
    run a few tests over and over in development when the manifest is not
    changing.
    
    On a Linux workstation, the time to run a single test
    (dom/historical.html) went from ~14s to ~7s.
    
    Bug: 905406
    Change-Id: I50e4b8bdd9d3bedbf1e31bc34a2338317a30aaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1361874
    Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Doug Turner <dougt@chromium.org>
    Reviewed-by: Luke Z <lpz@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#614301}

    Changed files

    • third_party/blink/tools/blinkpy/web_tests/controllers/manager.py
    • third_party/blink/tools/blinkpy/web_tests/port/base.py
    • third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
  76. [Autofill Assistant] Fixed SetFieldValue() to support UTF-8 text.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 10:09:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bec01af6dded902830ed08f80fefc816e5f4fdf9

    Comments

    [Autofill Assistant] Fixed SetFieldValue() to support UTF-8 text.
    
    Also in this CL:
     - refactoring of parts of the backend to remove redundant and potentially error-prone code
     - modified unit tests for web_controller to test for UTF-8 compliance of SetFieldValue()
    
    Change-Id: Ib7dd2429159a527ec81f325622e8bf6f97c5e5ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1360691
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614300}

    Changed files

    • components/autofill_assistant/browser/actions/action_delegate.h
    • components/autofill_assistant/browser/actions/mock_action_delegate.h
    • components/autofill_assistant/browser/actions/set_form_field_value_action.cc
    • components/autofill_assistant/browser/script_executor.cc
    • components/autofill_assistant/browser/script_executor.h
    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
    • components/autofill_assistant/browser/web_controller_browsertest.cc
  77. [iOS][MF] Remove extra loading indicator

    Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:57:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d038d4d49e0ae80b8ce1c7dcb6bac1e365778942

    Comments

    [iOS][MF] Remove extra loading indicator
    
    Only add the loading indicator if the model hasn't been created
    
    Bug: 912085
    Change-Id: I0d557013eeb63cf882793460a342e22485fa48d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1363179
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614299}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
  78. Move FTP directory listing from content/renderer/loader to Blink

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:56:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2046dd28639651936de4e8ec6b74fbf7a26c5545

    Comments

    Move FTP directory listing from content/renderer/loader to Blink
    
    In order to WebDataConsumerHandle deprecation easy, move
    content::FtpDirectoryListingResponseDelegate to blink.
    
    Bug: 910489
    Change-Id: I878df1c90c28de1c3f44d9ed48e518207fa831c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1358315
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614298}

    Changed files

    • content/renderer/BUILD.gn
    • content/renderer/loader/ftp_directory_listing_response_delegate.cc
    • content/renderer/loader/ftp_directory_listing_response_delegate.h
    • content/renderer/loader/web_url_loader_impl.cc
    • content/renderer/loader/web_url_loader_impl_unittest.cc
    • content/renderer/loader/weburlresponse_extradata_impl.cc
    • content/renderer/loader/weburlresponse_extradata_impl.h
    • content/renderer/render_frame_impl.cc
    • third_party/blink/public/web/web_document_loader.h
    • third_party/blink/renderer/core/exported/web_document_loader_impl.cc
    • third_party/blink/renderer/core/exported/web_document_loader_impl.h
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/document_loader.h
    • third_party/blink/renderer/platform/loader/BUILD.gn
    • third_party/blink/renderer/platform/loader/DEPS
    • third_party/blink/renderer/platform/loader/ftp_directory_listing.cc
    • third_party/blink/renderer/platform/loader/ftp_directory_listing.h
    • third_party/blink/renderer/platform/loader/ftp_directory_listing_test.cc
  79. Roll src/third_party/angle 8f1b7a66a5e3..d300548fcc28 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 09:38:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 11e903b61b49feff17e97ed5fe8060f23d16900e

    Comments

    Roll src/third_party/angle 8f1b7a66a5e3..d300548fcc28 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/8f1b7a66a5e3..d300548fcc28
    
    
    git log 8f1b7a66a5e3..d300548fcc28 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 enga@chromium.org Add ANGLE_multi_draw entrypoints to proc table
    
    
    Created with:
      gclient setdep -r src/third_party/angle@d300548fcc28
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:890539
    TBR=ynovikov@chromium.org
    
    Change-Id: Id92afc679acf0f0e00f46fba3d8806da8987f4d1
    Reviewed-on: https://chromium-review.googlesource.com/c/1365175
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614297}

    Changed files

    • DEPS
  80. Remove CheckValidityEventBehavior.

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:28:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5dea9d09e55412e6648f68a8e9326d95557888d0

    Comments

    Remove CheckValidityEventBehavior.
    
    The behavior of ListedElement::checkValidity() with
    kCheckValidityDispatchNoEvent was very simple. This CL introduces
    IsNotCandidateOrValid() for that behavior, and removes
    CheckValidityEventBehavior argument of checkValidity().
    
    Change-Id: Ieff28ada30cc47d8617e73306d874cdfa9dee43c
    Reviewed-on: https://chromium-review.googlesource.com/c/1364990
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614296}

    Changed files

    • third_party/blink/renderer/core/html/forms/html_field_set_element.cc
    • third_party/blink/renderer/core/html/forms/html_form_element.cc
    • third_party/blink/renderer/core/html/forms/html_form_element.h
    • third_party/blink/renderer/core/html/forms/listed_element.cc
    • third_party/blink/renderer/core/html/forms/listed_element.h
    • third_party/blink/renderer/core/html/html_element.cc
    • third_party/blink/renderer/core/html/html_element.h
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
  81. Flip S13nServiceWorker virtual test to disable the flag

    Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:23:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e

    Comments

    Flip S13nServiceWorker virtual test to disable the flag
    
    Currently NetS13nServiceWorker is enabled by default, and we don't have tests
    excercising non-S13nServiceWorker path. This flips the test to enable
    S13nServiceWorker to disabling S13nServiceWorker forcefully.
    
    Bug: 715640
    Change-Id: I8ba3401989dcd9da46e24cd7dc0500f66a200741
    Reviewed-on: https://chromium-review.googlesource.com/c/1365050
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614295}

    Changed files

    • third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService
    • third_party/blink/web_tests/NeverFixTests
    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/VirtualTestSuites
    • third_party/blink/web_tests/virtual/disabled-service-worker-servicification/external/wpt/service-workers/service-worker/README.txt
    • third_party/blink/web_tests/virtual/disabled-service-worker-servicification/http/tests/serviceworker/README.txt
    • third_party/blink/web_tests/virtual/service-worker-servicification/external/wpt/service-workers/service-worker/README.txt
    • third_party/blink/web_tests/virtual/service-worker-servicification/http/tests/serviceworker/README.txt
    • third_party/blink/web_tests/virtual/service-worker-servicification/http/tests/serviceworker/navigation_preload/use-counter-expected.txt
  82. Roll src-internal 3dc3d8f696a7..baf62bde47d2 (9 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 09:12:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad058b0d0c95e8cbdf14f26c7886c52d5d1aa110

    Comments

    Roll src-internal 3dc3d8f696a7..baf62bde47d2 (9 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3dc3d8f696a7..baf62bde47d2
    
    
    Created with:
      gclient setdep -r src-internal@baf62bde47d2
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I405f390d1485db257fc26dca9ad21eede7227b0f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365173
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614294}

    Changed files

    • DEPS
  83. [App Management] Add FakePageHandler

    Changed by Reka Norman - rekanormanohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 09:11:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dd7e3574c242e0e4544fe8d7e1780f4c588f614

    Comments

    [App Management] Add FakePageHandler
    
    This CL adds a fake page handler to the app management page which is used when
    accessing chrome://apps?fakeBackend=true.
    
    Bug: 906508
    Change-Id: Ib92a66a45b312efd14b5fb038d7cc506944dd716
    Reviewed-on: https://chromium-review.googlesource.com/c/1360034
    Commit-Queue: calamity <calamity@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614293}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/resources/app_management/BUILD.gn
    • chrome/browser/resources/app_management/browser_proxy.html
    • chrome/browser/resources/app_management/browser_proxy.js
    • chrome/browser/resources/app_management/fake_page_handler.js
    • chrome/browser/ui/webui/app_management/app_management_ui.cc
  84. Fix a typo in ResumableDelayedTaskRunner class comment.

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:02:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b2cd20b5972267a83ede700e622f7d2392a3474

    Comments

    Fix a typo in ResumableDelayedTaskRunner class comment.
    
    This CL introduced the ResumableTaskRunner:
    https://chromium-review.googlesource.com/c/chromium/src/+/1353946
    
    In the class comment where we describe how to make use of the class,
    one of the lines was not updated with the rest during the last
    iterations of the review, leaving the example code incorrect.
    
    This CL just ensures that we are using consistent variable naming
    throughout the example.
    
    Bug: 909682
    
    Change-Id: I67666306888909e867f624dddb85d003e24604e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1363284
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614292}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/invalidation/ResumableDelayedTaskRunner.java
  85. add "Chromium Mac Goma RBE Staging" and "Chromium Mac RBE Goma Staging (dbg)"

    Changed by Fumitoshi Ukai - ukaiohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 09:01:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f11bc1c065271288d74f2d865f16a82dadaf00d

    Comments

    add "Chromium Mac Goma RBE Staging" and "Chromium Mac RBE Goma Staging (dbg)"
    
    Bug: 901708, 901706
    Change-Id: I7eaaf7434a465be2020d7e81ebf08e8d5ca93ba6
    Reviewed-on: https://chromium-review.googlesource.com/c/1360452
    Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
    Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614291}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.goma.json
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  86. Revert "Add console message in MixedContentChecker::HandleCertificateError"

    Changed by Rakina Zata Amni - rakinaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 08:59:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e092dc1b1477a1192745054d5885eb50cdfd8b2f

    Comments

    Revert "Add console message in MixedContentChecker::HandleCertificateError"
    
    This reverts commit dcfa99386d0b0f91107fdb8c248be833ba18fd25.
    
    Reason for revert: Caused flaky tests: crbug.com/912431
    
    Original change's description:
    > Add console message in MixedContentChecker::HandleCertificateError
    > 
    > Print console message when subresources are loaded over broken HTTPS.
    > Screenshot: https://drive.google.com/file/d/1Sn_2c162NmvCoIXFuFVB68z-MhzphcNT/view?usp=sharing
    > 
    > Bug: 587168
    > Change-Id: I997a8da26f0fe015cc0103b96dcbaa7d40525eb8
    > Reviewed-on: https://chromium-review.googlesource.com/c/1306779
    > Commit-Queue: Livvie Lin <livvielin@chromium.org>
    > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Reviewed-by: Mike West <mkwst@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Nate Chapin <japhet@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614212}
    
    TBR=sky@chromium.org,meacer@chromium.org,yhirano@chromium.org,japhet@chromium.org,mkwst@chromium.org,livvielin@chromium.org
    
    Change-Id: I9142c895af7dd1c6a4c9ea7500ee0eca2ce9d118
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 587168, 912431
    Reviewed-on: https://chromium-review.googlesource.com/c/1364974
    Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614290}

    Changed files

    • chrome/browser/favicon/content_favicon_driver_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • third_party/blink/renderer/core/loader/mixed_content_checker.cc
    • third_party/blink/web_tests/http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.txt
    • third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https-expected.txt
    • third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-expected.txt
    • third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-other-https-expected.txt
    • third_party/blink/web_tests/http/tests/mixed-autoupgrade/optionally/image-upgrade-console-message.https-expected.txt
    • third_party/blink/web_tests/http/tests/navigation/ping-cross-origin-from-https-expected.txt
    • third_party/blink/web_tests/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/active-subresource-in-iframe-blocked.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-css-image-with-reload-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-css-resources-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-fetch-on-dedicated-worker-allowed.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-fetch-on-dedicated-worker-blocked.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-iframe-with-hsts.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/strict-mode-image-in-frame-blocked.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/referrer-on-client-redirect-expected.txt
    • third_party/blink/web_tests/http/tests/security/referrer-policy-attribute-img-no-referrer-when-downgrade-expected.txt
    • third_party/blink/web_tests/http/tests/security/xssAuditor/report-script-tag-cross-origin-https-expected.txt
  87. Convert InlineLoginHandlerImpl to IdentityManager

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Thursday, 06-Dec-18 08:54:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fea47aacf80c5e06dc7246a9b3673525cf14b62

    Comments

    Convert InlineLoginHandlerImpl to IdentityManager
    
    Replace usage of SigninManager's API with calls to APIs from the
    IdentityManager and PrimaryAccountMutator.
    
    Bug: 890813
    Change-Id: I1a70a47e41aa132f0d5e4a1de12bd7c5d5eb31ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1259009
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#614289}

    Changed files

    • chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
    • chrome/browser/ui/webui/signin/inline_login_handler_impl.h
  88. [ios] Fixed manual fallback cells vertical offsets

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 08:34:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d604e82d00923e85e22076e806208ab1daa04ba

    Comments

    [ios] Fixed manual fallback cells vertical offsets
    
    Fixed dynamic types for separating labels.
    
    Bug: 912030,912028
    Change-Id: I1acbfed7fe6569c8af712c45a04b8f86dbbbf0af
    Reviewed-on: https://chromium-review.googlesource.com/c/1363180
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614288}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
  89. Roll AFDO from 73.0.3631.0_rc-r1 to 73.0.3632.0_rc-r1

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 08:20:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f27b2e597d5cef4990fb1c109ed576d0412ed1d3

    Comments

    Roll AFDO from 73.0.3631.0_rc-r1 to 73.0.3632.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    Please note that, despite rolling to chrome/android, this profile is
    used for both Linux and Android.
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: Ib51caf6f12f66fcb6b8d98ce42033e316e3f87dd
    Reviewed-on: https://chromium-review.googlesource.com/c/1365390
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614287}

    Changed files

    • chrome/android/profiles/newest.txt
  90. WebUI: Convert remaining usages of var to let/const, part 4.

    Changed by dpapad - dpapadohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 08:14:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32b4afc9a7da18df541ef79dbbc623ccf2c5fa8

    Comments

    WebUI: Convert remaining usages of var to let/const, part 4.
    
    This is in preparation of turning on no-var, and prefer-const ESLint
    checks for all of chrome/browser/resources/
    
    Bug: 792774
    Change-Id: Id1bfd8720970876275499854d4fccce1c911d0b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1364053
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614286}

    Changed files

    • chrome/browser/resources/cast/cast.js
    • chrome/browser/resources/conflicts/about_conflicts.js
    • chrome/browser/resources/device_log_ui/device_log_ui.js
    • chrome/browser/resources/download_internals/download_internals.js
    • chrome/browser/resources/download_internals/download_internals_browser_proxy.js
    • chrome/browser/resources/engagement/site_engagement.js