Home | Search | chromium - Builders
Login

Builder linux-chromeos-rel Build 11794 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision31322898bc81e2e07e3d9f89aa051a60c5f93215
Got Revision31322898bc81e2e07e3d9f89aa051a60c5f93215

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. David Roger (drogerohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 06:50:15 UTC
Start Saturday, 11-Aug-18 06:50:19 UTC
End Saturday, 11-Aug-18 07:10:52 UTC
Pending 4 secs
Execution 20 mins 32 secs

All Changes:

  1. [Settings] UserEvents depends on history and passphrase

    Changed by David Roger - drogerohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 06:43:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31322898bc81e2e07e3d9f89aa051a60c5f93215

    Comments

    [Settings] UserEvents depends on history and passphrase
    
    This is a reland of:
    https://chromium-review.googlesource.com/1170202
    
    which was reverted because of missing svg icon.
    
    The user events UI toggle should be grayed out and turned off
    when there is a passphrase or when history sync is disabled.
    Note that this is purely a UI change: the internal sync datatype
    is not really turned off in that case, and we assume that the Sync
    engines will correctly stop syncing user events in these cases,
    even if the preference is still ON.
    
    Bug: 865522, 865537
    Change-Id: I745f048b3ca301231f57c04b82d0d9d82a6f3b90
    Reviewed-on: https://chromium-review.googlesource.com/1170825
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582433}

    Changed files

    • chrome/browser/resources/settings/people_page/sync_browser_proxy.js
    • chrome/browser/resources/settings/people_page/sync_page.html
    • chrome/browser/resources/settings/people_page/sync_page.js
    • chrome/test/data/webui/settings/people_page_sync_page_test.js