Home | Search | chromium - Builders
Login

Builder linux-chromeos-dbg Build 8303 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision863a437d0fdbbba19ad5446420b72d2f91748a72
Got Revision863a437d0fdbbba19ad5446420b72d2f91748a72

Execution:

Steps and Logfiles:

Show:
  1. ( 322 ms ) setup_build
    running recipe: "chromium"
  2. ( 850 ms ) report builders
     
    running builder/tester 'linux-chromeos-dbg' on master 'chromium.chromiumos'
  3. ( 4 mins 22 secs ) bot_update
    [119GB/295GB used (40%)]
  4. ( 2 secs ) swarming.py --version
    0.13
  5. ( 49 secs ) gclient runhooks
  6. ( 356 ms ) read test spec (chromium.chromiumos.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.chromiumos.json
  7. ( 562 ms ) lookup GN args
     
    ffmpeg_branding = "ChromeOS"
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    target_os = "chromeos"
    use_goma = true
    use_vaapi = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 1 mins 23 secs ) generate_build_files
  9. ( 21 mins 12 secs ) compile
  10. ( 10 secs ) compile confirm no-op
  11. ( 8 mins 54 secs ) isolate tests
  12. ( 715 ms ) find isolated tests
  13. ( 2 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
  14. ( 3 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:44.438357
  15. ( 1 secs ) app_list_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 28s
  16. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:11.215467
  17. ( 1 secs ) ash_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:19.817980
  18. ( 5 secs ) ash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:06.202038
  19. ( 2 secs ) single_process_mash_ash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:03.781795
  20. ( 1 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  21. ( 2 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 38s
  22. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  23. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  24. ( 1 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 40s
  25. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 52s
  26. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  27. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  28. ( 1 secs ) mash_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:09.968978
  29. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  30. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  31. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  32. ( 2 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:17.074095
  33. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 53s
  34. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 34s
  35. ( 1 secs ) chromeos_components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 35s
  36. ( 1 secs ) chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 40s
  37. ( 14 mins 39 secs ) chromevox_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:18:37.321023
  38. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:30.989411
  39. ( 7 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:08:59.458706
  40. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  41. ( 1 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 54s
  42. ( 4 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:45.581454
  43. ( 4 secs ) single_process_mash_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:55.175752
  44. ( 4 secs ) viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:21.514326
  45. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  46. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:07:36.641443
  47. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  48. ( 1 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  49. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  50. ( 2 secs ) exo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:29.173625
  51. ( 1 secs ) single_process_mash_exo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:25.480088
  52. ( 1 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:49.945612
  53. ( 1 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:27.092789
  54. ( 1 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  55. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  56. ( 3 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:05.051357
  57. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  58. ( 1 secs ) gl_unittests_ozone
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  59. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  60. ( 2 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 41s
  61. ( 1 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:03.753139
  62. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  63. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  64. ( 1 secs ) keyboard_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  65. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  66. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  67. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  68. ( 1 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:10.645568
  69. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  70. ( 4 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:06.470835
  71. ( 1 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  72. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  73. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 4s
  74. ( 1 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  75. ( 1 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  76. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 58s
  77. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 29s
  78. ( 1 secs ) ozone_gl_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  79. ( 1 secs ) ozone_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  80. ( 1 secs ) ozone_x11_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  81. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  82. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  83. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 29s
  84. ( 1 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 36s
  85. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  86. ( 1 secs ) select_to_speak_extension_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:15.905223
  87. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  88. ( 4 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:18.378913
  89. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  90. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  91. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 41s
  92. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  93. ( 1 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 48s
  94. ( 2 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:21:25.655373
  95. ( 1 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  96. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  97. ( 1 secs ) ui_chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  98. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  99. ( 7 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:11:24.558971
  100. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  101. ( 1 secs ) views_mus_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 41s
  102. ( 1 secs ) views_mus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:34.095379
  103. ( 1 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  104. ( 2 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:19.251925
  105. ( 6 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:25.266115
  106. ( 1 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  107. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  108. ( 2 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:21:44.956364 (shard #1)
    Min shard duration: 0:20:09.017254 (shard #0)
  109. ( 15 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:09:17.703865 (shard #1)
    Min shard duration: 0:09:14.955178 (shard #0)
  110. ( 1 mins 58 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:26:23.040598 (shard #0)
    Min shard duration: 0:19:37.681077 (shard #1)
  111. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:11:06.682430 (shard #0)
    Min shard duration: 0:08:02.223199 (shard #1)
  112. ( 3 secs ) single_process_mash_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:09:21.931502 (shard #1)
    Min shard duration: 0:07:47.449340 (shard #2)
  113. ( 3 secs ) viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:06:23.535999 (shard #0)
    Min shard duration: 0:04:00.644844 (shard #2)
  114. ( 2 mins 4 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:28:33.360366 (shard #2)
    Min shard duration: 0:20:30.635711 (shard #14)
  115. ( 34 secs ) single_process_mash_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:29:43.526249 (shard #2)
    Min shard duration: 0:17:33.883597 (shard #14)
  116. ( 13 secs ) viz_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:28:22.077349 (shard #12)
    Min shard duration: 0:18:53.026949 (shard #4)
  117. ( 2 secs ) Tests statistics
     
    Stats
    Total shards: 181
    Total runtime: 1 day, 4:31:59.944573
     
  118. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1567-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539349969828337, "id": "8932868281995825376", "project": "chromium", "tags": ["builder:linux-chromeos-dbg", "buildset:commit/git/863a437d0fdbbba19ad5446420b72d2f91748a72", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/863a437d0fdbbba19ad5446420b72d2f91748a72", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098298344185580464", "scheduler_job_id:chromium/linux-chromeos-dbg", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "linux-chromeos-dbg" setup_build
buildnumber 8303 setup_build
mastername "chromium.chromiumos" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "863a437d0fdbbba19ad5446420b72d2f91748a72" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "863a437d0fdbbba19ad5446420b72d2f91748a72" bot_update
got_revision_cp "refs/heads/master@{#599189}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25138}" bot_update
swarm_hashes_refs/heads/master(at){#599189}_without_patch {"accessibility_unittests": "b64e2da030737bcc858bde551e0ff0b3fd505755", "angle_unittests": "493f088d09b73a110c6c3eda4a3f8dba79d0b511", "app_list_unittests": "f62564c5d964edf5f185d9d35e1a629de1286aaf", "app_shell_unittests": "e8a6704fc8a7eb4907a23334376b78de436f28b3", "ash_content_unittests": "592112dc64dfd396331defd53a5eff422e15899c", "ash_unittests": "3827a43edbca3df59b837edf3a4c53a5b4ff40ba", "aura_unittests": "9bb4eb31b05b0c16a59ec52ebde2a01c324d429e", "base_unittests": "5afbaefa9cdbd3828e4576d8c470a546271fe6ab", "blink_common_unittests": "ffa69a3e90101a57f26f6f84c786a5b45f890002", "blink_fuzzer_unittests": "df7262ff47d504638d8e7b6a70eca331ab606660", "blink_heap_unittests": "7f0b1a696a1cb1ecb23c8c4afbbd551ecaf755a3", "blink_platform_unittests": "ab77bf9be9a0bfbe1a36ee4ff9aa00af62e5c671", "boringssl_crypto_tests": "3eb16b94a7b1b701803478fec4ea37e808455f0b", "boringssl_ssl_tests": "3377a5fd8f00fe866732bc5f3129faea39c00bae", "browser_tests": "3f5c18360e0c8f0bd43d84ac339dcc42f555fff1", "cacheinvalidation_unittests": "2c4af35cc23cd76b68f8dfa9a7fcc3eabc0b5a5b", "capture_unittests": "f899afd136caa41726cd2598c2bdbe058f98aa55", "cast_unittests": "94a392486ad3894ae065892bef301584bfec8d62", "cc_unittests": "7baa1d77ec080e8f983bae0805fa1c9900247ea3", "chrome_app_unittests": "9beccd7b64b3a280f2dcd81270f98703f04ee164", "chromedriver_unittests": "671f97763bc6ae5181c8975602f27fd15786488b", "chromeos_components_unittests": "7abfe8d8b946ff1e1c30f3c98dab9e471ebc15c1", "chromeos_unittests": "61a00d36e3127e46c5f7cab8be77cabb4a8cb55f", "chromevox_tests": "a1f134c6ba90b15e1f2765562eb46758d59fd0b5", "components_browsertests": "c97218bfaa9fbc6345979212511efb7e850ed94e", "components_unittests": "41955364b50a490a09abc606c8075dec5eebdb90", "compositor_unittests": "a77cc65ee7676016d0b1173734da8e33b1d0565c", "content_browsertests": "f9c0069cdd091d377ed0b14a116c085e89000039", "content_unittests": "fe79449210527fda704ae9302f500a0ed4ac078f", "crypto_unittests": "17336b2ab637f2c9e4da2c4a50c4ed59060db6c5", "dbus_unittests": "2610089bee5ad9becb165258217f242eab4ec913", "device_unittests": "da9c06fd3fa9239819ec1fa3306d948ab9bfe8ba", "display_unittests": "f1537b1a8fad5a4dcab24bb4a1520010e3b09de5", "events_unittests": "c6a5a34371e749a8fa485a088cdb0a4ad8995b68", "exo_unittests": "5375faeb3ddbf6d9c288c773baaf1bc5153aa4f1", "extensions_browsertests": "76ced94824ee255e763b3a303ef4d070904a0b11", "extensions_unittests": "9e701c1028b62acd0e34f58af4e9a81b54674005", "filesystem_service_unittests": "cbff1c8168249d45ab1101ac07353551ffc3f139", "gcm_unit_tests": "b663b6db4f7e1c20549804d68b42d41983aed85c", "gfx_unittests": "d707ecb0d6a3c6f51969563ddb8949f901c79e2f", "gin_unittests": "e6e18e237c6329dcdf19237bc5be12921ec0bbc3", "gl_unittests_ozone": "49b809dda4a9277de23bfbeba5d6f0e59c4760cd", "google_apis_unittests": "ff44537504cdb90a9830805088efd354c3ada82e", "gpu_unittests": "ae63947a75c635076c495e0175418330cd67e364", "interactive_ui_tests": "89696573a025599711c928b1bda7cd25e42c090a", "ipc_tests": "efa07515b2acd267187dbf819bd43c70cc5833f8", "jingle_unittests": "8e1afa5ae1fa4529a759d2af2afc5126c3074fd5", "keyboard_unittests": "9d9931faf471f422fd064e2ff9b8b75cd4efe7fa", "latency_unittests": "943b28e5faadabcba098a1c8255045531adfee39", "leveldb_service_unittests": "8ea5ee5da31559c0a67b5115bd273d2c98bfb4d6", "libjingle_xmpp_unittests": "f69c8cc4fd25fc94001c61fd41d1c5e2c5738545", "media_blink_unittests": "b267995cba0e3769f49d1accc9a768bfe9621fa7", "media_service_unittests": "cf181304d3592f745b1bbe994a44cf0b78ed1761", "media_unittests": "20f107b70c0e85eb766215c79877c251d97b8aeb", "message_center_unittests": "ab884cd4d2dbc16a35f17b30ab28a13fc88790b5", "midi_unittests": "87e5b2250d1d8114b143a6765b9ed6350a07d153", "mojo_core_unittests": "82c6cb5367fc27a70d7adc1615e287088e7e2574", "mojo_unittests": "09f746a4656c0bbbfa2a0b564cccdd09b7486f86", "nacl_helper_nonsfi_unittests": "faa79f8a583860557424e70605e0ac59e743acc6", "nacl_loader_unittests": "3e68d6eab432157e1212eafd14f9dc2275bbbbbc", "native_theme_unittests": "d17e7aa6fd262f4c70f410c89288ec48235d0451", "net_unittests": "95bba569f7c94394dc72b761cacfce04e7028894", "ozone_gl_unittests": "f7ff2d890d32605371bb527bf9c272827c4118c7", "ozone_unittests": "69554d0dd4c65bd3703c0fddb408a33408923906", "ozone_x11_unittests": "224399f9893edad7ab870907c4d944174a4aff6d", "pdf_unittests": "533a38eeb7172558e5abd673b4feff325f8787df", "ppapi_unittests": "e0d2c6ce765956f18ab6b3e79236f53417d7de9e", "printing_unittests": "4f6010da9753bb63baa0c06ffa2b1d7bd315ae34", "remoting_unittests": "9e001339fbf66566e79d7d3dfc4d8e4b76e47030", "sandbox_linux_unittests": "92089a2802839a7271d0f0144a9772f2e7493d8a", "select_to_speak_extension_tests": "2d46839adba47f42f928f7f451e80259c336bd4a", "service_manager_unittests": "6c695cc65294f0061e210c7e0946f7fb2e628a28", "services_unittests": "b4b4751e6579f766e623f9271daa6d221cbfaeef", "shell_dialogs_unittests": "738f7fa78b74b6f62956091cdb48586252d26540", "skia_unittests": "391dfc264feaed8558ca9f215e9113558137158a", "snapshot_unittests": "9c97dc2ae03d3a52a93fc4eea845d69d99818565", "sql_unittests": "9f70c043b50f33307f146ee8b7571f6232ea3fd0", "storage_unittests": "fcdad79d374ddaa704bcbd1f515593cf0715d161", "sync_integration_tests": "8df1d9111e2e1b7af8b663815f320dc1eb4482a5", "traffic_annotation_auditor_unittests": "1befc69c9433530abb8bbee2f2b76c8f99fc56d0", "ui_base_unittests": "b51e232050d512c76b0fe79ac0953fe13f5340ee", "ui_chromeos_unittests": "c6a9629927e8aef82fce11e11e7658f9f98d8d3c", "ui_touch_selection_unittests": "9abd1131cb78c332851b3d75bf80ae4c38e28625", "unit_tests": "c963cf4fee90dbd6087453c73a09b14e0c24a872", "url_unittests": "3db9485780e2d148960635c0aa656c23edc19bca", "views_mus_interactive_ui_tests": "a43f5fcc424971d92e4eed31922f1ac0a18a5ff8", "views_mus_unittests": "c28233a8b5e2d25a171cd2b568ac7a2d240b4391", "views_unittests": "d16f7d0f8ec724d94f796778d9a6687938358ea6", "viz_unittests": "52e4fe7e9eee254ac925fa9b2743647720b187ad", "webkit_unit_tests": "bac51a47c6678c17a64f9fe99fccfef44a19fea6", "wm_unittests": "2cbf6ff3aad45e56cfd98e15a0a09bc07667db07", "wtf_unittests": "f6f1bd10b0e6a0d484c6c718b8584dc16ca99232"} isolate tests
swarm_hashes {"accessibility_unittests": "b64e2da030737bcc858bde551e0ff0b3fd505755", "angle_unittests": "493f088d09b73a110c6c3eda4a3f8dba79d0b511", "app_list_unittests": "f62564c5d964edf5f185d9d35e1a629de1286aaf", "app_shell_unittests": "e8a6704fc8a7eb4907a23334376b78de436f28b3", "ash_content_unittests": "592112dc64dfd396331defd53a5eff422e15899c", "ash_unittests": "3827a43edbca3df59b837edf3a4c53a5b4ff40ba", "aura_unittests": "9bb4eb31b05b0c16a59ec52ebde2a01c324d429e", "base_unittests": "5afbaefa9cdbd3828e4576d8c470a546271fe6ab", "blink_common_unittests": "ffa69a3e90101a57f26f6f84c786a5b45f890002", "blink_fuzzer_unittests": "df7262ff47d504638d8e7b6a70eca331ab606660", "blink_heap_unittests": "7f0b1a696a1cb1ecb23c8c4afbbd551ecaf755a3", "blink_platform_unittests": "ab77bf9be9a0bfbe1a36ee4ff9aa00af62e5c671", "boringssl_crypto_tests": "3eb16b94a7b1b701803478fec4ea37e808455f0b", "boringssl_ssl_tests": "3377a5fd8f00fe866732bc5f3129faea39c00bae", "browser_tests": "3f5c18360e0c8f0bd43d84ac339dcc42f555fff1", "cacheinvalidation_unittests": "2c4af35cc23cd76b68f8dfa9a7fcc3eabc0b5a5b", "capture_unittests": "f899afd136caa41726cd2598c2bdbe058f98aa55", "cast_unittests": "94a392486ad3894ae065892bef301584bfec8d62", "cc_unittests": "7baa1d77ec080e8f983bae0805fa1c9900247ea3", "chrome_app_unittests": "9beccd7b64b3a280f2dcd81270f98703f04ee164", "chromedriver_unittests": "671f97763bc6ae5181c8975602f27fd15786488b", "chromeos_components_unittests": "7abfe8d8b946ff1e1c30f3c98dab9e471ebc15c1", "chromeos_unittests": "61a00d36e3127e46c5f7cab8be77cabb4a8cb55f", "chromevox_tests": "a1f134c6ba90b15e1f2765562eb46758d59fd0b5", "components_browsertests": "c97218bfaa9fbc6345979212511efb7e850ed94e", "components_unittests": "41955364b50a490a09abc606c8075dec5eebdb90", "compositor_unittests": "a77cc65ee7676016d0b1173734da8e33b1d0565c", "content_browsertests": "f9c0069cdd091d377ed0b14a116c085e89000039", "content_unittests": "fe79449210527fda704ae9302f500a0ed4ac078f", "crypto_unittests": "17336b2ab637f2c9e4da2c4a50c4ed59060db6c5", "dbus_unittests": "2610089bee5ad9becb165258217f242eab4ec913", "device_unittests": "da9c06fd3fa9239819ec1fa3306d948ab9bfe8ba", "display_unittests": "f1537b1a8fad5a4dcab24bb4a1520010e3b09de5", "events_unittests": "c6a5a34371e749a8fa485a088cdb0a4ad8995b68", "exo_unittests": "5375faeb3ddbf6d9c288c773baaf1bc5153aa4f1", "extensions_browsertests": "76ced94824ee255e763b3a303ef4d070904a0b11", "extensions_unittests": "9e701c1028b62acd0e34f58af4e9a81b54674005", "filesystem_service_unittests": "cbff1c8168249d45ab1101ac07353551ffc3f139", "gcm_unit_tests": "b663b6db4f7e1c20549804d68b42d41983aed85c", "gfx_unittests": "d707ecb0d6a3c6f51969563ddb8949f901c79e2f", "gin_unittests": "e6e18e237c6329dcdf19237bc5be12921ec0bbc3", "gl_unittests_ozone": "49b809dda4a9277de23bfbeba5d6f0e59c4760cd", "google_apis_unittests": "ff44537504cdb90a9830805088efd354c3ada82e", "gpu_unittests": "ae63947a75c635076c495e0175418330cd67e364", "interactive_ui_tests": "89696573a025599711c928b1bda7cd25e42c090a", "ipc_tests": "efa07515b2acd267187dbf819bd43c70cc5833f8", "jingle_unittests": "8e1afa5ae1fa4529a759d2af2afc5126c3074fd5", "keyboard_unittests": "9d9931faf471f422fd064e2ff9b8b75cd4efe7fa", "latency_unittests": "943b28e5faadabcba098a1c8255045531adfee39", "leveldb_service_unittests": "8ea5ee5da31559c0a67b5115bd273d2c98bfb4d6", "libjingle_xmpp_unittests": "f69c8cc4fd25fc94001c61fd41d1c5e2c5738545", "media_blink_unittests": "b267995cba0e3769f49d1accc9a768bfe9621fa7", "media_service_unittests": "cf181304d3592f745b1bbe994a44cf0b78ed1761", "media_unittests": "20f107b70c0e85eb766215c79877c251d97b8aeb", "message_center_unittests": "ab884cd4d2dbc16a35f17b30ab28a13fc88790b5", "midi_unittests": "87e5b2250d1d8114b143a6765b9ed6350a07d153", "mojo_core_unittests": "82c6cb5367fc27a70d7adc1615e287088e7e2574", "mojo_unittests": "09f746a4656c0bbbfa2a0b564cccdd09b7486f86", "nacl_helper_nonsfi_unittests": "faa79f8a583860557424e70605e0ac59e743acc6", "nacl_loader_unittests": "3e68d6eab432157e1212eafd14f9dc2275bbbbbc", "native_theme_unittests": "d17e7aa6fd262f4c70f410c89288ec48235d0451", "net_unittests": "95bba569f7c94394dc72b761cacfce04e7028894", "ozone_gl_unittests": "f7ff2d890d32605371bb527bf9c272827c4118c7", "ozone_unittests": "69554d0dd4c65bd3703c0fddb408a33408923906", "ozone_x11_unittests": "224399f9893edad7ab870907c4d944174a4aff6d", "pdf_unittests": "533a38eeb7172558e5abd673b4feff325f8787df", "ppapi_unittests": "e0d2c6ce765956f18ab6b3e79236f53417d7de9e", "printing_unittests": "4f6010da9753bb63baa0c06ffa2b1d7bd315ae34", "remoting_unittests": "9e001339fbf66566e79d7d3dfc4d8e4b76e47030", "sandbox_linux_unittests": "92089a2802839a7271d0f0144a9772f2e7493d8a", "select_to_speak_extension_tests": "2d46839adba47f42f928f7f451e80259c336bd4a", "service_manager_unittests": "6c695cc65294f0061e210c7e0946f7fb2e628a28", "services_unittests": "b4b4751e6579f766e623f9271daa6d221cbfaeef", "shell_dialogs_unittests": "738f7fa78b74b6f62956091cdb48586252d26540", "skia_unittests": "391dfc264feaed8558ca9f215e9113558137158a", "snapshot_unittests": "9c97dc2ae03d3a52a93fc4eea845d69d99818565", "sql_unittests": "9f70c043b50f33307f146ee8b7571f6232ea3fd0", "storage_unittests": "fcdad79d374ddaa704bcbd1f515593cf0715d161", "sync_integration_tests": "8df1d9111e2e1b7af8b663815f320dc1eb4482a5", "traffic_annotation_auditor_unittests": "1befc69c9433530abb8bbee2f2b76c8f99fc56d0", "ui_base_unittests": "b51e232050d512c76b0fe79ac0953fe13f5340ee", "ui_chromeos_unittests": "c6a9629927e8aef82fce11e11e7658f9f98d8d3c", "ui_touch_selection_unittests": "9abd1131cb78c332851b3d75bf80ae4c38e28625", "unit_tests": "c963cf4fee90dbd6087453c73a09b14e0c24a872", "url_unittests": "3db9485780e2d148960635c0aa656c23edc19bca", "views_mus_interactive_ui_tests": "a43f5fcc424971d92e4eed31922f1ac0a18a5ff8", "views_mus_unittests": "c28233a8b5e2d25a171cd2b568ac7a2d240b4391", "views_unittests": "d16f7d0f8ec724d94f796778d9a6687938358ea6", "viz_unittests": "52e4fe7e9eee254ac925fa9b2743647720b187ad", "webkit_unit_tests": "bac51a47c6678c17a64f9fe99fccfef44a19fea6", "wm_unittests": "2cbf6ff3aad45e56cfd98e15a0a09bc07667db07", "wtf_unittests": "f6f1bd10b0e6a0d484c6c718b8584dc16ca99232"} find isolated tests

Blamelist:

  1. Colin Blundell (blundellohnoyoudont@chromium.org)
  2. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  3. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  4. Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
  5. Christian Dullweber (dullweberohnoyoudont@chromium.org)
  6. Xida Chen (xidachenohnoyoudont@chromium.org)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. David Davidović (davidovicohnoyoudont@google.com)
  9. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  10. Florent Castelli (orphisohnoyoudont@chromium.org)
  11. Florent Castelli (orphisohnoyoudont@chromium.org)
  12. Colin Blundell (blundellohnoyoudont@chromium.org)
  13. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  14. Camille Lamy (clamyohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 13:12:49 UTC
Start Friday, 12-Oct-18 13:13:25 UTC
End Friday, 12-Oct-18 14:30:48 UTC
Pending 35 secs
Execution 1 hrs 17 mins

All Changes:

  1. Start using IdentityTestEnvironment in ProfileSyncServiceBundle

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:10:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 863a437d0fdbbba19ad5446420b72d2f91748a72

    Comments

    Start using IdentityTestEnvironment in ProfileSyncServiceBundle
    
    ProfileSyncServiceBundle owns and exposes signin-related objects for
    use by sync tests. These signin-related objects include ones that are
    deprecated by IdentityManager and no longer used directly in the
    production code being tested; however, up until now it has not been
    feasible to convert this test utility to using IdentityTestEnvironment,
    as doing so would have required converting the widespread usage of this
    utility in one go.
    
    We recently introduced an IdentityTestEnvironment usage mode wherein
    it can be supplied with IdentityManager's dependencies from the
    external client, precisely to enable incremental conversion in use cases
    like this. This CL exploits this usage mode to introduce
    IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
    example of its usage to eliminate a direct usage of the deprecated
    classes. Once the conversion is complete, ProfileSyncServiceBundle can
    then be changed to *only* hold an IdentityTestEnvironment object.
    
    Bug: 886600, 886599
    Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
    Reviewed-on: https://chromium-review.googlesource.com/c/1273065
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599189}

    Changed files

    • components/browser_sync/BUILD.gn
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
  2. Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c12ec9eedc27e721f93de806016cfcf26225fde9

    Comments

    Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243
    
    Using wpt-import in Chromium 68550e484d7eecf6bd1d39fca300644ab2c21f5d.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25974
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I132a332cdc953a69e5c54c550a9bb4e5d08c9bb5
    Reviewed-on: https://chromium-review.googlesource.com/c/1277603
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599188}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
  3. Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f64dae1358dab03fb6fb5e12fc444dad20d38f4

    Comments

    Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f37e9866851d..2cecd6e79600
    
    
    Created with:
      gclient setdep -r src-internal@2cecd6e79600
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iac9c77c5c0927e0ca3862bf5171f5972e5c40ca7
    Reviewed-on: https://chromium-review.googlesource.com/c/1278711
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599187}

    Changed files

    • DEPS
  4. [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.

    Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:45:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17f212ee41ac78c428f851f24fa76ffee0ec8c3d

    Comments

    [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.
    
    Needed some rebaselining on Mac.
    
    Attempted to mark it as passing here:
    https://chromium-review.googlesource.com/c/1277649
    
    Then a sheriff marked it as failing again:
    https://chromium-review.googlesource.com/c/chromium/src/+/1278785
    
    TBR=kojii@chromium.org,orphis@chromium.org
    
    Change-Id: I4b282cba19e6c94f032c127f70672cf4cfe133ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1278805
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599186}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/platform/mac/fast/block/float/nopaint-after-layer-destruction-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction-expected.png
  5. Log UserDeletedCookieOrCacheFromDialog from Android

    Changed by Christian Dullweber - dullweberohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:43:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aeec7095a6a5129132a4fe7e5f5f0abeb2cf8ff3

    Comments

    Log UserDeletedCookieOrCacheFromDialog from Android
    
    We currently log the UserDeletedCookieOrCacheFromDialog histogram from
    Desktop. On Android we only know about total cookie/cache deletion
    and not those started from CBD.
    This CL adds logging of the UserDeletedCookieOrCacheFromDialog histogram
    to the CBD dialog on Android.
    
    Change-Id: I51c1ff6d3c5dc6f531f5bfccc59f522718b1abef
    Reviewed-on: https://chromium-review.googlesource.com/c/1276605
    Commit-Queue: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599185}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
    • content/public/android/BUILD.gn
    • content/public/browser/browsing_data_remover.h
  6. Rename OnHasTouchEventHandlersForTest in InputRouterImpl

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:40:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f7980b37fba64a72e95e35f17633e6cb3915321

    Comments

    Rename OnHasTouchEventHandlersForTest in InputRouterImpl
    
    The call site of this function is resetting the |allowed_touch_action_|
    only, so rename this function to ForceResetTouchActionForTest.
    
    This CL should not introduce any behavior change.
    
    Bug: None
    Change-Id: I253d73f4f21bdb6268f43ce535453412f4b32c51
    Reviewed-on: https://chromium-review.googlesource.com/c/1277947
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599184}

    Changed files

    • content/browser/renderer_host/input/input_router_impl.cc
    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/input/touch_action_filter.cc
    • content/browser/renderer_host/input/touch_action_filter.h
    • content/browser/site_per_process_hit_test_browsertest.cc
    • content/public/test/browser_test_utils.cc
  7. Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:35:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9729f6efb4bae858cc91b281091f2df86433da8a

    Comments

    Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a
    
    
    git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs.
    2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@55d1af14751a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278709
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599183}

    Changed files

    • DEPS
  8. Reland "[sync::test] Add single client integration test for custom passphrase"

    Changed by David Davidović - davidovicohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 12:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1df3c494cc8dc1ef26ec3514b74b27c3047a4db

    Comments

    Reland "[sync::test] Add single client integration test for custom passphrase"
    
    This is a reland of 475bfe9da1df9ab55685e0a9ce1a62d8e50536f1. Fixed test
    failures which happened because some DCHECKs had side effects.
    
    Original change's description:
    > [sync::test] Add single client integration test for custom passphrase
    >
    > Add a Sync integration test which exercises custom passphrase flows, including
    > the handling and proper functioning of the newly added key derivation method
    > (scrypt).
    >
    > Add an integration test helper file for encryption-related tasks and modify
    > FakeServer and LoopbackServer to allow easier modification of persistent
    > entities such as Nigori. Add passphrase-related functionality to
    > ProfileSyncServiceHarness to give tests better control over how and when
    > passphrase-based encryption is enabled.
    >
    > The test uses a gray-box approach, where it tests the client at the
    > ProfileSyncService granularity, but injects and inspects entities on the (fake)
    > server to ensure that encryption is performed properly. This is necessary
    > because, when it comes to encryption, we are not interested merely in that it
    > does not hinder existing functionality (e.g. two clients are syncing data
    > properly in the presence of a custom passphrase), but also that it provides the
    > expected security to the user. For this reason, we use our knowledge of the
    > encryption architecture internals to ensure that the data committed to the
    > server is encrypted in the expected way.
    >
    > Bug: 894148
    > Change-Id: I728f7f18cc0db7b1da50f747a87a640877d0b023
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274205
    > Commit-Queue: David Davidović <davidovic@google.com>
    > Reviewed-by: vitaliii <vitaliii@chromium.org>
    > Reviewed-by: Marc Treib <treib@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598912}
    
    Bug: 894148
    Change-Id: I752acff5815531c0c83ebefb43fb620a785e3ca3
    Reviewed-on: https://chromium-review.googlesource.com/c/1278790
    Commit-Queue: David Davidović <davidovic@google.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599182}

    Changed files

    • chrome/browser/sync/test/integration/bookmarks_helper.cc
    • chrome/browser/sync/test/integration/bookmarks_helper.h
    • chrome/browser/sync/test/integration/encryption_helper.cc
    • chrome/browser/sync/test/integration/encryption_helper.h
    • chrome/browser/sync/test/integration/profile_sync_service_harness.cc
    • chrome/browser/sync/test/integration/profile_sync_service_harness.h
    • chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.h
    • chrome/test/BUILD.gn
    • components/sync/engine_impl/loopback_server/loopback_server.cc
    • components/sync/engine_impl/loopback_server/loopback_server.h
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  9. Don't update style for focusability when render-blocking.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 369b6fca37d5b416775fd7fafdbc6bde78a18bf8

    Comments

    Don't update style for focusability when render-blocking.
    
    WebNode::IsFocusable() updated style and layout tree, without ignoring
    pending stylesheets, which meant generating a display:none placeholder
    style for the root node. Instead, early return from IsFocusable() when
    we are blocking rendering.
    
    Bug: 521692
    
    Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
    Reviewed-on: https://chromium-review.googlesource.com/c/1245787
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599181}

    Changed files

    • third_party/blink/renderer/core/exported/web_node.cc
    • third_party/blink/renderer/core/exported/web_node_test.cc
  10. Revert "[blink] Control ScriptStreamer with ScriptResource"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7590d68012b9cf52c14e3f44e019ea36ecc2d9e

    Comments

    Revert "[blink] Control ScriptStreamer with ScriptResource"
    
    This reverts commit 7bd9163502462762e58d8010577dbf36aeef6c13.
    
    Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
    Bug: 894792, 894795
    
    Original change's description:
    > [blink] Control ScriptStreamer with ScriptResource
    > 
    > Move the ScriptStreamer control logic from ClassicPendingScript to
    > ScriptResource. In the future, this will allow us to start streaming
    > a ScriptResource before the ClassicPendingScript is available, e.g on
    > preload.
    > 
    > The ClassicPendingScript now only sends one "finished" callback, from
    > ScriptResource. This callback is either when the streaming completes,
    > or when there is no streaming and the ClassicPendingScript has told
    > the ScriptResource that it doesn't intend to start streaming. In the
    > long run, we want all scripts to go through the streaming interface,
    > and we want ScriptResource to control when streaming starts, so the
    > "no more streaming" call will disappear -- however it is necessary to
    > maintain the current behaviour, and be able to control it with a
    > runtime flag.
    > 
    > Bug: chromium:865098
    > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599148}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098
    Reviewed-on: https://chromium-review.googlesource.com/c/1278758
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599180}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  11. Revert "Make DriveFS opt-out in FilesApp tests."

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:11:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 70d0138d92d063b4d3032ffae54c950cf7c13f41

    Comments

    Revert "Make DriveFS opt-out in FilesApp tests."
    
    This reverts commit e9c79d562d8d3b789cca95b6909aa600a1dd39d2.
    
    Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
    Bug: 894799
    
    Original change's description:
    > Make DriveFS opt-out in FilesApp tests.
    > 
    > Bug: 891197
    > Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    > Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Commit-Queue: Sam McNally <sammc@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599117}
    
    TBR=noel@chromium.org,sammc@chromium.org
    
    Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 891197
    Reviewed-on: https://chromium-review.googlesource.com/c/1278757
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599179}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  12. Enable IdentityTestEnvironment to take in IdentityManager's dependencies

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b64e54c9a221efad82a4a60956cd3b58ac371059

    Comments

    Enable IdentityTestEnvironment to take in IdentityManager's dependencies
    
    Currently, IdentityTestEnvironment internally constructs all the
    dependencies of IdentityManager as well as the IdentityManager object
    itself. This behavior is nice for hiding the fact that IdentityManager
    has these dependencies from consumers, but doesn't allow for
    usage of IdentityTestEnviroment in incremental conversion of tests that
    have broad direct usage of these dependencies. Concretely,
    profile_sync_test_util.h provides one such problematic case: it
    constructs and directly exposes these dependencies, which are then
    broadly used by a set of tests that consume this utility class.
    Converting all these tests in one go is not practical.
    
    This CL adds an alternate IdentityTestEnvironment constructor that
    takes in the dependencies and constructs IdentityManager via those
    passed-in dependencies. To enable this constructor, the CL also
    encapsulates the fact that IdentityTestEnvironment otherwise obtains
    these dependencies from an internal object within the current
    IdentityTestEnvironment constructor.  It also moves ownership of
    IdentityManager from that internal object to IdentityTestEnvironment
    itself so that it can be created/owned independent of that internal
    object.
    
    A followup CL will use this new constructor.
    
    Bug: 886599
    Change-Id: I4c6a503dcc11c327193f80bc7d7c48e467c6919b
    Reviewed-on: https://chromium-review.googlesource.com/c/1273298
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599178}

    Changed files

    • services/identity/public/cpp/identity_test_environment.cc
    • services/identity/public/cpp/identity_test_environment.h
  13. [css-properties-values-api] Support StylePropertyMap.append.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:05:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84056b7e0dee6cb71b889254c2f33c0b338002fb

    Comments

    [css-properties-values-api] Support StylePropertyMap.append.
    
    This CL makes it possible to append values to list-valued properties.
    
    To do this, we must produce a CSSStyleValueVector which holds the final
    value produced by the append (i.e. the concatenation of the existing
    values and the incoming values). Then (like for StylePropertyMap.set),
    a CSSVariableReferenceValue with equivalent tokens is created from that
    vector.
    
    Bonus: Fix names of some tests to make it easier to read the output.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
    Reviewed-on: https://chromium-review.googlesource.com/c/1270967
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599177}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.h
  14. Create NavigationRequest from LoadURLParams

    Changed by Camille Lamy - clamyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5193caa162249e66ecec99fbf1e94fd38557b672

    Comments

    Create NavigationRequest from LoadURLParams
    
    This CL allows to create the NavigationRequest directly from
    LoadURLParams for new navigations.
    
    Bug: 803859
    Change-Id: Ic0f3f368ade86fe57bb549ae6c1d5711f1b58d0e
    Reviewed-on: https://chromium-review.googlesource.com/c/1097407
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599176}

    Changed files

    • content/browser/frame_host/navigation_controller_impl.cc
    • content/browser/frame_host/navigation_controller_impl.h
    • content/browser/frame_host/navigation_entry_impl.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request.h
    • content/browser/frame_host/navigator_impl.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc