Home | Search | chromium - Builders
Login

Builder linux-blink-heap-incremental-marking Build 5898 Canonical Ubuntu

Results:

Failure webkit_layout_tests

Trigger Info:

Projectchromium
Revisionc67047dd2ff166e62aa72f9d461e3a00baf5e573
Got Revisionc67047dd2ff166e62aa72f9d461e3a00baf5e573

Execution:

Steps and Logfiles:

Show:
  1. ( 421 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) report builders
     
    running builder/tester 'linux-blink-heap-incremental-marking' on master 'chromium.fyi'
  3. ( 8 mins 4 secs ) bot_update
    [76GB/295GB used (25%)]
  4. ( 2 secs ) swarming.py --version
    0.14
  5. ( 43 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
  7. ( 834 ms ) lookup GN args
     
    enable_blink_heap_incremental_marking = true
    is_component_build = true
    is_debug = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 5 mins 59 secs ) compile
  9. ( 1 mins 59 secs ) isolate tests
  10. ( 713 ms ) find isolated tests
  11. ( 1 secs ) wait for tasks
  12. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  13. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  14. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  15. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  16. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  17. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  18. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  19. ( 3 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 47s
  20. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  21. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  22. ( 3 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 57s
  23. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  24. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  25. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  26. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  27. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  28. ( 2 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  29. ( 2 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  30. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 48s
  31. ( 1 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 38s
  32. ( 15 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:20:41.209018
  33. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  34. ( 4 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:08.836086
  35. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  36. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  37. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  38. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  39. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  40. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  41. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  42. ( 2 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  43. ( 1 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 28s
  44. ( 1 secs ) wait for tasks (2)
  45. ( 4 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:12.140497
  46. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:23.878096
  47. ( 2 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  48. ( 3 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:58.980076
  49. ( 4 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 51s
  50. ( 2 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 38s
  51. ( 4 mins 9 secs ) wait for tasks (3)
  52. ( 6 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:06:08.863602
  53. ( 6 mins 2 secs ) wait for tasks (4)
  54. ( 7 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:13:59.832322
  55. ( 14 mins 4 secs ) wait for tasks (5)
  56. ( 7 mins 40 secs ) webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:28:32.548776 (shard #5)
    Min shard duration: 0:23:06.674135 (shard #6)
    Total tests: 91887
    * Passed: 78703 (78664 expected, 39 unexpected)
    * Skipped: 10466 (10466 expected, 0 unexpected)
    * Failed: 2625 (2624 expected, >>>1 unexpected<<<)
    * Flaky: 93 (93 expected, 0 unexpected)
     
    Unexpected Failures:
    * http/tests/priority-hints/link-dynamic-insertion.html
     
  57. ( 8 mins 12 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:46:42.507036
  58. ( 514 ms ) Tests statistics
     
    Stats
    Total shards: 53
    Total runtime: 6:29:41.941359
     
  59. ( 2 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm848-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544164163539676, "id": "8927820234011337200", "project": "chromium", "tags": ["builder:linux-blink-heap-incremental-marking", "buildset:commit/git/c67047dd2ff166e62aa72f9d461e3a00baf5e573", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c67047dd2ff166e62aa72f9d461e3a00baf5e573", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093250296118498848", "scheduler_job_id:chromium/linux-blink-heap-incremental-marking", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "linux-blink-heap-incremental-marking" setup_build
buildnumber 5898 setup_build
mastername "chromium.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "c67047dd2ff166e62aa72f9d461e3a00baf5e573" setup_build
got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "c67047dd2ff166e62aa72f9d461e3a00baf5e573" bot_update
got_revision_cp "refs/heads/master@{#614624}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" bot_update
got_v8_revision_cp "refs/heads/7.3.56@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes_refs/heads/master(at){#614624}_without_patch {"angle_unittests": "07efdb473ac2e22cafef3bdd21df68b13a099e55", "base_unittests": "bf42ee20d8222fa115fca3e867e5733136892c8f", "blink_common_unittests": "8e114034a4e16eedc67a4a9d57a674849fd9a7ea", "blink_heap_unittests": "4bffd836be6922602f7956e517e8a7df5b32e5d1", "blink_platform_unittests": "e34d219de2e40c19f8cfa7ce7a5947a0479555a8", "boringssl_crypto_tests": "86034beb88b619d34777fdcc2ff2afed2f28cffe", "boringssl_ssl_tests": "d372ea23c1a91d0c6f83929ddf3c33c5c5c0354f", "cacheinvalidation_unittests": "62800905bf08a84f71c4b956cf7f83a201f5d65a", "capture_unittests": "12b1e374830d53086e9017225f03d98ed1bc8200", "cast_unittests": "22554e6cc6d2b9321109399345f1334cb211359c", "components_browsertests": "bce4e98f526f37061a973c139f2739cd2038fde2", "components_unittests": "085e916c2a9f268e3c32e760fdfa821d04a3dcab", "content_browsertests": "2bb07045f4c725af611388c2c033b64cae49e95e", "content_unittests": "a3e7de2857baa5c487b528c546ee8ef0830bddad", "crypto_unittests": "7c178e73f4811d9365d4be563f43a35349351ce3", "events_unittests": "602fe981411b15df0847fd000794eacca7ba0620", "gcm_unit_tests": "fc1c21849151d4f376fd48dcea93a9c9fa4a2a76", "gin_unittests": "fc5a4ab38177291fee6b311057a1af1dfb73d369", "google_apis_unittests": "8422e6b95aee515d069667dfac4d71e90d8a0c00", "gpu_unittests": "a28587eec7ef03c339689a277b653a429fd2b1f0", "ipc_tests": "e08f576ad429f8897d442f8427f24272a5f5aec9", "jingle_unittests": "8f65ff9b7d7aaff8785b67faf7876909bc524382", "latency_unittests": "8462410b3a4d5b5e7caa5efff0316f6106c1b773", "libjingle_xmpp_unittests": "d3acce37a5c2bc497cd781b46d046edefc0c4862", "media_blink_unittests": "490a42da0d2e3f46d9cb3c1927ad2da320cd4c41", "media_service_unittests": "6f2665caa630e8006cefff7e3fb84aa14d72e82f", "media_unittests": "f69835cafdd3e4bf5be98462285f10eab4f418ea", "midi_unittests": "4068c9359be66763c0447aa418c28ca4b13c20c0", "mojo_unittests": "76c5bd1976496ed375fd9db94746c13c7bc2107b", "net_unittests": "8f33cf8e671050d63764b14bd90fa5fc4bf25c83", "services_unittests": "2a35ba0cf4a88133b2c387d95651e7a3604de54d", "shell_dialogs_unittests": "d5cda5054f6eb891d06f931c07498551750c2b2b", "skia_unittests": "207a4baa0ce6e2fa00466216705054c640a6f672", "sql_unittests": "f2c32cbe9c67b2744f5e2102ab3eb5d5d00dad10", "storage_unittests": "b6d5a06491afc9c384b64c893ed707a18d674766", "ui_base_unittests": "ae0e1a7e6bb7fdf06eb78a482c100f052d1ba1b3", "ui_touch_selection_unittests": "a347fadc64fd6ed6f2b1884f8e44c27e0bf6731a", "url_unittests": "38f82a8bf15020ba1efa9bb75ceda585c84d960f", "webkit_layout_tests_exparchive": "fa408823322b0259306b5388329bb872c18b4421", "webkit_unit_tests": "cc1f6b9143b4a7431370be15cb39e7bb8b9edbe8", "wtf_unittests": "21126c5f361e82cc6bfb1ffe1765f4318cd4d10c"} isolate tests
swarm_hashes {"angle_unittests": "07efdb473ac2e22cafef3bdd21df68b13a099e55", "base_unittests": "bf42ee20d8222fa115fca3e867e5733136892c8f", "blink_common_unittests": "8e114034a4e16eedc67a4a9d57a674849fd9a7ea", "blink_heap_unittests": "4bffd836be6922602f7956e517e8a7df5b32e5d1", "blink_platform_unittests": "e34d219de2e40c19f8cfa7ce7a5947a0479555a8", "boringssl_crypto_tests": "86034beb88b619d34777fdcc2ff2afed2f28cffe", "boringssl_ssl_tests": "d372ea23c1a91d0c6f83929ddf3c33c5c5c0354f", "cacheinvalidation_unittests": "62800905bf08a84f71c4b956cf7f83a201f5d65a", "capture_unittests": "12b1e374830d53086e9017225f03d98ed1bc8200", "cast_unittests": "22554e6cc6d2b9321109399345f1334cb211359c", "components_browsertests": "bce4e98f526f37061a973c139f2739cd2038fde2", "components_unittests": "085e916c2a9f268e3c32e760fdfa821d04a3dcab", "content_browsertests": "2bb07045f4c725af611388c2c033b64cae49e95e", "content_unittests": "a3e7de2857baa5c487b528c546ee8ef0830bddad", "crypto_unittests": "7c178e73f4811d9365d4be563f43a35349351ce3", "events_unittests": "602fe981411b15df0847fd000794eacca7ba0620", "gcm_unit_tests": "fc1c21849151d4f376fd48dcea93a9c9fa4a2a76", "gin_unittests": "fc5a4ab38177291fee6b311057a1af1dfb73d369", "google_apis_unittests": "8422e6b95aee515d069667dfac4d71e90d8a0c00", "gpu_unittests": "a28587eec7ef03c339689a277b653a429fd2b1f0", "ipc_tests": "e08f576ad429f8897d442f8427f24272a5f5aec9", "jingle_unittests": "8f65ff9b7d7aaff8785b67faf7876909bc524382", "latency_unittests": "8462410b3a4d5b5e7caa5efff0316f6106c1b773", "libjingle_xmpp_unittests": "d3acce37a5c2bc497cd781b46d046edefc0c4862", "media_blink_unittests": "490a42da0d2e3f46d9cb3c1927ad2da320cd4c41", "media_service_unittests": "6f2665caa630e8006cefff7e3fb84aa14d72e82f", "media_unittests": "f69835cafdd3e4bf5be98462285f10eab4f418ea", "midi_unittests": "4068c9359be66763c0447aa418c28ca4b13c20c0", "mojo_unittests": "76c5bd1976496ed375fd9db94746c13c7bc2107b", "net_unittests": "8f33cf8e671050d63764b14bd90fa5fc4bf25c83", "services_unittests": "2a35ba0cf4a88133b2c387d95651e7a3604de54d", "shell_dialogs_unittests": "d5cda5054f6eb891d06f931c07498551750c2b2b", "skia_unittests": "207a4baa0ce6e2fa00466216705054c640a6f672", "sql_unittests": "f2c32cbe9c67b2744f5e2102ab3eb5d5d00dad10", "storage_unittests": "b6d5a06491afc9c384b64c893ed707a18d674766", "ui_base_unittests": "ae0e1a7e6bb7fdf06eb78a482c100f052d1ba1b3", "ui_touch_selection_unittests": "a347fadc64fd6ed6f2b1884f8e44c27e0bf6731a", "url_unittests": "38f82a8bf15020ba1efa9bb75ceda585c84d960f", "webkit_layout_tests_exparchive": "fa408823322b0259306b5388329bb872c18b4421", "webkit_unit_tests": "cc1f6b9143b4a7431370be15cb39e7bb8b9edbe8", "wtf_unittests": "21126c5f361e82cc6bfb1ffe1765f4318cd4d10c"} find isolated tests

Blamelist:

  1. maxmorin (maxmorinohnoyoudont@chromium.org)
  2. Charles Zhao (charleszhaoohnoyoudont@chromium.org)
  3. Alan Cutter (alancutterohnoyoudont@chromium.org)
  4. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  5. Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
  6. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  7. Li Lin (llinohnoyoudont@chromium.org)
  8. Joel Hockey (joelhockeyohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 06:29:23 UTC
Start Friday, 07-Dec-18 06:30:00 UTC
End Friday, 07-Dec-18 07:40:59 UTC
Pending 36 secs
Execution 1 hrs 10 mins

All Changes:

  1. Activate audio thread hang monitoring when OOP

    Changed by maxmorin - maxmorinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c67047dd2ff166e62aa72f9d461e3a00baf5e573

    Comments

    Activate audio thread hang monitoring when OOP
    
    Also includes cleaning up the hang monitor:
     * Actually a class!
     * Actually possible to stop the hang monitor!
     * Tests!
     * When OOP, uploads dumps (without crashing). A kill switch is added for this.
     * Switch the UMA enum to kCase, make it a class enum, and use the simpler UMA
       histogram.
     * Switch from "tail posting" the periodic task to using RepeatingTimer.
     * Runs on the task scheduler rather than on the browser IO thread.
     * Some suspend/resume code was simplified.
    
    The hang monitor is now owned by the AudioThread implementation.
    
    Extra functionality (such a nuking the audio process in case of a hang)
    is coming later.
    
    Bug: 866442, 905681
    Change-Id: Icfe83cc3e7626b164648a8b502d13cf2cfc25518
    Reviewed-on: https://chromium-review.googlesource.com/c/1340264
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Max Morin <maxmorin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614624}

    Changed files

    • content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • media/audio/BUILD.gn
    • media/audio/audio_features.cc
    • media/audio/audio_features.h
    • media/audio/audio_manager.cc
    • media/audio/audio_manager.h
    • media/audio/audio_thread.h
    • media/audio/audio_thread_hang_monitor.cc
    • media/audio/audio_thread_hang_monitor.h
    • media/audio/audio_thread_hang_monitor_unittest.cc
    • media/audio/audio_thread_impl.cc
    • media/audio/audio_thread_impl.h
    • media/audio/test_audio_thread.cc
    • media/audio/test_audio_thread.h
    • services/audio/owning_audio_manager_accessor.cc
  2. TabRanker: Fix Query time logging.

    Changed by Charles Zhao - charleszhaoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6378752b810e6122744cefac544c8d84278dcc71

    Comments

    TabRanker: Fix Query time logging.
    
    
    TabRanker query time logging was landed in this cl:
    https://chromium-review.googlesource.com/c/chromium/src/+/1350445
    
    TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to
    TabManager::GetSortedLifecycleUnits()
    
    But this was wrong on two aspects:
    
    (1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(),
        so ChromeOS discards are all skipped.
    
    (2) TabManagerDelegate::Candidate is calling
        lifecycle_unit_->GetSortKey() for inferring sorting,
        Which means TabRanker model won't work for ChromeOS discards.
    
    
    The fix:
    (1) Change TabManager, TabLifecycleUnit back to their previous code,
        which were sorting LifecycleUnits by TabRanker when it's enabled.
    
    (2) Add TabActivityWatcher::LogOldestNTabFeatures() and call this function in
        TabManager::DiscardTab for query time logging.
    
    Bug: 911474
    
    Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1360471
    Reviewed-by: Christopher Morin <cmtm@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Charles . <charleszhao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614623}

    Changed files

    • chrome/browser/resource_coordinator/tab_activity_watcher.cc
    • chrome/browser/resource_coordinator/tab_activity_watcher.h
    • chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
  3. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"
    
    This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.
    
    Reason for revert: Broke compile:
    https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
    ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
    #include "libassistant/shared/internal_api/alarm_timer_types.h"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Original change's description:
    > Timer notification UI improvement:
    > 
    > * Add timer deeplinks for:
    >   - Stop timer
    >   - Add time to timer
    > * Add "add 1 min to timer" button to timer notification.
    > 
    > Using a feature flag to guard the usage of the deeplink as
    > AlarmTimerManager is not fully available yet.
    > 
    > Bug: b:119116816
    > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    > Commit-Queue: Li Lin <llin@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614618}
    
    TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org
    
    Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:119116816
    Reviewed-on: https://chromium-review.googlesource.com/c/1367081
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  4. Report PreviewsEligibilityReason as offline when device is offline

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:11:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1

    Comments

    Report PreviewsEligibilityReason as offline when device is offline
    
    Currently, if the device is offline, PreviewsEligibilityReason
    records the reason for not showing previews as network quality
    unavailable.
    
    This CL changes it to record the reason as device offline.
    Network quality unavailable reason is now used for only the cases where
    NQE (network quality estimator) reports ECT as Unknown.
    
    Bug: 912725
    Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366835
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614621}

    Changed files

    • components/previews/content/previews_decider_impl.cc
    • components/previews/content/previews_decider_impl_unittest.cc
    • components/previews/core/previews_black_list.h
    • components/previews/core/previews_logger.cc
    • tools/metrics/histograms/enums.xml
  5. Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

    Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1eb8373104f00c0ca44780a28d621dd6cf2f603

    Comments

    Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused
    
    This field was added before to keep the copy of the bundle around in
    RFHI but not really used any more.
    
    Bug: N/A
    Change-Id: Ib007ee7dc941b980bab3ad92a1de016ad14d155c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365052
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614620}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
  6. Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e595fa693a4ef17b348340dbb64cf039c765e9c7

    Comments

    Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10e8db47197f..3e90e0805dd5
    
    
    Created with:
      gclient setdep -r src-internal@3e90e0805dd5
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia59b4d7347cb4c123f7e30d889f30af08e8b39f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1367115
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614619}

    Changed files

    • DEPS
  7. Timer notification UI improvement:

    Changed by Li Lin - llinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:41:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d710a7b3ef59302c00c2e3fe1b00c788310801c6

    Comments

    Timer notification UI improvement:
    
    * Add timer deeplinks for:
      - Stop timer
      - Add time to timer
    * Add "add 1 min to timer" button to timer notification.
    
    Using a feature flag to guard the usage of the deeplink as
    AlarmTimerManager is not fully available yet.
    
    Bug: b:119116816
    Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    Commit-Queue: Li Lin <llin@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614618}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  8. Crostini: migrate persisted paths from Downloads to MyFiles

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:38:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa7bc76e086df2f9428a2d583546f84f81c59d16

    Comments

    Crostini: migrate persisted paths from Downloads to MyFiles
    
    When MyFiles is enabled, check persisted paths in prefs
    and convert paths as needed.
    
    Bug: 911946
    Change-Id: I3931d196f89f31fa2ae95f7e02f9241b25d23524
    Reviewed-on: https://chromium-review.googlesource.com/c/1366458
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614617}

    Changed files

    • chrome/browser/chromeos/crostini/crostini_share_path.cc
    • chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
    • chrome/browser/chromeos/file_manager/path_util.cc
    • chrome/browser/chromeos/file_manager/path_util.h
    • chrome/browser/chromeos/file_manager/path_util_unittest.cc