Builder linux-annotator-rel Build 6655

Results:

Success

Trigger Info:

Project	chromium
Revision	3b507230349b10d228ac6bbdbc8c47a382736b94
Got Revision	3b507230349b10d228ac6bbdbc8c47a382736b94

Execution:

• Source: Task 42f5e3aea21d7d10
• Bot: swarm2380-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 332 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 339 ms ) report builders

    

   running builder/tester 'linux-annotator-rel' on master 'chromium.fyi'
   • stdout
   • bots.json
3. ( 1 mins 4 secs ) bot_update

   [217GB/295GB used (73%)]
   • stdout
   • json.output
4. ( 125 ms ) ensure_goma
   • - no logs -
   1. ( 125 ms ) ensure_installed
      • stdout
      • json.output
5. ( 792 ms ) swarming.py --version

   0.14
   • stdout
6. ( 11 secs ) gclient runhooks
   • stdout
7. ( 2 secs ) get compile targets for scripts
   • stdout
   • json.output
8. ( 1 secs ) read test spec (chromium.fyi.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
   • stdout
   • json.output
9. ( 660 ms ) lookup GN args

    

   is_component_build = false

   is_debug = false

   strip_absolute_paths_from_debug_symbols = true

   use_goma = true

   goma_dir = "/b/swarming/w/ir/cache/goma/client"
   • stdout
10. ( 11 secs ) generate_build_files
    • stdout
11. ( 15 secs ) preprocess_for_goma
    • - no logs -
    1. ( 694 ms ) goma cache directory
       • stdout
    2. ( 13 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
12. ( 6 mins 6 secs ) compile
    • stdout
13. ( 6 secs ) compile confirm no-op
    • stdout
14. ( 19 secs ) postprocess_for_goma
    • - no logs -
    1. ( 1 secs ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 718 ms ) goma_stat
       • stdout
    3. ( 788 ms ) stop_goma
       • stdout
    4. ( 15 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 1 secs ) stop cloudtail
       • stdout
15. ( 0 ) test_pre_run
    • - no logs -
16. ( 5 hrs 49 mins ) test_traffic_annotation_auditor
    • stdout
    • json.output
17. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/buildbucket	{"build": {"builder": {"bucket": "ci", "builder": "linux-annotator-rel", "project": "chromium"}, "createTime": "2019-02-11T14:59:40.036422Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921808730504409536", "infra": {"buildbucket": {"serviceConfigRevision": "ef156230f5cd7f8c23f689fa4dc7f92742cd904d"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "chromium"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "3b507230349b10d228ac6bbdbc8c47a382736b94", "project": "chromium/src", "ref": "refs/heads/master"}}, "number": 6655, "tags": [{"key": "builder", "value": "linux-annotator-rel"}, {"key": "buildset", "value": "commit/git/3b507230349b10d228ac6bbdbc8c47a382736b94"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/chromium/src/+/3b507230349b10d228ac6bbdbc8c47a382736b94"}, {"key": "scheduler_invocation_id", "value": "9087238792648981808"}, {"key": "scheduler_job_id", "value": "chromium/linux-annotator-rel"}, {"key": "user_agent", "value": "luci-scheduler"}]}}	setup_build
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2380-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549897180036422, "id": "8921808730504409536", "project": "chromium", "tags": ["build_address:luci.chromium.ci/linux-annotator-rel/6655", "builder:linux-annotator-rel", "buildset:commit/git/3b507230349b10d228ac6bbdbc8c47a382736b94", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/3b507230349b10d228ac6bbdbc8c47a382736b94", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9087238792648981808", "scheduler_job_id:chromium/linux-annotator-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"linux-annotator-rel"	setup_build
buildnumber	6655	setup_build
mastername	"chromium.fyi"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"3b507230349b10d228ac6bbdbc8c47a382736b94"	setup_build
got_angle_revision	"abf6dbbb107b3487480422b6ce37e9662cb8f302"	bot_update
got_dawn_revision	"3b71e65658cdb3dd5c8455241e3a5b8576b5b1dc"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"3b507230349b10d228ac6bbdbc8c47a382736b94"	bot_update
got_revision_cp	"refs/heads/master@{#630755}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"b2a0a5fc72fc1a2e5f566db1fb1e17a9a3e8df8b"	bot_update
got_v8_revision_cp	"refs/heads/7.4.132@{#1}"	bot_update
got_webrtc_revision	"61b4f7489dbda45092973a2d28cc893388ae7bb2"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26625}"	bot_update

Blamelist:

1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
2. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
3. Lowell Manners (lowellohnoyoudont@chromium.org)
4. dstockwell (dstockwellohnoyoudont@google.com)
5. dpapad (dpapadohnoyoudont@chromium.org)
6. Mikhail Khokhlov (khokhlovohnoyoudont@google.com)
7. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
8. Olya Kalitova (okalitovaohnoyoudont@chromium.org)
9. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
10. Henrique Ferreiro (hferreiroohnoyoudont@igalia.com)
11. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
12. Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)
13. François Beaufort (beaufort.francoisohnoyoudont@gmail.com)
14. Raul Tambre (raulohnoyoudont@tambre.ee)
15. Tien Mai (tienmaiohnoyoudont@chromium.org)
16. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
17. jdoerrie (jdoerrieohnoyoudont@chromium.org)
18. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
20. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
21. Javier Fernandez (jfernandezohnoyoudont@igalia.com)
22. jdoerrie (jdoerrieohnoyoudont@chromium.org)
23. Markus Heintz (markusheintzohnoyoudont@chromium.org)
24. Maksim Sisov (msisovohnoyoudont@igalia.com)
25. Brian White (bcwhiteohnoyoudont@chromium.org)
26. jdoerrie (jdoerrieohnoyoudont@chromium.org)
27. jdoerrie (jdoerrieohnoyoudont@chromium.org)
28. Sergio Villar Senin (svillarohnoyoudont@igalia.com)
29. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
30. Raul Tambre (raulohnoyoudont@tambre.ee)
31. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
32. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
33. Rune Lillesveen (futharkohnoyoudont@chromium.org)
34. Raul Tambre (raulohnoyoudont@tambre.ee)
35. Mikel Astiz (mastizohnoyoudont@chromium.org)
36. jdoerrie (jdoerrieohnoyoudont@chromium.org)
37. Benoît Lizé (lizebohnoyoudont@chromium.org)
38. Ioana Pandele (ioanapohnoyoudont@chromium.org)
39. Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
40. Clemens Arbesser (arbesserohnoyoudont@google.com)
41. Juan Antonio Navarro Perez (perezjuohnoyoudont@chromium.org)
42. Marc Treib (treibohnoyoudont@chromium.org)
43. Christian Dullweber (dullweberohnoyoudont@chromium.org)
44. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
45. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
46. Mikel Astiz (mastizohnoyoudont@chromium.org)
47. arthursonzogni (arthursonzogniohnoyoudont@chromium.org)
48. Vaclav Brozek (vabrohnoyoudont@chromium.org)
49. Raul Tambre (raulohnoyoudont@tambre.ee)
50. Friedrich Horschig (fhorschigohnoyoudont@chromium.org)
51. Marc Treib (treibohnoyoudont@chromium.org)
52. Friedrich Horschig (fhorschigohnoyoudont@chromium.org)
53. Victor Costan (pwnallohnoyoudont@chromium.org)
54. arthursonzogni (arthursonzogniohnoyoudont@chromium.org)
55. Michael Giuffrida (michaelpgohnoyoudont@chromium.org)

Timing:

Create	Monday, 11-Feb-19 14:59:40 UTC
Start	Monday, 11-Feb-19 14:59:44 UTC
End	Monday, 11-Feb-19 20:58:08 UTC
Pending	4 secs
Execution	5 hrs 58 mins

All Changes:

1. Roll src/third_party/swiftshader 9388dded242f..d9ce258c174b (1 commits)

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Monday, 11-Feb-19 14:58:26 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	3b507230349b10d228ac6bbdbc8c47a382736b94

   Comments

   Roll src/third_party/swiftshader 9388dded242f..d9ce258c174b (1 commits)
   
   https://swiftshader.googlesource.com/SwiftShader.git/+log/9388dded242f..d9ce258c174b
   
   
   git log 9388dded242f..d9ce258c174b --date=short --no-merges --format='%ad %ae %s'
   2019-02-11 bclayton@google.com CMake: Generate the ICD json file into the output directory
   
   
   Created with:
     gclient setdep -r src/third_party/swiftshader@d9ce258c174b
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
   TBR=swiftshader-team+autoroll@chromium.org
   
   Change-Id: I1933110f805ca4baa9ccac24a1dbc45fd31d8acf
   Reviewed-on: https://chromium-review.googlesource.com/c/1463074
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#630755}

   Changed files

   • DEPS

2. Roll src/third_party/skia d336ebdea812..116d4065d0a8 (1 commits)

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Monday, 11-Feb-19 14:57:37 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	71b1ec3ea790c71bdf401285ec20eddbacf960f4

   Comments

   Roll src/third_party/skia d336ebdea812..116d4065d0a8 (1 commits)
   
   https://skia.googlesource.com/skia.git/+log/d336ebdea812..116d4065d0a8
   
   
   git log d336ebdea812..116d4065d0a8 --date=short --no-merges --format='%ad %ae %s'
   2019-02-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9686153413f3..9388dded242f (1 commits)
   
   
   Created with:
     gclient setdep -r src/third_party/skia@116d4065d0a8
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
   TBR=stephana@chromium.org
   
   Change-Id: Ib6d46b7592bb73393695db500969b82459b7081c
   Reviewed-on: https://chromium-review.googlesource.com/c/1463064
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#630754}

   Changed files

   • DEPS

3. Convert cloud_policy_manager_browsertest.cc to use GetSafeWeakWrapper.

   Changed by	Lowell Manners - lowellohnoyoudont@chromium.org
   Changed at	Monday, 11-Feb-19 14:54:56 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	7c187b7e2ab5d06ffc3286b5729d9d2934d0f716

   Comments

   Convert cloud_policy_manager_browsertest.cc to use GetSafeWeakWrapper.
   
   GetSafeWeakWrapper takes care of calling Detach(), so tests don't have
   to.
   
   This change also fixes some memory safety issues in this test where
   stack-allocated variables were being captured reference [&], for
   callbacks that may be invoked after the stack-allocated variables have
   been deallocated.
   
   Capturing stack-allocated variables by reference appears to have worked
   before this change only because the Detach() call on line 197 prevented
   callbacks from being run a second time.
   
   Bug: 924960
   Change-Id: I89e4a217ad4793104c560c7a61a34b3171765ec6
   Reviewed-on: https://chromium-review.googlesource.com/c/1454358
   Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
   Commit-Queue: Lowell Manners <lowell@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#630753}

   Changed files

   • chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc

4. pdf: Work around focus appearing for styled input elements

   Changed by	dstockwell - dstockwellohnoyoudont@google.com
   Changed at	Monday, 11-Feb-19 14:50:02 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	49deb96b74bc22894e326478d6d86886f2f797a5

   Comments

   pdf: Work around focus appearing for styled input elements
   
   Bug: 902646
   Change-Id: I9d8b18cbc95064367580d37dce9b1a48640f7706
   Reviewed-on: https://chromium-review.googlesource.com/c/1462378
   Auto-Submit: dstockwell <dstockwell@chromium.org>
   Commit-Queue: dsinclair <dsinclair@chromium.org>
   Reviewed-by: dsinclair <dsinclair@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#630752}

   Changed files

   • chrome/browser/resources/pdf/elements/viewer-pen-options/viewer-pen-options.html
   • chrome/browser/resources/pdf/elements/viewer-pen-options/viewer-pen-options.js

5. WebUI cleanup: Remove more obsolete dependencies to i18n_template.js.

   Changed by	dpapad - dpapadohnoyoudont@chromium.org
   Changed at	Monday, 11-Feb-19 14:45:16 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	d9c1fcfab6b497f67e3af7c939e6ea4559506648

   Comments

   WebUI cleanup: Remove more obsolete dependencies to i18n_template.js.
   
   Specifically removing from:
    - chrome://gcm-internals
    - chrome://network-errors/
    - chrome://signin-internals/
    - chrome://sync-internals
    - chrome://version
    - chrome://omaha
   
   With the exception of chrome://omaha all other pages had already been
   migrated away from i18n-values/i18n-content, but the dependency to
   i18n_template.js had not been removed.
   
   Bug: 677338
   Change-Id: If3214e4044615d7aeaf68fdf6001febc379487f3
   Reviewed-on: https://chromium-review.googlesource.com/c/1461716
   Commit-Queue: Jochen Eisinger <jochen@chromium.org>
   Reviewed-by: Jochen Eisinger <jochen@chromium.org>
   Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#630751}

   Changed files

   • components/gcm_driver/resources/gcm_internals.html
   • components/signin/core/browser/resources/signin_index.html
   • components/sync/driver/resources/index.html
   • components/version_ui/resources/about_version.html
   • content/browser/resources/net/network_errors_listing.html
   • ios/chrome/app/resources/omaha/omaha.html

6. skip login in replay mode only

   Changed by	Mikhail Khokhlov - khokhlovohnoyoudont@google.com
   Changed at	Monday, 11-Feb-19 14:44:12 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	6d045a6d593a30422702a9f9fdad3fcc86730436

   Comments

   skip login in replay mode only
   
   Bug: 882479,862077
   Change-Id: Icb78d14be9700126d105883a313506903e3c4250
   Reviewed-on: https://chromium-review.googlesource.com/c/1462817
   Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
   Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#630750}

   Changed files

   • tools/perf/page_sets/system_health/system_health_story.py

7. [Android] Fix Resources$NotFoundException from bg_white_dialog

   Changed by	Boris Sazonov - bsazonovohnoyoudont@chromium.org
   Changed at	Monday, 11-Feb-19 14:44:05 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	26a8dea796ab30dcea690b492be7ea5910c22fcc

   Comments

   [Android] Fix Resources$NotFoundException from bg_white_dialog
   
   This CL fixes an exception introduced by https://crrev.com/c/1437201
   that was happening on tablets while inflating bg_white_dialog.xml. This
   file had a nine-patch tag with android:src pointing to popup_bg_tinted,
   but popup_bg_tinted isn't a nine-patch image, thus the exception. This
   CL creates bg_white_dialog alias for popup_bg_tinted using drawables.xml
   in values folder.
   
   TBR=huayinz@chromium.org,twellington@chromium.org
   
   Bug: 925564, 930666
   Change-Id: I3e410fcd34e19036be28cc17c64b1be5dda05dc5
   Reviewed-on: https://chromium-review.googlesource.com/c/1462800
   Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
   Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#630749}

   Changed files

   • chrome/android/java/res/drawable-sw600dp/bg_white_dialog.xml
   • chrome/android/java/res/values-sw600dp/drawables.xml

8. Add download verification method to PluginVmImageManager

   Changed by	Olya Kalitova - okalitovaohnoyoudont@chromium.org
   Changed at	Monday, 11-Feb-19 14:41:59 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	c6afdbae157835a1ac880f554702ff3624baaf49

   Comments

   Add download verification method to PluginVmImageManager
   
   After download of PluginVm image has been finished successfully it
   should be verified using sha256 hash specified by PluginVmImage user policy.
   
   Bug: 928816
   Test: unit_tests --gtest_filter="PluginVmImageManagerTest.*"
   Change-Id: I1c53dfe0a5ce1f9c5f10a6b1f9b8f6dcecfbd4e1
   Reviewed-on: https://chromium-review.googlesource.com/c/1458440
   Reviewed-by: Igor <igorcov@chromium.org>
   Commit-Queue: Olya Kalitova <okalitova@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#630748}

   Changed files

   • chrome/browser/chromeos/plugin_vm/plugin_vm_image_manager.cc
   • chrome/browser/chromeos/plugin_vm/plugin_vm_image_manager.h
   • chrome/browser/chromeos/plugin_vm/plugin_vm_image_manager_unittest.cc

9. Update V8 to version 7.4.132.

   Changed by	v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
   Changed at	Monday, 11-Feb-19 14:15:51 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	3b5d3d654045dd61ee186d63149668cbdc798c5d

   Comments

   Update V8 to version 7.4.132.
   
   Summary of changes available at:
   https://chromium.googlesource.com/v8/v8/+log/ab0278e1..b2a0a5fc
   
   Please follow these instructions for assigning/CC'ing issues:
   https://github.com/v8/v8/wiki/Triaging%20issues
   
   Please close rolling in case of a roll revert:
   https://v8-roll.appspot.com/
   This only works with a Google account.
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
   
   TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
   
   Change-Id: I9419d33b2054203d035a7e70393b0546b5178e0a
   Reviewed-on: https://chromium-review.googlesource.com/c/1462996
   Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
   Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#630747}

   Changed files

   • DEPS

10. Replace use of GaiaCookieManagerService in ProfileManager

    Changed by	Henrique Ferreiro - hferreiroohnoyoudont@igalia.com
    Changed at	Monday, 11-Feb-19 14:11:01 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7f79293991341fa12a9661406b31e96b1610b437

    Comments

    Replace use of GaiaCookieManagerService in ProfileManager
    
    Port to the IdentityManager API.
    
    Bug: 926876
    Change-Id: I27dd75c47fe245bed85a89408a7b290c1a48b2db
    Reviewed-on: https://chromium-review.googlesource.com/c/1456084
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#630746}

    Changed files

    • chrome/browser/profiles/profile_manager.cc

11. Roll src/third_party/webrtc 1a1c52baf952..61b4f7489dbd (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 14:06:16 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	77cf24f65db0f79a49ec5d6113fd17578e11c895

    Comments

    Roll src/third_party/webrtc 1a1c52baf952..61b4f7489dbd (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/1a1c52baf952..61b4f7489dbd
    
    
    git log 1a1c52baf952..61b4f7489dbd --date=short --no-merges --format='%ad %ae %s'
    2019-02-11 mbonadei@webrtc.org Fix PeerConnectionInterface::StartRtcEventLog documentation.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@61b4f7489dbd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I976a68ebcd5c836e2f7950c7bb1127208fc2f433
    Reviewed-on: https://chromium-review.googlesource.com/c/1462677
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630745}

    Changed files

    • DEPS

12. [s13n] Implement IdentityManager::ForceTriggerOnCookieChange

    Changed by	Julie Jeongeun Kim - jkimohnoyoudont@igalia.com
    Changed at	Monday, 11-Feb-19 14:05:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	bfe13c0d076d9421dc5e05005fd126379f6afe29

    Comments

    [s13n] Implement IdentityManager::ForceTriggerOnCookieChange
    
    This CL implements IdentityManager::ForceTriggerOnCookieChange,
    which wraps GaiaCookieManagerService::ForceOnCookieChangeProcessing.
    
    It's only for replacement of production code for iOS.
    
    Bug: 926872
    Change-Id: Ic4e62c7ad27e41727f5a7e84c87d15fae4b215b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1457808
    Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630744}

    Changed files

    • services/identity/public/cpp/identity_manager.cc
    • services/identity/public/cpp/identity_manager.h
    • services/identity/public/cpp/identity_manager_unittest.cc

13. Picture-in-Picture: do not activate/focus window on show.

    Changed by	François Beaufort - beaufort.francoisohnoyoudont@gmail.com
    Changed at	Monday, 11-Feb-19 14:05:08 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8259d12b60480cb504fa7a5836c6a47fd8f47c3c

    Comments

    Picture-in-Picture: do not activate/focus window on show.
    
    This CL makes sure that Picture-in-Picture window does not steal focus
    when it is shown.
    
    Bug: 928697
    Change-Id: I9a9c3b95cf27f6fa951680bcf38becf21eaa9742
    Reviewed-on: https://chromium-review.googlesource.com/c/1459537
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#630743}

    Changed files

    • chrome/browser/ui/views/overlay/overlay_window_views.cc
    • chrome/browser/ui/views/overlay/overlay_window_views.h
    • content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
    • content/browser/web_contents/web_contents_impl_unittest.cc
    • content/public/browser/overlay_window.h
    • content/shell/browser/web_test/web_test_content_browser_client.cc

14. //pdf: Convert base::(U)Int(64)ToString(16) to NumberToString(16)

    Changed by	Raul Tambre - raulohnoyoudont@tambre.ee
    Changed at	Monday, 11-Feb-19 14:01:13 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ffb303af11b96bac6338e12017f139952e96bfd5

    Comments

    //pdf: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
    
    The former non-overloaded variants are deprecated.
    
    This is a mechanical change; there is no intended behavior change.
    
    Bug: 929827
    Change-Id: I09b032551c2d11590d787683effff151d1c833df
    Reviewed-on: https://chromium-review.googlesource.com/c/1461381
    Auto-Submit: Raul Tambre <raul@tambre.ee>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630742}

    Changed files

    • pdf/pdfium/pdfium_print.cc

15. [GCPW] Auto-generate new username when one is already used.

    Changed by	Tien Mai - tienmaiohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 13:59:41 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	b44b25dc8d98694dadc0d16db7efae76929106ad

    Comments

    [GCPW] Auto-generate new username when one is already used.
    
    - If the calculated username for specific gaia user already exists,
    then try a few times to find an alternative username that can be used to
    create a new user instead.
    - Also cleaned up the code that verifies if a authenticated gaia user can
    validly sign into the system to ensure that a user is already associated
    does not incorrectly sign in to another account not associated to the user.
    - Correctly delegate the setting of GLS CLI switches concerning specific
    gaia id and prefilled emails to the reauth credential which is the only
    one that will have this information.
    
    Bug: 930143
    Change-Id: I94e494ce1502e764c22d1f043cc8676fd5cd7309
    Reviewed-on: https://chromium-review.googlesource.com/c/1460608
    Commit-Queue: Tien Mai <tienmai@chromium.org>
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630741}

    Changed files

    • chrome/credential_provider/gaiacp/gaia_credential.cc
    • chrome/credential_provider/gaiacp/gaia_credential.h
    • chrome/credential_provider/gaiacp/gaia_credential_base.cc
    • chrome/credential_provider/gaiacp/gaia_credential_base.h
    • chrome/credential_provider/gaiacp/gaia_credential_base_unittests.cc
    • chrome/credential_provider/gaiacp/gaia_credential_unittests.cc
    • chrome/credential_provider/gaiacp/gcp_utils.h
    • chrome/credential_provider/gaiacp/reauth_credential.cc
    • chrome/credential_provider/gaiacp/reauth_credential.h
    • chrome/credential_provider/gaiacp/scoped_user_profile.cc
    • chrome/credential_provider/gaiacp/scoped_user_profile.h
    • chrome/credential_provider/test/com_fakes.h
    • chrome/credential_provider/test/gcp_fakes.cc
    • chrome/credential_provider/test/gcp_fakes.h
    • chrome/credential_provider/test/gcp_setup_unittests.cc
    • chrome/credential_provider/test/gls_runner_test_base.h
    • chrome/credential_provider/test/test_credential.h

16. Roll src-internal 171caf9508b1..45088b3b3faa (2 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 13:57:37 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d12bba09b34257ba54f61340f0b96f735b1390db

    Comments

    Roll src-internal 171caf9508b1..45088b3b3faa (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/171caf9508b1..45088b3b3faa
    
    
    Created with:
      gclient setdep -r src-internal@45088b3b3faa
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I12663a702c9cfab944072f777341a543ee7fa32a
    Reviewed-on: https://chromium-review.googlesource.com/c/1462780
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630740}

    Changed files

    • DEPS

17. [Sheriff] Disable flaky GetDisplayMediaVideoAndAudio

    Changed by	jdoerrie - jdoerrieohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 13:55:08 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	40c7483c02dd67efe2c7b78aac15b1d220d55a8e

    Comments

    [Sheriff] Disable flaky GetDisplayMediaVideoAndAudio
    
    TBR=hbos@chromium.org
    
    Bug: 930471
    Change-Id: Ib5162a48f4b6d68c42d8e52ec56f5f0d5b01119f
    Reviewed-on: https://chromium-review.googlesource.com/c/1462819
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630739}

    Changed files

    • chrome/browser/media/webrtc/webrtc_getdisplaymedia_browsertest.cc

18. Import wpt@ee563ea4a1f935bd1cac734dbe786f53c38dbeae

    Changed by	Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 13:46:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	35663ddf499743c70a2ce61c59e74361ff76eebf

    Comments

    Import wpt@ee563ea4a1f935bd1cac734dbe786f53c38dbeae
    
    Using wpt-import in Chromium 16f523ba6e0f17d165d5e1a10557659bcc5d31c8.
    With Chromium commits locally applied on WPT:
    14c111075b "Implement `Sec-CH-Lang`"
    c49d046dfa "Initial support for WorkletAnimation.playbackRate"
    70938d55b3 "Fix remaining preload tests flaking on wpt.fyi"
    af3b056c72 "[WPT] [wasm] Add JS-API tests for wasm threads"
    b81a614806 "[Animation Worklet] Upstream web tests (related to setting values) to WPT"
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    jfernandez@igalia.com:
      external/wpt/css/css-align
    
    NOAUTOREVERT=true
    TBR=kyleju
    
    No-Export: true
    Change-Id: I627c598f087a7888dca2b0db8334c172f87c255f
    Reviewed-on: https://chromium-review.googlesource.com/c/1462661
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630738}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/css/css-align/baseline-of-scrollable-2.html
    • third_party/blink/web_tests/external/wpt/css/css-align/reference/baseline-of-scrollable-2-ref.html

19. Roll src/third_party/swiftshader 9686153413f3..9388dded242f (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 13:44:50 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	43dfb8196bc748c49578f6f5aa60078178bcca3b

    Comments

    Roll src/third_party/swiftshader 9686153413f3..9388dded242f (1 commits)
    
    https://swiftshader.googlesource.com/SwiftShader.git/+log/9686153413f3..9388dded242f
    
    
    git log 9686153413f3..9388dded242f --date=short --no-merges --format='%ad %ae %s'
    2019-02-11 bclayton@google.com vscode: Rewrite tasks.json
    
    
    Created with:
      gclient setdep -r src/third_party/swiftshader@9388dded242f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=swiftshader-team+autoroll@chromium.org
    
    Change-Id: I2896805c871bce820281d1113ce643abcdd3c017
    Reviewed-on: https://chromium-review.googlesource.com/c/1462781
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630737}

    Changed files

    • DEPS

20. Roll AFDO from 74.0.3701.0_rc-r1 to 74.0.3702.0_rc-r1

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 13:35:21 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	97f9c37bfae395063785b3f7db27b6db3380ecbd

    Comments

    Roll AFDO from 74.0.3701.0_rc-r1 to 74.0.3702.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    Please note that, despite rolling to chrome/android, this profile is
    used for both Linux and Android.
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I2c147aa738be135888d17f9c2a6ec253e990f1f6
    Reviewed-on: https://chromium-review.googlesource.com/c/1463067
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630736}

    Changed files

    • chrome/android/profiles/newest.txt

21. [css-grid] Overflow should be computed with the actual logical bottom

    Changed by	Javier Fernandez - jfernandezohnoyoudont@igalia.com
    Changed at	Monday, 11-Feb-19 13:34:20 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d0a1b3f7a4556fea5df9014aba4e23d968ea0677

    Comments

    [css-grid] Overflow should be computed with the actual logical bottom
    
    In order to compute the 'auto' height of the grid container, we set
    temporarily a value based on the tracks' size. We can see this value as
    a kind of 'intrinsic height'. Then, we call to the UpdateLogicalHeight
    function to finally compute the grid container's actual logical height.
    
    In order to compute the overflow area in the grid container we should
    use the result of the ClientLogicalBottom function. However, we were
    retrieving this value just after setting the tracks-based temporary
    height, and before computing the actual logical height.
    
    The consequence of this wrong logic is that empty grid areas may
    affect the result of the ClientLogicalBottom and, as it's described
    in the bug, conclude that there is a content overflow in the grid
    container, even if such container has no grid items at all.
    
    Since the grid itself is not a box, it can't contribute to the grid
    container's content size; instead, its grid items should.
    
    This change ensures that we always use the actual grid container's
    logical bottom to properly compute the overflow area.
    
    Bug: 928885
    Change-Id: I05f86fbce06a83c0dbc0d5389bf0416763f8588a
    Reviewed-on: https://chromium-review.googlesource.com/c/1459620
    Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
    Reviewed-by: Manuel Rego <rego@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#630735}

    Changed files

    • third_party/blink/renderer/core/layout/layout_grid.cc
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-areas-overflowing-grid-container-001.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-areas-overflowing-grid-container-002.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-areas-overflowing-grid-container-003.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-areas-overflowing-grid-container-004.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-areas-overflowing-grid-container-005.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-areas-overflowing-grid-container-006.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-areas-overflowing-grid-container-007.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/grid-areas-overflowing-grid-container-008.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/reference/100x100-grey-box-with-horizontal-scrollbar.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/reference/100x100-grey-box-with-scrollbars.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/reference/100x100-grey-box-with-vertical-scrollbar.html
    • third_party/blink/web_tests/external/wpt/css/css-grid/grid-model/reference/100x100-grey-box.html

22. [Sheriff] Disable SiteSettingsHandlerTest.GetAllSites on CrOS and Linux

    Changed by	jdoerrie - jdoerrieohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 13:34:14 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	414fa14851a0e9fef988a9a96c2cb69ba6f1c330

    Comments

    [Sheriff] Disable SiteSettingsHandlerTest.GetAllSites on CrOS and Linux
    
    TBR=stevenjb@chromium.org
    
    Bug: 930481
    Change-Id: Ie62b939716d44c404c6930c54bfe7ed92ac2c4c6
    Reviewed-on: https://chromium-review.googlesource.com/c/1462937
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630734}

    Changed files

    • chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc

23. [Security Events] Add SECURITY_EVENTS datatype without enabling it yet.

    Changed by	Markus Heintz - markusheintzohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 13:28:24 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	39472bccbc1b5380c7e1fa569b5b81e7aac02d81

    Comments

    [Security Events] Add SECURITY_EVENTS datatype without enabling it yet.
    
    Bug: 919489
    Change-Id: I1e60791c3068a9d48e11b32f379d569fac72b83f
    Reviewed-on: https://chromium-review.googlesource.com/c/1455965
    Commit-Queue: Markus Heintz <markusheintz@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: ssid <ssid@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630733}

    Changed files

    • base/trace_event/memory_infra_background_whitelist.cc
    • chrome/browser/sync/chrome_sync_client.cc
    • chrome/browser/sync/profile_sync_service_factory_unittest.cc
    • components/browser_sync/profile_sync_components_factory_impl.cc
    • components/sync/base/data_type_histogram.h
    • components/sync/base/model_type.h
    • components/sync/base/sync_prefs.cc
    • components/sync/driver/model_association_manager.cc
    • components/sync/protocol/proto_value_conversions_unittest.cc
    • components/sync/protocol/proto_visitors.h
    • components/sync/syncable/model_type.cc
    • components/sync/syncable/nigori_util.cc
    • ios/chrome/browser/sync/profile_sync_service_factory_unittest.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml

24. [ozone] Implement Clipboard for Ozone platforms.

    Changed by	Maksim Sisov - msisovohnoyoudont@igalia.com
    Changed at	Monday, 11-Feb-19 13:25:10 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7f3199285c4c4d6b9443cdd2afd5c889d5677742

    Comments

    [ozone] Implement Clipboard for Ozone platforms.
    
    This patch provides a general clipboard implementation for Ozone.
    
    The initialization happens automatically:
    Clipboard::Create->ClipboardOzone::ClipboardOzone()->
    AsyncClipboardOzone::AsyncClipboardOzone()->ClipboardDelegate::GetInstance().
    
    where ClipboardOzone is a derived class from base::Clipboard,
    AsyncClipboardOzone is a private helper class of ClipboardOzone, which
    gets calls from it, makes requests and sends them to ClipboardDelegate.
    
    TL;DR:
    The ClipboardDelegate::GetInstance stores a singleton delegate instance,
    which is stored automatically once clipboard delegate is created.
    Each ozone platform, which uses clipboard, is responsible to create
    own instance of ClipboardDelegate, which communicates with a system
    clipboard. If a platform does not have own, the ClipboardDelegate::GetInstance
    creates a FakeClipboardDelegate, which emulates the system clipboard in
    such a way that it can pass unittests and provide copy/paste
    functionality within browser.
    
    The flow is asynchronous and based on requests.That is,
    whenever a ClipboardOzone receives a Read/Write/GetMime
    call, it forwards it to the helper AsyncClipboardOzone class, which
    then creates a request (used for internal usage and holding
    data filled by the ClipboardDelegate), calls to the delegate
    and start an abort timer to make sure the request is not stalled.
    
    What is more the clipboard data is cached and removed only when another
    chunk of data is written to a system clipboard. And whenever the chromium browser is the
    selection owner, the cached data is used.
    
    components_unittests --gtest_filter=BookmarkUtilsTest*
    
    Bug: 875168
    Test: interactive_ui_tests --gtest_filter=ClipboardTest*
    Change-Id: I0101aebe47cf2cac666f0434b6be2a9a11e2418c
    Reviewed-on: https://chromium-review.googlesource.com/c/1361872
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630732}

    Changed files

    • chrome/test/base/interactive_ui_tests_main.cc
    • ui/base/clipboard/BUILD.gn
    • ui/base/clipboard/DEPS
    • ui/base/clipboard/clipboard_ozone.cc
    • ui/base/clipboard/clipboard_ozone.h
    • ui/base/clipboard/clipboard_test_template.h
    • ui/ozone/platform/wayland/wayland_connection.cc
    • ui/ozone/platform/wayland/wayland_connection.h
    • ui/ozone/platform/wayland/wayland_data_device.cc
    • ui/ozone/public/platform_clipboard.h

25. Move aggregation documentation from internal.

    Changed by	Brian White - bcwhiteohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 13:13:22 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	0831d2ad101eff617912d7769115b9e3c6321950

    Comments

    Move aggregation documentation from internal.
    
    This is a direct copy from the internal page with some small
    wording changes in the first paragraph to match this document.
    The internal version will be removed and instead point here.
    https://g3doc.corp.google.com/analysis/uma/g3doc/ukm/aggregated-ukm.md#adding-new-metrics-to-history-table
    
    Change-Id: I48f9d8ffcecbe8f4bb34987a33c95600a73af875
    Reviewed-on: https://chromium-review.googlesource.com/c/1460606
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Brian White <bcwhite@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630731}

    Changed files

    • services/metrics/ukm_api.md

26. Conditionally Disable HostResolverImplTest.DeleteWithinAbortedCallback_ResolveHost

    Changed by	jdoerrie - jdoerrieohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 13:06:57 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	dfede5adf8d291c82463bff849ea27530fe28503

    Comments

    Conditionally Disable HostResolverImplTest.DeleteWithinAbortedCallback_ResolveHost
    
    TBR=ericorth@chromium.org
    
    Bug: 930483
    Change-Id: I3d34d27e5e866704778b85e7dc7a83cec7b2110a
    Reviewed-on: https://chromium-review.googlesource.com/c/1462798
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630730}

    Changed files

    • net/dns/host_resolver_impl_unittest.cc

27. [Sheriff] Disable SingleClientPreferencesSyncTest.ShouldRemoveBadDataWhenRegistering on Windows

    Changed by	jdoerrie - jdoerrieohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 13:03:08 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f86c4c9a8a99305a9aa805b9dca4f8ae3a534792

    Comments

    [Sheriff] Disable SingleClientPreferencesSyncTest.ShouldRemoveBadDataWhenRegistering on Windows
    
    TBR=jkrcal@chromium.org
    
    Bug: 930482
    Change-Id: Ifbb07226d94f8b42cbdf7487d20bd8d72811d96b
    Reviewed-on: https://chromium-review.googlesource.com/c/1462897
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630729}

    Changed files

    • chrome/browser/sync/test/integration/single_client_preferences_sync_test.cc

28. Remove duplicate error checking in FakeOAuth2TokenServiceDelegate

    Changed by	Sergio Villar Senin - svillarohnoyoudont@igalia.com
    Changed at	Monday, 11-Feb-19 12:52:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ba7c6f0fc544a722a67787bb3241232e97acaf0a

    Comments

    Remove duplicate error checking in FakeOAuth2TokenServiceDelegate
    
    The error.IsTransientError() check appeared in two consecutive
    exclusive if statements. It was by mistake in crrev.com/c/1070154.
    
    Change-Id: I7a49d29f57491ccf2bfbbfa6731490c23fdffd35
    Reviewed-on: https://chromium-review.googlesource.com/c/1461032
    Commit-Queue: Sergio Villar <svillar@igalia.com>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630728}

    Changed files

    • google_apis/gaia/fake_oauth2_token_service_delegate.cc

29. Update V8 to version 7.4.131.

    Changed by	v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 12:09:25 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	591fcab0f6062580d2ef126040245168b8d381f0

    Comments

    Update V8 to version 7.4.131.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/81215ad1..ab0278e1
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I36ae09fb3680e9eba8bc36b67c1d4b101cd2f30f
    Reviewed-on: https://chromium-review.googlesource.com/c/1462660
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630727}

    Changed files

    • DEPS

30. //components/spellcheck: Fix 64-bit truncation issues

    Changed by	Raul Tambre - raulohnoyoudont@tambre.ee
    Changed at	Monday, 11-Feb-19 12:07:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	80937cd48917fc3f4ba9297c492aba0af951bd76

    Comments

    //components/spellcheck: Fix 64-bit truncation issues
    
    Bug: 633312, 879657
    Change-Id: I25aa719c1632b7cf6b8191ce1523a6f230b98142
    Reviewed-on: https://chromium-review.googlesource.com/c/1450592
    Reviewed-by: Mike West <mkwst@chromium.org>
    Reviewed-by: Tim Volodine <timvolodine@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Auto-Submit: Raul Tambre <raul@tambre.ee>
    Cr-Commit-Position: refs/heads/master@{#630726}

    Changed files

    • components/spellcheck/browser/spellcheck_host_metrics.cc
    • components/spellcheck/browser/spellcheck_host_metrics.h
    • components/spellcheck/renderer/BUILD.gn
    • components/spellcheck/renderer/custom_dictionary_engine.cc
    • components/spellcheck/renderer/custom_dictionary_engine.h
    • components/spellcheck/renderer/spellcheck.cc
    • components/spellcheck/renderer/spellcheck.h
    • components/spellcheck/renderer/spellcheck_language.cc
    • components/spellcheck/renderer/spellcheck_language.h
    • components/spellcheck/renderer/spellcheck_multilingual_unittest.cc
    • components/spellcheck/renderer/spellcheck_provider.cc
    • components/spellcheck/renderer/spellcheck_provider.h
    • components/spellcheck/renderer/spellcheck_unittest.cc
    • components/spellcheck/renderer/spellcheck_worditerator.cc
    • components/spellcheck/renderer/spellcheck_worditerator.h
    • components/spellcheck/renderer/spellcheck_worditerator_unittest.cc
    • content/shell/test_runner/mock_spell_check.cc
    • content/shell/test_runner/mock_spell_check.h
    • content/shell/test_runner/spell_check_client.cc
    • content/shell/test_runner/spell_check_client.h
    • third_party/blink/public/web/web_text_check_client.h
    • third_party/blink/renderer/core/editing/spellcheck/spell_checker.cc
    • third_party/blink/renderer/core/page/context_menu_controller.cc

31. Roll src-internal 54496f14f521..171caf9508b1 (1 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 12:06:30 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	60471ea0525e19a674499d33d36b93ab2e7b8f78

    Comments

    Roll src-internal 54496f14f521..171caf9508b1 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/54496f14f521..171caf9508b1
    
    
    Created with:
      gclient setdep -r src-internal@171caf9508b1
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: If4e2981529071cb91dad89e7ecee69a3c7780dc5
    Reviewed-on: https://chromium-review.googlesource.com/c/1462779
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630725}

    Changed files

    • DEPS

32. Roll src/third_party/skia 9a2169e84f25..d336ebdea812 (3 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 12:05:52 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c6ca11b8a4d2bf7d1f485faed96e224ee5b95a3e

    Comments

    Roll src/third_party/skia 9a2169e84f25..d336ebdea812 (3 commits)
    
    https://skia.googlesource.com/skia.git/+log/9a2169e84f25..d336ebdea812
    
    
    git log 9a2169e84f25..d336ebdea812 --date=short --no-merges --format='%ad %ae %s'
    2019-02-11 gkaiser@google.com SkDeque: Move asserts prior to pointer dereference
    2019-02-11 gkaiser@google.com GrGLGpu: Remove unused 'return'
    2019-02-11 gkaiser@google.com SkPath: Cleanup code to make array size match
    
    
    Created with:
      gclient setdep -r src/third_party/skia@d336ebdea812
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=stephana@chromium.org
    
    Change-Id: Iaedc49f42eb9b26284be2066d487315440742b2a
    Reviewed-on: https://chromium-review.googlesource.com/c/1462778
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630724}

    Changed files

    • DEPS

33. Introduce dark color scheme with UA style.

    Changed by	Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 11:56:55 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1ede39b6f4d6d226139d59d0505d58e48a021ec1

    Comments

    Introduce dark color scheme with UA style.
    
    This is the start of introducing an opt-in dark color scheme where the
    plan is to let the author opt into dark color scheme and out of forced
    dark mode using a supported-color-schemes meta element.
    
    This CL introduces:
    
    * An enumerated set of color schemes, currently light and dark.
    * A document level color scheme, which will typically be set by
      combining the supported color schemes given by the meta tag with the
      UA/OS level setting for forced dark mode.
    * Color scheme awareness for LayoutTheme. Currently only for the root
      element text color, but will be extended for other theme parts.
    * An -internal-root-color to be used in html.css for setting the root
      element color according to the current color scheme.
    * Changing the base background color of the view from white to black for
      the dark scheme.
    
    Bug: 929098
    Change-Id: I876aa0b31ebdb50488a824ba7f7aab4e2ba752cc
    Reviewed-on: https://chromium-review.googlesource.com/c/1456065
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630723}

    Changed files

    • third_party/blink/renderer/core/css/css_gradient_value.cc
    • third_party/blink/renderer/core/css/css_value_keywords.json5
    • third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
    • third_party/blink/renderer/core/css/style_color.cc
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/dom/text_link_colors.cc
    • third_party/blink/renderer/core/dom/text_link_colors.h
    • third_party/blink/renderer/core/html/resources/html.css
    • third_party/blink/renderer/core/layout/layout_theme.cc
    • third_party/blink/renderer/core/layout/layout_theme.h
    • third_party/blink/renderer/core/layout/layout_theme_test.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/color_scheme.h
    • third_party/blink/web_tests/http/tests/devtools/elements/css-variables/resolve-inherited-css-variables-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/elements-delete-inline-style-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/elements-panel-styles-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/add-new-rule-invalid-selector-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/add-new-rule-keyboard-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/add-new-rule-with-style-after-body-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/commit-selector-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/commit-selector-mark-matching-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/css-live-edit-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/cssom-media-insert-crash-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/disable-property-workingcopy-update-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/dynamic-style-tag-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/edit-inspector-stylesheet-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/edit-media-text-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/empty-background-url-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-1/filter-matched-styles-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/add-import-rule-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/cssom-shorthand-important-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/filter-matched-styles-hides-separators-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/force-pseudo-state-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/inactive-properties-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/inherited-mixed-case-properties-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/inject-stylesheet-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/keyframes-rules-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/lazy-computed-style-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/media-emulation-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/media-queries-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/media-using-same-url-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/parse-comments-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/parse-declaration-unterminated-comment-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/parse-declaration-with-quote-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/parse-utf8-bom-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/paste-property-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/perform-undo-perform-of-mergable-action-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/pseudo-elements-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-2/region-style-crash-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/selector-list-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/shadow-dom-rules-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/style-rule-from-imported-stylesheet-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-add-blank-property-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-add-invalid-property-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-add-new-rule-colon-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-add-new-rule-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-add-new-rule-tab-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-add-new-rule-to-stylesheet-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-cancel-editing-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-commit-editing-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-computed-trace-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-cssom-important-property-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-disable-inherited-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-disable-property-after-selector-edit-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-disable-then-enable-overriden-ua-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-3/styles-variables-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/inline-style-sourcemap-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-do-not-detach-sourcemap-on-edits-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-edit-property-after-invalid-rule-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-iframe-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-inherited-same-source-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-keyframes-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-keyframes.js
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-new-API-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-overloaded-shorthand-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-overriden-properties-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-properties-overload-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-source-lines-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-source-lines-inline-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-source-lines-recovery-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-update-from-js-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-update-links-1-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-update-links-2-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-update-links-3-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-update-links-4-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/styles-with-spaces-in-sourceURL-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/svg-style-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/undo-add-new-rule-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles-4/undo-add-property-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/cancel-upon-invalid-property-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/edit-css-with-source-url-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/selector-line-deprecated-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/selector-line-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-deprecated-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/selector-line-sourcemap-header-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/show-all-properties-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/styles-parse-invalid-properties-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/undo-after-cancelled-editing-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/undo-change-property-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/elements/styles/undo-set-selector-text-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/startup/shadow-dom-rules-expected.txt

34. //ios: Convert base::(U)Int(64)ToString(16) to NumberToString(16)

    Changed by	Raul Tambre - raulohnoyoudont@tambre.ee
    Changed at	Monday, 11-Feb-19 11:45:26 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7bad6d65743b30240011691efa45e6aa5d455178

    Comments

    //ios: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
    
    The former non-overloaded variants are deprecated.
    
    This is a mechanical change; there is no intended behavior change.
    
    Bug: 929827
    Change-Id: I1df4a9aee87ddc94dcfed52ae6bc8b595eff8dc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1461038
    Auto-Submit: Raul Tambre <raul@tambre.ee>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630722}

    Changed files

    • ios/chrome/browser/autofill/form_suggestion_label.mm
    • ios/chrome/browser/notification_promo.cc
    • ios/chrome/browser/notification_promo_unittest.cc
    • ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm
    • ios/chrome/browser/ui/webui/about_ui.cc
    • ios/chrome/browser/ui/webui/version_ui.mm
    • ios/web/navigation/history_state_operations_inttest.mm
    • ios/web/shell/test/page_state_egtest.mm
    • ios/web/webui/mojo_facade.mm

35. Trivial: remove unused includes

    Changed by	Mikel Astiz - mastizohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 11:45:04 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	06acaf726fd02043441189f36708b5237258b903

    Comments

    Trivial: remove unused includes
    
    These are leftovers from previous patches.
    
    Bug: 922971
    Change-Id: Ic4cab0235c9b139c5d56221178d36f75b1e38c88
    Reviewed-on: https://chromium-review.googlesource.com/c/1462896
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Auto-Submit: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630721}

    Changed files

    • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm

36. [Sheriff] Disable Failing RTCIceTransport-extension.https.html Test on Linux

    Changed by	jdoerrie - jdoerrieohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 11:38:53 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	74b797d29cfd3c4e9a4acce82750c93148577d21

    Comments

    [Sheriff] Disable Failing RTCIceTransport-extension.https.html Test on Linux
    
    TBR=foolip
    
    Bug: 930654
    Change-Id: I6e8cc1b1ce378b00b4803efd7ceb10390519becb
    Reviewed-on: https://chromium-review.googlesource.com/c/1462856
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630720}

    Changed files

    • third_party/blink/web_tests/TestExpectations

37. blink/dom: Make CharacterData use ParkableStrings for large strings.

    Changed by	Benoît Lizé - lizebohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 11:38:44 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2069f0a0d4445b89dae4a0c13b56ebafd7817ceb

    Comments

    blink/dom: Make CharacterData use ParkableStrings for large strings.
    
    Some DOM nodes are large (for instance, inline scripts), and their data is kept
    in memory at all time. In the case of inline scripts, the data is owned by both
    the DOM node and the script object. This prevents any inline script source code
    from getting compressed.
    
    Add a way to store such nodes as ParkableStrings. On facebook.com/obama, this
    allows to compress ~1.9MB more data, and yields sizable memory savings (~1.5MB,
    see linked bug).
    
    The cost is to add a bool and a ParkableString member to each CharacterData
    node, that is ~2 * sizeof(void*). There is no runtime cost (aside from a single
    branch) if compression is not enabled, of if the data is small.
    
    Bug: 929110
    Change-Id: Icd70b108f5ebbd714f373ba362cb708cbb9aa52a
    Reviewed-on: https://chromium-review.googlesource.com/c/1459548
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630719}

    Changed files

    • third_party/blink/renderer/core/dom/character_data.cc
    • third_party/blink/renderer/core/dom/character_data.h
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
    • third_party/blink/renderer/platform/bindings/parkable_string_manager.cc

38. Add field trial testing config for the GooglePasswordManager UI on Android

    Changed by	Ioana Pandele - ioanapohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 11:12:29 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	16f523ba6e0f17d165d5e1a10557659bcc5d31c8

    Comments

    Add field trial testing config for the GooglePasswordManager UI on Android
    
    Change-Id: I14052aebbf13f4f363b49ea1f6ebb74a780a2c65
    Reviewed-on: https://chromium-review.googlesource.com/c/1456074
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630718}

    Changed files

    • testing/variations/fieldtrial_testing_config.json

39. s13n: Convert IdentityManager::Observer::OnErrorStateOfRefreshTokenUpdatedForAccount to use CoreAccountInfo

    Changed by	Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com
    Changed at	Monday, 11-Feb-19 11:11:19 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9bd706d4ffbcfe39ffd489fd5587cfe9f85946b9

    Comments

    s13n: Convert IdentityManager::Observer::OnErrorStateOfRefreshTokenUpdatedForAccount to use CoreAccountInfo
    
    CoreAccountInfo is enough to OnErrorStateOfRefreshTokenUpdatedForAccount. This CL converts
    AccountInfo to CoreAccountInfo in OnErrorStateOfRefreshTokenUpdatedForAccount.
    
    Bug: 930119
    Change-Id: Idd04ef95b5f4193dd79f2192df499daca10d0af8
    Reviewed-on: https://chromium-review.googlesource.com/c/1460746
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#630717}

    Changed files

    • components/signin/core/browser/account_reconcilor.cc
    • components/signin/core/browser/account_reconcilor.h
    • components/signin/core/browser/signin_error_controller.cc
    • components/signin/core/browser/signin_error_controller.h
    • components/sync/driver/sync_session_durations_metrics_recorder.cc
    • components/sync/driver/sync_session_durations_metrics_recorder.h
    • services/identity/public/cpp/identity_manager.cc
    • services/identity/public/cpp/identity_manager.h
    • services/identity/public/cpp/identity_manager_unittest.cc

40. [Autofill Assistant] Added DVLOGs to web_controller.

    Changed by	Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at	Monday, 11-Feb-19 11:06:57 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1e9060c28ad41af118acbb93c15a442a96fa7de0

    Comments

    [Autofill Assistant] Added DVLOGs to web_controller.
    
    To provide human-readable status messages, several enums now support the output operator <<. String representations of enums are only compiled into debug builds. The same is true for logging string representations of selectors, because they might contain sensitive data.
    
    Bug: 806868
    Change-Id: I09de68f93a612cd4060761e8171b0bcd959df942
    Reviewed-on: https://chromium-review.googlesource.com/c/1455901
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630716}

    Changed files

    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/metrics.h
    • components/autofill_assistant/browser/selector.cc
    • components/autofill_assistant/browser/selector.h
    • components/autofill_assistant/browser/state.h
    • components/autofill_assistant/browser/web_controller.cc

41. [tools/perf] Remove unused bootstrap.DownloadDeps

    Changed by	Juan Antonio Navarro Perez - perezjuohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 11:04:37 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e2d80b3814f632fcd08b44ad3a8e892eac6b6e2f

    Comments

    [tools/perf] Remove unused bootstrap.DownloadDeps
    
    These are from an old code path to get dependencies out of a WebDAV/SVN
    server, no longer in use.
    
    Keeps bootstrap.ListAllDepsPaths currently still in use by
    tools/perf/find_dependencies script
    
    Bug: 651219
    Change-Id: I262c2371aeb5871c5b9cdf7ebac29b73e04100cc
    Reviewed-on: https://chromium-review.googlesource.com/c/1452180
    Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
    Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630715}

    Changed files

    • tools/perf/core/bootstrap.py

42. PersonalDataManager: Small cleanups

    Changed by	Marc Treib - treibohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 10:48:44 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3e477150463b2c40a4028b315da058b92bf25f7a

    Comments

    PersonalDataManager: Small cleanups
    
    - Make OnAutofillProfileChanged private.
    - Avoid some unnecessary copying.
    - Remove an unnecessary "mutable".
    - Remove unused |profiles_| member.
    
    Bug: none
    Change-Id: I4a65fc35b18dc962dc18bb77d09412a94e13bbbf
    Reviewed-on: https://chromium-review.googlesource.com/c/1458116
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630714}

    Changed files

    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h

43. Sync history deletions from chrome.history api

    Changed by	Christian Dullweber - dullweberohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 10:47:44 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c2cbfdecd80bd460112b147a9d5c61e191263e01

    Comments

    Sync history deletions from chrome.history api
    
    History deletions from extensions are currently not propagated to
    synced history. This change will allow calls to history.deleteUrl(),
    history.deleteRange() and history.deleteAll() to remove urls from
    other devices and myactivity.
    There is currently no DeleteDirective to remove individual urls, so a
    new one is added. Old clients will just ignore the new directive.
    
    Bug: 395955
    Change-Id: I0ad0e7f84a7a5e2028634ff60546887ce265ccf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1439303
    Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Christian Dullweber <dullweber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630713}

    Changed files

    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
    • chrome/browser/extensions/api/history/history_api.cc
    • chrome/browser/sync/test/integration/single_client_history_delete_directives_sync_test.cc
    • components/history/core/browser/expire_history_backend.cc
    • components/history/core/browser/expire_history_backend.h
    • components/history/core/browser/expire_history_backend_unittest.cc
    • components/history/core/browser/history_backend.cc
    • components/history/core/browser/history_backend.h
    • components/history/core/browser/history_backend_unittest.cc
    • components/history/core/browser/history_service.cc
    • components/history/core/browser/history_service.h
    • components/history/core/browser/history_service_unittest.cc
    • components/history/core/browser/sync/delete_directive_handler.cc
    • components/history/core/browser/sync/delete_directive_handler.h
    • ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm
    • tools/traffic_annotation/summary/annotations.xml

44. Roll src/third_party/skia 136cd7018a99..9a2169e84f25 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 10:46:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e18ff52998d10ac9448052688f4f3dc6edd2e86f

    Comments

    Roll src/third_party/skia 136cd7018a99..9a2169e84f25 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/136cd7018a99..9a2169e84f25
    
    
    git log 136cd7018a99..9a2169e84f25 --date=short --no-merges --format='%ad %ae %s'
    2019-02-11 gkaiser@google.com SkImage_GpuYUVA: Also sanity check height
    
    
    Created with:
      gclient setdep -r src/third_party/skia@9a2169e84f25
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=stephana@chromium.org
    
    Change-Id: I19d821a7d452edcbb8a0d234be1c8426156f3be4
    Reviewed-on: https://chromium-review.googlesource.com/c/1462777
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630712}

    Changed files

    • DEPS

45. Roll src-internal 3c7ef7a3b16e..54496f14f521 (1 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Monday, 11-Feb-19 10:36:51 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ed40c8c2c9e09e3f89da7bbee7d7c362a6155c7b

    Comments

    Roll src-internal 3c7ef7a3b16e..54496f14f521 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c7ef7a3b16e..54496f14f521
    
    
    Created with:
      gclient setdep -r src-internal@54496f14f521
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I6ec5adb81dc47da38f3f6124ca07ccee74a81361
    Reviewed-on: https://chromium-review.googlesource.com/c/1462776
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#630711}

    Changed files

    • DEPS

46. Move datatype dependencies away from SyncClient

    Changed by	Mikel Astiz - mastizohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 10:25:17 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	83b9663e3814ef7e53af5009d10033b89955db44

    Comments

    Move datatype dependencies away from SyncClient
    
    We do this by introducing another layer, BrowserSyncClient, to minimize
    the code changes.
    
    Even in this humble form, the change substantially improves layering and
    already fixes some important issues like forward declarations being used
    to avoid build dependencies that would otherwise cause dependency cycles.
    
    The downside is that some extra boilerplate code is required to avoid
    dependencies selectively, as opposed to SyncClient being used as a big
    convenience bundle. This is arguably an improvement, though.
    
    In future patches, we should probably get rid of this new class
    altogether, but that requires more intrusive changes.
    
    Bug: 915154
    Change-Id: Iaad6d54272bb1ccc00759ad039b313896acd4e34
    Reviewed-on: https://chromium-review.googlesource.com/c/1458196
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630710}

    Changed files

    • chrome/browser/supervised_user/supervised_user_sync_model_type_controller.cc
    • chrome/browser/supervised_user/supervised_user_sync_model_type_controller.h
    • chrome/browser/sync/chrome_sync_client.cc
    • chrome/browser/sync/chrome_sync_client.h
    • chrome/browser/sync/profile_sync_service_factory.cc
    • chrome/browser/sync/profile_sync_test_util.cc
    • chrome/browser/sync/profile_sync_test_util.h
    • chrome/browser/sync/test/integration/bookmarks_helper.cc
    • chrome/browser/sync/test/integration/single_client_directory_sync_test.cc
    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • components/autofill/core/browser/autofill_wallet_data_type_controller.cc
    • components/autofill/core/browser/autofill_wallet_data_type_controller.h
    • components/autofill/core/browser/autofill_wallet_data_type_controller_unittest.cc
    • components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc
    • components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
    • components/browser_sync/BUILD.gn
    • components/browser_sync/abstract_profile_sync_service_test.cc
    • components/browser_sync/browser_sync_client.cc
    • components/browser_sync/browser_sync_client.h
    • components/browser_sync/profile_sync_components_factory_impl.cc
    • components/browser_sync/profile_sync_components_factory_impl.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_service_bookmark_unittest.cc
    • components/browser_sync/profile_sync_service_startup_unittest.cc
    • components/browser_sync/profile_sync_service_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
    • components/history/core/browser/sync/history_delete_directives_model_type_controller.cc
    • components/history/core/browser/sync/history_delete_directives_model_type_controller.h
    • components/password_manager/core/browser/sync/password_model_type_controller.cc
    • components/password_manager/core/browser/sync/password_model_type_controller.h
    • components/password_manager/core/browser/sync/password_syncable_service_based_model_type_controller.cc
    • components/password_manager/core/browser/sync/password_syncable_service_based_model_type_controller.h
    • components/search_engines/search_engine_data_type_controller_unittest.cc
    • components/sync/BUILD.gn
    • components/sync/driver/async_directory_type_controller_unittest.cc
    • components/sync/driver/fake_sync_client.cc
    • components/sync/driver/fake_sync_client.h
    • components/sync/driver/shared_change_processor.cc
    • components/sync/driver/shared_change_processor_unittest.cc
    • components/sync/driver/sync_api_component_factory.h
    • components/sync/driver/sync_api_component_factory_mock.h
    • components/sync/driver/sync_client.h
    • components/sync/driver/sync_client_mock.h
    • components/sync/engine_impl/model_type_registry.cc
    • components/sync_bookmarks/bookmark_change_processor.cc
    • components/sync_bookmarks/bookmark_change_processor.h
    • components/sync_bookmarks/bookmark_data_type_controller.cc
    • components/sync_bookmarks/bookmark_data_type_controller.h
    • components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
    • components/sync_bookmarks/bookmark_model_associator.cc
    • components/sync_bookmarks/bookmark_model_associator.h
    • components/sync_bookmarks/bookmark_model_type_processor_unittest.cc
    • ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc
    • ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.h
    • ios/chrome/browser/sync/ios_chrome_sync_client.h
    • ios/chrome/browser/sync/ios_chrome_sync_client.mm
    • ios/chrome/browser/ui/settings/passphrase_table_view_controller_test.mm
    • ios/chrome/browser/ui/settings/sync/sync_encryption_table_view_controller_unittest.mm
    • ios/chrome/browser/ui/settings/sync/sync_settings_table_view_controller_unittest.mm
    • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
    • ios/web_view/internal/sync/web_view_sync_client.h
    • ios/web_view/internal/sync/web_view_sync_client.mm

47. Ignore same-document navigation commit in pending deletion frame.

    Changed by	arthursonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 10:24:17 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d983179ffc57406e0a700d870366a1474b23244a

    Comments

    Ignore same-document navigation commit in pending deletion frame.
    
    Similar to what is done with different-document navigations. If a
    same-document navigation commits into a pending deletion frame, it needs
    to be ignored.
    
    Regression tests added.
    
    Bug: 930132
    Change-Id: Ib905197d30a754c3ac77b510d58741f40755a80f
    Reviewed-on: https://chromium-review.googlesource.com/c/1461023
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630709}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/site_per_process_browsertest.cc

48. CSVTable should only understand CRLF and LF as EOL

    Changed by	Vaclav Brozek - vabrohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 10:15:31 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7e4619a28048a050d68f4fdbbf3db3043374fd29

    Comments

    CSVTable should only understand CRLF and LF as EOL
    
    So far, CSVTable understood any combination of CR and LF characters as
    the end of line. After a discussion linked to in
    https://crbug.com/923811, this CL changes that to explicitly only
    allowing CRLF and LF.
    
    Moreover, CRLF is no longer converted to LF inside quoted (escaped)
    strings.
    
    Performance impact, as measured with the benchmark from
    https://crrev.com/c/1459642:
     * Run time of the benchmark decreased from about 10s to about 9.5s
     * Peak memory consumption over 5 runs decreased from about 168700 kB
       to about 168350 kB
    
    Bug: 923811
    Change-Id: I979d05e9f296f285db99dc22662bae29c907ea2a
    Reviewed-on: https://chromium-review.googlesource.com/c/1461042
    Commit-Queue: Vaclav Brozek <vabr@chromium.org>
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630708}

    Changed files

    • components/password_manager/core/browser/import/csv_reader.cc
    • components/password_manager/core/browser/import/csv_reader.h
    • components/password_manager/core/browser/import/csv_reader_unittest.cc

49. //components/supervised_user_error_page: Convert base::(U)Int(64)ToString(16) to NumberToString(16)

    Changed by	Raul Tambre - raulohnoyoudont@tambre.ee
    Changed at	Monday, 11-Feb-19 10:08:02 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	44827fbd572669eb59878beb9b208e12bafd7813

    Comments

    //components/supervised_user_error_page: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
    
    The former non-overloaded variants are deprecated.
    
    This is a mechanical change; there is no intended behavior change.
    
    Bug: 929827
    Change-Id: I19be29e50c0d268b4280a6b0e572acdb0ac67af3
    Reviewed-on: https://chromium-review.googlesource.com/c/1461385
    Auto-Submit: Raul Tambre <raul@tambre.ee>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630707}

    Changed files

    • components/supervised_user_error_page/supervised_user_error_page.cc

50. [Mfill Android] Display title of open sheet in accessory bar

    Changed by	Friedrich Horschig - fhorschigohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 10:04:38 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3d037722e894145122ff7f07783e6a9382e38a44

    Comments

    [Mfill Android] Display title of open sheet in accessory bar
    
    This CL removes the static title if suggestions are available.
    Margins between suggestions are adjusted (according to mocks).
    
    It also fixes a minor bug: the back arrow wasn't mirrored in RTL mode.
    
    Bug: TBA
    Change-Id: I8a6e12c75418ee5c90ed6bd326ed075e8033bc8d
    Reviewed-on: https://chromium-review.googlesource.com/c/1458856
    Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630706}

    Changed files

    • chrome/android/java/res/drawable/ic_arrow_back_24dp.xml
    • chrome/android/java/res/layout/keyboard_accessory_modern.xml
    • chrome/android/java/res/layout/keyboard_accessory_sheet_tab_legacy_title.xml
    • chrome/android/java/res/layout/keyboard_accessory_sheet_tab_password_info.xml
    • chrome/android/java/res/layout/keyboard_accessory_sheet_tab_title.xml
    • chrome/android/java/res/values/dimens.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/CreditCardAccessorySheetCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModernView.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModernViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryProperties.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetModernViewBinder.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetModernViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java

51. sync_ui_util: Only take a Profile* param, not other KeyedService*s

    Changed by	Marc Treib - treibohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 09:41:37 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6aa1608e02eef03a4642f7c3a54578fab47608d4

    Comments

    sync_ui_util: Only take a Profile* param, not other KeyedService*s
    
    If these functions need the Profile anyway, they can just grab any
    KeyedServices they require themselves. No need to make clients get them
    and pass them in.
    
    Bug: 911153
    Change-Id: I31e9ecd3739e06fd2d4c9da00a1727cf9833e116
    Reviewed-on: https://chromium-review.googlesource.com/c/1454539
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630705}

    Changed files

    • chrome/browser/browsing_data/counters/browsing_data_counter_utils.cc
    • chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
    • chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
    • chrome/browser/sync/profile_sync_test_util.cc
    • chrome/browser/sync/profile_sync_test_util.h
    • chrome/browser/sync/sync_ui_util.cc
    • chrome/browser/sync/sync_ui_util.h
    • chrome/browser/sync/sync_ui_util_unittest.cc
    • chrome/browser/ui/webui/settings/people_handler.cc
    • chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

52. [Android Mfill] Reenable integration tests

    Changed by	Friedrich Horschig - fhorschigohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 09:35:54 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	25117a7b92c42cb73856aa430897ba516fd4865c

    Comments

    [Android Mfill] Reenable integration tests
    
    This CL reenables all Autofill and Manual Filling Integration tests that
    previously flaked due to keyboard timing, unstable UI or were disabled
    because autofill chips were not yet available.
    
    Minor fix: Rescroll the chips when switching the focused field.
    
    Bug: 838922, 836027, 847959, 894428, 911056, 919988
    Change-Id: I2fcfdc4016da5952cddf79f2d5c33180d89b7e1f
    Reviewed-on: https://chromium-review.googlesource.com/c/1459552
    Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630704}

    Changed files

    • chrome/android/BUILD.gn
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingUiCaptureTest.java

53. blink: Fix member names in comments.

    Changed by	Victor Costan - pwnallohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 09:28:49 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6c34bd1ad0a8e7a846536be57d042cbd14709b17

    Comments

    blink: Fix member names in comments.
    
    This CL fixes member names that use the WebKit convention (m_name) to
    use the Google convention (name_). Where appropriate, the member names
    are wrapped in || so that they get code serachs' cross-reference
    navigation.
    
    Change-Id: I4d52de3b734cb28a998810bfb274f9f2716a4d79
    Reviewed-on: https://chromium-review.googlesource.com/c/1462152
    Commit-Queue: Kentaro Hara <haraken@chromium.org>
    Auto-Submit: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630703}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
    • third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc
    • third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.h
    • third_party/blink/renderer/build/scripts/core/css/templates/style_property_shorthand.h.tmpl
    • third_party/blink/renderer/build/scripts/templates/instrumenting_probes_impl.cc.tmpl
    • third_party/blink/renderer/build/scripts/templates/internal_settings_generated.cc.tmpl
    • third_party/blink/renderer/build/scripts/templates/internal_settings_generated.h.tmpl
    • third_party/blink/renderer/build/scripts/templates/probe_sink.h.tmpl
    • third_party/blink/renderer/core/animation/document_timeline.cc
    • third_party/blink/renderer/core/animation/invalidatable_interpolation.cc
    • third_party/blink/renderer/core/animation/underlying_value_owner.cc
    • third_party/blink/renderer/core/clipboard/data_object_item.cc
    • third_party/blink/renderer/core/clipboard/data_object_item.h
    • third_party/blink/renderer/core/clipboard/data_transfer.cc
    • third_party/blink/renderer/core/css/css_selector_watch.h
    • third_party/blink/renderer/core/css/selector_query.h
    • third_party/blink/renderer/core/editing/ephemeral_range.h
    • third_party/blink/renderer/core/editing/iterators/simplified_backwards_text_iterator.h
    • third_party/blink/renderer/core/editing/iterators/text_iterator.cc
    • third_party/blink/renderer/core/editing/position.h
    • third_party/blink/renderer/core/editing/selection_modifier.cc
    • third_party/blink/renderer/core/events/error_event.cc
    • third_party/blink/renderer/core/events/error_event.h
    • third_party/blink/renderer/core/events/pointer_event_factory.cc
    • third_party/blink/renderer/core/exported/web_associated_url_loader_impl.h
    • third_party/blink/renderer/core/exported/web_input_method_controller_impl.cc
    • third_party/blink/renderer/core/exported/web_meaningful_layouts_test.cc
    • third_party/blink/renderer/core/exported/web_page_popup_impl.cc
    • third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
    • third_party/blink/renderer/core/exported/web_view_impl.cc

54. Add comment to NavigationBodyLoader::OnReceiveCachedMetadata()

    Changed by	arthursonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 09:27:22 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2e6c3d90227b01b1fbc2a895e89e5dfd97886dd7

    Comments

    Add comment to NavigationBodyLoader::OnReceiveCachedMetadata()
    
    This function is used by the ServiceWorker, but is not covered by tests.
    Add a comment to explain it is used.
    
    Bug: None.
    Change-Id: Iebf201e743debc01f16954e327f3abbe02f1bd40
    Reviewed-on: https://chromium-review.googlesource.com/c/1455958
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630702}

    Changed files

    • content/renderer/loader/navigation_body_loader.cc

55. Fix mojo mailing list

    Changed by	Michael Giuffrida - michaelpgohnoyoudont@chromium.org
    Changed at	Monday, 11-Feb-19 09:15:21 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	682082177036e1017a7e90971d2b77511defec3c

    Comments

    Fix mojo mailing list
    
    Fixes the address of the chromium-mojo mailing list. Also makes it link
    to the Google Groups page for consistency with other Mojo docs.
    
    Bug: None
    Change-Id: Ic2230d996efab8b75c41c1a0d73f889d5c1124bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1462147
    Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#630701}

    Changed files

    • docs/security/mojo.md