Home | Search | chromium - Builders
Login

Builder ios-uirefresh-simulator Build 241 Apple OSX

Results:

Failure Uncaught Exception

Trigger Info:

Projectchromium
Revisioncae26c020606a88289e746e446999dd9c101019d
Got Revisioncae26c020606a88289e746e446999dd9c101019d

Execution:

Steps and Logfiles:

Show:
  1. ( 155 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 366 ms ) remove .cipd
  3. ( 1 mins 15 secs ) bot_update
    [79GB/232GB used (34%)]
  4. ( 278 ms ) read build config
  5. ( 0 ) ensure_goma
  6. ( 0 ) ensure xcode
    Ensuring Xcode version 9c40b in /b/s/w/ir/cache/xcode_ios_9c40b.app
  7. ( 12 secs ) gclient runhooks
  8. ( 3 mins 2 secs ) compile
  9. ( 0 ) isolate
  10. ( 397 ms ) isolate.generate 0.isolate.gen.json
    ios_chrome_unittests (iPhone 5s iOS 11.2)
  11. ( 401 ms ) isolate.generate 1.isolate.gen.json
    ios_net_unittests (iPhone 5s iOS 11.2)
  12. ( 400 ms ) isolate.generate 2.isolate.gen.json
    ios_web_inttests (iPhone 5s iOS 11.2)
  13. ( 399 ms ) isolate.generate 3.isolate.gen.json
    ios_web_unittests (iPhone 5s iOS 11.2)
  14. ( 399 ms ) isolate.generate 4.isolate.gen.json
    ios_web_view_inttests (iPhone 5s iOS 11.2)
  15. ( 399 ms ) isolate.generate 5.isolate.gen.json
    ios_chrome_unittests (iPhone X iOS 11.2)
  16. ( 401 ms ) isolate.generate 6.isolate.gen.json
    ios_net_unittests (iPhone X iOS 11.2)
  17. ( 402 ms ) isolate.generate 7.isolate.gen.json
    ios_web_inttests (iPhone X iOS 11.2)
  18. ( 402 ms ) isolate.generate 8.isolate.gen.json
    ios_web_unittests (iPhone X iOS 11.2)
  19. ( 415 ms ) isolate.generate 9.isolate.gen.json
    ios_web_view_inttests (iPhone X iOS 11.2)
  20. ( 404 ms ) isolate.generate 10.isolate.gen.json
    ios_chrome_unittests (iPad Air iOS 11.2)
  21. ( 398 ms ) isolate.generate 11.isolate.gen.json
    ios_net_unittests (iPad Air iOS 11.2)
  22. ( 400 ms ) isolate.generate 12.isolate.gen.json
    ios_web_inttests (iPad Air iOS 11.2)
  23. ( 400 ms ) isolate.generate 13.isolate.gen.json
    ios_web_unittests (iPad Air iOS 11.2)
  24. ( 400 ms ) isolate.generate 14.isolate.gen.json
    ios_web_view_inttests (iPad Air iOS 11.2)
  25. ( 399 ms ) isolate.generate 15.isolate.gen.json
    base_unittests (iPhone 6 iOS 11.2)
  26. ( 401 ms ) isolate.generate 16.isolate.gen.json
    components_unittests (iPhone 6 iOS 11.2)
  27. ( 400 ms ) isolate.generate 17.isolate.gen.json
    gfx_unittests (iPhone 6 iOS 11.2)
  28. ( 399 ms ) isolate.generate 18.isolate.gen.json
    ios_chrome_unittests (iPhone 6 iOS 11.2)
  29. ( 403 ms ) isolate.generate 19.isolate.gen.json
    ios_web_inttests (iPhone 6 iOS 11.2)
  30. ( 401 ms ) isolate.generate 20.isolate.gen.json
    ios_web_unittests (iPhone 6 iOS 11.2)
  31. ( 399 ms ) isolate.generate 21.isolate.gen.json
    ios_web_view_inttests (iPhone 6 iOS 11.2)
  32. ( 402 ms ) isolate.generate 22.isolate.gen.json
    ios_web_view_unittests (iPhone 6 iOS 11.2)
  33. ( 399 ms ) isolate.generate 23.isolate.gen.json
    skia_unittests (iPhone 6 iOS 11.2)
  34. ( 399 ms ) isolate.generate 24.isolate.gen.json
    ui_base_unittests (iPhone 6 iOS 11.2)
  35. ( 399 ms ) isolate.generate 25.isolate.gen.json
    base_unittests (iPad Air iOS 11.2)
  36. ( 401 ms ) isolate.generate 26.isolate.gen.json
    components_unittests (iPad Air iOS 11.2)
  37. ( 399 ms ) isolate.generate 27.isolate.gen.json
    gfx_unittests (iPad Air iOS 11.2)
  38. ( 401 ms ) isolate.generate 28.isolate.gen.json
    ios_chrome_unittests (iPad Air iOS 11.2)
  39. ( 400 ms ) isolate.generate 29.isolate.gen.json
    ios_web_inttests (iPad Air iOS 11.2)
  40. ( 400 ms ) isolate.generate 30.isolate.gen.json
    ios_web_unittests (iPad Air iOS 11.2)
  41. ( 402 ms ) isolate.generate 31.isolate.gen.json
    ios_web_view_inttests (iPad Air iOS 11.2)
  42. ( 399 ms ) isolate.generate 32.isolate.gen.json
    ios_web_view_unittests (iPad Air iOS 11.2)
  43. ( 405 ms ) isolate.generate 33.isolate.gen.json
    skia_unittests (iPad Air iOS 11.2)
  44. ( 401 ms ) isolate.generate 34.isolate.gen.json
    ui_base_unittests (iPad Air iOS 11.2)
  45. ( 400 ms ) isolate.generate 35.isolate.gen.json
    ios_chrome_integration_egtests (iPhone X iOS 11.2)
  46. ( 403 ms ) isolate.generate 36_0.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 0
  47. ( 398 ms ) isolate.generate 36_1.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 1
  48. ( 400 ms ) isolate.generate 36_2.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 2
  49. ( 399 ms ) isolate.generate 36_3.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 3
  50. ( 402 ms ) isolate.generate 37.isolate.gen.json
    ios_web_shell_egtests (iPhone X iOS 11.2)
  51. ( 403 ms ) isolate.generate 38.isolate.gen.json
    ios_chrome_integration_egtests (iPad Air iOS 11.2)
  52. ( 403 ms ) isolate.generate 39_0.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air iOS 11.2) shard 0
  53. ( 400 ms ) isolate.generate 39_1.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air iOS 11.2) shard 1
  54. ( 400 ms ) isolate.generate 39_2.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air iOS 11.2) shard 2
  55. ( 400 ms ) isolate.generate 39_3.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air iOS 11.2) shard 3
  56. ( 400 ms ) isolate.generate 40.isolate.gen.json
    ios_web_shell_egtests (iPad Air iOS 11.2)
  57. ( 401 ms ) isolate.generate 41.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPhone X iOS 11.2)
  58. ( 385 ms ) isolate.generate 42.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPhone X iOS 11.2)
  59. ( 352 ms ) isolate.generate 43.isolate.gen.json
    ios_chrome_web_egtests (iPhone X iOS 11.2)
  60. ( 356 ms ) isolate.generate 44.isolate.gen.json
    ios_chrome_settings_egtests (iPhone X iOS 11.2)
  61. ( 350 ms ) isolate.generate 45.isolate.gen.json
    ios_chrome_payments_egtests (iPhone X iOS 11.2)
  62. ( 349 ms ) isolate.generate 46.isolate.gen.json
    ios_chrome_reading_list_egtests (iPhone X iOS 11.2)
  63. ( 350 ms ) isolate.generate 47.isolate.gen.json
    ios_showcase_egtests (iPhone X iOS 11.2)
  64. ( 358 ms ) isolate.generate 48.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPad Air iOS 11.2)
  65. ( 352 ms ) isolate.generate 49.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPad Air iOS 11.2)
  66. ( 355 ms ) isolate.generate 50.isolate.gen.json
    ios_chrome_web_egtests (iPad Air iOS 11.2)
  67. ( 349 ms ) isolate.generate 51.isolate.gen.json
    ios_chrome_settings_egtests (iPad Air iOS 11.2)
  68. ( 350 ms ) isolate.generate 52.isolate.gen.json
    ios_chrome_payments_egtests (iPad Air iOS 11.2)
  69. ( 351 ms ) isolate.generate 53.isolate.gen.json
    ios_chrome_reading_list_egtests (iPad Air iOS 11.2)
  70. ( 354 ms ) isolate.generate 54.isolate.gen.json
    ios_showcase_egtests (iPad Air iOS 11.2)
  71. ( 2 mins 22 secs ) isolate.archive
  72. ( 0 ) trigger
  73. ( 2 ms ) Uncaught Exception
    Uncaught Exception: AssertionError('Triggered same task twice: ios_chrome_unittests (iPad Air iOS 11.2)/Mac/603c318b5b/ios-uirefresh-simulator/241',)
  74. ( 1 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build112-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531414716838060, "id": "8941188997835513248", "project": "chromium", "tags": ["builder:ios-uirefresh-simulator", "buildset:commit/git/cae26c020606a88289e746e446999dd9c101019d", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/cae26c020606a88289e746e446999dd9c101019d", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106619060125264800", "scheduler_job_id:chromium/ios-uirefresh-simulator", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-uirefresh-simulator" setup_build
buildnumber 241 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "cae26c020606a88289e746e446999dd9c101019d" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "cae26c020606a88289e746e446999dd9c101019d" bot_update
got_revision_cp "refs/heads/master@{#574605}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23952}" bot_update

Blamelist:

  1. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  2. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  3. Colin Blundell (blundellohnoyoudont@chromium.org)
  4. Jun Cai (juncaiohnoyoudont@chromium.org)
  5. Etienne Pierre-doray (etiennepohnoyoudont@chromium.org)
  6. Kim Paulhamus (kpaulhamusohnoyoudont@chromium.org)
  7. Eugene But (eugenebutohnoyoudont@google.com)
  8. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  9. Becky Zhou (huayinzohnoyoudont@chromium.org)
  10. Nico Weber (thakisohnoyoudont@chromium.org)
  11. David Grogan (dgroganohnoyoudont@chromium.org)
  12. Nick Burris (nburrisohnoyoudont@google.com)
  13. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  14. Mike Reed (reedohnoyoudont@google.com)
  15. Peter E Conn (peconnohnoyoudont@chromium.org)
  16. Peter Kasting (pkastingohnoyoudont@chromium.org)
  17. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  18. Jay Civelli (jcivelliohnoyoudont@google.com)
  19. Stefan Zager (szagerohnoyoudont@chromium.org)
  20. Bruce Dawson (brucedawsonohnoyoudont@chromium.org)
  21. Peter Kasting (pkastingohnoyoudont@chromium.org)
  22. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  23. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  24. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  25. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  26. Peter Wen (wnwenohnoyoudont@chromium.org)
  27. Xida Chen (xidachenohnoyoudont@chromium.org)
  28. Daniel Bratell (bratellohnoyoudont@opera.com)
  29. Danyao Wang (danyaoohnoyoudont@chromium.org)
  30. Stephen Lanham (slanohnoyoudont@google.com)
  31. Sujie Zhu (sujiezhuohnoyoudont@google.com)
  32. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  33. Majid Valipour (majidvpohnoyoudont@chromium.org)
  34. kylechar (kylecharohnoyoudont@chromium.org)
  35. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  36. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  37. vitaliii (vitaliiiohnoyoudont@chromium.org)
  38. Ken Rockot (rockotohnoyoudont@chromium.org)
  39. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  40. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  41. Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
  42. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  43. Ryan Daum (rdaumohnoyoudont@chromium.org)
  44. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  45. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  46. Amos Lim (eui-sang.limohnoyoudont@samsung.com)
  47. Orsi Batiz (orsibatizohnoyoudont@google.com)
  48. Gabriel Charette (gabohnoyoudont@chromium.org)
  49. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  50. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  51. Tiger Oakes (tigeroohnoyoudont@google.com)
  52. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  53. clamy (clamyohnoyoudont@chromium.org)
  54. Jan Wilken Doerrie (jdoerrieohnoyoudont@chromium.org)
  55. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  56. Colin Blundell (blundellohnoyoudont@chromium.org)
  57. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  58. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  59. Nico Weber (thakisohnoyoudont@chromium.org)
  60. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  61. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
  62. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  63. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  64. Emily Hanley (eyaichohnoyoudont@google.com)
  65. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  66. Yoshisato Yanagisawa (yyanagisawaohnoyoudont@chromium.org)
  67. Mike West (mkwstohnoyoudont@chromium.org)
  68. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  69. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  70. Kent Tamura (tkentohnoyoudont@chromium.org)
  71. Ivan Sandrk (isandrkohnoyoudont@google.com)
  72. Mike West (mkwstohnoyoudont@chromium.org)
  73. Arthur Hemery (ahemeryohnoyoudont@chromium.org)
  74. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  75. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  76. Shik Chen (shikohnoyoudont@chromium.org)
  77. Benoit Lize (lizebohnoyoudont@chromium.org)
  78. Peter Mayo (petermayoohnoyoudont@chromium.org)
  79. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  80. Mathieu Perreault (mathpohnoyoudont@chromium.org)
  81. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  82. Philip J├Ągenstedt (foolipohnoyoudont@chromium.org)
  83. Mike West (mkwstohnoyoudont@chromium.org)
  84. afdo-chromium-autoroll (afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  85. Tatsuhisa Yamaguchi (yamaguchiohnoyoudont@chromium.org)
  86. Rohit Rao (rohitraoohnoyoudont@chromium.org)
  87. Mark Cogan (marqohnoyoudont@google.com)
  88. Mike West (mkwstohnoyoudont@chromium.org)
  89. Stefan Teodorescu (faneohnoyoudont@google.com)
  90. Han Leon (leon.hanohnoyoudont@intel.com)
  91. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  92. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  93. Mike West (mkwstohnoyoudont@chromium.org)
  94. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  95. Colin Blundell (blundellohnoyoudont@chromium.org)
  96. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  97. Raphael Kubo da Costa (CET) (raphael.kubo.da.costaohnoyoudont@intel.com)
  98. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  99. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  100. rajendrant (rajendrantohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Thursday, 12-Jul-18 16:58:36 UTC
Start Thursday, 12-Jul-18 16:59:04 UTC
End Thursday, 12-Jul-18 17:08:37 UTC
Pending 27 secs
Execution 9 mins 33 secs

All Changes:

  1. Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 16:57:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cae26c020606a88289e746e446999dd9c101019d

    Comments

    Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/58c79f66dd3a..798ee75d2365
    
    
    git log 58c79f66dd3a..798ee75d2365 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 kthelgason@webrtc.org Always disable RED when ULPFEC is disabled.
    2018-07-12 hta@webrtc.org Buffer ICE candidates that can't be added immediately.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@798ee75d2365
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ia3faf57f19146a8b08a9a5cbe8915a9750b91210
    Reviewed-on: https://chromium-review.googlesource.com/1135226
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574605}

    Changed files

    • DEPS
  2. [unified-consent] Add unity logic to OneClickSigninSyncStarter

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:55:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90520e430b08a292bd878117370d0a7e68eb38bc

    Comments

    [unified-consent] Add unity logic to OneClickSigninSyncStarter
    
    All unified consent services are enabled when the unified
    consent is given through the OneClickSigninSyncStarter.
    
    Bug: 862202
    Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
    Reviewed-on: https://chromium-review.googlesource.com/1135001
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574604}

    Changed files

    • chrome/browser/ui/sync/one_click_signin_sync_starter.cc
    • chrome/browser/ui/sync/one_click_signin_sync_starter.h
  3. Revert "Have Device Service observe MessageLoop destruction"

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1

    Comments

    Revert "Have Device Service observe MessageLoop destruction"
    
    This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.
    
    Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which will mean doing the plumbing that the below CL was looking to avoid. This is all sad-making, but c'est la vie.
    
    Bug: 856771, 794105
    
    Original change's description:
    > Have Device Service observe MessageLoop destruction
    >
    > The Device Service needs to clean up parts of its internal state as part
    > of browser shutdown. However, it also needs to run on the UI thread,
    > and embedded services that run on the UI thread are not guaranteed to
    > be destroyed as part of browser shutdown (tasks to destroy these
    > services are posted from the IO thread by
    > ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
    > typically shut down before these posted tasks are run).
    >
    > To solve this issue we discussed adding plumbing wherein embedded
    > services could inform //content that they wanted to be notified when
    > shutdown was occurring on the main thread. However, on investigation
    > this plumbing would be painful to implement: it is only
    > EmbeddedInstanceManager that has direct information of these service
    > instances, and that object lives far away from //content's
    > ServiceManagerContext, the object that knows when shutdown is occurring
    > on the main thread.
    >
    > This CL takes an alternative approach of having the Device Service
    > implementation observe the destruction of its MessageLoop. I have
    > verified that the observation is triggered on shutdown of Chrome.
    >
    > Bug: 794105
    > Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
    > Reviewed-on: https://chromium-review.googlesource.com/1099245
    > Commit-Queue: Colin Blundell <blundell@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567260}
    
    TBR=rockot@chromium.org,blundell@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 794105
    Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
    Reviewed-on: https://chromium-review.googlesource.com/1134887
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h
  4. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3aba7f968ecb147e59a5460bd168e6085425848

    Comments

    Network Service: Document how adding/removing http headers for web content requests are implemented
    
    This is a follow-up CL per comments at:
    https://chromium-review.googlesource.com/c/chromium/src/+/1120955
    
    This CL adds comments to //components/variations/variations_http_header_provider.cc
    to document how adding/removing http headers for web content requests are
    implemented differently when Network Service is enabled or not enabled.
    
    Bug: 841309
    Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
    Reviewed-on: https://chromium-review.googlesource.com/1134408
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc
  5. [Autofill]: Create a policy flag for AutofillProfileEnabled.

    Changed by Etienne Pierre-doray - etiennepohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:50:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b27097af312f3f4a4ee22bf0ea2c65239de03ff

    Comments

    [Autofill]: Create a policy flag for AutofillProfileEnabled.
    
    AutofillProfileEnabled was added as a preference setting in 1127344.
    This CL creates a policy flag for AutofillProfileEnabled that can
    overwrite the user preference.
    
    Bug: 860526
    Change-Id: I5d4848c26a53cf163fc4557d9b2da5f597bd98cf
    Reviewed-on: https://chromium-review.googlesource.com/1127463
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Reviewed-by: Drew Wilson <atwilson@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574601}

    Changed files

    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/test/data/policy/policy_test_cases.json
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_profile_policy_handler.cc
    • components/autofill/core/browser/autofill_profile_policy_handler.h
    • components/autofill/core/browser/autofill_profile_policy_handler_unittest.cc
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  6. Mark window-focus-self as flaky on Win10

    Changed by Kim Paulhamus - kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:49:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7be9cc2e39f872aeb8e03afb7d0aabf92ffde03

    Comments

    Mark window-focus-self as flaky on Win10
    
    Tbr: tkent@chromium.org
    Bug: 863067
    Change-Id: I9f043eec8363dbb26ccaa8d901321e0d579f1a4f
    Reviewed-on: https://chromium-review.googlesource.com/1135433
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574600}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  7. Add testDownloadWhileBrowsing EG test.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:48:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cce6875386037980e3245c630a9b9bac926f91e

    Comments

    Add testDownloadWhileBrowsing EG test.
    
    After tapping Download this test opens a separate tabs and loads the URL
    there. Then closes the tab and waits for the download completion.
    
    Bug: 854232
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id05c9344d1da80a57b6c7cc663b2b8a835f18e82
    Reviewed-on: https://chromium-review.googlesource.com/1111916
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574599}

    Changed files

    • ios/chrome/browser/ui/download/BUILD.gn
    • ios/chrome/browser/ui/download/download_manager_egtest.mm
    • ios/chrome/test/BUILD.gn
    • ios/chrome/test/scoped_eg_synchronization_disabler.h
  8. [Fuchsia] Address CR comments in sys::Runner implementation

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:39:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c234b0272dff6ce746e9eaac813497986913c3

    Comments

    [Fuchsia] Address CR comments in sys::Runner implementation
    
    When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
    prematurely and landed the change without my changes that addresed
    review comments. Landing them separately.
    
    Bug: 856416
    Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
    Reviewed-on: https://chromium-review.googlesource.com/1133968
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574598}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/app/component_controller_impl.cc
    • webrunner/app/component_controller_impl.h
    • webrunner/app/main.cc
    • webrunner/app/web_content_runner.cc
    • webrunner/app/web_content_runner.h
  9. [Feed] Scroll and focus handling for the FeedNewTabPage

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:36:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54d1975f16b7efae2408a1428fbde7207556a29

    Comments

    [Feed] Scroll and focus handling for the FeedNewTabPage
    
    + Implement NewTabPageLayout.ScrollDelegate to the FeedNewTabPage
    + Refactor snap scroll logic to a new class to make it reusable
    + Add top padding for the FeedNewTabPage to display correctly on tablet
    + Fix a small bug that search box is not enabled after auto snap scroll
    
    Bug: 860028, 860032, 862470
    Change-Id: I5bda9696a4515281378c1effe47b6ad47fdd4c49
    Reviewed-on: https://chromium-review.googlesource.com/1133594
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574597}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/SnapScrollHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
  10. Remove most android-specific hard_timeout and shard overrides.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a64d6771d8b24f079f24e41ebaf14f672747084

    Comments

    Remove most android-specific hard_timeout and shard overrides.
    
    These were added during android swarming bring-up.  We shouldn't use
    per-bot exceptions for this.
    
    Also remove a random sharding setting for base_unittests on ToTMac
    that doesn't look necessary.
    
    Bug: 843511
    Change-Id: Ia20771786f1b4106cd86d24d446e0a66f319dbff
    Reviewed-on: https://chromium-review.googlesource.com/1134531
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574596}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.swarm.json
    • testing/buildbot/test_suite_exceptions.pyl
  11. [css-tables] Make table's max-content honor captions' min-content

    Changed by David Grogan - dgroganohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dff5931455e0302289a3cc9027fd3f98cfe22fca

    Comments

    [css-tables] Make table's max-content honor captions' min-content
    
    Table's min-content already honored it.
    
    We'd apparently never been bitten before by tables occasionally having
    min-content > max-content. A new DCHECK in LayoutNG exposed it.
    
    Bug: 857185
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I49009a4988fbf38c1bf745a4f028e4e8b050804b
    Reviewed-on: https://chromium-review.googlesource.com/1121251
    Commit-Queue: David Grogan <dgrogan@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574595}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/table/caption-min-greater-than-max-crash.html
    • third_party/WebKit/LayoutTests/fast/table/spans-min-greater-than-max-crash.html
    • third_party/blink/renderer/core/layout/layout_table.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
  12. Settings WebUI: Fix extensions url on cleanup result page

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:33:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7cde465a809facc9ecb61350aaa5c504a36d9174

    Comments

    Settings WebUI: Fix extensions url on cleanup result page
    
    The cleaner success string now has HTML in it, and the JS i18n
    function strips it off. i18nAdvanced allows us to let the <a> through to
    the string, but the way the cleanup result page works is it simply sets
    the card text variable ("title") to the result message string. This
    would result in the raw string (with HTML) getting displayed, so the
    title variable needs to also be set to be the inner-h-t-m-l.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
    Reviewed-on: https://chromium-review.googlesource.com/1134191
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574594}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  13. [Background Fetch] Add DB corruption handler to data manager observer.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:31:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96544636e959581575b9c4f1ac2ecd1c5f40296d

    Comments

    [Background Fetch] Add DB corruption handler to data manager observer.
    
    Bug: 850512
    Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
    Reviewed-on: https://chromium-review.googlesource.com/1128839
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574593}

    Changed files

    • content/browser/background_fetch/background_fetch_context.cc
    • content/browser/background_fetch/background_fetch_context.h
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_observer.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc
    • content/browser/background_fetch/storage/get_settled_fetches_task.cc
    • content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
    • content/browser/background_fetch/storage/start_next_pending_request_task.cc
  14. suppress until skia roll

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:30:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

    Comments

    suppress until skia roll
    
    Bug: 863042
    Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
    Reviewed-on: https://chromium-review.googlesource.com/1135288
    Commit-Queue: Mike Reed <reed@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574592}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  15. ­čĄŁ Add flag to force showing TWA disclosure.

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    ­čĄŁ Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  16. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b2b9af8ace2bbc3384147241601d4293f0c2259

    Comments

    Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
    
    Bug: none
    Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
    Reviewed-on: https://chromium-review.googlesource.com/1134499
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574590}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
  17. Keep timestamp in aar.py when file is not changed

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:22:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

    Comments

    Keep timestamp in aar.py when file is not changed
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1127565
    I didn't understand filecmp.dircmp.
    
    Changed to use md5_check.CallAndRecordIfStale instead.
    Also let ExtractAll create directory even when it is empty.
    
    Bug: 810298, 860251
    Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
    Reviewed-on: https://chromium-review.googlesource.com/1132818
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574589}

    Changed files

    • build/android/gyp/aar.py
    • build/android/gyp/util/build_utils.py
  18. Simplify FakeGaiaCookieManagerService

    Changed by Jay Civelli - jcivelliohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

    Comments

    Simplify FakeGaiaCookieManagerService
    
    Simplifying the FakeGaiaCookieManagerService API by not requiring to
    call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
    instead a member of the FakeGaiaCookieManagerService.
    
    This API simplification is in preparation for switching GaiaAuthFetcher
    to use the SimpleURLLoader (network service).
    
    Bug: 840396
    Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
    Reviewed-on: https://chromium-review.googlesource.com/1114226
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574588}

    Changed files

    • chrome/browser/extensions/api/identity/identity_apitest.cc
    • chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
    • chrome/browser/signin/signin_ui_util_unittest.cc
    • chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.h
    • components/search_provider_logos/logo_service_impl_unittest.cc
    • components/signin/core/browser/account_investigator_unittest.cc
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.h
    • components/signin/core/browser/signin_manager_unittest.cc
  19. Get rid of GraphicsLayer::scrollable_area_

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 442f13b7e97747ab09612a101159b1eb26072382

    Comments

    Get rid of GraphicsLayer::scrollable_area_
    
    The only place where it was actually used was in
    GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
    call to the GraphicsLayerClient.
    
    BUG=823365
    R=pdr@chromium.org,skobes@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
    Reviewed-on: https://chromium-review.googlesource.com/1132536
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574587}

    Changed files

    • third_party/blink/renderer/core/frame/visual_viewport.cc
    • third_party/blink/renderer/core/frame/visual_viewport.h
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.h
    • third_party/blink/renderer/platform/graphics/graphics_layer_client.h
  20. Add "latency" to list of ETW-traceable events

    Changed by Bruce Dawson - brucedawsonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5d9a9d75a9a8f7f6fb9d749c9b797eb2550d34e

    Comments

    Add "latency" to list of ETW-traceable events
    
    The "latency" category looks like a perfect event category for ETW
    tracing. In particular, TabSwitching::Latency indicates when Chrome
    thinks that tab switching has started and stopped which allows it to be
    profiled in detail. This has revealed where CPU time is going, and how
    long the delay is from when the keyboard event is generated to when
    Chrome starts officially processing it. This was helpful in
    investigating tab switching latency in bug 858944.
    
    This will require an update to UIforETW to fully enable, which I have
    done locally for testing purposes.
    
    Bug: 858944
    Change-Id: I4797b804ea6d35458aa3b4e876a78172a29d5131
    Reviewed-on: https://chromium-review.googlesource.com/1134516
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574586}

    Changed files

    • base/trace_event/trace_event_etw_export_win.cc
  21. Remove NewTabButton::GetVisibleBounds().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f448a241361b03dd2b6fd21ab052774e1074fdf1

    Comments

    Remove NewTabButton::GetVisibleBounds().
    
    This was a computed by constructing the border path and computing the bounding
    box.  However, it was only used for the ink drop, and ink drops are only used in
    newer material mode, where the border path is a square.
    
    Instead, we can use GetContentsBounds(), as long as those are actually
    positioned correctly.  The new tab button has empty space at the top, which is
    included (by the tabstrip) in its size and accounted for when doing painting and
    hittesting.  By adding an empty top border of this thickness, a lot of this code
    can be simplified.  (Further simplifications are coming in a subsequent CL.)
    
    Bug: none
    Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe
    Reviewed-on: https://chromium-review.googlesource.com/1134399
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574585}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
    • chrome/browser/ui/views/tabs/tab_strip.cc
  22. [AF] Use views::Separator in the Autofill dropdown

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff6fb086724fb3cd20409d3e72065bbd4a84abd

    Comments

    [AF] Use views::Separator in the Autofill dropdown
    
    This is a follow-up of crrev.com/c/1131680 and replace a custom view
    to simulate a separator with a views::Separator view.
    
    Change-Id: I0dc1db9c31039ce0959fa4aa4d37e4e99745a2d1
    Reviewed-on: https://chromium-review.googlesource.com/1133328
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574584}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  23. [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b35e9edf0aed36764ee35db8ed9e66466bb18249

    Comments

    [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests
    
    Remove a redundant URLPatternSet comparison method from
    ScriptingPermissionsModifier unittests, instead leveraging the
    string comparison and gmock utilities. These are slightly less code
    and offer better failure messages.
    
    Bug: None
    
    Change-Id: Ic8b99f0c9294658d6bdd16738f179a2e352eb408
    Reviewed-on: https://chromium-review.googlesource.com/1134496
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574583}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
  24. [ios] Set favicon fallback style for UI Refresh for ReadingList

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:05:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eeff01fbfa506b55fc9f1c0126c618a788015a4

    Comments

    [ios] Set favicon fallback style for UI Refresh for ReadingList
    
    - Sets the fallback monogram and background colors to a constant color.
    
    Collections flag off screenshot: https://drive.google.com/file/d/10fYA9oHwx_o3cGWXBSR5P4qXKIPDTcfm/view?usp=sharing
    Collections flag on screenshot: https://drive.google.com/file/d/1WtAYb-fPE6QdR4rIpcWxuZtLjGr7iPNQ/view?usp=sharing
    
    Bug: 851390
    
    Change-Id: I7d67a4129263b2deed52eb7603b3f84aa8b8a201
    Reviewed-on: https://chromium-review.googlesource.com/1125271
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574582}

    Changed files

    • ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
  25. Enable StaleWhileRevalidate in experimental features.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fc2f58c6417a00888317b79f40fd904b1f6628b

    Comments

    Enable StaleWhileRevalidate in experimental features.
    
    To gather some stability enable it for experimental features before
    we do the origin trial.
    
    BUG=348877
    
    Change-Id: I7598f35ac87b719305c6efa98c37de2eec8031a4
    Reviewed-on: https://chromium-review.googlesource.com/1134883
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574581}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  26. Android: Default to full instead of fast

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c98d04f201c356e8c4e811f3a43afa5c264750c

    Comments

    Android: Default to full instead of fast
    
    Switch from --full being optional to --fast being optional. Quite a few
    users of generate_gradle.py have found it unintuitive to have red
    underlines by default.
    
    Bug: 620034
    Change-Id: I24a19e16ed21baa19bde97bb2f3077430a73d148
    Reviewed-on: https://chromium-review.googlesource.com/1134882
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574580}

    Changed files

    • build/android/gradle/generate_gradle.py
  27. [Code health] Disable TouchActionBrowserTests on Debug and *San bots

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:02:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da109c8fd1b66a54c514b3012c29ebb232c113e9

    Comments

    [Code health] Disable TouchActionBrowserTests on Debug and *San bots
    
    These tests are flaky on Debug builds and *San bots. These tests sends
    synthetic gesture event and measure scroll offset. It should be fine
    without coverages on Debug and *San builds.
    
    TBR=sahel@chromium.org, tdresser@chromium.org
    
    Bug: 855979, 833015
    Change-Id: I009d3557454e0aab960d35fc5256ed487c2e47fe
    Reviewed-on: https://chromium-review.googlesource.com/1135195
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574579}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  28. [jumbo] Deduplicate a time constant in autofill code

    Changed by Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at Thursday, 12-Jul-18 16:01:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a742e15951f4e95d609b6628fc486a88b4fe0df

    Comments

    [jumbo] Deduplicate a time constant in autofill code
    
    Two different bubbles needed the same time constant and when
    they got copies of the constant that broke certain jumbo
    builds. This merges the constants to a single constant.
    
    It also changes type to base::TimeDelta which is the actual
    type needed and since the addition of constexpr can be used
    in global constants.
    
    Bug: 852904,862397
    Change-Id: I52a63d3301efb1c7aec55541c15427c5d96ba524
    Reviewed-on: https://chromium-review.googlesource.com/1134998
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574578}

    Changed files

    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/popup_constants.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
  29. Revert "[Nav Experiment] Add a wait after restore session."

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:01:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e33b9da8d371a25857c422d277115441c629ce5

    Comments

    Revert "[Nav Experiment] Add a wait after restore session."
    
    This reverts commit bcae87b0c7618e2fc61f78a073cf5589fe9679bd.
    
    Reason for revert: This didn't actually fix the problem and
    I didn't catch it due to a mistake in testing. The real
    problem is that the restore_session request started in 
    WKBasedNavigationManager::Restore() was not run, because
    |_containerView| is not yet initiated in the new CWVWebView.
    
    Original change's description:
    > [Nav Experiment] Add a wait after restore session.
    > 
    > This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    > enabled. A better approach would be to turn this test into a
    > programmatic test so both navigation managers implementations are
    > tested, but web::features symbols are not exposed in ios/web_view.
    > 
    > Bug: 862714
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
    > Reviewed-on: https://chromium-review.googlesource.com/1134046
    > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > Commit-Queue: Danyao Wang <danyao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574367}
    
    TBR=eugenebut@chromium.org,danyao@chromium.org
    
    Change-Id: Ia9d2d127e18264fbf69786c58b71706e0b34ead5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1135346
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574577}

    Changed files

    • ios/web_view/test/web_view_restorable_state_inttest.mm
  30. [Chromecast] Use MobileScoller on Cast Android builds.

    Changed by Stephen Lanham - slanohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:00:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bef77d4afc3b73eb7fc96dff1908164994b4a82

    Comments

    [Chromecast] Use MobileScoller on Cast Android builds.
    
    This class was renamed from Scroller here: crrev.com/c/1087641. Update the
    conditionals so that Scroller is only used on non-Android Cast builds,
    and MobileScroller is used on Android Cast builds.
    
    Bug: internal b/111287588
    Test: Compiles
    
    Change-Id: I19dc01e1339016e3db2ab3b7d81a95efc5c6a0f3
    Reviewed-on: https://chromium-review.googlesource.com/1133761
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Stephen Lanham <slan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574576}

    Changed files

    • ui/events/gestures/blink/web_gesture_curve_impl.cc
  31. Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type

    Changed by Sujie Zhu - sujiezhuohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 15:56:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdb64db76a187df14e07aa31daccedb1813ffb8e

    Comments

    Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type
    
    For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    
    Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    
    In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    
    The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    
    Bug: 852904
    Change-Id: I01191cb8a9d0a3bf954874e6c8beb62d3b02c1ea
    Reviewed-on: https://chromium-review.googlesource.com/1134388
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    Cr-Commit-Position: refs/heads/master@{#574575}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  32. fuzzer: Don't assume that the out dir is inside the src git repository.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:46:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fb53cf0d187b9537160ad967975f17641d59c1f

    Comments

    fuzzer: Don't assume that the out dir is inside the src git repository.
    
    This might not be the case in general. Not only could a output directory
    exist elsewhere altogether (though this only fixes one issue that breaks
    when you do that), but it could be a symlink or another filesystem; in
    such cases git does not consider it part of the repository.
    
    This can be addressed by explicitly giving the path to src.git when issuing
    git commands.
    
    Change-Id: Ibf62466548e15d6ef57ed1e959d507ff70076352
    Reviewed-on: https://chromium-review.googlesource.com/1131842
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574574}

    Changed files

    • testing/libfuzzer/fuzzer_test.gni
    • testing/libfuzzer/gen_fuzzer_owners.py
  33. [testing] Move context menu ever timestamp test to a separate test

    Changed by Majid Valipour - majidvpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:46:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8696fc59786065ffc8a2e06f2db8f9e9ebc772a1

    Comments

    [testing] Move context menu ever timestamp test to a separate test
    
    ContextMenu interaction with other events is a suspected cause of
    flakiness of the original test. This CL is separating it from the
    rest as a potential fix.
    
    Bug: 846750
    Change-Id: I3d452388be65984ca82238d55a938d7a273fcf3f
    Reviewed-on: https://chromium-review.googlesource.com/1134180
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Commit-Queue: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574573}

    Changed files

    • third_party/WebKit/LayoutTests/fast/events/hr-timestamp/context-menu-event.html
    • third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html
  34. Update viz_content_browsertests filter.

    Changed by kylechar - kylecharohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:43:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e0d4f50a43ad0ec12342ccbd16bf63f571651a7

    Comments

    Update viz_content_browsertests filter.
    
    Undo revert in https://crrev.com/c/1134144 which didn't end up being
    needed. Revert was in response to FindIt and failures in
    SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest but that problem
    had already been addressed.
    
    TBR: jonross@chromium.org
    Bug: 848825, 848348
    Change-Id: Ie00ce45db8b380847dddf4fb099a120ce7ada987
    Reviewed-on: https://chromium-review.googlesource.com/1135146
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574572}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  35. [iOS] New location bar icons and fonts.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:42:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57bfd6b0cba9de19f7dd75558447eba072bf84da

    Comments

    [iOS] New location bar icons and fonts.
    
    Updates the logic to switch between larger and smaller fonts, replaces
    security state and voice/share icons.
    
    Bug: 856542
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iecc5da700dd9b3004e8480abaa842dc6e143bdca
    Reviewed-on: https://chromium-review.googlesource.com/1135128
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574571}

    Changed files

    • ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@3x.png
    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
  36. Import wpt@b7f4f1d1ea5708bfb7578090f19c75dcf21cbef2

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:42:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3b164c24e967409cad5205e6a1ed651615566aa

    Comments

    Import wpt@b7f4f1d1ea5708bfb7578090f19c75dcf21cbef2
    
    Using wpt-import in Chromium d18929b41e24487865c4ed9da46129e6b037beeb.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21188
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    domenic@chromium.org, ricea@chromium.org:
      external/wpt/streams
    jsbell@chromium.org:
      external/wpt/encoding
    kojii@chromium.org:
      external/wpt/css/css-writing-modes
    mlamouri@chromium.org:
      external/wpt/screen-orientation
    
    TBR=foolip
    
    No-Export: true
    Change-Id: Ib04131d32533fd3a6687cc2999f6a0b409f08165
    Reviewed-on: https://chromium-review.googlesource.com/1134875
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574570}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/appmanifest/idlharness.window.js
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-htb-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-010.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-014.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-015.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-016.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-020.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-022.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-023.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-009.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-011.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-013.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-019.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-021.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-024.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-025.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/different-block-flow-dir-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/different-block-flow-dir-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/first-page-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/first-page-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/flexbox_align-items-stretch-writing-modes.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vlr-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vlr-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vrl-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-replaced-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-replaced-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-htb-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-010.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-013.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-014.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-018.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-020.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-009.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-011.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-017.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-019.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/page-flow-direction-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/page-flow-direction-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/replaced-content-image-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/replaced-content-image-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/writing-mode-vertical-rl-003.htm
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-basics.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-invalid-label.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-replacement-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-surrogates-utf8.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.html
    • third_party/WebKit/LayoutTests/external/wpt/encoding/replacement-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-byte-order-marks.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal-single-byte.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal-streaming.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-ignorebom.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-labels.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-streaming.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-utf16-surrogates.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textencoder-constructor-non-utf.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textencoder-utf16-surrogates.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/unsupported-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-button-element/button-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-fieldset-element/fieldset-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-fieldset-element/fieldset-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-input-element/input-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-output-element/output-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-output-element/output-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-select-element/select-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-textarea-element/textarea-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/appmanifest.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/screen-orientation.idl
    • third_party/WebKit/LayoutTests/external/wpt/screen-orientation/idlharness.window.js
    • third_party/WebKit/LayoutTests/external/wpt/screen-orientation/interfaces.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.dedicatedworker.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.js
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.serviceworker.https.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.sharedworker.html
    • third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/appmanifest/idlharness.window-expected.txt
  37. [Sync::Consent] Split ConsentAuditor interface from implementation.

    Changed by vitaliii - vitaliiiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:40:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7782405912e05feca6e0cf3808ab8f3c8ff70f2f

    Comments

    [Sync::Consent] Split ConsentAuditor interface from implementation.
    
    Also rewrite FakeConsentAuditor to implement the interface instead of
    inheriting from the implementation. This unblocks enabling the separate
    datatype feature by default.
    
    Bug: 862186
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I474f74f12278221ef6278c120576f1ff1a224c4a
    Reviewed-on: https://chromium-review.googlesource.com/1131508
    Reviewed-by: Markus Heintz <markusheintz@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574569}

    Changed files

    • chrome/browser/consent_auditor/consent_auditor_factory.cc
    • chrome/browser/consent_auditor/consent_auditor_test_utils.cc
    • components/consent_auditor/BUILD.gn
    • components/consent_auditor/consent_auditor.cc
    • components/consent_auditor/consent_auditor.h
    • components/consent_auditor/consent_auditor_impl.cc
    • components/consent_auditor/consent_auditor_impl.h
    • components/consent_auditor/consent_auditor_impl_unittest.cc
    • components/consent_auditor/fake_consent_auditor.cc
    • components/consent_auditor/fake_consent_auditor.h
    • ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
    • ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm
  38. [content-service] Support basic View embedding

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:36:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99c5bc74636041c26d31f3dae12c7fc51032ce27

    Comments

    [content-service] Support basic View embedding
    
    Adds support for embedding a View object within a client application's
    window tree. Currently Chrome OS only.
    
    Enables a new simple_browser test application to be launched via a
    command-line flag in DCHECK-enabled builds only, for manual developer
    testing. This application runs in a sandboxed utility process and embeds
    a View that can be navigated, displaying web contents within the
    application's UI, backed by a concrete WebContents owned by a Content
    Service instance in the browser process.
    
    Bug: 855092
    Change-Id: I95937f987e87ad303689d73b7e57c836ee706d28
    Test: Launch Chrome OS chrome --enable-features=Mash --launch-simple-browser and verify that you can navigate the cute little browser window that pops up.
    Reviewed-on: https://chromium-review.googlesource.com/1125342
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574568}

    Changed files

    • chrome/app/BUILD.gn
    • chrome/browser/BUILD.gn
    • chrome/browser/DEPS
    • chrome/browser/chrome_browser_main.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/common/BUILD.gn
    • chrome/common/features.gni
    • chrome/utility/BUILD.gn
    • chrome/utility/DEPS
    • chrome/utility/chrome_content_utility_client.cc
    • content/browser/browser_context.cc
    • content/browser/content_service_delegate_impl.cc
    • services/content/BUILD.gn
    • services/content/DEPS
    • services/content/public/cpp/BUILD.gn
    • services/content/public/cpp/DEPS
    • services/content/public/cpp/view.cc
    • services/content/public/cpp/view.h
    • services/content/public/features.gni
    • services/content/public/mojom/BUILD.gn
    • services/content/public/mojom/view.mojom
    • services/content/service_unittest.cc
    • services/content/simple_browser/BUILD.gn
    • services/content/simple_browser/DEPS
    • services/content/simple_browser/OWNERS
    • services/content/simple_browser/README.md
    • services/content/simple_browser/manifest.json
    • services/content/simple_browser/public/mojom/BUILD.gn
    • services/content/simple_browser/public/mojom/OWNERS
    • services/content/simple_browser/public/mojom/constants.mojom
    • services/content/simple_browser/simple_browser_service.cc
    • services/content/simple_browser/simple_browser_service.h
    • services/content/simple_browser/window.cc
    • services/content/simple_browser/window.h
    • services/content/view_delegate.h
    • services/content/view_impl.cc
    • services/content/view_impl.h
    • ui/views/mus/remote_view/BUILD.gn
  39. Fix crash with webRequest and network service when duplicate request IDs are seen.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:25:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4072ab48cadcd3f98481be63bdd59e5c623729d

    Comments

    Fix crash with webRequest and network service when duplicate request IDs are seen.
    
    The cause in this case was SimpleURLLoader always using a request ID of 0. These requests don't go through auth anyways (since there's no tab to associate them with). Gracefully handle this in WebRequestProxyingURLLoaderFactory by not crashing.
    
    Bug: 853118
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I856259f76caf67d7d6c0b8e48535cd56419ead1a
    Reviewed-on: https://chromium-review.googlesource.com/1133692
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574567}

    Changed files

    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
  40. [Background Fetch] Get options and title on initialization.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:21:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3925c59dce4a1a882e581e405c82303fbb99bce0

    Comments

    [Background Fetch] Get options and title on initialization.
    
    Bug: 853058
    Change-Id: Ib5ef98ad0cd988a5ac361b96fa55cebb0e09b800
    Reviewed-on: https://chromium-review.googlesource.com/1128863
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574566}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.h
  41. Erase unused const

    Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:17:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5037e10260cd47b7e6ac92b324d2e111e8970a3

    Comments

    Erase unused const
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I09e9bd22b692fb5d9a79bac0d2e29e3ec01046df
    Reviewed-on: https://chromium-review.googlesource.com/1134992
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574565}

    Changed files

    • ios/chrome/browser/passwords/password_generation_utils.mm
  42. Add Blink.ResourceFetcher.StaleWhileRevalidateDuration histogram.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:15:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 12f1a6d2b078baa8bda6dd3f9b94be9897a12e9f

    Comments

    Add Blink.ResourceFetcher.StaleWhileRevalidateDuration histogram.
    
    This histogram tracks the duration of completed stale revalidation
    attempts. This value will be used as a rough approximation of
    the benefit received by using Stale While Revalidate.
    
    BUG=348877
    
    Change-Id: I47601e667394c401ccdc96afc4d73d6c464faa3b
    Reviewed-on: https://chromium-review.googlesource.com/1133961
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574564}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/stale_revalidation_resource_client.cc
    • third_party/blink/renderer/platform/loader/fetch/stale_revalidation_resource_client.h
    • tools/metrics/histograms/histograms.xml
  43. [chromecast] Fix back gesture behavior.

    Changed by Ryan Daum - rdaumohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:13:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 937dab73796dc72314a70b8825f89484e03881c9

    Comments

    [chromecast] Fix back gesture behavior.
    
    Changes the back gesture behavior to match UX expectations.
    
      - Do not trigger the back gesture until the finger lifts.
      - Make sure progress events never continue after cancel or end.
    
    Bug: internal b/109888887
    Test: manual and unit tests
    Change-Id: I388e078d4ec520e53bfed34dfdaaa378dadf0d0a
    Reviewed-on: https://chromium-review.googlesource.com/1135188
    Commit-Queue: Ryan Daum <rdaum@chromium.org>
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574563}

    Changed files

    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher_test.cc
  44. macviews: use cocoa context menus for web content

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:10:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7a09eb8d51c7e5d4d6ae68b4de0c8d3d9fcbabb

    Comments

    macviews: use cocoa context menus for web content
    
    Bug: 860673
    Change-Id: I459eaf26c3fffb6c87ddbe2b8cd28db15d7cc90f
    Reviewed-on: https://chromium-review.googlesource.com/1134539
    Reviewed-by: Leonard Grey <lgrey@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574562}

    Changed files

    • chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm
  45. Revert "tcmalloc: Move existing tcmalloc files under gperftools-2.0."

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 14:59:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06c7d7e68470ca975c0d10340a89e3e69ebab6ad

    Comments

    Revert "tcmalloc: Move existing tcmalloc files under gperftools-2.0."
    
    This reverts commit 615e0342e44cbe073b1958ab9f5a318d799f6f34.
    
    Reason for revert: breaks compilation with enable_profiling = true
    
    Original change's description:
    > tcmalloc: Move existing tcmalloc files under gperftools-2.0.
    > 
    > Move existing tcmalloc files, both vendor and chromium, under gperftools-2.0
    > in preparation for upreving tcmalloc to the most recent gperftools version.
    > 
    > This CL did:
    > 
    >   # Create a gerftools-2.0 folder.
    >   mkdir gperftools-2.0
    > 
    >   # Move vendor/ and chromium/ under the new folder.
    >   git mv vendor gperftools-2.0/vendor
    >   git mv chromium gperftools-2.0/chromium
    > 
    >   # Update //base/allocator/BUILD.gn to have tcmalloc_dir point to
    >   # //third_party/tcmalloc/gperftools-2.0/chromium/src.
    >   # Update addr2line-pdb sources in tcmalloc/BUILD.gn.
    >   # Update include paths in files under //base/process and //base/allocator.
    > 
    > This is old code that uses currently banned functions.
    > NOPRESUBMIT=true
    > 
    > BUG=724399,b:70905156
    > 
    > Change-Id: I498a6edda48e178bbacfb41e30f75e9e96e336fc
    > Reviewed-on: https://chromium-review.googlesource.com/1130670
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Commit-Queue: Gabriel Marin <gmx@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574346}
    
    TBR=wfh@chromium.org,gmx@chromium.org
    
    Change-Id: Ifdd162a045009444621c6e3052f348919fdafc96
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 724399, b:70905156
    Reviewed-on: https://chromium-review.googlesource.com/1135266
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574561}

    Changed files

    • base/allocator/BUILD.gn
    • base/allocator/allocator_extension.cc
    • base/allocator/allocator_shim_default_dispatch_to_tcmalloc.cc
    • base/allocator/debugallocation_shim.cc
    • base/process/memory_linux.cc
    • third_party/tcmalloc/BUILD.gn
    • third_party/tcmalloc/chromium/src/OWNERS
    • third_party/tcmalloc/chromium/src/addressmap-inl.h
    • third_party/tcmalloc/chromium/src/base/abort.cc
    • third_party/tcmalloc/chromium/src/base/abort.h
    • third_party/tcmalloc/chromium/src/base/arm_instruction_set_select.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-v6plus.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-linuxppc.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-macosx.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-mips.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-windows.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-x86.cc
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-x86.h
    • third_party/tcmalloc/chromium/src/base/atomicops.h
    • third_party/tcmalloc/chromium/src/base/basictypes.h
    • third_party/tcmalloc/chromium/src/base/commandlineflags.h
    • third_party/tcmalloc/chromium/src/base/cycleclock.h
    • third_party/tcmalloc/chromium/src/base/dynamic_annotations.c
    • third_party/tcmalloc/chromium/src/base/dynamic_annotations.h
    • third_party/tcmalloc/chromium/src/base/elf_mem_image.cc
    • third_party/tcmalloc/chromium/src/base/elf_mem_image.h
    • third_party/tcmalloc/chromium/src/base/elfcore.h
    • third_party/tcmalloc/chromium/src/base/googleinit.h
    • third_party/tcmalloc/chromium/src/base/linux_syscall_support.h
    • third_party/tcmalloc/chromium/src/base/linuxthreads.cc
    • third_party/tcmalloc/chromium/src/base/linuxthreads.h
    • third_party/tcmalloc/chromium/src/base/logging.cc
    • third_party/tcmalloc/chromium/src/base/logging.h
    • third_party/tcmalloc/chromium/src/base/low_level_alloc.cc
    • third_party/tcmalloc/chromium/src/base/low_level_alloc.h
    • third_party/tcmalloc/chromium/src/base/simple_mutex.h
    • third_party/tcmalloc/chromium/src/base/spinlock.cc
    • third_party/tcmalloc/chromium/src/base/spinlock.h
    • third_party/tcmalloc/chromium/src/base/spinlock_internal.cc
    • third_party/tcmalloc/chromium/src/base/spinlock_internal.h
    • third_party/tcmalloc/chromium/src/base/spinlock_linux-inl.h
    • third_party/tcmalloc/chromium/src/base/spinlock_posix-inl.h
    • third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h
    • third_party/tcmalloc/chromium/src/base/stl_allocator.h
    • third_party/tcmalloc/chromium/src/base/synchronization_profiling.h
    • third_party/tcmalloc/chromium/src/base/sysinfo.cc
    • third_party/tcmalloc/chromium/src/base/sysinfo.h
    • third_party/tcmalloc/chromium/src/base/thread_annotations.h
    • third_party/tcmalloc/chromium/src/base/thread_lister.c
    • third_party/tcmalloc/chromium/src/base/thread_lister.h
    • third_party/tcmalloc/chromium/src/base/vdso_support.cc
    • third_party/tcmalloc/chromium/src/base/vdso_support.h
    • third_party/tcmalloc/chromium/src/central_freelist.cc
    • third_party/tcmalloc/chromium/src/central_freelist.h
    • third_party/tcmalloc/chromium/src/common.cc
    • third_party/tcmalloc/chromium/src/common.h
    • third_party/tcmalloc/chromium/src/config.h
    • third_party/tcmalloc/chromium/src/config.h.in
    • third_party/tcmalloc/chromium/src/config_android.h
    • third_party/tcmalloc/chromium/src/config_for_unittests.h
    • third_party/tcmalloc/chromium/src/config_freebsd.h
    • third_party/tcmalloc/chromium/src/config_linux.h
    • third_party/tcmalloc/chromium/src/config_win.h
    • third_party/tcmalloc/chromium/src/debugallocation.cc
    • third_party/tcmalloc/chromium/src/free_list.cc
    • third_party/tcmalloc/chromium/src/free_list.h
    • third_party/tcmalloc/chromium/src/getpc.h
    • third_party/tcmalloc/chromium/src/google/heap-checker.h
    • third_party/tcmalloc/chromium/src/google/heap-profiler.h
    • third_party/tcmalloc/chromium/src/google/malloc_extension.h
    • third_party/tcmalloc/chromium/src/google/malloc_extension_c.h
    • third_party/tcmalloc/chromium/src/google/malloc_hook.h
    • third_party/tcmalloc/chromium/src/google/malloc_hook_c.h
    • third_party/tcmalloc/chromium/src/google/profiler.h
    • third_party/tcmalloc/chromium/src/google/stacktrace.h
    • third_party/tcmalloc/chromium/src/google/tcmalloc.h
    • third_party/tcmalloc/chromium/src/gperftools/heap-checker.h
    • third_party/tcmalloc/chromium/src/gperftools/heap-profiler.h
    • third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h
    • third_party/tcmalloc/chromium/src/gperftools/malloc_extension_c.h
    • third_party/tcmalloc/chromium/src/gperftools/malloc_hook.h
    • third_party/tcmalloc/chromium/src/gperftools/malloc_hook_c.h
    • third_party/tcmalloc/chromium/src/gperftools/profiler.h
    • third_party/tcmalloc/chromium/src/gperftools/stacktrace.h
    • third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h
    • third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/chromium/src/heap-checker-bcad.cc
    • third_party/tcmalloc/chromium/src/heap-checker.cc
    • third_party/tcmalloc/chromium/src/heap-profile-stats.h
    • third_party/tcmalloc/chromium/src/heap-profile-table.cc
    • third_party/tcmalloc/chromium/src/heap-profile-table.h
    • third_party/tcmalloc/chromium/src/heap-profiler.cc
    • third_party/tcmalloc/chromium/src/internal_logging.cc
    • third_party/tcmalloc/chromium/src/internal_logging.h
    • third_party/tcmalloc/chromium/src/libc_override.h
    • third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
    • third_party/tcmalloc/chromium/src/libc_override_glibc.h
    • third_party/tcmalloc/chromium/src/libc_override_osx.h
    • third_party/tcmalloc/chromium/src/libc_override_redefine.h
    • third_party/tcmalloc/chromium/src/linked_list.h
    • third_party/tcmalloc/chromium/src/linux_shadow_stacks.cc
    • third_party/tcmalloc/chromium/src/linux_shadow_stacks.h
    • third_party/tcmalloc/chromium/src/malloc_extension.cc
    • third_party/tcmalloc/chromium/src/malloc_hook-inl.h
    • third_party/tcmalloc/chromium/src/malloc_hook.cc
    • third_party/tcmalloc/chromium/src/malloc_hook_mmap_freebsd.h
    • third_party/tcmalloc/chromium/src/malloc_hook_mmap_linux.h
    • third_party/tcmalloc/chromium/src/maybe_threads.cc
    • third_party/tcmalloc/chromium/src/maybe_threads.h
    • third_party/tcmalloc/chromium/src/memfs_malloc.cc
    • third_party/tcmalloc/chromium/src/memory_region_map.cc
    • third_party/tcmalloc/chromium/src/memory_region_map.h
    • third_party/tcmalloc/chromium/src/packed-cache-inl.h
    • third_party/tcmalloc/chromium/src/page_heap.cc
    • third_party/tcmalloc/chromium/src/page_heap.h
    • third_party/tcmalloc/chromium/src/page_heap_allocator.h
    • third_party/tcmalloc/chromium/src/pagemap.h
    • third_party/tcmalloc/chromium/src/pprof
    • third_party/tcmalloc/chromium/src/profile-handler.cc
    • third_party/tcmalloc/chromium/src/profile-handler.h
    • third_party/tcmalloc/chromium/src/profiledata.cc
    • third_party/tcmalloc/chromium/src/profiledata.h
    • third_party/tcmalloc/chromium/src/profiler.cc
    • third_party/tcmalloc/chromium/src/raw_printer.cc
    • third_party/tcmalloc/chromium/src/raw_printer.h
    • third_party/tcmalloc/chromium/src/sampler.cc
    • third_party/tcmalloc/chromium/src/sampler.h
    • third_party/tcmalloc/chromium/src/solaris/libstdc++.la
    • third_party/tcmalloc/chromium/src/span.cc
    • third_party/tcmalloc/chromium/src/span.h
    • third_party/tcmalloc/chromium/src/stack_trace_table.cc
    • third_party/tcmalloc/chromium/src/stack_trace_table.h
    • third_party/tcmalloc/chromium/src/stacktrace.cc
    • third_party/tcmalloc/chromium/src/stacktrace_android-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_arm-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_config.h
    • third_party/tcmalloc/chromium/src/stacktrace_generic-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_libunwind-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_mips-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_powerpc-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_win32-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_with_context.cc
    • third_party/tcmalloc/chromium/src/stacktrace_x86-inl.h
    • third_party/tcmalloc/chromium/src/static_vars.cc
    • third_party/tcmalloc/chromium/src/static_vars.h
    • third_party/tcmalloc/chromium/src/symbolize.cc
    • third_party/tcmalloc/chromium/src/symbolize.h
    • third_party/tcmalloc/chromium/src/system-alloc.cc
    • third_party/tcmalloc/chromium/src/system-alloc.h
    • third_party/tcmalloc/chromium/src/tcmalloc.cc
    • third_party/tcmalloc/chromium/src/tcmalloc.h
    • third_party/tcmalloc/chromium/src/tcmalloc_guard.h
    • third_party/tcmalloc/chromium/src/tests/addressmap_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/atomicops_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/current_allocated_bytes_test.cc
    • third_party/tcmalloc/chromium/src/tests/debugallocation_test.cc
    • third_party/tcmalloc/chromium/src/tests/debugallocation_test.sh
    • third_party/tcmalloc/chromium/src/tests/frag_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/getpc_test.cc
    • third_party/tcmalloc/chromium/src/tests/heap-checker-death_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/heap-checker_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/heap-checker_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/heap-profiler_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/heap-profiler_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/low_level_alloc_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/malloc_extension_c_test.c
    • third_party/tcmalloc/chromium/src/tests/malloc_extension_test.cc
    • third_party/tcmalloc/chromium/src/tests/malloc_hook_test.cc
    • third_party/tcmalloc/chromium/src/tests/markidle_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/maybe_threads_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/memalign_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/packed-cache_test.cc
    • third_party/tcmalloc/chromium/src/tests/page_heap_test.cc
    • third_party/tcmalloc/chromium/src/tests/pagemap_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/profile-handler_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/profiledata_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/profiler_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/profiler_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/raw_printer_test.cc
    • third_party/tcmalloc/chromium/src/tests/realloc_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/sampler_test.cc
    • third_party/tcmalloc/chromium/src/tests/sampling_test.cc
    • third_party/tcmalloc/chromium/src/tests/sampling_test.sh
    • third_party/tcmalloc/chromium/src/tests/simple_compat_test.cc
    • third_party/tcmalloc/chromium/src/tests/stack_trace_table_test.cc
    • third_party/tcmalloc/chromium/src/tests/stacktrace_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/system-alloc_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/tcmalloc_large_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/tcmalloc_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/testutil.cc
    • third_party/tcmalloc/chromium/src/tests/testutil.h
    • third_party/tcmalloc/chromium/src/tests/thread_dealloc_unittest.cc
    • third_party/tcmalloc/chromium/src/thread_cache.cc
    • third_party/tcmalloc/chromium/src/thread_cache.h
    • third_party/tcmalloc/chromium/src/windows/TODO
    • third_party/tcmalloc/chromium/src/windows/addr2line-pdb.c
    • third_party/tcmalloc/chromium/src/windows/auto_testing_hook.h
    • third_party/tcmalloc/chromium/src/windows/config.h
    • third_party/tcmalloc/chromium/src/windows/get_mangled_names.cc
    • third_party/tcmalloc/chromium/src/windows/google/tcmalloc.h
    • third_party/tcmalloc/chromium/src/windows/gperftools/tcmalloc.h
    • third_party/tcmalloc/chromium/src/windows/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/chromium/src/windows/ia32_modrm_map.cc
    • third_party/tcmalloc/chromium/src/windows/ia32_opcode_map.cc
    • third_party/tcmalloc/chromium/src/windows/mingw.h
    • third_party/tcmalloc/chromium/src/windows/mini_disassembler.cc
    • third_party/tcmalloc/chromium/src/windows/mini_disassembler.h
    • third_party/tcmalloc/chromium/src/windows/mini_disassembler_types.h
    • third_party/tcmalloc/chromium/src/windows/nm-pdb.c
    • third_party/tcmalloc/chromium/src/windows/override_functions.cc
    • third_party/tcmalloc/chromium/src/windows/patch_functions.cc
    • third_party/tcmalloc/chromium/src/windows/port.cc
    • third_party/tcmalloc/chromium/src/windows/port.h
    • third_party/tcmalloc/chromium/src/windows/preamble_patcher.cc
    • third_party/tcmalloc/chromium/src/windows/preamble_patcher.h
    • third_party/tcmalloc/chromium/src/windows/preamble_patcher_test.cc
    • third_party/tcmalloc/chromium/src/windows/preamble_patcher_with_stub.cc
    • third_party/tcmalloc/chromium/src/windows/shortproc.asm
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config.h
    • third_party/tcmalloc/vendor/AUTHORS
    • third_party/tcmalloc/vendor/COPYING
    • third_party/tcmalloc/vendor/ChangeLog
    • third_party/tcmalloc/vendor/INSTALL
    • third_party/tcmalloc/vendor/Makefile.am
    • third_party/tcmalloc/vendor/Makefile.in
    • third_party/tcmalloc/vendor/NEWS
    • third_party/tcmalloc/vendor/README
    • third_party/tcmalloc/vendor/README_windows.txt
    • third_party/tcmalloc/vendor/TODO
    • third_party/tcmalloc/vendor/aclocal.m4
    • third_party/tcmalloc/vendor/autogen.sh
    • third_party/tcmalloc/vendor/compile
    • third_party/tcmalloc/vendor/config.guess
    • third_party/tcmalloc/vendor/config.sub
    • third_party/tcmalloc/vendor/configure
    • third_party/tcmalloc/vendor/configure.ac
    • third_party/tcmalloc/vendor/depcomp
    • third_party/tcmalloc/vendor/doc/cpuprofile-fileformat.html
    • third_party/tcmalloc/vendor/doc/cpuprofile.html
    • third_party/tcmalloc/vendor/doc/designstyle.css
    • third_party/tcmalloc/vendor/doc/heap-example1.png
    • third_party/tcmalloc/vendor/doc/heap_checker.html
    • third_party/tcmalloc/vendor/doc/heapprofile.html
    • third_party/tcmalloc/vendor/doc/index.html
    • third_party/tcmalloc/vendor/doc/overview.dot
    • third_party/tcmalloc/vendor/doc/overview.gif
    • third_party/tcmalloc/vendor/doc/pageheap.dot
    • third_party/tcmalloc/vendor/doc/pageheap.gif
    • third_party/tcmalloc/vendor/doc/pprof-test-big.gif
    • third_party/tcmalloc/vendor/doc/pprof-test.gif
    • third_party/tcmalloc/vendor/doc/pprof-vsnprintf-big.gif
    • third_party/tcmalloc/vendor/doc/pprof-vsnprintf.gif
    • third_party/tcmalloc/vendor/doc/pprof.1
    • third_party/tcmalloc/vendor/doc/pprof.see_also
    • third_party/tcmalloc/vendor/doc/pprof_remote_servers.html
    • third_party/tcmalloc/vendor/doc/spanmap.dot
    • third_party/tcmalloc/vendor/doc/spanmap.gif
    • third_party/tcmalloc/vendor/doc/t-test1.times.txt
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.1024.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.128.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.131072.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.16384.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.2048.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.256.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.32768.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.4096.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.512.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.64.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.65536.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.8192.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.1.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.12.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.16.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.2.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.20.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.3.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.4.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.5.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.8.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc.html
    • third_party/tcmalloc/vendor/doc/threadheap.dot
    • third_party/tcmalloc/vendor/doc/threadheap.gif
    • third_party/tcmalloc/vendor/install-sh
    • third_party/tcmalloc/vendor/ltmain.sh
    • third_party/tcmalloc/vendor/m4/ac_have_attribute.m4
    • third_party/tcmalloc/vendor/m4/acx_nanosleep.m4
    • third_party/tcmalloc/vendor/m4/acx_pthread.m4
    • third_party/tcmalloc/vendor/m4/compiler_characteristics.m4
    • third_party/tcmalloc/vendor/m4/install_prefix.m4
    • third_party/tcmalloc/vendor/m4/libtool.m4
    • third_party/tcmalloc/vendor/m4/ltoptions.m4
    • third_party/tcmalloc/vendor/m4/ltsugar.m4
    • third_party/tcmalloc/vendor/m4/ltversion.m4
    • third_party/tcmalloc/vendor/m4/lt~obsolete.m4
    • third_party/tcmalloc/vendor/m4/namespaces.m4
    • third_party/tcmalloc/vendor/m4/pc_from_ucontext.m4
    • third_party/tcmalloc/vendor/m4/program_invocation_name.m4
    • third_party/tcmalloc/vendor/m4/stl_namespace.m4
    • third_party/tcmalloc/vendor/missing
    • third_party/tcmalloc/vendor/mkinstalldirs
    • third_party/tcmalloc/vendor/packages/deb.sh
    • third_party/tcmalloc/vendor/packages/deb/README
    • third_party/tcmalloc/vendor/packages/deb/changelog
    • third_party/tcmalloc/vendor/packages/deb/compat
    • third_party/tcmalloc/vendor/packages/deb/control
    • third_party/tcmalloc/vendor/packages/deb/copyright
    • third_party/tcmalloc/vendor/packages/deb/docs
    • third_party/tcmalloc/vendor/packages/deb/libgperftools-dev.dirs
    • third_party/tcmalloc/vendor/packages/deb/libgperftools-dev.install
    • third_party/tcmalloc/vendor/packages/deb/libgperftools0.dirs
    • third_party/tcmalloc/vendor/packages/deb/libgperftools0.install
    • third_party/tcmalloc/vendor/packages/deb/libgperftools0.manpages
    • third_party/tcmalloc/vendor/packages/deb/rules
    • third_party/tcmalloc/vendor/packages/rpm.sh
    • third_party/tcmalloc/vendor/packages/rpm/rpm.spec
    • third_party/tcmalloc/vendor/src/addressmap-inl.h
    • third_party/tcmalloc/vendor/src/base/arm_instruction_set_select.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-arm-generic.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-arm-v6plus.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-linuxppc.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-macosx.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-windows.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-x86.cc
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-x86.h
    • third_party/tcmalloc/vendor/src/base/atomicops.h
    • third_party/tcmalloc/vendor/src/base/basictypes.h
    • third_party/tcmalloc/vendor/src/base/commandlineflags.h
    • third_party/tcmalloc/vendor/src/base/cycleclock.h
    • third_party/tcmalloc/vendor/src/base/dynamic_annotations.c
    • third_party/tcmalloc/vendor/src/base/dynamic_annotations.h
    • third_party/tcmalloc/vendor/src/base/elf_mem_image.cc
    • third_party/tcmalloc/vendor/src/base/elf_mem_image.h
    • third_party/tcmalloc/vendor/src/base/elfcore.h
    • third_party/tcmalloc/vendor/src/base/googleinit.h
    • third_party/tcmalloc/vendor/src/base/linux_syscall_support.h
    • third_party/tcmalloc/vendor/src/base/linuxthreads.cc
    • third_party/tcmalloc/vendor/src/base/linuxthreads.h
    • third_party/tcmalloc/vendor/src/base/logging.cc
    • third_party/tcmalloc/vendor/src/base/logging.h
    • third_party/tcmalloc/vendor/src/base/low_level_alloc.cc
    • third_party/tcmalloc/vendor/src/base/low_level_alloc.h
    • third_party/tcmalloc/vendor/src/base/simple_mutex.h
    • third_party/tcmalloc/vendor/src/base/spinlock.cc
    • third_party/tcmalloc/vendor/src/base/spinlock.h
    • third_party/tcmalloc/vendor/src/base/spinlock_internal.cc
    • third_party/tcmalloc/vendor/src/base/spinlock_internal.h
    • third_party/tcmalloc/vendor/src/base/spinlock_linux-inl.h
    • third_party/tcmalloc/vendor/src/base/spinlock_posix-inl.h
    • third_party/tcmalloc/vendor/src/base/spinlock_win32-inl.h
    • third_party/tcmalloc/vendor/src/base/stl_allocator.h
    • third_party/tcmalloc/vendor/src/base/synchronization_profiling.h
    • third_party/tcmalloc/vendor/src/base/sysinfo.cc
    • third_party/tcmalloc/vendor/src/base/sysinfo.h
    • third_party/tcmalloc/vendor/src/base/thread_annotations.h
    • third_party/tcmalloc/vendor/src/base/thread_lister.c
    • third_party/tcmalloc/vendor/src/base/thread_lister.h
    • third_party/tcmalloc/vendor/src/base/vdso_support.cc
    • third_party/tcmalloc/vendor/src/base/vdso_support.h
    • third_party/tcmalloc/vendor/src/central_freelist.cc
    • third_party/tcmalloc/vendor/src/central_freelist.h
    • third_party/tcmalloc/vendor/src/common.cc
    • third_party/tcmalloc/vendor/src/common.h
    • third_party/tcmalloc/vendor/src/config.h.in
    • third_party/tcmalloc/vendor/src/config_for_unittests.h
    • third_party/tcmalloc/vendor/src/debugallocation.cc
    • third_party/tcmalloc/vendor/src/getpc.h
    • third_party/tcmalloc/vendor/src/google/heap-checker.h
    • third_party/tcmalloc/vendor/src/google/heap-profiler.h
    • third_party/tcmalloc/vendor/src/google/malloc_extension.h
    • third_party/tcmalloc/vendor/src/google/malloc_extension_c.h
    • third_party/tcmalloc/vendor/src/google/malloc_hook.h
    • third_party/tcmalloc/vendor/src/google/malloc_hook_c.h
    • third_party/tcmalloc/vendor/src/google/profiler.h
    • third_party/tcmalloc/vendor/src/google/stacktrace.h
    • third_party/tcmalloc/vendor/src/google/tcmalloc.h
    • third_party/tcmalloc/vendor/src/gperftools/heap-checker.h
    • third_party/tcmalloc/vendor/src/gperftools/heap-profiler.h
    • third_party/tcmalloc/vendor/src/gperftools/malloc_extension.h
    • third_party/tcmalloc/vendor/src/gperftools/malloc_extension_c.h
    • third_party/tcmalloc/vendor/src/gperftools/malloc_hook.h
    • third_party/tcmalloc/vendor/src/gperftools/malloc_hook_c.h
    • third_party/tcmalloc/vendor/src/gperftools/profiler.h
    • third_party/tcmalloc/vendor/src/gperftools/stacktrace.h
    • third_party/tcmalloc/vendor/src/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/vendor/src/heap-checker-bcad.cc
    • third_party/tcmalloc/vendor/src/heap-checker.cc
    • third_party/tcmalloc/vendor/src/heap-profile-table.cc
    • third_party/tcmalloc/vendor/src/heap-profile-table.h
    • third_party/tcmalloc/vendor/src/heap-profiler.cc
    • third_party/tcmalloc/vendor/src/internal_logging.cc
    • third_party/tcmalloc/vendor/src/internal_logging.h
    • third_party/tcmalloc/vendor/src/libc_override.h
    • third_party/tcmalloc/vendor/src/libc_override_gcc_and_weak.h
    • third_party/tcmalloc/vendor/src/libc_override_glibc.h
    • third_party/tcmalloc/vendor/src/libc_override_osx.h
    • third_party/tcmalloc/vendor/src/libc_override_redefine.h
    • third_party/tcmalloc/vendor/src/linked_list.h
    • third_party/tcmalloc/vendor/src/malloc_extension.cc
    • third_party/tcmalloc/vendor/src/malloc_hook-inl.h
    • third_party/tcmalloc/vendor/src/malloc_hook.cc
    • third_party/tcmalloc/vendor/src/malloc_hook_mmap_freebsd.h
    • third_party/tcmalloc/vendor/src/malloc_hook_mmap_linux.h
    • third_party/tcmalloc/vendor/src/maybe_threads.cc
    • third_party/tcmalloc/vendor/src/maybe_threads.h
    • third_party/tcmalloc/vendor/src/memfs_malloc.cc
    • third_party/tcmalloc/vendor/src/memory_region_map.cc
    • third_party/tcmalloc/vendor/src/memory_region_map.h
    • third_party/tcmalloc/vendor/src/packed-cache-inl.h
    • third_party/tcmalloc/vendor/src/page_heap.cc
    • third_party/tcmalloc/vendor/src/page_heap.h
    • third_party/tcmalloc/vendor/src/page_heap_allocator.h
    • third_party/tcmalloc/vendor/src/pagemap.h
    • third_party/tcmalloc/vendor/src/pprof
    • third_party/tcmalloc/vendor/src/profile-handler.cc
    • third_party/tcmalloc/vendor/src/profile-handler.h
    • third_party/tcmalloc/vendor/src/profiledata.cc
    • third_party/tcmalloc/vendor/src/profiledata.h
    • third_party/tcmalloc/vendor/src/profiler.cc
    • third_party/tcmalloc/vendor/src/raw_printer.cc
    • third_party/tcmalloc/vendor/src/raw_printer.h
    • third_party/tcmalloc/vendor/src/sampler.cc
    • third_party/tcmalloc/vendor/src/sampler.h
    • third_party/tcmalloc/vendor/src/solaris/libstdc++.la
    • third_party/tcmalloc/vendor/src/span.cc
    • third_party/tcmalloc/vendor/src/span.h
    • third_party/tcmalloc/vendor/src/stack_trace_table.cc
    • third_party/tcmalloc/vendor/src/stack_trace_table.h
    • third_party/tcmalloc/vendor/src/stacktrace.cc
    • third_party/tcmalloc/vendor/src/stacktrace_arm-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_config.h
    • third_party/tcmalloc/vendor/src/stacktrace_generic-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_libunwind-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_powerpc-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_win32-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_x86-inl.h
    • third_party/tcmalloc/vendor/src/static_vars.cc
    • third_party/tcmalloc/vendor/src/static_vars.h
    • third_party/tcmalloc/vendor/src/symbolize.cc
    • third_party/tcmalloc/vendor/src/symbolize.h
    • third_party/tcmalloc/vendor/src/system-alloc.cc
    • third_party/tcmalloc/vendor/src/system-alloc.h
    • third_party/tcmalloc/vendor/src/tcmalloc.cc
    • third_party/tcmalloc/vendor/src/tcmalloc.h
    • third_party/tcmalloc/vendor/src/tcmalloc_guard.h
    • third_party/tcmalloc/vendor/src/tests/addressmap_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/atomicops_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/current_allocated_bytes_test.cc
    • third_party/tcmalloc/vendor/src/tests/debugallocation_test.cc
    • third_party/tcmalloc/vendor/src/tests/debugallocation_test.sh
    • third_party/tcmalloc/vendor/src/tests/frag_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/getpc_test.cc
    • third_party/tcmalloc/vendor/src/tests/heap-checker-death_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/heap-checker_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/heap-checker_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/heap-profiler_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/heap-profiler_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/low_level_alloc_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/malloc_extension_c_test.c
    • third_party/tcmalloc/vendor/src/tests/malloc_extension_test.cc
    • third_party/tcmalloc/vendor/src/tests/malloc_hook_test.cc
    • third_party/tcmalloc/vendor/src/tests/markidle_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/maybe_threads_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/memalign_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/packed-cache_test.cc
    • third_party/tcmalloc/vendor/src/tests/page_heap_test.cc
    • third_party/tcmalloc/vendor/src/tests/pagemap_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/profile-handler_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/profiledata_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/profiler_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/profiler_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/raw_printer_test.cc
    • third_party/tcmalloc/vendor/src/tests/realloc_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/sampler_test.cc
    • third_party/tcmalloc/vendor/src/tests/sampling_test.cc
    • third_party/tcmalloc/vendor/src/tests/sampling_test.sh
    • third_party/tcmalloc/vendor/src/tests/simple_compat_test.cc
    • third_party/tcmalloc/vendor/src/tests/stack_trace_table_test.cc
    • third_party/tcmalloc/vendor/src/tests/stacktrace_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/system-alloc_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/tcmalloc_large_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/tcmalloc_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/testutil.cc
    • third_party/tcmalloc/vendor/src/tests/testutil.h
    • third_party/tcmalloc/vendor/src/tests/thread_dealloc_unittest.cc
    • third_party/tcmalloc/vendor/src/third_party/valgrind.h
    • third_party/tcmalloc/vendor/src/thread_cache.cc
    • third_party/tcmalloc/vendor/src/thread_cache.h
    • third_party/tcmalloc/vendor/src/windows/TODO
    • third_party/tcmalloc/vendor/src/windows/addr2line-pdb.c
    • third_party/tcmalloc/vendor/src/windows/auto_testing_hook.h
    • third_party/tcmalloc/vendor/src/windows/config.h
    • third_party/tcmalloc/vendor/src/windows/get_mangled_names.cc
    • third_party/tcmalloc/vendor/src/windows/google/tcmalloc.h
    • third_party/tcmalloc/vendor/src/windows/gperftools/tcmalloc.h
    • third_party/tcmalloc/vendor/src/windows/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/vendor/src/windows/ia32_modrm_map.cc
    • third_party/tcmalloc/vendor/src/windows/ia32_opcode_map.cc
    • third_party/tcmalloc/vendor/src/windows/mingw.h
    • third_party/tcmalloc/vendor/src/windows/mini_disassembler.cc
    • third_party/tcmalloc/vendor/src/windows/mini_disassembler.h
    • third_party/tcmalloc/vendor/src/windows/mini_disassembler_types.h
    • third_party/tcmalloc/vendor/src/windows/nm-pdb.c
    • third_party/tcmalloc/vendor/src/windows/override_functions.cc
    • third_party/tcmalloc/vendor/src/windows/patch_functions.cc
    • third_party/tcmalloc/vendor/src/windows/port.cc
    • third_party/tcmalloc/vendor/src/windows/port.h
    • third_party/tcmalloc/vendor/src/windows/preamble_patcher.cc
    • third_party/tcmalloc/vendor/src/windows/preamble_patcher.h
    • third_party/tcmalloc/vendor/src/windows/preamble_patcher_test.cc
    • third_party/tcmalloc/vendor/src/windows/preamble_patcher_with_stub.cc
    • third_party/tcmalloc/vendor/src/windows/shortproc.asm
    • third_party/tcmalloc/vendor/vsprojects/addr2line-pdb/addr2line-pdb.vcproj
    • third_party/tcmalloc/vendor/vsprojects/addressmap_unittest/addressmap_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/frag_unittest/frag_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/libtcmalloc_minimal/libtcmalloc_minimal.vcproj
    • third_party/tcmalloc/vendor/vsprojects/low_level_alloc_unittest/low_level_alloc_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/malloc_extension_test/malloc_extension_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/markidle_unittest/markidle_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/nm-pdb/nm-pdb.vcproj
    • third_party/tcmalloc/vendor/vsprojects/packed-cache_test/packed-cache_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/page_heap_test/page_heap_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/pagemap_unittest/pagemap_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/realloc_unittest/realloc_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/sampler_test/sampler_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/stack_trace_table_test/stack_trace_table_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/tcmalloc_minimal_large/tcmalloc_minimal_large_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/tcmalloc_minimal_unittest/tcmalloc_minimal_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/thread_dealloc_unittest/thread_dealloc_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/tmu-static/tmu-static.vcproj
  46. Fix format string without passing in the variables in code

    Changed by Amos Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Thursday, 12-Jul-18 14:58:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68c461c15c28ffe895f01e0f9a106564b10c5101

    Comments

    Fix format string without passing in the variables in code
    
    Fix 'OrphanedFormatString' and upgrade it to errorprone error
    to prevent future regressions.
    
    Bug: 834796
    Change-Id: Iff82021736367190cfd45b64ee7134cb40392449
    Reviewed-on: https://chromium-review.googlesource.com/1134828
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#574560}

    Changed files

    • base/test/android/javatests/src/org/chromium/base/test/params/ParameterizedRunner.java
    • build/android/gyp/javac.py
  47. DOMParser changed to accept StringOrTrustedHTML arguments

    Changed by Orsi Batiz - orsibatizohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 14:40:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec900e71940eb3c8ef19f064e7e3e57967818731

    Comments

    DOMParser changed to accept StringOrTrustedHTML arguments
    
    Previously existing constructor made private and its name is now parseFromStringInternal
    parseFromString wraps parseFromStringInternal
    
    Bug: 739170
    Change-Id: I3c4dd3aae13bb478ed054d328c77aa2d4ea5d3ef
    Reviewed-on: https://chromium-review.googlesource.com/1128970
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
    Cr-Commit-Position: refs/heads/master@{#574559}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser-requiresTrustedTypes.tentative.html
    • third_party/WebKit/LayoutTests/external/wpt/trusted-types/DOMParser.tentative.html
    • third_party/blink/renderer/core/xml/dom_parser.cc
    • third_party/blink/renderer/core/xml/dom_parser.h
    • third_party/blink/renderer/core/xml/dom_parser.idl
  48. [MessageLoop] Fix flaky death-on-destruction test

    Changed by Gabriel Charette - gabohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 14:40:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa9ef2b1e549c225a401873e66295bb7afdd51ee

    Comments

    [MessageLoop] Fix flaky death-on-destruction test
    
    gtest complains about the multi-threadedness of these tests not being
    supported in POSIX death tests. The multi-threadedness is caused by
    the WITH_TASK_SCHEDULER test variant which is unnecessary to test this.
    Hence, detaching the test from the fixture and testing independently
    will fix the flake I think.
    
    R=danakj@chromium.org
    
    Bug: 860733
    Change-Id: I0972e3c65614145825b8b40d5bb2fa9ccea9108b
    Reviewed-on: https://chromium-review.googlesource.com/1134346
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574558}

    Changed files

    • base/message_loop/message_loop_unittest.cc
  49. [Unity][Android] Increase char limit for 'Sync and Google services'

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 14:33:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f261109a91970ace70f10388bf8a39acb9977d4b

    Comments

    [Unity][Android] Increase char limit for 'Sync and Google services'
    
    This CL increases the char limit for 'Sync and Google services'
    translations to 40 characters. It also enables text wrapping for
    preference title that uses this string.
    
    Bug: 814728
    Change-Id: If1b2c3bb9d83a01a2fa13ddd38d39323dc94e689
    Reviewed-on: https://chromium-review.googlesource.com/1131126
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574557}

    Changed files

    • chrome/android/java/res/xml/main_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  50. Roll src/third_party/pdfium 5ff09fb5ee90..6aa2190f70a8 (1 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 14:29:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df1df391ec8f9534d21219ea753c260c4357588b

    Comments

    Roll src/third_party/pdfium 5ff09fb5ee90..6aa2190f70a8 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/5ff09fb5ee90..6aa2190f70a8
    
    
    git log 5ff09fb5ee90..6aa2190f70a8 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 thestig@chromium.org Use JSGetObject() in even more places.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@6aa2190f70a8
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:862059
    TBR=dsinclair@chromium.org
    
    Change-Id: I1f8681742658f04204fb7df938c0667e814d84c6
    Reviewed-on: https://chromium-review.googlesource.com/1134951
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574556}

    Changed files

    • DEPS
  51. Adds favicon for supersize UI

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 14:25:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a

    Comments

    Adds favicon for supersize UI
    
    Creates a simple icon by taking the pie chart icon and giving it colors
    from the Chromium logo.
    (https://material.io/tools/icons/?search=pie_chart&icon=pie_chart)
    
    Icon:
    https://notwoods.github.io/chrome-supersize-reports/icon.png
    
    Bug: 847599
    Change-Id: Ib711bf0c717b9339914ec4ba2d9f369b33fb84d7
    Reviewed-on: https://chromium-review.googlesource.com/1134195
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Cr-Commit-Position: refs/heads/master@{#574555}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/favicon.ico
    • tools/binary_size/libsupersize/template_tree_view/index.html
  52. Roll src/third_party/skia 4d6a844365e7..56a426a516d0 (2 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 14:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84a2e1ca7620207a3183a275d73d247035d4c078

    Comments

    Roll src/third_party/skia 4d6a844365e7..56a426a516d0 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/4d6a844365e7..56a426a516d0
    
    
    git log 4d6a844365e7..56a426a516d0 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5598148b7613..c9c259cccb2e (1 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/skia@56a426a516d0
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Iae08a82a8704081e534320f9183df4acbccb30d5
    Reviewed-on: https://chromium-review.googlesource.com/1134950
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574554}

    Changed files

    • DEPS
  53. Store multiple NavigationRequests in RenderFrameHost

    Changed by clamy - clamyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:52:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3bfdb09875f6b6cdadd5075d7c1f7305b5118ec

    Comments

    Store multiple NavigationRequests in RenderFrameHost
    
    This CL makes it so that RenderFrameHost can store several
    NavigationRequests waiting to commit instead of just one. This avoids
    deleting a NavigationRequest that would later commit (which can happen
    in quick navigations with a renderer process that is slow to process the
    commit).
    
    The regression test was originally written by arthursonzogni@chromium.org in
    https://chromium-review.googlesource.com/c/chromium/src/+/671351.
    
    The background for this change can be found in the following design doc:
    https://docs.google.com/document/d/1mXjxYJptb_bZ_EqGMF-c4LTSnhjt6Gn_WVvSrsinpq8/edit#.
    
    Bug: 738177
    Change-Id: Idd666e41bd2094c90fa576c77cdc26fb7b54cd7f
    Reviewed-on: https://chromium-review.googlesource.com/1082440
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574553}

    Changed files

    • content/browser/browser_side_navigation_browsertest.cc
    • content/browser/frame_host/navigation_controller_impl_browsertest.cc
    • content/browser/frame_host/navigation_controller_impl_unittest.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigator_impl_unittest.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
    • content/browser/frame_host/render_frame_host_manager.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_browsertest.cc
    • content/browser/security_exploit_browsertest.cc
    • content/browser/site_per_process_browsertest.cc
    • content/browser/web_contents/web_contents_impl_unittest.cc
    • content/browser/webauth/webauth_browsertest.cc
    • content/public/test/browser_test_utils.cc
    • content/public/test/navigation_simulator.cc
    • content/public/test/test_renderer_host.cc
    • content/test/data/infinite_load_1.html
    • content/test/data/infinite_load_2.html
    • content/test/did_commit_provisional_load_interceptor.cc
    • content/test/did_commit_provisional_load_interceptor.h
    • content/test/test_render_frame_host.cc
    • content/test/test_render_frame_host.h
    • content/test/test_web_contents.cc
  54. [bluetooth] Move Map of Characteristics in Gatt Service

    Changed by Jan Wilken Doerrie - jdoerrieohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:43:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efd642e61e6933f8e78a607f02b2478652547e92

    Comments

    [bluetooth] Move Map of Characteristics in Gatt Service
    
    This change cleans up BluetoothRemoteGattService and its implementations
    by moving the map of characteristics into the base class. This allows
    for less code duplication and a simplified interface. Furthermore, a
    AddCharacterisitic helper method is introduced.
    
    Bug: 821766
    Change-Id: Ib370c599f1c8519d497a379c976c89c48d7ecb56
    Reviewed-on: https://chromium-review.googlesource.com/1131178
    Commit-Queue: Jan Wilken D├Ârrie <jdoerrie@chromium.org>
    Reviewed-by: Giovanni Ortu├▒o Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574552}

    Changed files

    • content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
    • device/bluetooth/bluetooth_remote_gatt_characteristic.h
    • device/bluetooth/bluetooth_remote_gatt_service.cc
    • device/bluetooth/bluetooth_remote_gatt_service.h
    • device/bluetooth/bluetooth_remote_gatt_service_android.cc
    • device/bluetooth/bluetooth_remote_gatt_service_android.h
    • device/bluetooth/bluetooth_remote_gatt_service_mac.h
    • device/bluetooth/bluetooth_remote_gatt_service_mac.mm
    • device/bluetooth/bluetooth_remote_gatt_service_win.cc
    • device/bluetooth/bluetooth_remote_gatt_service_win.h
    • device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
    • device/bluetooth/bluetooth_remote_gatt_service_winrt.h
    • device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc
    • device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h
    • device/bluetooth/cast/bluetooth_remote_gatt_service_cast.cc
    • device/bluetooth/cast/bluetooth_remote_gatt_service_cast.h
    • device/bluetooth/device_unittest.cc
    • device/bluetooth/test/fake_remote_gatt_service.cc
    • device/bluetooth/test/fake_remote_gatt_service.h
    • device/bluetooth/test/mock_bluetooth_gatt_service.cc
    • device/bluetooth/test/mock_bluetooth_gatt_service.h
    • device/fido/fido_ble_connection_unittest.cc
  55. [iOS] Create FindInPage UI for UI Refresh

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:41:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 81f3e175814bb20d103aa178a71272c2cd422193

    Comments

    [iOS] Create FindInPage UI for UI Refresh
    
    This CL creates the FindInPage UI to be used with UI Refresh.
    
    Bug: 805504
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ib6f5adcfde4560a589fed323a717b02c4566621d
    Reviewed-on: https://chromium-review.googlesource.com/1133160
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574551}

    Changed files

    • ios/chrome/browser/ui/find_bar/BUILD.gn
    • ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
    • ios/chrome/browser/ui/find_bar/find_bar_ui_element.h
    • ios/chrome/browser/ui/find_bar/find_bar_view.h
    • ios/chrome/browser/ui/find_bar/find_bar_view.mm
  56. MutablePO2TS: Fire token available when adding invalid token at startup

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:40:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d373e8d468f12b8ca7bbf6b979961e3a3f29cc73

    Comments

    MutablePO2TS: Fire token available when adding invalid token at startup
    
    ProfileOAuth2TokenService maintains the invariant that if the user is
    signed in at startup, the primary account is always present in
    PO2TS::GetAccounts().
    
    To maintain this invariant, MutableProfileOAuth2TokenServiceDelegate
    performs the following action when the load of tokens from the on-disk
    database is complete: if the user is signed in, it checks whether there
    is a token present for the primary account and if not, inserts an
    invalid token for that account. (The token can be absent due to e.g. a
    failure to decrypt the database on disk for whatever reason).
    
    However, MutablePO2TSDelegate does *not* fire the
    OnRefreshTokenAvailable() callback in that case. This breaks the
    implicit expectation of clients that when ProfileOAuth2TokenService adds
    an account, it will always fire OnRefreshTokenAvailable(). It is also
    inconsistent with the behavior if the primary account happens to have
    an invalid token on disk that is successfully decrypted: in that case,
    MutablePO2TSDelegate will fire the observer callback, but of course,
    from clients' POV there is no difference whatsoever between these two
    cases.
    
    In particular, the failure of this invariant can cause IdentityManager
    to crash if a user in this situation later signs out, as the token
    being revoked violates IdentityManager's expectation that it had
    previously been made aware of that token via a notification that it
    was available.
    
    This CL remedies the problem by firing OnRefreshTokenAvailable() in
    this case. It also extends the relevant MutablePO2TSDelegate unittest
    to fail without this change and succeed with this change.
    
    Bug: 860011
    Change-Id: I66cebda29ec56d79f209f6b2c93dff67797c57b4
    Reviewed-on: https://chromium-review.googlesource.com/1126861
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574550}

    Changed files

    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
  57. [iOS] Hide clear button when the textfield is empty.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a0056ea7bc75754d4ac5388b0ee9108cc604945d

    Comments

    [iOS] Hide clear button when the textfield is empty.
    
    Makes UI Refresh omnibox hide the clear button when the textfield
    is empty.
    
    Bug: 854622
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I7905efa0c5ead8c7c2884c27474ec992b970355c
    Reviewed-on: https://chromium-review.googlesource.com/1122627
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574549}

    Changed files

    • ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
  58. [Dice] Add drop down button to signin button in user menu

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:27:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dcd444b288c6dc6237db97575abc35e4e4d81ce

    Comments

    [Dice] Add drop down button to signin button in user menu
    
    The "Sync to another account" button in the user menu
    is removed and instead a drop down button is added to
    the right of the sign-in button.
    
    Bug: 824546
    Change-Id: I8b1b892962b17229dfdc057169a7f18132ffb58b
    Reviewed-on: https://chromium-review.googlesource.com/1133978
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574548}

    Changed files

    • chrome/browser/ui/views/profiles/profile_chooser_view.cc
  59. Run filesystem_service_unittests, leveldb_service_unittests on all desktop bots.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:25:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb527397d46f689b27ba693793620d1a2fb98493

    Comments

    Run filesystem_service_unittests, leveldb_service_unittests on all desktop bots.
    
    Bug: 843511
    Change-Id: I082a2c9e4d5e573f07bef1e0176f32db6344f2f0
    Reviewed-on: https://chromium-review.googlesource.com/1132400
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574547}

    Changed files

    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  60. Remove webkit-appearance.tentative.html WPT test

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:22:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af6945a93a039f0717fbc6037dd66a1db081fa65

    Comments

    Remove webkit-appearance.tentative.html WPT test
    
    This test is not a good indicator of -webkit-appearance support; it only
    checks whether computed-value == applied-value for -webkit-appearance
    values specified on a vanilla <div>. In reality most values of
    -webkit-appearance are not of interest to other UAs (see
    https://github.com/whatwg/compat/issues/6), and the behavior is
    different on different elements (e.g. <input>).
    
    Since this has caused issues across different platforms on Chrome (see
    bug), remove it.
    
    Bug: 810162
    Change-Id: I9d469cb624569f453978f3c56cc180eb07435b5b
    Reviewed-on: https://chromium-review.googlesource.com/1134387
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574546}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/compat/webkit-appearance.tentative.html
    • third_party/WebKit/LayoutTests/platform/mac/external/wpt/compat/webkit-appearance.tentative-expected.txt
  61. Avoid incomplete live region text change announcements

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:04:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a32928f26183dce010284f0abcee28508e44a6f8

    Comments

    Avoid incomplete live region text change announcements
    
    When a live region change occurs we sometimes fire text change events
    for only part of the text. For example, if "car" changes to "cat", we
    fire an event that makes it look like only the "t" changed.
    
    This changes the heuristic so that when a live region occurs that is
    not in an editor, it will prefer to indicate that entire text nodes
    have changed.
    
    Bug: 778478
    Change-Id: If87f1ac8c9c0b237bd422e8b7217d8d0347a13ab
    Reviewed-on: https://chromium-review.googlesource.com/1134201
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574545}

    Changed files

    • content/test/data/accessibility/event/description-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/name-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
    • ui/accessibility/platform/ax_platform_node_win.h
  62. Roll src/third_party/pdfium 68d04f284423..5ff09fb5ee90 (2 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 13:03:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0aeff28f34f12485a9148321c00383c633d48c63

    Comments

    Roll src/third_party/pdfium 68d04f284423..5ff09fb5ee90 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/68d04f284423..5ff09fb5ee90
    
    
    git log 68d04f284423..5ff09fb5ee90 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 art-snake@yandex-team.ru Remove CPDF_HintTables::GetItemLength()
    2018-07-12 art-snake@yandex-team.ru Implement CPDF_HintsTable::SharedObjGroupInfo.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@5ff09fb5ee90
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I687479f194e638319b40fa5357179d8144f4b197
    Reviewed-on: https://chromium-review.googlesource.com/1134948
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574544}

    Changed files

    • DEPS
  63. Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 13:03:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e1637ff7a416934beedc7a637455779b85f6042

    Comments

    Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)
    
    https://webrtc.googlesource.com/src.git/+log/5795489e83ad..58c79f66dd3a
    
    
    git log 5795489e83ad..58c79f66dd3a --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 saza@webrtc.org Add saza to fuzzer owners
    2018-07-12 ilnik@webrtc.org Temporarly disable KSVC perf tests on Mac because of crashes
    2018-07-12 mbonadei@webrtc.org Removing -Wno-reorder from audio_device.
    2018-07-12 danilchap@webrtc.org Fix buffer overflow in ulpfec recovery
    2018-07-12 danilchap@webrtc.org Fix handling invalid empty red packets
    2018-07-12 buildbot@webrtc.org Roll chromium_revision 720dadbc21..efbdada3f7 (574387:574489)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@58c79f66dd3a
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:856823,chromium:856823,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I2e736098249694bb9480b4f170b065e60ddd44a2
    Reviewed-on: https://chromium-review.googlesource.com/1134949
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574543}

    Changed files

    • DEPS
  64. Updating names for job triggers on nexus5x and win 10 perf

    Changed by Emily Hanley - eyaichohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:55:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896ba71bc975b53346521228a32536296ea5d80e

    Comments

    Updating names for job triggers on nexus5x and win 10 perf
    
    Dependent on crrev.com/c/1131227
    
    NOTRY=True
    
    Bug: 758326
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: Icd5c18a166e815be5c2570cafd511bae4c545975
    Reviewed-on: https://chromium-review.googlesource.com/1131230
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574542}

    Changed files

    • infra/config/global/luci-milo-dev.cfg
    • infra/config/global/luci-milo.cfg
    • testing/buildbot/chromium.perf.json
    • tools/perf/core/perf_data_generator.py
  65. [unified-consent] USER_EVENT has its own sync pref group

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:50:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4432c3f9d16a93276eeb9c60a860190223888d96

    Comments

    [unified-consent] USER_EVENT has its own sync pref group
    
    This CL passes the information that unified consent is enabled to
    the sync service. It then uses it to move USER_EVENTS data type in
    a separate pref group (instead of having it tied to TYPED_URLS as
    before).
    
    The goal is not to un-link USER_EVENTS from HISTORY, but to have a
    separate toggle for USER_EVENTS (which will be linked to HISTORY toggle
    in the toggle UI).
    
    Unit tests have been updated accordingly.
    
    Bug: 860515
    
    Change-Id: Ic5461470114c0b05ec770817890c9123b81f3d77
    Reviewed-on: https://chromium-review.googlesource.com/1128876
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574541}

    Changed files

    • chrome/browser/android/contextualsearch/contextual_search_delegate.cc
    • chrome/browser/sync/profile_sync_service_factory.cc
    • chrome/browser/sync/test/integration/enable_disable_test.cc
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
    • components/sync/base/sync_prefs.cc
    • components/sync/base/sync_prefs.h
    • components/sync/base/sync_prefs_unittest.cc
  66. compare_build_artifacts: make ninja path command line option.

    Changed by Yoshisato Yanagisawa - yyanagisawaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:49:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3f55b21a7a48593a9ce1622346dad112a8b2e2f

    Comments

    compare_build_artifacts: make ninja path command line option.
    
    ninja seems not be in PATH when compare_build_artifacts.py is executed.
    Then compare_build_artifacts cannot compare object files difference,
    and just fails with exception.
    To fix that, let me make ninja path given with command line option.
    
    Bug: 862917
    Change-Id: Ieb7d7bd1db30217222f5cd5006e120244da28fd5
    Reviewed-on: https://chromium-review.googlesource.com/1134710
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574540}

    Changed files

    • tools/determinism/compare_build_artifacts.py
  67. Mark several layout tests as flaky.

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:44:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704b3f013b80c7a5f93296e3d146758d5c0b0ccc

    Comments

    Mark several layout tests as flaky.
    
    - css3/filters/effect-brightness-clamping-hw.html
    - virtual/gpu/fast/canvas/canvas-blending-image-over-image.html
    - css3/filters/effect-drop-shadow-hw.html
    - external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862716, 862729, 862806, 862826
    Change-Id: I08126b22afdc0a7a4ef776dde8cc1120643acdcc
    Reviewed-on: https://chromium-review.googlesource.com/1134990
    Commit-Queue: Mike West <mkwst@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574539}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  68. macviews: switch back to Cocoa menus for Views context menus

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b56c4e40b65ee14134dd2e61834f260ca9c1715e

    Comments

    macviews: switch back to Cocoa menus for Views context menus
    
    This change:
    1) Reverts erikchen@'s 79c8511fb8801f7fc23c4cbe81311b6065daef15, which removed
       the Cocoa menu runner code;
    2) Wires the Cocoa menu runner code back up in MenuRunnerImplInterface::Create;
    3) Fixes a latent bug in Textfield that could cause it to delete its context
       menu while handling a context menu activation - this is fine with Views menus
       but forbidden with Cocoa menus.
    
    Bug: 860673
    Change-Id: If110f09379c4661a4f61a8b0257cf5214503e6a9
    Reviewed-on: https://chromium-review.googlesource.com/1131564
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574538}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/controls/menu/menu_runner_cocoa_unittest.mm
    • ui/views/controls/menu/menu_runner_impl.cc
    • ui/views/controls/menu/menu_runner_impl_cocoa.h
    • ui/views/controls/menu/menu_runner_impl_cocoa.mm
    • ui/views/controls/textfield/textfield.cc
    • ui/views/controls/textfield/textfield_unittest.cc
  69. Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:32:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78a0a24222fde0f77a45d4f78b1f4502496c434e

    Comments

    Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/c228d491eb86..3973c26575e2
    
    
    git log c228d491eb86..3973c26575e2 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 dhanyaganesh@chromium.org CreateTarball: Add debug code with lsof
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@3973c26575e2
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Iabf74616719c8b90e6b34c6576772eeb313a7183
    Reviewed-on: https://chromium-review.googlesource.com/1134906
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574537}

    Changed files

    • DEPS
  70. Oilpan: Do not include wtf/functional.h

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb

    Comments

    Oilpan: Do not include wtf/functional.h
    
    No one in platform/heap/ needs wtf/functional.h, though persistent.h
    needs base/bind.h for IsWeakReceiver<> and BindUnwrapTraits<>.
    
    This CL reduces the pre-processed size of handle.h by 31KB.
    
    Bug: 242216
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I6097a6f22dbe7a762f4b0a23560c731a07daf5ce
    Reviewed-on: https://chromium-review.googlesource.com/1134809
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574536}

    Changed files

    • third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
    • third_party/blink/renderer/modules/budget/budget_service.cc
    • third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
    • third_party/blink/renderer/modules/filesystem/directory_reader.cc
    • third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc
    • third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
    • third_party/blink/renderer/modules/locks/lock.cc
    • third_party/blink/renderer/modules/mediastream/media_devices_test.cc
    • third_party/blink/renderer/modules/payments/payment_manager.cc
    • third_party/blink/renderer/modules/service_worker/respond_with_observer.cc
    • third_party/blink/renderer/modules/webusb/usb_device.cc
    • third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/skia_texture_holder.h
    • third_party/blink/renderer/platform/heap/persistent.h
    • third_party/blink/renderer/platform/heap/thread_state.h
    • third_party/blink/renderer/platform/testing/empty_web_media_player.h
    • third_party/blink/renderer/platform/testing/unit_test_helpers.cc
  71. Add UMA for locked-fullscreen state

    Changed by Ivan Sandrk - isandrkohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:29:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fe933a784678f6aa62203b7d57a638051c15f2a

    Comments

    Add UMA for locked-fullscreen state
    
    Locked-fullscreen state will be used for giving student quizzes on managed
    Chrome OS devices in schools. Add a UMA to track feature adoption.
    
    Change-Id: I59f809e2aecd67a4e9f10ee21a28658796c03b15
    Reviewed-on: https://chromium-review.googlesource.com/1126241
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574535}

    Changed files

    • chrome/browser/extensions/api/tabs/tabs_api.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  72. Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84356c12447981846eda650f06085913fa831126

    Comments

    Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862907
    Change-Id: If6ce15cb1633ae74177e385774a1cef7010e67c0
    Reviewed-on: https://chromium-review.googlesource.com/1134989
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574534}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  73. Navigation: Refactoring WebContents unittests to use NavigationSimulator

    Changed by Arthur Hemery - ahemeryohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:20:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c65bc1abc46c630c53a3e21bb0670dc602e8d37d

    Comments

    Navigation: Refactoring WebContents unittests to use NavigationSimulator
    
    Removed the usage of TestWebContents->DidNavigate variants in
    web_contents_impl_unittest.cc. Some usage remains, linked to
    overlapping navigations and other specific usages.
    
    Bug: 728571
    Change-Id: Ie2d6b73cb5deea077f720114fdd45ab4ee714c0a
    Reviewed-on: https://chromium-review.googlesource.com/1076240
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Commit-Queue: Arthur Hemery <ahemery@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574533}

    Changed files

    • content/browser/web_contents/web_contents_impl_unittest.cc
  74. Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a66959734236ca95f9372334bfa18bbc7a5a1b52

    Comments

    Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)
    
    https://skia.googlesource.com/skia.git/+log/fcc10da18eb5..4d6a844365e7
    
    
    git log fcc10da18eb5..4d6a844365e7 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
    2018-07-12 herb@google.com Use new SkGlyphIDSet - v3
    2018-07-12 bungeman@google.com Remove SkDrawFilter.
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5c8113d3c20f..5598148b7613 (8 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 robertphillips@google.com Revert "build debug on linux for gdb"
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 caryclark@google.com build debug on linux for gdb
    2018-07-12 benjaminwagner@google.com Update Win10 in Skolo.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@4d6a844365e7
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ifd4c74ca893ddae66e41fe10ff663287be1cf325
    Reviewed-on: https://chromium-review.googlesource.com/1134148
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574532}

    Changed files

    • DEPS
  75. Activate widget correctly when the inline reply opens on ARC notification

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

    Comments

    Activate widget correctly when the inline reply opens on ARC notification
    
    When a non-ARC normal window (eg. Chrome browser window) was active, the
    inline textbox didn't work for the second time and later. This CL solves
    this issue.
    
    This was because the widget was not activated correctly (IsActive() was
    true but CanActivate() was false) in that case. This CL removes the
    IsActive() guard to make the widget active correctly whenever the inline
    reply opens.
    
    Bug: b/111100376
    Bug: 858938
    Test: manual (inline reply can be used multiple times)
    
    Change-Id: I65d7604be5d24ff1e6c56336a76a5951d6066b39
    Reviewed-on: https://chromium-review.googlesource.com/1133039
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574531}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
  76. media: sync the camera metadata definitions

    Changed by Shik Chen - shikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38884d4717c2517cb832722d0fa4871a89d19799

    Comments

    media: sync the camera metadata definitions
    
    We need some new metadata tags for external camera, so regenerate and
    sync all of them in arc-camera, chromium, and ARC++.
    
    Some "arc" are replaced by "cros" manually.
    
    BUG=b:77833131
    TEST=Verify CCA works on Nautilus.
    
    Change-Id: I308e258d9b72acdd825591041a67ce7352dce6a8
    Reviewed-on: https://chromium-review.googlesource.com/1117970
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Shik Chen <shik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574530}

    Changed files

    • media/capture/video/chromeos/mojo/camera_metadata_tags.mojom
  77. blink/wtf: Really move MovableStrings when DCHECK_IS_ON.

    Changed by Benoit Lize - lizebohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:09:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1fef2b1ad38fe1ef8c3914fb5dadc39bae80b9b

    Comments

    blink/wtf: Really move MovableStrings when DCHECK_IS_ON.
    
    When a MovableString is parked, actually park the content, and poison
    the previous allocation. This is intended to find cached raw pointer
    accesses, which are not allowed beyond the UI thread task per the
    contract of the class.
    Enabled only when DCHECK_IS_ON to prevent potential crashes.
    
    Changes with and without DCHECK()s:
    - Cache some String properties in MovableStringImpl
    - Add a parked_strings_ to MovableStringTable for accounting, and
      update tests accordingly.
    
    Changes with DCHECK()s:
    - Add a parked_string_ member to MovableStringImpl
    - Copy the string to the parked version in Park(), and poison the
      previous allocation.
    - Restore the string in Unpark().
    
    Bug: 837659
    Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
    Reviewed-on: https://chromium-review.googlesource.com/1133169
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574529}

    Changed files

    • third_party/blink/renderer/platform/wtf/text/movable_string.cc
    • third_party/blink/renderer/platform/wtf/text/movable_string.h
    • third_party/blink/renderer/platform/wtf/text/movable_string_test.cc
  78. Re-enable opening-handshake/003-sets-origin.worker.html

    Changed by Peter Mayo - petermayoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:58:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d18929b41e24487865c4ed9da46129e6b037beeb

    Comments

    Re-enable opening-handshake/003-sets-origin.worker.html
    
    These tests no longer timeout.  The flakiness dashboard is green
    for a long time.
    
    Bug: 803558
    Change-Id: I2924740d2c736419fdc5130e546f557c8d874151
    Reviewed-on: https://chromium-review.googlesource.com/1134094
    Reviewed-by: Robert Ma <robertma@chromium.org>
    Commit-Queue: Peter Mayo <petermayo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574528}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  79. [Fetch] Use wrapper tracing to express references between wrappers

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:53:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a7c8ee607674efabc720016992893e2226ce3a0

    Comments

    [Fetch] Use wrapper tracing to express references between wrappers
    
    This is a reland of
    https://crrev.com/8057f58cb22579bc685efa50c579325ed047d51a which has
    been reverted due to a crash issue. The crash was caused by a missing
    TraceWrapperMember in blink::Response. This CL fixes that, and adds
    a layout test to verify that.
    
    Original CL: https://chromium-review.googlesource.com/c/1124270
    
    Bug: 862440
    Change-Id: I2842b957f223cfb32fee2aa9048b550010cb2e45
    Reviewed-on: https://chromium-review.googlesource.com/1134642
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574527}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/fetch/chromium/body-wrapper-tracing.html
    • third_party/blink/renderer/core/fetch/body_stream_buffer.cc
    • third_party/blink/renderer/core/fetch/body_stream_buffer.h
    • third_party/blink/renderer/core/fetch/fetch_request_data.cc
    • third_party/blink/renderer/core/fetch/fetch_request_data.h
    • third_party/blink/renderer/core/fetch/fetch_response_data.cc
    • third_party/blink/renderer/core/fetch/fetch_response_data.h
    • third_party/blink/renderer/core/fetch/request.cc
    • third_party/blink/renderer/core/fetch/request.h
    • third_party/blink/renderer/core/fetch/response.cc
    • third_party/blink/renderer/core/fetch/response.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/platform/bindings/v8_private_property.h
  80. [NTP] Adding mathp@ as owner of components/search

    Changed by Mathieu Perreault - mathpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1bc34891c3dbe8da1ac513111db7c7d2efd56f20

    Comments

    [NTP] Adding mathp@ as owner of components/search
    
    Few reasons for this:
    - My team and myself are now owners of the feature
    - Both current owners are gone through the end of July
    - I am owners of other parts of the NTP code (resources, data sources) as well
      as server-side code; as such, I think I'm qualified.
    
    Bug: None
    Change-Id: Ic1261dacba81a420500240c5a55bc547fb8b6c14
    Reviewed-on: https://chromium-review.googlesource.com/1133767
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574526}

    Changed files

    • components/search/OWNERS
  81. Roll src/third_party/pdfium d8882193737a..68d04f284423 (1 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:28:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1f9c10c3ca23a47aa60fe21a5b990c9d7cd589a

    Comments

    Roll src/third_party/pdfium d8882193737a..68d04f284423 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/d8882193737a..68d04f284423
    
    
    git log d8882193737a..68d04f284423 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 art-snake@yandex-team.ru Reland "Avoid duplicate data buffering in CPDF_SyntaxParser::ReadStream()."
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@68d04f284423
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I09ab0d06005fa49756095e583c16e039d0c8df3c
    Reviewed-on: https://chromium-review.googlesource.com/1134846
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574525}

    Changed files

    • DEPS
  82. Mark textdecoder-fatal-single-byte.any.worker.html flaky to unblock WPT import

    Changed by Philip J├Ągenstedt - foolipohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dea5439837339b97168cdbbf6a45bfa27748b16

    Comments

    Mark textdecoder-fatal-single-byte.any.worker.html flaky to unblock WPT import
    
    TBR=robertma
    
    Bug: 862938
    Change-Id: I9ceda537526da02ebadc9799d58fb042d7f339d3
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1134770
    Commit-Queue: Philip J├Ągenstedt <foolip@chromium.org>
    Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574524}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  83. Revert "Make NetworkConnectionTracker survive network service crashes and restarts"

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:11:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 197e9188dc5be69cb34e1ebd67f86a1146439367

    Comments

    Revert "Make NetworkConnectionTracker survive network service crashes and restarts"
    
    This reverts commit cec0800c372ef670f59999fb3f028013d36b866c.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified this CL at revision 574314 as the culprit
    for introducing flakiness in the tests as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2VjMDgwMGMzNzJlZjY3MGY1OTk5OWZiM2YwMjgwMTNkMzZiODY2Yww
    
    TBR=xunjieli@chromium.org
    
    Bug: 862883
    
    Original change's description:
    > Make NetworkConnectionTracker survive network service crashes and restarts
    > 
    > This CL is to mirror tbansal@'s CL
    > (https://chromium-review.googlesource.com/1058528) to make
    > NetworkConnectionTracker survice network service's crashes and restarts.
    > 
    > Bug: 821009
    > Change-Id: Iec33797c0fd0ce12a8e5fdab9fda0a710eb9a528
    > Reviewed-on: https://chromium-review.googlesource.com/1120738
    > Commit-Queue: Helen Li <xunjieli@chromium.org>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574314}
    
    TBR=jam@chromium.org,xunjieli@chromium.org,tbansal@chromium.org
    
    Change-Id: I2524f0e04441097e06585f4f2e4cdb948a419641
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 821009
    Reviewed-on: https://chromium-review.googlesource.com/1135006
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574523}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc
  84. Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1

    Changed by afdo-chromium-autoroll - afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a837f9d78ab2670ad242acd3651e0bf1f29a2a39

    Comments

    Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    The AutoRoll server is located here: https://afdo-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I0095acd5d9522beaf64a43baf3bb71106038fe7c
    Reviewed-on: https://chromium-review.googlesource.com/1134870
    Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574522}

    Changed files

    • chrome/android/profiles/newest.txt
  85. Always align slider bubbles to the bottom of the desktop.

    Changed by Tatsuhisa Yamaguchi - yamaguchiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:06:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a0ab14f53bb9b6346969ec10d376d51aff8eceb

    Comments

    Always align slider bubbles to the bottom of the desktop.
    
    The slider was aligned towards the system tray icon view in the shelf
    by the bubble's bottom edge. It meant that the slider bubble was shown
    apart from the bottom of the desktop when the shelf layout is either
    right or left. It was not consistent with popup notification, causing
    view overlap between notifications and a slider bubble.
    
    Bug: 862496
    Change-Id: Ie6db618f8b744ecc4de52ee7a4866ca9e9ecd26c
    Reviewed-on: https://chromium-review.googlesource.com/1134643
    Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574521}

    Changed files

    • ash/system/unified/unified_slider_bubble_controller.cc
  86. [ios] Adds icons and hides headers on the main Settings page.

    Changed by Rohit Rao - rohitraoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:00:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f5527a3ed5e88090ce316b8afac85c39cbb0ba8

    Comments

    [ios] Adds icons and hides headers on the main Settings page.
    
    Screenshot: https://drive.google.com/file/d/16aS0MP0LwdGOq8-IJgtIbq4ozXy44meT/view?usp=sharing
    
    BUG=805213,805214
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iccdd87d8f95fd80b51fcdcfa2caa691c7fcd78b4
    Reviewed-on: https://chromium-review.googlesource.com/1133323
    Reviewed-by: edchin <edchin@chromium.org>
    Commit-Queue: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574520}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
    • ios/chrome/browser/ui/settings/resources/BUILD.gn
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@3x.png
    • ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
  87. [iOS] Tweak tab grid transition animations.

    Changed by Mark Cogan - marqohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:57:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e96b9e2a058ddc4573deba9c0159077c8a89b45d

    Comments

    [iOS] Tweak tab grid transition animations.
    
    This CL adjusts the tab grid transition animations.
    
    (A) The timing (curve, delay, and duration) of some of the sub-animations is tweaked.
    
    (B) Because -viewWillAppear: is called inside the animation, some of the
        setup for the animations needs to be done before that method is called;
        the cleanest mechanism seemed to be to make these changes when the view
        disappeared. This is mostly setting the toolbar alpha to zero so it can be
        faded in during the animation.
    
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I8c84f5726a0ce49e13c5fd32ab91295ffbb00e57
    Reviewed-on: https://chromium-review.googlesource.com/1127994
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574519}

    Changed files

    • ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
    • ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm
  88. Disabling ViewIDTest.Basic.

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:52:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fc8ad7e2561f48248fee640b72a808f1592634a

    Comments

    Disabling ViewIDTest.Basic.
    
    This test is consistently failing on:
    
    * 10.11 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018
    * 10.12 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14366
    * 10.13 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4145
    
    TBR=mkwst@chromium.org,kpaulhamus@chromium.org
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862945
    Change-Id: I9156862b472f2ad993f9da7d709b75baaddc2908
    Reviewed-on: https://chromium-review.googlesource.com/1134780
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574518}

    Changed files

    • chrome/browser/ui/cocoa/view_id_util_browsertest.mm
  89. Fix description of NetworkPredictionOptions policy

    Changed by Stefan Teodorescu - faneohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:46:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d8142d8da58d317cc159294a6b9c6139e7173b1

    Comments

    Fix description of NetworkPredictionOptions policy
    
    Removed unnecessary preference names from description.
    
    Bug: 858829
    Change-Id: Ic75e9af5ebca5e56c20e796e1991a217ad427246
    Reviewed-on: https://chromium-review.googlesource.com/1131115
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Commit-Queue: Stefan Teodorescu <fane@google.com>
    Cr-Commit-Position: refs/heads/master@{#574517}

    Changed files

    • components/policy/resources/policy_templates.json
  90. [ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo

    Changed by Han Leon - leon.hanohnoyoudont@intel.com
    Changed at Thursday, 12-Jul-18 09:45:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d00d598cb4ae00510a30326c3db46f9b0506e36d

    Comments

    [ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo
    
    This CL removes native struct ServiceWorkerProviderHostInfo and the
    corresponding typemapping for it, instead, directly uses mojom struct
    ServiceWorkerProviderHostInfo everywhere.
    
    BUG=789854
    
    Change-Id: I5aa15afb38d5658e25ba40dacae5873cff4caa62
    Reviewed-on: https://chromium-review.googlesource.com/1132847
    Commit-Queue: Han Leon <leon.han@intel.com>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574516}

    Changed files

    • content/browser/service_worker/service_worker_dispatcher_host.cc
    • content/browser/service_worker/service_worker_dispatcher_host.h
    • content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
    • content/browser/service_worker/service_worker_object_host_unittest.cc
    • content/browser/service_worker/service_worker_provider_host.cc
    • content/browser/service_worker/service_worker_provider_host.h
    • content/browser/service_worker/service_worker_provider_host_unittest.cc
    • content/browser/service_worker/service_worker_test_utils.cc
    • content/browser/service_worker/service_worker_test_utils.h
    • content/common/BUILD.gn
    • content/common/service_worker/service_worker_provider.mojom
    • content/common/service_worker/service_worker_provider.typemap
    • content/common/service_worker/service_worker_provider_host_info.cc
    • content/common/service_worker/service_worker_provider_host_info.h
    • content/common/service_worker/service_worker_provider_struct_traits.cc
    • content/common/service_worker/service_worker_provider_struct_traits.h
    • content/common/typemaps.gni
    • content/renderer/service_worker/service_worker_network_provider.cc
  91. [unified-consent] Enable sync everything only when sync is active

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:41:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eef2c0be5716d8857f9ff7dce265e2569c8d333e

    Comments

    [unified-consent] Enable sync everything only when sync is active
    
    UnifiedConsentService is observing changes of the sync service,
    so the sync data types are only enabled when sync is started up
    and active.
    
    Bug: 862139, 819909
    Change-Id: I4c006e0c1cc7b263f113865da0c128620e1817ae
    Reviewed-on: https://chromium-review.googlesource.com/1131744
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574515}

    Changed files

    • components/unified_consent/unified_consent_service.cc
    • components/unified_consent/unified_consent_service.h
    • components/unified_consent/unified_consent_service_unittest.cc
  92. Roll src/third_party/depot_tools 32e3d1e37cd6..2b138f742b74 (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 09:40:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f198a1c4c492486c961c0a112247ddac9a9e3379

    Comments

    Roll src/third_party/depot_tools 32e3d1e37cd6..2b138f742b74 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/32e3d1e37cd6..2b138f742b74
    
    
    git log 32e3d1e37cd6..2b138f742b74 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 sdefresne@chromium.org Avoid creating an empty netrc file in $TEMP
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@2b138f742b74
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:none
    TBR=agable@chromium.org
    
    Change-Id: I8e88cdcad6399e9a7b117a2fe36dc264a6e61c78
    Reviewed-on: https://chromium-review.googlesource.com/1134149
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574514}

    Changed files

    • DEPS
  93. Revert "Delete the media cache(s) when using a single combined HTTP cache."

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb81f73d09c9efd4ff7eb181ce3ffe105d1549a8

    Comments

    Revert "Delete the media cache(s) when using a single combined HTTP cache."
    
    This reverts commit e226149af1b3f003b5d3f59e19ee17bef7419c42.
    
    Reason for revert: 
    
    `ProfileWithoutMediaCacheBrowserTest.DeleteMediaCache` and `ProfileWithoutMediaCacheBrowserTest.DeleteIsolatedAppMediaCache` have been failing, apparently since they were added by this CL.
    
    They were added here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28016 (which failed to actually run `browser_test`) and have been failing consistently since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018.
    
    
    Original change's description:
    > Delete the media cache(s) when using a single combined HTTP cache.
    > 
    > This is so that I can try increasing the media cache size in experiments
    > without increasing Chrome's profile size (Except possibly for profiles
    > that have never been used to play video).
    > 
    > Bug: 789657
    > Change-Id: I45e8f8c6e346a1fa7d05b0bea3e8b001d7dc41e1
    > Reviewed-on: https://chromium-review.googlesource.com/1130162
    > Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    > Commit-Queue: Matt Menke <mmenke@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574296}
    
    TBR=mmenke@chromium.org,morlovich@chromium.org
    
    Change-Id: Ibc519750f00ad7e698d279af6baffe77b32d30be
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 789657, 862945
    Reviewed-on: https://chromium-review.googlesource.com/1134886
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574513}

    Changed files

    • chrome/browser/profiles/profile_browsertest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
  94. Cancel long-press operation if the gesture is scrolling

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:21:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d417866204188b709447dfb64ba68740a182b7a5

    Comments

    Cancel long-press operation if the gesture is scrolling
    
    This CL adds the code to cancel the long-press operation which shows
    inline setting when the user stats the scrollingo
    
    Previously that was done in Android (ag/4340201) but it didn't work
    for vertical scroll since the scroll is handled on Chrome side. With
    this CL, scroll detection is done on Chrome side and the code handles
    correctly with vertical scrolls in addition to horizontal ones.
    
    Bug: b/111100376
    Bug: 858938
    Test: Manual (inline setting does't open during vertical scroll)
    Change-Id: I84407b331dc320e6acd3a776938104ad018d46a3
    Reviewed-on: https://chromium-review.googlesource.com/1124263
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Greg Kerr <kerrnel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574512}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
    • ash/system/message_center/arc/arc_notification_item.h
    • ash/system/message_center/arc/arc_notification_item_impl.cc
    • ash/system/message_center/arc/arc_notification_item_impl.h
    • ash/system/message_center/arc/arc_notification_manager.cc
    • ash/system/message_center/arc/arc_notification_manager.h
    • ash/system/message_center/arc/mock_arc_notification_item.h
    • components/arc/common/notifications.mojom
    • components/arc/test/fake_notifications_instance.cc
    • components/arc/test/fake_notifications_instance.h
  95. OAuth2LoginManager: Handle consecutive refresh token updates

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:20:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2f7998c5e85ffebc0c1f7588bcc45a73e1de4dc

    Comments

    OAuth2LoginManager: Handle consecutive refresh token updates
    
    OAuth2LoginManager currently assumes that
    OAuth2TokenService::Observer::OnRefreshTokenAvailable() will never be
    called twice consecutively for the primary account; in particular,
    it calls VerifySessionCookies(), which DCHECKS that
    |oauth2_login_verifier_| is null before instantiating that ivar.
    
    However, this assumption is no longer valid. A simple example:
    - A refresh token is found during startup, resulting in
      OnRefreshTokenAvailable() firing.
    - The user revokes their refresh token remotely.
    - Sync locally enters an error state, prompting the user to reauth
      locally.
    - The user reauths locally, resulting in OnRefreshTokenAvailable()
      firing.
    
    Other examples are possible as well.
    
    This CL extends OAuth2LoginManager to handle this case by stopping
    ongoing actions related to the current refresh token for the primary
    account when OAuth2LoginManager receives the notification that that
    refresh token has been updated.
    
    This CL is concretely necessary to unblock
    https://chromium-review.googlesource.com/c/chromium/src/+/1126861,
    which is firing the "token available" notification as part of startup
    when adding an invalid token for the primary account and triggers the
    DCHECK above on ChromeOS browsertests. Those failures were how I
    discovered this issue.
    
    Change-Id: I55ced6fe49055c6c6c4d1e7ce138a0d080ecda38
    Reviewed-on: https://chromium-review.googlesource.com/1127662
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574511}

    Changed files

    • chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
  96. shared worker: Simplify the default network factory logic.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:20:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab39b893750485f84d1f607be642fe1efdc27f7f

    Comments

    shared worker: Simplify the default network factory logic.
    
    When NetworkService is off but S13nSW is on, shared worker jumped
    through hoops to get a factory bundle to the renderer. It was
    giving the renderer a NetworkService default factory and expecting the
    renderer to clear it.
    
    But we can just give a non-NetworkService direct network default factory,
    since that capability was added in r565058.
    
    Bug: 839982
    Change-Id: Ie5c4f182b87526e2f15a7b2a8b62ed03f7e5595f
    Reviewed-on: https://chromium-review.googlesource.com/1134708
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574510}

    Changed files

    • content/browser/shared_worker/shared_worker_host.cc
    • content/renderer/shared_worker/embedded_shared_worker_stub.cc
  97. Revert "licenses.py: Skip another //tools/binary_size subdirectory."

    Changed by Raphael Kubo da Costa (CET) - raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 12-Jul-18 09:19:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc3a2b34c667b8e2e0cde7766e9439e80fb72174

    Comments

    Revert "licenses.py: Skip another //tools/binary_size subdirectory."
    
    This reverts commit a6c69c8113a7113cc6b4a4f8de3291095d717e40.
    
    Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1080401 moved gvr-android-sdk into a directory we already skip, so this is no longer needed.
    
    Original change's description:
    > licenses.py: Skip another //tools/binary_size subdirectory.
    > 
    > Commit 6a15a6c4 ("SuperSize: Teach it about thin archives") added a
    > third_party directory to tools/binary_size with a .a file with some dummy
    > contents that we need to skip.
    > 
    > Change-Id: Ia1e129dc67617207ac920106e835d762887e74ac
    > Reviewed-on: https://chromium-review.googlesource.com/1078967
    > Reviewed-by: Scott Graham <scottmg@chromium.org>
    > Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    > Cr-Commit-Position: refs/heads/master@{#564081}
    
    TBR=raphael.kubo.da.costa@intel.com,scottmg@chromium.org,ichikawa@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I8a85ee225f54a0499ee18e20311dfd5b9dc280fe
    Reviewed-on: https://chromium-review.googlesource.com/1133138
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#574509}

    Changed files

    • tools/licenses.py
  98. Add AudioLogFactory mojo interface.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:19:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee6cfd00b7b35f8bc4ced3eecc801fa2f55a85ae

    Comments

    Add AudioLogFactory mojo interface.
    
    This interface allows a mojo client to create audio logs on
    the browser process.
    This CL also removes content::MojoLogAudioAdapter, which is moved to the
    audio service as audio::LogAdapter in follow-up CL crrev.com/c/1128974
    
    Bug: 812557
    Change-Id: I70504a4878553f1a3c2d58a29c6ab960b6f15b39
    Reviewed-on: https://chromium-review.googlesource.com/1128966
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574508}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/media/audio_log_factory.cc
    • content/browser/media/audio_log_factory.h
    • content/browser/media/media_internals.cc
    • content/browser/media/media_internals.h
    • content/browser/media/mojo_audio_logging_adapter.cc
    • content/browser/media/mojo_audio_logging_adapter.h
    • media/mojo/interfaces/audio_logging.mojom
  99. Add service worker README.md.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:46:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

    Comments

    Add service worker README.md.
    
    Bug: 795989
    Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d
    Reviewed-on: https://chromium-review.googlesource.com/1134718
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574507}

    Changed files

    • content/browser/service_worker/README.md
    • content/common/service_worker/README.md
    • third_party/blink/common/service_worker/README.md
    • third_party/blink/public/common/service_worker/README.md
    • third_party/blink/public/mojom/service_worker/README.md
    • third_party/blink/public/platform/modules/service_worker/README.md
    • third_party/blink/public/web/modules/service_worker/README.md
    • third_party/blink/renderer/modules/service_worker/README.md
  100. Use PLM for data saver site-breakdown

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74f3e3d131a093053a5e5f737e162c99e1c69e62

    Comments

    Use PLM for data saver site-breakdown
    
    This CL adds PLM observer for site-breakdown that records the data use
    by host. The new codepath is enabled and the old data use asriber observer
    based site-breakdown codepath is disabled, based on a feature.
    
    Bug: 836029
    Change-Id: I667d0dc6e0227c83a46d353b2feffaec9043a219
    Reviewed-on: https://chromium-review.googlesource.com/1050868
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574506}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
    • chrome/test/BUILD.gn
    • components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>