Home | Search | chromium - Builders
Login

Builder ios-uirefresh-simulator Build 219 Apple OSX

Results:

Failure Uncaught Exception

Trigger Info:

Projectchromium
Revisiona32928f26183dce010284f0abcee28508e44a6f8
Got Revisiona32928f26183dce010284f0abcee28508e44a6f8

Execution:

Steps and Logfiles:

Show:
  1. ( 156 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 362 ms ) remove .cipd
  3. ( 1 mins 16 secs ) bot_update
    [79GB/232GB used (34%)]
  4. ( 275 ms ) read build config
  5. ( 0 ) ensure_goma
  6. ( 0 ) ensure xcode
    Ensuring Xcode version 9c40b in /b/s/w/ir/cache/xcode_ios_9c40b.app
  7. ( 12 secs ) gclient runhooks
  8. ( 2 mins 41 secs ) compile
  9. ( 0 ) isolate
  10. ( 403 ms ) isolate.generate 0.isolate.gen.json
    ios_chrome_unittests (iPhone 5s iOS 11.2)
  11. ( 402 ms ) isolate.generate 1.isolate.gen.json
    ios_net_unittests (iPhone 5s iOS 11.2)
  12. ( 404 ms ) isolate.generate 2.isolate.gen.json
    ios_web_inttests (iPhone 5s iOS 11.2)
  13. ( 402 ms ) isolate.generate 3.isolate.gen.json
    ios_web_unittests (iPhone 5s iOS 11.2)
  14. ( 403 ms ) isolate.generate 4.isolate.gen.json
    ios_web_view_inttests (iPhone 5s iOS 11.2)
  15. ( 403 ms ) isolate.generate 5.isolate.gen.json
    ios_chrome_unittests (iPhone X iOS 11.2)
  16. ( 404 ms ) isolate.generate 6.isolate.gen.json
    ios_net_unittests (iPhone X iOS 11.2)
  17. ( 403 ms ) isolate.generate 7.isolate.gen.json
    ios_web_inttests (iPhone X iOS 11.2)
  18. ( 402 ms ) isolate.generate 8.isolate.gen.json
    ios_web_unittests (iPhone X iOS 11.2)
  19. ( 400 ms ) isolate.generate 9.isolate.gen.json
    ios_web_view_inttests (iPhone X iOS 11.2)
  20. ( 402 ms ) isolate.generate 10.isolate.gen.json
    ios_chrome_unittests (iPad Air iOS 11.2)
  21. ( 402 ms ) isolate.generate 11.isolate.gen.json
    ios_net_unittests (iPad Air iOS 11.2)
  22. ( 402 ms ) isolate.generate 12.isolate.gen.json
    ios_web_inttests (iPad Air iOS 11.2)
  23. ( 400 ms ) isolate.generate 13.isolate.gen.json
    ios_web_unittests (iPad Air iOS 11.2)
  24. ( 402 ms ) isolate.generate 14.isolate.gen.json
    ios_web_view_inttests (iPad Air iOS 11.2)
  25. ( 400 ms ) isolate.generate 15.isolate.gen.json
    base_unittests (iPhone 6 iOS 11.2)
  26. ( 402 ms ) isolate.generate 16.isolate.gen.json
    components_unittests (iPhone 6 iOS 11.2)
  27. ( 402 ms ) isolate.generate 17.isolate.gen.json
    gfx_unittests (iPhone 6 iOS 11.2)
  28. ( 403 ms ) isolate.generate 18.isolate.gen.json
    ios_chrome_unittests (iPhone 6 iOS 11.2)
  29. ( 401 ms ) isolate.generate 19.isolate.gen.json
    ios_web_inttests (iPhone 6 iOS 11.2)
  30. ( 402 ms ) isolate.generate 20.isolate.gen.json
    ios_web_unittests (iPhone 6 iOS 11.2)
  31. ( 400 ms ) isolate.generate 21.isolate.gen.json
    ios_web_view_inttests (iPhone 6 iOS 11.2)
  32. ( 404 ms ) isolate.generate 22.isolate.gen.json
    ios_web_view_unittests (iPhone 6 iOS 11.2)
  33. ( 402 ms ) isolate.generate 23.isolate.gen.json
    skia_unittests (iPhone 6 iOS 11.2)
  34. ( 405 ms ) isolate.generate 24.isolate.gen.json
    ui_base_unittests (iPhone 6 iOS 11.2)
  35. ( 403 ms ) isolate.generate 25.isolate.gen.json
    base_unittests (iPad Air iOS 11.2)
  36. ( 402 ms ) isolate.generate 26.isolate.gen.json
    components_unittests (iPad Air iOS 11.2)
  37. ( 401 ms ) isolate.generate 27.isolate.gen.json
    gfx_unittests (iPad Air iOS 11.2)
  38. ( 402 ms ) isolate.generate 28.isolate.gen.json
    ios_chrome_unittests (iPad Air iOS 11.2)
  39. ( 403 ms ) isolate.generate 29.isolate.gen.json
    ios_web_inttests (iPad Air iOS 11.2)
  40. ( 381 ms ) isolate.generate 30.isolate.gen.json
    ios_web_unittests (iPad Air iOS 11.2)
  41. ( 359 ms ) isolate.generate 31.isolate.gen.json
    ios_web_view_inttests (iPad Air iOS 11.2)
  42. ( 352 ms ) isolate.generate 32.isolate.gen.json
    ios_web_view_unittests (iPad Air iOS 11.2)
  43. ( 353 ms ) isolate.generate 33.isolate.gen.json
    skia_unittests (iPad Air iOS 11.2)
  44. ( 352 ms ) isolate.generate 34.isolate.gen.json
    ui_base_unittests (iPad Air iOS 11.2)
  45. ( 352 ms ) isolate.generate 35.isolate.gen.json
    ios_chrome_integration_egtests (iPhone X iOS 11.2)
  46. ( 368 ms ) isolate.generate 36_0.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 0
  47. ( 352 ms ) isolate.generate 36_1.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 1
  48. ( 351 ms ) isolate.generate 36_2.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 2
  49. ( 355 ms ) isolate.generate 36_3.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 3
  50. ( 352 ms ) isolate.generate 37.isolate.gen.json
    ios_web_shell_egtests (iPhone X iOS 11.2)
  51. ( 356 ms ) isolate.generate 38.isolate.gen.json
    ios_chrome_integration_egtests (iPad Air iOS 11.2)
  52. ( 356 ms ) isolate.generate 39_0.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air iOS 11.2) shard 0
  53. ( 353 ms ) isolate.generate 39_1.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air iOS 11.2) shard 1
  54. ( 354 ms ) isolate.generate 39_2.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air iOS 11.2) shard 2
  55. ( 353 ms ) isolate.generate 39_3.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air iOS 11.2) shard 3
  56. ( 354 ms ) isolate.generate 40.isolate.gen.json
    ios_web_shell_egtests (iPad Air iOS 11.2)
  57. ( 354 ms ) isolate.generate 41.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPhone X iOS 11.2)
  58. ( 352 ms ) isolate.generate 42.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPhone X iOS 11.2)
  59. ( 349 ms ) isolate.generate 43.isolate.gen.json
    ios_chrome_web_egtests (iPhone X iOS 11.2)
  60. ( 353 ms ) isolate.generate 44.isolate.gen.json
    ios_chrome_settings_egtests (iPhone X iOS 11.2)
  61. ( 351 ms ) isolate.generate 45.isolate.gen.json
    ios_chrome_payments_egtests (iPhone X iOS 11.2)
  62. ( 354 ms ) isolate.generate 46.isolate.gen.json
    ios_chrome_reading_list_egtests (iPhone X iOS 11.2)
  63. ( 353 ms ) isolate.generate 47.isolate.gen.json
    ios_showcase_egtests (iPhone X iOS 11.2)
  64. ( 351 ms ) isolate.generate 48.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPad Air iOS 11.2)
  65. ( 354 ms ) isolate.generate 49.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPad Air iOS 11.2)
  66. ( 352 ms ) isolate.generate 50.isolate.gen.json
    ios_chrome_web_egtests (iPad Air iOS 11.2)
  67. ( 356 ms ) isolate.generate 51.isolate.gen.json
    ios_chrome_settings_egtests (iPad Air iOS 11.2)
  68. ( 352 ms ) isolate.generate 52.isolate.gen.json
    ios_chrome_payments_egtests (iPad Air iOS 11.2)
  69. ( 357 ms ) isolate.generate 53.isolate.gen.json
    ios_chrome_reading_list_egtests (iPad Air iOS 11.2)
  70. ( 352 ms ) isolate.generate 54.isolate.gen.json
    ios_showcase_egtests (iPad Air iOS 11.2)
  71. ( 2 mins 20 secs ) isolate.archive
  72. ( 0 ) trigger
  73. ( 2 ms ) Uncaught Exception
    Uncaught Exception: AssertionError('Triggered same task twice: ios_chrome_unittests (iPad Air iOS 11.2)/Mac/0caccc4b4b/ios-uirefresh-simulator/219',)
  74. ( 1 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build112-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531401187814140, "id": "8941203184045410080", "project": "chromium", "tags": ["builder:ios-uirefresh-simulator", "buildset:commit/git/a32928f26183dce010284f0abcee28508e44a6f8", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/a32928f26183dce010284f0abcee28508e44a6f8", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106633246169772368", "scheduler_job_id:chromium/ios-uirefresh-simulator", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-uirefresh-simulator" setup_build
buildnumber 219 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "a32928f26183dce010284f0abcee28508e44a6f8" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "a32928f26183dce010284f0abcee28508e44a6f8" bot_update
got_revision_cp "refs/heads/master@{#574545}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update

Blamelist:

  1. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
  2. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  4. Emily Hanley (eyaichohnoyoudont@google.com)
  5. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  6. Yoshisato Yanagisawa (yyanagisawaohnoyoudont@chromium.org)
  7. Mike West (mkwstohnoyoudont@chromium.org)
  8. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  9. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  10. Kent Tamura (tkentohnoyoudont@chromium.org)
  11. Ivan Sandrk (isandrkohnoyoudont@google.com)
  12. Mike West (mkwstohnoyoudont@chromium.org)
  13. Arthur Hemery (ahemeryohnoyoudont@chromium.org)
  14. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  15. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  16. Shik Chen (shikohnoyoudont@chromium.org)
  17. Benoit Lize (lizebohnoyoudont@chromium.org)
  18. Peter Mayo (petermayoohnoyoudont@chromium.org)
  19. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  20. Mathieu Perreault (mathpohnoyoudont@chromium.org)
  21. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  22. Philip Jägenstedt (foolipohnoyoudont@chromium.org)
  23. Mike West (mkwstohnoyoudont@chromium.org)
  24. afdo-chromium-autoroll (afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  25. Tatsuhisa Yamaguchi (yamaguchiohnoyoudont@chromium.org)
  26. Rohit Rao (rohitraoohnoyoudont@chromium.org)
  27. Mark Cogan (marqohnoyoudont@google.com)
  28. Mike West (mkwstohnoyoudont@chromium.org)
  29. Stefan Teodorescu (faneohnoyoudont@google.com)
  30. Han Leon (leon.hanohnoyoudont@intel.com)
  31. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  32. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  33. Mike West (mkwstohnoyoudont@chromium.org)
  34. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  35. Colin Blundell (blundellohnoyoudont@chromium.org)
  36. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  37. Raphael Kubo da Costa (CET) (raphael.kubo.da.costaohnoyoudont@intel.com)
  38. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  39. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  40. rajendrant (rajendrantohnoyoudont@chromium.org)
  41. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  42. Aleks Totic (atoticohnoyoudont@chromium.org)
  43. Makoto Shimazu (shimazuohnoyoudont@chromium.org)
  44. Anita Woodruff (awdfohnoyoudont@chromium.org)
  45. Hitoshi Yoshida (periaohnoyoudont@chromium.org)
  46. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  47. Alan Cutter (alancutterohnoyoudont@chromium.org)
  48. Marc Treib (treibohnoyoudont@chromium.org)
  49. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
  50. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  51. cathiechen (cathiechenohnoyoudont@tencent.com)
  52. Stefan Zager (szagerohnoyoudont@chromium.org)
  53. Jun Mukai (mukaiohnoyoudont@chromium.org)
  54. rbpotter (rbpotterohnoyoudont@chromium.org)
  55. Lei Zhang (thestigohnoyoudont@chromium.org)
  56. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  57. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  58. Koji Ishii (kojiiohnoyoudont@chromium.org)
  59. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  60. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  61. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  62. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  63. Nicholas Verne (nverneohnoyoudont@chromium.org)
  64. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  65. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  66. Yuri Wiitala (miuohnoyoudont@chromium.org)
  67. Derek Cheng (imchengohnoyoudont@chromium.org)
  68. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  69. Brian Salomon (bsalomonohnoyoudont@google.com)
  70. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  71. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  72. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  73. Victor Costan (pwnallohnoyoudont@chromium.org)
  74. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  75. Kenichi Ishibashi (bashiohnoyoudont@chromium.org)
  76. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  77. Halton Huo (halton.huoohnoyoudont@gmail.com)
  78. Maks Orlovich (morlovichohnoyoudont@chromium.org)
  79. tzik (tzikohnoyoudont@chromium.org)
  80. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  81. Yuichiro Hanada (yhanadaohnoyoudont@chromium.org)
  82. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  83. Scott Violet (skyohnoyoudont@chromium.org)
  84. sawtelle (sawtelleohnoyoudont@google.com)
  85. Tetsui Ohkubo (tetsuiohnoyoudont@chromium.org)
  86. Kenneth Russell (kbrohnoyoudont@chromium.org)
  87. Michael Giuffrida (michaelpgohnoyoudont@chromium.org)
  88. Karan Bhatia (karandeepbohnoyoudont@chromium.org)
  89. Daniel Park (danielparkohnoyoudont@chromium.org)
  90. Xiangjun Zhang (xjzohnoyoudont@chromium.org)
  91. angle-chromium-autoroll (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  92. Scott Haseley (shaseleyohnoyoudont@google.com)
  93. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  94. Darren Shen (shendohnoyoudont@chromium.org)
  95. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  96. Scott Wu (scottwuohnoyoudont@chromium.org)
  97. Ken Rockot (rockotohnoyoudont@chromium.org)
  98. Alexey Baskakov (loysoohnoyoudont@chromium.org)
  99. Michael Giuffrida (michaelpgohnoyoudont@chromium.org)
  100. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  101. <blame list capped at 100 commits> ()

Timing:

Create Thursday, 12-Jul-18 13:13:07 UTC
Start Thursday, 12-Jul-18 13:13:30 UTC
End Thursday, 12-Jul-18 13:22:40 UTC
Pending 23 secs
Execution 9 mins 9 secs

All Changes:

  1. Avoid incomplete live region text change announcements

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:04:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a32928f26183dce010284f0abcee28508e44a6f8

    Comments

    Avoid incomplete live region text change announcements
    
    When a live region change occurs we sometimes fire text change events
    for only part of the text. For example, if "car" changes to "cat", we
    fire an event that makes it look like only the "t" changed.
    
    This changes the heuristic so that when a live region occurs that is
    not in an editor, it will prefer to indicate that entire text nodes
    have changed.
    
    Bug: 778478
    Change-Id: If87f1ac8c9c0b237bd422e8b7217d8d0347a13ab
    Reviewed-on: https://chromium-review.googlesource.com/1134201
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574545}

    Changed files

    • content/test/data/accessibility/event/description-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/name-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
    • ui/accessibility/platform/ax_platform_node_win.h
  2. Roll src/third_party/pdfium 68d04f284423..5ff09fb5ee90 (2 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 13:03:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0aeff28f34f12485a9148321c00383c633d48c63

    Comments

    Roll src/third_party/pdfium 68d04f284423..5ff09fb5ee90 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/68d04f284423..5ff09fb5ee90
    
    
    git log 68d04f284423..5ff09fb5ee90 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 art-snake@yandex-team.ru Remove CPDF_HintTables::GetItemLength()
    2018-07-12 art-snake@yandex-team.ru Implement CPDF_HintsTable::SharedObjGroupInfo.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@5ff09fb5ee90
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I687479f194e638319b40fa5357179d8144f4b197
    Reviewed-on: https://chromium-review.googlesource.com/1134948
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574544}

    Changed files

    • DEPS
  3. Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 13:03:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e1637ff7a416934beedc7a637455779b85f6042

    Comments

    Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)
    
    https://webrtc.googlesource.com/src.git/+log/5795489e83ad..58c79f66dd3a
    
    
    git log 5795489e83ad..58c79f66dd3a --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 saza@webrtc.org Add saza to fuzzer owners
    2018-07-12 ilnik@webrtc.org Temporarly disable KSVC perf tests on Mac because of crashes
    2018-07-12 mbonadei@webrtc.org Removing -Wno-reorder from audio_device.
    2018-07-12 danilchap@webrtc.org Fix buffer overflow in ulpfec recovery
    2018-07-12 danilchap@webrtc.org Fix handling invalid empty red packets
    2018-07-12 buildbot@webrtc.org Roll chromium_revision 720dadbc21..efbdada3f7 (574387:574489)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@58c79f66dd3a
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:856823,chromium:856823,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I2e736098249694bb9480b4f170b065e60ddd44a2
    Reviewed-on: https://chromium-review.googlesource.com/1134949
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574543}

    Changed files

    • DEPS
  4. Updating names for job triggers on nexus5x and win 10 perf

    Changed by Emily Hanley - eyaichohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:55:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896ba71bc975b53346521228a32536296ea5d80e

    Comments

    Updating names for job triggers on nexus5x and win 10 perf
    
    Dependent on crrev.com/c/1131227
    
    NOTRY=True
    
    Bug: 758326
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: Icd5c18a166e815be5c2570cafd511bae4c545975
    Reviewed-on: https://chromium-review.googlesource.com/1131230
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574542}

    Changed files

    • infra/config/global/luci-milo-dev.cfg
    • infra/config/global/luci-milo.cfg
    • testing/buildbot/chromium.perf.json
    • tools/perf/core/perf_data_generator.py
  5. [unified-consent] USER_EVENT has its own sync pref group

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:50:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4432c3f9d16a93276eeb9c60a860190223888d96

    Comments

    [unified-consent] USER_EVENT has its own sync pref group
    
    This CL passes the information that unified consent is enabled to
    the sync service. It then uses it to move USER_EVENTS data type in
    a separate pref group (instead of having it tied to TYPED_URLS as
    before).
    
    The goal is not to un-link USER_EVENTS from HISTORY, but to have a
    separate toggle for USER_EVENTS (which will be linked to HISTORY toggle
    in the toggle UI).
    
    Unit tests have been updated accordingly.
    
    Bug: 860515
    
    Change-Id: Ic5461470114c0b05ec770817890c9123b81f3d77
    Reviewed-on: https://chromium-review.googlesource.com/1128876
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574541}

    Changed files

    • chrome/browser/android/contextualsearch/contextual_search_delegate.cc
    • chrome/browser/sync/profile_sync_service_factory.cc
    • chrome/browser/sync/test/integration/enable_disable_test.cc
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
    • components/sync/base/sync_prefs.cc
    • components/sync/base/sync_prefs.h
    • components/sync/base/sync_prefs_unittest.cc
  6. compare_build_artifacts: make ninja path command line option.

    Changed by Yoshisato Yanagisawa - yyanagisawaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:49:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3f55b21a7a48593a9ce1622346dad112a8b2e2f

    Comments

    compare_build_artifacts: make ninja path command line option.
    
    ninja seems not be in PATH when compare_build_artifacts.py is executed.
    Then compare_build_artifacts cannot compare object files difference,
    and just fails with exception.
    To fix that, let me make ninja path given with command line option.
    
    Bug: 862917
    Change-Id: Ieb7d7bd1db30217222f5cd5006e120244da28fd5
    Reviewed-on: https://chromium-review.googlesource.com/1134710
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574540}

    Changed files

    • tools/determinism/compare_build_artifacts.py
  7. Mark several layout tests as flaky.

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:44:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704b3f013b80c7a5f93296e3d146758d5c0b0ccc

    Comments

    Mark several layout tests as flaky.
    
    - css3/filters/effect-brightness-clamping-hw.html
    - virtual/gpu/fast/canvas/canvas-blending-image-over-image.html
    - css3/filters/effect-drop-shadow-hw.html
    - external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862716, 862729, 862806, 862826
    Change-Id: I08126b22afdc0a7a4ef776dde8cc1120643acdcc
    Reviewed-on: https://chromium-review.googlesource.com/1134990
    Commit-Queue: Mike West <mkwst@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574539}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  8. macviews: switch back to Cocoa menus for Views context menus

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b56c4e40b65ee14134dd2e61834f260ca9c1715e

    Comments

    macviews: switch back to Cocoa menus for Views context menus
    
    This change:
    1) Reverts erikchen@'s 79c8511fb8801f7fc23c4cbe81311b6065daef15, which removed
       the Cocoa menu runner code;
    2) Wires the Cocoa menu runner code back up in MenuRunnerImplInterface::Create;
    3) Fixes a latent bug in Textfield that could cause it to delete its context
       menu while handling a context menu activation - this is fine with Views menus
       but forbidden with Cocoa menus.
    
    Bug: 860673
    Change-Id: If110f09379c4661a4f61a8b0257cf5214503e6a9
    Reviewed-on: https://chromium-review.googlesource.com/1131564
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574538}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/controls/menu/menu_runner_cocoa_unittest.mm
    • ui/views/controls/menu/menu_runner_impl.cc
    • ui/views/controls/menu/menu_runner_impl_cocoa.h
    • ui/views/controls/menu/menu_runner_impl_cocoa.mm
    • ui/views/controls/textfield/textfield.cc
    • ui/views/controls/textfield/textfield_unittest.cc
  9. Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:32:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78a0a24222fde0f77a45d4f78b1f4502496c434e

    Comments

    Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/c228d491eb86..3973c26575e2
    
    
    git log c228d491eb86..3973c26575e2 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 dhanyaganesh@chromium.org CreateTarball: Add debug code with lsof
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@3973c26575e2
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Iabf74616719c8b90e6b34c6576772eeb313a7183
    Reviewed-on: https://chromium-review.googlesource.com/1134906
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574537}

    Changed files

    • DEPS
  10. Oilpan: Do not include wtf/functional.h

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb

    Comments

    Oilpan: Do not include wtf/functional.h
    
    No one in platform/heap/ needs wtf/functional.h, though persistent.h
    needs base/bind.h for IsWeakReceiver<> and BindUnwrapTraits<>.
    
    This CL reduces the pre-processed size of handle.h by 31KB.
    
    Bug: 242216
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I6097a6f22dbe7a762f4b0a23560c731a07daf5ce
    Reviewed-on: https://chromium-review.googlesource.com/1134809
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574536}

    Changed files

    • third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
    • third_party/blink/renderer/modules/budget/budget_service.cc
    • third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
    • third_party/blink/renderer/modules/filesystem/directory_reader.cc
    • third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc
    • third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
    • third_party/blink/renderer/modules/locks/lock.cc
    • third_party/blink/renderer/modules/mediastream/media_devices_test.cc
    • third_party/blink/renderer/modules/payments/payment_manager.cc
    • third_party/blink/renderer/modules/service_worker/respond_with_observer.cc
    • third_party/blink/renderer/modules/webusb/usb_device.cc
    • third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/skia_texture_holder.h
    • third_party/blink/renderer/platform/heap/persistent.h
    • third_party/blink/renderer/platform/heap/thread_state.h
    • third_party/blink/renderer/platform/testing/empty_web_media_player.h
    • third_party/blink/renderer/platform/testing/unit_test_helpers.cc
  11. Add UMA for locked-fullscreen state

    Changed by Ivan Sandrk - isandrkohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:29:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fe933a784678f6aa62203b7d57a638051c15f2a

    Comments

    Add UMA for locked-fullscreen state
    
    Locked-fullscreen state will be used for giving student quizzes on managed
    Chrome OS devices in schools. Add a UMA to track feature adoption.
    
    Change-Id: I59f809e2aecd67a4e9f10ee21a28658796c03b15
    Reviewed-on: https://chromium-review.googlesource.com/1126241
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574535}

    Changed files

    • chrome/browser/extensions/api/tabs/tabs_api.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  12. Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84356c12447981846eda650f06085913fa831126

    Comments

    Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862907
    Change-Id: If6ce15cb1633ae74177e385774a1cef7010e67c0
    Reviewed-on: https://chromium-review.googlesource.com/1134989
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574534}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  13. Navigation: Refactoring WebContents unittests to use NavigationSimulator

    Changed by Arthur Hemery - ahemeryohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:20:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c65bc1abc46c630c53a3e21bb0670dc602e8d37d

    Comments

    Navigation: Refactoring WebContents unittests to use NavigationSimulator
    
    Removed the usage of TestWebContents->DidNavigate variants in
    web_contents_impl_unittest.cc. Some usage remains, linked to
    overlapping navigations and other specific usages.
    
    Bug: 728571
    Change-Id: Ie2d6b73cb5deea077f720114fdd45ab4ee714c0a
    Reviewed-on: https://chromium-review.googlesource.com/1076240
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Commit-Queue: Arthur Hemery <ahemery@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574533}

    Changed files

    • content/browser/web_contents/web_contents_impl_unittest.cc
  14. Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a66959734236ca95f9372334bfa18bbc7a5a1b52

    Comments

    Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)
    
    https://skia.googlesource.com/skia.git/+log/fcc10da18eb5..4d6a844365e7
    
    
    git log fcc10da18eb5..4d6a844365e7 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
    2018-07-12 herb@google.com Use new SkGlyphIDSet - v3
    2018-07-12 bungeman@google.com Remove SkDrawFilter.
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5c8113d3c20f..5598148b7613 (8 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 robertphillips@google.com Revert "build debug on linux for gdb"
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 caryclark@google.com build debug on linux for gdb
    2018-07-12 benjaminwagner@google.com Update Win10 in Skolo.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@4d6a844365e7
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ifd4c74ca893ddae66e41fe10ff663287be1cf325
    Reviewed-on: https://chromium-review.googlesource.com/1134148
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574532}

    Changed files

    • DEPS
  15. Activate widget correctly when the inline reply opens on ARC notification

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

    Comments

    Activate widget correctly when the inline reply opens on ARC notification
    
    When a non-ARC normal window (eg. Chrome browser window) was active, the
    inline textbox didn't work for the second time and later. This CL solves
    this issue.
    
    This was because the widget was not activated correctly (IsActive() was
    true but CanActivate() was false) in that case. This CL removes the
    IsActive() guard to make the widget active correctly whenever the inline
    reply opens.
    
    Bug: b/111100376
    Bug: 858938
    Test: manual (inline reply can be used multiple times)
    
    Change-Id: I65d7604be5d24ff1e6c56336a76a5951d6066b39
    Reviewed-on: https://chromium-review.googlesource.com/1133039
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574531}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
  16. media: sync the camera metadata definitions

    Changed by Shik Chen - shikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38884d4717c2517cb832722d0fa4871a89d19799

    Comments

    media: sync the camera metadata definitions
    
    We need some new metadata tags for external camera, so regenerate and
    sync all of them in arc-camera, chromium, and ARC++.
    
    Some "arc" are replaced by "cros" manually.
    
    BUG=b:77833131
    TEST=Verify CCA works on Nautilus.
    
    Change-Id: I308e258d9b72acdd825591041a67ce7352dce6a8
    Reviewed-on: https://chromium-review.googlesource.com/1117970
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Shik Chen <shik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574530}

    Changed files

    • media/capture/video/chromeos/mojo/camera_metadata_tags.mojom
  17. blink/wtf: Really move MovableStrings when DCHECK_IS_ON.

    Changed by Benoit Lize - lizebohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:09:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1fef2b1ad38fe1ef8c3914fb5dadc39bae80b9b

    Comments

    blink/wtf: Really move MovableStrings when DCHECK_IS_ON.
    
    When a MovableString is parked, actually park the content, and poison
    the previous allocation. This is intended to find cached raw pointer
    accesses, which are not allowed beyond the UI thread task per the
    contract of the class.
    Enabled only when DCHECK_IS_ON to prevent potential crashes.
    
    Changes with and without DCHECK()s:
    - Cache some String properties in MovableStringImpl
    - Add a parked_strings_ to MovableStringTable for accounting, and
      update tests accordingly.
    
    Changes with DCHECK()s:
    - Add a parked_string_ member to MovableStringImpl
    - Copy the string to the parked version in Park(), and poison the
      previous allocation.
    - Restore the string in Unpark().
    
    Bug: 837659
    Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
    Reviewed-on: https://chromium-review.googlesource.com/1133169
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574529}

    Changed files

    • third_party/blink/renderer/platform/wtf/text/movable_string.cc
    • third_party/blink/renderer/platform/wtf/text/movable_string.h
    • third_party/blink/renderer/platform/wtf/text/movable_string_test.cc
  18. Re-enable opening-handshake/003-sets-origin.worker.html

    Changed by Peter Mayo - petermayoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:58:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d18929b41e24487865c4ed9da46129e6b037beeb

    Comments

    Re-enable opening-handshake/003-sets-origin.worker.html
    
    These tests no longer timeout.  The flakiness dashboard is green
    for a long time.
    
    Bug: 803558
    Change-Id: I2924740d2c736419fdc5130e546f557c8d874151
    Reviewed-on: https://chromium-review.googlesource.com/1134094
    Reviewed-by: Robert Ma <robertma@chromium.org>
    Commit-Queue: Peter Mayo <petermayo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574528}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  19. [Fetch] Use wrapper tracing to express references between wrappers

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:53:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a7c8ee607674efabc720016992893e2226ce3a0

    Comments

    [Fetch] Use wrapper tracing to express references between wrappers
    
    This is a reland of
    https://crrev.com/8057f58cb22579bc685efa50c579325ed047d51a which has
    been reverted due to a crash issue. The crash was caused by a missing
    TraceWrapperMember in blink::Response. This CL fixes that, and adds
    a layout test to verify that.
    
    Original CL: https://chromium-review.googlesource.com/c/1124270
    
    Bug: 862440
    Change-Id: I2842b957f223cfb32fee2aa9048b550010cb2e45
    Reviewed-on: https://chromium-review.googlesource.com/1134642
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574527}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/fetch/chromium/body-wrapper-tracing.html
    • third_party/blink/renderer/core/fetch/body_stream_buffer.cc
    • third_party/blink/renderer/core/fetch/body_stream_buffer.h
    • third_party/blink/renderer/core/fetch/fetch_request_data.cc
    • third_party/blink/renderer/core/fetch/fetch_request_data.h
    • third_party/blink/renderer/core/fetch/fetch_response_data.cc
    • third_party/blink/renderer/core/fetch/fetch_response_data.h
    • third_party/blink/renderer/core/fetch/request.cc
    • third_party/blink/renderer/core/fetch/request.h
    • third_party/blink/renderer/core/fetch/response.cc
    • third_party/blink/renderer/core/fetch/response.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/platform/bindings/v8_private_property.h
  20. [NTP] Adding mathp@ as owner of components/search

    Changed by Mathieu Perreault - mathpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1bc34891c3dbe8da1ac513111db7c7d2efd56f20

    Comments

    [NTP] Adding mathp@ as owner of components/search
    
    Few reasons for this:
    - My team and myself are now owners of the feature
    - Both current owners are gone through the end of July
    - I am owners of other parts of the NTP code (resources, data sources) as well
      as server-side code; as such, I think I'm qualified.
    
    Bug: None
    Change-Id: Ic1261dacba81a420500240c5a55bc547fb8b6c14
    Reviewed-on: https://chromium-review.googlesource.com/1133767
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574526}

    Changed files

    • components/search/OWNERS
  21. Roll src/third_party/pdfium d8882193737a..68d04f284423 (1 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:28:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1f9c10c3ca23a47aa60fe21a5b990c9d7cd589a

    Comments

    Roll src/third_party/pdfium d8882193737a..68d04f284423 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/d8882193737a..68d04f284423
    
    
    git log d8882193737a..68d04f284423 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 art-snake@yandex-team.ru Reland "Avoid duplicate data buffering in CPDF_SyntaxParser::ReadStream()."
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@68d04f284423
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I09ab0d06005fa49756095e583c16e039d0c8df3c
    Reviewed-on: https://chromium-review.googlesource.com/1134846
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574525}

    Changed files

    • DEPS
  22. Mark textdecoder-fatal-single-byte.any.worker.html flaky to unblock WPT import

    Changed by Philip Jägenstedt - foolipohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dea5439837339b97168cdbbf6a45bfa27748b16

    Comments

    Mark textdecoder-fatal-single-byte.any.worker.html flaky to unblock WPT import
    
    TBR=robertma
    
    Bug: 862938
    Change-Id: I9ceda537526da02ebadc9799d58fb042d7f339d3
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1134770
    Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574524}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  23. Revert "Make NetworkConnectionTracker survive network service crashes and restarts"

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:11:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 197e9188dc5be69cb34e1ebd67f86a1146439367

    Comments

    Revert "Make NetworkConnectionTracker survive network service crashes and restarts"
    
    This reverts commit cec0800c372ef670f59999fb3f028013d36b866c.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified this CL at revision 574314 as the culprit
    for introducing flakiness in the tests as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2VjMDgwMGMzNzJlZjY3MGY1OTk5OWZiM2YwMjgwMTNkMzZiODY2Yww
    
    TBR=xunjieli@chromium.org
    
    Bug: 862883
    
    Original change's description:
    > Make NetworkConnectionTracker survive network service crashes and restarts
    > 
    > This CL is to mirror tbansal@'s CL
    > (https://chromium-review.googlesource.com/1058528) to make
    > NetworkConnectionTracker survice network service's crashes and restarts.
    > 
    > Bug: 821009
    > Change-Id: Iec33797c0fd0ce12a8e5fdab9fda0a710eb9a528
    > Reviewed-on: https://chromium-review.googlesource.com/1120738
    > Commit-Queue: Helen Li <xunjieli@chromium.org>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574314}
    
    TBR=jam@chromium.org,xunjieli@chromium.org,tbansal@chromium.org
    
    Change-Id: I2524f0e04441097e06585f4f2e4cdb948a419641
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 821009
    Reviewed-on: https://chromium-review.googlesource.com/1135006
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574523}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc
  24. Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1

    Changed by afdo-chromium-autoroll - afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a837f9d78ab2670ad242acd3651e0bf1f29a2a39

    Comments

    Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    The AutoRoll server is located here: https://afdo-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I0095acd5d9522beaf64a43baf3bb71106038fe7c
    Reviewed-on: https://chromium-review.googlesource.com/1134870
    Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574522}

    Changed files

    • chrome/android/profiles/newest.txt
  25. Always align slider bubbles to the bottom of the desktop.

    Changed by Tatsuhisa Yamaguchi - yamaguchiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:06:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a0ab14f53bb9b6346969ec10d376d51aff8eceb

    Comments

    Always align slider bubbles to the bottom of the desktop.
    
    The slider was aligned towards the system tray icon view in the shelf
    by the bubble's bottom edge. It meant that the slider bubble was shown
    apart from the bottom of the desktop when the shelf layout is either
    right or left. It was not consistent with popup notification, causing
    view overlap between notifications and a slider bubble.
    
    Bug: 862496
    Change-Id: Ie6db618f8b744ecc4de52ee7a4866ca9e9ecd26c
    Reviewed-on: https://chromium-review.googlesource.com/1134643
    Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574521}

    Changed files

    • ash/system/unified/unified_slider_bubble_controller.cc
  26. [ios] Adds icons and hides headers on the main Settings page.

    Changed by Rohit Rao - rohitraoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:00:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f5527a3ed5e88090ce316b8afac85c39cbb0ba8

    Comments

    [ios] Adds icons and hides headers on the main Settings page.
    
    Screenshot: https://drive.google.com/file/d/16aS0MP0LwdGOq8-IJgtIbq4ozXy44meT/view?usp=sharing
    
    BUG=805213,805214
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iccdd87d8f95fd80b51fcdcfa2caa691c7fcd78b4
    Reviewed-on: https://chromium-review.googlesource.com/1133323
    Reviewed-by: edchin <edchin@chromium.org>
    Commit-Queue: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574520}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
    • ios/chrome/browser/ui/settings/resources/BUILD.gn
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@3x.png
    • ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
  27. [iOS] Tweak tab grid transition animations.

    Changed by Mark Cogan - marqohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:57:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e96b9e2a058ddc4573deba9c0159077c8a89b45d

    Comments

    [iOS] Tweak tab grid transition animations.
    
    This CL adjusts the tab grid transition animations.
    
    (A) The timing (curve, delay, and duration) of some of the sub-animations is tweaked.
    
    (B) Because -viewWillAppear: is called inside the animation, some of the
        setup for the animations needs to be done before that method is called;
        the cleanest mechanism seemed to be to make these changes when the view
        disappeared. This is mostly setting the toolbar alpha to zero so it can be
        faded in during the animation.
    
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I8c84f5726a0ce49e13c5fd32ab91295ffbb00e57
    Reviewed-on: https://chromium-review.googlesource.com/1127994
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574519}

    Changed files

    • ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
    • ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm
  28. Disabling ViewIDTest.Basic.

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:52:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fc8ad7e2561f48248fee640b72a808f1592634a

    Comments

    Disabling ViewIDTest.Basic.
    
    This test is consistently failing on:
    
    * 10.11 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018
    * 10.12 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14366
    * 10.13 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4145
    
    TBR=mkwst@chromium.org,kpaulhamus@chromium.org
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862945
    Change-Id: I9156862b472f2ad993f9da7d709b75baaddc2908
    Reviewed-on: https://chromium-review.googlesource.com/1134780
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574518}

    Changed files

    • chrome/browser/ui/cocoa/view_id_util_browsertest.mm
  29. Fix description of NetworkPredictionOptions policy

    Changed by Stefan Teodorescu - faneohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:46:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d8142d8da58d317cc159294a6b9c6139e7173b1

    Comments

    Fix description of NetworkPredictionOptions policy
    
    Removed unnecessary preference names from description.
    
    Bug: 858829
    Change-Id: Ic75e9af5ebca5e56c20e796e1991a217ad427246
    Reviewed-on: https://chromium-review.googlesource.com/1131115
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Commit-Queue: Stefan Teodorescu <fane@google.com>
    Cr-Commit-Position: refs/heads/master@{#574517}

    Changed files

    • components/policy/resources/policy_templates.json
  30. [ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo

    Changed by Han Leon - leon.hanohnoyoudont@intel.com
    Changed at Thursday, 12-Jul-18 09:45:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d00d598cb4ae00510a30326c3db46f9b0506e36d

    Comments

    [ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo
    
    This CL removes native struct ServiceWorkerProviderHostInfo and the
    corresponding typemapping for it, instead, directly uses mojom struct
    ServiceWorkerProviderHostInfo everywhere.
    
    BUG=789854
    
    Change-Id: I5aa15afb38d5658e25ba40dacae5873cff4caa62
    Reviewed-on: https://chromium-review.googlesource.com/1132847
    Commit-Queue: Han Leon <leon.han@intel.com>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574516}

    Changed files

    • content/browser/service_worker/service_worker_dispatcher_host.cc
    • content/browser/service_worker/service_worker_dispatcher_host.h
    • content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
    • content/browser/service_worker/service_worker_object_host_unittest.cc
    • content/browser/service_worker/service_worker_provider_host.cc
    • content/browser/service_worker/service_worker_provider_host.h
    • content/browser/service_worker/service_worker_provider_host_unittest.cc
    • content/browser/service_worker/service_worker_test_utils.cc
    • content/browser/service_worker/service_worker_test_utils.h
    • content/common/BUILD.gn
    • content/common/service_worker/service_worker_provider.mojom
    • content/common/service_worker/service_worker_provider.typemap
    • content/common/service_worker/service_worker_provider_host_info.cc
    • content/common/service_worker/service_worker_provider_host_info.h
    • content/common/service_worker/service_worker_provider_struct_traits.cc
    • content/common/service_worker/service_worker_provider_struct_traits.h
    • content/common/typemaps.gni
    • content/renderer/service_worker/service_worker_network_provider.cc
  31. [unified-consent] Enable sync everything only when sync is active

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:41:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eef2c0be5716d8857f9ff7dce265e2569c8d333e

    Comments

    [unified-consent] Enable sync everything only when sync is active
    
    UnifiedConsentService is observing changes of the sync service,
    so the sync data types are only enabled when sync is started up
    and active.
    
    Bug: 862139, 819909
    Change-Id: I4c006e0c1cc7b263f113865da0c128620e1817ae
    Reviewed-on: https://chromium-review.googlesource.com/1131744
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574515}

    Changed files

    • components/unified_consent/unified_consent_service.cc
    • components/unified_consent/unified_consent_service.h
    • components/unified_consent/unified_consent_service_unittest.cc
  32. Roll src/third_party/depot_tools 32e3d1e37cd6..2b138f742b74 (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 09:40:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f198a1c4c492486c961c0a112247ddac9a9e3379

    Comments

    Roll src/third_party/depot_tools 32e3d1e37cd6..2b138f742b74 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/32e3d1e37cd6..2b138f742b74
    
    
    git log 32e3d1e37cd6..2b138f742b74 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 sdefresne@chromium.org Avoid creating an empty netrc file in $TEMP
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@2b138f742b74
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:none
    TBR=agable@chromium.org
    
    Change-Id: I8e88cdcad6399e9a7b117a2fe36dc264a6e61c78
    Reviewed-on: https://chromium-review.googlesource.com/1134149
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574514}

    Changed files

    • DEPS
  33. Revert "Delete the media cache(s) when using a single combined HTTP cache."

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb81f73d09c9efd4ff7eb181ce3ffe105d1549a8

    Comments

    Revert "Delete the media cache(s) when using a single combined HTTP cache."
    
    This reverts commit e226149af1b3f003b5d3f59e19ee17bef7419c42.
    
    Reason for revert: 
    
    `ProfileWithoutMediaCacheBrowserTest.DeleteMediaCache` and `ProfileWithoutMediaCacheBrowserTest.DeleteIsolatedAppMediaCache` have been failing, apparently since they were added by this CL.
    
    They were added here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28016 (which failed to actually run `browser_test`) and have been failing consistently since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018.
    
    
    Original change's description:
    > Delete the media cache(s) when using a single combined HTTP cache.
    > 
    > This is so that I can try increasing the media cache size in experiments
    > without increasing Chrome's profile size (Except possibly for profiles
    > that have never been used to play video).
    > 
    > Bug: 789657
    > Change-Id: I45e8f8c6e346a1fa7d05b0bea3e8b001d7dc41e1
    > Reviewed-on: https://chromium-review.googlesource.com/1130162
    > Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    > Commit-Queue: Matt Menke <mmenke@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574296}
    
    TBR=mmenke@chromium.org,morlovich@chromium.org
    
    Change-Id: Ibc519750f00ad7e698d279af6baffe77b32d30be
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 789657, 862945
    Reviewed-on: https://chromium-review.googlesource.com/1134886
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574513}

    Changed files

    • chrome/browser/profiles/profile_browsertest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
  34. Cancel long-press operation if the gesture is scrolling

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:21:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d417866204188b709447dfb64ba68740a182b7a5

    Comments

    Cancel long-press operation if the gesture is scrolling
    
    This CL adds the code to cancel the long-press operation which shows
    inline setting when the user stats the scrollingo
    
    Previously that was done in Android (ag/4340201) but it didn't work
    for vertical scroll since the scroll is handled on Chrome side. With
    this CL, scroll detection is done on Chrome side and the code handles
    correctly with vertical scrolls in addition to horizontal ones.
    
    Bug: b/111100376
    Bug: 858938
    Test: Manual (inline setting does't open during vertical scroll)
    Change-Id: I84407b331dc320e6acd3a776938104ad018d46a3
    Reviewed-on: https://chromium-review.googlesource.com/1124263
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Greg Kerr <kerrnel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574512}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
    • ash/system/message_center/arc/arc_notification_item.h
    • ash/system/message_center/arc/arc_notification_item_impl.cc
    • ash/system/message_center/arc/arc_notification_item_impl.h
    • ash/system/message_center/arc/arc_notification_manager.cc
    • ash/system/message_center/arc/arc_notification_manager.h
    • ash/system/message_center/arc/mock_arc_notification_item.h
    • components/arc/common/notifications.mojom
    • components/arc/test/fake_notifications_instance.cc
    • components/arc/test/fake_notifications_instance.h
  35. OAuth2LoginManager: Handle consecutive refresh token updates

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:20:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2f7998c5e85ffebc0c1f7588bcc45a73e1de4dc

    Comments

    OAuth2LoginManager: Handle consecutive refresh token updates
    
    OAuth2LoginManager currently assumes that
    OAuth2TokenService::Observer::OnRefreshTokenAvailable() will never be
    called twice consecutively for the primary account; in particular,
    it calls VerifySessionCookies(), which DCHECKS that
    |oauth2_login_verifier_| is null before instantiating that ivar.
    
    However, this assumption is no longer valid. A simple example:
    - A refresh token is found during startup, resulting in
      OnRefreshTokenAvailable() firing.
    - The user revokes their refresh token remotely.
    - Sync locally enters an error state, prompting the user to reauth
      locally.
    - The user reauths locally, resulting in OnRefreshTokenAvailable()
      firing.
    
    Other examples are possible as well.
    
    This CL extends OAuth2LoginManager to handle this case by stopping
    ongoing actions related to the current refresh token for the primary
    account when OAuth2LoginManager receives the notification that that
    refresh token has been updated.
    
    This CL is concretely necessary to unblock
    https://chromium-review.googlesource.com/c/chromium/src/+/1126861,
    which is firing the "token available" notification as part of startup
    when adding an invalid token for the primary account and triggers the
    DCHECK above on ChromeOS browsertests. Those failures were how I
    discovered this issue.
    
    Change-Id: I55ced6fe49055c6c6c4d1e7ce138a0d080ecda38
    Reviewed-on: https://chromium-review.googlesource.com/1127662
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574511}

    Changed files

    • chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
  36. shared worker: Simplify the default network factory logic.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:20:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab39b893750485f84d1f607be642fe1efdc27f7f

    Comments

    shared worker: Simplify the default network factory logic.
    
    When NetworkService is off but S13nSW is on, shared worker jumped
    through hoops to get a factory bundle to the renderer. It was
    giving the renderer a NetworkService default factory and expecting the
    renderer to clear it.
    
    But we can just give a non-NetworkService direct network default factory,
    since that capability was added in r565058.
    
    Bug: 839982
    Change-Id: Ie5c4f182b87526e2f15a7b2a8b62ed03f7e5595f
    Reviewed-on: https://chromium-review.googlesource.com/1134708
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574510}

    Changed files

    • content/browser/shared_worker/shared_worker_host.cc
    • content/renderer/shared_worker/embedded_shared_worker_stub.cc
  37. Revert "licenses.py: Skip another //tools/binary_size subdirectory."

    Changed by Raphael Kubo da Costa (CET) - raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 12-Jul-18 09:19:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc3a2b34c667b8e2e0cde7766e9439e80fb72174

    Comments

    Revert "licenses.py: Skip another //tools/binary_size subdirectory."
    
    This reverts commit a6c69c8113a7113cc6b4a4f8de3291095d717e40.
    
    Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1080401 moved gvr-android-sdk into a directory we already skip, so this is no longer needed.
    
    Original change's description:
    > licenses.py: Skip another //tools/binary_size subdirectory.
    > 
    > Commit 6a15a6c4 ("SuperSize: Teach it about thin archives") added a
    > third_party directory to tools/binary_size with a .a file with some dummy
    > contents that we need to skip.
    > 
    > Change-Id: Ia1e129dc67617207ac920106e835d762887e74ac
    > Reviewed-on: https://chromium-review.googlesource.com/1078967
    > Reviewed-by: Scott Graham <scottmg@chromium.org>
    > Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    > Cr-Commit-Position: refs/heads/master@{#564081}
    
    TBR=raphael.kubo.da.costa@intel.com,scottmg@chromium.org,ichikawa@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I8a85ee225f54a0499ee18e20311dfd5b9dc280fe
    Reviewed-on: https://chromium-review.googlesource.com/1133138
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#574509}

    Changed files

    • tools/licenses.py
  38. Add AudioLogFactory mojo interface.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:19:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee6cfd00b7b35f8bc4ced3eecc801fa2f55a85ae

    Comments

    Add AudioLogFactory mojo interface.
    
    This interface allows a mojo client to create audio logs on
    the browser process.
    This CL also removes content::MojoLogAudioAdapter, which is moved to the
    audio service as audio::LogAdapter in follow-up CL crrev.com/c/1128974
    
    Bug: 812557
    Change-Id: I70504a4878553f1a3c2d58a29c6ab960b6f15b39
    Reviewed-on: https://chromium-review.googlesource.com/1128966
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574508}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/media/audio_log_factory.cc
    • content/browser/media/audio_log_factory.h
    • content/browser/media/media_internals.cc
    • content/browser/media/media_internals.h
    • content/browser/media/mojo_audio_logging_adapter.cc
    • content/browser/media/mojo_audio_logging_adapter.h
    • media/mojo/interfaces/audio_logging.mojom
  39. Add service worker README.md.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:46:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

    Comments

    Add service worker README.md.
    
    Bug: 795989
    Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d
    Reviewed-on: https://chromium-review.googlesource.com/1134718
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574507}

    Changed files

    • content/browser/service_worker/README.md
    • content/common/service_worker/README.md
    • third_party/blink/common/service_worker/README.md
    • third_party/blink/public/common/service_worker/README.md
    • third_party/blink/public/mojom/service_worker/README.md
    • third_party/blink/public/platform/modules/service_worker/README.md
    • third_party/blink/public/web/modules/service_worker/README.md
    • third_party/blink/renderer/modules/service_worker/README.md
  40. Use PLM for data saver site-breakdown

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74f3e3d131a093053a5e5f737e162c99e1c69e62

    Comments

    Use PLM for data saver site-breakdown
    
    This CL adds PLM observer for site-breakdown that records the data use
    by host. The new codepath is enabled and the old data use asriber observer
    based site-breakdown codepath is disabled, based on a feature.
    
    Bug: 836029
    Change-Id: I667d0dc6e0227c83a46d353b2feffaec9043a219
    Reviewed-on: https://chromium-review.googlesource.com/1050868
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574506}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
    • chrome/test/BUILD.gn
    • components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
  41. Add new methods to EntryList and tests

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76bc398de31290a2d97ee6b7ea804a55d1d5451d

    Comments

    Add new methods to EntryList and tests
    
    Change the logic to add entries to My Files to account for volume being
    mounted/unmounted. This fixes some broken tests when running with the
    flag enabled by default, so test to cover this is on
    crrev.com/c/1131025.
    
    Fix test getMetadata function name.
    
    Bug: 857335
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id056b0e0d5c77a07c2561f6566bfc99111864917
    Reviewed-on: https://chromium-review.googlesource.com/1133613
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574505}

    Changed files

    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.html
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
  42. [LayoutNG] Fix static position for inline containing block

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f321a196a45bce7d32257d0b93b472dba89e205a

    Comments

    [LayoutNG] Fix static position for inline containing block
    
    Bug: 740993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Iacdfc2694b2522c06a2512000ed1ca7f043b7541
    Reviewed-on: https://chromium-review.googlesource.com/1134386
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574504}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
  43. NetS13nServiceWorker: Add more info to traces in SWNavigationLoader

    Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:13:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 670a4fd7d5c89c8904f638edda72083e41e5d016

    Comments

    NetS13nServiceWorker: Add more info to traces in SWNavigationLoader
    
    Bug: 806658
    Change-Id: Ie52bdfdd6f44354c42067f1c069996cc80b6df17
    Reviewed-on: https://chromium-review.googlesource.com/1134711
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574503}

    Changed files

    • content/browser/service_worker/service_worker_navigation_loader.cc
  44. [Android PageInfo] Refactor PageInfoController to enable testing

    Changed by Anita Woodruff - awdfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:05:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfb08c4ccef342639df17f6a423643df1784b767

    Comments

    [Android PageInfo] Refactor PageInfoController to enable testing
    
    - Extracted PermissionParamsListBuilder from PageInfoController
    to handle all the permission-related logic when displaying
    permissions in page info. This new class requires fewer
    hard-to-unit-test dependencies so its logic can now be tested.
    
    Bug: 691898
    Change-Id: Iddbea30642a0dc31dae26110381e2dad9feb2af4
    Reviewed-on: https://chromium-review.googlesource.com/1103564
    Commit-Queue: Anita Woodruff <awdf@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574502}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilder.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/SystemSettingsActivityRequiredListener.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
  45. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc
  46. Change test to use full-path-for-testing attribute selector

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector
    
    This makes this test compatible with directory tree having My Files or
    not, and makes the test more readable too.
    
    This is a preparation to enable new navigation (with My Files) by
    default.
    
    Bug: 857335
    No-presubmit: true
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
    Reviewed-on: https://chromium-review.googlesource.com/1133610
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
  47. Add find bar icon to hosted app windows

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:03:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35f205a1441afebe9987e606c7c876d5bfc4594

    Comments

    Add find bar icon to hosted app windows
    
    This CL moves the find icon from LocationBarView into PageActionIconContainerView
    enabling the icon to appear in hosted app window title bars.
    
    This change also fixes the find icon getting nudged by
    crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e.
    
    Before 108c0687254683b3beeaa32b6e0a86f2046a867e:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1
    Before CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1
    After CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1
    
    Bug: 788051, 814531
    Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967
    Reviewed-on: https://chromium-review.googlesource.com/1054908
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574499}

    Changed files

    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/find_bar/find_bar_controller.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/page_action/page_action_icon_container.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.h
    • chrome/browser/ui/views/frame/toolbar_button_provider.h
    • chrome/browser/ui/views/location_bar/find_bar_icon.cc
    • chrome/browser/ui/views/location_bar/find_bar_icon.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h
  48. Replace ThreadChecker by SequenceChecker in /components/sync*

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc8a763a002339d6a7821e3c69d45ad8642dafc1

    Comments

    Replace ThreadChecker by SequenceChecker in /components/sync*
    
    https://crrev.com/c/1131474 removed the unnecessary thread-affinity,
    this one adjusts the checks accordingly.
    
    Bug: 846238
    Change-Id: If4e1145712fe99f4d8236d93e4f645e69c3e7655
    Reviewed-on: https://chromium-review.googlesource.com/1131738
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574498}

    Changed files

    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_core.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
    • components/sync/driver/glue/sync_backend_host_impl.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_service_crypto.h
    • components/sync/engine/sync_backend_registrar.cc
    • components/sync/engine/sync_backend_registrar.h
    • components/sync/engine_impl/debug_info_event_listener.cc
    • components/sync/engine_impl/debug_info_event_listener.h
    • components/sync/engine_impl/model_type_worker.cc
    • components/sync/engine_impl/model_type_worker.h
    • components/sync/engine_impl/net/server_connection_manager.cc
    • components/sync/engine_impl/net/server_connection_manager.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_manager_impl.h
    • components/sync/engine_impl/sync_manager_impl_unittest.cc
    • components/sync/test/engine/fake_model_worker.cc
    • components/sync/test/engine/fake_model_worker.h
    • components/sync_bookmarks/bookmark_change_processor.cc
    • components/sync_bookmarks/bookmark_change_processor.h
  49. Track changes to nodes that are in the AX tree but aren't laid out.

    Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d535bf95b998d1061629905139485c937272fc3b

    Comments

    Track changes to nodes that are in the AX tree but aren't laid out.
    
    Previously we only had hooks to update the children of a node in the
    AX tree when LayoutObjects were inserted or removed. That left out some
    corner cases when Nodes are inserted or removed that are part of the
    AX tree but not laid out, like nodes in the accessible / fallback content
    for a canvas.
    
    Bug: 862311
    Change-Id: I9482a9e0dc9ba45368b2fc87ea3449bdd4ef1c50
    Reviewed-on: https://chromium-review.googlesource.com/1132119
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574497}

    Changed files

    • third_party/WebKit/LayoutTests/accessibility/children-changed-in-canvas.html
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.h
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_node_object.h
  50. media/gpu/test/RenderingHelper: Unify interface to process video frame

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:09:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9e1a62b97488da8c36e7c12d0fe9769a60b4238

    Comments

    media/gpu/test/RenderingHelper: Unify interface to process video frame
    
    VDA test client calls RenderingHelper::RenderThumbnail() if a thumbnail is made
    from a video frame. Otherwise, it calls RenderingHelper::QueueVideoFrame().
    RenderingHelper itself knows which function to be called, and thus these
    functions should be unified into a single interface.
    
    BUG=chromium:834170
    TEST=VDA unittest at veyron_minnie and eve
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I106d4ce1c05b003d6333a6865a8d96e276031598
    Reviewed-on: https://chromium-review.googlesource.com/1122656
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574496}

    Changed files

    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/rendering_helper.h
    • media/gpu/video_decode_accelerator_unittest.cc
  51. [LayoutNG]Make the first marker of nested list occupying a whole line

    Changed by cathiechen - cathiechenohnoyoudont@tencent.com
    Changed at Thursday, 12-Jul-18 05:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347323ce0f71964c59a50c507f14484baff8a386

    Comments

    [LayoutNG]Make the first marker of nested list occupying a whole line
    
    In legacy Layout, there's line-break between marker and the nesting
    <ul>/<ol>. In order to keep consistency with it, add NeedsOccupyWholeLine()
    in LayoutNGListMarker to indicate that marker would occupy a line.
    During Layout(), this kind of marker won't be added to container_builder_,
    and layout directly. And its margin will be handled after layout.
    
    Bug: 725277
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ie9f6dbca0945c8e031ec7bb44594db2e96773462
    Reviewed-on: https://chromium-review.googlesource.com/1132819
    Commit-Queue: cathie chen <cathiechen@tencent.com>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574495}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/001-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/003-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/004-expected.txt
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.cc
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.h
    • third_party/blink/renderer/core/layout/ng/list/ng_unpositioned_list_marker.h
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
  52. Move scroll-related platform test code into core/testing/

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:49:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecb9b545a199897e05ca621e40fd5e93289f82bd

    Comments

    Move scroll-related platform test code into core/testing/
    
    Also delete unused fake_scrollable_area.h.
    
    BUG=823365
    R=skobes@chromium.org,pdr@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I5620b9c31d53d523108c0c7a3a247264e588fc90
    Reviewed-on: https://chromium-review.googlesource.com/1132380
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574494}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/editing/rendered_position_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater_test.cc
    • third_party/blink/renderer/core/testing/core_unit_test_helper.h
    • third_party/blink/renderer/core/testing/use_mock_scrollbar_settings.h
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
  53. check |focused_surface_| on SetCursorType

    Changed by Jun Mukai - mukaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:47:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5939dab948bcde131510fa955f2802e93159238

    Comments

    check |focused_surface_| on SetCursorType
    
    SetCursorType hasn't checked the focused surface, thus it could
    change the cursor shapes even though the mouse pointer isn't
    related to the apps under exo.
    
    BUG=b/111360026
    TEST=the new test case in exo_unittests
    
    Change-Id: Ibacb0b8689720caa00ec206848cc6efb74854946
    Reviewed-on: https://chromium-review.googlesource.com/1134185
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574493}

    Changed files

    • components/exo/pointer.cc
    • components/exo/pointer_unittest.cc
  54. Print Preview: Add new Cloud Printer Handler flag

    Changed by rbpotter - rbpotterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:34:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9990eb4884bf57e3f907c5a475d182ff4db6d760

    Comments

    Print Preview: Add new Cloud Printer Handler flag
    
    Use a new cloud printer handler flag to control using the C++ cloud
    printer handler instead of the JS cloud print interface in Print
    Preview. Print Preview will be temporarily whitelisted to send network
    requests with the network service flag enabled, so these changes should
    be de-coupled from the network service flag.
    
    Bug: 829414
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I9a7b53fe69bfe5aad4ab7cc5688dfb88e6074014
    Reviewed-on: https://chromium-review.googlesource.com/1134397
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574492}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/resources/print_preview/data/destination_store.js
    • chrome/browser/ui/webui/print_preview/print_preview_handler.cc
    • chrome/browser/ui/webui/print_preview/print_preview_ui.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • tools/metrics/histograms/enums.xml
  55. Remove debugging code in base::MessagePumpWin.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:29:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95f61506c064bf502b2f2f81293866e40843ab2b

    Comments

    Remove debugging code in base::MessagePumpWin.
    
    BUG=596190
    
    Change-Id: Ie9b6ee2cc1db8399247be767cabba1b39df50544
    Reviewed-on: https://chromium-review.googlesource.com/1128274
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574491}

    Changed files

    • base/message_loop/message_pump_win.cc
    • base/message_loop/message_pump_win.h
  56. Add workaround for WebUIs that make network requests when running with the network service.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:28:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 04bfa853ac261c316e0ef799e7c10ae05dece8c1

    Comments

    Add workaround for WebUIs that make network requests when running with the network service.
    
    Currently with the network service, renderers that have WebUI bindings are not allowed to make requests over the internet. This is to improve security in case the response hijacks the renderer. However there are a couple of WebUIs that are doing this now, so temporarily allow them.
    
    Bug: 848987, 829412
    Change-Id: I34c1b66e63fd1b7c2960cc867709c065329cf489
    Reviewed-on: https://chromium-review.googlesource.com/1134412
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574490}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_content_browser_client.h
    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • extensions/browser/api/web_request/web_request_permissions.cc
    • extensions/browser/extensions_browser_client.cc
    • extensions/browser/extensions_browser_client.h
  57. Stop content sniffing after successful encoding detection

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:40:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efbdada3f735a2631e9dfeed5c5e3f880245ccd3

    Comments

    Stop content sniffing after successful encoding detection
    
    Content sniffing should stop once the detector makes a valid
    guess. http://crrev.com/2697213002 introduced a side effect
    that has the detector continue to sniff the content, therefore
    opens the possibility of returning an encoding different from
    the first guess. It leads to a document decoded with multiple
    encoding schemes, one of which may not be correct.
    
    This CL addresses it by defining a new flag |detection_completed_|
    to tell the TextResourceDecoder to stop sniffing, even if
    detector returns false for unlabelled UTF-8 documents. Also added
    a test verifying the behavior.
    
    Bug: 710861
    Change-Id: Ic07de3ae08fbb742aa3c24f1e18055348d6acbd8
    Reviewed-on: https://chromium-review.googlesource.com/1132904
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574489}

    Changed files

    • third_party/blink/renderer/core/html/parser/text_resource_decoder.cc
    • third_party/blink/renderer/core/html/parser/text_resource_decoder.h
    • third_party/blink/renderer/core/html/parser/text_resource_decoder_test.cc
    • third_party/blink/renderer/platform/text/text_encoding_detector.cc
    • third_party/blink/renderer/platform/wtf/text/text_encoding.cc
    • third_party/blink/renderer/platform/wtf/text/text_encoding.h
  58. [LayoutNG] Minor cleanup for NGInlineItem::Script()

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:27:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 078bf960f5874ead134ad8f8c2e3f265969044cb

    Comments

    [LayoutNG] Minor cleanup for NGInlineItem::Script()
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ie8d9ac37eca29db6a39f9a4612a3c0151ef06006
    Reviewed-on: https://chromium-review.googlesource.com/1132254
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574488}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.h
  59. Fix crash in ResourceFetcher::CachedResource()

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:26:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae18f0f47b8272cc5b911cc22cb799a648405f45

    Comments

    Fix crash in ResourceFetcher::CachedResource()
    
    This fixes a bug where ResourceFetcher::CachedResource() crashes when
    given a null KURL.
    
    Bug: 859314
    Change-Id: Iae07ded3124b690854aa7ba2a532f21be2a99972
    Reviewed-on: https://chromium-review.googlesource.com/1132914
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574487}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
  60. Disable flaky resource loading hints browser test on windows.

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:25:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 91567a36db92e68bb36a513b68c119707b4c2cec

    Comments

    Disable flaky resource loading hints browser test on windows.
    
    Change-Id: Iea8b186c1673fb14982c98ce24141003d267df21
    TBR: ryansturm@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134595
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574486}

    Changed files

    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  61. Gardening: Revise bug # for broken-chunked-encoding.https.html.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:20:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 349d297d20d841791815fd8b86b87f02e755bd22

    Comments

    Gardening: Revise bug # for broken-chunked-encoding.https.html.
    
    NOTRY=true
    
    Bug: 830472,862886
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: Ia6b50e1730d1f5dcb4f84b5c18d47003565fd838
    TBR: bashi
    Reviewed-on: https://chromium-review.googlesource.com/1134627
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574485}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
    • third_party/WebKit/LayoutTests/TestExpectations
  62. Roll src/third_party/webrtc d78323faba86..5795489e83ad (1 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 04:20:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1fc8a107a045fc9722cc619cd867e1197564f338

    Comments

    Roll src/third_party/webrtc d78323faba86..5795489e83ad (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/d78323faba86..5795489e83ad
    
    
    git log d78323faba86..5795489e83ad --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 buildbot@webrtc.org Roll chromium_revision 2e3b05bf93..720dadbc21 (574261:574387)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@5795489e83ad
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I921992cf5317868ff92ddfd27ecdba4c9cd8c78f
    Reviewed-on: https://chromium-review.googlesource.com/1134146
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574484}

    Changed files

    • DEPS
  63. Linux install dialog now has the word (Beta)

    Changed by Nicholas Verne - nverneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:19:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5adc1de421e13cb871f50ed27d194a6ed1d5fb4

    Comments

    Linux install dialog now has the word (Beta)
    
    Bug: 848118
    Change-Id: Ib19c766d00084771d58f648076901eb6c4e25533
    Reviewed-on: https://chromium-review.googlesource.com/1133605
    Reviewed-by: Renée Wright <rjwright@chromium.org>
    Commit-Queue: Nicholas Verne <nverne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574483}

    Changed files

    • chrome/app/chromeos_strings.grdp
  64. Ensure NavigationURLLoader does not exist in OnStartChecksComplete.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:05:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db52f93a94ed44198ade982c1640aa6aec35346c

    Comments

    Ensure NavigationURLLoader does not exist in OnStartChecksComplete.
    
    navigation_handle_->InitServiceWorkerHandle and navigation_handle_->InitAppCacheHandle
    reset the objects that NavigationURLLoaderImpl holds raw pointers to.
    So we must ensure |loader_| does not exist before doing that.
    
    Follow-up to r574110 <https://chromium-review.googlesource.com/1132715>.
    
    Bug: 857005
    Change-Id: If150832a8f6a104dbd662f2cc0e2c119e7a523bf
    Reviewed-on: https://chromium-review.googlesource.com/1133611
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574482}

    Changed files

    • content/browser/frame_host/navigation_request.cc
  65. Update signed exchange test directory reference

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:42:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e72dce733afafe0340e25390b5f4c228702e9de

    Comments

    Update signed exchange test directory reference
    
    The directory was renamed in crrev.com/c/1132835.
    
    Bug: 856530
    Change-Id: I34890b24f256048d49bc59f5ba34ec048ce48d1c
    Reviewed-on: https://chromium-review.googlesource.com/1133609
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574481}

    Changed files

    • third_party/blink/tools/blinkpy/third_party/wpt/README.chromium
  66. Add viz::VideoCaptureOverlay to support mouse cursor rendering VIZ-side.

    Changed by Yuri Wiitala - miuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:36:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7bed8483e07637b8b24e7492d97bbc0499b6c16

    Comments

    Add viz::VideoCaptureOverlay to support mouse cursor rendering VIZ-side.
    
    VideoCaptureOverlay provides the post-GPU-readback rendering of small
    SkBitmaps onto the VideoFrames captured by viz::FrameSinkVideoCapturer.
    This will be used to move mouse cursor rendering out of the browser
    process, and into VIZ, as was intended in the original design. More
    details in crbug/810133.
    
    A soon-upcoming series of changes will provide mojo IDL definition as
    well as integration of VideoCaptureOverlay with FrameSinkVideoCapturer.
    
    Bug: 810133
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I16897dbd361af153d10a1223339d9fb5f7e5f05a
    Reviewed-on: https://chromium-review.googlesource.com/1132318
    Commit-Queue: Yuri Wiitala <miu@chromium.org>
    Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574480}

    Changed files

    • components/viz/service/BUILD.gn
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay.cc
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay.h
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay_unittest.cc
    • components/viz/test/data/video_capture/overlay_clips_ll.png
    • components/viz/test/data/video_capture/overlay_clips_lr.png
    • components/viz/test/data/video_capture/overlay_clips_ul.png
    • components/viz/test/data/video_capture/overlay_clips_ur.png
    • components/viz/test/data/video_capture/overlay_full_cover.png
    • components/viz/test/data/video_capture/overlay_full_cover_scaled.png
    • components/viz/test/data/video_capture/overlay_moves_0_0.png
    • components/viz/test/data/video_capture/overlay_moves_1_0.png
    • components/viz/test/data/video_capture/overlay_moves_2_0.png
    • components/viz/test/data/video_capture/overlay_moves_2_1.png
    • components/viz/test/data/video_capture/overlay_moves_2_2.png
    • components/viz/test/data/video_capture/overlay_moves_lr.png
  67. [MediaRouter] Reconnect the extension MRP Mojo pipe on connection error.

    Changed by Derek Cheng - imchengohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:34:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da7bd5a1bbf177bb5822564193a7ea1795e0159b

    Comments

    [MediaRouter] Reconnect the extension MRP Mojo pipe on connection error.
    
    MR extension can fail/crash for many reasons. This in turn may cause
    ExtensionMediaRouteProviderProxy to violate its Mojo message pipe
    contract by dropping pending callbacks.
    
    Rather than wrapping each callback and tracking them in EMRPP, this
    patch deals with this by having MediaRouterDesktop detect when the EMRPP
    pipe encounters an error and attempt to recreate the pipe, subject to a
    max number of attempts.
    
    Bug: 861778
    Change-Id: Ie70e2cae3ea6650b65f658aba4ec527d4e2eb0d0
    Reviewed-on: https://chromium-review.googlesource.com/1129208
    Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
    Commit-Queue: Derek Cheng <imcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574479}

    Changed files

    • chrome/browser/media/router/mojo/media_router_desktop.cc
    • chrome/browser/media/router/mojo/media_router_desktop.h
    • chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.cc
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.h
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy_unittest.cc
  68. [Save card dialog] Update Google Pay logo and title padding

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:30:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb48e72d0b5d141e297e1e0a04d47cca079b0e1a

    Comments

    [Save card dialog] Update Google Pay logo and title padding
    
    According to the new spec, title for the server card should be:
      [GPay icon]<8px>|<8px>[Title]
    as opposed to the current:
      [GPay icon]<16px>|<16px>[Title]
    
    Mocks: https://drive.google.com/open?id=1A717QrLWOYSj3_A75tyMZomLUhy0xdV0
    Testing:
     - Local card: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Local --test-launcher-interactive
     - Upstream card: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Server --test-launcher-interactive
    
    The way it was done before was to consider that the separator
    was part of the GPay icon. However, that doesn't work properly
    for RTL languages, and the approach was harder to expand for
    different paddings.
    
    In order to achieve that, this CL:
     - Replaces the gpay logo icon with a new version without the
       separator (logo provided by our UX designer, by inspection
       it's easy to see that there was no change to the icon);
     - Creates a custom title container view that includes the icon,
       the | separator, and the "Save card?" title.
    
    Please notice that I didn't want to add complexity to the base
    classes to handle separators. However, if we think it might be
    useful for other dialogs, I'd like to generalize in a follow-up
    CL, to make sure we have proper testing.
    
    Also added comments to the different sections of the GPay logo
    .icon file, to make it easier to inspect any future updates.
    
    Bug: 859893
    Change-Id: I6c551b113e476f21f3e74198b37f6df080226e78
    Reviewed-on: https://chromium-review.googlesource.com/1127471
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574478}

    Changed files

    • chrome/app/vector_icons/BUILD.gn
    • chrome/app/vector_icons/google_pay_logo.icon
    • chrome/browser/ui/views/autofill/save_card_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views.h
  69. Revert "Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.""

    Changed by Brian Salomon - bsalomonohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 03:18:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cbaa2f11a4e9f5ef04eeb8cf0dc2acfdbaa79f56

    Comments

    Revert "Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.""
    
    This reverts commit 23370775c415c21f4de1c7d97dd5645fe2b7e818.
    
    Reason for revert: still fails on Nexus 9
    
    Original change's description:
    > Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."
    > 
    > This is a reland of 841c0dde5461c763fdd524c2078aafaf241444aa
    > 
    > The updated change uses window.devicePixelRatio to determine the inset.
    > It also accounts for the absolute position used by the "WithDivs"
    > variations of this test. One additional device pixel of offset is used
    > to make this pass on mac_chromium_rel_ng. This is probably necessary
    > because either window.devicePixelRatio reports 1 incorrectly or the
    > edge antialiasing covers slightly more than one pixel. This wasn't
    > investigated.
    > 
    > Original change's description:
    > > Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.
    > >
    > > Skia currently has a driver workaround that performans antialiased
    > > rectangle edge equation evalution in the fragment shader rather than
    > > vertex shader on Adreno 3xx GPUs. This was done because the interpolation
    > > of values computed in the vertex shader lacks enough precision to pass
    > > these tests. However, doing so has a negative performance impact. Skia
    > > tests run with the workaround removed show that in practice the visual
    > > difference is insignificant. Moreover, cc::GLRenderer also incurs these
    > > same errors as it uses the same antialiasing approach without the
    > > workaround and has shipped on Adreno 3xx devices for years with no known
    > > complaints about antialiasing quality/accuracy. We're better off
    > > reclaiming the performance and accepting a small hit to antialiasing
    > > accuracy.
    > >
    > > Bug: 847984
    > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > > Change-Id: If1e62e0780a752179a75ddd57ccc7b24128c68ac
    > > Reviewed-on: https://chromium-review.googlesource.com/1129041
    > > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > > Commit-Queue: Brian Salomon <bsalomon@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#573695}
    > 
    > Bug: 847984
    > Change-Id: Ie5e685e8d5e0afbcf4c54ea3186ee68d238464ba
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > Reviewed-on: https://chromium-review.googlesource.com/1132574
    > Commit-Queue: Brian Salomon <bsalomon@google.com>
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574369}
    
    TBR=bsalomon@google.com,zmo@chromium.org,kbr@chromium.org
    
    Change-Id: Idf353b940d79a85adba768e22593057d00310e47
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 847984
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1134120
    Reviewed-by: Brian Salomon <bsalomon@google.com>
    Commit-Queue: Brian Salomon <bsalomon@google.com>
    Cr-Commit-Position: refs/heads/master@{#574477}

    Changed files

    • content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
  70. Roll src/third_party/chromite a3bc29bcacf3..c228d491eb86 (3 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 03:16:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0b7cacfc5ff01fe6d83463c81048b244322db8c

    Comments

    Roll src/third_party/chromite a3bc29bcacf3..c228d491eb86 (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/a3bc29bcacf3..c228d491eb86
    
    
    git log a3bc29bcacf3..c228d491eb86 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 bpastene@chromium.org cros_chrome_sdk: Change default location of cros cache dir.
    2018-07-12 vapier@chromium.org config_lib: delay loading of site_config in many modules
    2018-07-12 tbrindus@chromium.org paygen: Fix exception instantiation in error path
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@c228d491eb86
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I88e283d9cb6593f6c1be6a0dfb2a9853e8e09f7f
    Reviewed-on: https://chromium-review.googlesource.com/1134103
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574476}

    Changed files

    • DEPS
  71. Updating trunk VERSION from 3489.0 to 3490.0

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:08:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 21d5fa75c5045ffda38bb5368435754a3a42d8e8

    Comments

    Updating trunk VERSION from 3489.0 to 3490.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=amineer@chromium.org
    
    Change-Id: I6fc6232d8ba9ed933cc765caf4098281916f453d
    Reviewed-on: https://chromium-review.googlesource.com/1134528
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574475}

    Changed files

    • chrome/VERSION
  72. [Extensions Cleanup] Remove unnecessary call to sync service

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:08:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 34a47acf551fda25534bde4146c5f94409bd8b5b

    Comments

    [Extensions Cleanup] Remove unnecessary call to sync service
    
    The runtime host permissions preferences used to be synced, but aren't
    currently. Remove the call to the sync service, since it's unnecessary.
    
    If/when we add back syncing support, we can re-add this call.
    
    Bug: 839681
    Change-Id: Iba45e431ad09f8ff92861c69ae8447c125af707a
    Reviewed-on: https://chromium-review.googlesource.com/1134433
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574474}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier.cc
  73. Blink: Add test for LifecycleNotifier::ForEachObserver.

    Changed by Victor Costan - pwnallohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d12a94d841e7040cb516cb29c535cb899bdb58f0

    Comments

    Blink: Add test for LifecycleNotifier::ForEachObserver.
    
    Change-Id: I105750df8a76a5cabface400ba0dcfe60a77b810
    Reviewed-on: https://chromium-review.googlesource.com/1132848
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574473}

    Changed files

    • third_party/blink/renderer/platform/lifecycle_context_test.cc
  74. Settings: remove use of /deep/ selector in settings-ui

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:57:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 953e0851bee83c191092a0e7abeb883aab2fe1fc

    Comments

    Settings: remove use of /deep/ selector in settings-ui
    
    Bug: 860069
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I15349a654bd8309688cb5f0f58a4df115d3e180d
    Reviewed-on: https://chromium-review.googlesource.com/1133707
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574472}

    Changed files

    • chrome/browser/resources/settings/settings_ui/settings_ui.js
  75. Skip a ChromeResourceDispatcherHostDelegateBrowserTest when S13nSW is enabled

    Changed by Kenichi Ishibashi - bashiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:54:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f1fbed9c375f8c5301ea55a28320e56c0a4653ac

    Comments

    Skip a ChromeResourceDispatcherHostDelegateBrowserTest when S13nSW is enabled
    
    ChromeResourceDispatcherHostDelegateBrowserTest.NavigationDataProcessed
    tries to get NavigationData from NavigationHandle but we dont set
    NavigationData when S13nSW is enabled. Skip it when S13nSW is enabled.
    
    Bug: 861657
    Change-Id: I7af24fa1981d66c76cf5f83920b29b49d3988f33
    Reviewed-on: https://chromium-review.googlesource.com/1131041
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574471}

    Changed files

    • chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc
  76. Roll src/third_party/webrtc ef43aafcf595..d78323faba86 (47 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 02:51:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b0529974fae81606d19de5722d21320de4678e8

    Comments

    Roll src/third_party/webrtc ef43aafcf595..d78323faba86 (47 commits)
    
    https://webrtc.googlesource.com/src.git/+log/ef43aafcf595..d78323faba86
    
    
    git log ef43aafcf595..d78323faba86 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 steveanton@webrtc.org Remove AddTrack override with MediaStreams
    2018-07-11 buildbot@webrtc.org Roll chromium_revision c797a4c559..2e3b05bf93 (574101:574261)
    2018-07-11 danilchap@webrtc.org Reland "Remove rtc::Optional alias and api:optional target"
    2018-07-11 tkchin@webrtc.org Clear interrupted flag on CallKit audio activation.
    2018-07-11 yujo@chromium.org Remove not-updating-stats log message.
    2018-07-11 qingsi@google.com Revert "Reland "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*.""
    2018-07-11 fbarchard@google.com Include libyuv/planar_functions.h for CopyPlane
    2018-07-11 stefan@webrtc.org Moved PayloadRouter to call/.
    2018-07-11 sprang@webrtc.org Fix incorrect screenshare bitrate configs in test cases
    2018-07-11 magjed@webrtc.org Android: Remove use of EGLContexts in PeerConnectionFactory
    2018-07-11 magjed@webrtc.org VCMPacket: Set VCMNaluCompleteness for generic codecs
    2018-07-11 mbonadei@webrtc.org Removing unneeded warning suppression flags from audio_device.
    2018-07-11 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before RTCRtpReceiver in ObjC
    2018-07-11 srte@webrtc.org Removes unnecessary destructor checks in tests.
    2018-07-11 hbos@webrtc.org RtpReceiverInterface::stream_ids() added.
    2018-07-11 mbonadei@webrtc.org Remove -Wno-reorder from examples/BUILD.gn.
    2018-07-11 andersc@webrtc.org Fix null check in CricketToWebRtcVideoDecoderFactory
    2018-07-11 mbonadei@webrtc.org Add missing dependency on //third_party/abseil-cpp/absl/memory.
    2018-07-11 buildbot@webrtc.org Roll chromium_revision 916138ba7e..c797a4c559 (573665:574101)
    2018-07-11 mbonadei@webrtc.org Removing -Wno-sentinel from examples/BUILD.gn.
    2018-07-11 mbonadei@webrtc.org Add missing dependencies on //third_party/abseil-cpp/absl/memory.
    2018-07-11 asapersson@webrtc.org Add unit tests for simulcast layer configurations.
    2018-07-11 ilnik@webrtc.org Revert "Remove rtc::Optional alias and api:optional target"
    2018-07-11 qingsi@webrtc.org Revert "Add Profile 2 configuration to VP9 Encoder and Decoder"
    2018-07-11 qingsi@google.com Reland "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*."
    2018-07-11 emircan@webrtc.org Add Profile 2 to default supported profiles
    2018-07-10 emircan@webrtc.org Add Profile 2 configuration to VP9 Encoder and Decoder
    2018-07-10 qingsi@google.com Revert "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*."
    2018-07-10 ouj@fb.com Add unittest for default severity level of RTCCallbackLogger
    2018-07-10 qingsi@google.com Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*.
    2018-07-10 danilchap@webrtc.org Remove rtc::Optional alias and api:optional target
    2018-07-10 magjed@webrtc.org Android: Fix QueryVideoEncoder() for H264 High Profile
    2018-07-10 philipel@webrtc.org Actually input packets into the PacketBuffer.
    2018-07-10 alessiob@webrtc.org Reland "IWYU: Add <cmath> for fabsf() and powf(), switch to C++ versions"
    2018-07-10 magjed@webrtc.org Android: Honor disabling legacy video HW codec acceleration
    2018-07-10 saza@webrtc.org Fix fuzzer-found flow-over in AGC1
    2018-07-10 mbonadei@webrtc.org Removing -Wno-microsoft-extra-qualification.
    2018-07-10 mbonadei@webrtc.org Removing rtc_unittests warning suppression flags.
    2018-07-10 mbonadei@webrtc.org Remove -Wno-sign-compare, -Wno-unused-variable and -Wno-format.
    2018-07-10 philipel@webrtc.org Change RTPVideoTypeHeader to absl::variant and move RTPVideoHeader into its own h/cc file.
    2018-07-10 srte@webrtc.org Moves VideoAnalyzer class to a separate file.
    2018-07-10 srte@webrtc.org Removes unnecessary destructor checks in tests.
    2018-07-10 buildbot@webrtc.org Roll chromium_revision ef3275516a..916138ba7e (573561:573665)
    2018-07-10 ouj@fb.com Regenerate mock peer connection to add missing mock methods.
    2018-07-10 sakal@webrtc.org Update examples to use the new VideoCapturer interface.
    2018-07-10 ouj@fb.com Make the default severity level of RTCCallbackLogger match the comment on its header.
    2018-07-10 andersc@webrtc.org Migrate legacy Android video codec factories.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@d78323faba86
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None,chromium:None,chromium:861721,chromium:None,chromium:None,chromium:None,chromium:none,chromium:819294,chromium:860638,chromium:none,chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I76bc9222cb5ac91beb290da2d1740e35a029679c
    Reviewed-on: https://chromium-review.googlesource.com/1134448
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574470}

    Changed files

    • DEPS
  77. Fix debain package issue for ARM64.

    Changed by Halton Huo - halton.huoohnoyoudont@gmail.com
    Changed at Thursday, 12-Jul-18 02:49:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c621f6274616b050108d3cbb3b9d24bfa2c56233

    Comments

    Fix debain package issue for ARM64.
    
    Bug: 862500
    Change-Id: Ib456bdb3773cf9f50d7de85275804700c807f18e
    Reviewed-on: https://chromium-review.googlesource.com/1134578
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574469}

    Changed files

    • chrome/installer/linux/debian/build.sh
    • chrome/installer/linux/debian/calculate_package_deps.py
  78. Port GCM's RegistrationRequest to SimpleURLLoader

    Changed by Maks Orlovich - morlovichohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:45:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c70c93c4855cbbdd5c9f05fe2f383599be7a0eb5

    Comments

    Port GCM's RegistrationRequest to SimpleURLLoader
    
    URLFetcher will stop working with advent of Network Service, and
    SimpleURLLoader is the replacement API for most clients.
    
    (Other request types will follow; they were not done for now to keep CL size down, since there is a
     lot of wiring of pointers through and test infra stuff).
    
    Bug: 844987
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I1dc5efda6d239509d060f154cedf57ecf73edff2
    Reviewed-on: https://chromium-review.googlesource.com/1110705
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574468}

    Changed files

    • chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
    • chrome/browser/gcm/gcm_profile_service_unittest.cc
    • chrome/browser/net/system_network_context_manager.cc
    • components/gcm_driver/fake_gcm_client.cc
    • components/gcm_driver/fake_gcm_client.h
    • components/gcm_driver/gcm_client.h
    • components/gcm_driver/gcm_client_impl.cc
    • components/gcm_driver/gcm_client_impl.h
    • components/gcm_driver/gcm_client_impl_unittest.cc
    • components/gcm_driver/gcm_driver_desktop.cc
    • components/gcm_driver/gcm_driver_desktop.h
    • components/gcm_driver/gcm_driver_desktop_unittest.cc
    • google_apis/gcm/BUILD.gn
    • google_apis/gcm/engine/gcm_request_test_base.cc
    • google_apis/gcm/engine/gcm_request_test_base.h
    • google_apis/gcm/engine/registration_request.cc
    • google_apis/gcm/engine/registration_request.h
    • google_apis/gcm/engine/registration_request_unittest.cc
    • google_apis/gcm/test/DEPS
    • google_apis/gcm/test/run_all_unittests.cc
  79. Add base::OneShotTimer::FireNow() as a replacement of user_task()

    Changed by tzik - tzikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:25:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f550a61d86c912dabe13cc71ea1e81762b951ae4

    Comments

    Add base::OneShotTimer::FireNow() as a replacement of user_task()
    
    This CL adds base::OneShotTimer::FireNow(), and replaces all user_task()
    call on base::OneShotTimer with FireNow(), as a preparation of
    OnceCallback support of OneShotTimer.
    
    After OneShotTimer starts supporting OnceCallback, user_task() needs to
    change the type of its return value to `const OnceClosure&`, which is
    unusable to run the callback. Assuming all users of user_task() of
    OneShotTimer run the resulting callback immediately and stop the timer,
    FireNow should work as the replacement.
    
    Bug: 850247
    Change-Id: I52617fecfaf75aee19d681838af0e8a6b6f736a1
    Reviewed-on: https://chromium-review.googlesource.com/1128684
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574467}

    Changed files

    • ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
    • ash/policy/policy_recommendation_restorer_unittest.cc
    • ash/system/night_light/night_light_controller.h
    • ash/system/night_light/night_light_controller_unittest.cc
    • ash/system/power/power_button_controller_test_api.cc
    • ash/system/power/power_button_screenshot_controller_test_api.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • base/timer/timer.cc
    • base/timer/timer.h
    • chrome/browser/chromeos/arc/voice_interaction/highlighter_controller_client.cc
    • chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
    • components/arc/power/arc_power_bridge.cc
    • components/sync/driver/data_type_manager_impl_unittest.cc
    • components/sync/driver/model_association_manager_unittest.cc
    • components/variations/variations_request_scheduler_mobile_unittest.cc
    • content/browser/indexed_db/indexed_db_backing_store.cc
    • content/browser/indexed_db/indexed_db_factory_unittest.cc
    • content/browser/renderer_host/input/mouse_wheel_phase_handler.cc
    • media/remoting/renderer_controller_unittest.cc
    • net/disk_cache/simple/simple_index_unittest.cc
    • ui/display/manager/display_configurator.cc
  80. Roll src/third_party/depot_tools d64781e17af7..32e3d1e37cd6 (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 02:20:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00714da94e9a0e147844f4d5625b433cb57cddd6

    Comments

    Roll src/third_party/depot_tools d64781e17af7..32e3d1e37cd6 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d64781e17af7..32e3d1e37cd6
    
    
    git log d64781e17af7..32e3d1e37cd6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 ehmaldonado@chromium.org Add a library for monitoring.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@32e3d1e37cd6
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ie6794e65ad8cfec457900a56f6808509b810267c
    Reviewed-on: https://chromium-review.googlesource.com/1134450
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574466}

    Changed files

    • DEPS
  81. Expose Arc input method feature to chrome://flags.

    Changed by Yuichiro Hanada - yhanadaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:18:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0b63f06694d4bea2639fc3921d69fe2972cd699d

    Comments

    Expose Arc input method feature to chrome://flags.
    
    Bug: 845079
    Change-Id: I9f674c68d3cc442c042dde834a5f3123f15170cf
    Reviewed-on: https://chromium-review.googlesource.com/1131048
    Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574465}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • tools/metrics/histograms/enums.xml
  82. Settings: fix find in page shortcut handling

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:14:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 123398402602d1d9259cc9e3b71f50eae20c2415

    Comments

    Settings: fix find in page shortcut handling
    
    Bug: 862701
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I10c6f5888d53e0faf055adf9a45216bd83a71767
    Reviewed-on: https://chromium-review.googlesource.com/1133969
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574464}

    Changed files

    • chrome/browser/resources/settings/settings.html
    • chrome/browser/resources/settings/settings_ui/settings_ui.html
  83. chromeos: adds more comments about child modal/transients

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:12:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 20a46d01a72532d0375df58d797487cad764eede

    Comments

    chromeos: adds more comments about child modal/transients
    
    And a DCHECK that we're not attempting to use a DesktopNativeWidgetAura for
    CHILD_MODAL windows.
    
    BUG=none
    TEST=none
    
    Change-Id: I9138c7d5fb83078e6ee5cfe04d8fbf8a12e1cc85
    Reviewed-on: https://chromium-review.googlesource.com/1134048
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574463}

    Changed files

    • ui/views/mus/desktop_window_tree_host_mus.cc
  84. [Picture in Picture] Create PictureInPictureControlEvent

    Changed by sawtelle - sawtelleohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 02:08:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 281b1ee604a3095d93c5bed1eb05e84f57db6966

    Comments

    [Picture in Picture] Create PictureInPictureControlEvent
    
    This change creates a subclass of Event called
    PictureInPictureControlEvent that can be called when
    a custom control is clicked on the Picture in Picture Window
     - the reason for this event specifically is that it also
    contains a String 'id', which is useful for a developer
    to see which control was clicked.
    
    Manual testing was done by initiating the call in
    overlay_window_views.cc by calling controller_->ControlClick() and
    confirming that the Event was triggered. An example can be seen at:
    https://stevensawtelle.github.io/pictureinpicture
        /picture_in_picture_example.html
    
    Note: There is still no built in way of assigning the string based on
    the id of the control that was clicked - that will come in a future CL.
    This CL is just to create the custom event.
    
    Bug: 854271
    Change-Id: Idf8c290c7f7745af8f492d3b3169ba4cadb2386a
    Reviewed-on: https://chromium-review.googlesource.com/1106615
    Commit-Queue: Steven Sawtelle <sawtelle@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: apacible <apacible@chromium.org>
    Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#574462}

    Changed files

    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/core_idl_files.gni
    • third_party/blink/renderer/core/events/BUILD.gn
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.cc
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.h
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.idl
    • third_party/blink/renderer/core/events/picture_in_picture_control_event_init.idl
    • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
  85. Unified: Get default focus on detailed view.

    Changed by Tetsui Ohkubo - tetsuiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:06:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704db340a765dc9972c0018b74fbb2908cb04d0c

    Comments

    Unified: Get default focus on detailed view.
    
    In UnifiedSystemTray, detailed view did not get focus when it is
    transitioned by keyboard.
    
    TEST=manual
    BUG=862504
    
    Change-Id: I9f39359d3fa72be4bff5d42e5a9f98144b1a1bad
    Reviewed-on: https://chromium-review.googlesource.com/1132899
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574461}

    Changed files

    • ash/system/tray/tray_detailed_view.cc
    • ash/system/tray/tray_detailed_view.h
    • ash/system/unified/unified_system_tray_controller.cc
    • ash/system/unified/unified_system_tray_view.cc
  86. Remove fetch_telemetry_dependencies DEPS hook.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:04:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bec21faa451d3fc5c62018430ec212d46db17707

    Comments

    Remove fetch_telemetry_dependencies DEPS hook.
    
    The recipes are using the new checkout_telemetry_binary_dependencies
    hook instead and the bots no longer set this gyp variable.
    
    Bug: 862640
    Change-Id: I53c136898a21f18d246b431c5b2a6b08bfb6a0d5
    Reviewed-on: https://chromium-review.googlesource.com/1134189
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574460}

    Changed files

    • DEPS
  87. Add chromeosInfoPrivate stylusStatus API (part 1)

    Changed by Michael Giuffrida - michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:02:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6279eb8c5898875d456fc753c8e28ca8cea08e80

    Comments

    Add chromeosInfoPrivate stylusStatus API (part 1)
    
    Adds the "stylusStatus" property to chromeosInfoPrivate.get(). Will be:
    - "unsupported" if the device doesn't support stylus input.
    - "supported" if the device supports it.
    
    Part 2 will add:
    - "seen" if supported and stylus has been used at least once or the
      device comes with an internal stylus.
    
    Test: try && manually using supported and unsupported devices
    Bug: 632814
    Change-Id: I343908bcada0d149410875b885416bdc17f907da
    Reviewed-on: https://chromium-review.googlesource.com/1123320
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Reviewed-by: Toni Barzic <tbarzic@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574459}

    Changed files

    • chrome/browser/chromeos/extensions/info_private_api.cc
    • chrome/browser/chromeos/extensions/info_private_apitest.cc
    • chrome/common/extensions/api/chromeos_info_private.json
    • chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
  88. Declarative Net Request: Handle flatbuffer indexed ruleset corruption.

    Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:59:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b7bb4be8c040188b1ad9e36ee9262dd6fcdf8f8

    Comments

    Declarative Net Request: Handle flatbuffer indexed ruleset corruption.
    
    The JSON rulesets provided by an extension for the Declarative Net Request API
    are indexed to a flatbuffer (indexed) format during extension installation. This
    indexed ruleset is excluded from content verification and it is possible that it
    may get corrupted, making the extension ruleset useless.
    
    This CL handles ruleset corruption by re-indexing the JSON ruleset if the
    indexed ruleset fails to load.
    
    BUG=852058
    
    Change-Id: Ief43cd8f2bc030ad634a92e1fcf7656d03abd4c0
    Reviewed-on: https://chromium-review.googlesource.com/1107479
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574458}

    Changed files

    • chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/ruleset_manager.cc
    • extensions/browser/api/declarative_net_request/ruleset_manager.h
    • extensions/browser/api/declarative_net_request/utils.cc
    • extensions/browser/api/declarative_net_request/utils.h
    • extensions/browser/sandboxed_unpacker.cc
    • tools/metrics/histograms/histograms.xml
  89. [Modern] Modernizes settings action bar

    Changed by Daniel Park - danielparkohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:51:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8b1c7455e423788c982bc899cd32cd635a2d2c

    Comments

    [Modern] Modernizes settings action bar
    
    > Changes action bar color to white
    > Adds shadow on scroll
    > Per Hannah's request, this change also affects ManageStorage
        - White action bar carries over to ManageStorage
    
    Bug: 834600
    Change-Id: Ib09e63bafbf03237ac07ff323743f689a73205fe
    Reviewed-on: https://chromium-review.googlesource.com/1098375
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Daniel Park <danielpark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574457}

    Changed files

    • chrome/android/java/res/drawable-hdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-mdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xxhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xxxhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/layout/add_languages_main.xml
    • chrome/android/java/res/layout/autofill_editor_base.xml
    • chrome/android/java/res/layout/bookmark_add_edit_folder_activity.xml
    • chrome/android/java/res/layout/bookmark_edit.xml
    • chrome/android/java/res/layout/bookmark_folder_select_activity.xml
    • chrome/android/java/res/layout/clear_browsing_data_tabs.xml
    • chrome/android/java/res/layout/homepage_editor.xml
    • chrome/android/java/res/layout/password_entry_editor_interactive.xml
    • chrome/android/java/res/layout/password_entry_exception.xml
    • chrome/android/java/res/layout/payment_request_editor.xml
    • chrome/android/java/res/layout/preferences_action_bar_shadow.xml
    • chrome/android/java/res/menu/prefeditor_editor_menu.xml
    • chrome/android/java/res/values-v17/styles.xml
    • chrome/android/java/res/values-v21/styles.xml
    • chrome/android/java/res/values/colors.xml
    • chrome/android/java/res/values/dimens.xml
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/HomepageEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferenceUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/AddLanguageFragment.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDialog.java
    • ui/android/java/res/values-v17/styles.xml
    • ui/android/java/res/values/colors.xml
  90. Mirroring Service: Supports switching between mirroring and remoting.

    Changed by Xiangjun Zhang - xjzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1eb8fa9af662dd108d6033c5d8813db78b8489ee

    Comments

    Mirroring Service: Supports switching between mirroring and remoting.
    
    Add the implementation to support the switching between mirroring and
    remoting. Also changed to only monitor the WiFi status when receiver
    indicates that it supports the get status message.
    
    Bug: 734672
    Change-Id: I72eefbcadc6f790c2573a81976cd9d0e2dbe3ae7
    Reviewed-on: https://chromium-review.googlesource.com/1104966
    Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
    Reviewed-by: Yuri Wiitala <miu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574456}

    Changed files

    • components/mirroring/service/BUILD.gn
    • components/mirroring/service/interface.h
    • components/mirroring/service/message_dispatcher.cc
    • components/mirroring/service/message_dispatcher.h
    • components/mirroring/service/message_dispatcher_unittest.cc
    • components/mirroring/service/session.cc
    • components/mirroring/service/session.h
    • components/mirroring/service/session_monitor.cc
    • components/mirroring/service/session_monitor.h
    • components/mirroring/service/session_monitor_unittest.cc
    • components/mirroring/service/session_unittest.cc
  91. Roll src/third_party/angle 89ef177f9475..5598148b7613 (5 commits)

    Changed by angle-chromium-autoroll - angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:48:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a77159361b8dbc319ff208be3a0a38970c79d2c5

    Comments

    Roll src/third_party/angle 89ef177f9475..5598148b7613 (5 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/89ef177f9475..5598148b7613
    
    
    git log 89ef177f9475..5598148b7613 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 jmadill@chromium.org Vulkan: Don't use gl::ErrorOrResult.
    2018-07-11 jmadill@chromium.org Vulkan: Clean up Error usage.
    2018-07-11 jmadill@chromium.org Vulkan: Move Feature init before device creation.
    2018-07-11 jmadill@chromium.org Generalize Context scratch buffer errors.
    2018-07-11 jmadill@chromium.org Refactor internal format pixel math methods.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@5598148b7613
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jmadill@chromium.org
    
    Change-Id: Ib007468f11fc8153eca19ee8925a7558fea89d47
    Reviewed-on: https://chromium-review.googlesource.com/1133872
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574455}

    Changed files

    • DEPS
  92. [scheduler] Refactor QueueCreationParams, separating out QueueTraits

    Changed by Scott Haseley - shaseleyohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 01:47:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 520720d455489da4f863ee202944c7dc0171ceaf

    Comments

    [scheduler] Refactor QueueCreationParams, separating out QueueTraits
    
    QueueTraits is the (deferrable, throttleable, pausable, freezable)
    4-tuple. We will be associating each non-loading TaskType with a
    QueueTraits to map it to a unique task queue.
    
    This CL also forward declares FrameSchedulerImpl in
    main_thread_task_queue.h and cleans up the necessary frame_scheduler_impl.h
    includes in files that were relying on the indirect include.
    
    Bug: 859963
    Change-Id: I84f883379d718d85e5baf806f199181d7e7bf753
    Reviewed-on: https://chromium-review.googlesource.com/1125033
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Commit-Queue: Scott Haseley <shaseley@google.com>
    Cr-Commit-Position: refs/heads/master@{#574454}

    Changed files

    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
    • third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
    • third_party/blink/renderer/platform/scheduler/test/fake_frame_scheduler.h
  93. [LayoutNG] Fix handling of generated boxes in ComputeNGCaretPosition

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:45:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bce39b0838948fbed6bcea5f4e88d4890d7edd2

    Comments

    [LayoutNG] Fix handling of generated boxes in ComputeNGCaretPosition
    
    Since there is no caret position allowed at the sides of a generated or
    pseudo inline box, ComputeNGCaretPosition should skip such box
    fragments.
    
    Existing code only checks GetNode() of the box fragment, which misses
    the case where GetNode() returns a pseudo node, and is fixed in this
    patch.
    
    Bug: 861669
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I4e46f25ea07b66fa9b4821a8944db3f854c839ae
    Reviewed-on: https://chromium-review.googlesource.com/1134396
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574453}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_caret_position.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_caret_position_test.cc
  94. [VK] Tidy up KeyboardController::PopulateKeyboardContent.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:42:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0cb32b12d33d62e3e56c9b8c9922aa9d5ca2b68f

    Comments

    [VK] Tidy up KeyboardController::PopulateKeyboardContent.
    
    Just moved some code around. Looks more consistent IMO when every switch
    case early returns.
    
    Bug: 845780
    Change-Id: If828b05cb088395d1e44d83ec038b57e8bffe9bd
    Reviewed-on: https://chromium-review.googlesource.com/1132908
    Reviewed-by: Blake O'Hare <blakeo@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574452}

    Changed files

    • ui/keyboard/keyboard_controller.cc
  95. Luci configs for Oreo Phone Tester on chromium.android

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:40:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c73e96e974871abb7258d040f9bbbdc85c9807e9

    Comments

    Luci configs for Oreo Phone Tester on chromium.android
    
    And move its testing spec to chromium.android
    
    Bug: 862645
    Change-Id: I2a45d509faeba8b75ef8d7ed1b1d8e95e347dddd
    Reviewed-on: https://chromium-review.googlesource.com/1134420
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574451}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
  96. Add icon getter for CWVAutofillSuggestion.

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision de45c8fcb6f97db5346bc6a52dc4edba0b7d1f3e

    Comments

    Add icon getter for CWVAutofillSuggestion.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic1c360a24dfdb35581a13cf0532173d66c9f953c
    Reviewed-on: https://chromium-review.googlesource.com/1131050
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: John Wu <jzw@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574450}

    Changed files

    • ios/web_view/internal/autofill/cwv_autofill_suggestion.mm
    • ios/web_view/public/cwv_autofill_suggestion.h
  97. Reland "Use BigBuffer for legacy IPC messages"

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:37:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c5bd80e5a7b379c0539ef33c5722fb1ee974cda

    Comments

    Reland "Use BigBuffer for legacy IPC messages"
    
    This is a reland of 3e126191c1a7a022260c1072b1b9288f09bb2dce,
    unchanged.
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1134079
    fixes the root cause of the failure which caused this to be
    reverted. This CL can land once that one does.
    
    Original change's description:
    > Use BigBuffer for legacy IPC messages
    >
    > This replaces use of ReadOnlyBuffer with a new mojom Message type
    > specific to //ipc. This type maps to another new C++ MessageView type
    > which in turn wraps a BigBufferView.
    >
    > This allows us to transparently fall back onto shared memory for large
    > IPC messages without increasing the number of copies during send or
    > receive in any (small- or large-message) cases.
    >
    > In order to avoid introducing more mojo-base targets, this also removes
    > the remaining [Native] structs from mojo_base mojom (LOGFONT and
    > FileInfo) and replaces them with real mojom structures + StructTraits,
    > thus allowing //ipc to depend on mojo/public/*/base in its entirety.
    >
    > Also fixes random missing public_deps entries for a
    > chrome/services/file_util typemap, because it decided to start breaking
    > all of my local builds. :3
    >
    > Bug: 784069
    > Change-Id: I359b964ffc1fe44ffd6aa704405ea63156f4fbc9
    > Reviewed-on: https://chromium-review.googlesource.com/1131685
    > Commit-Queue: Ken Rockot <rockot@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573956}
    
    TBR=dcheng@chromium.org
    
    Bug: 784069
    Change-Id: I1224367e9db026cb06b0099ee5dfdada89804f23
    Reviewed-on: https://chromium-review.googlesource.com/1134100
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574449}

    Changed files

    • chrome/services/file_util/public/mojom/safe_archive_analyzer.typemap
    • ipc/BUILD.gn
    • ipc/OWNERS
    • ipc/ipc.mojom
    • ipc/ipc_message_pipe_reader.cc
    • ipc/ipc_message_pipe_reader.h
    • ipc/ipc_message_utils.cc
    • ipc/ipc_message_utils.h
    • ipc/ipc_mojo_bootstrap_unittest.cc
    • ipc/message.typemap
    • ipc/message_mojom_traits.cc
    • ipc/message_mojom_traits.h
    • ipc/message_view.cc
    • ipc/message_view.h
    • ipc/typemaps.gni
    • mojo/public/cpp/base/BUILD.gn
    • mojo/public/cpp/base/file_info.typemap
    • mojo/public/cpp/base/file_info_mojom_traits.cc
    • mojo/public/cpp/base/file_info_mojom_traits.h
    • mojo/public/cpp/base/logfont_win.typemap
    • mojo/public/cpp/base/logfont_win_mojom_traits.cc
    • mojo/public/cpp/base/logfont_win_mojom_traits.h
    • mojo/public/cpp/base/time.typemap
    • mojo/public/cpp/base/time_mojom_traits.h
    • mojo/public/mojom/base/file_info.mojom
    • mojo/public/mojom/base/logfont_win.mojom
    • mojo/public/tools/bindings/chromium_bindings_configuration.gni
  98. WebApp: Extract web_applications source sets in GN.

    Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:36:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d538ba3e10d2498292aa429cef90d8b6c18473cd

    Comments

    WebApp: Extract web_applications source sets in GN.
    
    This CL reflects the existing dependencies and dependency
    cycles we have.
    
    Also, we want to establish the following folders in web_applications/:
    1) components/
    Any independent components which are shared between extensions/
    and web_applications/
    
    2) extensions/
    A code which is thematically part of chrome/browser/extensions/
    E.g. an upcoming BookmarkAppInstaller will be used by extensions.
    
    3) bookmark_apps/
    Any extension-based high-level helpers which are used by chrome/browser/
    
    Note that web_applications/policy content will be moved to
    web_applications/bookmark_apps/policy/
    
    Bug: 860581
    Change-Id: Ib89f0e327759cfab050caceae5818c8e72f40f08
    Reviewed-on: https://chromium-review.googlesource.com/1128665
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574448}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/extensions/BUILD.gn
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/web_applications/BUILD.gn
    • chrome/browser/web_applications/bookmark_apps/BUILD.gn
    • chrome/browser/web_applications/components/BUILD.gn
    • chrome/browser/web_applications/extensions/BUILD.gn
    • chrome/browser/web_applications/policy/BUILD.gn
    • chrome/test/BUILD.gn
  99. Add isDemoSession to chrome.app.runtime LaunchData

    Changed by Michael Giuffrida - michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:33:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 456e84e95d9f7060c117953d251e121bc052b158

    Comments

    Add isDemoSession to chrome.app.runtime LaunchData
    
    Adds the |isDemoSession| boolean property to launch data for the
    chrome.app.runtime.onLaunched event.
    
    Built-in platform apps on Chrome OS will check this to enable special
    Chrome OS Demo Mode behavior.
    
    This CL adds the property as |false|; a follow-up CL will correctly set
    it to |true| when the device is actually in Demo Mode.
    
    Bug: 835024
    Change-Id: Ie77f50f1551c3dfb00fff27e7779775ceca1f44d
    Reviewed-on: https://chromium-review.googlesource.com/1121113
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574447}

    Changed files

    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/test/data/extensions/platform_apps/launch_file/test.js
    • chrome/test/data/extensions/platform_apps/launch_whitelisted_ext_with_file/test.js
    • chromecast/browser/extensions/cast_extensions_browser_client.cc
    • chromecast/browser/extensions/cast_extensions_browser_client.h
    • extensions/browser/api/app_runtime/app_runtime_api.cc
    • extensions/browser/extensions_browser_client.h
    • extensions/browser/test_extensions_browser_client.cc
    • extensions/browser/test_extensions_browser_client.h
    • extensions/common/api/app_runtime.idl
    • extensions/renderer/resources/app_runtime_custom_bindings.js
    • extensions/shell/browser/shell_extensions_browser_client.cc
    • extensions/shell/browser/shell_extensions_browser_client.h
  100. Roll src/third_party/pdfium b165ffb64e59..d8882193737a (8 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:32:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b787d55ee623265f615215231a0fe6bc860b1

    Comments

    Roll src/third_party/pdfium b165ffb64e59..d8882193737a (8 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/b165ffb64e59..d8882193737a
    
    
    git log b165ffb64e59..d8882193737a --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 hnakashima@chromium.org Inline GetMarkParamPairAtIndex into FPDFPageObjMark_GetParamKey.
    2018-07-11 thestig@chromium.org Roll third_party/yasm/source/patched-yasm/ b98114e18..720b70524 (1 commit)
    2018-07-11 hnakashima@chromium.org Rename content mark parameter value getters.
    2018-07-11 hnakashima@chromium.org Remove clunky mark property value getters by index.
    2018-07-11 hnakashima@chromium.org Write marked content operators when generating a stream.
    2018-07-11 hnakashima@chromium.org Store property name for marked content with an indirect dict.
    2018-07-11 hnakashima@chromium.org Cleanup CPDF_ContentMark.
    2018-07-11 hnakashima@chromium.org Split CPDF_ContentMark::AddMark() into three versions.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@d8882193737a
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I7acff8886402b7c92a599963707f72dacaa02ffa
    Reviewed-on: https://chromium-review.googlesource.com/1133877
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574446}

    Changed files

    • DEPS
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>