Home | Search | chromium - Builders
Login

Builder ios-simulator Build 39230 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisione02c93aa236dd55c50eafd019f865e192192ac34
Got Revisione02c93aa236dd55c50eafd019f865e192192ac34

Execution:

Steps and Logfiles:

Show:
  1. ( 263 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 2 mins 8 secs ) bot_update
    [152GB/232GB used (65%)]
  3. ( 727 ms ) read build config
  4. ( 23 secs ) gclient runhooks
  5. ( 632 ms ) lookup GN args
     
    is_component_build = false
    is_debug = true
    symbol_level = 1
    target_cpu = "x64"
    target_os = "ios"
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  6. ( 5 mins 18 secs ) compile
  7. ( 7 secs ) base_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:05:04.601575
  8. ( 2 mins 17 secs ) components_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:07:49.881591
  9. ( 6 secs ) gfx_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:56.538596
  10. ( 7 secs ) ios_chrome_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:06:34.095598
  11. ( 6 secs ) ios_web_inttests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:05:13.208884
  12. ( 6 secs ) ios_web_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:14.055637
  13. ( 6 secs ) ios_web_view_inttests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:22.950570
  14. ( 6 secs ) ios_web_view_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:51.665690
  15. ( 6 secs ) skia_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:03.511210
  16. ( 6 secs ) ui_base_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:32.410250
  17. ( 8 secs ) base_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:05:09.080789
  18. ( 8 secs ) components_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:06:57.376726
  19. ( 6 secs ) gfx_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:06.324825
  20. ( 6 secs ) ios_chrome_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:07:48.313267
  21. ( 6 secs ) ios_web_inttests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:04:28.973777
  22. ( 6 secs ) ios_web_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:49.029269
  23. ( 6 secs ) ios_web_view_inttests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:37.324566
  24. ( 7 secs ) ios_web_view_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:34.748269
  25. ( 5 secs ) skia_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:10.901440
  26. ( 7 secs ) ui_base_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:47.087891
  27. ( 6 secs ) boringssl_crypto_tests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:23.979315
  28. ( 6 secs ) boringssl_ssl_tests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:06.155456
  29. ( 6 secs ) crypto_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:33.349316
  30. ( 6 secs ) google_apis_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:32.184427
  31. ( 6 secs ) ios_components_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:12.340983
  32. ( 6 secs ) ios_net_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:21.490112
  33. ( 6 secs ) ios_remoting_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:23.912821
  34. ( 25 secs ) net_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:10:11.152385
  35. ( 6 secs ) ocmock_support_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:53.156192
  36. ( 6 secs ) services_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:08.237379
  37. ( 7 secs ) sql_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:57.560386
  38. ( 6 secs ) url_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:13.165175
  39. ( 8 secs ) base_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:05:30.867990
  40. ( 8 secs ) components_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:06:28.031230
  41. ( 6 secs ) gfx_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:19.646511
  42. ( 7 secs ) ios_chrome_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:06:50.637114
  43. ( 6 secs ) ios_web_inttests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:04:44.510130
  44. ( 6 secs ) ios_web_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:05.862949
  45. ( 6 secs ) ios_web_view_inttests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:22.235243
  46. ( 6 secs ) ios_web_view_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:16.693372
  47. ( 6 secs ) skia_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:00.748998
  48. ( 6 secs ) ui_base_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:47.958761
  49. ( 3 secs ) base_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:05:02.375558
  50. ( 5 secs ) components_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:06:46.391944
  51. ( 2 secs ) gfx_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:41.257217
  52. ( 2 secs ) ios_chrome_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Pending time: 11s
    Shard duration: 0:05:45.453750
  53. ( 2 secs ) ios_web_inttests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Pending time: 10s
    Shard duration: 0:03:57.673161
  54. ( 2 secs ) ios_web_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:41.179677
  55. ( 2 secs ) ios_web_view_inttests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:08.363299
  56. ( 2 secs ) ios_web_view_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:03:01.968718
  57. ( 2 secs ) skia_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:15.637763
  58. ( 2 secs ) ui_base_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:09.785290
  59. ( 3 secs ) base_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:05:02.885719
  60. ( 4 secs ) components_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:06:42.567805
  61. ( 2 secs ) gfx_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:15.881748
  62. ( 3 secs ) ios_chrome_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:06:30.885711
  63. ( 2 secs ) ios_web_inttests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:05:10.101049
  64. ( 2 secs ) ios_web_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:03:32.317764
  65. ( 2 secs ) ios_web_view_inttests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:53.433399
  66. ( 2 secs ) ios_web_view_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:29.487988
  67. ( 2 secs ) skia_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:46.178791
  68. ( 2 secs ) ui_base_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:50.760533
  69. ( 2 secs ) boringssl_crypto_tests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:03:53.013510
  70. ( 2 secs ) boringssl_ssl_tests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:06.675732
  71. ( 2 secs ) crypto_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:25.481680
  72. ( 2 secs ) google_apis_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:16.417500
  73. ( 2 secs ) ios_components_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:15.211745
  74. ( 2 secs ) ios_net_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:08.761803
  75. ( 2 secs ) ios_remoting_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:45.342631
  76. ( 19 secs ) net_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:07:58.529014
  77. ( 2 secs ) ocmock_support_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:28.443061
  78. ( 2 secs ) services_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:23.697343
  79. ( 2 secs ) sql_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:29.513532
  80. ( 2 secs ) url_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:31.078227
  81. ( 3 secs ) base_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:04:11.273234
  82. ( 6 secs ) components_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:04:55.213265
  83. ( 2 secs ) gfx_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:51.111939
  84. ( 2 secs ) ios_chrome_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:06:12.363802
  85. ( 2 secs ) ios_web_inttests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:04:14.365331
  86. ( 2 secs ) ios_web_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:03.296748
  87. ( 2 secs ) ios_web_view_inttests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:56.989969
  88. ( 2 secs ) ios_web_view_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:39.226149
  89. ( 2 secs ) skia_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:29.776966
  90. ( 2 secs ) ui_base_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:30.293749
  91. ( 5 secs ) ios_chrome_integration_egtests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:15:57.825912
  92. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:08:11.411237
  93. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:11:58.170667
  94. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 2
    Run on OS: 'Mac'
    Shard duration: 0:07:54.178677
  95. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 3
    Run on OS: 'Mac'
    Shard duration: 0:07:17.042515
  96. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 4
    Run on OS: 'Mac'
    Shard duration: 0:09:09.072424
  97. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 5
    Run on OS: 'Mac'
    Shard duration: 0:07:48.633343
  98. ( 2 secs ) ios_web_shell_egtests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:00.064408
  99. ( 387 ms ) Tests statistics
     
    Stats
    Total shards: 92
    Total runtime: 4:11:54.654132
     
  100. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm63-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541783491732445, "id": "8930316549332062736", "project": "chromium", "tags": ["builder:ios-simulator", "buildset:commit/git/e02c93aa236dd55c50eafd019f865e192192ac34", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e02c93aa236dd55c50eafd019f865e192192ac34", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095746611529088688", "scheduler_job_id:chromium/ios-simulator", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-simulator" setup_build
buildnumber 39230 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "e02c93aa236dd55c50eafd019f865e192192ac34" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "e02c93aa236dd55c50eafd019f865e192192ac34" bot_update
got_revision_cp "refs/heads/master@{#606875}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update

Blamelist:

  1. Tatiana Buldina (buldinaohnoyoudont@chromium.org)
  2. Philip Rogers (pdrohnoyoudont@chromium.org)
  3. Sky Malice (skymohnoyoudont@google.com)
  4. Scott Graham (scottmgohnoyoudont@chromium.org)
  5. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  6. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  7. David Jean (djeanohnoyoudont@google.com)
  8. Lei Zhang (thestigohnoyoudont@chromium.org)
  9. Yi Su (mrsuyiohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 17:11:31 UTC
Start Friday, 09-Nov-18 17:11:35 UTC
End Friday, 09-Nov-18 17:46:07 UTC
Pending 3 secs
Execution 34 mins 31 secs

All Changes:

  1. [ChromeDriver] Add tests names where Chrome retried to start to logs

    Changed by Tatiana Buldina - buldinaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e02c93aa236dd55c50eafd019f865e192192ac34

    Comments

    [ChromeDriver] Add tests names where Chrome retried to start to logs
    
    Change-Id: I6d2cf48b16562f60e35b2d499bfbbe25c12533c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1327168
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606875}

    Changed files

    • chrome/test/chromedriver/client/chromedriver.py
    • chrome/test/chromedriver/test/run_py_tests.py
  2. [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed

    Changed by Philip Rogers - pdrohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f5a1bd0249536b05ba2d3b45f175e742d1a6a47

    Comments

    [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed
    
    PaintPropertyTreeNode::Changed is used for in-layer raster invalidation,
    and cc damage for both SPV2 and BGPT. https://crrev.com/606472 failed
    to account for the case when non-transient paint controllers in
    GraphicsLayers would clear property tree changed values before the
    values could be used for damage.
    
    As a reminder, with BlinkGenPropertyTrees, each GraphicsLayer keeps a
    non-transient paint controller, and at the end of painting a transient
    paint controller is created and each GraphicsLayer's cc::Layer is
    inserted as a foreign layer into the transient paint controller.
    
    This patch changes BGPT to clear all property tree changed bits after
    damage has been calculated in PaintArtifactCompositor. It is implemented
    with a recursive walk of the GraphicsLayer tree.
    
    Bug: 899628
    Change-Id: Ibc7d65d6ab8875508b9c3dd18ab6db1230bf1308
    Reviewed-on: https://chromium-review.googlesource.com/c/1327804
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606874}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/clip/clip-path-constant-repaint-expected.txt
    • third_party/blink/renderer/core/exported/web_layer_test.cc
    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_artifact.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.h
    • third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
  3. [Feed] When rescheduling, just set period to 1 day instead of going to

    Changed by Sky Malice - skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:02:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1dc99fe0bd2792457e4cc526e945df228ec47234

    Comments

    [Feed] When rescheduling, just set period to 1 day instead of going to
    native.
    
    Bug: 901331
    Change-Id: I65b3d748cb96669fa78a712552f82a44873debf3
    Reviewed-on: https://chromium-review.googlesource.com/c/1315929
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606873}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedRefreshTask.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
  4. fuchsia: Update sdk build job link in docs

    Changed by Scott Graham - scottmgohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e05b6f1c53bf3cfa376b672b70ed83643274b56

    Comments

    fuchsia: Update sdk build job link in docs
    
    Change-Id: I203f142ee84ecefeb36adaf9da175404f75194eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1329506
    Commit-Queue: Scott Graham <scottmg@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606872}

    Changed files

    • docs/fuchsia_sdk_updates.md
  5. Retire PerformanceNavigationTiming2 runtime enabled flag.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:56:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48519d5c39fc3533942f8107cce3df766e1d45b2

    Comments

    Retire PerformanceNavigationTiming2 runtime enabled flag.
    
    Feature first shipped in M57.
    
    BUG=611276
    
    Change-Id: Ib4b514df4f72b29333b534e6978ea8fa3dea5128
    Reviewed-on: https://chromium-review.googlesource.com/c/1323628
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606871}

    Changed files

    • third_party/blink/renderer/core/timing/performance_navigation_timing.idl
    • third_party/blink/renderer/core/timing/window_performance.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  6. [Autofill Assistant] Integrate Payment Request.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:54:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56a06fd5e79c627d247ce9976c217ea14a17c9c5

    Comments

    [Autofill Assistant] Integrate Payment Request.
    
    This patch is the first step to integrate the payment request UI into
    the autofill assistant sheet.
    
    The patch has and leaves a few rough edges but we'll deal with that
    piece by piece. In particular, the dismiss logic needs to be handled
    differently, so does the error view logic.
    
    Note: The DimmingDialog is reverted to package default visibility since
    the dependency from autofill assistant is removed here.
    
    Bug: 806868
    Change-Id: I25b83b804e13bbdec5d2a1688dd01cd085615b38
    Reviewed-on: https://chromium-review.googlesource.com/c/1324451
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606870}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request_bottom_bar.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/BottomBarAnimations.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • chrome/android/java/src/org/chromium/chrome/browser/payments/ui/DimmingDialog.java
  7. [ios] plug in manual fallback for credit card and address

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:50:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec464d0a7b2ab771c1c7642a3568de17f4904b29

    Comments

    [ios] plug in manual fallback for credit card and address
    
    Bug: 845472
    Change-Id: Ie26e9022b60612b5ef90c7e9b2bde4202e6e745c
    Reviewed-on: https://chromium-review.googlesource.com/c/1319594
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606869}

    Changed files

    • ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
  8. Fix a typo in bisect-builds.py.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:46:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c8c6f7ecd6a1927225c2257544c6d370441854f

    Comments

    Fix a typo in bisect-builds.py.
    
    Windows archives extract out into a directory called chrome-win. There
    is no chrome-winp directory.
    
    TBR=robertocn@chromium.org
    
    Change-Id: Ia5ee2725e107f32c44105ca396e28a4c0a06844c
    Reviewed-on: https://chromium-review.googlesource.com/c/1313731
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606868}

    Changed files

    • tools/bisect-builds.py
  9. Remove JavaScript const/let/lambda presubmit check for iOS9.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:44:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a81bed5026f4a47ed9a0b690b0a950260f6e3e06

    Comments

    Remove JavaScript const/let/lambda presubmit check for iOS9.
    
    iOS9 is not supported by Chrome iOS and iGSA anymore, the presubmit check
    for risky ES6 grammar(const/let/lambda) can be removed now.
    
    Change-Id: I5a35d54097dbd215393aaba78868107befdc93b6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329249
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606867}

    Changed files

    • PRESUBMIT.py
    • PRESUBMIT_test.py