Home | Search | chromium - Builders
Login

Builder ios-simulator Build 38250 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3
Got Revision4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3

Execution:

Steps and Logfiles:

Show:
  1. ( 262 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 2 mins 7 secs ) bot_update
    [169GB/232GB used (72%)]
  3. ( 474 ms ) read build config
  4. ( 0 ) ensure_goma
  5. ( 0 ) ensure xcode
    Ensuring Xcode version 10a254a in /b/s/w/ir/cache/xcode_ios_10a254a.app
  6. ( 20 secs ) gclient runhooks
  7. ( 624 ms ) lookup GN args
     
    additional_target_cpus = [ "x86" ]
    is_component_build = false
    is_debug = true
    symbol_level = 1
    target_cpu = "x64"
    target_os = "ios"
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  8. ( 8 mins 19 secs ) compile
  9. ( 0 ) isolate
  10. ( 623 ms ) isolate.generate 0.isolated.gen.json
    base_unittests (iPhone 6s Plus iOS 12.0)
  11. ( 621 ms ) isolate.generate 1.isolated.gen.json
    components_unittests (iPhone 6s Plus iOS 12.0)
  12. ( 619 ms ) isolate.generate 2.isolated.gen.json
    gfx_unittests (iPhone 6s Plus iOS 12.0)
  13. ( 607 ms ) isolate.generate 3.isolated.gen.json
    ios_chrome_unittests (iPhone 6s Plus iOS 12.0)
  14. ( 616 ms ) isolate.generate 4.isolated.gen.json
    ios_web_inttests (iPhone 6s Plus iOS 12.0)
  15. ( 611 ms ) isolate.generate 5.isolated.gen.json
    ios_web_unittests (iPhone 6s Plus iOS 12.0)
  16. ( 606 ms ) isolate.generate 6.isolated.gen.json
    ios_web_view_inttests (iPhone 6s Plus iOS 12.0)
  17. ( 610 ms ) isolate.generate 7.isolated.gen.json
    ios_web_view_unittests (iPhone 6s Plus iOS 12.0)
  18. ( 612 ms ) isolate.generate 8.isolated.gen.json
    skia_unittests (iPhone 6s Plus iOS 12.0)
  19. ( 606 ms ) isolate.generate 9.isolated.gen.json
    ui_base_unittests (iPhone 6s Plus iOS 12.0)
  20. ( 612 ms ) isolate.generate 10.isolated.gen.json
    base_unittests (iPhone 6s iOS 12.0)
  21. ( 605 ms ) isolate.generate 11.isolated.gen.json
    components_unittests (iPhone 6s iOS 12.0)
  22. ( 605 ms ) isolate.generate 12.isolated.gen.json
    gfx_unittests (iPhone 6s iOS 12.0)
  23. ( 609 ms ) isolate.generate 13.isolated.gen.json
    ios_chrome_unittests (iPhone 6s iOS 12.0)
  24. ( 604 ms ) isolate.generate 14.isolated.gen.json
    ios_web_inttests (iPhone 6s iOS 12.0)
  25. ( 606 ms ) isolate.generate 15.isolated.gen.json
    ios_web_unittests (iPhone 6s iOS 12.0)
  26. ( 612 ms ) isolate.generate 16.isolated.gen.json
    ios_web_view_inttests (iPhone 6s iOS 12.0)
  27. ( 611 ms ) isolate.generate 17.isolated.gen.json
    ios_web_view_unittests (iPhone 6s iOS 12.0)
  28. ( 606 ms ) isolate.generate 18.isolated.gen.json
    skia_unittests (iPhone 6s iOS 12.0)
  29. ( 611 ms ) isolate.generate 19.isolated.gen.json
    ui_base_unittests (iPhone 6s iOS 12.0)
  30. ( 613 ms ) isolate.generate 20.isolated.gen.json
    boringssl_crypto_tests (iPhone 6s iOS 12.0)
  31. ( 613 ms ) isolate.generate 21.isolated.gen.json
    boringssl_ssl_tests (iPhone 6s iOS 12.0)
  32. ( 598 ms ) isolate.generate 22.isolated.gen.json
    crypto_unittests (iPhone 6s iOS 12.0)
  33. ( 601 ms ) isolate.generate 23.isolated.gen.json
    google_apis_unittests (iPhone 6s iOS 12.0)
  34. ( 607 ms ) isolate.generate 24.isolated.gen.json
    ios_components_unittests (iPhone 6s iOS 12.0)
  35. ( 612 ms ) isolate.generate 25.isolated.gen.json
    ios_net_unittests (iPhone 6s iOS 12.0)
  36. ( 610 ms ) isolate.generate 26.isolated.gen.json
    ios_remoting_unittests (iPhone 6s iOS 12.0)
  37. ( 606 ms ) isolate.generate 27.isolated.gen.json
    net_unittests (iPhone 6s iOS 12.0)
  38. ( 605 ms ) isolate.generate 28.isolated.gen.json
    ocmock_support_unittests (iPhone 6s iOS 12.0)
  39. ( 604 ms ) isolate.generate 29.isolated.gen.json
    services_unittests (iPhone 6s iOS 12.0)
  40. ( 613 ms ) isolate.generate 30.isolated.gen.json
    sql_unittests (iPhone 6s iOS 12.0)
  41. ( 640 ms ) isolate.generate 31.isolated.gen.json
    url_unittests (iPhone 6s iOS 12.0)
  42. ( 608 ms ) isolate.generate 32.isolated.gen.json
    base_unittests (iPad Air 2 iOS 12.0)
  43. ( 613 ms ) isolate.generate 33.isolated.gen.json
    components_unittests (iPad Air 2 iOS 12.0)
  44. ( 607 ms ) isolate.generate 34.isolated.gen.json
    gfx_unittests (iPad Air 2 iOS 12.0)
  45. ( 611 ms ) isolate.generate 35.isolated.gen.json
    ios_chrome_unittests (iPad Air 2 iOS 12.0)
  46. ( 609 ms ) isolate.generate 36.isolated.gen.json
    ios_web_inttests (iPad Air 2 iOS 12.0)
  47. ( 620 ms ) isolate.generate 37.isolated.gen.json
    ios_web_unittests (iPad Air 2 iOS 12.0)
  48. ( 612 ms ) isolate.generate 38.isolated.gen.json
    ios_web_view_inttests (iPad Air 2 iOS 12.0)
  49. ( 612 ms ) isolate.generate 39.isolated.gen.json
    ios_web_view_unittests (iPad Air 2 iOS 12.0)
  50. ( 612 ms ) isolate.generate 40.isolated.gen.json
    skia_unittests (iPad Air 2 iOS 12.0)
  51. ( 614 ms ) isolate.generate 41.isolated.gen.json
    ui_base_unittests (iPad Air 2 iOS 12.0)
  52. ( 617 ms ) isolate.generate 42.isolated.gen.json
    base_unittests (iPhone 6s Plus iOS 11.4)
  53. ( 601 ms ) isolate.generate 43.isolated.gen.json
    components_unittests (iPhone 6s Plus iOS 11.4)
  54. ( 606 ms ) isolate.generate 44.isolated.gen.json
    gfx_unittests (iPhone 6s Plus iOS 11.4)
  55. ( 610 ms ) isolate.generate 45.isolated.gen.json
    ios_chrome_unittests (iPhone 6s Plus iOS 11.4)
  56. ( 609 ms ) isolate.generate 46.isolated.gen.json
    ios_web_inttests (iPhone 6s Plus iOS 11.4)
  57. ( 619 ms ) isolate.generate 47.isolated.gen.json
    ios_web_unittests (iPhone 6s Plus iOS 11.4)
  58. ( 609 ms ) isolate.generate 48.isolated.gen.json
    ios_web_view_inttests (iPhone 6s Plus iOS 11.4)
  59. ( 607 ms ) isolate.generate 49.isolated.gen.json
    ios_web_view_unittests (iPhone 6s Plus iOS 11.4)
  60. ( 603 ms ) isolate.generate 50.isolated.gen.json
    skia_unittests (iPhone 6s Plus iOS 11.4)
  61. ( 697 ms ) isolate.generate 51.isolated.gen.json
    ui_base_unittests (iPhone 6s Plus iOS 11.4)
  62. ( 618 ms ) isolate.generate 52.isolated.gen.json
    base_unittests (iPhone 6s iOS 11.4)
  63. ( 662 ms ) isolate.generate 53.isolated.gen.json
    components_unittests (iPhone 6s iOS 11.4)
  64. ( 616 ms ) isolate.generate 54.isolated.gen.json
    gfx_unittests (iPhone 6s iOS 11.4)
  65. ( 613 ms ) isolate.generate 55.isolated.gen.json
    ios_chrome_unittests (iPhone 6s iOS 11.4)
  66. ( 602 ms ) isolate.generate 56.isolated.gen.json
    ios_web_inttests (iPhone 6s iOS 11.4)
  67. ( 611 ms ) isolate.generate 57.isolated.gen.json
    ios_web_unittests (iPhone 6s iOS 11.4)
  68. ( 632 ms ) isolate.generate 58.isolated.gen.json
    ios_web_view_inttests (iPhone 6s iOS 11.4)
  69. ( 613 ms ) isolate.generate 59.isolated.gen.json
    ios_web_view_unittests (iPhone 6s iOS 11.4)
  70. ( 604 ms ) isolate.generate 60.isolated.gen.json
    skia_unittests (iPhone 6s iOS 11.4)
  71. ( 611 ms ) isolate.generate 61.isolated.gen.json
    ui_base_unittests (iPhone 6s iOS 11.4)
  72. ( 618 ms ) isolate.generate 62.isolated.gen.json
    boringssl_crypto_tests (iPhone 6s iOS 11.4)
  73. ( 615 ms ) isolate.generate 63.isolated.gen.json
    boringssl_ssl_tests (iPhone 6s iOS 11.4)
  74. ( 613 ms ) isolate.generate 64.isolated.gen.json
    crypto_unittests (iPhone 6s iOS 11.4)
  75. ( 629 ms ) isolate.generate 65.isolated.gen.json
    google_apis_unittests (iPhone 6s iOS 11.4)
  76. ( 618 ms ) isolate.generate 66.isolated.gen.json
    ios_components_unittests (iPhone 6s iOS 11.4)
  77. ( 628 ms ) isolate.generate 67.isolated.gen.json
    ios_net_unittests (iPhone 6s iOS 11.4)
  78. ( 611 ms ) isolate.generate 68.isolated.gen.json
    ios_remoting_unittests (iPhone 6s iOS 11.4)
  79. ( 615 ms ) isolate.generate 69.isolated.gen.json
    net_unittests (iPhone 6s iOS 11.4)
  80. ( 620 ms ) isolate.generate 70.isolated.gen.json
    ocmock_support_unittests (iPhone 6s iOS 11.4)
  81. ( 606 ms ) isolate.generate 71.isolated.gen.json
    services_unittests (iPhone 6s iOS 11.4)
  82. ( 646 ms ) isolate.generate 72.isolated.gen.json
    sql_unittests (iPhone 6s iOS 11.4)
  83. ( 777 ms ) isolate.generate 73.isolated.gen.json
    url_unittests (iPhone 6s iOS 11.4)
  84. ( 662 ms ) isolate.generate 74.isolated.gen.json
    base_unittests (iPad Air 2 iOS 11.4)
  85. ( 619 ms ) isolate.generate 75.isolated.gen.json
    components_unittests (iPad Air 2 iOS 11.4)
  86. ( 622 ms ) isolate.generate 76.isolated.gen.json
    gfx_unittests (iPad Air 2 iOS 11.4)
  87. ( 635 ms ) isolate.generate 77.isolated.gen.json
    ios_chrome_unittests (iPad Air 2 iOS 11.4)
  88. ( 604 ms ) isolate.generate 78.isolated.gen.json
    ios_web_inttests (iPad Air 2 iOS 11.4)
  89. ( 626 ms ) isolate.generate 79.isolated.gen.json
    ios_web_unittests (iPad Air 2 iOS 11.4)
  90. ( 618 ms ) isolate.generate 80.isolated.gen.json
    ios_web_view_inttests (iPad Air 2 iOS 11.4)
  91. ( 619 ms ) isolate.generate 81.isolated.gen.json
    ios_web_view_unittests (iPad Air 2 iOS 11.4)
  92. ( 642 ms ) isolate.generate 82.isolated.gen.json
    skia_unittests (iPad Air 2 iOS 11.4)
  93. ( 609 ms ) isolate.generate 83.isolated.gen.json
    ui_base_unittests (iPad Air 2 iOS 11.4)
  94. ( 603 ms ) isolate.generate 84.isolated.gen.json
    base_unittests (iPad Air 2 iOS 10.3)
  95. ( 617 ms ) isolate.generate 85.isolated.gen.json
    components_unittests (iPad Air 2 iOS 10.3)
  96. ( 621 ms ) isolate.generate 86.isolated.gen.json
    gfx_unittests (iPad Air 2 iOS 10.3)
  97. ( 611 ms ) isolate.generate 87.isolated.gen.json
    ios_chrome_unittests (iPad Air 2 iOS 10.3)
  98. ( 640 ms ) isolate.generate 88.isolated.gen.json
    ios_web_inttests (iPad Air 2 iOS 10.3)
  99. ( 649 ms ) isolate.generate 89.isolated.gen.json
    ios_web_unittests (iPad Air 2 iOS 10.3)
  100. ( 624 ms ) isolate.generate 90.isolated.gen.json
    ios_web_view_inttests (iPad Air 2 iOS 10.3)
  101. ( 620 ms ) isolate.generate 91.isolated.gen.json
    ios_web_view_unittests (iPad Air 2 iOS 10.3)
  102. ( 685 ms ) isolate.generate 92.isolated.gen.json
    skia_unittests (iPad Air 2 iOS 10.3)
  103. ( 606 ms ) isolate.generate 93.isolated.gen.json
    ui_base_unittests (iPad Air 2 iOS 10.3)
  104. ( 613 ms ) isolate.generate 94.isolated.gen.json
    boringssl_crypto_tests (iPad Air 2 iOS 10.3)
  105. ( 614 ms ) isolate.generate 95.isolated.gen.json
    boringssl_ssl_tests (iPad Air 2 iOS 10.3)
  106. ( 617 ms ) isolate.generate 96.isolated.gen.json
    crypto_unittests (iPad Air 2 iOS 10.3)
  107. ( 621 ms ) isolate.generate 97.isolated.gen.json
    google_apis_unittests (iPad Air 2 iOS 10.3)
  108. ( 615 ms ) isolate.generate 98.isolated.gen.json
    ios_components_unittests (iPad Air 2 iOS 10.3)
  109. ( 625 ms ) isolate.generate 99.isolated.gen.json
    ios_net_unittests (iPad Air 2 iOS 10.3)
  110. ( 625 ms ) isolate.generate 100.isolated.gen.json
    ios_remoting_unittests (iPad Air 2 iOS 10.3)
  111. ( 614 ms ) isolate.generate 101.isolated.gen.json
    net_unittests (iPad Air 2 iOS 10.3)
  112. ( 616 ms ) isolate.generate 102.isolated.gen.json
    ocmock_support_unittests (iPad Air 2 iOS 10.3)
  113. ( 611 ms ) isolate.generate 103.isolated.gen.json
    services_unittests (iPad Air 2 iOS 10.3)
  114. ( 609 ms ) isolate.generate 104.isolated.gen.json
    sql_unittests (iPad Air 2 iOS 10.3)
  115. ( 651 ms ) isolate.generate 105.isolated.gen.json
    url_unittests (iPad Air 2 iOS 10.3)
  116. ( 639 ms ) isolate.generate 106.isolated.gen.json
    ios_chrome_integration_egtests (iPhone 6s iOS 11.4)
  117. ( 616 ms ) isolate.generate 107_0.isolated.gen.json
    ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 0
  118. ( 623 ms ) isolate.generate 107_1.isolated.gen.json
    ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 1
  119. ( 638 ms ) isolate.generate 107_2.isolated.gen.json
    ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 2
  120. ( 631 ms ) isolate.generate 107_3.isolated.gen.json
    ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 3
  121. ( 633 ms ) isolate.generate 108.isolated.gen.json
    ios_web_shell_egtests (iPhone 6s iOS 11.4)
  122. ( 1 mins 33 secs ) isolate.isolate tests
  123. ( 0 ) trigger
  124. ( 7 secs ) base_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:44.534951
  125. ( 1 mins 23 secs ) components_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:07:15.151699
  126. ( 6 secs ) gfx_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:08.291726
  127. ( 7 secs ) ios_chrome_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:05:10.415143
  128. ( 6 secs ) ios_web_inttests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:04:41.071276
  129. ( 7 secs ) ios_web_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:45.044553
  130. ( 6 secs ) ios_web_view_inttests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:32.967123
  131. ( 6 secs ) ios_web_view_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:36.310869
  132. ( 6 secs ) skia_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:46.103170
  133. ( 6 secs ) ui_base_unittests (iPhone 6s Plus iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:15.140299
  134. ( 7 secs ) base_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:55.479202
  135. ( 8 secs ) components_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:04:42.544038
  136. ( 6 secs ) gfx_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:36.053264
  137. ( 6 secs ) ios_chrome_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:05:41.014818
  138. ( 5 secs ) ios_web_inttests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:58.581503
  139. ( 6 secs ) ios_web_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:23.224903
  140. ( 6 secs ) ios_web_view_inttests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:18.889465
  141. ( 5 secs ) ios_web_view_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:47.158490
  142. ( 6 secs ) skia_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:06.821562
  143. ( 5 secs ) ui_base_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:45.028987
  144. ( 6 secs ) boringssl_crypto_tests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:49.762853
  145. ( 6 secs ) boringssl_ssl_tests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:01.342900
  146. ( 6 secs ) crypto_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:11.789854
  147. ( 5 secs ) google_apis_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:17.644636
  148. ( 6 secs ) ios_components_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:46.511440
  149. ( 5 secs ) ios_net_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:26.347953
  150. ( 6 secs ) ios_remoting_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:27.308412
  151. ( 23 secs ) net_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:09:05.010832
  152. ( 6 secs ) ocmock_support_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:02.000870
  153. ( 6 secs ) services_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:56.482752
  154. ( 6 secs ) sql_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:48.960015
  155. ( 7 secs ) url_unittests (iPhone 6s iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:03.151435
  156. ( 7 secs ) base_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:38.912383
  157. ( 8 secs ) components_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:04:51.283176
  158. ( 6 secs ) gfx_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:18.774025
  159. ( 6 secs ) ios_chrome_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:06:51.109059
  160. ( 5 secs ) ios_web_inttests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:03:52.671132
  161. ( 6 secs ) ios_web_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:59.200864
  162. ( 6 secs ) ios_web_view_inttests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:50.993613
  163. ( 5 secs ) ios_web_view_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:04.175188
  164. ( 5 secs ) skia_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:01:44.435485
  165. ( 5 secs ) ui_base_unittests (iPad Air 2 iOS 12.0)
    Run on OS: 'Mac'
    Shard duration: 0:02:18.419388
  166. ( 3 secs ) base_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:52.638701
  167. ( 5 secs ) components_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:06:14.415095
  168. ( 2 secs ) gfx_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:05.016636
  169. ( 2 secs ) ios_chrome_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:05:53.770500
  170. ( 2 secs ) ios_web_inttests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:05:00.696904
  171. ( 2 secs ) ios_web_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:03:16.979514
  172. ( 2 secs ) ios_web_view_inttests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:03:36.763543
  173. ( 2 secs ) ios_web_view_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:26.483829
  174. ( 2 secs ) skia_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:35.618209
  175. ( 2 secs ) ui_base_unittests (iPhone 6s Plus iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:29.609409
  176. ( 3 secs ) base_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:03:47.883341
  177. ( 5 secs ) components_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:05:56.355640
  178. ( 2 secs ) gfx_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:59.668980
  179. ( 3 secs ) ios_chrome_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:04:24.653541
  180. ( 2 secs ) ios_web_inttests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:04:54.227018
  181. ( 3 secs ) ios_web_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:29.018668
  182. ( 2 secs ) ios_web_view_inttests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:33.360213
  183. ( 2 secs ) ios_web_view_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:08.200731
  184. ( 2 secs ) skia_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:08.728628
  185. ( 2 secs ) ui_base_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:56.122701
  186. ( 2 secs ) boringssl_crypto_tests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:37.843727
  187. ( 2 secs ) boringssl_ssl_tests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:28.713669
  188. ( 2 secs ) crypto_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:59.967158
  189. ( 3 secs ) google_apis_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:53.726351
  190. ( 4 secs ) ios_components_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:04.253175
  191. ( 2 secs ) ios_net_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:12.520754
  192. ( 2 secs ) ios_remoting_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:06.190172
  193. ( 19 secs ) net_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:08:23.702309
  194. ( 2 secs ) ocmock_support_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:53.601600
  195. ( 2 secs ) services_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:33.535619
  196. ( 2 secs ) sql_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:56.742514
  197. ( 2 secs ) url_unittests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:52.271423
  198. ( 3 secs ) base_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:03:21.505184
  199. ( 6 secs ) components_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:05:45.408046
  200. ( 2 secs ) gfx_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:00.134521
  201. ( 2 secs ) ios_chrome_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:04:40.842577
  202. ( 2 secs ) ios_web_inttests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:03:56.942283
  203. ( 2 secs ) ios_web_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:23.500538
  204. ( 2 secs ) ios_web_view_inttests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:27.508040
  205. ( 2 secs ) ios_web_view_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:03.488391
  206. ( 2 secs ) skia_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:33.988445
  207. ( 2 secs ) ui_base_unittests (iPad Air 2 iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:01:37.712850
  208. ( 6 secs ) base_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:03:27.094626
  209. ( 4 secs ) components_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:05:45.002940
  210. ( 2 secs ) gfx_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:02:56.829292
  211. ( 2 secs ) ios_chrome_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:05:15.843907
  212. ( 2 secs ) ios_web_inttests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:03:55.429919
  213. ( 2 secs ) ios_web_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:03:06.594305
  214. ( 2 secs ) ios_web_view_inttests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:43.275072
  215. ( 2 secs ) ios_web_view_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:30.278524
  216. ( 2 secs ) skia_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:33.094043
  217. ( 2 secs ) ui_base_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:58.020136
  218. ( 2 secs ) boringssl_crypto_tests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:03:25.590860
  219. ( 2 secs ) boringssl_ssl_tests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:02:03.392118
  220. ( 2 secs ) crypto_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:55.220443
  221. ( 2 secs ) google_apis_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:02:00.189178
  222. ( 2 secs ) ios_components_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:59.662669
  223. ( 2 secs ) ios_net_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:53.820656
  224. ( 2 secs ) ios_remoting_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:38.106904
  225. ( 18 secs ) net_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:08:20.431203
  226. ( 2 secs ) ocmock_support_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:23.509975
  227. ( 2 secs ) services_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:02:39.098382
  228. ( 2 secs ) sql_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:52.203449
  229. ( 2 secs ) url_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:29.980676
  230. ( 2 secs ) ios_chrome_integration_egtests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:15:42.041754
  231. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:09:24.151178
  232. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:11:04.784250
  233. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 2
    Run on OS: 'Mac'
    Shard duration: 0:09:45.353020
  234. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 3
    Run on OS: 'Mac'
    Shard duration: 0:08:37.341097
  235. ( 2 secs ) ios_web_shell_egtests (iPhone 6s iOS 11.4)
    Run on OS: 'Mac'
    Shard duration: 0:02:28.353394
  236. ( 386 ms ) Tests statistics
     
    Stats
    Total shards: 112
    Total runtime: 4:20:55.515643
     
  237. ( 4 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm63-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539335211544565, "id": "8932883757177893664", "project": "chromium", "tags": ["builder:ios-simulator", "buildset:commit/git/4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098313819270254880", "scheduler_job_id:chromium/ios-simulator", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-simulator" setup_build
buildnumber 38250 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3" bot_update
got_revision_cp "refs/heads/master@{#599149}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update

Blamelist:

  1. Olivier Robin (olivierrobinohnoyoudont@chromium.org)
  2. Leszek Swirski (leszeksohnoyoudont@chromium.org)
  3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  5. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  6. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  7. Florent Castelli (orphisohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 09:06:51 UTC
Start Friday, 12-Oct-18 09:06:55 UTC
End Friday, 12-Oct-18 09:46:06 UTC
Pending 4 secs
Execution 39 mins 10 secs

All Changes:

  1. Stop observing prefs in MainController on Shutdown

    Changed by Olivier Robin - olivierrobinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:04:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3

    Comments

    Stop observing prefs in MainController on Shutdown
    
    Bug: 893486
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Iba70383fe0993c7c921a118197197497c1d42572
    Reviewed-on: https://chromium-review.googlesource.com/c/1270899
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599149}

    Changed files

    • ios/chrome/app/main_controller.mm
  2. [blink] Control ScriptStreamer with ScriptResource

    Changed by Leszek Swirski - leszeksohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:03:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bd9163502462762e58d8010577dbf36aeef6c13

    Comments

    [blink] Control ScriptStreamer with ScriptResource
    
    Move the ScriptStreamer control logic from ClassicPendingScript to
    ScriptResource. In the future, this will allow us to start streaming
    a ScriptResource before the ClassicPendingScript is available, e.g on
    preload.
    
    The ClassicPendingScript now only sends one "finished" callback, from
    ScriptResource. This callback is either when the streaming completes,
    or when there is no streaming and the ClassicPendingScript has told
    the ScriptResource that it doesn't intend to start streaming. In the
    long run, we want all scripts to go through the streaming interface,
    and we want ScriptResource to control when streaming starts, so the
    "no more streaming" call will disappear -- however it is necessary to
    maintain the current behaviour, and be able to control it with a
    runtime flag.
    
    Bug: chromium:865098
    Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599148}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  3. Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 08:52:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae1d881f2c19438f9bf1efad82eaaaa11980b30f

    Comments

    Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/a54daf162fac..28d200c24624
    
    
    git log a54daf162fac..28d200c24624 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 37b6d53f02..d47784f23e (598967:599082)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@28d200c24624
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I6547afd3d833e047bb877b0bece2206b5c8661ec
    Reviewed-on: https://chromium-review.googlesource.com/c/1278304
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599147}

    Changed files

    • DEPS
  4. Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:49:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 30958ae060dbfee80d985b84caa9e3c5f4d9c4cc

    Comments

    Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.
    
    TBR=sky@chromium.org
    
    Bug: 828999
    Change-Id: I46514f21581ab6d30e1c4b38719b66e43b075f42
    Reviewed-on: https://chromium-review.googlesource.com/c/1278129
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599146}

    Changed files

    • chrome/browser/browser_process_platform_part_chromeos.cc
    • chrome/browser/browser_process_platform_part_chromeos.h
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
  5. [iOS] Support Accessibility ContentSize on NTP header

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5

    Comments

    [iOS] Support Accessibility ContentSize on NTP header
    
    This CL changes the header of the "Articles for you" section of the NTP
    to have a better support for the "accessibility" categories of preferred
    content size chosen by the user.
    
    Bug: 893524
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
    Reviewed-on: https://chromium-review.googlesource.com/c/1273522
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599145}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
  6. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  7. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc