Home | Search | chromium - Builders
Login

Builder ios-simulator Build 35383 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8
Got Revision2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

Execution:

Steps and Logfiles:

Show:
  1. ( 228 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 616 ms ) remove .cipd
  3. ( 2 mins 8 secs ) bot_update
    [131GB/232GB used (56%)]
  4. ( 441 ms ) read build config
  5. ( 0 ) ensure_goma
  6. ( 0 ) ensure xcode
    Ensuring Xcode version 9c40b in /b/s/w/ir/cache/xcode_ios_9c40b.app
  7. ( 19 secs ) gclient runhooks
  8. ( 6 mins 42 secs ) compile
  9. ( 0 ) isolate
  10. ( 581 ms ) isolate.generate 0.isolate.gen.json
    base_unittests (iPhone 6s Plus iOS 11.2)
  11. ( 585 ms ) isolate.generate 1.isolate.gen.json
    components_unittests (iPhone 6s Plus iOS 11.2)
  12. ( 583 ms ) isolate.generate 2.isolate.gen.json
    gfx_unittests (iPhone 6s Plus iOS 11.2)
  13. ( 586 ms ) isolate.generate 3.isolate.gen.json
    ios_chrome_unittests (iPhone 6s Plus iOS 11.2)
  14. ( 587 ms ) isolate.generate 4.isolate.gen.json
    ios_web_inttests (iPhone 6s Plus iOS 11.2)
  15. ( 588 ms ) isolate.generate 5.isolate.gen.json
    ios_web_unittests (iPhone 6s Plus iOS 11.2)
  16. ( 580 ms ) isolate.generate 6.isolate.gen.json
    ios_web_view_inttests (iPhone 6s Plus iOS 11.2)
  17. ( 582 ms ) isolate.generate 7.isolate.gen.json
    ios_web_view_unittests (iPhone 6s Plus iOS 11.2)
  18. ( 583 ms ) isolate.generate 8.isolate.gen.json
    skia_unittests (iPhone 6s Plus iOS 11.2)
  19. ( 584 ms ) isolate.generate 9.isolate.gen.json
    ui_base_unittests (iPhone 6s Plus iOS 11.2)
  20. ( 592 ms ) isolate.generate 10.isolate.gen.json
    base_unittests (iPhone 6s iOS 11.2)
  21. ( 587 ms ) isolate.generate 11.isolate.gen.json
    components_unittests (iPhone 6s iOS 11.2)
  22. ( 589 ms ) isolate.generate 12.isolate.gen.json
    gfx_unittests (iPhone 6s iOS 11.2)
  23. ( 594 ms ) isolate.generate 13.isolate.gen.json
    ios_chrome_unittests (iPhone 6s iOS 11.2)
  24. ( 587 ms ) isolate.generate 14.isolate.gen.json
    ios_web_inttests (iPhone 6s iOS 11.2)
  25. ( 583 ms ) isolate.generate 15.isolate.gen.json
    ios_web_unittests (iPhone 6s iOS 11.2)
  26. ( 583 ms ) isolate.generate 16.isolate.gen.json
    ios_web_view_inttests (iPhone 6s iOS 11.2)
  27. ( 584 ms ) isolate.generate 17.isolate.gen.json
    ios_web_view_unittests (iPhone 6s iOS 11.2)
  28. ( 576 ms ) isolate.generate 18.isolate.gen.json
    skia_unittests (iPhone 6s iOS 11.2)
  29. ( 588 ms ) isolate.generate 19.isolate.gen.json
    ui_base_unittests (iPhone 6s iOS 11.2)
  30. ( 585 ms ) isolate.generate 20.isolate.gen.json
    boringssl_crypto_tests (iPhone 6s iOS 11.2)
  31. ( 581 ms ) isolate.generate 21.isolate.gen.json
    boringssl_ssl_tests (iPhone 6s iOS 11.2)
  32. ( 612 ms ) isolate.generate 22.isolate.gen.json
    crypto_unittests (iPhone 6s iOS 11.2)
  33. ( 577 ms ) isolate.generate 23.isolate.gen.json
    google_apis_unittests (iPhone 6s iOS 11.2)
  34. ( 572 ms ) isolate.generate 24.isolate.gen.json
    ios_components_unittests (iPhone 6s iOS 11.2)
  35. ( 587 ms ) isolate.generate 25.isolate.gen.json
    ios_net_unittests (iPhone 6s iOS 11.2)
  36. ( 594 ms ) isolate.generate 26.isolate.gen.json
    ios_remoting_unittests (iPhone 6s iOS 11.2)
  37. ( 584 ms ) isolate.generate 27.isolate.gen.json
    net_unittests (iPhone 6s iOS 11.2)
  38. ( 575 ms ) isolate.generate 28.isolate.gen.json
    ocmock_support_unittests (iPhone 6s iOS 11.2)
  39. ( 583 ms ) isolate.generate 29.isolate.gen.json
    services_unittests (iPhone 6s iOS 11.2)
  40. ( 589 ms ) isolate.generate 30.isolate.gen.json
    sql_unittests (iPhone 6s iOS 11.2)
  41. ( 597 ms ) isolate.generate 31.isolate.gen.json
    url_unittests (iPhone 6s iOS 11.2)
  42. ( 589 ms ) isolate.generate 32.isolate.gen.json
    base_unittests (iPad Air 2 iOS 11.2)
  43. ( 581 ms ) isolate.generate 33.isolate.gen.json
    components_unittests (iPad Air 2 iOS 11.2)
  44. ( 586 ms ) isolate.generate 34.isolate.gen.json
    gfx_unittests (iPad Air 2 iOS 11.2)
  45. ( 619 ms ) isolate.generate 35.isolate.gen.json
    ios_chrome_unittests (iPad Air 2 iOS 11.2)
  46. ( 602 ms ) isolate.generate 36.isolate.gen.json
    ios_web_inttests (iPad Air 2 iOS 11.2)
  47. ( 588 ms ) isolate.generate 37.isolate.gen.json
    ios_web_unittests (iPad Air 2 iOS 11.2)
  48. ( 612 ms ) isolate.generate 38.isolate.gen.json
    ios_web_view_inttests (iPad Air 2 iOS 11.2)
  49. ( 632 ms ) isolate.generate 39.isolate.gen.json
    ios_web_view_unittests (iPad Air 2 iOS 11.2)
  50. ( 615 ms ) isolate.generate 40.isolate.gen.json
    skia_unittests (iPad Air 2 iOS 11.2)
  51. ( 592 ms ) isolate.generate 41.isolate.gen.json
    ui_base_unittests (iPad Air 2 iOS 11.2)
  52. ( 587 ms ) isolate.generate 42.isolate.gen.json
    base_unittests (iPad Air 2 iOS 10.3)
  53. ( 608 ms ) isolate.generate 43.isolate.gen.json
    components_unittests (iPad Air 2 iOS 10.3)
  54. ( 597 ms ) isolate.generate 44.isolate.gen.json
    gfx_unittests (iPad Air 2 iOS 10.3)
  55. ( 588 ms ) isolate.generate 45.isolate.gen.json
    ios_chrome_unittests (iPad Air 2 iOS 10.3)
  56. ( 582 ms ) isolate.generate 46.isolate.gen.json
    ios_web_inttests (iPad Air 2 iOS 10.3)
  57. ( 591 ms ) isolate.generate 47.isolate.gen.json
    ios_web_unittests (iPad Air 2 iOS 10.3)
  58. ( 590 ms ) isolate.generate 48.isolate.gen.json
    ios_web_view_inttests (iPad Air 2 iOS 10.3)
  59. ( 583 ms ) isolate.generate 49.isolate.gen.json
    ios_web_view_unittests (iPad Air 2 iOS 10.3)
  60. ( 589 ms ) isolate.generate 50.isolate.gen.json
    skia_unittests (iPad Air 2 iOS 10.3)
  61. ( 583 ms ) isolate.generate 51.isolate.gen.json
    ui_base_unittests (iPad Air 2 iOS 10.3)
  62. ( 589 ms ) isolate.generate 52.isolate.gen.json
    boringssl_crypto_tests (iPad Air 2 iOS 10.3)
  63. ( 591 ms ) isolate.generate 53.isolate.gen.json
    boringssl_ssl_tests (iPad Air 2 iOS 10.3)
  64. ( 580 ms ) isolate.generate 54.isolate.gen.json
    crypto_unittests (iPad Air 2 iOS 10.3)
  65. ( 593 ms ) isolate.generate 55.isolate.gen.json
    google_apis_unittests (iPad Air 2 iOS 10.3)
  66. ( 627 ms ) isolate.generate 56.isolate.gen.json
    ios_components_unittests (iPad Air 2 iOS 10.3)
  67. ( 603 ms ) isolate.generate 57.isolate.gen.json
    ios_net_unittests (iPad Air 2 iOS 10.3)
  68. ( 608 ms ) isolate.generate 58.isolate.gen.json
    ios_remoting_unittests (iPad Air 2 iOS 10.3)
  69. ( 585 ms ) isolate.generate 59.isolate.gen.json
    net_unittests (iPad Air 2 iOS 10.3)
  70. ( 591 ms ) isolate.generate 60.isolate.gen.json
    ocmock_support_unittests (iPad Air 2 iOS 10.3)
  71. ( 617 ms ) isolate.generate 61.isolate.gen.json
    services_unittests (iPad Air 2 iOS 10.3)
  72. ( 593 ms ) isolate.generate 62.isolate.gen.json
    sql_unittests (iPad Air 2 iOS 10.3)
  73. ( 627 ms ) isolate.generate 63.isolate.gen.json
    url_unittests (iPad Air 2 iOS 10.3)
  74. ( 632 ms ) isolate.generate 64.isolate.gen.json
    ios_chrome_integration_egtests (iPhone 6s iOS 11.2)
  75. ( 658 ms ) isolate.generate 65_0.isolate.gen.json
    ios_chrome_ui_egtests (iPhone 6s iOS 11.2) shard 0
  76. ( 597 ms ) isolate.generate 65_1.isolate.gen.json
    ios_chrome_ui_egtests (iPhone 6s iOS 11.2) shard 1
  77. ( 604 ms ) isolate.generate 65_2.isolate.gen.json
    ios_chrome_ui_egtests (iPhone 6s iOS 11.2) shard 2
  78. ( 663 ms ) isolate.generate 65_3.isolate.gen.json
    ios_chrome_ui_egtests (iPhone 6s iOS 11.2) shard 3
  79. ( 618 ms ) isolate.generate 66.isolate.gen.json
    ios_web_shell_egtests (iPhone 6s iOS 11.2)
  80. ( 1 mins 11 secs ) isolate.archive
  81. ( 0 ) trigger
  82. ( 10 secs ) base_unittests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:03.805480
  83. ( 36 secs ) components_unittests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:40.266690
  84. ( 2 secs ) gfx_unittests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:13.807040
  85. ( 2 secs ) ios_chrome_unittests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:19.083400
  86. ( 2 secs ) ios_web_inttests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:29.026550
  87. ( 2 secs ) ios_web_unittests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:02:53.193460
  88. ( 2 secs ) ios_web_view_inttests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:31.656010
  89. ( 2 secs ) ios_web_view_unittests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:29.061740
  90. ( 2 secs ) skia_unittests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:28.399790
  91. ( 2 secs ) ui_base_unittests (iPhone 6s Plus iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:38.674970
  92. ( 2 secs ) base_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:06.184820
  93. ( 39 secs ) components_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:04:44.272070
  94. ( 2 secs ) gfx_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:33.606830
  95. ( 2 secs ) ios_chrome_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:33.198650
  96. ( 2 secs ) ios_web_inttests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:02:51.394300
  97. ( 2 secs ) ios_web_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:07.189040
  98. ( 2 secs ) ios_web_view_inttests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:50.266490
  99. ( 2 secs ) ios_web_view_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:07.161430
  100. ( 2 secs ) skia_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:15.327760
  101. ( 2 secs ) ui_base_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:27.154000
  102. ( 2 secs ) boringssl_crypto_tests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:02:19.496980
  103. ( 2 secs ) boringssl_ssl_tests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:08.690540
  104. ( 2 secs ) crypto_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 57s
  105. ( 2 secs ) google_apis_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:20.458120
  106. ( 2 secs ) ios_components_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:02.585540
  107. ( 2 secs ) ios_net_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:03.650900
  108. ( 2 secs ) ios_remoting_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:19.326440
  109. ( 3 mins 13 secs ) net_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:08:15.626400
  110. ( 3 secs ) ocmock_support_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:04.328070
  111. ( 2 secs ) services_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:41.598590
  112. ( 2 secs ) sql_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:05.759760
  113. ( 2 secs ) url_unittests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:08.432700
  114. ( 3 secs ) base_unittests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:12.643120
  115. ( 4 secs ) components_unittests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:42.817320
  116. ( 2 secs ) gfx_unittests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 58s
  117. ( 2 secs ) ios_chrome_unittests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:51.472440
  118. ( 2 secs ) ios_web_inttests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:23.819360
  119. ( 2 secs ) ios_web_unittests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:02:48.930590
  120. ( 2 secs ) ios_web_view_inttests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:28.431760
  121. ( 2 secs ) ios_web_view_unittests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:11.104360
  122. ( 2 secs ) skia_unittests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 57s
  123. ( 2 secs ) ui_base_unittests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:19.877910
  124. ( 3 secs ) base_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:02:58.984910
  125. ( 4 secs ) components_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:04:52.324230
  126. ( 2 secs ) gfx_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:13.064650
  127. ( 2 secs ) ios_chrome_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:04:27.876360
  128. ( 2 secs ) ios_web_inttests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:02:49.356920
  129. ( 2 secs ) ios_web_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:04:00.265110
  130. ( 2 secs ) ios_web_view_inttests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:40.180600
  131. ( 2 secs ) ios_web_view_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:15.567700
  132. ( 2 secs ) skia_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:16.988620
  133. ( 2 secs ) ui_base_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 57s
  134. ( 2 secs ) boringssl_crypto_tests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:02:34.538800
  135. ( 2 secs ) boringssl_ssl_tests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:04:21.616460
  136. ( 2 secs ) crypto_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:11.871470
  137. ( 2 secs ) google_apis_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 56s
  138. ( 2 secs ) ios_components_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 59s
  139. ( 2 secs ) ios_net_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:01.098810
  140. ( 2 secs ) ios_remoting_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:27.984300
  141. ( 19 secs ) net_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:08:14.177870
  142. ( 2 secs ) ocmock_support_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:13.364260
  143. ( 2 secs ) services_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:08.858890
  144. ( 2 secs ) sql_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:04:13.569450
  145. ( 2 secs ) url_unittests (iPad Air 2 iOS 10.3)
    Run on OS: 'Mac'
    Shard duration: 0:01:04.221920
  146. ( 2 secs ) ios_chrome_integration_egtests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:10:41.565040
  147. ( 4 mins 21 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.2) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:15:21.184170
  148. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.2) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:08:51.754690
  149. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.2) shard 2
    Run on OS: 'Mac'
    Shard duration: 0:10:37.187650
  150. ( 2 secs ) ios_chrome_ui_egtests (iPhone 6s iOS 11.2) shard 3
    Run on OS: 'Mac'
    Shard duration: 0:08:43.332440
  151. ( 2 secs ) ios_web_shell_egtests (iPhone 6s iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:01:46.663890
  152. ( 388 ms ) Tests statistics
     
    Stats
    Total shards: 70
    Total runtime: 2:40:58.349697
     
  153. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm63-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531412498076890, "id": "8941191324375674272", "project": "chromium", "tags": ["builder:ios-simulator", "buildset:commit/git/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106621387011089456", "scheduler_job_id:chromium/ios-simulator", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-simulator" setup_build
buildnumber 35383 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8" bot_update
got_revision_cp "refs/heads/master@{#574588}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update

Blamelist:

  1. Jay Civelli (jcivelliohnoyoudont@google.com)
  2. Stefan Zager (szagerohnoyoudont@chromium.org)
  3. Bruce Dawson (brucedawsonohnoyoudont@chromium.org)
  4. Peter Kasting (pkastingohnoyoudont@chromium.org)
  5. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  6. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  7. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  8. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  9. Peter Wen (wnwenohnoyoudont@chromium.org)
  10. Xida Chen (xidachenohnoyoudont@chromium.org)
  11. Daniel Bratell (bratellohnoyoudont@opera.com)
  12. Danyao Wang (danyaoohnoyoudont@chromium.org)
  13. Stephen Lanham (slanohnoyoudont@google.com)
  14. Sujie Zhu (sujiezhuohnoyoudont@google.com)

Timing:

Create Thursday, 12-Jul-18 16:21:38 UTC
Start Thursday, 12-Jul-18 16:21:41 UTC
End Thursday, 12-Jul-18 16:53:37 UTC
Pending 3 secs
Execution 31 mins 55 secs

All Changes:

  1. Simplify FakeGaiaCookieManagerService

    Changed by Jay Civelli - jcivelliohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

    Comments

    Simplify FakeGaiaCookieManagerService
    
    Simplifying the FakeGaiaCookieManagerService API by not requiring to
    call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
    instead a member of the FakeGaiaCookieManagerService.
    
    This API simplification is in preparation for switching GaiaAuthFetcher
    to use the SimpleURLLoader (network service).
    
    Bug: 840396
    Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
    Reviewed-on: https://chromium-review.googlesource.com/1114226
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574588}

    Changed files

    • chrome/browser/extensions/api/identity/identity_apitest.cc
    • chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
    • chrome/browser/signin/signin_ui_util_unittest.cc
    • chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.h
    • components/search_provider_logos/logo_service_impl_unittest.cc
    • components/signin/core/browser/account_investigator_unittest.cc
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.h
    • components/signin/core/browser/signin_manager_unittest.cc
  2. Get rid of GraphicsLayer::scrollable_area_

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 442f13b7e97747ab09612a101159b1eb26072382

    Comments

    Get rid of GraphicsLayer::scrollable_area_
    
    The only place where it was actually used was in
    GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
    call to the GraphicsLayerClient.
    
    BUG=823365
    R=pdr@chromium.org,skobes@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
    Reviewed-on: https://chromium-review.googlesource.com/1132536
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574587}

    Changed files

    • third_party/blink/renderer/core/frame/visual_viewport.cc
    • third_party/blink/renderer/core/frame/visual_viewport.h
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.h
    • third_party/blink/renderer/platform/graphics/graphics_layer_client.h
  3. Add "latency" to list of ETW-traceable events

    Changed by Bruce Dawson - brucedawsonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5d9a9d75a9a8f7f6fb9d749c9b797eb2550d34e

    Comments

    Add "latency" to list of ETW-traceable events
    
    The "latency" category looks like a perfect event category for ETW
    tracing. In particular, TabSwitching::Latency indicates when Chrome
    thinks that tab switching has started and stopped which allows it to be
    profiled in detail. This has revealed where CPU time is going, and how
    long the delay is from when the keyboard event is generated to when
    Chrome starts officially processing it. This was helpful in
    investigating tab switching latency in bug 858944.
    
    This will require an update to UIforETW to fully enable, which I have
    done locally for testing purposes.
    
    Bug: 858944
    Change-Id: I4797b804ea6d35458aa3b4e876a78172a29d5131
    Reviewed-on: https://chromium-review.googlesource.com/1134516
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574586}

    Changed files

    • base/trace_event/trace_event_etw_export_win.cc
  4. Remove NewTabButton::GetVisibleBounds().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f448a241361b03dd2b6fd21ab052774e1074fdf1

    Comments

    Remove NewTabButton::GetVisibleBounds().
    
    This was a computed by constructing the border path and computing the bounding
    box.  However, it was only used for the ink drop, and ink drops are only used in
    newer material mode, where the border path is a square.
    
    Instead, we can use GetContentsBounds(), as long as those are actually
    positioned correctly.  The new tab button has empty space at the top, which is
    included (by the tabstrip) in its size and accounted for when doing painting and
    hittesting.  By adding an empty top border of this thickness, a lot of this code
    can be simplified.  (Further simplifications are coming in a subsequent CL.)
    
    Bug: none
    Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe
    Reviewed-on: https://chromium-review.googlesource.com/1134399
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574585}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
    • chrome/browser/ui/views/tabs/tab_strip.cc
  5. [AF] Use views::Separator in the Autofill dropdown

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff6fb086724fb3cd20409d3e72065bbd4a84abd

    Comments

    [AF] Use views::Separator in the Autofill dropdown
    
    This is a follow-up of crrev.com/c/1131680 and replace a custom view
    to simulate a separator with a views::Separator view.
    
    Change-Id: I0dc1db9c31039ce0959fa4aa4d37e4e99745a2d1
    Reviewed-on: https://chromium-review.googlesource.com/1133328
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574584}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  6. [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b35e9edf0aed36764ee35db8ed9e66466bb18249

    Comments

    [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests
    
    Remove a redundant URLPatternSet comparison method from
    ScriptingPermissionsModifier unittests, instead leveraging the
    string comparison and gmock utilities. These are slightly less code
    and offer better failure messages.
    
    Bug: None
    
    Change-Id: Ic8b99f0c9294658d6bdd16738f179a2e352eb408
    Reviewed-on: https://chromium-review.googlesource.com/1134496
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574583}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
  7. [ios] Set favicon fallback style for UI Refresh for ReadingList

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:05:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eeff01fbfa506b55fc9f1c0126c618a788015a4

    Comments

    [ios] Set favicon fallback style for UI Refresh for ReadingList
    
    - Sets the fallback monogram and background colors to a constant color.
    
    Collections flag off screenshot: https://drive.google.com/file/d/10fYA9oHwx_o3cGWXBSR5P4qXKIPDTcfm/view?usp=sharing
    Collections flag on screenshot: https://drive.google.com/file/d/1WtAYb-fPE6QdR4rIpcWxuZtLjGr7iPNQ/view?usp=sharing
    
    Bug: 851390
    
    Change-Id: I7d67a4129263b2deed52eb7603b3f84aa8b8a201
    Reviewed-on: https://chromium-review.googlesource.com/1125271
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574582}

    Changed files

    • ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
  8. Enable StaleWhileRevalidate in experimental features.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fc2f58c6417a00888317b79f40fd904b1f6628b

    Comments

    Enable StaleWhileRevalidate in experimental features.
    
    To gather some stability enable it for experimental features before
    we do the origin trial.
    
    BUG=348877
    
    Change-Id: I7598f35ac87b719305c6efa98c37de2eec8031a4
    Reviewed-on: https://chromium-review.googlesource.com/1134883
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574581}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  9. Android: Default to full instead of fast

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c98d04f201c356e8c4e811f3a43afa5c264750c

    Comments

    Android: Default to full instead of fast
    
    Switch from --full being optional to --fast being optional. Quite a few
    users of generate_gradle.py have found it unintuitive to have red
    underlines by default.
    
    Bug: 620034
    Change-Id: I24a19e16ed21baa19bde97bb2f3077430a73d148
    Reviewed-on: https://chromium-review.googlesource.com/1134882
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574580}

    Changed files

    • build/android/gradle/generate_gradle.py
  10. [Code health] Disable TouchActionBrowserTests on Debug and *San bots

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:02:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da109c8fd1b66a54c514b3012c29ebb232c113e9

    Comments

    [Code health] Disable TouchActionBrowserTests on Debug and *San bots
    
    These tests are flaky on Debug builds and *San bots. These tests sends
    synthetic gesture event and measure scroll offset. It should be fine
    without coverages on Debug and *San builds.
    
    TBR=sahel@chromium.org, tdresser@chromium.org
    
    Bug: 855979, 833015
    Change-Id: I009d3557454e0aab960d35fc5256ed487c2e47fe
    Reviewed-on: https://chromium-review.googlesource.com/1135195
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574579}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  11. [jumbo] Deduplicate a time constant in autofill code

    Changed by Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at Thursday, 12-Jul-18 16:01:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a742e15951f4e95d609b6628fc486a88b4fe0df

    Comments

    [jumbo] Deduplicate a time constant in autofill code
    
    Two different bubbles needed the same time constant and when
    they got copies of the constant that broke certain jumbo
    builds. This merges the constants to a single constant.
    
    It also changes type to base::TimeDelta which is the actual
    type needed and since the addition of constexpr can be used
    in global constants.
    
    Bug: 852904,862397
    Change-Id: I52a63d3301efb1c7aec55541c15427c5d96ba524
    Reviewed-on: https://chromium-review.googlesource.com/1134998
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574578}

    Changed files

    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/popup_constants.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
  12. Revert "[Nav Experiment] Add a wait after restore session."

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:01:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e33b9da8d371a25857c422d277115441c629ce5

    Comments

    Revert "[Nav Experiment] Add a wait after restore session."
    
    This reverts commit bcae87b0c7618e2fc61f78a073cf5589fe9679bd.
    
    Reason for revert: This didn't actually fix the problem and
    I didn't catch it due to a mistake in testing. The real
    problem is that the restore_session request started in 
    WKBasedNavigationManager::Restore() was not run, because
    |_containerView| is not yet initiated in the new CWVWebView.
    
    Original change's description:
    > [Nav Experiment] Add a wait after restore session.
    > 
    > This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    > enabled. A better approach would be to turn this test into a
    > programmatic test so both navigation managers implementations are
    > tested, but web::features symbols are not exposed in ios/web_view.
    > 
    > Bug: 862714
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
    > Reviewed-on: https://chromium-review.googlesource.com/1134046
    > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > Commit-Queue: Danyao Wang <danyao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574367}
    
    TBR=eugenebut@chromium.org,danyao@chromium.org
    
    Change-Id: Ia9d2d127e18264fbf69786c58b71706e0b34ead5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1135346
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574577}

    Changed files

    • ios/web_view/test/web_view_restorable_state_inttest.mm
  13. [Chromecast] Use MobileScoller on Cast Android builds.

    Changed by Stephen Lanham - slanohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:00:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bef77d4afc3b73eb7fc96dff1908164994b4a82

    Comments

    [Chromecast] Use MobileScoller on Cast Android builds.
    
    This class was renamed from Scroller here: crrev.com/c/1087641. Update the
    conditionals so that Scroller is only used on non-Android Cast builds,
    and MobileScroller is used on Android Cast builds.
    
    Bug: internal b/111287588
    Test: Compiles
    
    Change-Id: I19dc01e1339016e3db2ab3b7d81a95efc5c6a0f3
    Reviewed-on: https://chromium-review.googlesource.com/1133761
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Stephen Lanham <slan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574576}

    Changed files

    • ui/events/gestures/blink/web_gesture_curve_impl.cc
  14. Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type

    Changed by Sujie Zhu - sujiezhuohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 15:56:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdb64db76a187df14e07aa31daccedb1813ffb8e

    Comments

    Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type
    
    For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    
    Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    
    In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    
    The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    
    Bug: 852904
    Change-Id: I01191cb8a9d0a3bf954874e6c8beb62d3b02c1ea
    Reviewed-on: https://chromium-review.googlesource.com/1134388
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    Cr-Commit-Position: refs/heads/master@{#574575}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc