Home | Search | chromium - Builders
Login

Builder ios-simulator-xcode-clang Build 58561 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision77b7b35987d9420138ebc3fcb7d24d786bf5549c
Got Revision77b7b35987d9420138ebc3fcb7d24d786bf5549c

Execution:

Steps and Logfiles:

Show:
  1. ( 259 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 11 mins 43 secs ) bot_update
    [166GB/232GB used (71%)]
  3. ( 586 ms ) read build config
  4. ( 1 mins 45 secs ) gclient runhooks
  5. ( 647 ms ) lookup GN args
     
    ios_enable_code_signing = false
    is_component_build = false
    is_debug = true
    symbol_level = 0
    target_cpu = "x64"
    target_os = "ios"
    use_goma = true
    use_xcode_clang = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  6. ( 19 mins 25 secs ) compile
  7. ( 0 ) trigger

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm123-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541781449789585, "id": "8930318690463896160", "project": "chromium", "tags": ["builder:ios-simulator-xcode-clang", "buildset:commit/git/77b7b35987d9420138ebc3fcb7d24d786bf5549c", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/77b7b35987d9420138ebc3fcb7d24d786bf5549c", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095748752795538064", "scheduler_job_id:chromium/ios-simulator-xcode-clang", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-simulator-xcode-clang" setup_build
buildnumber 58561 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "77b7b35987d9420138ebc3fcb7d24d786bf5549c" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "77b7b35987d9420138ebc3fcb7d24d786bf5549c" bot_update
got_revision_cp "refs/heads/master@{#606866}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update

Blamelist:

  1. David 'Digit' Turner (digitohnoyoudont@google.com)
  2. James Hawkins (jhawkinsohnoyoudont@chromium.org)
  3. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
  4. Vasilii Sukhanov (vasiliiohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. Fernando Serboncini (fserbohnoyoudont@chromium.org)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. Nico Weber (thakisohnoyoudont@chromium.org)
  9. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  10. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  11. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  12. Eugene But (eugenebutohnoyoudont@google.com)
  13. Eugene But (eugenebutohnoyoudont@google.com)
  14. Pavel Shmakov (pshmakovohnoyoudont@google.com)
  15. Tim Volodine (timvolodineohnoyoudont@chromium.org)
  16. Rayan Kanso (rayankansohnoyoudont@google.com)
  17. David Jean (djeanohnoyoudont@google.com)
  18. Aaron Krajeski (aaronhkohnoyoudont@google.com)
  19. Marc Treib (treibohnoyoudont@chromium.org)
  20. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  21. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  22. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  23. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  24. Lukasz Suder (lsuderohnoyoudont@google.com)
  25. Greg Thompson (grtohnoyoudont@chromium.org)
  26. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  27. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  28. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  29. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  30. Ioana Pandele (ioanapohnoyoudont@chromium.org)
  31. Sam Maier (smaierohnoyoudont@chromium.org)
  32. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  33. Rohit Rao (rohitraoohnoyoudont@chromium.org)
  34. Sigurdur Asgeirsson (siggiohnoyoudont@chromium.org)
  35. Mike Reed (reedohnoyoudont@google.com)
  36. Marc Treib (treibohnoyoudont@chromium.org)
  37. Marc Treib (treibohnoyoudont@chromium.org)
  38. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  39. Leonard Grey (lgreyohnoyoudont@chromium.org)
  40. Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
  41. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  42. Mark Cogan (marqohnoyoudont@google.com)
  43. gogerald (gogeraldohnoyoudont@google.com)
  44. Clemens Arbesser (arbesserohnoyoudont@google.com)
  45. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  46. Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
  47. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  48. Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
  49. Patrik Höglund (phoglundohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 16:37:29 UTC
Start Friday, 09-Nov-18 16:39:52 UTC
End Friday, 09-Nov-18 17:44:07 UTC
Pending 2 mins 22 secs
Execution 1 hrs 4 mins

All Changes:

  1. Android: Fix resource extraction from splits for Hebrew and others.

    Changed by David 'Digit' Turner - digitohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:32:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77b7b35987d9420138ebc3fcb7d24d786bf5549c

    Comments

    Android: Fix resource extraction from splits for Hebrew and others.
    
    This CL fixes a bug in the logic used to locate locale .pak files
    inside bundle splits. The reason for the bug is that bundletool
    wants to use deprecated language names (i.e. 'iw' instead of 'he')
    to store asset files.
    
    As an example, for Hebrew, Chrome was looking at:
    
      assets/locales#lang_he/he.pak
    
    While the file was really stored under:
    
      assets/locales#lang_iw/he.pak
    
    The CL fixes the issue for Hebrew, Yiddish and Indonesian and
    Filipino.
    
    BUG=902915
    R=benmason@chromium.org, tiborg@chromium.org, yfriedman@chromium.org, twellington@chromium.org
    
    Change-Id: I420158c30ba33c6203495af9453877722271e104
    Reviewed-on: https://chromium-review.googlesource.com/c/1327203
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606866}

    Changed files

    • ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java
    • ui/android/java/src/org/chromium/ui/resources/ResourceExtractor.java
    • ui/android/junit/src/org/chromium/ui/base/LocalizationUtilsTest.java
  2. Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7bfd5bb2031d217d0e0f87240b4ce16705abb3d

    Comments

    Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: Iac6aacb1b40608d261d6c13b12fd37bfd6b0df8f
    Reviewed-on: https://chromium-review.googlesource.com/c/1325393
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606865}

    Changed files

    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.h
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h
  3. Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 16:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f513b7c0c1803fe4688b8eee2dab06f48dabf081

    Comments

    Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy
    
    ... and remove the later.
    
    This is a follow up of mmenke's request in [1].
    
    [1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70
    
    TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc)
    TBR=jam@chromium.org (content/browser/loader/resource_loader.cc)
    
    BUG=773295
    
    Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1320769
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606864}

    Changed files

    • components/policy/core/common/cloud/device_management_service.cc
    • components/safe_browsing/browser/threat_details_cache.cc
    • content/browser/loader/resource_loader.cc
    • services/network/public/cpp/resource_response.cc
    • services/network/public/cpp/resource_response_info.cc
    • services/network/public/cpp/resource_response_info.h
    • services/network/url_loader.cc
  4. Ignore blur events caused by the password generation.

    Changed by Vasilii Sukhanov - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:18:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

    Comments

    Ignore blur events caused by the password generation.
    
    When PasswordGenerationAgent copies the password value from the password field
    to "Confirm Password" filed, a blur event is generated. It hides the currently
    open generation prompt. Those events are just side-effects of how the class
    works and should be ignored.
    
    Bug: 899756,850079
    Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444
    Reviewed-on: https://chromium-review.googlesource.com/c/1327205
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606863}

    Changed files

    • chrome/renderer/autofill/fake_password_manager_client.cc
    • chrome/renderer/autofill/fake_password_manager_client.h
    • chrome/renderer/autofill/password_generation_agent_browsertest.cc
    • components/autofill/content/renderer/autofill_agent.cc
    • components/autofill/content/renderer/password_generation_agent.cc
    • components/autofill/content/renderer/password_generation_agent.h
  5. Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:12:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5657f328e5325aa821d8714a3f7686c078603a43

    Comments

    Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a
    
    
    git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cf90797ef05a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606862}

    Changed files

    • DEPS
  6. Save transform context for filters

    Changed by Fernando Serboncini - fserbohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d07d7323809b59b52b1237dacb94330cc9dab4bd

    Comments

    Save transform context for filters
    
    Otherwise we get weird behavior on filters while transforming.
    
    TBR=
    
    Bug: 901759
    Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251
    Reviewed-on: https://chromium-review.googlesource.com/c/1329342
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606861}

    Changed files

    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
  7. Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:10:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99e210e29e5e55c29142398eb11e164801f7d0c8

    Comments

    Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8
    
    
    git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs
    
    
    Created with:
      gclient setdep -r src/third_party/skia@c244c2fbbbf8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155
    Reviewed-on: https://chromium-review.googlesource.com/c/1329045
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606860}

    Changed files

    • DEPS
  8. Remove v8_context_snapshot.bin determinism hack.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:08:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2acccc10cf8afd5a3709f5fd562d700d6b96979

    Comments

    Remove v8_context_snapshot.bin determinism hack.
    
    Reverts parts of
    https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should
    no longer be needed after https://chromium-review.googlesource.com/c/1304441
    
    Bug: 870584
    Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1328823
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606859}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
  9. Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:06:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7669a6683a5f927ae9a3fa2c2d7802e2a8d5c165

    Comments

    Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file
    
    In case the files are somehow not found or unreadable on the bots, the tests should fail.
    R=dmazzoni@chromium.org
    
    Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171
    Reviewed-on: https://chromium-review.googlesource.com/c/1324232
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606858}

    Changed files

    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.cc
  10. Roll src-internal 6166365225d6..827de2c806ba (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56904b670753b8f8a1f5131ef61b9e1027f34c6e

    Comments

    Roll src-internal 6166365225d6..827de2c806ba (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba
    
    
    Created with:
      gclient setdep -r src-internal@827de2c806ba
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1329361
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606857}

    Changed files

    • DEPS
  11. Wire the resizeMode property to the constraints parsing mechanism.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:02:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c6c086d575a9e131e70eaf6512a0da14150442

    Comments

    Wire the resizeMode property to the constraints parsing mechanism.
    
    This CL adds resizeMode support for MediaStreamTrack.getConstraints()
    and marks resizeMode as a supported constrainable property.
    
    Support for getUserMedia(), applyConstraints() and getCapabilities()
    will be added in follow-up CLs in this series.
    
    Intent to Ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
    
    Bug: 854980
    Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
    Reviewed-on: https://chromium-review.googlesource.com/c/1309749
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606856}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html
    • third_party/blink/public/platform/web_media_constraints.h
    • third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
    • third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
    • third_party/blink/renderer/platform/exported/web_media_constraints.cc
  12. Call WebStateObserver::PageLoaded after loading placeholder URL.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:00:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 386114b5bacc02e12b584786671d67b6080f02e7

    Comments

    Call WebStateObserver::PageLoaded after loading placeholder URL.
    
    Before this CL PageLoaded was called right from
    didFailProvisionalNavigation:, where URL may still represent the
    previous page.
    
    Bug: 903497
    Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327608
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606855}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  13. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  14. Refactor Trusted Web Activity UI code to MVC

    Changed by Pavel Shmakov - pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java
  15. [AW NS] Add CTS test filter for Android WebView

    Changed by Tim Volodine - timvolodineohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:47:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e57afbcbc0d8a4fff7a9d8df6164bf0f6dcedd75

    Comments

    [AW NS] Add CTS test filter for Android WebView
    
    The idea of this CTS filter is similar to the filter we have for
    instrumentation tests, i.e.
    mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains
    failing tests and their corresponding issues / root causes.
    
    The current filter contains results from a local run for a subset of
    tests (the actual CTS is not running yet). The CTS filter also
    augments the instrumentation test filter for test coverage that is
    missing from instrumentation tests.
    
    BUG=903822,902330,841556
    
    Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/1319677
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606852}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_webview_CTS_test.filter
  16. [Background Fetch] Report uploadTotal in the registration

    Changed by Rayan Kanso - rayankansohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a2e1006e2f0960cea11264c2cb65c73d0334b90

    Comments

    [Background Fetch] Report uploadTotal in the registration
    
    Also sets up some useful testing helpers for future upload features.
    
    Bug: 774054
    Change-Id: I9aea33086b228357d9a160bd35b0a37ceaa30592
    Reviewed-on: https://chromium-review.googlesource.com/c/1329149
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606851}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.h
    • content/browser/background_fetch/storage/create_metadata_task.cc
  17. [ios] add manual fallback credit card and address coordinator

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:34:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b02a7719f78de1e78ded7807aa4d139f8c2b77d6

    Comments

    [ios] add manual fallback credit card and address coordinator
    
    And a common base class.
    
    Bug: 845472
    Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1318914
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606850}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
  18. Add RAF tests to blink_perf.canvas benchmark.

    Changed by Aaron Krajeski - aaronhkohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:28:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7149ab705c9a7c1c9c57c960c05e2de216680c7d

    Comments

    Add RAF tests to blink_perf.canvas benchmark.
    
    Current canvas benchmarks only measure CPU time.
    Using requestAnimationFrame (raf) in javascript we can
    measure CPU + raster + GPU time. This CL adds a mode to
    blink_perf.py that runs canvas all canvas test in a way
    that takes raster and GPU time into account.
    
    Roughly doubles the duration of `blink_perf.canvas`
    benchmark from ~2 minutes to ~4 minutes on a linux desktop.
    
    Bug: 894043
    Change-Id: I2fdd13af75615802266fa39a01db3e883f2c95bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1300038
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606849}

    Changed files

    • docs/speed/benchmark/harnesses/blink_perf.md
    • third_party/blink/perf_tests/canvas/OWNERS
    • third_party/blink/perf_tests/canvas/gpu-bound-shader.html
    • third_party/blink/perf_tests/canvas/resources/canvas_runner.js
    • third_party/blink/perf_tests/canvas/sheets-render.html
    • third_party/blink/perf_tests/canvas/upload-webgl-to-texture.html
    • tools/perf/benchmark.csv
    • tools/perf/benchmarks/blink_perf.py
    • tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
    • tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
    • tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py
    • tools/perf/core/shard_maps/android-nexus5x-perf_map.json
    • tools/perf/core/shard_maps/android_nexus5_perf_map.json
    • tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
    • tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
    • tools/perf/core/shard_maps/linux-perf_map.json
    • tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
    • tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
    • tools/perf/core/shard_maps/win-10-perf_map.json
    • tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
    • tools/perf/core/shard_maps/win_7_perf_map.json
  19. SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:27:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 413493e0052d3f0537cf96d619849e8acf248658

    Comments

    SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard
    
    Bug: 856179
    Change-Id: I0fb499c5bb5c0de6df4fa7c2f46d3b0b35f5f0df
    Reviewed-on: https://chromium-review.googlesource.com/c/1326901
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606848}

    Changed files

    • chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  20. Fix MergeAndOverrideOnConflict for custom properties.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:25:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3052bf26cacf33ea7dd70fda7cccb5bebb28cfe9

    Comments

    Fix MergeAndOverrideOnConflict for custom properties.
    
    Utilizing CSSPropertyName, to make the code much nicer.
    
    R=futhark@chromium.org
    
    Change-Id: I10733cabe27cc271eaaf3ecf62fa7713cf74eac3
    Reviewed-on: https://chromium-review.googlesource.com/c/1323650
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606847}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_value.cc
    • third_party/blink/renderer/core/css/css_property_value.h
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/css_property_value_set_test.cc
  21. Add redirected cases to CSP/import tests in wpt/worklets

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff65400edef4c2d8e8ed01f1e2bd60c1c55aa8c

    Comments

    Add redirected cases to CSP/import tests in wpt/worklets
    
    Also this CL replaces some of empty-worklet-script.js usage
    in CSP tests with empty-worklet-script-with-cors-header.js
    to make sure worklets are rejected due to CSP, not CORS.
    
    Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92
    Reviewed-on: https://chromium-review.googlesource.com/c/1312146
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606846}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/csp-tests.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js
  22. Add UseCounter for unknown namespace usage in selectors.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c413c91c21481af23cfb54d742e80fd2b589608

    Comments

    Add UseCounter for unknown namespace usage in selectors.
    
    R=chrishtr@chromium.org
    
    Bug: 901938
    Change-Id: I9e20fe19f2c97b98f8250c6c9914512b5a73d8c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1318891
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606845}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/frame/use_counter_test.cc
    • tools/metrics/histograms/enums.xml
  23. Retire NotificationInlineReplies runtime enabled flag.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:15:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5395d94feaf7a04c1a7fd9832d3750c636d6dea1

    Comments

    Retire NotificationInlineReplies runtime enabled flag.
    
    NotificationInlineReplies shipped in M70.
    
    BUG=834580
    
    Change-Id: Ibed1612aae4c21a239e9328d7134cd75169c713a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323615
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606844}

    Changed files

    • third_party/blink/renderer/modules/notifications/notification_action.idl
    • third_party/blink/renderer/modules/notifications/notification_event.idl
    • third_party/blink/renderer/modules/notifications/notification_event_init.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  24. [Autofill Assistant] Fixes Payement Request details bug.

    Changed by Lukasz Suder - lsuderohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:13:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be08662134b0c40ff6913cf531e2fefed5c2d4d9

    Comments

    [Autofill Assistant] Fixes Payement Request details bug.
    
    Before all details where asked each time.
    
    Bug: 806868
    Change-Id: Ie3a278e2882d4829cfe2c54ac641d10abf5af2e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329167
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606843}

    Changed files

    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
  25. Fix the icons for the app menu and the upgrade item in it when an update is available.

    Changed by Greg Thompson - grtohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:12:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5a766d75a0eb8006212cb5cee94d704650c787b

    Comments

    Fix the icons for the app menu and the upgrade item in it when an update is available.
    
    A regression was introduced in r581520 that caused the wrong icon and/or
    the wrong coloring to be used in some circumstances. This CL fixes this
    in two parts:
    
    - AppMenuIconController may decide that the "annoyance level" from a
      pending update is too low to bother the user. One bug introduced in
      r581520 was that the controller still notified delegates that the
      UPGRADE_NOTIFICATION icon type should be used in this case. Now, the
      VERY_LOW annoyance level is ignore entirely for beta and stable
      channels.
    
    - AppMenuModel no longer bases its decision to include the upgrade menu
      item directly on the UpgradeDetector. Rather, it now queries the
      AppMenuIconController. This ensures that the same logic is used for
      both the badging of the app menu and for the presence of the upgrade
      item in the menu.
    
    BUG=898958
    
    Change-Id: I4b761844365968a24bc69030d711122fcaf16e28
    Reviewed-on: https://chromium-review.googlesource.com/c/1312475
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606842}

    Changed files

    • chrome/browser/ui/toolbar/app_menu_icon_controller.cc
    • chrome/browser/ui/toolbar/app_menu_icon_controller.h
    • chrome/browser/ui/toolbar/app_menu_icon_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
    • chrome/browser/ui/toolbar/app_menu_model.h
    • chrome/browser/ui/toolbar/app_menu_model_unittest.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/BUILD.gn
  26. Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c42eb303c89bfba751ae499abfb7252e2ceb7532

    Comments

    Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02
    
    Using wpt-import in Chromium 43d0eed3db77a5e6167b5ebbf6ecb3710790272a.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: I4bcac484d08efe8d6e6412d40b1c7d73ffe512d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329061
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606841}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/selection-api.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  27. testing/buildbot: add fake bots to run Dawn's GPU tests.

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f2b5efa43dfe2ff69fab31ba83c352ecf8e62ab

    Comments

    testing/buildbot: add fake bots to run Dawn's GPU tests.
    
    BUG=chromium:901830
    
    Change-Id: I5c5b0b08fadddc34f6a2d176ae39ebfae7e7f706
    Reviewed-on: https://chromium-review.googlesource.com/c/1326157
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606840}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
  28. Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:03:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01d002523922e64775a90ae4fbcb831f3aebf024

    Comments

    Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/606ed681f4ea..fd986312652f
    
    
    git log 606ed681f4ea..fd986312652f --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 hjd@google.com Merge "perfetto-ui: Fix UI with counter only traces"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@fd986312652f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I602c7205239349ff0faf4467740388c6cb05725f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329044
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606839}

    Changed files

    • DEPS
  29. Roll src-internal c458532c0628..6166365225d6 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 14:56:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02a2080524dcf1a59efd81b88b8a6526fc6224ee

    Comments

    Roll src-internal c458532c0628..6166365225d6 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c458532c0628..6166365225d6
    
    
    Created with:
      gclient setdep -r src-internal@6166365225d6
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I57783466072640b229610c2550d50f9c46d0c4e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329043
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606838}

    Changed files

    • DEPS
  30. Add a provider for the Passwords UI in Settings

    Changed by Ioana Pandele - ioanapohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:51:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda313fc19c2032e21eed604a1a0e58d42587ee

    Comments

    Add a provider for the Passwords UI in Settings
    
    This CL introduces ManagePasswordsUIProvider, a class which aims to allow
    for alternative UI surfaces to be shown if available.
    
    Bug: 903249
    Change-Id: I8c03f2f539772044bd5ba0fa944fd5e441d43c76
    Reviewed-on: https://chromium-review.googlesource.com/c/1326488
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606837}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
    • chrome/android/java/src/org/chromium/chrome/browser/password_manager/ManagePasswordsUIProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
    • chrome/android/java_sources.gni
  31. Apk for test proguard flags ignoring classes which don't exist

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:50:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4fffd63b4281c67f7e142087c476ce903a5a08a

    Comments

    Apk for test proguard flags ignoring classes which don't exist
    
    Bug: 872904
    Change-Id: Ib178be906c8d74ecabd7cfafeba8e7cf3a3398ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1327331
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606836}

    Changed files

    • chrome/android/java/apk_for_test.flags
  32. Enable multiple WorkerFetchContext per one global scope

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:46:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7ede5922f5c054c81b5ea049651775ab0503582c

    Comments

    Enable multiple WorkerFetchContext per one global scope
    
    Currently WorkerFetchContext has the ownership of
    some objects originated from WebWorkerFetchContext.
    To create multiple WorkerFetchContexts
    for one WorkerOrWorkletGlobalScope/WebWorkerFetchContext,
    this CL moves these ownership outside WorkerFetchContext.
    Namely,
    - url_loader_factory_ and script_loader_factory_
      from WorkerFetchContext to WebWorketFetchContext subclasses, and
    - subresource_filter_ from WorkerFetchContext to
      WorkerOrWorkletGlobalScope.
      Still |WorkerFetchContext::subresource_filter_| is kept, but
      it is created in WorkerOrWorkletGlobalScope and passed to
      WorkerFetchContext.
    
    This CL doesn't change the observable behavior.
    This CL creates WebURLLoaderFactory a little more eagerly, i.e.
    when WorkerFetchContext is created,
    while previously it was created when
    WorkerFetchContext::CreateURLLoader() is called for the first time.
    
    Bug: 880027, 903579
    Change-Id: I84a8bafee25b7f293201a271d198260e2dfb8e68
    Reviewed-on: https://chromium-review.googlesource.com/c/1193385
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606835}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/service_worker/service_worker_fetch_context_impl.cc
    • content/renderer/service_worker/service_worker_fetch_context_impl.h
    • third_party/blink/public/platform/web_worker_fetch_context.h
    • third_party/blink/renderer/core/loader/worker_fetch_context.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.h
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
  33. [ios] Deletes unused code that was migrated from ios/clean.

    Changed by Rohit Rao - rohitraoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:41:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e3ace0051b91c7144046c60acd04c7d658c9b09

    Comments

    [ios] Deletes unused code that was migrated from ios/clean.
    
    BUG=None
    
    Change-Id: I3a14f465f152e9b1b514802723093e9702edc001
    Reviewed-on: https://chromium-review.googlesource.com/c/1326487
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606834}

    Changed files

    • ios/chrome/browser/browser_state/BUILD.gn
    • ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
    • ios/chrome/browser/ui/coordinators/BUILD.gn
    • ios/chrome/browser/ui/coordinators/browser_coordinator+internal.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.mm
    • ios/chrome/browser/ui/main_content/BUILD.gn
    • ios/chrome/browser/ui/main_content/main_content_coordinator.h
    • ios/chrome/browser/ui/main_content/main_content_coordinator.mm
    • ios/chrome/browser/ui/main_content/main_content_coordinator_unittest.mm
    • ios/chrome/browser/ui/overlays/BUILD.gn
    • ios/chrome/browser/ui/overlays/OWNERS
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.h
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_coordinator+internal.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/overlay_queue.h
    • ios/chrome/browser/ui/overlays/overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler_observer.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_service.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.mm
    • ios/chrome/browser/ui/overlays/overlay_service_impl.h
    • ios/chrome/browser/ui/overlays/overlay_service_impl.mm
    • ios/chrome/browser/ui/overlays/overlay_service_observer.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.mm
    • ios/chrome/browser/ui/overlays/test/BUILD.gn
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.h
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.mm
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.h
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.mm
    • ios/chrome/test/BUILD.gn
  34. RC: Compress all chrome://discards resources.

    Changed by Sigurdur Asgeirsson - siggiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:35:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e826ee9592541ae9d53fd23c51761adf9df17cfc

    Comments

    RC: Compress all chrome://discards resources.
    
    I don't know whether to trust these numbers, but this is what I see
    for my local Windows release 32 bit build.
    
    Uncompressed:
    3,034,139 browser_resources.pak
    233,038,336 mini_installer.exe
    
    Compressed:
    2,869,382 browser_resources.pak
    232,873,472 mini_installer.exe
    
    Bug: 891310
    Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822
    Reviewed-on: https://chromium-review.googlesource.com/c/1327406
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606833}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/ui/webui/discards/discards_ui.cc
  35. use SkFontHinting

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf

    Comments

    use SkFontHinting
    
    Bug: skia:2664
    Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205
    Reviewed-on: https://chromium-review.googlesource.com/c/1318416
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606832}

    Changed files

    • cc/paint/oop_pixeltest.cc
    • cc/paint/paint_flags.cc
    • cc/paint/paint_flags.h
    • chrome/renderer/pepper/pepper_flash_renderer_host.cc
    • content/renderer/render_view_fuchsia.cc
    • content/renderer/render_view_linux.cc
    • skia/config/SkUserConfig.h
    • third_party/blink/public/platform/web_font_render_style.h
    • third_party/blink/renderer/platform/fonts/font_metrics.cc
    • third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
    • third_party/blink/renderer/platform/fonts/web_font_render_style.cc
    • third_party/blink/renderer/platform/graphics/logging_canvas.cc
  36. PersonalDataManager: Rename AccountStorageForServer(Cards->Data)

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41c87263ae4560b264e15ec45be4832be2e79e86

    Comments

    PersonalDataManager: Rename AccountStorageForServer(Cards->Data)
    
    The account storage is now used for both server cards and server
    addresses.
    
    Bug: 864519
    Change-Id: Ia5fb5ebc4bd4e334b162378923ccd04562d4cac9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329241
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606831}

    Changed files

    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
  37. PersonalDataManager: Store server (aka Wallet) addresses in the Server DB

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 274ab9c5685ffb50c277a68979c46b4abf9c9455

    Comments

    PersonalDataManager: Store server (aka Wallet) addresses in the Server DB
    
    Currently, this makes no functional difference: In full Sync mode, the
    local DB and the server DB are the same thing anyway, and in
    lightweight/Butter mode, we don't store server addresses at all.
    However,
    1) this change will unlock actually supporting Wallet addresses in
       Butter mode, and
    2) it's just less confusing if "server" things are actually stored in
       the "server" DB.
    
    Bug: 864519
    Change-Id: I4f5479faff87cfa4f7def6b98f6b2235294393b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1326492
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606830}

    Changed files

    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager_unittest.cc
  38. Ribbon: Apply values via CustomProperty.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:23:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 634f8db566f7e5401be35e6d6d98f8858a41e0d0

    Comments

    Ribbon: Apply values via CustomProperty.
    
    Instead of applying custom properties via the static Variable instance,
    use the new CustomProperty class (which knows about its name and
    registration) to apply values. This brings the custom property code path
    closer to the standard property code path.
    
    To assist CSSPropertyRef in producing a CSSProperty&, this CL adds the
    class CSSPropertyName. The idea is that CSSPropertyName can be used instead
    of CSSPropertyID/AtomicString where both standard and custom properties are
    expected. My intent is to store a CSSPropertyName in
    CSSPropertyValueMetadata (instead of the CSSProperty*), but this is a big
    change, as everything that creates property/value pairs must carry the
    CSSPropertyName. So, for now PropertyReference.Name() is faking it by
    digging the name out of the associated CSSValue.
    
    Note that CSSPropertyName::ToAtomicString intentionally does not return
    a const AtomicString&. This is because 1) I want to try and reduce the
    size of CSSPropertyName to one pointer, which means it will contain a
    StringImpl* rather than an AtomicString, and 2) I want CSSPropertyName to
    be something that can be passed to other threads if needed, which again
    means StringImpl* (or String, at least) rather than AtomicString.
    
    In general, this CL is a step on the path to achieve these things:
    
     1. Removing the useless and dangerous static Variable instance.
     2. Not having to piggy-back the custom property name in a CSSValue.
     3. Not having to smuggle initial/inherit/unset via the
        CSSCustomPropertyDeclaration (vs. applying CSSIdentifierValues
        holding these values, like civilized individuals).
    
    R=flackr@chromium.org, futhark@chromium.org
    
    Change-Id: I1a062138fc86c5a398542ac147bf9d71feed7b3c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323113
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606829}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/animation/css_default_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_var_cycle_interpolation_type.cc
    • third_party/blink/renderer/core/animation/property_handle.h
    • third_party/blink/renderer/core/animation/property_handle_test.cc
    • third_party/blink/renderer/core/css/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_name.cc
    • third_party/blink/renderer/core/css/css_property_name.h
    • third_party/blink/renderer/core/css/css_property_name_test.cc
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/properties/css_property_ref.cc
    • third_party/blink/renderer/core/css/properties/css_property_ref.h
    • third_party/blink/renderer/core/css/properties/css_property_ref_test.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.h
    • third_party/blink/renderer/core/css/properties/longhands/variable.cc
    • third_party/blink/renderer/core/css/properties/longhands/variable.h
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver_test.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.h
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc
  39. Revert "Mac: Disallow dragging tab into blocked tabstrip"

    Changed by Leonard Grey - lgreyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 899b84ea267b8ce6ce522d2cf3b34453be3ac164

    Comments

    Revert "Mac: Disallow dragging tab into blocked tabstrip"
    
    This reverts commit 002dfaef6957632740a412c3d69af0913536e1dd.
    
    Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=903706#c1
    
    Original change's description:
    > Mac: Disallow dragging tab into blocked tabstrip
    > 
    > This is a really longwinded way for me to fix some NOTIMPLEMENTED spam,
    > though I'm pretty sure the thing that happens right now when you open
    > a certificate prompt and drag a tab into the parent window is bad.
    > 
    > This introduces a new method because we're not sure if it matches the
    > Aura semantics, and this is better than the nothing we were doing previously.
    > 
    > Bug: 825834
    > Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1315956
    > Commit-Queue: Leonard Grey <lgrey@chromium.org>
    > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606619}
    
    TBR=ellyjones@chromium.org,lgrey@chromium.org
    
    Change-Id: If2a6470657f160a0e7fa2fd9978078ab46ae048a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 825834
    Reviewed-on: https://chromium-review.googlesource.com/c/1329341
    Reviewed-by: Leonard Grey <lgrey@chromium.org>
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606828}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/tabs/tab_drag_controller.h
  40. Fix h2o_junit_manifest_target_name on the bots

    Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a996f2946740acd659f5ed757b2ae364c0168c0

    Comments

    Fix h2o_junit_manifest_target_name on the bots
    
    This CL:
    - Makes the generated AndroidManifest.xml a data dependency of
    h2o_junit_manifest_target_name
    - Reenables LaunchTest.*
    
    BUG=902325
    
    Change-Id: I47e3c5c2226c78c696716712a4307127493c5903
    Reviewed-on: https://chromium-review.googlesource.com/c/1324875
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606827}

    Changed files

    • chrome/android/webapk/shell_apk/BUILD.gn
    • chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/h2o/LaunchTest.java
  41. [Autofill Assistant] Allow clicking on links.

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:16:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74c9dc10cd643cc6eec6928ae7a8c8d364b85738

    Comments

    [Autofill Assistant] Allow clicking on links.
    
    Before this patch, navigation triggered by clicking on a link or through
    javascript (renderer-initiated navigation) was considered an end state
    for Autofill assistant.
    
    With this patch, such actions are only considered an end state if the
    page that's navigated to has no scripts. This is necessary, as such
    navigation is part of the expected flow of some scripts.
    
    Going back a page or refreshing through the UI (non renderer-initiated
    navigation) are still considered an end state with this patch.
    
    Bug: 806868
    Change-Id: I5a38a82e7edf8b34a5830130b957dfad387e1b0d
    Reviewed-on: https://chromium-review.googlesource.com/c/1329242
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606826}

    Changed files

    • components/autofill_assistant/browser/controller.cc
  42. [iOS] Decouple completion handler from new tab creation in BVC.

    Changed by Mark Cogan - marqohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:15:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c86aa454442704cbfc07d7bf5aaf6a7e301b70c

    Comments

    [iOS] Decouple completion handler from new tab creation in BVC.
    
    This CL decouples the addition of a tab completion block from the other
    tab opening code in the BVC. This will allow the tab opening logic
    (which is just tab model manipulation) to be moved out of the BVC.
    
    Bug: 903338
    Change-Id: Ibc7ba411c2cbec58dd11ac7cb65e2b9284eb811c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323558
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606825}

    Changed files

    • ios/chrome/app/application_delegate/url_opener_unittest.mm
    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/ui/browser_view_controller.h
    • ios/chrome/browser/ui/browser_view_controller.mm
  43. [Autofill Assistant] Fix tap operation and add browser tests

    Changed by gogerald - gogeraldohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:02:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c30a7925aa902990811797ff7dcd2cf89994947

    Comments

    [Autofill Assistant] Fix tap operation and add browser tests
    
    Bug: 806868
    Change-Id: I9730373e60f28b65fb515f9de42da0f6505db594
    Reviewed-on: https://chromium-review.googlesource.com/c/1324239
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606824}

    Changed files

    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
    • components/autofill_assistant/browser/web_controller_browsertest.cc
    • components/test/data/autofill_assistant/autofill_assistant_target_website.html
    • components/test/data/autofill_assistant/autofill_assistant_target_website_iframe_one.html
  44. [Autofill Assistant] Extended the amount of information available through feedback forms.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 13:57:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0eb90453d54daf47f522b220ba83dda94bba669

    Comments

    [Autofill Assistant] Extended the amount of information available through feedback forms.
    
    The stock android feedback form has an optional string field `feedbackContext', which can be used to provide extended information. Depending on when the user taps the feedback button, not all of the information may be available.
    
    Bug: 806868
    Change-Id: I5dfaaf813c48198f573f2e1fbd0d6468439d3a6c
    Reviewed-on: https://chromium-review.googlesource.com/c/1317911
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606823}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/FeedbackContext.java
    • chrome/android/java_sources.gni
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/mock_ui_controller.h
    • components/autofill_assistant/browser/script_tracker.cc
    • components/autofill_assistant/browser/script_tracker.h
    • components/autofill_assistant/browser/ui_controller.h
    • components/autofill_assistant/browser/ui_delegate.h
  45. Revert "Add resource load priority Service Worker tests"

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:57:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c01e9b4c3145dbde2c4d472ab75dd00937663981

    Comments

    Revert "Add resource load priority Service Worker tests"
    
    This reverts commit 0f0d0b74734bf82737b893d03ed334ef360f9b0b.
    
    Reason for revert: super flaky on win7_chromium_rel_ng
    
    BUG=chromium:872776
    
    Original change's description:
    > Add resource load priority Service Worker tests
    > 
    > This CL adds resource load priority tests ensuring that the priority of
    > requests that pass through a Service Worker is preserved.
    > 
    > R=​kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org
    > 
    > Bug: 872776
    > Change-Id: I74f334359b3255fcac5c13fbdb9f1e601af0f8f0
    > Reviewed-on: https://chromium-review.googlesource.com/c/1316104
    > Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
    > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606689}
    
    TBR=falken@chromium.org,kinuko@chromium.org,yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com
    
    Change-Id: I6d997795ffc64f1005ed3821799300cd3401eea9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 872776
    Reviewed-on: https://chromium-review.googlesource.com/c/1329245
    Reviewed-by: Corentin Wallez <cwallez@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606822}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/priorities/resource-load-priorities-service-worker.https-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/priorities/resource-load-priorities-service-worker.https.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/common.js
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/async-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/defer-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/fetch.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/module-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/off-screen-image.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/parser-blocking-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/prefetch.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/render-blocking-stylesheet.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/xhr.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/service-worker-get-priority.js
  46. [SPv2] Fix background invalidation on scroll

    Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:55:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 089805f4087998a3c196305ad8f13cc488bb7655

    Comments

    [SPv2] Fix background invalidation on scroll
    
    The previous early return shortcut required invalidation of fixed-attachment
    background etc.
    
    Now in PaintLayerScrollableArea::InvalidatePaintForScrollOffsetChange():
    - always invalidate for fixed-attachment background
    - correct invalidation of local-attachment background for SPv2
    - remove the SetNeedsRepaint() logic for change of existence of
      ScrollTranslation because now PaintPropertyTreeBuilder will do that
      whenever a paint property node is created or removed
    
    Bug: 529963
    Change-Id: I5c9636cb318412cf8398f305a43bc0c55b9a3fc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1308988
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606821}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/full-viewport-repaint-for-background-attachment-fixed-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll/overflow-scroll-local-background-text-color-change-expected.txt
    • third_party/WebKit/LayoutTests/paint/invalidation/scroll/repaint-during-scroll-with-zoom-expected.txt
    • third_party/blink/renderer/core/paint/box_paint_invalidator.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
    • third_party/blink/renderer/core/style/fill_layer.cc
    • third_party/blink/renderer/core/style/fill_layer.h
  47. Revert "Fix page slip issue after dragging"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:55:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a47b88e164851a0821bd9d6107b63deedb09656a

    Comments

    Revert "Fix page slip issue after dragging"
    
    This reverts commit 05e6d6110b8ee4c29a04943ac021bf59c1d62c72.
    
    Reason for revert: Breaks AppsGridViewDragTest.MouseDragMaxItemsInFolder/6 and a bunch of other tests. 
    
    ==23676==ERROR: AddressSanitizer: container-overflow on address 0x608000011e50 at pc 0x5580f7784dcd bp 0x7ffd9affb130 sp 0x7ffd9affb128
    READ of size 8 at 0x608000011e50 thread T0
        #0 0x5580f7784dcc in ViewAtBase ui/views/view_model.h:71:28
    
    See https://sheriff-o-matic.appspot.com/chromium/examine/chromium.memory.Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1).app_list_unittests.
    
    Original change's description:
    > Fix page slip issue after dragging
    > 
    > Changes:
    > Update the selected page to be the target page of dragged item at the
    > end of dragging.
    > 
    > Bug: 893832
    > Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df
    > Reviewed-on: https://chromium-review.googlesource.com/c/1324851
    > Commit-Queue: Weidong Guo <weidongg@chromium.org>
    > Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606585}
    
    TBR=newcomer@chromium.org,weidongg@chromium.org
    
    Change-Id: I4177d2e3ac6226b415b627148db211614d0b7ec4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893832
    Reviewed-on: https://chromium-review.googlesource.com/c/1329170
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606820}

    Changed files

    • ash/app_list/views/apps_grid_view.cc
  48. v8binding: Use explicitly-typed callback functions in custom elements

    Changed by Yuki Shiino - yukishiinoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:46:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f2d97b775634dcb3f099162f926af93924d29ab

    Comments

    v8binding: Use explicitly-typed callback functions in custom elements
    
    We're planning to not use cross origin ScriptStates everywhere,
    especially in IDL callback function and callback interface.
    Given that, we'd like to minimize use of ScriptState of callbacks,
    which will be nullptr in case of cross origin, so that the call sites
    of callbacks do not need to handle a SecurityError.
    
    This patch is a preparation of https://crrev.com/c/1314023 and
    removes the use of the ScriptState from custom elements.
    
    Bug: 886588, 892755
    Change-Id: I52068920b659efe119496ec092448cdc107e0631
    Reviewed-on: https://chromium-review.googlesource.com/c/1325585
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606819}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/BUILD.gn
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.cc
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.h
    • third_party/blink/renderer/bindings/scripts/v8_callback_function.py
    • third_party/blink/renderer/bindings/scripts/v8_callback_interface.py
    • third_party/blink/renderer/bindings/scripts/v8_types.py
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.h
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.h
    • third_party/blink/renderer/core/html/custom/custom_element_registry.idl
  49. DisabletestModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab.

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:41:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 496cd36004b1f6d845e66930bbbd939de4e4f5bb

    Comments

    DisabletestModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab.
    
    It is flaky. See for instance
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/121816.
    
    Bug: 903658, 903657
    Change-Id: Ic682ac60329923a35745d135d101d0eb8b61b08b
    Tbr: mdjones@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1329161
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606818}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java