Home | Search | chromium - Builders
Login

Builder ios-simulator-xcode-clang Build 58138 Apple OSX

Results:

Failure compile Failure postprocess_for_goma

Trigger Info:

Projectchromium
Revision290bc882fa0022afd17118d11949266c86fa631b
Got Revision290bc882fa0022afd17118d11949266c86fa631b

Execution:

Steps and Logfiles:

Show:
  1. ( 243 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 14 mins 5 secs ) bot_update
    [116GB/232GB used (50%)]
  3. ( 281 ms ) read build config
  4. ( 0 ) ensure_goma
  5. ( 0 ) ensure xcode
    Ensuring Xcode version 10l213o in /b/s/w/ir/cache/xcode_ios_10l213o.app
  6. ( 17 mins 17 secs ) ensure xcode.install xcode
  7. ( 20 mins 34 secs ) gclient runhooks
  8. ( 566 ms ) lookup GN args
     
    additional_target_cpus = [ "x86" ]
    ios_enable_code_signing = false
    is_component_build = false
    is_debug = true
    symbol_level = 1
    target_cpu = "x64"
    target_os = "ios"
    use_goma = true
    use_xcode_clang = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 1 hrs 1 mins ) compile
  10. ( 1 mins 40 secs ) postprocess_for_goma.upload_log

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm123-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539341391629939, "id": "8932877276889845744", "project": "chromium", "tags": ["builder:ios-simulator-xcode-clang", "buildset:commit/git/290bc882fa0022afd17118d11949266c86fa631b", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/290bc882fa0022afd17118d11949266c86fa631b", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098307339081282928", "scheduler_job_id:chromium/ios-simulator-xcode-clang", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-simulator-xcode-clang" setup_build
buildnumber 58138 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "290bc882fa0022afd17118d11949266c86fa631b" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "290bc882fa0022afd17118d11949266c86fa631b" bot_update
got_revision_cp "refs/heads/master@{#599168}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update

Blamelist:

  1. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  2. Scott Wu (scottwuohnoyoudont@chromium.org)
  3. Laís Minchillo (laisminchilloohnoyoudont@chromium.org)
  4. Scott Wu (scottwuohnoyoudont@chromium.org)
  5. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  6. Jordan Demeulenaere (jdemeulenaereohnoyoudont@google.com)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. Kurt Horimoto (kkhorimotoohnoyoudont@chromium.org)
  9. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  10. Fan Yang (fayangohnoyoudont@chromium.org)
  11. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  12. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  13. vasilii (vasiliiohnoyoudont@chromium.org)
  14. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  15. Yuki Yamada (yukiyohnoyoudont@google.com)
  16. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  17. Peter E Conn (peconnohnoyoudont@chromium.org)
  18. Florent Castelli (orphisohnoyoudont@chromium.org)
  19. Mostyn Bramley-Moore (mostynbohnoyoudont@vewd.com)
  20. Olivier Robin (olivierrobinohnoyoudont@chromium.org)
  21. Leszek Swirski (leszeksohnoyoudont@chromium.org)
  22. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  23. Alexander Alekseev (alemateohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 10:49:51 UTC
Start Friday, 12-Oct-18 10:53:37 UTC
End Friday, 12-Oct-18 12:52:59 UTC
Pending 3 mins 46 secs
Execution 1 hrs 59 mins

All Changes:

  1. Reland "Remove IDC_SHOW_SYNC_SETUP"

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:48:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 290bc882fa0022afd17118d11949266c86fa631b

    Comments

    Reland "Remove IDC_SHOW_SYNC_SETUP"
    
    This reverts commit 2ec520568c51bcd167a1ed24baa3a6f45023f02b.
    
    Reason for revert: This original CL was reverted as in emergency for M70 as it was in the CL dependency chain for the signin allowed pref CL.
    
    Original change's description:
    > Revert "Remove IDC_SHOW_SYNC_SETUP"
    > 
    > This reverts commit eafee2dc30fa6fdb34e07c664fd858a361cb5424.
    > 
    > Reason for revert: Still needed for http://crbug.com/888776
    > 
    > Original change's description:
    > > Remove IDC_SHOW_SYNC_SETUP
    > > 
    > > IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This
    > > CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up
    > > the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP
    > > and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing.
    > > 
    > > Bug: 870239
    > > Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402
    > > Reviewed-on: https://chromium-review.googlesource.com/1236263
    > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > > Reviewed-by: Scott Violet <sky@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#593138}
    > 
    > TBR=sky@chromium.org,msarda@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 870239
    > Change-Id: I50cd0042f2630dca0bafe4540c2c32411acf0338
    > Reviewed-on: https://chromium-review.googlesource.com/1245381
    > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#594261}
    
    TBR=sky@chromium.org,msarda@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 870239
    Change-Id: Icde4e75988dd24b5bb2add35be055177708c7bfe
    Reviewed-on: https://chromium-review.googlesource.com/c/1278745
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599168}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/browser/ui/browser_command_controller.cc
    • chrome/browser/ui/browser_command_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
  2. Rename PasswordControllerHelper to PasswordFormHelper

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:44:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 830919bab9ae548252386c0e0b2bb97b4a22152e

    Comments

    Rename PasswordControllerHelper to PasswordFormHelper
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587
    Reviewed-on: https://chromium-review.googlesource.com/c/1278670
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599167}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_form_helper.h
    • components/password_manager/ios/password_form_helper.mm
    • components/password_manager/ios/password_form_helper_unittest.mm
    • components/password_manager/ios/password_suggestion_helper.h
    • ios/chrome/browser/passwords/password_controller.h
    • ios/chrome/browser/passwords/password_controller.mm
    • ios/chrome/browser/passwords/password_controller_unittest.mm
    • ios/web_view/internal/passwords/cwv_password_controller.mm
  3. [aw] Add callback to proxy override methods

    Changed by Laís Minchillo - laisminchilloohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2dd9b16afe9c2808aaa11566aa54fa854282db2

    Comments

    [aw] Add callback to proxy override methods
    
    Add an optional callback to proxy override methods introduced in change
    https://chromium-review.googlesource.com/c/chromium/src/+/1148384
    
    This adds an optional callback developers can use to know when the
    changes have been made to the network settings, since the methods are
    not synchronous with the UI thread.
    
    Bug: 851995
    Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217
    Reviewed-on: https://chromium-review.googlesource.com/c/1258770
    Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599166}

    Changed files

    • android_webview/browser/aw_contents_statics.cc
    • android_webview/browser/net/aw_url_request_context_getter.cc
    • android_webview/browser/net/aw_url_request_context_getter.h
    • android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java
    • android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/StaticsBoundaryInterface.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
    • android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
    • net/proxy_resolution/proxy_config_service_android.cc
    • net/proxy_resolution/proxy_config_service_android.h
    • net/proxy_resolution/proxy_config_service_android_unittest.cc
  4. Move password suggestion logic into components.

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b9a4429e3b49acb3be07a11697d3d9680f08e616

    Comments

    Move password suggestion logic into components.
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ibf5ee92330172532dff87f9752d301a134ec49fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1264455
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599165}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_suggestion_helper.h
    • components/password_manager/ios/password_suggestion_helper.mm
    • ios/chrome/browser/passwords/password_controller.mm
  5. [css-properties-values-api] Multi-value StylePropertyMap.set.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d84303e41153ea9cb0f6475b6bb9e430666022a2

    Comments

    [css-properties-values-api] Multi-value StylePropertyMap.set.
    
    This adds support for setting multiple values with TypedOM for list-valued
    custom properties. For example, for a property --x with syntax <length>+,
    it will now be possible to do:
    
      element.attributeStyleMap.set('--x', CSS.px(1), CSS.px(2));
    
    This is done by producing a CSSVariableReferenceValue holding tokens
    equivalent to the incoming CSSStyleValues, provided that those values
    match the grammar of the custom property.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: Ic28497edbbea894a9c09b840dcb6c8fb825d99bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1270963
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599164}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/css_syntax_descriptor.h
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
  6. [Autofill Assistant] Make various improvements to the UI.

    Changed by Jordan Demeulenaere - jdemeulenaereohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 10:29:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e83ced5f800af6a60da52d8a183776b002c7b54

    Comments

    [Autofill Assistant] Make various improvements to the UI.
    
    Screenshot before: https://screenshot.googleplex.com/5zbTV7W40Rh.png
    Screenshot after: https://screenshot.googleplex.com/59OsupD4J5o.png
    
    Binary-Size: Increase is due to adding new bottom bar background.
    Bug: 806868
    Change-Id: Ie6863f6922eca210f3e823c22318cd6bd323be81
    Reviewed-on: https://chromium-review.googlesource.com/c/1273518
    Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599163}

    Changed files

    • chrome/android/BUILD.gn
    • chrome/android/java/res_autofill_assistant/drawable-hdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-mdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xxhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xxxhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg.xml
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_normal.xml
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_pressed.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_chip.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/res_autofill_assistant/values-v17/styles.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
  7. Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 10:26:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31904c2ab872bb48841916acaa8dd9fad167589e

    Comments

    Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2727ef6f5dc..03ec3c699be2
    
    
    git log e2727ef6f5dc..03ec3c699be2 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 vapier@chromium.org cros_portage_upgrade_unittest: convert to mock
    2018-10-12 vapier@chromium.org gsutil: add wrapper script for our pinned version
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@03ec3c699be2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I9f381f438b01450da63805d85cec801baa22ec4d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278706
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599162}

    Changed files

    • DEPS
  8. [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.

    Changed by Kurt Horimoto - kkhorimotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61701cc0ee389e0dae437516d9b8edad2f874b18

    Comments

    [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.
    
    Now that the scroll proxy's contentInset is not guaranteed to be zero,
    we need to check against the contentInset instead of CGPointZero.
    
    Bug: 894617
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I5ba5131c969a4584879be905a92f0736a34d7f46
    Reviewed-on: https://chromium-review.googlesource.com/c/1277674
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599161}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
  9. Roll src-internal 7781cb9daa22..f37e9866851d (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 10:10:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 042ad90ac5334bd95efe24e495bdf3274930305e

    Comments

    Roll src-internal 7781cb9daa22..f37e9866851d (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7781cb9daa22..f37e9866851d
    
    
    Created with:
      gclient setdep -r src-internal@f37e9866851d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I1d534c0a85bbd4bb0af445e93060dbd898251de6
    Reviewed-on: https://chromium-review.googlesource.com/c/1278707
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599160}

    Changed files

    • DEPS
  10. Drop Dynamic from CreateIncomingDynamicStream, ShouldCreateIncomingDynamicStream and ShouldCreateOutgoingDynamicStream.

    Changed by Fan Yang - fayangohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:05:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a3bddfbdef537e0ec1eca74bef7fa64596ae5dd

    Comments

    Drop Dynamic from CreateIncomingDynamicStream, ShouldCreateIncomingDynamicStream and ShouldCreateOutgoingDynamicStream.
    
    Merge internal change: 214983203
    
    R=rch@chromium.org
    
    Change-Id: Iacfc81d8ed6e4a8931aab9fcc52ce8d847bd0e06
    Reviewed-on: https://chromium-review.googlesource.com/c/1276445
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Commit-Queue: Fan Yang <fayang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599159}

    Changed files

    • net/quic/quic_chromium_client_session.cc
    • net/quic/quic_chromium_client_session.h
    • net/quic/quic_chromium_client_session_peer.cc
    • net/quic/quic_chromium_client_session_peer.h
    • net/quic/quic_chromium_client_session_test.cc
    • net/quic/quic_chromium_client_stream_test.cc
    • net/third_party/quic/core/http/quic_server_session_base.cc
    • net/third_party/quic/core/http/quic_server_session_base.h
    • net/third_party/quic/core/http/quic_server_session_base_test.cc
    • net/third_party/quic/core/http/quic_spdy_client_session.cc
    • net/third_party/quic/core/http/quic_spdy_client_session.h
    • net/third_party/quic/core/http/quic_spdy_client_session_test.cc
    • net/third_party/quic/core/http/quic_spdy_session.h
    • net/third_party/quic/core/http/quic_spdy_session_test.cc
    • net/third_party/quic/core/quic_dispatcher_test.cc
    • net/third_party/quic/core/quic_session.cc
    • net/third_party/quic/core/quic_session.h
    • net/third_party/quic/core/quic_session_test.cc
    • net/third_party/quic/quartc/quartc_session.cc
    • net/third_party/quic/quartc/quartc_session.h
    • net/third_party/quic/quartc/quartc_stream_test.cc
    • net/third_party/quic/test_tools/quic_test_server.cc
    • net/third_party/quic/test_tools/quic_test_utils.h
    • net/third_party/quic/tools/quic_simple_server_session.cc
    • net/third_party/quic/tools/quic_simple_server_session.h
    • net/third_party/quic/tools/quic_simple_server_session_test.cc
    • net/third_party/quic/tools/quic_simple_server_stream_test.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
  11. media/gpu/VEA unittest: Enable VEAs to test with any yuv format stream

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:04:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd7080ae434cf6f6b7a0e388b466ae7c7b6dbee1

    Comments

    media/gpu/VEA unittest: Enable VEAs to test with any yuv format stream
    
    VEA unittest is only able to test I420 format input file.
    This enables it to test any yuv format stream.
    
    NV12, NV12 and YV21 formated raw videos are created by following commands.
    $ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt nv12 bear_320x192_40frames.nv12.yuv
    $ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt nv21 bear_320x192_40frames.nv21.yuv
    $ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt yuv420p -vf shuffleplanes=0:2:1 bear_320x192_40frames.yv12.yuv
    
    BUG=chromium:894381
    TEST=[kevin] ./video_encode_accelerator_unittest --test_stream_data=bear_320x192_40frames.nv12.yuv:320:192:1:bear.out:200000:30:::6 --ozone-platform=gbm
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I8a6b142671fc0532ba872f7eff966d43a2848ad9
    Reviewed-on: https://chromium-review.googlesource.com/c/1135106
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
    Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599158}

    Changed files

    • media/gpu/video_encode_accelerator_unittest.cc
    • media/test/data/README.md
    • media/test/data/bear_320x192_40frames.nv12.yuv
    • media/test/data/bear_320x192_40frames.nv21.yuv
    • media/test/data/bear_320x192_40frames.yv12.yuv
  12. Fix radio button bug on sync_page.html

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:04:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b00f3499c1dc74c8e0419384a69f041ebcd2442

    Comments

    Fix radio button bug on sync_page.html
    
    The second radio button in the passphrase section
    was not visibly checked on selection.
    
    To solve this, move the spans containing the conditional
    strings inside one radio-button, instead off having two
    conditional radio buttons.
    
    Additional change:
     - Remove aria-label attribute because the visible text
       is used automatically as radio button title.
    
    Bug: 894385
    Change-Id: Ie339def905ca976444880166552ba580068b9271
    Reviewed-on: https://chromium-review.googlesource.com/c/1276645
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599157}

    Changed files

    • chrome/browser/resources/settings/people_page/sync_page.html
  13. Rename the iVars in confirm_infobar_view.mm to match the style guide.

    Changed by vasilii - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:00:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b6016fba9fe8d6a5a7d2b13de035b34eb16d303

    Comments

    Rename the iVars in confirm_infobar_view.mm to match the style guide.
    
    It's a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1270922
    
    Bug: 890336
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Iea3b7be1d588cdcdbdded5409927e18c069812b4
    Reviewed-on: https://chromium-review.googlesource.com/c/1277287
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599156}

    Changed files

    • ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
  14. [iOS] Add SwitchToTab button to the omnibox popup

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:59:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2cc06f195b610cbe4aef0645fd96ddc29b2ab72a

    Comments

    [iOS] Add SwitchToTab button to the omnibox popup
    
    This CL adds the SwitchToTab image and handling to the omnibox popup
    row. It allows to switch easily to an opened tab based on omnibox
    suggestions.
    
    Bug: 893121
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ib440267802c1210ea416066c679a2ff4e963fbb6
    Reviewed-on: https://chromium-review.googlesource.com/c/1268344
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599155}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/browser_view_controller_unittest.mm
    • ios/chrome/browser/ui/commands/browser_commands.h
    • ios/chrome/browser/ui/omnibox/autocomplete_result_consumer.h
    • ios/chrome/browser/ui/omnibox/popup/BUILD.gn
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.h
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.h
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller_unittest.mm
    • ios/chrome/browser/ui/omnibox/popup/resources/BUILD.gn
    • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/Contents.json
    • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match.png
    • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match@2x.png
    • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match@3x.png
  15. Added security check for cross origin

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 09:45:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d2509fc2ebc7c9848726c1b208483e1e1efc485

    Comments

    Added security check for cross origin
    
    This CL adds a security check for cross origin with
    BindingSecurity::ShouldAllowAccessToCreationContext().
    |js_event|, a V8 wrapper object for event object, must be created in the
    relevant realm of the event target, but it is possible that listener's
    relevant context cannnot access the relevant realm of event target
    (ex. when Document.origin is changed).
    We have to check this before invoking event listener.
    
    Bug: 872138, 884516
    Change-Id: Ic5d0c8e6cda4db57a2097ce230e75cc59905b350
    Reviewed-on: https://chromium-review.googlesource.com/c/1270300
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599154}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  16. [iOS] Support Dynamic Type for ReadingList empty string

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:41:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe100b299e7bc889ccafc03cf8854efe64020679

    Comments

    [iOS] Support Dynamic Type for ReadingList empty string
    
    This CL changes the string displayed when the ReadingList is empty so
    it doesn't overflow below the bottom and top toolbar when the font is
    too big. It does that by limiting the font size.
    
    Bug: 893535
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I03335f2c1fee192a765b6e85011627c0f5ae2019
    Reviewed-on: https://chromium-review.googlesource.com/c/1276925
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599153}

    Changed files

    • ios/chrome/browser/ui/reading_list/empty_reading_list_message_util.mm
    • ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
  17. 🛃 Protect against disk read in queryIntentActivities

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:29:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5275c3572a1a4f0255f17e3c50d20465922cfd1e

    Comments

    🛃 Protect against disk read in queryIntentActivities
    
    Bug: 894160
    Change-Id: Idd2daa239adee9245690aaa8ae258437bf16c41f
    Reviewed-on: https://chromium-review.googlesource.com/c/1275431
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599152}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
  18. Mark virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction.html as failing

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:14:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 944dd0e6749ab63a23d50ddce1fae3ad610c47f3

    Comments

    Mark virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction.html as failing
    
    TBR=mstensho@chromium.org
    
    Bug: 635619
    Change-Id: I6dee9c7fd68b317c816216f3a8c521501acce255
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1278785
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599151}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  19. [jumbo] fixup after recent headless network service work

    Changed by Mostyn Bramley-Moore - mostynbohnoyoudont@vewd.com
    Changed at Friday, 12-Oct-18 09:11:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed8c927801fdf271cff29cb95a46546cef0a9239

    Comments

    [jumbo] fixup after recent headless network service work
    
    Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1263566
    which introduced a namespace clash between ::network and ::headless::network.
    
    Also, rename one of two kProductName's.
    
    TBR=caseq@chromium.org
    
    Bug: 838291,792676
    Change-Id: Ie1fc9ab2096a09651ba2dd45aa262ab30bfd3efc
    Reviewed-on: https://chromium-review.googlesource.com/c/1277992
    Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
    Reviewed-by: Daniel Bratell <bratell@opera.com>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599150}

    Changed files

    • headless/lib/browser/headless_request_context_manager.cc
    • headless/public/headless_browser.cc
  20. Stop observing prefs in MainController on Shutdown

    Changed by Olivier Robin - olivierrobinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:04:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3

    Comments

    Stop observing prefs in MainController on Shutdown
    
    Bug: 893486
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Iba70383fe0993c7c921a118197197497c1d42572
    Reviewed-on: https://chromium-review.googlesource.com/c/1270899
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599149}

    Changed files

    • ios/chrome/app/main_controller.mm
  21. [blink] Control ScriptStreamer with ScriptResource

    Changed by Leszek Swirski - leszeksohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:03:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bd9163502462762e58d8010577dbf36aeef6c13

    Comments

    [blink] Control ScriptStreamer with ScriptResource
    
    Move the ScriptStreamer control logic from ClassicPendingScript to
    ScriptResource. In the future, this will allow us to start streaming
    a ScriptResource before the ClassicPendingScript is available, e.g on
    preload.
    
    The ClassicPendingScript now only sends one "finished" callback, from
    ScriptResource. This callback is either when the streaming completes,
    or when there is no streaming and the ClassicPendingScript has told
    the ScriptResource that it doesn't intend to start streaming. In the
    long run, we want all scripts to go through the streaming interface,
    and we want ScriptResource to control when streaming starts, so the
    "no more streaming" call will disappear -- however it is necessary to
    maintain the current behaviour, and be able to control it with a
    runtime flag.
    
    Bug: chromium:865098
    Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599148}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  22. Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 08:52:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae1d881f2c19438f9bf1efad82eaaaa11980b30f

    Comments

    Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/a54daf162fac..28d200c24624
    
    
    git log a54daf162fac..28d200c24624 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 37b6d53f02..d47784f23e (598967:599082)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@28d200c24624
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I6547afd3d833e047bb877b0bece2206b5c8661ec
    Reviewed-on: https://chromium-review.googlesource.com/c/1278304
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599147}

    Changed files

    • DEPS
  23. Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:49:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 30958ae060dbfee80d985b84caa9e3c5f4d9c4cc

    Comments

    Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.
    
    TBR=sky@chromium.org
    
    Bug: 828999
    Change-Id: I46514f21581ab6d30e1c4b38719b66e43b075f42
    Reviewed-on: https://chromium-review.googlesource.com/c/1278129
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599146}

    Changed files

    • chrome/browser/browser_process_platform_part_chromeos.cc
    • chrome/browser/browser_process_platform_part_chromeos.h
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc