Home | Search | chromium - Builders
Login

Builder ios-simulator-xcode-clang Build 54555 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision90520e430b08a292bd878117370d0a7e68eb38bc
Got Revision90520e430b08a292bd878117370d0a7e68eb38bc

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries
    • - no logs -

Build Properties:

NameValueSource

Blamelist:

  1. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  2. Colin Blundell (blundellohnoyoudont@chromium.org)
  3. Jun Cai (juncaiohnoyoudont@chromium.org)
  4. Etienne Pierre-doray (etiennepohnoyoudont@chromium.org)
  5. Kim Paulhamus (kpaulhamusohnoyoudont@chromium.org)
  6. Eugene But (eugenebutohnoyoudont@google.com)

Timing:

Create Thursday, 12-Jul-18 16:58:19 UTC
Start Thursday, 12-Jul-18 16:58:23 UTC
End Thursday, 12-Jul-18 17:09:31 UTC
Pending 4 secs
Execution 11 mins 7 secs

All Changes:

  1. [unified-consent] Add unity logic to OneClickSigninSyncStarter

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:55:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90520e430b08a292bd878117370d0a7e68eb38bc

    Comments

    [unified-consent] Add unity logic to OneClickSigninSyncStarter

All unified consent services are enabled when the unified
consent is given through the OneClickSigninSyncStarter.

Bug: 862202
Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
Reviewed-on: https://chromium-review.googlesource.com/1135001
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574604}

    Changed files

    • chrome/browser/ui/sync/one_click_signin_sync_starter.cc
    • chrome/browser/ui/sync/one_click_signin_sync_starter.h

  2. Revert "Have Device Service observe MessageLoop destruction"

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1

    Comments

    Revert "Have Device Service observe MessageLoop destruction"

This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.

Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which will mean doing the plumbing that the below CL was looking to avoid. This is all sad-making, but c'est la vie.

Bug: 856771, 794105

Original change's description:
> Have Device Service observe MessageLoop destruction
>
> The Device Service needs to clean up parts of its internal state as part
> of browser shutdown. However, it also needs to run on the UI thread,
> and embedded services that run on the UI thread are not guaranteed to
> be destroyed as part of browser shutdown (tasks to destroy these
> services are posted from the IO thread by
> ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
> typically shut down before these posted tasks are run).
>
> To solve this issue we discussed adding plumbing wherein embedded
> services could inform //content that they wanted to be notified when
> shutdown was occurring on the main thread. However, on investigation
> this plumbing would be painful to implement: it is only
> EmbeddedInstanceManager that has direct information of these service
> instances, and that object lives far away from //content's
> ServiceManagerContext, the object that knows when shutdown is occurring
> on the main thread.
>
> This CL takes an alternative approach of having the Device Service
> implementation observe the destruction of its MessageLoop. I have
> verified that the observation is triggered on shutdown of Chrome.
>
> Bug: 794105
> Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
> Reviewed-on: https://chromium-review.googlesource.com/1099245
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567260}

TBR=rockot@chromium.org,blundell@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 794105
Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
Reviewed-on: https://chromium-review.googlesource.com/1134887
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h

  3. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3aba7f968ecb147e59a5460bd168e6085425848

    Comments

    Network Service: Document how adding/removing http headers for web content requests are implemented

This is a follow-up CL per comments at:
https://chromium-review.googlesource.com/c/chromium/src/+/1120955

This CL adds comments to //components/variations/variations_http_header_provider.cc
to document how adding/removing http headers for web content requests are
implemented differently when Network Service is enabled or not enabled.

Bug: 841309
Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
Reviewed-on: https://chromium-review.googlesource.com/1134408
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc

  4. [Autofill]: Create a policy flag for AutofillProfileEnabled.

    Changed by Etienne Pierre-doray - etiennepohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:50:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b27097af312f3f4a4ee22bf0ea2c65239de03ff

    Comments

    [Autofill]: Create a policy flag for AutofillProfileEnabled.

AutofillProfileEnabled was added as a preference setting in 1127344.
This CL creates a policy flag for AutofillProfileEnabled that can
overwrite the user preference.

Bug: 860526
Change-Id: I5d4848c26a53cf163fc4557d9b2da5f597bd98cf
Reviewed-on: https://chromium-review.googlesource.com/1127463
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574601}

    Changed files

    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/test/data/policy/policy_test_cases.json
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_profile_policy_handler.cc
    • components/autofill/core/browser/autofill_profile_policy_handler.h
    • components/autofill/core/browser/autofill_profile_policy_handler_unittest.cc
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml

  5. Mark window-focus-self as flaky on Win10

    Changed by Kim Paulhamus - kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:49:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7be9cc2e39f872aeb8e03afb7d0aabf92ffde03

    Comments

    Mark window-focus-self as flaky on Win10

Tbr: tkent@chromium.org
Bug: 863067
Change-Id: I9f043eec8363dbb26ccaa8d901321e0d579f1a4f
Reviewed-on: https://chromium-review.googlesource.com/1135433
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574600}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations

  6. Add testDownloadWhileBrowsing EG test.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:48:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cce6875386037980e3245c630a9b9bac926f91e

    Comments

    Add testDownloadWhileBrowsing EG test.

After tapping Download this test opens a separate tabs and loads the URL
there. Then closes the tab and waits for the download completion.

Bug: 854232
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id05c9344d1da80a57b6c7cc663b2b8a835f18e82
Reviewed-on: https://chromium-review.googlesource.com/1111916
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574599}

    Changed files

    • ios/chrome/browser/ui/download/BUILD.gn
    • ios/chrome/browser/ui/download/download_manager_egtest.mm
    • ios/chrome/test/BUILD.gn
    • ios/chrome/test/scoped_eg_synchronization_disabler.h