Home | Search | chromium - Builders
Login

Builder ios-simulator-full-configs Build 8020 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisione233c1d178562ac6171d190f1e4d9ec9a94ac11e
Got Revisione233c1d178562ac6171d190f1e4d9ec9a94ac11e

Execution:

Steps and Logfiles:

Show:
  1. ( 223 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 605 ms ) remove .cipd
  3. ( 1 mins 34 secs ) bot_update
    [129GB/232GB used (55%)]
  4. ( 358 ms ) read build config
  5. ( 0 ) ensure_goma
  6. ( 0 ) ensure xcode
    Ensuring Xcode version 9c40b in /b/s/w/ir/cache/xcode_ios_9c40b.app
  7. ( 19 secs ) gclient runhooks
  8. ( 8 mins 15 secs ) compile
  9. ( 0 ) isolate
  10. ( 564 ms ) isolate.generate 0_0.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPhone 6s Plus iOS 10.3) shard 0
  11. ( 565 ms ) isolate.generate 1_0.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPhone 6s Plus iOS 10.3) shard 0
  12. ( 551 ms ) isolate.generate 2_0.isolate.gen.json
    ios_chrome_web_egtests (iPhone 6s Plus iOS 10.3) shard 0
  13. ( 569 ms ) isolate.generate 2_1.isolate.gen.json
    ios_chrome_web_egtests (iPhone 6s Plus iOS 10.3) shard 1
  14. ( 561 ms ) isolate.generate 3_0.isolate.gen.json
    ios_chrome_settings_egtests (iPhone 6s Plus iOS 10.3) shard 0
  15. ( 559 ms ) isolate.generate 4_0.isolate.gen.json
    ios_chrome_payments_egtests (iPhone 6s Plus iOS 10.3) shard 0
  16. ( 569 ms ) isolate.generate 4_1.isolate.gen.json
    ios_chrome_payments_egtests (iPhone 6s Plus iOS 10.3) shard 1
  17. ( 566 ms ) isolate.generate 5_0.isolate.gen.json
    ios_chrome_reading_list_egtests (iPhone 6s Plus iOS 10.3) shard 0
  18. ( 556 ms ) isolate.generate 6_0.isolate.gen.json
    ios_showcase_egtests (iPhone 6s Plus iOS 10.3) shard 0
  19. ( 552 ms ) isolate.generate 7.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPhone 7 iOS 11.2)
  20. ( 557 ms ) isolate.generate 8.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPhone 7 iOS 11.2)
  21. ( 559 ms ) isolate.generate 9.isolate.gen.json
    ios_chrome_web_egtests (iPhone 7 iOS 11.2)
  22. ( 561 ms ) isolate.generate 10.isolate.gen.json
    ios_chrome_settings_egtests (iPhone 7 iOS 11.2)
  23. ( 566 ms ) isolate.generate 11.isolate.gen.json
    ios_chrome_payments_egtests (iPhone 7 iOS 11.2)
  24. ( 583 ms ) isolate.generate 12.isolate.gen.json
    ios_chrome_reading_list_egtests (iPhone 7 iOS 11.2)
  25. ( 571 ms ) isolate.generate 13.isolate.gen.json
    ios_showcase_egtests (iPhone 7 iOS 11.2)
  26. ( 573 ms ) isolate.generate 14.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPad Air 2 iOS 11.2)
  27. ( 567 ms ) isolate.generate 15.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPad Air 2 iOS 11.2)
  28. ( 564 ms ) isolate.generate 16.isolate.gen.json
    ios_chrome_web_egtests (iPad Air 2 iOS 11.2)
  29. ( 553 ms ) isolate.generate 17.isolate.gen.json
    ios_chrome_settings_egtests (iPad Air 2 iOS 11.2)
  30. ( 568 ms ) isolate.generate 18.isolate.gen.json
    ios_chrome_payments_egtests (iPad Air 2 iOS 11.2)
  31. ( 555 ms ) isolate.generate 19.isolate.gen.json
    ios_chrome_reading_list_egtests (iPad Air 2 iOS 11.2)
  32. ( 574 ms ) isolate.generate 20.isolate.gen.json
    ios_showcase_egtests (iPad Air 2 iOS 11.2)
  33. ( 571 ms ) isolate.generate 21_0.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPad Air 2 iOS 10.3) shard 0
  34. ( 566 ms ) isolate.generate 22_0.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPad Air 2 iOS 10.3) shard 0
  35. ( 568 ms ) isolate.generate 23_0.isolate.gen.json
    ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 0
  36. ( 569 ms ) isolate.generate 23_1.isolate.gen.json
    ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 1
  37. ( 598 ms ) isolate.generate 24_0.isolate.gen.json
    ios_chrome_settings_egtests (iPad Air 2 iOS 10.3) shard 0
  38. ( 604 ms ) isolate.generate 25_0.isolate.gen.json
    ios_chrome_payments_egtests (iPad Air 2 iOS 10.3) shard 0
  39. ( 592 ms ) isolate.generate 25_1.isolate.gen.json
    ios_chrome_payments_egtests (iPad Air 2 iOS 10.3) shard 1
  40. ( 576 ms ) isolate.generate 26_0.isolate.gen.json
    ios_chrome_reading_list_egtests (iPad Air 2 iOS 10.3) shard 0
  41. ( 585 ms ) isolate.generate 27_0.isolate.gen.json
    ios_showcase_egtests (iPad Air 2 iOS 10.3) shard 0
  42. ( 599 ms ) isolate.generate 28.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPhone X iOS 11.2)
  43. ( 623 ms ) isolate.generate 29.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPhone X iOS 11.2)
  44. ( 612 ms ) isolate.generate 30.isolate.gen.json
    ios_chrome_web_egtests (iPhone X iOS 11.2)
  45. ( 590 ms ) isolate.generate 31.isolate.gen.json
    ios_chrome_settings_egtests (iPhone X iOS 11.2)
  46. ( 623 ms ) isolate.generate 32.isolate.gen.json
    ios_chrome_payments_egtests (iPhone X iOS 11.2)
  47. ( 621 ms ) isolate.generate 33.isolate.gen.json
    ios_chrome_reading_list_egtests (iPhone X iOS 11.2)
  48. ( 592 ms ) isolate.generate 34.isolate.gen.json
    ios_showcase_egtests (iPhone X iOS 11.2)
  49. ( 580 ms ) isolate.generate 35_0.isolate.gen.json
    ios_chrome_integration_egtests (iPad Air 2 iOS 10.3) shard 0
  50. ( 578 ms ) isolate.generate 35_1.isolate.gen.json
    ios_chrome_integration_egtests (iPad Air 2 iOS 10.3) shard 1
  51. ( 583 ms ) isolate.generate 36_0.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 0
  52. ( 644 ms ) isolate.generate 36_1.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 1
  53. ( 574 ms ) isolate.generate 36_2.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 2
  54. ( 577 ms ) isolate.generate 36_3.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 3
  55. ( 635 ms ) isolate.generate 37_0.isolate.gen.json
    ios_web_shell_egtests (iPad Air 2 iOS 10.3) shard 0
  56. ( 595 ms ) isolate.generate 38.isolate.gen.json
    ios_chrome_integration_egtests (iPhone X iOS 11.2)
  57. ( 627 ms ) isolate.generate 39_0.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 0
  58. ( 582 ms ) isolate.generate 39_1.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 1
  59. ( 577 ms ) isolate.generate 39_2.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 2
  60. ( 578 ms ) isolate.generate 39_3.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 3
  61. ( 576 ms ) isolate.generate 40.isolate.gen.json
    ios_web_shell_egtests (iPhone X iOS 11.2)
  62. ( 1 mins 21 secs ) isolate.archive
  63. ( 0 ) trigger
  64. ( 1 mins 24 secs ) ios_chrome_adaptive_toolbar_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:03:32.299810
  65. ( 3 mins 29 secs ) ios_chrome_bookmarks_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:58.222050
  66. ( 2 secs ) ios_chrome_web_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:59.049010
  67. ( 3 mins 8 secs ) ios_chrome_web_egtests (iPhone 6s Plus iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:10:09.867740
  68. ( 6 mins 56 secs ) ios_chrome_settings_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:16:56.068260
  69. ( 2 secs ) ios_chrome_payments_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:50.921630
  70. ( 2 secs ) ios_chrome_payments_egtests (iPhone 6s Plus iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:06:21.451320
  71. ( 2 secs ) ios_chrome_reading_list_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:05:44.586340
  72. ( 2 secs ) ios_showcase_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:14.230800
  73. ( 2 secs ) ios_chrome_adaptive_toolbar_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:15.988590
  74. ( 5 mins 23 secs ) ios_chrome_bookmarks_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:22:32.573800
  75. ( 2 secs ) ios_chrome_web_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:16:12.781300
  76. ( 2 secs ) ios_chrome_settings_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:15:34.980780
  77. ( 2 secs ) ios_chrome_payments_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:11:40.459580
  78. ( 2 secs ) ios_chrome_reading_list_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:05:24.085290
  79. ( 2 secs ) ios_showcase_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:04:10.896190
  80. ( 2 secs ) ios_chrome_adaptive_toolbar_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:42.073660
  81. ( 2 secs ) ios_chrome_bookmarks_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:04:17.983880
  82. ( 2 secs ) ios_chrome_web_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:14:28.517000
  83. ( 2 secs ) ios_chrome_settings_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:17:17.601310
  84. ( 3 secs ) ios_chrome_payments_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:08:20.694580
  85. ( 2 secs ) ios_chrome_reading_list_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:06:03.410920
  86. ( 2 secs ) ios_showcase_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:04:00.323060
  87. ( 2 secs ) ios_chrome_adaptive_toolbar_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:03:20.933640
  88. ( 2 secs ) ios_chrome_bookmarks_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:25.042160
  89. ( 2 secs ) ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:06.064000
  90. ( 2 secs ) ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:08:36.216900
  91. ( 2 secs ) ios_chrome_settings_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:16:51.790060
  92. ( 2 secs ) ios_chrome_payments_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:05:49.173320
  93. ( 2 secs ) ios_chrome_payments_egtests (iPad Air 2 iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:06:15.461720
  94. ( 2 secs ) ios_chrome_reading_list_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:05:45.005250
  95. ( 2 secs ) ios_showcase_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:16.899210
  96. ( 2 secs ) ios_chrome_adaptive_toolbar_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:22.966890
  97. ( 2 secs ) ios_chrome_bookmarks_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:04:46.122790
  98. ( 2 secs ) ios_chrome_web_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:15:37.268450
  99. ( 2 secs ) ios_chrome_settings_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:18:14.870040
  100. ( 2 secs ) ios_chrome_payments_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:11:42.054280
  101. ( 2 secs ) ios_chrome_reading_list_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:06:24.022310
  102. ( 2 secs ) ios_showcase_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:06:22.385780
  103. ( 2 secs ) ios_chrome_integration_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:18.987250
  104. ( 2 secs ) ios_chrome_integration_egtests (iPad Air 2 iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:05:48.174830
  105. ( 2 secs ) ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:08:37.421780
  106. ( 2 secs ) ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:08:00.703910
  107. ( 2 secs ) ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 2
    Run on OS: 'Mac'
    Shard duration: 0:12:47.036170
  108. ( 2 secs ) ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 3
    Run on OS: 'Mac'
    Shard duration: 0:09:22.096930
  109. ( 2 secs ) ios_web_shell_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:01:45.904000
  110. ( 2 secs ) ios_chrome_integration_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:11:35.210050
  111. ( 2 secs ) ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:09:31.908170
  112. ( 2 secs ) ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:09:42.846960
  113. ( 2 secs ) ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 2
    Run on OS: 'Mac'
    Shard duration: 0:12:53.985070
  114. ( 2 secs ) ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 3
    Run on OS: 'Mac'
    Shard duration: 0:09:27.687110
  115. ( 2 secs ) ios_web_shell_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:02:16.656940
  116. ( 371 ms ) Tests statistics
     
    Stats
    Total shards: 52
    Total runtime: 6:56:52.551910
     
  117. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm124-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531427571670550, "id": "8941175518566737248", "project": "chromium", "tags": ["builder:ios-simulator-full-configs", "buildset:commit/git/e233c1d178562ac6171d190f1e4d9ec9a94ac11e", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e233c1d178562ac6171d190f1e4d9ec9a94ac11e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106605580736071808", "scheduler_job_id:chromium/ios-simulator-full-configs", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-simulator-full-configs" setup_build
buildnumber 8020 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "e233c1d178562ac6171d190f1e4d9ec9a94ac11e" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "e233c1d178562ac6171d190f1e4d9ec9a94ac11e" bot_update
got_revision_cp "refs/heads/master@{#574705}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23955}" bot_update

Blamelist:

  1. Will Harris (wfhohnoyoudont@chromium.org)
  2. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  3. Tibor Goldschwendt (tiborgohnoyoudont@chromium.org)
  4. Yiming Zhou (uwyimingohnoyoudont@google.com)
  5. Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
  6. Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
  7. erikchen (erikchenohnoyoudont@chromium.org)
  8. Moe Ahmadi (mahmadiohnoyoudont@chromium.org)
  9. Martin Kreichgauer (martinkrohnoyoudont@google.com)
  10. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  11. Nick Burris (nburrisohnoyoudont@google.com)
  12. Greg Kraynov (kraynovohnoyoudont@chromium.org)
  13. spqchan (spqchanohnoyoudont@chromium.org)
  14. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  15. Andrey Lushnikov (lushnikovohnoyoudont@chromium.org)
  16. Thomas Guilbert (tguilbertohnoyoudont@chromium.org)
  17. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  18. Amirhossein Simjour (asimjourohnoyoudont@chromium.org)
  19. Ryan Daum (rdaumohnoyoudont@chromium.org)
  20. Danyao Wang (danyaoohnoyoudont@chromium.org)
  21. Tarun Bansal (tbansalohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 20:32:51 UTC
Start Thursday, 12-Jul-18 20:32:53 UTC
End Thursday, 12-Jul-18 21:13:25 UTC
Pending 2 secs
Execution 40 mins 32 secs

All Changes:

  1. Update Flash plugin metadata versions to latest version.

    Changed by Will Harris - wfhohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:31:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e233c1d178562ac6171d190f1e4d9ec9a94ac11e

    Comments

    Update Flash plugin metadata versions to latest version.
    
    https://helpx.adobe.com/security/products/flash-player/apsb18-24.html
    
    BUG=412078
    TBR=jschuh@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iecc32fe539d6d16418086f9d8b4e44fde19bdd69
    Reviewed-on: https://chromium-review.googlesource.com/1135713
    Commit-Queue: Will Harris <wfh@chromium.org>
    Reviewed-by: Will Harris <wfh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574705}

    Changed files

    • chrome/browser/resources/plugin_metadata/plugins_linux.json
    • chrome/browser/resources/plugin_metadata/plugins_mac.json
    • chrome/browser/resources/plugin_metadata/plugins_win.json
  2. Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:29:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e40e820481f52c0cc29b1841542b4e24465909bd

    Comments

    Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32
    
    Using wpt-import in Chromium a7edd65b959ed3edbb808bd0bd2c914e5a92cfff.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21190
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    jsbell@chromium.org, mek@chromium.org:
      external/wpt/FileAPI
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I99e9ecbe3e626ec461f4663c7d48a6896f6a9616
    Reviewed-on: https://chromium-review.googlesource.com/1135585
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574704}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.html
    • third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.worker.js
  3. Android: Do not generate R.java from android_apk AndroidManifest.xml

    Changed by Tibor Goldschwendt - tiborgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:29:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01020f3bca281b6de9bd9deacbe849cbc1255cfa

    Comments

    Android: Do not generate R.java from android_apk AndroidManifest.xml
    
    In order to implement synchronized proguarding we cannot have multiple
    R class with the same package. Thus, prevent creation of R files with
    manifest's package when creating APKs.
    
    Bug: 862696
    Change-Id: I51253c0434f18e19ea627710beaa85b8690b175c
    Reviewed-on: https://chromium-review.googlesource.com/1134414
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574703}

    Changed files

    • build/android/gyp/compile_resources.py
    • build/android/gyp/util/resource_utils.py
  4. Record when a user presses Enter on a web page.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:28:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb5a18d97233f6a11c4606fa3b085d2b7ba0ff11

    Comments

    Record when a user presses Enter on a web page.
    
    This change adds a feature that allows the Action Recorder Extension to
    detect when a user presses the Enter key on a page, and records this
    action. Pressing the Enter key is a common action that a user invokes to
    submit a form.
    
    Bug: 855284
    Change-Id: Ia0ec4ab99683266f09a422a4f7ae24fe52eb0b0b
    Reviewed-on: https://chromium-review.googlesource.com/1135523
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574702}

    Changed files

    • components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/content/panel.js
  5. Reset listener properties after provisional load

    Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:25:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8afd07cc1159e077da359175edefd419a090fb7d

    Comments

    Reset listener properties after provisional load
    
    When provisional load is committed in FrameLoader and the corresponding
    frame is a LocalRoot, the EventListenerProperties are reset to none for
    touch and wheel listeners. This update is then propagate through render
    widget and LayterTreeHost to the browser and the CC correspondingly.
    
    However, if the local root is provisional the call is dropped in
    ChromeClientImpl. This would include all cross-process navigations which
    end up in a provisional frame.
    
    This change will make sure the initial updates for
    EventListenerProperties for a local root are sent after
    WebLocalFrameClient is notified about committing provisional load.
    
    Bug: 850994
    Change-Id: I686ab51277bf675d93bd744d6d0208977ac06b5c
    Reviewed-on: https://chromium-review.googlesource.com/1126329
    Commit-Queue: Ehsan Karamad <ekaramad@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574701}

    Changed files

    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/render_widget_host_browsertest.cc
    • third_party/blink/renderer/core/exported/local_frame_client_impl.cc
    • third_party/blink/renderer/core/loader/frame_loader.cc
  6. Migrate PrivetTrafficDetector to use NetworkConnectionTracker.

    Changed by Robbie McElrath - rmcelrathohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:20:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b78521765f33993e81dfba771127fe9d5eb4add

    Comments

    Migrate PrivetTrafficDetector to use NetworkConnectionTracker.
    
    This migrates PrivetTrafficDetector from using
    net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
    works with the network service enabled.
    
    Bug: 859134
    Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581
    Reviewed-on: https://chromium-review.googlesource.com/1123681
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574700}

    Changed files

    • chrome/browser/printing/cloud_print/privet_traffic_detector.cc
    • chrome/browser/printing/cloud_print/privet_traffic_detector.h
  7. Remove assertion from DetachToOwnWindow on macOS 10.10.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:16:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b20bb048913985eae71b480db2a2017173ef73a2

    Comments

    Remove assertion from DetachToOwnWindow on macOS 10.10.
    
    On macOS 10.10, AppKit appears to use the test's generated events to
    asynchronously reactivate the first window. There's no way to tell when this
    asynchronous reactivation will happen, so just avoid checking the assertion in
    the test. This problem appears constrained to how we generate test events, and
    not to the actual behavior of Chrome.
    
    Bug: 862859
    Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063
    Reviewed-on: https://chromium-review.googlesource.com/1135305
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574699}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
  8. Revert "[AF][IOS] Scan page for form changes when a field is focused"

    Changed by Moe Ahmadi - mahmadiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b937d53836386e51532fbe870938b33ce0455ed

    Comments

    Revert "[AF][IOS] Scan page for form changes when a field is focused"
    
    This reverts commit 77318515062e22c6dbcb5b4ae8c6daa4ef70d5b9.
    
    Reason for revert:
    This change caused a regression (crbug.com/860225). The cause of the regression is that when user focuses a field in order to edit it, Autofill::OnFormsSeen is called which in turn updates the cached form with the new user entered values. Once submitted, form values are discarded as they're thought to be the initial form values on page load. In its current implementation Autofill::OnFormsSeen is only intended to be called on page load.
    
    Original change's description:
    > [AF][IOS] Scan page for form changes when a field is focused
    >
    > This CL fixes a regression caused by crrev.com/c/1012979. Previously,
    > AutofillAgent would scan the whole page on form activities due to the
    > possiblity of Autofill having been enabled after page load.
    > crrev.com/c/1012979 replaced that logic in favor of observing the Pref
    > directly. This has a side effect where previously hidden fields can go
    > unnoticed by AutofillManager. This CL fixes that regression by scanning the
    > page when a field is focused. All fields receive focuse before their value
    > is set by Autofill, therefore, AutofillManager can get notified of
    > previously hidden fields.
    >
    > Bug: 855696
    > Change-Id: I175bf90e12d1ca356b746e6347943a295063c288
    > Reviewed-on: https://chromium-review.googlesource.com/1112493
    > Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    > Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#570713}
    
    TBR=olivierrobin@chromium.org,mahmadi@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 855696, 860225
    Change-Id: Icc39e67e6d502d75451dbec83d6271255639ee4c
    Reviewed-on: https://chromium-review.googlesource.com/1135671
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574698}

    Changed files

    • components/autofill/ios/browser/autofill_agent.mm
  9. device/fido/mac: integrate with browsing data deletion

    Changed by Martin Kreichgauer - martinkrohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:13:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d54b58e5b08b96664080795a01e0bd2373952e6e

    Comments

    device/fido/mac: integrate with browsing data deletion
    
    This updates browsing data deletion for DATA_TYPE_PASSWORDS to call
    device::fido::mac::DeleteWebAuthnCredentials, which deletes credentials
    created by the macOS platform authenticator from the OS keychain.
    
    Also combine the two Touch ID specific configuration methods in
    {Chrome,}AuthenticatorRequestDelegate and introduce a static variant for
    Chrome.
    
    Bug: 678128
    Change-Id: I0034e0815da068fb27c1ea60cad95f958956838e
    Reviewed-on: https://chromium-review.googlesource.com/1125177
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574697}

    Changed files

    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.h
    • chrome/browser/webauthn/chrome_authenticator_request_delegate_unittest.cc
    • content/browser/webauth/authenticator_impl.cc
    • content/public/browser/authenticator_request_client_delegate.cc
    • content/public/browser/authenticator_request_client_delegate.h
    • device/fido/mac/authenticator.h
  10. Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 20:12:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 460febcbc6e56f2355493a4f43188b08753c2dc6

    Comments

    Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)
    
    https://webrtc.googlesource.com/src.git/+log/798ee75d2365..895617fa9bc3
    
    
    git log 798ee75d2365..895617fa9bc3 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 buildbot@webrtc.org Roll chromium_revision efbdada3f7..f7c234b027 (574489:574598)
    2018-07-12 magjed@webrtc.org Android: Add helper functions for comparing H264 codecs
    2018-07-12 saza@webrtc.org Remove useless import of arm.gni
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@895617fa9bc3
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I07750ee2f3c028532fb0dfbfa0386eeeb119c8f8
    Reviewed-on: https://chromium-review.googlesource.com/1135612
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574696}

    Changed files

    • DEPS
  11. Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:11:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda02794921ad4eca0b4c5d15c21bc0461e73fa

    Comments

    Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results
    
    Chrome runs into a fatal error when the cleaner detects unwanted
    software. This is because ChromeCleanerScannerResults is created in the
    IO thread, and ProfileManager::GetLastUsedProfile requires the UI
    thread. The tests passed because they run a test browser process.
    
    - Extract extension name fetching to a separate function.
    - Call this function in tests so they're not affected.
    - Follow-up CL: Call this function once the scanner results are on the
    UI thread, before they're sent to the web UI.
    
    Bug: 853339
    Change-Id: I9cc2425f7b196e923a22b2afd1e8eee7fca61f5b
    Reviewed-on: https://chromium-review.googlesource.com/1135194
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574695}

    Changed files

    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.h
  12. Remove components/viz/test dependency from blink platform.

    Changed by Greg Kraynov - kraynovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:07:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a7df13b2932f8f83559de4c263c972e08f9301b

    Comments

    Remove components/viz/test dependency from blink platform.
    
    cc::OrderedSimpleTestTaskRunner isn't used there anymore.
    
    Bug: 841735
    Change-Id: I88a5bfa2ebaf01a08943396ce20f63c483a19b3a
    Reviewed-on: https://chromium-review.googlesource.com/1133177
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Greg Kraynov <kraynov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574694}

    Changed files

    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/child/DEPS
    • third_party/blink/renderer/platform/scheduler/common/DEPS
    • third_party/blink/renderer/platform/scheduler/main_thread/DEPS
    • third_party/blink/renderer/platform/scheduler/renderer/DEPS
    • third_party/blink/renderer/platform/scheduler/worker/DEPS
    • third_party/blink/renderer/platform/testing/DEPS
  13. [Mac] Refactor BrowserWindowTouchBarMac

    Changed by spqchan - spqchanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:05:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e95b7292bae44c8e6fb9af5801f102ae28587d6c

    Comments

    [Mac] Refactor BrowserWindowTouchBarMac
    
    Separate BrowserWindowTouchBarMac into two classes:
    BrowserWindowDefaultTouchBar and
    BrowserWindowTouchBarController.
    
    BrowserWindowTouchBarController determines what
    touch bar should be used for browser window.
    BrowserWindowDefaultTouchBar creates a default
    touch bar for the browser.
    
    These changes are split from a bigger change to
    hook up touch bar support for web textfield in
    MacViews:
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1132597
    
    Bug: 856391
    Change-Id: I9be31c65bd0acc2ec4d39b5e2f6b06fc30e36bf7
    Reviewed-on: https://chromium-review.googlesource.com/1133705
    Commit-Queue: Sarah Chan <spqchan@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574693}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/browser_window_touch_bar_mac.h
    • chrome/browser/ui/cocoa/browser_window_controller.h
    • chrome/browser/ui/cocoa/browser_window_controller.mm
    • chrome/browser/ui/cocoa/framed_browser_window.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar_unittest.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller_browsertest.mm
    • chrome/browser/ui/views/frame/browser_frame_mac.mm
    • chrome/test/BUILD.gn
  14. milo: Add link to chromiumos tryserver to chromium's console.

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6678ca5e07d42a16c0e63b123543672ab94c3c29

    Comments

    milo: Add link to chromiumos tryserver to chromium's console.
    
    And alphabetize the list.
    
    R=hinoka
    
    Change-Id: I28d7c354c153f848fae7098e57b67445345cb850
    Reviewed-on: https://chromium-review.googlesource.com/1135691
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574692}

    Changed files

    • infra/config/global/luci-milo.cfg
  15. Make content::PermissionManager a delegate of PermissionController

    Changed by Andrey Lushnikov - lushnikovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ebff0440cc1ada42a20446c0f6d9ddf0619f64df

    Comments

    Make content::PermissionManager a delegate of PermissionController
    
    One-pager describing this refactoring: https://goo.gl/24gkCb
    
    Today, `content/` layer provides `permission_manager.h` interface that
    is supposed to be implemented by embedders and simultaneously used
    as API in `content/` layer. This leaves us with no place in content/ layer
    where we can put DevTools instrumentation.
    
    This patch separates content API from embedder interface. With this
    patch, `content/` layer provides 2 interfaces:
    - content::PermissionController - content-level API to manage permissions
    - content::PermissionManager - interface to be implemented by
    embedders. This is a delegate for content::PermissionController.
    
    This design enables DevTools to handle and override content permissions through
    DevTools protocol. The functionality will be encapsulated in
    PermissionController class.
    
    There's exactly one PermissionController for each BrowserContext.
    If embedder doesn't implement PermissionManager, then
    PermissionController rejects all permission requests.
    
    In a follow-up:
    - rename `content::PermissionManager` into `content::PermissionControllerDelegate`.
    - rename `BrowserContext::GetPermissionManager()` into `BrowserContext::GetPermissionControllerDelegate()`.
    - rename `TestBrowserContext::SetPermissionManager()` into `TestBrowserContext::SetPermissionControllerDelegate()`.
    
    R=dgozman
    TBR=sdefresne, tobiasjs, slan, thakis
    BUG=631464
    
    Change-Id: I5f6f1ea5b28e284c462a5055d9b072f12f30ce19
    Reviewed-on: https://chromium-review.googlesource.com/1111340
    Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574691}

    Changed files

    • android_webview/browser/aw_permission_manager.cc
    • chrome/browser/net/reporting_permissions_checker.cc
    • chrome/browser/notifications/platform_notification_service_impl.cc
    • chrome/browser/permissions/permission_manager.cc
    • chromecast/browser/cast_permission_manager.cc
    • components/domain_reliability/service.cc
    • components/domain_reliability/service_unittest.cc
    • components/payments/content/installable_payment_app_crawler.cc
    • content/browser/BUILD.gn
    • content/browser/background_sync/background_sync_manager.cc
    • content/browser/browser_context.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.h
    • content/browser/geolocation/geolocation_service_impl.cc
    • content/browser/geolocation/geolocation_service_impl.h
    • content/browser/geolocation/geolocation_service_impl_unittest.cc
    • content/browser/notifications/blink_notification_service_impl.cc
    • content/browser/payments/payment_app_provider_impl.cc
    • content/browser/permissions/permission_controller_impl.cc
    • content/browser/permissions/permission_controller_impl.h
    • content/browser/permissions/permission_service_context.cc
    • content/browser/permissions/permission_service_impl.cc
    • content/browser/push_messaging/push_messaging_manager.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/browser_context.h
    • content/public/browser/permission_controller.h
    • content/public/browser/permission_manager.h
    • content/public/test/mock_permission_manager.cc
    • content/shell/browser/layout_test/layout_test_permission_manager.cc
    • content/shell/browser/shell_permission_manager.cc
    • headless/lib/browser/headless_permission_manager.cc
  16. Move content::MediaController to media/base

    Changed by Thomas Guilbert - tguilbertohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2784a2c6630a8de538a7b2bf6d993823d321a489

    Comments

    Move content::MediaController to media/base
    
    The MediaController interface and the upcoming MediaStatusObserver do
    not have to live in content/public/browser. The media/base folder and
    the media namespace is a more generic place for them to live, even if
    most of the code that will use them lives in content.
    
    Bug: 820277
    Change-Id: I2f91cd88c6f5238723aae8aeff1c323c02f738d4
    Reviewed-on: https://chromium-review.googlesource.com/1134090
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574690}

    Changed files

    • chrome/browser/media/android/remote/media_controller_bridge.h
    • chrome/browser/media/android/router/media_router_android.cc
    • chrome/browser/media/android/router/media_router_android.h
    • chrome/browser/media/android/router/media_router_android_bridge.cc
    • chrome/browser/media/android/router/media_router_android_bridge.h
    • chrome/browser/media/router/media_router.h
    • chrome/browser/media/router/media_router_base.cc
    • chrome/browser/media/router/media_router_base.h
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
    • content/browser/media/flinging_renderer.cc
    • content/browser/media/flinging_renderer.h
    • content/browser/media/flinging_renderer_unittest.cc
    • content/browser/presentation/presentation_service_impl_unittest.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/presentation_service_delegate.h
    • media/base/BUILD.gn
    • media/base/media_controller.h
  17. Improved performance of AXPosition::operator less than

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1

    Comments

    Improved performance of AXPosition::operator less than
    
    Only move up or down the tree using text equivalent positions (by calling CreateParentPosition and AsLeafTextPosition) when we absolutely need to.
    R=dmazzoni@chromium.org
    
    Tested: VoiceOver on Mac by navigating in Gmail and checking how many times you hear "Busy"
    Change-Id: Id9469e52ef87b8b8a0c6c5fac5325abec415382d
    Bug: 861567
    Reviewed-on: https://chromium-review.googlesource.com/1133334
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574689}

    Changed files

    • ui/accessibility/ax_node_position_unittest.cc
    • ui/accessibility/ax_position.h
  18. VR: fix autofill popup size

    Changed by Amirhossein Simjour - asimjourohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d07f06bb5c43657ce38efc57039e36287eac2a6

    Comments

    VR: fix autofill popup size
    
    Break SetAlertDialogSize into to methods. One to set the relative
    size to the main content, another one to set the absolute size.
    Also added comment to hosted_platform_ui to clarify the size of
    the rectangle in the model.
    
    Bug: 863071
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
    Reviewed-on: https://chromium-review.googlesource.com/1132140
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574688}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/model/hosted_platform_ui.h
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
  19. [chromecast] Support for top-down drag gesture.

    Changed by Ryan Daum - rdaumohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:00:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7281e2b2ea7ce739c6106b6005a2d58a9eedb86a

    Comments

    [chromecast] Support for top-down drag gesture.
    
    Bug: internal b/111304882
    Test: unit test and manual
    Change-Id: Iab32b58098a02eb054faeb94625e312d274cdae1
    Reviewed-on: https://chromium-review.googlesource.com/1135692
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574687}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/browser/cast_gesture_dispatcher_test.cc
  20. [Nav Experiment] Parameterize HistoryStateOperationsTest.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:57:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32bdecc1fac228cf335811bea0f31e2a29153f29

    Comments

    [Nav Experiment] Parameterize HistoryStateOperationsTest.
    
    So both LegacyNavigationManager and WKBasedNavigationManager can be
    tested on trybots.
    
    Fixed test expectation for StateReplacementBackForward to match the
    behavior of WebKit (and Safari on other platforms).
    
    Bug: 862724
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic01dcabf2e6ef6903d8f8ee348798951007660cc
    Reviewed-on: https://chromium-review.googlesource.com/1134472
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574686}

    Changed files

    • ios/web/navigation/history_state_operations_inttest.mm
  21. Network quality servicification of RTT and downlink estimates

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 88c8cc52351f93d11e0bfac3b75ded5b420b131b

    Comments

    Network quality servicification of RTT and downlink estimates
    
    Send the RTT and downlink estimates over the mojo channel
    to the browser process. The RTT and downlink estimates are
    sent over an existing mojo message which carrier the current
    effective connection type estimate.
    
    The mojo message is sent only if there is a significant change
    in the values of either the RTT or the downlink estimate.
    
    In the next CL, I will move the network quality consumers
    in the browser process over to NetworkQualityTracker.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I01bbc7af2e7e3cf41f69e7ac19f8edd9ec59de90
    Bug: 819244
    Reviewed-on: https://chromium-review.googlesource.com/1130233
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574685}

    Changed files

    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • services/network/network_quality_estimator_manager.cc
    • services/network/network_quality_estimator_manager.h
    • services/network/network_quality_estimator_manager_unittest.cc
    • services/network/public/cpp/network_quality_tracker.cc
    • services/network/public/cpp/network_quality_tracker.h
    • services/network/public/cpp/network_quality_tracker_unittest.cc
    • services/network/public/mojom/network_quality_estimator_manager.mojom