Home | Search | chromium - Builders
Login

Builder ios-simulator-full-configs Build 8008 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisionab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2
Got Revisionab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

Execution:

Steps and Logfiles:

Show:
  1. ( 230 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 627 ms ) remove .cipd
  3. ( 1 mins 33 secs ) bot_update
    [130GB/232GB used (56%)]
  4. ( 403 ms ) read build config
  5. ( 0 ) ensure_goma
  6. ( 0 ) ensure xcode
    Ensuring Xcode version 9c40b in /b/s/w/ir/cache/xcode_ios_9c40b.app
  7. ( 19 secs ) gclient runhooks
  8. ( 6 mins 38 secs ) compile
  9. ( 0 ) isolate
  10. ( 583 ms ) isolate.generate 0_0.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPhone 6s Plus iOS 10.3) shard 0
  11. ( 620 ms ) isolate.generate 1_0.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPhone 6s Plus iOS 10.3) shard 0
  12. ( 637 ms ) isolate.generate 2_0.isolate.gen.json
    ios_chrome_web_egtests (iPhone 6s Plus iOS 10.3) shard 0
  13. ( 616 ms ) isolate.generate 2_1.isolate.gen.json
    ios_chrome_web_egtests (iPhone 6s Plus iOS 10.3) shard 1
  14. ( 588 ms ) isolate.generate 3_0.isolate.gen.json
    ios_chrome_settings_egtests (iPhone 6s Plus iOS 10.3) shard 0
  15. ( 575 ms ) isolate.generate 4_0.isolate.gen.json
    ios_chrome_payments_egtests (iPhone 6s Plus iOS 10.3) shard 0
  16. ( 573 ms ) isolate.generate 4_1.isolate.gen.json
    ios_chrome_payments_egtests (iPhone 6s Plus iOS 10.3) shard 1
  17. ( 580 ms ) isolate.generate 5_0.isolate.gen.json
    ios_chrome_reading_list_egtests (iPhone 6s Plus iOS 10.3) shard 0
  18. ( 585 ms ) isolate.generate 6_0.isolate.gen.json
    ios_showcase_egtests (iPhone 6s Plus iOS 10.3) shard 0
  19. ( 593 ms ) isolate.generate 7.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPhone 7 iOS 11.2)
  20. ( 581 ms ) isolate.generate 8.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPhone 7 iOS 11.2)
  21. ( 569 ms ) isolate.generate 9.isolate.gen.json
    ios_chrome_web_egtests (iPhone 7 iOS 11.2)
  22. ( 585 ms ) isolate.generate 10.isolate.gen.json
    ios_chrome_settings_egtests (iPhone 7 iOS 11.2)
  23. ( 589 ms ) isolate.generate 11.isolate.gen.json
    ios_chrome_payments_egtests (iPhone 7 iOS 11.2)
  24. ( 568 ms ) isolate.generate 12.isolate.gen.json
    ios_chrome_reading_list_egtests (iPhone 7 iOS 11.2)
  25. ( 580 ms ) isolate.generate 13.isolate.gen.json
    ios_showcase_egtests (iPhone 7 iOS 11.2)
  26. ( 611 ms ) isolate.generate 14.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPad Air 2 iOS 11.2)
  27. ( 674 ms ) isolate.generate 15.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPad Air 2 iOS 11.2)
  28. ( 585 ms ) isolate.generate 16.isolate.gen.json
    ios_chrome_web_egtests (iPad Air 2 iOS 11.2)
  29. ( 575 ms ) isolate.generate 17.isolate.gen.json
    ios_chrome_settings_egtests (iPad Air 2 iOS 11.2)
  30. ( 587 ms ) isolate.generate 18.isolate.gen.json
    ios_chrome_payments_egtests (iPad Air 2 iOS 11.2)
  31. ( 582 ms ) isolate.generate 19.isolate.gen.json
    ios_chrome_reading_list_egtests (iPad Air 2 iOS 11.2)
  32. ( 584 ms ) isolate.generate 20.isolate.gen.json
    ios_showcase_egtests (iPad Air 2 iOS 11.2)
  33. ( 596 ms ) isolate.generate 21_0.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPad Air 2 iOS 10.3) shard 0
  34. ( 573 ms ) isolate.generate 22_0.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPad Air 2 iOS 10.3) shard 0
  35. ( 617 ms ) isolate.generate 23_0.isolate.gen.json
    ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 0
  36. ( 603 ms ) isolate.generate 23_1.isolate.gen.json
    ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 1
  37. ( 581 ms ) isolate.generate 24_0.isolate.gen.json
    ios_chrome_settings_egtests (iPad Air 2 iOS 10.3) shard 0
  38. ( 578 ms ) isolate.generate 25_0.isolate.gen.json
    ios_chrome_payments_egtests (iPad Air 2 iOS 10.3) shard 0
  39. ( 574 ms ) isolate.generate 25_1.isolate.gen.json
    ios_chrome_payments_egtests (iPad Air 2 iOS 10.3) shard 1
  40. ( 620 ms ) isolate.generate 26_0.isolate.gen.json
    ios_chrome_reading_list_egtests (iPad Air 2 iOS 10.3) shard 0
  41. ( 588 ms ) isolate.generate 27_0.isolate.gen.json
    ios_showcase_egtests (iPad Air 2 iOS 10.3) shard 0
  42. ( 575 ms ) isolate.generate 28.isolate.gen.json
    ios_chrome_adaptive_toolbar_egtests (iPhone X iOS 11.2)
  43. ( 589 ms ) isolate.generate 29.isolate.gen.json
    ios_chrome_bookmarks_egtests (iPhone X iOS 11.2)
  44. ( 574 ms ) isolate.generate 30.isolate.gen.json
    ios_chrome_web_egtests (iPhone X iOS 11.2)
  45. ( 579 ms ) isolate.generate 31.isolate.gen.json
    ios_chrome_settings_egtests (iPhone X iOS 11.2)
  46. ( 635 ms ) isolate.generate 32.isolate.gen.json
    ios_chrome_payments_egtests (iPhone X iOS 11.2)
  47. ( 572 ms ) isolate.generate 33.isolate.gen.json
    ios_chrome_reading_list_egtests (iPhone X iOS 11.2)
  48. ( 570 ms ) isolate.generate 34.isolate.gen.json
    ios_showcase_egtests (iPhone X iOS 11.2)
  49. ( 577 ms ) isolate.generate 35_0.isolate.gen.json
    ios_chrome_integration_egtests (iPad Air 2 iOS 10.3) shard 0
  50. ( 578 ms ) isolate.generate 35_1.isolate.gen.json
    ios_chrome_integration_egtests (iPad Air 2 iOS 10.3) shard 1
  51. ( 581 ms ) isolate.generate 36_0.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 0
  52. ( 573 ms ) isolate.generate 36_1.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 1
  53. ( 584 ms ) isolate.generate 36_2.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 2
  54. ( 605 ms ) isolate.generate 36_3.isolate.gen.json
    ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 3
  55. ( 596 ms ) isolate.generate 37_0.isolate.gen.json
    ios_web_shell_egtests (iPad Air 2 iOS 10.3) shard 0
  56. ( 572 ms ) isolate.generate 38.isolate.gen.json
    ios_chrome_integration_egtests (iPhone X iOS 11.2)
  57. ( 586 ms ) isolate.generate 39_0.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 0
  58. ( 597 ms ) isolate.generate 39_1.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 1
  59. ( 600 ms ) isolate.generate 39_2.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 2
  60. ( 612 ms ) isolate.generate 39_3.isolate.gen.json
    ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 3
  61. ( 597 ms ) isolate.generate 40.isolate.gen.json
    ios_web_shell_egtests (iPhone X iOS 11.2)
  62. ( 1 mins 18 secs ) isolate.archive
  63. ( 0 ) trigger
  64. ( 1 mins 55 secs ) ios_chrome_adaptive_toolbar_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:03:57.292950
  65. ( 3 mins 3 secs ) ios_chrome_bookmarks_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:59.082140
  66. ( 9 secs ) ios_chrome_web_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:07:12.871430
  67. ( 3 mins 15 secs ) ios_chrome_web_egtests (iPhone 6s Plus iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:10:25.102510
  68. ( 6 mins 42 secs ) ios_chrome_settings_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:17:03.839300
  69. ( 2 secs ) ios_chrome_payments_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:55.726790
  70. ( 2 secs ) ios_chrome_payments_egtests (iPhone 6s Plus iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:06:05.583060
  71. ( 2 secs ) ios_chrome_reading_list_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:05:31.126890
  72. ( 2 secs ) ios_showcase_egtests (iPhone 6s Plus iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:26.243560
  73. ( 2 secs ) ios_chrome_adaptive_toolbar_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:02:36.575010
  74. ( 4 mins 33 secs ) ios_chrome_bookmarks_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:22:19.491760
  75. ( 2 secs ) ios_chrome_web_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:16:02.695120
  76. ( 2 secs ) ios_chrome_settings_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:09:20.838230
  77. ( 2 secs ) ios_chrome_payments_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:11:36.698630
  78. ( 2 secs ) ios_chrome_reading_list_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:39.682870
  79. ( 2 secs ) ios_showcase_egtests (iPhone 7 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:05:36.862940
  80. ( 2 secs ) ios_chrome_adaptive_toolbar_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:37.457560
  81. ( 2 secs ) ios_chrome_bookmarks_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:22:29.822430
  82. ( 2 secs ) ios_chrome_web_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:14:22.562500
  83. ( 2 secs ) ios_chrome_settings_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:12:43.848600
  84. ( 2 secs ) ios_chrome_payments_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:11:31.534690
  85. ( 2 secs ) ios_chrome_reading_list_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:05:56.928210
  86. ( 2 secs ) ios_showcase_egtests (iPad Air 2 iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:04:05.157740
  87. ( 2 secs ) ios_chrome_adaptive_toolbar_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:03:10.972240
  88. ( 2 secs ) ios_chrome_bookmarks_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:37.435240
  89. ( 2 secs ) ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:33.960830
  90. ( 2 secs ) ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:09:10.633040
  91. ( 2 secs ) ios_chrome_settings_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:17:04.707350
  92. ( 2 secs ) ios_chrome_payments_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:24.903330
  93. ( 2 secs ) ios_chrome_payments_egtests (iPad Air 2 iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:05:39.612370
  94. ( 2 secs ) ios_chrome_reading_list_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:05:45.562350
  95. ( 2 secs ) ios_showcase_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:23.195140
  96. ( 2 secs ) ios_chrome_adaptive_toolbar_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:03:13.641440
  97. ( 2 secs ) ios_chrome_bookmarks_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:04:50.774140
  98. ( 2 secs ) ios_chrome_web_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:16:34.688070
  99. ( 2 secs ) ios_chrome_settings_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:17:35.157390
  100. ( 2 secs ) ios_chrome_payments_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:08:00.266760
  101. ( 2 secs ) ios_chrome_reading_list_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:06:00.449910
  102. ( 2 secs ) ios_showcase_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:06:26.652270
  103. ( 2 secs ) ios_chrome_integration_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:06:20.687200
  104. ( 2 secs ) ios_chrome_integration_egtests (iPad Air 2 iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:05:52.474540
  105. ( 2 secs ) ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:08:40.981500
  106. ( 2 secs ) ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:07:41.528460
  107. ( 2 secs ) ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 2
    Run on OS: 'Mac'
    Shard duration: 0:13:13.337540
  108. ( 2 secs ) ios_chrome_ui_egtests (iPad Air 2 iOS 10.3) shard 3
    Run on OS: 'Mac'
    Shard duration: 0:09:40.994060
  109. ( 2 secs ) ios_web_shell_egtests (iPad Air 2 iOS 10.3) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:01:55.202690
  110. ( 2 secs ) ios_chrome_integration_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:11:13.410400
  111. ( 2 secs ) ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 0
    Run on OS: 'Mac'
    Shard duration: 0:09:10.390530
  112. ( 3 secs ) ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 1
    Run on OS: 'Mac'
    Shard duration: 0:09:31.158960
  113. ( 2 secs ) ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 2
    Run on OS: 'Mac'
    Shard duration: 0:11:53.138110
  114. ( 2 secs ) ios_chrome_ui_egtests (iPhone X iOS 11.2) shard 3
    Run on OS: 'Mac'
    Shard duration: 0:10:15.191670
  115. ( 2 secs ) ios_web_shell_egtests (iPhone X iOS 11.2)
    Run on OS: 'Mac'
    Shard duration: 0:02:12.971170
  116. ( 365 ms ) Tests statistics
     
    Stats
    Total shards: 52
    Total runtime: 7:00:06.398233
     
  117. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm124-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531397990047420, "id": "8941206537146946384", "project": "chromium", "tags": ["builder:ios-simulator-full-configs", "buildset:commit/git/ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106636599436283520", "scheduler_job_id:chromium/ios-simulator-full-configs", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-simulator-full-configs" setup_build
buildnumber 8008 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2" bot_update
got_revision_cp "refs/heads/master@{#574531}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update

Blamelist:

  1. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  2. Shik Chen (shikohnoyoudont@chromium.org)
  3. Benoit Lize (lizebohnoyoudont@chromium.org)
  4. Peter Mayo (petermayoohnoyoudont@chromium.org)
  5. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 12:19:50 UTC
Start Thursday, 12-Jul-18 12:19:53 UTC
End Thursday, 12-Jul-18 12:58:16 UTC
Pending 3 secs
Execution 38 mins 22 secs

All Changes:

  1. Activate widget correctly when the inline reply opens on ARC notification

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

    Comments

    Activate widget correctly when the inline reply opens on ARC notification
    
    When a non-ARC normal window (eg. Chrome browser window) was active, the
    inline textbox didn't work for the second time and later. This CL solves
    this issue.
    
    This was because the widget was not activated correctly (IsActive() was
    true but CanActivate() was false) in that case. This CL removes the
    IsActive() guard to make the widget active correctly whenever the inline
    reply opens.
    
    Bug: b/111100376
    Bug: 858938
    Test: manual (inline reply can be used multiple times)
    
    Change-Id: I65d7604be5d24ff1e6c56336a76a5951d6066b39
    Reviewed-on: https://chromium-review.googlesource.com/1133039
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574531}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
  2. media: sync the camera metadata definitions

    Changed by Shik Chen - shikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38884d4717c2517cb832722d0fa4871a89d19799

    Comments

    media: sync the camera metadata definitions
    
    We need some new metadata tags for external camera, so regenerate and
    sync all of them in arc-camera, chromium, and ARC++.
    
    Some "arc" are replaced by "cros" manually.
    
    BUG=b:77833131
    TEST=Verify CCA works on Nautilus.
    
    Change-Id: I308e258d9b72acdd825591041a67ce7352dce6a8
    Reviewed-on: https://chromium-review.googlesource.com/1117970
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Shik Chen <shik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574530}

    Changed files

    • media/capture/video/chromeos/mojo/camera_metadata_tags.mojom
  3. blink/wtf: Really move MovableStrings when DCHECK_IS_ON.

    Changed by Benoit Lize - lizebohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:09:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1fef2b1ad38fe1ef8c3914fb5dadc39bae80b9b

    Comments

    blink/wtf: Really move MovableStrings when DCHECK_IS_ON.
    
    When a MovableString is parked, actually park the content, and poison
    the previous allocation. This is intended to find cached raw pointer
    accesses, which are not allowed beyond the UI thread task per the
    contract of the class.
    Enabled only when DCHECK_IS_ON to prevent potential crashes.
    
    Changes with and without DCHECK()s:
    - Cache some String properties in MovableStringImpl
    - Add a parked_strings_ to MovableStringTable for accounting, and
      update tests accordingly.
    
    Changes with DCHECK()s:
    - Add a parked_string_ member to MovableStringImpl
    - Copy the string to the parked version in Park(), and poison the
      previous allocation.
    - Restore the string in Unpark().
    
    Bug: 837659
    Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
    Reviewed-on: https://chromium-review.googlesource.com/1133169
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574529}

    Changed files

    • third_party/blink/renderer/platform/wtf/text/movable_string.cc
    • third_party/blink/renderer/platform/wtf/text/movable_string.h
    • third_party/blink/renderer/platform/wtf/text/movable_string_test.cc
  4. Re-enable opening-handshake/003-sets-origin.worker.html

    Changed by Peter Mayo - petermayoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:58:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d18929b41e24487865c4ed9da46129e6b037beeb

    Comments

    Re-enable opening-handshake/003-sets-origin.worker.html
    
    These tests no longer timeout.  The flakiness dashboard is green
    for a long time.
    
    Bug: 803558
    Change-Id: I2924740d2c736419fdc5130e546f557c8d874151
    Reviewed-on: https://chromium-review.googlesource.com/1134094
    Reviewed-by: Robert Ma <robertma@chromium.org>
    Commit-Queue: Peter Mayo <petermayo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574528}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  5. [Fetch] Use wrapper tracing to express references between wrappers

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:53:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a7c8ee607674efabc720016992893e2226ce3a0

    Comments

    [Fetch] Use wrapper tracing to express references between wrappers
    
    This is a reland of
    https://crrev.com/8057f58cb22579bc685efa50c579325ed047d51a which has
    been reverted due to a crash issue. The crash was caused by a missing
    TraceWrapperMember in blink::Response. This CL fixes that, and adds
    a layout test to verify that.
    
    Original CL: https://chromium-review.googlesource.com/c/1124270
    
    Bug: 862440
    Change-Id: I2842b957f223cfb32fee2aa9048b550010cb2e45
    Reviewed-on: https://chromium-review.googlesource.com/1134642
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574527}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/fetch/chromium/body-wrapper-tracing.html
    • third_party/blink/renderer/core/fetch/body_stream_buffer.cc
    • third_party/blink/renderer/core/fetch/body_stream_buffer.h
    • third_party/blink/renderer/core/fetch/fetch_request_data.cc
    • third_party/blink/renderer/core/fetch/fetch_request_data.h
    • third_party/blink/renderer/core/fetch/fetch_response_data.cc
    • third_party/blink/renderer/core/fetch/fetch_response_data.h
    • third_party/blink/renderer/core/fetch/request.cc
    • third_party/blink/renderer/core/fetch/request.h
    • third_party/blink/renderer/core/fetch/response.cc
    • third_party/blink/renderer/core/fetch/response.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/platform/bindings/v8_private_property.h