Home | Search | chromium - Builders
Login

Builder ios-device Build 105077 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisionf947cd08cce8175e8486d9543713a16589d47589
Got Revisionf947cd08cce8175e8486d9543713a16589d47589

Execution:

Steps and Logfiles:

Show:
  1. ( 285 ms ) setup_build
    running recipe: "ios/unified_builder_tester"
  2. ( 2 mins 7 secs ) bot_update
    [147GB/232GB used (63%)]
  3. ( 732 ms ) read build config
  4. ( 23 secs ) gclient runhooks
  5. ( 611 ms ) lookup GN args
     
    ios_enable_code_signing = false
    is_component_build = false
    is_debug = false
    symbol_level = 0
    target_cpu = "arm64"
    target_os = "ios"
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  6. ( 5 secs ) explain compile
  7. ( 5 mins 9 secs ) compile
  8. ( 0 ) trigger

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm121-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541786680146787, "id": "8930313206037049712", "project": "chromium", "tags": ["builder:ios-device", "buildset:commit/git/f947cd08cce8175e8486d9543713a16589d47589", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f947cd08cce8175e8486d9543713a16589d47589", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095743268215845888", "scheduler_job_id:chromium/ios-device", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ios-device" setup_build
buildnumber 105077 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "ios/unified_builder_tester" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "f947cd08cce8175e8486d9543713a16589d47589" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "f947cd08cce8175e8486d9543713a16589d47589" bot_update
got_revision_cp "refs/heads/master@{#606898}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" bot_update
got_v8_revision_cp "refs/heads/7.2.287@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update

Blamelist:

  1. Yi Su (mrsuyiohnoyoudont@chromium.org)
  2. Arthur Sonzogni (arthursonzogniohnoyoudont@chromium.org)
  3. Douglas Creager (dcreagerohnoyoudont@chromium.org)
  4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  5. Mario Sanchez Prada (marioohnoyoudont@igalia.com)

Timing:

Create Friday, 09-Nov-18 18:04:40 UTC
Start Friday, 09-Nov-18 18:04:44 UTC
End Friday, 09-Nov-18 18:15:32 UTC
Pending 4 secs
Execution 10 mins 47 secs

All Changes:

  1. Let SearchEngineTabHelper extend FaviconDriverObserver to update the favicon in TemplateURLService.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 18:02:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f947cd08cce8175e8486d9543713a16589d47589

    Comments

    Let SearchEngineTabHelper extend FaviconDriverObserver to update the favicon in TemplateURLService.
    
    This CL let iOS SearchEngineTabHelper extend FaviconDriverObserver so that
    it has equivalent functionality as the SearchEngineTabHelper in
    /chrome/browser/ui/search_engines.
    
    Bug: 433824
    Change-Id: If49d1b46d90b2250c2b378d77d9e3cea5cdd96a5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329171
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606898}

    Changed files

    • ios/chrome/browser/search_engines/BUILD.gn
    • ios/chrome/browser/search_engines/search_engine_tab_helper.h
    • ios/chrome/browser/search_engines/search_engine_tab_helper.mm
    • ios/chrome/browser/search_engines/search_engine_tab_helper_unittest.mm
    • ios/chrome/browser/tabs/tab_helper_util.mm
  2. Revert "BlobUrlLoader: Instrument for bug 882661."

    Changed by Arthur Sonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 18:01:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee333c3fc796980f722e5969fd373755fe97d3ec

    Comments

    Revert "BlobUrlLoader: Instrument for bug 882661."
    
    This reverts commit 4ff885a19e44b128bc9151a93289ce61a313295c.
    
    Reason for revert: CHECK not reached. The URLLoader to blame was the
    WebRequestProxyingURLLoader.
    
    Original change's description:
    > BlobUrlLoader: Instrument for bug 882661.
    > 
    > In bug 882661: one mojo::URLLoader is sending OnStartLoadingResponseBody
    > without sending OnReceiveResponse before.
    > 
    > Add instrumentation to check this never happen with this class.
    > 
    > Bug: 882661
    > Change-Id: Ia9df5debbc03f0a5296c64edbcf6d975806bc021
    > Reviewed-on: https://chromium-review.googlesource.com/c/1304435
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#605181}
    
    TBR=kinuko@chromium.org,mek@chromium.org,arthursonzogni@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 882661
    Change-Id: I16e8a5709f34d6909445c9cb0f674f07702ff594
    Reviewed-on: https://chromium-review.googlesource.com/c/1329782
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606897}

    Changed files

    • storage/browser/blob/blob_url_loader.cc
    • storage/browser/blob/blob_url_loader.h
  3. Reporting: Process Report-To headers in HTTPNetworkTransaction

    Changed by Douglas Creager - dcreagerohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 18:00:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 134b52eafe64a29308d4258df58418307ac21c51

    Comments

    Reporting: Process Report-To headers in HTTPNetworkTransaction
    
    Piece by piece, we are moving the Reporting and NEL processing code from
    URLRequest and friends into HTTPNetworkTransaction, to make sure that we
    produce reports for network requests as defined by the spec (e.g., for
    redirects and cached responses).
    
    This patch moves the processing of the Report-To configuration header.
    
    Bug: 895823
    Change-Id: Id6f51eefdb9afc43ad3841fb3c3f6d6b39fd2943
    Reviewed-on: https://chromium-review.googlesource.com/c/1293555
    Commit-Queue: Douglas Creager <dcreager@chromium.org>
    Reviewed-by: Misha Efimov <mef@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606896}

    Changed files

    • net/http/http_network_session.cc
    • net/http/http_network_session.h
    • net/http/http_network_transaction.cc
    • net/http/http_network_transaction.h
    • net/http/http_network_transaction_unittest.cc
    • net/reporting/reporting_header_parser.cc
    • net/reporting/reporting_header_parser.h
    • net/reporting/reporting_service.cc
    • net/spdy/spdy_test_util_common.cc
    • net/spdy/spdy_test_util_common.h
    • net/url_request/url_request_context_builder.cc
    • net/url_request/url_request_http_job.cc
    • net/url_request/url_request_http_job.h
    • net/url_request/url_request_unittest.cc
  4. Roll src/third_party/skia c244c2fbbbf8..ef4709b7850d (8 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 18:00:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 97477fc11e6476b6fab50dccea7f69fdeb1309d4

    Comments

    Roll src/third_party/skia c244c2fbbbf8..ef4709b7850d (8 commits)
    
    https://skia.googlesource.com/skia.git/+log/c244c2fbbbf8..ef4709b7850d
    
    
    git log c244c2fbbbf8..ef4709b7850d --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com move blend-row routines to SkBlitter_ARGB32.cpp
    2018-11-09 mtklein@google.com get familiar with SkBlitMask_D32.cpp
    2018-11-09 egdaniel@google.com Revert "Have a GrBackendFormat be stored on gpu proxies."
    2018-11-09 mtklein@google.com remove unused typedef
    2018-11-09 halcanary@google.com SkQP: script: fix non-existant build path
    2018-11-09 reed@google.com remove guards for hinting in google3
    2018-11-09 nathanrogers@google.com Fix another typo in SkSize comments
    2018-11-09 nigeltao@google.com Merge SkFooAdapterCodec impls into one impl
    
    
    Created with:
      gclient setdep -r src/third_party/skia@ef4709b7850d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    
    BUG=chromium:903701 chromium:903756
    TBR=allanmac@chromium.org
    
    Change-Id: I49bf07d7c1d1b5a67bf3317b67cd93e5bcb44e6b
    Reviewed-on: https://chromium-review.googlesource.com/c/1329504
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606895}

    Changed files

    • DEPS
  5. Migrate clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 17:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7586428da170b5323c25305dd3e213c38c6aa41

    Comments

    Migrate clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager
    
    Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually
    creating the browser's state by providing specific factories, and then
    use the APIs from IdentityTestEnvironment, instead of SigninManagerBase.
    
    Also remove an unnecessary DCHECK in clear_browsing_data_manager_unittest.mm,
    as pointed out post-review when fixing crbug.com/890826 (CL 1318974).
    
    Bug: 903703
    Change-Id: I9d4dd625441005a36c962628fe3fe1f15ab56bb6
    Reviewed-on: https://chromium-review.googlesource.com/c/1328985
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#606894}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager_unittest.mm