Home | Search | chromium - Builders

Builder ios-device-xcode-clang Build 68147 Apple OSX



Trigger Info:

Got Revisioncae26c020606a88289e746e446999dd9c101019d


Steps and Logfiles:

  1. ( 0 ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:



  1. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  2. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  3. Colin Blundell (blundellohnoyoudont@chromium.org)
  4. Jun Cai (juncaiohnoyoudont@chromium.org)


Create Thursday, 12-Jul-18 16:59:59 UTC
Start Thursday, 12-Jul-18 17:00:05 UTC
End Thursday, 12-Jul-18 17:07:52 UTC
Pending 5 secs
Execution 7 mins 47 secs

All Changes:

  1. Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 16:57:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision cae26c020606a88289e746e446999dd9c101019d


    Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)
    git log 58c79f66dd3a..798ee75d2365 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 kthelgason@webrtc.org Always disable RED when ULPFEC is disabled.
    2018-07-12 hta@webrtc.org Buffer ICE candidates that can't be added immediately.
    Created with:
      gclient setdep -r src/third_party/webrtc@798ee75d2365
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    Documentation for the AutoRoller is here:
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    Change-Id: Ia3faf57f19146a8b08a9a5cbe8915a9750b91210
    Reviewed-on: https://chromium-review.googlesource.com/1135226
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574605}

    Changed files

    • DEPS
  2. [unified-consent] Add unity logic to OneClickSigninSyncStarter

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:55:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision 90520e430b08a292bd878117370d0a7e68eb38bc


    [unified-consent] Add unity logic to OneClickSigninSyncStarter
    All unified consent services are enabled when the unified
    consent is given through the OneClickSigninSyncStarter.
    Bug: 862202
    Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
    Reviewed-on: https://chromium-review.googlesource.com/1135001
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574604}

    Changed files

    • chrome/browser/ui/sync/one_click_signin_sync_starter.cc
    • chrome/browser/ui/sync/one_click_signin_sync_starter.h
  3. Revert "Have Device Service observe MessageLoop destruction"

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1


    Revert "Have Device Service observe MessageLoop destruction"
    This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.
    Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which will mean doing the plumbing that the below CL was looking to avoid. This is all sad-making, but c'est la vie.
    Bug: 856771, 794105
    Original change's description:
    > Have Device Service observe MessageLoop destruction
    > The Device Service needs to clean up parts of its internal state as part
    > of browser shutdown. However, it also needs to run on the UI thread,
    > and embedded services that run on the UI thread are not guaranteed to
    > be destroyed as part of browser shutdown (tasks to destroy these
    > services are posted from the IO thread by
    > ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
    > typically shut down before these posted tasks are run).
    > To solve this issue we discussed adding plumbing wherein embedded
    > services could inform //content that they wanted to be notified when
    > shutdown was occurring on the main thread. However, on investigation
    > this plumbing would be painful to implement: it is only
    > EmbeddedInstanceManager that has direct information of these service
    > instances, and that object lives far away from //content's
    > ServiceManagerContext, the object that knows when shutdown is occurring
    > on the main thread.
    > This CL takes an alternative approach of having the Device Service
    > implementation observe the destruction of its MessageLoop. I have
    > verified that the observation is triggered on shutdown of Chrome.
    > Bug: 794105
    > Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
    > Reviewed-on: https://chromium-review.googlesource.com/1099245
    > Commit-Queue: Colin Blundell <blundell@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567260}
    # Not skipping CQ checks because original CL landed > 1 day ago.
    Bug: 794105
    Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
    Reviewed-on: https://chromium-review.googlesource.com/1134887
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h
  4. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision f3aba7f968ecb147e59a5460bd168e6085425848


    Network Service: Document how adding/removing http headers for web content requests are implemented
    This is a follow-up CL per comments at:
    This CL adds comments to //components/variations/variations_http_header_provider.cc
    to document how adding/removing http headers for web content requests are
    implemented differently when Network Service is enabled or not enabled.
    Bug: 841309
    Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
    Reviewed-on: https://chromium-review.googlesource.com/1134408
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc