Builder fuchsia-x64-cast Build 11643
Results:
Success
Trigger Info:
Project | chromium |
Revision | b2850e38619db9edb91bf84e82f8732ace0c8875 |
Got Revision | b2850e38619db9edb91bf84e82f8732ace0c8875 |
Execution:
- Source: Task 42927f8e83133110
- Bot: swarm974-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 606 ms ) read test spec (chromium.linux.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.linux.json
-
( 445 ms ) lookup GN argsis_chromecast = trueis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = truesymbol_level = 0target_os = "fuchsia"use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$build/goma | {"jobs": 500} | setup_build |
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm974-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548229674051435, "id": "8923557237260952416", "project": "chromium", "tags": ["builder:fuchsia-x64-cast", "buildset:commit/git/b2850e38619db9edb91bf84e82f8732ace0c8875", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b2850e38619db9edb91bf84e82f8732ace0c8875", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088987299402188432", "scheduler_job_id:chromium/fuchsia-x64-cast", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "fuchsia-x64-cast" | setup_build |
buildnumber | 11643 | setup_build |
mastername | "chromium.linux" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "b2850e38619db9edb91bf84e82f8732ace0c8875" | setup_build |
got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "b2850e38619db9edb91bf84e82f8732ace0c8875" | bot_update |
got_revision_cp | "refs/heads/master@{#625122}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "2307cc4b68d51f1071113d8ca92a5267e1feadc0" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.486@{#1}" | bot_update |
got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
Blamelist:
- Sam McNally (sammcohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 23-Jan-19 07:47:54 UTC |
Start | Wednesday, 23-Jan-19 07:48:23 UTC |
End | Wednesday, 23-Jan-19 07:50:56 UTC |
Pending | 29 secs |
Execution | 2 mins 33 secs |
All Changes:
-
Add support for $i18n{} for component app/extension resources.
Changed by Sam McNally - sammcohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 07:46:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b2850e38619db9edb91bf84e82f8732ace0c8875 Comments
Add support for $i18n{} for component app/extension resources. i18n-values and i18n-content are deprecated, to be replaced by $i18n{} in Web UI. Allow component apps/extensions to use the same i18n template replacements as Web UI during serving. Update the Files app quickview localization covered by a test to use this method. Bug: 923206,923204 Change-Id: I647bdea906c6bc427a82981fac780cc0e6badf2c Reviewed-on: https://chromium-review.googlesource.com/c/1424619 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#625122}
Changed files
- chrome/browser/extensions/chrome_component_extension_resource_manager.cc
- chrome/browser/extensions/chrome_component_extension_resource_manager.h
- chrome/browser/extensions/chrome_url_request_util.cc
- extensions/browser/component_extension_resource_manager.h
- ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
- ui/file_manager/integration_tests/file_manager/quick_view.js