Builder fuchsia-x64-cast Build 11642
Results:
Success
Trigger Info:
Project | chromium |
Revision | df90eab0e54f9b31b421fbd2bdbb79c7d5434191 |
Got Revision | df90eab0e54f9b31b421fbd2bdbb79c7d5434191 |
Execution:
- Source: Task 42926d99a0d12110
- Bot: swarm974-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 599 ms ) read test spec (chromium.linux.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.linux.json
-
( 432 ms ) lookup GN argsis_chromecast = trueis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = truesymbol_level = 0target_os = "fuchsia"use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$build/goma | {"jobs": 500} | setup_build |
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm974-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548228497467780, "id": "8923558470998565232", "project": "chromium", "tags": ["builder:fuchsia-x64-cast", "buildset:commit/git/df90eab0e54f9b31b421fbd2bdbb79c7d5434191", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/df90eab0e54f9b31b421fbd2bdbb79c7d5434191", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088988533000582944", "scheduler_job_id:chromium/fuchsia-x64-cast", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "fuchsia-x64-cast" | setup_build |
buildnumber | 11642 | setup_build |
mastername | "chromium.linux" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "df90eab0e54f9b31b421fbd2bdbb79c7d5434191" | setup_build |
got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "df90eab0e54f9b31b421fbd2bdbb79c7d5434191" | bot_update |
got_revision_cp | "refs/heads/master@{#625121}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "2307cc4b68d51f1071113d8ca92a5267e1feadc0" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.486@{#1}" | bot_update |
got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
Blamelist:
- Tsuyoshi Horo (horoohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 23-Jan-19 07:28:17 UTC |
Start | Wednesday, 23-Jan-19 07:28:20 UTC |
End | Wednesday, 23-Jan-19 07:31:19 UTC |
Pending | 2 secs |
Execution | 2 mins 59 secs |
All Changes:
-
Use an opaque Origin initiator for cert request
Changed by Tsuyoshi Horo - horoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 07:25:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision df90eab0e54f9b31b421fbd2bdbb79c7d5434191 Comments
Use an opaque Origin initiator for cert request We are using the original request's request_initiator to certificate request. But we can just use an opaque Origin because SignedExchangeCertFetcher fetches the cert with LOAD_DO_NOT_SEND_COOKIES flag, and so URLRequestHttpJob::AddCookieHeaderAndStart() doesn't use the initiator(). https://chromium.googlesource.com/chromium/src/+/accda06/content/browser/web_package/signed_exchange_cert_fetcher.cc#112 https://chromium.googlesource.com/chromium/src/+/f3caee1/net/url_request/url_request_http_job.cc#691 Bug: 920905 Change-Id: If1512420c60bc971e959b66a0e25a39afacc57b9 Reviewed-on: https://chromium-review.googlesource.com/c/1429362 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625121}
Changed files
- content/browser/web_package/signed_exchange_cert_fetcher.cc
- content/browser/web_package/signed_exchange_cert_fetcher.h
- content/browser/web_package/signed_exchange_cert_fetcher_factory.cc
- content/browser/web_package/signed_exchange_cert_fetcher_factory.h
- content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
- content/browser/web_package/signed_exchange_loader.cc