Home | Search | chromium - Builders
Login

Builder fuchsia-fyi-arm64-rel Build 4156 Canonical Ubuntu

Results:

Failure base_unittests Failure content_unittests Failure cronet_tests Failure cronet_unittests Failure crypto_unittests Failure fidlgen_js_unittests Failure http_service_tests Failure ipc_tests Failure media_unittests Failure mojo_unittests Failure service_manager_unittests Failure skia_unittests Failure sql_unittests Failure ui_base_unittests Failure webrunner_browsertests Failure webrunner_unittests

Trigger Info:

Projectchromium
Revision8112997ce464e3fa4ae5ca8e166c7adc1de03e35
Got Revision8112997ce464e3fa4ae5ca8e166c7adc1de03e35

Execution:

Steps and Logfiles:

Show:
  1. ( 323 ms ) setup_build
    running recipe: "chromium"
  2. ( 770 ms ) report builders
     
    running builder/tester 'fuchsia-fyi-arm64-rel' on master 'chromium.fyi'
  3. ( 3 mins 29 secs ) bot_update
    [68GB/295GB used (23%)]
  4. ( 1 secs ) swarming.py --version
    0.14
  5. ( 39 secs ) gclient runhooks
  6. ( 996 ms ) read test spec (chromium.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
  7. ( 525 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    target_cpu = "arm64"
    target_os = "fuchsia"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 35 secs ) generate_build_files
  9. ( 4 mins 24 secs ) compile
  10. ( 54 secs ) isolate tests
  11. ( 451 ms ) find isolated tests
  12. ( 1 mins 15 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:14.170276
  13. ( 1 mins 22 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:21.215228
  14. ( 1 mins 20 secs ) cronet_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:19.829745
  15. ( 1 mins 29 secs ) cronet_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:28.453445
  16. ( 1 mins 21 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:18.705459
  17. ( 1 mins 38 secs ) fidlgen_js_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:37.331126
  18. ( 1 mins 17 secs ) http_service_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:13.993710
  19. ( 1 mins 29 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:28.284045
  20. ( 1 mins 36 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:35.773603
  21. ( 1 mins 20 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:18.426859
  22. ( 1 mins 31 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:30.008176
  23. ( 1 mins 22 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:19.206942
  24. ( 1 mins 21 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:19.163325
  25. ( 1 mins 22 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:20.034525
  26. ( 1 mins 42 secs ) webrunner_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:39.500253
  27. ( 1 mins 33 secs ) webrunner_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:29.166856
  28. ( 225 ms ) Tests statistics
     
    Stats
    Total shards: 16
    Total runtime: 0:19:13.402391
     
  29. ( 1 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2461-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544165705749599, "id": "8927818616886604224", "project": "chromium", "tags": ["builder:fuchsia-fyi-arm64-rel", "buildset:commit/git/8112997ce464e3fa4ae5ca8e166c7adc1de03e35", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/8112997ce464e3fa4ae5ca8e166c7adc1de03e35", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093248679002032176", "scheduler_job_id:chromium/fuchsia-fyi-arm64-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "fuchsia-fyi-arm64-rel" setup_build
buildnumber 4156 setup_build
mastername "chromium.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "8112997ce464e3fa4ae5ca8e166c7adc1de03e35" setup_build
got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "8112997ce464e3fa4ae5ca8e166c7adc1de03e35" bot_update
got_revision_cp "refs/heads/master@{#614629}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" bot_update
got_v8_revision_cp "refs/heads/7.3.56@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes_refs/heads/master(at){#614629}_without_patch {"base_unittests": "3096d8a682f23f946157501ebfe76ff509a04786", "content_unittests": "ad2994ab69deb37cdfa9dbcdf55682d342d21782", "cronet_tests": "9b1e93e25d751ee84a1ab828c85d68e9b0a30a7c", "cronet_unittests": "522451317248103c5e1b98e7bc123d5faa542283", "crypto_unittests": "20a88e1664e2141c3e5b640a6ff243761502cdb5", "fidlgen_js_unittests": "f45f28b9cd80040bf0138ea0c9ebfb8a1bd43c0c", "http_service_tests": "aff8bab87030af8fd9ef8108d10f00a5e4bd0966", "ipc_tests": "de28d8a901d74db2999b68a571ed031ea2979e56", "media_unittests": "d04d9a355f1a5470325f9e284f55b13d31f340be", "mojo_unittests": "19f08e2b9661257ff9124f189f72b1aa1f3dec72", "service_manager_unittests": "b05d574ec8ddbd03180324c84d1293582bd2884f", "skia_unittests": "8bdfba598542338a7980193205946f1d7b00c8f4", "sql_unittests": "a2d9c76590c65d6cc1da0d7ce66f4d57d1b3f6ff", "ui_base_unittests": "b5821a1143cc25c899269b7b5b5a997bddb13fe7", "webrunner_browsertests": "7619ad23edff6fbb2682b22f12ba6f4b8e4ac3ee", "webrunner_unittests": "afbc7c444733c1d7909b1b538d85bdaddc452895"} isolate tests
swarm_hashes {"base_unittests": "3096d8a682f23f946157501ebfe76ff509a04786", "content_unittests": "ad2994ab69deb37cdfa9dbcdf55682d342d21782", "cronet_tests": "9b1e93e25d751ee84a1ab828c85d68e9b0a30a7c", "cronet_unittests": "522451317248103c5e1b98e7bc123d5faa542283", "crypto_unittests": "20a88e1664e2141c3e5b640a6ff243761502cdb5", "fidlgen_js_unittests": "f45f28b9cd80040bf0138ea0c9ebfb8a1bd43c0c", "http_service_tests": "aff8bab87030af8fd9ef8108d10f00a5e4bd0966", "ipc_tests": "de28d8a901d74db2999b68a571ed031ea2979e56", "media_unittests": "d04d9a355f1a5470325f9e284f55b13d31f340be", "mojo_unittests": "19f08e2b9661257ff9124f189f72b1aa1f3dec72", "service_manager_unittests": "b05d574ec8ddbd03180324c84d1293582bd2884f", "skia_unittests": "8bdfba598542338a7980193205946f1d7b00c8f4", "sql_unittests": "a2d9c76590c65d6cc1da0d7ce66f4d57d1b3f6ff", "ui_base_unittests": "b5821a1143cc25c899269b7b5b5a997bddb13fe7", "webrunner_browsertests": "7619ad23edff6fbb2682b22f12ba6f4b8e4ac3ee", "webrunner_unittests": "afbc7c444733c1d7909b1b538d85bdaddc452895"} find isolated tests

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Shu Chen (shuchenohnoyoudont@google.com)
  3. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  4. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. maxmorin (maxmorinohnoyoudont@chromium.org)
  7. Charles Zhao (charleszhaoohnoyoudont@chromium.org)
  8. Alan Cutter (alancutterohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 06:55:05 UTC
Start Friday, 07-Dec-18 06:55:38 UTC
End Friday, 07-Dec-18 07:30:59 UTC
Pending 32 secs
Execution 35 mins 21 secs

All Changes:

  1. Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:49:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8112997ce464e3fa4ae5ca8e166c7adc1de03e35

    Comments

    Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/309f1deddf8e..f3babcd0afb3
    
    
    git log 309f1deddf8e..f3babcd0afb3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 sergeyu@chromium.org Reland "Add SkFontMgr implementation for Fuchsia"
    2018-12-07 reed@google.com Revert "Add SkFontMgr implementation for Fuchsia"
    
    
    Created with:
      gclient setdep -r src/third_party/skia@f3babcd0afb3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Ieefefb070c45ba63a5efa3872a75e1d4140b5e41
    Reviewed-on: https://chromium-review.googlesource.com/c/1367116
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614629}

    Changed files

    • DEPS
  2. Updates the order of key mappings to match the same as layout rendering in VK.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 06:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65054bfdd84984501e8054b2f96edacc1bab93a9

    Comments

    Updates the order of key mappings to match the same as layout rendering in VK.
    
    The modifier importance priority is: Altgr > Shift > Capslock.
    So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method.
    It will fallback to other key mappings in this order:
     - Shift + Altgr
     - Altgr + Capslock
     - Shift + Capslock
     - Altgr
     - Shift
     - Capslock
     - Normal
    
    Bug: 910049
    Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1356735
    Reviewed-by: Leo Zhang <googleo@chromium.org>
    Commit-Queue: Leo Zhang <googleo@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614628}

    Changed files

    • chromeos/services/ime/public/cpp/rulebased/def/fa.cc
    • chromeos/services/ime/public/cpp/rulebased/def/lo.cc
    • chromeos/services/ime/public/cpp/rulebased/def/ta_inscript.cc
    • chromeos/services/ime/public/cpp/rulebased/def/ta_phone.cc
    • chromeos/services/ime/public/cpp/rulebased/def/th.cc
  3. Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:36:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b38c320095ae37996d50a735f7d2690c9e0eed10

    Comments

    Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720
    
    Using wpt-import in Chromium c71812f1007dae45bce45b451c384bf9c0dbd356.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hbos@chromium.org, hta@chromium.org:
      external/wpt/webrtc
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I379fefc2dcbcf7082675a8eced0893890f23b0ef
    Reviewed-on: https://chromium-review.googlesource.com/c/1367132
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614627}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https-expected.txt
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-addStream.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/no-media-call.html
  4. Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:31:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b9acb3dea58c30c4a4cd8d251938f66a47c1e

    Comments

    Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs
    
    <meta name="timeout"> is prefereable for WPTs:
    https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout
    
    Bug: 912240
    Change-Id: I3c4a9acb1fb070c34d10f59ff9d3fd3d2bd11afb
    Reviewed-on: https://chromium-review.googlesource.com/c/1366469
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614626}

    Changed files

    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/external/wpt/worklets/animation-worklet-csp.https.html
    • third_party/blink/web_tests/external/wpt/worklets/audio-worklet-csp.https.html
  5. Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61e410e3beb88a04880f973dbde7c0099dbdff6

    Comments

    Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5d7bcad36ff4..62ba44ace70c
    
    
    git log 5d7bcad36ff4..62ba44ace70c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 rmhasan@google.com Adds another verification to the Test expectation parser
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@62ba44ace70c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:905426
    TBR=sullivan@chromium.org
    
    Change-Id: Ibda0e80cd77c7ecd1434701f064e2f99db1b8307
    Reviewed-on: https://chromium-review.googlesource.com/c/1367099
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614625}

    Changed files

    • DEPS
  6. Activate audio thread hang monitoring when OOP

    Changed by maxmorin - maxmorinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c67047dd2ff166e62aa72f9d461e3a00baf5e573

    Comments

    Activate audio thread hang monitoring when OOP
    
    Also includes cleaning up the hang monitor:
     * Actually a class!
     * Actually possible to stop the hang monitor!
     * Tests!
     * When OOP, uploads dumps (without crashing). A kill switch is added for this.
     * Switch the UMA enum to kCase, make it a class enum, and use the simpler UMA
       histogram.
     * Switch from "tail posting" the periodic task to using RepeatingTimer.
     * Runs on the task scheduler rather than on the browser IO thread.
     * Some suspend/resume code was simplified.
    
    The hang monitor is now owned by the AudioThread implementation.
    
    Extra functionality (such a nuking the audio process in case of a hang)
    is coming later.
    
    Bug: 866442, 905681
    Change-Id: Icfe83cc3e7626b164648a8b502d13cf2cfc25518
    Reviewed-on: https://chromium-review.googlesource.com/c/1340264
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Max Morin <maxmorin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614624}

    Changed files

    • content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • media/audio/BUILD.gn
    • media/audio/audio_features.cc
    • media/audio/audio_features.h
    • media/audio/audio_manager.cc
    • media/audio/audio_manager.h
    • media/audio/audio_thread.h
    • media/audio/audio_thread_hang_monitor.cc
    • media/audio/audio_thread_hang_monitor.h
    • media/audio/audio_thread_hang_monitor_unittest.cc
    • media/audio/audio_thread_impl.cc
    • media/audio/audio_thread_impl.h
    • media/audio/test_audio_thread.cc
    • media/audio/test_audio_thread.h
    • services/audio/owning_audio_manager_accessor.cc
  7. TabRanker: Fix Query time logging.

    Changed by Charles Zhao - charleszhaoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6378752b810e6122744cefac544c8d84278dcc71

    Comments

    TabRanker: Fix Query time logging.
    
    
    TabRanker query time logging was landed in this cl:
    https://chromium-review.googlesource.com/c/chromium/src/+/1350445
    
    TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to
    TabManager::GetSortedLifecycleUnits()
    
    But this was wrong on two aspects:
    
    (1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(),
        so ChromeOS discards are all skipped.
    
    (2) TabManagerDelegate::Candidate is calling
        lifecycle_unit_->GetSortKey() for inferring sorting,
        Which means TabRanker model won't work for ChromeOS discards.
    
    
    The fix:
    (1) Change TabManager, TabLifecycleUnit back to their previous code,
        which were sorting LifecycleUnits by TabRanker when it's enabled.
    
    (2) Add TabActivityWatcher::LogOldestNTabFeatures() and call this function in
        TabManager::DiscardTab for query time logging.
    
    Bug: 911474
    
    Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1360471
    Reviewed-by: Christopher Morin <cmtm@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Charles . <charleszhao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614623}

    Changed files

    • chrome/browser/resource_coordinator/tab_activity_watcher.cc
    • chrome/browser/resource_coordinator/tab_activity_watcher.h
    • chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
  8. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"
    
    This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.
    
    Reason for revert: Broke compile:
    https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
    ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
    #include "libassistant/shared/internal_api/alarm_timer_types.h"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Original change's description:
    > Timer notification UI improvement:
    > 
    > * Add timer deeplinks for:
    >   - Stop timer
    >   - Add time to timer
    > * Add "add 1 min to timer" button to timer notification.
    > 
    > Using a feature flag to guard the usage of the deeplink as
    > AlarmTimerManager is not fully available yet.
    > 
    > Bug: b:119116816
    > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    > Commit-Queue: Li Lin <llin@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614618}
    
    TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org
    
    Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:119116816
    Reviewed-on: https://chromium-review.googlesource.com/c/1367081
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h