Home | Search | chromium - Builders
Login

Builder chromeos-amd64-generic-rel-vm-tests Build 6520 Canonical Ubuntu

Results:

Failure base_unittests Failure chrome_login_tast_tests Failure chromeos_unittests Failure cros_vm_sanity_test Failure services_unittests

Trigger Info:

Projectchromium
Revisionc5b4ca56d0a0b4037577c7e4fc812ead5aa72b78
Got Revisionc5b4ca56d0a0b4037577c7e4fc812ead5aa72b78

Execution:

Steps and Logfiles:

Show:
  1. ( 335 ms ) setup_build
    running recipe: "chromium"
  2. ( 861 ms ) report builders
     
    running builder/tester 'chromeos-amd64-generic-rel-vm-tests' on master 'chromium.fyi'
  3. ( 4 mins 13 secs ) bot_update
    [146GB/295GB used (49%)]
  4. ( 2 secs ) swarming.py --version
    0.13
  5. ( 3 mins 3 secs ) gclient runhooks
  6. ( 929 ms ) read test spec (chromium.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
  7. ( 1 secs ) lookup GN args
     
    Count of GN args (80) exceeds limit (15), presented in logs instead
  8. ( 1 mins 47 secs ) generate_build_files
  9. ( 8 mins 40 secs ) compile
  10. ( 2 mins 1 secs ) isolate tests
  11. ( 449 ms ) find isolated tests
  12. ( 1 hrs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
  13. ( 44 secs ) chrome_login_tast_tests
    Run on OS: 'Ubuntu-14.04'
  14. ( 1 secs ) chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
  15. ( 916 ms ) cros_vm_sanity_test
    Run on OS: 'Ubuntu-14.04'
  16. ( 937 ms ) services_unittests
    Run on OS: 'Ubuntu-14.04'
  17. ( 1 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm930-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1540843288027190, "id": "8931302424372467184", "project": "chromium", "tags": ["builder:chromeos-amd64-generic-rel-vm-tests", "buildset:commit/git/c5b4ca56d0a0b4037577c7e4fc812ead5aa72b78", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c5b4ca56d0a0b4037577c7e4fc812ead5aa72b78", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9096732486486318720", "scheduler_job_id:chromium/chromeos-amd64-generic-rel-vm-tests", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "chromeos-amd64-generic-rel-vm-tests" setup_build
buildnumber 6520 setup_build
mastername "chromium.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "c5b4ca56d0a0b4037577c7e4fc812ead5aa72b78" setup_build
got_angle_revision "25224e786ffea77e8993daa8e8b9b236428cd6eb" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "c5b4ca56d0a0b4037577c7e4fc812ead5aa72b78" bot_update
got_revision_cp "refs/heads/master@{#603596}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "ca9994a1559db41b59fc031f796d16b5751854da" bot_update
got_v8_revision_cp "refs/heads/7.2.172@{#1}" bot_update
got_webrtc_revision "12048c71501a2b62225e65ba270cdcd0dcd691ee" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25412}" bot_update
swarm_hashes_refs/heads/master(at){#603596}_without_patch {"base_unittests": "1354b8f4bdd2c75340c5b7ac2dea7af2cbb52e44", "chrome_login_tast_tests": "460b5950d8490a2ce76f6b8d3fbbe9b677cfe641", "chromeos_unittests": "b691b7c5c63cccff20e4a627501cb3487cf1f8ba", "cros_vm_sanity_test": "63e8649af3cf97a191bfd4e00c7b733a1e4b285e", "services_unittests": "dcdcb4b40b747c47dc30c73e011a4d11278704f5"} isolate tests
swarm_hashes {"base_unittests": "1354b8f4bdd2c75340c5b7ac2dea7af2cbb52e44", "chrome_login_tast_tests": "460b5950d8490a2ce76f6b8d3fbbe9b677cfe641", "chromeos_unittests": "b691b7c5c63cccff20e4a627501cb3487cf1f8ba", "cros_vm_sanity_test": "63e8649af3cf97a191bfd4e00c7b733a1e4b285e", "services_unittests": "dcdcb4b40b747c47dc30c73e011a4d11278704f5"} find isolated tests

Blamelist:

  1. Nate Chapin (japhetohnoyoudont@chromium.org)
  2. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  3. bsheedy (bsheedyohnoyoudont@chromium.org)
  4. Chase Phillips (cmpohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. Evan Stade (estadeohnoyoudont@chromium.org)
  7. Chase Phillips (cmpohnoyoudont@chromium.org)
  8. Weidong Guo (weidonggohnoyoudont@chromium.org)
  9. Clark DuVall (cduvallohnoyoudont@chromium.org)
  10. sebsg (sebsgohnoyoudont@chromium.org)
  11. James Hawkins (jhawkinsohnoyoudont@chromium.org)
  12. Patrick Noland (pnolandohnoyoudont@chromium.org)
  13. Tommy C. Li (tommycliohnoyoudont@chromium.org)
  14. Adam Langley (aglohnoyoudont@chromium.org)
  15. Nicolas Ouellet-Payeur (nicolasoohnoyoudont@chromium.org)
  16. Jonathan Metzman (metzmanohnoyoudont@chromium.org)
  17. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  18. Toni Barzic (tbarzicohnoyoudont@google.com)
  19. Aleks Totic (atoticohnoyoudont@chromium.org)
  20. liberato@chromium.org (liberatoohnoyoudont@chromium.org)
  21. David Jacobo (djacoboohnoyoudont@chromium.org)
  22. Yuly Novikov (ynovikovohnoyoudont@chromium.org)
  23. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  24. Yuly Novikov (ynovikovohnoyoudont@chromium.org)
  25. David Tseng (dtsengohnoyoudont@chromium.org)

Timing:

Create Monday, 29-Oct-18 20:01:28 UTC
Start Monday, 29-Oct-18 20:02:06 UTC
End Monday, 29-Oct-18 21:25:13 UTC
Pending 38 secs
Execution 1 hrs 23 mins

All Changes:

  1. TaskWorklet: always return a promise from task.result.

    Changed by Nate Chapin - japhetohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:54:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c5b4ca56d0a0b4037577c7e4fc812ead5aa72b78

    Comments

    TaskWorklet: always return a promise from task.result.
    
    Previously task.result sometimes returned the result value directly. Making
    it always return a promise makes it easily to handle in JS.
    
    Bug: 879306
    Change-Id: I6c0168d828d8234875a20e1128b14f1ab6603d4f
    Reviewed-on: https://chromium-review.googlesource.com/c/1303100
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Commit-Queue: Nate Chapin <japhet@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603596}

    Changed files

    • third_party/blink/renderer/core/workers/experimental/task.cc
    • third_party/blink/renderer/core/workers/experimental/task.h
    • third_party/blink/renderer/core/workers/experimental/task.idl
    • third_party/blink/renderer/core/workers/experimental/task_worklet.cc
    • third_party/blink/renderer/core/workers/experimental/worker_task_queue.cc
  2. Roll src/third_party/chromite 9201a4e1a936..9ab423a548ac (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Monday, 29-Oct-18 19:54:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc2ee01af9160e3c7eb0ef91d5771203065bbb79

    Comments

    Roll src/third_party/chromite 9201a4e1a936..9ab423a548ac (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/9201a4e1a936..9ab423a548ac
    
    
    git log 9201a4e1a936..9ab423a548ac --date=short --no-merges --format='%ad %ae %s'
    2018-10-29 chrome-bot@chromium.org Update config settings by config-updater.
    2018-10-29 hungte@chromium.org Remove amd64-generic-goofy build target.
    2018-10-29 martinroth@chromium.org chromeos_config: disable grunt firmware branch configs
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@9ab423a548ac
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I6a3493cb5bf51996ec2b12f09638cdb8ac40fb04
    Reviewed-on: https://chromium-review.googlesource.com/c/1305853
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#603595}

    Changed files

    • DEPS
  3. Re-enable disabled VR tests

    Changed by bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:52:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28c21fa4ef12dce06b3f63316e307f2d1f37df52

    Comments

    Re-enable disabled VR tests
    
    Re-enables all the VR tests that were marked as flaky now that the
    root cause has been reverted.
    
    TBR=mthiesse@chromium.org
    
    Bug: 894796
    Change-Id: I34c4b8e10edec2e682c450b1b18c2428f3e29473
    Reviewed-on: https://chromium-review.googlesource.com/c/1305211
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603594}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrDeviceTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrTransitionTest.java
  4. Revert "[jumbo] Remove 'using' declaration for mojom::blink::IDBCursor"

    Changed by Chase Phillips - cmpohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:51:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 63debc6587a8e13227953c8a25f3ae7c547711c1

    Comments

    Revert "[jumbo] Remove 'using' declaration for mojom::blink::IDBCursor"
    
    This reverts commit e76b26c998094a9577431f56abeb848bb0255825.
    
    Reason for revert:
    Reverting the "move content/renderer/indexed_db/ to Blink" CL.  This
    commit touches a file that was created by that CL, so reverting it.
    See these bugs for more info:
    https://crbug.com/899446
    https://crbug.com/717812
    
    Original change's description:
    > [jumbo] Remove 'using' declaration for mojom::blink::IDBCursor
    > 
    > The lone 'IDBCursor' can collide with the blink::IDBCursor. Remove the
    > 'using' and specify the namespace instead.
    > 
    > TBR=pwnall@chromium.org
    > 
    > Bug: 717812
    > Change-Id: I092b6d3c30931f45d13fd5c35af24539884fa686
    > Reviewed-on: https://chromium-review.googlesource.com/c/1301434
    > Commit-Queue: Fredrik Söderquist <fs@opera.com>
    > Reviewed-by: Daniel Bratell <bratell@opera.com>
    > Cr-Commit-Position: refs/heads/master@{#603039}
    
    TBR=cmp@chromium.org,bratell@opera.com,fs@opera.com,pwnall@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 717812
    Change-Id: I29d7de9ef16258d9cc2c6b68d5fb4ac2ad449cca
    Reviewed-on: https://chromium-review.googlesource.com/c/1305245
    Commit-Queue: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#603593}

    Changed files

    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
  5. Roll src/third_party/perfetto a56061dd6c20..acda68b0292e (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Monday, 29-Oct-18 19:51:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1cbc41aa9e9bebd7d254933dbd5069163319f23

    Comments

    Roll src/third_party/perfetto a56061dd6c20..acda68b0292e (5 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/a56061dd6c20..acda68b0292e
    
    
    git log a56061dd6c20..acda68b0292e --date=short --no-merges --format='%ad %ae %s'
    2018-10-29 lalitm@google.com trace_processor: overhaul filter and sort system for storage backed tables
    2018-10-29 lalitm@google.com Merge "trace_processor: refactor span table to be a bit cleaner"
    2018-10-29 ilkos@google.com Merge "Expose a stable TraceProcessor API in include/"
    2018-10-29 lalitm@google.com trace_processor: make span joins much more efficient
    2018-10-29 taylori@google.com Add support for more events
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@acda68b0292e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:117588397
    TBR=perfetto-bugs@google.com
    
    Change-Id: I305ab82ce5116e00107f7e7ca9937ecc654f6646
    Reviewed-on: https://chromium-review.googlesource.com/c/1305294
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#603592}

    Changed files

    • DEPS
  6. Mash: Re-enable a test which may no longer be flaky.

    Changed by Evan Stade - estadeohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:49:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b68dde46a6048ababe2d30edf1d4c1879a84aa3a

    Comments

    Mash: Re-enable a test which may no longer be flaky.
    
    test is ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown
    
    Bug: 883371
    Change-Id: I1ce860a5c25e9b6b791be681e98907aed9ffb9bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1305873
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603591}

    Changed files

    • testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
  7. Revert "Remove 'using' directives in web_idb_cursor_impl_unittest.cc"

    Changed by Chase Phillips - cmpohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:36:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e14fc0eec15c68760ac5211e6fc15a08d5ce4635

    Comments

    Revert "Remove 'using' directives in web_idb_cursor_impl_unittest.cc"
    
    This reverts commit 5ac9ece1fe7724339dd76b7827f44a9cc73835c9.
    
    Reason for revert:
    Reverting the "move content/renderer/indexed_db/ to Blink" CL.  This
    commit touches a file that was created by that CL, so reverting it.
    See these bugs for more info:
    https://crbug.com/899446
    https://crbug.com/717812
    
    Original change's description:
    > Remove 'using' directives in web_idb_cursor_impl_unittest.cc
    > 
    > All of the 'blink::*' directives should be unnecessary (now that the code
    > is within Blink.) Remove the testing::StrictMock 'using' too, and just
    > "expand" it at its single usage point.
    > 
    > Change-Id: I3171d05f41364fa134c2ee781e93178d831d4eab
    > Reviewed-on: https://chromium-review.googlesource.com/c/1301458
    > Commit-Queue: Victor Costan <pwnall@chromium.org>
    > Reviewed-by: Victor Costan <pwnall@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#603049}
    
    TBR=fs@opera.com,pwnall@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I10c3fe89cdb7708d8e66978474f6a0299b775af7
    Reviewed-on: https://chromium-review.googlesource.com/c/1305395
    Commit-Queue: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Fredrik Söderquist <fs@opera.com>
    Reviewed-by: Chase Phillips <cmp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603590}

    Changed files

    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
  8. Fix arrow button issue in tablet mode

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:36:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision edccc9b7128aee9bb555c1c03985ed4be6bb6c06

    Comments

    Fix arrow button issue in tablet mode
    
    Changes:
    Only reset views::FocusManager::arrow_key_traversal_enabled_ when power
    button menu is shown before.
    
    Bug: 898716
    Change-Id: I01de4fe8b9438e75d1104997aa0e90c61ae52dd2
    Reviewed-on: https://chromium-review.googlesource.com/c/1300685
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Reviewed-by: Min Chen <minch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603589}

    Changed files

    • ash/app_list/views/app_list_view.cc
    • ash/app_list/views/app_list_view.h
    • ash/system/power/power_button_controller.cc
    • ash/system/power/power_button_controller.h
    • ui/views/focus/focus_manager.cc
    • ui/views/focus/focus_manager.h
  9. Make sure DRP is disabled when incognito

    Changed by Clark DuVall - cduvallohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:34:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 05faba13cd28021efa0499ae1eab3986d92bf96b

    Comments

    Make sure DRP is disabled when incognito
    
    Creating an incognito window was crashing when DRP was enabled with
    network service.
    
    Bug: 721403
    Change-Id: I7c97fec3e6dd4b15358c73eb442f441caa45f5af
    Reviewed-on: https://chromium-review.googlesource.com/c/1305515
    Reviewed-by: rajendrant <rajendrant@chromium.org>
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603588}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/net/spdyproxy/data_reduction_proxy_browsertest.cc
  10. [AF] Add methods to set wallet data independently from the metadata.

    Changed by sebsg - sebsgohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:31:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0fdad893c8889305deafb6f08d7fd1ca18df5231

    Comments

    [AF] Add methods to set wallet data independently from the metadata.
    
    Change-Id: Ic290185b178ce9944b471d3cfa404684c3ce8aaa
    Reviewed-on: https://chromium-review.googlesource.com/c/1303881
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Jan Krcal <jkrcal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603587}

    Changed files

    • components/autofill/core/browser/webdata/autofill_table.cc
    • components/autofill/core/browser/webdata/autofill_table.h
    • components/autofill/core/browser/webdata/autofill_table_unittest.cc
  11. Smart Lock: Remove RecordClickOnLockIcon.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 218f9a3be029f649fad25e02d89abdd42affed18

    Comments

    Smart Lock: Remove RecordClickOnLockIcon.
    
    This was only used for the EasyUnlock trial which is currently unused
    and about to be removed.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: Ic3b7271a386d26728e7af4e4ea56dfdd6b19c675
    Reviewed-on: https://chromium-review.googlesource.com/c/1302696
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603586}

    Changed files

    • ash/login/login_screen_controller.cc
    • ash/login/login_screen_controller.h
    • ash/login/login_screen_controller_unittest.cc
    • ash/login/mock_login_screen_client.h
    • ash/public/interfaces/login_screen.mojom
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.h
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler_unittest.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
    • chrome/browser/chromeos/login/lock/views_screen_locker.cc
    • chrome/browser/chromeos/login/lock/views_screen_locker.h
    • chrome/browser/chromeos/login/screens/user_selection_screen.cc
    • chrome/browser/chromeos/login/screens/user_selection_screen.h
    • chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
    • chrome/browser/chromeos/login/ui/login_display_host_mojo.h
    • chrome/browser/ui/ash/login_screen_client.cc
    • chrome/browser/ui/ash/login_screen_client.h
    • chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc
    • chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h
  12. Clear scroll anchor when saving scroll state

    Changed by Patrick Noland - pnolandohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:27:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3f9f0c8dfeeabd6e4b498189d7cbaf83f12e5f65

    Comments

    Clear scroll anchor when saving scroll state
    
    When saved scroll state is changed, any saved scroll anchor is now
    stale. This usually doesn't matter, but can bite us in the case of same
    document loads, where we can mistakenly restore a saved scroll anchor
    even after scrolling the page manually. To fix this, we clear the stale
    anchor. It will still get saved before navigating away from the page.
    
    Bug: 898142
    Change-Id: Ia3a10e54f732d97bd9ebf2162c0f30c9e079280f
    Reviewed-on: https://chromium-review.googlesource.com/c/1298476
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Commit-Queue: Patrick Noland <pnoland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603585}

    Changed files

    • third_party/blink/renderer/core/loader/frame_loader.cc
    • third_party/blink/renderer/core/loader/programmatic_scroll_test.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  13. Omnibox: Make a single Ctrl+L reveal the full URL

    Changed by Tommy C. Li - tommycliohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:23:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 575dc09174cfeff0f04ac4b9b27733b584cfea57

    Comments

    Omnibox: Make a single Ctrl+L reveal the full URL
    
    After this CL, a single Ctrl+L will reveal the full URL.
    
    This applies to beth Query in Omnibox and Steady State Elisions.
    
    This CL also adds a unit test, as well as an internal-only killswitch
    in case we need to remotely disable this feature.
    
    Bug: 874592, 882348
    Change-Id: I6bce176e613b46bfc9b6ce524ddf855bdb14f399
    Reviewed-on: https://chromium-review.googlesource.com/c/1285511
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603584}

    Changed files

    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/omnibox/omnibox_view_views.cc
    • chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
    • components/omnibox/browser/omnibox_edit_model.cc
    • components/omnibox/browser/omnibox_edit_model.h
    • components/omnibox/browser/omnibox_edit_model_unittest.cc
    • components/omnibox/browser/omnibox_view.h
    • components/omnibox/browser/test_toolbar_model.cc
    • components/omnibox/browser/test_toolbar_model.h
  14. Rename CBOR files to match the newly renamed classes.

    Changed by Adam Langley - aglohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:23:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0e46cdf7ba25f893a0ec409bdc01a95193ade36

    Comments

    Rename CBOR files to match the newly renamed classes.
    
    CBOR{Reader|Writer|Value} were renamed in b4f12f9a to remove the “CBOR”
    prefix. This change reflects that in the filenames.
    
    (TBR for webpackage code since this is just renaming headers of
    an underlying library.)
    
    TBR=kinuko@chromium.org
    
    Change-Id: I0262c827181fe8ab51cd08ad41fce14aa1aed331
    Reviewed-on: https://chromium-review.googlesource.com/c/1303177
    Commit-Queue: Adam Langley <agl@chromium.org>
    Reviewed-by: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603583}

    Changed files

    • components/cbor/BUILD.gn
    • components/cbor/constants.h
    • components/cbor/reader.cc
    • components/cbor/reader.h
    • components/cbor/reader_fuzzer.cc
    • components/cbor/reader_fuzzer_corpus/cbor0
    • components/cbor/reader_fuzzer_corpus/cbor1
    • components/cbor/reader_fuzzer_corpus/cbor10
    • components/cbor/reader_fuzzer_corpus/cbor11
    • components/cbor/reader_fuzzer_corpus/cbor12
    • components/cbor/reader_fuzzer_corpus/cbor13
    • components/cbor/reader_fuzzer_corpus/cbor14
    • components/cbor/reader_fuzzer_corpus/cbor15
    • components/cbor/reader_fuzzer_corpus/cbor16
    • components/cbor/reader_fuzzer_corpus/cbor17
    • components/cbor/reader_fuzzer_corpus/cbor18
    • components/cbor/reader_fuzzer_corpus/cbor19
    • components/cbor/reader_fuzzer_corpus/cbor2
    • components/cbor/reader_fuzzer_corpus/cbor20
    • components/cbor/reader_fuzzer_corpus/cbor21
    • components/cbor/reader_fuzzer_corpus/cbor22
    • components/cbor/reader_fuzzer_corpus/cbor23
    • components/cbor/reader_fuzzer_corpus/cbor24
    • components/cbor/reader_fuzzer_corpus/cbor25
    • components/cbor/reader_fuzzer_corpus/cbor26
    • components/cbor/reader_fuzzer_corpus/cbor27
    • components/cbor/reader_fuzzer_corpus/cbor28
    • components/cbor/reader_fuzzer_corpus/cbor29
    • components/cbor/reader_fuzzer_corpus/cbor3
    • components/cbor/reader_fuzzer_corpus/cbor30
    • components/cbor/reader_fuzzer_corpus/cbor31
    • components/cbor/reader_fuzzer_corpus/cbor32
    • components/cbor/reader_fuzzer_corpus/cbor33
    • components/cbor/reader_fuzzer_corpus/cbor34
    • components/cbor/reader_fuzzer_corpus/cbor35
    • components/cbor/reader_fuzzer_corpus/cbor36
    • components/cbor/reader_fuzzer_corpus/cbor37
    • components/cbor/reader_fuzzer_corpus/cbor38
    • components/cbor/reader_fuzzer_corpus/cbor39
    • components/cbor/reader_fuzzer_corpus/cbor4
    • components/cbor/reader_fuzzer_corpus/cbor40
    • components/cbor/reader_fuzzer_corpus/cbor41
    • components/cbor/reader_fuzzer_corpus/cbor42
    • components/cbor/reader_fuzzer_corpus/cbor43
    • components/cbor/reader_fuzzer_corpus/cbor44
    • components/cbor/reader_fuzzer_corpus/cbor45
    • components/cbor/reader_fuzzer_corpus/cbor46
    • components/cbor/reader_fuzzer_corpus/cbor47
    • components/cbor/reader_fuzzer_corpus/cbor48
    • components/cbor/reader_fuzzer_corpus/cbor49
    • components/cbor/reader_fuzzer_corpus/cbor5
    • components/cbor/reader_fuzzer_corpus/cbor50
    • components/cbor/reader_fuzzer_corpus/cbor51
    • components/cbor/reader_fuzzer_corpus/cbor52
    • components/cbor/reader_fuzzer_corpus/cbor53
    • components/cbor/reader_fuzzer_corpus/cbor54
    • components/cbor/reader_fuzzer_corpus/cbor55
    • components/cbor/reader_fuzzer_corpus/cbor56
    • components/cbor/reader_fuzzer_corpus/cbor57
    • components/cbor/reader_fuzzer_corpus/cbor58
    • components/cbor/reader_fuzzer_corpus/cbor59
    • components/cbor/reader_fuzzer_corpus/cbor6
    • components/cbor/reader_fuzzer_corpus/cbor60
    • components/cbor/reader_fuzzer_corpus/cbor61
    • components/cbor/reader_fuzzer_corpus/cbor62
    • components/cbor/reader_fuzzer_corpus/cbor63
    • components/cbor/reader_fuzzer_corpus/cbor64
    • components/cbor/reader_fuzzer_corpus/cbor65
    • components/cbor/reader_fuzzer_corpus/cbor66
    • components/cbor/reader_fuzzer_corpus/cbor67
    • components/cbor/reader_fuzzer_corpus/cbor68
    • components/cbor/reader_fuzzer_corpus/cbor69
    • components/cbor/reader_fuzzer_corpus/cbor7
    • components/cbor/reader_fuzzer_corpus/cbor70
    • components/cbor/reader_fuzzer_corpus/cbor71
    • components/cbor/reader_fuzzer_corpus/cbor72
    • components/cbor/reader_fuzzer_corpus/cbor73
    • components/cbor/reader_fuzzer_corpus/cbor74
    • components/cbor/reader_fuzzer_corpus/cbor75
    • components/cbor/reader_fuzzer_corpus/cbor76
    • components/cbor/reader_fuzzer_corpus/cbor77
    • components/cbor/reader_fuzzer_corpus/cbor78
    • components/cbor/reader_fuzzer_corpus/cbor79
    • components/cbor/reader_fuzzer_corpus/cbor8
    • components/cbor/reader_fuzzer_corpus/cbor80
    • components/cbor/reader_fuzzer_corpus/cbor81
    • components/cbor/reader_fuzzer_corpus/cbor9
    • components/cbor/reader_unittest.cc
    • components/cbor/values.cc
    • components/cbor/values.h
    • components/cbor/values_unittest.cc
    • components/cbor/writer.cc
    • components/cbor/writer.h
    • components/cbor/writer_unittest.cc
    • content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
    • content/browser/web_package/signed_exchange_certificate_chain.cc
    • content/browser/web_package/signed_exchange_certificate_chain_unittest.cc
    • content/browser/web_package/signed_exchange_envelope.cc
    • content/browser/web_package/signed_exchange_envelope_unittest.cc
    • content/browser/webauth/authenticator_impl_unittest.cc
    • device/fido/attestation_object.cc
    • device/fido/attestation_statement.h
    • device/fido/attestation_statement_formats.h
    • device/fido/attestation_statement_formats_unittest.cc
    • device/fido/attested_credential_data.cc
    • device/fido/authenticator_data.cc
    • device/fido/authenticator_data.h
    • device/fido/authenticator_get_assertion_response.cc
    • device/fido/authenticator_get_info_response.cc
    • device/fido/authenticator_supported_options.h
    • device/fido/cable/fido_cable_handshake_handler.cc
    • device/fido/cable/fido_cable_handshake_handler_unittest.cc
    • device/fido/ctap_get_assertion_request.cc
    • device/fido/ctap_make_credential_request.cc
    • device/fido/ctap_response_unittest.cc
    • device/fido/device_response_converter.cc
    • device/fido/ec_public_key.cc
    • device/fido/mac/credential_metadata.cc
    • device/fido/mac/util.mm
    • device/fido/opaque_attestation_statement.cc
    • device/fido/opaque_attestation_statement.h
    • device/fido/public_key_credential_descriptor.h
    • device/fido/public_key_credential_params.h
    • device/fido/public_key_credential_rp_entity.h
    • device/fido/public_key_credential_user_entity.h
    • device/fido/virtual_ctap2_device.cc
    • device/fido/virtual_ctap2_device.h
  15. [BrowserSwitcher] Download IE Enterprise Mode SiteList if configured

    Changed by Nicolas Ouellet-Payeur - nicolasoohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:20:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0637edbd49bc89e86d34c06927d6a4babb050a43

    Comments

    [BrowserSwitcher] Download IE Enterprise Mode SiteList if configured
    
    Adds the "browser_switcher.use_ie_sitelist" boolean pref. When set to
    true, BrowserSwitcherService will download IE's sitelist after 60s.
    
    Once the sitelist XML is downloaded, the rules are parsed and applied.
    
    Bug: 884837
    Change-Id: Ib7a6c374526c56c42265187667ea2d6febc3628b
    Reviewed-on: https://chromium-review.googlesource.com/c/1286288
    Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
    Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603582}

    Changed files

    • chrome/browser/browser_switcher/browser_switcher_prefs.cc
    • chrome/browser/browser_switcher/browser_switcher_prefs.h
    • chrome/browser/browser_switcher/browser_switcher_service.cc
    • chrome/browser/browser_switcher/browser_switcher_service.h
    • chrome/browser/browser_switcher/browser_switcher_service_browsertest.cc
    • chrome/browser/browser_switcher/browser_switcher_service_factory.cc
    • chrome/browser/browser_switcher/ieem_sitelist_parser.cc
    • chrome/browser/browser_switcher/ieem_sitelist_parser.h
    • chrome/test/BUILD.gn
    • tools/traffic_annotation/summary/annotations.xml
  16. [libFuzzer][Windows][LPM] Enable skia_image_filter_proto_fuzzer

    Changed by Jonathan Metzman - metzmanohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:19:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59816a6e7bde955ee9c2bf4785e1c581df18823c

    Comments

    [libFuzzer][Windows][LPM] Enable skia_image_filter_proto_fuzzer
    
    Get it building and enable it on Windows to increase our coverage of
    skia on Windows.
    
    Change-Id: If88d332d8dcc2fb39e80850a654682fc92530aed
    Reviewed-on: https://chromium-review.googlesource.com/c/1305208
    Reviewed-by: Abhishek Arya <inferno@chromium.org>
    Commit-Queue: Jonathan Metzman <metzman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603581}

    Changed files

    • testing/libfuzzer/fuzzers/BUILD.gn
    • testing/libfuzzer/proto/BUILD.gn
    • testing/libfuzzer/proto/skia_image_filter_proto_converter.cc
  17. [Android] Disable failing synthetic_gestures/smooth-scroll-tiny-delta.html

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:18:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c6dfba778151ac1ea2a2c9c154ea835bfa78f72a

    Comments

    [Android] Disable failing synthetic_gestures/smooth-scroll-tiny-delta.html
    
    This test was added by https://crrev.com/c/1293171 and it is failing on
    KitKat Phone Tester (dbg) builder:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Phone%20Tester%20%28dbg%29/10119
    
    TBR=bokan@chromium.org
    
    Bug: 898987
    Change-Id: I82fe04a5d11cbe09a2794fc6daadb33ce5b1463e
    Reviewed-on: https://chromium-review.googlesource.com/c/1305316
    Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603580}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  18. Use fake cros component manager in crostini browser tests

    Changed by Toni Barzic - tbarzicohnoyoudont@google.com
    Changed at Monday, 29-Oct-18 19:16:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76a48daef0a3dcb935909cf42988e7520f177bf4

    Comments

    Use fake cros component manager in crostini browser tests
    
    Updates crostini installer browser test setup to use fake cros component
    manager implementation.
    
    BUG=None
    TEST=cq passes
    
    Change-Id: I85e19ffeade2a932678ddaee92db8329b0bde426
    Reviewed-on: https://chromium-review.googlesource.com/c/1303036
    Reviewed-by: Nicholas Verne <nverne@chromium.org>
    Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603579}

    Changed files

    • chrome/browser/ui/views/crostini/crostini_browser_test_util.cc
    • chrome/browser/ui/views/crostini/crostini_browser_test_util.h
    • chrome/browser/ui/views/crostini/crostini_installer_view_browsertest.cc
    • chrome/browser/ui/views/crostini/crostini_uninstaller_view_browsertest.cc
    • chrome/browser/ui/views/crostini/crostini_upgrade_view_browsertest.cc
  19. [LayoutTestViewer] Add support for AUDIO

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:15:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65f5d3e1d5563898d676bec91a9f102c29bb266e

    Comments

    [LayoutTestViewer] Add support for AUDIO
    
    Bug: 898212
    Change-Id: I83a8f9e355f2b527db8eabfba40625f60a78822f
    Reviewed-on: https://chromium-review.googlesource.com/c/1303949
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603578}

    Changed files

    • third_party/WebKit/LayoutTests/fast/harness/results.html
  20. Use kOnDemand for MediaStream if player starts in PIP.

    Changed by liberato@chromium.org - liberatoohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:08:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 44dd0d00462700e2db1497302b9db8ea99d6499b

    Comments

    Use  kOnDemand for MediaStream if player starts in PIP.
    
    This fixes SurfaceLayer kOnDemand mode to work with
    webmediaplayer_ms when the player starts in PIP.
    
    Previously, the player wouldn't use SurfaceLayer, since it would
    wait to enter PIP.  Now, it checks if the client is already in PIP,
    and switches to SurfaceLayer immediately in kOnDemand mode.
    
    Bug: 891619
    Change-Id: I669003b512152cc22c3e0d1f7d69133304669108
    Reviewed-on: https://chromium-review.googlesource.com/c/1301958
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603577}

    Changed files

    • content/renderer/media/stream/webmediaplayer_ms.cc
  21. Create TouchSelectionMenuViews to separate Menu

    Changed by David Jacobo - djacoboohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:02:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a0f2af84c082c3deccd2355e6c82bffda0ec6e6

    Comments

    Create TouchSelectionMenuViews to separate Menu
    
    views::TouchSelectionMenuRunnerViews::Menu should be better by
    separating it on their own class, this CL introduces
    TouchSelectionMenuViews.
    
    Bug: None
    Test: Build.
    Change-Id: I6e23c379abc7eb746713dde1b9224389a98014e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1300054
    Commit-Queue: David Jacobo <djacobo@chromium.org>
    Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603576}

    Changed files

    • chrome/browser/ui/views/touch_selection_menu_chromeos.cc
    • chrome/browser/ui/views/touch_selection_menu_chromeos.h
    • ui/views/BUILD.gn
    • ui/views/touchui/touch_selection_menu_runner_views.cc
    • ui/views/touchui/touch_selection_menu_runner_views.h
    • ui/views/touchui/touch_selection_menu_views.cc
    • ui/views/touchui/touch_selection_menu_views.h
  22. Suppress WebGL tests failures after roll to 0d55c88

    Changed by Yuly Novikov - ynovikovohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 19:01:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 852a784464f1f02a55b4edb2fd452a56a45c1b7a

    Comments

    Suppress WebGL tests failures after roll to 0d55c88
    
    conformance2/vertex_arrays/vertex-array-object-and-disabled-attributes.html
    on Linux AMD
    
    conformance/attribs/gl-disabled-vertex-attrib-update.html
    on Nexus 5
    
    conformance/reading/fbo-remains-unchanged-after-read-pixels.html
    conformance/reading/read-pixels-pack-alignment.html
    conformance/reading/read-pixels-test.html
    on Nexus 6
    
    TBR=kbr@chromium.org
    
    Bug: 899754
    Change-Id: Icb1db2a029fa20897baf925609a2ed4dd00cf132
    Reviewed-on: https://chromium-review.googlesource.com/c/1305206
    Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603575}

    Changed files

    • content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
    • content/test/gpu/gpu_tests/webgl_conformance_expectations.py
  23. Roll src/third_party/pdfium b7c4a0243e82..ea08d171755b (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Monday, 29-Oct-18 18:45:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 348cfae7792d32736661761102552f7928731cba

    Comments

    Roll src/third_party/pdfium b7c4a0243e82..ea08d171755b (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/b7c4a0243e82..ea08d171755b
    
    
    git log b7c4a0243e82..ea08d171755b --date=short --no-merges --format='%ad %ae %s'
    2018-10-29 tsepez@chromium.org Fold virtual CPWL_Wnd::OnCreate into subclass constructors.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@ea08d171755b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I30edbacb27ea609d7357f68f0ce62e43b1f55316
    Reviewed-on: https://chromium-review.googlesource.com/c/1305295
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#603574}

    Changed files

    • DEPS
  24. Revert "Oilpan: Enable HeapCompaction for incremental marking"

    Changed by Yuly Novikov - ynovikovohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 18:33:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0ce72e129d923a9f4a6ff0eae3c599b25fdb8d36

    Comments

    Revert "Oilpan: Enable HeapCompaction for incremental marking"
    
    This reverts commit 10a10dd9fde23fa0f038c83fa9940ea69afcae2a.
    
    Reason for revert: Suspected for flaky crashes affecting Chromium CQ.
    
    Original change's description:
    > Oilpan: Enable HeapCompaction for incremental marking
    > 
    > Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC.
    > 
    > Bug: 864425
    > 
    > Change-Id: I1fb04d7c501a8519e106237946f86f52eb7ce8f8
    > Reviewed-on: https://chromium-review.googlesource.com/c/1297782
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Commit-Queue: Keishi Hattori <keishi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#603477}
    
    TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org
    
    Change-Id: Ie72a2eb04571945b3515ee7374a75a1ab87275c2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 864425, 899809
    Reviewed-on: https://chromium-review.googlesource.com/c/1305833
    Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603573}

    Changed files

    • third_party/blink/renderer/platform/heap/heap_compact.cc
  25. Queue all output by default

    Changed by David Tseng - dtsengohnoyoudont@chromium.org
    Changed at Monday, 29-Oct-18 18:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e722fb87ec7e75c8c7538984c90dfbf8bd58a299

    Comments

    Queue all output by default
    
    ChromeVox has "force flush" behavior when it receives user input via qwerty keys, braille keys, and touch (explore/gestures).
    It also has programmatic queue behaviors via Output.withQueueMode.
    By default, ChromeVox is ready to queue all other output.
    
    This will help ChromeVox be flexible when receiving events and not dropping output. For example, when pressing Ctrl+l, we receive focus on the omnibox and quickly after, a selection event on the listbox option auto completion.
    
    This is a separate change to ensure we don't miss any corner cases and have to revert.
    
    Test: existing tests/manually on omnibox.
    Change-Id: Iba069c5794fe8cc2b3318c64a87dbd4cc7df6385
    Reviewed-on: https://chromium-review.googlesource.com/c/1302414
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603572}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
    • chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js