Builder android-rel Build 7348
Results:
Success
Trigger Info:
Project | chromium |
Revision | 912a5885f3594d9987fd495c4b3c4960dcecf8c1 |
Got Revision | 912a5885f3594d9987fd495c4b3c4960dcecf8c1 |
Execution:
- Source: Task 4293b7868a51d410
- Bot: swarm581-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 237 ms ) read test spec (chromium.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.json
-
( 468 ms ) lookup GN argsis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = truestrip_debug_info = truesymbol_level = 1target_os = "android"use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm581-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548250119479109, "id": "8923535798675804128", "project": "chromium", "tags": ["builder:android-rel", "buildset:commit/git/912a5885f3594d9987fd495c4b3c4960dcecf8c1", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/912a5885f3594d9987fd495c4b3c4960dcecf8c1", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088965860739406464", "scheduler_job_id:chromium/android-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "android-rel" | setup_build |
buildnumber | 7348 | setup_build |
mastername | "chromium" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "912a5885f3594d9987fd495c4b3c4960dcecf8c1" | setup_build |
got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "912a5885f3594d9987fd495c4b3c4960dcecf8c1" | bot_update |
got_revision_cp | "refs/heads/master@{#625179}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "f6929d6c3888a08d5cf55534c7bf4a57ddc59f4a" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.488@{#1}" | bot_update |
got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
Blamelist:
- Mario Sanchez Prada (marioohnoyoudont@igalia.com)
- Dominic Battre (battreohnoyoudont@chromium.org)
- Antonio Gomes (tonikitooohnoyoudont@igalia.com)
- Mario Sanchez Prada (marioohnoyoudont@igalia.com)
- Simon Que (squeohnoyoudont@google.com)
- Zakhar Voit (voitohnoyoudont@google.com)
Timing:
Create | Wednesday, 23-Jan-19 13:28:39 UTC |
Start | Wednesday, 23-Jan-19 13:28:42 UTC |
End | Wednesday, 23-Jan-19 13:53:19 UTC |
Pending | 2 secs |
Execution | 24 mins 37 secs |
All Changes:
-
Move MutableProfileOAuth2TokenServiceDelegate to //components
Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com Changed at Wednesday, 23-Jan-19 13:27:11 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 912a5885f3594d9987fd495c4b3c4960dcecf8c1 Comments
Move MutableProfileOAuth2TokenServiceDelegate to //components Following the cleanup to remove any dependency on includes from //content, let's move this delegate of ProfileOAuth2TokenService into //components now as necessary step in the direction of hiding the PO2TS delegates behind the IdentityManager. Bug: 922555 Change-Id: I6b54723b232efea24a7001a2f7e25733ccbbabb7 Reviewed-on: https://chromium-review.googlesource.com/c/1425500 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#625179}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/signin/dice_response_handler_unittest.cc
- chrome/browser/signin/profile_oauth2_token_service_factory.cc
- chrome/test/BUILD.gn
- components/signin/core/browser/BUILD.gn
- components/signin/core/browser/mutable_profile_oauth2_token_service_delegate.cc
- components/signin/core/browser/mutable_profile_oauth2_token_service_delegate.h
- components/signin/core/browser/mutable_profile_oauth2_token_service_delegate_unittest.cc
-
Don't record first filling result for sign-in forms
Changed by Dominic Battre - battreohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 13:25:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 34d69265b1f1f5a3c7739827a0b7e05bfc928e08 Comments
Don't record first filling result for sign-in forms The new form parser may decide that a form has no current-password element, but only new-password / confirmation elements. In this case, the parser sets the unique_renderer_id to 'undefined'. The credentials will be sent to the renderer for filling via manual fallback but the renderer won't ever fill (as there is no password element defined for filling. This CL ensures that this case does not get recorded as a failure to fill. This is important because we record two metrics about the first fill attempt: PasswordManager.FirstWaitForUsernameReason and PasswordManager.FirstRendererFillingResult For websites that have a sign-up form followed by a sign-in form, we don't want to record the failure to fill on the sign-up form. Bug: 918846 Change-Id: I79e9a73ae3573a81e121eaa483e0ecef0889184f Reviewed-on: https://chromium-review.googlesource.com/c/1422018 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#625178}
Changed files
- chrome/renderer/autofill/password_autofill_agent_browsertest.cc
- components/autofill/content/renderer/password_autofill_agent.cc
- components/password_manager/core/browser/password_form_filling.cc
- components/password_manager/core/browser/password_form_filling_unittest.cc
-
[s13n] Convert c/b/ui/webui/signin/dice_turn_sync_on_helper.cc away from PO2TS
Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com Changed at Wednesday, 23-Jan-19 13:25:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e9bbcd81e6f9f2086c387ea62a419b12c36b2317 Comments
[s13n] Convert c/b/ui/webui/signin/dice_turn_sync_on_helper.cc away from PO2TS This is the second out of 2 CLs that migrate DiceTurnSyncOnHelper to IdentityManager. The first part [1] migrated it away from using SigninManager APIs directly. [1] https://chromium-review.googlesource.com/c/1387393 Additionally, the CL also takes the opportunity to remove AccountTrackerService usage, and replace the PO2TSObserver inheritance by IdentityManagerObserver. Both SigninManager and PO2TS are becoming implementation details of the new IdentityManager API. This CL migrates the direct PO2TS API calls to their respective IdentityManager APIs. BUG=890811,922789 Change-Id: I928390d4a336a6b42f56661586c90b3d2f5d4635 Reviewed-on: https://chromium-review.googlesource.com/c/1426457 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625177}
Changed files
- chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
- chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h
-
Remove references to SigninManagerBase from ios_web_view::ApplicationContext
Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com Changed at Wednesday, 23-Jan-19 13:22:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4e5e1c0d1f29da47df3e3b05d19be0903b27165e Comments
Remove references to SigninManagerBase from ios_web_view::ApplicationContext Add a new static SigninManagerFactory::RegisterPrefs() method to the relevant factory for //ios/web_view, have it call SigninManagerBase::RegisterPrefs() instead and call that static method from ios_web_view::ApplicationContext, similar to what's already done in //chrome and //ios//chrome. Bug: 920191 Change-Id: If8f1c86b4f0dc069fe66aa013235d9e695543a2b Reviewed-on: https://chromium-review.googlesource.com/c/1425733 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625176}
Changed files
- ios/web_view/internal/app/application_context.mm
- ios/web_view/internal/signin/web_view_signin_manager_factory.h
- ios/web_view/internal/signin/web_view_signin_manager_factory.mm
-
infra: Add Chromium Win Goma RBE ToT builder
Changed by Simon Que - squeohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 13:19:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9f00d598c8e00e58450d65c219766899f1d4ad1a Comments
infra: Add Chromium Win Goma RBE ToT builder Bug: 922354 Change-Id: I0d168efeea407409ab234bdcb1ebf307a9c7b551 Reviewed-on: https://chromium-review.googlesource.com/c/1426248 Reviewed-by: Shinya Kawanaka <shinyak@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#625175}
Changed files
- infra/config/global/cr-buildbucket.cfg
- infra/config/global/luci-milo.cfg
- infra/config/global/luci-scheduler.cfg
- tools/mb/mb_config.pyl
-
[Managed Session] Force managed sessions mode when network certificates are set via ONC device policy
Changed by Zakhar Voit - voitohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 13:04:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9b849d6be98e33a73d64dcb742a18910c8a42528 Comments
[Managed Session] Force managed sessions mode when network certificates are set via ONC device policy The same way as force-installed extensions, forced network certificates are considered "risky" should activate "Managed Session" mode (i.e. show warning about admin capabilities on the login page). Bug: 910218 Change-Id: Ic34898ed255f51b48b948b00ae4563bcd7939347 Reviewed-on: https://chromium-review.googlesource.com/c/1391590 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#625174}
Changed files
- chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
- chrome/browser/chromeos/policy/device_local_account_browsertest.cc