Home | Search | chromium - Builders
Login

Builder android-marshmallow-arm64-rel Build 9884 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionacf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6
Got Revisionacf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

Execution:

Steps and Logfiles:

Show:
  1. ( 422 ms ) setup_build
    running recipe: "chromium"
  2. ( 242 ms ) report builders
     
    running builder/tester 'android-marshmallow-arm64-rel' on master 'chromium.android'
  3. ( 1 mins 5 secs ) bot_update
    [122GB/295GB used (41%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 21 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  7. ( 4 secs ) clean local files
  8. ( 682 ms ) tree truth steps
  9. ( 558 ms ) lookup GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    strip_debug_info = true
    symbol_level = 1
    target_cpu = "arm64"
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  10. ( 56 secs ) generate_build_files
  11. ( 14 mins 27 secs ) compile
  12. ( 1 mins 41 secs ) compile confirm no-op
  13. ( 4 mins 12 secs ) isolate tests
  14. ( 482 ms ) find isolated tests
  15. ( 1 secs ) wait for tasks
  16. ( 35 secs ) net_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:12:30.668339 (shard #1)
    Min shard duration: 0:10:58.898910 (shard #2)
  17. ( 2 secs ) media_service_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  18. ( 6 secs ) base_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:06:23.039509
  19. ( 2 secs ) midi_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 44s
  20. ( 2 secs ) capture_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:05.294236
  21. ( 2 secs ) gl_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 46s
  22. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 55s
  23. ( 2 secs ) wtf_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 54s
  24. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 44s
  25. ( 2 secs ) cast_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:02.658911
  26. ( 2 secs ) latency_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 46s
  27. ( 2 secs ) mojo_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:32.803770
  28. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 46s
  29. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 27s
  30. ( 2 secs ) blink_common_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  31. ( 2 secs ) ipc_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:10:59.963527
  32. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:10.130124
  33. ( 3 secs ) breakpad_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 24s
  34. ( 7 secs ) angle_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:11.965936
  35. ( 2 secs ) url_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 44s
  36. ( 2 secs ) crypto_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 47s
  37. ( 2 secs ) display_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  38. ( 2 secs ) gin_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 46s
  39. ( 2 secs ) sql_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  40. ( 1 secs ) wait for tasks (2)
  41. ( 4 secs ) blink_platform_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:15.319175
  42. ( 7 secs ) gpu_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:57.481452
  43. ( 2 secs ) ui_base_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:20.976321
  44. ( 2 secs ) blink_heap_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:47.931440
  45. ( 2 secs ) google_apis_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 57s
  46. ( 2 secs ) gl_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:08.633403
  47. ( 2 secs ) perfetto_content_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:34.303485
  48. ( 3 secs ) media_blink_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:08.922204
  49. ( 2 secs ) jingle_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 59s
  50. ( 2 secs ) vr_pixeltests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:31.610339
  51. ( 3 secs ) viz_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:39.585839
  52. ( 1 secs ) monochrome_apk_checker on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 20s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  53. ( 2 secs ) gcm_unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:33.278096
  54. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 44s
  55. ( 3 secs ) device_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:31.685367
  56. ( 7 secs ) gfx_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:02.395675
  57. ( 5 secs ) cc_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:50.098300
  58. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 43s
  59. ( 1 secs ) components_perftests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:57.831748
    Total tests: n/a
     
  60. ( 3 secs ) storage_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:31.150242
  61. ( 2 secs ) android_webview_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:22.987200
  62. ( 2 secs ) skia_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  63. ( 4 secs ) services_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:47.181545
  64. ( 3 secs ) events_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:05.305286
  65. ( 2 secs ) ui_android_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  66. ( 3 secs ) vr_common_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:38.392230
  67. ( 1 secs ) wait for tasks (3)
  68. ( 2 secs ) components_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:05:55.977222
  69. ( 8 secs ) media_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:06:04.228389
  70. ( 8 secs ) content_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:06:06.456713 (shard #1)
    Min shard duration: 0:05:19.889942 (shard #0)
  71. ( 8 secs ) wait for tasks (4)
  72. ( 3 secs ) content_shell_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:07:54.147673 (shard #2)
    Min shard duration: 0:07:12.657383 (shard #1)
  73. ( 59 secs ) wait for tasks (5)
  74. ( 3 secs ) chrome_public_test_vr_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:08:43.403954 (shard #0)
    Min shard duration: 0:08:05.681177 (shard #1)
  75. ( 15 secs ) components_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:09:09.487566 (shard #2)
    Min shard duration: 0:07:25.840370 (shard #1)
  76. ( 943 ms ) wait for tasks (6)
  77. ( 12 secs ) webkit_unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:08:22.293313 (shard #0)
    Min shard duration: 0:07:33.048946 (shard #1)
  78. ( 921 ms ) wait for tasks (7)
  79. ( 4 secs ) webview_instrumentation_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:09:12.888640 (shard #2)
    Min shard duration: 0:07:49.388551 (shard #6)
  80. ( 1 mins 5 secs ) wait for tasks (8)
  81. ( 2 secs ) telemetry_perf_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:09:15.534712 (shard #9)
    Min shard duration: 0:05:28.159774 (shard #4)
    Total tests: 281
    * Passed: 207 (207 expected, 0 unexpected)
    * Skipped: 74 (74 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  82. ( 5 secs ) unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:10:37.635197 (shard #2)
    Min shard duration: 0:06:46.821051 (shard #1)
  83. ( 4 mins 1 secs ) wait for tasks (9)
  84. ( 12 secs ) content_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:14:50.165629 (shard #7)
    Min shard duration: 0:09:20.915714 (shard #2)
  85. ( 21 mins 49 secs ) mojo_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:37:11.948674
  86. ( 932 ms ) Tests statistics
     
    Stats
    Total shards: 110
    Total runtime: 10:06:36.326191
     
  87. ( 1 secs ) test_report
  88. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1596-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541780627651901, "id": "8930319552538112368", "project": "chromium", "tags": ["builder:android-marshmallow-arm64-rel", "buildset:commit/git/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095749614755838816", "scheduler_job_id:chromium/android-marshmallow-arm64-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "android-marshmallow-arm64-rel" setup_build
buildnumber 9884 setup_build
mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6" bot_update
got_revision_cp "refs/heads/master@{#606863}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes_refs/heads/master(at){#606863}_without_patch {"android_webview_unittests": "8bf853bc5dfda9de2d827bf5ab1bdffa911df811", "angle_unittests": "56fbbdb28526f6261aa55d60a22e0f52eb1a0015", "base_unittests": "dfc9683baa51bfc943f7ff7b3124045753281899", "blink_common_unittests": "aa84ce0068d26e29b3b1d19b4f88b918cae0c59f", "blink_heap_unittests": "e1e17bbb69d694b7335607fa5d8f9081c1f7d342", "blink_platform_unittests": "ece1097785179f934dc11a2cd1ffb613938991d6", "boringssl_crypto_tests": "63054b9f958e936c48ed810e40e233a0f77dba8e", "boringssl_ssl_tests": "08fb63116601048712543c978bbd69bb1d07b301", "breakpad_unittests": "87fe3a7169081d14f76f86a9c8ef87c2e8702e0e", "cacheinvalidation_unittests": "d31f07a7fb92917a62f1d5895a89f54b8346992e", "capture_unittests": "f99d8a9fd0187f52c350631d83210ba0c4b4dc27", "cast_unittests": "085df03bb17abefb9f2d45834e5493f4f887d93d", "cc_unittests": "5622a2834a78afa9f55cc57156a28239abc2f0b9", "chrome_public_test_apk": "1c6fbd9e0fa4a02474e2610c181925e86498f0cb", "chrome_public_test_vr_apk": "5b46c7476590895fa586a43f83988dbd867271b1", "components_browsertests": "3399dcdfaa27fa983a8f95d511b5d01c99bb5ac5", "components_perftests": "81d0985ab4251d745a651d451f90c73193cc99c2", "components_unittests": "91108546621a71ec6e5c0a2b307e95632a8d359e", "content_browsertests": "1b391b8c73ec04122ec404977a4a0777cc0a7bc0", "content_shell_test_apk": "b4252b3fd435455ac94846c9c30f40f617d6464a", "content_unittests": "36d3f9a26ac3cc823c4141a03ec7e67a22de2ca6", "crypto_unittests": "b3531f0b2073440a48e95e9652e4b58e30393e38", "device_unittests": "8f2e062043a360f1b286c658801ee4b3a6d7777d", "display_unittests": "eee14020f2c02c1823d4c020de23d822a29a8250", "events_unittests": "5de3cc08ba195c0f81f4c1186506ca137febdfda", "gcm_unit_tests": "84e339300e5ad297657eca93f3a5a34e6d7bde4e", "gfx_unittests": "6612f57631becc88bcde27baf1cb658ecf3dc93a", "gin_unittests": "f0c848353f84b4514eef13750e62f4e79945e4ec", "gl_tests": "274a4ab8b2ced6d3ce94ae3d2a320787f35d7341", "gl_unittests": "a413ee6562e6c6a3aac16d3b2ca37a488ef03791", "google_apis_unittests": "bda466550d78acef02480b3ed3549ae5b56bbbe9", "gpu_unittests": "401c74d2bb46fa11939844c280d3bf8362c36736", "ipc_tests": "4b6a889106bd514e131f91619a5ee4b4c0789b7a", "jingle_unittests": "1072c1dfd41b636ee312aa40fd6dbb5528dacc05", "latency_unittests": "4bef8e006dabb5f793656a534b36e18d092c5f20", "libjingle_xmpp_unittests": "1d4dbfe103b2c9633dc53e5126a973ae9dcf52eb", "media_blink_unittests": "5fce4ffee1d989ae84c932f240545e16598527ee", "media_service_unittests": "0d91040c6bbe8aa33f36454417191ac108f6ef7e", "media_unittests": "f5ceed3c0bf5460c12bc421f0133435c569baeb2", "midi_unittests": "59ec04854f1db71fdada516515503ead25cc6d5e", "mojo_test_apk": "fa917a45def5533b8362d3e48d76608a05c1c509", "mojo_unittests": "ae577356b431e17723f0b8c7c1c67c4cd3d518b6", "monochrome_apk_checker": "91050e7b96b8553ec57f7324253dc9ff9f9045e3", "net_unittests": "a7b8e473f23e84dc3ed4116db1079a0868d76fe3", "sandbox_linux_unittests": "8e2382e24783d92f81ce3882ece4a88585d8b856", "services_unittests": "a259a5612701fd9f2daeaf4d6babf484b160ffd8", "shell_dialogs_unittests": "18cebf40568df6566eacd31c368ad76f55de9bfd", "skia_unittests": "4f36cd2a17e27932721ed24c3ff875d6c9e6e697", "sql_unittests": "a1aa31f882201183c9b2aa8d1166b82ef523d1b4", "storage_unittests": "5a169f4824dec20812917cdecc901d402adc7110", "telemetry_perf_unittests": "7e12448eacc46874dfac58bea6086b582df04ac0", "ui_android_unittests": "c4e6af2a72e073af17f3a6fdfc32ca23888182f4", "ui_base_unittests": "ad3e131e5a273b1106de50fd0ba3792190335ab1", "ui_touch_selection_unittests": "9fa0e7a1e2652f482b4c461a50465429a5a04aa1", "unit_tests": "bfb3643d5ff49c98e247c5b2aba6d8fdccf93c62", "url_unittests": "958cc12107495024285c57a92cdb5aa00baff594", "viz_unittests": "8c26d287e2903582eaea5fef30895060c00d3c29", "vr_common_unittests": "6461fecb4378d44268951bd40558861fa9b716a6", "vr_pixeltests": "5f1bbfe8646fa9b7e78038cfdb0432274c29d6cd", "webkit_unit_tests": "c22e612258e6d096f5899b14524b6dc7e0b2c0db", "webview_instrumentation_test_apk": "45bd0fdf976b8dbc4c21b6d84bc44b16901a8f0c", "wtf_unittests": "958a48f27e81944a0c1793e8e965e38cdae38039"} isolate tests
swarm_hashes {"android_webview_unittests": "8bf853bc5dfda9de2d827bf5ab1bdffa911df811", "angle_unittests": "56fbbdb28526f6261aa55d60a22e0f52eb1a0015", "base_unittests": "dfc9683baa51bfc943f7ff7b3124045753281899", "blink_common_unittests": "aa84ce0068d26e29b3b1d19b4f88b918cae0c59f", "blink_heap_unittests": "e1e17bbb69d694b7335607fa5d8f9081c1f7d342", "blink_platform_unittests": "ece1097785179f934dc11a2cd1ffb613938991d6", "boringssl_crypto_tests": "63054b9f958e936c48ed810e40e233a0f77dba8e", "boringssl_ssl_tests": "08fb63116601048712543c978bbd69bb1d07b301", "breakpad_unittests": "87fe3a7169081d14f76f86a9c8ef87c2e8702e0e", "cacheinvalidation_unittests": "d31f07a7fb92917a62f1d5895a89f54b8346992e", "capture_unittests": "f99d8a9fd0187f52c350631d83210ba0c4b4dc27", "cast_unittests": "085df03bb17abefb9f2d45834e5493f4f887d93d", "cc_unittests": "5622a2834a78afa9f55cc57156a28239abc2f0b9", "chrome_public_test_apk": "1c6fbd9e0fa4a02474e2610c181925e86498f0cb", "chrome_public_test_vr_apk": "5b46c7476590895fa586a43f83988dbd867271b1", "components_browsertests": "3399dcdfaa27fa983a8f95d511b5d01c99bb5ac5", "components_perftests": "81d0985ab4251d745a651d451f90c73193cc99c2", "components_unittests": "91108546621a71ec6e5c0a2b307e95632a8d359e", "content_browsertests": "1b391b8c73ec04122ec404977a4a0777cc0a7bc0", "content_shell_test_apk": "b4252b3fd435455ac94846c9c30f40f617d6464a", "content_unittests": "36d3f9a26ac3cc823c4141a03ec7e67a22de2ca6", "crypto_unittests": "b3531f0b2073440a48e95e9652e4b58e30393e38", "device_unittests": "8f2e062043a360f1b286c658801ee4b3a6d7777d", "display_unittests": "eee14020f2c02c1823d4c020de23d822a29a8250", "events_unittests": "5de3cc08ba195c0f81f4c1186506ca137febdfda", "gcm_unit_tests": "84e339300e5ad297657eca93f3a5a34e6d7bde4e", "gfx_unittests": "6612f57631becc88bcde27baf1cb658ecf3dc93a", "gin_unittests": "f0c848353f84b4514eef13750e62f4e79945e4ec", "gl_tests": "274a4ab8b2ced6d3ce94ae3d2a320787f35d7341", "gl_unittests": "a413ee6562e6c6a3aac16d3b2ca37a488ef03791", "google_apis_unittests": "bda466550d78acef02480b3ed3549ae5b56bbbe9", "gpu_unittests": "401c74d2bb46fa11939844c280d3bf8362c36736", "ipc_tests": "4b6a889106bd514e131f91619a5ee4b4c0789b7a", "jingle_unittests": "1072c1dfd41b636ee312aa40fd6dbb5528dacc05", "latency_unittests": "4bef8e006dabb5f793656a534b36e18d092c5f20", "libjingle_xmpp_unittests": "1d4dbfe103b2c9633dc53e5126a973ae9dcf52eb", "media_blink_unittests": "5fce4ffee1d989ae84c932f240545e16598527ee", "media_service_unittests": "0d91040c6bbe8aa33f36454417191ac108f6ef7e", "media_unittests": "f5ceed3c0bf5460c12bc421f0133435c569baeb2", "midi_unittests": "59ec04854f1db71fdada516515503ead25cc6d5e", "mojo_test_apk": "fa917a45def5533b8362d3e48d76608a05c1c509", "mojo_unittests": "ae577356b431e17723f0b8c7c1c67c4cd3d518b6", "monochrome_apk_checker": "91050e7b96b8553ec57f7324253dc9ff9f9045e3", "net_unittests": "a7b8e473f23e84dc3ed4116db1079a0868d76fe3", "sandbox_linux_unittests": "8e2382e24783d92f81ce3882ece4a88585d8b856", "services_unittests": "a259a5612701fd9f2daeaf4d6babf484b160ffd8", "shell_dialogs_unittests": "18cebf40568df6566eacd31c368ad76f55de9bfd", "skia_unittests": "4f36cd2a17e27932721ed24c3ff875d6c9e6e697", "sql_unittests": "a1aa31f882201183c9b2aa8d1166b82ef523d1b4", "storage_unittests": "5a169f4824dec20812917cdecc901d402adc7110", "telemetry_perf_unittests": "7e12448eacc46874dfac58bea6086b582df04ac0", "ui_android_unittests": "c4e6af2a72e073af17f3a6fdfc32ca23888182f4", "ui_base_unittests": "ad3e131e5a273b1106de50fd0ba3792190335ab1", "ui_touch_selection_unittests": "9fa0e7a1e2652f482b4c461a50465429a5a04aa1", "unit_tests": "bfb3643d5ff49c98e247c5b2aba6d8fdccf93c62", "url_unittests": "958cc12107495024285c57a92cdb5aa00baff594", "viz_unittests": "8c26d287e2903582eaea5fef30895060c00d3c29", "vr_common_unittests": "6461fecb4378d44268951bd40558861fa9b716a6", "vr_pixeltests": "5f1bbfe8646fa9b7e78038cfdb0432274c29d6cd", "webkit_unit_tests": "c22e612258e6d096f5899b14524b6dc7e0b2c0db", "webview_instrumentation_test_apk": "45bd0fdf976b8dbc4c21b6d84bc44b16901a8f0c", "wtf_unittests": "958a48f27e81944a0c1793e8e965e38cdae38039"} find isolated tests

Blamelist:

  1. Vasilii Sukhanov (vasiliiohnoyoudont@chromium.org)
  2. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  3. Fernando Serboncini (fserbohnoyoudont@chromium.org)
  4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  5. Nico Weber (thakisohnoyoudont@chromium.org)
  6. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  7. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  8. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  9. Eugene But (eugenebutohnoyoudont@google.com)
  10. Eugene But (eugenebutohnoyoudont@google.com)
  11. Pavel Shmakov (pshmakovohnoyoudont@google.com)
  12. Tim Volodine (timvolodineohnoyoudont@chromium.org)
  13. Rayan Kanso (rayankansohnoyoudont@google.com)
  14. David Jean (djeanohnoyoudont@google.com)

Timing:

Create Friday, 09-Nov-18 16:23:47 UTC
Start Friday, 09-Nov-18 16:23:49 UTC
End Friday, 09-Nov-18 17:28:16 UTC
Pending 1 secs
Execution 1 hrs 4 mins

All Changes:

  1. Ignore blur events caused by the password generation.

    Changed by Vasilii Sukhanov - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:18:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

    Comments

    Ignore blur events caused by the password generation.
    
    When PasswordGenerationAgent copies the password value from the password field
    to "Confirm Password" filed, a blur event is generated. It hides the currently
    open generation prompt. Those events are just side-effects of how the class
    works and should be ignored.
    
    Bug: 899756,850079
    Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444
    Reviewed-on: https://chromium-review.googlesource.com/c/1327205
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606863}

    Changed files

    • chrome/renderer/autofill/fake_password_manager_client.cc
    • chrome/renderer/autofill/fake_password_manager_client.h
    • chrome/renderer/autofill/password_generation_agent_browsertest.cc
    • components/autofill/content/renderer/autofill_agent.cc
    • components/autofill/content/renderer/password_generation_agent.cc
    • components/autofill/content/renderer/password_generation_agent.h
  2. Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:12:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5657f328e5325aa821d8714a3f7686c078603a43

    Comments

    Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a
    
    
    git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cf90797ef05a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606862}

    Changed files

    • DEPS
  3. Save transform context for filters

    Changed by Fernando Serboncini - fserbohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d07d7323809b59b52b1237dacb94330cc9dab4bd

    Comments

    Save transform context for filters
    
    Otherwise we get weird behavior on filters while transforming.
    
    TBR=
    
    Bug: 901759
    Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251
    Reviewed-on: https://chromium-review.googlesource.com/c/1329342
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606861}

    Changed files

    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
  4. Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:10:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99e210e29e5e55c29142398eb11e164801f7d0c8

    Comments

    Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8
    
    
    git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs
    
    
    Created with:
      gclient setdep -r src/third_party/skia@c244c2fbbbf8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155
    Reviewed-on: https://chromium-review.googlesource.com/c/1329045
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606860}

    Changed files

    • DEPS
  5. Remove v8_context_snapshot.bin determinism hack.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:08:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2acccc10cf8afd5a3709f5fd562d700d6b96979

    Comments

    Remove v8_context_snapshot.bin determinism hack.
    
    Reverts parts of
    https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should
    no longer be needed after https://chromium-review.googlesource.com/c/1304441
    
    Bug: 870584
    Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1328823
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606859}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
  6. Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:06:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7669a6683a5f927ae9a3fa2c2d7802e2a8d5c165

    Comments

    Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file
    
    In case the files are somehow not found or unreadable on the bots, the tests should fail.
    R=dmazzoni@chromium.org
    
    Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171
    Reviewed-on: https://chromium-review.googlesource.com/c/1324232
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606858}

    Changed files

    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.cc
  7. Roll src-internal 6166365225d6..827de2c806ba (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56904b670753b8f8a1f5131ef61b9e1027f34c6e

    Comments

    Roll src-internal 6166365225d6..827de2c806ba (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba
    
    
    Created with:
      gclient setdep -r src-internal@827de2c806ba
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1329361
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606857}

    Changed files

    • DEPS
  8. Wire the resizeMode property to the constraints parsing mechanism.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:02:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c6c086d575a9e131e70eaf6512a0da14150442

    Comments

    Wire the resizeMode property to the constraints parsing mechanism.
    
    This CL adds resizeMode support for MediaStreamTrack.getConstraints()
    and marks resizeMode as a supported constrainable property.
    
    Support for getUserMedia(), applyConstraints() and getCapabilities()
    will be added in follow-up CLs in this series.
    
    Intent to Ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
    
    Bug: 854980
    Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
    Reviewed-on: https://chromium-review.googlesource.com/c/1309749
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606856}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html
    • third_party/blink/public/platform/web_media_constraints.h
    • third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
    • third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
    • third_party/blink/renderer/platform/exported/web_media_constraints.cc
  9. Call WebStateObserver::PageLoaded after loading placeholder URL.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:00:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 386114b5bacc02e12b584786671d67b6080f02e7

    Comments

    Call WebStateObserver::PageLoaded after loading placeholder URL.
    
    Before this CL PageLoaded was called right from
    didFailProvisionalNavigation:, where URL may still represent the
    previous page.
    
    Bug: 903497
    Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327608
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606855}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  10. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  11. Refactor Trusted Web Activity UI code to MVC

    Changed by Pavel Shmakov - pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java
  12. [AW NS] Add CTS test filter for Android WebView

    Changed by Tim Volodine - timvolodineohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:47:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e57afbcbc0d8a4fff7a9d8df6164bf0f6dcedd75

    Comments

    [AW NS] Add CTS test filter for Android WebView
    
    The idea of this CTS filter is similar to the filter we have for
    instrumentation tests, i.e.
    mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains
    failing tests and their corresponding issues / root causes.
    
    The current filter contains results from a local run for a subset of
    tests (the actual CTS is not running yet). The CTS filter also
    augments the instrumentation test filter for test coverage that is
    missing from instrumentation tests.
    
    BUG=903822,902330,841556
    
    Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/1319677
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606852}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_webview_CTS_test.filter
  13. [Background Fetch] Report uploadTotal in the registration

    Changed by Rayan Kanso - rayankansohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a2e1006e2f0960cea11264c2cb65c73d0334b90

    Comments

    [Background Fetch] Report uploadTotal in the registration
    
    Also sets up some useful testing helpers for future upload features.
    
    Bug: 774054
    Change-Id: I9aea33086b228357d9a160bd35b0a37ceaa30592
    Reviewed-on: https://chromium-review.googlesource.com/c/1329149
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606851}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.h
    • content/browser/background_fetch/storage/create_metadata_task.cc
  14. [ios] add manual fallback credit card and address coordinator

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:34:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b02a7719f78de1e78ded7807aa4d139f8c2b77d6

    Comments

    [ios] add manual fallback credit card and address coordinator
    
    And a common base class.
    
    Bug: 845472
    Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1318914
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606850}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm