Home | Search | chromium - Builders
Login

Builder android-kitkat-arm-rel Build 8404 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision31322898bc81e2e07e3d9f89aa051a60c5f93215
Got Revision31322898bc81e2e07e3d9f89aa051a60c5f93215

Execution:

Steps and Logfiles:

Show:
  1. ( 320 ms ) setup_build
    running recipe: "chromium"
  2. ( 43 secs ) bot_update
    [70GB/295GB used (23%)]
  3. ( 0 ) ensure_goma
  4. ( 817 ms ) swarming.py --version
    0.13
  5. ( 12 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  7. ( 4 secs ) clean local files
  8. ( 63 ms ) tree truth steps
  9. ( 15 secs ) generate_build_files
  10. ( 1 mins 44 secs ) compile
  11. ( 33 secs ) isolate tests
  12. ( 678 ms ) find isolated tests
  13. ( 0 ) test_pre_run
  14. ( 1 ms ) ui_junit_tests
  15. ( 6 secs ) angle_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:29.294040
  16. ( 5 secs ) base_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:03:44.559980
  17. ( 2 secs ) blink_common_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 24s
  18. ( 2 secs ) blink_heap_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 51s
  19. ( 4 secs ) blink_platform_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:09.645990
  20. ( 3 secs ) boringssl_crypto_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:00.724170
  21. ( 3 secs ) boringssl_ssl_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 29s
  22. ( 2 secs ) breakpad_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 22s
  23. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 30s
  24. ( 2 secs ) capture_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 34s
  25. ( 3 secs ) cast_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 54s
  26. ( 5 secs ) cc_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:53.807660
  27. ( 2 secs ) chrome_sync_shell_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:06:56.553600
  28. ( 2 secs ) components_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:49.883650
  29. ( 3 secs ) perfetto_content_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:24.974160
  30. ( 3 secs ) crypto_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 26s
  31. ( 2 secs ) device_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 42s
  32. ( 2 secs ) display_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 30s
  33. ( 3 secs ) events_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 35s
  34. ( 2 secs ) gcm_unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 34s
  35. ( 5 secs ) gfx_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:55.643840
  36. ( 2 secs ) gin_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 28s
  37. ( 2 secs ) gl_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 42s
  38. ( 2 secs ) gl_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:01.280000
  39. ( 2 secs ) google_apis_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 39s
  40. ( 5 secs ) gpu_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:18.572010
  41. ( 2 secs ) ipc_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 29s
  42. ( 2 secs ) jingle_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:10.337080
  43. ( 2 secs ) latency_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 28s
  44. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 35s
  45. ( 3 secs ) media_blink_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:09.111470
  46. ( 2 secs ) media_service_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 25s
  47. ( 6 secs ) media_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:03:26.851560
  48. ( 2 secs ) midi_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:06.850400
  49. ( 2 secs ) mojo_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:45.189950
  50. ( 3 secs ) mojo_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:23.444340
  51. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 26s
  52. ( 4 secs ) services_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:03.570500
  53. ( 3 secs ) shell_dialogs_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 26s
  54. ( 2 secs ) skia_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 27s
  55. ( 2 secs ) sql_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 31s
  56. ( 3 secs ) storage_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:09.292620
  57. ( 3 secs ) ui_android_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:05.221330
  58. ( 2 secs ) ui_base_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 40s
  59. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 24s
  60. ( 3 secs ) url_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 24s
  61. ( 4 secs ) viz_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 40s
  62. ( 2 secs ) vr_common_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 49s
  63. ( 2 secs ) vr_pixeltests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 42s
  64. ( 2 secs ) wtf_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 35s
  65. ( 3 secs ) chrome_public_test_vr_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:07:31.329820 (shard #0)
    Min shard duration: 0:06:44.975690 (shard #1)
  66. ( 10 secs ) webkit_unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:06:32.230350 (shard #0)
    Min shard duration: 0:05:53.433950 (shard #1)
  67. ( 3 secs ) content_shell_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:07:00.312220 (shard #2)
    Min shard duration: 0:05:55.967820 (shard #1)
  68. ( 8 secs ) content_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:03:15.110890 (shard #1)
    Min shard duration: 0:02:44.426140 (shard #2)
  69. ( 34 secs ) net_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:08:36.990550 (shard #1)
    Min shard duration: 0:07:49.023300 (shard #2)
  70. ( 14 secs ) components_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:05:48.783690 (shard #2)
    Min shard duration: 0:05:14.089660 (shard #1)
  71. ( 11 secs ) content_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:08:01.706070 (shard #6)
    Min shard duration: 0:06:45.223930 (shard #8)
  72. ( 6 secs ) surface_sync_content_browsertests on Android device Nexus 5 (experimental)
    Run on OS: 'Android'
    Max shard duration: 0:08:45.028060 (shard #8)
    Min shard duration: 0:06:54.592190 (shard #1)
  73. ( 6 secs ) unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:05:45.574980 (shard #5)
    Min shard duration: 0:02:58.993990 (shard #0)
  74. ( 1 mins 56 secs ) chrome_public_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:15:06.948380 (shard #1)
    Min shard duration: 0:12:54.859350 (shard #3)
  75. ( 1 secs ) monochrome_apk_checker on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 49s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  76. ( 387 ms ) Tests statistics
     
    Stats
    Total shards: 108
    Total runtime: 7:59:26.013373
     
  77. ( 989 ms ) test_report
  78. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm265-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1533970191631040, "id": "8938509388298455120", "project": "chromium", "tags": ["builder:android-kitkat-arm-rel", "buildset:commit/git/31322898bc81e2e07e3d9f89aa051a60c5f93215", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/31322898bc81e2e07e3d9f89aa051a60c5f93215", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9103939450415114336", "scheduler_job_id:chromium/android-kitkat-arm-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "android-kitkat-arm-rel" setup_build
buildnumber 8404 setup_build
mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "31322898bc81e2e07e3d9f89aa051a60c5f93215" setup_build
got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" bot_update
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" bot_update
got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" bot_update
got_revision "31322898bc81e2e07e3d9f89aa051a60c5f93215" bot_update
got_revision_cp "refs/heads/master@{#582433}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" bot_update
got_v8_revision_cp "refs/heads/7.0.193@{#2}" bot_update
got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" bot_update
got_webrtc_revision_cp "refs/heads/master@{#24263}" bot_update
swarm_hashes_refs/heads/master(at){#582433}_without_patch {"angle_unittests": "640f7692f11d21cf8aae2d69a264c05402dcc467", "base_unittests": "e953575e9eedfba212d964dd35b2c187f3a3c110", "blink_common_unittests": "53e2cfa403151a9ee0b624de8c66009606751d05", "blink_heap_unittests": "3997541e93f95d453cb75a3e31f04fa705589582", "blink_platform_unittests": "b2a16287797722b79b28faa980954725ced43323", "boringssl_crypto_tests": "7a20454b26e98c27d6541c4940dd606f74512730", "boringssl_ssl_tests": "81d93c48c3d885cd19bd30194c75df1bedee4f56", "breakpad_unittests": "d393223bf5afdb212649eaa91f4ed93de58a3e85", "cacheinvalidation_unittests": "e368990154cb3a5be99ed3b4263ed2dc3674a2fe", "capture_unittests": "99107b63c9c3fde7b5372496cac4368117f8de90", "cast_unittests": "03ada998c05e2e23f72da2178a45c18263001c74", "cc_unittests": "2b9b0c4a1a8cdaec1e698d83785a3e817760cd60", "chrome_public_test_apk": "fca2daf59f7ca5c3331efee12b8e8466762a4ce0", "chrome_public_test_vr_apk": "aa77d9b66420fdda8cb44b5ee67fe6a8e6c19612", "chrome_sync_shell_test_apk": "3b0364298c26409afd5e61299d1a2e332112ce07", "components_browsertests": "6f955a73642d8fd16b0705c1981c17a205b14dbb", "components_unittests": "c7ad02214adc3663f0755a34945e8648c04efc26", "content_browsertests": "5c49244f9f8e0354297094dd160510d51f3bbced", "content_shell_test_apk": "7928bddc5c6eee5133cfe6a31e08e02c74666163", "content_unittests": "548c21bbe544d89bc996b97247c6d640746d69b6", "crypto_unittests": "9ce9b51d2415c02734d28b67cd5b95b5fbaf7559", "device_unittests": "a6a841c7977a47a5ca318787d5a1fc1f95e11256", "display_unittests": "902b199bc824d2cae87ffebae236d26464d06016", "events_unittests": "f79ef9191465caed923950838b3b24d28a736835", "gcm_unit_tests": "96f2b37ee0bbde3b8881916d4d5b2cb95293feb0", "gfx_unittests": "5920439bad2e82aba688045b09da978a84bb4943", "gin_unittests": "e6a5c18a70596b3b1f85beb0d99400771a10c795", "gl_tests": "fc39a51dd891fa3c4c5560255a2d146aaa05b548", "gl_unittests": "e2c14ced7078c8dcb1b119b87a158395429676c4", "google_apis_unittests": "6a71eb3cad1d435534aa76be3800ee2e3da79384", "gpu_unittests": "ad26ea9502a757e84374aafaf5447ba12263a193", "ipc_tests": "4dc9f7e5564a3f5108b7cf1eca91df1c50281488", "jingle_unittests": "0e7ee9f96ffc877decb0d1e2cc6abb17365825b9", "latency_unittests": "913944a027e0969f40b3a7567707d70a56a36871", "libjingle_xmpp_unittests": "f35d1cd303cdab58ab8249dff7e555569fe436ad", "media_blink_unittests": "621d1daab5d91f9417ab80afe13dc42c727a15c2", "media_service_unittests": "ff3b80bba57ee4cc7656fb83a3826f7f74a8b927", "media_unittests": "0e273cf4fb09596fe0719f9cd5413a221655dae4", "midi_unittests": "827122bdcb83872f4ca6cdd78c0264e78aca7794", "mojo_test_apk": "62399688aaba6d2195c244a04de947ac325e4a96", "mojo_unittests": "f6d20c41b5f8d2d8566ac2ce0c3bc506b3b8f0ca", "monochrome_apk_checker": "7cfb5d9f23a31f0577ffe3dbfd0b613b2e93e183", "net_unittests": "80363a85d4065678d2478b169620b8985d624288", "sandbox_linux_unittests": "e34515e26e6341c122ab56c4ef9fcdfb80616b2e", "services_unittests": "ed3a34d981da54fe696c56d0b66c12217926d88d", "shell_dialogs_unittests": "ded9ffb4ad11dd9414f26c7f60efb38ef1c2af2e", "skia_unittests": "0ccfcfae902f08e5bcd1fe950d15606cb60c73ec", "sql_unittests": "65d344b1cd3abc82155e378a5d605e079c308bc2", "storage_unittests": "8d476b652efdc7dfc170f856d149aa98227f1cbc", "ui_android_unittests": "281b5740e262746c899c31d534d71f523d75a9b8", "ui_base_unittests": "c01f26345e97cc5bcd5e4e339ac3727f4e97c5d7", "ui_touch_selection_unittests": "04d472b5d938e8c649741a153716019623bc7b31", "unit_tests": "d89541afc5fe074558b669f96c497eac483c7a12", "url_unittests": "116956daae12cd6299d8e9b16f821c9cceb608f6", "viz_unittests": "c77097094d241b51a4390f6a75ed7e037390a070", "vr_common_unittests": "0ea63e74e00c096a527260cb542b2d6f1c480ef0", "vr_pixeltests": "53c8df1c13d7909f70179abc53959deaa0a3669e", "webkit_unit_tests": "bd72b1c9017b395537c9fd58de73a17bfcf6a710", "wtf_unittests": "1948f9049a967cc7e3a1e6530e6bae56e8e2a4b0"} isolate tests
swarm_hashes {"angle_unittests": "640f7692f11d21cf8aae2d69a264c05402dcc467", "base_unittests": "e953575e9eedfba212d964dd35b2c187f3a3c110", "blink_common_unittests": "53e2cfa403151a9ee0b624de8c66009606751d05", "blink_heap_unittests": "3997541e93f95d453cb75a3e31f04fa705589582", "blink_platform_unittests": "b2a16287797722b79b28faa980954725ced43323", "boringssl_crypto_tests": "7a20454b26e98c27d6541c4940dd606f74512730", "boringssl_ssl_tests": "81d93c48c3d885cd19bd30194c75df1bedee4f56", "breakpad_unittests": "d393223bf5afdb212649eaa91f4ed93de58a3e85", "cacheinvalidation_unittests": "e368990154cb3a5be99ed3b4263ed2dc3674a2fe", "capture_unittests": "99107b63c9c3fde7b5372496cac4368117f8de90", "cast_unittests": "03ada998c05e2e23f72da2178a45c18263001c74", "cc_unittests": "2b9b0c4a1a8cdaec1e698d83785a3e817760cd60", "chrome_public_test_apk": "fca2daf59f7ca5c3331efee12b8e8466762a4ce0", "chrome_public_test_vr_apk": "aa77d9b66420fdda8cb44b5ee67fe6a8e6c19612", "chrome_sync_shell_test_apk": "3b0364298c26409afd5e61299d1a2e332112ce07", "components_browsertests": "6f955a73642d8fd16b0705c1981c17a205b14dbb", "components_unittests": "c7ad02214adc3663f0755a34945e8648c04efc26", "content_browsertests": "5c49244f9f8e0354297094dd160510d51f3bbced", "content_shell_test_apk": "7928bddc5c6eee5133cfe6a31e08e02c74666163", "content_unittests": "548c21bbe544d89bc996b97247c6d640746d69b6", "crypto_unittests": "9ce9b51d2415c02734d28b67cd5b95b5fbaf7559", "device_unittests": "a6a841c7977a47a5ca318787d5a1fc1f95e11256", "display_unittests": "902b199bc824d2cae87ffebae236d26464d06016", "events_unittests": "f79ef9191465caed923950838b3b24d28a736835", "gcm_unit_tests": "96f2b37ee0bbde3b8881916d4d5b2cb95293feb0", "gfx_unittests": "5920439bad2e82aba688045b09da978a84bb4943", "gin_unittests": "e6a5c18a70596b3b1f85beb0d99400771a10c795", "gl_tests": "fc39a51dd891fa3c4c5560255a2d146aaa05b548", "gl_unittests": "e2c14ced7078c8dcb1b119b87a158395429676c4", "google_apis_unittests": "6a71eb3cad1d435534aa76be3800ee2e3da79384", "gpu_unittests": "ad26ea9502a757e84374aafaf5447ba12263a193", "ipc_tests": "4dc9f7e5564a3f5108b7cf1eca91df1c50281488", "jingle_unittests": "0e7ee9f96ffc877decb0d1e2cc6abb17365825b9", "latency_unittests": "913944a027e0969f40b3a7567707d70a56a36871", "libjingle_xmpp_unittests": "f35d1cd303cdab58ab8249dff7e555569fe436ad", "media_blink_unittests": "621d1daab5d91f9417ab80afe13dc42c727a15c2", "media_service_unittests": "ff3b80bba57ee4cc7656fb83a3826f7f74a8b927", "media_unittests": "0e273cf4fb09596fe0719f9cd5413a221655dae4", "midi_unittests": "827122bdcb83872f4ca6cdd78c0264e78aca7794", "mojo_test_apk": "62399688aaba6d2195c244a04de947ac325e4a96", "mojo_unittests": "f6d20c41b5f8d2d8566ac2ce0c3bc506b3b8f0ca", "monochrome_apk_checker": "7cfb5d9f23a31f0577ffe3dbfd0b613b2e93e183", "net_unittests": "80363a85d4065678d2478b169620b8985d624288", "sandbox_linux_unittests": "e34515e26e6341c122ab56c4ef9fcdfb80616b2e", "services_unittests": "ed3a34d981da54fe696c56d0b66c12217926d88d", "shell_dialogs_unittests": "ded9ffb4ad11dd9414f26c7f60efb38ef1c2af2e", "skia_unittests": "0ccfcfae902f08e5bcd1fe950d15606cb60c73ec", "sql_unittests": "65d344b1cd3abc82155e378a5d605e079c308bc2", "storage_unittests": "8d476b652efdc7dfc170f856d149aa98227f1cbc", "ui_android_unittests": "281b5740e262746c899c31d534d71f523d75a9b8", "ui_base_unittests": "c01f26345e97cc5bcd5e4e339ac3727f4e97c5d7", "ui_touch_selection_unittests": "04d472b5d938e8c649741a153716019623bc7b31", "unit_tests": "d89541afc5fe074558b669f96c497eac483c7a12", "url_unittests": "116956daae12cd6299d8e9b16f821c9cceb608f6", "viz_unittests": "c77097094d241b51a4390f6a75ed7e037390a070", "vr_common_unittests": "0ea63e74e00c096a527260cb542b2d6f1c480ef0", "vr_pixeltests": "53c8df1c13d7909f70179abc53959deaa0a3669e", "webkit_unit_tests": "bd72b1c9017b395537c9fd58de73a17bfcf6a710", "wtf_unittests": "1948f9049a967cc7e3a1e6530e6bae56e8e2a4b0"} find isolated tests

Blamelist:

  1. David Roger (drogerohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 06:49:51 UTC
Start Saturday, 11-Aug-18 06:49:55 UTC
End Saturday, 11-Aug-18 07:12:03 UTC
Pending 3 secs
Execution 22 mins 8 secs

All Changes:

  1. [Settings] UserEvents depends on history and passphrase

    Changed by David Roger - drogerohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 06:43:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31322898bc81e2e07e3d9f89aa051a60c5f93215

    Comments

    [Settings] UserEvents depends on history and passphrase
    
    This is a reland of:
    https://chromium-review.googlesource.com/1170202
    
    which was reverted because of missing svg icon.
    
    The user events UI toggle should be grayed out and turned off
    when there is a passphrase or when history sync is disabled.
    Note that this is purely a UI change: the internal sync datatype
    is not really turned off in that case, and we assume that the Sync
    engines will correctly stop syncing user events in these cases,
    even if the preference is still ON.
    
    Bug: 865522, 865537
    Change-Id: I745f048b3ca301231f57c04b82d0d9d82a6f3b90
    Reviewed-on: https://chromium-review.googlesource.com/1170825
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582433}

    Changed files

    • chrome/browser/resources/settings/people_page/sync_browser_proxy.js
    • chrome/browser/resources/settings/people_page/sync_page.html
    • chrome/browser/resources/settings/people_page/sync_page.js
    • chrome/test/data/webui/settings/people_page_sync_page_test.js