Home | Search | chromium - Builders
Login

Builder android-dbg Build 1049 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3
Got Revision4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3

Execution:

Steps and Logfiles:

Show:
  1. ( 447 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) report builders
     
    running builder/tester 'android-dbg' on master 'chromium'
  3. ( 2 mins 35 secs ) bot_update
    [87GB/295GB used (29%)]
  4. ( 0 ) ensure_goma
  5. ( 1 secs ) swarming.py --version
    0.13
  6. ( 9 secs ) clobber
  7. ( 31 secs ) gclient runhooks
  8. ( 365 ms ) read test spec (chromium.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.json
  9. ( 3 secs ) clean local files
  10. ( 1 secs ) tree truth steps
  11. ( 748 ms ) lookup GN args
     
    is_component_build = true
    is_debug = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  12. ( 26 secs ) generate_build_files
  13. ( 47 mins 40 secs ) compile
  14. ( 1 mins 20 secs ) compile confirm no-op
    This should have been a no-op, but it wasn't.

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2921-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539335269625533, "id": "8932883696276200784", "project": "chromium", "tags": ["builder:android-dbg", "buildset:commit/git/4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098313758490038448", "scheduler_job_id:chromium/android-dbg", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "android-dbg" setup_build
buildnumber 1049 setup_build
mastername "chromium" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3" bot_update
got_revision_cp "refs/heads/master@{#599149}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update

Blamelist:

  1. Olivier Robin (olivierrobinohnoyoudont@chromium.org)
  2. Leszek Swirski (leszeksohnoyoudont@chromium.org)
  3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  5. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  6. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  7. Florent Castelli (orphisohnoyoudont@chromium.org)
  8. Fergal Daly (fergalohnoyoudont@chromium.org)
  9. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  10. A Olsen (olsenohnoyoudont@chromium.org)
  11. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  12. Roman Sorokin (rsorokinohnoyoudont@chromium.org)
  13. Alexander Alekseev (alemateohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 09:07:49 UTC
Start Friday, 12-Oct-18 09:07:51 UTC
End Friday, 12-Oct-18 10:04:18 UTC
Pending 1 secs
Execution 56 mins 27 secs

All Changes:

  1. Stop observing prefs in MainController on Shutdown

    Changed by Olivier Robin - olivierrobinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:04:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3

    Comments

    Stop observing prefs in MainController on Shutdown
    
    Bug: 893486
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Iba70383fe0993c7c921a118197197497c1d42572
    Reviewed-on: https://chromium-review.googlesource.com/c/1270899
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599149}

    Changed files

    • ios/chrome/app/main_controller.mm
  2. [blink] Control ScriptStreamer with ScriptResource

    Changed by Leszek Swirski - leszeksohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:03:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bd9163502462762e58d8010577dbf36aeef6c13

    Comments

    [blink] Control ScriptStreamer with ScriptResource
    
    Move the ScriptStreamer control logic from ClassicPendingScript to
    ScriptResource. In the future, this will allow us to start streaming
    a ScriptResource before the ClassicPendingScript is available, e.g on
    preload.
    
    The ClassicPendingScript now only sends one "finished" callback, from
    ScriptResource. This callback is either when the streaming completes,
    or when there is no streaming and the ClassicPendingScript has told
    the ScriptResource that it doesn't intend to start streaming. In the
    long run, we want all scripts to go through the streaming interface,
    and we want ScriptResource to control when streaming starts, so the
    "no more streaming" call will disappear -- however it is necessary to
    maintain the current behaviour, and be able to control it with a
    runtime flag.
    
    Bug: chromium:865098
    Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599148}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  3. Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 08:52:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae1d881f2c19438f9bf1efad82eaaaa11980b30f

    Comments

    Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/a54daf162fac..28d200c24624
    
    
    git log a54daf162fac..28d200c24624 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 37b6d53f02..d47784f23e (598967:599082)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@28d200c24624
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I6547afd3d833e047bb877b0bece2206b5c8661ec
    Reviewed-on: https://chromium-review.googlesource.com/c/1278304
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599147}

    Changed files

    • DEPS
  4. Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:49:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 30958ae060dbfee80d985b84caa9e3c5f4d9c4cc

    Comments

    Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.
    
    TBR=sky@chromium.org
    
    Bug: 828999
    Change-Id: I46514f21581ab6d30e1c4b38719b66e43b075f42
    Reviewed-on: https://chromium-review.googlesource.com/c/1278129
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599146}

    Changed files

    • chrome/browser/browser_process_platform_part_chromeos.cc
    • chrome/browser/browser_process_platform_part_chromeos.h
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
  5. [iOS] Support Accessibility ContentSize on NTP header

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5

    Comments

    [iOS] Support Accessibility ContentSize on NTP header
    
    This CL changes the header of the "Articles for you" section of the NTP
    to have a better support for the "accessibility" categories of preferred
    content size chosen by the user.
    
    Bug: 893524
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
    Reviewed-on: https://chromium-review.googlesource.com/c/1273522
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599145}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
  6. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  7. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  8. [css, dom] Support partmap="foo: bar" syntax.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:26:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda

    Comments

    [css, dom] Support partmap="foo: bar" syntax.
    
    This is the new syntax agreed for partmap.
    
    Bug: 805271
    Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1278566
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599142}

    Changed files

    • third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
    • third_party/blink/renderer/core/dom/element_test.cc
    • third_party/blink/renderer/core/dom/names_map.cc
    • third_party/blink/renderer/core/dom/names_map_test.cc
    • third_party/blink/renderer/core/html/parser/html_parser_idioms.h
  9. Chrome OS Powerwash screen: update icon and illustration.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:22:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afc97ac06f5d3677c1016d1530c1e196844e2432

    Comments

    Chrome OS Powerwash screen: update icon and illustration.
    
    
    Bug: 894280
    Change-Id: I0d478790d35323008a0622404ebde6983fea06ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1278211
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599141}

    Changed files

    • chrome/browser/resources/chromeos/login/images/1x/reset_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/images/2x/reset_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/images/reset_illustration_1x.png
    • chrome/browser/resources/chromeos/login/images/reset_illustration_2x.png
    • chrome/browser/resources/chromeos/login/oobe_reset.css
    • chrome/browser/resources/chromeos/login/oobe_reset.html
  10. Move InstallAttributes to chromeos/settings

    Changed by A Olsen - olsenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa6c62dce936e966e2db445045dd04414553642b

    Comments

    Move InstallAttributes to chromeos/settings
    
    Necessary for moving CrosSettings to chromeos/settings, so it
    can eventually be used by Mustash.
    
    The following changes were necessary:
    1. Move install_attributes{.h, .cc} and unit_test.cc
    2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    (destination)
    3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    which is included by install_attributes.h
    
    4. Unfortunately, that same dependency lead to a circular dependency.
    I was able to avoid that by separating out a "common_constants" rule in
    components/policy/core/common, so that chromeos/settings only depends on
    that, and not on all of components/policy. So I had to change
    components/policy/core/common/BUILD.gn
    and I removed an unnecessary include from
    components/policy/core/common/cloud/cloud_policy_constants.cc
    
    5. Update #include directives for install_attributes to point to new
    location. This is the other 22 files, all with diffs of +1 -1.
    
    Bug: 446937
    Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599140}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • chromeos/settings/install_attributes.cc
    • chromeos/settings/install_attributes.h
    • chromeos/settings/install_attributes_unittest.cc
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  11. Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:18:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112288aae86b2fcd3dde5b2a67872e292e54a8b0

    Comments

    Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf
    
    Using wpt-import in Chromium fb7986d88b0b8f174020916003d6939d2d928b83.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hongchan@chromium.org, rtoy@chromium.org:
      external/wpt/webaudio
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02
    Reviewed-on: https://chromium-review.googlesource.com/c/1278059
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599139}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse.html
  12. Override stub path before PreEarlyInitDBus

    Changed by Roman Sorokin - rsorokinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:10:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b80ea1c80ef7c8ec439c14def8120498fc35eda8

    Comments

    Override stub path before PreEarlyInitDBus
    
    Otherwise install attributes are not loaded on the linux Chrome OS
    build.
    
    TEST=manual
    
    Bug: 848615, 729596
    Change-Id: I445b2b337b707822459c076058610f49f02767ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1264643
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599138}

    Changed files

    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/metrics/chrome_feature_list_creator.cc
  13. Chrome OS: Integrate Discover PIN setup into First run UI.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:08:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a

    Comments

    Chrome OS: Integrate Discover PIN setup into First run UI.
    
    Bug: 852553
    Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
    Reviewed-on: https://chromium-review.googlesource.com/c/1250136
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599137}

    Changed files

    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
    • chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/chromeos/login/wizard_controller.cc
    • chrome/browser/chromeos/login/wizard_controller.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc