Home | Search | chromium - Builders
Login

Builder android-cronet-x86-rel Build 7597 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision8c3cd622f0bc02e3b9744194b5ff8e7410d26a27
Got Revision8c3cd622f0bc02e3b9744194b5ff8e7410d26a27

Execution:

Steps and Logfiles:

Show:
  1. ( 327 ms ) setup_build
    running recipe: "chromium"
  2. ( 236 ms ) report builders
     
    running builder/tester 'android-cronet-x86-rel' on master 'chromium.android'
  3. ( 47 secs ) bot_update
    [82GB/295GB used (27%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 2 secs ) clobber
  6. ( 11 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 3 secs ) clean local files
  9. ( 106 ms ) tree truth steps
  10. ( 502 ms ) lookup GN args
     
    Count of GN args (22) exceeds limit (15), presented in logs instead
  11. ( 11 secs ) generate_build_files
  12. ( 10 mins 28 secs ) compile

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2479-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541786157686821, "id": "8930313753876774496", "project": "chromium", "tags": ["builder:android-cronet-x86-rel", "buildset:commit/git/8c3cd622f0bc02e3b9744194b5ff8e7410d26a27", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/8c3cd622f0bc02e3b9744194b5ff8e7410d26a27", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095743816132322832", "scheduler_job_id:chromium/android-cronet-x86-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "android-cronet-x86-rel" setup_build
buildnumber 7597 setup_build
mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "8c3cd622f0bc02e3b9744194b5ff8e7410d26a27" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "8c3cd622f0bc02e3b9744194b5ff8e7410d26a27" bot_update
got_revision_cp "refs/heads/master@{#606893}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" bot_update
got_v8_revision_cp "refs/heads/7.2.287@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update

Blamelist:

  1. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  2. Peng Huang (penghuangohnoyoudont@chromium.org)
  3. Bin Wu (wubohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 17:55:57 UTC
Start Friday, 09-Nov-18 17:55:59 UTC
End Friday, 09-Nov-18 18:08:25 UTC
Pending 2 secs
Execution 12 mins 25 secs

All Changes:

  1. [Sync::USS] Rename syncPositioningScheme in ModelTypeWorker

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:52:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c3cd622f0bc02e3b9744194b5ff8e7410d26a27

    Comments

    [Sync::USS] Rename syncPositioningScheme in ModelTypeWorker
    
    Change-Id: I04dcc33b375f552a8e4e6dbc8b5ae75869ddfa08
    Reviewed-on: https://chromium-review.googlesource.com/c/1329783
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606893}

    Changed files

    • components/sync/engine_impl/model_type_worker.cc
  2. Fix SkiaRenderer WebGL content not show problem

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:47:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2fef5671fb6850a4cdc203534f90483c35e2564

    Comments

    Fix SkiaRenderer WebGL content not show problem
    
    The WebGL content is a flipped TextureQuad. SkiaRenderer only flips the
    Y coordinate for drawImageRect(with canvas->scale(1, -1)). It will draw
    the image outside of the Window (y < 0). To fix this problem, we use
    canvas->translate(0, quad_rect.bottom()) to move it back into the
    window.
    
    Bug: 901822
    Change-Id: I6b98f82fba896021e1c2878632b26a3bd8029845
    Reviewed-on: https://chromium-review.googlesource.com/c/1324137
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606892}

    Changed files

    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/renderer_pixeltest.cc
    • components/viz/service/display/skia_renderer.cc
    • components/viz/test/data/intersecting_flipped_blue_green_half_size_rectangles.png
    • components/viz/test/data/intersecting_non_flipped_blue_green_half_size_rectangles.png
  3. Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."

    Changed by Bin Wu - wubohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:45:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 346d1aac0d7c49126b8a9943434ee88af85481af

    Comments

    Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."
    
    This reverts commit 683a348730bbea7ccea7158eacc04b928b3d5256.
    
    
    In addition to the auto-revert, I also changed two bzero calls to memset calls. I don't know why, but net_unittest under msan fails with a use-of-uninitialized-value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930601665674446576/+/steps/net_unittests/0/stdout
    
    The msan error goes away after I changed the following bzero(s) into memset(s):
    
    diff --git a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    index 94f055f35564..198e266dfdf2 100644
    --- a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    +++ b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    @@ -102,7 +102,7 @@ class QuicMMsgHdr {
         }
    
         storage_.reset(new char[StorageSize()]);
    -    bzero(&storage_[0], StorageSize());
    +    memset(&storage_[0], 0, StorageSize());
    
         int i = -1;
         for (auto it = first; it != last; ++it) {
    diff --git a/net/third_party/quic/platform/impl/quic_socket_utils.cc b/net/third_party/quic/platform/impl/quic_socket_utils.cc
    index c25f4697dbef..1f252e50f953 100644
    --- a/net/third_party/quic/platform/impl/quic_socket_utils.cc
    +++ b/net/third_party/quic/platform/impl/quic_socket_utils.cc
    @@ -78,7 +78,7 @@ void* QuicMsgHdr::GetNextCmsgDataInternal(int cmsg_level,
    
       if (cmsg_ == nullptr) {
         DCHECK_EQ(nullptr, hdr_.msg_control);
    -    bzero(cbuf_, cbuf_size_);
    +    memset(cbuf_, 0, cbuf_size_);
         hdr_.msg_control = cbuf_;
         cmsg_ = CMSG_FIRSTHDR(&hdr_);
       } else {
    
    
    R=rch@chromium.org
    
    Change-Id: Ibe60068cb87c0f974088b8c1601cc516ee333106
    Reviewed-on: https://chromium-review.googlesource.com/c/1329348
    Commit-Queue: Bin Wu <wub@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606891}

    Changed files

    • net/BUILD.gn
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_test.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer_test.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    • net/third_party/quic/platform/impl/quic_linux_socket_utils_test.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.h