Builder android-cronet-x86-rel Build 14358

Results:

Success

Trigger Info:

Project	chromium
Revision	99ba5a60e6357f95d4a15465b7b4f44dbc88aa86
Got Revision	99ba5a60e6357f95d4a15465b7b4f44dbc88aa86

Execution:

• Source: Task 42f823d05ec18d10
• Bot: swarm2479-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 375 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 228 ms ) report builders

    

   running builder/tester 'android-cronet-x86-rel' on master 'chromium.android'
   • stdout
   • bots.json
3. ( 53 secs ) bot_update

   [65GB/295GB used (22%)]
   • stdout
   • json.output
4. ( 95 ms ) ensure_goma
   • - no logs -
   1. ( 95 ms ) ensure_installed
      • stdout
      • json.output
5. ( 754 ms ) swarming.py --version

   0.14
   • stdout
6. ( 1 secs ) clobber
   • stdout
7. ( 13 secs ) gclient runhooks
   • stdout
8. ( 2 secs ) get compile targets for scripts
   • stdout
   • json.output
9. ( 1 secs ) read test spec (chromium.android.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
   • stdout
   • json.output
10. ( 3 secs ) clean local files
    • stdout
    • python.inline
11. ( 130 ms ) tree truth steps
    • stdout
12. ( 507 ms ) lookup GN args

     

    Count of GN args (23) exceeds limit (15), presented in logs instead
    • stdout
    • gn_args
13. ( 14 secs ) generate_build_files
    • stdout
14. ( 3 secs ) preprocess_for_goma
    • - no logs -
    1. ( 458 ms ) goma cache directory
       • stdout
    2. ( 1 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
15. ( 13 mins 4 secs ) compile
    • stdout
16. ( 2 secs ) compile confirm no-op
    • stdout
17. ( 11 secs ) postprocess_for_goma
    • - no logs -
    1. ( 527 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 512 ms ) goma_stat
       • stdout
    3. ( 548 ms ) stop_goma
       • stdout
    4. ( 8 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 1 secs ) stop cloudtail
       • stdout
18. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$build/goma	{"jobs": 150}	setup_build
$recipe_engine/buildbucket	{"build": {"builder": {"bucket": "ci", "builder": "android-cronet-x86-rel", "project": "chromium"}, "createTime": "2019-02-12T01:28:57.820607Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921769138598425936", "infra": {"buildbucket": {"serviceConfigRevision": "ef156230f5cd7f8c23f689fa4dc7f92742cd904d"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "chromium"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "99ba5a60e6357f95d4a15465b7b4f44dbc88aa86", "project": "chromium/src", "ref": "refs/heads/master"}}, "number": 14358, "tags": [{"key": "builder", "value": "android-cronet-x86-rel"}, {"key": "buildset", "value": "commit/git/99ba5a60e6357f95d4a15465b7b4f44dbc88aa86"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/chromium/src/+/99ba5a60e6357f95d4a15465b7b4f44dbc88aa86"}, {"key": "scheduler_invocation_id", "value": "9087199200870409984"}, {"key": "scheduler_job_id", "value": "chromium/android-cronet-x86-rel"}, {"key": "user_agent", "value": "luci-scheduler"}]}}	setup_build
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2479-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549934937820607, "id": "8921769138598425936", "project": "chromium", "tags": ["build_address:luci.chromium.ci/android-cronet-x86-rel/14358", "builder:android-cronet-x86-rel", "buildset:commit/git/99ba5a60e6357f95d4a15465b7b4f44dbc88aa86", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/99ba5a60e6357f95d4a15465b7b4f44dbc88aa86", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9087199200870409984", "scheduler_job_id:chromium/android-cronet-x86-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"android-cronet-x86-rel"	setup_build
buildnumber	14358	setup_build
mastername	"chromium.android"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"99ba5a60e6357f95d4a15465b7b4f44dbc88aa86"	setup_build
got_angle_revision	"6b695c3ffb27ad1df71f4f1682dc7a1d8adc9f31"	bot_update
got_dawn_revision	"62e83971caa1099bdbc334817efa035047c90ddf"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"99ba5a60e6357f95d4a15465b7b4f44dbc88aa86"	bot_update
got_revision_cp	"refs/heads/master@{#631030}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"872455b5fe0cf1f09eb5550fb1e0bdd259523e8b"	bot_update
got_v8_revision_cp	"refs/heads/7.4.138@{#1}"	bot_update
got_webrtc_revision	"f13c2cd9ee41f4ca572232a4e397b05449474632"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26626}"	bot_update

Blamelist:

1. Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
2. Tatiana Buldina (buldinaohnoyoudont@chromium.org)
3. Pavel Feldman (pfeldmanohnoyoudont@chromium.org)
4. Robert Ogden (robertogdenohnoyoudont@chromium.org)
5. Nico Weber (thakisohnoyoudont@chromium.org)

Timing:

Create	Tuesday, 12-Feb-19 01:28:57 UTC
Start	Tuesday, 12-Feb-19 01:29:02 UTC
End	Tuesday, 12-Feb-19 01:44:13 UTC
Pending	4 secs
Execution	15 mins 11 secs

All Changes:

1. Reland "Picture-in-Picture: move key methods into a service."

   Changed by	Mounir Lamouri - mlamouriohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:27:47 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	99ba5a60e6357f95d4a15465b7b4f44dbc88aa86

   Comments

   Reland "Picture-in-Picture: move key methods into a service."
   
   This reverts commit 9a3eafe448d45259b15e2c8bfa4916da2b39ee75.
   
   Reason for revert: the flake source was found and the test will be disabled until then.
   
   Original change's description:
   > Revert "Picture-in-Picture: move key methods into a service."
   >
   > This reverts commit 45675d0dfab5de54253d40cb2bd52ef034c3a200.
   >
   > Reason for revert: Speculative revert for crbug.com/930338
   >
   > Original change's description:
   > > Picture-in-Picture: move key methods into a service.
   > >
   > > This is moving most of the Picture-in-Picture feature into a service.
   > > Follow-up CLs will move the remaining methods and some Android auto-pip
   > > code. It will also include further cleanups.
   > >
   > > This CL was meant to be the smallest CL that could move the core feature
   > > set without breaking compilation or tests. It's larger than expected.
   > >
   > > Bug: 919860, 908400
   > > Change-Id: I72c5faad9a14de6645a7cd1565b29d6a353e24a3
   > > Binary-Size: cause unknown, landing approved by agrieve@
   > > Reviewed-on: https://chromium-review.googlesource.com/c/1379049
   > > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
   > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
   > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
   > > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
   > > Cr-Commit-Position: refs/heads/master@{#630361}
   >
   > TBR=dcheng@chromium.org,dalecurtis@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,agrieve@chromium.org,jochen@chromium.org
   >
   > Change-Id: I88efa31a23ab1c55b256e5813fa20fd2d8776a21
   > No-Presubmit: true
   > No-Tree-Checks: true
   > No-Try: true
   > Bug: 919860, 908400, 930338
   > Reviewed-on: https://chromium-review.googlesource.com/c/1461546
   > Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
   > Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
   > Cr-Commit-Position: refs/heads/master@{#630550}
   
   TBR=dcheng@chromium.org,dalecurtis@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,agrieve@chromium.org,karandeepb@chromium.org,jochen@chromium.org
   
   # Not skipping CQ checks because original CL landed > 1 day ago.
   
   Bug: 919860, 908400, 930338
   Change-Id: I1bd2ab7ade56569a83951ec942685d9f77dc4af5
   Binary-Size: cause unknown, landing approved by agrieve@
   No-Presubmit: true
   Reviewed-on: https://chromium-review.googlesource.com/c/1465063
   Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
   Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
   Reviewed-by: Kentaro Hara <haraken@chromium.org>
   Reviewed-by: Daniel Cheng <dcheng@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631030}

   Changed files

   • chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
   • content/browser/BUILD.gn
   • content/browser/frame_host/render_frame_host_impl.cc
   • content/browser/media/media_web_contents_observer.cc
   • content/browser/media/media_web_contents_observer.h
   • content/browser/picture_in_picture/picture_in_picture_service_impl.cc
   • content/browser/picture_in_picture/picture_in_picture_service_impl.h
   • content/browser/picture_in_picture/picture_in_picture_service_impl_unittest.cc
   • content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
   • content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
   • content/browser/web_contents/web_contents_impl_unittest.cc
   • content/common/media/media_player_delegate_messages.h
   • content/public/app/content_browser_manifest.cc
   • content/renderer/media/renderer_webmediaplayer_delegate.cc
   • content/renderer/media/renderer_webmediaplayer_delegate.h
   • content/renderer/media/stream/webmediaplayer_ms.cc
   • content/renderer/media/stream/webmediaplayer_ms.h
   • content/renderer/media/stream/webmediaplayer_ms_unittest.cc
   • content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
   • content/test/BUILD.gn
   • media/blink/webmediaplayer_delegate.h
   • media/blink/webmediaplayer_impl.cc
   • media/blink/webmediaplayer_impl.h
   • media/blink/webmediaplayer_impl_unittest.cc
   • third_party/blink/public/mojom/BUILD.gn
   • third_party/blink/public/mojom/picture_in_picture/OWNERS
   • third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom
   • third_party/blink/public/platform/web_media_player.h
   • third_party/blink/public/platform/web_media_player_client.h
   • third_party/blink/renderer/core/frame/picture_in_picture_controller.h
   • third_party/blink/renderer/core/html/media/html_audio_element.h
   • third_party/blink/renderer/core/html/media/html_media_element.h
   • third_party/blink/renderer/core/html/media/html_video_element.cc
   • third_party/blink/renderer/core/html/media/html_video_element.h
   • third_party/blink/renderer/core/html/media/video_wake_lock_test.cc
   • third_party/blink/renderer/modules/BUILD.gn
   • third_party/blink/renderer/modules/picture_in_picture/DEPS
   • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
   • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h
   • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_test.cc
   • third_party/blink/renderer/platform/testing/empty_web_media_player.h

2. [ChromeDriver] Remove tests from _NEGATIVE_FILTER

   Changed by	Tatiana Buldina - buldinaohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:19:49 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	8d1bd234344ea13172b7a25375584bcb9d96a44b

   Comments

   [ChromeDriver] Remove tests from _NEGATIVE_FILTER
   
   - testReturningAFunctionInJavascript absent in test list
   - others tests pass locally
   
   Change-Id: I52d24f97aebfb10b1344c3b6927d5ceec3391db7
   Reviewed-on: https://chromium-review.googlesource.com/c/1465073
   Commit-Queue: John Chen <johnchen@chromium.org>
   Commit-Queue: Tatiana Buldina <buldina@chromium.org>
   Reviewed-by: John Chen <johnchen@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631029}

   Changed files

   • chrome/test/chromedriver/test/run_py_tests.py

3. DevTools: manage String and ProtocolMessage types independently.

   Changed by	Pavel Feldman - pfeldmanohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:19:30 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	62194c03a62e64d22fd965f92e15a8ad65f72c08

   Comments

   DevTools: manage String and ProtocolMessage types independently.
   
   Bug: 929862
   Change-Id: I907b342e2503b85fea6e2fbfd3cbbfed1a11db67
   Reviewed-on: https://chromium-review.googlesource.com/c/1464426
   Reviewed-by: Johannes Henkel <johannes@chromium.org>
   Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631028}

   Changed files

   • content/browser/devtools/devtools_session.h
   • third_party/blink/renderer/core/inspector/devtools_session.cc
   • third_party/blink/renderer/core/inspector/devtools_session.h
   • third_party/blink/renderer/core/inspector/inspector_dom_debugger_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_network_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_session_state.cc
   • third_party/blink/renderer/core/inspector/protocol_parser_test.cc
   • third_party/blink/renderer/core/inspector/v8_inspector_string.cc
   • third_party/blink/renderer/core/inspector/v8_inspector_string.h
   • third_party/blink/renderer/platform/cross_thread_copier.h
   • third_party/inspector_protocol/README.chromium
   • third_party/inspector_protocol/code_generator.py
   • third_party/inspector_protocol/encoding/cbor.cc
   • third_party/inspector_protocol/encoding/cbor.h
   • third_party/inspector_protocol/encoding/cbor_test.cc
   • third_party/inspector_protocol/encoding/json_parser.cc
   • third_party/inspector_protocol/encoding/json_parser_test.cc
   • third_party/inspector_protocol/encoding/json_std_string_writer.cc
   • third_party/inspector_protocol/encoding/status.h
   • third_party/inspector_protocol/encoding/str_util.cc
   • third_party/inspector_protocol/lib/CBOR_cpp.template
   • third_party/inspector_protocol/lib/CBOR_h.template
   • third_party/inspector_protocol/lib/DispatcherBase_cpp.template
   • third_party/inspector_protocol/lib/DispatcherBase_h.template
   • third_party/inspector_protocol/lib/FrontendChannel_h.template
   • third_party/inspector_protocol/lib/Values_cpp.template
   • third_party/inspector_protocol/lib/Values_h.template
   • third_party/inspector_protocol/lib/base_string_adapter_cc.template
   • third_party/inspector_protocol/lib/base_string_adapter_h.template
   • third_party/inspector_protocol/templates/Imported_h.template
   • third_party/inspector_protocol/templates/TypeBuilder_cpp.template
   • third_party/inspector_protocol/templates/TypeBuilder_h.template

4. Disable highlight for Previews IPH

   Changed by	Robert Ogden - robertogdenohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:18:43 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	9b58eaed9d581d271d15449aed9b855bcd7cb410

   Comments

   Disable highlight for Previews IPH
   
   I added a helper method for this to allow for easier changes like this
   down the road, if wanted for other features.
   
   Bug: 930877
   Change-Id: Iad809f2e94e85db57e661f610ce63be9619a2dff
   Reviewed-on: https://chromium-review.googlesource.com/c/1465062
   Reviewed-by: Theresa <twellington@chromium.org>
   Commit-Queue: Robert Ogden <robertogden@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631027}

   Changed files

   • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java

5. Remove a few unnecessary semicolons.

   Changed by	Nico Weber - thakisohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:18:23 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	18e1008abc72e6d9df76ecc2e7538c9a309dbc80

   Comments

   Remove a few unnecessary semicolons.
   
   This CL was uploaded by git cl split.
   
   R=vmiura@chromium.org
   
   Bug: 926235
   Change-Id: I32fb6abf6e06114f42263729b507aeb3a70498cc
   Reviewed-on: https://chromium-review.googlesource.com/c/1464159
   Reviewed-by: Victor Miura <vmiura@chromium.org>
   Commit-Queue: Victor Miura <vmiura@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631026}

   Changed files

   • gpu/ipc/client/gpu_context_tests.h
   • gpu/ipc/host/shader_disk_cache_unittest.cc