Builder android-cronet-x86-rel Build 12897

Results:

Success

Trigger Info:

Project	chromium
Revision	912a5885f3594d9987fd495c4b3c4960dcecf8c1
Got Revision	912a5885f3594d9987fd495c4b3c4960dcecf8c1

Execution:

• Source: Task 4293be5004b28a10
• Bot: swarm2479-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 317 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 221 ms ) report builders

    

   running builder/tester 'android-cronet-x86-rel' on master 'chromium.android'
   • stdout
   • bots.json
3. ( 46 secs ) bot_update

   [64GB/295GB used (21%)]
   • stdout
   • json.output
4. ( 78 ms ) ensure_goma
   • - no logs -
   1. ( 78 ms ) ensure_installed
      • stdout
      • json.output
5. ( 731 ms ) swarming.py --version

   0.14
   • stdout
6. ( 1 secs ) clobber
   • stdout
7. ( 11 secs ) gclient runhooks
   • stdout
8. ( 2 secs ) get compile targets for scripts
   • stdout
   • json.output
9. ( 1 secs ) read test spec (chromium.android.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
   • stdout
   • json.output
10. ( 3 secs ) clean local files
    • stdout
    • python.inline
11. ( 181 ms ) tree truth steps
    • stdout
12. ( 465 ms ) lookup GN args

     

    Count of GN args (23) exceeds limit (15), presented in logs instead
    • stdout
    • gn_args
13. ( 11 secs ) generate_build_files
    • stdout
14. ( 3 secs ) preprocess_for_goma
    • - no logs -
    1. ( 430 ms ) goma cache directory
       • stdout
    2. ( 1 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
15. ( 11 mins 53 secs ) compile
    • stdout
16. ( 2 secs ) compile confirm no-op
    • stdout
17. ( 10 secs ) postprocess_for_goma
    • - no logs -
    1. ( 492 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 485 ms ) goma_stat
       • stdout
    3. ( 496 ms ) stop_goma
       • stdout
    4. ( 7 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 1 secs ) stop cloudtail
       • stdout
18. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$build/goma	{"jobs": 150}	setup_build
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2479-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548250563776649, "id": "8923535332796398384", "project": "chromium", "tags": ["builder:android-cronet-x86-rel", "buildset:commit/git/912a5885f3594d9987fd495c4b3c4960dcecf8c1", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/912a5885f3594d9987fd495c4b3c4960dcecf8c1", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088965394918363696", "scheduler_job_id:chromium/android-cronet-x86-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"android-cronet-x86-rel"	setup_build
buildnumber	12897	setup_build
mastername	"chromium.android"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"912a5885f3594d9987fd495c4b3c4960dcecf8c1"	setup_build
got_angle_revision	"5313c8a89964f536bff2c7f7943499f9c52e5664"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"c0f31e73e481f32d308cb6232e75e6d860d97063"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"912a5885f3594d9987fd495c4b3c4960dcecf8c1"	bot_update
got_revision_cp	"refs/heads/master@{#625179}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"f6929d6c3888a08d5cf55534c7bf4a57ddc59f4a"	bot_update
got_v8_revision_cp	"refs/heads/7.3.488@{#1}"	bot_update
got_webrtc_revision	"71b5a7df7794bbc4103296fcd8bd740acebdc901"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26351}"	bot_update

Blamelist:

1. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
2. Dominic Battre (battreohnoyoudont@chromium.org)
3. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
4. Mario Sanchez Prada (marioohnoyoudont@igalia.com)

Timing:

Create	Wednesday, 23-Jan-19 13:36:03 UTC
Start	Wednesday, 23-Jan-19 13:36:06 UTC
End	Wednesday, 23-Jan-19 13:49:51 UTC
Pending	2 secs
Execution	13 mins 45 secs

All Changes:

1. Move MutableProfileOAuth2TokenServiceDelegate to //components

   Changed by	Mario Sanchez Prada - marioohnoyoudont@igalia.com
   Changed at	Wednesday, 23-Jan-19 13:27:11 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	912a5885f3594d9987fd495c4b3c4960dcecf8c1

   Comments

   Move MutableProfileOAuth2TokenServiceDelegate to //components
   
   Following the cleanup to remove any dependency on includes from //content,
   let's move this delegate of ProfileOAuth2TokenService into //components now
   as necessary step in the direction of hiding the PO2TS delegates behind the
   IdentityManager.
   
   Bug: 922555
   Change-Id: I6b54723b232efea24a7001a2f7e25733ccbbabb7
   Reviewed-on: https://chromium-review.googlesource.com/c/1425500
   Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
   Reviewed-by: Scott Violet <sky@chromium.org>
   Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
   Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
   Cr-Commit-Position: refs/heads/master@{#625179}

   Changed files

   • chrome/browser/BUILD.gn
   • chrome/browser/signin/dice_response_handler_unittest.cc
   • chrome/browser/signin/profile_oauth2_token_service_factory.cc
   • chrome/test/BUILD.gn
   • components/signin/core/browser/BUILD.gn
   • components/signin/core/browser/mutable_profile_oauth2_token_service_delegate.cc
   • components/signin/core/browser/mutable_profile_oauth2_token_service_delegate.h
   • components/signin/core/browser/mutable_profile_oauth2_token_service_delegate_unittest.cc

2. Don't record first filling result for sign-in forms

   Changed by	Dominic Battre - battreohnoyoudont@chromium.org
   Changed at	Wednesday, 23-Jan-19 13:25:39 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	34d69265b1f1f5a3c7739827a0b7e05bfc928e08

   Comments

   Don't record first filling result for sign-in forms
   
   The new form parser may decide that a form has no current-password element, but
   only new-password / confirmation elements. In this case, the parser sets the
   unique_renderer_id to 'undefined'. The credentials will be sent to the renderer
   for filling via manual fallback but the renderer won't ever fill (as there is
   no password element defined for filling.
   
   This CL ensures that this case does not get recorded as a failure to fill. This
   is important because we record two metrics about the first fill attempt:
   PasswordManager.FirstWaitForUsernameReason and
   PasswordManager.FirstRendererFillingResult For websites that have a sign-up
   form followed by a sign-in form, we don't want to record the failure to fill on
   the sign-up form.
   
   Bug: 918846
   Change-Id: I79e9a73ae3573a81e121eaa483e0ecef0889184f
   Reviewed-on: https://chromium-review.googlesource.com/c/1422018
   Commit-Queue: Dominic Battré <battre@chromium.org>
   Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625178}

   Changed files

   • chrome/renderer/autofill/password_autofill_agent_browsertest.cc
   • components/autofill/content/renderer/password_autofill_agent.cc
   • components/password_manager/core/browser/password_form_filling.cc
   • components/password_manager/core/browser/password_form_filling_unittest.cc

3. [s13n] Convert c/b/ui/webui/signin/dice_turn_sync_on_helper.cc away from PO2TS

   Changed by	Antonio Gomes - tonikitooohnoyoudont@igalia.com
   Changed at	Wednesday, 23-Jan-19 13:25:26 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	e9bbcd81e6f9f2086c387ea62a419b12c36b2317

   Comments

   [s13n] Convert c/b/ui/webui/signin/dice_turn_sync_on_helper.cc away from PO2TS
   
   This is the second out of 2 CLs that migrate DiceTurnSyncOnHelper to
   IdentityManager. The first part [1] migrated it away from using
   SigninManager APIs directly.
   
   [1] https://chromium-review.googlesource.com/c/1387393
   
   Additionally, the CL also takes the opportunity to remove AccountTrackerService
   usage, and replace the PO2TSObserver inheritance by
   IdentityManagerObserver.
   
   Both SigninManager and PO2TS are becoming implementation details of
   the new IdentityManager API. This CL migrates the direct PO2TS API
   calls to their respective IdentityManager APIs.
   
   BUG=890811,922789
   
   Change-Id: I928390d4a336a6b42f56661586c90b3d2f5d4635
   Reviewed-on: https://chromium-review.googlesource.com/c/1426457
   Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
   Reviewed-by: David Roger <droger@chromium.org>
   Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625177}

   Changed files

   • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
   • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h

4. Remove references to SigninManagerBase from ios_web_view::ApplicationContext

   Changed by	Mario Sanchez Prada - marioohnoyoudont@igalia.com
   Changed at	Wednesday, 23-Jan-19 13:22:44 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	4e5e1c0d1f29da47df3e3b05d19be0903b27165e

   Comments

   Remove references to SigninManagerBase from ios_web_view::ApplicationContext
   
   Add a new static SigninManagerFactory::RegisterPrefs() method to the relevant
   factory for //ios/web_view, have it call SigninManagerBase::RegisterPrefs()
   instead and call that static method from ios_web_view::ApplicationContext,
   similar to what's already done in //chrome and //ios//chrome.
   
   Bug: 920191
   Change-Id: If8f1c86b4f0dc069fe66aa013235d9e695543a2b
   Reviewed-on: https://chromium-review.googlesource.com/c/1425733
   Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
   Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625176}

   Changed files

   • ios/web_view/internal/app/application_context.mm
   • ios/web_view/internal/signin/web_view_signin_manager_factory.h
   • ios/web_view/internal/signin/web_view_signin_manager_factory.mm