Builder android-cronet-x86-dbg Build 6576
Results:
Success
Trigger Info:
Project | chromium |
Revision | 1d2509fc2ebc7c9848726c1b208483e1e1efc485 |
Got Revision | 1d2509fc2ebc7c9848726c1b208483e1e1efc485 |
Execution:
- Source: Task 408080644b86fc10
- Bot: swarm2480-c4
Steps and Logfiles:
Show:-
( 106751 days 23 hrs ) Failed to fetch step information from LogDogLog stream has no annotation entries
- - no logs -
Build Properties:
Name | Value | Source |
---|
Blamelist:
- Yuki Yamada (yukiyohnoyoudont@google.com)
Timing:
Create | Friday, 12-Oct-18 09:50:04 UTC |
Start | Friday, 12-Oct-18 09:50:07 UTC |
End | Friday, 12-Oct-18 09:57:33 UTC |
Pending | 3 secs |
Execution | 7 mins 25 secs |
All Changes:
-
Added security check for cross origin
Changed by Yuki Yamada - yukiyohnoyoudont@google.com Changed at Friday, 12-Oct-18 09:45:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1d2509fc2ebc7c9848726c1b208483e1e1efc485 Comments
Added security check for cross origin This CL adds a security check for cross origin with BindingSecurity::ShouldAllowAccessToCreationContext(). |js_event|, a V8 wrapper object for event object, must be created in the relevant realm of the event target, but it is possible that listener's relevant context cannnot access the relevant realm of event target (ex. when Document.origin is changed). We have to check this before invoking event listener. Bug: 872138, 884516 Change-Id: Ic5d0c8e6cda4db57a2097ce230e75cc59905b350 Reviewed-on: https://chromium-review.googlesource.com/c/1270300 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#599154}
Changed files
- third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc