Builder android-cronet-kitkat-arm-rel Build 9498
Results:
Success
Trigger Info:
Project | chromium |
Revision | 52c80e8cffaddb831df6e42bc4557d7fdcc7c6a2 |
Got Revision | 52c80e8cffaddb831df6e42bc4557d7fdcc7c6a2 |
Execution:
- Source: Task 42933b16bdb0f710
- Bot: swarm2474-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 227 ms ) report buildersrunning tester 'android-cronet-kitkat-arm-rel' on master 'chromium.android'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.android.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
-
( 466 ms ) lookup builder GN argsCount of GN args (24) exceeds limit (15), presented in logs instead
-
- - no logs -
-
( 1 secs ) [trigger] cronet_smoketests_missing_native_library_instrumentation_apk on Android device Nexus 5Run on OS: 'Android'
-
( 884 ms ) [trigger] cronet_smoketests_platform_only_instrumentation_apk on Android device Nexus 5Run on OS: 'Android'
-
- - no logs -
-
( 2 secs ) cronet_smoketests_platform_only_instrumentation_apk on Android device Nexus 5Run on OS: 'Android'Shard duration: 22s
-
( 2 secs ) cronet_test_instrumentation_apk on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:13:59.605910
-
( 2 secs ) cronet_smoketests_missing_native_library_instrumentation_apk on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:01:06.609040
-
( 2 secs ) cronet_unittests_android on Android device Nexus 5Run on OS: 'Android'Shard duration: 32s
-
( 7 mins 7 secs ) net_unittests on Android device Nexus 5Run on OS: 'Android'Max shard duration: 0:07:04.534246 (shard #0)Min shard duration: 0:06:34.607351 (shard #1)
Build Properties:
Name | Value | Source |
---|---|---|
$build/goma | {"jobs": 150} | setup_build |
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm2474-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548241964043043, "id": "8923544350269407376", "project": "chromium", "tags": ["builder:android-cronet-kitkat-arm-rel", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/52c80e8cffaddb831df6e42bc4557d7fdcc7c6a2", "gitiles_ref:refs/heads/master", "parent_buildername:android-cronet-arm-rel", "parent_buildnumber:12230", "scheduler_invocation_id:9088974412380329744", "scheduler_job_id:chromium/android-cronet-kitkat-arm-rel", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "android-cronet-kitkat-arm-rel" | setup_build |
buildnumber | 9498 | setup_build |
mastername | "chromium.android" | setup_build |
parent_buildername | "android-cronet-arm-rel" | setup_build |
parent_got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | setup_build |
parent_got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | setup_build |
parent_got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | setup_build |
parent_got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | setup_build |
parent_got_revision | "52c80e8cffaddb831df6e42bc4557d7fdcc7c6a2" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#625160}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "f6d33d43027bc31ea10b1856356e7ac6d829bbad" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.487@{#1}" | setup_build |
parent_got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26351}" | setup_build |
parent_mastername | "chromium.android" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "52c80e8cffaddb831df6e42bc4557d7fdcc7c6a2" | setup_build |
swarm_hashes | {"cronet_sample_test_apk": "441854705b791fa9f5a814d83888da560a616b91", "cronet_smoketests_missing_native_library_instrumentation_apk": "80c27119a3022f78df3d12db86ddccac5f1046de", "cronet_smoketests_platform_only_instrumentation_apk": "f067949139a5bf53b0c09b6ecd88d81bc580b28e", "cronet_test_instrumentation_apk": "2863d8cc31e390501f2c7fd893f0588ffc779a33", "cronet_tests_android": "07086514a119466af5164d72567197f01fce4efa", "cronet_unittests_android": "c5cf08ae7f341fab9091ec32a64bb10036da11ef", "net_unittests": "09e5fcfdbf567743897f75d63750efd72915a608"} | setup_build |
got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "52c80e8cffaddb831df6e42bc4557d7fdcc7c6a2" | bot_update |
got_revision_cp | "refs/heads/master@{#625160}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "f6d33d43027bc31ea10b1856356e7ac6d829bbad" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.487@{#1}" | bot_update |
got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Kent Tamura (tkentohnoyoudont@chromium.org)
- Zakhar Voit (voitohnoyoudont@google.com)
- Alex Clarke (alexclarkeohnoyoudont@chromium.org)
- Keishi Hattori (keishiohnoyoudont@chromium.org)
- Carlos Caballero (carlscabohnoyoudont@google.com)
- Pavel Shmakov (pshmakovohnoyoudont@google.com)
- Antonio Gomes (tonikitooohnoyoudont@igalia.com)
Timing:
Create | Wednesday, 23-Jan-19 11:12:44 UTC |
Start | Wednesday, 23-Jan-19 11:13:24 UTC |
End | Wednesday, 23-Jan-19 11:22:30 UTC |
Pending | 40 secs |
Execution | 9 mins 6 secs |
All Changes:
-
Remove unnecessary blink:: in renderer/core/html
Changed by Kent Tamura - tkentohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 10:49:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 52c80e8cffaddb831df6e42bc4557d7fdcc7c6a2 Comments
Remove unnecessary blink:: in renderer/core/html We have bunch of "Trace(blink::Visitor*" in Blink though their classes are also in blink namespace. This CL removes a part of such unnecessary blink::. This CL has no behavior changes. This CL was produced by the following command on zsh: % for i in **/*.{h,cc}; sed -i "" -e "s/Trace(blink::/Trace(/g" $i Change-Id: Ia7cc19c2b26ffee332dc2e66b2cb65f6895e9b51 Reviewed-on: https://chromium-review.googlesource.com/c/1428506 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#625160}
Changed files
- third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
- third_party/blink/renderer/core/html/anchor_element_metrics_sender.h
- third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
- third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.h
- third_party/blink/renderer/core/html/canvas/canvas_font_cache.cc
- third_party/blink/renderer/core/html/canvas/canvas_font_cache.h
- third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
- third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
- third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
- third_party/blink/renderer/core/html/canvas/html_canvas_element.h
- third_party/blink/renderer/core/html/canvas/image_data.cc
- third_party/blink/renderer/core/html/canvas/image_data.h
- third_party/blink/renderer/core/html/canvas/text_metrics.cc
- third_party/blink/renderer/core/html/canvas/text_metrics.h
- third_party/blink/renderer/core/html/collection_items_cache.h
- third_party/blink/renderer/core/html/custom/custom_element_definition.cc
- third_party/blink/renderer/core/html/custom/custom_element_definition.h
- third_party/blink/renderer/core/html/custom/custom_element_reaction.cc
- third_party/blink/renderer/core/html/custom/custom_element_reaction.h
- third_party/blink/renderer/core/html/custom/custom_element_reaction_queue.cc
- third_party/blink/renderer/core/html/custom/custom_element_reaction_queue.h
- third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.cc
- third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.h
- third_party/blink/renderer/core/html/custom/custom_element_reaction_stack_test.cc
- third_party/blink/renderer/core/html/custom/custom_element_reaction_test_helpers.h
- third_party/blink/renderer/core/html/custom/custom_element_registry.cc
- third_party/blink/renderer/core/html/custom/custom_element_registry.h
- third_party/blink/renderer/core/html/custom/custom_element_registry_test.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_callback_invocation.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_callback_invocation.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_callback_queue.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_callback_queue.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_definition.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_definition.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_lifecycle_callbacks.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_dispatcher.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_dispatcher.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_import_step.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_import_step.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_queue_base.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_queue_base.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_resolution_step.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_resolution_step.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_run_queue.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_run_queue.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_microtask_step.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_observer.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_processing_stack.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_processing_stack.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_processing_step.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_registration_context.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_registration_context.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_registry.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_registry.h
- third_party/blink/renderer/core/html/custom/v0_custom_element_upgrade_candidate_map.cc
- third_party/blink/renderer/core/html/custom/v0_custom_element_upgrade_candidate_map.h
- third_party/blink/renderer/core/html/forms/base_button_input_type.cc
- third_party/blink/renderer/core/html/forms/base_button_input_type.h
- third_party/blink/renderer/core/html/forms/base_checkable_input_type.cc
- third_party/blink/renderer/core/html/forms/base_checkable_input_type.h
- third_party/blink/renderer/core/html/forms/chooser_only_temporal_input_type_view.cc
- third_party/blink/renderer/core/html/forms/chooser_only_temporal_input_type_view.h
- third_party/blink/renderer/core/html/forms/clear_button_element.cc
- third_party/blink/renderer/core/html/forms/clear_button_element.h
- third_party/blink/renderer/core/html/forms/color_chooser.h
- third_party/blink/renderer/core/html/forms/color_chooser_client.h
- third_party/blink/renderer/core/html/forms/color_chooser_popup_ui_controller.cc
- third_party/blink/renderer/core/html/forms/color_chooser_popup_ui_controller.h
- third_party/blink/renderer/core/html/forms/color_chooser_ui_controller.cc
- third_party/blink/renderer/core/html/forms/color_chooser_ui_controller.h
- third_party/blink/renderer/core/html/forms/color_input_type.cc
- third_party/blink/renderer/core/html/forms/color_input_type.h
- third_party/blink/renderer/core/html/forms/date_time_chooser.h
- third_party/blink/renderer/core/html/forms/date_time_chooser_client.h
- third_party/blink/renderer/core/html/forms/date_time_chooser_impl.cc
- third_party/blink/renderer/core/html/forms/date_time_chooser_impl.h
- third_party/blink/renderer/core/html/forms/date_time_edit_element.cc
- third_party/blink/renderer/core/html/forms/date_time_edit_element.h
- third_party/blink/renderer/core/html/forms/date_time_field_element.cc
- third_party/blink/renderer/core/html/forms/date_time_field_element.h
- third_party/blink/renderer/core/html/forms/external_date_time_chooser.cc
- third_party/blink/renderer/core/html/forms/external_date_time_chooser.h
- third_party/blink/renderer/core/html/forms/external_popup_menu.cc
- third_party/blink/renderer/core/html/forms/external_popup_menu.h
- third_party/blink/renderer/core/html/forms/file_input_type.cc
- third_party/blink/renderer/core/html/forms/file_input_type.h
- third_party/blink/renderer/core/html/forms/form_controller.cc
- third_party/blink/renderer/core/html/forms/form_controller.h
- third_party/blink/renderer/core/html/forms/form_data.cc
- third_party/blink/renderer/core/html/forms/form_data.h
- third_party/blink/renderer/core/html/forms/hidden_input_type.cc
- third_party/blink/renderer/core/html/forms/hidden_input_type.h
- third_party/blink/renderer/core/html/forms/html_form_control_element.cc
- third_party/blink/renderer/core/html/forms/html_form_control_element.h
- third_party/blink/renderer/core/html/forms/html_form_control_element_test.cc
- third_party/blink/renderer/core/html/forms/html_form_controls_collection.cc
- third_party/blink/renderer/core/html/forms/html_form_controls_collection.h
- third_party/blink/renderer/core/html/forms/html_form_element.cc
- third_party/blink/renderer/core/html/forms/html_form_element.h
- third_party/blink/renderer/core/html/forms/html_input_element.cc
- third_party/blink/renderer/core/html/forms/html_input_element.h
- third_party/blink/renderer/core/html/forms/html_output_element.cc
- third_party/blink/renderer/core/html/forms/html_output_element.h
- third_party/blink/renderer/core/html/forms/html_select_element.cc
- third_party/blink/renderer/core/html/forms/html_select_element.h
- third_party/blink/renderer/core/html/forms/input_type.cc
- third_party/blink/renderer/core/html/forms/input_type.h
- third_party/blink/renderer/core/html/forms/input_type_view.cc
- third_party/blink/renderer/core/html/forms/input_type_view.h
- third_party/blink/renderer/core/html/forms/internal_popup_menu.cc
- third_party/blink/renderer/core/html/forms/internal_popup_menu.h
- third_party/blink/renderer/core/html/forms/listed_element.cc
- third_party/blink/renderer/core/html/forms/listed_element.h
- third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc
- third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h
- third_party/blink/renderer/core/html/forms/picker_indicator_element.cc
- third_party/blink/renderer/core/html/forms/picker_indicator_element.h
- third_party/blink/renderer/core/html/forms/popup_menu.h
- third_party/blink/renderer/core/html/forms/radio_button_group_scope.cc
- third_party/blink/renderer/core/html/forms/radio_button_group_scope.h
- third_party/blink/renderer/core/html/forms/range_input_type.cc
- third_party/blink/renderer/core/html/forms/range_input_type.h
- third_party/blink/renderer/core/html/forms/spin_button_element.cc
- third_party/blink/renderer/core/html/forms/spin_button_element.h
- third_party/blink/renderer/core/html/forms/text_field_input_type.cc
- third_party/blink/renderer/core/html/forms/text_field_input_type.h
- third_party/blink/renderer/core/html/forms/validity_state.h
- third_party/blink/renderer/core/html/html_anchor_element.cc
- third_party/blink/renderer/core/html/html_anchor_element.h
- third_party/blink/renderer/core/html/html_collection.cc
- third_party/blink/renderer/core/html/html_collection.h
- third_party/blink/renderer/core/html/html_content_element.cc
- third_party/blink/renderer/core/html/html_content_element.h
- third_party/blink/renderer/core/html/html_frame_owner_element.cc
- third_party/blink/renderer/core/html/html_frame_owner_element.h
- third_party/blink/renderer/core/html/html_iframe_element.cc
- third_party/blink/renderer/core/html/html_iframe_element.h
- third_party/blink/renderer/core/html/html_image_element.cc
- third_party/blink/renderer/core/html/html_image_element.h
- third_party/blink/renderer/core/html/html_link_element.cc
- third_party/blink/renderer/core/html/html_link_element.h
- third_party/blink/renderer/core/html/html_marquee_element.cc
- third_party/blink/renderer/core/html/html_marquee_element.h
- third_party/blink/renderer/core/html/html_meter_element.cc
- third_party/blink/renderer/core/html/html_meter_element.h
- third_party/blink/renderer/core/html/html_object_element.cc
- third_party/blink/renderer/core/html/html_object_element.h
- third_party/blink/renderer/core/html/html_plugin_element.cc
- third_party/blink/renderer/core/html/html_plugin_element.h
- third_party/blink/renderer/core/html/html_progress_element.cc
- third_party/blink/renderer/core/html/html_progress_element.h
- third_party/blink/renderer/core/html/html_script_element.cc
- third_party/blink/renderer/core/html/html_script_element.h
- third_party/blink/renderer/core/html/html_slot_element.cc
- third_party/blink/renderer/core/html/html_slot_element.h
- third_party/blink/renderer/core/html/html_source_element.cc
- third_party/blink/renderer/core/html/html_source_element.h
- third_party/blink/renderer/core/html/html_style_element.cc
- third_party/blink/renderer/core/html/html_style_element.h
- third_party/blink/renderer/core/html/html_table_element.cc
- third_party/blink/renderer/core/html/html_table_element.h
- third_party/blink/renderer/core/html/html_template_element.cc
- third_party/blink/renderer/core/html/html_template_element.h
- third_party/blink/renderer/core/html/html_view_source_document.cc
- third_party/blink/renderer/core/html/html_view_source_document.h
- third_party/blink/renderer/core/html/image_document.cc
- third_party/blink/renderer/core/html/image_document.h
- third_party/blink/renderer/core/html/imports/html_import.h
- third_party/blink/renderer/core/html/imports/html_import_child.cc
- third_party/blink/renderer/core/html/imports/html_import_child.h
- third_party/blink/renderer/core/html/imports/html_import_child_client.h
- third_party/blink/renderer/core/html/imports/html_import_loader.cc
- third_party/blink/renderer/core/html/imports/html_import_loader.h
- third_party/blink/renderer/core/html/imports/html_import_tree_root.cc
- third_party/blink/renderer/core/html/imports/html_import_tree_root.h
- third_party/blink/renderer/core/html/imports/html_imports_controller.cc
- third_party/blink/renderer/core/html/imports/html_imports_controller.h
- third_party/blink/renderer/core/html/imports/link_import.cc
- third_party/blink/renderer/core/html/imports/link_import.h
- third_party/blink/renderer/core/html/lazy_load_frame_observer.cc
- third_party/blink/renderer/core/html/lazy_load_frame_observer.h
- third_party/blink/renderer/core/html/link_resource.cc
- third_party/blink/renderer/core/html/link_resource.h
- third_party/blink/renderer/core/html/link_style.cc
- third_party/blink/renderer/core/html/link_style.h
- third_party/blink/renderer/core/html/media/autoplay_policy.cc
- third_party/blink/renderer/core/html/media/autoplay_policy.h
- third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
- third_party/blink/renderer/core/html/media/autoplay_uma_helper.h
- third_party/blink/renderer/core/html/media/html_media_element.cc
- third_party/blink/renderer/core/html/media/html_media_element.h
- third_party/blink/renderer/core/html/media/html_video_element.cc
- third_party/blink/renderer/core/html/media/html_video_element.h
- third_party/blink/renderer/core/html/media/media_controls.cc
- third_party/blink/renderer/core/html/media/media_controls.h
- third_party/blink/renderer/core/html/media/media_custom_controls_fullscreen_detector.cc
- third_party/blink/renderer/core/html/media/media_custom_controls_fullscreen_detector.h
- third_party/blink/renderer/core/html/media/media_remoting_interstitial.cc
- third_party/blink/renderer/core/html/media/media_remoting_interstitial.h
- third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
- third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.h
- third_party/blink/renderer/core/html/media/remote_playback_controller.cc
- third_party/blink/renderer/core/html/media/remote_playback_controller.h
- third_party/blink/renderer/core/html/media/video_wake_lock.cc
- third_party/blink/renderer/core/html/media/video_wake_lock.h
- third_party/blink/renderer/core/html/parser/html_construction_site.cc
- third_party/blink/renderer/core/html/parser/html_construction_site.h
- third_party/blink/renderer/core/html/parser/html_document_parser.cc
- third_party/blink/renderer/core/html/parser/html_document_parser.h
- third_party/blink/renderer/core/html/parser/html_element_stack.cc
- third_party/blink/renderer/core/html/parser/html_element_stack.h
- third_party/blink/renderer/core/html/parser/html_formatting_element_list.h
- third_party/blink/renderer/core/html/parser/html_parser_scheduler.cc
- third_party/blink/renderer/core/html/parser/html_parser_scheduler.h
- third_party/blink/renderer/core/html/parser/html_resource_preloader.cc
- third_party/blink/renderer/core/html/parser/html_resource_preloader.h
- third_party/blink/renderer/core/html/parser/html_stack_item.h
- third_party/blink/renderer/core/html/parser/html_tree_builder.cc
- third_party/blink/renderer/core/html/parser/html_tree_builder.h
- third_party/blink/renderer/core/html/parser/xss_auditor_delegate.cc
- third_party/blink/renderer/core/html/parser/xss_auditor_delegate.h
- third_party/blink/renderer/core/html/plugin_document.cc
- third_party/blink/renderer/core/html/plugin_document.h
- third_party/blink/renderer/core/html/track/audio_track.cc
- third_party/blink/renderer/core/html/track/audio_track.h
- third_party/blink/renderer/core/html/track/audio_track_list.h
- third_party/blink/renderer/core/html/track/cue_timeline.cc
- third_party/blink/renderer/core/html/track/cue_timeline.h
- third_party/blink/renderer/core/html/track/html_track_element.cc
- third_party/blink/renderer/core/html/track/html_track_element.h
- third_party/blink/renderer/core/html/track/loadable_text_track.cc
- third_party/blink/renderer/core/html/track/loadable_text_track.h
- third_party/blink/renderer/core/html/track/text_track.cc
- third_party/blink/renderer/core/html/track/text_track.h
- third_party/blink/renderer/core/html/track/text_track_container.cc
- third_party/blink/renderer/core/html/track/text_track_container.h
- third_party/blink/renderer/core/html/track/text_track_cue.cc
- third_party/blink/renderer/core/html/track/text_track_cue.h
- third_party/blink/renderer/core/html/track/text_track_cue_list.cc
- third_party/blink/renderer/core/html/track/text_track_cue_list.h
- third_party/blink/renderer/core/html/track/text_track_list.cc
- third_party/blink/renderer/core/html/track/text_track_list.h
- third_party/blink/renderer/core/html/track/track_base.cc
- third_party/blink/renderer/core/html/track/track_base.h
- third_party/blink/renderer/core/html/track/track_event.cc
- third_party/blink/renderer/core/html/track/track_event.h
- third_party/blink/renderer/core/html/track/track_list_base.h
- third_party/blink/renderer/core/html/track/video_track.cc
- third_party/blink/renderer/core/html/track/video_track.h
- third_party/blink/renderer/core/html/track/video_track_list.h
- third_party/blink/renderer/core/html/track/vtt/vtt_cue.cc
- third_party/blink/renderer/core/html/track/vtt/vtt_cue.h
- third_party/blink/renderer/core/html/track/vtt/vtt_parser.cc
- third_party/blink/renderer/core/html/track/vtt/vtt_parser.h
- third_party/blink/renderer/core/html/track/vtt/vtt_region.cc
- third_party/blink/renderer/core/html/track/vtt/vtt_region.h
-
[Managed Session] Activate managed session mode when risky extension is installed
Changed by Zakhar Voit - voitohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 10:47:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 800c07ef76d8166c52befb086b4ffcef6b7cea89 Comments
[Managed Session] Activate managed session mode when risky extension is installed Managed session mode now is only activated when any "risky" extensions are force-installed. Right now an extension is considered "risky" if it's force-installed, but not whitelisted. Bug: 910218 Change-Id: I42cc76e3723513b23f827c99505a096e3832a94d Reviewed-on: https://chromium-review.googlesource.com/c/1391589 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#625159}
Changed files
- chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
- chrome/browser/chromeos/policy/device_local_account_browsertest.cc
-
Make it easier to use traits with TestBrowserThreadBundle
Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 10:43:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f0527a9b0c9321be0b6fd9f0fe118d4c01005e22 Comments
Make it easier to use traits with TestBrowserThreadBundle All those default values made TestBrowserThreadBundle's constructor (and ChromeRenderViewHostTestHarness and BrowserWithTestWindowTest) awkward to use and maintain (imagine if we added another trait to ScopedTaskEnvironment). This patch changes TestBrowserThreadBundle's main constructor to take zero or more traits to configure the TestBrowserThreadBundle and the underlying ScopedTaskEnvironment. Note there is a 20kb test binary size hit which we are happy to take in favour of readability for tests but that this paradigm should be used with care on non-constexpr types in prod. A number of clients of TestBrowserThreadBundle are also refactored to take advantage of this. Change-Id: I2bdb3b8c382f1389058508f870815eddb500726d Bug: 881041 Reviewed-on: https://chromium-review.googlesource.com/c/1394377 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#625158}
Changed files
- base/task/test_task_traits_extension.h
- base/test/scoped_task_environment.cc
- base/test/scoped_task_environment.h
- base/traits_bag.h
- base/traits_bag_unittest.cc
- chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc
- chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
- chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
- chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager_unittest.cc
- chrome/browser/chromeos/power/ml/user_activity_manager_unittest.cc
- chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc
- chrome/browser/extensions/api/image_writer_private/test_utils.cc
- chrome/browser/extensions/api/notifications/extension_notification_handler_unittest.cc
- chrome/browser/extensions/extension_service_test_base.cc
- chrome/browser/metrics/subprocess_metrics_provider_unittest.cc
- chrome/browser/sync/glue/extensions_activity_monitor_unittest.cc
- chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
- chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc
- chrome/browser/ui/views/frame/browser_view_unittest.cc
- chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
- chrome/browser/ui/views/frame/test_with_browser_view.cc
- chrome/browser/ui/views/frame/test_with_browser_view.h
- chrome/test/base/browser_with_test_window_test.cc
- chrome/test/base/browser_with_test_window_test.h
- chrome/test/base/chrome_render_view_host_test_harness.cc
- chrome/test/base/chrome_render_view_host_test_harness.h
- components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc
- components/drive/file_system/operation_test_base.cc
- components/drive/file_system/operation_test_base.h
- content/browser/net/network_quality_observer_impl_unittest.cc
- content/public/test/test_browser_thread_bundle.cc
- content/public/test/test_browser_thread_bundle.h
- content/public/test/test_browser_thread_bundle_unittest.cc
- content/public/test/test_renderer_host.cc
- content/public/test/test_renderer_host.h
- extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc
- extensions/browser/extensions_test.cc
- extensions/browser/extensions_test.h
- extensions/browser/image_sanitizer_unittest.cc
- extensions/browser/json_file_sanitizer_unittest.cc
- extensions/browser/sandboxed_unpacker_unittest.cc
-
Introduce MemoryUsageMonitor
Changed by Keishi Hattori - keishiohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 10:43:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9a9ccbc08949a7936b803e58117a57cc26b46de8 Comments
Introduce MemoryUsageMonitor CrashMemoryMetricsReporterImpl, OomInterventionImpl, and the "additional critical memory pressure generator" we plan to implement, all require access to periodic memory usage data. This CL introduces a MemoryUsageMonitor class that periodically checks the memory usage and notifies its observers. Bug=920922 Change-Id: I1243ffa43369b6accedf3a0eb000230438c34883 Reviewed-on: https://chromium-review.googlesource.com/c/1404903 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#625157}
Changed files
- third_party/blink/renderer/controller/BUILD.gn
- third_party/blink/renderer/controller/memory_usage_monitor.cc
- third_party/blink/renderer/controller/memory_usage_monitor.h
- third_party/blink/renderer/controller/memory_usage_monitor_android.cc
- third_party/blink/renderer/controller/memory_usage_monitor_android.h
- third_party/blink/renderer/controller/memory_usage_monitor_android_test.cc
- third_party/blink/renderer/controller/memory_usage_monitor_test.cc
- third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
-
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in browser
Changed by Carlos Caballero - carlscabohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 10:41:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5ffb39e60dfd31ac34ad5a47d8cca69169376af7 Comments
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in browser MessageLoop will go away, eventually. BUG=891670 Change-Id: I61904bdd8b32af26509ef2f78cfb3b51361fa891 Reviewed-on: https://chromium-review.googlesource.com/c/1417175 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#625156}
Changed files
- chrome/browser/internal_auth_unittest.cc
-
Restore TWA snackbar when Chrome comes back to foreground
Changed by Pavel Shmakov - pshmakovohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 10:35:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3e096b0304b62604c486da4d4fcdd02e627ac208 Comments
Restore TWA snackbar when Chrome comes back to foreground SnackbarManager removes all snackbars when Chrome goes to background, so we must restore TWA snackbar when coming back to foreground Bug: 923861 Change-Id: I9480fb6e4aace42890abad19433ff612fabece19 Reviewed-on: https://chromium-review.googlesource.com/c/1426706 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#625155}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
-
[s13n] Deploy the replacement PO2TS::LoadCredentials in account_reconcilor_unittest.cc
Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com Changed at Wednesday, 23-Jan-19 10:35:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 622df21ada9c40475e26feb24e1f8d30a7088ee6 Comments
[s13n] Deploy the replacement PO2TS::LoadCredentials in account_reconcilor_unittest.cc This is a follow up of [1], when the IdentityManager::LegacyLoadCredentials API was added. [1] https://chromium-review.googlesource.com/c/1412775 BUG=910581 Change-Id: If6faf0d242149ec57d2560c2c6d4d6295907c2cd Reviewed-on: https://chromium-review.googlesource.com/c/1425659 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#625154}
Changed files
- components/signin/core/browser/account_reconcilor_unittest.cc