Home | Search | chromium - Builders
Login

Builder android-cronet-kitkat-arm-rel Build 5093 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision346d1aac0d7c49126b8a9943434ee88af85481af
Got Revision346d1aac0d7c49126b8a9943434ee88af85481af

Execution:

Steps and Logfiles:

Show:
  1. ( 312 ms ) setup_build
    running recipe: "chromium"
  2. ( 223 ms ) report builders
     
    running tester 'android-cronet-kitkat-arm-rel' on master 'chromium.android'
  3. ( 47 secs ) bot_update
    [78GB/295GB used (26%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 1 secs ) clobber
  6. ( 11 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 462 ms ) lookup builder GN args
     
    Count of GN args (23) exceeds limit (15), presented in logs instead
  9. ( 3 secs ) clean local files
  10. ( 607 ms ) tree truth steps
  11. ( 449 ms ) build directory
  12. ( 437 ms ) find isolated tests
  13. ( 724 ms ) wait for tasks
  14. ( 2 secs ) cronet_smoketests_platform_only_instrumentation_apk on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 28s
  15. ( 2 secs ) cronet_smoketests_missing_native_library_instrumentation_apk on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:04.594739
  16. ( 2 secs ) cronet_test_instrumentation_apk on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:13:44.222107
  17. ( 2 secs ) cronet_sample_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 26s
  18. ( 35 secs ) net_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:06:52.167659 (shard #3)
    Min shard duration: 0:06:34.869270 (shard #1)
  19. ( 921 ms ) wait for tasks (2)
  20. ( 2 secs ) cronet_tests_android on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 41s
  21. ( 3 secs ) cronet_unittests_android on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 34s
  22. ( 236 ms ) Tests statistics
     
    Stats
    Total shards: 10
    Total runtime: 0:41:26.781821
     
  23. ( 376 ms ) test_report

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2474-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541786619574582, "id": "8930313269551623584", "project": "chromium", "tags": ["builder:android-cronet-kitkat-arm-rel", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/346d1aac0d7c49126b8a9943434ee88af85481af", "gitiles_ref:refs/heads/master", "parent_buildername:android-cronet-arm-rel", "parent_buildnumber:7788", "scheduler_invocation_id:9095743331640526112", "scheduler_job_id:chromium/android-cronet-kitkat-arm-rel", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "android-cronet-kitkat-arm-rel" setup_build
buildnumber 5093 setup_build
mastername "chromium.android" setup_build
parent_buildername "android-cronet-arm-rel" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "346d1aac0d7c49126b8a9943434ee88af85481af" setup_build
parent_got_revision_cp "refs/heads/master@{#606891}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.287@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "346d1aac0d7c49126b8a9943434ee88af85481af" setup_build
swarm_hashes {"cronet_sample_test_apk": "022532a2221818baf07759fc00563e5dcf77a8b2", "cronet_smoketests_missing_native_library_instrumentation_apk": "8b2ad2ff44587690d45d8b635da54f23743c37ee", "cronet_smoketests_platform_only_instrumentation_apk": "c2f4562e75e922e8abbfc87a74a750534fe391dc", "cronet_test_instrumentation_apk": "d3a9dde0cf3cdac77613320a8fec10f4c244f662", "cronet_tests_android": "87fd7e0db6069b17f80b6443939eeee17c303d24", "cronet_unittests_android": "7d1b1b0c979d9401cfb13f465e2e55b051ecc7d7", "net_unittests": "791fc35c106e34dcf51c6e3f55c14fd1eb6310df"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "346d1aac0d7c49126b8a9943434ee88af85481af" bot_update
got_revision_cp "refs/heads/master@{#606891}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" bot_update
got_v8_revision_cp "refs/heads/7.2.287@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Bin Wu (wubohnoyoudont@chromium.org)
  2. Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
  3. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  4. Fady Samuel (fsamuelohnoyoudont@chromium.org)
  5. Joe DeBlasio (jdeblasioohnoyoudont@chromium.org)
  6. Sky Malice (skymohnoyoudont@google.com)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. Hayato Ito (hayatoohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 18:03:39 UTC
Start Friday, 09-Nov-18 18:03:41 UTC
End Friday, 09-Nov-18 18:06:40 UTC
Pending 2 secs
Execution 2 mins 58 secs

All Changes:

  1. Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."

    Changed by Bin Wu - wubohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:45:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 346d1aac0d7c49126b8a9943434ee88af85481af

    Comments

    Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."
    
    This reverts commit 683a348730bbea7ccea7158eacc04b928b3d5256.
    
    
    In addition to the auto-revert, I also changed two bzero calls to memset calls. I don't know why, but net_unittest under msan fails with a use-of-uninitialized-value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930601665674446576/+/steps/net_unittests/0/stdout
    
    The msan error goes away after I changed the following bzero(s) into memset(s):
    
    diff --git a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    index 94f055f35564..198e266dfdf2 100644
    --- a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    +++ b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    @@ -102,7 +102,7 @@ class QuicMMsgHdr {
         }
    
         storage_.reset(new char[StorageSize()]);
    -    bzero(&storage_[0], StorageSize());
    +    memset(&storage_[0], 0, StorageSize());
    
         int i = -1;
         for (auto it = first; it != last; ++it) {
    diff --git a/net/third_party/quic/platform/impl/quic_socket_utils.cc b/net/third_party/quic/platform/impl/quic_socket_utils.cc
    index c25f4697dbef..1f252e50f953 100644
    --- a/net/third_party/quic/platform/impl/quic_socket_utils.cc
    +++ b/net/third_party/quic/platform/impl/quic_socket_utils.cc
    @@ -78,7 +78,7 @@ void* QuicMsgHdr::GetNextCmsgDataInternal(int cmsg_level,
    
       if (cmsg_ == nullptr) {
         DCHECK_EQ(nullptr, hdr_.msg_control);
    -    bzero(cbuf_, cbuf_size_);
    +    memset(cbuf_, 0, cbuf_size_);
         hdr_.msg_control = cbuf_;
         cmsg_ = CMSG_FIRSTHDR(&hdr_);
       } else {
    
    
    R=rch@chromium.org
    
    Change-Id: Ibe60068cb87c0f974088b8c1601cc516ee333106
    Reviewed-on: https://chromium-review.googlesource.com/c/1329348
    Commit-Queue: Bin Wu <wub@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606891}

    Changed files

    • net/BUILD.gn
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_test.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer_test.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    • net/third_party/quic/platform/impl/quic_linux_socket_utils_test.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.h
  2. [iOS][MF] Adds password related histograms

    Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:41:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f350cfe2c23c02c23f852840ee9d5e08d9c61e96

    Comments

    [iOS][MF] Adds password related histograms
    
    Bug: 878388
    Change-Id: Ia0a6622596753d87888e480401e38f7ef61ae539
    Reviewed-on: https://chromium-review.googlesource.com/c/1326013
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606890}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
    • tools/metrics/histograms/histograms.xml
  3. Roll src-internal 827de2c806ba..5fa11106b909 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:40:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e4f2a9f17b74405f73aca4ecee7dcd639477de6

    Comments

    Roll src-internal 827de2c806ba..5fa11106b909 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/827de2c806ba..5fa11106b909
    
    
    Created with:
      gclient setdep -r src-internal@5fa11106b909
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ie1b9b04d41e2a6dfe8e4fa45f0d25892052660e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1329503
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606889}

    Changed files

    • DEPS
  4. viz: Plumb LocalSurfaceIdAllocation to more places [part 5]

    Changed by Fady Samuel - fsamuelohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:36:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e806513b1b91da6e96a56bfd3ca5f464c4666b9

    Comments

    viz: Plumb LocalSurfaceIdAllocation to more places [part 5]
    
    viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an
    allocation time for that viz::LocalSurfaceId. The purpose of this allocation
    time is to determine how long it takes for a surface to get embedded once
    an ID has been allocated for it.
    
    There was some concern raised about drift between LocalSurfaceIds and allocation
    times and so a previous CL bundled the two together in a class. This CL plumbs
    LocalSurfaceIdAllocation to more places to ensure the two quantities remain
    in sync with one another.
    
    This CL plumbs removes various accessors on ChildLocalSurfaceIdAllocator and
    ParentLocalSurfaceIdAllocator that return an allocation time or LocalSurfaceId
    independent of the other. This is to encourage future plumbing of
    LocalSurfaceIdAllocation instead.
    
    Bug: 655231
    Change-Id: I3118cc06e0afa04914a0e2e7457ffdfd5ad5778d
    Reviewed-on: https://chromium-review.googlesource.com/c/1327573
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606888}

    Changed files

    • cc/test/layer_tree_test.cc
    • cc/test/layer_tree_test.h
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_unittest.cc
    • components/viz/common/surfaces/child_local_surface_id_allocator.h
    • components/viz/common/surfaces/child_local_surface_id_allocator_unittest.cc
    • components/viz/common/surfaces/parent_local_surface_id_allocator.h
    • components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
    • third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
  5. Record Android revokes in Permissions.Action.Notification.

    Changed by Joe DeBlasio - jdeblasioohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8c0f174bb015976222531ead359ade19b488833

    Comments

    Record Android revokes in Permissions.Action.Notification.
    
    This CL modifies fixes a bug in which metrics were not being recorded on
    Android when notification permissions were revoked. It adds a missing
    ScopedRevocationReporter for Chrome-visible changes, and adds detection
    code for when notification permissions are revoked in Android O+
    system channel settings.
    
    Bug: 782126
    Change-Id: I609e909936d09e6dd948f0601bbf73ecdb6b8b75
    Reviewed-on: https://chromium-review.googlesource.com/c/1324394
    Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Christopher Thompson <cthomp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606887}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java
    • chrome/browser/android/preferences/website_preference_bridge.cc
    • chrome/browser/permissions/permission_uma_util.h
    • tools/metrics/ukm/ukm.xml
  6. [Feed] Check loadUrlParams for null, fallback to opening online.

    Changed by Sky Malice - skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 60b47f98f87e0f3689826e4342fab09b7a35ed5e

    Comments

    [Feed] Check loadUrlParams for null, fallback to opening online.
    
    Bug: 901179
    Change-Id: Ieb3a421a7930ddc0014f7ef57b6a8f6d89dc3615
    Reviewed-on: https://chromium-review.googlesource.com/c/1315358
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606886}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/action/FeedActionHandler.java
    • chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
  7. Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:32:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0475284ad58e36e9950059000bb7ec3556bb31bb

    Comments

    Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/cf90797ef05a..5fc6c2c52e7b
    
    
    git log cf90797ef05a..5fc6c2c52e7b --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: allow integers to be compared against doubles"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@5fc6c2c52e7b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ifd53d09565e264f09c1deffb23f8adfce3a34958
    Reviewed-on: https://chromium-review.googlesource.com/c/1329505
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606885}

    Changed files

    • DEPS
  8. Fix a bug in https://crrev.com/c/1272937, where event.target can be still null

    Changed by Hayato Ito - hayatoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:31:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ed9605b4c99774d8865dbd190e13c9fe5c2d03a

    Comments

    Fix a bug in https://crrev.com/c/1272937, where event.target can be still null
    
    Fix a bug in the previous CL, https://crrev.com/c/1272937, where event.target
    can be null when GetElement() returns nullptr.
    
    Bug: 892970, 893449, 902287
    Change-Id: I7a08227d39117c2dc90fe720f0d6ffd62d9b2ea6
    Reviewed-on: https://chromium-review.googlesource.com/c/1322177
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606884}

    Changed files

    • third_party/blink/renderer/modules/accessibility/ax_object.cc