Builder Windows deterministic
Build 11624
Results:
Success
Trigger Info:
Project | chromium |
Revision | f1639a837a7242ab03ff36399277bd47ccaf1d4a |
Got Revision | f1639a837a7242ab03ff36399277bd47ccaf1d4a |
Execution:
- Source: Task 426f7b826ccf6310
- Bot: swarm2173-c4
- Recipe: swarming/deterministic_build
Steps and Logfiles:
Show:-
- - no logs -
-
( 500 ms ) lookup GN argsis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1target_cpu = "x86"use_goma = truegoma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
-
- - no logs -
-
- - no logs -
-
( 795 ms ) lookup GN args (2)is_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1target_cpu = "x86"use_goma = truegoma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm2173-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547642205501535, "id": "8924173242683028224", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/f1639a837a7242ab03ff36399277bd47ccaf1d4a", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f1639a837a7242ab03ff36399277bd47ccaf1d4a", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089603304834249616", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Windows deterministic" | setup_build |
buildnumber | 11624 | setup_build |
mastername | "chromium.win" | setup_build |
path_config | "generic" | setup_build |
recipe | "swarming/deterministic_build" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "f1639a837a7242ab03ff36399277bd47ccaf1d4a" | setup_build |
got_angle_revision | "ab2bfa814ceefdcbe24483b3a12ba525345d486c" | bot_update |
got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | bot_update |
got_dawn_revision | "acd8b7d937cc4dcc81856377863f2d56af7037b5" | bot_update |
got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | bot_update |
got_revision | "f1639a837a7242ab03ff36399277bd47ccaf1d4a" | bot_update |
got_revision_cp | "refs/heads/master@{#623205}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "871f913bad24b4ead79468f431a1ae8326d9d27b" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.412@{#1}" | bot_update |
got_webrtc_revision | "ccc1b57e32bd99e4f220a3db0e540713f4349ad9" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26266}" | bot_update |
Blamelist:
- Mike Reed (reedohnoyoudont@google.com)
- Roman Aleksandrov (raleksandrovohnoyoudont@google.com)
- Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
- David Jean (djeanohnoyoudont@google.com)
- Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Dominik Röttsches (drottohnoyoudont@chromium.org)
- Fergal Daly (fergalohnoyoudont@chromium.org)
- dstockwell (dstockwellohnoyoudont@google.com)
- Alexander Yashkin (a-v-yohnoyoudont@yandex-team.ru)
- Jan Krcal (jkrcalohnoyoudont@chromium.org)
- Vladislav Kuzkokov (vkuzkokovohnoyoudont@chromium.org)
- Dominik Röttsches (drottohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 16-Jan-19 12:36:45 UTC |
Start | Wednesday, 16-Jan-19 12:36:48 UTC |
End | Wednesday, 16-Jan-19 14:01:28 UTC |
Pending | 2 secs |
Execution | 1 hrs 24 mins |
All Changes:
-
drawText is deprecated, use drawSimpleText or drawTextBlob
Changed by Mike Reed - reedohnoyoudont@google.com Changed at Wednesday, 16-Jan-19 12:19:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f1639a837a7242ab03ff36399277bd47ccaf1d4a Comments
drawText is deprecated, use drawSimpleText or drawTextBlob Bug: skia:2664 Change-Id: Iaf60f02455f530031fecfefc1d022b448643302a Reviewed-on: https://chromium-review.googlesource.com/c/1413635 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#623205}
Changed files
- media/capture/video/fake_video_capture_device.cc
-
Fix sleeping lag in Chrome/ChromeOS relaunch-to-update timer
Changed by Roman Aleksandrov - raleksandrovohnoyoudont@google.com Changed at Wednesday, 16-Jan-19 12:15:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7ed8e104acef9a74047e20fccbc0c53602e7958e Comments
Fix sleeping lag in Chrome/ChromeOS relaunch-to-update timer Migrate RelaunchNotificationController from using OneShotTimer to WallClockTimer which based on real time. Refactor all surroundings to use base::Time instead of base::TimeTicks as well. Bug: 906689 Change-Id: If65cd37ac8d7e1848a2a6c0dfa1f7a50b6aeca0f Reviewed-on: https://chromium-review.googlesource.com/c/1397633 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#623204}
Changed files
- chrome/browser/ui/toolbar/app_menu_icon_controller_unittest.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.h
- chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_chromeos.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_chromeos.h
- chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_desktop.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_desktop.h
- chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_unittest.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.h
- chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view_browsertest.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_recommended_timer.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_recommended_timer.h
- chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.h
- chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view_browsertest.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_required_timer.cc
- chrome/browser/ui/views/relaunch_notification/relaunch_required_timer.h
- chrome/browser/ui/views/relaunch_notification/wall_clock_timer.cc
- chrome/browser/ui/views/relaunch_notification/wall_clock_timer.h
- chrome/browser/ui/views/relaunch_notification/wall_clock_timer_unittest.cc
- chrome/browser/upgrade_detector/upgrade_detector.cc
- chrome/browser/upgrade_detector/upgrade_detector.h
- chrome/browser/upgrade_detector/upgrade_detector_chromeos.cc
- chrome/browser/upgrade_detector/upgrade_detector_chromeos.h
- chrome/browser/upgrade_detector/upgrade_detector_impl.cc
- chrome/browser/upgrade_detector/upgrade_detector_impl.h
- chrome/browser/upgrade_detector/upgrade_detector_impl_unittest.cc
-
Perf tests changing available size for fit-content child.
Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 12:14:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b658d76d4bb05bc93cba0281c3607393177f0f4e Comments
Perf tests changing available size for fit-content child. Change-Id: I7098bd765b0b1ea6e272c4472b0598d1da95dbe2 Reviewed-on: https://chromium-review.googlesource.com/c/1411599 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#623203}
Changed files
- third_party/blink/perf_tests/layout/fit-content-change-available-size-blocks.html
- third_party/blink/perf_tests/layout/fit-content-change-available-size-text.html
-
[ios] Add js injection for password generation
Changed by David Jean - djeanohnoyoudont@google.com Changed at Wednesday, 16-Jan-19 12:10:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9e0c5379d6809b2caf0a08e71834ff589bd7d295 Comments
[ios] Add js injection for password generation Bug: 886583 Change-Id: I557d7204102f4a28cfb1f6d91a37df50e117e3bd Reviewed-on: https://chromium-review.googlesource.com/c/1379898 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#623202}
Changed files
- components/autofill/core/common/password_form_generation_data.h
- components/password_manager/core/browser/new_password_form_manager.cc
- components/password_manager/core/browser/new_password_form_manager_unittest.cc
- components/password_manager/ios/js_password_manager.h
- components/password_manager/ios/js_password_manager.mm
- components/password_manager/ios/password_form_helper.h
- components/password_manager/ios/password_form_helper.mm
- components/password_manager/ios/resources/password_controller.js
- ios/chrome/browser/passwords/password_controller.h
- ios/chrome/browser/passwords/password_controller.mm
- ios/chrome/browser/passwords/password_controller_js_unittest.mm
- ios/chrome/browser/passwords/password_tab_helper.h
- ios/chrome/browser/passwords/password_tab_helper.mm
- ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm
-
Import wpt@344e01763afe4e707286188ce6c1b4584cb1b864
Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Wednesday, 16-Jan-19 11:41:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8fac1ece71d743450a3543092a24c156e2d9d414 Comments
Import wpt@344e01763afe4e707286188ce6c1b4584cb1b864 Using wpt-import in Chromium 893c068d35a42afd462e3caebc35ef3814af99f8. With Chromium commits locally applied on WPT: 1c633d483b "Snap the snapped_dest_rect for backgrounds" 1061788dd2 "Reland "Add quota usage details tests for all other storage backends."" bcd3934d05 "Add a test for ServiceWorker and AppCache interaction with claim()" 4836c563b1 "Change web platform test with mouse inputs under "pinterevents/"" 33a49f0de5 "[WebLocks]: Modifying weblocks algos to be O(1)" 66a94294e7 "Verify getContributingSources() does not return any CSRCs." 8e4e5d7297 "Fix preload tests failing on wpt.fyi dashboard" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I4f69c20aac42b9131c9886f8f2bef1e7f93b0536 Reviewed-on: https://chromium-review.googlesource.com/c/1414870 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623201}
Changed files
- third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
- third_party/blink/web_tests/external/wpt/css/css-device-adapt/documentElement-clientWidth-on-minimum-scale-size.tentative.html
-
Roll src-internal f2c8fe4e24b3..8b326e1c2f3d (1 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 16-Jan-19 11:37:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d38340b89f86c31c52b26924675466e717d7e1ed Comments
Roll src-internal f2c8fe4e24b3..8b326e1c2f3d (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2c8fe4e24b3..8b326e1c2f3d Created with: gclient setdep -r src-internal@8b326e1c2f3d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie1cf5ccd165b57597acebc1db00091fffbc07d52 Reviewed-on: https://chromium-review.googlesource.com/c/1414699 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623200}
Changed files
- DEPS
-
Reland "Enable unique font matching matching by default"
Changed by Dominik Röttsches - drottohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 11:36:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f Comments
Reland "Enable unique font matching matching by default" This reverts commit f6c717eb8b60f311b6357b3ddace4c79b1a2e64e. Reason for revert: Crash has been addressed in https://chromium-review.googlesource.com/c/chromium/src/+/1414852 Original change's description: > Revert "Enable unique font matching matching by default" > > This reverts commit 2e8e7c130cbb432732e973fd8c266a0608727b5f. > > Reason for revert: Crashes observed in Windows Canary > > Bug: 922183 > > Original change's description: > > Enable unique font matching matching by default > > > > Now that all implementations for Android, Windows, Linux/CrOS and Mac > > are in place, enable the feature globally. Chrome will match fonts > > references in @font-face { src: local(<font-name>) } correctly by > > postscript name or full font name. This addresses a long standing, > > highly starred font matching issue in Chrome. > > > > Bug: 828317, 627143, 921029 > > Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004 > > Reviewed-on: https://chromium-review.googlesource.com/c/1400695 > > Commit-Queue: Dominik Röttsches <drott@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622456} > > TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 828317, 627143, 921029 > Change-Id: I6a89f36923abb7d87de712c9ac0852da06a66d37 > Reviewed-on: https://chromium-review.googlesource.com/c/1412824 > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622898} TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org Change-Id: I915e1bb20ee51325befa5ef7eab07f78eaa8c974 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922183, 828317, 627143, 921029, 922183 Reviewed-on: https://chromium-review.googlesource.com/c/1413603 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#623199}
Changed files
- content/public/common/content_features.cc
- third_party/blink/web_tests/NeverFixTests
- third_party/blink/web_tests/fast/css/font-face-character-fallback.html
- third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
- third_party/blink/web_tests/fast/css/font-face-download-error.html
- third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
- third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
- third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
- third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
- third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
- third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
- third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
- third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
- third_party/blink/web_tests/fast/text/capitalize-boundaries.html
- third_party/blink/web_tests/fast/text/unique-vs-family-match.html
- third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
- third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
- third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
- third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png
-
[CSS] Support ::part with ::before/::after
Changed by Fergal Daly - fergalohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 11:32:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 58c317ab643531e1bfff4d58007310cb9faba0cf Comments
[CSS] Support ::part with ::before/::after This enables it for ::before, ::after and ::placeholder and adds a test for all 3 but for reasons I haven't dug into yet, ::placeholder doesn't work with ::part, so this includes a failing expectation. Bug: 921908 Change-Id: I60a859ede98f8284cb3a1e44c81a33230b490239 Reviewed-on: https://chromium-review.googlesource.com/c/1414536 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#623198}
Changed files
- third_party/blink/renderer/core/css/parser/css_selector_parser.cc
- third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
- third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-tree-abiding-expected.txt
- third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-tree-abiding.html
-
pdf: Use chrome.fileSystem.chooseFile when saving PDF from extension
Changed by dstockwell - dstockwellohnoyoudont@google.com Changed at Wednesday, 16-Jan-19 11:31:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dc03dd49f4a78c65985e75796edaafc7719a506d Comments
pdf: Use chrome.fileSystem.chooseFile when saving PDF from extension This matches the save behavior of the plugin, where a file picker is opened rather than the file being immediately downloaded. Bug: 61248 Change-Id: I2481ffcb8fe1ba346acadb8106d786ee09fc8a94 Reviewed-on: https://chromium-review.googlesource.com/c/1356161 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#623197}
Changed files
- chrome/browser/resources/pdf/manifest.json
- chrome/browser/resources/pdf/pdf_viewer.js
- extensions/common/api/_permission_features.json
-
Fixed IPC memory leak of prerender alias urls messages.
Changed by Alexander Yashkin - a-v-yohnoyoudont@yandex-team.ru Changed at Wednesday, 16-Jan-19 11:26:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6b058fecd94d99f75aec20fa7eb05cbc3bcc1c41 Comments
Fixed IPC memory leak of prerender alias urls messages. This patch fixes minor leak of prerender IPC messages that are broadcasted to all renderers to inform that alias url is added or removed. Added check that target renderer is initialized and not dead. More details for reasons of leaks are described in https://bugs.chromium.org/p/chromium/issues/detail?id=813045 Bug: 813045 Change-Id: Ida6ea0eae4fbfd0e89ede9863449168d95d93fd2 Reviewed-on: https://chromium-review.googlesource.com/c/1406629 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Matthew Cary <mattcary@chromium.org> Reviewed-by: Alexander Semashko <ahest@yandex-team.ru> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#623196}
Changed files
- chrome/browser/prerender/prerender_contents.cc
-
[Custom passphrase] Moving ScopedFeatureList out of the test body
Changed by Jan Krcal - jkrcalohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 11:23:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision beb2bb688f7780a1810f76c07c834f73a549fa73 Comments
[Custom passphrase] Moving ScopedFeatureList out of the test body This CL addresses a TSan failure that occurs when the global g_feature_list_instance is changed after some parts of Chrome has been initialized (and have accessed the previous g_feature_list_instance via FeatureList::IsEnabled()). Thus, this CL removed the use of ScopedFeatureList from the test body (where possible). Bug: 915219 Change-Id: I8c442c1c7dcbc7e7086daa41fc4dcc4919e84339 Reviewed-on: https://chromium-review.googlesource.com/c/1411930 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#623195}
Changed files
- chrome/browser/sync/test/integration/two_client_custom_passphrase_sync_test.cc
-
Partial cleanup use of base::Value in printing backend.
Changed by Vladislav Kuzkokov - vkuzkokovohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 11:21:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 490ab0c8364fdf4b25829ff56b3df401b988bec8 Comments
Partial cleanup use of base::Value in printing backend. Bug: 660612 Change-Id: I75404c19cf794abee8eff74e78005226139682b9 Reviewed-on: https://chromium-review.googlesource.com/c/1387467 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#623194}
Changed files
- chrome/browser/printing/print_job_worker.cc
- chrome/browser/printing/print_job_worker.h
- chrome/browser/printing/print_view_manager_base.cc
- chrome/browser/printing/print_view_manager_base.h
- chrome/browser/printing/print_view_manager_unittest.cc
- chrome/browser/printing/printer_query.cc
- chrome/browser/printing/printer_query.h
- chrome/browser/printing/printing_message_filter.cc
- chrome/browser/printing/printing_message_filter.h
- chrome/browser/printing/test_printer_query.cc
- chrome/browser/printing/test_printer_query.h
- chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc
- chrome/browser/ui/webui/print_preview/local_printer_handler_default.cc
- chrome/browser/ui/webui/print_preview/print_preview_utils.cc
- chrome/browser/ui/webui/print_preview/print_preview_utils.h
- printing/print_settings_conversion.cc
- printing/print_settings_conversion.h
- printing/printing_context.cc
- printing/printing_context.h
-
Make Font Table construction resilient to lack of font pathname
Changed by Dominik Röttsches - drottohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 11:14:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7d2d2b1e2b26ec1585384bbcd3dae15495a69a9f Comments
Make Font Table construction resilient to lack of font pathname If we were unable to retrieve a path for a font registered in the system font collection, continue with the next font in the system font collection, instead of hitting the assertion. Speculative fix for such cases seen in the wild, unable to reproduce locally as it probably is hit for corrupt fonts or an invalid font registration in the registry. Bug: 922183 Change-Id: Ic071cee9a16ef0cb3a6fe095474348e437d65459 Reviewed-on: https://chromium-review.googlesource.com/c/1414852 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#623193}
Changed files
- content/browser/renderer_host/dwrite_font_proxy_impl_win.cc