Home | Search | chromium - Builders
Login

Builder Windows deterministic Build 10723 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisione676b7b4c45de16791c3148da4214c7e88a1a4bd
Got Revisione676b7b4c45de16791c3148da4214c7e88a1a4bd

Execution:

Steps and Logfiles:

Show:
  1. ( 401 ms ) setup_build
    running recipe: "swarming/deterministic_build"
  2. ( 11 mins 22 secs ) bot_update
    [116GB/299GB used (38%)]
  3. ( 368 ms ) clobber
  4. ( 36 secs ) gclient runhooks
  5. ( 561 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  6. ( 3 mins 37 secs ) generate_build_files
  7. ( 25 mins 15 secs ) First build
  8. ( 2 mins 3 secs ) First build confirm no-op
  9. ( 11 mins 7 secs ) isolate tests
  10. ( 521 ms ) clobber (2)
  11. ( 51 secs ) gclient runhooks (2)
  12. ( 957 ms ) lookup GN args (2)
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  13. ( 3 mins 35 secs ) generate_build_files (2)
  14. ( 16 mins 51 secs ) Second build
  15. ( 2 mins 12 secs ) Second build confirm no-op
  16. ( 10 mins 48 secs ) isolate tests (2)
  17. ( 29 mins 32 secs ) compare_build_artifacts
  18. ( 1 mins 36 secs ) create tarball
  19. ( 12 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2173-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542296733862094, "id": "8929778375951762080", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/e676b7b4c45de16791c3148da4214c7e88a1a4bd", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e676b7b4c45de16791c3148da4214c7e88a1a4bd", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095208437926805248", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Windows deterministic" setup_build
buildnumber 10723 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "swarming/deterministic_build" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "e676b7b4c45de16791c3148da4214c7e88a1a4bd" setup_build
got_angle_revision "f3acb8c133fa825d5f25159eaf4ebf303bfef7a6" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "69b44ee6a1269afb5c7622189de236af0c4ec2a7" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "e676b7b4c45de16791c3148da4214c7e88a1a4bd" bot_update
got_revision_cp "refs/heads/master@{#608376}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "14d4267208e7ee70b79186955b9b1b8c0273f3ca" bot_update
got_v8_revision_cp "refs/heads/7.2.341@{#1}" bot_update
got_webrtc_revision "a06bf8506fdfc0aff1098831bfc49bff4436399d" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25655}" bot_update
swarm_hashes {"accessibility_unittests": "b70160baa2d67096a7d395e7051076f51b2c61d6", "angle_end2end_tests": "5c34eb061834190ffda72c2540bcc8588a54cbd6", "angle_perftests": "e2afaa7b8dd5d4349676202586f1fa0a4d4c0a29", "angle_unittests": "4ac8ced3bc395dd43b2da9370297d51b1337997f", "angle_white_box_tests": "46b98d01505e0804388b09b67c5c4dbe34263449", "app_shell_unittests": "fc3eac1bceabcf799e816d0ee1015e31cd7d9ace", "aura_unittests": "09f02cc59b7fc82b240f94bd0f69ca255e59ed65", "base_perftests": "25e2157711e41d83b288f79c9e54db19e0ce30a1", "base_unittests": "0076d5045f4462c95a3e6836764176de14ff8b3a", "blink_common_unittests": "9b823a56089b366d3eae1d47264e6a952be94306", "blink_fuzzer_unittests": "0c85aceb0779cb65e3271ab505b0dbd44f88fc8c", "blink_heap_unittests": "0b3ce3e312ef692765cf2d62d0ad900126ce99ed", "blink_platform_unittests": "d115347decdabb3d8dbea981fb4d8ca07f10aa7d", "boringssl_crypto_tests": "20a32270ff0a6b33ba51d5402a475105087d79ff", "boringssl_ssl_tests": "5678527a746e62149def9abe4a749d6b0b03b378", "browser_tests": "47874ff7ada35c2335027536fc8749d20edcff8a", "cacheinvalidation_unittests": "726b23f20720a966a6cb9b936ab7125c8d670a78", "capture_unittests": "31aafa7b30154491a34d6a58d873a7e3bf6e7ac8", "cast_unittests": "7a8d3854b1e9b3a9936dd67b2f582400d98e68f9", "cc_unittests": "9d48a0e2aa99a1f4d868443fd0791ca4e9fc9ec6", "chrome_app_unittests": "32672d74c3991f429a857a484684368a36ad151b", "chrome_cleaner_unittests": "838090685efb9ff182c39e376cff5951711bd547", "chrome_elf_import_unittests": "2183290bd5832be1ab07c9ee437702d53bfec6e4", "chrome_elf_unittests": "f1f58bcdbb7c276c4e136dce1b1298325402aae5", "chromedriver_py_tests": "4f54909b05c57d2a2684534c28d1964b7aac7889", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "8d0dd2615051e277b6cf11f53e7c98bf1bd5153d", "command_buffer_perftests": "7cc7e81a5dfc8b9b5c9a783c172b611c7eb11c7a", "components_browsertests": "65da3a831b2c7e60fe6f49a33002459e1d3faa98", "components_perftests": "4400e7904389dcc94154f9700f7f24278bc05195", "components_unittests": "ac62af1e3c241bb9f1ce532b71c649aa0ed79fc2", "compositor_unittests": "7a033884d6f207f03889ec1f0dc723ea2331237f", "content_browsertests": "9507f1c48c88e9e0ba9ad65b327fe8c13bf438a6", "content_shell_crash_test": "ddad344bb43094cda7dc5d2de13cfb0ad19dd0a7", "content_unittests": "7d72446e485ab84ca7f660b498b4b7e2144665ce", "courgette_unittests": "4b7eeedf1dad4c2323ffa3cffe74ef246404c7cb", "crashpad_tests": "907b925d642e196a16ea7fe9b2624c5a646a905a", "cronet_tests": "f03f144afd6ac78c504f3bd2a53b18bdd2be0e9a", "cronet_unittests": "76ea0b47076da8ea274bd1f6961ce59f3c3745d7", "crypto_unittests": "dec3e6573d64bbe2be85be3bd9aa7056a3986ae8", "dawn_end2end_tests": "9f130e7c8ae77bcf200b5d55dc91e1a89a7bfff9", "device_unittests": "34f2d3db76251bcdde3381fd842507e4e74daa7f", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "d71adc8432d403ca15478e1fcf634d69eef37ee2", "elevation_service_unittests": "4c1b3e8c82e8f4d145676ec97887a398ec6ea7d6", "events_unittests": "48bf100ba8eb02c56530c1838c6d0da7d0d6c9b4", "extensions_browsertests": "de2fc709461f06306f3c5497270f8baa614925af", "extensions_unittests": "632ffb3720720609fb448774a9cc04790fff5ebe", "filesystem_service_unittests": "b43e1aa29dce574e766c063cf7cee3524d5eaf6b", "gcm_unit_tests": "070b9d545804ec11518f517a8aa362b43d434d08", "gcp_unittests": "1ac920b8fd3566e1eed651d91bac0f2c038e7e5b", "gfx_unittests": "55e86b97377de33c289a03f408df219c4f560640", "gin_unittests": "d3151924775b0b5fc811c63c13011a5e24154306", "gl_tests": "725735e3129adf82475620360669b025d8539e5e", "gl_unittests": "b57a33dfad9765b9acc135406110b15bee9236a5", "gl_unittests_ozone": "b57a33dfad9765b9acc135406110b15bee9236a5", "gles2_conform_test": "b6680d9ddeb2382e669f13d70a6ab744bcea40f7", "google_apis_unittests": "8946409e685ab9aaa3c518002ed0de7629ceed45", "gpu_perftests": "5b8a759ba08c6853f94118a086275e328bc613c7", "gpu_unittests": "cacd7a8959f60952f3c4e573cc17ee73340a4827", "headless_browsertests": "2f309ac5ffaacc726d9db7b139af2c7d698c37c3", "headless_unittests": "cb99bbdce70c8cc23f873fd53a7d9e944035210b", "install_static_unittests": "3b0c8982f247888ee6ff64ad246bd17ebb91b99b", "installer_util_unittests": "65061a12d0c03877d1abe276aa2d5b34217a5625", "interactive_ui_tests": "2153af0033a977eae479bf9c51f8732434f5aaec", "ipc_tests": "a89cf48868eac83b7b97f44aeb1e50a638e646dc", "jingle_unittests": "0dff26add043cae59c4603a80afeb6340ea6d074", "latency_unittests": "1984822e0c98adcf6a980ae05f3acf12174a093c", "leveldb_service_unittests": "54f10b6c13c361b34f420d8dfa3bf10135cd6255", "libjingle_xmpp_unittests": "31ba039c843f19076b3481fd451e995287915d39", "load_library_perf_tests": "569605fc961fbf6466370bff9f9a42d023cb127a", "media_blink_unittests": "c632d27eab4437bc1c9424d5a30478a6f2205500", "media_perftests": "f0795c0e869a2537d739813ed3aa2c0058417098", "media_service_unittests": "2d194daa9fc0e2adfa06dd7f0f188b1a63f70a70", "media_unittests": "c2d115548b5c15a503ebf6e9379377372a30281a", "message_center_unittests": "c5112f2d64f6d47e397d90462edb3f945aac81b4", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "c48541e97937f4ef262b23853ee3db5c1485a1a0", "mini_installer_tests": "d05d599da6c917f56a15128de194b06485d003ea", "mojo_core_unittests": "290a6577feafa82aafe3cf22a3c58db3233de233", "mojo_unittests": "a863341e0696843e485ae0a5991664fc91efa1f7", "nacl_loader_unittests": "59ab95d36f3ceb51cbd0130dc8f0d12b14685832", "native_theme_unittests": "2e54a7d05d5a27e495226f5371f9be2b217d651d", "net_perftests": "44a1d2efb322c12a98ca3781ce8d2daae9387468", "net_unittests": "c718f0546679d2b64306ea167db2eea029fcf97c", "notification_helper_unittests": "8340ece41c93dd44c8a15aac01f171aa6e9231ac", "pdf_unittests": "e2ec7638af1cd016f59fc029e8f18965ce35df99", "performance_browser_tests": "11c6dc0cd7e072e8ff1d5f42ac8366472ea30587", "performance_test_suite": "63c616ab42464bf880c887138899eec7f4bada96", "performance_webview_test_suite": "8296e943680e84f69b0a183da4e4aef949dc6285", "ppapi_unittests": "95c9502a6ce553162a1d03d869cab479d798c72c", "printing_unittests": "e882d68e0e7e70f6a507564414faefe6eca1d0d3", "remoting_unittests": "eb10b2d6915df0480b48f201586c4de2a29ae9c7", "sbox_integration_tests": "6ba57035f9895546714306d900af6f8ec47d53d5", "sbox_unittests": "2dd9ec56bb2357579f8e7cdc42cd9b62de0fe2a7", "sbox_validation_tests": "0d946a36364ee08ca43379a093ebe2966f9ff87f", "service_manager_unittests": "c85190788549cc3744274f6979b21ce3ee3986f6", "services_unittests": "ba264a83b4ea3067ecb5f005cffbfee14ccca564", "setup_unittests": "f4baa0de53437edca85e21e3f9c5e3947b3a1cb1", "shell_dialogs_unittests": "8ad1658d88be1aa952734ee406d23225eb7852b2", "skia_unittests": "0a85e73d3db32c9b5f0440224031d6791f32a011", "snapshot_unittests": "5dd22c2cd3d91617ad206cbb92a273826be4c0dd", "sql_unittests": "345b2bc20299504f62f00fc988d5ad5b76c55473", "storage_unittests": "317c385b17550ada6ceb4f08f238491ab3935943", "swiftshader_unittests": "36be6957ff830ff51e0d6a869caf7a3ee596e7d4", "sync_integration_tests": "edc5990497fa0e97bc4510d4f21dcf82ef1b06b1", "telemetry_gpu_integration_test": "188b3fe9d0cd1a9160497f3d4e142164dd108b76", "telemetry_gpu_unittests": "c36f9018d318f1525dd914161d8673e2f350547c", "telemetry_perf_tests_without_chrome": "9648ad817bfb03c3648af07b2f47773bee3cbcbf", "telemetry_perf_unittests": "b96837a295e5b9e8c77039a8982aecc88383e8ee", "telemetry_unittests": "b9af5161a5782bb07e841d64468fc1a67a33cb7b", "tracing_perftests": "637acec7197947118b944602d4d03a8672ff20c2", "traffic_annotation_auditor_unittests": "fbf2567494bc9606b9c5c767026d003c61d762bb", "ui_base_unittests": "fcaa4cc68b0f26a9269ae748fad72faac2196d6b", "ui_touch_selection_unittests": "41cad68fa5cc44ee0a37cd5eafc259d7f215e0e8", "unit_tests": "2781e5d897858efe76f60281c93f42e92259f2d0", "url_unittests": "ae55b84e69e1a324e110f9063a49366fbd92e7f6", "video_decode_accelerator_unittest": "c546e258b5df8cd01c447dba370be2b365cbdfae", "views_mus_interactive_ui_tests": "e4bd50d0852dac8bac80780e6c1a0615bc73c2ff", "views_mus_unittests": "298537df930162a59628bc4d92914965921a0442", "views_perftests": "34fe267a1fe9ea2ea4f6989b8759aa525dd12b73", "views_unittests": "e19503577c49e11bbcd26a673e5a9586b99f56bd", "viz_unittests": "d21bb7b3f5f9bb47feb2050ac37890a8bbbefaad", "vr_common_perftests": "73da2b1eef03d9049677cf6ef17993f0e0ac6093", "vr_common_unittests": "751aa13c0ffc948a5f308f2588fc78a03483ab58", "vr_pixeltests": "7266e15ae829340ed08a0c552006f4c9373ccd9d", "webkit_layout_tests": "ecd0851a98ac431190f4c26dcb125acb6a7200e5", "webkit_layout_tests_exparchive": "5da5025891c498264e80730448e10aa4bcb9a9e2", "webkit_python_tests": "9c3106e77399dba3dd333bfca32e0aab790dd7df", "webkit_unit_tests": "5ec14618edb886bf18c1025a40c6931d671774ff", "wm_unittests": "dca471345ff046f558257e372b0a6c907020d65d", "wtf_unittests": "85d69e2733b811ca21981a97549fc1579544f795", "zucchini_unittests": "3e12302962ebbb7924151e05e3b10a17f8021f04"} isolate tests
swarm_hashes {"accessibility_unittests": "b70160baa2d67096a7d395e7051076f51b2c61d6", "angle_end2end_tests": "5c34eb061834190ffda72c2540bcc8588a54cbd6", "angle_perftests": "e2afaa7b8dd5d4349676202586f1fa0a4d4c0a29", "angle_unittests": "4ac8ced3bc395dd43b2da9370297d51b1337997f", "angle_white_box_tests": "46b98d01505e0804388b09b67c5c4dbe34263449", "app_shell_unittests": "fc3eac1bceabcf799e816d0ee1015e31cd7d9ace", "aura_unittests": "09f02cc59b7fc82b240f94bd0f69ca255e59ed65", "base_perftests": "25e2157711e41d83b288f79c9e54db19e0ce30a1", "base_unittests": "0076d5045f4462c95a3e6836764176de14ff8b3a", "blink_common_unittests": "9b823a56089b366d3eae1d47264e6a952be94306", "blink_fuzzer_unittests": "0c85aceb0779cb65e3271ab505b0dbd44f88fc8c", "blink_heap_unittests": "0b3ce3e312ef692765cf2d62d0ad900126ce99ed", "blink_platform_unittests": "d115347decdabb3d8dbea981fb4d8ca07f10aa7d", "boringssl_crypto_tests": "20a32270ff0a6b33ba51d5402a475105087d79ff", "boringssl_ssl_tests": "5678527a746e62149def9abe4a749d6b0b03b378", "browser_tests": "47874ff7ada35c2335027536fc8749d20edcff8a", "cacheinvalidation_unittests": "726b23f20720a966a6cb9b936ab7125c8d670a78", "capture_unittests": "31aafa7b30154491a34d6a58d873a7e3bf6e7ac8", "cast_unittests": "7a8d3854b1e9b3a9936dd67b2f582400d98e68f9", "cc_unittests": "9d48a0e2aa99a1f4d868443fd0791ca4e9fc9ec6", "chrome_app_unittests": "32672d74c3991f429a857a484684368a36ad151b", "chrome_cleaner_unittests": "838090685efb9ff182c39e376cff5951711bd547", "chrome_elf_import_unittests": "2183290bd5832be1ab07c9ee437702d53bfec6e4", "chrome_elf_unittests": "f1f58bcdbb7c276c4e136dce1b1298325402aae5", "chromedriver_py_tests": "4f54909b05c57d2a2684534c28d1964b7aac7889", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "8d0dd2615051e277b6cf11f53e7c98bf1bd5153d", "command_buffer_perftests": "7cc7e81a5dfc8b9b5c9a783c172b611c7eb11c7a", "components_browsertests": "65da3a831b2c7e60fe6f49a33002459e1d3faa98", "components_perftests": "4400e7904389dcc94154f9700f7f24278bc05195", "components_unittests": "ac62af1e3c241bb9f1ce532b71c649aa0ed79fc2", "compositor_unittests": "7a033884d6f207f03889ec1f0dc723ea2331237f", "content_browsertests": "9507f1c48c88e9e0ba9ad65b327fe8c13bf438a6", "content_shell_crash_test": "ddad344bb43094cda7dc5d2de13cfb0ad19dd0a7", "content_unittests": "7d72446e485ab84ca7f660b498b4b7e2144665ce", "courgette_unittests": "4b7eeedf1dad4c2323ffa3cffe74ef246404c7cb", "crashpad_tests": "907b925d642e196a16ea7fe9b2624c5a646a905a", "cronet_tests": "f03f144afd6ac78c504f3bd2a53b18bdd2be0e9a", "cronet_unittests": "76ea0b47076da8ea274bd1f6961ce59f3c3745d7", "crypto_unittests": "dec3e6573d64bbe2be85be3bd9aa7056a3986ae8", "dawn_end2end_tests": "9f130e7c8ae77bcf200b5d55dc91e1a89a7bfff9", "device_unittests": "34f2d3db76251bcdde3381fd842507e4e74daa7f", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "d71adc8432d403ca15478e1fcf634d69eef37ee2", "elevation_service_unittests": "4c1b3e8c82e8f4d145676ec97887a398ec6ea7d6", "events_unittests": "48bf100ba8eb02c56530c1838c6d0da7d0d6c9b4", "extensions_browsertests": "de2fc709461f06306f3c5497270f8baa614925af", "extensions_unittests": "632ffb3720720609fb448774a9cc04790fff5ebe", "filesystem_service_unittests": "b43e1aa29dce574e766c063cf7cee3524d5eaf6b", "gcm_unit_tests": "070b9d545804ec11518f517a8aa362b43d434d08", "gcp_unittests": "1ac920b8fd3566e1eed651d91bac0f2c038e7e5b", "gfx_unittests": "55e86b97377de33c289a03f408df219c4f560640", "gin_unittests": "d3151924775b0b5fc811c63c13011a5e24154306", "gl_tests": "725735e3129adf82475620360669b025d8539e5e", "gl_unittests": "b57a33dfad9765b9acc135406110b15bee9236a5", "gl_unittests_ozone": "b57a33dfad9765b9acc135406110b15bee9236a5", "gles2_conform_test": "b6680d9ddeb2382e669f13d70a6ab744bcea40f7", "google_apis_unittests": "8946409e685ab9aaa3c518002ed0de7629ceed45", "gpu_perftests": "5b8a759ba08c6853f94118a086275e328bc613c7", "gpu_unittests": "cacd7a8959f60952f3c4e573cc17ee73340a4827", "headless_browsertests": "2f309ac5ffaacc726d9db7b139af2c7d698c37c3", "headless_unittests": "cb99bbdce70c8cc23f873fd53a7d9e944035210b", "install_static_unittests": "3b0c8982f247888ee6ff64ad246bd17ebb91b99b", "installer_util_unittests": "65061a12d0c03877d1abe276aa2d5b34217a5625", "interactive_ui_tests": "2153af0033a977eae479bf9c51f8732434f5aaec", "ipc_tests": "a89cf48868eac83b7b97f44aeb1e50a638e646dc", "jingle_unittests": "0dff26add043cae59c4603a80afeb6340ea6d074", "latency_unittests": "1984822e0c98adcf6a980ae05f3acf12174a093c", "leveldb_service_unittests": "54f10b6c13c361b34f420d8dfa3bf10135cd6255", "libjingle_xmpp_unittests": "31ba039c843f19076b3481fd451e995287915d39", "load_library_perf_tests": "569605fc961fbf6466370bff9f9a42d023cb127a", "media_blink_unittests": "c632d27eab4437bc1c9424d5a30478a6f2205500", "media_perftests": "f0795c0e869a2537d739813ed3aa2c0058417098", "media_service_unittests": "2d194daa9fc0e2adfa06dd7f0f188b1a63f70a70", "media_unittests": "c2d115548b5c15a503ebf6e9379377372a30281a", "message_center_unittests": "c5112f2d64f6d47e397d90462edb3f945aac81b4", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "c48541e97937f4ef262b23853ee3db5c1485a1a0", "mini_installer_tests": "d25276fae4a07ccbc10961b58a7b75e1f9a0b51b", "mojo_core_unittests": "290a6577feafa82aafe3cf22a3c58db3233de233", "mojo_unittests": "a863341e0696843e485ae0a5991664fc91efa1f7", "nacl_loader_unittests": "59ab95d36f3ceb51cbd0130dc8f0d12b14685832", "native_theme_unittests": "2e54a7d05d5a27e495226f5371f9be2b217d651d", "net_perftests": "44a1d2efb322c12a98ca3781ce8d2daae9387468", "net_unittests": "c718f0546679d2b64306ea167db2eea029fcf97c", "notification_helper_unittests": "8340ece41c93dd44c8a15aac01f171aa6e9231ac", "pdf_unittests": "e2ec7638af1cd016f59fc029e8f18965ce35df99", "performance_browser_tests": "11c6dc0cd7e072e8ff1d5f42ac8366472ea30587", "performance_test_suite": "63c616ab42464bf880c887138899eec7f4bada96", "performance_webview_test_suite": "8296e943680e84f69b0a183da4e4aef949dc6285", "ppapi_unittests": "95c9502a6ce553162a1d03d869cab479d798c72c", "printing_unittests": "e882d68e0e7e70f6a507564414faefe6eca1d0d3", "remoting_unittests": "eb10b2d6915df0480b48f201586c4de2a29ae9c7", "sbox_integration_tests": "6ba57035f9895546714306d900af6f8ec47d53d5", "sbox_unittests": "2dd9ec56bb2357579f8e7cdc42cd9b62de0fe2a7", "sbox_validation_tests": "0d946a36364ee08ca43379a093ebe2966f9ff87f", "service_manager_unittests": "c85190788549cc3744274f6979b21ce3ee3986f6", "services_unittests": "ba264a83b4ea3067ecb5f005cffbfee14ccca564", "setup_unittests": "f4baa0de53437edca85e21e3f9c5e3947b3a1cb1", "shell_dialogs_unittests": "8ad1658d88be1aa952734ee406d23225eb7852b2", "skia_unittests": "0a85e73d3db32c9b5f0440224031d6791f32a011", "snapshot_unittests": "5dd22c2cd3d91617ad206cbb92a273826be4c0dd", "sql_unittests": "345b2bc20299504f62f00fc988d5ad5b76c55473", "storage_unittests": "317c385b17550ada6ceb4f08f238491ab3935943", "swiftshader_unittests": "36be6957ff830ff51e0d6a869caf7a3ee596e7d4", "sync_integration_tests": "edc5990497fa0e97bc4510d4f21dcf82ef1b06b1", "telemetry_gpu_integration_test": "188b3fe9d0cd1a9160497f3d4e142164dd108b76", "telemetry_gpu_unittests": "c36f9018d318f1525dd914161d8673e2f350547c", "telemetry_perf_tests_without_chrome": "9648ad817bfb03c3648af07b2f47773bee3cbcbf", "telemetry_perf_unittests": "b96837a295e5b9e8c77039a8982aecc88383e8ee", "telemetry_unittests": "b9af5161a5782bb07e841d64468fc1a67a33cb7b", "tracing_perftests": "637acec7197947118b944602d4d03a8672ff20c2", "traffic_annotation_auditor_unittests": "fbf2567494bc9606b9c5c767026d003c61d762bb", "ui_base_unittests": "fcaa4cc68b0f26a9269ae748fad72faac2196d6b", "ui_touch_selection_unittests": "41cad68fa5cc44ee0a37cd5eafc259d7f215e0e8", "unit_tests": "2781e5d897858efe76f60281c93f42e92259f2d0", "url_unittests": "ae55b84e69e1a324e110f9063a49366fbd92e7f6", "video_decode_accelerator_unittest": "c546e258b5df8cd01c447dba370be2b365cbdfae", "views_mus_interactive_ui_tests": "e4bd50d0852dac8bac80780e6c1a0615bc73c2ff", "views_mus_unittests": "298537df930162a59628bc4d92914965921a0442", "views_perftests": "34fe267a1fe9ea2ea4f6989b8759aa525dd12b73", "views_unittests": "e19503577c49e11bbcd26a673e5a9586b99f56bd", "viz_unittests": "d21bb7b3f5f9bb47feb2050ac37890a8bbbefaad", "vr_common_perftests": "73da2b1eef03d9049677cf6ef17993f0e0ac6093", "vr_common_unittests": "751aa13c0ffc948a5f308f2588fc78a03483ab58", "vr_pixeltests": "7266e15ae829340ed08a0c552006f4c9373ccd9d", "webkit_layout_tests": "ecd0851a98ac431190f4c26dcb125acb6a7200e5", "webkit_layout_tests_exparchive": "5da5025891c498264e80730448e10aa4bcb9a9e2", "webkit_python_tests": "9c3106e77399dba3dd333bfca32e0aab790dd7df", "webkit_unit_tests": "5ec14618edb886bf18c1025a40c6931d671774ff", "wm_unittests": "dca471345ff046f558257e372b0a6c907020d65d", "wtf_unittests": "85d69e2733b811ca21981a97549fc1579544f795", "zucchini_unittests": "3e12302962ebbb7924151e05e3b10a17f8021f04"} isolate tests (2)

Blamelist:

  1. David Jean (djeanohnoyoudont@google.com)
  2. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  3. Tim Volodine (timvolodineohnoyoudont@google.com)
  4. Vladislav Kaznacheev (kaznacheevohnoyoudont@google.com)
  5. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  6. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  7. manuk (manukhohnoyoudont@chromium.org)
  8. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. Daniel Bratell (bratellohnoyoudont@opera.com)
  10. Stepan Khapugin (stkhapuginohnoyoudont@chromium.org)
  11. Yves Gerey (yvesgohnoyoudont@google.com)
  12. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  13. Clemens Arbesser (arbesserohnoyoudont@google.com)
  14. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  15. David 'Digit' Turner (digitohnoyoudont@google.com)
  16. edchin (edchinohnoyoudont@chromium.org)
  17. Koji Ishii (kojiiohnoyoudont@chromium.org)
  18. Erik Chen (erikchenohnoyoudont@chromium.org)
  19. arthursonzogni (arthursonzogniohnoyoudont@chromium.org)
  20. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  21. Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
  22. David Jean (djeanohnoyoudont@google.com)
  23. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  24. Marc Treib (treibohnoyoudont@chromium.org)
  25. Alexandre Frechette (frechetteohnoyoudont@chromium.org)
  26. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  27. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  28. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  29. Vadym Doroshenko (dvadymohnoyoudont@chromium.org)
  30. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  31. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  32. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  33. arthursonzogni (arthursonzogniohnoyoudont@chromium.org)

Timing:

Create Thursday, 15-Nov-18 15:45:33 UTC
Start Thursday, 15-Nov-18 15:45:36 UTC
End Thursday, 15-Nov-18 18:23:32 UTC
Pending 2 secs
Execution 2 hrs 37 mins

All Changes:

  1. [ios] use view controller base class for manual fill passwords

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 15:37:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e676b7b4c45de16791c3148da4214c7e88a1a4bd

    Comments

    [ios] use view controller base class for manual fill passwords
    
    Bug: 845472
    Change-Id: I012839e8ee5dee6ae54d66327f1de5f38ff96d71
    Reviewed-on: https://chromium-review.googlesource.com/c/1335599
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608376}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
  2. Roll src/third_party/webrtc 95140715009f..a06bf8506fdf (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 15:36:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e409d21b7a1ed490c90681d64db8e34cf1126017

    Comments

    Roll src/third_party/webrtc 95140715009f..a06bf8506fdf (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/95140715009f..a06bf8506fdf
    
    
    git log 95140715009f..a06bf8506fdf --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 tzik@chromium.org Add a presubmit check for absl/memory/memory.h inclusion
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@a06bf8506fdf
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:752720
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Iac7aba638ab8133c587b282f40892e534293ad38
    Reviewed-on: https://chromium-review.googlesource.com/c/1337481
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608375}

    Changed files

    • DEPS
  3. [Web Speech API] Make it possible to enable speech-to-text separately from text-to-speech.

    Changed by Tim Volodine - timvolodineohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 15:34:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adfe3021565f243fe59911475cce301bf71bfefa

    Comments

    [Web Speech API] Make it possible to enable speech-to-text separately from text-to-speech.
    
    Web Speech API [1] consists of two parts:
    1. speech recognition (speech-to-text, STT)
    2. speech synthesis (text-to-speech, TTS)
    
    Currently Web Speech API can be either enabled or disabled completely,
    by means of "disable-speech-api" command line flag. However we want to
    be able to enable STT and TTS functionality separately. This has to do
    with some security/privacy concerns regarding speech synthesis.
    
    In particular we want to enable STT functionality in Android WebView,
    but not TTS (at least until all concerns are addressed).
    
    In this patch the ScriptedSpeech runtime blink flag is split into two:
    ScriptedSpeechRecognition and ScriptedSpeechSynthesis. An additional
    "disable-speech-synthesis-api" command line flag is added to control
    how much of the Web Speech API we want to expose.
    
    [1] https://w3c.github.io/speech-api/
    
    BUG=487255
    
    Change-Id: I959b73600bb8e7a0542661bfb997ceae1aa144ed
    Reviewed-on: https://chromium-review.googlesource.com/c/1329150
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608374}

    Changed files

    • content/child/runtime_features.cc
    • content/public/common/content_switches.cc
    • content/public/common/content_switches.h
    • third_party/blink/public/platform/web_runtime_features.h
    • third_party/blink/renderer/modules/speech/speech_synthesis_error_event.idl
    • third_party/blink/renderer/modules/speech/speech_synthesis_event.idl
    • third_party/blink/renderer/modules/speech/speech_synthesis_utterance.idl
    • third_party/blink/renderer/modules/speech/window_speech.idl
    • third_party/blink/renderer/modules/speech/window_speech_synthesis.idl
    • third_party/blink/renderer/platform/exported/web_runtime_features.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  4. Bring back full range of icon sizes for Files app

    Changed by Vladislav Kaznacheev - kaznacheevohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 15:30:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9dca2f22e8863e5f8ec15ca228531f29cec5d5c

    Comments

    Bring back full range of icon sizes for Files app
    
    Return to using icon sizes from before crrev.com/c/1243680.
    This should exclude a possibility of any regressions.
    Updating the icon look to the latest UI design.
    
    Bug: 893548
    Test: steps in bug
    Change-Id: I596750416a5c87f0239119086b4db84554f3d3a0
    Reviewed-on: https://chromium-review.googlesource.com/c/1336188
    Reviewed-by: Naoki Fukino <fukino@chromium.org>
    Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608373}

    Changed files

    • ui/file_manager/audio_player/icons/audio-player-256.png
    • ui/file_manager/audio_player/icons/audio-player-32.png
    • ui/file_manager/audio_player/icons/audio-player-64.png
    • ui/file_manager/audio_player/icons/audio-player-96.png
    • ui/file_manager/audio_player/manifest.json
    • ui/file_manager/file_manager/common/images/icon256.png
    • ui/file_manager/file_manager/common/images/icon32.png
    • ui/file_manager/file_manager/common/images/icon64.png
    • ui/file_manager/file_manager/manifest.json
    • ui/file_manager/file_manager_resources.grd
    • ui/file_manager/gallery/images/icon256.png
    • ui/file_manager/gallery/images/icon32.png
    • ui/file_manager/gallery/images/icon64.png
    • ui/file_manager/gallery/images/icon96.png
    • ui/file_manager/gallery/manifest.json
    • ui/file_manager/video_player/images/icon/video-player-256.png
    • ui/file_manager/video_player/images/icon/video-player-32.png
    • ui/file_manager/video_player/images/icon/video-player-64.png
    • ui/file_manager/video_player/images/icon/video-player-96.png
    • ui/file_manager/video_player/manifest.json
  5. Import wpt@02dccc6b5ad45352ae5c3bdf23fcbd9b0deea071

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 15:26:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29bfc14f877f2cb18672f7b7504770ed7fe1364e

    Comments

    Import wpt@02dccc6b5ad45352ae5c3bdf23fcbd9b0deea071
    
    Using wpt-import in Chromium 73b488158ac6d9426c8e0ff2f8f65e8026608705.
    With Chromium commits locally applied on WPT:
    f482e77e59 "Add report-only mode to Feature Policy"
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
      external/wpt/infrastructure
    jsbell@chromium.org:
      external/wpt/IndexedDB
      external/wpt/resources
    nzolghadr@chromium.org, mustaq@chromium.org:
      external/wpt/pointerevents
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I4111c4acfe912b4ad363acce5b6216afd1b03ec6
    Reviewed-on: https://chromium-review.googlesource.com/c/1337633
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608372}

    Changed files

    • third_party/WebKit/LayoutTests/NeverFixTests
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_advance_index2.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_advance_index3.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_advance_index5.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_continue_index5.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_continue_index6.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_continue_invalid.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating_index.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating_index2.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating_objectstore.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating_objectstore2.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_update_objectstore4.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbdatabase_createObjectStore10-1000ends.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbdatabase_createObjectStore7.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbdatabase_deleteObjectStore4-not_reused.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbdatabase_transaction4.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbfactory_deleteDatabase3.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbfactory_open10.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbfactory_open11.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbfactory_open12.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex-multientry-arraykeypath.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex-multientry-big.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex-multientry.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex_indexNames.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex3-usable-right-away.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex4-deleteIndex-event_order.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex5-emptykeypath.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex6-event_order.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex7-event_order.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex8-valid_keys.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_deleted.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbtransaction-oncomplete.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbtransaction_abort.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbversionchangeevent.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/keygenerator-constrainterror.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/keygenerator-overflow.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/keyorder.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/keypath_maxsize.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/request_bubble-and-capture.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/transaction-lifetime-blocked.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/transaction-lifetime.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/transaction-requestqueue.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/transaction_bubble-and-capture.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/writer-starvation.htm
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/elementPosition.html.ini
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/eventOrder.html.ini
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/geometry.idl
    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove-manual.html
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js
  6. [DevTools] Speculative fix for ResetViewport crash

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:25:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d45720ead927ee7a2761c0a4cd1e76338c676c03

    Comments

    [DevTools] Speculative fix for ResetViewport crash
    
    It seems that we can have no layer tree view, but a
    visual_viewport_container_layer_, because we
    set them up and wind down separately. Adding null-check
    to fight the crash.
    
    Note there is no stable repro for this crash, so it
    might be something else.
    
    Bug: 902413
    Change-Id: I33dc8419f33ab11d8a49d0be543ac0c8119f9d19
    Reviewed-on: https://chromium-review.googlesource.com/c/1334887
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608371}

    Changed files

    • third_party/blink/renderer/core/exported/web_view_impl.cc
  7. [chrome:omnibox] Add buttons to copy response data.

    Changed by manuk - manukhohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:22:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d557ace8644a84f3e217b13562c91d1bf20945d3

    Comments

    [chrome:omnibox] Add buttons to copy response data.
    
    Two copy buttons are added. The first copies the visible table as text; display options, which affect the visibility of tables, columns, rows, also affect what text is copied. The second copies the responses as JSON.
    
    Also, as this CL introduces a second outputs interface, I took this opportunity to consolidate this new interface and the previous OutputController (which served as an interface for OmniboxOutput) into a single interface, OmniboxController, which will be responsible for interfacing to individual Output classes responsible for:
    1 render tables from responses
    2 control visibility based on display options
    3 control visibility and coloring based on search text
    4 export/copy output
    5 preserve inputs and reset default inputs
    6 export/import inputs
    
    Bug: 891303
    Change-Id: I1b6e10e6aa2213912235863f61163c9d8e9f66f7
    Reviewed-on: https://chromium-review.googlesource.com/c/1329842
    Commit-Queue: manuk hovanesian <manukh@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608370}

    Changed files

    • chrome/browser/resources/omnibox/BUILD.gn
    • chrome/browser/resources/omnibox/omnibox.html
    • chrome/browser/resources/omnibox/omnibox.js
    • chrome/browser/resources/omnibox/omnibox_inputs.js
    • chrome/browser/resources/omnibox/omnibox_output.js
    • third_party/closure_compiler/externs/pending.js
  8. Roll src/third_party/perfetto b93264e2b16b..c17c1dc0e795 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 15:20:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5104e13a609d57e6ede716c8f11611ad95315854

    Comments

    Roll src/third_party/perfetto b93264e2b16b..c17c1dc0e795 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/b93264e2b16b..c17c1dc0e795
    
    
    git log b93264e2b16b..c17c1dc0e795 --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 fmayer@google.com profiling: Include PIDs in heap dumps.
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@c17c1dc0e795
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I283fb20d9a326b05c00ef13d485487d823db184b
    Reviewed-on: https://chromium-review.googlesource.com/c/1337479
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608369}

    Changed files

    • DEPS
  9. Restore the nonull warning in chrome/browser/ui for everything but mac

    Changed by Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at Thursday, 15-Nov-18 15:11:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9c78579915f5035e97adb0000f2fa82bc6cb0e20

    Comments

    Restore the nonull warning in chrome/browser/ui for everything but mac
    
    -Wno-null has been disabled for clang in chrome/browser/ui since 2015
    but it seems to be enough to disable that warning for mac (the only
    platform that used clang by default in 2015).
    
    Bug: 383820
    Change-Id: Iadc03f761c120db91fb806369ecf6f3bd8459c1c
    Reviewed-on: https://chromium-review.googlesource.com/c/982057
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608368}

    Changed files

    • chrome/browser/ui/BUILD.gn
  10. Add owners for ntp_tile_views

    Changed by Stepan Khapugin - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:02:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 35385741e820020edddd9f116878779ca93f71a0

    Comments

    Add owners for ntp_tile_views
    
    Adds gambard@ as OWNER of ntp_tile_views.
    Gambard is the original author of ntp tiles before they were moved to
    this folder.
    
    Change-Id: Ie93a894cc685e4a0d5783e417ed714ae29901b14
    Reviewed-on: https://chromium-review.googlesource.com/c/1337505
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608367}

    Changed files

    • ios/chrome/browser/ui/ntp_tile_views/OWNERS
  11. Revert "Disable all WebRtcBrowserTests on ASan"

    Changed by Yves Gerey - yvesgohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 14:56:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8700ed14ef6030b990233f03b729c1b60f81bc43

    Comments

    Revert "Disable all WebRtcBrowserTests on ASan"
    
    This reverts commit 6d582d186fc5763adc328767d84a39d1b0e98376.
    
    Reason for revert: The leaks are not caused by WebRTC code,
                       but merely revealed by the tests.
    We re-enable those tests: either the leaks have been fixed, or we'll add
    a suppression (less drastic than muting the whole WebRTC test suite).
    
    Original change's description:
    >Disable all WebRtcBrowserTests on ASan
    >
    >Many of these tests flakily leak and thus fail on ASan bots.
    >
    >TBR=phoglund@chromium.org
    >
    >Bug: 898546
    >Change-Id: Icd3cc5dc3a46d0194c807c27b66f7eb902b35794
    >Reviewed-on: https://chromium-review.googlesource.com/c/1299161
    >Reviewed-by: Marc Treib <treib@chromium.org>
    >Commit-Queue: Marc Treib <treib@chromium.org>
    >Cr-Commit-Position: refs/heads/master@{#602745}
    
    Bug: chromium:898546
    Change-Id: Idccff7827e6381e20060f7116cac75ee2b25018f
    Reviewed-on: https://chromium-review.googlesource.com/c/1337626
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Yves Gerey <yvesg@google.com>
    Cr-Commit-Position: refs/heads/master@{#608366}

    Changed files

    • chrome/browser/media/webrtc/webrtc_browsertest.cc
  12. [css-properties-values-api] Validate var() fallbacks.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:56:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 67e449b925663f3b91e0f588da99178bf696fbdf

    Comments

    [css-properties-values-api] Validate var() fallbacks.
    
    According to a recent spec edit, any fallback in a var()-reference must
    match the syntax of the referenced property, otherwise the var()-reference
    is invalid. This applies even if the fallback is not used.
    
    To implement this, ResolveFallback now returns kNone/kFail/kSuccess instead
    of a bool. This is necessary, because the kNone case may be both an error
    state and a success state, depending on whether the fallback is being
    used or not, hence a plain bool is not sufficient.
    
    R=futhark@chromium.org
    
    Bug: 641877
    Change-Id: I951eef6335bf1cd4064d59959d73ec4fa39c9ee0
    Reviewed-on: https://chromium-review.googlesource.com/c/1335576
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608365}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/var-reference-registered-properties.html
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver.cc
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver.h
  13. [Autofill Assistant] Removed the link to the chrome settings from the expanded payment request.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 14:45:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 911038cc9bd6438ab2406664c5f00c6a77c90437

    Comments

    [Autofill Assistant] Removed the link to the chrome settings from the expanded payment request.
    
    It takes up space and is redundant, since the user can access more specific settings pages by tapping the edit/add buttons next to the payment methods and contact details.
    
    Bug: 806868
    Change-Id: I0ac076930dc605102931bfe2c7d958aa4ad36c3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1337503
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#608364}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
  14. [iOS] Fix SteadyView highlighted state shape

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:39:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33d9de49a9a8bf7105b7dc2bffb70c701355e6c1

    Comments

    [iOS] Fix SteadyView highlighted state shape
    
    This CL changes the state of the highlighted state of the location bar,
    to have it shaped like a pill, as the non-highlighted state.
    
    Bug: 905630
    Change-Id: Ieeb5180d514b928c158ed2cd4f5b39cfde2b7aec
    Reviewed-on: https://chromium-review.googlesource.com/c/1337500
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608363}

    Changed files

    • ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
  15. base/trace_event: Make TRACE_EVENTXX call sites smaller.

    Changed by David 'Digit' Turner - digitohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 14:37:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc57a1780b06d0444fde693de8c733f8247ece83

    Comments

    base/trace_event: Make TRACE_EVENTXX call sites smaller.
    
    Replaces two function calls by one at each trace macro call
    site. This should save about 12 kiB in 32-bit ARM libmonochrome.so
    
    BUG=898794
    R=primiano@chromium.org,oysteine@chromium.org,alexiln@chromium.org
    
    Change-Id: Icf64644355b584dd5ff9910920df02930344f837
    Reviewed-on: https://chromium-review.googlesource.com/c/1301913
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: oysteine <oysteine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608362}

    Changed files

    • base/trace_event/trace_event.h
    • base/trace_event/trace_log.cc
    • base/trace_event/trace_log.h
  16. [ios] Remove ExternalSearchProvider

    Changed by edchin - edchinohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:37:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2677c981faa69fd1b590fc6592ac1357f567aa81

    Comments

    [ios] Remove ExternalSearchProvider
    
    External Search was added for an app that no longer exists. This
    feature has never been enabled. This CL cleans up dead code.
    
    Bug: 904616
    Change-Id: Id7df06097ac2c5a598e7bc2f0f91657481de4a9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1332689
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608361}

    Changed files

    • ios/chrome/browser/BUILD.gn
    • ios/chrome/browser/about_flags.mm
    • ios/chrome/browser/ios_chrome_flag_descriptions.cc
    • ios/chrome/browser/ios_chrome_flag_descriptions.h
    • ios/chrome/browser/providers/BUILD.gn
    • ios/chrome/browser/providers/chromium_browser_provider.h
    • ios/chrome/browser/providers/chromium_browser_provider.mm
    • ios/chrome/browser/ui/BUILD.gn
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/commands/BUILD.gn
    • ios/chrome/browser/ui/commands/browser_commands.h
    • ios/chrome/browser/ui/commands/external_search_commands.h
    • ios/chrome/browser/ui/external_search/BUILD.gn
    • ios/chrome/browser/ui/external_search/external_search_coordinator.h
    • ios/chrome/browser/ui/external_search/external_search_coordinator.mm
    • ios/chrome/browser/ui/external_search/external_search_coordinator_unittest.mm
    • ios/chrome/browser/ui/external_search/external_search_mediator.h
    • ios/chrome/browser/ui/external_search/external_search_mediator.mm
    • ios/chrome/browser/ui/external_search/external_search_mediator_unittest.mm
    • ios/chrome/browser/ui/external_search/features.cc
    • ios/chrome/browser/ui/external_search/features.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/BUILD.gn
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.mm
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views_utils.mm
    • ios/chrome/test/BUILD.gn
    • ios/public/provider/chrome/browser/BUILD.gn
    • ios/public/provider/chrome/browser/chrome_browser_provider.h
    • ios/public/provider/chrome/browser/chrome_browser_provider.mm
    • ios/public/provider/chrome/browser/external_search/BUILD.gn
    • ios/public/provider/chrome/browser/external_search/external_search_provider.h
    • ios/public/provider/chrome/browser/external_search/external_search_provider.mm
    • ios/public/provider/chrome/browser/external_search/test_external_search_provider.h
    • ios/public/provider/chrome/browser/external_search/test_external_search_provider.mm
    • ios/public/provider/chrome/browser/test_chrome_browser_provider.h
    • ios/public/provider/chrome/browser/test_chrome_browser_provider.mm
  17. [LayoutNG] Enable fragment caching when BFC block offset changes

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:32:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41c1ee8a95439ceb6018ca296858ed417bd5c500

    Comments

    [LayoutNG] Enable fragment caching when BFC block offset changes
    
    This patch enables fragment caching when BFC block offset
    changes, as long as 1) either the cached or new doesn't have
    floats, and 2) the cached fragment doesn't propagate OOF
    objects. The latter may not be needed, but helps to simplify.
    
    Minor but mostly positive improvements are seen in pinpoint:
    blink_perf.layout https://pinpoint-dot-chromeperf.appspot.com/job/13a7a7f7e40000
    loading.desktop https://pinpoint-dot-chromeperf.appspot.com/job/17a7a7f7e40000
    
    2 block fragmentation tests fail with this change that this
    change is not enabled for block fragmentation for now.
    * virtual/layout_ng_experimental/fast/multicol/balance-breakafter-before-nested-block.html
    * virtual/layout_ng_experimental/fast/multicol/dynamic/spanner-becomes-regular-block.html
    
    Bug: 635619
    Change-Id: I46826b45defd556c8dadbf861fb1bbf61c5ae658
    Reviewed-on: https://chromium-review.googlesource.com/c/1335072
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608360}

    Changed files

    • third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc
    • third_party/blink/renderer/core/layout/ng/ng_constraint_space.cc
    • third_party/blink/renderer/core/layout/ng/ng_constraint_space.h
    • third_party/blink/renderer/core/layout/ng/ng_layout_result.cc
    • third_party/blink/renderer/core/layout/ng/ng_layout_result.h
  18. macOS: Use system Xcode on 10.14.

    Changed by Erik Chen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:31:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2619f3b0f4807321f18065a469c2c371b006bb4

    Comments

    macOS: Use system Xcode on 10.14.
    
    A previous CL: https://chromium-review.googlesource.com/c/1333877 commented out
    an assert to allow default fallback to the local toolchain, but failed to update
    the subsequent conditional correctly.
    
    Bug: 904400
    Change-Id: I8d299e60645db4821dbb79c45b57ac1c01767d57
    Reviewed-on: https://chromium-review.googlesource.com/c/1335949
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608359}

    Changed files

    • build_overrides/build.gni
  19. Disable one flaky PaymentRequestPaymentAppTest

    Changed by arthursonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:30:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bf868aa6237a473dfb1910112805f5cc3f671d4

    Comments

    Disable one flaky PaymentRequestPaymentAppTest
    
    Flaky test:
    org.chromium.chrome.browser.payments.PaymentRequestPaymentAppTest#testPayViaDelayedSlowBobPay
    
    TBR=rouslan@chromium.org
    
    Bug: 769851
    Change-Id: Ic9ea6a0ddd72055145fb2e738744f0d60a13df40
    Reviewed-on: https://chromium-review.googlesource.com/c/1337502
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608358}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java
  20. Roll src-internal 659370e71be5..a59368241b0c (5 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 14:30:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ddfdf4618cb6d1f8d4272264c0c49bcfd982fbe3

    Comments

    Roll src-internal 659370e71be5..a59368241b0c (5 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/659370e71be5..a59368241b0c
    
    
    Created with:
      gclient setdep -r src-internal@a59368241b0c
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ic65cb6a4973f5266810dc2531c95883dc46f90c4
    Reviewed-on: https://chromium-review.googlesource.com/c/1337478
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608357}

    Changed files

    • DEPS
  21. [SPv2] Rebaseline tests with benign differences

    Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:23:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4dc85491581a807e02d524643b6bb310f3ee4f42

    Comments

    [SPv2] Rebaseline tests with benign differences
    
    Change-Id: I60a46974819d536c0f178cb2ee23ee50951982f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1337135
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608356}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-clip-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-clip-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-effect-interleave-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-z-order-interleave-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-z-order-interleave-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/css3/blending/mix-blend-mode-isolated-group-1-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/css3/blending/mix-blend-mode-isolated-group-2-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/css3/blending/mix-blend-mode-isolated-group-3-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-with-mask-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-video-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/fast/forms/textarea/basic-textareas-expected.png
  22. [ios] Plug in obj-c credit card object in manual fill.

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 14:19:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 73c81f2435b5005fbac81ab3b34d74e43e63a4a0

    Comments

    [ios] Plug in obj-c credit card object in manual fill.
    
    Also added use of cell utils in manual_fill_card_cell.
    
    Bug: 845472
    Change-Id: Ie015a2335c3cfe37f34620e2efb1447b8429d3c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1335550
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608355}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_mediator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card_form.mm
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card_form_unittest.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
  23. Roll src/third_party/webrtc a859d41366c6..95140715009f (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 14:16:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eaf11202cdea2d9609c8256a434428411713e450

    Comments

    Roll src/third_party/webrtc a859d41366c6..95140715009f (5 commits)
    
    https://webrtc.googlesource.com/src.git/+log/a859d41366c6..95140715009f
    
    
    git log a859d41366c6..95140715009f --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 magjed@webrtc.org Android: Support externally aligned timestamps
    2018-11-15 srte@webrtc.org Adds OWNERS to rtc_base/experiments.
    2018-11-15 jonasolsson@webrtc.org Add android bindings for PeerConnectionState.
    2018-11-15 jonasolsson@webrtc.org Add ios bindings for PeerConnectionState.
    2018-11-15 nisse@webrtc.org Make member internal::SynchronousMethodCall::e_ a non-pointer.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@95140715009f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I8686709667989fa57176c8bee3410bd35c2eb12b
    Reviewed-on: https://chromium-review.googlesource.com/c/1337476
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608354}

    Changed files

    • DEPS
  24. Migrate ProfileSyncService unit tests to SyncUserSettings

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:10:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ab642dc09d5aba8fc83c10522a38a32be820c01

    Comments

    Migrate ProfileSyncService unit tests to SyncUserSettings
    
    SyncUserSettings is a new class that encapsulates all the
    user-configurable knobs for Sync. It replaces a bunch of setters
    and getters directly on the SyncService.
    
    Bug: 884159
    Change-Id: I31374ece7bf1d6c8b72f8c894e1d9b9a5660d18f
    Reviewed-on: https://chromium-review.googlesource.com/c/1337495
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608353}

    Changed files

    • components/browser_sync/profile_sync_service_startup_unittest.cc
    • components/browser_sync/profile_sync_service_unittest.cc
  25. [Translate Manual Trigger] Manual translation implementation that waits for source language.

    Changed by Alexandre Frechette - frechetteohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:05:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 923926a4097c9ca3e72641c28ea4ba5d5760baeb

    Comments

    [Translate Manual Trigger] Manual translation implementation that waits for source language.
    
    The translate UI should not appear before the necessary information (i.e. source language) has been computed.
    This changes manual translations to block before the state is correct.
    
    Bug: 902803
    Change-Id: I0d0549b5093774ae5b60dd0e18fd72fe7349f895
    Reviewed-on: https://chromium-review.googlesource.com/c/1331688
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: anthonyvd <anthonyvd@chromium.org>
    Commit-Queue: Alexandre Frechette <frechette@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608352}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/translate/TranslateBridge.java
    • chrome/browser/translate/android/translate_bridge.cc
    • chrome/browser/translate/chrome_translate_client.cc
    • chrome/browser/translate/chrome_translate_client.h
    • chrome/browser/translate/translate_fake_page.cc
    • chrome/browser/translate/translate_fake_page.h
    • chrome/browser/translate/translate_manager_render_view_host_android_unittest.cc
    • chrome/browser/translate/translate_manager_render_view_host_unittest.cc
    • chrome/test/BUILD.gn
  26. Update V8 to version 7.2.341.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 13:56:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 19f0ea3baf3270d62a0e48fab3e1837d90a0059b

    Comments

    Update V8 to version 7.2.341.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/de5944d2..14d42672
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I05b8d2401aece2afec0e95ba327672da68363812
    Reviewed-on: https://chromium-review.googlesource.com/c/1337632
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608351}

    Changed files

    • DEPS
  27. Rename WebRTC Linux builder.

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 13:53:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0779bc1ada5022dc0c98712e8a41505d62920dcf

    Comments

    Rename WebRTC Linux builder.
    
    Missed mb_config.pyl in my previous CL.
    
    Bug: 877018
    Change-Id: I897caf43b76190a8e59e07e99436f5b5e48f1b07
    Tbr: jbudorick@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1337342
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608350}

    Changed files

    • tools/mb/mb_config.pyl
  28. blink: use php7 for web tests on 10.14

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 13:48:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 194ae154045ac6e880fae4ad14b3b4ca9f82e395

    Comments

    blink: use php7 for web tests on 10.14
    
    php5 is unsupported, same as 10.13.
    
    Bug: 892187
    Change-Id: I52bc19b4f6ea8408093b7fcc61f6fe5153c984fd
    Reviewed-on: https://chromium-review.googlesource.com/c/1335947
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608349}

    Changed files

    • third_party/blink/tools/blinkpy/web_tests/port/mac.py
  29. Teach NewPasswordFormManager gracefully process multiple submissions.

    Changed by Vadym Doroshenko - dvadymohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 13:41:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f5f1f8f06239d7504da2d086daf3102d39c1041

    Comments

    Teach NewPasswordFormManager gracefully process multiple submissions.
    
    Password form submission detection is based on heuristics. So it's ok,
    when submission is found multiple times for the same form. The function
    SetSubmittedFormIfIsManaged is called when a submission is detected.
    It might be that in call SetSubmittedFormIfIsManaged, the submitted form
    is invalid (eg. JavaScript removed all fields), but a previous call
    the submitted form was valid. Then NewPasswordFormManager should not
    override valid submitted form. This CL implements this.
    
    Bug: 905579, 831123
    Change-Id: I5762ac98f951e941a462504aaf62ac9f60203b3e
    Reviewed-on: https://chromium-review.googlesource.com/c/1337616
    Reviewed-by: Vaclav Brozek <vabr@chromium.org>
    Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608348}

    Changed files

    • components/password_manager/core/browser/new_password_form_manager.cc
    • components/password_manager/core/browser/new_password_form_manager_unittest.cc
  30. Roll src/third_party/dawn/ 597e1587b..69b44ee6a (4 commits)

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 13:38:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 54249105664df48b9b1a2e43e241cc2475f1a3e7

    Comments

    Roll src/third_party/dawn/ 597e1587b..69b44ee6a (4 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/597e1587b4bf..69b44ee6a126
    
    $ git log 597e1587b..69b44ee6a --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 cwallez BUILD.gn: Fix libdawn_native missing dep on its own headers
    2018-11-14 cwallez Don't use shared libraries in the wire fuzzer.
    2018-11-14 rharrison Set correct ASAN flags for SPIRV-cross fuzzers
    2018-11-13 dneto README.md: Need pkg-config on Linux
    
    Created with:
      roll-dep src/third_party/dawn
    
    TBR=kainino@chromium.org
    
    Change-Id: I1cc0bd6efbca778f792004d9372eb78f9dae56fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1337620
    Reviewed-by: Corentin Wallez <cwallez@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608347}

    Changed files

    • DEPS
  31. [Autofill Assistant] Payment Request UI tweaks.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 13:28:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5719d0c75f6daa22478801d772378ecf021178b

    Comments

    [Autofill Assistant] Payment Request UI tweaks.
    
     - Update the status message with the PR prompt.
     - The progress bar should pulse when the PR is shown.
    
    R=arbesser@google.com
    
    Bug: 806868
    Change-Id: I00e8ec07cc19c06bd13f49116955f0e09e422dd9
    Reviewed-on: https://chromium-review.googlesource.com/c/1337494
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608346}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
  32. Roll src-internal c52201b23b48..659370e71be5 (6 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 13:23:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3099a2178a2e8784d0185cc9c6510a9767de2a25

    Comments

    Roll src-internal c52201b23b48..659370e71be5 (6 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c52201b23b48..659370e71be5
    
    
    Created with:
      gclient setdep -r src-internal@659370e71be5
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I11f746791624b8dc36f4ec198d3e452b7719b951
    Reviewed-on: https://chromium-review.googlesource.com/c/1337475
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608345}

    Changed files

    • DEPS
  33. Disable mojo unittest flaky on Android.

    Changed by arthursonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 13:22:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fbce494fd382ce850b8ce19b76e3c82a56e2edb9

    Comments

    Disable mojo unittest flaky on Android.
    
    Disabled test:
    MultiprocessMessagePipeTestWithPeerSupport.ChannelPipesWithMultipleChildren
    
    TBR=rockot@chromium.org
    
    Bug: 905620
    Change-Id: I228040b5c07a420beae202da43887c0db17d0e27
    Reviewed-on: https://chromium-review.googlesource.com/c/1337619
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608344}

    Changed files

    • mojo/core/multiprocess_message_pipe_unittest.cc