Builder Windows deterministic Build 10720

Overview

Results:

Success

Trigger Info:

Project	chromium
Revision	4f5cf795f34dfa683d6e8429c9ed1bdb85020920
Got Revision	4f5cf795f34dfa683d6e8429c9ed1bdb85020920

Execution:

Source: Task 412f5efae67c7810
Bot: swarm2173-c4

Steps and Logfiles:

Show: Expanded Default Non-Green

( 351 ms ) setup_build
running recipe: "swarming/deterministic_build"
- stdout
- run_recipe
( 529 ms ) init cache if not exists
- stdout
( 7 mins ) bot_update
[116GB/299GB used (38%)]
- stdout
- json.output
( 26 secs ) rmtree C:\b\swarming\w\ir\cache\builder\src\out\Release.1
- stdout
( 25 secs ) rmtree C:\b\swarming\w\ir\cache\builder\src\out\Release.2
- stdout
( 361 ms ) ensure_goma
- - no logs -
1. ( 361 ms ) ensure_installed
  - stdout
  - json.output
( 414 ms ) clobber
- stdout
( 32 secs ) gclient runhooks
- stdout
( 530 ms ) lookup GN args

is_component_build = false
is_debug = false
strip_absolute_paths_from_debug_symbols = true
symbol_level = 1
target_cpu = "x86"
use_goma = true
goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
- stdout
( 3 mins 3 secs ) generate_build_files
- stdout
( 40 secs ) generate .isolate files
- stdout
( 21 secs ) preprocess_for_goma
- - no logs -
1. ( 484 ms ) goma cache directory
  - stdout
2. ( 19 secs ) start_goma
  - stdout
  - cloudtail
3. ( 1 secs ) start cloudtail
  - stdout
( 16 mins 39 secs ) First build
- stdout
( 1 mins 37 secs ) First build confirm no-op
- stdout
( 45 secs ) postprocess_for_goma
- - no logs -
1. ( 3 secs ) goma_jsonstatus
  - stdout
  - json.output
2. ( 622 ms ) goma_stat
  - stdout
3. ( 734 ms ) stop_goma
  - stdout
4. ( 30 secs ) upload_log
5. ( 11 secs ) stop cloudtail
  - stdout
( 693 ms ) find isolated targets
- stdout
- glob
( 7 mins ) isolate webkit_layout_tests_exparchive
- stdout
- json.output
( 10 mins 1 secs ) isolate tests
- stdout
- json.output
( 1 secs ) Move C:\b\swarming\w\ir\cache\builder\src\out\Release to C:\b\swarming\w\ir\cache\builder\src\out\Release.1
- stdout
- python.inline
( 539 ms ) clobber (2)
- stdout
( 44 secs ) gclient runhooks (2)
- stdout
( 578 ms ) lookup GN args (2)

is_component_build = false
is_debug = false
strip_absolute_paths_from_debug_symbols = true
symbol_level = 1
target_cpu = "x86"
use_goma = true
goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
- stdout
( 3 mins 14 secs ) generate_build_files (2)
- stdout
( 41 secs ) generate .isolate files (2)
- stdout
( 20 secs ) preprocess_for_goma (2)
- - no logs -
1. ( 561 ms ) preprocess_for_goma.goma cache directory (2)
  - stdout
2. ( 17 secs ) preprocess_for_goma.start_goma (2)
  - stdout
  - cloudtail
3. ( 1 secs ) preprocess_for_goma.start cloudtail (2)
  - stdout
( 16 mins 49 secs ) Second build
- stdout
( 1 mins 27 secs ) Second build confirm no-op
- stdout
( 38 secs ) postprocess_for_goma (2)
- - no logs -
1. ( 3 secs ) postprocess_for_goma.goma_jsonstatus (2)
  - stdout
  - json.output
2. ( 652 ms ) postprocess_for_goma.goma_stat (2)
  - stdout
3. ( 783 ms ) postprocess_for_goma.stop_goma (2)
  - stdout
4. ( 22 secs ) postprocess_for_goma.upload_log (2)
5. ( 10 secs ) postprocess_for_goma.stop cloudtail (2)
  - stdout
( 679 ms ) find isolated targets (2)
- stdout
- glob
( 6 mins 38 secs ) isolate webkit_layout_tests_exparchive (2)
- stdout
- json.output
( 10 mins 24 secs ) isolate tests (2)
- stdout
- json.output
( 1 secs ) Move C:\b\swarming\w\ir\cache\builder\src\out\Release to C:\b\swarming\w\ir\cache\builder\src\out\Release.2
- stdout
- python.inline
( 23 mins 51 secs ) compare_build_artifacts
- stdout
- json.output
( 1 mins 36 secs ) create tarball
- stdout
( 12 secs ) gsutil upload
- stdout
- gsutil.upload
( 988 ms ) rmtree C:\b\swarming\w\ir\tmp\rt\deterministic_build1_mxr2
- stdout
( 0 ) recipe result
- result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2173-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542271626375152, "id": "8929804703060207184", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/4f5cf795f34dfa683d6e8429c9ed1bdb85020920", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/4f5cf795f34dfa683d6e8429c9ed1bdb85020920", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095234765577258592", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Windows deterministic"	setup_build
buildnumber	10720	setup_build
mastername	"chromium.win"	setup_build
path_config	"generic"	setup_build
recipe	"swarming/deterministic_build"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"4f5cf795f34dfa683d6e8429c9ed1bdb85020920"	setup_build
got_angle_revision	"f3acb8c133fa825d5f25159eaf4ebf303bfef7a6"	bot_update
got_buildtools_revision	"13a00f110ef910a25763346d6538b60f12845656"	bot_update
got_dawn_revision	"597e1587b4bfc7bf89895c7c879ae58b649da3c5"	bot_update
got_nacl_revision	"99673869a3cd8731d924bd32fa486feebfdc6c4f"	bot_update
got_revision	"4f5cf795f34dfa683d6e8429c9ed1bdb85020920"	bot_update
got_revision_cp	"refs/heads/master@{#608295}"	bot_update
got_swarming_client_revision	"f78187ab77127de42555afe0ad410bebde6ac6a5"	bot_update
got_v8_revision	"b0e3bc7d7fd4655b488fd916eea1a3601ab3bede"	bot_update
got_v8_revision_cp	"refs/heads/7.2.338@{#1}"	bot_update
got_webrtc_revision	"c25d2344574830a3f73a934ba5b4662e0475cbbb"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#25646}"	bot_update
swarm_hashes	{"accessibility_unittests": "7ff39c499537eac06e9d5ab7d10714eb60e4a5dc", "angle_end2end_tests": "f3bcdb5a20b58b71ac2a3c3791c67fe9e76e48da", "angle_perftests": "64b8c1872d5cfb96e8e59e84fcab18bb2af57129", "angle_unittests": "f41324fa827080426b478251bc2f52b3e252e062", "angle_white_box_tests": "d8f1ea9291dfeb693cf2ed3e32c982b2fbac21ea", "app_shell_unittests": "28f21fe7d89b9b5b61bb48c0cbee6a98e548d7e5", "aura_unittests": "2d996de4ee90f634793485bc146629bd7b3a54ce", "base_perftests": "1f05a5b2461a1d74ac7029226e48cdab7a4a99b5", "base_unittests": "bb14583f90979083001ae2a8b9e47a7197405757", "blink_common_unittests": "c57c1bce8ab916f94db65b7e94264cad2c96d285", "blink_fuzzer_unittests": "e038df0456eaf6a2ca6b7da11272c203457d65aa", "blink_heap_unittests": "be8596bc6209b9b0941fd4f887add9a3fcaab66f", "blink_platform_unittests": "d5aaa12ac50525b5fc5d65d8cb99a6b369b989d9", "boringssl_crypto_tests": "76568ed33c9123a9d0b0d4ae9c441f07f8fb2cd2", "boringssl_ssl_tests": "cafec2eb9800f75e771de18114b83c471660d15a", "browser_tests": "62b67e4cf0e50b7994df46208ab69cc492515029", "cacheinvalidation_unittests": "bea555180229f1c98c6db46d26d6642fb03121e8", "capture_unittests": "5dfa97f007243e64b028cbd4aeb49b61d8601fda", "cast_unittests": "49046b779ce4e0cdf0dc8223c3a02597f1a9320d", "cc_unittests": "f1206bb1c8a88320147016a43a8c1b20ba53423b", "chrome_app_unittests": "7b814e15593e1c3ae59f3f9341703a663f28fd7e", "chrome_cleaner_unittests": "9c8a639ed8aa7af25fbc1548eeead92e3da15224", "chrome_elf_import_unittests": "78a6e736f67aed378a27e5159b9b3f9f32591fed", "chrome_elf_unittests": "543e04385e40342a464db184fe255136b8566acb", "chromedriver_py_tests": "a503375daac421d333eed8d1b920257a77cc48c3", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "6fd58b2bc2ab14054d730956aa829208f85f421a", "command_buffer_perftests": "a6841c654c95e0b776474ae7efba63440b891427", "components_browsertests": "5a8d91859878c58a170852109657889368d8231e", "components_perftests": "cbe38a079544988aeddc0a9c8f64483a7c1816ef", "components_unittests": "95fe4d86be5443b80468ca618ae9e342e446bef3", "compositor_unittests": "65b6943514e6390cff397cb206476439da3b85b5", "content_browsertests": "28bf970a2a6134c407346b103d669d369636aa5d", "content_shell_crash_test": "ce5866c8e8542fd13e63d281daad092bb35e05ec", "content_unittests": "8cc5f6c103f5993b674560b5e6f26f2652b3f725", "courgette_unittests": "c9ce17b272a7418961b987cc4efe180f0990ea23", "crashpad_tests": "7340dc066971b9ebf934062dd979fa4b27059f50", "cronet_tests": "a55ebe7251a4ad3ddfd6a4392b908b2e0b6ba8e2", "cronet_unittests": "9fa2b5a72a20feef720c241575bf80d4278d7e39", "crypto_unittests": "c3e6ecaa4ebc7a3e7be93b24379e640dc3525508", "dawn_end2end_tests": "1620e478feece7dcd63410d20598c76b8440b9aa", "device_unittests": "d2264f552b89926a8a3f5fe9439ffe54bae815c5", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "93b22824e1194d1c9e760262cb2769fbf3d09927", "elevation_service_unittests": "65dce63031f9f300bc2aa269cc25df313cbe95ae", "events_unittests": "f5cc46de76981d33ec9ae149be0c82af8801531d", "extensions_browsertests": "f28b12ff0dc24c3ae6d67f43a7c2468f03fe6a18", "extensions_unittests": "a23ee8218b9fb238727a702f88b7aa839557ec5c", "filesystem_service_unittests": "13675059b0f08a38605b4a0310f6906b74d86f62", "gcm_unit_tests": "49a024f32ada3145a0e6739602f27afca783d748", "gcp_unittests": "82b160128e48743eadadca8db3f9be65d73ba3b5", "gfx_unittests": "6d635e1c592243eba4128f246a99508915990960", "gin_unittests": "17d027837585172649638138e7c4e310450c93fb", "gl_tests": "68e1a93d5cd62f0440f875f5fee89728fe6b7188", "gl_unittests": "44d18bc602a7f5445756c57fc111cd18ea1d7326", "gl_unittests_ozone": "44d18bc602a7f5445756c57fc111cd18ea1d7326", "gles2_conform_test": "758eec3345b066be9b08de223ea649eedbedc666", "google_apis_unittests": "6b85d966e5291a25d13285dcfc9bf10b9637500b", "gpu_perftests": "cbb20a3491f077c5ebc66f01540f83f5a29fa320", "gpu_unittests": "f274c274c363779fb6b6c80857c0c4bf03027cd0", "headless_browsertests": "29bcfa0d4394a5d2e5acf459e778f2241e52c80f", "headless_unittests": "970af55293b1841715b4adc59d501439f79ba18a", "install_static_unittests": "28b4f32aa51d7a5d33908789d26f6a7180110b68", "installer_util_unittests": "c0af35caa898f84d4b92a07f3f2a2dfdf075f494", "interactive_ui_tests": "a8c163242fe48c797b6a512e35328db69cc52293", "ipc_tests": "f16773a5566ff8bfc4b00e20cfa2d0a97771f89c", "jingle_unittests": "bf7fcede6bcbdd63fe75a2ff86db74b4ed1897e9", "latency_unittests": "3ba6b4e78bbac02e7d56b0cb2a274e3a16b04fff", "leveldb_service_unittests": "e5490491ff70e2ee92360bc3295d48e97d7adc39", "libjingle_xmpp_unittests": "c0b23fe1cdf35f46e4df385935f87eff74f8f425", "load_library_perf_tests": "83c8c7248fdf97f0cd8dbaf7cfdba9353b3b3d42", "media_blink_unittests": "92fb0c2eb0f81afe1f90e923831d0b44fece5a13", "media_perftests": "adfbbb88531af1344f6782756f639f2d5a9c8fa4", "media_service_unittests": "5d7dea83151c5e740c0d5c7df9f9abe318a68484", "media_unittests": "1636421d5809494c71548cf41bc5fd666fc0d8cd", "message_center_unittests": "74129541fdf5236d8a0042ffe20647e321df3b06", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "0a9db1b8c9747d09b614ad380b5b0f9c7d89995d", "mini_installer_tests": "6d2695535f4e88da05b2e69b51c4444b79755b22", "mojo_core_unittests": "1602f5f157954fdf4cff147d70535bc77ed58913", "mojo_unittests": "1a1fe7fa4f9ab181fe457f5efdd8558cc7d9019e", "nacl_loader_unittests": "b72e76fe43ceb395e92b3ac2bc78908f889a5670", "native_theme_unittests": "119126785cfd0f6560ee724afd51c61cf5b82d59", "net_perftests": "b6d9c0b34fe8a3786bcb6da928cf7aa196ccb989", "net_unittests": "069a22cfd0b2cd251e755e5475de806cc4f8f777", "notification_helper_unittests": "16789375a2363dafa82494a52e7bc518fcd0275c", "pdf_unittests": "4039702eb710b1258714edde5ec73b7409904a65", "performance_browser_tests": "c46e65f5e3f8bf230f4f3617e2cfe38fdd6ca921", "performance_test_suite": "c00fed60a2a188032ebae23031c72583d9f8dbd7", "performance_webview_test_suite": "4e3df62058e294f20f9ca5d24c2023f6a6b14686", "ppapi_unittests": "e46a92e5a1005d7388286b57156b5060ca81e486", "printing_unittests": "f1cd962519fbb8d1a24b67925ff09abd264174c4", "remoting_unittests": "5272c37d99bec7414386b09547e62050dfe3159d", "sbox_integration_tests": "e4f1ce9cd4c7c1f7deb720aef425f2f4a808a6e8", "sbox_unittests": "9daf082365ff34c0aacd486c989a69a5889a8129", "sbox_validation_tests": "dc3fbf610be7de3ae0d35f33ce98811cb1aecbad", "service_manager_unittests": "ac96fcb97a19466eb1f3716a80f89249dbf8e628", "services_unittests": "5ca48bf32c2b39a38f92ed0757c10e81aec44275", "setup_unittests": "820b898e65ae1299979b426fad83c0bf0f1be20d", "shell_dialogs_unittests": "1402e4df01a2a77b0d4266f2dff2f58b3daae333", "skia_unittests": "029c6398f10ba14f1554fbd00b12d8741fa8916a", "snapshot_unittests": "e6fb2a1ec17906907c9e0a624aa455b8999a5cdd", "sql_unittests": "2646698ab94d873f6a2b567e91fb919e8119f639", "storage_unittests": "580374523c71eb5698bc7378be0a4b02739ccdfc", "swiftshader_unittests": "093d7fa044ee7fc11baf167a361cdc7fa5e5d0ca", "sync_integration_tests": "d750442f61e768e488bacbd140935516e86a35dd", "telemetry_gpu_integration_test": "b0fb985749272ffbf275e83a2e2afe7c3b347638", "telemetry_gpu_unittests": "c36f9018d318f1525dd914161d8673e2f350547c", "telemetry_perf_tests_without_chrome": "5650b4a46179fe13747342548b6feb102eff74f2", "telemetry_perf_unittests": "5d76206e58656cbd064f3992146ad3c72d58563e", "telemetry_unittests": "7c492bf7f8ec62cf8e99af1672448cc63553ce81", "tracing_perftests": "63d6ccd1cbe5595664253f77810ba0e6fd53375f", "traffic_annotation_auditor_unittests": "655f206df1dce06d491b3ff8b7dadaeb0ce7122b", "ui_base_unittests": "527f79f622332e1870c59b67fc8b8dfa7b986f1f", "ui_touch_selection_unittests": "a2232b6bad2297dc054602c05e9abe44cbb95493", "unit_tests": "06a026f2d1485e62df0406d30f6b803fbdae2bb1", "url_unittests": "971ae7aa663cfc5f6c63753a11c27f3accd5a78a", "video_decode_accelerator_unittest": "1a9ecbd3c3784eefeda0330c02c4b43a821dc3a0", "views_mus_interactive_ui_tests": "61a31309af3051fa36340b36267b2218ad2efbdd", "views_mus_unittests": "8f243db11a3a9d367d4b11d96fa745a495bca281", "views_perftests": "fcf87175925f2ad00c3f3f0e7ea14bbc904dd1d4", "views_unittests": "e2bb32b86d96832baafefb51ddfad77284c8443f", "viz_unittests": "8b931ab40655b0f490fc03a2a213bad57c8cac8d", "vr_common_perftests": "0217aec7f2e25b47fbcd2d9c19f31d2b05420562", "vr_common_unittests": "47c32fac77f2477598999a02f3a02fad3cab0581", "vr_pixeltests": "58b648045361a353c7ea6efb174f50d8473c4f5e", "webkit_layout_tests": "fea7c15820fca68117cd7a5849337052f504cb1b", "webkit_layout_tests_exparchive": "ec3096aeadc6f0b0767fdcfd56bf0bb482812a23", "webkit_python_tests": "ae37fa979716d2f661be3cb058168af26a2f1d9e", "webkit_unit_tests": "0409a81bae917f2dead6d6b848010e41455e896b", "wm_unittests": "79cc04ea58166f8b8316effe7e95ba4438a034ca", "wtf_unittests": "3cee23b944740adb407dea6aeac94eae55cb15ce", "zucchini_unittests": "9cc855c002caac073bce36bb504df45594346507"}	isolate tests
swarm_hashes	{"accessibility_unittests": "7ff39c499537eac06e9d5ab7d10714eb60e4a5dc", "angle_end2end_tests": "f3bcdb5a20b58b71ac2a3c3791c67fe9e76e48da", "angle_perftests": "64b8c1872d5cfb96e8e59e84fcab18bb2af57129", "angle_unittests": "f41324fa827080426b478251bc2f52b3e252e062", "angle_white_box_tests": "d8f1ea9291dfeb693cf2ed3e32c982b2fbac21ea", "app_shell_unittests": "28f21fe7d89b9b5b61bb48c0cbee6a98e548d7e5", "aura_unittests": "2d996de4ee90f634793485bc146629bd7b3a54ce", "base_perftests": "1f05a5b2461a1d74ac7029226e48cdab7a4a99b5", "base_unittests": "bb14583f90979083001ae2a8b9e47a7197405757", "blink_common_unittests": "c57c1bce8ab916f94db65b7e94264cad2c96d285", "blink_fuzzer_unittests": "e038df0456eaf6a2ca6b7da11272c203457d65aa", "blink_heap_unittests": "be8596bc6209b9b0941fd4f887add9a3fcaab66f", "blink_platform_unittests": "d5aaa12ac50525b5fc5d65d8cb99a6b369b989d9", "boringssl_crypto_tests": "76568ed33c9123a9d0b0d4ae9c441f07f8fb2cd2", "boringssl_ssl_tests": "cafec2eb9800f75e771de18114b83c471660d15a", "browser_tests": "62b67e4cf0e50b7994df46208ab69cc492515029", "cacheinvalidation_unittests": "bea555180229f1c98c6db46d26d6642fb03121e8", "capture_unittests": "5dfa97f007243e64b028cbd4aeb49b61d8601fda", "cast_unittests": "49046b779ce4e0cdf0dc8223c3a02597f1a9320d", "cc_unittests": "f1206bb1c8a88320147016a43a8c1b20ba53423b", "chrome_app_unittests": "7b814e15593e1c3ae59f3f9341703a663f28fd7e", "chrome_cleaner_unittests": "9c8a639ed8aa7af25fbc1548eeead92e3da15224", "chrome_elf_import_unittests": "78a6e736f67aed378a27e5159b9b3f9f32591fed", "chrome_elf_unittests": "543e04385e40342a464db184fe255136b8566acb", "chromedriver_py_tests": "a503375daac421d333eed8d1b920257a77cc48c3", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "6fd58b2bc2ab14054d730956aa829208f85f421a", "command_buffer_perftests": "a6841c654c95e0b776474ae7efba63440b891427", "components_browsertests": "5a8d91859878c58a170852109657889368d8231e", "components_perftests": "cbe38a079544988aeddc0a9c8f64483a7c1816ef", "components_unittests": "95fe4d86be5443b80468ca618ae9e342e446bef3", "compositor_unittests": "65b6943514e6390cff397cb206476439da3b85b5", "content_browsertests": "28bf970a2a6134c407346b103d669d369636aa5d", "content_shell_crash_test": "ce5866c8e8542fd13e63d281daad092bb35e05ec", "content_unittests": "8cc5f6c103f5993b674560b5e6f26f2652b3f725", "courgette_unittests": "c9ce17b272a7418961b987cc4efe180f0990ea23", "crashpad_tests": "7340dc066971b9ebf934062dd979fa4b27059f50", "cronet_tests": "a55ebe7251a4ad3ddfd6a4392b908b2e0b6ba8e2", "cronet_unittests": "9fa2b5a72a20feef720c241575bf80d4278d7e39", "crypto_unittests": "c3e6ecaa4ebc7a3e7be93b24379e640dc3525508", "dawn_end2end_tests": "1620e478feece7dcd63410d20598c76b8440b9aa", "device_unittests": "d2264f552b89926a8a3f5fe9439ffe54bae815c5", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "93b22824e1194d1c9e760262cb2769fbf3d09927", "elevation_service_unittests": "65dce63031f9f300bc2aa269cc25df313cbe95ae", "events_unittests": "f5cc46de76981d33ec9ae149be0c82af8801531d", "extensions_browsertests": "f28b12ff0dc24c3ae6d67f43a7c2468f03fe6a18", "extensions_unittests": "a23ee8218b9fb238727a702f88b7aa839557ec5c", "filesystem_service_unittests": "13675059b0f08a38605b4a0310f6906b74d86f62", "gcm_unit_tests": "49a024f32ada3145a0e6739602f27afca783d748", "gcp_unittests": "82b160128e48743eadadca8db3f9be65d73ba3b5", "gfx_unittests": "6d635e1c592243eba4128f246a99508915990960", "gin_unittests": "17d027837585172649638138e7c4e310450c93fb", "gl_tests": "68e1a93d5cd62f0440f875f5fee89728fe6b7188", "gl_unittests": "44d18bc602a7f5445756c57fc111cd18ea1d7326", "gl_unittests_ozone": "44d18bc602a7f5445756c57fc111cd18ea1d7326", "gles2_conform_test": "758eec3345b066be9b08de223ea649eedbedc666", "google_apis_unittests": "6b85d966e5291a25d13285dcfc9bf10b9637500b", "gpu_perftests": "cbb20a3491f077c5ebc66f01540f83f5a29fa320", "gpu_unittests": "f274c274c363779fb6b6c80857c0c4bf03027cd0", "headless_browsertests": "29bcfa0d4394a5d2e5acf459e778f2241e52c80f", "headless_unittests": "970af55293b1841715b4adc59d501439f79ba18a", "install_static_unittests": "28b4f32aa51d7a5d33908789d26f6a7180110b68", "installer_util_unittests": "c0af35caa898f84d4b92a07f3f2a2dfdf075f494", "interactive_ui_tests": "a8c163242fe48c797b6a512e35328db69cc52293", "ipc_tests": "f16773a5566ff8bfc4b00e20cfa2d0a97771f89c", "jingle_unittests": "bf7fcede6bcbdd63fe75a2ff86db74b4ed1897e9", "latency_unittests": "3ba6b4e78bbac02e7d56b0cb2a274e3a16b04fff", "leveldb_service_unittests": "e5490491ff70e2ee92360bc3295d48e97d7adc39", "libjingle_xmpp_unittests": "c0b23fe1cdf35f46e4df385935f87eff74f8f425", "load_library_perf_tests": "83c8c7248fdf97f0cd8dbaf7cfdba9353b3b3d42", "media_blink_unittests": "92fb0c2eb0f81afe1f90e923831d0b44fece5a13", "media_perftests": "adfbbb88531af1344f6782756f639f2d5a9c8fa4", "media_service_unittests": "5d7dea83151c5e740c0d5c7df9f9abe318a68484", "media_unittests": "1636421d5809494c71548cf41bc5fd666fc0d8cd", "message_center_unittests": "74129541fdf5236d8a0042ffe20647e321df3b06", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "0a9db1b8c9747d09b614ad380b5b0f9c7d89995d", "mini_installer_tests": "6f85f3b0404ffb356f9177cd14a271e85ef91a23", "mojo_core_unittests": "1602f5f157954fdf4cff147d70535bc77ed58913", "mojo_unittests": "1a1fe7fa4f9ab181fe457f5efdd8558cc7d9019e", "nacl_loader_unittests": "b72e76fe43ceb395e92b3ac2bc78908f889a5670", "native_theme_unittests": "119126785cfd0f6560ee724afd51c61cf5b82d59", "net_perftests": "b6d9c0b34fe8a3786bcb6da928cf7aa196ccb989", "net_unittests": "069a22cfd0b2cd251e755e5475de806cc4f8f777", "notification_helper_unittests": "16789375a2363dafa82494a52e7bc518fcd0275c", "pdf_unittests": "4039702eb710b1258714edde5ec73b7409904a65", "performance_browser_tests": "c46e65f5e3f8bf230f4f3617e2cfe38fdd6ca921", "performance_test_suite": "c00fed60a2a188032ebae23031c72583d9f8dbd7", "performance_webview_test_suite": "4e3df62058e294f20f9ca5d24c2023f6a6b14686", "ppapi_unittests": "e46a92e5a1005d7388286b57156b5060ca81e486", "printing_unittests": "f1cd962519fbb8d1a24b67925ff09abd264174c4", "remoting_unittests": "5272c37d99bec7414386b09547e62050dfe3159d", "sbox_integration_tests": "e4f1ce9cd4c7c1f7deb720aef425f2f4a808a6e8", "sbox_unittests": "9daf082365ff34c0aacd486c989a69a5889a8129", "sbox_validation_tests": "dc3fbf610be7de3ae0d35f33ce98811cb1aecbad", "service_manager_unittests": "ac96fcb97a19466eb1f3716a80f89249dbf8e628", "services_unittests": "5ca48bf32c2b39a38f92ed0757c10e81aec44275", "setup_unittests": "820b898e65ae1299979b426fad83c0bf0f1be20d", "shell_dialogs_unittests": "1402e4df01a2a77b0d4266f2dff2f58b3daae333", "skia_unittests": "029c6398f10ba14f1554fbd00b12d8741fa8916a", "snapshot_unittests": "e6fb2a1ec17906907c9e0a624aa455b8999a5cdd", "sql_unittests": "2646698ab94d873f6a2b567e91fb919e8119f639", "storage_unittests": "580374523c71eb5698bc7378be0a4b02739ccdfc", "swiftshader_unittests": "093d7fa044ee7fc11baf167a361cdc7fa5e5d0ca", "sync_integration_tests": "d750442f61e768e488bacbd140935516e86a35dd", "telemetry_gpu_integration_test": "b0fb985749272ffbf275e83a2e2afe7c3b347638", "telemetry_gpu_unittests": "c36f9018d318f1525dd914161d8673e2f350547c", "telemetry_perf_tests_without_chrome": "5650b4a46179fe13747342548b6feb102eff74f2", "telemetry_perf_unittests": "5d76206e58656cbd064f3992146ad3c72d58563e", "telemetry_unittests": "7c492bf7f8ec62cf8e99af1672448cc63553ce81", "tracing_perftests": "63d6ccd1cbe5595664253f77810ba0e6fd53375f", "traffic_annotation_auditor_unittests": "655f206df1dce06d491b3ff8b7dadaeb0ce7122b", "ui_base_unittests": "527f79f622332e1870c59b67fc8b8dfa7b986f1f", "ui_touch_selection_unittests": "a2232b6bad2297dc054602c05e9abe44cbb95493", "unit_tests": "06a026f2d1485e62df0406d30f6b803fbdae2bb1", "url_unittests": "971ae7aa663cfc5f6c63753a11c27f3accd5a78a", "video_decode_accelerator_unittest": "1a9ecbd3c3784eefeda0330c02c4b43a821dc3a0", "views_mus_interactive_ui_tests": "61a31309af3051fa36340b36267b2218ad2efbdd", "views_mus_unittests": "8f243db11a3a9d367d4b11d96fa745a495bca281", "views_perftests": "fcf87175925f2ad00c3f3f0e7ea14bbc904dd1d4", "views_unittests": "e2bb32b86d96832baafefb51ddfad77284c8443f", "viz_unittests": "8b931ab40655b0f490fc03a2a213bad57c8cac8d", "vr_common_perftests": "0217aec7f2e25b47fbcd2d9c19f31d2b05420562", "vr_common_unittests": "47c32fac77f2477598999a02f3a02fad3cab0581", "vr_pixeltests": "58b648045361a353c7ea6efb174f50d8473c4f5e", "webkit_layout_tests": "fea7c15820fca68117cd7a5849337052f504cb1b", "webkit_layout_tests_exparchive": "ec3096aeadc6f0b0767fdcfd56bf0bb482812a23", "webkit_python_tests": "ae37fa979716d2f661be3cb058168af26a2f1d9e", "webkit_unit_tests": "0409a81bae917f2dead6d6b848010e41455e896b", "wm_unittests": "79cc04ea58166f8b8316effe7e95ba4438a034ca", "wtf_unittests": "3cee23b944740adb407dea6aeac94eae55cb15ce", "zucchini_unittests": "9cc855c002caac073bce36bb504df45594346507"}	isolate tests (2)

Blamelist:

chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
Noel Gordon (noelohnoyoudont@chromium.org)
Koji Ishii (kojiiohnoyoudont@chromium.org)
Nigel Tao (nigeltaoohnoyoudont@chromium.org)
Joel Hockey (joelhockeyohnoyoudont@chromium.org)
Benoît Lizé (lizebohnoyoudont@chromium.org)
chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
Koji Ishii (kojiiohnoyoudont@chromium.org)
Marc Treib (treibohnoyoudont@chromium.org)
chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
Kent Tamura (tkentohnoyoudont@chromium.org)
Joel Hockey (joelhockeyohnoyoudont@chromium.org)

Timing:

Create	Thursday, 15-Nov-18 08:47:06 UTC
Start	Thursday, 15-Nov-18 08:47:11 UTC
End	Thursday, 15-Nov-18 10:55:47 UTC
Pending	5 secs
Execution	2 hrs 8 mins

All Changes:

Roll src/third_party/skia e36f46461df6..1315333b6bfb (1 commits)

Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
Changed at	Thursday, 15-Nov-18 08:28:46 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	4f5cf795f34dfa683d6e8429c9ed1bdb85020920

Comments

Roll src/third_party/skia e36f46461df6..1315333b6bfb (1 commits)

https://skia.googlesource.com/skia.git/+log/e36f46461df6..1315333b6bfb


git log e36f46461df6..1315333b6bfb --date=short --no-merges --format='%ad %ae %s'
2018-11-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset


Created with:
  gclient setdep -r src/third_party/skia@1315333b6bfb

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: I3da15f0b1e9b621ef6fa6b2191c1d319099ffd05
Reviewed-on: https://chromium-review.googlesource.com/c/1337274
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608295}

Changed files

DEPS

Roll src-internal 5ad919faea83..52d757db392f (4 commits)

Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
Changed at	Thursday, 15-Nov-18 08:25:07 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	ffa5838fee064e345d02b27675ba4d676e78544c

Comments

Roll src-internal 5ad919faea83..52d757db392f (4 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ad919faea83..52d757db392f


Created with:
  gclient setdep -r src-internal@52d757db392f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iedd6a593d23a1e26a7bce0f372d6625f74eeac87
Reviewed-on: https://chromium-review.googlesource.com/c/1337469
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608294}

Changed files

DEPS

Comment fix: say tablet mode

Changed by	Noel Gordon - noelohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 08:05:37 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	45a8716f391142751234187fdf367376ae9164a5

Comments

Comment fix: say tablet mode

Ash immersive mode is not quite right anymore: remove it.

Bug: 839243
No-Try: true
Change-Id: If25f8e3411006c694825a38841fd1ae92f287623
Reviewed-on: https://chromium-review.googlesource.com/c/1336951
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608293}

Changed files

chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h

[LayoutNG] Move should_create_box_fragment to LayoutInline

Changed by	Koji Ishii - kojiiohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 07:54:26 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	8c9196789132507fb3062f7306cb36ef839b7dc4

Comments

[LayoutNG] Move should_create_box_fragment to LayoutInline

This patch moves the flag whether to force to create a box
fragment for LayoutInline or not from NGInlineItem to
LayoutInline.

This is part of an effort to reduce re-collecting
NGInlineItem when styles were changed. Re-collecting is
rather an expensive operation that changes in, for instance,
background should not require it.

Note, this patch itself does not reduce the collection,
because we require re-collection whenever NeedsLayout is set.
It is planned in future patches, but this change is needed to
make it happen.

Also benefits to keep the flag turned on once it's on, until
the LayoutInline is reattached.

The change has minor performance gain in most blink_perf.layout
https://pinpoint-dot-chromeperf.appspot.com/job/15f8c74be40000

Bug: 636993
Change-Id: I8d4e7c421d5fad26fee60832cdfbacd575f7ad34
Reviewed-on: https://chromium-review.googlesource.com/c/1333588
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608292}

Changed files

third_party/blink/renderer/core/layout/layout_inline.cc
third_party/blink/renderer/core/layout/layout_inline.h
third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.cc
third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.h
third_party/blink/renderer/core/layout/ng/inline/ng_inline_items_builder_test.cc
third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc

Delete obsolete "move to chrome/services" TODO

Changed by	Nigel Tao - nigeltaoohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 07:46:49 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	8d7b77a1205f89f36b216c301016599c87538354

Comments

Delete obsolete "move to chrome/services" TODO

Change-Id: I7ddbabf86c83256d608bd0f97736e8ead373a81d
Reviewed-on: https://chromium-review.googlesource.com/c/1337217
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608291}

Changed files

chrome/services/app_service/BUILD.gn

Add crostini unshare path

Changed by	Joel Hockey - joelhockeyohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 07:39:57 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	cbb33eaa06eb7d357f289dbe764d38aa15f6619e

Comments

Add crostini unshare path

Unshares a path previously shared, and removes path from prefs.

Bug: 878324
Change-Id: I9655c16851eed2eccca225fc3d9642db21b51dde
Reviewed-on: https://chromium-review.googlesource.com/c/1317212
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608290}

Changed files

chrome/browser/chromeos/crostini/crostini_share_path.cc
chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
chromeos/dbus/fake_seneschal_client.cc
chromeos/dbus/fake_seneschal_client.h
chromeos/dbus/seneschal_client.cc
chromeos/dbus/seneschal_client.h

blink/bindings: Fix false-positive ASAN warning in ParkableString.

Changed by	Benoît Lizé - lizebohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 07:38:57 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	3cb93d0aa21a7cb92b92ca169104e5efab7c295c

Comments

blink/bindings: Fix false-positive ASAN warning in ParkableString.

The following sequence is racy with the current ASAN checks in ParkableString,
on the main thread:

Park()
Lock()
ToString()
Unlock()

Park() poisons the string, ToString() unpoisons it, and Unlock() poisons it
again. If this last call happens while the compression is in progress, then this
is a use-after-poison.

This is not a real issue, merely an overaly eager poisoning, still making using
ASAN builds painful. Fix it by making sure the string stays unpoisoned during
compression.
Also adds a regression test.

Bug: 905137,877044
Change-Id: I5276b9ae6eee4abe2f2bf041818d1ba17358a80a
Reviewed-on: https://chromium-review.googlesource.com/c/1335585
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608289}

Changed files

third_party/blink/renderer/platform/bindings/parkable_string.cc
third_party/blink/renderer/platform/bindings/parkable_string_test.cc

Roll src/third_party/catapult 8a6451c727a2..d098799efb32 (1 commits)

Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
Changed at	Thursday, 15-Nov-18 07:38:49 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	1bfeb84d3a339c93e0f9b3ec60cf8e8665bc55bc

Comments

Roll src/third_party/catapult 8a6451c727a2..d098799efb32 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/8a6451c727a2..d098799efb32


git log 8a6451c727a2..d098799efb32 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 sabbakumov@yandex-team.ru Fix race condition while handling errors


Created with:
  gclient setdep -r src/third_party/catapult@d098799efb32

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I4e4286213e559250c206b596b98fc3b0ab4343ef
Reviewed-on: https://chromium-review.googlesource.com/c/1337309
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608288}

Changed files

DEPS

[LayoutNG] Change how LayoutInline determines in NG context

Changed by	Koji Ishii - kojiiohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 07:36:01 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	e36384f537bce29b518ae231c3449f817c8441ad

Comments

[LayoutNG] Change how LayoutInline determines in NG context

This patch changes LayoutInline to use
|IsInLayoutNGInlineFormattingContext()| to determine whether
it's in LayoutNG inline formatting context or not.

This was revealed in crrev.com/c/1333588, tests will fail
with the CL without this fix.

Bug: 636993
Change-Id: I6ae4fb3bcaf18afceb4ab3486618a031b4a895c9
Reviewed-on: https://chromium-review.googlesource.com/c/1337212
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608287}

Changed files

third_party/blink/renderer/core/layout/layout_inline.cc

Introduce TestSyncUserSettings

Changed by	Marc Treib - treibohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 07:35:58 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	fac49554f80072e949782d638fe204d37beb66d9

Comments

Introduce TestSyncUserSettings

It's a simple test implementation of SyncUserSettings that mostly
forwards calls to the TestSyncService. It is not actually used yet, but
it unlocks the migration of tests over to SyncUserSettings.

Bug: 884159
Change-Id: Id9d9c03f639c6523bb6d6592517ba46d1f8f4566
Reviewed-on: https://chromium-review.googlesource.com/c/1335565
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608286}

Changed files

components/browser_sync/sync_user_settings_impl.h
components/sync/BUILD.gn
components/sync/driver/sync_user_settings.h
components/sync/driver/test_sync_service.cc
components/sync/driver/test_sync_service.h
components/sync/driver/test_sync_user_settings.cc
components/sync/driver/test_sync_user_settings.h

Roll src-internal bb18f19dce17..5ad919faea83 (1 commits)

Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
Changed at	Thursday, 15-Nov-18 07:21:34 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	33283f195a0b8ef1bcfbe5a1d6114ba84449d0d0

Comments

Roll src-internal bb18f19dce17..5ad919faea83 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb18f19dce17..5ad919faea83


Created with:
  gclient setdep -r src-internal@5ad919faea83

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie26dfafd1271a82eb4bea28cae1d65ed76a7e4f0
Reviewed-on: https://chromium-review.googlesource.com/c/1337310
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608285}

Changed files

DEPS

Change the level of Selection.addRange failure message.

Changed by	Kent Tamura - tkentohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 07:20:14 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	ada1a56e19efbc88c532ba3862d3ad1fa62ce3e1

Comments

Change the level of Selection.addRange failure message.

Error -> Warning.

Bug: 697443
Change-Id: Ib4e88bb64cd5f1a533ae88306c47e91ca0606085
Reviewed-on: https://chromium-review.googlesource.com/c/1337216
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608284}

Changed files

third_party/WebKit/LayoutTests/editing/selection/addRange-failures-expected.txt
third_party/blink/renderer/core/editing/dom_selection.cc
third_party/blink/renderer/core/editing/dom_selection.h

Roll src/third_party/cros_system_api/ 693e848cd..9a5d5fab3 (2 commits)

Changed by	Joel Hockey - joelhockeyohnoyoudont@chromium.org
Changed at	Thursday, 15-Nov-18 07:04:34 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	6d58bff25a18bdba2b94e06143cf5011b044ef3b

Comments

Roll src/third_party/cros_system_api/ 693e848cd..9a5d5fab3 (2 commits)

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/693e848cded9..9a5d5fab32aa

$ git log 693e848cd..9a5d5fab3 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 joelhockey vm_tools: seneschal: Add support for Unshare
2018-11-01 chirantan vm_tools: concierge: Remove StartContainer method

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I73b23667ce4168d6a6d5c184376eda856ab15b14
Reviewed-on: https://chromium-review.googlesource.com/c/1337137
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608283}

Changed files

DEPS