Home | Search | chromium - Builders
Login

Builder Windows deterministic Build 10719 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision92e84c81c1ce85d297776ed9d71d580f43b24d3d
Got Revision92e84c81c1ce85d297776ed9d71d580f43b24d3d

Execution:

Steps and Logfiles:

Show:
  1. ( 333 ms ) setup_build
    running recipe: "swarming/deterministic_build"
  2. ( 6 mins 47 secs ) bot_update
    [116GB/299GB used (38%)]
  3. ( 402 ms ) clobber
  4. ( 33 secs ) gclient runhooks
  5. ( 484 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  6. ( 3 mins 7 secs ) generate_build_files
  7. ( 17 mins 2 secs ) First build
  8. ( 1 mins 3 secs ) First build confirm no-op
  9. ( 9 mins 13 secs ) isolate tests
  10. ( 523 ms ) clobber (2)
  11. ( 38 secs ) gclient runhooks (2)
  12. ( 639 ms ) lookup GN args (2)
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  13. ( 3 mins 13 secs ) generate_build_files (2)
  14. ( 16 mins 41 secs ) Second build
  15. ( 1 mins 19 secs ) Second build confirm no-op
  16. ( 8 mins 55 secs ) isolate tests (2)
  17. ( 18 mins 33 secs ) compare_build_artifacts
  18. ( 1 mins 35 secs ) create tarball
  19. ( 12 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2173-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542264815916912, "id": "8929811844344242688", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/92e84c81c1ce85d297776ed9d71d580f43b24d3d", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/92e84c81c1ce85d297776ed9d71d580f43b24d3d", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095241906630506032", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Windows deterministic" setup_build
buildnumber 10719 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "swarming/deterministic_build" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "92e84c81c1ce85d297776ed9d71d580f43b24d3d" setup_build
got_angle_revision "f3acb8c133fa825d5f25159eaf4ebf303bfef7a6" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "597e1587b4bfc7bf89895c7c879ae58b649da3c5" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "92e84c81c1ce85d297776ed9d71d580f43b24d3d" bot_update
got_revision_cp "refs/heads/master@{#608282}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "b0e3bc7d7fd4655b488fd916eea1a3601ab3bede" bot_update
got_v8_revision_cp "refs/heads/7.2.338@{#1}" bot_update
got_webrtc_revision "c25d2344574830a3f73a934ba5b4662e0475cbbb" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25646}" bot_update
swarm_hashes {"accessibility_unittests": "7ff39c499537eac06e9d5ab7d10714eb60e4a5dc", "angle_end2end_tests": "f3bcdb5a20b58b71ac2a3c3791c67fe9e76e48da", "angle_perftests": "64b8c1872d5cfb96e8e59e84fcab18bb2af57129", "angle_unittests": "f41324fa827080426b478251bc2f52b3e252e062", "angle_white_box_tests": "d8f1ea9291dfeb693cf2ed3e32c982b2fbac21ea", "app_shell_unittests": "874afe043b0a9a565bafca4426fc0832f39bcace", "aura_unittests": "2d996de4ee90f634793485bc146629bd7b3a54ce", "base_perftests": "1f05a5b2461a1d74ac7029226e48cdab7a4a99b5", "base_unittests": "bb14583f90979083001ae2a8b9e47a7197405757", "blink_common_unittests": "c57c1bce8ab916f94db65b7e94264cad2c96d285", "blink_fuzzer_unittests": "7805197d6c1760fb5507bfa719130cb7fc2bd54a", "blink_heap_unittests": "2635ab04cdeade314cb7be75443df813fab10b06", "blink_platform_unittests": "0da20eeb387e16496494acb050b5d489d414eceb", "boringssl_crypto_tests": "76568ed33c9123a9d0b0d4ae9c441f07f8fb2cd2", "boringssl_ssl_tests": "cafec2eb9800f75e771de18114b83c471660d15a", "browser_tests": "00da9c7d4ea27a3a1729e0773ca25f56a8eec5e8", "cacheinvalidation_unittests": "bea555180229f1c98c6db46d26d6642fb03121e8", "capture_unittests": "5dfa97f007243e64b028cbd4aeb49b61d8601fda", "cast_unittests": "49046b779ce4e0cdf0dc8223c3a02597f1a9320d", "cc_unittests": "f1206bb1c8a88320147016a43a8c1b20ba53423b", "chrome_app_unittests": "4698dfa516a25524e206e79bd266852ef6ebaebe", "chrome_cleaner_unittests": "71786cc30ca19d01aef23b71ff9e05c8f2cb4454", "chrome_elf_import_unittests": "e0afc4049c448458ef742633e91f355434cac1d2", "chrome_elf_unittests": "4ede337d2363a5e5645685db4e83168336bd56ea", "chromedriver_py_tests": "a6d2fec3e239d17d0ce27ef07c0ec765616f2c22", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "4a604b1d0897f6f98deb8f20d2dac33c1bbaea77", "command_buffer_perftests": "a6841c654c95e0b776474ae7efba63440b891427", "components_browsertests": "69a5422a04fa66fcce12034785d8319337ffaae0", "components_perftests": "52154806e1ee961f5bb23a949293a808fbb98949", "components_unittests": "4ffe32ff7482b28579e70c26de08d8c81fd7f618", "compositor_unittests": "65b6943514e6390cff397cb206476439da3b85b5", "content_browsertests": "f6d223662cb543f14ff5f8cc9508bd0728457ea5", "content_shell_crash_test": "b823dd9c62e8c78a55603147452fafccbb9a1cb5", "content_unittests": "cd439f4438a34fdf6b6218026a39e643c0918cb3", "courgette_unittests": "c9ce17b272a7418961b987cc4efe180f0990ea23", "crashpad_tests": "7340dc066971b9ebf934062dd979fa4b27059f50", "cronet_tests": "a55ebe7251a4ad3ddfd6a4392b908b2e0b6ba8e2", "cronet_unittests": "9fa2b5a72a20feef720c241575bf80d4278d7e39", "crypto_unittests": "c3e6ecaa4ebc7a3e7be93b24379e640dc3525508", "dawn_end2end_tests": "1620e478feece7dcd63410d20598c76b8440b9aa", "device_unittests": "d2264f552b89926a8a3f5fe9439ffe54bae815c5", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "93b22824e1194d1c9e760262cb2769fbf3d09927", "elevation_service_unittests": "8d6048c2eee9e12f83d2854895e4a7872eeb5b32", "events_unittests": "f5cc46de76981d33ec9ae149be0c82af8801531d", "extensions_browsertests": "25d6cea81f52e2b5b5282283f1154e6a2c119c3b", "extensions_unittests": "7c22112168c9fa2f497608ebdb4d822e0f414058", "filesystem_service_unittests": "13675059b0f08a38605b4a0310f6906b74d86f62", "gcm_unit_tests": "49a024f32ada3145a0e6739602f27afca783d748", "gcp_unittests": "bc4fb65a11a06392e0195c4508dfe1565f5b3d6e", "gfx_unittests": "6d635e1c592243eba4128f246a99508915990960", "gin_unittests": "17d027837585172649638138e7c4e310450c93fb", "gl_tests": "68e1a93d5cd62f0440f875f5fee89728fe6b7188", "gl_unittests": "44d18bc602a7f5445756c57fc111cd18ea1d7326", "gl_unittests_ozone": "44d18bc602a7f5445756c57fc111cd18ea1d7326", "gles2_conform_test": "758eec3345b066be9b08de223ea649eedbedc666", "google_apis_unittests": "6b85d966e5291a25d13285dcfc9bf10b9637500b", "gpu_perftests": "cbb20a3491f077c5ebc66f01540f83f5a29fa320", "gpu_unittests": "f274c274c363779fb6b6c80857c0c4bf03027cd0", "headless_browsertests": "7bc0e6b7165de7277ca838247580fee40d13426e", "headless_unittests": "0265e3e9a405f43c73adb32a98aaaa88ae8b4cb4", "install_static_unittests": "28b4f32aa51d7a5d33908789d26f6a7180110b68", "installer_util_unittests": "dbb360b0a034c3d387a90eef59b1ab6d11df9f38", "interactive_ui_tests": "23b24ce68b1f6ac6533290557e95a0571c979cb0", "ipc_tests": "f16773a5566ff8bfc4b00e20cfa2d0a97771f89c", "jingle_unittests": "bf7fcede6bcbdd63fe75a2ff86db74b4ed1897e9", "latency_unittests": "3ba6b4e78bbac02e7d56b0cb2a274e3a16b04fff", "leveldb_service_unittests": "e5490491ff70e2ee92360bc3295d48e97d7adc39", "libjingle_xmpp_unittests": "c0b23fe1cdf35f46e4df385935f87eff74f8f425", "load_library_perf_tests": "83c8c7248fdf97f0cd8dbaf7cfdba9353b3b3d42", "media_blink_unittests": "5ca39f0eedccc71cfc1416a802e75115f2459181", "media_perftests": "adfbbb88531af1344f6782756f639f2d5a9c8fa4", "media_service_unittests": "5d7dea83151c5e740c0d5c7df9f9abe318a68484", "media_unittests": "1636421d5809494c71548cf41bc5fd666fc0d8cd", "message_center_unittests": "74129541fdf5236d8a0042ffe20647e321df3b06", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "0a9db1b8c9747d09b614ad380b5b0f9c7d89995d", "mini_installer_tests": "9f0f8a00d28c9b6dd1b8b92c4757312e695b2c16", "mojo_core_unittests": "1602f5f157954fdf4cff147d70535bc77ed58913", "mojo_unittests": "1a1fe7fa4f9ab181fe457f5efdd8558cc7d9019e", "nacl_loader_unittests": "b72e76fe43ceb395e92b3ac2bc78908f889a5670", "native_theme_unittests": "119126785cfd0f6560ee724afd51c61cf5b82d59", "net_perftests": "b6d9c0b34fe8a3786bcb6da928cf7aa196ccb989", "net_unittests": "069a22cfd0b2cd251e755e5475de806cc4f8f777", "notification_helper_unittests": "e64389632352d74270d2ad11a0791813574d7009", "pdf_unittests": "4039702eb710b1258714edde5ec73b7409904a65", "performance_browser_tests": "6578a329c9087233d73d75767623961497700078", "performance_test_suite": "854e2b271e5a4a722dab4f949c3eafecc6ae7edc", "performance_webview_test_suite": "29e6ba56bd30204549f7eb10bd43376839952971", "ppapi_unittests": "e46a92e5a1005d7388286b57156b5060ca81e486", "printing_unittests": "f1cd962519fbb8d1a24b67925ff09abd264174c4", "remoting_unittests": "5272c37d99bec7414386b09547e62050dfe3159d", "sbox_integration_tests": "e4f1ce9cd4c7c1f7deb720aef425f2f4a808a6e8", "sbox_unittests": "9daf082365ff34c0aacd486c989a69a5889a8129", "sbox_validation_tests": "dc3fbf610be7de3ae0d35f33ce98811cb1aecbad", "service_manager_unittests": "ac96fcb97a19466eb1f3716a80f89249dbf8e628", "services_unittests": "849abde4a18fcbe0a2a65760edd22e25af003b41", "setup_unittests": "820b898e65ae1299979b426fad83c0bf0f1be20d", "shell_dialogs_unittests": "1402e4df01a2a77b0d4266f2dff2f58b3daae333", "skia_unittests": "029c6398f10ba14f1554fbd00b12d8741fa8916a", "snapshot_unittests": "e6fb2a1ec17906907c9e0a624aa455b8999a5cdd", "sql_unittests": "2646698ab94d873f6a2b567e91fb919e8119f639", "storage_unittests": "580374523c71eb5698bc7378be0a4b02739ccdfc", "swiftshader_unittests": "093d7fa044ee7fc11baf167a361cdc7fa5e5d0ca", "sync_integration_tests": "47aa833e3266065dc00300a5c57cb3900409fdcc", "telemetry_gpu_integration_test": "7cf5454074d4b46c600cfd5d6fcbb83c3dfc959c", "telemetry_gpu_unittests": "cd272018b653f964247ea7036e9cdfb73c4d8960", "telemetry_perf_tests_without_chrome": "6125069ada65a6bb10c70e5ab3426b5dc4c4aa8e", "telemetry_perf_unittests": "b2243103a148fa7a63f04d9f7169de1dcee5183d", "telemetry_unittests": "b63254b8f4e6a188af894c1280b23cede49ed824", "tracing_perftests": "63d6ccd1cbe5595664253f77810ba0e6fd53375f", "traffic_annotation_auditor_unittests": "655f206df1dce06d491b3ff8b7dadaeb0ce7122b", "ui_base_unittests": "527f79f622332e1870c59b67fc8b8dfa7b986f1f", "ui_touch_selection_unittests": "a2232b6bad2297dc054602c05e9abe44cbb95493", "unit_tests": "09b281916d8f075e440be4a2e11523d9411fece9", "url_unittests": "971ae7aa663cfc5f6c63753a11c27f3accd5a78a", "video_decode_accelerator_unittest": "1a9ecbd3c3784eefeda0330c02c4b43a821dc3a0", "views_mus_interactive_ui_tests": "61a31309af3051fa36340b36267b2218ad2efbdd", "views_mus_unittests": "8f243db11a3a9d367d4b11d96fa745a495bca281", "views_perftests": "fcf87175925f2ad00c3f3f0e7ea14bbc904dd1d4", "views_unittests": "e2bb32b86d96832baafefb51ddfad77284c8443f", "viz_unittests": "8b931ab40655b0f490fc03a2a213bad57c8cac8d", "vr_common_perftests": "6be4db0c5c7b2bd6a070f565d55989e35c6730fe", "vr_common_unittests": "2284bcbfae8a99d9c3d174d68ba9a36dad56123a", "vr_pixeltests": "be543ce7c88d07d69985588692911255945584d9", "webkit_layout_tests": "649b9e07d3649d886bc3d2dd29029bd9f5dad809", "webkit_layout_tests_exparchive": "a486a8b7fd0d725d0b5c614d4b3841623f0e79d2", "webkit_python_tests": "ae37fa979716d2f661be3cb058168af26a2f1d9e", "webkit_unit_tests": "28f2c960da10227f1c4f0fd2e6266f770e91d18a", "wm_unittests": "79cc04ea58166f8b8316effe7e95ba4438a034ca", "wtf_unittests": "3cee23b944740adb407dea6aeac94eae55cb15ce", "zucchini_unittests": "9cc855c002caac073bce36bb504df45594346507"} isolate tests
swarm_hashes {"accessibility_unittests": "7ff39c499537eac06e9d5ab7d10714eb60e4a5dc", "angle_end2end_tests": "f3bcdb5a20b58b71ac2a3c3791c67fe9e76e48da", "angle_perftests": "64b8c1872d5cfb96e8e59e84fcab18bb2af57129", "angle_unittests": "f41324fa827080426b478251bc2f52b3e252e062", "angle_white_box_tests": "d8f1ea9291dfeb693cf2ed3e32c982b2fbac21ea", "app_shell_unittests": "874afe043b0a9a565bafca4426fc0832f39bcace", "aura_unittests": "2d996de4ee90f634793485bc146629bd7b3a54ce", "base_perftests": "1f05a5b2461a1d74ac7029226e48cdab7a4a99b5", "base_unittests": "bb14583f90979083001ae2a8b9e47a7197405757", "blink_common_unittests": "c57c1bce8ab916f94db65b7e94264cad2c96d285", "blink_fuzzer_unittests": "7805197d6c1760fb5507bfa719130cb7fc2bd54a", "blink_heap_unittests": "2635ab04cdeade314cb7be75443df813fab10b06", "blink_platform_unittests": "0da20eeb387e16496494acb050b5d489d414eceb", "boringssl_crypto_tests": "76568ed33c9123a9d0b0d4ae9c441f07f8fb2cd2", "boringssl_ssl_tests": "cafec2eb9800f75e771de18114b83c471660d15a", "browser_tests": "00da9c7d4ea27a3a1729e0773ca25f56a8eec5e8", "cacheinvalidation_unittests": "bea555180229f1c98c6db46d26d6642fb03121e8", "capture_unittests": "5dfa97f007243e64b028cbd4aeb49b61d8601fda", "cast_unittests": "49046b779ce4e0cdf0dc8223c3a02597f1a9320d", "cc_unittests": "f1206bb1c8a88320147016a43a8c1b20ba53423b", "chrome_app_unittests": "4698dfa516a25524e206e79bd266852ef6ebaebe", "chrome_cleaner_unittests": "71786cc30ca19d01aef23b71ff9e05c8f2cb4454", "chrome_elf_import_unittests": "e0afc4049c448458ef742633e91f355434cac1d2", "chrome_elf_unittests": "4ede337d2363a5e5645685db4e83168336bd56ea", "chromedriver_py_tests": "a6d2fec3e239d17d0ce27ef07c0ec765616f2c22", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "4a604b1d0897f6f98deb8f20d2dac33c1bbaea77", "command_buffer_perftests": "a6841c654c95e0b776474ae7efba63440b891427", "components_browsertests": "69a5422a04fa66fcce12034785d8319337ffaae0", "components_perftests": "52154806e1ee961f5bb23a949293a808fbb98949", "components_unittests": "4ffe32ff7482b28579e70c26de08d8c81fd7f618", "compositor_unittests": "65b6943514e6390cff397cb206476439da3b85b5", "content_browsertests": "f6d223662cb543f14ff5f8cc9508bd0728457ea5", "content_shell_crash_test": "b823dd9c62e8c78a55603147452fafccbb9a1cb5", "content_unittests": "cd439f4438a34fdf6b6218026a39e643c0918cb3", "courgette_unittests": "c9ce17b272a7418961b987cc4efe180f0990ea23", "crashpad_tests": "7340dc066971b9ebf934062dd979fa4b27059f50", "cronet_tests": "a55ebe7251a4ad3ddfd6a4392b908b2e0b6ba8e2", "cronet_unittests": "9fa2b5a72a20feef720c241575bf80d4278d7e39", "crypto_unittests": "c3e6ecaa4ebc7a3e7be93b24379e640dc3525508", "dawn_end2end_tests": "1620e478feece7dcd63410d20598c76b8440b9aa", "device_unittests": "d2264f552b89926a8a3f5fe9439ffe54bae815c5", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "93b22824e1194d1c9e760262cb2769fbf3d09927", "elevation_service_unittests": "8d6048c2eee9e12f83d2854895e4a7872eeb5b32", "events_unittests": "f5cc46de76981d33ec9ae149be0c82af8801531d", "extensions_browsertests": "25d6cea81f52e2b5b5282283f1154e6a2c119c3b", "extensions_unittests": "7c22112168c9fa2f497608ebdb4d822e0f414058", "filesystem_service_unittests": "13675059b0f08a38605b4a0310f6906b74d86f62", "gcm_unit_tests": "49a024f32ada3145a0e6739602f27afca783d748", "gcp_unittests": "bc4fb65a11a06392e0195c4508dfe1565f5b3d6e", "gfx_unittests": "6d635e1c592243eba4128f246a99508915990960", "gin_unittests": "17d027837585172649638138e7c4e310450c93fb", "gl_tests": "68e1a93d5cd62f0440f875f5fee89728fe6b7188", "gl_unittests": "44d18bc602a7f5445756c57fc111cd18ea1d7326", "gl_unittests_ozone": "44d18bc602a7f5445756c57fc111cd18ea1d7326", "gles2_conform_test": "758eec3345b066be9b08de223ea649eedbedc666", "google_apis_unittests": "6b85d966e5291a25d13285dcfc9bf10b9637500b", "gpu_perftests": "cbb20a3491f077c5ebc66f01540f83f5a29fa320", "gpu_unittests": "f274c274c363779fb6b6c80857c0c4bf03027cd0", "headless_browsertests": "7bc0e6b7165de7277ca838247580fee40d13426e", "headless_unittests": "0265e3e9a405f43c73adb32a98aaaa88ae8b4cb4", "install_static_unittests": "28b4f32aa51d7a5d33908789d26f6a7180110b68", "installer_util_unittests": "dbb360b0a034c3d387a90eef59b1ab6d11df9f38", "interactive_ui_tests": "23b24ce68b1f6ac6533290557e95a0571c979cb0", "ipc_tests": "f16773a5566ff8bfc4b00e20cfa2d0a97771f89c", "jingle_unittests": "bf7fcede6bcbdd63fe75a2ff86db74b4ed1897e9", "latency_unittests": "3ba6b4e78bbac02e7d56b0cb2a274e3a16b04fff", "leveldb_service_unittests": "e5490491ff70e2ee92360bc3295d48e97d7adc39", "libjingle_xmpp_unittests": "c0b23fe1cdf35f46e4df385935f87eff74f8f425", "load_library_perf_tests": "83c8c7248fdf97f0cd8dbaf7cfdba9353b3b3d42", "media_blink_unittests": "5ca39f0eedccc71cfc1416a802e75115f2459181", "media_perftests": "adfbbb88531af1344f6782756f639f2d5a9c8fa4", "media_service_unittests": "5d7dea83151c5e740c0d5c7df9f9abe318a68484", "media_unittests": "1636421d5809494c71548cf41bc5fd666fc0d8cd", "message_center_unittests": "74129541fdf5236d8a0042ffe20647e321df3b06", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "0a9db1b8c9747d09b614ad380b5b0f9c7d89995d", "mini_installer_tests": "918ceb92ab8228dbb6eaff46a9ab7063a823d9b4", "mojo_core_unittests": "1602f5f157954fdf4cff147d70535bc77ed58913", "mojo_unittests": "1a1fe7fa4f9ab181fe457f5efdd8558cc7d9019e", "nacl_loader_unittests": "b72e76fe43ceb395e92b3ac2bc78908f889a5670", "native_theme_unittests": "119126785cfd0f6560ee724afd51c61cf5b82d59", "net_perftests": "b6d9c0b34fe8a3786bcb6da928cf7aa196ccb989", "net_unittests": "069a22cfd0b2cd251e755e5475de806cc4f8f777", "notification_helper_unittests": "e64389632352d74270d2ad11a0791813574d7009", "pdf_unittests": "4039702eb710b1258714edde5ec73b7409904a65", "performance_browser_tests": "6578a329c9087233d73d75767623961497700078", "performance_test_suite": "854e2b271e5a4a722dab4f949c3eafecc6ae7edc", "performance_webview_test_suite": "29e6ba56bd30204549f7eb10bd43376839952971", "ppapi_unittests": "e46a92e5a1005d7388286b57156b5060ca81e486", "printing_unittests": "f1cd962519fbb8d1a24b67925ff09abd264174c4", "remoting_unittests": "5272c37d99bec7414386b09547e62050dfe3159d", "sbox_integration_tests": "e4f1ce9cd4c7c1f7deb720aef425f2f4a808a6e8", "sbox_unittests": "9daf082365ff34c0aacd486c989a69a5889a8129", "sbox_validation_tests": "dc3fbf610be7de3ae0d35f33ce98811cb1aecbad", "service_manager_unittests": "ac96fcb97a19466eb1f3716a80f89249dbf8e628", "services_unittests": "849abde4a18fcbe0a2a65760edd22e25af003b41", "setup_unittests": "820b898e65ae1299979b426fad83c0bf0f1be20d", "shell_dialogs_unittests": "1402e4df01a2a77b0d4266f2dff2f58b3daae333", "skia_unittests": "029c6398f10ba14f1554fbd00b12d8741fa8916a", "snapshot_unittests": "e6fb2a1ec17906907c9e0a624aa455b8999a5cdd", "sql_unittests": "2646698ab94d873f6a2b567e91fb919e8119f639", "storage_unittests": "580374523c71eb5698bc7378be0a4b02739ccdfc", "swiftshader_unittests": "093d7fa044ee7fc11baf167a361cdc7fa5e5d0ca", "sync_integration_tests": "47aa833e3266065dc00300a5c57cb3900409fdcc", "telemetry_gpu_integration_test": "7cf5454074d4b46c600cfd5d6fcbb83c3dfc959c", "telemetry_gpu_unittests": "cd272018b653f964247ea7036e9cdfb73c4d8960", "telemetry_perf_tests_without_chrome": "6125069ada65a6bb10c70e5ab3426b5dc4c4aa8e", "telemetry_perf_unittests": "b2243103a148fa7a63f04d9f7169de1dcee5183d", "telemetry_unittests": "b63254b8f4e6a188af894c1280b23cede49ed824", "tracing_perftests": "63d6ccd1cbe5595664253f77810ba0e6fd53375f", "traffic_annotation_auditor_unittests": "655f206df1dce06d491b3ff8b7dadaeb0ce7122b", "ui_base_unittests": "527f79f622332e1870c59b67fc8b8dfa7b986f1f", "ui_touch_selection_unittests": "a2232b6bad2297dc054602c05e9abe44cbb95493", "unit_tests": "09b281916d8f075e440be4a2e11523d9411fece9", "url_unittests": "971ae7aa663cfc5f6c63753a11c27f3accd5a78a", "video_decode_accelerator_unittest": "1a9ecbd3c3784eefeda0330c02c4b43a821dc3a0", "views_mus_interactive_ui_tests": "61a31309af3051fa36340b36267b2218ad2efbdd", "views_mus_unittests": "8f243db11a3a9d367d4b11d96fa745a495bca281", "views_perftests": "fcf87175925f2ad00c3f3f0e7ea14bbc904dd1d4", "views_unittests": "e2bb32b86d96832baafefb51ddfad77284c8443f", "viz_unittests": "8b931ab40655b0f490fc03a2a213bad57c8cac8d", "vr_common_perftests": "6be4db0c5c7b2bd6a070f565d55989e35c6730fe", "vr_common_unittests": "2284bcbfae8a99d9c3d174d68ba9a36dad56123a", "vr_pixeltests": "be543ce7c88d07d69985588692911255945584d9", "webkit_layout_tests": "649b9e07d3649d886bc3d2dd29029bd9f5dad809", "webkit_layout_tests_exparchive": "a486a8b7fd0d725d0b5c614d4b3841623f0e79d2", "webkit_python_tests": "ae37fa979716d2f661be3cb058168af26a2f1d9e", "webkit_unit_tests": "28f2c960da10227f1c4f0fd2e6266f770e91d18a", "wm_unittests": "79cc04ea58166f8b8316effe7e95ba4438a034ca", "wtf_unittests": "3cee23b944740adb407dea6aeac94eae55cb15ce", "zucchini_unittests": "9cc855c002caac073bce36bb504df45594346507"} isolate tests (2)

Blamelist:

  1. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  2. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  3. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  4. Makoto Shimazu (shimazuohnoyoudont@chromium.org)
  5. Kentaro Hara (harakenohnoyoudont@chromium.org)
  6. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  7. Lei Zhang (thestigohnoyoudont@chromium.org)
  8. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. Jay Harris (harrisjayohnoyoudont@chromium.org)
  10. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  11. Hao Zhang (hozhngohnoyoudont@google.com)
  12. Adrienne Walker (enneohnoyoudont@chromium.org)
  13. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  14. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  15. Kentaro Hara (harakenohnoyoudont@chromium.org)
  16. Nicolas Pena (npmohnoyoudont@chromium.org)
  17. Koji Ishii (kojiiohnoyoudont@chromium.org)
  18. Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
  19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  20. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  21. Kent Tamura (tkentohnoyoudont@chromium.org)
  22. Xiaoqian Dai (xdaiohnoyoudont@chromium.org)

Timing:

Create Thursday, 15-Nov-18 06:53:35 UTC
Start Thursday, 15-Nov-18 06:53:37 UTC
End Thursday, 15-Nov-18 08:47:00 UTC
Pending 1 secs
Execution 1 hrs 53 mins

All Changes:

  1. Import wpt@42abd6cc7ebd7c0b0513639e1a8c1bd958638fed

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 06:52:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 92e84c81c1ce85d297776ed9d71d580f43b24d3d

    Comments

    Import wpt@42abd6cc7ebd7c0b0513639e1a8c1bd958638fed
    
    Using wpt-import in Chromium 6b0ab168c4d630c29b73f99f6e3825310f83fb1a.
    With Chromium commits locally applied on WPT:
    f482e77e59 "Add report-only mode to Feature Policy"
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hbos@chromium.org, hta@chromium.org:
      external/wpt/webrtc
    
    NOAUTOREVERT=true
    TBR=kyleju
    
    No-Export: true
    Change-Id: I622df7e594bbff38c9752638e80a1ca926bbecb0
    Reviewed-on: https://chromium-review.googlesource.com/c/1337291
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608282}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCConfiguration-rtcpMuxPolicy.html
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-iceGatheringState.html
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded.html
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-rollback.html
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-offer.html
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt
  2. Reland "Remove remaining components/domain_reliability dependency on content/ and components/keyed_service."

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 06:51:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 506d1d88dd858024e14a5b9565a8940df67c92df

    Comments

    Reland "Remove remaining components/domain_reliability dependency on content/ and components/keyed_service."
    
    This is a reland of bd611e3e7daa6e4048f775a4db95f1045a800548
    
    Original change's description:
    > Remove remaining components/domain_reliability dependency on content/ and components/keyed_service.
    >
    > This way it can run in the network process, similar to Network Error Logging.
    >
    > Bug: 853251
    > Change-Id: I403a5dcc3cae12b592a444c7e23f71c552b58e1f
    > Reviewed-on: https://chromium-review.googlesource.com/c/1334848
    > Reviewed-by: Misha Efimov <mef@chromium.org>
    > Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#608175}
    
    TBR=mef@chromium.org
    
    Bug: 853251
    Change-Id: Iee089ae0cd422e242df53604da6dcb8ef25b74cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1337373
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608281}

    Changed files

    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
    • chrome/browser/domain_reliability/service_factory.cc
    • chrome/browser/domain_reliability/service_factory.h
    • chrome/browser/profiles/profile_impl.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/domain_reliability/BUILD.gn
    • components/domain_reliability/DEPS
    • components/domain_reliability/monitor.cc
    • components/domain_reliability/monitor.h
    • components/domain_reliability/monitor_unittest.cc
    • components/domain_reliability/service.cc
    • components/domain_reliability/service.h
    • components/domain_reliability/service_unittest.cc
  3. media/gpu: use 0x1000 alignment for user buffers passed to V4L2 devices

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 06:42:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5749f28d663fe9f72392661ac0e31a4ead4fc19a

    Comments

    media/gpu: use 0x1000 alignment for user buffers passed to V4L2 devices
    
    User-allocated memory can be passed to some hardware (like video
    encoder). Such hardware is generally not happy if the memory is not
    page-aligned. This patch adds a new member to VideoFrameLayout that
    specifies the desired alignment of the buffer, and make VideoFrame
    comply to it when allocating memory. It also makes use of it by
    specifying a page-alignment to formats returned by V4L2Device.
    
    Other users of VideoFrame/VideoFrameLayout are not affected by this
    CL.
    
    BUG=b:80274650
    TEST=Made sure the VEA unittest was working on Hana and Cheza.
    
    Change-Id: Id615ca1ba3f9b253ba774573146a3428c144f57f
    Reviewed-on: https://chromium-review.googlesource.com/c/1154769
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608280}

    Changed files

    • media/base/video_frame.cc
    • media/base/video_frame.h
    • media/base/video_frame_layout.cc
    • media/base/video_frame_layout.h
    • media/gpu/v4l2/v4l2_device.cc
  4. Deflake NetworkServiceRestartBrowserTests on slower bots

    Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 06:24:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2540a64831994cf0e880aaa88c26cc32ba77f106

    Comments

    Deflake NetworkServiceRestartBrowserTests on slower bots
    
    Previously ServiceWorkerObserver::WaitForState(STOPPED) starts to observe the
    state when it's called, but sometimes it's too slow and restarting the worker is
    already happening when starting to wait for state STOPPED. This CL fixes it by
    keeping all state changes and returning from WaitForState() if the observer saw
    the state previously at least once.
    
    Bug: 889855
    Change-Id: Ide180fa49c9f47f68e1482b9a368b386648a3d4e
    Reviewed-on: https://chromium-review.googlesource.com/c/1337214
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608279}

    Changed files

    • content/browser/network_service_restart_browsertest.cc
  5. Revert "cros: Turn LoginBubble flags into a LoginBaseBubbleView member function"

    Changed by Kentaro Hara - harakenohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 06:23:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f29016ee2304c4a46c39393390a58d83bf07d35

    Comments

    Revert "cros: Turn LoginBubble flags into a LoginBaseBubbleView member function"
    
    This reverts commit 21216eb00511781a2e2c93de0321e7fcf886024d.
    
    Reason for revert: I'm 20% sure but this CL is suspicious for the failure on Linux Chromium OS ASan LSan Tests. Let me try to revert it and see how it goes. If it's innocent, let me reland!
    
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30100
    
    Original change's description:
    > cros: Turn LoginBubble flags into a LoginBaseBubbleView member function
    > 
    > This prevents us from having to mutate the flags variable each time a bubble is
    > shown or hidden.
    > 
    > Bug: 905436
    > Change-Id: Ia40f2d0b9aa949fd6c67b46dcf22a5e5272f60a7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1336254
    > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#608151}
    
    TBR=jdufault@chromium.org,qnnguyen@chromium.org
    
    Change-Id: Iebf03b66402b61999a53a1db372fbc36d9a91c0c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 905436
    Reviewed-on: https://chromium-review.googlesource.com/c/1337141
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608278}

    Changed files

    • ash/login/ui/lock_contents_view.cc
    • ash/login/ui/login_base_bubble_view.cc
    • ash/login/ui/login_base_bubble_view.h
    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble.h
    • ash/login/ui/login_bubble_unittest.cc
  6. FilesApp: guard getLocationInfo call

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 06:23:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b1943b7e9bbe5b6ad6cb6217531fdf1916d442e

    Comments

    FilesApp: guard getLocationInfo call
    
    I saw some flakiness today in the QuickView UI test where a volume can
    be unmounted whilst a rescan is in progress.  Then when it is finally
    complete, this call to getLocationInfo fails.
    
    Change-Id: Ie29e551b980b3e4bacea7b6bd39746c8c140e1aa
    Reviewed-on: https://chromium-review.googlesource.com/c/1337136
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608277}

    Changed files

    • ui/file_manager/file_manager/foreground/js/directory_model.js
  7. Remove TearDown() test functions that just call TearDown().

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:47:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c51b6c6a9acb8387d6820c0e0113c6603efd1a52

    Comments

    Remove TearDown() test functions that just call TearDown().
    
    TBR=halliwell@chromium.org,kbr@chromium.org,kinuko@chromium.org,marq@chromium.org, olka@chromium.org,thakis@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I40a84a602bfa25f6f38c8a9b1d8fc4015906563b
    Reviewed-on: https://chromium-review.googlesource.com/c/1279182
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608276}

    Changed files

    • ash/app_list/model/app_list_model_unittest.cc
    • ash/display/mirror_window_controller_unittest.cc
    • ash/metrics/login_metrics_recorder_unittest.cc
    • ash/sticky_keys/sticky_keys_unittest.cc
    • ash/wm/ash_focus_rules_unittest.cc
    • ash/wm/window_animations_unittest.cc
    • chromecast/browser/cast_media_blocker_unittest.cc
    • content/browser/media/session/media_session_impl_uma_unittest.cc
    • content/browser/tracing/tracing_controller_browsertest.cc
    • gpu/command_buffer/service/mailbox_manager_unittest.cc
    • ios/chrome/browser/ui/open_in_controller_unittest.mm
    • media/audio/audio_output_proxy_unittest.cc
    • third_party/blink/renderer/core/frame/ad_tracker_test.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
    • ui/wm/core/window_animations_unittest.cc
  8. Roll src/third_party/skia 2eccd58916ee..e36f46461df6 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 05:44:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2785bf0cd5f50f8ee8e14ed4d301d25e5c1b82a2

    Comments

    Roll src/third_party/skia 2eccd58916ee..e36f46461df6 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/2eccd58916ee..e36f46461df6
    
    
    git log 2eccd58916ee..e36f46461df6 --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-11-15 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/skia@e36f46461df6
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=rmistry@chromium.org
    
    Change-Id: Ifb7138c0396e5a0f6ba8b378dac95e2046beecd6
    Reviewed-on: https://chromium-review.googlesource.com/c/1337273
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608275}

    Changed files

    • DEPS
  9. Prepares for addition of CustomTabBar.

    Changed by Jay Harris - harrisjayohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:43:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c9a2691f0e3ad2814ee3549abbf9decbec15161

    Comments

    Prepares for addition of CustomTabBar.
    The CustomTabBar will be added in a future CL.
    
    * Lifts LocationBar animation into Toolbar, so the same animation
    can be reused on the CustomTabBar without duplication.
    * Renames ShouldShowLocationBar to ShouldShowToolbar
    * Renames UpdateLocationBarVisibility to UpdateToolbarVisibility
    
    Bug: 853593
    Change-Id: Ib303275f7d560cb67cc2e30767a7dbf2783da497
    Reviewed-on: https://chromium-review.googlesource.com/c/1328081
    Commit-Queue: Jay Harris <harrisjay@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Matt Giuca <mgiuca@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608274}

    Changed files

    • chrome/browser/ui/browser.cc
    • chrome/browser/ui/browser_window.h
    • chrome/browser/ui/extensions/hosted_app_browser_controller.cc
    • chrome/browser/ui/extensions/hosted_app_browser_controller.h
    • chrome/browser/ui/extensions/hosted_app_browsertest.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h
  10. Roll src/third_party/webrtc d575a2d43a2d..c25d23445748 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 05:38:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8745c7395bb84c1c5c02622b78f33b2872ee643b

    Comments

    Roll src/third_party/webrtc d575a2d43a2d..c25d23445748 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/d575a2d43a2d..c25d23445748
    
    
    git log d575a2d43a2d..c25d23445748 --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 srte@webrtc.org Adds OWNERS to api/transport.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@c25d23445748
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ic32c4a49597d57d252c5c595e315e019bab5f5bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1337269
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608273}

    Changed files

    • DEPS
  11. [Exp date fix flow] Disable Save Button When selecting expired expiration date

    Changed by Hao Zhang - hozhngohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 05:35:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 118efde1678c69ce77bf72ccd4198af2ad8a2300

    Comments

    [Exp date fix flow] Disable Save Button When selecting expired expiration date
    
    Bug: 899057
    Change-Id: I4d87ee3b3f12d0f76376976b0be0460b8b94c007
    Reviewed-on: https://chromium-review.googlesource.com/c/1334228
    Commit-Queue: Hao Zhang <hozhng@google.com>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608272}

    Changed files

    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
  12. cc: Fix flaky ImageController crash

    Changed by Adrienne Walker - enneohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:32:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0cd20e8caf2b90933e61bd511819312cebacd16

    Comments

    cc: Fix flaky ImageController crash
    
    If non-lazy tasks are queued but never executed, it would still try to
    unref them, causing a crash.  Add some tests to make sure that lazy and
    non-lazy images get unref'd (or not) appropriately and reenable the
    test.
    
    Bug: 902644,902022,905239
    Change-Id: I778d81aa390c1a529b7bfd88a2e146f245fb35e5
    Reviewed-on: https://chromium-review.googlesource.com/c/1324874
    Commit-Queue: enne <enne@chromium.org>
    Reviewed-by: Khushal <khushalsagar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608271}

    Changed files

    • cc/tiles/image_controller.cc
    • cc/tiles/image_controller_unittest.cc
    • cc/trees/layer_tree_host_unittest.cc
  13. Move crostini shared path state into background

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:31:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca6925d865869ef6b53108c30cd58d0f43d82e52

    Comments

    Move crostini shared path state into background
    
    Convert Crostini to a class, and move state into bg so that all
    FilesApp windows will have a consistent view of which paths are shared.
    
    Bug: 878324
    Change-Id: I3c21465b625091fd6360e6b799d9e85baf1ea614
    Reviewed-on: https://chromium-review.googlesource.com/c/1335747
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608270}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_jstest.cc
    • ui/file_manager/externs/background/crostini.js
    • ui/file_manager/externs/background/file_browser_background_full.js
    • ui/file_manager/externs/command_handler_deps.js
    • ui/file_manager/file_manager/background/js/BUILD.gn
    • ui/file_manager/file_manager/background/js/background.js
    • ui/file_manager/file_manager/background/js/background_scripts.js
    • ui/file_manager/file_manager/background/js/crostini.js
    • ui/file_manager/file_manager/background/js/crostini_unittest.js
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/crostini.js
    • ui/file_manager/file_manager/foreground/js/crostini_unittest.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
    • ui/file_manager/file_manager/foreground/js/file_tasks.js
    • ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
    • ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
    • ui/file_manager/file_manager/foreground/js/main_scripts.js
    • ui/file_manager/file_manager/foreground/js/task_controller.js
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
    • ui/file_manager/file_manager/test/BUILD.gn
    • ui/file_manager/file_manager/test/crostini_share.js
    • ui/file_manager/file_manager/test/js/externs.js
  14. FilesApp crostini: show dialog when sharing root folders

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:24:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bde2b01f89501bc654932d2dabe8a3c1ac0dbb85

    Comments

    FilesApp crostini: show dialog when sharing root folders
    
    When a user right-clicks and shares a root folder of a volume,
    a dialog is shown for the user to confirm the action.
    
    For Drive, the dialog with specific wording for Drive is shown
    for My Drive, Team Drives, and Computers.
    
    For other volumes, generic wording is used.
    
    Bug: 878324
    Change-Id: I92dad87c8e7b042dd45902d93e08e3cd66abc753
    Reviewed-on: https://chromium-review.googlesource.com/c/1337109
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608269}

    Changed files

    • chrome/app/file_manager_strings.grdp
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_ROOT_FOLDER_WITH_CROSTINI.png.sha1
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_ROOT_FOLDER_WITH_CROSTINI_DRIVE.png.sha1
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_SHARE_ROOT_FOLDER_WITH_CROSTINI_TITLE.png.sha1
    • chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
    • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
    • ui/file_manager/file_manager/test/crostini_share.js
  15. Revert "Remove remaining components/domain_reliability dependency on content/ and components/keyed_service."

    Changed by Kentaro Hara - harakenohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:15:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0dde16793a37c31a7093378258a2abfac3bb49f1

    Comments

    Revert "Remove remaining components/domain_reliability dependency on content/ and components/keyed_service."
    
    This reverts commit bd611e3e7daa6e4048f775a4db95f1045a800548.
    
    Reason for revert: It looks like this CL broke CFI bots:
    
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11301
    
    Original change's description:
    > Remove remaining components/domain_reliability dependency on content/ and components/keyed_service.
    > 
    > This way it can run in the network process, similar to Network Error Logging.
    > 
    > Bug: 853251
    > Change-Id: I403a5dcc3cae12b592a444c7e23f71c552b58e1f
    > Reviewed-on: https://chromium-review.googlesource.com/c/1334848
    > Reviewed-by: Misha Efimov <mef@chromium.org>
    > Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#608175}
    
    TBR=jam@chromium.org,mef@chromium.org
    
    Change-Id: I57829e413ad57ec667882069f77bf2d97faec4a3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 853251
    Reviewed-on: https://chromium-review.googlesource.com/c/1337215
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608268}

    Changed files

    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
    • chrome/browser/domain_reliability/service_factory.cc
    • chrome/browser/profiles/profile_impl.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/domain_reliability/BUILD.gn
    • components/domain_reliability/DEPS
    • components/domain_reliability/monitor.cc
    • components/domain_reliability/monitor.h
    • components/domain_reliability/monitor_unittest.cc
    • components/domain_reliability/service.cc
    • components/domain_reliability/service.h
    • components/domain_reliability/service_unittest.cc
  16. [ElementTiming] Remove a DCHECK for cached image

    Changed by Nicolas Pena - npmohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2043308746d0ecbd3d206eb6d144eb69556abc20

    Comments

    [ElementTiming] Remove a DCHECK for cached image
    
    Bug: 896024
    Change-Id: Ie4a0ba6a07c96557f0bfd464e523c0ad8d804c8e
    Reviewed-on: https://chromium-review.googlesource.com/c/1336431
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608267}

    Changed files

    • third_party/blink/renderer/core/paint/image_element_timing.cc
  17. [LayoutNG] Adjust BoxInfo::item_index when items are removed

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:12:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5b684d2cfabe74104622e5b241d7deac9b542fd

    Comments

    [LayoutNG] Adjust BoxInfo::item_index when items are removed
    
    When NGInlineItemsBuilder removed an item, it needs to adjust
    BoxInfo::item_index. This patch fixes it.
    
    This was revealed in crrev.com/c/1333588, tests will fail
    with the CL without this fix.
    
    Bug: 636993
    Change-Id: I7a996e358c0daa8e6c7aa1b5227e4027fe0295bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1337210
    Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608266}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_items_builder.cc
  18. Reland "Get NetworkChangeNotifier working on ChromeOS with network service."

    Changed by Robbie McElrath - rmcelrathohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:10:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 21f4d49913435d77666383128b62657b56e0bfb3

    Comments

    Reland "Get NetworkChangeNotifier working on ChromeOS with network service."
    
    This is identical to crrev.com/c/1329897, but the underlying issue that
    caused that CL to break unit tests was fixed in crrev.com/c/1336066.
    
    Original change's description:
    > Get NetworkChangeNotifier working on ChromeOS with network service.
    >
    > The current NetworkChangeNotifierChromeOS implementation won't work
    > with the network service enabled because it listens for network changes
    > from Shill, which only supports a single client. The browser process
    > has other dependencies on Shill, so it has to be the client for the time
    > being, meaning the network service can't directly listen for network
    > changes and has to be notified of them from the browser process.
    >
    > This CL splits the NetworkChangeNotifierChromeOS into two parts;
    > the first will live in the browser process and listen to Shill, while
    > the second is the actual NetworkChangeNotifierChromeOS implementation
    > which will have an instance in both the browser and network processes.
    > Since NetworkChangeNotifierChromeOS can't actually listen for network
    > changes itself, it just gets notified of changes from part 1 via a new
    > method in NetworkChangeManager. When the thing listening to Shill sees
    > a network change, it notifies its local NetworkChangeNotifierChromeOS
    > instance, and calls the new NetworkChangeManager method, the
    > implementation of which then notifies the network service's
    > NetworkChangeNotifierChromeOS instance.
    >
    > Bug: 882610
    > Cq-Include-Trybots: luci.chromium.try:linux_mojo
    > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274445
    > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606665}
    
    Bug: 882610
    Change-Id: I05ecbac510b479eb28520cc0b0ad5b613519fab7
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Reviewed-on: https://chromium-review.googlesource.com/c/1336154
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Paul Jensen <pauljensen@chromium.org>
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608265}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/chromeos/network_change_manager_client.cc
    • chrome/browser/chromeos/network_change_manager_client.h
    • chrome/browser/chromeos/network_change_manager_client_browsertest.cc
    • chrome/browser/chromeos/network_change_manager_client_unittest.cc
    • chrome/browser/net/network_context_configuration_browsertest.cc
    • chrome/test/BUILD.gn
    • chromeos/network/BUILD.gn
    • chromeos/network/managed_state.h
    • chromeos/network/network_change_notifier_chromeos.cc
    • chromeos/network/network_change_notifier_chromeos.h
    • chromeos/network/network_change_notifier_chromeos_unittest.cc
    • chromeos/network/network_change_notifier_factory_chromeos.cc
    • chromeos/network/network_change_notifier_factory_chromeos.h
    • chromeos/network/network_state.h
    • content/browser/browser_main_loop.h
    • content/browser/net_info_browsertest.cc
    • content/browser/network_service_instance.cc
    • content/public/browser/network_service_instance.h
    • content/public/test/browser_test_base.cc
    • net/BUILD.gn
    • net/base/network_change_notifier.cc
    • net/base/network_change_notifier_chromeos.cc
    • net/base/network_change_notifier_chromeos.h
    • net/base/network_change_notifier_chromeos_unittest.cc
    • services/network/network_change_manager.cc
    • services/network/network_change_manager.h
    • services/network/network_context_unittest.cc
    • services/network/network_service.cc
    • services/network/public/mojom/network_change_manager.mojom
    • testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
  19. Roll src/third_party/depot_tools 43a35d299bbc..91de11099dcd (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 05:08:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0de7e526fb15ae64006a88cea29a6eeca7d63d70

    Comments

    Roll src/third_party/depot_tools 43a35d299bbc..91de11099dcd (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43a35d299bbc..91de11099dcd
    
    
    git log 43a35d299bbc..91de11099dcd --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 yyanagisawa@chromium.org autoninja: fix shellcheck warnings
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@91de11099dcd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: I8f9333288bfebeeafe6100b3a59331110818b1d0
    Reviewed-on: https://chromium-review.googlesource.com/c/1337272
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608264}

    Changed files

    • DEPS
  20. Make fast/dom/Range/range-expand.html match its intention

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:08:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29ca362336b4e89e49000ed5e24f0e0ba983bb3b

    Comments

    Make fast/dom/Range/range-expand.html match its intention
    
    The layout test has a "multiline" test case which isn't really multiline,
    as the linebreak characters in HTML are turned into whitespaces.
    
    This patch changes the <p> element into <pre> so that the linebreak
    characters are really breaking text into lines, and the test case is a
    multiline test case.
    
    This patch is a preparation for changing StartOfSentence() to use
    TextOffsetMapping (crrev.com/c/1335959).
    
    Bug: 778507
    Change-Id: I77cd48eb13a1ff442e7ecbe1c71819055bccf078
    Reviewed-on: https://chromium-review.googlesource.com/c/1336785
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608263}

    Changed files

    • third_party/WebKit/LayoutTests/fast/dom/Range/range-expand.html
  21. Editing: Introduce two UseCounters for -webkit-user-modify and contenteditable.

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:07:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed9d8ec7a1e9bbb5e92c569a37f04d16c185a66a

    Comments

    Editing: Introduce two UseCounters for -webkit-user-modify and contenteditable.
    
    * kWebKitUserModifyEffective
     It counts if contenteditable content attribute value and
     -webkit-user-modify property value are mismatched.
    
    * kPlaintTextEditingEffective
     It counts if -webkit-user-modify:read-write-plaintext-only is effective
     or a user interact with an element with contenteditable=plaintext-only.
    
    The counters are triggered only in Element::IsFocusable().
     - Checking all elements costs too much.
     - If a user interacts with an element, IsFocusable() must be called.
      It's ok to ignore elements without user interaction. The behavior of
      such elements isn't important for web-site compatibility.
    
    Bug: 687843
    Change-Id: Idb7a9280e1f63c4ecdca0c4ce3298c3c9be715da
    Reviewed-on: https://chromium-review.googlesource.com/c/1335069
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608262}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/dom/element.cc
    • tools/metrics/histograms/enums.xml
  22. Update device UI mode and virtual keyboard when BT adapter changes.

    Changed by Xiaoqian Dai - xdaiohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 05:07:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f631084c451038189262f38bbc37cd05fc4c4fa9

    Comments

    Update device UI mode and virtual keyboard when BT adapter changes.
    
    It's a speculative fix for
    https://listnr.corp.google.com/product/5015361/report/85785278442. In
    the report, the reporter observed (from offline email):
    1. opened up my mewoth/brydge
    2. noticed that brydge kb wasn't working, checked quick settings menu
       and noticed bluetooth was missing
    3. tried to enter password but no virtual kb came up
    
    Since there is not a consistently repro way to repro this, my guess is
    the Bluetooth stack was broken somehow but Chrome didn't get notified.
    With this CL, the device should be able (hopefully) to enter the correct
    ui mode and have the virtual keyboard if Bluetooth stack is broken.
    
    Bug: None. See description
    Change-Id: Ic04a769c111f772211e99c25d187726b46429626
    Reviewed-on: https://chromium-review.googlesource.com/c/1337011
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608261}

    Changed files

    • ash/bluetooth_devices_observer.cc
    • ash/bluetooth_devices_observer.h
    • ash/keyboard/virtual_keyboard_controller.cc
    • ash/keyboard/virtual_keyboard_controller.h
    • ash/wm/tablet_mode/tablet_mode_controller.cc
    • ash/wm/tablet_mode/tablet_mode_controller.h
    • ash/wm/tablet_mode/tablet_mode_controller_unittest.cc