Home | Search | chromium - Builders
Login

Builder Windows deterministic Build 10717 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision82a862172a6cc54cc7389d099e6299c5c9db7488
Got Revision82a862172a6cc54cc7389d099e6299c5c9db7488

Execution:

Steps and Logfiles:

Show:
  1. ( 349 ms ) setup_build
    running recipe: "swarming/deterministic_build"
  2. ( 6 mins 1 secs ) bot_update
    [116GB/299GB used (38%)]
  3. ( 399 ms ) clobber
  4. ( 33 secs ) gclient runhooks
  5. ( 498 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  6. ( 3 mins 4 secs ) generate_build_files
  7. ( 17 mins 25 secs ) First build
  8. ( 1 mins 18 secs ) First build confirm no-op
  9. ( 9 mins 3 secs ) isolate tests
  10. ( 459 ms ) clobber (2)
  11. ( 41 secs ) gclient runhooks (2)
  12. ( 608 ms ) lookup GN args (2)
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  13. ( 3 mins 4 secs ) generate_build_files (2)
  14. ( 16 mins 54 secs ) Second build
  15. ( 1 mins 10 secs ) Second build confirm no-op
  16. ( 8 mins 57 secs ) isolate tests (2)
  17. ( 18 mins 36 secs ) compare_build_artifacts
  18. ( 1 mins 35 secs ) create tarball
  19. ( 8 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2173-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542251228356628, "id": "8929826091933624528", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/82a862172a6cc54cc7389d099e6299c5c9db7488", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/82a862172a6cc54cc7389d099e6299c5c9db7488", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095256153980940512", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Windows deterministic" setup_build
buildnumber 10717 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "swarming/deterministic_build" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "82a862172a6cc54cc7389d099e6299c5c9db7488" setup_build
got_angle_revision "1934b786149db8fa93a28f78e70908fc2abc1599" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "597e1587b4bfc7bf89895c7c879ae58b649da3c5" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "82a862172a6cc54cc7389d099e6299c5c9db7488" bot_update
got_revision_cp "refs/heads/master@{#608240}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "8117fe38b740829c47d86554a0264a392fc84957" bot_update
got_v8_revision_cp "refs/heads/7.2.337@{#1}" bot_update
got_webrtc_revision "83aa5ace99a52bbe85055d89ed6837930f8d1f2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25642}" bot_update
swarm_hashes {"accessibility_unittests": "2ef71ff5fe114fc024a6ae7ad854f46d4bcab173", "angle_end2end_tests": "d192a2eb011258ddba51edb3248d3bc9507bf36e", "angle_perftests": "b28ae6dfec75783e29732d821226e85a1fda74df", "angle_unittests": "f5fdf4734088987b481aa1824de4bf1b8154e472", "angle_white_box_tests": "ee0bf91de4981af042eea1040726586a2aec1c5a", "app_shell_unittests": "dd087483244ee4f5cd6241a2aa1c38dce6113fa9", "aura_unittests": "8e3d283b778f03f3248e500724b4213ee11417d1", "base_perftests": "1f05a5b2461a1d74ac7029226e48cdab7a4a99b5", "base_unittests": "44c613812a64baaee931bc7db2d341bd55e8bb31", "blink_common_unittests": "21142376a8b02e6b8ab87750348ba544e0ff8992", "blink_fuzzer_unittests": "8eacee3ed68befcb3d017a59da3b733584cfe918", "blink_heap_unittests": "d0680d34879d092be235a3d1172a7541c7fb09f5", "blink_platform_unittests": "45b42abf39e77e937efb55fbe4902c64c4705b26", "boringssl_crypto_tests": "76568ed33c9123a9d0b0d4ae9c441f07f8fb2cd2", "boringssl_ssl_tests": "cafec2eb9800f75e771de18114b83c471660d15a", "browser_tests": "964b5dea00e544230a9a8a9311c23abd7e65db84", "cacheinvalidation_unittests": "bea555180229f1c98c6db46d26d6642fb03121e8", "capture_unittests": "d69d685d2f88312b917214b6f5d3dd1f3f86ea99", "cast_unittests": "525f5606b116f7b9f838c8f2186abeaf82f4e831", "cc_unittests": "456096482c31612b9122bb30b44f937872460c36", "chrome_app_unittests": "df5e2328671a926bbaa35389b47b362b956760a5", "chrome_cleaner_unittests": "fbfe0917be731f8a7e84bc598d3b1348d5606785", "chrome_elf_import_unittests": "11c0a892cf747226607fe41194e192f9a184611f", "chrome_elf_unittests": "9414d04d2431ecee09103df6d28b177bd4d87a7a", "chromedriver_py_tests": "05c60aff018d87761a0f943dbc3f0d36d28342a0", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "3eb69cb64d3f3cba7841c544dc18fb9698eb90cc", "command_buffer_perftests": "7e1d28a828321d49b312a0c563fdeb88d2531666", "components_browsertests": "f40f850dd3a2074266116bfb45e632d54ce4cbee", "components_perftests": "a624763207309ab29c700e4b2ebc3fdcf413d0d3", "components_unittests": "b95d1ac9a478b84766e1eac3975d34a8c907ccae", "compositor_unittests": "2b4e88774babfce73a4ba6f05f6cfa73d678ca49", "content_browsertests": "e225d24fe2f3ab20d2f8e4d167e50d02e44621d2", "content_shell_crash_test": "ed3cafdb2110a6f77b34ff0a9ca7da9afa6d9863", "content_unittests": "516c87c059326b39a9aec7d39f6ecb07c2c8719a", "courgette_unittests": "c9ce17b272a7418961b987cc4efe180f0990ea23", "crashpad_tests": "7340dc066971b9ebf934062dd979fa4b27059f50", "cronet_tests": "7a4c088d7af4bd5288ac237d32b54a0317774d9b", "cronet_unittests": "a4bc30857614cf157e49bc313debb18e6426baf9", "crypto_unittests": "c3e6ecaa4ebc7a3e7be93b24379e640dc3525508", "dawn_end2end_tests": "1620e478feece7dcd63410d20598c76b8440b9aa", "device_unittests": "5a41b28c1092500ab9518770789380dbd8fba9d6", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "66057526e3dc2c9d9d7f9e7d5e9af45f7addddef", "elevation_service_unittests": "782863a319387b0a14fcc16e81fb08e5ab89f379", "events_unittests": "2b01ba65fc8be0f34480047df20e19e85c1b8c97", "extensions_browsertests": "d10a852d6d8dbb13eded2b44a164c0fc7a3659e7", "extensions_unittests": "08fe0c94ec2efeadc082353c905ece4e4497b0cc", "filesystem_service_unittests": "eecfa1dbec795a9c1178d06946fd38ea420cb6b8", "gcm_unit_tests": "196ab03d2725a8c4e383bc0f90845f931846cb1e", "gcp_unittests": "d8163acc23550c89ea335be5c3d21ff28529de37", "gfx_unittests": "25c698ca03c7db9b8db7e579f438b2e36aaeb60c", "gin_unittests": "3faf81a5db6919c4992d9b563e9f7aa482aa13f1", "gl_tests": "cc4383e2893d14ff641bea445af6efe2e8dea168", "gl_unittests": "7ac486753d1d9f01860a05f4b4d853271806961f", "gl_unittests_ozone": "7ac486753d1d9f01860a05f4b4d853271806961f", "gles2_conform_test": "f378ee5837dcfde7004bd2135086dc31392e81fb", "google_apis_unittests": "9a283f719667303d0511887a43cb7cb94bde9d1f", "gpu_perftests": "0f0b23a029df4bd67aec141b013e1da5a85cd148", "gpu_unittests": "96af10957fe2a3379e816ef20e217c4247a3a1de", "headless_browsertests": "821cbfd5511c29fbe627deb182a59f21620a1d81", "headless_unittests": "c70626563890b4f207654106f8bba5925bd22bda", "install_static_unittests": "ca7988b5df9593a9950f2a8378b75ab9af8c5dc2", "installer_util_unittests": "d842c63857c7fbdbe45e91c024676e4ac17d02ed", "interactive_ui_tests": "cf63c4b5eb6943b91d62c5a996183b1059f3cbaa", "ipc_tests": "48c5f83ec10e56de992ba28460cee4bfc69c849a", "jingle_unittests": "92ee0b4176653a217ae8ea35276973ca9353b919", "latency_unittests": "e804d812e5df68d9b3c1d3490d73e57e16bc8013", "leveldb_service_unittests": "ce07cab1672abfb23d3d70da141d28a952ae7a24", "libjingle_xmpp_unittests": "c0b23fe1cdf35f46e4df385935f87eff74f8f425", "load_library_perf_tests": "cb53723571faf447189e402698a3a0d7d06956e0", "media_blink_unittests": "d687d50474614b0c5acb90431f72aa40f7226117", "media_perftests": "c427239d3512b98ae443984929c76d0330e3b08b", "media_service_unittests": "6bd0437a64f8f0593f98cd008732eb698fbba91d", "media_unittests": "d6e2b825cc4c2164b544bc3203c41a2760c9ce78", "message_center_unittests": "9da2fa134522b2345b43e2d90583686db4e204de", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "0a9db1b8c9747d09b614ad380b5b0f9c7d89995d", "mini_installer_tests": "9e6c8e648451e3900462b611ca236cc543b1a5a7", "mojo_core_unittests": "1602f5f157954fdf4cff147d70535bc77ed58913", "mojo_unittests": "a3ce88f38b72c20f5da5433c6cfd81bd3bac7aab", "nacl_loader_unittests": "06e81f142d2dc76842fccb77817e4b616fac9917", "native_theme_unittests": "c653f721425f18fef9b76684041ce822f248cad9", "net_perftests": "b32924d374b8af74d1efdd8d8c492cd8e8f5ebee", "net_unittests": "7d752ec505eb25f0bf253614d94771e372f33fe6", "notification_helper_unittests": "443a4fbecc8cd5b86076c35004e586efa601a8e5", "pdf_unittests": "904eaafc13b06851f5b008a926827fd3ec5a8399", "performance_browser_tests": "0ebbc3a3018cca9cad1d274e82f440765252f91a", "performance_test_suite": "64668a0636a79f810dedaf46dc9c9969fe769de6", "performance_webview_test_suite": "f9b0a0be23c4dbe11691658fa9e6fe962ed6c6ed", "ppapi_unittests": "3b26163b0910f5e2602fd369a946e22ec5bc8454", "printing_unittests": "b3f80bee2ffbc2a5edb3a4945f2360f5200929ea", "remoting_unittests": "9234420a2b875f72634e57218224320d8a3f473b", "sbox_integration_tests": "e4f1ce9cd4c7c1f7deb720aef425f2f4a808a6e8", "sbox_unittests": "9daf082365ff34c0aacd486c989a69a5889a8129", "sbox_validation_tests": "dc3fbf610be7de3ae0d35f33ce98811cb1aecbad", "service_manager_unittests": "7882618ed5172773bba0fd4fc625be4bf3e91267", "services_unittests": "f59b5a8ad12cd7a3510093def504a95368c032f0", "setup_unittests": "e30920dcfafd99fa8995b2e1111188af7568626d", "shell_dialogs_unittests": "6652e4d278daf109dc609d6570c9eb48856448ac", "skia_unittests": "d2aa1e5c2bd419b5acacfb41c68501f026536713", "snapshot_unittests": "dc93601ff68fbe24f7f83341f0f873a729ab5d00", "sql_unittests": "2646698ab94d873f6a2b567e91fb919e8119f639", "storage_unittests": "2f6175ffd662fd68493ef4b0566befe3456180d7", "swiftshader_unittests": "093d7fa044ee7fc11baf167a361cdc7fa5e5d0ca", "sync_integration_tests": "8cff655331b5f81500e6b463d3352fadf1abeff1", "telemetry_gpu_integration_test": "c26511edade9180a939ef2fe516ecde8fcb2f336", "telemetry_gpu_unittests": "cd272018b653f964247ea7036e9cdfb73c4d8960", "telemetry_perf_tests_without_chrome": "fcf0372dcf3894aa6336d3e78d002bab1254a2cf", "telemetry_perf_unittests": "88d775df4bb1646e12936132b78a7e40339d66ed", "telemetry_unittests": "eec23f23ae763509bb6cccee82287d3b9ed20589", "tracing_perftests": "63d6ccd1cbe5595664253f77810ba0e6fd53375f", "traffic_annotation_auditor_unittests": "655f206df1dce06d491b3ff8b7dadaeb0ce7122b", "ui_base_unittests": "2c229c46012b0e4a4e3ada2194c7ba507464299c", "ui_touch_selection_unittests": "7d1cb36c48685e5a2878bb8b8b5cccd4505895b9", "unit_tests": "11432b0196c4e93919d20c3f30c699e9a8f41c9a", "url_unittests": "73d8c42033b15be1a7721ed6603ea013042d2b30", "video_decode_accelerator_unittest": "aa4af007d9fbb64802b91ae3e836e5e30331d568", "views_mus_interactive_ui_tests": "97c96a306d2ad0b0df49ea36400333d042c76852", "views_mus_unittests": "8e3916d317689ae42c8de42b61de25f74daa12db", "views_perftests": "5271f03d5a4aa7f809e1236bffebfb7090738567", "views_unittests": "4329652fee6cc8ff2f18f68d56bd93e5a7fd4854", "viz_unittests": "b3014b40c8b38ade94303fc2de98f6f9b207606d", "vr_common_perftests": "41d7cc468a488d3da11502f9a3d79a539d276860", "vr_common_unittests": "5580223932871bd559051cb2892150949ec81d04", "vr_pixeltests": "d5a3f58a966d5d553e07abf13701eca8c4759305", "webkit_layout_tests": "08d9a81a822a2f14ab518d49e4032e9df46250f4", "webkit_layout_tests_exparchive": "32449dc63d219b31282273c9381e0c53da5e3d7c", "webkit_python_tests": "ae37fa979716d2f661be3cb058168af26a2f1d9e", "webkit_unit_tests": "05c3fb35c26537b344dc5d0f20e33ad6493a7088", "wm_unittests": "851b3d4bf4e36724c6a09ffb088f254bf4701a8e", "wtf_unittests": "3cee23b944740adb407dea6aeac94eae55cb15ce", "zucchini_unittests": "9cc855c002caac073bce36bb504df45594346507"} isolate tests
swarm_hashes {"accessibility_unittests": "2ef71ff5fe114fc024a6ae7ad854f46d4bcab173", "angle_end2end_tests": "d192a2eb011258ddba51edb3248d3bc9507bf36e", "angle_perftests": "b28ae6dfec75783e29732d821226e85a1fda74df", "angle_unittests": "f5fdf4734088987b481aa1824de4bf1b8154e472", "angle_white_box_tests": "ee0bf91de4981af042eea1040726586a2aec1c5a", "app_shell_unittests": "dd087483244ee4f5cd6241a2aa1c38dce6113fa9", "aura_unittests": "8e3d283b778f03f3248e500724b4213ee11417d1", "base_perftests": "1f05a5b2461a1d74ac7029226e48cdab7a4a99b5", "base_unittests": "44c613812a64baaee931bc7db2d341bd55e8bb31", "blink_common_unittests": "21142376a8b02e6b8ab87750348ba544e0ff8992", "blink_fuzzer_unittests": "8eacee3ed68befcb3d017a59da3b733584cfe918", "blink_heap_unittests": "d0680d34879d092be235a3d1172a7541c7fb09f5", "blink_platform_unittests": "45b42abf39e77e937efb55fbe4902c64c4705b26", "boringssl_crypto_tests": "76568ed33c9123a9d0b0d4ae9c441f07f8fb2cd2", "boringssl_ssl_tests": "cafec2eb9800f75e771de18114b83c471660d15a", "browser_tests": "964b5dea00e544230a9a8a9311c23abd7e65db84", "cacheinvalidation_unittests": "bea555180229f1c98c6db46d26d6642fb03121e8", "capture_unittests": "d69d685d2f88312b917214b6f5d3dd1f3f86ea99", "cast_unittests": "525f5606b116f7b9f838c8f2186abeaf82f4e831", "cc_unittests": "456096482c31612b9122bb30b44f937872460c36", "chrome_app_unittests": "df5e2328671a926bbaa35389b47b362b956760a5", "chrome_cleaner_unittests": "fbfe0917be731f8a7e84bc598d3b1348d5606785", "chrome_elf_import_unittests": "11c0a892cf747226607fe41194e192f9a184611f", "chrome_elf_unittests": "9414d04d2431ecee09103df6d28b177bd4d87a7a", "chromedriver_py_tests": "05c60aff018d87761a0f943dbc3f0d36d28342a0", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "3eb69cb64d3f3cba7841c544dc18fb9698eb90cc", "command_buffer_perftests": "7e1d28a828321d49b312a0c563fdeb88d2531666", "components_browsertests": "f40f850dd3a2074266116bfb45e632d54ce4cbee", "components_perftests": "a624763207309ab29c700e4b2ebc3fdcf413d0d3", "components_unittests": "b95d1ac9a478b84766e1eac3975d34a8c907ccae", "compositor_unittests": "2b4e88774babfce73a4ba6f05f6cfa73d678ca49", "content_browsertests": "e225d24fe2f3ab20d2f8e4d167e50d02e44621d2", "content_shell_crash_test": "ed3cafdb2110a6f77b34ff0a9ca7da9afa6d9863", "content_unittests": "516c87c059326b39a9aec7d39f6ecb07c2c8719a", "courgette_unittests": "c9ce17b272a7418961b987cc4efe180f0990ea23", "crashpad_tests": "7340dc066971b9ebf934062dd979fa4b27059f50", "cronet_tests": "7a4c088d7af4bd5288ac237d32b54a0317774d9b", "cronet_unittests": "a4bc30857614cf157e49bc313debb18e6426baf9", "crypto_unittests": "c3e6ecaa4ebc7a3e7be93b24379e640dc3525508", "dawn_end2end_tests": "1620e478feece7dcd63410d20598c76b8440b9aa", "device_unittests": "5a41b28c1092500ab9518770789380dbd8fba9d6", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "66057526e3dc2c9d9d7f9e7d5e9af45f7addddef", "elevation_service_unittests": "782863a319387b0a14fcc16e81fb08e5ab89f379", "events_unittests": "2b01ba65fc8be0f34480047df20e19e85c1b8c97", "extensions_browsertests": "d10a852d6d8dbb13eded2b44a164c0fc7a3659e7", "extensions_unittests": "08fe0c94ec2efeadc082353c905ece4e4497b0cc", "filesystem_service_unittests": "eecfa1dbec795a9c1178d06946fd38ea420cb6b8", "gcm_unit_tests": "196ab03d2725a8c4e383bc0f90845f931846cb1e", "gcp_unittests": "d8163acc23550c89ea335be5c3d21ff28529de37", "gfx_unittests": "25c698ca03c7db9b8db7e579f438b2e36aaeb60c", "gin_unittests": "3faf81a5db6919c4992d9b563e9f7aa482aa13f1", "gl_tests": "cc4383e2893d14ff641bea445af6efe2e8dea168", "gl_unittests": "7ac486753d1d9f01860a05f4b4d853271806961f", "gl_unittests_ozone": "7ac486753d1d9f01860a05f4b4d853271806961f", "gles2_conform_test": "f378ee5837dcfde7004bd2135086dc31392e81fb", "google_apis_unittests": "9a283f719667303d0511887a43cb7cb94bde9d1f", "gpu_perftests": "0f0b23a029df4bd67aec141b013e1da5a85cd148", "gpu_unittests": "96af10957fe2a3379e816ef20e217c4247a3a1de", "headless_browsertests": "821cbfd5511c29fbe627deb182a59f21620a1d81", "headless_unittests": "c70626563890b4f207654106f8bba5925bd22bda", "install_static_unittests": "ca7988b5df9593a9950f2a8378b75ab9af8c5dc2", "installer_util_unittests": "d842c63857c7fbdbe45e91c024676e4ac17d02ed", "interactive_ui_tests": "cf63c4b5eb6943b91d62c5a996183b1059f3cbaa", "ipc_tests": "48c5f83ec10e56de992ba28460cee4bfc69c849a", "jingle_unittests": "92ee0b4176653a217ae8ea35276973ca9353b919", "latency_unittests": "e804d812e5df68d9b3c1d3490d73e57e16bc8013", "leveldb_service_unittests": "ce07cab1672abfb23d3d70da141d28a952ae7a24", "libjingle_xmpp_unittests": "c0b23fe1cdf35f46e4df385935f87eff74f8f425", "load_library_perf_tests": "cb53723571faf447189e402698a3a0d7d06956e0", "media_blink_unittests": "d687d50474614b0c5acb90431f72aa40f7226117", "media_perftests": "c427239d3512b98ae443984929c76d0330e3b08b", "media_service_unittests": "6bd0437a64f8f0593f98cd008732eb698fbba91d", "media_unittests": "d6e2b825cc4c2164b544bc3203c41a2760c9ce78", "message_center_unittests": "9da2fa134522b2345b43e2d90583686db4e204de", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "0a9db1b8c9747d09b614ad380b5b0f9c7d89995d", "mini_installer_tests": "54d6eff0896bb1e2928f4ddaa25faa7f9484dd8f", "mojo_core_unittests": "1602f5f157954fdf4cff147d70535bc77ed58913", "mojo_unittests": "a3ce88f38b72c20f5da5433c6cfd81bd3bac7aab", "nacl_loader_unittests": "06e81f142d2dc76842fccb77817e4b616fac9917", "native_theme_unittests": "c653f721425f18fef9b76684041ce822f248cad9", "net_perftests": "b32924d374b8af74d1efdd8d8c492cd8e8f5ebee", "net_unittests": "7d752ec505eb25f0bf253614d94771e372f33fe6", "notification_helper_unittests": "443a4fbecc8cd5b86076c35004e586efa601a8e5", "pdf_unittests": "904eaafc13b06851f5b008a926827fd3ec5a8399", "performance_browser_tests": "0ebbc3a3018cca9cad1d274e82f440765252f91a", "performance_test_suite": "64668a0636a79f810dedaf46dc9c9969fe769de6", "performance_webview_test_suite": "f9b0a0be23c4dbe11691658fa9e6fe962ed6c6ed", "ppapi_unittests": "3b26163b0910f5e2602fd369a946e22ec5bc8454", "printing_unittests": "b3f80bee2ffbc2a5edb3a4945f2360f5200929ea", "remoting_unittests": "9234420a2b875f72634e57218224320d8a3f473b", "sbox_integration_tests": "e4f1ce9cd4c7c1f7deb720aef425f2f4a808a6e8", "sbox_unittests": "9daf082365ff34c0aacd486c989a69a5889a8129", "sbox_validation_tests": "dc3fbf610be7de3ae0d35f33ce98811cb1aecbad", "service_manager_unittests": "7882618ed5172773bba0fd4fc625be4bf3e91267", "services_unittests": "f59b5a8ad12cd7a3510093def504a95368c032f0", "setup_unittests": "e30920dcfafd99fa8995b2e1111188af7568626d", "shell_dialogs_unittests": "6652e4d278daf109dc609d6570c9eb48856448ac", "skia_unittests": "d2aa1e5c2bd419b5acacfb41c68501f026536713", "snapshot_unittests": "dc93601ff68fbe24f7f83341f0f873a729ab5d00", "sql_unittests": "2646698ab94d873f6a2b567e91fb919e8119f639", "storage_unittests": "2f6175ffd662fd68493ef4b0566befe3456180d7", "swiftshader_unittests": "093d7fa044ee7fc11baf167a361cdc7fa5e5d0ca", "sync_integration_tests": "8cff655331b5f81500e6b463d3352fadf1abeff1", "telemetry_gpu_integration_test": "c26511edade9180a939ef2fe516ecde8fcb2f336", "telemetry_gpu_unittests": "cd272018b653f964247ea7036e9cdfb73c4d8960", "telemetry_perf_tests_without_chrome": "fcf0372dcf3894aa6336d3e78d002bab1254a2cf", "telemetry_perf_unittests": "88d775df4bb1646e12936132b78a7e40339d66ed", "telemetry_unittests": "eec23f23ae763509bb6cccee82287d3b9ed20589", "tracing_perftests": "63d6ccd1cbe5595664253f77810ba0e6fd53375f", "traffic_annotation_auditor_unittests": "655f206df1dce06d491b3ff8b7dadaeb0ce7122b", "ui_base_unittests": "2c229c46012b0e4a4e3ada2194c7ba507464299c", "ui_touch_selection_unittests": "7d1cb36c48685e5a2878bb8b8b5cccd4505895b9", "unit_tests": "11432b0196c4e93919d20c3f30c699e9a8f41c9a", "url_unittests": "73d8c42033b15be1a7721ed6603ea013042d2b30", "video_decode_accelerator_unittest": "aa4af007d9fbb64802b91ae3e836e5e30331d568", "views_mus_interactive_ui_tests": "97c96a306d2ad0b0df49ea36400333d042c76852", "views_mus_unittests": "8e3916d317689ae42c8de42b61de25f74daa12db", "views_perftests": "5271f03d5a4aa7f809e1236bffebfb7090738567", "views_unittests": "4329652fee6cc8ff2f18f68d56bd93e5a7fd4854", "viz_unittests": "b3014b40c8b38ade94303fc2de98f6f9b207606d", "vr_common_perftests": "41d7cc468a488d3da11502f9a3d79a539d276860", "vr_common_unittests": "5580223932871bd559051cb2892150949ec81d04", "vr_pixeltests": "d5a3f58a966d5d553e07abf13701eca8c4759305", "webkit_layout_tests": "08d9a81a822a2f14ab518d49e4032e9df46250f4", "webkit_layout_tests_exparchive": "32449dc63d219b31282273c9381e0c53da5e3d7c", "webkit_python_tests": "ae37fa979716d2f661be3cb058168af26a2f1d9e", "webkit_unit_tests": "05c3fb35c26537b344dc5d0f20e33ad6493a7088", "wm_unittests": "851b3d4bf4e36724c6a09ffb088f254bf4701a8e", "wtf_unittests": "3cee23b944740adb407dea6aeac94eae55cb15ce", "zucchini_unittests": "9cc855c002caac073bce36bb504df45594346507"} isolate tests (2)

Blamelist:

  1. David Tseng (dtsengohnoyoudont@chromium.org)
  2. Stuart Langley (slangleyohnoyoudont@google.com)
  3. Hitoshi Yoshida (periaohnoyoudont@chromium.org)
  4. Sergey Berezin (sergeyberezinohnoyoudont@google.com)
  5. Bence Béky (bncohnoyoudont@chromium.org)
  6. Sadrul Habib Chowdhury (sadrulohnoyoudont@chromium.org)
  7. Zhuoyu Qian (zhuoyu.qianohnoyoudont@samsung.com)
  8. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. David Black (dmblackohnoyoudont@google.com)
  10. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  11. Tony de Luna (tonydelunaohnoyoudont@chromium.org)
  12. Shu Chen (shuchenohnoyoudont@google.com)
  13. Shawn Gallea (sagalleaohnoyoudont@google.com)
  14. James Hollyer (jameshollyerohnoyoudont@chromium.org)
  15. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  16. David Black (dmblackohnoyoudont@google.com)
  17. dpapad (dpapadohnoyoudont@chromium.org)
  18. Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
  19. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  20. Lei Zhang (thestigohnoyoudont@chromium.org)
  21. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  22. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  23. Eric Roman (eromanohnoyoudont@chromium.org)
  24. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  25. Noel Gordon (noelohnoyoudont@chromium.org)
  26. Lei Zhang (thestigohnoyoudont@chromium.org)
  27. Charlie Harrison (csharrisonohnoyoudont@chromium.org)
  28. Michael Giuffrida (michaelpgohnoyoudont@chromium.org)
  29. Sunny Sachanandani (sunnypsohnoyoudont@chromium.org)
  30. Shawn Gallea (sagalleaohnoyoudont@google.com)
  31. Nate Fischer (ntfschrohnoyoudont@chromium.org)
  32. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  33. khmel@chromium.org (khmelohnoyoudont@chromium.org)

Timing:

Create Thursday, 15-Nov-18 03:07:08 UTC
Start Thursday, 15-Nov-18 03:07:11 UTC
End Thursday, 15-Nov-18 05:00:04 UTC
Pending 3 secs
Execution 1 hrs 52 mins

All Changes:

  1. BTBrl: adds manager class to interact with bluetooth braille

    Changed by David Tseng - dtsengohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 03:06:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82a862172a6cc54cc7389d099e6299c5c9db7488

    Comments

    BTBrl: adds manager class to interact with bluetooth braille
    
    This changes does the bulk of the work to stitch together all of the public surface a UI component needs to expose a list of braille displays:
    - connect/disconnect/forget operations
    - device change, pincode request notifications
    - finish pairing response
    - management of a single preferred display connection
    
    ChromeVox will keep an explicit list of braille display device names. This appears to be the same strategy used by all other clients of Brltty, including NVDA, and BrailleBack.
    This list is currently not complete, during the initial phase of this feature.
    
    Bug: 882261
    Test: new test suite added. Manually tested.
    Change-Id: I033c6ce6425421db26ad04a1af8f04a04a9e8a47
    Reviewed-on: https://chromium-review.googlesource.com/c/1335946
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608240}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/BUILD.gn
    • chrome/browser/resources/chromeos/chromevox/braille/bluetooth_braille_display_manager.js
    • chrome/browser/resources/chromeos/chromevox/braille/bluetooth_braille_display_manager_test.unitjs
    • chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
    • chrome/browser/resources/chromeos/chromevox/host/chrome/externs.js
    • chrome/browser/resources/chromeos/chromevox/testing/assert_additions.js
    • third_party/closure_compiler/externs/chrome_extensions.js
  2. Reduce and smooth traffic on drive back ends when requesting change lists.

    Changed by Stuart Langley - slangleyohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 03:03:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6477fb06bb932b0d1806f6ba6e8639d204cf3906

    Comments

    Reduce and smooth traffic on drive back ends when requesting change lists.
    
    As requested by Drive SRE these changes reduce the frequency of requests on the
    drive back ends, and also lessens the likelihood of convoying.
    
    1. When XMPP is connected, change the poll timeout for changes from 5 minutes to
       between 60 & 120 minutes.
    2. When XMPP is disconnected, change the poll timeout for changes from 1 minute
       to between 1 and 2 minutes. This issues start page token requests which are
       cheap for the drive back ends.
    3. When batching XMPP notifications, change the batch time from 5 seconds to
       between 15 and 30 seconds. This reduces the QPS on drive back ends when a
       team drive change notification is broadcast to a large corpus of users, and
       prevents convoying of requests by introducing jitter.
    
    Bug: 905201
    Change-Id: I5310d956c9ccb5b59261cdf99bbefb515f75771f
    Reviewed-on: https://chromium-review.googlesource.com/c/1336949
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Commit-Queue: Stuart Langley <slangley@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608239}

    Changed files

    • components/drive/drive_notification_manager.cc
    • components/drive/drive_notification_manager.h
    • components/drive/drive_notification_manager_unittest.cc
  3. IDL Compiler: Accept ', ' to split Exposed values

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 02:59:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13f7b176e1e45569f9cb96454bfd5ee676810355

    Comments

    IDL Compiler: Accept ', ' to split Exposed values
    
    IDL compiler did not work for cases that have multiple
    values separated with ', '.
    For example, we couldn't specify "Exposed=(Window, Worker)".
    
    This CL fixes for Exposed cases, thus we will be possible to
    use "Expose=(Window, Worker)".
    This change works only for Expose attributes, because it is
    handled separately, and it would be a huge change if we work
    for general cases.
    
    
    Bug: 904326
    Change-Id: I33bc09d96c1dd1afdd29850300add30687fa9d3b
    Reviewed-on: https://chromium-review.googlesource.com/c/1331292
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608238}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt
    • third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
    • third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
    • third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
    • third_party/blink/renderer/bindings/scripts/compute_global_objects.py
    • third_party/blink/renderer/bindings/scripts/generate_global_constructors.py
    • third_party/blink/renderer/bindings/scripts/utilities.py
  4. Fix hash for luci-go client

    Changed by Sergey Berezin - sergeyberezinohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 02:58:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17a0c94ffb0faa9df24d34f2b47ed6ed187ba9fb

    Comments

    Fix hash for luci-go client
    
    A previous luci-go roll was introduced in https://crrev.com/c/1333093
    but that git_revision hash doesn't exist for all packages.
    
    Bug: 905218
    Change-Id: Iad06836b7c1b6fa3c511eb7eaa70d52068d8d64b
    Reviewed-on: https://chromium-review.googlesource.com/c/1336909
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608237}

    Changed files

    • DEPS
  5. Add CHECK to help investigate crash.

    Changed by Bence Béky - bncohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 02:56:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 52c6e18b3def62dc869278acbd2734e147cc0bea

    Comments

    Add CHECK to help investigate crash.
    
    Bug: 461981
    Change-Id: I2e58d90f9f9e2a983286fbec9742234838fbbf50
    Reviewed-on: https://chromium-review.googlesource.com/c/1335951
    Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
    Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608236}

    Changed files

    • net/http/http_stream_factory_job_controller.cc
  6. Reland "viz: Include presentation-feedback with begin-frame."

    Changed by Sadrul Habib Chowdhury - sadrulohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 02:51:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ef6d91f2490997c2e32ab0dff50c556fc2e51d7

    Comments

    Reland "viz: Include presentation-feedback with begin-frame."
    
    This reverts commit 68dbb3a45c940c5a39ec8d3b4ce3c2f6b86a5554.
    
    Original commit message
    =======================
    Instead of sending the presentation-feedback over a separate IPC,
    include it with the begin-frame messages. The presentation feedback
    can be requested for each frame. So this can reduce an extra IPC
    per frame for each client.
    
    TBR=flackr@chromium.org,boliu@chromium.org,tsepez@chromium.org,piman@chromium.org
    tbr'ing since this is a reland with a trivial build fix.
    
    Bug: 883592
    Change-Id: Ia017b14f79eb06b247a9a75a395e4e1d4b51c1db
    Reviewed-on: https://chromium-review.googlesource.com/c/1336989
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608235}

    Changed files

    • android_webview/browser/hardware_renderer.cc
    • android_webview/browser/hardware_renderer.h
    • android_webview/browser/surfaces_instance.cc
    • android_webview/browser/surfaces_instance.h
    • cc/mojo_embedder/async_layer_tree_frame_sink.cc
    • cc/mojo_embedder/async_layer_tree_frame_sink.h
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_impl.cc
    • components/viz/service/display/display_unittest.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.h
    • components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
    • components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
    • components/viz/service/surfaces/surface_unittest.cc
    • components/viz/test/fake_compositor_frame_sink_client.cc
    • components/viz/test/fake_compositor_frame_sink_client.h
    • components/viz/test/mock_compositor_frame_sink_client.h
    • components/viz/test/test_layer_tree_frame_sink.cc
    • components/viz/test/test_layer_tree_frame_sink.h
    • content/browser/renderer_host/delegated_frame_host.cc
    • content/browser/renderer_host/delegated_frame_host.h
    • content/browser/renderer_host/delegated_frame_host_client_android.cc
    • content/browser/renderer_host/delegated_frame_host_client_android.h
    • content/browser/renderer_host/render_widget_host_view_android.cc
    • content/browser/renderer_host/render_widget_host_view_android.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
    • content/renderer/android/synchronous_layer_tree_frame_sink.cc
    • content/renderer/android/synchronous_layer_tree_frame_sink.h
    • content/test/fake_renderer_compositor_frame_sink.h
    • services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
    • third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
    • third_party/blink/renderer/platform/graphics/begin_frame_provider.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.h
    • third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
    • ui/android/delegated_frame_host_android.cc
    • ui/android/delegated_frame_host_android.h
    • ui/android/delegated_frame_host_android_unittest.cc
  7. Move build/scripts/{ => core/css}/make_css_property_names.py

    Changed by Zhuoyu Qian - zhuoyu.qianohnoyoudont@samsung.com
    Changed at Thursday, 15-Nov-18 02:37:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b189a621380cdf6dfa9c23e20eb5809db5224a33

    Comments

    Move build/scripts/{ => core/css}/make_css_property_names.py
    
    Move:
      build/scripts/{ => core/css}/make_css_property_names.py
      build/scripts/{ => core/css}/templates/css_property_names.h.tmpl
      build/scripts/{ => core/css}/templates/css_property_names.cc.tmpl
    
    This CL has no behavior changes.
    
    Bug: 732657
    Change-Id: I267ff9cf0824109aebb7c1f791172b481ae4e0fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1334995
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#608234}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_object_parser.h
    • third_party/blink/renderer/build/scripts/core/css/make_css_property_names.py
    • third_party/blink/renderer/build/scripts/core/css/parser/templates/at_rule_descriptors.h.tmpl
    • third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property.h.tmpl
    • third_party/blink/renderer/build/scripts/core/css/properties/templates/css_unresolved_property.h.tmpl
    • third_party/blink/renderer/build/scripts/core/css/templates/css_property_names.cc.tmpl
    • third_party/blink/renderer/build/scripts/core/css/templates/css_property_names.h.tmpl
    • third_party/blink/renderer/build/scripts/core/css/templates/style_property_shorthand.h.tmpl
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/animation/animation.h
    • third_party/blink/renderer/core/animation/animation_input_helpers.h
    • third_party/blink/renderer/core/animation/color_property_functions.h
    • third_party/blink/renderer/core/animation/css/css_animatable_value_factory.h
    • third_party/blink/renderer/core/animation/css/css_transition_data.h
    • third_party/blink/renderer/core/animation/css_basic_shape_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_border_image_length_box_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_filter_list_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_image_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_paint_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_shadow_list_interpolation_type.cc
    • third_party/blink/renderer/core/animation/document_animations.h
    • third_party/blink/renderer/core/animation/effect_model.h
    • third_party/blink/renderer/core/animation/image_list_property_functions.h
    • third_party/blink/renderer/core/animation/image_slice_property_functions.h
    • third_party/blink/renderer/core/animation/length_list_property_functions.h
    • third_party/blink/renderer/core/animation/length_property_functions.h
    • third_party/blink/renderer/core/animation/number_property_functions.h
    • third_party/blink/renderer/core/animation/property_handle.h
    • third_party/blink/renderer/core/animation/size_list_property_functions.h
    • third_party/blink/renderer/core/css/css_computed_style_declaration.cc
    • third_party/blink/renderer/core/css/css_custom_ident_value.h
    • third_party/blink/renderer/core/css/css_paint_image_generator.h
    • third_party/blink/renderer/core/css/css_pending_substitution_value.h
    • third_party/blink/renderer/core/css/css_primitive_value.h
    • third_party/blink/renderer/core/css/css_property_equality.h
    • third_party/blink/renderer/core/css/css_property_id_templates.h
    • third_party/blink/renderer/core/css/css_property_name.h
    • third_party/blink/renderer/core/css/css_property_value.h
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/css_style_declaration.cc
    • third_party/blink/renderer/core/css/css_style_declaration.h
    • third_party/blink/renderer/core/css/css_value_pool.h
    • third_party/blink/renderer/core/css/cssom/css_style_value.h
    • third_party/blink/renderer/core/css/cssom/css_unsupported_style_value.cc
    • third_party/blink/renderer/core/css/cssom/cssom_keywords.h
    • third_party/blink/renderer/core/css/cssom/cssom_types.h
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.h
    • third_party/blink/renderer/core/css/cssom/style_value_factory.h
    • third_party/blink/renderer/core/css/parser/css_parser.h
    • third_party/blink/renderer/core/css/parser/css_parser_context.h
    • third_party/blink/renderer/core/css/parser/css_parser_fast_paths.h
    • third_party/blink/renderer/core/css/parser/css_parser_impl.h
    • third_party/blink/renderer/core/css/parser/css_parser_local_context.h
    • third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
    • third_party/blink/renderer/core/css/resolver/animated_style_builder.h
    • third_party/blink/renderer/core/css/resolver/css_property_priority.h
    • third_party/blink/renderer/core/css/resolver/css_to_style_map.h
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver.cc
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver.h
    • third_party/blink/renderer/core/css/resolver/element_style_resources.cc
    • third_party/blink/renderer/core/css/resolver/element_style_resources.h
    • third_party/blink/renderer/core/css/resolver/style_builder.h
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc
    • third_party/blink/renderer/core/css/resolver/style_resolver_state.h
    • third_party/blink/renderer/core/css/resolver/viewport_style_resolver.h
    • third_party/blink/renderer/core/css/threaded/css_parser_threaded_test.cc
    • third_party/blink/renderer/core/editing/commands/apply_style_command.cc
    • third_party/blink/renderer/core/editing/commands/composite_edit_command.h
    • third_party/blink/renderer/core/editing/commands/editor_command.cc
    • third_party/blink/renderer/core/editing/commands/remove_css_property_command.h
    • third_party/blink/renderer/core/editing/commands/replace_selection_command.cc
    • third_party/blink/renderer/core/editing/editing_style.h
    • third_party/blink/renderer/core/editing/editing_style_utilities.cc
    • third_party/blink/renderer/core/editing/editor.cc
    • third_party/blink/renderer/core/editing/serializers/serialization.h
    • third_party/blink/renderer/core/exported/web_document_test.cc
    • third_party/blink/renderer/core/frame/deprecation.h
    • third_party/blink/renderer/core/frame/use_counter.h
    • third_party/blink/renderer/core/html/forms/color_input_type.cc
    • third_party/blink/renderer/core/html/forms/date_time_numeric_field_element.cc
    • third_party/blink/renderer/core/html/forms/html_input_element.cc
    • third_party/blink/renderer/core/html/html_br_element.cc
    • third_party/blink/renderer/core/html/html_details_element.cc
    • third_party/blink/renderer/core/html/html_div_element.cc
    • third_party/blink/renderer/core/html/html_element.cc
    • third_party/blink/renderer/core/html/html_embed_element.cc
    • third_party/blink/renderer/core/html/html_font_element.cc
    • third_party/blink/renderer/core/html/html_frame_set_element.cc
    • third_party/blink/renderer/core/html/html_hr_element.cc
    • third_party/blink/renderer/core/html/html_iframe_element.cc
    • third_party/blink/renderer/core/html/html_image_element.cc
    • third_party/blink/renderer/core/html/html_li_element.cc
    • third_party/blink/renderer/core/html/html_marquee_element.cc
    • third_party/blink/renderer/core/html/html_olist_element.cc
    • third_party/blink/renderer/core/html/html_paragraph_element.cc
    • third_party/blink/renderer/core/html/html_plugin_element.cc
    • third_party/blink/renderer/core/html/html_pre_element.cc
    • third_party/blink/renderer/core/html/html_table_caption_element.cc
    • third_party/blink/renderer/core/html/html_table_cell_element.cc
    • third_party/blink/renderer/core/html/html_table_col_element.cc
    • third_party/blink/renderer/core/html/html_table_element.cc
    • third_party/blink/renderer/core/html/html_table_part_element.cc
    • third_party/blink/renderer/core/html/html_ulist_element.cc
    • third_party/blink/renderer/core/html/media/html_video_element.cc
    • third_party/blink/renderer/core/html/track/vtt/vtt_cue.cc
    • third_party/blink/renderer/core/inspector/inspector_css_agent.cc
    • third_party/blink/renderer/core/inspector/inspector_dom_snapshot_agent.h
    • third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
    • third_party/blink/renderer/core/layout/custom/css_layout_definition.h
    • third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.cc
    • third_party/blink/renderer/core/layout/layout_fieldset.cc
    • third_party/blink/renderer/core/layout/layout_table.h
    • third_party/blink/renderer/core/layout/line/inline_flow_box.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
    • third_party/blink/renderer/core/paint/ng/ng_text_painter.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/text_painter.cc
    • third_party/blink/renderer/core/paint/text_painter_test.cc
    • third_party/blink/renderer/core/style/computed_style.h
    • third_party/blink/renderer/core/style/computed_style_extra_fields.json5
    • third_party/blink/renderer/core/svg/properties/svg_animated_property.h
    • third_party/blink/renderer/core/svg/svg_animate_element.h
    • third_party/blink/renderer/core/svg/svg_image_element.cc
    • third_party/blink/renderer/core/svg/svg_text_content_element.cc
    • third_party/blink/renderer/core/testing/internals.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_style.cc
    • third_party/blink/renderer/modules/csspaint/css_paint_definition.h
    • third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.cc
  8. Roll src/third_party/depot_tools ef71a5f047da..f66e5510327b (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 02:35:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eda15b3404c8112e2b25fc6b74f42bdeafca85f1

    Comments

    Roll src/third_party/depot_tools ef71a5f047da..f66e5510327b (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ef71a5f047da..f66e5510327b
    
    
    git log ef71a5f047da..f66e5510327b --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 yyanagisawa@chromium.org autoninja: support -j100 and -tclean.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@f66e5510327b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: I41516e4c6a5990999b112587a8b7c75bbdd1357a
    Reviewed-on: https://chromium-review.googlesource.com/c/1336652
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608233}

    Changed files

    • DEPS
  9. Change height of Assistant caption bar.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 02:32:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f5d78a9777cb0342ae5f1cba82c5e0ca450b6f1

    Comments

    Change height of Assistant caption bar.
    
    Per change in spec, the Assistant caption bar should be 48dip tall.
    See bug for detailed spec.
    
    Bug: b:119498360
    Change-Id: I40cd7cd44a37b9ca99710dad9311b929373b3797
    Reviewed-on: https://chromium-review.googlesource.com/c/1336525
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#608232}

    Changed files

    • ash/assistant/ui/caption_bar.cc
  10. Roll src/third_party/perfetto 74096ec8f277..cd83dda45843 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 02:25:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d217522d449aec4c99c5303fe10249e841f60969

    Comments

    Roll src/third_party/perfetto 74096ec8f277..cd83dda45843 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/74096ec8f277..cd83dda45843
    
    
    git log 74096ec8f277..cd83dda45843 --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 hjd@google.com Unify on for (;;)
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cd83dda45843
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I7444b3208fa39e54a631954fe8bcd5a38f0bb917
    Reviewed-on: https://chromium-review.googlesource.com/c/1336651
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608231}

    Changed files

    • DEPS
  11. Create an observer to purge network icons

    Changed by Tony de Luna - tonydelunaohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 02:23:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a49b0b145fdbcd99e9f8cb1b9ca23e3fcf6fb3a7

    Comments

    Create an observer to purge network icons
    
    This cl moves network icon cache purging to a new observer that is owned
    by the unified system tray.
    
    Currently there are five subclasses of
    TrayNetworkStateObserver::Delegate. Every time we get a network list
    update the global network icon cache is purged.
    This means that for every update the cache is purged at least five
    times.
    
    With this cl TrayNetworkStateObserver::Delegate can still be used as a
    simple way of subscribing to all network events without excessive icon
    purging.
    
    Bug: 902409
    Change-Id: I078ac8dbdee473fc285ee8e91f735c99524c74a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1334835
    Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608230}

    Changed files

    • ash/BUILD.gn
    • ash/system/network/network_icon_purger.cc
    • ash/system/network/network_icon_purger.h
    • ash/system/network/tray_network_state_observer.cc
    • ash/system/network/tray_network_state_observer.h
    • ash/system/unified/unified_system_tray.cc
    • ash/system/unified/unified_system_tray.h
  12. Sends events of surrounding text changed to IME not only when the caret bounds

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 02:23:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d50e57f4c1abb74274b9564816d7415a0a67652

    Comments

    Sends events of surrounding text changed to IME not only when the caret bounds
    are changed but also when the selection is changed.
    
    Bug: 898442
    Change-Id: I927171f7ded54cad1626e367a33a900e90adc8f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1319211
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608229}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_aura.cc
    • content/browser/renderer_host/render_widget_host_view_aura.h
    • content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
  13. EXO: Refactor input timestamps manager interface

    Changed by Shawn Gallea - sagalleaohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 02:16:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2761eb6a36be2d79ebfba0959ce87c96e2248174

    Comments

    EXO: Refactor input timestamps manager interface
    
    Move input timestamps manager out of server.cc
    This CL only moves code around.
    
    Bug: 896710
    Test: Built on ChromeOS
    Change-Id: I65e8baba6d20b726cf69fed3b90286d6ea7cd756
    Reviewed-on: https://chromium-review.googlesource.com/c/1318789
    Commit-Queue: Shawn Gallea <sagallea@google.com>
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608228}

    Changed files

    • components/exo/wayland/BUILD.gn
    • components/exo/wayland/server.cc
    • components/exo/wayland/zwp_input_timestamps_manager.cc
    • components/exo/wayland/zwp_input_timestamps_manager.h
  14. Refactor motion data in device orientation

    Changed by James Hollyer - jameshollyerohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 02:14:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a71f4e5e9a576129c6acabbc8358ea3f02032ab

    Comments

    Refactor motion data in device orientation
    
    removed acceleration and rotation rate class from device motion data and put all the logic into device_acceleration and device_rotation_data class
    
    Change-Id: If54ad00321f4fe14be4468ed3d01291af4d6c783
    Reviewed-on: https://chromium-review.googlesource.com/c/1320589
    Reviewed-by: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Commit-Queue: James Hollyer <jameshollyer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608227}

    Changed files

    • third_party/blink/renderer/modules/device_orientation/device_acceleration.cc
    • third_party/blink/renderer/modules/device_orientation/device_acceleration.h
    • third_party/blink/renderer/modules/device_orientation/device_motion_data.cc
    • third_party/blink/renderer/modules/device_orientation/device_motion_data.h
    • third_party/blink/renderer/modules/device_orientation/device_motion_event.cc
    • third_party/blink/renderer/modules/device_orientation/device_motion_event.h
    • third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.cc
    • third_party/blink/renderer/modules/device_orientation/device_motion_event_pump_unittest.cc
    • third_party/blink/renderer/modules/device_orientation/device_rotation_rate.cc
    • third_party/blink/renderer/modules/device_orientation/device_rotation_rate.h
  15. Roll src/third_party/angle ccad5e333472..1934b786149d (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 02:12:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bfa62c6eade5ca2ef8fe012d932c49a6405702b8

    Comments

    Roll src/third_party/angle ccad5e333472..1934b786149d (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/ccad5e333472..1934b786149d
    
    
    git log ccad5e333472..1934b786149d --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 fjhenigman@chromium.org Refactor instancing tests.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@1934b786149d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: Ibc369c9aa7e350c8a270e6cd369537a15d7b277a
    Reviewed-on: https://chromium-review.googlesource.com/c/1336653
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608226}

    Changed files

    • DEPS
  16. Revise Assistant strings in Assistant setup flow and Voice Match.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 02:11:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 54bcb7fcb993e5ba72bdb462296324e5b278c3d6

    Comments

    Revise Assistant strings in Assistant setup flow and Voice Match.
    
    Bug: b:119555990
    Change-Id: I5c2e49fe96c4524db0fd07d2d826f9d5aaa0b48c
    Reviewed-on: https://chromium-review.googlesource.com/c/1335880
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#608225}

    Changed files

    • chrome/app/chromeos_strings.grdp
  17. WebUI: Update action-link element to use Shadow DOM v1.

    Changed by dpapad - dpapadohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 02:06:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4d7d1f5565ebe85c29da4c8109fe3189080f8e56

    Comments

    WebUI: Update action-link element to use Shadow DOM v1.
    
    Bug: 837381
    Change-Id: I5421657d43646c768def7a5ccf235b9eb483e2e2
    Reviewed-on: https://chromium-review.googlesource.com/c/1336548
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608224}

    Changed files

    • ui/webui/resources/js/action_link.js
  18. Fix race condition in net::SerialWorker.

    Changed by Robbie McElrath - rmcelrathohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 02:04:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31391ba33a8da1d9618fbfdb42aaa911cb986cf3

    Comments

    Fix race condition in net::SerialWorker.
    
    net::SerialWorker is a RefCountedThreadSafe object that also uses
    WeakPtrFactory to create WeakPtrs of itself. To run whatever work it's
    supposed to run, it PostTaskWithTraitsAndReply's to another sequence to
    do the work there, and then gets called back when the work is complete.
    The work callback holds a (refcounted) reference to the SerialWorker,
    and the reply callback is bound to a WeakPtr to ensure the SerialWorker
    will still be deleted if posting the reply fails. WeakPtr enforces that
    all dereferences to it, as well as its invalidation, must happen on the
    same sequence to avoid races. When the reply callback is being called,
    it dereferences the SerialWorker WeakPtr on the original sequence,
    which binds that WeakPtr to that sequence. It's possible for the
    SerialWorker’s owner to release it after the WeakPtr has been checked,
    but before the worker function has returned, in which case the worker
    function will have the last reference to the SerialWorker. In that case,
    when the worker function finally does return, it will delete the
    SerialWorker, which will delete its WeakPtrFactory, which will
    invalidate existing WeakPtrs. However, the WeakPtr was previously
    dereferenced on the SerialWorker sequence, and now it’s being
    invalidated on the worker sequence, which is invalid.
    
    To fix this, this CL makes SerialWorker a RefCountedDeleteOnSequence to
    ensure the deletion always happens in the right sequence.
    
    Bug: 882610
    Change-Id: If738d3724384ffd5ac210130415bce7262932feb
    Reviewed-on: https://chromium-review.googlesource.com/c/1336066
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Reviewed-by: Eric Orth <ericorth@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608223}

    Changed files

    • net/dns/dns_config_service_posix_unittest.cc
    • net/dns/serial_worker.cc
    • net/dns/serial_worker.h
  19. Roll src-internal 8a878e1c2fc6..ccb751a21b7d (7 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 02:03:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 342d16b408d9af840c61aeca5e32e9422e314e17

    Comments

    Roll src-internal 8a878e1c2fc6..ccb751a21b7d (7 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a878e1c2fc6..ccb751a21b7d
    
    
    Created with:
      gclient setdep -r src-internal@ccb751a21b7d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I8f29523afd0cb4f75f942e28a15d93fb5a245df3
    Reviewed-on: https://chromium-review.googlesource.com/c/1336850
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608222}

    Changed files

    • DEPS
  20. Avoid explicit empty string initializations.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 02:02:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7eadc0fb08dd3612fddf87af0dc786b346dfa9e9

    Comments

    Avoid explicit empty string initializations.
    
    They already start out empty by default.
    
    Change-Id: Iccfab99f6591753b91c08fbdc1d5edc13b1fa1c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1335280
    Reviewed-by: David Jacobo <djacobo@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608221}

    Changed files

    • chrome/browser/ui/find_bar/find_bar_platform_helper_mac_interactive_uitest.mm
    • components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc
  21. Roll src/third_party/skia 44764000b49c..7d2aae3165a2 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 02:00:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa6cb1f18d082455c3b0ae15eb6b9e9f4497a7d5

    Comments

    Roll src/third_party/skia 44764000b49c..7d2aae3165a2 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/44764000b49c..7d2aae3165a2
    
    
    git log 44764000b49c..7d2aae3165a2 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d5f1489286b8..3fc6893c8b24 (1 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@7d2aae3165a2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=rmistry@chromium.org
    
    Change-Id: Ifa5267e17f2bf8e0bab205dc9e4e76d1cbcd2b14
    Reviewed-on: https://chromium-review.googlesource.com/c/1336649
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608220}

    Changed files

    • DEPS
  22. Roll src/third_party/chromite 88c15c341d97..ece712e727b4 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 01:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d93eecd37fabeefa8974aa3dbb1e46ae424905f

    Comments

    Roll src/third_party/chromite 88c15c341d97..ece712e727b4 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/88c15c341d97..ece712e727b4
    
    
    git log 88c15c341d97..ece712e727b4 --date=short --no-merges --format='%ad %ae %s'
    2018-11-15 pprabhu@chromium.org chromeos_config: Temporarily drop hwtests from clapper-release
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@ece712e727b4
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I9b584177509c5cd7a92adfe6f3ae58d7e2b7ca79
    Reviewed-on: https://chromium-review.googlesource.com/c/1336750
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608219}

    Changed files

    • DEPS
  23. Fix a typo in comment.

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:56:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e212c3275657ba1250b541556f31ce469aca5f46

    Comments

    Fix a typo in comment.
    
    Change-Id: I6d6704beaeec441a2848ce9c53e9faa6df79fdee
    Reviewed-on: https://chromium-review.googlesource.com/c/1336919
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608218}

    Changed files

    • build/config/win/BUILD.gn
  24. Revert "chromeos: refactors MultiUserWindowManager into two classes"

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:52:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56483341806609d6e29b206433ecf95658d14dca

    Comments

    Revert "chromeos: refactors MultiUserWindowManager into two classes"
    
    This reverts commit 41f8a81f91026740a72d8633b35c3ccdfe5173f5.
    
    Reason for revert: broke browser_tests on chrome_os, see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8900
    
    Original change's description:
    > chromeos: refactors MultiUserWindowManager into two classes
    > 
    > One lives in ash, the other in the browser. The one in ash is responsible
    > for the actual window management and animations, the one in the browser for
    > forwarding to the one in ash and caching state. I'm happy to rename these
    > classes in the future.
    > 
    > BUG=756085,875111
    > TEST=covered by test
    > 
    > Change-Id: I2367534e0566742f3897c69fb8ece7dfff1b1aff
    > Reviewed-on: https://chromium-review.googlesource.com/c/1328567
    > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    > Commit-Queue: Scott Violet <sky@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#608022}
    
    TBR=sky@chromium.org,afakhry@chromium.org
    
    Change-Id: I23f7126a5ff8e897b7ad2ced79277392f771f2f8
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 756085, 875111
    Reviewed-on: https://chromium-review.googlesource.com/c/1336792
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608217}

    Changed files

    • ash/BUILD.gn
    • ash/multi_user/multi_user_window_manager.cc
    • ash/multi_user/multi_user_window_manager.h
    • ash/multi_user/multi_user_window_manager_delegate.h
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/ash/launcher/DEPS
    • chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
    • chrome/browser/ui/ash/multi_user/DEPS
    • chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
    • chrome/browser/ui/ash/multi_user/multi_user_window_manager.h
    • chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
    • chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
    • chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
    • chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
    • chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.h
  25. Add FilesApp owners for select_file_dialog_extension

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:49:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b764625cfe5f18e10b3e5bca0267fdcb0751031

    Comments

    Add FilesApp owners for select_file_dialog_extension
    
    FilesApp OWNERS should be consulted, and also help review changes, to
    the ChromeOS system modal select file dialog.
    
    Bug: 895703
    Change-Id: I4258de9c2b3bfc7e37e68b546c9e16a1395572dc
    Reviewed-on: https://chromium-review.googlesource.com/c/1336952
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608216}

    Changed files

    • chrome/browser/ui/views/OWNERS
  26. Put code in an anonymous namespace inside content/common/user_agent.cc.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:44:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c11913092bc45f05035112b34e73592a5fb0595

    Comments

    Put code in an anonymous namespace inside content/common/user_agent.cc.
    
    Not all code in the file needs to be visible to the outside. Also use
    the appropriate naming style for functions.
    
    Change-Id: I4f22df2932954b71ce65232a019cfcddd5fd408b
    Reviewed-on: https://chromium-review.googlesource.com/c/1336521
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608215}

    Changed files

    • content/common/user_agent.cc
  27. ContentSettingBubbleModel: Clean up url formating logic

    Changed by Charlie Harrison - csharrisonohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:40:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9fba96a92da733e214c8ade2e3757ecab53db000

    Comments

    ContentSettingBubbleModel: Clean up url formating logic
    
    This CL:
    1. Extracts logic for displaying lists of URLs (used by popup and
       redirect blocking UIs).
    
    2. Removes a failure-case from url_formatter::FormatUrlForSecurityDisplay.
       This API should handle all cases, and other UI code does not fall back
       to using the raw URL string if FormatUrlForSecurityDisplay returns an
       empty string.
    
    Bug: None
    Change-Id: I6f610cb41b8fba85a0952bd1aae2419c23c66586
    Reviewed-on: https://chromium-review.googlesource.com/c/1334414
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608214}

    Changed files

    • chrome/browser/ui/content_settings/content_setting_bubble_model.cc
  28. Move Demo Resources logic to new class

    Changed by Michael Giuffrida - michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:39:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe40bbc7fa3933ad3e3536307db41b306f709312

    Comments

    Move Demo Resources logic to new class
    
    Creates the DemoResources class, removing the nitty-gritty details of
    component loading from the global DemoSession instance.
    
    This will make it simpler to update the offline-enrolled mode to use the
    offline version of the Demo Mode Resources component. It will also allow
    us to check for the existence of Demo Mode resources without starting a
    a DemoSession, eg from OOBE.
    
    DemoResources avoids using the term "offline resources" except in the
    context of the preinstalled resources used in offline-enrolled Demo
    Mode. General Demo Mode resources will just be called "Demo Resources"
    or similar.
    
    A follow-up change will update calls to
    DemoSession::EnsureOfflineResourcesLoaded() to instead call a similar
    function on DemoResources.
    
    Bug: 904641
    Change-Id: Ia931721511fac4efb9e796052bd760a87c952be9
    Reviewed-on: https://chromium-review.googlesource.com/c/1333112
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608213}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/arc/arc_session_manager.cc
    • chrome/browser/chromeos/login/demo_mode/demo_extensions_external_loader.cc
    • chrome/browser/chromeos/login/demo_mode/demo_mode_resources_remover.cc
    • chrome/browser/chromeos/login/demo_mode/demo_mode_test_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_resources.cc
    • chrome/browser/chromeos/login/demo_mode/demo_resources.h
    • chrome/browser/chromeos/login/demo_mode/demo_resources_unittest.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.h
    • chrome/browser/chromeos/login/demo_mode/demo_session_unittest.cc
    • chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
    • chrome/browser/chromeos/login/session/chrome_session_manager.cc
  29. Reland "viz: DCHECK that clients don't send empty frames"

    Changed by Sunny Sachanandani - sunnypsohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:36:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 895bd797322a487584fe9f1b191847d26f4c32fd

    Comments

    Reland "viz: DCHECK that clients don't send empty frames"
    
    This is a reland of b44653f942d0b1a2265417a93134cc67a7e7fa55
    
    Original change's description:
    > viz: DCHECK that clients don't send empty frames
    >
    > The service rejects a CompostiorFrame if it has an empty render pass
    > list, or an empty output rect.  Add a DCHECK to ensure that clients
    > don't send these.
    >
    > Change-Id: I2a1a25fab8b2e01f5355eaf0378c98d730490863
    > Reviewed-on: https://chromium-review.googlesource.com/c/1335268
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#608087}
    
    TBR=dcheng@chromium.org
    
    Change-Id: Ia29587d7033a01bd4679bffb8a89508db01b0545
    Reviewed-on: https://chromium-review.googlesource.com/c/1336373
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608212}

    Changed files

    • services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
  30. EXO: Refactor WaylandTouchDelegate into its own file

    Changed by Shawn Gallea - sagalleaohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 01:24:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ebc16b65e4922f22c2d2b3c37172c9541dc0f0af

    Comments

    EXO: Refactor WaylandTouchDelegate into its own file
    
    Move WaylandTouchDelegate out of server.cc
    This CL only moves code around.
    
    Bug: 896710
    Test: Built on ChromeOS
    Change-Id: I8fc2cb3d52c76bdcc4d52c70e63beeb6cd403894
    Reviewed-on: https://chromium-review.googlesource.com/c/1318737
    Commit-Queue: Shawn Gallea <sagallea@google.com>
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608211}

    Changed files

    • components/exo/wayland/BUILD.gn
    • components/exo/wayland/server.cc
    • components/exo/wayland/wayland_touch_delegate.cc
    • components/exo/wayland/wayland_touch_delegate.h
  31. AW: metrics for schemes passed to loadUrl

    Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:21:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a2066fbae4a7c23b4c7f10fa75f8562ed3785e1

    Comments

    AW: metrics for schemes passed to loadUrl
    
    No change to logic.
    
    This adds metrics to track the scheme passed to loadUrl(). This also
    modifies our previous metric (tracking baseUrl() scheme) to distinguish
    between file:///android_asset/ URLs (and android_res) from other
    file:// URLs.
    
    This treats loadData() as "data:" scheme. This intentionally excludes
    loadDataWithBaseURL().
    
    R=isherman@chromium.org, torne@chromium.org
    
    Bug: 901581
    Test: run_webview_instrumentation_test_apk \
    Test: --gtest_filter=AwContentsTest#testLoadUrlRecordsScheme*
    Change-Id: Ic09bf91a25ebeb7dd075337ae3e28e26e603c3ff
    Reviewed-on: https://chromium-review.googlesource.com/c/1334843
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608210}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwContents.java
    • android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  32. Navigation Predictor: Add UMA for action taken

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:17:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d3aee35420cda1b39b1786d3b5c17b54238feef

    Comments

    Navigation Predictor: Add UMA for action taken
    
    This CL adds logic for determining which URL to prefetch and records
    UMA around that. Note that navigation predictor is still running in
    dry-run mode, as in no prefetch is actually done.
    
    Change-Id: I620a3c10146f47b3bd2d8b042b54af0a5879fc90
    Bug: 903945
    TBR: ryansturm@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1333247
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608209}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor.cc
    • chrome/browser/navigation_predictor/navigation_predictor.h
    • chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
    • chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
    • chrome/test/data/navigation_predictor/page_with_same_host_anchor_element.html
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  33. arc: Preserve suppress Play Store show state.

    Changed by khmel@chromium.org - khmelohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 01:14:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dad2367914c352136e72903d522e31eabeadf7c9

    Comments

    arc: Preserve suppress Play Store show state.
    
    This preserves suppress Play Store show state in case Chrome was
    restarted during the previous session and initial OptIn flow is
    currently active.
    
    TEST=Locally, simulating that case  + unit test
    BUG=b:119069366
    
    Change-Id: Ifc30bf538baf42d6b91a20d8263d90e7d8962db2
    Reviewed-on: https://chromium-review.googlesource.com/c/1331829
    Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
    Commit-Queue: Yury Khmel <khmel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608208}

    Changed files

    • chrome/browser/chromeos/arc/arc_session_manager.cc
    • chrome/browser/chromeos/arc/arc_session_manager.h
    • chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
    • components/arc/arc_prefs.cc
    • components/arc/arc_prefs.h