Home | Search | chromium - Builders
Login

Builder Windows deterministic Build 10714 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision8bb08aa27446a3361e60a01c1e6f3e53704446d4
Got Revision8bb08aa27446a3361e60a01c1e6f3e53704446d4

Execution:

Steps and Logfiles:

Show:
  1. ( 321 ms ) setup_build
    running recipe: "swarming/deterministic_build"
  2. ( 11 mins 31 secs ) bot_update
    [26GB/299GB used (8%)]
  3. ( 491 ms ) clobber
  4. ( 11 mins 42 secs ) gclient runhooks
  5. ( 636 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  6. ( 2 mins 50 secs ) generate_build_files
  7. ( 25 mins 51 secs ) First build
  8. ( 1 mins 36 secs ) First build confirm no-op
  9. ( 11 mins 31 secs ) isolate tests
  10. ( 528 ms ) clobber (2)
  11. ( 36 secs ) gclient runhooks (2)
  12. ( 593 ms ) lookup GN args (2)
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  13. ( 2 mins 52 secs ) generate_build_files (2)
  14. ( 16 mins 54 secs ) Second build
  15. ( 1 mins 17 secs ) Second build confirm no-op
  16. ( 8 mins 46 secs ) isolate tests (2)
  17. ( 17 mins 9 secs ) compare_build_artifacts
  18. ( 1 mins 35 secs ) create tarball
  19. ( 12 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2173-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542227661780311, "id": "8929850803279986320", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/8bb08aa27446a3361e60a01c1e6f3e53704446d4", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/8bb08aa27446a3361e60a01c1e6f3e53704446d4", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095280865374594000", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Windows deterministic" setup_build
buildnumber 10714 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "swarming/deterministic_build" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "8bb08aa27446a3361e60a01c1e6f3e53704446d4" setup_build
got_angle_revision "fca8fd6201901e372ef544a847284b0ea02cd1b1" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "597e1587b4bfc7bf89895c7c879ae58b649da3c5" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "8bb08aa27446a3361e60a01c1e6f3e53704446d4" bot_update
got_revision_cp "refs/heads/master@{#608110}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "5986b74408c48f91de1d0478e9f0a2224bd77403" bot_update
got_v8_revision_cp "refs/heads/7.2.332@{#1}" bot_update
got_webrtc_revision "fdc635d2a8ffceeec44b57a83c9ca102fba1a88f" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25637}" bot_update
swarm_hashes {"accessibility_unittests": "0ebe0215d26020bb01484bd4945d344b4ac9f6cf", "angle_end2end_tests": "77c31bca9b7c8b9d3d3fcd7392970a0495395471", "angle_perftests": "63f571f4487937d6cd5db2b20d09637453b9add4", "angle_unittests": "ea330d358e2dbf174602bbb0e88bbdff2c1c3f45", "angle_white_box_tests": "708034fb73b17d41cbbb08e52a8a2d1099becd4b", "app_shell_unittests": "507d2acba20d108ee39381a1a8383989693b55e6", "aura_unittests": "88bbf631d874f7e5d2700847a2ecb1805bc7e7d6", "base_perftests": "1f05a5b2461a1d74ac7029226e48cdab7a4a99b5", "base_unittests": "9da32a3c3bf06e3ae4d20bf164d7467543199e3c", "blink_common_unittests": "461d2f13edae4fa22d09f4c879ce63c2c2a11e08", "blink_fuzzer_unittests": "5682776a11dbf0434d23816c7f14cf0146c105ca", "blink_heap_unittests": "96362d74bfd0cb1b773246351a17bdd3ada1d7c8", "blink_platform_unittests": "723f5fe963f1f7915f3eda24d30d4c95a463cdc1", "boringssl_crypto_tests": "76568ed33c9123a9d0b0d4ae9c441f07f8fb2cd2", "boringssl_ssl_tests": "cafec2eb9800f75e771de18114b83c471660d15a", "browser_tests": "60e515bbdaffaa2f2d5a5bd2170e0686aface507", "cacheinvalidation_unittests": "bea555180229f1c98c6db46d26d6642fb03121e8", "capture_unittests": "6a6a9adef3d378380b661f9d9c981be104cb7395", "cast_unittests": "a12a0b00d0276130ddc366f1489e56db2a1ed584", "cc_unittests": "1b3826fcab8d20282a5249cdcf73fc8e039ef257", "chrome_app_unittests": "cd4b90d09066551fe3740bd44fdd0f75641e4b81", "chrome_cleaner_unittests": "eadf38fb431ca71bb2985ef40f291eddcdb6db67", "chrome_elf_import_unittests": "31f16b983cfb0f77d49c97f32f5a230c86d6a468", "chrome_elf_unittests": "63832453680675adb3717059d030616b4944693d", "chromedriver_py_tests": "84adc3ae9f080f377686358988ceaddd9a41428c", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "5720598dcc5e2aee13f6620fbffa420761cf7fff", "command_buffer_perftests": "2be4631511167609f58c67c73d1470f027817bdb", "components_browsertests": "d709e5920900a22befa3f17594b1f25bfb2be657", "components_perftests": "ee4ebb4d6924434c3807eb29302ea0c95838bc28", "components_unittests": "bbf66c1541034d2ec73e8d48e29d63575674f734", "compositor_unittests": "3bb6f6416f32f8751583c27ce55df1229a8c93bb", "content_browsertests": "2d91fc8007e2537cf8279c682444c8e170adb3f7", "content_shell_crash_test": "eb9ce6959156c254b3710b99af3a635fdae025da", "content_unittests": "cb05bba05da9fd21d39fd23bc136b0ad59c4d34a", "courgette_unittests": "c9ce17b272a7418961b987cc4efe180f0990ea23", "crashpad_tests": "7340dc066971b9ebf934062dd979fa4b27059f50", "cronet_tests": "4601f9c3f46e7c29e18edb4d62ac7e332f3c785d", "cronet_unittests": "1e4ec5ddecb5b2190fb7e5d66180c2d7c40259e3", "crypto_unittests": "c3e6ecaa4ebc7a3e7be93b24379e640dc3525508", "dawn_end2end_tests": "1620e478feece7dcd63410d20598c76b8440b9aa", "device_unittests": "6d1a232d7729e404d6df0514d1eecdde3f146f1b", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "6b2011c4717dafe6956d2bd36c9ffbce116ff530", "elevation_service_unittests": "05539183b222f33b033b24a359b96856b651f143", "events_unittests": "5444f4008f0eebd98ff60bd6775e11dd83811a62", "extensions_browsertests": "d7f6f9b51077923180895990731d5b6d7480886a", "extensions_unittests": "462d7774d3646d19399a86951ccdf486cc60ec17", "filesystem_service_unittests": "eecfa1dbec795a9c1178d06946fd38ea420cb6b8", "gcm_unit_tests": "afd9a196a8fe9799ed784951fbbaf004d0c3f489", "gcp_unittests": "310485a67e74cf7f146dd9ee5e2a84a6e47d9bd3", "gfx_unittests": "e1e17fb06ce5a9bd63a325cbc3e5fc15440db280", "gin_unittests": "9d24f4c2980bc792e0888ba17188895a0bd8d97d", "gl_tests": "ca89a8951cbf536382435ed6ecfce669bd569571", "gl_unittests": "6204bd00872a36a1a0e68ff86ccf2fab747bc4e0", "gl_unittests_ozone": "6204bd00872a36a1a0e68ff86ccf2fab747bc4e0", "gles2_conform_test": "c6deef1a48535a73ec600abcf6bf3f5b71c77944", "google_apis_unittests": "a0d067800b1355f2fad767b5fcb94c8aeaf8b1f8", "gpu_perftests": "acd9a6fd04b43a3d9a968d669d0a37ac8d8ae101", "gpu_unittests": "4b3841422fb40111e4bae2c13dd3c96981ff3e63", "headless_browsertests": "b00e7d236e8af2516a99e7690c4ee90dc3f35f00", "headless_unittests": "9ef628b4e3c5541d333bb566ec87b94c7d70b145", "install_static_unittests": "ca7988b5df9593a9950f2a8378b75ab9af8c5dc2", "installer_util_unittests": "cddee15b5e682fc226666811138e6f44367166ce", "interactive_ui_tests": "1d025eeca1e57d1f4561c245e2513367f0c2c9ac", "ipc_tests": "48c5f83ec10e56de992ba28460cee4bfc69c849a", "jingle_unittests": "d1b30ae09c9aceac4f6f35f99cc0bd278c9826bf", "latency_unittests": "e804d812e5df68d9b3c1d3490d73e57e16bc8013", "leveldb_service_unittests": "ce07cab1672abfb23d3d70da141d28a952ae7a24", "libjingle_xmpp_unittests": "4801cdbed49fb7cf3b7c7920f4bc30da124941d9", "load_library_perf_tests": "2b45a7d1c2f259dcbfd1c6e94a9e716dba928e3d", "media_blink_unittests": "b1779d2385d424270fbc852a7cf0774c949ee1f1", "media_perftests": "866a9992ddb1ab66db49fcf0b345ce0255761200", "media_service_unittests": "975350ab3a1e76c8f5cd2bb893e254150cc347d1", "media_unittests": "22cfc98bb8793302329c81f9720ee49004f470c9", "message_center_unittests": "83372deb8eeff3a3a8f47e671d9a3e9593c0b712", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "0a9db1b8c9747d09b614ad380b5b0f9c7d89995d", "mini_installer_tests": "73aeab396ae07f17b9dba507d9d6d4089741322f", "mojo_core_unittests": "1602f5f157954fdf4cff147d70535bc77ed58913", "mojo_unittests": "d47ba850d48479bfbeee98d265a2a607d675cbc9", "nacl_loader_unittests": "9e42e01eb2cf3db6539ae20fd2489649c658eb8f", "native_theme_unittests": "de9744de46b1460517ce4f9bedcf321b4f3e60ee", "net_perftests": "b432c8640599524b02340359f6b9bd312abe9496", "net_unittests": "63e6a53f37a19f31338201558c95765947325a3b", "notification_helper_unittests": "d9f87af99328b5ebbe67a2e55f7528ecf4874096", "pdf_unittests": "6862d708a3f3122c0acfdaec235abdd8f91d0c1d", "performance_browser_tests": "3405d9d5f6c0d880d5cc6dd9a6c04dcb6a02bfa1", "performance_test_suite": "e36ee70f256de3bbf3eab9987537de928b470796", "performance_webview_test_suite": "cffe564ee8bcdf123f50e1693dca5aa156f6fd50", "ppapi_unittests": "4d7080caa7338f055ceeedda3ae6a4e31705a11d", "printing_unittests": "a667c82d8e3856a63cc703f65268668f6de4f2db", "remoting_unittests": "c2bbbc13dffb30c9cda286938ff47c47c8472a17", "sbox_integration_tests": "e4f1ce9cd4c7c1f7deb720aef425f2f4a808a6e8", "sbox_unittests": "9daf082365ff34c0aacd486c989a69a5889a8129", "sbox_validation_tests": "dc3fbf610be7de3ae0d35f33ce98811cb1aecbad", "service_manager_unittests": "f6250e01cec8ee9ecfa40f4c54f74222d9333e0a", "services_unittests": "bd6ee30cc382dc76a4ad0975c5f237e7762fb78c", "setup_unittests": "eff7742a512759b4c824f10c6589eb3719eae425", "shell_dialogs_unittests": "49314202a485a3697d481899d1875256e6a416cc", "skia_unittests": "691e6c548b919a529c9feb79d93b7366421fe29c", "snapshot_unittests": "441a9eb1d07e0ff7becbfd47c5ea6cc059d0f787", "sql_unittests": "2646698ab94d873f6a2b567e91fb919e8119f639", "storage_unittests": "44e410876dbdbb6243c30ce9751a9fc87711018e", "swiftshader_unittests": "093d7fa044ee7fc11baf167a361cdc7fa5e5d0ca", "sync_integration_tests": "69796e2c6bd6e7b0212c3ce3cc6b6cd5563d9c10", "telemetry_gpu_integration_test": "6c2910a7e729e8c0cb4f23b2f05a8748c822ce9d", "telemetry_gpu_unittests": "3fcfc26f176aff4a55fad2903e3e8acb2816da3d", "telemetry_perf_tests_without_chrome": "ef9800df15329430291acb728cce88cce07b6e67", "telemetry_perf_unittests": "e1460cb6edba86012367c920a6d07e5a2da9d7d8", "telemetry_unittests": "19f2c70e452f5d29d8a364acb804624ad18a5d4a", "tracing_perftests": "63d6ccd1cbe5595664253f77810ba0e6fd53375f", "traffic_annotation_auditor_unittests": "655f206df1dce06d491b3ff8b7dadaeb0ce7122b", "ui_base_unittests": "96e6e19404ce58c22dab2d45565b518f690d4485", "ui_touch_selection_unittests": "3267a161789fd33374236d3f6a83a47f0d2f2ed5", "unit_tests": "b89f972f8bdef1ea95c3cef119524609aeb6cbde", "url_unittests": "73d8c42033b15be1a7721ed6603ea013042d2b30", "video_decode_accelerator_unittest": "85c97786860fe2bbf98f8b5afb8b4ea87e337ade", "views_mus_interactive_ui_tests": "9214d0cd862d3fb8dd3d112a384c097a6ca692d6", "views_mus_unittests": "79aa7a6bcf5fc872c0fac0db80b4e511d2aa086a", "views_perftests": "317d939967d8a2c30af99c5cd701b1de64bc1550", "views_unittests": "b9ff8ec5e6293a1d9d731ea70eea9436082b1e6c", "viz_unittests": "b064af6cd1a3f401dce6e996e870fe02745384fe", "vr_common_perftests": "25f82884691080705b83f78aa8c02cae3dd6da0e", "vr_common_unittests": "03e5dd5655e0bee1c443f9601ca14ac4b429509c", "vr_pixeltests": "887db524236410e10f635ee8d959c313c20ce1bf", "webkit_layout_tests": "ffc648446e73286e4045d91c28e8c54b284f373d", "webkit_layout_tests_exparchive": "a71f08e5fc1a821f980f5e2aa1e6e565a03b7254", "webkit_python_tests": "867a9be812fe49612a0bf1d866288dc15983a559", "webkit_unit_tests": "a4b0ed20637b27f2ab2a4358c7a8f482a5ec5a73", "wm_unittests": "a505da3a3c089251792415ee501e7aa02aa41382", "wtf_unittests": "3cee23b944740adb407dea6aeac94eae55cb15ce", "zucchini_unittests": "9cc855c002caac073bce36bb504df45594346507"} isolate tests
swarm_hashes {"accessibility_unittests": "0ebe0215d26020bb01484bd4945d344b4ac9f6cf", "angle_end2end_tests": "77c31bca9b7c8b9d3d3fcd7392970a0495395471", "angle_perftests": "63f571f4487937d6cd5db2b20d09637453b9add4", "angle_unittests": "ea330d358e2dbf174602bbb0e88bbdff2c1c3f45", "angle_white_box_tests": "708034fb73b17d41cbbb08e52a8a2d1099becd4b", "app_shell_unittests": "507d2acba20d108ee39381a1a8383989693b55e6", "aura_unittests": "88bbf631d874f7e5d2700847a2ecb1805bc7e7d6", "base_perftests": "1f05a5b2461a1d74ac7029226e48cdab7a4a99b5", "base_unittests": "9da32a3c3bf06e3ae4d20bf164d7467543199e3c", "blink_common_unittests": "461d2f13edae4fa22d09f4c879ce63c2c2a11e08", "blink_fuzzer_unittests": "5682776a11dbf0434d23816c7f14cf0146c105ca", "blink_heap_unittests": "96362d74bfd0cb1b773246351a17bdd3ada1d7c8", "blink_platform_unittests": "723f5fe963f1f7915f3eda24d30d4c95a463cdc1", "boringssl_crypto_tests": "76568ed33c9123a9d0b0d4ae9c441f07f8fb2cd2", "boringssl_ssl_tests": "cafec2eb9800f75e771de18114b83c471660d15a", "browser_tests": "60e515bbdaffaa2f2d5a5bd2170e0686aface507", "cacheinvalidation_unittests": "bea555180229f1c98c6db46d26d6642fb03121e8", "capture_unittests": "6a6a9adef3d378380b661f9d9c981be104cb7395", "cast_unittests": "a12a0b00d0276130ddc366f1489e56db2a1ed584", "cc_unittests": "1b3826fcab8d20282a5249cdcf73fc8e039ef257", "chrome_app_unittests": "cd4b90d09066551fe3740bd44fdd0f75641e4b81", "chrome_cleaner_unittests": "eadf38fb431ca71bb2985ef40f291eddcdb6db67", "chrome_elf_import_unittests": "31f16b983cfb0f77d49c97f32f5a230c86d6a468", "chrome_elf_unittests": "63832453680675adb3717059d030616b4944693d", "chromedriver_py_tests": "84adc3ae9f080f377686358988ceaddd9a41428c", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "5720598dcc5e2aee13f6620fbffa420761cf7fff", "command_buffer_perftests": "2be4631511167609f58c67c73d1470f027817bdb", "components_browsertests": "d709e5920900a22befa3f17594b1f25bfb2be657", "components_perftests": "ee4ebb4d6924434c3807eb29302ea0c95838bc28", "components_unittests": "bbf66c1541034d2ec73e8d48e29d63575674f734", "compositor_unittests": "3bb6f6416f32f8751583c27ce55df1229a8c93bb", "content_browsertests": "2d91fc8007e2537cf8279c682444c8e170adb3f7", "content_shell_crash_test": "eb9ce6959156c254b3710b99af3a635fdae025da", "content_unittests": "cb05bba05da9fd21d39fd23bc136b0ad59c4d34a", "courgette_unittests": "c9ce17b272a7418961b987cc4efe180f0990ea23", "crashpad_tests": "7340dc066971b9ebf934062dd979fa4b27059f50", "cronet_tests": "4601f9c3f46e7c29e18edb4d62ac7e332f3c785d", "cronet_unittests": "1e4ec5ddecb5b2190fb7e5d66180c2d7c40259e3", "crypto_unittests": "c3e6ecaa4ebc7a3e7be93b24379e640dc3525508", "dawn_end2end_tests": "1620e478feece7dcd63410d20598c76b8440b9aa", "device_unittests": "6d1a232d7729e404d6df0514d1eecdde3f146f1b", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "6b2011c4717dafe6956d2bd36c9ffbce116ff530", "elevation_service_unittests": "05539183b222f33b033b24a359b96856b651f143", "events_unittests": "5444f4008f0eebd98ff60bd6775e11dd83811a62", "extensions_browsertests": "d7f6f9b51077923180895990731d5b6d7480886a", "extensions_unittests": "462d7774d3646d19399a86951ccdf486cc60ec17", "filesystem_service_unittests": "eecfa1dbec795a9c1178d06946fd38ea420cb6b8", "gcm_unit_tests": "afd9a196a8fe9799ed784951fbbaf004d0c3f489", "gcp_unittests": "310485a67e74cf7f146dd9ee5e2a84a6e47d9bd3", "gfx_unittests": "e1e17fb06ce5a9bd63a325cbc3e5fc15440db280", "gin_unittests": "9d24f4c2980bc792e0888ba17188895a0bd8d97d", "gl_tests": "ca89a8951cbf536382435ed6ecfce669bd569571", "gl_unittests": "6204bd00872a36a1a0e68ff86ccf2fab747bc4e0", "gl_unittests_ozone": "6204bd00872a36a1a0e68ff86ccf2fab747bc4e0", "gles2_conform_test": "c6deef1a48535a73ec600abcf6bf3f5b71c77944", "google_apis_unittests": "a0d067800b1355f2fad767b5fcb94c8aeaf8b1f8", "gpu_perftests": "acd9a6fd04b43a3d9a968d669d0a37ac8d8ae101", "gpu_unittests": "4b3841422fb40111e4bae2c13dd3c96981ff3e63", "headless_browsertests": "b00e7d236e8af2516a99e7690c4ee90dc3f35f00", "headless_unittests": "9ef628b4e3c5541d333bb566ec87b94c7d70b145", "install_static_unittests": "ca7988b5df9593a9950f2a8378b75ab9af8c5dc2", "installer_util_unittests": "cddee15b5e682fc226666811138e6f44367166ce", "interactive_ui_tests": "1d025eeca1e57d1f4561c245e2513367f0c2c9ac", "ipc_tests": "48c5f83ec10e56de992ba28460cee4bfc69c849a", "jingle_unittests": "d1b30ae09c9aceac4f6f35f99cc0bd278c9826bf", "latency_unittests": "e804d812e5df68d9b3c1d3490d73e57e16bc8013", "leveldb_service_unittests": "ce07cab1672abfb23d3d70da141d28a952ae7a24", "libjingle_xmpp_unittests": "4801cdbed49fb7cf3b7c7920f4bc30da124941d9", "load_library_perf_tests": "2b45a7d1c2f259dcbfd1c6e94a9e716dba928e3d", "media_blink_unittests": "b1779d2385d424270fbc852a7cf0774c949ee1f1", "media_perftests": "866a9992ddb1ab66db49fcf0b345ce0255761200", "media_service_unittests": "975350ab3a1e76c8f5cd2bb893e254150cc347d1", "media_unittests": "22cfc98bb8793302329c81f9720ee49004f470c9", "message_center_unittests": "83372deb8eeff3a3a8f47e671d9a3e9593c0b712", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "0a9db1b8c9747d09b614ad380b5b0f9c7d89995d", "mini_installer_tests": "77e091973f743b7d45a62aac9204b75d4c566ae9", "mojo_core_unittests": "1602f5f157954fdf4cff147d70535bc77ed58913", "mojo_unittests": "d47ba850d48479bfbeee98d265a2a607d675cbc9", "nacl_loader_unittests": "9e42e01eb2cf3db6539ae20fd2489649c658eb8f", "native_theme_unittests": "de9744de46b1460517ce4f9bedcf321b4f3e60ee", "net_perftests": "b432c8640599524b02340359f6b9bd312abe9496", "net_unittests": "63e6a53f37a19f31338201558c95765947325a3b", "notification_helper_unittests": "d9f87af99328b5ebbe67a2e55f7528ecf4874096", "pdf_unittests": "6862d708a3f3122c0acfdaec235abdd8f91d0c1d", "performance_browser_tests": "3405d9d5f6c0d880d5cc6dd9a6c04dcb6a02bfa1", "performance_test_suite": "e36ee70f256de3bbf3eab9987537de928b470796", "performance_webview_test_suite": "cffe564ee8bcdf123f50e1693dca5aa156f6fd50", "ppapi_unittests": "4d7080caa7338f055ceeedda3ae6a4e31705a11d", "printing_unittests": "a667c82d8e3856a63cc703f65268668f6de4f2db", "remoting_unittests": "c2bbbc13dffb30c9cda286938ff47c47c8472a17", "sbox_integration_tests": "e4f1ce9cd4c7c1f7deb720aef425f2f4a808a6e8", "sbox_unittests": "9daf082365ff34c0aacd486c989a69a5889a8129", "sbox_validation_tests": "dc3fbf610be7de3ae0d35f33ce98811cb1aecbad", "service_manager_unittests": "f6250e01cec8ee9ecfa40f4c54f74222d9333e0a", "services_unittests": "bd6ee30cc382dc76a4ad0975c5f237e7762fb78c", "setup_unittests": "eff7742a512759b4c824f10c6589eb3719eae425", "shell_dialogs_unittests": "49314202a485a3697d481899d1875256e6a416cc", "skia_unittests": "691e6c548b919a529c9feb79d93b7366421fe29c", "snapshot_unittests": "441a9eb1d07e0ff7becbfd47c5ea6cc059d0f787", "sql_unittests": "2646698ab94d873f6a2b567e91fb919e8119f639", "storage_unittests": "44e410876dbdbb6243c30ce9751a9fc87711018e", "swiftshader_unittests": "093d7fa044ee7fc11baf167a361cdc7fa5e5d0ca", "sync_integration_tests": "69796e2c6bd6e7b0212c3ce3cc6b6cd5563d9c10", "telemetry_gpu_integration_test": "6c2910a7e729e8c0cb4f23b2f05a8748c822ce9d", "telemetry_gpu_unittests": "3fcfc26f176aff4a55fad2903e3e8acb2816da3d", "telemetry_perf_tests_without_chrome": "ef9800df15329430291acb728cce88cce07b6e67", "telemetry_perf_unittests": "e1460cb6edba86012367c920a6d07e5a2da9d7d8", "telemetry_unittests": "19f2c70e452f5d29d8a364acb804624ad18a5d4a", "tracing_perftests": "63d6ccd1cbe5595664253f77810ba0e6fd53375f", "traffic_annotation_auditor_unittests": "655f206df1dce06d491b3ff8b7dadaeb0ce7122b", "ui_base_unittests": "96e6e19404ce58c22dab2d45565b518f690d4485", "ui_touch_selection_unittests": "3267a161789fd33374236d3f6a83a47f0d2f2ed5", "unit_tests": "b89f972f8bdef1ea95c3cef119524609aeb6cbde", "url_unittests": "73d8c42033b15be1a7721ed6603ea013042d2b30", "video_decode_accelerator_unittest": "85c97786860fe2bbf98f8b5afb8b4ea87e337ade", "views_mus_interactive_ui_tests": "9214d0cd862d3fb8dd3d112a384c097a6ca692d6", "views_mus_unittests": "79aa7a6bcf5fc872c0fac0db80b4e511d2aa086a", "views_perftests": "317d939967d8a2c30af99c5cd701b1de64bc1550", "views_unittests": "b9ff8ec5e6293a1d9d731ea70eea9436082b1e6c", "viz_unittests": "b064af6cd1a3f401dce6e996e870fe02745384fe", "vr_common_perftests": "25f82884691080705b83f78aa8c02cae3dd6da0e", "vr_common_unittests": "03e5dd5655e0bee1c443f9601ca14ac4b429509c", "vr_pixeltests": "887db524236410e10f635ee8d959c313c20ce1bf", "webkit_layout_tests": "ffc648446e73286e4045d91c28e8c54b284f373d", "webkit_layout_tests_exparchive": "a71f08e5fc1a821f980f5e2aa1e6e565a03b7254", "webkit_python_tests": "867a9be812fe49612a0bf1d866288dc15983a559", "webkit_unit_tests": "a4b0ed20637b27f2ab2a4358c7a8f482a5ec5a73", "wm_unittests": "a505da3a3c089251792415ee501e7aa02aa41382", "wtf_unittests": "3cee23b944740adb407dea6aeac94eae55cb15ce", "zucchini_unittests": "9cc855c002caac073bce36bb504df45594346507"} isolate tests (2)

Blamelist:

  1. sczs (sczsohnoyoudont@chromium.org)
  2. Misha Efimov (mefohnoyoudont@chromium.org)
  3. Bret Sepulveda (bsepohnoyoudont@chromium.org)
  4. Tom Tan (Tom.Tanohnoyoudont@microsoft.com)
  5. Shawn Gallea (sagalleaohnoyoudont@google.com)
  6. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  7. Bo Liu (boliuohnoyoudont@chromium.org)
  8. Justin Cohen (justincohenohnoyoudont@google.com)
  9. Justin Cohen (justincohenohnoyoudont@google.com)
  10. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  11. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  12. Sunny Sachanandani (sunnypsohnoyoudont@chromium.org)
  13. Ryan Meier (rameierohnoyoudont@chromium.org)
  14. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  15. Justin Cohen (justincohenohnoyoudont@google.com)
  16. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  17. Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
  18. Justin Cohen (justincohenohnoyoudont@google.com)
  19. Steven Valdez (svaldezohnoyoudont@chromium.org)
  20. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  21. James Darpinian (jdarpinianohnoyoudont@chromium.org)
  22. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  23. Zakhar Voit (voitohnoyoudont@google.com)
  24. Sunny Sachanandani (sunnypsohnoyoudont@chromium.org)
  25. Richard Townsend (Richard.Townsendohnoyoudont@arm.com)
  26. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  27. Joe Mason (joenotcharlesohnoyoudont@google.com)
  28. Lei Zhang (thestigohnoyoudont@chromium.org)
  29. Jonathan Metzman (metzmanohnoyoudont@chromium.org)
  30. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  31. Fernando Serboncini (fserbohnoyoudont@chromium.org)
  32. Eric Orth (ericorthohnoyoudont@chromium.org)
  33. Dan Sanders (sandersdohnoyoudont@chromium.org)
  34. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  35. Collin Baker (collinbakerohnoyoudont@chromium.org)
  36. Justin Cohen (justincohenohnoyoudont@google.com)
  37. Roger Tawa (rogertaohnoyoudont@chromium.org)
  38. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  39. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
  40. Kristi Park (kristiparkohnoyoudont@chromium.org)
  41. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  42. Joe Downing (joedowohnoyoudont@google.com)
  43. Kristi Park (kristiparkohnoyoudont@chromium.org)
  44. Mustafa Emre Acer (meacerohnoyoudont@chromium.org)
  45. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  46. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  47. Emircan Uysaler (emircanohnoyoudont@chromium.org)
  48. Lei Zhang (thestigohnoyoudont@chromium.org)
  49. Evan Stade (estadeohnoyoudont@chromium.org)
  50. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  51. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  52. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  53. Yiming Zhou (uwyimingohnoyoudont@google.com)
  54. Dan Harrington (harringtondohnoyoudont@chromium.org)
  55. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  56. edchin (edchinohnoyoudont@chromium.org)
  57. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  58. Tom Tan (Tom.Tanohnoyoudont@microsoft.com)
  59. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  60. Jacob Dufault (jdufaultohnoyoudont@google.com)
  61. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  62. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  63. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  64. Etienne Bergeron (etiennebohnoyoudont@chromium.org)
  65. Lei Zhang (thestigohnoyoudont@chromium.org)
  66. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  67. Becky Zhou (huayinzohnoyoudont@chromium.org)
  68. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  69. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  70. Saman Sami (samansohnoyoudont@chromium.org)
  71. Min Qin (qinminohnoyoudont@chromium.org)
  72. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  73. Eric Stevenson (estevensonohnoyoudont@chromium.org)
  74. Tommy C. Li (tommycliohnoyoudont@chromium.org)
  75. Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
  76. Shawn Gallea (sagalleaohnoyoudont@google.com)
  77. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  78. Rayan Kanso (rayankansohnoyoudont@google.com)
  79. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  80. Wei Li (weiliohnoyoudont@chromium.org)
  81. bsheedy (bsheedyohnoyoudont@chromium.org)
  82. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  83. Tony de Luna (tonydelunaohnoyoudont@chromium.org)
  84. Alex Newcomer (newcomerohnoyoudont@chromium.org)
  85. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  86. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  87. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  88. Abhishek Arya (infernoohnoyoudont@chromium.org)
  89. Scott Violet (skyohnoyoudont@chromium.org)
  90. Fernando Serboncini (fserbohnoyoudont@chromium.org)
  91. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  92. Rouslan Solomakhin (rouslanohnoyoudont@chromium.org)
  93. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
  94. Carlos IL (carlosilohnoyoudont@chromium.org)
  95. yiyix (yiyixohnoyoudont@chromium.org)
  96. John Budorick (jbudorickohnoyoudont@chromium.org)
  97. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  98. Hugo Holgersson (hugohohnoyoudont@vewd.com)
  99. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  100. Adithya Srinivasan (adithyasohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Wednesday, 14-Nov-18 20:34:21 UTC
Start Wednesday, 14-Nov-18 20:59:32 UTC
End Wednesday, 14-Nov-18 23:19:44 UTC
Pending 25 mins 10 secs
Execution 2 hrs 20 mins

All Changes:

  1. [ios] Removes isParentViewVisible from InfobarPositioner

    Changed by sczs - sczsohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 20:29:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8bb08aa27446a3361e60a01c1e6f3e53704446d4

    Comments

    [ios] Removes isParentViewVisible from InfobarPositioner
    
    Since now InfobarContainer is a VC we no longer need to get this info
    from the parent VC.
    
    Bug: 892376
    Change-Id: I04a7af0676437e20ebe0c31db16f0bf88c7b4ec6
    Reviewed-on: https://chromium-review.googlesource.com/c/1331171
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608110}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/infobars/infobar_container_view_controller.mm
    • ios/chrome/browser/ui/infobars/infobar_positioner.h
  2. Prevent PII logging in domain reliability component.

    Changed by Misha Efimov - mefohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 20:26:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99c53bcfb565218859bb8f4a99dcc18891fa1d4b

    Comments

    Prevent PII logging in domain reliability component.
    
    Bug: 905262
    Change-Id: I84199aa390a7b67e996d9022e94a826363084796
    Reviewed-on: https://chromium-review.googlesource.com/c/1335954
    Reviewed-by: Eric Orth <ericorth@chromium.org>
    Commit-Queue: Misha Efimov <mef@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608109}

    Changed files

    • components/domain_reliability/context.cc
    • components/domain_reliability/context_manager.cc
    • components/domain_reliability/header.cc
    • components/domain_reliability/monitor.cc
    • components/domain_reliability/uploader.cc
  3. Add support for WM_NCPOINTER* messages.

    Changed by Bret Sepulveda - bsepohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 20:25:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fbdbb023f2619c745abcd8bcab3039688b8eded5

    Comments

    Add support for WM_NCPOINTER* messages.
    
    A recent change caused the caption buttons to stop responding to touch.
    When I investigated, the change caused Windows to send WM_NCPOINTERDOWN
    and WM_NCPOINTERUP in that area (which we don't handle), where
    previously it was sending WM_POINTERDOWN and WM_POINTERUP.
    
    Since the change in question is fixing a different critical issue, this
    patch implements handling for WM_NCPOINTERDOWN, WM_NCPOINTERUP, and
    WM_NCPOINTERUPDATE, by delegating to the existing touch event handler.
    
    This patch also modifies the workaround frin crrev.com/c/1260507, since
    the type of messages being translated into ui::ET_TOUCH_RELEASED events
    is now different.
    
    Bug: 897662
    Change-Id: I6fd052211b91a9a78834573deac830883972092b
    Reviewed-on: https://chromium-review.googlesource.com/c/1330838
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608108}

    Changed files

    • ui/views/win/hwnd_message_handler.cc
    • ui/views/win/hwnd_message_handler.h
    • ui/views/win/pen_event_processor.cc
  4. Initialize zlib processor feature flags for Windows ARM64

    Changed by Tom Tan - Tom.Tanohnoyoudont@microsoft.com
    Changed at Wednesday, 14-Nov-18 20:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d9059165fdb75fd66b68b10f977c810fb5559c

    Comments

    Initialize zlib processor feature flags for Windows ARM64
    
    Bug: 893460
    Change-Id: I69914310f35a1b21159da701447651aba4f1b888
    Reviewed-on: https://chromium-review.googlesource.com/c/1334934
    Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
    Reviewed-by: Chris Blume <cblume@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608107}

    Changed files

    • third_party/zlib/arm_features.c
  5. EXO: Move WaylandPointerDelegate out of server.cc

    Changed by Shawn Gallea - sagalleaohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 20:24:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f4e2cd968006ac3a6a608ea3a44657ceebe2bb1

    Comments

    EXO: Move WaylandPointerDelegate out of server.cc
    
    This CL only moves code around.
    
    Bug: 896710
    Test: Built on ChromeOS
    Change-Id: Id9567918d751a9768d00489b5532a1abea3490e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1318083
    Commit-Queue: Shawn Gallea <sagallea@google.com>
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608106}

    Changed files

    • components/exo/wayland/BUILD.gn
    • components/exo/wayland/server.cc
    • components/exo/wayland/wayland_pointer_delegate.cc
    • components/exo/wayland/wayland_pointer_delegate.h
  6. Revert "Include anchor element metrics that differ from one from document URL"

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 20:23:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa9be2897840783b56146d69021ed259e5bac879

    Comments

    Revert "Include anchor element metrics that differ from one from document URL"
    
    This reverts commit 290d578e4aa4458206ceb564744ef3d7c43c7c9a.
    
    Reason for revert: Crashes renderer
    
    Original change's description:
    > Include anchor element metrics that differ from one from document URL
    > 
    > Currently, the render process sends the statistics of
    > only the anchor elements that are in the viewport to
    > the browser. This CL changes it to also include the
    > anchor elements whose target URL is one digit different
    > from the document URL.
    > 
    > Note that there is still a limit of 40 on the count of anchor
    > elements that are sent from the render to the browser process.
    > 
    > Change-Id: I4083e3605095a44700cc2178615713ede6e0dde2
    > Bug: 850624
    > TBR: ryansturm@chromium.org
    > Reviewed-on: https://chromium-review.googlesource.com/c/1329848
    > Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    > Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607328}
    
    TBR=kinuko@chromium.org,tbansal@chromium.org,ryansturm@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 850624,905224
    Change-Id: I8fe41adb0434d410eb6fd2244e525c05037585f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1335664
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608105}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
    • chrome/test/data/navigation_predictor/long_page_with_anchors-1.html
    • third_party/blink/renderer/core/html/anchor_element_metrics.cc
    • third_party/blink/renderer/core/html/anchor_element_metrics.h
  7. Prepare for new sdk

    Changed by Bo Liu - boliuohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 20:23:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 19f9a541235436db865c01288520cd9c16f3129f

    Comments

    Prepare for new sdk
    
    Put webview_cts_tests behind public_android_sdk since
    system_webview_apk dependency is behind public_android_sdk.
    
    Remove override on Picture.writeToStream which has been removed.
    
    Bug: 904912
    Change-Id: Idcda7dbcb31d5bb02926e2b6743f369f988426d6
    Reviewed-on: https://chromium-review.googlesource.com/c/1335955
    Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
    Commit-Queue: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608104}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwPicture.java
    • android_webview/test/BUILD.gn
  8. [ios] Add more ios egtest helpers to synchronise closing tabs.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 20:22:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9df6f8704a223f176576bf6992e767508ec3dbc4

    Comments

    [ios] Add more ios egtest helpers to synchronise closing tabs.
    
    Bug: 783192
    Change-Id: I54f44ee294418a5de54ba59456e0e672893697f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1334854
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608103}

    Changed files

    • ios/chrome/browser/device_sharing/handoff_manager_egtest.mm
    • ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
    • ios/chrome/browser/metrics/ukm_egtest.mm
    • ios/chrome/browser/net/cookies_egtest.mm
    • ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
    • ios/chrome/browser/ui/download/download_manager_egtest.mm
    • ios/chrome/browser/ui/infobars/infobar_egtest.mm
    • ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm
    • ios/chrome/browser/ui/recent_tabs/recent_tabs_egtest.mm
    • ios/chrome/browser/ui/settings/settings_egtest.mm
    • ios/chrome/browser/ui/tab_grid/tab_grid_transition_egtest.mm
    • ios/chrome/browser/web/window_open_by_dom_egtest.mm
    • ios/chrome/test/earl_grey/chrome_earl_grey.h
    • ios/chrome/test/earl_grey/chrome_earl_grey.mm
  9. [ios] Fix case on UIKit and WebKit includes.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 20:22:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 342db1c1553107c6ea92671bb62d3c6699014cdd

    Comments

    [ios] Fix case on UIKit and WebKit includes.
    
    Corrected cases found with:
       git grep -h "#import <.*>" ios | sort | uniq
    
    Bug: 904101
    Change-Id: I17903375ef18d77bfd6f76052d6ea483a933ce56
    Reviewed-on: https://chromium-review.googlesource.com/c/1335876
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608102}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/content_suggestions_metrics_recording.h
    • ios/chrome/browser/ui/print/print_controller.mm
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views_utils.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_input_assistant_items.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_ui_bar_button_item.h
    • ios/web/net/cookies/wk_http_system_cookie_store.h
    • ios/web/net/cookies/wk_http_system_cookie_store_unittest.mm
  10. [perf] Add load:search:google:2018 system health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 20:05:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31bdb48c93335949c0c7b739e41de2628205a3cc

    Comments

    [perf] Add load:search:google:2018 system health story
    
    This CL was created automatically with tools/perf/update_wpr script
    Bug: 878390
    R=perezju@chromium.org
    
    Change-Id: I65300d654439ed65591691f5881cd8b1002c913c
    Reviewed-on: https://chromium-review.googlesource.com/c/1329665
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608101}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_b11350f30f.wprgo.sha1
    • tools/perf/page_sets/data/system_health_mobile.json
    • tools/perf/page_sets/data/system_health_mobile_09493f5937.wprgo.sha1
    • tools/perf/page_sets/system_health/loading_stories.py
  11. Update V8 to version 7.2.332.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 20:04:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ac86517f9af2ad22e820b73ea5e5e80928ff910

    Comments

    Update V8 to version 7.2.332.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/ebedb7eb..5986b744
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I3f6ecedb85aa3929fd670e994034f7852a7658c3
    Reviewed-on: https://chromium-review.googlesource.com/c/1336050
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608100}

    Changed files

    • DEPS
  12. Revert "viz: DCHECK that clients don't send empty frames"

    Changed by Sunny Sachanandani - sunnypsohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 20:02:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99128917058918742779379f82eeaaf2056087d4

    Comments

    Revert "viz: DCHECK that clients don't send empty frames"
    
    This reverts commit b44653f942d0b1a2265417a93134cc67a7e7fa55.
    
    Reason for revert: Broke the tree due to a typo :(
    
    Original change's description:
    > viz: DCHECK that clients don't send empty frames
    > 
    > The service rejects a CompostiorFrame if it has an empty render pass
    > list, or an empty output rect.  Add a DCHECK to ensure that clients
    > don't send these.
    > 
    > Change-Id: I2a1a25fab8b2e01f5355eaf0378c98d730490863
    > Reviewed-on: https://chromium-review.googlesource.com/c/1335268
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#608087}
    
    TBR=dcheng@chromium.org,fsamuel@chromium.org,sunnyps@chromium.org
    
    Change-Id: I95c5f1a54a39f5ae482aa311caaf0c5fdc8df094
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1336207
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608099}

    Changed files

    • services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
  13. Re-enable BookmarkBrowsertest.HideStarOnNonbookmarkedInterstitial

    Changed by Ryan Meier - rameierohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:55:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 182605f06c4613e967f47092c012acab1dda2616

    Comments

    Re-enable BookmarkBrowsertest.HideStarOnNonbookmarkedInterstitial
    
    Change-Id: Ic64d8059a0cad7b831044151d822a912d71718de
    Reviewed-on: https://chromium-review.googlesource.com/c/1334551
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608098}

    Changed files

    • chrome/browser/ui/bookmarks/bookmark_browsertest.cc
  14. Roll src/third_party/pdfium a89ef2b38df0..e3b7b56f6bc3 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 19:53:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 25d8dccbd2f6047541e247b07cc893568368bee7

    Comments

    Roll src/third_party/pdfium a89ef2b38df0..e3b7b56f6bc3 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/a89ef2b38df0..e3b7b56f6bc3
    
    
    git log a89ef2b38df0..e3b7b56f6bc3 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 thestig@chromium.org Break up ASSERT statements with ands.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@e3b7b56f6bc3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I5612bcb9520da5db3f12f908b398c4c950d2bc6d
    Reviewed-on: https://chromium-review.googlesource.com/c/1335839
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608097}

    Changed files

    • DEPS
  15. [ios] Work around --enable-features overwrite in ios-slimnav bot.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 19:51:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d389b5c67fec6bcf62197275b68bd0b478b2c57

    Comments

    [ios] Work around --enable-features overwrite in ios-slimnav bot.
    
    --enable-features overwrites eg_tests.json's own set of overrides, which
    breaks ios_chrome_manual_fill_egtests.  Instead, directly import and
    expand eg_tests.json and set --enable-features directly.
    
    Change-Id: Ia3e03bad59c6d3e9745037666a0b16cfe3da90e7
    Reviewed-on: https://chromium-review.googlesource.com/c/1335873
    Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608096}

    Changed files

    • ios/build/bots/chromium.fyi/ios-slimnav.json
  16. Roll src/third_party/skia d7157b2ccf53..bb9844ef69e7 (4 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 19:51:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4867cec8a749871ba0191cebceae89d95634abc7

    Comments

    Roll src/third_party/skia d7157b2ccf53..bb9844ef69e7 (4 commits)
    
    https://skia.googlesource.com/skia.git/+log/d7157b2ccf53..bb9844ef69e7
    
    
    git log d7157b2ccf53..bb9844ef69e7 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 benjaminwagner@google.com Add client code search to docs.
    2018-11-14 reed@google.com impl SkFont::getPath
    2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 02ce5830e7db..d5f1489286b8 (7 commits)
    2018-11-14 halcanary@google.com SkPDF: store indirect references in object
    
    
    Created with:
      gclient setdep -r src/third_party/skia@bb9844ef69e7
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=rmistry@chromium.org
    
    Change-Id: Ic3dd7bbc8234810035ec1ef12c6c3c66e0e8503e
    Reviewed-on: https://chromium-review.googlesource.com/c/1335778
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608095}

    Changed files

    • DEPS
  17. [iOS][MF] Hide and show password icon

    Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:48:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d21adc8d1cd34c7189ed9ada94e365b32d11432

    Comments

    [iOS][MF] Hide and show password icon
    
    Hide password icon when no passwords are available and show it again
    if passwords become available.
    
    Updates SavePasswordsConsumer to post empty results and adds an early
    return where this was expected to keep the same behavior.
    
    Bug: 878388
    Change-Id: Ie4948d3b68e1ce00fa34f37f9207d64fca174ceb
    Reviewed-on: https://chromium-review.googlesource.com/c/1333427
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608094}

    Changed files

    • ios/chrome/browser/autofill/manual_fill/passwords_fetcher.mm
    • ios/chrome/browser/autofill/manual_fill/passwords_fetcher_unittest.mm
    • ios/chrome/browser/passwords/save_passwords_consumer.mm
    • ios/chrome/browser/ui/autofill/BUILD.gn
    • ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm
    • ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
  18. [ios] Add fakebox focus helper to content suggestions egtest.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 19:47:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dce02bb5413cd52c65926b26425f8d3205b2e9c2

    Comments

    [ios] Add fakebox focus helper to content suggestions egtest.
    
    Bug: 866281
    Change-Id: Idedb310b57b39c532b31b8755eb61886742639c6
    Reviewed-on: https://chromium-review.googlesource.com/c/1334857
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608093}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
  19. Reland of "Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots."

    Changed by Steven Valdez - svaldezohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:45:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50a3d2c99e0d05cb8051399f17f630c8707ff298

    Comments

    Reland of "Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots."
    
    Using an explicit string in about_flags to avoid static initializer.
    
    Bug: boringssl:226
    Change-Id: I095c5060e903eb610576705acd760a535e55325e
    Reviewed-on: https://chromium-review.googlesource.com/c/1335872
    Commit-Queue: Steven Valdez <svaldez@chromium.org>
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608092}

    Changed files

    • chrome/browser/about_flags.cc
    • net/socket/ssl_client_socket_impl.cc
    • net/socket/ssl_client_socket_unittest.cc
  20. Roll src/third_party/angle d1a55e393e65..fca8fd620190 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 19:45:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d483396d85ca738c0aef8d81dbafcd06ee2d9588

    Comments

    Roll src/third_party/angle d1a55e393e65..fca8fd620190 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/d1a55e393e65..fca8fd620190
    
    
    git log d1a55e393e65..fca8fd620190 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 syoussefi@chromium.org Vulkan: Refix cleanup race condition on Context destroy
    2018-11-14 syoussefi@chromium.org Vulkan: prepare for ES3
    
    
    Created with:
      gclient setdep -r src/third_party/angle@fca8fd620190
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:904846
    TBR=cwallez@chromium.org
    
    Change-Id: I53bef44de36347ad8e04b502c461208a7c35e581
    Reviewed-on: https://chromium-review.googlesource.com/c/1335777
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608091}

    Changed files

    • DEPS
  21. Remove failure expectation for fixed driver bug.

    Changed by James Darpinian - jdarpinianohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:44:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31eba634451cfb44f7f987b38a8cae34c2871463

    Comments

    Remove failure expectation for fixed driver bug.
    
    Bug: 648337
    TBR: kbr@chromium.org
    Change-Id: I3389e93cbbe0c6361311d6bd6673bddbcea8f834
    Reviewed-on: https://chromium-review.googlesource.com/c/1334510
    Reviewed-by: James Darpinian <jdarpinian@chromium.org>
    Commit-Queue: James Darpinian <jdarpinian@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608090}

    Changed files

    • content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
  22. Stop using VisiblePosition in FrameSelection::SelectWordAroundCaret

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:44:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 404ec3769c6cd8537cbab7757a27e78309a32b64

    Comments

    Stop using VisiblePosition in FrameSelection::SelectWordAroundCaret
    
    This patch changes FrameSelection::SelectWordAroundCaret to use
    VisiblePosition-free versions of word boundary algorithms to reduce
    usage of VisiblePosition.
    
    Bug: 657237
    Change-Id: I1605f77a86332fa20caa7966454fbf1307c10cea
    Reviewed-on: https://chromium-review.googlesource.com/c/1330752
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608089}

    Changed files

    • third_party/blink/renderer/core/editing/frame_selection.cc
  23. Remove red warning icon from public session login page

    Changed by Zakhar Voit - voitohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 19:42:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7488f36809d7a737ae81934b8bf16985243725e6

    Comments

    Remove red warning icon from public session login page
    
    This is a temporary change until we support managed
    sessions properly and can show the UI based on
    whether we run public session or managed session.
    
    Bug: 905317
    Change-Id: I03c15f2d0bc59ed9a86d4da86aa62590721366eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1335584
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
    Commit-Queue: Zakhar Voit <voit@google.com>
    Cr-Commit-Position: refs/heads/master@{#608088}

    Changed files

    • ash/login/ui/login_expanded_public_account_view.cc
  24. viz: DCHECK that clients don't send empty frames

    Changed by Sunny Sachanandani - sunnypsohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:42:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b44653f942d0b1a2265417a93134cc67a7e7fa55

    Comments

    viz: DCHECK that clients don't send empty frames
    
    The service rejects a CompostiorFrame if it has an empty render pass
    list, or an empty output rect.  Add a DCHECK to ensure that clients
    don't send these.
    
    Change-Id: I2a1a25fab8b2e01f5355eaf0378c98d730490863
    Reviewed-on: https://chromium-review.googlesource.com/c/1335268
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608087}

    Changed files

    • services/viz/public/cpp/compositing/compositor_frame_struct_traits.h
  25. Add CSP meta detection to HTMLPreloadScanner::Scan

    Changed by Richard Townsend - Richard.Townsendohnoyoudont@arm.com
    Changed at Wednesday, 14-Nov-18 19:40:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d9cd7eec7fc024ebb8debfabae0f745dc706152

    Comments

    Add CSP meta detection to HTMLPreloadScanner::Scan
    
    The content-security policy meta tag must be read before preloads can
    be dispatched. This change allows the foreground HTML parser to use a
    single HTMLPreloadScanner to read when this tag's been consumed.
    It can then dispatch preloads at the correct time.
    
    Bug: 901056
    
    Change-Id: I70d0c75132b4203992f3b9d16db5c4442037ab13
    Reviewed-on: https://chromium-review.googlesource.com/c/1320853
    Commit-Queue: Richard Townsend <richard.townsend@arm.com>
    Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608086}

    Changed files

    • third_party/blink/renderer/core/html/parser/html_document_parser.cc
    • third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
    • third_party/blink/renderer/core/html/parser/html_preload_scanner.h
    • third_party/blink/renderer/core/html/parser/html_preload_scanner_fuzzer.cc
    • third_party/blink/renderer/core/html/parser/html_preload_scanner_test.cc
  26. Import wpt@f082fd63300fec7b6201cf5e0eaf0944ee7ccb6e

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 19:39:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0661bc2fe5c8daa081d8ea7f5e950654fcbd4df6

    Comments

    Import wpt@f082fd63300fec7b6201cf5e0eaf0944ee7ccb6e
    
    Using wpt-import in Chromium 2dba2177324a3d5adf7f07d8d693976551880323.
    With Chromium commits locally applied on WPT:
    39c398adaa "Worklet: Modernize service worker interception tests for worklets using async/await"
    f482e77e59 "Add report-only mode to Feature Policy"
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hbos@chromium.org, hta@chromium.org:
      external/wpt/webrtc
    yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
      external/wpt/fetch
    
    NOAUTOREVERT=true
    TBR=kyleju
    
    No-Export: true
    Change-Id: I4fa4ae9132e88c9ff3252692d06958168b5d6e5d
    Reviewed-on: https://chromium-review.googlesource.com/c/1336031
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608085}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/fetch/sec-metadata/resources/record-header.py
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpTransceiver.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpTransceiver.https.html
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpTransceiver.https-expected.txt
  27. Move the JSON parser into a general Parser interface

    Changed by Joe Mason - joenotcharlesohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 19:37:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9bb61a5504151697a0eb07f2fbb54c0bf62bb8d4

    Comments

    Move the JSON parser into a general Parser interface
    
    This also moves json_parser into a parsers subdir. More parsers that
    run in the same sandbox will be added in followups.
    
    R=csharp
    
    Bug: 830892
    Change-Id: I8c73d7a88d03f62dd817bd9c834bd9a61783eb5b
    Reviewed-on: https://chromium-review.googlesource.com/c/1329893
    Commit-Queue: Joe Mason <joenotcharles@google.com>
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Ken Rockot <rockot@google.com>
    Reviewed-by: Chris Sharp <csharp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608084}

    Changed files

    • chrome/chrome_cleaner/BUILD.gn
    • chrome/chrome_cleaner/DEPS
    • chrome/chrome_cleaner/chrome_utils/BUILD.gn
    • chrome/chrome_cleaner/chrome_utils/extensions_util.h
    • chrome/chrome_cleaner/chrome_utils/extensions_util_unittest.cc
    • chrome/chrome_cleaner/components/BUILD.gn
    • chrome/chrome_cleaner/components/system_report_component.cc
    • chrome/chrome_cleaner/components/system_report_component.h
    • chrome/chrome_cleaner/components/system_report_component_unittest.cc
    • chrome/chrome_cleaner/crash/crashpad_crash_client.cc
    • chrome/chrome_cleaner/interfaces/BUILD.gn
    • chrome/chrome_cleaner/interfaces/json_parser.mojom
    • chrome/chrome_cleaner/interfaces/parser_interface.mojom
    • chrome/chrome_cleaner/ipc/sandbox.cc
    • chrome/chrome_cleaner/json_parser/DEPS
    • chrome/chrome_cleaner/json_parser/json_parser_impl.h
    • chrome/chrome_cleaner/json_parser/json_splicer.h
    • chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.cc
    • chrome/chrome_cleaner/json_parser/sandbox_setup_hooks.h
    • chrome/chrome_cleaner/json_parser/sandbox_target_hooks.cc
    • chrome/chrome_cleaner/json_parser/sandbox_target_hooks.h
    • chrome/chrome_cleaner/json_parser/sandboxed_json_parser.cc
    • chrome/chrome_cleaner/json_parser/sandboxed_json_parser.h
    • chrome/chrome_cleaner/logging/proto/shared_data.proto
    • chrome/chrome_cleaner/logging/utils.cc
    • chrome/chrome_cleaner/parsers/DEPS
    • chrome/chrome_cleaner/parsers/broker/BUILD.gn
    • chrome/chrome_cleaner/parsers/broker/json_parser_sandbox_setup_unittest.cc
    • chrome/chrome_cleaner/parsers/broker/sandbox_setup_hooks.cc
    • chrome/chrome_cleaner/parsers/broker/sandbox_setup_hooks.h
    • chrome/chrome_cleaner/parsers/json_parser/BUILD.gn
    • chrome/chrome_cleaner/parsers/json_parser/json_parser_api.h
    • chrome/chrome_cleaner/parsers/json_parser/json_splicer.cc
    • chrome/chrome_cleaner/parsers/json_parser/json_splicer.h
    • chrome/chrome_cleaner/parsers/json_parser/json_splicer_unittest.cc
    • chrome/chrome_cleaner/parsers/json_parser/sandboxed_json_parser.cc
    • chrome/chrome_cleaner/parsers/json_parser/sandboxed_json_parser.h
    • chrome/chrome_cleaner/parsers/json_parser/test_json_parser.cc
    • chrome/chrome_cleaner/parsers/json_parser/test_json_parser.h
    • chrome/chrome_cleaner/parsers/target/BUILD.gn
    • chrome/chrome_cleaner/parsers/target/parser_impl.cc
    • chrome/chrome_cleaner/parsers/target/parser_impl.h
    • chrome/chrome_cleaner/parsers/target/parser_impl_unittest.cc
    • chrome/chrome_cleaner/parsers/target/sandbox_setup.cc
    • chrome/chrome_cleaner/parsers/target/sandbox_setup.h
    • chrome/chrome_cleaner/settings/settings_types.h
  28. Remove some DestructorAtExit LazyInstances.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:36:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2cfceacd244692996b25004d58240d4decb38dde

    Comments

    Remove some DestructorAtExit LazyInstances.
    
    There do not need to be destroyed. So switch over to NoDestructor.
    
    Change-Id: Ie4ffb45a9b38188716a2bc3f1290bbbb3b64e939
    Reviewed-on: https://chromium-review.googlesource.com/c/1330915
    Reviewed-by: Scott Graham <scottmg@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608083}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
    • chrome/browser/extensions/install_signer.cc
    • chrome/browser/first_run/first_run.cc
    • chrome/browser/resources_util.cc
    • chrome/browser/ui/extensions/extension_message_bubble_factory.cc
    • chrome/common/chrome_paths.cc
    • chrome/renderer/pepper/pepper_flash_renderer_host.cc
    • chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
  29. Prevent stack overflow on Windows

    Changed by Jonathan Metzman - metzmanohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:35:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcae318ae5cea468d3d9fec9600231a258c5d6c4

    Comments

    Prevent stack overflow on Windows
    
    Bug: 895233
    Change-Id: I4beea124124a9f773d5d32db2957be1a2c5dfdd0
    Reviewed-on: https://chromium-review.googlesource.com/c/1334933
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Marja Hölttä <marja@chromium.org>
    Commit-Queue: Jonathan Metzman <metzman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608082}

    Changed files

    • testing/libfuzzer/fuzzers/generate_javascript_parser_proto.py
  30. Roll src/third_party/chromite d5fa47311da1..88c15c341d97 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 19:34:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 47cb346fad30d1525291f47162b5369324bac6aa

    Comments

    Roll src/third_party/chromite d5fa47311da1..88c15c341d97 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/d5fa47311da1..88c15c341d97
    
    
    git log d5fa47311da1..88c15c341d97 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 dgarrett@google.com chromeos_config: All firmwarebranch builds on 30 day schedule.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@88c15c341d97
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Ieac55be458a1ff24cb9291fbb7681d0929d7d661
    Reviewed-on: https://chromium-review.googlesource.com/c/1335838
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608081}

    Changed files

    • DEPS
  31. Remove IsGpuCompositingEnabled from CRC creation

    Changed by Fernando Serboncini - fserbohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:31:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 71ad9d982ba44c7bee89f616b481bbda3c47a3bf

    Comments

    Remove IsGpuCompositingEnabled from CRC creation
    
    
    
    TBR=zakerinasab@chromium.org
    
    Bug: 903101,840371
    Change-Id: I855ea360aefab4aae00b991f1000fa55e3f49935
    Reviewed-on: https://chromium-review.googlesource.com/c/1336079
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608080}

    Changed files

    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
  32. Add DnsQueryType to HostCache::Key

    Changed by Eric Orth - ericorthohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:30:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 192e3bbaa4a34c21ab43e63a0839acd9d070afe9

    Comments

    Add DnsQueryType to HostCache::Key
    
    Preparing to handle non-address results in HostResolver and HostCache.
    First step is to switch HostCache::Key from AddressFamily to the more
    general DnsQueryType and remove assumptions in HostCache and
    HostResolverImpl that the only requestable types are A and AAAA.
    
    No support yet for parsing and returning the non-address results. That
    will be added in a later CL.
    
    TBR=bbudge@chromium.org,tsepez@chromium.org
    
    Bug: 846423
    Change-Id: Ie921de57bd744e1796321c7d5706057c0db074d2
    Reviewed-on: https://chromium-review.googlesource.com/c/1327232
    Commit-Queue: Eric Orth <ericorth@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608079}

    Changed files

    • content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc
    • content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h
    • net/dns/BUILD.gn
    • net/dns/dns_util.cc
    • net/dns/dns_util.h
    • net/dns/host_cache.cc
    • net/dns/host_cache.h
    • net/dns/host_cache_unittest.cc
    • net/dns/host_resolver.cc
    • net/dns/host_resolver.h
    • net/dns/host_resolver_impl.cc
    • net/dns/host_resolver_impl.h
    • net/dns/host_resolver_impl_unittest.cc
    • net/dns/host_resolver_mdns_task.cc
    • net/dns/host_resolver_mdns_task.h
    • net/dns/mock_host_resolver.cc
    • net/dns/mock_host_resolver.h
    • net/dns/public/BUILD.gn
    • net/dns/public/dns_query_type.cc
    • net/dns/public/dns_query_type.h
    • services/network/host_resolver_unittest.cc
    • services/network/network_context_unittest.cc
    • services/network/public/cpp/host_resolver.typemap
    • services/network/public/cpp/host_resolver_mojom_traits.cc
    • services/network/public/cpp/host_resolver_mojom_traits.h
  33. [media] Lower log level for VTVDA initialization failure.

    Changed by Dan Sanders - sandersdohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:29:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2810c4cdabdde1085bf671b249d952b1699dc155

    Comments

    [media] Lower log level for VTVDA initialization failure.
    
    It is expected that initialization will fail when it is not supported by
    the hardware, so lower these from DLOG(WARN) to DVLOG(1).
    
    Failure to create a software decode session is still DLOG(WARN) because
    this should work on all hardware.
    
    Bug: 903656
    Change-Id: I7bd62051c4c1d9082731b393d44166971f1aa0f6
    Reviewed-on: https://chromium-review.googlesource.com/c/1334849
    Reviewed-by: Miguel Casas <mcasas@chromium.org>
    Commit-Queue: Dan Sanders <sandersd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608078}

    Changed files

    • media/gpu/vt_video_decode_accelerator_mac.cc
  34. Roll src-internal 8eae8558004a..93345bb86e3d (6 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 19:28:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9df075754a778b42342f8f833f05db63f43b8a8d

    Comments

    Roll src-internal 8eae8558004a..93345bb86e3d (6 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8eae8558004a..93345bb86e3d
    
    
    Created with:
      gclient setdep -r src-internal@93345bb86e3d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I2101e2d29186d18cfc7a23e1909138fc833cfef5
    Reviewed-on: https://chromium-review.googlesource.com/c/1335835
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608077}

    Changed files

    • DEPS
  35. Make tab view order match tab strip model order

    Changed by Collin Baker - collinbakerohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:28:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49b47da02e0975e274eb7e6328cc16975bcb31e4

    Comments

    Make tab view order match tab strip model order
    
    Bug: 897086
    Change-Id: Idfd8e9a68c663ba3e560a6f2443b2a468cdd3c65
    Reviewed-on: https://chromium-review.googlesource.com/c/1331617
    Commit-Queue: Collin Baker <collinbaker@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608076}

    Changed files

    • chrome/browser/ui/views/tabs/tab_strip.cc
    • chrome/browser/ui/views/tabs/tab_strip_unittest.cc
  36. [ios] Drop iOS10 specific code.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 19:27:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 58a6b4910cafd88be5a971e6cbd5e10171f91524

    Comments

    [ios] Drop iOS10 specific code.
    
    875528, 875528, 750185, 850814
    
    Bug: 894099, 766951, 836808, 740987, 765146, 826369, 730461, 869176,
    Change-Id: I07b3ab43cff3d4d4f17349fe5eff9070fef5d437
    Reviewed-on: https://chromium-review.googlesource.com/c/1335207
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608075}

    Changed files

    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/autofill/autofill_controller_unittest.mm
    • ios/chrome/browser/autofill/form_input_accessory_view.mm
    • ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
    • ios/chrome/browser/drag_and_drop/drop_and_navigate_interaction_unittest.mm
    • ios/chrome/browser/metrics/drag_and_drop_recorder.mm
    • ios/chrome/browser/net/cookie_util.mm
    • ios/chrome/browser/net/cookie_util_unittest.mm
    • ios/chrome/browser/prerender/prerender_egtest.mm
    • ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm
    • ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
    • ios/chrome/browser/snapshots/snapshot_tab_helper.mm
    • ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
    • ios/chrome/browser/ui/app_launcher/open_mail_handler_view_controller.mm
    • ios/chrome/browser/ui/authentication/consent_bump/consent_bump_option_button.mm
    • ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_view_controller.mm
    • ios/chrome/browser/ui/authentication/consent_bump/consent_bump_view_controller.mm
    • ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_cell.mm
    • ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_presentation_controller.mm
    • ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
    • ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
    • ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
    • ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
    • ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/bubble/bubble_view_unittest.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
    • ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
    • ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
    • ios/chrome/browser/ui/find_bar/find_bar_view.mm
    • ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
    • ios/chrome/browser/ui/fullscreen/fullscreen_system_notification_observer.mm
    • ios/chrome/browser/ui/history/history_table_view_controller.mm
    • ios/chrome/browser/ui/history/history_ui_egtest.mm
    • ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
    • ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.mm
    • ios/chrome/browser/ui/ntp/incognito_view.mm
    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
    • ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
    • ios/chrome/browser/ui/payments/cells/page_info_item.mm
    • ios/chrome/browser/ui/payments/cells/payments_selector_edit_item.mm
    • ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm
    • ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
    • ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
    • ios/chrome/browser/ui/print/print_controller_egtest.mm
    • ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
    • ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
    • ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
    • ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
    • ios/chrome/browser/ui/settings/settings_navigation_controller.mm
    • ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
    • ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
    • ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
    • ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
    • ios/chrome/browser/ui/tab_grid/tab_grid_transition_handler.mm
    • ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
    • ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
    • ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
    • ios/chrome/browser/ui/tabs/tab_view.mm
    • ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm
    • ios/chrome/browser/ui/toolbar/primary_toolbar_view.mm
    • ios/chrome/browser/ui/toolbar/secondary_toolbar_view.mm
    • ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
    • ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller.mm
    • ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller_unittest.mm
    • ios/chrome/browser/ui/util/uikit_ui_util.h
    • ios/chrome/browser/ui/util/uikit_ui_util.mm
    • ios/chrome/browser/web/cache_egtest.mm
    • ios/chrome/common/ui_util/BUILD.gn
    • ios/chrome/common/ui_util/constraints_ui_util.h
    • ios/chrome/common/ui_util/constraints_ui_util.mm
    • ios/chrome/common/ui_util/constraints_ui_util_unittest.mm
    • ios/showcase/payments/sc_payments_picker_egtest.mm
    • ios/showcase/test/showcase_eg_utils.mm
  37. Revert "Reland "Android: Allow proguard to strip unused native methods.""

    Changed by Roger Tawa - rogertaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:27:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d8af30684b21a6141ab4b4e163eb300f6cb1c4af

    Comments

    Revert "Reland "Android: Allow proguard to strip unused native methods.""
    
    This reverts commit 1a055a9b5ffeda1dd5e09f2ad6c57a93caba8253.
    
    Reason for revert: broken tree:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/4386
    
    Original change's description:
    > Reland "Android: Allow proguard to strip unused native methods."
    > 
    > Reland of dc8f3c0aba827f550bef775a6645bcbd978052f7.
    > 
    > chrome_public_test_apk is now merged with chrome_public_apk_for_test
    > which should fix the proguard issue.
    > 
    > TBR: agrieve@chromium.org
    > Bug: 688465
    > Change-Id: Ie43eae7f945e5ae444f1cb0adc0703b334402f3c
    > Reviewed-on: https://chromium-review.googlesource.com/c/1333988
    > Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    > Commit-Queue: Eric Stevenson <estevenson@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#608038}
    
    TBR=estevenson@chromium.org
    
    Change-Id: Ia718741dad550c0a4c861bd634a21232518dd161
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 688465
    Reviewed-on: https://chromium-review.googlesource.com/c/1336064
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Commit-Queue: Roger Tawa <rogerta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608074}

    Changed files

    • base/android/proguard/chromium_code.flags
    • base/android/proguard/explicit_jni_registration.flags
    • base/android/proguard/implicit_jni_registration.flags
    • build/config/android/rules.gni
    • components/cronet/android/BUILD.gn
  38. Have the DeferredTaskHandler be the source of whether tail processing handlers can be added.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:11:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bec98d732e86eaac12f258610cc49c265315ac24

    Comments

    Have the DeferredTaskHandler be the source of whether tail processing handlers can be added.
    
    Bug: 884059
    Change-Id: Iaee6daa6003c4956e6dba6d5351621b10bc0b5e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1332254
    Reviewed-by: Hongchan Choi <hongchan@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608073}

    Changed files

    • third_party/blink/renderer/modules/webaudio/audio_node.cc
    • third_party/blink/renderer/modules/webaudio/base_audio_context.cc
    • third_party/blink/renderer/modules/webaudio/deferred_task_handler.cc
    • third_party/blink/renderer/modules/webaudio/deferred_task_handler.h
  39. Use MarkAXObjectDirty()

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:07:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 085b7a32b1c1c2a60ed5ed39945d7053f83a5472

    Comments

    Use MarkAXObjectDirty()
    
    This updates the code to use MarkAXObjectDirty() where we were using a
    hack to fire value changes for generic tree changes. However, tree
    change serialization/deserialization did not handle bundles where
    there were only changed objects, and no events were provided.
    
    Bug: 902324
    Change-Id: I93f6a1ae1f2e7d835621af8f8deb6c62043454fe
    Reviewed-on: https://chromium-review.googlesource.com/c/1318361
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608072}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/renderer/accessibility/render_accessibility_impl.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
  40. [NTP] Remove 'white flash' transition from MV tiles

    Changed by Kristi Park - kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:04:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 857f4dd86add8b3f795772837969a6d699dd286a

    Comments

    [NTP] Remove 'white flash' transition from MV tiles
    
    Use smoother transition when the MV tiles are updated. This removes the
    'white flash' that is currently present.
    
    Screencast: https://screencast.googleplex.com/cast/NTM0NjkzNjMyNDM1ODE0NHxhZWM4ZWEyOS04MA
    
    Bug: 905119
    Change-Id: Ic1a7ea35b2e05bbcbcd583b2ca792a6b7c8f2dc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1334938
    Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608071}

    Changed files

    • chrome/browser/resources/local_ntp/most_visited_single.css
  41. Roll src/third_party/SPIRV-Tools/src 5beeee15c175..a6150a3fe778 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 19:03:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 80109fc5b3afc4288dcdc886058a67efb550327e

    Comments

    Roll src/third_party/SPIRV-Tools/src 5beeee15c175..a6150a3fe778 (2 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5beeee15c175..a6150a3fe778
    
    
    git log 5beeee15c175..a6150a3fe778 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 stevenperron@google.com Don't assert on void function parameters. (#2047)
    2018-11-14 stevenperron@google.com Instruction::GetBaseAddress to handle OpPtrAccessChain (#2050)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@a6150a3fe778
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: Idea0961f43f7a415cc7f644c295ff39c735c4e75
    Reviewed-on: https://chromium-review.googlesource.com/c/1335834
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608070}

    Changed files

    • DEPS
  42. Updating MacOS Host icns files to use the current CRD logo

    Changed by Joe Downing - joedowohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 19:02:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d76a59d7d13b2e5bdf1ea6c78b3c8286bff974b

    Comments

    Updating MacOS Host icns files to use the current CRD logo
    
    As part of the permission dialog work, I want to make sure that the
    icon displayed in the dialog matches that of the Chrome app and other
    clients (instead of the older icon which had two blue rectangles).
    
    The concern is that the outdated icon may make the dialog look less
    trustworthy and users might dismiss it outright instead of reading it.
    
    Bug: 902041, 757618
    Change-Id: Ia69ea7dab6d7d246302b75b199831c4048935888
    Reviewed-on: https://chromium-review.googlesource.com/c/1336058
    Commit-Queue: Joe Downing <joedow@chromium.org>
    Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608069}

    Changed files

    • remoting/host/installer/mac/uninstaller/remoting_uninstaller.icns
    • remoting/host/mac/remoting_me2me_host.icns
  43. [NTP] Fix various tile reorder issues and edit menu icon styling

    Changed by Kristi Park - kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:01:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5289121d3014801ffd79d14fb628ea0dc019aaa3

    Comments

    [NTP] Fix various tile reorder issues and edit menu icon styling
    
    - Do not start reordering if a modifier key is also held down (e.g.
      ctrl, shift, etc.)
    - Fix reorder CSS if a theme or custom background is applied.
      - With theme: https://screenshot.googleplex.com/eVSKahPM34w.png
      - With custom bg: https://screenshot.googleplex.com/mQ0hPUJ9XLs.png
      - With theme and custom bg: https://screenshot.googleplex.com/XkSBSEtpxV1.png
    - For themes/custom backgrounds, keep the edit menu icon white when
      focused using keyboard navigation. This makes it slightly easier to
      see on multicolored backgrounds.
      - Before: https://screenshot.googleplex.com/Agf1nZaxwwP.png
      - After: https://screenshot.googleplex.com/fPZmseG3LyN.png
    
    Bug: 851335
    Change-Id: Ic7fb6d5522dbc5b5395fadf5766ac643613a8bfd
    Reviewed-on: https://chromium-review.googlesource.com/c/1335027
    Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608068}

    Changed files

    • chrome/browser/resources/local_ntp/most_visited_single.css
    • chrome/browser/resources/local_ntp/most_visited_single.js
  44. Change engagement threshold to medium for lookalike URLs

    Changed by Mustafa Emre Acer - meacerohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 19:00:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 713805e41dce7433048320d8f0bae36abe170c80

    Comments

    Change engagement threshold to medium for lookalike URLs
    
    The current threshold is LOW which corresponds to any non-zero score. This will cause any site with a non-zero engagement score to be ignored from lookalike suggestions.
    
    The effect of this change is:
    - The navigated site will be more likely to be considered for a lookalike suggestion
    - The navigated site will be compared to fewer engaged sites
    
    Bug: 878153
    Change-Id: I19928398b207d36981736ed22e6a026263f93751
    Reviewed-on: https://chromium-review.googlesource.com/c/1334851
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608067}

    Changed files

    • chrome/browser/ui/omnibox/lookalike_url_navigation_observer.cc
    • chrome/browser/ui/omnibox/lookalike_url_navigation_observer_browsertest.cc
  45. Stop using VisiblePosition in GranularityStrategy's NextWordBound

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:57:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ddd786854125de5ea99b7878970502b0cd60cd1

    Comments

    Stop using VisiblePosition in GranularityStrategy's NextWordBound
    
    This patch changes the function to use VisiblePosition-free versions
    of Start/EndOfWord, and hoists the creation of VisiblePosition to
    callers to reduce the usage of VisiblePosition.
    
    Bug: 657237
    Change-Id: I8565ab3fa839b79c3e464c8622fc7a75161cc621
    Reviewed-on: https://chromium-review.googlesource.com/c/1330755
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608066}

    Changed files

    • third_party/blink/renderer/core/editing/granularity_strategy.cc
  46. Enable media holdback experiment by default

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:56:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 304bca03503f89c8c671c10f36d9b8985af36918

    Comments

    Enable media holdback experiment by default
    
    Change-Id: Ibbdd75e179458b401f2e5ff3a61a415865769351
    Bug: 905095
    Reviewed-on: https://chromium-review.googlesource.com/c/1335274
    Reviewed-by: rajendrant <rajendrant@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608065}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
  47. Change default selection in getDisplayMedia to cancel

    Changed by Emircan Uysaler - emircanohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:55:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b573fcc404ab3c3e2917a12b2c41e7ff6c202cf3

    Comments

    Change default selection in getDisplayMedia to cancel
    
    To prevent permissions being accepted accidentally, permission prompts should
    not be accepted as the default action. This CL changes default selection to
    cancel button to reflect that.
    
    Bug: 326740
    Change-Id: I29d3e5c61c6a56546c7d9ada0824d3fccb91bc4f
    Reviewed-on: https://chromium-review.googlesource.com/c/1334856
    Reviewed-by: Christopher Thompson <cthomp@chromium.org>
    Reviewed-by: Qiang Chen <qiangchen@chromium.org>
    Commit-Queue: Emircan Uysaler <emircan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608064}

    Changed files

    • chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
    • chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
    • chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_browsertest.cc
  48. Add fine grained DEPS rules in chrome/ for pdf/ usage.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:53:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a27b84f1603b4c08abef95c5597076d3781aa3c

    Comments

    Add fine grained DEPS rules in chrome/ for pdf/ usage.
    
    There are several public headers in pdf/ now. Better restrict which ones
    should be used where.
    
    Change-Id: I1cb4d746391bfbd6b41d98785c30a6d4309751b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1330991
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: dsinclair <dsinclair@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608063}

    Changed files

    • chrome/DEPS
    • chrome/app/DEPS
    • chrome/browser/printing/DEPS
    • chrome/services/printing/DEPS
  49. Enable some browser tests that previously DCHECKed.

    Changed by Evan Stade - estadeohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 18c6c9fed214304438154c0add76b1d0754bcf0f

    Comments

    Enable some browser tests that previously DCHECKed.
    
    Bug: 879030
    Change-Id: I4483a426013086588b0801485a241424d2c426b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1334270
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Reviewed-by: Matt Giuca <mgiuca@chromium.org>
    Commit-Queue: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608062}

    Changed files

    • chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc
  50. [perf] Add load:search:yandex:2018 system health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:48:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 549d02200c4f55b012111adb07eccc1005887444

    Comments

    [perf] Add load:search:yandex:2018 system health story
    
    This CL was created automatically with tools/perf/update_wpr script
    
    There are a couple of failing requests to https://yandex.ru/clck/safeclick/
    
    R=perezju@chromium.org
    
    Bug: 878390
    Change-Id: Ifcc0cddbb43496c50abdc6ebbc3f5aabc52c3f10
    Reviewed-on: https://chromium-review.googlesource.com/c/1329749
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608061}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_84d11cb3d6.wprgo.sha1
    • tools/perf/page_sets/data/system_health_mobile.json
    • tools/perf/page_sets/data/system_health_mobile_5d042249d1.wprgo.sha1
    • tools/perf/page_sets/system_health/loading_stories.py
  51. Let SequenceManager bind to MessageLoopCurrent

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:46:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 605c203135d75b2d07855ecc3a41b84ae29dca88

    Comments

    Let SequenceManager bind to MessageLoopCurrent
    
    This is a step towards introducing a UIThreadScheduler which will
    have a SequenceManager rather than a MessageLoop on the UI thread.
    
    We also remove the SequenceManager from base::Thread since we no longer
    considering having anything other than a FIFO scheduler there.
    
    TBR=marq@chromium.org
    
    Bug: 863341, 891670
    Change-Id: If1603e623688a5bb4d0ca71b2b55bc50ffb9c506
    Reviewed-on: https://chromium-review.googlesource.com/c/1320329
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608060}

    Changed files

    • base/message_loop/message_loop.cc
    • base/message_loop/message_loop.h
    • base/message_loop/message_loop_current.cc
    • base/message_loop/message_loop_current.h
    • base/message_loop/message_loop_impl.cc
    • base/message_loop/message_loop_impl.h
    • base/message_loop/message_loop_task_runner_unittest.cc
    • base/task/sequence_manager/sequence_manager.h
    • base/task/sequence_manager/sequence_manager_impl.cc
    • base/task/sequence_manager/sequence_manager_impl.h
    • base/task/sequence_manager/sequence_manager_impl_unittest.cc
    • base/task/sequence_manager/sequence_manager_perftest.cc
    • base/task/sequence_manager/test/lazy_thread_controller_for_test.cc
    • base/task/sequence_manager/test/sequence_manager_for_test.cc
    • base/task/sequence_manager/test/sequence_manager_for_test.h
    • base/task/sequence_manager/thread_controller.h
    • base/task/sequence_manager/thread_controller_impl.cc
    • base/task/sequence_manager/thread_controller_impl.h
    • base/task/sequence_manager/thread_controller_with_message_pump_impl.cc
    • base/task/sequence_manager/thread_controller_with_message_pump_impl.h
    • ios/web/public/test/test_web_thread_bundle.h
    • ios/web/test/test_web_thread_bundle.cc
    • third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
    • third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_unittest.cc
  52. Migrate SigninManagerAndroid to the IdentityManager

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Wednesday, 14-Nov-18 18:38:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 487f0f4e635c69b413e2ee79489805da0050a842

    Comments

    Migrate SigninManagerAndroid to the IdentityManager
    
    Move away from SigninManager[Base] in favor of the IdentityManager
    for every single API call except for OnExternalSigninCompleted(),
    which hasn't got mapped yet to the IdentityManager (crbug.com/889902).
    
    Bug: 882464
    Change-Id: I68c8b4845caaed59dd9b2650da977fac74be06b4
    Reviewed-on: https://chromium-review.googlesource.com/c/1333390
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608059}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/android/signin/signin_manager_android.cc
    • chrome/browser/android/signin/signin_manager_android.h
  53. Use mouse click as a backup way to place focus in tests.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 18:36:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3ce18059af578b6f9c45bdd275edf3c6cbf55ad

    Comments

    Use mouse click as a backup way to place focus in tests.
    
    The Captured Sites Automation Framework interacts with real-world pages.
    Some test actions, such as triggering autofill or typing password,
    require the automation to place focus on page elements.
    
    The framework currently invokes JavaScript's 'HtmlElement.focus()'
    method to place focus on an element. However, it came to my attention
    that this method occasionally fail on some test machines. This change
    introduces mouse left click as a backup way to place focus on an
    element, if JavaScript fails.
    
    Fixed focus function in Capture Sites Test Framework.
    
    The Captured Sites Test Framework uses JavaScript's .focus function to
    place focus on a html element. This apparently fails from time to time
    on some machines. This fix adds a left mouse click action to the element
    if focus via script fails.
    
    Bug: 847905
    Change-Id: Idef08ac1e9adb225889d5da35d8f426bf4663f3e
    Reviewed-on: https://chromium-review.googlesource.com/c/1332716
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Cr-Commit-Position: refs/heads/master@{#608058}

    Changed files

    • chrome/browser/autofill/captured_sites_test_utils.cc
  54. auto-fetch: store tab ID in ClientId

    Changed by Dan Harrington - harringtondohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 847e913a24a005925f33267c1ba40da5e053fb03

    Comments

    auto-fetch: store tab ID in ClientId
    
    This changes how the ClientId is generated for this feature. The tabID
    is not used yet, but will be
    needed to implement the system notification correctly.
    
    I manually verified that FindTab() returns the correct ID.
    
    Bug: 883486
    Change-Id: I466fc5d3eb1b6f373d969a3d8eb88de7e96854ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1327409
    Commit-Queue: Dan H <harringtond@google.com>
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608057}

    Changed files

    • chrome/browser/offline_pages/offline_page_auto_fetcher.cc
    • chrome/browser/offline_pages/offline_page_auto_fetcher_service.cc
    • chrome/browser/offline_pages/offline_page_auto_fetcher_service.h
    • chrome/browser/offline_pages/offline_page_auto_fetcher_service_unittest.cc
    • components/offline_pages/core/BUILD.gn
    • components/offline_pages/core/auto_fetch.cc
    • components/offline_pages/core/auto_fetch.h
    • components/offline_pages/core/auto_fetch_unittest.cc
  55. Record SWR candidates for non SWR revalidation requests.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:30:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 048ae5804fca8912b4badf95764326ca6efbd651

    Comments

    Record SWR candidates for non SWR revalidation requests.
    
    Revalidation requests would get tagged as SWR candidates when
    the revalidation occurred causing skew in the histograms.
    
    BUG=348877
    
    Change-Id: I5d713b9d18513337d7ef9379effda8495ddcad4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1334662
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608056}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
  56. [ios] Add BVC URL opening integration tests

    Changed by edchin - edchinohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:25:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ce3170f04a74230ec1952c899c5e04abc448830d

    Comments

    [ios] Add BVC URL opening integration tests
    
    This CL converts 2 tests in url_opener_unittest.mm from unit tests to
    integreation tests.
    The unit tests were poor tests because:
    1) They test the logic inside URLOpener as well as MainController
    2) They expose BVC as settable public API in MainController for testing
    3) They expose private tab creation API in BVC for testing
    
    Change-Id: Ie442c7ba26d15350f4a13761a32c1666fdb764f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1334850
    Commit-Queue: edchin <edchin@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608055}

    Changed files

    • ios/chrome/app/application_delegate/url_opener_unittest.mm
    • ios/chrome/browser/ui/browser_view_controller_egtest.mm
  57. [perf] Add load:media:flickr:2018 system health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:23:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a8b751c114437335fa21cb6a570b9297c52d48b5

    Comments

    [perf] Add load:media:flickr:2018 system health story
    
    This CL was created automatically with tools/perf/update_wpr script
    Two failing requests due to ad scripts.
    
    R=perezju@chromium.org
    
    Bug: 878390
    Change-Id: I1f83c87567f3af80484b5ddbba32f57923706587
    Reviewed-on: https://chromium-review.googlesource.com/c/1329626
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608054}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_ae117f4f81.wprgo.sha1
    • tools/perf/page_sets/data/system_health_mobile.json
    • tools/perf/page_sets/data/system_health_mobile_3d332e7f0f.wprgo.sha1
    • tools/perf/page_sets/system_health/loading_stories.py
  58. Add Windows ARM64 stack frame extraction from OS context record.

    Changed by Tom Tan - Tom.Tanohnoyoudont@microsoft.com
    Changed at Wednesday, 14-Nov-18 18:20:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15d3ed39bb85253ea0f8b20a472eafdd0f570526

    Comments

    Add Windows ARM64 stack frame extraction from OS context record.
    
    Bug: 893460
    Change-Id: Iff38ac0d8b65c28ad531b1c3d3d8d2842bb76e40
    Reviewed-on: https://chromium-review.googlesource.com/c/1330714
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#608053}

    Changed files

    • base/debug/stack_trace_win.cc
  59. [Accessibility] Add histograms for Android reduce-motion API

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:19:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a73dfdba61d1ad37d885ccecbcb9868de5c05c7f

    Comments

    [Accessibility] Add histograms for Android reduce-motion API
    
    This histogram will be used to guide the implementation of the CSS
    prefers-reduced-motion media feature. The primary goal is to compare
    usage levels across platforms.
    
    Bug: 722548
    Change-Id: I9162d4e9df2e04afa0c8716266c2f0dc2c57b2ac
    Reviewed-on: https://chromium-review.googlesource.com/c/1330827
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608052}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/accessibility/browser_accessibility_state_impl.cc
    • content/browser/accessibility/browser_accessibility_state_impl_android.cc
    • content/public/android/BUILD.gn
    • content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityState.java
    • tools/metrics/histograms/histograms.xml
  60. cros: Eliminate usage of AshTestBase in login tests

    Changed by Jacob Dufault - jdufaultohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 18:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8367c32cd696e49d39867731a2b40c7f7f5221a1

    Comments

    cros: Eliminate usage of AshTestBase in login tests
    
    Bug: 905109
    Change-Id: Iff9db5d47f2086156a0170bd3cf0efc058b40812
    Reviewed-on: https://chromium-review.googlesource.com/c/1334931
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608051}

    Changed files

    • chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc
  61. Add a win-dawn-rel builder to be triggered from the Dawn CQ

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:18:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 86fb5cfcb0361bcc346aaf9a70247a2cc29693c7

    Comments

    Add a win-dawn-rel builder to be triggered from the Dawn CQ
    
    This builder will run the dawn_end2end_tests on the GPU swarming bots
    through the Chromium recipe.
    
    BUG=chromium:901830
    
    Change-Id: Ic943058c3b46119222509c6a435f0b83a305590f
    Reviewed-on: https://chromium-review.googlesource.com/c/1325992
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608050}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
  62. views: don't allow bookmark menus to be repositioned next to the anchor

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:18:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df1012dd8ee8b887f87383d6649e209e45bc6ed0

    Comments

    views: don't allow bookmark menus to be repositioned next to the anchor
    
    Doing this prevents easy "scrubbing" through the bookmark bar menus, since the
    newly-appearing menu draws over the top of the adjacent bookmark buttons.
    
    Bug: 902344
    Change-Id: Ief783f4b417810416821b717f92f796b4e6b07e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1335870
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608049}

    Changed files

    • chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc
    • chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h
    • ui/views/controls/menu/menu_controller.cc
    • ui/views/controls/menu/menu_delegate.cc
    • ui/views/controls/menu/menu_delegate.h
  63. Roll src/third_party/webrtc 76f9954b17a4..fdc635d2a8ff (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 18:17:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41a5f8f54885b45286a29374a0e2c71bf8bdb716

    Comments

    Roll src/third_party/webrtc 76f9954b17a4..fdc635d2a8ff (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/76f9954b17a4..fdc635d2a8ff
    
    
    git log 76f9954b17a4..fdc635d2a8ff --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 terelius@webrtc.org Remove deprecated APIs from RTC event log parser.
    2018-11-14 magjed@webrtc.org Android EglRenderer: Replace unicoce character with ascii character
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@fdc635d2a8ff
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ic592e1678c27e13d919cd63d2c0b6bf941aa110a
    Reviewed-on: https://chromium-review.googlesource.com/c/1335832
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608048}

    Changed files

    • DEPS
  64. Add user action to traces under UI category

    Changed by Etienne Bergeron - etiennebohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:17:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c87cdc98f7d6ef88c242ddfedd916085fa68d418

    Comments

    Add user action to traces under UI category
    
    This CL is adding a trace event for each user RecordComputedAction
    (see base/metrics/user_metrics.cc). This is helping to understand the
    user interaction.
    
    These events are activated under the "UI" tracing category.
    
    R=asvitkine@chromium.org, oysteine@chromium.org
    
    Change-Id: I180372c97293ce4da1d290e70f065d54da23bb2f
    Reviewed-on: https://chromium-review.googlesource.com/c/1327218
    Reviewed-by: oysteine <oysteine@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608047}

    Changed files

    • base/metrics/user_metrics.cc
  65. Add about:flags entry for "pdf-form-save" feature.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:16:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 802201cb0726cea4498b8fccb5a2553685fe3b5a

    Comments

    Add about:flags entry for "pdf-form-save" feature.
    
    Also put the "pdf-isolation" feature behind the same ifdef. These
    features should only be available when plugins are enabled at compile
    time.
    
    Bug: 61248
    Change-Id: Ia928ea89d197d2f94d80e1e67c8ac8ece13548f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1330846
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608046}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • pdf/BUILD.gn
    • pdf/out_of_process_instance.cc
    • pdf/pdf_features.cc
    • pdf/pdf_features.h
    • tools/metrics/histograms/enums.xml
  66. Layout test text dump rebaseline using Element.innerText part 9

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:16:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41823459c5891dab0a7f452eeb4913c916f61ecf

    Comments

    Layout test text dump rebaseline using Element.innerText part 9
    
    This patch changes tests in the following directories to use
    Element.innerText for text dump:
    
    LayoutTests/h* - LayoutTests/o*
    
    Most of this patch is mechanical rebaseline, except that:
    - Some LayoutNG-specific baselines become redundant and
      are removed.
    - Two LayoutNG-specific baselines are added due to different
      treatments of formatting characters in legacy and NG innerText
      implementations.
    
    Bug: 887148
    Change-Id: I433fc4cf279a95e71a5b21fd84780fa6825dd8dd
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/1331747
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608045}

    Changed files

    • content/shell/test_runner/test_interfaces.cc
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/harness-tests/special-characters-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/html/dialog/form-method-dialog-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/html/dialog/inert-label-focus-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/html/dialog/inert-node-is-unselectable-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/html/tabular_data/table_border_invalid-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/color-profile-background-image-cross-fade-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/color-profile-background-image-cross-fade-png-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/color-profile-image-filter-all-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/color-profile-image-pseudo-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/color-profile-munsell-adobe-to-srgb-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/color-profile-munsell-srgb-to-srgb-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/exif-orientation-css-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/exif-orientation-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/exif-orientation-image-document-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/image-map-multiple-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/image-map-multiple-xhtml-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/image-map-zoom-alt-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/image-map-zoom-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/imagemap-nested-area-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/images/png-extra-row-crash-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/inspector-protocol/page/capture-snapshot-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/media/video-controls-visible-audio-only-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/color-profile-image-pseudo-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/crash-bad-cast-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/exif-orientation-css-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/exif-orientation-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/exif-orientation-image-document-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/image-map-multiple-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/image-map-multiple-xhtml-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/image-map-zoom-alt-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/image-map-zoom-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/virtual/gpu-rasterization/images/png-extra-row-crash-expected.txt
    • third_party/WebKit/LayoutTests/hittesting/text-overflow-inline-image-expected.txt
    • third_party/WebKit/LayoutTests/html/details_summary/details-children-merge-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/details_summary/details-clone-expected.txt
    • third_party/WebKit/LayoutTests/html/details_summary/details-keyboard-show-hide-expected.txt
    • third_party/WebKit/LayoutTests/html/details_summary/details-open-toggle-event-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/closed-dialog-does-not-block-mouse-events-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/dialog-canceling-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/dialog-close-event-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/dialog-open-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/fixpos-dialog-layout-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/form-method-dialog-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/inert-focus-in-frames-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/inert-inlines-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/inert-label-focus-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/inert-node-is-uneditable-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/inert-node-is-unselectable-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/modal-dialog-ancestor-is-inert-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/modal-dialog-blocks-mouse-events-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/modal-dialog-distributed-child-is-not-inert-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/non-modal-dialog-does-not-block-mouse-events-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/non-modal-dialog-layout-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/scrollable-after-close-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/simulated-click-inert-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/submit-dialog-close-event-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/synthetic-click-inert-expected.txt
    • third_party/WebKit/LayoutTests/html/document_metadata/base-expected.txt
    • third_party/WebKit/LayoutTests/html/document_metadata/base-multiple-expected.txt
    • third_party/WebKit/LayoutTests/html/document_metadata/head-check-expected.txt
    • third_party/WebKit/LayoutTests/html/document_metadata/meta-attributes-expected.txt
    • third_party/WebKit/LayoutTests/html/document_metadata/style-disabled-expected.txt
    • third_party/WebKit/LayoutTests/html/grouping_content/figcaption-element-expected.txt
    • third_party/WebKit/LayoutTests/html/grouping_content/figure-element-expected.txt
    • third_party/WebKit/LayoutTests/html/grouping_content/main-element-expected.txt
    • third_party/WebKit/LayoutTests/html/marquee/marquee-direction-attribute-should-be-case-insensitive-expected.txt
    • third_party/WebKit/LayoutTests/html/marquee/marquee-element-expected.txt
    • third_party/WebKit/LayoutTests/html/marquee/marquee-should-not-wrap-expected.txt
    • third_party/WebKit/LayoutTests/html/marquee/marquee-without-frame-no-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/article-element-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/aside-element-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/body-clone-link-decl-parent-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/body-legacy-colors-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/body-quirk-client-size-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/footer-element-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/header-element-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/hgroup-element-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/nav-element-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/numbered-header-element-expected.txt
    • third_party/WebKit/LayoutTests/html/sections/section-element-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/col_span-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/early-acid3-65-excerpt-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/early-acid3-66-excerpt-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/table_border_invalid-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/table_cellpadding-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/table_exceptions-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/table_insertrow-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/table_insertrow_default_argument-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/table_rows-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/table_tbodies-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/tbody_insertrow_default_argument-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/tbody_insertrow_skips_non_tr-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/tbody_rows-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/td_colspan-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/td_rowspan-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/tr_cells-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/tr_exceptions-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/tr_insertcell_default_argument-expected.txt
    • third_party/WebKit/LayoutTests/html/tabular_data/tr_insertcell_skips_non_td_th-expected.txt
    • third_party/WebKit/LayoutTests/html/text_level_semantics/mark-element-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/blob/send-data-blob-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/blob/send-hybrid-blob-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/blob/send-sliced-data-blob-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/drag-over-remote-content-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/fileapi/file-last-modified-after-delete-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/fileapi/file-last-modified-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/fileapi/send-dragged-file-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/fileapi/send-sliced-dragged-file-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/form-data-with-unknown-file-extension-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-with-bad-string-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-with-empty-blob-filename-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-with-empty-file-filename-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-with-empty-name-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-with-filename-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-with-null-string-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/send-form-data-with-string-containing-null-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/formdata/upload-events-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/local/style-access-before-stylesheet-loaded-expected.txt
    • third_party/WebKit/LayoutTests/idle-callback/test-runner-run-idle-tasks-expected.txt
    • third_party/WebKit/LayoutTests/images/12-55-expected.txt
    • third_party/WebKit/LayoutTests/images/182-expected.txt
    • third_party/WebKit/LayoutTests/images/2-dht-expected.txt
    • third_party/WebKit/LayoutTests/images/23-55-expected.txt
    • third_party/WebKit/LayoutTests/images/55-expected.txt
    • third_party/WebKit/LayoutTests/images/bad-png-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-background-image-cross-fade-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-background-image-cross-fade-png-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-border-image-source-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-border-radius-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-filter-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-group-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-image-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-image-filter-all-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-image-object-fit-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-image-profile-match-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-image-shape-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-layer-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-layer-filter-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-mask-image-svg-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-munsell-adobe-to-srgb-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-munsell-srgb-to-srgb-expected.txt
    • third_party/WebKit/LayoutTests/images/color-profile-svg-fill-text-expected.txt
    • third_party/WebKit/LayoutTests/images/crash-bad-cast-expected.txt
    • third_party/WebKit/LayoutTests/images/crash-when-zoom-factor-changes-expected.txt
    • third_party/WebKit/LayoutTests/images/destroyed-image-load-event-expected.txt
    • third_party/WebKit/LayoutTests/images/drag-pdf-as-image-expected.txt
    • third_party/WebKit/LayoutTests/images/embed-does-not-propagate-dimensions-to-object-ancestor-expected.txt
    • third_party/WebKit/LayoutTests/images/exif-orientation-css-expected.txt
    • third_party/WebKit/LayoutTests/images/exif-orientation-expected.txt
    • third_party/WebKit/LayoutTests/images/exif-orientation-image-document-expected.txt
    • third_party/WebKit/LayoutTests/images/huge-image-viewport-scale-expected.txt
    • third_party/WebKit/LayoutTests/images/image-load-event-in-fragment-expected.txt
    • third_party/WebKit/LayoutTests/images/image-map-multiple-expected.txt
    • third_party/WebKit/LayoutTests/images/image-map-multiple-xhtml-expected.txt
    • third_party/WebKit/LayoutTests/images/image-map-zoom-alt-content-expected.txt
    • third_party/WebKit/LayoutTests/images/image-map-zoom-expected.txt
    • third_party/WebKit/LayoutTests/images/imagemap-nested-area-expected.txt
    • third_party/WebKit/LayoutTests/images/jpeg-with-color-profile-expected.txt
    • third_party/WebKit/LayoutTests/images/large-size-image-crash-expected.txt
    • third_party/WebKit/LayoutTests/images/link-body-content-imageDimensionChanged-crash-expected.txt
    • third_party/WebKit/LayoutTests/images/png-extra-row-crash-expected.txt
    • third_party/WebKit/LayoutTests/images/png-missing-plte-before-trns-crash-expected.txt
    • third_party/WebKit/LayoutTests/images/png-suite/test-expected.txt
    • third_party/WebKit/LayoutTests/images/png-with-color-profile-expected.txt
    • third_party/WebKit/LayoutTests/images/script-counter-imageDimensionChanged-crash-expected.txt
    • third_party/WebKit/LayoutTests/images/size-failure-expected.txt
    • third_party/WebKit/LayoutTests/images/style-access-during-imageChanged-style-freeze-expected.txt
    • third_party/WebKit/LayoutTests/images/viewport-in-standalone-image-document-expected.txt
    • third_party/WebKit/LayoutTests/images/width-on-broken-data-src-expected.txt
    • third_party/WebKit/LayoutTests/images/zoomed-img-size-expected.txt
    • third_party/WebKit/LayoutTests/intersection-observer/observer-shared-from-iframe-expected.txt
    • third_party/WebKit/LayoutTests/loader/iframe-src-change-onload-crash-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/currentSrc/currentSrc_empty_if_no_src-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/currentSrc/currentSrc_nonempty_after_adding_source_child-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/currentSrc/currentSrc_nonempty_after_setting_src-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/currentSrc/currentSrc_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/error/error_null-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/error/error_onerror_called_on_bogus_source-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/error/error_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_canplay-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_canplay_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_canplaythrough-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_canplaythrough_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_loadeddata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_loadeddata_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_loadedmetadata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_loadedmetadata_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_loadstart-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_loadstart_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_order_canplay_playing-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_order_loadstart_progress-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_pause_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_play-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_play_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_playing-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_playing_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_progress-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_progress_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_timeupdate-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/events/event_timeupdate_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/networkState/networkState_during_loadstart-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/networkState/networkState_initial-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/networkState/networkState_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/paused/paused_false_during_play-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/paused/paused_true_during_pause-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_auto_value-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_bogus_value-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_empty-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_metadata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_no_value-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_none-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/preload/preload_reflects_none_autoplay-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/readyState/readyState_during_canplay-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/readyState/readyState_during_playing-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/readyState/readyState_initial-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/readyState/readyState_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/src/src_reflects_attribute_not_source_elements-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/src/src_reflects_no_value-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/audio/src/src_removal_does_not_trigger_loadstart-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/currentSrc/currentSrc_nonempty_after_adding_source_child-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/currentSrc/currentSrc_nonempty_after_setting_src-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/error/error_null-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/error/error_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_canplay-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_canplay_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_canplaythrough-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_canplaythrough_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_loadeddata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_loadeddata_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_loadedmetadata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_loadedmetadata_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_loadstart-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_loadstart_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_order_canplay_playing-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_order_loadstart_progress-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_pause_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_play-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_play_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_playing-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_playing_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_progress-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_progress_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_timeupdate-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/events/event_timeupdate_manual-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/networkState/networkState_during_loadstart-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/networkState/networkState_during_progress-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/networkState/networkState_initial-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/networkState/networkState_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/paused/paused_false_during_play-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/paused/paused_true_during_pause-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_auto_value-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_bogus_value-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_empty-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_metadata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_no_value-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_none-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/readyState/readyState_during_canplay-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/readyState/readyState_during_loadeddata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/readyState/readyState_during_playing-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/readyState/readyState_initial-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/readyState/readyState_property_exists-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/src/src_reflects_no_value-expected.txt
    • third_party/WebKit/LayoutTests/media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt
    • third_party/WebKit/LayoutTests/media/absolute-positioned-video-crash-expected.txt
    • third_party/WebKit/LayoutTests/media/color-profile-munsell-bt601-smpte-to-srgb-expected.txt
    • third_party/WebKit/LayoutTests/media/color-profile-munsell-bt709-to-srgb-expected.txt
    • third_party/WebKit/LayoutTests/media/controls-slider-appearance-crash-expected.txt
    • third_party/WebKit/LayoutTests/media/media-document-audio-size-expected.txt
    • third_party/WebKit/LayoutTests/media/network-no-source-const-shadow-expected.txt
    • third_party/WebKit/LayoutTests/media/remove-from-document-config-controls-no-crash-expected.txt
    • third_party/WebKit/LayoutTests/media/video-buffered-too-few-arguments-expected.txt
    • third_party/WebKit/LayoutTests/media/video-controls-start-selection-expected.txt
    • third_party/WebKit/LayoutTests/media/video-controls-visible-audio-only-expected.txt
    • third_party/WebKit/LayoutTests/media/video-controls-with-mutation-event-handler-expected.txt
    • third_party/WebKit/LayoutTests/media/video-default-poster-expected.txt
    • third_party/WebKit/LayoutTests/media/video-no-default-poster-expected.txt
    • third_party/WebKit/LayoutTests/mhtml/cid_in_html_iframe-expected.txt
    • third_party/WebKit/LayoutTests/mhtml/cid_in_html_resource-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/basic-operation-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/connection-types-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/estimate-web-worker-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/gc-frame-listeners-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/gc-unused-listeners-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/gc-used-listeners-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/multiple-frames-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/network-quality-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/saveData-basic-operation-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/type-change-no-listener-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/unregister-during-event-expected.txt
    • third_party/WebKit/LayoutTests/netinfo/web-worker-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.txt
  67. [ModalDialog] Fix cancel on touch outside not initalized

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:15:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b311430d945e8504515a56c465ad44ddc6a94346

    Comments

    [ModalDialog] Fix cancel on touch outside not initalized
    
    Bug: 905248
    Change-Id: Iab5d219feccbb265c72a83770d3a48bc368e2d10
    Reviewed-on: https://chromium-review.googlesource.com/c/1336032
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608044}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/modaldialog/ModalDialogView.java
  68. Roll src/third_party/skia 7f2b6fa66575..d7157b2ccf53 (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 18:15:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f6d25560bf9bc07b6ad1dda8f47e3e9a5f0bfcf4

    Comments

    Roll src/third_party/skia 7f2b6fa66575..d7157b2ccf53 (3 commits)
    
    https://skia.googlesource.com/skia.git/+log/7f2b6fa66575..d7157b2ccf53
    
    
    git log 7f2b6fa66575..d7157b2ccf53 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 egdaniel@google.com Revert "Reland "Have a GrBackendFormat be stored on gpu proxies.""
    2018-11-14 mtklein@google.com skip alpha scale if 256
    2018-11-14 egdaniel@google.com Reland "Have a GrBackendFormat be stored on gpu proxies."
    
    
    Created with:
      gclient setdep -r src/third_party/skia@d7157b2ccf53
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    
    BUG=chromium:903701 chromium:903756,chromium:903701 chromium:903756
    TBR=rmistry@chromium.org
    
    Change-Id: Ib7f4f617164efa46fdc0435416971fbb06f2a197
    Reviewed-on: https://chromium-review.googlesource.com/c/1335776
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608043}

    Changed files

    • DEPS
  69. Roll src/third_party/perfetto d7aa8b741012..74096ec8f277 (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 18:14:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1471d974678022561b3890eaf6e84c444fa5b245

    Comments

    Roll src/third_party/perfetto d7aa8b741012..74096ec8f277 (5 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/d7aa8b741012..74096ec8f277
    
    
    git log d7aa8b741012..74096ec8f277 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 hjd@google.com Merge "Fix tools/gen_binary_descriptors"
    2018-11-14 eseckler@google.com Merge "perfetto: replace remaining gtest_prod.h header usages"
    2018-11-14 skyostil@google.com Merge "Implement trace sqlite exporting"
    2018-11-14 lalitm@google.com Merge "trace_processor: fix multiple bugs with filtering and casting"
    2018-11-14 fmayer@google.com Merge "profiling: Update README."
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@74096ec8f277
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I4afcedd02fff000630e9df6541b94dd76a8a74cd
    Reviewed-on: https://chromium-review.googlesource.com/c/1335833
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608042}

    Changed files

    • DEPS
  70. Hack for demo screensaver disappearing momentarily after login

    Changed by Saman Sami - samansohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:14:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 27ac690d2b92b3fe1635036c1035db5c37d5abe9

    Comments

    Hack for demo screensaver disappearing momentarily after login
    
    There is an existing bug in Chrome OS where the screensaver is told to
    hide even though it's still visible. Before crrev.com/c/1277826 this
    used to only cause a freeze, but since then the screensaver disappears
    altogether. The reason is that during the first 10-20 seconds after
    logging into Chrome OS, there are 30+ renderers spawned in the
    background that don't actually draw anything. These renderers overwhelm
    FrameEvictionManager such that any renderer that goes hidden (e.g. the
    screensaver) will have its surface immediately evicted. This used to
    work fine before because notifying FrameEvictionManager used to happen
    in OnFirstSurfaceActivation as opposed to EmbedSurface, and therefore
    these useless renderers would not interfere with frame eviction. The
    Chrome OS team is worried they won't have a proper fix in time, so for
    the time being implement a behaviour similar to what we had before: only
    report DelegatedFrameHosts to FrameEvictionManager that have seen their
    first surface activation.
    
    Bug: 900373
    Change-Id: Ic98929f8e1c834de2af22aa299805395be6a9072
    Reviewed-on: https://chromium-review.googlesource.com/c/1334590
    Commit-Queue: Saman Sami <samans@chromium.org>
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608041}

    Changed files

    • content/browser/renderer_host/delegated_frame_host.cc
    • content/browser/renderer_host/delegated_frame_host.h
    • content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
  71. Fix a reentrance issue when showing file picker dialog

    Changed by Min Qin - qinminohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:13:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e8fcf79a7d21f178daf27a1d467d1431bc0bed85

    Comments

    Fix a reentrance issue when showing file picker dialog
    
    If we have multiple file picker dialogs, we queue the callbacks in a deque
    so that they will be handled sequentially. However, if one of the download
    is removed while enqueued, OnConfirmationCallbackComplete() call to
    ShowFilePicker() will cause an reentrance into OnConfirmationCallbackComplete().
    This CL fixes the issue by posing a task to call ShowFilePicker().
    Unit test is also added.
    
    BUG=904319
    
    Change-Id: I00d324a06977a173671a3405594371ccbdc4a5fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1332776
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608040}

    Changed files

    • chrome/browser/download/chrome_download_manager_delegate.cc
    • chrome/browser/download/chrome_download_manager_delegate.h
    • chrome/browser/download/chrome_download_manager_delegate_unittest.cc
    • chrome/browser/download/download_test_file_activity_observer.cc
  72. Add ability to track usage of the hrefTranslate attribute via use counter.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:13:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a391fb3711e8cd60b7eb3612df70482cf4102c6

    Comments

    Add ability to track usage of the hrefTranslate attribute via use counter.
    
    Read the attribute based on the origin trial being enabled otherwise
    even if it wasn't the attribute would get set on the navigation param.
    In the same branch count the usage as this will be useful for the origin
    trial.
    
    BUG=872777
    
    Change-Id: I1cc4eeba4051cf45c65e54f7dad02ec1114ecb1a
    Reviewed-on: https://chromium-review.googlesource.com/c/1334198
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608039}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/html/html_anchor_element.cc
    • tools/metrics/histograms/enums.xml
  73. Reland "Android: Allow proguard to strip unused native methods."

    Changed by Eric Stevenson - estevensonohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:12:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a055a9b5ffeda1dd5e09f2ad6c57a93caba8253

    Comments

    Reland "Android: Allow proguard to strip unused native methods."
    
    Reland of dc8f3c0aba827f550bef775a6645bcbd978052f7.
    
    chrome_public_test_apk is now merged with chrome_public_apk_for_test
    which should fix the proguard issue.
    
    TBR: agrieve@chromium.org
    Bug: 688465
    Change-Id: Ie43eae7f945e5ae444f1cb0adc0703b334402f3c
    Reviewed-on: https://chromium-review.googlesource.com/c/1333988
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: Eric Stevenson <estevenson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608038}

    Changed files

    • base/android/proguard/chromium_code.flags
    • base/android/proguard/explicit_jni_registration.flags
    • base/android/proguard/implicit_jni_registration.flags
    • build/config/android/rules.gni
    • components/cronet/android/BUILD.gn
  74. Omnibox: Query in Omnibox - Remove Page Info unelision on Desktop

    Changed by Tommy C. Li - tommycliohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:12:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d82637f008ac74a3ae81c7fc9cf3a15638cf6ba

    Comments

    Omnibox: Query in Omnibox - Remove Page Info unelision on Desktop
    
    Removes the page info popup triggering unelision on Desktop.
    
    Users found it more surprising than useful. We are adding other, more
    explicit methods of unelision.
    
    This CL is a simple revert of:
    https://chromium-review.googlesource.com/c/chromium/src/+/1265497
    
    Bug: 874592, 894862
    Change-Id: Ia1ebc7de91bb69f0aac9df22235b4ea24e7c0e93
    Reviewed-on: https://chromium-review.googlesource.com/c/1332266
    Reviewed-by: Kevin Bailey <krb@chromium.org>
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608037}

    Changed files

    • chrome/browser/ui/views/location_bar/location_bar_view.cc
  75. Don't set the window name if params.name is empty

    Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:11:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5337562e386e7e5ab9f02fd4d75c795dcd4ab221

    Comments

    Don't set the window name if params.name is empty
    
    Bug: None
    Test: Print window tree and the browser's window shows its name "BrowserFrameAsh"
    Change-Id: I3520f7a735441c9c8d6b2cf56ae91d03eafa5db4
    Reviewed-on: https://chromium-review.googlesource.com/c/1334588
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608036}

    Changed files

    • ui/views/widget/native_widget_aura.cc
  76. EXO: Move WaylandInputDelegate out of server.cc

    Changed by Shawn Gallea - sagalleaohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 18:10:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02bb1be52442d9786b9faa4d94477a95504bcce7

    Comments

    EXO: Move WaylandInputDelegate out of server.cc
    
    Include wayland_input_delegate.h in server.cc until a later CL,
    this is needed for classes in server.cc that inherit from it.
    
    Bug: 896710
    Test: Build ChromeOS
    Change-Id: I668280ccceab8a9e75874247919d0d0b3fea1cb1
    Reviewed-on: https://chromium-review.googlesource.com/c/1316100
    Commit-Queue: Shawn Gallea <sagallea@google.com>
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608035}

    Changed files

    • components/exo/wayland/BUILD.gn
    • components/exo/wayland/server.cc
    • components/exo/wayland/wayland_input_delegate.cc
    • components/exo/wayland/wayland_input_delegate.h
  77. Roll src/third_party/chromite c59d48ec1594..d5fa47311da1 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 18:09:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f37441a5a441f3ec1db44a787c67e31855db97ff

    Comments

    Roll src/third_party/chromite c59d48ec1594..d5fa47311da1 (2 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/c59d48ec1594..d5fa47311da1
    
    
    git log c59d48ec1594..d5fa47311da1 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 dgarrett@google.com image_lib_unittest: Fix test if default board set.
    2018-11-14 dgarrett@google.com repo_sync_manifest: Rework repo_sync_manifest.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@d5fa47311da1
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Id31c4aa62ff8c7326c060eb8221c49cb046dd4f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1335830
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608034}

    Changed files

    • DEPS
  78. [Background Fetch] Delete all in-memory fetch data

    Changed by Rayan Kanso - rayankansohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 18:08:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed6175923cdbc5973d8206f12491b9cb1f96d3c4

    Comments

    [Background Fetch] Delete all in-memory fetch data
    
    Inform upstream systems when a fetch is completely finished (event
    dispatch is complete) to know that it's safe to remove in-memory
    fetch data.
    
    Bug: 904818
    Change-Id: Ieef3ff87ce66e97f177ef8422994adb22568e155
    Reviewed-on: https://chromium-review.googlesource.com/c/1333815
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Mugdha Lakhani <nator@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608033}

    Changed files

    • chrome/browser/background_fetch/background_fetch_browsertest.cc
    • chrome/browser/background_fetch/background_fetch_delegate_impl.cc
    • chrome/browser/background_fetch/background_fetch_delegate_impl.h
    • content/browser/background_fetch/background_fetch_delegate_proxy.cc
    • content/browser/background_fetch/background_fetch_delegate_proxy.h
    • content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
    • content/browser/background_fetch/background_fetch_scheduler.cc
    • content/browser/background_fetch/background_fetch_service_unittest.cc
    • content/browser/background_fetch/mock_background_fetch_delegate.cc
    • content/browser/background_fetch/mock_background_fetch_delegate.h
    • content/public/browser/background_fetch_delegate.h
    • content/shell/browser/layout_test/layout_test_background_fetch_delegate.cc
    • content/shell/browser/layout_test/layout_test_background_fetch_delegate.h
  79. Fix 64 bit truncations in core/loader

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e7eed439e2a52806e9cbaf2408d776ff48be19b6

    Comments

    Fix 64 bit truncations in core/loader
    
    Use appropriate types in loader code.
    
    BUG=879657
    
    Change-Id: I3d94d7a6d6b3dce98792f4bf055a871f49d5a2da
    Reviewed-on: https://chromium-review.googlesource.com/c/1332507
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608032}

    Changed files

    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
    • third_party/blink/renderer/core/loader/resource/image_resource.cc
    • third_party/blink/renderer/core/loader/resource/image_resource_content.cc
    • third_party/blink/renderer/core/loader/resource/image_resource_test.cc
    • third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.cc
    • third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.h
    • third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser_test.cc
    • third_party/blink/renderer/core/loader/threadable_loader.cc
  80. Re-enable TabFullscreenHasLocationBar browser test

    Changed by Wei Li - weiliohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:07:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1e4445d16305c5d0c709d2f416cfa418ecb61ff

    Comments

    Re-enable TabFullscreenHasLocationBar browser test
    
    This test was disabled before. Now we should be able to re-enable it
    since we can reliably test fullscreen states. In this CL, we also
    removed an obsolete TODO since we no longer support MacOS 10.9.
    
    BUG=845389
    
    Change-Id: I2226bb408bf966b9eeca185fade145c0206ea0bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1334200
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Wei Li <weili@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608031}

    Changed files

    • chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
  81. Short circuit RenderTestRule comparison

    Changed by bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:07:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 772c7a3089b644e699f6da11e88d85c0328dea5f

    Comments

    Short circuit RenderTestRule comparison
    
    Short circuits RenderTestRule's Bitmap comparison if Bitmap.sameAs
    returns true. This comparison is signiciantly faster than the fallback
    pixel-by-pixel comparison, particularly when comparing large images like
    those produced by VR.
    
    Bug: 904012
    Change-Id: Ia9cdd91c91f94079d853ec28fd49fee3c3dd0905
    Reviewed-on: https://chromium-review.googlesource.com/c/1334945
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608030}

    Changed files

    • chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderTestRule.java
  82. Roll src-internal 1680e702bb3f..8eae8558004a (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 18:06:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9db1b4f78cb59374b932316c6e633a715847ea34

    Comments

    Roll src-internal 1680e702bb3f..8eae8558004a (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1680e702bb3f..8eae8558004a
    
    
    Created with:
      gclient setdep -r src-internal@8eae8558004a
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I20b667a7bf308633ccf17bfd7191db8673aca8b6
    Reviewed-on: https://chromium-review.googlesource.com/c/1335774
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608029}

    Changed files

    • DEPS
  83. Move TrayNetworkStateObserver to NetworkTrayView

    Changed by Tony de Luna - tonydelunaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:06:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29a38a99aa45deeb7b813541f651d5793f879370

    Comments

    Move TrayNetworkStateObserver to NetworkTrayView
    
    Make NetworkTrayView own its network state observer. We want to have
    multiple instances of NetworkTrayView in the future, one for each
    network icon type.
    
    Now each instance is responsible of subscribing to network state
    updates.
    
    BUG=902409
    
    Change-Id: I5dabfbff662dea6c975a4d64e63691194c7e5476
    Reviewed-on: https://chromium-review.googlesource.com/c/1332210
    Reviewed-by: Toni Baržić <tbarzic@chromium.org>
    Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
    Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608028}

    Changed files

    • ash/system/network/network_tray_view.cc
    • ash/system/network/network_tray_view.h
    • ash/system/unified/unified_system_tray.cc
    • ash/system/unified/unified_system_tray.h
  84. cros: Fix elided app names

    Changed by Alex Newcomer - newcomerohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:05:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7f3afb9fa858121ce4cf2fb5046766af9efa3fff

    Comments

    cros: Fix elided app names
    
    For the new launcher design:
     - Make grid title padding 0.
     - Allow max space for the title.
    
    This brings the app pods up to spec.
    
    Bug: 885338
    Change-Id: I41ceb36558c8955079f476bdd8511ccc77e4fb40
    Reviewed-on: https://chromium-review.googlesource.com/c/1332415
    Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608027}

    Changed files

    • ash/app_list/views/app_list_item_view.cc
    • ash/public/cpp/app_list/app_list_config.cc
  85. Use uncanonicalized EndOfWordPosition() in visible selection end adjuster

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ac52e7568811dd697d71e4c6286299ce5538f0d

    Comments

    Use uncanonicalized EndOfWordPosition() in visible selection end adjuster
    
    This patch hoists the creation of VisiblePosition from EndOfWord
    to its caller ComputeEndRespectingGranularityAlgorithm() to reduce
    the usage VisiblePosition.
    
    Bug: 657237
    Change-Id: I29cc408d35ecc30db4aa635f5ad4bed88c0032c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1330789
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608026}

    Changed files

    • third_party/blink/renderer/core/editing/selection_adjuster.cc
  86. Add ZX dependency in googletest

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:03:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc1e38cdab9722363298f027f71d0ca075640185

    Comments

    Add ZX dependency in googletest
    
    Add explicit dependency on fuchsia-sdk:zx in googletest. This should
    unblock chromium roll to V8, which was broken after crrev.com/607798
    
    TBR=dpranke@chromium.org
    
    Bug: 893369
    Change-Id: I58895fce6d2ed40008cac724735403be8b70226d
    Reviewed-on: https://chromium-review.googlesource.com/c/1336070
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608025}

    Changed files

    • third_party/googletest/BUILD.gn
  87. Roll src/third_party/catapult b0c06d4b490c..6b8b30c8a1b1 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 18:03:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d042c766bb13e008245187b65f09f4a59073e134

    Comments

    Roll src/third_party/catapult b0c06d4b490c..6b8b30c8a1b1 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/b0c06d4b490c..6b8b30c8a1b1
    
    
    git log b0c06d4b490c..6b8b30c8a1b1 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 cbruni@chromium.org [telemetry] Preserve stacktrace on rethrow in InspectorBackendList
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@6b8b30c8a1b1
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: Ia3e03613712f46d5d75e7913faea2d43c6208e97
    Reviewed-on: https://chromium-review.googlesource.com/c/1335775
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608024}

    Changed files

    • DEPS
  88. Remove /v2 prefix from clusterfuzz.com links.

    Changed by Abhishek Arya - infernoohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:02:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e9d57cd556ed3ef965df944548c874e87293940

    Comments

    Remove /v2 prefix from clusterfuzz.com links.
    
    R=mmoroz@chromium.org
    
    Change-Id: I2f2b99dbdfd97247b52d5bb86d53908237c3ff94
    Reviewed-on: https://chromium-review.googlesource.com/c/1336074
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608023}

    Changed files

    • docs/security/sheriff.md
    • testing/libfuzzer/README.md
    • testing/libfuzzer/clusterfuzz.md
  89. chromeos: refactors MultiUserWindowManager into two classes

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:02:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41f8a81f91026740a72d8633b35c3ccdfe5173f5

    Comments

    chromeos: refactors MultiUserWindowManager into two classes
    
    One lives in ash, the other in the browser. The one in ash is responsible
    for the actual window management and animations, the one in the browser for
    forwarding to the one in ash and caching state. I'm happy to rename these
    classes in the future.
    
    BUG=756085,875111
    TEST=covered by test
    
    Change-Id: I2367534e0566742f3897c69fb8ece7dfff1b1aff
    Reviewed-on: https://chromium-review.googlesource.com/c/1328567
    Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608022}

    Changed files

    • ash/BUILD.gn
    • ash/multi_user/multi_user_window_manager.cc
    • ash/multi_user/multi_user_window_manager.h
    • ash/multi_user/multi_user_window_manager_delegate.h
    • ash/multi_user/user_switch_animator.cc
    • ash/multi_user/user_switch_animator.h
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/ash/launcher/DEPS
    • chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
    • chrome/browser/ui/ash/multi_user/DEPS
    • chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
    • chrome/browser/ui/ash/multi_user/multi_user_window_manager.h
    • chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
    • chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
    • chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
  90. Revert "viz: Include presentation-feedback with begin-frame."

    Changed by Fernando Serboncini - fserbohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 18:01:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68dbb3a45c940c5a39ec8d3b4ce3c2f6b86a5554

    Comments

    Revert "viz: Include presentation-feedback with begin-frame."
    
    This reverts commit fd1a4804046eec31e0ba44435cb41aed015266b9.
    
    Reason for revert: Broke build.
    
    Original change's description:
    > viz: Include presentation-feedback with begin-frame.
    > 
    > Instead of sending the presentation-feedback over a separate IPC,
    > include it with the begin-frame messages. The presentation feedback
    > can be requested for each frame. So this can reduce an extra IPC
    > per frame for each client.
    > 
    > BUG=883592
    > 
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    > Change-Id: Iab52a29f406078eab79948a942124c8e13cb4332
    > Reviewed-on: https://chromium-review.googlesource.com/c/1175492
    > Reviewed-by: Robert Flack <flackr@chromium.org>
    > Reviewed-by: Tom Sepez <tsepez@chromium.org>
    > Reviewed-by: Bo <boliu@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#608002}
    
    TBR=sadrul@chromium.org,flackr@chromium.org,boliu@chromium.org,tsepez@chromium.org,piman@chromium.org
    
    Change-Id: Id6732cb3052d7cd2d7c4c8cf9256eb8856ab23d9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 883592
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/c/1336080
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608021}

    Changed files

    • android_webview/browser/hardware_renderer.cc
    • android_webview/browser/hardware_renderer.h
    • android_webview/browser/surfaces_instance.cc
    • android_webview/browser/surfaces_instance.h
    • cc/mojo_embedder/async_layer_tree_frame_sink.cc
    • cc/mojo_embedder/async_layer_tree_frame_sink.h
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_impl.cc
    • components/viz/service/display/display_unittest.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.h
    • components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
    • components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
    • components/viz/service/surfaces/surface_unittest.cc
    • components/viz/test/fake_compositor_frame_sink_client.cc
    • components/viz/test/fake_compositor_frame_sink_client.h
    • components/viz/test/mock_compositor_frame_sink_client.h
    • components/viz/test/test_layer_tree_frame_sink.cc
    • components/viz/test/test_layer_tree_frame_sink.h
    • content/browser/renderer_host/delegated_frame_host.cc
    • content/browser/renderer_host/delegated_frame_host.h
    • content/browser/renderer_host/delegated_frame_host_client_android.cc
    • content/browser/renderer_host/delegated_frame_host_client_android.h
    • content/browser/renderer_host/render_widget_host_view_android.cc
    • content/browser/renderer_host/render_widget_host_view_android.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
    • content/renderer/android/synchronous_layer_tree_frame_sink.cc
    • content/renderer/android/synchronous_layer_tree_frame_sink.h
    • content/test/fake_renderer_compositor_frame_sink.h
    • services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
    • third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
    • third_party/blink/renderer/platform/graphics/begin_frame_provider.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.h
    • third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
    • ui/android/delegated_frame_host_android.cc
    • ui/android/delegated_frame_host_android.h
    • ui/android/delegated_frame_host_android_unittest.cc
  91. Import wpt@3029f42ddc9060f1631fb5ed8c87be9f514c210a

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 17:08:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2dba2177324a3d5adf7f07d8d693976551880323

    Comments

    Import wpt@3029f42ddc9060f1631fb5ed8c87be9f514c210a
    
    Using wpt-import in Chromium d4f327badd2fdd83341ade8adb32d8151725a752.
    With Chromium commits locally applied on WPT:
    39c398adaa "Worklet: Modernize service worker interception tests for worklets using async/await"
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=kyleju
    
    No-Export: true
    Change-Id: I7a3d9eac1d26f1dc7a0bebbd9a746a5e01affc00
    Reviewed-on: https://chromium-review.googlesource.com/c/1335729
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608020}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/html/dom/elements-obsolete.js
    • third_party/WebKit/LayoutTests/external/wpt/html/dom/reflection-obsolete-expected.txt
  92. [Payment Handler] Better logs + tests for JIT install

    Changed by Rouslan Solomakhin - rouslanohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 17:07:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e253721d25cbeaa494aa3da7425950df8609c179

    Comments

    [Payment Handler] Better logs + tests for JIT install
    
    Before this patch, some errors for payment handlers were printed
    to stderr, which is not convenient for web developers.
    
    This patch re-routes payment handler related error and warning messages
    into the web developer console. In case of errors in the payment handler
    page that close the payment handler window, the error messages are
    printed into the developer console for the page that invoked
    PaymentRequest instead, so that the messages don't disappear immediately
    after being printed. The error messages in the payment handler info
    fetcher have been expanded to notify the web developer about more corner
    cases that would make the payment handler not work properly, such as
    cross-site iframes when installing a payment handler. In addition, this
    patch adds unit tests for JIT payment handler install.
    
    After this patch, more errors for payment handlers are printed in
    the web developer console, which is more convenient for web developers.
    
    Change-Id: If14b7a947eb2a4915dfe66f5ac2d3cccfc4b6e07
    Bug: 867747
    Reviewed-on: https://chromium-review.googlesource.com/c/1321093
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608019}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestParserTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderUnitTest.java
    • chrome/browser/payments/manifest_verifier_browsertest.cc
    • chrome/browser/payments/payment_manifest_parser_browsertest.cc
    • chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc
    • chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h
    • chrome/browser/ui/views/payments/payment_request_dialog_view.cc
    • components/payments/content/BUILD.gn
    • components/payments/content/android/java/src/org/chromium/components/payments/PaymentManifestParser.java
    • components/payments/content/android/payment_manifest_downloader_android.cc
    • components/payments/content/android/payment_manifest_downloader_android.h
    • components/payments/content/android/payment_manifest_parser_android.cc
    • components/payments/content/android/payment_manifest_parser_android.h
    • components/payments/content/developer_console_logger.cc
    • components/payments/content/developer_console_logger.h
    • components/payments/content/installable_payment_app_crawler.cc
    • components/payments/content/installable_payment_app_crawler.h
    • components/payments/content/manifest_verifier.cc
    • components/payments/content/manifest_verifier.h
    • components/payments/content/service_worker_payment_app_factory.cc
    • components/payments/content/utility/BUILD.gn
    • components/payments/content/utility/fingerprint_parser.cc
    • components/payments/content/utility/fingerprint_parser.h
    • components/payments/content/utility/fingerprint_parser_fuzzer.cc
    • components/payments/content/utility/fingerprint_parser_unittest.cc
    • components/payments/content/utility/payment_manifest_parser.cc
    • components/payments/content/utility/payment_manifest_parser.h
    • components/payments/content/utility/payment_manifest_parser_unittest.cc
    • components/payments/content/utility/payment_method_manifest_parser_fuzzer.cc
    • components/payments/content/utility/payment_web_app_manifest_parser_fuzzer.cc
    • components/payments/content/web_app_manifest.h
    • components/payments/core/BUILD.gn
    • components/payments/core/error_logger.cc
    • components/payments/core/error_logger.h
    • components/payments/core/payment_manifest_downloader.cc
    • components/payments/core/payment_manifest_downloader.h
    • components/payments/core/payment_manifest_downloader_unittest.cc
    • components/payments/core/test_payment_manifest_downloader.cc
    • content/browser/payments/payment_app_info_fetcher.cc
    • ios/chrome/browser/payments/ios_payment_instrument_finder.mm
  93. [s13n] Convert AccountReconcilor{Delegate} away from SigninManager

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Wednesday, 14-Nov-18 17:05:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c36892c23f35bd11497e1f0c730ffdad14b7f74f

    Comments

    [s13n] Convert AccountReconcilor{Delegate} away from SigninManager
    
    This CL migrates AccountReconcilor and AccountReconcilorDelegate production
    code away from SigninManager, leaves migration away from
    ProfileOAuth2TokenService and unittests for a follow up step.
    
    Unit tests were minimally adapted to keep passing.
    
    TBR=mkwst@chromium.org (chrome/browser/extensions/api/browsing_data/)
    
    BUG=903907
    
    Change-Id: I9093fb989351b9a924a02a07821a637c59038ba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1330223
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608018}

    Changed files

    • chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
    • chrome/browser/signin/account_reconcilor_factory.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • components/signin/core/browser/BUILD.gn
    • components/signin/core/browser/DEPS
    • components/signin/core/browser/account_reconcilor.cc
    • components/signin/core/browser/account_reconcilor.h
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/mirror_account_reconcilor_delegate.cc
    • components/signin/core/browser/mirror_account_reconcilor_delegate.h
    • ios/chrome/browser/signin/account_reconcilor_factory.cc
  94. Adapt HideStarOnNonbookmarkedInterstitial for committed interstitials

    Changed by Carlos IL - carlosilohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 17:01:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 73defadf883036a56cb541f79c727a0d1f875719

    Comments

    Adapt HideStarOnNonbookmarkedInterstitial for committed interstitials
    
    Bug: 752372
    Change-Id: I11f97243aa8aecd1ae00d55317e31d94d8e0d612
    Reviewed-on: https://chromium-review.googlesource.com/c/1334649
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608017}

    Changed files

    • chrome/browser/ui/bookmarks/bookmark_browsertest.cc
  95. FrameMetrics: Add more comments to unittests

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 17:01:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7f559c7c94d4d41d055bb02700e6178b17a3279

    Comments

    FrameMetrics: Add more comments to unittests
    
    Bug: 894149
    
    TBR=sadrul@chromium.org
    
    Change-Id: Ibeece84bc1490050a9c61c8deb976c370506e45e
    Reviewed-on: https://chromium-review.googlesource.com/c/1335279
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608016}

    Changed files

    • ui/latency/skipped_frame_tracker_unittest.cc
  96. Reenable telemetry_perf_unittests on android-marshmallow-arm64-rel.

    Changed by John Budorick - jbudorickohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:59:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99c1e76e6abddbef91b6f64ea5c6997df227ad6f

    Comments

    Reenable telemetry_perf_unittests on android-marshmallow-arm64-rel.
    
    Tbr: crouleau@chromium.org,nednguyen@google.com,perezju@chromium.org
    Bug: 903849
    Change-Id: Ib0857c3bbd630ea7e47928dcd43b9f9fcc12597e
    Reviewed-on: https://chromium-review.googlesource.com/c/1335935
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608015}

    Changed files

    • testing/buildbot/chromium.android.json
    • testing/buildbot/test_suite_exceptions.pyl
  97. [css-properties-values-api] Support fallbacks.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:59:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c1c6809373770c7af95a3cd7b278dc55cdbcd12

    Comments

    [css-properties-values-api] Support fallbacks.
    
    According to css-variables-1, any custom property that participates in a
    cycle is invalid. This also applies to registered custom properties.
    In the current implementation, however, registered custom properties
    with an initial value can not become invalid; they compute to their initial
    value instead, as provided by registerProperty. A consequence of this, is
    that fallbacks (specified by var()-references) are never triggered if the
    referenced property is a registered property with an initial value defined.
    
    The value for any unregistered custom property, if no other value is
    specified, is the invalid initial value described by css-variables-1.
    This means we can just avoid storing the variable on ComputedStyle, to
    signify the invalid initial value.
    
    However, the value for any registered custom property, if no other value is
    specified, can be the initial value specified by registerProperty. When
    there is no value explicitly stored on ComputedStyle, we check
    StyleInitialData and fetch the initial value from there. Hence, we can not
    use the absence of a value to signify an invalid registered variable, as
    we already use this state to mean "initial value from registerProperty".
    This means that we must explicitly store a value for registered properties
    that participate in a cycle. This CL adds CSSInvalidVariableValue to do
    this.
    
     * When resolving a registered custom property, if a cycle is detected, set
       the registered value to CSSInvalidVariableValue.
     * When looking up a registered custom property, if we already have the
       value CSSInvalidVariableValue, return nullptr instead of initial data.
       This triggers fallbacks.
     * The code that set the cycle_detected flag was weird; a cycle could be
       marked as detected, even though ResolveTokenRange succeeded. This meant
       that any custom property which referenced a property in a cycle would
       also be treated as part of the cycle, which is wrong. Fixed by only
       setting the cycle_detected flag when we have cycle start points.
     * CSSInterpolationType did not initialize its cycle_detected variable,
       which led to undefined behavior.
    
    R=futhark@chromium.org
    
    Bug: 641877
    Change-Id: I2c518b176de26f7b2f05b36b568041a228fcb0ea
    Reviewed-on: https://chromium-review.googlesource.com/c/1333758
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608014}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/var-reference-registered-properties-cycles.html
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/animation/css_interpolation_type.cc
    • third_party/blink/renderer/core/css/BUILD.gn
    • third_party/blink/renderer/core/css/css_invalid_variable_value.cc
    • third_party/blink/renderer/core/css/css_invalid_variable_value.h
    • third_party/blink/renderer/core/css/css_invalid_variable_value_test.cc
    • third_party/blink/renderer/core/css/css_value.cc
    • third_party/blink/renderer/core/css/css_value.h
    • third_party/blink/renderer/core/css/css_value_pool.cc
    • third_party/blink/renderer/core/css/css_value_pool.h
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver.cc
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver.h
  98. Keyboard-accessible scroll containers (with tabIndex = 0)

    Changed by Hugo Holgersson - hugohohnoyoudont@vewd.com
    Changed at Wednesday, 14-Nov-18 16:57:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b64d0a8c04db08eaa81502868a5802d660030842

    Comments

    Keyboard-accessible scroll containers (with tabIndex = 0)
    
    Intent to Ship (approved November 6):
    https://groups.google.com/a/chromium.org/d/msg/blink-dev/Fku6784p0wI/3MyOMTk7BwAJ
    
    This CL mimics Firefox's behavior; all content in scroll
    containers are now keyboard-accessible, see the test
    reach-and-scroll-overflow-div-without-mouse.html.
    
    Without this fix, some scrollers' web content is not accessible
    at all without a mouse pointer.
    
    To be able to write compact and hopefully soon WPT-compatible
    tests, this CL generalizes spatial navigation's JS helpers so
    they also cover sequential navigation.
    
    If you suspect this change caused a regression, try disabling
    it: --disable-blink-features=KeyboardFocusableScrollers
    
    Follow-up:
    - This change is needed by spatial navigation (Issue 801162).
    
    Bug: 585413
    Change-Id: I200cdfd1afd02b354ef23bafd119abe558491dd0
    Reviewed-on: https://chromium-review.googlesource.com/c/1258331
    Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608013}

    Changed files

    • content/test/data/accessibility/html/scrollable-overflow-expected-blink.txt
    • third_party/WebKit/LayoutTests/accessibility/reach-and-scroll-overflow-div-without-mouse.html
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/extension/pointerevent_touch-action-pan-down-css_touch-manual-automation.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/extension/pointerevent_touch-action-pan-up-css_touch-manual-automation.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_touch-action-none-css_touch-manual-automation.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual-automation.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual-automation.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_touch-action-span-test_touch-manual-automation.js
    • third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-panIcon-expected.html
    • third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-panIcon.html
    • third_party/WebKit/LayoutTests/fast/spatial-navigation/resources/snav-testharness.js
    • third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-clipped-overflowed-content.html
    • third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html
    • third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-search-outside-of-focused-scroller.html
    • third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-key-navigation-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-text-hit-testing-expected.png
    • third_party/WebKit/LayoutTests/platform/linux/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-text-hit-testing-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png
    • third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-text-hit-testing-expected.png
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/core/page/spatial_navigation.cc
    • third_party/blink/renderer/core/page/spatial_navigation.h
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  99. [perf] Add load:search:yahoo:2018 system health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:57:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f231722674efc952111bde4ba7fc8921c165c29

    Comments

    [perf] Add load:search:yahoo:2018 system health story
    
    This CL was created automatically with tools/perf/update_wpr script
    
    R=perezju@chromium.org
    
    Bug: 878390
    Change-Id: I40efb621c05c77f0d032f8392991cb3b827cab1d
    Reviewed-on: https://chromium-review.googlesource.com/c/1329666
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608012}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_d661408019.wprgo.sha1
    • tools/perf/page_sets/data/system_health_mobile.json
    • tools/perf/page_sets/data/system_health_mobile_4367fb5828.wprgo.sha1
    • tools/perf/page_sets/system_health/loading_stories.py
  100. Update function name in mojo docs

    Changed by Adithya Srinivasan - adithyasohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b6c6086801c7e2f1028dc6978d8405e9ba870e6

    Comments

    Update function name in mojo docs
    
    MakeIsolatedRequest was renamed in https://crrev.com/c/753624.
    
    Change-Id: I1225ce04242adb398693ac0ff4612c9f672754df
    Reviewed-on: https://chromium-review.googlesource.com/c/1334663
    Reviewed-by: Ken Rockot <rockot@google.com>
    Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608011}

    Changed files

    • mojo/public/cpp/bindings/README.md
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>