Home | Search | chromium - Builders
Login

Builder Windows deterministic Build 10713 Microsoft Windows

Results:

Internal Failure

Trigger Info:

Projectchromium
Revision103faf893940889d189a6620ddb46ff871666b32

Execution:

Steps and Logfiles:

Show:
  1. ( 383 ms ) setup_build
    running recipe: "swarming/deterministic_build"
  2. ( 18 mins 6 secs ) bot_update
    [26GB/299GB used (8%)]
  3. ( 385 ms ) clobber
  4. ( 12 mins 58 secs ) gclient runhooks
  5. ( 764 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  6. ( 3 mins 10 secs ) generate_build_files
  7. ( 44 mins 1 secs ) First build
  8. ( 2 mins 44 secs ) First build confirm no-op
  9. ( 16 mins 22 secs ) isolate tests
  10. ( 492 ms ) clobber (2)
  11. ( 49 secs ) gclient runhooks (2)
  12. ( 497 ms ) lookup GN args (2)
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  13. ( 3 mins 32 secs ) generate_build_files (2)
  14. ( 17 mins 57 secs ) Second build
  15. ( 1 mins 37 secs ) Second build confirm no-op
  16. ( 14 mins 18 secs ) isolate tests (2)
  17. ( 19 mins 13 secs ) compare_build_artifacts

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2173-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542213838101822, "id": "8929865298457401632", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/103faf893940889d189a6620ddb46ff871666b32", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/103faf893940889d189a6620ddb46ff871666b32", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095295360756243744", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Windows deterministic" setup_build
buildnumber 10713 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "swarming/deterministic_build" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "103faf893940889d189a6620ddb46ff871666b32" setup_build
got_angle_revision "d1a55e393e65601ba26e2d76bd46a12fc6bc4e3e" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "597e1587b4bfc7bf89895c7c879ae58b649da3c5" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "103faf893940889d189a6620ddb46ff871666b32" bot_update
got_revision_cp "refs/heads/master@{#608005}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "388a62c245f992ebd6a18c507062f14801d844b0" bot_update
got_v8_revision_cp "refs/heads/7.2.328@{#1}" bot_update
got_webrtc_revision "76f9954b17a47623af6c1e5a538ff9bc31bbf96f" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25635}" bot_update
swarm_hashes {"accessibility_unittests": "be50f9a3647f355349fec7e2315c55927384b79c", "angle_end2end_tests": "822f77c6198b4ae026a3b4ba0d593f75adb98077", "angle_perftests": "7168d884e2a232f0da74a1e2813f008585b37adf", "angle_unittests": "bf7566b88a0f986328b997f392e381f6c1de3792", "angle_white_box_tests": "d6893dcd8ef350184a911da880912bebd21b3fbd", "app_shell_unittests": "717bd13575d66aaf3a28eb60f5c9be2284c2dda0", "aura_unittests": "b66c1d5580587f62d7e49f0dd3cd69f923acf033", "base_perftests": "b43df4115d3a4948573512c2a97a690e7dd8e742", "base_unittests": "f32fafd98ec4558633451acda43ad072a81cb898", "blink_common_unittests": "cc94daea2eadbd8a7435d6aa48f567ad197b39f8", "blink_fuzzer_unittests": "7ae6d0d0820fa0e50d608d0711add12ef55b0c1c", "blink_heap_unittests": "bb07291fe8fd2253be184beee874bdd001f873da", "blink_platform_unittests": "4f885f90991918e75724fcbeaa92ab5fcf14e0bd", "boringssl_crypto_tests": "952098a50fc6869679d61c093398c3d2297afcca", "boringssl_ssl_tests": "e8e7ba6be926100cd1f7ae02cb5301d1b11a00be", "browser_tests": "0aaf17a427a244a7f2baa7614f6402493b23f1a9", "cacheinvalidation_unittests": "7c737dcf178de503175650fe491bd53a7d6c1de6", "capture_unittests": "9b03a8a1b377cbd63d565cca707b46f82074cd10", "cast_unittests": "d312e876ad012098456241b9d93b61aa7ec47b68", "cc_unittests": "68287c0edea8414fe503424b832f919beb638510", "chrome_app_unittests": "552cca1a04e1e99fdfa6f1f3464df210fdd89d82", "chrome_cleaner_unittests": "d78e9acd5e1bb2353004213d83d3f8ba721774f1", "chrome_elf_import_unittests": "147c36a1f9d928a97c01ebf32cb9407cb15b04ce", "chrome_elf_unittests": "d204230d0d02e8d7c063c623cc51bad1932a4da3", "chromedriver_py_tests": "716384c2640f6abcc00f6989168ff44b070b4550", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "21e187612034f37344fa4ce9a7a83490d789f5a8", "command_buffer_perftests": "1e5931c9782b0a529514929e5c71a90f7589ed0a", "components_browsertests": "50b24ece55eb8de297401f597f237e9b577e6117", "components_perftests": "bdde8238fa5b38dfc51740de9da2fd9f2f6a8c3b", "components_unittests": "105d97d39504686799635e9d010715e858ebfcbe", "compositor_unittests": "e51d49f01c9ca3115aba89b111438f9d038406d6", "content_browsertests": "41a9319fcc3a95fdda21ed1ebb6ed984d7fb3353", "content_shell_crash_test": "8029a16600399b768494cf8f2671c7721d2b1e32", "content_unittests": "59fefdaf2cc4cde341a44f7381565d648991e1b8", "courgette_unittests": "cdb6593ab5a29156b7a86f368a089b33cad9a510", "crashpad_tests": "0fddef42e87ffbeac0e81d72c7bd9d31462026cd", "cronet_tests": "6382f9d7cb4ce3b5c78209bd55afa58c1de7f77e", "cronet_unittests": "9a300eb5d7cb7e207773c193ce2ef59e2acffb67", "crypto_unittests": "4cb106500ee7b40f8ca8e3a6eafcf7ed7e77f823", "dawn_end2end_tests": "c4d3c1315f6c0d3b25c0e3939ba56660d35d9712", "device_unittests": "ab30ca37954cddf4846ea49ef8893c37feb0d5b5", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "9dcaa26f55d1a07638447036aaa0346682bfce98", "elevation_service_unittests": "1caebb6938d789af509bf98bb05238926d2d3221", "events_unittests": "3e28322db40bf02525efa39417d73ba201d46917", "extensions_browsertests": "36859ed5d9af6f50dfe907a702d55be4304c6f7d", "extensions_unittests": "c26f2ab799eb5192da3443253c872322a23f0016", "filesystem_service_unittests": "26fbb7c9516e8f7ba58c2e8a36f28e537b83f653", "gcm_unit_tests": "863da59337cb34bc41628e94ef0363136d2bd1b8", "gcp_unittests": "552340f2cee9d87124ece68552a512390e0e8ac0", "gfx_unittests": "109812ab6477468c5c12b86e3d3d82cb34ec3786", "gin_unittests": "fba794e1164bae54a4c1bcffcd6270b469bfb61e", "gl_tests": "90500ba8a30409d1ab5fdf66514a917ef76606d2", "gl_unittests": "b8ad21fc9f88bdcf96d8f8d1eb8d5bca4d4e2df7", "gl_unittests_ozone": "b8ad21fc9f88bdcf96d8f8d1eb8d5bca4d4e2df7", "gles2_conform_test": "58fb668507afcccf628cffd7d64976a8cd98f755", "google_apis_unittests": "74c91f2bf3b97c9d24643f02864a677f34b05f4a", "gpu_perftests": "95595840bf0fb3ece987fa462f0f1ba290e5feac", "gpu_unittests": "ed63280474ccf1330294535ef78633905bd7d9b9", "headless_browsertests": "6ecf8a1f6a2ab5683606f2db8f43871dbe1415bc", "headless_unittests": "3fbdaca892aa352d77f7b515949601df4df199af", "install_static_unittests": "283828edb289295a8a00eceb173e1a577d13eb1d", "installer_util_unittests": "4ec5e128d26c594054f6d36983ca7120edc3cd2e", "interactive_ui_tests": "04881da8b264797b75dd399645f1a59e7ab085ec", "ipc_tests": "e04315470aefba37ef2f86a8fff1450fd775789d", "jingle_unittests": "1af0967f235f73d5b2e4b799a8823efe6c3ad313", "latency_unittests": "254fea732f596c3ab13804b56f9978934c6d95cd", "leveldb_service_unittests": "1e95d87bf35992284e8dd7252d11bfe4284479af", "libjingle_xmpp_unittests": "c8404350576c67ad4c39c3ffa17880f9fd19962c", "load_library_perf_tests": "cd8773f98738796c5c9657f3a44228c7c68c4a30", "media_blink_unittests": "5c7349b1ac06358bb6eb092ea9b6bf5ac40438c5", "media_perftests": "8bd8fb61ec1d4e11e91f0fc725bed16f29dff19f", "media_service_unittests": "d91845dad7067d96006095d9601d26f30a4b5a00", "media_unittests": "b3ac5f7fc7cf00fa156551277855434c6b305262", "message_center_unittests": "068f3978f76bf88dc2d0874a6973041e296754bb", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "e0ebd1c7e4a0d58eba3c9a56abe8308e58ab7e26", "mini_installer_tests": "ba49f61c89e378d31f07a558282643b566472783", "mojo_core_unittests": "1f8cf39dcf69c290d34d9c37c169c7713167ae1b", "mojo_unittests": "bb0a0d20a98e9cfd6644fbbbab02f2c79fbabb27", "nacl_loader_unittests": "e315856ee7f72f52a3c66fdf7e0809b381e09d37", "native_theme_unittests": "46929c1fb7a7c4bef15a3f6b813ff37c0a8f9c60", "net_perftests": "d0e512e15b51950d2dab07e552fc71e3e3b4d108", "net_unittests": "b110f012d90dc4e676bd1f34302159e897d71d38", "notification_helper_unittests": "4c90639e3af615cb9efb4a58af0769a8da43e1f7", "pdf_unittests": "4627be04ba02603323b2ceadbca2030fa4c62123", "performance_browser_tests": "b4733eafaed109bf532082b34c44827adb41806d", "performance_test_suite": "8e32ae72231f3c4275f6e5d812a45a4f7c280093", "performance_webview_test_suite": "c96a486df3c6dd756c1cac992806c490a1d7210c", "ppapi_unittests": "6eac22f213a6030c3306454423ea21ff94c4d66b", "printing_unittests": "86fc542f7a508d1b3e0f2ef9de8225f8532d48d0", "remoting_unittests": "83c225ea07564bc2421887ac2d199f4a083b23cc", "sbox_integration_tests": "b444e3062885ae615082870ae91793c98e85fcb0", "sbox_unittests": "2763a234ddc9e7c59d7fd6a0c9f3a2e406c7576f", "sbox_validation_tests": "633a6d897e0ed4817644fdc0b581e1300b02815b", "service_manager_unittests": "3de515b83e19acfdba3eb60ec19f5230ad49144c", "services_unittests": "a431f0545c46cc16909ecfd10b0115e2544e8741", "setup_unittests": "eeba6ce19a30dc1070aff8d44816e4f409e66eac", "shell_dialogs_unittests": "ff16db3b4d7900586e5c83f2061b13b2600c8f8d", "skia_unittests": "81dc7e77b997087212279075068047e1d5c8b083", "snapshot_unittests": "738971bd43a569d7502d2344c2fef4f7d53fe1a8", "sql_unittests": "2f54ac648551601e399a7233b5d2f91f720aeb62", "storage_unittests": "495c8accae5e73d95f36a35678fce19cb6194a20", "swiftshader_unittests": "b08d8af1ed75e24bdd89ce952f7afc47f09899ae", "sync_integration_tests": "3518cb84d3509debae4a719ab8ef8bd0bb33e4bc", "telemetry_gpu_integration_test": "692c3470b9ef7cb452995937d95159440c025b9e", "telemetry_gpu_unittests": "7ad68d36309318bade6a7f904431cdf8609beebe", "telemetry_perf_tests_without_chrome": "a70e51559c0e3b36166bc0d236cde207e2bdc4ec", "telemetry_perf_unittests": "502c01cd78e4f53fc0d562cae591c57773fd626d", "telemetry_unittests": "077067decfb1471423776c88cad93769f8a87b36", "tracing_perftests": "0c0f5b34e2343307cae357a2857c2e29b00a0872", "traffic_annotation_auditor_unittests": "0db38f95e20774206353e0a1d2784fb248421058", "ui_base_unittests": "29b027cd155891981ec0559a14b134cddaea8410", "ui_touch_selection_unittests": "62371c158e94295abcfe7acae55bcae31ed8f375", "unit_tests": "7017f3bf1c5e9e6d97f9fc0a03249f446903f53d", "url_unittests": "c2638b8e70303dd86853138821dd66f8415101b8", "video_decode_accelerator_unittest": "e7219ff5f7ca674a0dc9056aafd6ec87841489b9", "views_mus_interactive_ui_tests": "6dddd060b6ea428ded96c2f7fe7446cfe248c9ee", "views_mus_unittests": "cdfe960f02986e1975294f0ccad866d958ed2c8f", "views_perftests": "79fe821e23368510fdb0f002d81f722a201622bb", "views_unittests": "6944f897c5e54a77771a3c60ec77c7a6b048d5d7", "viz_unittests": "ffdfa8436e6af24a17db021e5a2828c2889ff0ae", "vr_common_perftests": "81f7b5ca3b9d862aa4f55bf7a47fd0d8021e5a3b", "vr_common_unittests": "6dd062aa5488d3be8808712826058d835163ac2b", "vr_pixeltests": "d7690f9aa70ef81713c45b27f1e8e7d0cc8a84e5", "webkit_layout_tests": "39c29561e75138069a8623b500b1649643e20b34", "webkit_layout_tests_exparchive": "e950d2fb5c8207f51eb78b02e27baca0e75e6e25", "webkit_python_tests": "afdb39b51aa52c05ebc3f3b9534a1b2754fab389", "webkit_unit_tests": "6e04fda81dcb37a14ea08438083dee25187ca624", "wm_unittests": "e8129a6ebe6ccd5c39ebe4571043b53f02a38255", "wtf_unittests": "f079eb940bb651cf40887678d8ee04029401431f", "zucchini_unittests": "c5e340f7260b95a01ae7f22ef89de759995133b1"} isolate tests
swarm_hashes {"accessibility_unittests": "be50f9a3647f355349fec7e2315c55927384b79c", "angle_end2end_tests": "822f77c6198b4ae026a3b4ba0d593f75adb98077", "angle_perftests": "7168d884e2a232f0da74a1e2813f008585b37adf", "angle_unittests": "bf7566b88a0f986328b997f392e381f6c1de3792", "angle_white_box_tests": "d6893dcd8ef350184a911da880912bebd21b3fbd", "app_shell_unittests": "717bd13575d66aaf3a28eb60f5c9be2284c2dda0", "aura_unittests": "b66c1d5580587f62d7e49f0dd3cd69f923acf033", "base_perftests": "b43df4115d3a4948573512c2a97a690e7dd8e742", "base_unittests": "f32fafd98ec4558633451acda43ad072a81cb898", "blink_common_unittests": "cc94daea2eadbd8a7435d6aa48f567ad197b39f8", "blink_fuzzer_unittests": "7ae6d0d0820fa0e50d608d0711add12ef55b0c1c", "blink_heap_unittests": "bb07291fe8fd2253be184beee874bdd001f873da", "blink_platform_unittests": "4f885f90991918e75724fcbeaa92ab5fcf14e0bd", "boringssl_crypto_tests": "952098a50fc6869679d61c093398c3d2297afcca", "boringssl_ssl_tests": "e8e7ba6be926100cd1f7ae02cb5301d1b11a00be", "browser_tests": "0aaf17a427a244a7f2baa7614f6402493b23f1a9", "cacheinvalidation_unittests": "7c737dcf178de503175650fe491bd53a7d6c1de6", "capture_unittests": "9b03a8a1b377cbd63d565cca707b46f82074cd10", "cast_unittests": "d312e876ad012098456241b9d93b61aa7ec47b68", "cc_unittests": "68287c0edea8414fe503424b832f919beb638510", "chrome_app_unittests": "552cca1a04e1e99fdfa6f1f3464df210fdd89d82", "chrome_cleaner_unittests": "d78e9acd5e1bb2353004213d83d3f8ba721774f1", "chrome_elf_import_unittests": "147c36a1f9d928a97c01ebf32cb9407cb15b04ce", "chrome_elf_unittests": "d204230d0d02e8d7c063c623cc51bad1932a4da3", "chromedriver_py_tests": "716384c2640f6abcc00f6989168ff44b070b4550", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "21e187612034f37344fa4ce9a7a83490d789f5a8", "command_buffer_perftests": "1e5931c9782b0a529514929e5c71a90f7589ed0a", "components_browsertests": "50b24ece55eb8de297401f597f237e9b577e6117", "components_perftests": "bdde8238fa5b38dfc51740de9da2fd9f2f6a8c3b", "components_unittests": "105d97d39504686799635e9d010715e858ebfcbe", "compositor_unittests": "e51d49f01c9ca3115aba89b111438f9d038406d6", "content_browsertests": "41a9319fcc3a95fdda21ed1ebb6ed984d7fb3353", "content_shell_crash_test": "8029a16600399b768494cf8f2671c7721d2b1e32", "content_unittests": "59fefdaf2cc4cde341a44f7381565d648991e1b8", "courgette_unittests": "cdb6593ab5a29156b7a86f368a089b33cad9a510", "crashpad_tests": "0fddef42e87ffbeac0e81d72c7bd9d31462026cd", "cronet_tests": "6382f9d7cb4ce3b5c78209bd55afa58c1de7f77e", "cronet_unittests": "9a300eb5d7cb7e207773c193ce2ef59e2acffb67", "crypto_unittests": "4cb106500ee7b40f8ca8e3a6eafcf7ed7e77f823", "dawn_end2end_tests": "c4d3c1315f6c0d3b25c0e3939ba56660d35d9712", "device_unittests": "ab30ca37954cddf4846ea49ef8893c37feb0d5b5", "devtools_closure_compile": "e7c0635d2cd8cb124ad5d3ca233a16d3e2f84068", "display_unittests": "9dcaa26f55d1a07638447036aaa0346682bfce98", "elevation_service_unittests": "1caebb6938d789af509bf98bb05238926d2d3221", "events_unittests": "3e28322db40bf02525efa39417d73ba201d46917", "extensions_browsertests": "36859ed5d9af6f50dfe907a702d55be4304c6f7d", "extensions_unittests": "c26f2ab799eb5192da3443253c872322a23f0016", "filesystem_service_unittests": "26fbb7c9516e8f7ba58c2e8a36f28e537b83f653", "gcm_unit_tests": "863da59337cb34bc41628e94ef0363136d2bd1b8", "gcp_unittests": "552340f2cee9d87124ece68552a512390e0e8ac0", "gfx_unittests": "109812ab6477468c5c12b86e3d3d82cb34ec3786", "gin_unittests": "fba794e1164bae54a4c1bcffcd6270b469bfb61e", "gl_tests": "90500ba8a30409d1ab5fdf66514a917ef76606d2", "gl_unittests": "b8ad21fc9f88bdcf96d8f8d1eb8d5bca4d4e2df7", "gl_unittests_ozone": "b8ad21fc9f88bdcf96d8f8d1eb8d5bca4d4e2df7", "gles2_conform_test": "58fb668507afcccf628cffd7d64976a8cd98f755", "google_apis_unittests": "74c91f2bf3b97c9d24643f02864a677f34b05f4a", "gpu_perftests": "95595840bf0fb3ece987fa462f0f1ba290e5feac", "gpu_unittests": "ed63280474ccf1330294535ef78633905bd7d9b9", "headless_browsertests": "6ecf8a1f6a2ab5683606f2db8f43871dbe1415bc", "headless_unittests": "3fbdaca892aa352d77f7b515949601df4df199af", "install_static_unittests": "283828edb289295a8a00eceb173e1a577d13eb1d", "installer_util_unittests": "4ec5e128d26c594054f6d36983ca7120edc3cd2e", "interactive_ui_tests": "04881da8b264797b75dd399645f1a59e7ab085ec", "ipc_tests": "e04315470aefba37ef2f86a8fff1450fd775789d", "jingle_unittests": "1af0967f235f73d5b2e4b799a8823efe6c3ad313", "latency_unittests": "254fea732f596c3ab13804b56f9978934c6d95cd", "leveldb_service_unittests": "1e95d87bf35992284e8dd7252d11bfe4284479af", "libjingle_xmpp_unittests": "c8404350576c67ad4c39c3ffa17880f9fd19962c", "load_library_perf_tests": "cd8773f98738796c5c9657f3a44228c7c68c4a30", "media_blink_unittests": "5c7349b1ac06358bb6eb092ea9b6bf5ac40438c5", "media_perftests": "8bd8fb61ec1d4e11e91f0fc725bed16f29dff19f", "media_service_unittests": "d91845dad7067d96006095d9601d26f30a4b5a00", "media_unittests": "b3ac5f7fc7cf00fa156551277855434c6b305262", "message_center_unittests": "068f3978f76bf88dc2d0874a6973041e296754bb", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "e0ebd1c7e4a0d58eba3c9a56abe8308e58ab7e26", "mini_installer_tests": "d86c64e47ba5e61ad83db731bdc5410d5ed91937", "mojo_core_unittests": "1f8cf39dcf69c290d34d9c37c169c7713167ae1b", "mojo_unittests": "bb0a0d20a98e9cfd6644fbbbab02f2c79fbabb27", "nacl_loader_unittests": "e315856ee7f72f52a3c66fdf7e0809b381e09d37", "native_theme_unittests": "46929c1fb7a7c4bef15a3f6b813ff37c0a8f9c60", "net_perftests": "d0e512e15b51950d2dab07e552fc71e3e3b4d108", "net_unittests": "b110f012d90dc4e676bd1f34302159e897d71d38", "notification_helper_unittests": "4c90639e3af615cb9efb4a58af0769a8da43e1f7", "pdf_unittests": "4627be04ba02603323b2ceadbca2030fa4c62123", "performance_browser_tests": "b4733eafaed109bf532082b34c44827adb41806d", "performance_test_suite": "8e32ae72231f3c4275f6e5d812a45a4f7c280093", "performance_webview_test_suite": "c96a486df3c6dd756c1cac992806c490a1d7210c", "ppapi_unittests": "6eac22f213a6030c3306454423ea21ff94c4d66b", "printing_unittests": "86fc542f7a508d1b3e0f2ef9de8225f8532d48d0", "remoting_unittests": "83c225ea07564bc2421887ac2d199f4a083b23cc", "sbox_integration_tests": "b444e3062885ae615082870ae91793c98e85fcb0", "sbox_unittests": "2763a234ddc9e7c59d7fd6a0c9f3a2e406c7576f", "sbox_validation_tests": "633a6d897e0ed4817644fdc0b581e1300b02815b", "service_manager_unittests": "3de515b83e19acfdba3eb60ec19f5230ad49144c", "services_unittests": "a431f0545c46cc16909ecfd10b0115e2544e8741", "setup_unittests": "eeba6ce19a30dc1070aff8d44816e4f409e66eac", "shell_dialogs_unittests": "ff16db3b4d7900586e5c83f2061b13b2600c8f8d", "skia_unittests": "81dc7e77b997087212279075068047e1d5c8b083", "snapshot_unittests": "738971bd43a569d7502d2344c2fef4f7d53fe1a8", "sql_unittests": "2f54ac648551601e399a7233b5d2f91f720aeb62", "storage_unittests": "495c8accae5e73d95f36a35678fce19cb6194a20", "swiftshader_unittests": "b08d8af1ed75e24bdd89ce952f7afc47f09899ae", "sync_integration_tests": "3518cb84d3509debae4a719ab8ef8bd0bb33e4bc", "telemetry_gpu_integration_test": "692c3470b9ef7cb452995937d95159440c025b9e", "telemetry_gpu_unittests": "7ad68d36309318bade6a7f904431cdf8609beebe", "telemetry_perf_tests_without_chrome": "a70e51559c0e3b36166bc0d236cde207e2bdc4ec", "telemetry_perf_unittests": "502c01cd78e4f53fc0d562cae591c57773fd626d", "telemetry_unittests": "077067decfb1471423776c88cad93769f8a87b36", "tracing_perftests": "0c0f5b34e2343307cae357a2857c2e29b00a0872", "traffic_annotation_auditor_unittests": "0db38f95e20774206353e0a1d2784fb248421058", "ui_base_unittests": "29b027cd155891981ec0559a14b134cddaea8410", "ui_touch_selection_unittests": "62371c158e94295abcfe7acae55bcae31ed8f375", "unit_tests": "7017f3bf1c5e9e6d97f9fc0a03249f446903f53d", "url_unittests": "c2638b8e70303dd86853138821dd66f8415101b8", "video_decode_accelerator_unittest": "e7219ff5f7ca674a0dc9056aafd6ec87841489b9", "views_mus_interactive_ui_tests": "6dddd060b6ea428ded96c2f7fe7446cfe248c9ee", "views_mus_unittests": "cdfe960f02986e1975294f0ccad866d958ed2c8f", "views_perftests": "79fe821e23368510fdb0f002d81f722a201622bb", "views_unittests": "6944f897c5e54a77771a3c60ec77c7a6b048d5d7", "viz_unittests": "ffdfa8436e6af24a17db021e5a2828c2889ff0ae", "vr_common_perftests": "81f7b5ca3b9d862aa4f55bf7a47fd0d8021e5a3b", "vr_common_unittests": "6dd062aa5488d3be8808712826058d835163ac2b", "vr_pixeltests": "d7690f9aa70ef81713c45b27f1e8e7d0cc8a84e5", "webkit_layout_tests": "39c29561e75138069a8623b500b1649643e20b34", "webkit_layout_tests_exparchive": "e950d2fb5c8207f51eb78b02e27baca0e75e6e25", "webkit_python_tests": "afdb39b51aa52c05ebc3f3b9534a1b2754fab389", "webkit_unit_tests": "6e04fda81dcb37a14ea08438083dee25187ca624", "wm_unittests": "e8129a6ebe6ccd5c39ebe4571043b53f02a38255", "wtf_unittests": "f079eb940bb651cf40887678d8ee04029401431f", "zucchini_unittests": "c5e340f7260b95a01ae7f22ef89de759995133b1"} isolate tests (2)

Blamelist:

  1. Alexei Svitkine (asvitkineohnoyoudont@chromium.org)
  2. Ian Clelland (iclellandohnoyoudont@chromium.org)
  3. Jan Krcal (jkrcalohnoyoudont@chromium.org)
  4. Sadrul Habib Chowdhury (sadrulohnoyoudont@chromium.org)
  5. Brian Osman (brianosmanohnoyoudont@google.com)
  6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. Jun Choi (hongjunchoiohnoyoudont@chromium.org)
  8. David Bokan (bokanohnoyoudont@chromium.org)
  9. Xida Chen (xidachenohnoyoudont@chromium.org)
  10. Peter Boström (pbosohnoyoudont@chromium.org)
  11. Eric Seckler (esecklerohnoyoudont@chromium.org)
  12. Steve Anton (steveantonohnoyoudont@chromium.org)
  13. Vladislav Kaznacheev (kaznacheevohnoyoudont@google.com)
  14. Paul Jensen (pauljensenohnoyoudont@chromium.org)
  15. Philip Rogers (pdrohnoyoudont@chromium.org)
  16. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  17. Martin Robinson (mrobinsonohnoyoudont@igalia.com)
  18. Mirko Bonadei (mbonadeiohnoyoudont@chromium.org)
  19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  20. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  21. Xianda Sun (sunxdohnoyoudont@chromium.org)
  22. Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
  23. Takumi Fujimoto (takumifohnoyoudont@chromium.org)
  24. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  25. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
  26. Ken Rockot (rockotohnoyoudont@chromium.org)
  27. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  28. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  29. Marc Treib (treibohnoyoudont@chromium.org)
  30. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  31. Alexandr Ilin (alexilinohnoyoudont@chromium.org)
  32. gogerald (gogeraldohnoyoudont@google.com)
  33. Jan Lamecki (jachorohnoyoudont@google.com)
  34. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  35. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  36. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  37. Colin Blundell (blundellohnoyoudont@chromium.org)
  38. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  39. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  40. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  41. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  42. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  43. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  44. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  45. Rayan Kanso (rayankansohnoyoudont@google.com)
  46. David Roger (drogerohnoyoudont@chromium.org)
  47. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  48. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  49. Eric Seckler (esecklerohnoyoudont@chromium.org)
  50. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  51. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  52. Clemens Arbesser (arbesserohnoyoudont@google.com)
  53. David Jean (djeanohnoyoudont@google.com)
  54. jdoerrie (jdoerrieohnoyoudont@chromium.org)
  55. Shu Chen (shuchenohnoyoudont@google.com)
  56. Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
  57. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  58. Arthur Sonzogni (arthursonzogniohnoyoudont@chromium.org)
  59. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  60. Clemens Arbesser (arbesserohnoyoudont@google.com)

Timing:

Create Wednesday, 14-Nov-18 16:43:58 UTC
Start Wednesday, 14-Nov-18 17:32:09 UTC
End Wednesday, 14-Nov-18 20:34:13 UTC
Pending 48 mins 11 secs
Execution 3 hrs 2 mins

All Changes:

  1. Optimize about_flags::RecordUMAStatistics().

    Changed by Alexei Svitkine - asvitkineohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 103faf893940889d189a6620ddb46ff871666b32

    Comments

    Optimize about_flags::RecordUMAStatistics().
    
    Combines the GetSwitchesFromFlags() and GetFeaturesFromFlags()
    calls to avoid GenerateFlagsToSwitchesMapping() being called
    twice, which we have evidence of being expensive.
    
    Bug: 904575
    Change-Id: Ie89acad8175fdfe029a951074b9aa1f4f7678f95
    Reviewed-on: https://chromium-review.googlesource.com/c/1333875
    Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: ssid <ssid@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608005}

    Changed files

    • chrome/browser/about_flags.cc
    • components/flags_ui/flags_state.cc
    • components/flags_ui/flags_state.h
  2. Add report-only mode to Feature Policy

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:42:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f482e77e59ef0a506e745182ca6843080cd8d1ea

    Comments

    Add report-only mode to Feature Policy
    
    This change adds a "report-only" policy to each security context, which
    is local to that context (not replicated across processes) and is used
    to determine whether a report should be sent even if a feature is
    enabled, when the feature is used.
    
    Reports are now augmented with a "disposition" field, which is either
    "enforce", if the feature usage was actually blocked, or "report", if
    it was not.
    
    Feature policy directives are placed in the report-only policy if the
    feature name is suffixed with "-report-only", otherwise, they affect
    the regular (enforcing) policy.
    
    Explainer at
    https://github.com/WICG/feature-policy/blob/master/reporting.md
    
    Existing tests are updated, and new tests for report-only mode are
    added to ensure that reports are sent even when the feature is used
    successfully.
    
    Bug: 904878
    Change-Id: I27bc42729c5ab5560160f3d993431e606a8a3a47
    Reviewed-on: https://chromium-review.googlesource.com/c/1178811
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608004}

    Changed files

    • content/browser/frame_host/render_frame_host_feature_policy_unittest.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/net/reporting_service_proxy.cc
    • content/browser/site_per_process_browsertest.cc
    • content/common/frame_messages.h
    • content/test/test_render_frame_host.cc
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/camera-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/camera-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/camera-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/document-write-report-only.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/document-write-report-only.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/document-write-reporting.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/encrypted-media-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/encrypted-media-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/encrypted-media-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/fullscreen-report-only.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/fullscreen-report-only.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/fullscreen-reporting.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/geolocation-report-only.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/geolocation-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/geolocation-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/geolocation-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/microphone-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/microphone-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/microphone-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/midi-report-only-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/midi-report-only.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/midi-report-only.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/midi-reporting.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/payment-report-only.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/payment-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/payment-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/payment-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/picture-in-picture-report-only.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/picture-in-picture-report-only.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/picture-in-picture-reporting.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/sync-xhr-report-only.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/sync-xhr-report-only.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/sync-xhr-reporting.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/usb-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/usb-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/usb-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/vr-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/vr-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/vr-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/xr-report-only.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/xr-report-only.https.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/xr-reporting.https.html
    • third_party/blink/common/feature_policy/feature_policy.cc
    • third_party/blink/common/feature_policy/feature_policy_mojom_traits.cc
    • third_party/blink/common/feature_policy/feature_policy_mojom_traits.h
    • third_party/blink/common/feature_policy/feature_policy_unittest.cc
    • third_party/blink/public/common/feature_policy/feature_policy.h
    • third_party/blink/public/mojom/feature_policy/feature_policy.mojom
    • third_party/blink/public/platform/reporting.mojom
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/execution_context/security_context.cc
    • third_party/blink/renderer/core/execution_context/security_context.h
    • third_party/blink/renderer/core/feature_policy/feature_policy.cc
    • third_party/blink/renderer/core/feature_policy/feature_policy_test.cc
    • third_party/blink/renderer/core/feature_policy/iframe_policy.h
    • third_party/blink/renderer/core/frame/feature_policy_violation_report_body.h
    • third_party/blink/renderer/core/frame/feature_policy_violation_report_body.idl
    • third_party/blink/renderer/core/html/html_frame_element.cc
    • third_party/blink/renderer/core/html/html_plugin_element.cc
    • third_party/blink/renderer/core/html/media/media_element_parser_helpers.cc
    • third_party/blink/renderer/modules/webusb/usb.cc
    • third_party/blink/renderer/modules/webusb/usb.h
  3. [AF] Integration tests for changing additional info for wallet metadata

    Changed by Jan Krcal - jkrcalohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:41:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad793ba03b073e47e865aa2625c9bd12118d6e77

    Comments

    [AF] Integration tests for changing additional info for wallet metadata
    
    This CL adds more integration tests; it also fixes a bug that
    stopped local changes of billing address and local changes of
    has_converted to get propagated to sync.
    
    Bug: 894001
    Change-Id: Idd91e6799afd3c936b76ac8b1a6851abc67b5ad7
    Reviewed-on: https://chromium-review.googlesource.com/c/1333819
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Jan Krcal <jkrcal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608003}

    Changed files

    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
    • chrome/browser/sync/test/integration/wallet_helper.cc
    • chrome/browser/sync/test/integration/wallet_helper.h
    • components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
    • components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
    • components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
  4. viz: Include presentation-feedback with begin-frame.

    Changed by Sadrul Habib Chowdhury - sadrulohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:28:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fd1a4804046eec31e0ba44435cb41aed015266b9

    Comments

    viz: Include presentation-feedback with begin-frame.
    
    Instead of sending the presentation-feedback over a separate IPC,
    include it with the begin-frame messages. The presentation feedback
    can be requested for each frame. So this can reduce an extra IPC
    per frame for each client.
    
    BUG=883592
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Iab52a29f406078eab79948a942124c8e13cb4332
    Reviewed-on: https://chromium-review.googlesource.com/c/1175492
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608002}

    Changed files

    • android_webview/browser/hardware_renderer.cc
    • android_webview/browser/hardware_renderer.h
    • android_webview/browser/surfaces_instance.cc
    • android_webview/browser/surfaces_instance.h
    • cc/mojo_embedder/async_layer_tree_frame_sink.cc
    • cc/mojo_embedder/async_layer_tree_frame_sink.h
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_impl.cc
    • components/viz/service/display/display_unittest.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.h
    • components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
    • components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
    • components/viz/service/surfaces/surface_unittest.cc
    • components/viz/test/fake_compositor_frame_sink_client.cc
    • components/viz/test/fake_compositor_frame_sink_client.h
    • components/viz/test/mock_compositor_frame_sink_client.h
    • components/viz/test/test_layer_tree_frame_sink.cc
    • components/viz/test/test_layer_tree_frame_sink.h
    • content/browser/renderer_host/delegated_frame_host.cc
    • content/browser/renderer_host/delegated_frame_host.h
    • content/browser/renderer_host/delegated_frame_host_client_android.cc
    • content/browser/renderer_host/delegated_frame_host_client_android.h
    • content/browser/renderer_host/render_widget_host_view_android.cc
    • content/browser/renderer_host/render_widget_host_view_android.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
    • content/renderer/android/synchronous_layer_tree_frame_sink.cc
    • content/renderer/android/synchronous_layer_tree_frame_sink.h
    • content/test/fake_renderer_compositor_frame_sink.h
    • services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
    • third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
    • third_party/blink/renderer/platform/graphics/begin_frame_provider.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.h
    • third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
    • ui/android/delegated_frame_host_android.cc
    • ui/android/delegated_frame_host_android.h
    • ui/android/delegated_frame_host_android_unittest.cc
  5. Remove SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS

    Changed by Brian Osman - brianosmanohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 16:14:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 684b8a721741358d284507d7a17675e538c1e750

    Comments

    Remove SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS
    
    This enables a fast-path in Skia's AAConvexPathRenderer for paths that
    only have lines (no higher order curves).
    
    Change-Id: I0222d572f7679a270f6634bfc326a145dd6a7bed
    Reviewed-on: https://chromium-review.googlesource.com/c/1334230
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Commit-Queue: Brian Osman <brianosman@google.com>
    Cr-Commit-Position: refs/heads/master@{#608001}

    Changed files

    • skia/config/SkUserConfig.h
    • third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
    • third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
    • third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
    • third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
    • third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
    • third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
    • third_party/WebKit/LayoutTests/platform/win7/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
    • third_party/WebKit/LayoutTests/platform/win7/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
    • third_party/WebKit/LayoutTests/platform/win7/virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png
  6. Roll src/third_party/perfetto 4cda101d36dd..d7aa8b741012 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 16:12:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46e09889a99d71f808959db390838b19aa32fc46

    Comments

    Roll src/third_party/perfetto 4cda101d36dd..d7aa8b741012 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/4cda101d36dd..d7aa8b741012
    
    
    git log 4cda101d36dd..d7aa8b741012 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 hjd@google.com Merge "trace_processor: JSON importer coerces numbers"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@d7aa8b741012
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I6bb7e0224ea80be04506b7b1ff07176e67d040c6
    Reviewed-on: https://chromium-review.googlesource.com/c/1335770
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#608000}

    Changed files

    • DEPS
  7. Remove callbacks bound to base::Unretained(this) in FidoBleDevice

    Changed by Jun Choi - hongjunchoiohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:12:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e0a0c6a68a3509b578febde5ec103fa16665fad

    Comments

    Remove callbacks bound to base::Unretained(this) in FidoBleDevice
    
    Replace callbacks in FidoBleDevice bound to base::Unretained(this) to
    callbacks bound to weak pointers. When user navigates away from the site
    calling the WebAuthN API while request is being dispatched, callbacks in
    FidoBleDevice may be invoked after FidoBleDevice is destroyed. This is
    especially the case when the user navigates away during pairing process.
    In this case, FidoBleDevice::OnReadControlPointLength() will be called
    after FidoBleDevice is destroyed.
    
    Bug: 877344
    Change-Id: I14ad94cfc9624c50eeee88feb1a12a6f8488c696
    Reviewed-on: https://chromium-review.googlesource.com/c/1335727
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607999}

    Changed files

    • device/fido/ble/fido_ble_device.cc
  8. Minor cleanups in GestureEventQueue

    Changed by David Bokan - bokanohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e34b190866767a53598230f4a2668ec45b1bdfa

    Comments

    Minor cleanups in GestureEventQueue
    
    In https://crrev.com/c/1332769 we removed the vsync aligned feature
    flag. This caused the removal of much code in GestureEventQueue. Namely,
    it no longer attempts to coalesce and queue events.
    
    This CL cleans up the nomenclature and commentary in the class to better
    reflect its current duties.
    
    Bug: 625689
    Change-Id: I295fec7923b8d251853b9522c54641edfcac076a
    Reviewed-on: https://chromium-review.googlesource.com/c/1334203
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607998}

    Changed files

    • content/browser/renderer_host/input/gesture_event_queue.cc
    • content/browser/renderer_host/input/gesture_event_queue.h
    • content/browser/renderer_host/input/gesture_event_queue_unittest.cc
    • content/browser/renderer_host/input/input_router_impl.cc
  9. [Code health] Remove a dead function declaration

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:11:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c3fa1796a807bd68b7fcf205732187541ffc989

    Comments

    [Code health] Remove a dead function declaration
    
    There is no definition of this function.
    
    Bug: None
    Change-Id: I51f25306a794bfe55612ad90500f9538643a85c4
    Reviewed-on: https://chromium-review.googlesource.com/c/1335829
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607997}

    Changed files

    • content/renderer/render_widget.h
  10. Don't schedule UI updates on load progress

    Changed by Peter Boström - pbosohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:10:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c65b08a1d44375e034ee693649bc923b179799e9

    Comments

    Don't schedule UI updates on load progress
    
    The load-progress animation is driven off a timer that starts in
    LoadingStateChanged and progresses without scheduling another update.
    
    This is a likely cause for performance regressions as all load progress
    updates (even ones without UI changes) will hammer this function.
    
    Bug: chromium:905189, chromium:903147, chromium:901751
    Change-Id: I92828bbaee6f15fc497ae50ec0d4c3975e638a86
    Reviewed-on: https://chromium-review.googlesource.com/c/1335948
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Peter Boström <pbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607996}

    Changed files

    • chrome/browser/ui/browser.cc
    • chrome/browser/ui/browser.h
  11. perfetto: Make ProducerClient a singleton

    Changed by Eric Seckler - esecklerohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:09:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 178e46f542fc17abd0d0c74fcb2a2d274b46a2e1

    Comments

    perfetto: Make ProducerClient a singleton
    
    So that we can access the process-wide client from other tracing agents.
    
    Bug: 900603
    Change-Id: Ie157ecc6c5e59e449c8e8182d3a2b31ea8b1bd9e
    Reviewed-on: https://chromium-review.googlesource.com/c/1335588
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: oysteine <oysteine@chromium.org>
    Commit-Queue: Eric Seckler <eseckler@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607995}

    Changed files

    • services/tracing/public/cpp/perfetto/producer_client.cc
    • services/tracing/public/cpp/perfetto/producer_client.h
    • services/tracing/public/cpp/trace_event_agent.cc
  12. Add steveanton to modules/peerconnection OWNERS

    Changed by Steve Anton - steveantonohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 16:06:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c8b45750be548c09f7bc04f7192913989af183c

    Comments

    Add steveanton to modules/peerconnection OWNERS
    
    Bug: None
    Change-Id: I39361bdfe70f51804cdc01e54d474fe064e1b366
    No-Try: True
    Reviewed-on: https://chromium-review.googlesource.com/c/1335888
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Commit-Queue: Steve Anton <steveanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607994}

    Changed files

    • third_party/blink/renderer/modules/peerconnection/OWNERS
  13. Update app.mojom

    Changed by Vladislav Kaznacheev - kaznacheevohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 16:02:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2cb5dd3b0abbdb6d5a11dccafffc741734e92ea1

    Comments

    Update app.mojom
    
    Add AppDataRequestState.NOT_SIGNED_IN to support ag/5485166
    
    Bug: b:118888407
    Test: compile
    Change-Id: If708bbad7a400edacd8c0b144ba1903c448d9286
    Reviewed-on: https://chromium-review.googlesource.com/c/1331952
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Reviewed-by: Mattias Nissler <mnissler@chromium.org>
    Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607993}

    Changed files

    • components/arc/common/app.mojom
  14. Avoid crashing if app does not have ACCESS_NETWORK_STATE permission.

    Changed by Paul Jensen - pauljensenohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:58:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68d91f825adb215c35c18fddb0fef67612a09b42

    Comments

    Avoid crashing if app does not have ACCESS_NETWORK_STATE permission.
    
    WebView does not require this permissions so this check is necessary.
    Internal bug b/119516001.
    
    Change-Id: Icbc37b5f9ff24343d50a81a28d1ee0a58644e9bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1335868
    Reviewed-by: Misha Efimov <mef@chromium.org>
    Commit-Queue: Paul Jensen <pauljensen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607992}

    Changed files

    • net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java
  15. Re-enable PaintTouchActionRects

    Changed by Philip Rogers - pdrohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:47:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82cc4869d96f7345e42e3114b4bb12e6f5c9a368

    Comments

    Re-enable PaintTouchActionRects
    
    This patch re-enables PaintTouchActionRects after the following changes:
    crrev.com/606921 - Ensure PaintChunk::hit_test_data is updated in a cached subsequence
    crrev.com/607236 - Paint replaced hit test rects without background
    crrev.com/607238 - Paint hit test rects when acceleration skips bg
    
    These fixes address all known issues.
    
    Bug: 903480
    Change-Id: I8ae56a1b97b5d9345508a8193a55097a9040bd89
    Reviewed-on: https://chromium-review.googlesource.com/c/1334330
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Reviewed-by: Xianda Sun <sunxd@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607991}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  16. Roll src/third_party/skia b45b53f01cf3..7f2b6fa66575 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 15:47:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ebc59cb68fb799c24d9c0b1872dc202b90e41c2

    Comments

    Roll src/third_party/skia b45b53f01cf3..7f2b6fa66575 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/b45b53f01cf3..7f2b6fa66575
    
    
    git log b45b53f01cf3..7f2b6fa66575 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 caryclark@skia.org fix pathops fuzzes
    
    
    Created with:
      gclient setdep -r src/third_party/skia@7f2b6fa66575
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=rmistry@chromium.org
    
    Change-Id: Ia8902afcad2f62d7b681d99b04b89c761795add7
    Reviewed-on: https://chromium-review.googlesource.com/c/1335771
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607990}

    Changed files

    • DEPS
  17. Add X11 support for ATK key event listeners

    Changed by Martin Robinson - mrobinsonohnoyoudont@igalia.com
    Changed at Wednesday, 14-Nov-18 15:43:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b26b9d891ad497c3928e9b7c04567100efe9bbdd

    Comments

    Add X11 support for ATK key event listeners
    
    ATK requires us to allow it to filter all key events. Add an AtkUtil
    mechanism to filter key events.
    
    Bug: 866334
    Change-Id: I42383479ab78242325bda0714afb60b7dcf2fe65
    Reviewed-on: https://chromium-review.googlesource.com/c/1319709
    Commit-Queue: Martin Robinson <mrobinson@igalia.com>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607989}

    Changed files

    • ui/accessibility/BUILD.gn
    • ui/accessibility/platform/DEPS
    • ui/accessibility/platform/atk_util_auralinux.cc
    • ui/accessibility/platform/atk_util_auralinux.h
    • ui/accessibility/platform/atk_util_auralinux_unittest.cc
    • ui/accessibility/platform/atk_util_auralinux_x11.cc
    • ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
  18. Patch to avoid -Wundef error in the WebRTC build.

    Changed by Mirko Bonadei - mbonadeiohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:42:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c0293693337dbf4902581dc1bcc00233a564b0c4

    Comments

    Patch to avoid -Wundef error in the WebRTC build.
    
    The fix has been upstreamed and it will be rolled as soon as Abseil
    rolls into //third_party/abseil-cpp.
    
    Bug: None
    Change-Id: Ifd5e17c30b021518f09d81ad60da919303d5e6ee
    Reviewed-on: https://chromium-review.googlesource.com/c/1335927
    Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
    Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607988}

    Changed files

    • third_party/abseil-cpp/absl/hash/internal/hash.h
  19. Roll src/third_party/webrtc c58c8a54224d..76f9954b17a4 (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 15:41:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e7f70c16998abd53ebd1c3083a9032fcc051ee41

    Comments

    Roll src/third_party/webrtc c58c8a54224d..76f9954b17a4 (5 commits)
    
    https://webrtc.googlesource.com/src.git/+log/c58c8a54224d..76f9954b17a4
    
    
    git log c58c8a54224d..76f9954b17a4 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 terelius@webrtc.org Remove the old RTC event log parser.
    2018-11-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db720b4ab9..fbed28d429 (606025:607938)
    2018-11-14 yvesg@webrtc.org Less strict audio codec tests to accomodate opus switch to SSE.
    2018-11-14 yvesg@webrtc.org Fix lint errors for android manifests.
    2018-11-14 mbonadei@webrtc.org Rectify comment about 'build_with_chromium'.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@76f9954b17a4
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:900912
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I9b3cfb1fa144d2aaf6dcffc1c1968642403d327c
    Reviewed-on: https://chromium-review.googlesource.com/c/1335772
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607987}

    Changed files

    • DEPS
  20. Remove libgtk-3-0:i386 from install-build-deps.sh

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:33:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a9a24b45775ace57856ebb7567e497e66f3d289

    Comments

    Remove libgtk-3-0:i386 from install-build-deps.sh
    
    The CL removes libgtk-3-0:i386 from install-build-deps.sh as it fails to be
    installed on the freshly installed Google glinux machine.
    
    For more info and the errors installing the package, see
    https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ODZ88EuoxK4
    
    Change-Id: I4cf64ef3b98fd2a8a5299d4859da63c7a0c5f4f9
    Reviewed-on: https://chromium-review.googlesource.com/c/1332207
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607986}

    Changed files

    • build/install-build-deps.sh
  21. Add viz hit test surface layer metrics

    Changed by Xianda Sun - sunxdohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:32:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 567005d56ccb3072bd723c3422997d0c42546b69

    Comments

    Add viz hit test surface layer metrics
    
    With cc generated hit test data, viz hit test surface layer is capable
    of doing synchronous hit testing under some non-trivial cases. Despite
    that it still has to do slow path hit testing under some circumstances.
    This patch added a metric to record the reasons of slow path hit test.
    
    Bug: 901882
    Change-Id: Icaff4c9ba01add4dfc4620b5d7e28fd85683dba9
    Reviewed-on: https://chromium-review.googlesource.com/c/1318078
    Reviewed-by: Ria Jiang <riajiang@chromium.org>
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Commit-Queue: Xianda Sun <sunxd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607985}

    Changed files

    • cc/trees/layer_tree_host_impl.cc
    • components/viz/client/hit_test_data_provider_draw_quad.cc
    • components/viz/common/hit_test/aggregated_hit_test_region.h
    • components/viz/common/hit_test/hit_test_region_list.h
    • components/viz/host/hit_test/hit_test_query.cc
    • components/viz/host/hit_test/hit_test_query.h
    • components/viz/host/hit_test/hit_test_query_fuzzer.cc
    • components/viz/host/hit_test/hit_test_query_unittest.cc
    • components/viz/service/hit_test/hit_test_aggregator.cc
    • components/viz/service/hit_test/hit_test_aggregator.h
    • content/browser/renderer_host/render_widget_host_input_event_router_unittest.cc
    • services/viz/public/cpp/hit_test/aggregated_hit_test_region_struct_traits.cc
    • services/viz/public/cpp/hit_test/aggregated_hit_test_region_struct_traits.h
    • services/viz/public/cpp/hit_test/hit_test_region_list_struct_traits.cc
    • services/viz/public/cpp/hit_test/hit_test_region_list_struct_traits.h
    • services/viz/public/cpp/hit_test/struct_traits_unittest.cc
    • services/viz/public/interfaces/hit_test/aggregated_hit_test_region.mojom
    • services/viz/public/interfaces/hit_test/hit_test_region_list.mojom
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  22. v8binding: Handle nullable DOMString return value of OnBeforeUnloadEventHandler

    Changed by Yuki Shiino - yukishiinoohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:29:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 869e3162d9efe4cdfd2a7726f23648baec929c6f

    Comments

    v8binding: Handle nullable DOMString return value of OnBeforeUnloadEventHandler
    
    OnBeforeUnloadEventHandler's return type is DOMString?, so we need to
    handle the case that the return value is null.  This patch fixes the
    behavior in case of null.
    
    Change-Id: I23e4b06174adb42111584f1e84f7ca1c9d04e56c
    Reviewed-on: https://chromium-review.googlesource.com/c/1335750
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607984}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
  23. [Media Router] Add MediaRouterUiForTest

    Changed by Takumi Fujimoto - takumifohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:22:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 139eccc4102611b140471ee0a275337be7fd7966

    Comments

    [Media Router] Add MediaRouterUiForTest
    
    This CL adds test API that will be used by integration and e2e browser
    tests to manipulate the Views Cast dialog.
    
    Bug: 900243
    Change-Id: I0dc0c4ce08a3f9b78764459b6298502d4a8e0901
    Reviewed-on: https://chromium-review.googlesource.com/c/1284211
    Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
    Reviewed-by: mark a. foltz <mfoltz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607983}

    Changed files

    • chrome/browser/ui/views/media_router/cast_dialog_sink_button.h
    • chrome/browser/ui/views/media_router/cast_dialog_view.cc
    • chrome/browser/ui/views/media_router/cast_dialog_view.h
    • chrome/test/media_router/BUILD.gn
    • chrome/test/media_router/media_router_ui_for_test.cc
    • chrome/test/media_router/media_router_ui_for_test.h
  24. Roll src-internal db3e43bd9c5d..1680e702bb3f (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 15:19:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 85504ef95070cf6ba49a01aaed4c15c1c2535679

    Comments

    Roll src-internal db3e43bd9c5d..1680e702bb3f (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db3e43bd9c5d..1680e702bb3f
    
    
    Created with:
      gclient setdep -r src-internal@1680e702bb3f
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ic9b3206c365407f978d0306b19a51c022207168c
    Reviewed-on: https://chromium-review.googlesource.com/c/1335773
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607982}

    Changed files

    • DEPS
  25. [s13n] Convert profile_downloader_unittest.cc away from using ProfileOAuth2TokenService

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Wednesday, 14-Nov-18 15:13:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b33214021c662a278d50d34fc88098786322ae2c

    Comments

    [s13n] Convert profile_downloader_unittest.cc away from using ProfileOAuth2TokenService
    
    BUG=904407
    
    Change-Id: Ibfc219bb273a7ff8ee1d8693ca2f25994a038f5b
    Reviewed-on: https://chromium-review.googlesource.com/c/1335907
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#607981}

    Changed files

    • chrome/browser/profiles/profile_downloader_unittest.cc
  26. [mojo-bindings] Fix JS lite serialization

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:10:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f209969571d32c3e234c74b84d4d6a2359ec7f5c

    Comments

    [mojo-bindings] Fix JS lite serialization
    
    Fixes mojom JS lite serialization in cases where fields are
    intentionally packed out of order.
    
    This actually simplifies the serialization and deserialization logic
    significantly by leveraging precomputed byte/bit offset values from
    the bindings generator and preallocating the entire message buffer
    prior to serialization.
    
    It also is now correct instead of incorrect, which is nice.
    
    Bug: 904861
    Change-Id: If08c301303004d164f4a0afcc3085dac86ca3089
    Reviewed-on: https://chromium-review.googlesource.com/c/1335269
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Ken Rockot <rockot@google.com>
    Cr-Commit-Position: refs/heads/master@{#607980}

    Changed files

    • mojo/public/js/bindings_lite.js
    • mojo/public/tools/bindings/generators/js_templates/lite/struct_definition.tmpl
  27. [perf] Add load:media:google_images:2018 system health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 15:01:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aed4a1140a02c3634a795a8ec25f069264c1330b

    Comments

    [perf] Add load:media:google_images:2018 system health story
    
    This CL was created automatically with tools/perf/update_wpr script
    
    R=perezju@chromium.org
    
    Bug: 878390
    Change-Id: Ib1c39da9570be4bdebccc23e896663f0eeb3ddd5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329628
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607979}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_2fefa84cbf.wprgo.sha1
    • tools/perf/page_sets/data/system_health_mobile.json
    • tools/perf/page_sets/data/system_health_mobile_cac60dab45.wprgo.sha1
    • tools/perf/page_sets/system_health/loading_stories.py
  28. [Unity][Android] Check for null before getting the account name

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 14:58:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5b672136268b2fb136bb6541f3c3f244007f0e2b

    Comments

    [Unity][Android] Check for null before getting the account name
    
    This CL checks that Intent received by
    SigninFragmentBase.onActivityResult isn't null before trying to get
    account name from it. The Intent can be null on older Android versions,
    leading to a crash. Also, after this CL AccountPickerDialogFragment
    won't be dismissed if onActivityResult can't get the account name from
    the Intent, letting the user to select the account manually.
    
    Bug: None
    Change-Id: I4740410da75023ee73fb90b6f7f9659982b96190
    Reviewed-on: https://chromium-review.googlesource.com/c/1335577
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607978}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninFragmentBase.java
  29. UrlKeyedDataCollectionConsentHelperTest: Use syncer::TestSyncService

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 14:56:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0955e76b373804b6623c1adbc89af246066fa361

    Comments

    UrlKeyedDataCollectionConsentHelperTest: Use syncer::TestSyncService
    
    instead of syncer::FakeSyncService. TestSyncService already supports a
    good portion of the setters that are needed here, so this allows us to
    remove a bunch of boilerplate.
    
    Bug: 859874
    Change-Id: I2520cfb526c81de566630dd7f956ddc45eabcee3
    Reviewed-on: https://chromium-review.googlesource.com/c/1335593
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607977}

    Changed files

    • components/unified_consent/url_keyed_data_collection_consent_helper_unittest.cc
  30. Update V8 to version 7.2.328.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 14:49:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a5b9af8d06b884031db89c4dc1dd23357e717ac

    Comments

    Update V8 to version 7.2.328.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/e7da3e75..388a62c2
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I456267006d8b70fe61c2d95ff3d3ab9d4c1d6333
    Reviewed-on: https://chromium-review.googlesource.com/c/1335828
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607976}

    Changed files

    • DEPS
  31. Constexpr-eliminate GetCategoryGroupEnabled calls for popular categories

    Changed by Alexandr Ilin - alexilinohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 14:48:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 331266377d03b51dc3e2cf2c26b896e21f8f0391

    Comments

    Constexpr-eliminate GetCategoryGroupEnabled calls for popular categories
    
    This CL allows to avoid the cost of calling GetCategoryGroupEnabled() in
    TRACE_EVENT macros for popular categories, in a way that doesn't require more
    macros, nor changing all the call sites.
    
    The idea is to put all popular categories into a static global array so an
    address of a category state may be determined at compile-time through a call
    to a constexpr function.
    
    This CL makes it impossible to use non constant expressions as a category name
    in the tracing macros. All the call sites that don't satisfy this requirement
    have to be converted. Hopefully, there aren't a lot of such callers.
    
    This change reduces the code size generated from each trace macro by ~16 bytes,
    check the full report here:
    https://docs.google.com/document/d/1piIq_yi2fsqOEKObx0tFHeunMyX7hp2ZdAGKK6t0k80/edit?usp=sharing.
    The total Android apk size savings are ~60 KiB.
    
    Bug: 702718, 708990
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I9f7b48fd4ee614996feaabda3e5495fd9b786c3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1251361
    Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Frank Liberato <liberato@chromium.org>
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: David Turner <digit@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607975}

    Changed files

    • android_webview/common/devtools_instrumentation.h
    • base/BUILD.gn
    • base/android/early_trace_event_binding.cc
    • base/android/trace_event_binding.cc
    • base/trace_event/auto_open_close_event.cc
    • base/trace_event/auto_open_close_event.h
    • base/trace_event/builtin_categories.cc
    • base/trace_event/builtin_categories.h
    • base/trace_event/category_registry.cc
    • base/trace_event/category_registry.h
    • base/trace_event/cpufreq_monitor_android.cc
    • base/trace_event/memory_dump_manager.cc
    • base/trace_event/memory_dump_manager.h
    • base/trace_event/trace_category.h
    • base/trace_event/trace_category_unittest.cc
    • base/trace_event/trace_event.h
    • base/trace_event/trace_event_unittest.cc
    • base/trace_event/trace_log.cc
    • base/trace_event/trace_log.h
    • cc/base/devtools_instrumentation.cc
    • cc/base/devtools_instrumentation.h
    • cc/benchmarks/benchmark_instrumentation.h
    • cc/tiles/frame_viewer_instrumentation.cc
    • cc/tiles/frame_viewer_instrumentation.h
    • cc/trees/layer_tree_host_impl.cc
    • chrome/browser/android/vr/gvr_scheduler_delegate.cc
    • chrome/browser/android/vr/scoped_gpu_trace.cc
    • chrome/browser/android/vr/scoped_gpu_trace.h
    • components/heap_profiling/test_driver.cc
    • content/browser/renderer_host/render_widget_targeter.cc
    • content/browser/tracing/file_tracing_provider_impl.cc
    • media/base/scoped_async_trace.cc
    • media/base/scoped_async_trace.h
    • media/blink/video_frame_compositor.cc
    • media/blink/video_frame_compositor.h
    • media/gpu/android/media_codec_video_decoder.cc
    • net/BUILD.gn
    • net/base/network_delegate.cc
    • net/base/trace_constants.cc
    • net/base/trace_constants.h
    • net/cert/crl_set.cc
    • net/cert/multi_threaded_cert_verifier.cc
    • net/dns/host_cache.cc
    • net/dns/host_resolver_impl.cc
    • net/http/http_cache_transaction.cc
    • net/http/http_stream_factory_job.cc
    • net/log/trace_net_log_observer.cc
    • net/nqe/network_quality_estimator.cc
    • net/proxy_resolution/proxy_resolver_v8_tracing.cc
    • net/quic/quic_stream_factory.cc
    • net/socket/client_socket_handle.cc
    • net/socket/client_socket_pool_base.cc
    • net/socket/socket_posix.cc
    • net/socket/ssl_client_socket_impl.cc
    • net/socket/ssl_client_socket_pool.cc
    • net/socket/transport_client_socket_pool.cc
    • net/socket/udp_socket_posix.cc
    • net/socket/websocket_transport_client_socket_pool.cc
    • net/spdy/spdy_session_pool.cc
    • net/url_request/url_request_http_job.cc
    • services/tracing/public/cpp/perfetto/trace_event_data_source_unittest.cc
    • services/tracing/public/cpp/trace_event_agent_unittest.cc
    • third_party/blink/renderer/platform/bindings/runtime_call_stats.cc
    • third_party/blink/renderer/platform/network/network_instrumentation.cc
    • third_party/blink/renderer/platform/scheduler/common/throttling/cpu_time_budget_pool.h
    • third_party/blink/renderer/platform/scheduler/common/tracing_helper.cc
    • third_party/blink/renderer/platform/scheduler/common/tracing_helper.h
    • third_party/blink/renderer/platform/scheduler/common/tracing_helper_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
    • ui/gl/gl_surface_egl.cc
    • ui/latency/frame_metrics.cc
    • ui/latency/latency_info.cc
  32. [Autofill Assistant] Use touch tap instead of mouse click on Android

    Changed by gogerald - gogeraldohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 14:44:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65644ef9859380e742f3a5d91c627e3b3e942183

    Comments

    [Autofill Assistant] Use touch tap instead of mouse click on Android
    
    Bug: 806868
    Change-Id: I4848426960e868b600e238b0cbc0edd8aa1f443b
    Reviewed-on: https://chromium-review.googlesource.com/c/1331873
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607974}

    Changed files

    • components/autofill_assistant/browser/actions/action_delegate.h
    • components/autofill_assistant/browser/actions/click_action.cc
    • components/autofill_assistant/browser/actions/click_action.h
    • components/autofill_assistant/browser/actions/mock_action_delegate.h
    • components/autofill_assistant/browser/mock_web_controller.h
    • components/autofill_assistant/browser/script_executor.cc
    • components/autofill_assistant/browser/script_executor.h
    • components/autofill_assistant/browser/script_executor_unittest.cc
    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
  33. Make org.chromium.chromecast.base.Unit thread-safe.

    Changed by Jan Lamecki - jachorohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 14:24:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d4f327badd2fdd83341ade8adb32d8151725a752

    Comments

    Make org.chromium.chromecast.base.Unit thread-safe.
    
    It had race condition on unsynchronized access to static field. Fixed it
    by using clinit (static initializer). Other typical pattern for
    singletons would be "enum MyType {INSTANCE;}".
    
    Bug: None.
    Change-Id: I421e0b9f56ef1184194be2a4e083da7e06ab114c
    Reviewed-on: https://chromium-review.googlesource.com/c/1333470
    Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
    Commit-Queue: Jan Lamecki <jachor@google.com>
    Cr-Commit-Position: refs/heads/master@{#607973}

    Changed files

    • chromecast/base/java/src/org/chromium/chromecast/base/Unit.java
  34. Roll src-internal a69b0e63ca9f..db3e43bd9c5d (5 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 14:18:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 119440308781272b7fca9b737dd28b88337a2b6e

    Comments

    Roll src-internal a69b0e63ca9f..db3e43bd9c5d (5 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a69b0e63ca9f..db3e43bd9c5d
    
    
    Created with:
      gclient setdep -r src-internal@db3e43bd9c5d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I1815728c8dcb62b5ec572f123e67d0fad29c094c
    Reviewed-on: https://chromium-review.googlesource.com/c/1335769
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607972}

    Changed files

    • DEPS
  35. Roll src/third_party/webrtc 6dbf0e43a5ff..c58c8a54224d (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 14:11:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5e27e27687282bd0427c46c08c2db965c6bf0df

    Comments

    Roll src/third_party/webrtc 6dbf0e43a5ff..c58c8a54224d (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/6dbf0e43a5ff..c58c8a54224d
    
    
    git log 6dbf0e43a5ff..c58c8a54224d --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 mbonadei@webrtc.org Adding mbonadei@ to build_overrides/OWNERS.
    2018-11-13 Peter) Slatala Add visibility to ana config proto
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@c58c8a54224d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Icd852cb7a7de44ac0fe95d98f797ba76192d67c2
    Reviewed-on: https://chromium-review.googlesource.com/c/1335768
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607971}

    Changed files

    • DEPS
  36. Make ThreadableLoaderClient GarbageCollectedMixin

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 14:01:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 89797ba017745f20895099117706278ae305566d

    Comments

    Make ThreadableLoaderClient GarbageCollectedMixin
    
    ThreadableLoaderClient has not been GarbageCollected mainly for
    WorkerThreadableLoader. Now WorkerThreadableLoader is gone, so we can
    make it an on-heap class. Doing so brings several benefits:
    
     - This is a blocker of removing ThreadableLoader after OOR-CORS is
       enabled, as ResourceClient is a GarbageCollectedMixin.
     - As ThreadableLoader holds a reference to its client as a raw
       pointer, each user needs to guarantee to cancel the loader properly
       before the client gets invalid. As most of clietns are already
       on-heap, this requires pre-finalizer for each client. Also, failing
       to keep the contract leads to crashes which are very hard to
       investigate.
    
    Bug: 900506
    Change-Id: I67b3e3dab7e0600f06da5222d458ff2d81c36c7b
    Reviewed-on: https://chromium-review.googlesource.com/c/1335056
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607970}

    Changed files

    • third_party/blink/renderer/core/exported/web_associated_url_loader_impl.cc
    • third_party/blink/renderer/core/exported/web_associated_url_loader_impl.h
    • third_party/blink/renderer/core/fetch/fetch_manager.cc
    • third_party/blink/renderer/core/inspector/inspector_network_agent.cc
    • third_party/blink/renderer/core/inspector/inspector_network_agent.h
    • third_party/blink/renderer/core/loader/threadable_loader.cc
    • third_party/blink/renderer/core/loader/threadable_loader.h
    • third_party/blink/renderer/core/loader/threadable_loader_client.h
    • third_party/blink/renderer/core/loader/threadable_loader_test.cc
    • third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
    • third_party/blink/renderer/core/workers/worker_classic_script_loader.h
    • third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
    • third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h
    • third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.h
    • third_party/blink/renderer/modules/eventsource/event_source.cc
    • third_party/blink/renderer/modules/notifications/notification_image_loader.h
  37. //components/signin: Move switches/prefs into shared target

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 13:47:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 394bed001b098ae8b9b676be4b763726356f01c7

    Comments

    //components/signin: Move switches/prefs into shared target
    
    We'll see where things go long-term, but for now, these seem more
    intuitively like shared code than internal code.
    
    Bug: 901859
    Change-Id: Ie3caff7ab36afa2453baa80199fd612e4ab9dfbb
    Reviewed-on: https://chromium-review.googlesource.com/c/1331472
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607969}

    Changed files

    • components/signin/core/browser/BUILD.gn
  38. Revert deprecation of webkitURL on Window

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 13:40:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5ee8a62a4a57a6d90b0b5c3c2708dc0e8cd74a64

    Comments

    Revert deprecation of webkitURL on Window
    
    Intent thread:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EEo3kba4h2g
    
    Bug: 348985
    Change-Id: Ia35a1075aca6a2a82de22bda737cb92885453d11
    Reviewed-on: https://chromium-review.googlesource.com/c/1334987
    Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607968}

    Changed files

    • third_party/WebKit/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
    • third_party/WebKit/LayoutTests/fast/domurl/check-instanceof-domurl-functions-expected.txt
    • third_party/WebKit/LayoutTests/fast/js/global-constructors-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt
    • third_party/WebKit/LayoutTests/platform/win7/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt
    • third_party/WebKit/LayoutTests/reporting-observer/buffering.html
    • third_party/WebKit/LayoutTests/reporting-observer/resources/deprecation.js
    • third_party/WebKit/LayoutTests/reporting-observer/type-filtering.html
    • third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-platform-specific-expected.txt
    • third_party/blink/renderer/core/frame/window.idl
  39. [iOS] Fix toolbar issues with Dynamic Type

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 13:16:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1

    Comments

    [iOS] Fix toolbar issues with Dynamic Type
    
    This CL fixes few issues with Dynamic Type in the toolbar:
    - The steady view label is cut and wrongly positionned in fullscreen.
    - The location bar isn't pill shaped.
    - The incognito ntp's top icon can be cut out by the toolbar.
    
    Bug: 892145
    Change-Id: Ic9c35f593bf776cc506661da35a786ed584ae6fb
    Reviewed-on: https://chromium-review.googlesource.com/c/1333392
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607967}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
    • ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
    • ios/chrome/browser/ui/ntp/BUILD.gn
    • ios/chrome/browser/ui/ntp/incognito_view.mm
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
    • ios/chrome/browser/ui/toolbar/primary_toolbar_view.mm
    • ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm
  40. Update V8 to version 7.2.322.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 13:10:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b03731cdc9555ec526cc4eabfb0dfcddeeb02ec5

    Comments

    Update V8 to version 7.2.322.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/666bded3..e7da3e75
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I0c51fd1e5592a80e13fb15496c673ee1064b92d4
    Reviewed-on: https://chromium-review.googlesource.com/c/1335283
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607966}

    Changed files

    • DEPS
  41. Roll src/third_party/perfetto 8b58568c5cfc..4cda101d36dd (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 13:09:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e8726a9947e8d12ec20095f443eb49db7545076

    Comments

    Roll src/third_party/perfetto 8b58568c5cfc..4cda101d36dd (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/8b58568c5cfc..4cda101d36dd
    
    
    git log 8b58568c5cfc..4cda101d36dd --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 lalitm@google.com Merge "traced_probes: capture stderr from atrace"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@4cda101d36dd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I976eeac69003378a80c5f375777d0348052cfac5
    Reviewed-on: https://chromium-review.googlesource.com/c/1335767
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607965}

    Changed files

    • DEPS
  42. Revert "[Extensions] Add recent extension activities to the activity log page"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 13:04:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7662f4b0a581380e266a3f709a7f9442f6e7138a

    Comments

    Revert "[Extensions] Add recent extension activities to the activity log page"
    
    This reverts commit e393ff4753bfe97f90e9614feda10a0ca1d73f08.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 607924 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZTM5M2ZmNDc1M2JmZTk3ZjkwZTk2MTRmZWRhMTBhMGNhMWQ3M2YwOAw
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4885
    
    Sample Failed Step: browser_tests on Ubuntu-16.04
    
    Sample Flaky Test: ExtensionsActivityLogTest.TestActivityLogVisible
    
    Original change's description:
    > [Extensions] Add recent extension activities to the activity log page
    > 
    > Show recent extension activities by making a call to
    > chrome.activityLogPrivate.getExtensionActivities whenever the user
    > navigates to the activity log page. Currently, the activity type,
    > api call, event count and page url (if there is one) are shown
    > in descending order of event count.
    > 
    > Note: the activity log database can sometimes store more than one entry
    > that has the same api call/event type. This CL currently does not
    > group any duplicate activity entries.
    > 
    > Bug: 832354
    > Change-Id: I0191d77cd7961bdc5d95ec8daea98d39b1a7c638
    > Reviewed-on: https://chromium-review.googlesource.com/c/1321166
    > Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
    > Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607924}
    
    Change-Id: I0074574f067f532e3398b48254a52bb9f7a7af0f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 832354, 905278
    Reviewed-on: https://chromium-review.googlesource.com/c/1335827
    Cr-Commit-Position: refs/heads/master@{#607964}

    Changed files

    • chrome/app/md_extensions_strings.grdp
    • chrome/browser/resources/md_extensions/BUILD.gn
    • chrome/browser/resources/md_extensions/activity_log.html
    • chrome/browser/resources/md_extensions/activity_log.js
    • chrome/browser/resources/md_extensions/activity_log_item.html
    • chrome/browser/resources/md_extensions/activity_log_item.js
    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/error_page.html
    • chrome/browser/resources/md_extensions/extensions_resources.grd
    • chrome/browser/resources/md_extensions/manager.html
    • chrome/browser/resources/md_extensions/manager.js
    • chrome/browser/resources/md_extensions/service.js
    • chrome/browser/resources/md_extensions/shared_style.html
    • chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
    • chrome/browser/ui/webui/extensions/extensions_ui.cc
    • chrome/common/extensions/api/PRESUBMIT.py
    • chrome/common/extensions/api/_api_features.json
    • chrome/test/data/extensions/activity_log/simple_call/background.js
    • chrome/test/data/extensions/activity_log/simple_call/manifest.json
    • chrome/test/data/extensions/webui/sanity_check_available_apis.js
    • chrome/test/data/webui/extensions/activity_log_test.js
    • chrome/test/data/webui/extensions/cr_extensions_browsertest.js
    • chrome/test/data/webui/extensions/test_service.js
    • testing/buildbot/filters/webui_polymer2_browser_tests.filter
    • third_party/closure_compiler/externs/activity_log_private.js
  43. Roll src-internal cbbca2b41db2..a69b0e63ca9f (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 12:54:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eab6e04f58c9f5182a76e00260559f010fc15bec

    Comments

    Roll src-internal cbbca2b41db2..a69b0e63ca9f (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbbca2b41db2..a69b0e63ca9f
    
    
    Created with:
      gclient setdep -r src-internal@a69b0e63ca9f
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ic7de6c48d9f809d0278b78d9e6934c13f606a004
    Reviewed-on: https://chromium-review.googlesource.com/c/1335102
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607963}

    Changed files

    • DEPS
  44. Mark wpt/.../clients-matchall-order.https.html as Timeout

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 12:41:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 866643108a002c98736eb3cdfb505056a60947b8

    Comments

    Mark wpt/.../clients-matchall-order.https.html as Timeout
    
    It's marked as Skip but we cannot investigate the failure without
    running it.
    
    Bug: 870173
    Change-Id: I110fdf24cbe625974f9596deaedcee88a92e384e
    Reviewed-on: https://chromium-review.googlesource.com/c/1334990
    Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607962}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  45. [Background Fetch] Fix UpdateUI icon update.

    Changed by Rayan Kanso - rayankansohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 12:39:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c09063a599c30c32ad735bdf4183b947b6e70a4c

    Comments

    [Background Fetch] Fix UpdateUI icon update.
    
    The JobDetails were being deleted before the OIC could query for the updated visuals.
    The breaking change was not merged into M71.
    
    Change-Id: I8dcbaa5916001198006a3550c3bfc337436d62cf
    Reviewed-on: https://chromium-review.googlesource.com/c/1333807
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Mugdha Lakhani <nator@chromium.org>
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607961}

    Changed files

    • chrome/browser/background_fetch/background_fetch_delegate_impl.cc
  46. [signin] Remove TODOs in MutableProfileOAuth2TokenServiceDelegateTest

    Changed by David Roger - drogerohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 12:38:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f39ae5fc02a5fbce96b532393f5158b660884739

    Comments

    [signin] Remove TODOs in MutableProfileOAuth2TokenServiceDelegateTest
    
    Change-Id: I4355145d640484cf056bb3fabb038fc99d682b71
    Reviewed-on: https://chromium-review.googlesource.com/c/1335568
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607960}

    Changed files

    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
  47. Import wpt@59fba01e9f04a3acd865fa3620b389fc2f8a194b

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 12:38:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 21369b35f32e7356b9de2022366707746f4c1a86

    Comments

    Import wpt@59fba01e9f04a3acd865fa3620b389fc2f8a194b
    
    Using wpt-import in Chromium 678fc40f10bb52e86d53f9f49ce936ecf98162b0.
    With Chromium commits locally applied on WPT:
    39c398adaa "Worklet: Modernize service worker interception tests for worklets using async/await"
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    meade@chromium.org:
      external/wpt/web-animations
    
    NOAUTOREVERT=true
    TBR=kyleju
    
    No-Export: true
    Change-Id: I9443f8ef437516c1faee136eefdca0e921dd8228
    Reviewed-on: https://chromium-review.googlesource.com/c/1335284
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607959}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/rotate-parsing-valid-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/rotate-parsing-valid.html
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/property-types.js
  48. Roll src/third_party/perfetto 96026fbcbeee..8b58568c5cfc (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 11:59:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 818a335aaa175dbd58bd39877b3887412c4454ba

    Comments

    Roll src/third_party/perfetto 96026fbcbeee..8b58568c5cfc (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/96026fbcbeee..8b58568c5cfc
    
    
    git log 96026fbcbeee..8b58568c5cfc --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 hjd@google.com Merge "perfetto-ui: Bump omnibar placeholder size and darkness"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@8b58568c5cfc
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I4b63b411d616e3d828c914858ce40d7224a8651d
    Reviewed-on: https://chromium-review.googlesource.com/c/1335101
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607958}

    Changed files

    • DEPS
  49. tracing: Add basic mobile tracing preferences

    Changed by Eric Seckler - esecklerohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 11:39:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa5b7f9870a13aa948fe7de4b5f65b3f91965c93

    Comments

    tracing: Add basic mobile tracing preferences
    
    Adds a simple preferences menu under the developer options menu with a
    button to start recording a trace. The recording is controlled via a
    notification. For now, the recorded trace cannot be configured or
    shared, we will add these features in follow up patches.
    
    See bug for design doc.
    
    Bug: 898512
    Change-Id: I3a6b4dd24359f8098234ed5fbf5b6db07071a608
    Binary-Size: feature implementation, strings won't be translated.
    Reviewed-on: https://chromium-review.googlesource.com/c/1327208
    Commit-Queue: Eric Seckler <eseckler@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607957}

    Changed files

    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/res/xml/developer_preferences.xml
    • chrome/android/java/res/xml/tracing_preferences.xml
    • chrome/android/java/res_template/xml/file_paths.xml
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/developer/TracingPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/tracing/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingController.java
    • chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingNotificationManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingNotificationService.java
    • chrome/android/java/strings/android_chrome_strings.grd
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/developer/TracingPreferencesTest.java
  50. [perf] Add load:search:baidu:2018 system health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 11:36:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48c11487d072ce18bf84eb31e41402b6165de49f

    Comments

    [perf] Add load:search:baidu:2018 system health story
    
    This CL was created automatically with tools/perf/update_wpr script
    
    R=perezju@chromium.org
    
    Bug: 878390
    Change-Id: Iecbdac6cee1180b1cf1fdd08fb03e47813b0140f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329927
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607956}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_beec2d8329.wprgo.sha1
    • tools/perf/page_sets/data/system_health_mobile.json
    • tools/perf/page_sets/data/system_health_mobile_028870b3b5.wprgo.sha1
    • tools/perf/page_sets/system_health/loading_stories.py
  51. flags: add expiry & ownership metadata

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 11:30:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d0e77e1b415e9e5e1eb8dee40a414fa71cbbc019

    Comments

    flags: add expiry & ownership metadata
    
    This change:
    1) Adds c/b/flag-metadata.json, to store metadata about flags that is needed for
       other tooling but not for the browser;
    2) Adds a disabled unit test AboutFlagsTest.EveryFlagHasMetadata, which asserts
       that every flag has an entry in this file.
    3) Adds a unit test AboutFlagsTest.OnlyAllowedFlagsNeverExpire, which asserts
       that only a specified set of flags have no expiry milestone.
    
    Next steps are to make AboutFlagsTest.EveryFlagHasMetadata pass by adding
    entries for all current flags, then enable the test.
    
    Bug: 897809
    Change-Id: Icbf0055cb88106e7212bd6a1f90fcf9350fc7bf4
    Reviewed-on: https://chromium-review.googlesource.com/c/1309106
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607955}

    Changed files

    • chrome/browser/about_flags_unittest.cc
    • chrome/browser/flag-metadata.json
    • chrome/test/BUILD.gn
  52. [Autofill Assistant] The system locale and country code are now part of all messages to the server.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 11:27:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d19edb62d5f29077966a40bf30e46d42ce63dd51

    Comments

    [Autofill Assistant] The system locale and country code are now part of all messages to the server.
    
    Use-case: This would allow a server to serve locale-specific content to users. For example, the server can decide to send a locale-filtered set of scripts (currently, all scripts are returned).
    
    The locale can also explicitly be set in the script parameters (new parameter `LOCALE', see http://critique.corp.google.com/220786955).
    The country code is currently retrieved from the SIM network provider, which only works for devices with active SIM cards. This is good enough for now, but will need to be extended in the future. A more general approach will likely involve the android LocationManager and Geocoder, as well as some application logic on our side.
    
    Bug: 806868
    Change-Id: Ibacffe940117926157c35247e4e061d3d98a27d1
    Reviewed-on: https://chromium-review.googlesource.com/c/1329145
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607954}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/mock_service.cc
    • components/autofill_assistant/browser/protocol_utils.cc
    • components/autofill_assistant/browser/protocol_utils.h
    • components/autofill_assistant/browser/protocol_utils_unittest.cc
    • components/autofill_assistant/browser/service.cc
    • components/autofill_assistant/browser/service.h
    • components/autofill_assistant/browser/service.proto
  53. [ios] Add pure obj-c address for manual fallback

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 11:21:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24d8d0c2f45d8418cbee88653b404a4b5cf0fc34

    Comments

    [ios] Add pure obj-c address for manual fallback
    
    Bug: 845472
    Change-Id: Icb239377ea417d68c46d4a8bf4bc38ddf11b1b42
    Reviewed-on: https://chromium-review.googlesource.com/c/1333810
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607953}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address.h
    • ios/chrome/browser/ui/autofill/manual_fill/address.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_form.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_form.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_form_unittest.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_unittest.mm
  54. [Passwords] Extend BlacklistedSites Histograms

    Changed by jdoerrie - jdoerrieohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 11:16:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5dd3494ad745a93ec8ae5450deff1fbce926826

    Comments

    [Passwords] Extend BlacklistedSites Histograms
    
    As discussed in https://crbug.com/899948#c2 we would like to keep the
    PasswordManager.BlacklistedSites.* histograms for another couple of
    milestones. This change accomplishes this by incrementing the expiration
    date to M75.
    
    Bug: 899948
    Change-Id: I90a38d06cb36d6db3a06a0a4975d403182640d06
    Reviewed-on: https://chromium-review.googlesource.com/c/1333308
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Vaclav Brozek <vabr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607952}

    Changed files

    • tools/metrics/histograms/histograms.xml
  55. Support auto finishing composition in rulebased engine.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 10:57:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1270c4006781c335c32c41432636edf6192f88b8

    Comments

    Support auto finishing composition in rulebased engine.
    
    Bug: 859432
    Change-Id: I320f388acd90ed40d7343d9954ab067cadde15b6
    Reviewed-on: https://chromium-review.googlesource.com/c/1335051
    Reviewed-by: Leo Zhang <googleo@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607951}

    Changed files

    • chromeos/services/ime/public/cpp/rulebased/engine.cc
    • chromeos/services/ime/public/cpp/rulebased/rulebased_unittest.cc
    • chromeos/services/ime/public/cpp/rulebased/rules_data.cc
    • chromeos/services/ime/public/cpp/rulebased/rules_data.h
  56. [iOS][MF] Add histograms for autofill data types

    Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 10:56:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c78653112cf1a244def81606c45f036c8bcfde10

    Comments

    [iOS][MF] Add histograms for autofill data types
    
    Bug: 845472
    Change-Id: I57c17eaa6add94d6defe8fea4e24c70bcb20af0b
    Reviewed-on: https://chromium-review.googlesource.com/c/1329165
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607950}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.mm
    • tools/metrics/histograms/histograms.xml
  57. Roll src-internal 87927acfcf75..cbbca2b41db2 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 10:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e437d403634ed0678c8b75bce3fca01a8fb1b1cb

    Comments

    Roll src-internal 87927acfcf75..cbbca2b41db2 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87927acfcf75..cbbca2b41db2
    
    
    Created with:
      gclient setdep -r src-internal@cbbca2b41db2
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia95c5529310d51beffe037e8fce42f118947f9f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1335100
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607949}

    Changed files

    • DEPS
  58. Disable NetworkServiceRestartBrowserTests on Android ASan.

    Changed by Arthur Sonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 10:50:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dff9cb43846a3f9a82da47cbe0cf23e7d650cf5

    Comments

    Disable NetworkServiceRestartBrowserTests on Android ASan.
    
    Disabled tests:
    NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch
    NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough
    NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler
    
    TBR=shimazu@chromium.org
    
    Bug: 889855
    Change-Id: Ibbeb9faaf6d5d1657d893bf4d4c825045b1f0cbf
    Reviewed-on: https://chromium-review.googlesource.com/c/1335587
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607948}

    Changed files

    • content/browser/network_service_restart_browsertest.cc
  59. Clamp double to int instead of using static_cast.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 10:43:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 643f4512490bc82c35684c4adf99a5b959eb3405

    Comments

    Clamp double to int instead of using static_cast.
    
    Better overflow handling for CSSPrimitiveValue::Create.
    
    Bug: 904872
    Change-Id: Ieafc28406497b4a676994efdc6515959549a7ba1
    Reviewed-on: https://chromium-review.googlesource.com/c/1335527
    Reviewed-by: Anders Ruud <andruud@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607947}

    Changed files

    • third_party/blink/renderer/core/css/css_primitive_value.cc
  60. [Autofill Assistant] Changed autofill assistant payment request section order to: contact details -> shipping -> payment.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 10:38:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10ca0d3299bb3fe8634f29167a86f405ce6ed465

    Comments

    [Autofill Assistant] Changed autofill assistant payment request section order to: contact details -> shipping -> payment.
    
    Also removed the first section separator according to our mocks. The chrome feature WEB_PAYMENTS_METHOD_SECTION_ORDER_V2 is now disabled for autofill assistant payment PR.
    
    Bug: 806868
    Change-Id: I52ed027192b145e50fb22c65fd50cfb5272d0fd2
    Reviewed-on: https://chromium-review.googlesource.com/c/1333776
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607946}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java