Home | Search | chromium - Builders
Login

Builder Windows deterministic Build 10703 Microsoft Windows

Results:

Internal Failure

Trigger Info:

Projectchromium
Revisiondda5fa8bc55b051debe85947931c8b31e3d70f63

Execution:

Steps and Logfiles:

Show:
  1. ( 522 ms ) setup_build
    running recipe: "swarming/deterministic_build"
  2. ( 14 mins 37 secs ) bot_update
    [43GB/299GB used (14%)]
  3. ( 383 ms ) clobber
  4. ( 11 mins 2 secs ) gclient runhooks
  5. ( 468 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  6. ( 2 mins 30 secs ) generate_build_files
  7. ( 19 mins 19 secs ) First build
  8. ( 2 mins 37 secs ) First build confirm no-op
  9. ( 20 mins 10 secs ) isolate tests
  10. ( 497 ms ) clobber (2)
  11. ( 52 secs ) gclient runhooks (2)
  12. ( 545 ms ) lookup GN args (2)
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  13. ( 3 mins 43 secs ) generate_build_files (2)
  14. ( 16 mins 51 secs ) Second build
  15. ( 2 mins 6 secs ) Second build confirm no-op
  16. ( 16 mins 7 secs ) isolate tests (2)
  17. ( 33 mins 58 secs ) compare_build_artifacts
  18. ( 1 mins 38 secs ) create tarball
  19. ( 16 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2173-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542108769846866, "id": "8929975470507903472", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/dda5fa8bc55b051debe85947931c8b31e3d70f63", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/dda5fa8bc55b051debe85947931c8b31e3d70f63", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095405532614616208", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Windows deterministic" setup_build
buildnumber 10703 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "swarming/deterministic_build" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "dda5fa8bc55b051debe85947931c8b31e3d70f63" setup_build
got_angle_revision "cd47a379f9606a2ff47c047acabaeea73eeeaaef" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "597e1587b4bfc7bf89895c7c879ae58b649da3c5" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "dda5fa8bc55b051debe85947931c8b31e3d70f63" bot_update
got_revision_cp "refs/heads/master@{#607561}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "9e77655ddd93113bccb3d9868cc07c33891c9152" bot_update
got_v8_revision_cp "refs/heads/7.2.310@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {"accessibility_unittests": "9af518e749104a740f9249dd5a3197d35ff1f879", "angle_end2end_tests": "f1fc8b3e901be3f16a3f80d166da3b99c5c82c77", "angle_perftests": "2b3843f8adfb2085bb03a6cd086be9034f77c864", "angle_unittests": "8c146c846f85f86d0e69ac5a04f954484495f1bb", "angle_white_box_tests": "633b494fed43adf7b8230faa50ef485b2a2870cb", "app_shell_unittests": "0332c82dd39c6eba231c170c6f49e107bbc62a11", "aura_unittests": "f7dd9ceab3478d89a3dd7847b39715249d6804d3", "base_perftests": "2a69246658a8cd51ced2b6b0adb2f729818f594a", "base_unittests": "acc87ccf59f7e4f0e46daec79b3a3e95a51eb5a7", "blink_common_unittests": "f71c3137b4a271bfb84815123877a4ca52c57f47", "blink_fuzzer_unittests": "982a7705c6dae7b0429212b0500becb54aa35137", "blink_heap_unittests": "8afaa754223822ab156e713293146ac6589dae5d", "blink_platform_unittests": "5fd42574ea595b84eba16a3a973ffc07da0cdd76", "boringssl_crypto_tests": "12da91fc6bb7891909f3ececb61049ac7ce36e1b", "boringssl_ssl_tests": "bb6552f957f82cb6d047d0597317ec78d0e2548d", "browser_tests": "a2b24655716aaa599df9cd1530ff513028f97170", "cacheinvalidation_unittests": "0305969761ac0be2bfb810a900364af15703f755", "capture_unittests": "82d3d1dc1c2f36d80ab6b66db08c54f439d18099", "cast_unittests": "dc08e06177410d0a28d66ff6468e6a83d19f617f", "cc_unittests": "b45938361668076f287aaf8febd2fb0f3f4d8bf5", "chrome_app_unittests": "54c2b72401d6e2fb67909be7b217ce202864c403", "chrome_cleaner_unittests": "b67ff0dae025ef2dba56bbaa8a919dd234e2840d", "chrome_elf_import_unittests": "4dc44cf89197635bcc59bd85d976e72649c252a1", "chrome_elf_unittests": "0a5442ef7338be807c3c557414d5d3322a779f10", "chromedriver_py_tests": "8b0f62eaf33bd2bade5a4759b235094f3519392f", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "05487ae14171da320389cb51a344dda6a77254cc", "command_buffer_perftests": "aa5659b9ace378d00012a0727fab53301c5e7749", "components_browsertests": "c76e523aabb342c79ff06f099714e62214b6be7f", "components_perftests": "941a8cbeaa8fdd89c198a2514b4699bf63d837c9", "components_unittests": "701890c3268e2d153bc6ecd0408557ac5f2cbf02", "compositor_unittests": "bf0a86f1767b54c4b0a05c721c1e722d56f0da3c", "content_browsertests": "67634a49e2f46333c0d752cd5f4513e55930a1f4", "content_shell_crash_test": "cc7150cb13fba7fd24ed2ae1feba30ea5114a510", "content_unittests": "995b1e27fb502333f60fbf9fcb932a798c6d5a91", "courgette_unittests": "5efb723ba54493c047b16f2527e9f2a3e741347c", "crashpad_tests": "4f900392e1b019052f426dd24e91e8272d338ba6", "cronet_tests": "bd84f9c0b203cd4921f9eeddc4125d89f3526aa7", "cronet_unittests": "01246db7d9099ea9724c8035af4692931f4e0297", "crypto_unittests": "0c0f17f9d18c3f57bd788e21392dc6a75e8ee5cd", "dawn_end2end_tests": "3aed5aa4d67f4f6b02a207fb5cc936d6ad7f888f", "device_unittests": "749d22e0734c837a0c6cf5b75ea5706db3b55f2a", "devtools_closure_compile": "ed9d7a684c308aec41c8c31da06eb0cc552aa754", "display_unittests": "2a3521e727b1143f4d3070430510cf399fa520ec", "elevation_service_unittests": "90e9a33d5ecd22adef81c429ec6e825a5e0fe3d6", "events_unittests": "fd9c016e70a1c7f728ec75a9ba8d22c20f5976a9", "extensions_browsertests": "250d93b33db978aa1113a11fc98fcd53c54fbb3a", "extensions_unittests": "79b6bd8bcb7cc6ef144b9af9da18303d8e4719bb", "filesystem_service_unittests": "23b7231e48d84d40cdc36c088b47d129149192aa", "gcm_unit_tests": "0e2430293c38097e00f369667ba39bea51b5e42d", "gcp_unittests": "09ad332d73afa73c8fb4794ed2cd7b818a3ffffa", "gfx_unittests": "6d8609f7af20e95db2fc15d490887ea90c9ebda9", "gin_unittests": "0b0b06c50d4e1108405cb8c80cade3ffd1b0ad8f", "gl_tests": "df373529d1064c1ccaef3a92a5a36cee68083cfd", "gl_unittests": "41481a366fde221214afcead351bdc837bcba944", "gl_unittests_ozone": "41481a366fde221214afcead351bdc837bcba944", "gles2_conform_test": "55b442fc9fd92fa696c3ffa537384f7f9039d740", "google_apis_unittests": "d986dcb561eeed2c43c0fc0b32e61a9437372945", "gpu_perftests": "3e40983d9019cda287baef52d939a30073256df2", "gpu_unittests": "2ddc812154ae9b1c75079e34bd576f59ef14f9b7", "headless_browsertests": "0f96d2819e6e9eb4cb79bf8ce8ed77feab4ebf9b", "headless_unittests": "982bf7faa2c9d21cae70193c988f5ad4f26f9c93", "install_static_unittests": "54e5dcbb1982ca8f5cc678d3e8d54bb8188f38e5", "installer_util_unittests": "2f6d86e0621dc4931d3d66aa0b72979bd4d97a4b", "interactive_ui_tests": "dae39066479aad29231a07265a4ae3576737fe46", "ipc_tests": "f14de3f035a325ee8fe0e8fded684afba9285bb3", "jingle_unittests": "94b27e0fc12f549efad438ca5f2c54f0a838e02b", "latency_unittests": "c746637f32fefa3055ebf5e687c7560e782f617f", "leveldb_service_unittests": "92ea7011c934cdbfb801360689c2981761400703", "libjingle_xmpp_unittests": "65b3d4ed5e9e8520e4895c937f42e4d56d52e56d", "load_library_perf_tests": "c5da838615500afab3f990bed1780f9e08639a1c", "media_blink_unittests": "e51a4d4c041f1ed33b4b65f49e18394979a16a88", "media_perftests": "a71af3f417c55bf9681ed90d4c58d21671262b7f", "media_service_unittests": "f70b22c3dbaeb613b439f9ce639e898d989f46ff", "media_unittests": "139b5178fd39ee2859f501a037748a1ee3294f8b", "message_center_unittests": "b069dc27661c75717a827939533d72408b1f937a", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "9668dc81030c016b1beb4cd94127460d4fa7c9f7", "mini_installer_tests": "ca652cca3bbc77b2950e6fbb6720fc7ccc0a7b34", "mojo_core_unittests": "77ae4ffa4adb7d496bd8a1fc68d07493cc624721", "mojo_unittests": "d2a46d01fa58339ab8ecacc418addf408bea47b9", "nacl_loader_unittests": "c86fb0ca5f37dd56620252ab040167e756a41226", "native_theme_unittests": "7935072ec5e8d0eee7b8e63cb57b3af1f39447af", "net_perftests": "28c1cf6c835231f1ff62711f8d7537ae51a0cd7c", "net_unittests": "f47c9ad92698bc5ffe5b95274581fa0753fac536", "notification_helper_unittests": "a7c0eccad6c3329741f666dada26e3e453816b49", "pdf_unittests": "ea3c048efa9c7b08347ae131161fdb870a68ea3b", "performance_browser_tests": "ec28493306f9d2cd593a96095595ec4a25f2d6a3", "performance_test_suite": "0371df34a566db919fc9c24950336ee249899184", "performance_webview_test_suite": "50a9e35acd8ea5f83ab0b27f937f49bf973b4b67", "ppapi_unittests": "023e308678ae5d2d5098ebb0c43c07248d8af75f", "printing_unittests": "416a5dbf8a30895097b2ce1a47d94ac48607e70b", "remoting_unittests": "841fb60e80d66e5496687c38f66ff226f88b4363", "sbox_integration_tests": "97ce85cb2d9724a4922c4ef1fd1d4967fd4685b5", "sbox_unittests": "fa2039cbdeda3ce8ee966d8cb51beaa15aba5f3c", "sbox_validation_tests": "3d8c4469e812a61b0b60adc22d084b1d931702c2", "service_manager_unittests": "25bc88d6e17f6bf207428b0d0a42249590af8282", "services_unittests": "30879146eaadad8ace991d44cdf16c9504d74da9", "setup_unittests": "76f4cb623cc11242b88ebe66dd2e6256155c647f", "shell_dialogs_unittests": "4f4ab1e1973a12c248f6db925f6e1f2d5b680084", "skia_unittests": "c9d441bed9c7cb17e6b6436a28ee1a5198749344", "snapshot_unittests": "317045fc38fe188ab24bc366a2c4ebcd58daeb76", "sql_unittests": "e554b12f0d446dacea39663c81b55da49b77e70a", "storage_unittests": "3494fd04acb2adc7dd0a9f4472eabedb2f675763", "swiftshader_unittests": "2746f52895ecb6c0f286cd1bc3c311a30e9e7179", "sync_integration_tests": "8a6e37b4d0c518ef0719bfb84eb1b0f38fbf0699", "telemetry_gpu_integration_test": "a1687579b7356d6bf629f9db712084f1095ce512", "telemetry_gpu_unittests": "5f32d3ca6d49dd3f81d4c3ae618ccb029b403cfc", "telemetry_perf_tests_without_chrome": "3adbd43aa543ec8372d3304a687dff99eae35d36", "telemetry_perf_unittests": "4c1d48563d1d5c134feb49269e19e4a037c0900e", "telemetry_unittests": "a119d1bf52655b20d1bee847bf5a9ab3f4d18503", "tracing_perftests": "743324cc791b10040979fe56d1fcd38f9aa725b6", "traffic_annotation_auditor_unittests": "d492b9c1ed87dad6cfd18d7ccef2132e429ed1bd", "ui_base_unittests": "b0a984e19500a86c7b59569f40e5626e292e2390", "ui_touch_selection_unittests": "06e60bc96c6544658b991d805c1bc8d642024738", "unit_tests": "c1dbea4407920f35ce44aefe4ae75c5155578c14", "url_unittests": "a7b0050d001f4511ca7b4745fd6d1ab6a27afbe4", "video_decode_accelerator_unittest": "03f9ad7cd7be247ff65bd8eebdc20c7e156a0c30", "views_mus_interactive_ui_tests": "6e31f26d8df3356f06e2fdbe42c35c86407e7a5e", "views_mus_unittests": "20fb9715bdfcf9eea187d84253a2a5b2e39ddfc4", "views_perftests": "8a6e7da7f970c8632e94df69e7c3bcab878e2837", "views_unittests": "6dd7925fabe58020faf0fdb689abc46a5182f331", "viz_unittests": "c0ecfeb7d0c7ccbea6ec2970cd80b80b4cd23f13", "vr_common_perftests": "0ca7ca05a0a262b0f3d54d323e090d66dd6eb3da", "vr_common_unittests": "21c3096d590fa281ce13364099764431f0fe2c35", "vr_pixeltests": "8091d85bc9c3afbf15c9743de0fe34445834e93f", "webkit_layout_tests": "9e82a5883f6d4031fceba50d51124b484c469217", "webkit_layout_tests_exparchive": "cf8f005a2dc23e0ed1df991369e68335c4bf05c6", "webkit_python_tests": "1fda54f5da55e529ce222e33353f46234925360c", "webkit_unit_tests": "f24b3d2ab6081a42856277cf85e19aece64ec4a8", "wm_unittests": "a6f547afd203a034ce613729ba8a83a521ab9181", "wtf_unittests": "fd88fc03bb9dba4118f483229f7b0728162e69fb", "zucchini_unittests": "994cd75a6da5cae48ab1df43f1faec48ca483a30"} isolate tests
swarm_hashes {"accessibility_unittests": "9af518e749104a740f9249dd5a3197d35ff1f879", "angle_end2end_tests": "f1fc8b3e901be3f16a3f80d166da3b99c5c82c77", "angle_perftests": "2b3843f8adfb2085bb03a6cd086be9034f77c864", "angle_unittests": "8c146c846f85f86d0e69ac5a04f954484495f1bb", "angle_white_box_tests": "633b494fed43adf7b8230faa50ef485b2a2870cb", "app_shell_unittests": "0332c82dd39c6eba231c170c6f49e107bbc62a11", "aura_unittests": "f7dd9ceab3478d89a3dd7847b39715249d6804d3", "base_perftests": "2a69246658a8cd51ced2b6b0adb2f729818f594a", "base_unittests": "acc87ccf59f7e4f0e46daec79b3a3e95a51eb5a7", "blink_common_unittests": "f71c3137b4a271bfb84815123877a4ca52c57f47", "blink_fuzzer_unittests": "982a7705c6dae7b0429212b0500becb54aa35137", "blink_heap_unittests": "8afaa754223822ab156e713293146ac6589dae5d", "blink_platform_unittests": "5fd42574ea595b84eba16a3a973ffc07da0cdd76", "boringssl_crypto_tests": "12da91fc6bb7891909f3ececb61049ac7ce36e1b", "boringssl_ssl_tests": "bb6552f957f82cb6d047d0597317ec78d0e2548d", "browser_tests": "a2b24655716aaa599df9cd1530ff513028f97170", "cacheinvalidation_unittests": "0305969761ac0be2bfb810a900364af15703f755", "capture_unittests": "82d3d1dc1c2f36d80ab6b66db08c54f439d18099", "cast_unittests": "dc08e06177410d0a28d66ff6468e6a83d19f617f", "cc_unittests": "b45938361668076f287aaf8febd2fb0f3f4d8bf5", "chrome_app_unittests": "54c2b72401d6e2fb67909be7b217ce202864c403", "chrome_cleaner_unittests": "b67ff0dae025ef2dba56bbaa8a919dd234e2840d", "chrome_elf_import_unittests": "4dc44cf89197635bcc59bd85d976e72649c252a1", "chrome_elf_unittests": "0a5442ef7338be807c3c557414d5d3322a779f10", "chromedriver_py_tests": "8b0f62eaf33bd2bade5a4759b235094f3519392f", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "05487ae14171da320389cb51a344dda6a77254cc", "command_buffer_perftests": "aa5659b9ace378d00012a0727fab53301c5e7749", "components_browsertests": "c76e523aabb342c79ff06f099714e62214b6be7f", "components_perftests": "941a8cbeaa8fdd89c198a2514b4699bf63d837c9", "components_unittests": "701890c3268e2d153bc6ecd0408557ac5f2cbf02", "compositor_unittests": "bf0a86f1767b54c4b0a05c721c1e722d56f0da3c", "content_browsertests": "67634a49e2f46333c0d752cd5f4513e55930a1f4", "content_shell_crash_test": "cc7150cb13fba7fd24ed2ae1feba30ea5114a510", "content_unittests": "995b1e27fb502333f60fbf9fcb932a798c6d5a91", "courgette_unittests": "5efb723ba54493c047b16f2527e9f2a3e741347c", "crashpad_tests": "4f900392e1b019052f426dd24e91e8272d338ba6", "cronet_tests": "bd84f9c0b203cd4921f9eeddc4125d89f3526aa7", "cronet_unittests": "01246db7d9099ea9724c8035af4692931f4e0297", "crypto_unittests": "0c0f17f9d18c3f57bd788e21392dc6a75e8ee5cd", "dawn_end2end_tests": "3aed5aa4d67f4f6b02a207fb5cc936d6ad7f888f", "device_unittests": "749d22e0734c837a0c6cf5b75ea5706db3b55f2a", "devtools_closure_compile": "ed9d7a684c308aec41c8c31da06eb0cc552aa754", "display_unittests": "2a3521e727b1143f4d3070430510cf399fa520ec", "elevation_service_unittests": "90e9a33d5ecd22adef81c429ec6e825a5e0fe3d6", "events_unittests": "fd9c016e70a1c7f728ec75a9ba8d22c20f5976a9", "extensions_browsertests": "250d93b33db978aa1113a11fc98fcd53c54fbb3a", "extensions_unittests": "79b6bd8bcb7cc6ef144b9af9da18303d8e4719bb", "filesystem_service_unittests": "23b7231e48d84d40cdc36c088b47d129149192aa", "gcm_unit_tests": "0e2430293c38097e00f369667ba39bea51b5e42d", "gcp_unittests": "09ad332d73afa73c8fb4794ed2cd7b818a3ffffa", "gfx_unittests": "6d8609f7af20e95db2fc15d490887ea90c9ebda9", "gin_unittests": "0b0b06c50d4e1108405cb8c80cade3ffd1b0ad8f", "gl_tests": "df373529d1064c1ccaef3a92a5a36cee68083cfd", "gl_unittests": "41481a366fde221214afcead351bdc837bcba944", "gl_unittests_ozone": "41481a366fde221214afcead351bdc837bcba944", "gles2_conform_test": "55b442fc9fd92fa696c3ffa537384f7f9039d740", "google_apis_unittests": "d986dcb561eeed2c43c0fc0b32e61a9437372945", "gpu_perftests": "3e40983d9019cda287baef52d939a30073256df2", "gpu_unittests": "2ddc812154ae9b1c75079e34bd576f59ef14f9b7", "headless_browsertests": "0f96d2819e6e9eb4cb79bf8ce8ed77feab4ebf9b", "headless_unittests": "982bf7faa2c9d21cae70193c988f5ad4f26f9c93", "install_static_unittests": "54e5dcbb1982ca8f5cc678d3e8d54bb8188f38e5", "installer_util_unittests": "2f6d86e0621dc4931d3d66aa0b72979bd4d97a4b", "interactive_ui_tests": "dae39066479aad29231a07265a4ae3576737fe46", "ipc_tests": "f14de3f035a325ee8fe0e8fded684afba9285bb3", "jingle_unittests": "94b27e0fc12f549efad438ca5f2c54f0a838e02b", "latency_unittests": "c746637f32fefa3055ebf5e687c7560e782f617f", "leveldb_service_unittests": "92ea7011c934cdbfb801360689c2981761400703", "libjingle_xmpp_unittests": "65b3d4ed5e9e8520e4895c937f42e4d56d52e56d", "load_library_perf_tests": "c5da838615500afab3f990bed1780f9e08639a1c", "media_blink_unittests": "e51a4d4c041f1ed33b4b65f49e18394979a16a88", "media_perftests": "a71af3f417c55bf9681ed90d4c58d21671262b7f", "media_service_unittests": "f70b22c3dbaeb613b439f9ce639e898d989f46ff", "media_unittests": "139b5178fd39ee2859f501a037748a1ee3294f8b", "message_center_unittests": "b069dc27661c75717a827939533d72408b1f937a", "metrics_python_tests": "c16ec0dcde7e4d9f2dde0d7c528c94206d571f67", "midi_unittests": "9668dc81030c016b1beb4cd94127460d4fa7c9f7", "mini_installer_tests": "f35577075b03694da406714e4f5ad8afc71fc595", "mojo_core_unittests": "77ae4ffa4adb7d496bd8a1fc68d07493cc624721", "mojo_unittests": "d2a46d01fa58339ab8ecacc418addf408bea47b9", "nacl_loader_unittests": "c86fb0ca5f37dd56620252ab040167e756a41226", "native_theme_unittests": "7935072ec5e8d0eee7b8e63cb57b3af1f39447af", "net_perftests": "28c1cf6c835231f1ff62711f8d7537ae51a0cd7c", "net_unittests": "f47c9ad92698bc5ffe5b95274581fa0753fac536", "notification_helper_unittests": "a7c0eccad6c3329741f666dada26e3e453816b49", "pdf_unittests": "ea3c048efa9c7b08347ae131161fdb870a68ea3b", "performance_browser_tests": "ec28493306f9d2cd593a96095595ec4a25f2d6a3", "performance_test_suite": "0371df34a566db919fc9c24950336ee249899184", "performance_webview_test_suite": "50a9e35acd8ea5f83ab0b27f937f49bf973b4b67", "ppapi_unittests": "023e308678ae5d2d5098ebb0c43c07248d8af75f", "printing_unittests": "416a5dbf8a30895097b2ce1a47d94ac48607e70b", "remoting_unittests": "841fb60e80d66e5496687c38f66ff226f88b4363", "sbox_integration_tests": "97ce85cb2d9724a4922c4ef1fd1d4967fd4685b5", "sbox_unittests": "fa2039cbdeda3ce8ee966d8cb51beaa15aba5f3c", "sbox_validation_tests": "3d8c4469e812a61b0b60adc22d084b1d931702c2", "service_manager_unittests": "25bc88d6e17f6bf207428b0d0a42249590af8282", "services_unittests": "30879146eaadad8ace991d44cdf16c9504d74da9", "setup_unittests": "76f4cb623cc11242b88ebe66dd2e6256155c647f", "shell_dialogs_unittests": "4f4ab1e1973a12c248f6db925f6e1f2d5b680084", "skia_unittests": "c9d441bed9c7cb17e6b6436a28ee1a5198749344", "snapshot_unittests": "317045fc38fe188ab24bc366a2c4ebcd58daeb76", "sql_unittests": "e554b12f0d446dacea39663c81b55da49b77e70a", "storage_unittests": "3494fd04acb2adc7dd0a9f4472eabedb2f675763", "swiftshader_unittests": "2746f52895ecb6c0f286cd1bc3c311a30e9e7179", "sync_integration_tests": "8a6e37b4d0c518ef0719bfb84eb1b0f38fbf0699", "telemetry_gpu_integration_test": "a1687579b7356d6bf629f9db712084f1095ce512", "telemetry_gpu_unittests": "5f32d3ca6d49dd3f81d4c3ae618ccb029b403cfc", "telemetry_perf_tests_without_chrome": "3adbd43aa543ec8372d3304a687dff99eae35d36", "telemetry_perf_unittests": "4c1d48563d1d5c134feb49269e19e4a037c0900e", "telemetry_unittests": "a119d1bf52655b20d1bee847bf5a9ab3f4d18503", "tracing_perftests": "743324cc791b10040979fe56d1fcd38f9aa725b6", "traffic_annotation_auditor_unittests": "d492b9c1ed87dad6cfd18d7ccef2132e429ed1bd", "ui_base_unittests": "b0a984e19500a86c7b59569f40e5626e292e2390", "ui_touch_selection_unittests": "06e60bc96c6544658b991d805c1bc8d642024738", "unit_tests": "c1dbea4407920f35ce44aefe4ae75c5155578c14", "url_unittests": "a7b0050d001f4511ca7b4745fd6d1ab6a27afbe4", "video_decode_accelerator_unittest": "03f9ad7cd7be247ff65bd8eebdc20c7e156a0c30", "views_mus_interactive_ui_tests": "6e31f26d8df3356f06e2fdbe42c35c86407e7a5e", "views_mus_unittests": "20fb9715bdfcf9eea187d84253a2a5b2e39ddfc4", "views_perftests": "8a6e7da7f970c8632e94df69e7c3bcab878e2837", "views_unittests": "6dd7925fabe58020faf0fdb689abc46a5182f331", "viz_unittests": "c0ecfeb7d0c7ccbea6ec2970cd80b80b4cd23f13", "vr_common_perftests": "0ca7ca05a0a262b0f3d54d323e090d66dd6eb3da", "vr_common_unittests": "21c3096d590fa281ce13364099764431f0fe2c35", "vr_pixeltests": "8091d85bc9c3afbf15c9743de0fe34445834e93f", "webkit_layout_tests": "9e82a5883f6d4031fceba50d51124b484c469217", "webkit_layout_tests_exparchive": "cf8f005a2dc23e0ed1df991369e68335c4bf05c6", "webkit_python_tests": "1fda54f5da55e529ce222e33353f46234925360c", "webkit_unit_tests": "f24b3d2ab6081a42856277cf85e19aece64ec4a8", "wm_unittests": "a6f547afd203a034ce613729ba8a83a521ab9181", "wtf_unittests": "fd88fc03bb9dba4118f483229f7b0728162e69fb", "zucchini_unittests": "994cd75a6da5cae48ab1df43f1faec48ca483a30"} isolate tests (2)

Blamelist:

  1. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  2. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. Takashi Toyoshima (toyoshimohnoyoudont@chromium.org)
  5. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  6. Sergio Villar Senin (svillarohnoyoudont@igalia.com)
  7. Moja Hsu (mojahsuohnoyoudont@google.com)
  8. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  9. Ioana Pandele (ioanapohnoyoudont@chromium.org)
  10. Amos Lim (eui-sang.limohnoyoudont@samsung.com)
  11. David Jean (djeanohnoyoudont@google.com)
  12. Javier Fernandez (jfernandezohnoyoudont@igalia.com)
  13. Lukasz Suder (lsuderohnoyoudont@google.com)
  14. Mark Cogan (marqohnoyoudont@google.com)
  15. Richard Li (richard.liohnoyoudont@intel.com)
  16. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  17. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  18. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  19. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  20. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  21. David Roger (drogerohnoyoudont@chromium.org)
  22. Marc Treib (treibohnoyoudont@chromium.org)
  23. David Jean (djeanohnoyoudont@google.com)
  24. Marc Treib (treibohnoyoudont@chromium.org)
  25. Mugdha Lakhani (natorohnoyoudont@chromium.org)
  26. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  27. Roman Aleksandrov (raleksandrovohnoyoudont@google.com)
  28. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  29. Marc Treib (treibohnoyoudont@chromium.org)
  30. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  31. Shao-Chuan Lee (shaochuanohnoyoudont@chromium.org)
  32. Mike West (mkwstohnoyoudont@chromium.org)
  33. Andreas Haas (ahaasohnoyoudont@chromium.org)
  34. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  35. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  36. Andreas Haas (ahaasohnoyoudont@chromium.org)
  37. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  38. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  39. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  40. Yi Su (mrsuyiohnoyoudont@chromium.org)
  41. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  42. Gang Wu (gangwuohnoyoudont@chromium.org)
  43. Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
  44. Benoît Lizé (lizebohnoyoudont@chromium.org)
  45. Koji Ishii (kojiiohnoyoudont@chromium.org)
  46. Christopher Lam (calamityohnoyoudont@chromium.org)
  47. Vladislav Kaznacheev (kaznacheevohnoyoudont@google.com)
  48. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  49. Takashi Toyoshima (toyoshimohnoyoudont@chromium.org)
  50. Christopher Lam (calamityohnoyoudont@chromium.org)
  51. Koji Ishii (kojiiohnoyoudont@chromium.org)
  52. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  53. Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
  54. Jia (jiamengohnoyoudont@chromium.org)
  55. Alexey Baskakov (loysoohnoyoudont@chromium.org)
  56. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  57. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  58. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  59. Zhuoyu Qian (zhuoyu.qianohnoyoudont@samsung.com)
  60. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  61. Sam McNally (sammcohnoyoudont@chromium.org)

Timing:

Create Tuesday, 13-Nov-18 11:32:49 UTC
Start Tuesday, 13-Nov-18 12:12:23 UTC
End Tuesday, 13-Nov-18 15:13:55 UTC
Pending 39 mins 33 secs
Execution 3 hrs 1 mins

All Changes:

  1. Update V8 to version 7.2.310.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 11:27:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dda5fa8bc55b051debe85947931c8b31e3d70f63

    Comments

    Update V8 to version 7.2.310.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/4fe505da..9e77655d
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I93ffe315a45fb7edd76d8eb4901d1a57d0cd01e8
    Reviewed-on: https://chromium-review.googlesource.com/c/1333249
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607561}

    Changed files

    • DEPS
  2. Roll src-internal 21a6d3755355..4b7f221ffce4 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 11:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec2cb014d56cc1a6927c2c835797068629dd6bb9

    Comments

    Roll src-internal 21a6d3755355..4b7f221ffce4 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21a6d3755355..4b7f221ffce4
    
    
    Created with:
      gclient setdep -r src-internal@4b7f221ffce4
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia29112da86d70f675b4b4da8ad13d52dad2bb28d
    Reviewed-on: https://chromium-review.googlesource.com/c/1332834
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607560}

    Changed files

    • DEPS
  3. Roll src/third_party/perfetto 22d2394b3274..12378af8eb5f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 11:14:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f5ff73639736752389988e3541bdc0f97d07084

    Comments

    Roll src/third_party/perfetto 22d2394b3274..12378af8eb5f (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/22d2394b3274..12378af8eb5f
    
    
    git log 22d2394b3274..12378af8eb5f --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 primiano@google.com Merge "Allow move ctor for Patch."
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@12378af8eb5f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I959d0e47be5e689175cc20a489f3e934a6c81fcf
    Reviewed-on: https://chromium-review.googlesource.com/c/1332833
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607559}

    Changed files

    • DEPS
  4. OOR-CORS: Remove unused function from platform/loader/cors/cors.{cc|h}

    Changed by Takashi Toyoshima - toyoshimohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 11:10:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2cd648db6f75ae51cc8f5e2920348bfa618c8dec

    Comments

    OOR-CORS: Remove unused function from platform/loader/cors/cors.{cc|h}
    
    IsCORSSafelistedHeader in platform/loader/cors/ is not used any more.
    
    Bug: None
    Change-Id: Iec373260b869d1af64f8a025a1e244be8a446c44
    Reviewed-on: https://chromium-review.googlesource.com/c/1332973
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607558}

    Changed files

    • third_party/blink/renderer/platform/loader/cors/cors.cc
    • third_party/blink/renderer/platform/loader/cors/cors.h
  5. [perf] Add load:news:wikipedia:2018 system health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 11:06:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c255cff84e1698223e4d574e624dc5b983f3937f

    Comments

    [perf] Add load:news:wikipedia:2018 system health story
    
    This CL was created automatically with tools/perf/update_wpr script
    
    R=perezju@chromium.org
    
    Bug: 878390
    Change-Id: Ieeeb3b33918eca669e109f0938b0ee0daca90a13
    Reviewed-on: https://chromium-review.googlesource.com/c/1329745
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607557}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_2c06c24ac6.wprgo.sha1
    • tools/perf/page_sets/data/system_health_mobile.json
    • tools/perf/page_sets/data/system_health_mobile_69876ae4b7.wprgo.sha1
    • tools/perf/page_sets/system_health/loading_stories.py
  6. Migrate RendererUpdater to IdentityManager

    Changed by Sergio Villar Senin - svillarohnoyoudont@igalia.com
    Changed at Tuesday, 13-Nov-18 10:59:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1bdcf632f3345eae5f589a5280fb85b4d4f210b1

    Comments

    Migrate RendererUpdater to IdentityManager
    
    It's currently observer SigninManager but it could instead observe
    IdentityManager. This will allow RenderUpdater to eventually use the
    identity service.
    
    Bug: 887453
    Change-Id: I588bcdaa1e0c5fe02207ad4fabff552193c49766
    Reviewed-on: https://chromium-review.googlesource.com/c/1268339
    Commit-Queue: Sergio Villar <svillar@igalia.com>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607556}

    Changed files

    • chrome/browser/profiles/renderer_updater.cc
    • chrome/browser/profiles/renderer_updater.h
  7. Add V4L2 JPEG Encoder support.

    Changed by Moja Hsu - mojahsuohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 10:55:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f961aaebd68a08cb4b1ccfb1662d8fe5e027600

    Comments

    Add V4L2 JPEG Encoder support.
    
    Support V4L2 JPEG devices.
    It supports both JPEG and JPEG_RAW devices for different hardware
    accelerators.
    This CL also increase the kMeanDiffThreshold to 10 in
    jpeg_encode_accelerator_unittest.
    The encoded results are much different between SW and HW encode.
    
    
    CQ-DEPEND=CL:1161846
    BUG=b:77835279
    TEST=Pass compile on scarlet and nautilus.
    Pass jpeg_encode_accelerator_unittest
    Pass libjea_test
    Take picture on dru and check if we use HW encoder for jpeg.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I9d12625d398e9d66a5e228081a718f55e194a8a4
    Reviewed-on: https://chromium-review.googlesource.com/c/1122146
    Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Dan Sanders <sandersd@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607555}

    Changed files

    • content/gpu/gpu_sandbox_hook_linux.cc
    • media/filters/jpeg_parser.cc
    • media/filters/jpeg_parser.h
    • media/gpu/BUILD.gn
    • media/gpu/gpu_jpeg_encode_accelerator_factory.cc
    • media/gpu/jpeg_encode_accelerator_unittest.cc
    • media/gpu/v4l2/generic_v4l2_device.cc
    • media/gpu/v4l2/generic_v4l2_device.h
    • media/gpu/v4l2/tegra_v4l2_device.cc
    • media/gpu/v4l2/tegra_v4l2_device.h
    • media/gpu/v4l2/v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.h
    • media/gpu/v4l2/v4l2_jpeg_encode_accelerator.cc
    • media/gpu/v4l2/v4l2_jpeg_encode_accelerator.h
    • media/gpu/vaapi/vaapi_jpeg_encode_accelerator.cc
    • media/gpu/vaapi/vaapi_jpeg_encoder.cc
    • media/video/jpeg_encode_accelerator.h
  8. Ribbon: Get computed CSSValues via CSSProperty also for custom properties.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 10:53:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78cf9afa7b11d20e90bbe4838970ae13778a0f3c

    Comments

    Ribbon: Get computed CSSValues via CSSProperty also for custom properties.
    
    This brings the computed CSSValue codepaths closer together for standard
    and custom properties.
    
    R=futhark@chromium.org
    
    Change-Id: Ie80e38c422c7076787218661b2946d08cf59cfe3
    Reviewed-on: https://chromium-review.googlesource.com/c/1329784
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607554}

    Changed files

    • third_party/blink/renderer/core/css/computed_style_css_value_mapping.cc
    • third_party/blink/renderer/core/css/computed_style_css_value_mapping.h
    • third_party/blink/renderer/core/css/css_computed_style_declaration.cc
    • third_party/blink/renderer/core/css/cssom/computed_style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/prepopulated_computed_style_property_map.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.h
    • third_party/blink/renderer/core/css/properties/longhands/custom_property_test.cc
    • third_party/blink/renderer/core/css/properties/longhands/variable.h
    • third_party/blink/renderer/core/css/resolver/element_resolve_context.h
    • third_party/blink/renderer/core/dom/node.h
  9. [Android] Remove ellipsis from generation action strings

    Changed by Ioana Pandele - ioanapohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 10:51:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d310d79ab0d590faecb1cb9937cea6e77b2ee069

    Comments

    [Android] Remove ellipsis from generation action strings
    
    Bug: 904476
    Change-Id: I9d7604f0066bc4f559a5b7676e7bb2f17640cbe4
    Reviewed-on: https://chromium-review.googlesource.com/c/1332193
    Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607553}

    Changed files

    • chrome/android/java/strings/android_chrome_strings.grd
  10. Fix old links in css property template

    Changed by Amos Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Tuesday, 13-Nov-18 10:47:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1735f14f7a6ef64b0f2baf4447ad6fa8c0eba3a6

    Comments

    Fix old links in css property template
    
    Change src/third_party/WebKit/Source/core/css/properties/README.md
    to src/third_party/blink/renderer/core/css/properties/README.md
    
    Bug: N/A
    Change-Id: I604bc885c459c14ea25d8973de75cf8c04080bec
    Reviewed-on: https://chromium-review.googlesource.com/c/1333095
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#607552}

    Changed files

    • third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property_subclass.h.tmpl
  11. [ios] Add manual fallback actions for Credit Cards and Addresses

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 10:45:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7eb50ad7f0c3428e5d8395b9ecf6f55a3c42db4b

    Comments

    [ios] Add manual fallback actions for Credit Cards and Addresses
    
    Follows adding piping into settings in https://crrev.com/c/1332298
    
    Bug: 845472
    Change-Id: I490d24ea9a64beb534372b5c0aad25dfd40f7f6d
    Reviewed-on: https://chromium-review.googlesource.com/c/1332932
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607551}

    Changed files

    • ios/chrome/app/strings/ios_strings.grd
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_mediator.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_mediator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_mediator.mm
  12. [css-text] Skip trailing spaces for pre-wrap even if word can be broken

    Changed by Javier Fernandez - jfernandezohnoyoudont@igalia.com
    Changed at Tuesday, 13-Nov-18 10:43:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c9ddfebad716cd1aed2386175bdd1870efa0217

    Comments

    [css-text] Skip trailing spaces for pre-wrap even if word can be broken
    
    According to the specs, preserved white-spaces should hang, or visually
    collapse, when white-space is set to pre-wrap; even if word-break allows
    breaing the word at any point.
    
    https://www.w3.org/TR/css-text-3/#line-break-details
    
    Bug: 768363
    Change-Id: I7ab356ed6f789ecef087ff469ad97c50e7af49be
    Reviewed-on: https://chromium-review.googlesource.com/c/1318694
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#607550}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/editing/deleting/delete-across-editable-content-boundaries-2.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-text/white-space/pre-wrap-002.html
    • third_party/WebKit/LayoutTests/platform/linux/editing/style/table-selection-expected.png
    • third_party/WebKit/LayoutTests/platform/linux/editing/style/table-selection-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/fast/forms/textarea/basic-textareas-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/editing/style/table-selection-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/editing/style/table-selection-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/editing/style/table-selection-expected.png
    • third_party/WebKit/LayoutTests/platform/win/editing/style/table-selection-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/fast/forms/textarea/basic-textareas-expected.png
    • third_party/blink/renderer/core/layout/line/breaking_context_inline_headers.h
  13. [Autofill Assistant] Changes icon for feedback.

    Changed by Lukasz Suder - lsuderohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 10:40:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bab19ca578902fb12817d0cf79e136e623115f9d

    Comments

    [Autofill Assistant] Changes icon for feedback.
    
    The new icon is: https://icons.googleplex.com/#icon=ic_bug_report
    
    Bug: 806868
    Change-Id: I093adad3a533e1cf4236c74fa589f24ecb725686
    Reviewed-on: https://chromium-review.googlesource.com/c/1329796
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607549}

    Changed files

    • chrome/android/java/res_autofill_assistant/drawable/ic_bug_report_24dp.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
  14. [iOS] Factor web params creation into a tab utility.

    Changed by Mark Cogan - marqohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 10:37:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb485c335ced9fb2eaacd41d9c14aad982e5b4ea

    Comments

    [iOS] Factor web params creation into a tab utility.
    
    This CL creates a tab utility file (free functions used in managing
    tabs), and adds a function to it to create web navigation params from
    a URL, transition type, and post data. It factors this code out of BVC.
    
    Additionally, it moves the logic for translating a tab model index of
    NSNotFound into the last index of the model into TabModel. This was
    also in the BVC.
    
    Bug: 903338
    Change-Id: I856163785d34bb064ea27b76c3094834d3f31626
    Reviewed-on: https://chromium-review.googlesource.com/c/1326509
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607548}

    Changed files

    • ios/chrome/app/application_delegate/url_opener_unittest.mm
    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/tabs/BUILD.gn
    • ios/chrome/browser/tabs/tab_model.mm
    • ios/chrome/browser/tabs/tab_util.h
    • ios/chrome/browser/tabs/tab_util.mm
    • ios/chrome/browser/tabs/tab_util_unittest.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
  15. [OnionSoup] a quick fix for base::internal::flat_tree::insert()

    Changed by Richard Li - richard.liohnoyoudont@intel.com
    Changed at Tuesday, 13-Nov-18 10:33:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3102794f581d27440050412eda663e4ead034e83

    Comments

    [OnionSoup] a quick fix for base::internal::flat_tree::insert()
    
    Looks like the operation of base::internal::flat_tree::insert() will
    cause a build error in specific version of MSVC's STL.
    This CL makes a quick fix for the bug, which still needs a more
    generic solution.
    
    The bug is raised here by Martin:
    https://crrev.com/c/1312673/9/content/common/service_worker/
    service_worker_utils.cc#265
    
    Taiju provides a possible workaround:
    https://crrev.com/c/1333171
    
    Change-Id: I55ab4eaecb77ea974b7b651fd32f7982bc79e039
    Reviewed-on: https://chromium-review.googlesource.com/c/1331172
    Commit-Queue: Richard Li <richard.li@intel.com>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Martin Kreichgauer <martinkr@google.com>
    Cr-Commit-Position: refs/heads/master@{#607547}

    Changed files

    • content/common/service_worker/service_worker_utils.cc
  16. media/gpu/v4l2/v4l2 VEA: Support DMABuf-backed video frame input on Encode()

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 10:29:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8dada6eb2d55994e79f65d4ef04bb37abd2fd8d

    Comments

    media/gpu/v4l2/v4l2 VEA: Support DMABuf-backed video frame input on Encode()
    
    V4L2VEA supports only SHMEM video frame for Encode().
    V4L2_MEMORY_USERPTR API is used on VIDIOC_QBUF, which is less efficient than
    V4L2_MEMORY_{MMAP, DMABUF} API.
    This enables V4L2VEA to accept DMABuf-backed video frame on Encode(). The video
    frame is queued with V4L2_MEMORY_DMABUF API unless ImageProcessor outputs SHMEM
    video frame.
    
    BUG=895230, 901264
    TEST=VDA unittest --native_input on minnie, kevin
    
    Change-Id: I545e26ffb619eb6c065183f794cef78e42cc2ea8
    Reviewed-on: https://chromium-review.googlesource.com/c/1301579
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607546}

    Changed files

    • media/gpu/v4l2/v4l2_video_encode_accelerator.cc
  17. Revert "Add support for variadic arguments in generated stubs"

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 10:27:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc6ae6a34d49604633b77f030a78a49d8bb89e3d

    Comments

    Revert "Add support for variadic arguments in generated stubs"
    
    This reverts commit d27bb5431562964962e8eef4a4374d27290b218d.
    
    Reason for revert: This CL causes HW encoding functionality loss on some Chrome OS devices, minnie and kevin.
    
    Original change's description:
    > Add support for variadic arguments in generated stubs
    >
    > Previously we were using va_list for variadic arguments. The downside
    > for this was that only the first value from the variadic argument was
    > passed to the original function.
    >
    > To make it work properly we have to use the __VA_ARGS__ variadic macro
    > that was introduces in C99 and is available in all major C/C++
    > compilers.
    >
    > Change-Id: I50652f7348a16214811aaab8af116d78cdb70444
    > Reviewed-on: https://chromium-review.googlesource.com/c/1323089
    > Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com>
    > Cr-Commit-Position: refs/heads/master@{#606588}
    
    TBR=phoglund@chromium.org,dpranke@chromium.org,braveyao@chromium.org,brucedawson@chromium.org,tomas.popela@gmail.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 904586
    Change-Id: I04157ea305decc170d5efd4ba228c92bd4020ef6
    Reviewed-on: https://chromium-review.googlesource.com/c/1333013
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607545}

    Changed files

    • tools/generate_stubs/generate_stubs.py
    • tools/generate_stubs/generate_stubs_unittest.py
  18. Orderfile: better pregenerated profile handling.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 10:21:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a2bea453e180501909c8f8ab57e36e15a26a3e6d

    Comments

    Orderfile: better pregenerated profile handling.
    
    Use pregenerated profiles for system health orderfiles, and
    avoid compiling if they are being used.
    
    Change-Id: Ib386bcd227e4f3ee4892d50ea2ec41085497f41b
    Reviewed-on: https://chromium-review.googlesource.com/c/1332299
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607544}

    Changed files

    • tools/cygprofile/orderfile_generator_backend.py
    • tools/cygprofile/profile_android_startup.py
  19. Roll src-internal 5ff1dec42b3d..21a6d3755355 (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 10:21:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57f1e0490934660cd401a2760d43f15912e417d7

    Comments

    Roll src-internal 5ff1dec42b3d..21a6d3755355 (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ff1dec42b3d..21a6d3755355
    
    
    Created with:
      gclient setdep -r src-internal@21a6d3755355
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ieeeefe42cb65a95731943f01596badef7b5c45ea
    Reviewed-on: https://chromium-review.googlesource.com/c/1332832
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607543}

    Changed files

    • DEPS
  20. [iOS] Support Dynamic Type in NTP fakebox

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 10:13:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a9a3dc9e3c68a1f501215703548c48745cfdcfe

    Comments

    [iOS] Support Dynamic Type in NTP fakebox
    
    This CL changes the NTP fakebox so it supports Dynamic Type, in the
    same way as the toolbar is supporting it.
    
    Bug: 893522
    Change-Id: Icd1e90374bcd071ab77516147891882bd4af5fa7
    Reviewed-on: https://chromium-review.googlesource.com/c/1307408
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607542}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/BUILD.gn
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
    • ios/chrome/browser/ui/ntp/new_tab_page_header_constants.h
    • ios/chrome/browser/ui/ntp/new_tab_page_header_constants.mm
    • ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm
    • ios/chrome/browser/ui/toolbar/toolbar_utils.h
    • ios/chrome/browser/ui/toolbar/toolbar_utils.mm
  21. [signin] Remove source parameter in GaiaCookieManagerService

    Changed by David Roger - drogerohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 10:02:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 092f8caba5930ad2730aaad5139d6030ccc946de

    Comments

    [signin] Remove source parameter in GaiaCookieManagerService
    
    All callers were using the same source, it is now hardcoded.
    
    TBR=treib, eugenebut
    
    Bug: 895010
    Change-Id: Ib068188ac152f39d6f552644c373cf9103d56087
    Reviewed-on: https://chromium-review.googlesource.com/c/1329621
    Commit-Queue: David Roger <droger@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607541}

    Changed files

    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • chrome/browser/signin/gaia_cookie_manager_service_factory.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/search_provider_logos/logo_service_impl_unittest.cc
    • components/signin/core/browser/account_investigator_unittest.cc
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.h
    • components/signin/core/browser/gaia_cookie_manager_service.cc
    • components/signin/core/browser/gaia_cookie_manager_service.h
    • components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
    • components/signin/core/browser/signin_manager_unittest.cc
    • components/signin/core/browser/signin_tracker_unittest.cc
    • components/signin/ios/browser/account_consistency_service_unittest.mm
    • google_apis/gaia/ubertoken_fetcher.cc
    • google_apis/gaia/ubertoken_fetcher.h
    • ios/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • ios/chrome/browser/signin/gaia_cookie_manager_service_factory.cc
    • ios/web_view/internal/signin/web_view_gaia_cookie_manager_service_factory.mm
    • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
    • services/identity/public/cpp/identity_manager_unittest.cc
    • services/identity/public/cpp/identity_test_environment.cc
  22. PersonalDataManagerTest cleanups

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 10:01:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c03990036667d7311b9ef82b4bb3f4be2742d07

    Comments

    PersonalDataManagerTest cleanups
    
    - Properly distinguish "does an account DB exist" (= is the feature flag
      enabled) vs "should we use the account DB" (= is the active account a
      non-primary one).
    - Use a primary account by default.
    - Write to the correct (profile vs account) table depending on the
      current PDM state.
    
    Bug: 864519
    Change-Id: Ie6a097254d99c82d48c8f2eb98ec46191ca1d3e5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329168
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607540}

    Changed files

    • components/autofill/core/browser/personal_data_manager_unittest.cc
  23. [ios] add opening of credit cards / addresses settings from manual fallback

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 09:58:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7187874ae5eaf5009545a9408e7d55f308f28e10

    Comments

    [ios] add opening of credit cards / addresses settings from manual fallback
    
    Bug: 845472
    Change-Id: I1dabe1fd33812e0d533087b0aa2b4f56f6c2f721
    Reviewed-on: https://chromium-review.googlesource.com/c/1332298
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607539}

    Changed files

    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.h
    • ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/commands/application_commands.h
    • ios/chrome/browser/ui/settings/settings_navigation_controller.h
    • ios/chrome/browser/ui/settings/settings_navigation_controller.mm
  24. Cleanup: Remove unused FakeSyncService implementation in ntp_snippets

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:53:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 69a0c405c5129b6b9ec690703988ee40a1af4d88

    Comments

    Cleanup: Remove unused FakeSyncService implementation in ntp_snippets
    
    Bug: 859874
    Change-Id: Ib02931e14a22b2454b94b2021b65744441856475
    Reviewed-on: https://chromium-review.googlesource.com/c/1326504
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607538}

    Changed files

    • components/ntp_snippets/remote/test_utils.cc
    • components/ntp_snippets/remote/test_utils.h
  25. [Background Fetch] Add feature flag for access to

    Changed by Mugdha Lakhani - natorohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc348bc897b0ccb123a4d63c7cdb6d0547a6729e

    Comments

    [Background Fetch] Add feature flag for access to
    
    active background fetches.
    This allows iterative implementation of this feature.
    
    Bug: 875201
    Change-Id: Ia349eb55e682cf22825b53559c8e1f603d189501
    Reviewed-on: https://chromium-review.googlesource.com/c/1331397
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Mugdha Lakhani <nator@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607537}

    Changed files

    • content/child/runtime_features.cc
    • content/public/common/content_features.cc
    • content/public/common/content_features.h
    • third_party/blink/public/platform/web_runtime_features.h
    • third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
    • third_party/blink/renderer/platform/exported/web_runtime_features.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  26. Deflake fast/css/no-recalc-on-no-op-inline-style-changes.html

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:45:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb0fc8da6655254bddcf03fcd6a9730ad481eb1e

    Comments

    Deflake fast/css/no-recalc-on-no-op-inline-style-changes.html
    
    The test had an assumption about a style recalc count at a point during
    loading which was not preceeded by a forced recalc at any point. The
    result was undefined and it did not test anything useful. Add a forced
    recalc through offsetTop before the test instead.
    
    Bug: 904587
    Change-Id: I17d00e017a625ca10f71ebfd3a946266d6ea9ff5
    Reviewed-on: https://chromium-review.googlesource.com/c/1332431
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607536}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/css/no-recalc-on-no-op-inline-style-changes.html
  27. Show dummy values for all types of Passwords/Passphrases/PSK in case we have already stored a particular value

    Changed by Roman Aleksandrov - raleksandrovohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 09:42:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b8576e9f978d8536dee497834602ebf33f0eb1e4

    Comments

    Show dummy values for all types of Passwords/Passphrases/PSK in case we have already stored a particular value
    
    
    Change-Id: I6c6b8293aa7748152a44b945f092e563643328d8
    Bug: 888959
    Reviewed-on: https://chromium-review.googlesource.com/c/1296540
    Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607535}

    Changed files

    • chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
    • chromeos/network/onc/onc_merger.cc
    • chromeos/network/onc/onc_translator_shill_to_onc.cc
    • chromeos/network/policy_util.cc
    • chromeos/network/policy_util.h
    • chromeos/test/data/network/augmented_merge.json
    • ui/webui/resources/cr_components/chromeos/network/network_config.html
    • ui/webui/resources/cr_components/chromeos/network/network_config.js
    • ui/webui/resources/cr_components/chromeos/network/network_password_input.html
    • ui/webui/resources/cr_components/chromeos/network/network_password_input.js
  28. [iOS] Add delete in SettingsTableView's toolbar

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:39:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b269a4b2030a61eb75b06564c555e81e0a5dcf50

    Comments

    [iOS] Add delete in SettingsTableView's toolbar
    
    This CL adds a toolbar with a "delete" item in the
    SettingsRootTableViewController, displayed when the item selection is
    not nil.
    
    Bug: 894791
    Change-Id: Ifffc2b774ab96bad97814cdf80829f2f0b74d77a
    Reviewed-on: https://chromium-review.googlesource.com/c/1331469
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607534}

    Changed files

    • ios/chrome/app/strings/ios_strings.grd
    • ios/chrome/browser/ui/settings/settings_root_table_view_controller.h
    • ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm
    • ios/chrome/browser/ui/settings/settings_root_table_view_controller_unittest.mm
  29. Migrate PeopleHandler to use SyncUserSettings

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:38:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a785431019d0dae45c45d9c6bf62b7a258a7b6f0

    Comments

    Migrate PeopleHandler to use SyncUserSettings
    
    SyncUserSettings is a new class that encapsulates all the
    user-configurable knobs for Sync. It replaces a bunch of setters
    and getters directly on the SyncService.
    
    Bug: 884159
    Change-Id: I0d689d5a07a17895ddf93463a7896fdf1484b3dd
    Reviewed-on: https://chromium-review.googlesource.com/c/1286452
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607533}

    Changed files

    • chrome/browser/ui/webui/settings/people_handler.cc
  30. Orderfile: use reliable package killing.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:32:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9b58467532dd8b1901ca073132ee53340eb334d

    Comments

    Orderfile: use reliable package killing.
    
    The device_utils.KillAll command is not reliable for chrome. This
    command uses `ps` on the device to enumerate all pids for a package,
    and then does a `kill` for each pid. If, for example, a chrome browser
    process is killed by the host, and a dependent renderer process dies
    before the host can get around to killing it, device_utils.KillAll
    will think that the kill failed and raise an exception.
    
    This could be circumvented either by passing quiet=True to KillAll, or
    by using the activity manager force-stop command, as is done in the
    CL. This latter method seems to be the current preferred way to
    gracefully kill all processes of a package.
    
    Bug: 898979
    Change-Id: I0451c04b1d9e9ab919dde5e12df247fce3a7651a
    Reviewed-on: https://chromium-review.googlesource.com/c/1329152
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607532}

    Changed files

    • tools/cygprofile/profile_android_startup.py
  31. Fix DCHECKs in HammerdClient D-Bus callbacks

    Changed by Shao-Chuan Lee - shaochuanohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:27:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 330ebc0b5730376a591e6c022a853645988f52c4

    Comments

    Fix DCHECKs in HammerdClient D-Bus callbacks
    
    DCHECKs in callbacks did not match corresponding signals.
    
    Bug: 902717
    Change-Id: I1fb9385ce0360445593c1c1b095706dfcd4821dc
    Reviewed-on: https://chromium-review.googlesource.com/c/1331092
    Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
    Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607531}

    Changed files

    • chromeos/dbus/hammerd_client.cc
  32. Enable Feature Policy control over setting `document.domain`.

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:17:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59b93fee3639bf638833521032d30823f5240c01

    Comments

    Enable Feature Policy control over setting  `document.domain`.
    
    Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Ff6Ywg5vnh4/VbDH4X6wBQAJ
    Explainer: https://github.com/WICG/feature-policy/issues/241
    Spec PR: https://github.com/whatwg/html/pull/4170
    
    Bug: 904351
    Change-Id: I14c0c3c871a01017f9c2bcbe8ed41c7b26782e71
    Reviewed-on: https://chromium-review.googlesource.com/c/1329791
    Commit-Queue: Mike West <mkwst@chromium.org>
    Reviewed-by: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607530}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_feature_policy.tentative.sub.html
    • third_party/blink/common/feature_policy/feature_policy.cc
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/feature_policy/feature_policy.cc
  33. [v8][wasm] Enable testing of trap handlers on Windows

    Changed by Andreas Haas - ahaasohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:16:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0028b6de84286309b62c123a77aa8fbb49538b9e

    Comments

    [v8][wasm] Enable testing of trap handlers on Windows
    
    The field trial should be turned on by http://cl/220249819.
    
    R=mpearson@chromium.org
    
    Change-Id: Ifa0b4c5d7c9850c304bc4d2ce5b4fb44328f85da
    Reviewed-on: https://chromium-review.googlesource.com/c/1318910
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607529}

    Changed files

    • chrome/test/v8/wasm_trap_handler_browsertest.cc
    • testing/variations/fieldtrial_testing_config.json
  34. Update V8 to version 7.2.309.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 09:13:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c4412cb466794a654337bba2ac11ab432d76ebde

    Comments

    Update V8 to version 7.2.309.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/eb9d3fbd..4fe505da
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I338bb51edb7fd45e953971dbe50e453985088b07
    Reviewed-on: https://chromium-review.googlesource.com/c/1333229
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607528}

    Changed files

    • DEPS
  35. [Autofill Assistant] Smoother scrolling for highlighted element.

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:12:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8948cc5346afcec51c3a3cda2bb268d3fa8ee47a

    Comments

    [Autofill Assistant] Smoother scrolling for highlighted element.
    
    This change improves the scrolling for highlighted elements.
    
    Before this change, while scrolling, highlighted elements were updated
    by the periodic update of the element position, which happens every
    100ms. While scrolling, this produces noticeable jumps.
    
    After this change, while scrolling, elements position is updated based
    on the scroll position and the periodic updates are ignored. This means
    that scrolling of the highlighted area follows the UI scrolling, which
    is much smoother.
    
    Note that there can still be a shift between the highlighted area and
    the element, as the web page doesn't always scroll exactly at the same
    speed as the UI elements, but the shift is much smaller and smoother.
    
    Bug: 806868
    Change-Id: Ide5f9b6f0ba472c93ced2dd26b4cbaf2ee14b59f
    Reviewed-on: https://chromium-review.googlesource.com/c/1331401
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607527}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/TouchEventFilter.java
    • components/autofill_assistant/browser/element_area.cc
  36. [wasm] Change owners of wasm_trap_handler_browsertest.cc

    Changed by Andreas Haas - ahaasohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:12:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c027688fb644c72a0ce6255f5d709462a0fe47d5

    Comments

    [wasm] Change owners of wasm_trap_handler_browsertest.cc
    
    eholk left the team.
    
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    
    R=adamk@chromium.org
    
    Change-Id: Icef00e5fe48a66388fdb891014c204ad494ea3bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1331470
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607526}

    Changed files

    • chrome/test/v8/OWNERS
  37. Roll src/third_party/skia 13b099f8982c..1e1ba0e0176f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 09:01:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb67cdac5ec45c1e991fe45a34fe56dd48e3a6e1

    Comments

    Roll src/third_party/skia 13b099f8982c..1e1ba0e0176f (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/13b099f8982c..1e1ba0e0176f
    
    
    git log 13b099f8982c..1e1ba0e0176f --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
    
    
    Created with:
      gclient setdep -r src/third_party/skia@1e1ba0e0176f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=rmistry@chromium.org
    
    Change-Id: I73b739adba30946c9702c72f53162a1bfa8298a5
    Reviewed-on: https://chromium-review.googlesource.com/c/1332831
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607525}

    Changed files

    • DEPS
  38. Orderfile: Correctly use symbol size to translate offset

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 09:00:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3e2f70ffdeebff84d58ef5665adc21cac739930

    Comments

    Orderfile: Correctly use symbol size to translate offset
    
    The existing logic is not correct for code that's not word-aligned,
    which happens frequently with thumb (16-bit) instruction words.
    
    Also asserts that no symbols appear before the starting symbol. We
    expect that the only symbols we have are from text, and that the
    symbol placed by the linker script occurs not after any
    symbol. Breaking either of the assumptions may break assumptions made
    elsewhere.
    
    Bug: 893981
    Change-Id: I748c9edd0f6a5f49790b4c06d4246ee1cf8f90dc
    Reviewed-on: https://chromium-review.googlesource.com/c/1329166
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607524}

    Changed files

    • tools/cygprofile/process_profiles.py
    • tools/cygprofile/process_profiles_unittest.py
  39. Roll src-internal c7c538bb4af4..5ff1dec42b3d (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 08:54:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd3e6748c4a31c2cf65f40b93cde5fb66116bb8b

    Comments

    Roll src-internal c7c538bb4af4..5ff1dec42b3d (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7c538bb4af4..5ff1dec42b3d
    
    
    Created with:
      gclient setdep -r src-internal@5ff1dec42b3d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ie122e4ef711f3c3059a9b25a59536683baf96f94
    Reviewed-on: https://chromium-review.googlesource.com/c/1333058
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607523}

    Changed files

    • DEPS
  40. Clean up search_engine.js: modify fragile links to webpages and change to ES6 grammar.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 08:48:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07fe0e6d1492214d210c776855c27fcdacbcc9d0

    Comments

    Clean up search_engine.js: modify fragile links to webpages and change to ES6 grammar.
    
    This CL clean up some defects in search_engine.js. Firstly remove those
    URL links in comments that contain line number as URL args, because they
    are easy to be broken by change in referred files. Secondly change all
    "var" to "let" since it's supported in iOS 10 and the presubmit check
    has been removed.
    
    Bug: 433824
    Change-Id: I6ba00a95c904c897b3845ddd6a96b29fef639b73
    Reviewed-on: https://chromium-review.googlesource.com/c/1329976
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607522}

    Changed files

    • ios/chrome/browser/search_engines/resources/search_engine.js
  41. Convert CustodianProfileDownloaderService to the Identity service

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Tuesday, 13-Nov-18 08:34:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ce66e0150c658aa9f1cf6de49bd2fff6e0ffaa59

    Comments

    Convert CustodianProfileDownloaderService to the Identity service
    
    Migrate usage of SigninManagerBase::IsAuthenticated() to the
    IdentityManager's API.
    
    Bug: 903882
    Change-Id: Ib452442d5eff692eed54c7c690845005c9b1717c
    Reviewed-on: https://chromium-review.googlesource.com/c/1331399
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#607521}

    Changed files

    • chrome/browser/supervised_user/legacy/custodian_profile_downloader_service.cc
  42. [Feed] Add user action for the Feed

    Changed by Gang Wu - gangwuohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 08:28:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82320bd1d7aeb28b13c1452df4945968e40eddb7

    Comments

    [Feed] Add user action for the Feed
    
    This CL for Recording user actions in Feed, which were recorded in Zine.
    
    Bug: 902126
    Change-Id: Ie20f82d5644dd856f350c4ad7729b72946a41601
    Reviewed-on: https://chromium-review.googlesource.com/c/1330721
    Commit-Queue: Gang Wu <gangwu@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607520}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/action/FeedActionHandler.java
    • chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
    • components/feed/core/feed_logging_metrics.cc
    • components/feed/core/feed_logging_metrics.h
  43. Revert "Reland "Get NetworkChangeNotifier working on ChromeOS with network service.""

    Changed by Robbie McElrath - rmcelrathohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 08:28:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 53a1b6f6e1adae07f464990a4e9cb766832f10fe

    Comments

    Revert "Reland "Get NetworkChangeNotifier working on ChromeOS with network service.""
    
    This reverts commit 1ab94ee7bca8b041bdbd8fc9d19efc96aba255b1.
    
    Reason for revert: crbug.com/904739
    
    Original change's description:
    > Reland "Get NetworkChangeNotifier working on ChromeOS with network service."
    > 
    > This reverts commit 0d2550b11b39253ef0351fdd85f94b10c97bb927.
    > 
    > Reason for revert: Fixed NetworkContextConfigurationFilePacBrowserTest
    > 
    > Original change's description:
    > > Revert "Get NetworkChangeNotifier working on ChromeOS with network service."
    > >
    > > This reverts commit 7b0677dd5848ec9f489652d899188731404defea.
    > >
    > > Reason for revert: findit says this broke something. I'll revert and see if it's right tomorrow.
    > >
    > > Original change's description:
    > > > Get NetworkChangeNotifier working on ChromeOS with network service.
    > > >
    > > > The current NetworkChangeNotifierChromeOS implementation won't work
    > > > with the network service enabled because it listens for network changes
    > > > from Shill, which only supports a single client. The browser process
    > > > has other dependencies on Shill, so it has to be the client for the time
    > > > being, meaning the network service can't directly listen for network
    > > > changes and has to be notified of them from the browser process.
    > > >
    > > > This CL splits the NetworkChangeNotifierChromeOS into two parts;
    > > > the first will live in the browser process and listen to Shill, while
    > > > the second is the actual NetworkChangeNotifierChromeOS implementation
    > > > which will have an instance in both the browser and network processes.
    > > > Since NetworkChangeNotifierChromeOS can't actually listen for network
    > > > changes itself, it just gets notified of changes from part 1 via a new
    > > > method in NetworkChangeManager. When the thing listening to Shill sees
    > > > a network change, it notifies its local NetworkChangeNotifierChromeOS
    > > > instance, and calls the new NetworkChangeManager method, the
    > > > implementation of which then notifies the network service's
    > > > NetworkChangeNotifierChromeOS instance.
    > > >
    > > > Bug: 882610
    > > > Cq-Include-Trybots: luci.chromium.try:linux_mojo
    > > > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/1274445
    > > > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
    > > > Reviewed-by: Will Harris <wfh@chromium.org>
    > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#606665}
    > >
    > > TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org
    > >
    > > Change-Id: I1fa2bcabe73082e02e59f7c613d08aec4ac94e57
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Bug: 882610
    > > Cq-Include-Trybots: luci.chromium.try:linux_mojo
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1328701
    > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
    > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#606745}
    > 
    > TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org
    > 
    > Change-Id: Ied0722203a1fa29aa3420bb84c70dee15d47fbb6
    > Bug: 882610
    > Cq-Include-Trybots: luci.chromium.try:linux_mojo
    > Reviewed-on: https://chromium-review.googlesource.com/c/1329897
    > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
    > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607351}
    
    TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org
    
    Change-Id: Iaf54b01741708b865f8ab5979afc9292babdb1c2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 882610
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Reviewed-on: https://chromium-review.googlesource.com/c/1333248
    Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607519}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/chromeos/network_change_manager_client.cc
    • chrome/browser/chromeos/network_change_manager_client.h
    • chrome/browser/chromeos/network_change_manager_client_browsertest.cc
    • chrome/browser/chromeos/network_change_manager_client_unittest.cc
    • chrome/browser/net/network_context_configuration_browsertest.cc
    • chrome/test/BUILD.gn
    • chromeos/network/BUILD.gn
    • chromeos/network/managed_state.h
    • chromeos/network/network_change_notifier_chromeos.cc
    • chromeos/network/network_change_notifier_chromeos.h
    • chromeos/network/network_change_notifier_chromeos_unittest.cc
    • chromeos/network/network_change_notifier_factory_chromeos.cc
    • chromeos/network/network_change_notifier_factory_chromeos.h
    • chromeos/network/network_state.h
    • content/browser/browser_main_loop.h
    • content/browser/net_info_browsertest.cc
    • content/browser/network_service_instance.cc
    • content/public/browser/network_service_instance.h
    • content/public/test/browser_test_base.cc
    • net/BUILD.gn
    • net/base/network_change_notifier.cc
    • net/base/network_change_notifier_chromeos.cc
    • net/base/network_change_notifier_chromeos.h
    • net/base/network_change_notifier_chromeos_unittest.cc
    • services/network/network_change_manager.cc
    • services/network/network_change_manager.h
    • services/network/network_context_unittest.cc
    • services/network/network_service.cc
    • services/network/public/mojom/network_change_manager.mojom
    • testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
  44. blink/bindings: Improve ParkableStringManager testing.

    Changed by Benoît Lizé - lizebohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 08:07:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a852678d14edee58ec1f83c56196547a4a5cc09b

    Comments

    blink/bindings: Improve ParkableStringManager testing.
    
    |ParkableStringManager::SetRendererBackgrounded()| schedules delayed tasks, but
    tests were not waiting for the tasks to run, instead directly calling the
    delayed functions.
    
    This adds a test checking for proper task sequencing, and changes other tests to
    properly wait for tasks. As a consequence, the ParkableStringManager tests no
    longer need to be friend with ParkableStringManager, provided that |Size()|
    becomes public.
    
    Also fixes a couple "git cl lint" warnings.
    
    Bug: 877044
    Change-Id: I15ea4285596dc744969e0bce63c5687e6fed023c
    Reviewed-on: https://chromium-review.googlesource.com/c/1331476
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607518}

    Changed files

    • third_party/blink/renderer/platform/bindings/parkable_string.cc
    • third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
    • third_party/blink/renderer/platform/bindings/parkable_string_manager.h
    • third_party/blink/renderer/platform/bindings/parkable_string_test.cc
  45. [LayoutNG] Avoid copying NGOutOfFlowPositionedDescendant

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 08:02:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f780e9be389aa05e6188f2cb99d12026d47ffd48

    Comments

    [LayoutNG] Avoid copying NGOutOfFlowPositionedDescendant
    
    Bug: 635619
    Change-Id: I5f2992f95f755e56c34ce5a89c5185ae31b6537f
    Reviewed-on: https://chromium-review.googlesource.com/c/1333010
    Reviewed-by: Aleks Totic <atotic@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607517}

    Changed files

    • third_party/blink/renderer/core/layout/ng/layout_ng_block_flow.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_node.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_node.h
  46. Make PendingAppManager::AppInfo an editable struct.

    Changed by Christopher Lam - calamityohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 07:53:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdc86f4ba591f0a8ce2e39d5c7777f8b22e2fdc0

    Comments

    Make PendingAppManager::AppInfo an editable struct.
    
    This CL makes the optional parts of AppInfo editable, which allows
    for simpler construction.
    
    TBR=jamescook@chromium.org
    
    Bug: None
    Change-Id: I2a94765cdcba253951f802f15bab0e5d0e01a6d0
    Reviewed-on: https://chromium-review.googlesource.com/c/1325277
    Reviewed-by: calamity <calamity@chromium.org>
    Reviewed-by: Jeremy Klein <jlklein@chromium.org>
    Reviewed-by: Alexey Baskakov <loyso@chromium.org>
    Reviewed-by: Ben Wells <benwells@chromium.org>
    Commit-Queue: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607516}

    Changed files

    • chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc
    • chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc
    • chrome/browser/web_applications/bookmark_apps/external_web_apps.cc
    • chrome/browser/web_applications/bookmark_apps/external_web_apps_unittest.cc
    • chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager.cc
    • chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager_unittest.cc
    • chrome/browser/web_applications/bookmark_apps/system_web_app_manager.cc
    • chrome/browser/web_applications/bookmark_apps/system_web_app_manager_unittest.cc
    • chrome/browser/web_applications/components/pending_app_manager.cc
    • chrome/browser/web_applications/components/pending_app_manager.h
    • chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc
    • chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc
    • chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc
  47. Disable Launcher autocomplete by default

    Changed by Vladislav Kaznacheev - kaznacheevohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 07:28:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f7a616d6293adb1a33306fd3ce968181dd8e516

    Comments

    Disable Launcher autocomplete by default
    
    Autocomplete breaks several features (see linked bugs) and a correct
    fix requires investigation. Disabling the feature for now.
    
    Bug: 897206, 902558
    Test: manual
    Change-Id: I54a68a88541fab0e2054349c32c1c1892324f67a
    Reviewed-on: https://chromium-review.googlesource.com/c/1332148
    Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607515}

    Changed files

    • ash/public/cpp/app_list/app_list_features.cc
  48. Roll src-internal 16bc600d527a..c7c538bb4af4 (4 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 07:24:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a79bd84bdc22dee73190e6c8dd5847aecf5404eb

    Comments

    Roll src-internal 16bc600d527a..c7c538bb4af4 (4 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16bc600d527a..c7c538bb4af4
    
    
    Created with:
      gclient setdep -r src-internal@c7c538bb4af4
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ieaceefc4d9c8b241aaace92693a8ff48f5bb6277
    Reviewed-on: https://chromium-review.googlesource.com/c/1333057
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607514}

    Changed files

    • DEPS
  49. OOR-CORS: Make PreflightController per-profile

    Changed by Takashi Toyoshima - toyoshimohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 07:15:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef3eae66abc67ff1334fb375e182cf5d6396582b

    Comments

    OOR-CORS: Make PreflightController per-profile
    
    Existing implementation uses a single PreflightController for all
    profiles, but ideally it should be per-profile.
    
    This patch makes the controller per-profile for NetworkService, and does
    it per-factory for legacy code path due to lack of NetworkContext.
    
    Bug: 894690
    Change-Id: Ief446431e4235bcecd68ba1f50528e721efed96a
    Reviewed-on: https://chromium-review.googlesource.com/c/1331349
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607513}

    Changed files

    • services/network/cors/cors_url_loader.cc
    • services/network/cors/cors_url_loader.h
    • services/network/cors/cors_url_loader_factory.cc
    • services/network/cors/cors_url_loader_factory.h
    • services/network/cors/preflight_controller.cc
    • services/network/cors/preflight_controller.h
    • services/network/network_context.h
  50. [Mojo WebUI] Move removeListener to CallbackRouters.

    Changed by Christopher Lam - calamityohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 07:09:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ebfee307edc9517da8ed9516f655bf994fb00999

    Comments

    [Mojo WebUI] Move removeListener to CallbackRouters.
    
    This CL makes the CallbackRouters responsible for removing listeners.
    This improves ergonomics of removing a list of listeners for different
    InterfaceCallbackTargets.
    
    Bug: 894376
    Change-Id: I051857e463257100d667cf78ca8cc2c1d53bcd83
    Reviewed-on: https://chromium-review.googlesource.com/c/1301034
    Commit-Queue: calamity <calamity@chromium.org>
    Reviewed-by: Ken Rockot <rockot@google.com>
    Cr-Commit-Position: refs/heads/master@{#607512}

    Changed files

    • mojo/public/js/bindings_lite.js
    • mojo/public/tools/bindings/generators/js_templates/lite/interface_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/interface_externs.tmpl
    • third_party/closure_compiler/externs/mojo.js
  51. [auto] Update FlagExpectations for LayoutNG

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 06:51:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15e618569312e7fd854ae0b692ca0e4cf30cf70f

    Comments

    [auto] Update FlagExpectations for LayoutNG
    
    Following bot results are included.
    11590 11634 11637 11639 11644 11652 11670 11680 11685 11686
    11689 11694 11703 11710 11720 11722 11724 11734 11740 11746
    11751 11755
    
    2 lines were removed and 9 lines were deflaked by consecutive
    results since 11689.
    
    TBR=eae@chromium.org, mstensho@chromium.org
    NOTRY=true
    
    Bug: 591099
    Change-Id: Iba29f6bf95f6025fb6304757e0f1652ac8a13db2
    Reviewed-on: https://chromium-review.googlesource.com/c/1327301
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607511}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
  52. Roll src/third_party/skia f04fb3cacbad..13b099f8982c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 06:51:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bc3c39b11640d42b1d5c0f10de3a28dc57ce1041

    Comments

    Roll src/third_party/skia f04fb3cacbad..13b099f8982c (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/f04fb3cacbad..13b099f8982c
    
    
    git log f04fb3cacbad..13b099f8982c --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
    
    
    Created with:
      gclient setdep -r src/third_party/skia@13b099f8982c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=rmistry@chromium.org
    
    Change-Id: I23c1df8e102aeda4c5bb5a0a8ca41535a018461f
    Reviewed-on: https://chromium-review.googlesource.com/c/1333056
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607510}

    Changed files

    • DEPS
  53. Revert "Android: TabThemeColorHelper"

    Changed by Yuki Shiino - yukishiinoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 06:44:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7d0fbfd8b6d57ccbd94d78d66288485c07c2819e

    Comments

    Revert "Android: TabThemeColorHelper"
    
    This reverts commit bf9ab045817f097bd5935e44fa7db377a7896715.
    
    Reason for revert: This seems like causing "chrome_public_test_apk on Android device Nexus 5X" fail.
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3601
    https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/3602
    
    Original change's description:
    > Android: TabThemeColorHelper
    > 
    > This is to break the TabObserver present in Tab class down to feature
    > level and eventually remove it. Theme color used for Tab is managed via
    > Tab UserData. Relevant Tab methods also got migrated.
    > 
    > Bug: 877878
    > Change-Id: If120beaaa370d07f6855ab666e380cc2318e945a
    > Reviewed-on: https://chromium-review.googlesource.com/c/1304038
    > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    > Reviewed-by: Ted Choc <tedchoc@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607422}
    
    TBR=tedchoc@chromium.org,jinsukkim@chromium.org
    
    Change-Id: I4bc704a509682873ef9f1a2e4f4fe82ac2a5cac2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 877878
    Reviewed-on: https://chromium-review.googlesource.com/c/1333098
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607509}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabThemeColorHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/TabThemeTest.java
  54. [On-device adaptive brightness] Change ALS sampling frequency to 1hz.

    Changed by Jia - jiamengohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 06:35:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 98a2b71083227a60edb1c4dfece91fa1e03cbebe

    Comments

    [On-device adaptive brightness] Change ALS sampling frequency to 1hz.
    
    Default frequency of the sensor is 1hz. As we are not increasing it, we should
    only read it at the same frequency.
    
    Bug: 881215
    Change-Id: Id3caa1d5f41177f511e6d0d5559b9da3311b5edf
    Reviewed-on: https://chromium-review.googlesource.com/c/1333172
    Reviewed-by: Dan Erat <derat@chromium.org>
    Commit-Queue: Jia Meng <jiameng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607508}

    Changed files

    • chrome/browser/chromeos/power/auto_screen_brightness/adapter_unittest.cc
    • chrome/browser/chromeos/power/auto_screen_brightness/als_reader.h
  55. WebApp: Extract pre- and post- WebAppIconDownloader utils.

    Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 06:29:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00fad307e5101e01b7c66772acb8d621132b2fa0

    Comments

    WebApp: Extract pre- and post- WebAppIconDownloader utils.
    
    We will reuse them in WebAppDataRetriever together with WebAppIconDownloader.
    
    Unify |SizesToGenerate|: it is {32, 64, 48, 96, 128, 256} preset everywhere.
    (Matches the old behavior).
    
    Bug: 875698
    Change-Id: Ifa06136294ab5dfefd1785a143268c6a5379a154
    Reviewed-on: https://chromium-review.googlesource.com/c/1331101
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607507}

    Changed files

    • chrome/browser/extensions/bookmark_app_helper.cc
    • chrome/browser/web_applications/components/web_app_data_retriever.cc
    • chrome/browser/web_applications/components/web_app_data_retriever_unittest.cc
    • chrome/browser/web_applications/components/web_app_icon_generator.h
    • chrome/browser/web_applications/components/web_app_install_utils.cc
    • chrome/browser/web_applications/components/web_app_install_utils.h
  56. Roll src-internal 51a60d9d8dca..16bc600d527a (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 06:27:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4fbd608648741a0b676d105cc701492a07fbaba

    Comments

    Roll src-internal 51a60d9d8dca..16bc600d527a (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/51a60d9d8dca..16bc600d527a
    
    
    Created with:
      gclient setdep -r src-internal@16bc600d527a
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: If12294a83b54cd421dadba8064d4148be185cc5c
    Reviewed-on: https://chromium-review.googlesource.com/c/1332830
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607506}

    Changed files

    • DEPS
  57. AXSelection: Strengthened table test

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 06:15:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d1d3e69de3156b8b0280ce60df2644ef451677d

    Comments

    AXSelection: Strengthened table test
    
    I tried hard, but I wasn't able to make non-text positions work inside a table.
    The DOM parser collects all the non-white space text nodes between the table cells and places them in a single text node before the table element.
    This is not part of the accessibility code, but is how the DOM parser works.
    The alternative, which I implemented in this patch, is to enhance the table test by adding more selections inside text nodes.
    <table>
      ^<tr>
        <td>column</td>
      </tr>|
    </table>
    Becomes in the DOM tree:
    Body
    ++#Text "\n^|\n"
    ++Table
    ++++Tr
    ++++++Td
    
    R=dmazzoni@chromium.org
    
    Change-Id: I99c4a1f14805f9a0ba4addbaaff9bad1b1a0b86b
    Reviewed-on: https://chromium-review.googlesource.com/c/1332728
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607505}

    Changed files

    • third_party/blink/renderer/modules/accessibility/testing/data/selection/table-ax.txt
    • third_party/blink/renderer/modules/accessibility/testing/data/selection/table.html
  58. Update V8 to version 7.2.308.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 06:08:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03a083db9134dd3c4c77e62c998d8a042fa777e5

    Comments

    Update V8 to version 7.2.308.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/24bad97f..eb9d3fbd
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I58bae19089f736c8f54d96929b3a53f0eb10b0a1
    Reviewed-on: https://chromium-review.googlesource.com/c/1333125
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607504}

    Changed files

    • DEPS
  59. Rename ScrollCustomization namepsace to scroll_customization

    Changed by Zhuoyu Qian - zhuoyu.qianohnoyoudont@samsung.com
    Changed at Tuesday, 13-Nov-18 05:46:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc997fc5403f4580118176a906f50ad5c8f4b19a

    Comments

    Rename ScrollCustomization namepsace to scroll_customization
    
    https://google.github.io/styleguide/cppguide.html#Namespace_Names
    > Namespace names are all lower-case.
    
    This CL has no behavior changes.
    
    Bug: 889726
    Change-Id: I4a8be4dff14b6921cc2fb04eb34594f759c545df
    Reviewed-on: https://chromium-review.googlesource.com/c/1333168
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#607503}

    Changed files

    • third_party/blink/renderer/core/css/css_primitive_value_mappings.h
    • third_party/blink/renderer/core/css/css_properties.json5
    • third_party/blink/renderer/core/css/properties/computed_style_utils.cc
    • third_party/blink/renderer/core/css/properties/computed_style_utils.h
    • third_party/blink/renderer/core/dom/node.cc
    • third_party/blink/renderer/core/dom/node.h
    • third_party/blink/renderer/core/input/scroll_manager.cc
    • third_party/blink/renderer/core/scroll/scroll_customization.cc
    • third_party/blink/renderer/core/scroll/scroll_customization.h
    • third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
  60. Roll src/third_party/angle 0b18583285cb..cd47a379f960 (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 05:42:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e449edb49bf9919fae21c11caf53926753e85d0

    Comments

    Roll src/third_party/angle 0b18583285cb..cd47a379f960 (5 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/0b18583285cb..cd47a379f960
    
    
    git log 0b18583285cb..cd47a379f960 --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 jie.a.chen@intel.com Add SH_INIT_SHARED_VARIABLES flag
    2018-11-12 timvp@google.com Fix failing dEQP EGL tests.
    2018-11-12 jmadill@chromium.org Whitespace change to cq.cfg.
    2018-11-12 jmadill@chromium.org Add missing refs.cfg.
    2018-11-12 jmadill@chromium.org Whitespace change to cq.cfg.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@cd47a379f960
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:898030,chromium:833848,chromium:833848,chromium:833848
    TBR=cwallez@chromium.org
    
    Change-Id: I5b67d20c08fdeb6614bca9c7e0f451988f836d27
    Reviewed-on: https://chromium-review.googlesource.com/c/1333054
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607502}

    Changed files

    • DEPS
  61. Avoid requesting the Drive mount path if Drive is disabled.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 05:40:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2e2e140716353c164101a166eb0e5100e88eb5a2

    Comments

    Avoid requesting the Drive mount path if Drive is disabled.
    
    Guest mode profiles do not have a valid account ID key so requesting
    their DriveFS path is invalid. Such accounts never have Drive enabled
    and the downloads path should not be within Drive if disabled.
    
    Update DriveIntegrationService to avoid paths within Drive when
    disabling Drive with DriveFS enabled so the above assumption is valid
    with DriveFS enabled.
    
    Bug: 904558
    Change-Id: Ic8b64609f3657feae4b1f289e3726a51a871b36c
    Reviewed-on: https://chromium-review.googlesource.com/c/1333091
    Reviewed-by: Sergei Datsenko <dats@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607501}

    Changed files

    • chrome/browser/chromeos/drive/drive_integration_service.cc
    • chrome/browser/chromeos/drive/drive_integration_service.h
    • chrome/browser/chromeos/file_manager/path_util.cc
    • chrome/browser/chromeos/file_manager/path_util_unittest.cc