Home | Search | chromium - Builders
Login

Builder Windows deterministic Build 10679 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisione826ee9592541ae9d53fd23c51761adf9df17cfc
Got Revisione826ee9592541ae9d53fd23c51761adf9df17cfc

Execution:

Steps and Logfiles:

Show:
  1. ( 393 ms ) setup_build
    running recipe: "swarming/deterministic_build"
  2. ( 7 mins 53 secs ) bot_update
    [116GB/299GB used (38%)]
  3. ( 377 ms ) clobber
  4. ( 38 secs ) gclient runhooks
  5. ( 545 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  6. ( 3 mins 7 secs ) generate_build_files
  7. ( 23 mins 3 secs ) First build
  8. ( 1 mins 27 secs ) First build confirm no-op
  9. ( 9 mins 22 secs ) isolate tests
  10. ( 541 ms ) clobber (2)
  11. ( 44 secs ) gclient runhooks (2)
  12. ( 640 ms ) lookup GN args (2)
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  13. ( 3 mins 7 secs ) generate_build_files (2)
  14. ( 16 mins 46 secs ) Second build
  15. ( 1 mins 30 secs ) Second build confirm no-op
  16. ( 9 mins 31 secs ) isolate tests (2)
  17. ( 21 mins 46 secs ) compare_build_artifacts
  18. ( 1 mins 35 secs ) create tarball
  19. ( 10 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2173-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541774387518670, "id": "8930326095792168096", "project": "chromium", "tags": ["builder:Windows deterministic", "buildset:commit/git/e826ee9592541ae9d53fd23c51761adf9df17cfc", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e826ee9592541ae9d53fd23c51761adf9df17cfc", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095756157919163424", "scheduler_job_id:chromium/Windows deterministic", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Windows deterministic" setup_build
buildnumber 10679 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "swarming/deterministic_build" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "e826ee9592541ae9d53fd23c51761adf9df17cfc" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "e826ee9592541ae9d53fd23c51761adf9df17cfc" bot_update
got_revision_cp "refs/heads/master@{#606833}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {"accessibility_unittests": "f43cced06182705f0cc237269579e1867792fd53", "angle_end2end_tests": "24734c5a9de2600a1e5167d0ca1a27964475e544", "angle_perftests": "e7923f58ec381b783d813664a70909237d792e03", "angle_unittests": "8ba4720a99e0dfc3052ae607d5ffc35a47ac6596", "angle_white_box_tests": "8404a13eedffbffc2c009deb425cb15debb8c5c6", "app_shell_unittests": "6236f961b0b27e471180ae507f7ee1e65563123e", "aura_unittests": "34b598c57f75629ec6f96db8d8e8d5fa97fdb4c6", "base_perftests": "2bf5199ec4e7074a5a9ee4ed4e92f7654fe824ec", "base_unittests": "66607e85d0966956a87259f3a0346ada8039c41f", "blink_common_unittests": "d8dda52d30d36fe7f7e723ce597794e822b55d57", "blink_fuzzer_unittests": "a2012aa288c45ce3fb3482735b68219ca64afba3", "blink_heap_unittests": "7ce0efe65b9afe3e7e13a7f70bdc1d5c1f46914d", "blink_platform_unittests": "b56c3fae6d5a597af9d4ce135777563759e6fef3", "boringssl_crypto_tests": "45a848975b66488b4d587fce669e8e4c7ccf4276", "boringssl_ssl_tests": "0b5b1840ed3cab210cfb36ad08064d33d52d31f8", "browser_tests": "4b1797511ab3799eb913f2b5a9754318e7d9f2e1", "cacheinvalidation_unittests": "d7ae79261790a4a4fa9598243ee8c0a453ba43d9", "capture_unittests": "d17dd6a5d9870d3f29aae948f42b102d69a52686", "cast_unittests": "d7294894b30c838579acbdc4aea8c6cb4e12d0ce", "cc_unittests": "c75b5ca06226849db9e90dd8609d4baa2a74eb0f", "chrome_app_unittests": "102c8123c1d5e6dce5f23d6eb4194b653442ede9", "chrome_cleaner_unittests": "7605ab7babf6d55a80ad94800e810d1ad2e7d3c1", "chrome_elf_import_unittests": "cd972e92b397563347035b8b0102970adff15f00", "chrome_elf_unittests": "42fdf9c5333ea44f2bb7f1e6403e4ea7c18ba16b", "chromedriver_py_tests": "6a51e7a56f61d38931e077c05dabfdca05542e4c", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "276dfcd1f158e7318d1ff82386a126b81db84165", "command_buffer_perftests": "7a4a2155b499ace9ad727c47259580cc7549b9ff", "components_browsertests": "b6fd1206dbd73ff75f3acdd640ef6cbc43c1962f", "components_perftests": "a6b1b01e751afbe69f461b3b9ada472cd75eda06", "components_unittests": "b94eed43f01994c38ab42c3394322c2a2802a854", "compositor_unittests": "e8b4b305b8e798f7d5d10cab91c838555ab166ad", "content_browsertests": "239f012cdf3741f82c9615cfaa02543ded65b033", "content_shell_crash_test": "fee6d5e7e4a619da302ba2934d597c647cb1e913", "content_unittests": "cd671e0d90e60eaf71bac911704537aee3f8d3f3", "courgette_unittests": "e5fe19538fd90f0f257bcad8ae763499efe9374a", "crashpad_tests": "38b1225d2da7787e21215b12fd8bf2432c569ecd", "cronet_tests": "7f7645a8a693acc82fccd56209ea62e5ba3e523a", "cronet_unittests": "583f5d6e68cdded20bac95b0a663049b0ff34220", "crypto_unittests": "201c293d20dee0ae8c9c2e4909f0054758cb9ced", "device_unittests": "0221e94ebde322a874c2627bd5274ba2ffc28193", "devtools_closure_compile": "0a97b0b32bfb2d1df23592728e6cd59c33470d6c", "display_unittests": "a2c610b0e760d74787fe78da50414e0df11b9187", "elevation_service_unittests": "5c6f4b64ffc6442ade13d5dd2984ae8667338e75", "events_unittests": "e8cd1c60343ad5720a79cf7218ec1a6dc045ed04", "extensions_browsertests": "7f9fb067d4a38504cc1d20b3a5be34b4264e26d2", "extensions_unittests": "3b2c01f9de12073b71d3fd10829c6d33987b0ccf", "filesystem_service_unittests": "754fe0ccdcf9450ef4c027599874e326e706dbcd", "gcm_unit_tests": "d1ab3df5c64b36bbf5b935c94336cad5644488f6", "gcp_unittests": "22935630b5a287db46cb8e30541e5a814a7beae0", "gfx_unittests": "deadda01a2b70e1d45a7fa47cd8102372e2a4d18", "gin_unittests": "552ff17a4e0c2305ef727dafd0b6938a89474b41", "gl_tests": "316090ca35651d574f50fdc02f7b464dcac6509b", "gl_unittests": "42f19256c9c45fa842b38ba48cd7a8d5e7d0c9c3", "gl_unittests_ozone": "42f19256c9c45fa842b38ba48cd7a8d5e7d0c9c3", "gles2_conform_test": "5c3c07c0ed5c80d9caff93effaf4d84f7659f258", "google_apis_unittests": "2d8ba1d6328771be0aef70a28dafa822d4692dfb", "gpu_perftests": "d4e4d17026e215881450fb20ca57f86843e04832", "gpu_unittests": "4a46d470c7c129d563b8f1dec9ce36ba7ca22177", "headless_browsertests": "257b2fb595e857270406a56e68a2244d44e7dc95", "headless_unittests": "0723295b6392004700ac431ae245c9a0034b44a8", "install_static_unittests": "71fd22051f3df7feb7774a07670562ee83e9809f", "installer_util_unittests": "0b16ef9bade85add496fb6bb736f430a4fee7301", "interactive_ui_tests": "869335f813fc341d7b1c730e2f4b509d48163ebb", "ipc_tests": "f8f0e84911f31bbab6e6467c047e2ba68572ee26", "jingle_unittests": "06aa8e63b386643edebc15fe56cb7113b07754ac", "latency_unittests": "d0d67064482d41d6120f2776f59a81d9e1a3700d", "leveldb_service_unittests": "00acfc063e42f72a025b868d42aecd7e3051fc04", "libjingle_xmpp_unittests": "7abc88696e4c12b9d4638753616a04498bbb03e0", "load_library_perf_tests": "b2be66acd62e020395868e1456bfd6b396e79bfa", "media_blink_unittests": "9bc89c58318c5c94b666a68d28ed9fc88aebc379", "media_perftests": "11ecb0ac1b0856ba9b45746cda05aa265aff7d9e", "media_service_unittests": "93b715304ef912f690468f40390a3b10ded657f8", "media_unittests": "3a67feea719819f9a498f0cf91855bdd78ca347c", "message_center_unittests": "987063d201afe2d8aa1f66461dec2260057049e6", "metrics_python_tests": "e752064845c425b315bbbf6f4006b9307b4aa2dc", "midi_unittests": "7e9e7f6da21c9bfef354ddea52731de18b7a62a4", "mini_installer_tests": "1e1b5ff23e19b10083f354ce362b2acd16a14591", "mojo_core_unittests": "2165e27570f94b69192333dd23e80553d0c7505c", "mojo_unittests": "b7c832b62973f6dc8d9ccb6043ade7613b7fb788", "nacl_loader_unittests": "08b2aaa54ccba1aa0bda1826783bd82cea3e9b02", "native_theme_unittests": "a34f050fc2b7fba096c446c4df85407607eaed7d", "net_perftests": "465bdfd337cd8ed5309ba9e4b5139c7426cf1a36", "net_unittests": "14774f3dec3dc35963307f89d26b9c5db8a305c3", "notification_helper_unittests": "ebf8f9c1d017258cfef3500cb76e1e20ea268d7b", "pdf_unittests": "b43a55226eb4ac282840caa750dfcb775b715f4d", "performance_browser_tests": "5660c6a2e104dc96d3f9f581c9a387111723426d", "performance_test_suite": "8ac360be7763e318f67539957e2ac95e1cea13a1", "performance_webview_test_suite": "653c905126113ca204e4f38455ec9e0fb476d395", "ppapi_unittests": "d0aa7d7b7af06c34544cd88bf330873340ae458a", "printing_unittests": "1af5779c790d10af564ea4aa594601d25b9bac4d", "remoting_unittests": "1c8dbd950cef258bd89ad9b6a73e15538ed35903", "sbox_integration_tests": "fe29e98cf0292318ae86d4fa8fa9ea3cf8eb2a97", "sbox_unittests": "0961bc4c19c0fdbcadae5bfd39ec0854c229e97e", "sbox_validation_tests": "0554c2c56db46058643c05b8c402f4ed1cf76936", "service_manager_unittests": "5fc1acc90a699f642567bc51ce1ac32bd5d78c6c", "services_unittests": "f1679fe26f6c3dfc9714efeafe33b7961f0ecee4", "setup_unittests": "67bc4a0bb9ef872a4f13c70503323f97bf687078", "shell_dialogs_unittests": "81b73401f0df1384e1db85a112a52244345942b9", "skia_unittests": "05d08a11fe7f565f6a1e5f88c8d2092b68f6cb6f", "snapshot_unittests": "09bd5c3bb096f5276249630d90506c2496c9f2df", "sql_unittests": "f203c7646dbb8a522c52c37a4d3511f481bcaa89", "storage_unittests": "2f8f2874184102d9555b24745eca6c23b2162d7e", "swiftshader_unittests": "7af73a962bee33bcae0e81f85a7ada05d30dccc8", "sync_integration_tests": "469a44063631ee8006369a15e08935ca5eea3f9c", "telemetry_gpu_integration_test": "67a0425814f47c1b8b3f96c5dfddcdbfa8e77cfe", "telemetry_gpu_unittests": "5ff733d11786f3664a45d00d28cf29bd90398e8e", "telemetry_perf_tests_without_chrome": "faacf64d71f7c9de5f6f75981cf648e427d9bb32", "telemetry_perf_unittests": "db70c86b7f7895623de6baaf53311e221469a1a5", "telemetry_unittests": "91ae8642e480063fff382786dcf4dea65bcb2c71", "tracing_perftests": "0984c9570f658cb207c962b1c63491a2772456f4", "traffic_annotation_auditor_unittests": "308f6fcbc5dd2d7d55368188aaa30e07c74cbede", "ui_base_unittests": "1cec7704d620eccbeb820e74af924060a12ffab1", "ui_touch_selection_unittests": "df936b676cac58cef36d33c7f96c5e9e602469de", "unit_tests": "f66bcd8f335d0b9a53adc4b659b7d16384cef67a", "url_unittests": "e7878506c99e14cb95a8cd35d9c391acab3ee215", "video_decode_accelerator_unittest": "5794570f12bd21479f548c5dc04babc56d772882", "views_mus_interactive_ui_tests": "c45aea1730728842d3f9dc004aaa6f78d6cd4c5f", "views_mus_unittests": "57656b28f5ed5d5381888ac23db6b0b4409171d9", "views_perftests": "736d3239f783b6c0035c37ed476296c125775452", "views_unittests": "73e74cadd2fdfa34b0d44ee95b71ef1bfe7ad54e", "viz_unittests": "bf46d3935d02d7aefc1c93bca5bf72389ddfbd3d", "vr_common_perftests": "b0c6115ad3e41e5fdeb4119624e5b2f77021fd8d", "vr_common_unittests": "886c9b2bde43ebf991052621b1100571d5c8e702", "vr_pixeltests": "8abcfff02dd679014837276a4ffb31a3fef2fdeb", "webkit_layout_tests": "d7b9febc0f3a7add4e0d1c9ffd00821b0905dfd2", "webkit_layout_tests_exparchive": "967a053d6cb3102c637aad816ec2629701de03c9", "webkit_python_tests": "5f3540816053b99043f7c9bb9159b6e0297ab93e", "webkit_unit_tests": "b8fa661bbcbe8a55c33dc1e4a4b81c532ba3f4c3", "wm_unittests": "bf030804d87b50ea7fa0eb7602926bd3a48e77dc", "wtf_unittests": "cecc6981701a334dd72d4811c9dd4d400de6ea68", "zucchini_unittests": "73e0963785fde5ea538da96ab67b55560c30e256"} isolate tests
swarm_hashes {"accessibility_unittests": "f43cced06182705f0cc237269579e1867792fd53", "angle_end2end_tests": "24734c5a9de2600a1e5167d0ca1a27964475e544", "angle_perftests": "e7923f58ec381b783d813664a70909237d792e03", "angle_unittests": "8ba4720a99e0dfc3052ae607d5ffc35a47ac6596", "angle_white_box_tests": "8404a13eedffbffc2c009deb425cb15debb8c5c6", "app_shell_unittests": "6236f961b0b27e471180ae507f7ee1e65563123e", "aura_unittests": "34b598c57f75629ec6f96db8d8e8d5fa97fdb4c6", "base_perftests": "2bf5199ec4e7074a5a9ee4ed4e92f7654fe824ec", "base_unittests": "66607e85d0966956a87259f3a0346ada8039c41f", "blink_common_unittests": "d8dda52d30d36fe7f7e723ce597794e822b55d57", "blink_fuzzer_unittests": "a2012aa288c45ce3fb3482735b68219ca64afba3", "blink_heap_unittests": "7ce0efe65b9afe3e7e13a7f70bdc1d5c1f46914d", "blink_platform_unittests": "b56c3fae6d5a597af9d4ce135777563759e6fef3", "boringssl_crypto_tests": "45a848975b66488b4d587fce669e8e4c7ccf4276", "boringssl_ssl_tests": "0b5b1840ed3cab210cfb36ad08064d33d52d31f8", "browser_tests": "4b1797511ab3799eb913f2b5a9754318e7d9f2e1", "cacheinvalidation_unittests": "d7ae79261790a4a4fa9598243ee8c0a453ba43d9", "capture_unittests": "d17dd6a5d9870d3f29aae948f42b102d69a52686", "cast_unittests": "d7294894b30c838579acbdc4aea8c6cb4e12d0ce", "cc_unittests": "c75b5ca06226849db9e90dd8609d4baa2a74eb0f", "chrome_app_unittests": "102c8123c1d5e6dce5f23d6eb4194b653442ede9", "chrome_cleaner_unittests": "7605ab7babf6d55a80ad94800e810d1ad2e7d3c1", "chrome_elf_import_unittests": "cd972e92b397563347035b8b0102970adff15f00", "chrome_elf_unittests": "42fdf9c5333ea44f2bb7f1e6403e4ea7c18ba16b", "chromedriver_py_tests": "6a51e7a56f61d38931e077c05dabfdca05542e4c", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "276dfcd1f158e7318d1ff82386a126b81db84165", "command_buffer_perftests": "7a4a2155b499ace9ad727c47259580cc7549b9ff", "components_browsertests": "b6fd1206dbd73ff75f3acdd640ef6cbc43c1962f", "components_perftests": "a6b1b01e751afbe69f461b3b9ada472cd75eda06", "components_unittests": "b94eed43f01994c38ab42c3394322c2a2802a854", "compositor_unittests": "e8b4b305b8e798f7d5d10cab91c838555ab166ad", "content_browsertests": "239f012cdf3741f82c9615cfaa02543ded65b033", "content_shell_crash_test": "fee6d5e7e4a619da302ba2934d597c647cb1e913", "content_unittests": "cd671e0d90e60eaf71bac911704537aee3f8d3f3", "courgette_unittests": "e5fe19538fd90f0f257bcad8ae763499efe9374a", "crashpad_tests": "38b1225d2da7787e21215b12fd8bf2432c569ecd", "cronet_tests": "7f7645a8a693acc82fccd56209ea62e5ba3e523a", "cronet_unittests": "583f5d6e68cdded20bac95b0a663049b0ff34220", "crypto_unittests": "201c293d20dee0ae8c9c2e4909f0054758cb9ced", "device_unittests": "0221e94ebde322a874c2627bd5274ba2ffc28193", "devtools_closure_compile": "0a97b0b32bfb2d1df23592728e6cd59c33470d6c", "display_unittests": "a2c610b0e760d74787fe78da50414e0df11b9187", "elevation_service_unittests": "5c6f4b64ffc6442ade13d5dd2984ae8667338e75", "events_unittests": "e8cd1c60343ad5720a79cf7218ec1a6dc045ed04", "extensions_browsertests": "7f9fb067d4a38504cc1d20b3a5be34b4264e26d2", "extensions_unittests": "3b2c01f9de12073b71d3fd10829c6d33987b0ccf", "filesystem_service_unittests": "754fe0ccdcf9450ef4c027599874e326e706dbcd", "gcm_unit_tests": "d1ab3df5c64b36bbf5b935c94336cad5644488f6", "gcp_unittests": "22935630b5a287db46cb8e30541e5a814a7beae0", "gfx_unittests": "deadda01a2b70e1d45a7fa47cd8102372e2a4d18", "gin_unittests": "552ff17a4e0c2305ef727dafd0b6938a89474b41", "gl_tests": "316090ca35651d574f50fdc02f7b464dcac6509b", "gl_unittests": "42f19256c9c45fa842b38ba48cd7a8d5e7d0c9c3", "gl_unittests_ozone": "42f19256c9c45fa842b38ba48cd7a8d5e7d0c9c3", "gles2_conform_test": "5c3c07c0ed5c80d9caff93effaf4d84f7659f258", "google_apis_unittests": "2d8ba1d6328771be0aef70a28dafa822d4692dfb", "gpu_perftests": "d4e4d17026e215881450fb20ca57f86843e04832", "gpu_unittests": "4a46d470c7c129d563b8f1dec9ce36ba7ca22177", "headless_browsertests": "257b2fb595e857270406a56e68a2244d44e7dc95", "headless_unittests": "0723295b6392004700ac431ae245c9a0034b44a8", "install_static_unittests": "71fd22051f3df7feb7774a07670562ee83e9809f", "installer_util_unittests": "0b16ef9bade85add496fb6bb736f430a4fee7301", "interactive_ui_tests": "869335f813fc341d7b1c730e2f4b509d48163ebb", "ipc_tests": "f8f0e84911f31bbab6e6467c047e2ba68572ee26", "jingle_unittests": "06aa8e63b386643edebc15fe56cb7113b07754ac", "latency_unittests": "d0d67064482d41d6120f2776f59a81d9e1a3700d", "leveldb_service_unittests": "00acfc063e42f72a025b868d42aecd7e3051fc04", "libjingle_xmpp_unittests": "7abc88696e4c12b9d4638753616a04498bbb03e0", "load_library_perf_tests": "b2be66acd62e020395868e1456bfd6b396e79bfa", "media_blink_unittests": "9bc89c58318c5c94b666a68d28ed9fc88aebc379", "media_perftests": "11ecb0ac1b0856ba9b45746cda05aa265aff7d9e", "media_service_unittests": "93b715304ef912f690468f40390a3b10ded657f8", "media_unittests": "3a67feea719819f9a498f0cf91855bdd78ca347c", "message_center_unittests": "987063d201afe2d8aa1f66461dec2260057049e6", "metrics_python_tests": "e752064845c425b315bbbf6f4006b9307b4aa2dc", "midi_unittests": "7e9e7f6da21c9bfef354ddea52731de18b7a62a4", "mini_installer_tests": "45a5370c68e335d6643b488a5d24116d9734a7c5", "mojo_core_unittests": "2165e27570f94b69192333dd23e80553d0c7505c", "mojo_unittests": "b7c832b62973f6dc8d9ccb6043ade7613b7fb788", "nacl_loader_unittests": "08b2aaa54ccba1aa0bda1826783bd82cea3e9b02", "native_theme_unittests": "a34f050fc2b7fba096c446c4df85407607eaed7d", "net_perftests": "465bdfd337cd8ed5309ba9e4b5139c7426cf1a36", "net_unittests": "14774f3dec3dc35963307f89d26b9c5db8a305c3", "notification_helper_unittests": "ebf8f9c1d017258cfef3500cb76e1e20ea268d7b", "pdf_unittests": "b43a55226eb4ac282840caa750dfcb775b715f4d", "performance_browser_tests": "5660c6a2e104dc96d3f9f581c9a387111723426d", "performance_test_suite": "8ac360be7763e318f67539957e2ac95e1cea13a1", "performance_webview_test_suite": "653c905126113ca204e4f38455ec9e0fb476d395", "ppapi_unittests": "d0aa7d7b7af06c34544cd88bf330873340ae458a", "printing_unittests": "1af5779c790d10af564ea4aa594601d25b9bac4d", "remoting_unittests": "1c8dbd950cef258bd89ad9b6a73e15538ed35903", "sbox_integration_tests": "fe29e98cf0292318ae86d4fa8fa9ea3cf8eb2a97", "sbox_unittests": "0961bc4c19c0fdbcadae5bfd39ec0854c229e97e", "sbox_validation_tests": "0554c2c56db46058643c05b8c402f4ed1cf76936", "service_manager_unittests": "5fc1acc90a699f642567bc51ce1ac32bd5d78c6c", "services_unittests": "f1679fe26f6c3dfc9714efeafe33b7961f0ecee4", "setup_unittests": "67bc4a0bb9ef872a4f13c70503323f97bf687078", "shell_dialogs_unittests": "81b73401f0df1384e1db85a112a52244345942b9", "skia_unittests": "05d08a11fe7f565f6a1e5f88c8d2092b68f6cb6f", "snapshot_unittests": "09bd5c3bb096f5276249630d90506c2496c9f2df", "sql_unittests": "f203c7646dbb8a522c52c37a4d3511f481bcaa89", "storage_unittests": "2f8f2874184102d9555b24745eca6c23b2162d7e", "swiftshader_unittests": "7af73a962bee33bcae0e81f85a7ada05d30dccc8", "sync_integration_tests": "469a44063631ee8006369a15e08935ca5eea3f9c", "telemetry_gpu_integration_test": "67a0425814f47c1b8b3f96c5dfddcdbfa8e77cfe", "telemetry_gpu_unittests": "5ff733d11786f3664a45d00d28cf29bd90398e8e", "telemetry_perf_tests_without_chrome": "faacf64d71f7c9de5f6f75981cf648e427d9bb32", "telemetry_perf_unittests": "db70c86b7f7895623de6baaf53311e221469a1a5", "telemetry_unittests": "91ae8642e480063fff382786dcf4dea65bcb2c71", "tracing_perftests": "0984c9570f658cb207c962b1c63491a2772456f4", "traffic_annotation_auditor_unittests": "308f6fcbc5dd2d7d55368188aaa30e07c74cbede", "ui_base_unittests": "1cec7704d620eccbeb820e74af924060a12ffab1", "ui_touch_selection_unittests": "df936b676cac58cef36d33c7f96c5e9e602469de", "unit_tests": "f66bcd8f335d0b9a53adc4b659b7d16384cef67a", "url_unittests": "e7878506c99e14cb95a8cd35d9c391acab3ee215", "video_decode_accelerator_unittest": "5794570f12bd21479f548c5dc04babc56d772882", "views_mus_interactive_ui_tests": "c45aea1730728842d3f9dc004aaa6f78d6cd4c5f", "views_mus_unittests": "57656b28f5ed5d5381888ac23db6b0b4409171d9", "views_perftests": "736d3239f783b6c0035c37ed476296c125775452", "views_unittests": "73e74cadd2fdfa34b0d44ee95b71ef1bfe7ad54e", "viz_unittests": "bf46d3935d02d7aefc1c93bca5bf72389ddfbd3d", "vr_common_perftests": "b0c6115ad3e41e5fdeb4119624e5b2f77021fd8d", "vr_common_unittests": "886c9b2bde43ebf991052621b1100571d5c8e702", "vr_pixeltests": "8abcfff02dd679014837276a4ffb31a3fef2fdeb", "webkit_layout_tests": "d7b9febc0f3a7add4e0d1c9ffd00821b0905dfd2", "webkit_layout_tests_exparchive": "967a053d6cb3102c637aad816ec2629701de03c9", "webkit_python_tests": "5f3540816053b99043f7c9bb9159b6e0297ab93e", "webkit_unit_tests": "b8fa661bbcbe8a55c33dc1e4a4b81c532ba3f4c3", "wm_unittests": "bf030804d87b50ea7fa0eb7602926bd3a48e77dc", "wtf_unittests": "cecc6981701a334dd72d4811c9dd4d400de6ea68", "zucchini_unittests": "73e0963785fde5ea538da96ab67b55560c30e256"} isolate tests (2)

Blamelist:

  1. Sigurdur Asgeirsson (siggiohnoyoudont@chromium.org)
  2. Mike Reed (reedohnoyoudont@google.com)
  3. Marc Treib (treibohnoyoudont@chromium.org)
  4. Marc Treib (treibohnoyoudont@chromium.org)
  5. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  6. Leonard Grey (lgreyohnoyoudont@chromium.org)
  7. Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
  8. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  9. Mark Cogan (marqohnoyoudont@google.com)
  10. gogerald (gogeraldohnoyoudont@google.com)
  11. Clemens Arbesser (arbesserohnoyoudont@google.com)
  12. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  13. Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
  14. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  15. Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
  16. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  17. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  18. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  20. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  21. Michael Lippautz (mlippautzohnoyoudont@chromium.org)
  22. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  23. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  24. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  25. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  26. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  27. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  28. Colin Blundell (blundellohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 14:39:47 UTC
Start Friday, 09-Nov-18 14:39:48 UTC
End Friday, 09-Nov-18 16:49:54 UTC
Pending 1 secs
Execution 2 hrs 10 mins

All Changes:

  1. RC: Compress all chrome://discards resources.

    Changed by Sigurdur Asgeirsson - siggiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:35:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e826ee9592541ae9d53fd23c51761adf9df17cfc

    Comments

    RC: Compress all chrome://discards resources.
    
    I don't know whether to trust these numbers, but this is what I see
    for my local Windows release 32 bit build.
    
    Uncompressed:
    3,034,139 browser_resources.pak
    233,038,336 mini_installer.exe
    
    Compressed:
    2,869,382 browser_resources.pak
    232,873,472 mini_installer.exe
    
    Bug: 891310
    Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822
    Reviewed-on: https://chromium-review.googlesource.com/c/1327406
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606833}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/ui/webui/discards/discards_ui.cc
  2. use SkFontHinting

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf

    Comments

    use SkFontHinting
    
    Bug: skia:2664
    Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205
    Reviewed-on: https://chromium-review.googlesource.com/c/1318416
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606832}

    Changed files

    • cc/paint/oop_pixeltest.cc
    • cc/paint/paint_flags.cc
    • cc/paint/paint_flags.h
    • chrome/renderer/pepper/pepper_flash_renderer_host.cc
    • content/renderer/render_view_fuchsia.cc
    • content/renderer/render_view_linux.cc
    • skia/config/SkUserConfig.h
    • third_party/blink/public/platform/web_font_render_style.h
    • third_party/blink/renderer/platform/fonts/font_metrics.cc
    • third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
    • third_party/blink/renderer/platform/fonts/web_font_render_style.cc
    • third_party/blink/renderer/platform/graphics/logging_canvas.cc
  3. PersonalDataManager: Rename AccountStorageForServer(Cards->Data)

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41c87263ae4560b264e15ec45be4832be2e79e86

    Comments

    PersonalDataManager: Rename AccountStorageForServer(Cards->Data)
    
    The account storage is now used for both server cards and server
    addresses.
    
    Bug: 864519
    Change-Id: Ia5fb5ebc4bd4e334b162378923ccd04562d4cac9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329241
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606831}

    Changed files

    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
  4. PersonalDataManager: Store server (aka Wallet) addresses in the Server DB

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 274ab9c5685ffb50c277a68979c46b4abf9c9455

    Comments

    PersonalDataManager: Store server (aka Wallet) addresses in the Server DB
    
    Currently, this makes no functional difference: In full Sync mode, the
    local DB and the server DB are the same thing anyway, and in
    lightweight/Butter mode, we don't store server addresses at all.
    However,
    1) this change will unlock actually supporting Wallet addresses in
       Butter mode, and
    2) it's just less confusing if "server" things are actually stored in
       the "server" DB.
    
    Bug: 864519
    Change-Id: I4f5479faff87cfa4f7def6b98f6b2235294393b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1326492
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606830}

    Changed files

    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager_unittest.cc
  5. Ribbon: Apply values via CustomProperty.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:23:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 634f8db566f7e5401be35e6d6d98f8858a41e0d0

    Comments

    Ribbon: Apply values via CustomProperty.
    
    Instead of applying custom properties via the static Variable instance,
    use the new CustomProperty class (which knows about its name and
    registration) to apply values. This brings the custom property code path
    closer to the standard property code path.
    
    To assist CSSPropertyRef in producing a CSSProperty&, this CL adds the
    class CSSPropertyName. The idea is that CSSPropertyName can be used instead
    of CSSPropertyID/AtomicString where both standard and custom properties are
    expected. My intent is to store a CSSPropertyName in
    CSSPropertyValueMetadata (instead of the CSSProperty*), but this is a big
    change, as everything that creates property/value pairs must carry the
    CSSPropertyName. So, for now PropertyReference.Name() is faking it by
    digging the name out of the associated CSSValue.
    
    Note that CSSPropertyName::ToAtomicString intentionally does not return
    a const AtomicString&. This is because 1) I want to try and reduce the
    size of CSSPropertyName to one pointer, which means it will contain a
    StringImpl* rather than an AtomicString, and 2) I want CSSPropertyName to
    be something that can be passed to other threads if needed, which again
    means StringImpl* (or String, at least) rather than AtomicString.
    
    In general, this CL is a step on the path to achieve these things:
    
     1. Removing the useless and dangerous static Variable instance.
     2. Not having to piggy-back the custom property name in a CSSValue.
     3. Not having to smuggle initial/inherit/unset via the
        CSSCustomPropertyDeclaration (vs. applying CSSIdentifierValues
        holding these values, like civilized individuals).
    
    R=flackr@chromium.org, futhark@chromium.org
    
    Change-Id: I1a062138fc86c5a398542ac147bf9d71feed7b3c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323113
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606829}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/animation/css_default_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_var_cycle_interpolation_type.cc
    • third_party/blink/renderer/core/animation/property_handle.h
    • third_party/blink/renderer/core/animation/property_handle_test.cc
    • third_party/blink/renderer/core/css/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_name.cc
    • third_party/blink/renderer/core/css/css_property_name.h
    • third_party/blink/renderer/core/css/css_property_name_test.cc
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/properties/css_property_ref.cc
    • third_party/blink/renderer/core/css/properties/css_property_ref.h
    • third_party/blink/renderer/core/css/properties/css_property_ref_test.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.h
    • third_party/blink/renderer/core/css/properties/longhands/variable.cc
    • third_party/blink/renderer/core/css/properties/longhands/variable.h
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver_test.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.h
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc
  6. Revert "Mac: Disallow dragging tab into blocked tabstrip"

    Changed by Leonard Grey - lgreyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 899b84ea267b8ce6ce522d2cf3b34453be3ac164

    Comments

    Revert "Mac: Disallow dragging tab into blocked tabstrip"
    
    This reverts commit 002dfaef6957632740a412c3d69af0913536e1dd.
    
    Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=903706#c1
    
    Original change's description:
    > Mac: Disallow dragging tab into blocked tabstrip
    > 
    > This is a really longwinded way for me to fix some NOTIMPLEMENTED spam,
    > though I'm pretty sure the thing that happens right now when you open
    > a certificate prompt and drag a tab into the parent window is bad.
    > 
    > This introduces a new method because we're not sure if it matches the
    > Aura semantics, and this is better than the nothing we were doing previously.
    > 
    > Bug: 825834
    > Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1315956
    > Commit-Queue: Leonard Grey <lgrey@chromium.org>
    > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606619}
    
    TBR=ellyjones@chromium.org,lgrey@chromium.org
    
    Change-Id: If2a6470657f160a0e7fa2fd9978078ab46ae048a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 825834
    Reviewed-on: https://chromium-review.googlesource.com/c/1329341
    Reviewed-by: Leonard Grey <lgrey@chromium.org>
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606828}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/tabs/tab_drag_controller.h
  7. Fix h2o_junit_manifest_target_name on the bots

    Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a996f2946740acd659f5ed757b2ae364c0168c0

    Comments

    Fix h2o_junit_manifest_target_name on the bots
    
    This CL:
    - Makes the generated AndroidManifest.xml a data dependency of
    h2o_junit_manifest_target_name
    - Reenables LaunchTest.*
    
    BUG=902325
    
    Change-Id: I47e3c5c2226c78c696716712a4307127493c5903
    Reviewed-on: https://chromium-review.googlesource.com/c/1324875
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606827}

    Changed files

    • chrome/android/webapk/shell_apk/BUILD.gn
    • chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/h2o/LaunchTest.java
  8. [Autofill Assistant] Allow clicking on links.

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:16:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74c9dc10cd643cc6eec6928ae7a8c8d364b85738

    Comments

    [Autofill Assistant] Allow clicking on links.
    
    Before this patch, navigation triggered by clicking on a link or through
    javascript (renderer-initiated navigation) was considered an end state
    for Autofill assistant.
    
    With this patch, such actions are only considered an end state if the
    page that's navigated to has no scripts. This is necessary, as such
    navigation is part of the expected flow of some scripts.
    
    Going back a page or refreshing through the UI (non renderer-initiated
    navigation) are still considered an end state with this patch.
    
    Bug: 806868
    Change-Id: I5a38a82e7edf8b34a5830130b957dfad387e1b0d
    Reviewed-on: https://chromium-review.googlesource.com/c/1329242
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606826}

    Changed files

    • components/autofill_assistant/browser/controller.cc
  9. [iOS] Decouple completion handler from new tab creation in BVC.

    Changed by Mark Cogan - marqohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:15:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c86aa454442704cbfc07d7bf5aaf6a7e301b70c

    Comments

    [iOS] Decouple completion handler from new tab creation in BVC.
    
    This CL decouples the addition of a tab completion block from the other
    tab opening code in the BVC. This will allow the tab opening logic
    (which is just tab model manipulation) to be moved out of the BVC.
    
    Bug: 903338
    Change-Id: Ibc7ba411c2cbec58dd11ac7cb65e2b9284eb811c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323558
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606825}

    Changed files

    • ios/chrome/app/application_delegate/url_opener_unittest.mm
    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/ui/browser_view_controller.h
    • ios/chrome/browser/ui/browser_view_controller.mm
  10. [Autofill Assistant] Fix tap operation and add browser tests

    Changed by gogerald - gogeraldohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:02:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c30a7925aa902990811797ff7dcd2cf89994947

    Comments

    [Autofill Assistant] Fix tap operation and add browser tests
    
    Bug: 806868
    Change-Id: I9730373e60f28b65fb515f9de42da0f6505db594
    Reviewed-on: https://chromium-review.googlesource.com/c/1324239
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606824}

    Changed files

    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
    • components/autofill_assistant/browser/web_controller_browsertest.cc
    • components/test/data/autofill_assistant/autofill_assistant_target_website.html
    • components/test/data/autofill_assistant/autofill_assistant_target_website_iframe_one.html
  11. [Autofill Assistant] Extended the amount of information available through feedback forms.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 13:57:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0eb90453d54daf47f522b220ba83dda94bba669

    Comments

    [Autofill Assistant] Extended the amount of information available through feedback forms.
    
    The stock android feedback form has an optional string field `feedbackContext', which can be used to provide extended information. Depending on when the user taps the feedback button, not all of the information may be available.
    
    Bug: 806868
    Change-Id: I5dfaaf813c48198f573f2e1fbd0d6468439d3a6c
    Reviewed-on: https://chromium-review.googlesource.com/c/1317911
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606823}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/FeedbackContext.java
    • chrome/android/java_sources.gni
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/mock_ui_controller.h
    • components/autofill_assistant/browser/script_tracker.cc
    • components/autofill_assistant/browser/script_tracker.h
    • components/autofill_assistant/browser/ui_controller.h
    • components/autofill_assistant/browser/ui_delegate.h
  12. Revert "Add resource load priority Service Worker tests"

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:57:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c01e9b4c3145dbde2c4d472ab75dd00937663981

    Comments

    Revert "Add resource load priority Service Worker tests"
    
    This reverts commit 0f0d0b74734bf82737b893d03ed334ef360f9b0b.
    
    Reason for revert: super flaky on win7_chromium_rel_ng
    
    BUG=chromium:872776
    
    Original change's description:
    > Add resource load priority Service Worker tests
    > 
    > This CL adds resource load priority tests ensuring that the priority of
    > requests that pass through a Service Worker is preserved.
    > 
    > R=​kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org
    > 
    > Bug: 872776
    > Change-Id: I74f334359b3255fcac5c13fbdb9f1e601af0f8f0
    > Reviewed-on: https://chromium-review.googlesource.com/c/1316104
    > Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
    > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606689}
    
    TBR=falken@chromium.org,kinuko@chromium.org,yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com
    
    Change-Id: I6d997795ffc64f1005ed3821799300cd3401eea9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 872776
    Reviewed-on: https://chromium-review.googlesource.com/c/1329245
    Reviewed-by: Corentin Wallez <cwallez@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606822}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/priorities/resource-load-priorities-service-worker.https-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/priorities/resource-load-priorities-service-worker.https.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/common.js
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/async-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/defer-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/fetch.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/module-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/off-screen-image.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/parser-blocking-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/prefetch.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/render-blocking-stylesheet.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/xhr.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/service-worker-get-priority.js
  13. [SPv2] Fix background invalidation on scroll

    Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:55:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 089805f4087998a3c196305ad8f13cc488bb7655

    Comments

    [SPv2] Fix background invalidation on scroll
    
    The previous early return shortcut required invalidation of fixed-attachment
    background etc.
    
    Now in PaintLayerScrollableArea::InvalidatePaintForScrollOffsetChange():
    - always invalidate for fixed-attachment background
    - correct invalidation of local-attachment background for SPv2
    - remove the SetNeedsRepaint() logic for change of existence of
      ScrollTranslation because now PaintPropertyTreeBuilder will do that
      whenever a paint property node is created or removed
    
    Bug: 529963
    Change-Id: I5c9636cb318412cf8398f305a43bc0c55b9a3fc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1308988
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606821}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/full-viewport-repaint-for-background-attachment-fixed-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll/overflow-scroll-local-background-text-color-change-expected.txt
    • third_party/WebKit/LayoutTests/paint/invalidation/scroll/repaint-during-scroll-with-zoom-expected.txt
    • third_party/blink/renderer/core/paint/box_paint_invalidator.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
    • third_party/blink/renderer/core/style/fill_layer.cc
    • third_party/blink/renderer/core/style/fill_layer.h
  14. Revert "Fix page slip issue after dragging"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:55:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a47b88e164851a0821bd9d6107b63deedb09656a

    Comments

    Revert "Fix page slip issue after dragging"
    
    This reverts commit 05e6d6110b8ee4c29a04943ac021bf59c1d62c72.
    
    Reason for revert: Breaks AppsGridViewDragTest.MouseDragMaxItemsInFolder/6 and a bunch of other tests. 
    
    ==23676==ERROR: AddressSanitizer: container-overflow on address 0x608000011e50 at pc 0x5580f7784dcd bp 0x7ffd9affb130 sp 0x7ffd9affb128
    READ of size 8 at 0x608000011e50 thread T0
        #0 0x5580f7784dcc in ViewAtBase ui/views/view_model.h:71:28
    
    See https://sheriff-o-matic.appspot.com/chromium/examine/chromium.memory.Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1).app_list_unittests.
    
    Original change's description:
    > Fix page slip issue after dragging
    > 
    > Changes:
    > Update the selected page to be the target page of dragged item at the
    > end of dragging.
    > 
    > Bug: 893832
    > Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df
    > Reviewed-on: https://chromium-review.googlesource.com/c/1324851
    > Commit-Queue: Weidong Guo <weidongg@chromium.org>
    > Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606585}
    
    TBR=newcomer@chromium.org,weidongg@chromium.org
    
    Change-Id: I4177d2e3ac6226b415b627148db211614d0b7ec4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893832
    Reviewed-on: https://chromium-review.googlesource.com/c/1329170
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606820}

    Changed files

    • ash/app_list/views/apps_grid_view.cc
  15. v8binding: Use explicitly-typed callback functions in custom elements

    Changed by Yuki Shiino - yukishiinoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:46:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f2d97b775634dcb3f099162f926af93924d29ab

    Comments

    v8binding: Use explicitly-typed callback functions in custom elements
    
    We're planning to not use cross origin ScriptStates everywhere,
    especially in IDL callback function and callback interface.
    Given that, we'd like to minimize use of ScriptState of callbacks,
    which will be nullptr in case of cross origin, so that the call sites
    of callbacks do not need to handle a SecurityError.
    
    This patch is a preparation of https://crrev.com/c/1314023 and
    removes the use of the ScriptState from custom elements.
    
    Bug: 886588, 892755
    Change-Id: I52068920b659efe119496ec092448cdc107e0631
    Reviewed-on: https://chromium-review.googlesource.com/c/1325585
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606819}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/BUILD.gn
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.cc
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.h
    • third_party/blink/renderer/bindings/scripts/v8_callback_function.py
    • third_party/blink/renderer/bindings/scripts/v8_callback_interface.py
    • third_party/blink/renderer/bindings/scripts/v8_types.py
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.h
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.h
    • third_party/blink/renderer/core/html/custom/custom_element_registry.idl
  16. DisabletestModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab.

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:41:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 496cd36004b1f6d845e66930bbbd939de4e4f5bb

    Comments

    DisabletestModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab.
    
    It is flaky. See for instance
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/121816.
    
    Bug: 903658, 903657
    Change-Id: Ic682ac60329923a35745d135d101d0eb8b61b08b
    Tbr: mdjones@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1329161
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606818}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
  17. Update V8 to version 7.2.286.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3d9d78bc2653ea749eb1719fffdd70f53cedfc6

    Comments

    Update V8 to version 7.2.286.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/6130e69e..31b2546b
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I2a2852bb93f2c67cb5e6a1f0ed39315bab81006f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329062
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606817}

    Changed files

    • DEPS
  18. [Sync::USS] Fix for counting unsyncable bookmarks when loading model

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:34:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6a54aa7e9e0d98986cdbaa84a41d1441e17ad1c

    Comments

    [Sync::USS] Fix for counting unsyncable bookmarks when loading model
    
    On every start up, the bookmarks sync metadata are compared to the
    local model to check the integrity of the persisted data.
    If the model and the metadata don't match, sync infrastructure assumes
    the metadata are corrupted and start syncing from a clean state.
    
    Before this CL:
    Unsyncable bookmarks where considered at comparison. This resulted in the
    models to always never match, and issue an initial update at every
    start up.
    
    After this CL:
    Only syncable bookmarks are considering when comparing the model
    and the metadata.
    
    This issue could be observed using the UMA metric
    Sync.ModelTypeEntityChange3.BOOKMARK
    which should how frequently the client asks for initial updates.
    Before this patch, the client was unnecessarily asking for initial
    updates at every start up, and hence resulted in huge increase in
    the bucket in REMOTE_INITIAL_UPDATE of
    Sync.ModelTypeEntityChange3.BOOKMARK
    
    Bug: 516866
    Change-Id: I61c453359c4265af09a91253f2e13139034b2a53
    Reviewed-on: https://chromium-review.googlesource.com/c/1329001
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606816}

    Changed files

    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker_unittest.cc
  19. Roll src/third_party/perfetto 486203eeaffd..606ed681f4ea (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:33:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6318418e6bff257eaf360aa0661f49f993a8f3c1

    Comments

    Roll src/third_party/perfetto 486203eeaffd..606ed681f4ea (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/486203eeaffd..606ed681f4ea
    
    
    git log 486203eeaffd..606ed681f4ea --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 treehugger-gerrit@google.com Merge "Add comment on ftrace pid"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@606ed681f4ea
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: If0bd022a39477de441941826e42f178807d978bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1329042
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606815}

    Changed files

    • DEPS
  20. Roll src-internal 73158cecda02..c458532c0628 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:29:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bde1aec4c859fd39a039a59a98da4c8b51f6f4f

    Comments

    Roll src-internal 73158cecda02..c458532c0628 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73158cecda02..c458532c0628
    
    
    Created with:
      gclient setdep -r src-internal@c458532c0628
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I8311db5f4432ad7184b609969b5a2ecd787fbe9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329041
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606814}

    Changed files

    • DEPS
  21. Revert "Enable unified garbage collections"

    Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c36eb8acab5820a2fcaefb9e856b698e3cc0ce52

    Comments

    Revert "Enable unified garbage collections"
    
    This reverts commit a8228cdc699831699180ecd3b327366305c830d2.
    
    Reason for revert: Reverting as we've cycled through the waterfalls and the other flag change on the content layer already got reverted.
    
    Original change's description:
    > Enable unified garbage collections
    > 
    > Enables unified heap garbage collection across V8 and Blink. The GC
    > computes a single transitive closure across V8's API boundary before
    > starting the separate sweepers.
    > 
    > Sheriffs: This is a dry-run of the feature and will be reverted after
    > cycling through the waterfall and performance bots.
    > 
    > Bug: 843903
    > Change-Id: I0d3e9fc76fa9b116f32d92a234c45afe11120cf9
    > Reviewed-on: https://chromium-review.googlesource.com/c/1290869
    > Reviewed-by: Hannes Payer <hpayer@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#605634}
    
    TBR=ulan@chromium.org,haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 843903
    Change-Id: I1d1f695431919864cb15dffe0d9b1e4ba85fd3c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329021
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606813}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  22. [perf] Add browse:media:youtube:2018 system_health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:09:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5ece11759649faaa791f155e7c88cc13c99d497

    Comments

    [perf] Add browse:media:youtube:2018 system_health story
    
    Due to many ads being loaded and certain requests will not work.
        [console:error:js]:       ~30
        [console:error:network]:  ~30
    
    Bug: 878390
    Change-Id: I3e09c9302514b1fb089d77b4671c59fb44afb22f
    Reviewed-on: https://chromium-review.googlesource.com/c/1296172
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606812}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_6b6bdda708.wprgo.sha1
    • tools/perf/page_sets/system_health/browsing_stories.py
  23. Disable AudioOutputDeviceTest.VerifyDataFlow.

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:01:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4dc1efff9f39f75768c64004fea6a83b7b38d71

    Comments

    Disable AudioOutputDeviceTest.VerifyDataFlow.
    
    Flakily fails like this:
    ../../media/audio/audio_output_device_unittest.cc:411: Failure
    Actual function call count doesn't match EXPECT_CALL(env.callback,
        Render(kDelay, env.time_stamp, kFramesSkipped, NotNull()))...
             Expected: to be called once
               Actual: never called - unsatisfied and active
    
    See for instance
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/
        Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30025
    
    Tbr: olka@chromium.org
    Bug: 903696
    Change-Id: I621eab844322e47a36cfa55ddf6c09c04d825266
    Reviewed-on: https://chromium-review.googlesource.com/c/1328987
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606811}

    Changed files

    • media/audio/audio_output_device_unittest.cc
  24. Revert "Reenable direct composition without video layers"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:58:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fb9951ce0f87e70b86cb5b12b4cca635341cbad

    Comments

    Revert "Reenable direct composition without video layers"
    
    This reverts commit eec86ff6c03b228b426a4553c89724d04e0a0f56.
    
    Reason for revert: Appears to break cc_unittests on the Linux CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11190
    
    Original change's description:
    > Reenable direct composition without video layers
    > 
    > Reenable direct composition surface on devices without hardware overlays
    > since it enables other power improvements like flip mode swap chain and
    > disabling DWM redirection surface.
    > 
    > To mitigate the original concerns about direct composition, this change
    > makes DCLayerTree lazy initialize the video context and processor when
    > a video layer is first used.  On devices that don't support hardware
    > overlays, the video context and processor will never be initialized.
    > 
    > Bug: 894675, 900702
    > Change-Id: I8c9d5b78718de2620ca177410d4916390e7cb219
    > Reviewed-on: https://chromium-review.googlesource.com/c/1318808
    > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606312}
    
    TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 894675, 900702
    Change-Id: I094721159277c50d9061dfded252bbac1084977f
    Reviewed-on: https://chromium-review.googlesource.com/c/1328965
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606810}

    Changed files

    • content/browser/gpu/gpu_internals_ui.cc
    • content/renderer/render_thread_impl.cc
    • gpu/config/gpu_driver_bug_list.json
    • gpu/config/gpu_info.cc
    • gpu/config/gpu_info.h
    • gpu/config/gpu_util.cc
    • gpu/ipc/common/gpu_info.mojom
    • gpu/ipc/common/gpu_info_struct_traits.cc
    • gpu/ipc/common/gpu_info_struct_traits.h
    • gpu/ipc/common/struct_traits_unittest.cc
    • gpu/ipc/service/direct_composition_surface_win.cc
    • gpu/ipc/service/direct_composition_surface_win.h
    • gpu/ipc/service/gpu_init.cc
    • gpu/ipc/service/image_transport_surface_win.cc
    • ui/gl/gl_switches.cc
    • ui/gl/gl_switches.h
  25. [Android] Remove GmsCoreSyncListener

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:55:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c5f96267752a38d90b07932c438ca7354e92f3e3

    Comments

    [Android] Remove GmsCoreSyncListener
    
    This CL removes GmsCoreSyncListener class and some harness around it.
    This class was implemented for https://crbug.com/552106, but that
    feature was never finished. This CL also removes
    ProfileSyncService::GetCustomPassphraseKey that became unused.
    
    Bug: 903284
    Change-Id: I096b2ab74915d2ed93b4c4077902a1de9abb4cee
    Reviewed-on: https://chromium-review.googlesource.com/c/1326502
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606809}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/GmsCoreSyncListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java
    • chrome/browser/sync/profile_sync_service_android.cc
    • chrome/browser/sync/profile_sync_service_android.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
  26. Revert "Fix a crash when switching to tablet mode in Unified Desktop mode"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:47:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f547d178e2b806007b88aa4c70ffe530de94f78

    Comments

    Revert "Fix a crash when switching to tablet mode in Unified Desktop mode"
    
    This reverts commit dcb55ce2871fe258d30386a85af754d496dfdb62.
    
    Reason for revert: Appears to cause crashes in LoginCursorTest.CursorHidden. See https://chromium-swarm.appspot.com/task?id=410f91874d359810&refresh=10&show_raw=1:
    BrowserTestBase received signal: Segmentation fault. Backtrace:
    #0 0x55c75309100f base::debug::StackTrace::StackTrace()
    #1 0x55c752aa8075 content::(anonymous namespace)::DumpStackTraceSignalHandler()
    #2 0x7f17e8b21cb0 <unknown>
    #3 0x55c751991a1d chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate()
    #4 0x55c751991c8e chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate()
    #5 0x55c7553a6063 views::WebDialogView::OnDialogClosed()
    #6 0x55c7553a5d92 views::WebDialogView::WindowClosing()
    #7 0x55c752f81eb0 views::Widget::OnNativeWidgetDestroying()
    #8 0x55c7548080ff views::DesktopWindowTreeHostMus::CloseNow()
    
    Original change's description:
    > Fix a crash when switching to tablet mode in Unified Desktop mode
    > 
    > 1) The Home Launcher used to use the wrong display ID when in
    >    Unified Desktop mode.
    > 2) If (1) is fixed, we hit https://crbug.com/902601. The captive
    >    portal dialog widget used to be leaked and never destroyed.
    > 3) If (2) is fixed, we crash on the first attempt to press the
    >    app list button. The reason is tablet mode triggers a switch
    >    to mirror mode. This switch happens asynchronously after the
    >    Home Launcher had already been created. Switching from Unified
    >    to mirror mode destroys the Unified host and the Home Launcher.
    >    That's why we need to ensure that the Home Launcher is
    >    recreated.
    > 
    > BUG=900956, 902601
    > TEST=Added a test that crashes without the fix.
    > 
    > Change-Id: If6eb9c2255dfa9d442aa115a3274db2d8a4110d7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325389
    > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    > Reviewed-by: Weidong Guo <weidongg@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606687}
    
    TBR=xiyuan@chromium.org,oshima@chromium.org,afakhry@chromium.org,jdufault@chromium.org,weidongg@chromium.org
    
    Change-Id: I2e0cacc2c29bbc44e8e8c9dfcb86fd8106c008ff
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 900956, 902601
    Reviewed-on: https://chromium-review.googlesource.com/c/1329004
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606808}

    Changed files

    • ash/app_list/app_list_controller_impl.cc
    • ash/app_list/app_list_controller_impl.h
    • ash/display/display_configuration_observer.cc
    • ash/display/display_manager_unittest.cc
    • chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
  27. Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget."

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:39:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b39a541429c5031a7a7d12d13ade6fd69a10356

    Comments

    Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget."
    
    This reverts commit 68d8dbc019fd37659252e273ade868aac7a9d8ac.
    
    Reason for revert: Looks like it makes PrerenderBrowserTest.PrerenderInfiniteLoop according to FindIt. 
    
    ../../chrome/browser/prerender/prerender_browsertest.cc:1721: Failure
    Expected equality of these values:
      1U
        Which is: 1
      GetLinkPrerenderCount()
        Which is: 2
    
    Original change's description:
    > Don't make a LayerTreeFrameSink for a non-visible RenderWidget.
    > 
    > Importantly, non-visible RenderWidgets include swapped out RenderWidgets
    > which are zombies, without a frame, and which should not be used.
    > 
    > This can happen if the RenderWidget swap out races with the posted task
    > from the compositor to make a LayerTreeFrameSink. When swapping out, the
    > compositor would be marked as not-visible, which would stop it from
    > making such requests, but one could already be in flight.
    > 
    > In the other case, honoring the request for a non-visible compositor is
    > more benign, but we can delay it until the compositor is actually
    > visible again. This means if a context is lost, backgrounded tabs would
    > not all attempt to reconnect to the Gpu process at once.
    > 
    > This is a better followup for the hacky
    > https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which
    > was meant only for merge to a release branch. It reverts that change as
    > part of this one.
    > 
    > R=​piman@chromium.org
    > 
    > Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7
    > Bug: 896836, 419087
    > Reviewed-on: https://chromium-review.googlesource.com/c/1292714
    > Commit-Queue: danakj <danakj@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606655}
    
    TBR=danakj@chromium.org,dcheng@chromium.org,piman@chromium.org
    
    Change-Id: I65238aba0abdb6c9192e9f3cb3691f8dd89b3ea5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 896836, 419087, 903696
    Reviewed-on: https://chromium-review.googlesource.com/c/1329003
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606807}

    Changed files

    • content/renderer/gpu/layer_tree_view.cc
    • content/renderer/gpu/layer_tree_view_delegate.h
    • content/renderer/input/widget_input_handler_impl.cc
    • content/renderer/input/widget_input_handler_manager.cc
    • content/renderer/render_frame_impl.cc
    • content/renderer/render_view_impl.cc
    • content/renderer/render_widget.cc
    • content/renderer/render_widget.h
    • content/test/stub_layer_tree_view_delegate.cc
    • content/test/stub_layer_tree_view_delegate.h
    • third_party/blink/renderer/core/exported/web_view_impl.cc
  28. Change Identity Service impl to depend only on signin internals

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24599fc67d36d611bdde3dc74d2f069491c7b9ca

    Comments

    Change Identity Service impl to depend only on signin internals
    
    Now that a distinct GN target exists just for the code backing
    IdentityManager/Identity Service, change the Identity Service
    implementation to depend only on that target. The change worked right
    out of the box -- good validation of the initial split.
    
    Bug: 901859
    Change-Id: I9b04ef952c34d9e9c0efcf137c55d41c8d616aff
    Reviewed-on: https://chromium-review.googlesource.com/c/1323649
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606806}

    Changed files

    • services/identity/BUILD.gn