Home | Search | chromium - Builders
Login

Builder Win7 Tests (dbg)(1) Build 72850 Microsoft Windows

Results:

Failure telemetry_perf_unittests (experimental) Failure webkit_layout_tests (experimental) Failure network_service_browser_tests

Trigger Info:

Projectchromium
Revisionacf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6
Got Revisionacf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

Execution:

Steps and Logfiles:

Show:
  1. ( 628 ms ) setup_build
    running recipe: "chromium"
  2. ( 224 ms ) report builders
     
    running tester 'Win7 Tests (dbg)(1)' on master 'chromium.win'
  3. ( 4 secs ) taskkill
  4. ( 1 mins 8 secs ) bot_update
    [59GB/349GB used (16%)]
  5. ( 2 secs ) swarming.py --version
    0.13
  6. ( 15 secs ) gclient runhooks
  7. ( 679 ms ) read test spec (chromium.win.json)
    path: e:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 461 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "e:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 1 secs ) build directory
  10. ( 382 ms ) find isolated tests
  11. ( 13 mins 28 secs ) telemetry_perf_unittests (experimental)
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:17:16.065463 (shard #14)
    Min shard duration: 0:02:30.775704 (shard #15)
    Total tests: 268
    * Passed: 209 (209 expected, 0 unexpected)
    * Skipped: 58 (58 expected, 0 unexpected)
    * Failed: 1 (0 expected, >>>1 unexpected<<<)
    * Flaky: 0 (0 expected, 0 unexpected)
     
    Unexpected Failures:
    * benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse:search:google_india:2018
     
  12. ( 32 mins 4 secs ) webkit_layout_tests (experimental)
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:47:22.152853 (shard #1)
    Min shard duration: 0:24:28.569981 (shard #2)
    Total tests: 88202
    * Passed: 75060 (75020 expected, 40 unexpected)
    * Skipped: 10556 (10556 expected, 0 unexpected)
    * Failed: 2492 (2491 expected, >>>1 unexpected<<<)
    * Flaky: 94 (94 expected, 0 unexpected)
     
    Unexpected Failures:
    * gamepad/multiple-event-listeners.html
     
  13. ( 2 secs ) wait for tasks
  14. ( 2 secs ) events_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  15. ( 2 secs ) courgette_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  16. ( 2 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 30s
  17. ( 2 secs ) network_service_components_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:24.087840
  18. ( 2 secs ) libjingle_xmpp_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 27s
  19. ( 2 secs ) crypto_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  20. ( 2 secs ) cast_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 31s
  21. ( 2 secs ) sbox_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  22. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 37s
  23. ( 3 secs ) blink_platform_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 44s
  24. ( 2 secs ) gcm_unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  25. ( 2 secs ) storage_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 32s
  26. ( 2 secs ) gin_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  27. ( 3 secs ) views_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 35s
  28. ( 2 secs ) jingle_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 19s
  29. ( 2 secs ) midi_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  30. ( 3 secs ) vr_pixeltests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 45s
  31. ( 2 secs ) message_center_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  32. ( 2 secs ) elevation_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  33. ( 2 secs ) cacheinvalidation_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  34. ( 6 secs ) unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:20:06.699262
  35. ( 2 secs ) nacl_loader_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 24s
  36. ( 2 secs ) display_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  37. ( 2 secs ) sync_integration_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:16:39.544229 (shard #1)
    Min shard duration: 0:14:31.789649 (shard #0)
  38. ( 2 secs ) google_apis_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  39. ( 2 secs ) snapshot_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 45s
  40. ( 3 secs ) boringssl_crypto_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 41s
  41. ( 6 secs ) webkit_unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:05:03.068135
  42. ( 2 secs ) viz_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:56.058331
  43. ( 2 secs ) headless_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 56s
  44. ( 2 secs ) views_perftests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 28s
    Total tests: n/a
     
  45. ( 2 secs ) skia_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 29s
  46. ( 2 secs ) shell_dialogs_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:08:37.719669
  47. ( 2 secs ) telemetry_gpu_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:14.644017
    Total tests: 38
    * Passed: 38 (38 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  48. ( 2 secs ) boringssl_ssl_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 20s
  49. ( 2 secs ) install_static_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  50. ( 2 secs ) chrome_elf_import_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 34s
  51. ( 2 secs ) extensions_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:12.592296
  52. ( 2 secs ) gcp_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 30s
  53. ( 2 secs ) service_manager_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  54. ( 2 secs ) network_service_extensions_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:27.524872
  55. ( 2 secs ) chrome_app_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 41s
  56. ( 2 secs ) ui_base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 31s
  57. ( 2 secs ) network_service_interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:33:28.722393 (shard #2)
    Min shard duration: 0:17:48.506512 (shard #1)
  58. ( 2 secs ) leveldb_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 35s
  59. ( 5 secs ) media_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:31.533984
  60. ( 2 secs ) ui_touch_selection_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  61. ( 2 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:03:42.555513
  62. ( 2 secs ) accessibility_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 20s
  63. ( 2 secs ) aura_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 36s
  64. ( 3 secs ) base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:43.100527
  65. ( 2 secs ) latency_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  66. ( 2 secs ) capture_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 27s
  67. ( 2 secs ) app_shell_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 43s
  68. ( 4 secs ) gpu_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 47s
  69. ( 2 secs ) device_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 31s
  70. ( 2 secs ) vr_common_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 46s
  71. ( 2 secs ) ppapi_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  72. ( 2 secs ) compositor_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 30s
  73. ( 2 secs ) extensions_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:03:31.814985
  74. ( 2 secs ) media_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  75. ( 2 secs ) installer_util_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  76. ( 2 secs ) mojo_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:14.730780
  77. ( 2 secs ) sbox_validation_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 20s
  78. ( 2 secs ) printing_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  79. ( 2 secs ) headless_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:03:11.512509
  80. ( 2 secs ) setup_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:18.538515
  81. ( 2 secs ) url_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  82. ( 11 secs ) network_service_browser_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:49:24.679109 (shard #11)
    Min shard duration: 0:29:53.741938 (shard #12)
  83. ( 9 secs ) components_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:12:10.619646
  84. ( 4 secs ) network_service_content_browsertests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:28:17.511105 (shard #0)
    Min shard duration: 0:23:14.177680 (shard #1)
  85. ( 3 secs ) gfx_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:20.263084
  86. ( 11 secs ) browser_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:33:41.085462 (shard #10)
    Min shard duration: 0:18:00.631072 (shard #15)
  87. ( 3 secs ) cc_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:03:25.116917
  88. ( 2 secs ) metrics_python_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 19s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  89. ( 2 secs ) ipc_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 28s
  90. ( 2 secs ) content_shell_crash_test
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:01.241918
    Total tests: n/a
     
  91. ( 5 secs ) angle_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:07:57.342951
  92. ( 4 secs ) content_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:03:12.310975
  93. ( 3 secs ) content_browsertests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:19:30.729758 (shard #0)
    Min shard duration: 0:16:19.250414 (shard #1)
  94. ( 2 secs ) remoting_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 46s
  95. ( 2 secs ) cronet_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 32s
  96. ( 2 secs ) sql_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  97. ( 2 secs ) wtf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  98. ( 2 secs ) components_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:14.321869
  99. ( 2 secs ) chrome_elf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  100. ( 2 secs ) zucchini_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:11.135101
  101. ( 2 secs ) chrome_cleaner_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:04:33.008688
  102. ( 2 secs ) blink_fuzzer_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 27s
  103. ( 2 secs ) wm_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 24s
  104. ( 3 secs ) webkit_python_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
    Total tests: 1578
    * Passed: 1562 (1562 expected, 0 unexpected)
    * Skipped: 16 (16 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  105. ( 2 secs ) cronet_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  106. ( 17 secs ) net_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:17:07.298519
  107. ( 2 secs ) mojo_core_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  108. ( 2 secs ) perfetto_content_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 41s
  109. ( 2 secs ) blink_common_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  110. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:19:16.921525 (shard #3)
    Min shard duration: 0:16:06.587255 (shard #2)
  111. ( 2 secs ) chromedriver_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 35s
  112. ( 2 secs ) crashpad_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 24s
  113. ( 2 secs ) filesystem_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  114. ( 2 secs ) sbox_integration_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  115. ( 3 secs ) telemetry_unittests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:10:10.908132 (shard #1)
    Min shard duration: 0:07:53.171078 (shard #2)
    Total tests: 1141
    * Passed: 1035 (1035 expected, 0 unexpected)
    * Skipped: 106 (106 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  116. ( 2 secs ) performance_test_suite
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:01:38.106528 (shard #1)
    Min shard duration: 58s (shard #0)
    Total tests: 2
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 1 (1 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  117. ( 2 secs ) pdf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 30s
  118. ( 3 secs ) services_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:26.182470
  119. ( 2 secs ) media_blink_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 47s
  120. ( 2 secs ) native_theme_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  121. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:09:12.127795 (shard #3)
    Min shard duration: 0:05:08.199262 (shard #1)
  122. ( 205 ms ) Tests statistics
     
    Stats
    Total shards: 188
    Total runtime: 1 day, 9:03:52.837000
     
  123. ( 436 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "e:\\b\\s\\w\\ir\\cache", "temp_dir": "e:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm12-m1" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541781589800217, "id": "8930318543652150128", "project": "chromium", "tags": ["builder:Win7 Tests (dbg)(1)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6", "gitiles_ref:refs/heads/master", "parent_buildername:Win Builder (dbg)", "parent_buildnumber:56362", "scheduler_invocation_id:9095748605895039056", "scheduler_job_id:chromium/Win7 Tests (dbg)(1)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 Tests (dbg)(1)" setup_build
buildnumber 72850 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win Builder (dbg)" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6" setup_build
parent_got_revision_cp "refs/heads/master@{#606863}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.286@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6" setup_build
swarm_hashes {"accessibility_unittests": "de57ab8391b1b0b1d1a44846aad9ea469bdadaa2", "angle_unittests": "d5d29550e91d510ffc02c91cfa712a2e00566bc9", "app_shell_unittests": "22b9f6817f760c627052469351b843fc56d60619", "aura_unittests": "feb1b5e2049315722b8a6c3da9e19fecf24424ee", "base_unittests": "9c31e673d68c038b0be3fa236f818a8f60fbfa24", "blink_common_unittests": "9872ac1a7addd147eb78493b792590d89fac0ce9", "blink_fuzzer_unittests": "536c9bf28e7ed0de08941dda39ae466db1ab8bca", "blink_heap_unittests": "2dc79ffdcb0206aa6b9114842beaa84571c18751", "blink_platform_unittests": "7a5360e99304274a0aa354e9494a3fd3de66fb5c", "boringssl_crypto_tests": "87ce069e28347e706b5ec72760156267efba8663", "boringssl_ssl_tests": "b58db02b26c29fcdf94236efcfa8fe74da6a0122", "browser_tests": "6fb53b2228794a0654cf92f52822c7391ec02936", "cacheinvalidation_unittests": "1efb099003578742f7377e8875221d7ede6e1815", "capture_unittests": "e830e4749e5f5b160c70087c4f7a1d1cc595eebe", "cast_unittests": "1619e657e9eab5e1ef6a23a3f2e8ba3a9956e3d3", "cc_unittests": "d528a18272404779d817168001cd99245d9fca85", "chrome_app_unittests": "9770517c0b326390af67f379547df0cc16aa0dbe", "chrome_cleaner_unittests": "34e79d563bff425708b3105378c0e8c8091a3449", "chrome_elf_import_unittests": "2d14815e5515e2d02f289b8d37f4343ebdb49453", "chrome_elf_unittests": "a96bd98cf32cb0968548b0707703253078c21c35", "chromedriver_unittests": "42426a69708f19857a917dcccab7ca96331b85e2", "components_browsertests": "ab989778925d096d804af1781244f941681189ba", "components_unittests": "7e9e9b7aaa4621eac8f1037086f8a33fda87046a", "compositor_unittests": "514676183db409ebc1b0adc589a4fcc282c80ec0", "content_browsertests": "7f2475df98aba1758501619a67327c70c11f8446", "content_shell_crash_test": "31e90c82d9d8fe4ad8f7eba89d0bdfb412388d73", "content_unittests": "7091a325ea1d34077cc7efc9d33e021add3cedfb", "courgette_unittests": "84bf919edd94e9b43e530eada8bce8a6f2db613a", "crashpad_tests": "75a07e651806c66d0c03bc016a6d56c410dd706c", "cronet_tests": "034b77a641ffa86a73443960f04270062c8d7abb", "cronet_unittests": "1ef9a7470b17b6e16b370c914e280566b9371f89", "crypto_unittests": "ff0c984a021f2a39222f429696836f3b26c7e083", "device_unittests": "c3659bcfad724cd468baa0fc152d67eefaf41aa9", "display_unittests": "e087eda305b12b26e6acb6b3ba8404e79e94c902", "elevation_service_unittests": "4981eb0d3ad4f8d0bbad548df6f7772235974cce", "events_unittests": "b78db0cbe27f20ef05f1239902a11f6b40385abe", "extensions_browsertests": "05534765f0928ef938831f9a41d40821cd1b05b0", "extensions_unittests": "276f81101589676ef133852882f8f1ef61c5e799", "filesystem_service_unittests": "0af6643473974546f9d73ce58e88d7a09507793c", "gcm_unit_tests": "e5378a51c1dd25aa71fef63ef9cff69a399a95f5", "gcp_unittests": "5cb5b495c20ab3f9d41ca6381fc80bade6fd8652", "gfx_unittests": "8036a77f6c3a1fb99f62357085b903d725472f69", "gin_unittests": "c7bc9d71767d604ea736c398f382f904c061a604", "google_apis_unittests": "f085e2e872a81555925c816514713d042b30cafa", "gpu_unittests": "ddaebfff17c47da4579147ee0a0447d50ed9f613", "headless_browsertests": "94ae6c29712ed5f00b76d68f8c9760e97cb183c5", "headless_unittests": "8a1ba1a293cc21a14d8e816bce8af95797257b31", "install_static_unittests": "8b99c1cad6c49ba7fff35d81a49c7e9cccf7dc48", "installer_util_unittests": "7ca83fe6948980b75122e2b57dbc9a443287f624", "interactive_ui_tests": "07e04105ef261c87732843b1c800b537624b76ac", "ipc_tests": "5fff2006c828d3a22b51fe39ffc69af5d6bc46d3", "jingle_unittests": "e15870c5a79451212f09042e5facf8543ad2c1ec", "latency_unittests": "7cebc4de072ae93c822149f0fd3a8e5ea0aaf91f", "leveldb_service_unittests": "7d568a6ca870dde2d33f161bc9c70f90cc886187", "libjingle_xmpp_unittests": "777b6b7bf65396a142e79a1151410ed9730cef64", "media_blink_unittests": "4a42369073d487b16479c78ec7935ff58d7b52b7", "media_service_unittests": "fa6158422cceb37e1f92c412a56610d5f2e8fbb3", "media_unittests": "ac58ecce47790ef889ff3965d2f807bcedd0706b", "message_center_unittests": "0e0e29598de147b5c46985e7a1e2b2dbabe299ca", "metrics_python_tests": "9e374d5cc925c81ab79219164c600044a12b261d", "midi_unittests": "012ef89d93b7cdd205958d92efd532fa29514026", "mojo_core_unittests": "07e5ad5b4f4f79dac80cd412a0fe5280ef505885", "mojo_unittests": "83917bd3a172916e4dcbee31b5dae0f505e9c752", "nacl_loader_unittests": "b05b329d89c5d8b06440bda13dcb4323e86800a6", "native_theme_unittests": "8c2495f6d41bbd3b6e806f5b1514616583328a05", "net_unittests": "9cd7e7c4a2837842a610041f0ad4d0e3ff538fab", "pdf_unittests": "16c81ecc0798b20ac825f1daab17bb4f488f45cf", "performance_test_suite": "a1d35155ee652362e6d9d9d7f07f82710391a5a3", "ppapi_unittests": "d960eeaea88da2b51767cbb02fd5cb6af170c0e6", "printing_unittests": "470928293e77a11bee7a6a9bf2c23ee51564a8ad", "remoting_unittests": "bd4b4ed539b1441508c245c7fc91d93f88dc5d34", "sbox_integration_tests": "1d5d8e9a7e34a0d6c4dbc94e336a437c5812daf6", "sbox_unittests": "c0adcfcdc88531b13e1770d18d4f57390ed9d46c", "sbox_validation_tests": "d28e398d656896c3abd9d63bca6fcc8514f4e7aa", "service_manager_unittests": "ad3fb9b38f8a7d509ae6db56d646922ff56bfbe9", "services_unittests": "5a09ea46ba20f818577c52df476b53cc85fa1257", "setup_unittests": "597313ac76a70e59841a3ab76a69b19f2920f163", "shell_dialogs_unittests": "e07d29a3e5652f6cc6c2100b9a9a4967e145c227", "skia_unittests": "9a60f043ccdee27997cdcbf9f61a828ec20b3d15", "snapshot_unittests": "8c98e0ff3f49d1a471364f5a42df0cc99c1b0807", "sql_unittests": "70bc24fb1b1f5b23b185ac7c73954091fe791738", "storage_unittests": "4ce6dec058bc81320e3efe3c24a845788f1408e7", "sync_integration_tests": "631d0b5a61b38f963d06e1c8bcc1254a965f5198", "telemetry_gpu_unittests": "90b13b98aea4922d687d9c8cb4de2d85c392c25a", "telemetry_perf_unittests": "c7e5625eef4ab775e88953c15ae2e4d7c03db3ff", "telemetry_unittests": "f5112a735d6dacdb10e5a174e7e7d31d7e8a203f", "traffic_annotation_auditor_unittests": "30d7e5eb844f4470f6b77061aec5b3ca536e8c0e", "ui_base_unittests": "0f371a723a79282f99dee10910a07ed68083df97", "ui_touch_selection_unittests": "2167b714dd6a35bb9fabdc5ac51ac055e74fdecc", "unit_tests": "01afc5e4b0a98fadc1117cc130c1c38a0c39645b", "url_unittests": "264fdbea801562d0c1fd3fdd4942cbae8d091859", "views_perftests": "854cb89d5c732700930b2cc2c61f3967a6d07f6a", "views_unittests": "1ad89761fbdfa9cecad47a61fadae6ff31546670", "viz_unittests": "8f48559bb82f7e9bf6e43945545440175eb21ce0", "vr_common_unittests": "51582fdb1c10599938a160a33922aba6baeb4b6c", "vr_pixeltests": "69e1b5baf774fae6e371e2b6276cb967c8cc9a3b", "webkit_layout_tests_exparchive": "c2ce31b812cef019eb53425931230565d8c98412", "webkit_python_tests": "cde94d9bfd49dc19a39cfa9dada6f66bb46eb5d8", "webkit_unit_tests": "2a1b09b9f8ab2336a1c6914c4f5e75e929aef5ad", "wm_unittests": "e0a755b503bedb2a101e065521c0b1f94acfdefc", "wtf_unittests": "bf4fe618af6efba212e1d1d6bdfee45343a3b8da", "zucchini_unittests": "a2879b6257febe4155d6abbd6f497f539581889e"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6" bot_update
got_revision_cp "refs/heads/master@{#606863}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Vasilii Sukhanov (vasiliiohnoyoudont@chromium.org)
  2. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  3. Fernando Serboncini (fserbohnoyoudont@chromium.org)
  4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  5. Nico Weber (thakisohnoyoudont@chromium.org)
  6. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  7. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  8. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  9. Eugene But (eugenebutohnoyoudont@google.com)
  10. Eugene But (eugenebutohnoyoudont@google.com)
  11. Pavel Shmakov (pshmakovohnoyoudont@google.com)
  12. Tim Volodine (timvolodineohnoyoudont@chromium.org)
  13. Rayan Kanso (rayankansohnoyoudont@google.com)
  14. David Jean (djeanohnoyoudont@google.com)
  15. Aaron Krajeski (aaronhkohnoyoudont@google.com)
  16. Marc Treib (treibohnoyoudont@chromium.org)
  17. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  18. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  19. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  20. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  21. Lukasz Suder (lsuderohnoyoudont@google.com)
  22. Greg Thompson (grtohnoyoudont@chromium.org)
  23. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  24. Corentin Wallez (cwallezohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 16:39:49 UTC
Start Friday, 09-Nov-18 16:39:52 UTC
End Friday, 09-Nov-18 17:49:38 UTC
Pending 2 secs
Execution 1 hrs 9 mins

All Changes:

  1. Ignore blur events caused by the password generation.

    Changed by Vasilii Sukhanov - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:18:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

    Comments

    Ignore blur events caused by the password generation.
    
    When PasswordGenerationAgent copies the password value from the password field
    to "Confirm Password" filed, a blur event is generated. It hides the currently
    open generation prompt. Those events are just side-effects of how the class
    works and should be ignored.
    
    Bug: 899756,850079
    Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444
    Reviewed-on: https://chromium-review.googlesource.com/c/1327205
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606863}

    Changed files

    • chrome/renderer/autofill/fake_password_manager_client.cc
    • chrome/renderer/autofill/fake_password_manager_client.h
    • chrome/renderer/autofill/password_generation_agent_browsertest.cc
    • components/autofill/content/renderer/autofill_agent.cc
    • components/autofill/content/renderer/password_generation_agent.cc
    • components/autofill/content/renderer/password_generation_agent.h
  2. Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:12:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5657f328e5325aa821d8714a3f7686c078603a43

    Comments

    Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a
    
    
    git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cf90797ef05a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606862}

    Changed files

    • DEPS
  3. Save transform context for filters

    Changed by Fernando Serboncini - fserbohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d07d7323809b59b52b1237dacb94330cc9dab4bd

    Comments

    Save transform context for filters
    
    Otherwise we get weird behavior on filters while transforming.
    
    TBR=
    
    Bug: 901759
    Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251
    Reviewed-on: https://chromium-review.googlesource.com/c/1329342
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606861}

    Changed files

    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
  4. Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:10:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99e210e29e5e55c29142398eb11e164801f7d0c8

    Comments

    Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8
    
    
    git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs
    
    
    Created with:
      gclient setdep -r src/third_party/skia@c244c2fbbbf8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155
    Reviewed-on: https://chromium-review.googlesource.com/c/1329045
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606860}

    Changed files

    • DEPS
  5. Remove v8_context_snapshot.bin determinism hack.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:08:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2acccc10cf8afd5a3709f5fd562d700d6b96979

    Comments

    Remove v8_context_snapshot.bin determinism hack.
    
    Reverts parts of
    https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should
    no longer be needed after https://chromium-review.googlesource.com/c/1304441
    
    Bug: 870584
    Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1328823
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606859}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
  6. Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:06:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7669a6683a5f927ae9a3fa2c2d7802e2a8d5c165

    Comments

    Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file
    
    In case the files are somehow not found or unreadable on the bots, the tests should fail.
    R=dmazzoni@chromium.org
    
    Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171
    Reviewed-on: https://chromium-review.googlesource.com/c/1324232
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606858}

    Changed files

    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.cc
  7. Roll src-internal 6166365225d6..827de2c806ba (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56904b670753b8f8a1f5131ef61b9e1027f34c6e

    Comments

    Roll src-internal 6166365225d6..827de2c806ba (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba
    
    
    Created with:
      gclient setdep -r src-internal@827de2c806ba
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1329361
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606857}

    Changed files

    • DEPS
  8. Wire the resizeMode property to the constraints parsing mechanism.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:02:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c6c086d575a9e131e70eaf6512a0da14150442

    Comments

    Wire the resizeMode property to the constraints parsing mechanism.
    
    This CL adds resizeMode support for MediaStreamTrack.getConstraints()
    and marks resizeMode as a supported constrainable property.
    
    Support for getUserMedia(), applyConstraints() and getCapabilities()
    will be added in follow-up CLs in this series.
    
    Intent to Ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
    
    Bug: 854980
    Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
    Reviewed-on: https://chromium-review.googlesource.com/c/1309749
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606856}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html
    • third_party/blink/public/platform/web_media_constraints.h
    • third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
    • third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
    • third_party/blink/renderer/platform/exported/web_media_constraints.cc
  9. Call WebStateObserver::PageLoaded after loading placeholder URL.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:00:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 386114b5bacc02e12b584786671d67b6080f02e7

    Comments

    Call WebStateObserver::PageLoaded after loading placeholder URL.
    
    Before this CL PageLoaded was called right from
    didFailProvisionalNavigation:, where URL may still represent the
    previous page.
    
    Bug: 903497
    Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327608
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606855}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  10. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  11. Refactor Trusted Web Activity UI code to MVC

    Changed by Pavel Shmakov - pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java
  12. [AW NS] Add CTS test filter for Android WebView

    Changed by Tim Volodine - timvolodineohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:47:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e57afbcbc0d8a4fff7a9d8df6164bf0f6dcedd75

    Comments

    [AW NS] Add CTS test filter for Android WebView
    
    The idea of this CTS filter is similar to the filter we have for
    instrumentation tests, i.e.
    mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains
    failing tests and their corresponding issues / root causes.
    
    The current filter contains results from a local run for a subset of
    tests (the actual CTS is not running yet). The CTS filter also
    augments the instrumentation test filter for test coverage that is
    missing from instrumentation tests.
    
    BUG=903822,902330,841556
    
    Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/1319677
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606852}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_webview_CTS_test.filter
  13. [Background Fetch] Report uploadTotal in the registration

    Changed by Rayan Kanso - rayankansohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a2e1006e2f0960cea11264c2cb65c73d0334b90

    Comments

    [Background Fetch] Report uploadTotal in the registration
    
    Also sets up some useful testing helpers for future upload features.
    
    Bug: 774054
    Change-Id: I9aea33086b228357d9a160bd35b0a37ceaa30592
    Reviewed-on: https://chromium-review.googlesource.com/c/1329149
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606851}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.h
    • content/browser/background_fetch/storage/create_metadata_task.cc
  14. [ios] add manual fallback credit card and address coordinator

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:34:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b02a7719f78de1e78ded7807aa4d139f8c2b77d6

    Comments

    [ios] add manual fallback credit card and address coordinator
    
    And a common base class.
    
    Bug: 845472
    Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1318914
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606850}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
  15. Add RAF tests to blink_perf.canvas benchmark.

    Changed by Aaron Krajeski - aaronhkohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:28:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7149ab705c9a7c1c9c57c960c05e2de216680c7d

    Comments

    Add RAF tests to blink_perf.canvas benchmark.
    
    Current canvas benchmarks only measure CPU time.
    Using requestAnimationFrame (raf) in javascript we can
    measure CPU + raster + GPU time. This CL adds a mode to
    blink_perf.py that runs canvas all canvas test in a way
    that takes raster and GPU time into account.
    
    Roughly doubles the duration of `blink_perf.canvas`
    benchmark from ~2 minutes to ~4 minutes on a linux desktop.
    
    Bug: 894043
    Change-Id: I2fdd13af75615802266fa39a01db3e883f2c95bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1300038
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606849}

    Changed files

    • docs/speed/benchmark/harnesses/blink_perf.md
    • third_party/blink/perf_tests/canvas/OWNERS
    • third_party/blink/perf_tests/canvas/gpu-bound-shader.html
    • third_party/blink/perf_tests/canvas/resources/canvas_runner.js
    • third_party/blink/perf_tests/canvas/sheets-render.html
    • third_party/blink/perf_tests/canvas/upload-webgl-to-texture.html
    • tools/perf/benchmark.csv
    • tools/perf/benchmarks/blink_perf.py
    • tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
    • tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
    • tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py
    • tools/perf/core/shard_maps/android-nexus5x-perf_map.json
    • tools/perf/core/shard_maps/android_nexus5_perf_map.json
    • tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
    • tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
    • tools/perf/core/shard_maps/linux-perf_map.json
    • tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
    • tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
    • tools/perf/core/shard_maps/win-10-perf_map.json
    • tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
    • tools/perf/core/shard_maps/win_7_perf_map.json
  16. SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:27:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 413493e0052d3f0537cf96d619849e8acf248658

    Comments

    SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard
    
    Bug: 856179
    Change-Id: I0fb499c5bb5c0de6df4fa7c2f46d3b0b35f5f0df
    Reviewed-on: https://chromium-review.googlesource.com/c/1326901
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606848}

    Changed files

    • chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  17. Fix MergeAndOverrideOnConflict for custom properties.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:25:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3052bf26cacf33ea7dd70fda7cccb5bebb28cfe9

    Comments

    Fix MergeAndOverrideOnConflict for custom properties.
    
    Utilizing CSSPropertyName, to make the code much nicer.
    
    R=futhark@chromium.org
    
    Change-Id: I10733cabe27cc271eaaf3ecf62fa7713cf74eac3
    Reviewed-on: https://chromium-review.googlesource.com/c/1323650
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606847}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_value.cc
    • third_party/blink/renderer/core/css/css_property_value.h
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/css_property_value_set_test.cc
  18. Add redirected cases to CSP/import tests in wpt/worklets

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff65400edef4c2d8e8ed01f1e2bd60c1c55aa8c

    Comments

    Add redirected cases to CSP/import tests in wpt/worklets
    
    Also this CL replaces some of empty-worklet-script.js usage
    in CSP tests with empty-worklet-script-with-cors-header.js
    to make sure worklets are rejected due to CSP, not CORS.
    
    Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92
    Reviewed-on: https://chromium-review.googlesource.com/c/1312146
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606846}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/csp-tests.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js
  19. Add UseCounter for unknown namespace usage in selectors.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c413c91c21481af23cfb54d742e80fd2b589608

    Comments

    Add UseCounter for unknown namespace usage in selectors.
    
    R=chrishtr@chromium.org
    
    Bug: 901938
    Change-Id: I9e20fe19f2c97b98f8250c6c9914512b5a73d8c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1318891
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606845}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/frame/use_counter_test.cc
    • tools/metrics/histograms/enums.xml
  20. Retire NotificationInlineReplies runtime enabled flag.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:15:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5395d94feaf7a04c1a7fd9832d3750c636d6dea1

    Comments

    Retire NotificationInlineReplies runtime enabled flag.
    
    NotificationInlineReplies shipped in M70.
    
    BUG=834580
    
    Change-Id: Ibed1612aae4c21a239e9328d7134cd75169c713a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323615
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606844}

    Changed files

    • third_party/blink/renderer/modules/notifications/notification_action.idl
    • third_party/blink/renderer/modules/notifications/notification_event.idl
    • third_party/blink/renderer/modules/notifications/notification_event_init.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  21. [Autofill Assistant] Fixes Payement Request details bug.

    Changed by Lukasz Suder - lsuderohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:13:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be08662134b0c40ff6913cf531e2fefed5c2d4d9

    Comments

    [Autofill Assistant] Fixes Payement Request details bug.
    
    Before all details where asked each time.
    
    Bug: 806868
    Change-Id: Ie3a278e2882d4829cfe2c54ac641d10abf5af2e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329167
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606843}

    Changed files

    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
  22. Fix the icons for the app menu and the upgrade item in it when an update is available.

    Changed by Greg Thompson - grtohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:12:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5a766d75a0eb8006212cb5cee94d704650c787b

    Comments

    Fix the icons for the app menu and the upgrade item in it when an update is available.
    
    A regression was introduced in r581520 that caused the wrong icon and/or
    the wrong coloring to be used in some circumstances. This CL fixes this
    in two parts:
    
    - AppMenuIconController may decide that the "annoyance level" from a
      pending update is too low to bother the user. One bug introduced in
      r581520 was that the controller still notified delegates that the
      UPGRADE_NOTIFICATION icon type should be used in this case. Now, the
      VERY_LOW annoyance level is ignore entirely for beta and stable
      channels.
    
    - AppMenuModel no longer bases its decision to include the upgrade menu
      item directly on the UpgradeDetector. Rather, it now queries the
      AppMenuIconController. This ensures that the same logic is used for
      both the badging of the app menu and for the presence of the upgrade
      item in the menu.
    
    BUG=898958
    
    Change-Id: I4b761844365968a24bc69030d711122fcaf16e28
    Reviewed-on: https://chromium-review.googlesource.com/c/1312475
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606842}

    Changed files

    • chrome/browser/ui/toolbar/app_menu_icon_controller.cc
    • chrome/browser/ui/toolbar/app_menu_icon_controller.h
    • chrome/browser/ui/toolbar/app_menu_icon_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
    • chrome/browser/ui/toolbar/app_menu_model.h
    • chrome/browser/ui/toolbar/app_menu_model_unittest.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/BUILD.gn
  23. Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c42eb303c89bfba751ae499abfb7252e2ceb7532

    Comments

    Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02
    
    Using wpt-import in Chromium 43d0eed3db77a5e6167b5ebbf6ecb3710790272a.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: I4bcac484d08efe8d6e6412d40b1c7d73ffe512d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329061
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606841}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/selection-api.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  24. testing/buildbot: add fake bots to run Dawn's GPU tests.

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f2b5efa43dfe2ff69fab31ba83c352ecf8e62ab

    Comments

    testing/buildbot: add fake bots to run Dawn's GPU tests.
    
    BUG=chromium:901830
    
    Change-Id: I5c5b0b08fadddc34f6a2d176ae39ebfae7e7f706
    Reviewed-on: https://chromium-review.googlesource.com/c/1326157
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606840}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl