Home | Search | chromium - Builders
Login

Builder Win7 Tests (dbg)(1) Build 72203 Microsoft Windows

Results:

Failure telemetry_perf_unittests (experimental) Failure webkit_layout_tests (experimental)

Trigger Info:

Projectchromium
Revisionc245af46fb47db066cbdc99a5f578e2b94b2ca2f
Got Revisionc245af46fb47db066cbdc99a5f578e2b94b2ca2f

Execution:

Steps and Logfiles:

Show:
  1. ( 528 ms ) setup_build
    running recipe: "chromium"
  2. ( 274 ms ) report builders
     
    running tester 'Win7 Tests (dbg)(1)' on master 'chromium.win'
  3. ( 3 secs ) taskkill
  4. ( 1 mins 3 secs ) bot_update
    [42GB/349GB used (12%)]
  5. ( 653 ms ) swarming.py --version
    0.13
  6. ( 14 secs ) gclient runhooks
  7. ( 617 ms ) read test spec (chromium.win.json)
    path: e:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 458 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "e:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 358 ms ) build directory
  10. ( 382 ms ) find isolated tests
  11. ( 2 secs ) accessibility_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  12. ( 4 secs ) angle_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:05:22.848600
  13. ( 2 secs ) app_shell_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  14. ( 2 secs ) aura_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 28s
  15. ( 3 secs ) base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 58s
  16. ( 2 secs ) blink_common_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  17. ( 2 secs ) blink_fuzzer_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  18. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 38s
  19. ( 3 secs ) blink_platform_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 30s
  20. ( 2 secs ) boringssl_crypto_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:55.205473
  21. ( 2 secs ) boringssl_ssl_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  22. ( 2 secs ) cacheinvalidation_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  23. ( 2 secs ) capture_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 25s
  24. ( 2 secs ) cast_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 28s
  25. ( 3 secs ) cc_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:56.082511
  26. ( 2 secs ) chrome_app_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 31s
  27. ( 2 secs ) chrome_cleaner_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:08.554577
  28. ( 1 secs ) chrome_elf_import_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  29. ( 2 secs ) chrome_elf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  30. ( 2 secs ) chromedriver_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  31. ( 2 secs ) components_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:20.099124
  32. ( 2 secs ) network_service_components_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:10.887365
  33. ( 1 mins 12 secs ) components_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:06:31.095709
  34. ( 2 secs ) compositor_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  35. ( 2 secs ) perfetto_content_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 41s
  36. ( 4 secs ) content_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:57.707817
  37. ( 2 secs ) courgette_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 20s
  38. ( 2 secs ) crashpad_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 20s
  39. ( 2 secs ) cronet_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  40. ( 2 secs ) cronet_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  41. ( 2 secs ) crypto_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:43.843391
  42. ( 2 secs ) device_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  43. ( 4 secs ) display_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 19s
  44. ( 2 secs ) elevation_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  45. ( 2 secs ) events_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  46. ( 2 secs ) extensions_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:05.992864
  47. ( 2 secs ) network_service_extensions_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:02.421466
  48. ( 2 secs ) extensions_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:20.770705
  49. ( 2 secs ) filesystem_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  50. ( 2 secs ) gcm_unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 20s
  51. ( 4 secs ) gfx_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 57s
  52. ( 2 secs ) gin_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  53. ( 2 secs ) google_apis_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  54. ( 3 secs ) gpu_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 43s
  55. ( 2 secs ) headless_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:27.376807
  56. ( 2 secs ) headless_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  57. ( 2 secs ) install_static_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  58. ( 2 secs ) installer_util_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 27s
  59. ( 2 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:56.479855
  60. ( 2 secs ) ipc_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 20s
  61. ( 2 secs ) jingle_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  62. ( 2 secs ) latency_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  63. ( 2 secs ) leveldb_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  64. ( 2 secs ) libjingle_xmpp_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 25s
  65. ( 2 secs ) media_blink_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 38s
  66. ( 2 secs ) media_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 19s
  67. ( 4 secs ) media_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:26.883997
  68. ( 2 secs ) message_center_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  69. ( 2 secs ) midi_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  70. ( 2 secs ) mojo_core_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  71. ( 2 secs ) mojo_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  72. ( 2 secs ) nacl_loader_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  73. ( 2 secs ) native_theme_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  74. ( 13 secs ) net_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:19:55.751863
  75. ( 2 secs ) pdf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  76. ( 2 secs ) ppapi_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  77. ( 2 secs ) printing_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  78. ( 2 secs ) remoting_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 51s
  79. ( 2 secs ) sbox_integration_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  80. ( 2 secs ) sbox_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  81. ( 2 secs ) sbox_validation_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  82. ( 2 secs ) service_manager_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  83. ( 4 secs ) services_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:34.469533
  84. ( 2 secs ) setup_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  85. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  86. ( 2 secs ) skia_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  87. ( 2 secs ) snapshot_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 45s
  88. ( 2 secs ) sql_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  89. ( 2 secs ) storage_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  90. ( 2 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 24s
  91. ( 2 secs ) ui_base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  92. ( 2 secs ) ui_touch_selection_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  93. ( 3 mins 28 secs ) unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:14:51.026072
  94. ( 2 secs ) url_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  95. ( 2 secs ) views_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 45s
  96. ( 2 secs ) viz_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:27.292103
  97. ( 2 secs ) vr_common_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 42s
  98. ( 2 secs ) vr_pixeltests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 28s
  99. ( 7 secs ) webkit_unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:03:58.942882
  100. ( 2 secs ) wm_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  101. ( 2 secs ) wtf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  102. ( 2 secs ) zucchini_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  103. ( 3 secs ) content_browsertests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:15:48.570502 (shard #1)
    Min shard duration: 0:14:04.190938 (shard #0)
  104. ( 7 mins 13 secs ) network_service_content_browsertests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:23:16.603849 (shard #0)
    Min shard duration: 0:17:34.695154 (shard #1)
  105. ( 2 secs ) sync_integration_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:13:19.694046 (shard #0)
    Min shard duration: 0:09:49.272579 (shard #1)
  106. ( 4 secs ) network_service_interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:23:20.504128 (shard #1)
    Min shard duration: 0:20:43.268130 (shard #2)
  107. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:06:35.362979 (shard #1)
    Min shard duration: 0:05:57.806628 (shard #2)
  108. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:17:29.261625 (shard #3)
    Min shard duration: 0:10:07.097816 (shard #2)
  109. ( 9 mins 59 secs ) network_service_browser_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:33:29.577034 (shard #7)
    Min shard duration: 0:21:18.480420 (shard #3)
  110. ( 8 secs ) browser_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:31:57.182093 (shard #9)
    Min shard duration: 0:16:04.688694 (shard #4)
  111. ( 2 secs ) content_shell_crash_test
    Run on OS: 'Windows-7-SP1'
    Shard duration: 38s
    Total tests: n/a
     
  112. ( 2 secs ) metrics_python_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  113. ( 2 secs ) performance_test_suite
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:01:26.009671 (shard #1)
    Min shard duration: 0:01:24.974302 (shard #0)
    Total tests: n/a
     
  114. ( 2 secs ) telemetry_gpu_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 49s
    Total tests: 35
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  115. ( 3 secs ) telemetry_perf_unittests (experimental)
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:20:48.982843 (shard #3)
    Min shard duration: 0:04:51.967755 (shard #16)
    Total tests: 241
    * Passed: 209 (209 expected, 0 unexpected)
    * Skipped: 31 (31 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 1 (1 expected, 0 unexpected)
     
  116. ( 3 secs ) telemetry_unittests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:12:31.183066 (shard #3)
    Min shard duration: 0:06:13.306372 (shard #2)
    Total tests: 1169
    * Passed: 1063 (1063 expected, 0 unexpected)
    * Skipped: 106 (106 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  117. ( 2 secs ) views_perftests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
    Total tests: n/a
     
  118. ( 4 mins 44 secs ) webkit_layout_tests (experimental)
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:38:04.726979 (shard #9)
    Min shard duration: 0:25:30.497662 (shard #3)
    Total tests: 87453
    * Passed: 74325 (74266 expected, 59 unexpected)
    * Skipped: 10507 (10507 expected, 0 unexpected)
    * Failed: 2551 (2549 expected, >>>2 unexpected<<<)
    * Flaky: 70 (70 expected, 0 unexpected)
     
    Unexpected Failures:
    * virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-touch-action-manual.tentative.html
    * virtual/threaded/printing/ellipsis-printing-style.html
     
  119. ( 3 secs ) webkit_python_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 35s
    Total tests: 1551
    * Passed: 1535 (1535 expected, 0 unexpected)
    * Skipped: 16 (16 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  120. ( 230 ms ) Tests statistics
     
    Stats
    Total shards: 187
    Total runtime: 1 day, 2:59:33.752002
     
  121. ( 1 secs ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "e:\\b\\s\\w\\ir\\cache", "temp_dir": "e:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm12-m1" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539334129877331, "id": "8932884891388628416", "project": "chromium", "tags": ["builder:Win7 Tests (dbg)(1)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c245af46fb47db066cbdc99a5f578e2b94b2ca2f", "gitiles_ref:refs/heads/master", "parent_buildername:Win Builder (dbg)", "parent_buildnumber:54265", "scheduler_invocation_id:9098314953818908144", "scheduler_job_id:chromium/Win7 Tests (dbg)(1)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 Tests (dbg)(1)" setup_build
buildnumber 72203 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win Builder (dbg)" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "c245af46fb47db066cbdc99a5f578e2b94b2ca2f" setup_build
parent_got_revision_cp "refs/heads/master@{#599144}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25135}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "c245af46fb47db066cbdc99a5f578e2b94b2ca2f" setup_build
swarm_hashes {"accessibility_unittests": "c572eba4e15cc544ee45b4a0a25f028e86bd1f23", "angle_unittests": "f9f88135c4e1114b52c3dd7edf51d60d4c231184", "app_shell_unittests": "4902f377a8860b25ac3c0449aa3ee0d7272e98e7", "aura_unittests": "ff544d434216cfc9098823ab081de2d48232b0d9", "base_unittests": "dabe0f21c4c565d1bdda447b4fca0db839194d4e", "blink_common_unittests": "876a2dde9a640ab625795054ff0975b0c44c3817", "blink_fuzzer_unittests": "7cdde8fe4edc9e6dad88f80b509c57c1f19a2e90", "blink_heap_unittests": "0f7c51449dba9239bbdf8769f192fc3712d677fd", "blink_platform_unittests": "13da2f428991844deadb65f609a137ca967e6b69", "boringssl_crypto_tests": "f5f215040b5e4add144c498f1eb78b13259b8ef8", "boringssl_ssl_tests": "05f53a0b38177686817bbc9ab9af67426e1215a3", "browser_tests": "af860f5b0ee67848b4c7beace30bc90471e70812", "cacheinvalidation_unittests": "6947f17a5e9d74c698886d2ff6762c4ea6be56a2", "capture_unittests": "ad963271423978fddfc31f3d2a775d3bcf4cd16e", "cast_unittests": "2833a7e23f9110741169ede53a3d1cf38bac769f", "cc_unittests": "11bda41bd2235994786b4c3db0021707e4474312", "chrome_app_unittests": "0203e4d11782ba602abced8b65d5b2fbf1a61aa1", "chrome_cleaner_unittests": "2068a18e70085291362d847e2671769a846c1285", "chrome_elf_import_unittests": "37945ac5667ee909c980595f327ec98cd6663305", "chrome_elf_unittests": "486bc01c28c044c0175eddd8eb43477b551784af", "chromedriver_unittests": "6086b5362760f395b8b0aa3bda7d71cf8cbb6c07", "components_browsertests": "8bb8ac19a82bf1174fb3c5cfc6a3a204c56b8cb7", "components_unittests": "ccd291e28768d7665b670aabe6d4fc27b8fd5568", "compositor_unittests": "f9b9a436b4365e976805bad83425f5d2cf29f540", "content_browsertests": "bd4699cd0a8551345c17b3df429d6e67095b6872", "content_shell_crash_test": "aea6a2fd472ba0ac60f8497ac3e87c1c4c2b7b08", "content_unittests": "e6ec64dd2cd9c058e9ea1a462b7b93b401c1bdb5", "courgette_unittests": "05f8d42b3d6a8c82098a3851919e28af1f557376", "crashpad_tests": "b46bcecab6aaa1402ea455f6677813b8520c0a45", "cronet_tests": "af25d01f2e00647763ec61b03612ebc382ba75b8", "cronet_unittests": "fd64f52f0ae98b51bd0bd3f58c85250fe32a0dbc", "crypto_unittests": "56ce98fc42dafbcf652cae10055b5c9b6b98b9ae", "device_unittests": "5ab5208f778f3b8e832548ead7c2c5d55d14d41e", "display_unittests": "4fb68ec59150fcb6f1a46c1ee19aba2c36a6d73a", "elevation_service_unittests": "9fd81a7c11b6813c420655e61a7992ef7b4eaacc", "events_unittests": "100f5f4f6a05f6dfc10691f632cf20262c4f45fa", "extensions_browsertests": "f433ae1dff05119d892e902bc28f21360f222c89", "extensions_unittests": "4a53eee30fe53d70cbaae9d28759dfbfd65307c7", "filesystem_service_unittests": "25e0f1c0de5f18993e5ebc33d467a8bc7d2b2d0f", "gcm_unit_tests": "704dd86e7fe52f07fe9d7bb81176fe144ec81042", "gfx_unittests": "5de5a2605f04052d4d9859c9a97c3bf2deea2b4d", "gin_unittests": "908357b1a24bcaddaa8bf0b097c96737732c386d", "google_apis_unittests": "ee659a90c9188df52b206aec8e96708c2f4c34ca", "gpu_unittests": "461391fd311d59b3f7e594e19155328a61dc341e", "headless_browsertests": "5279cfe776dfa5cc88ba187c300d51b397f53bb8", "headless_unittests": "0778df80ca7359530633a5a7e2fcab5df0ea3926", "install_static_unittests": "e1d6da9dbf79171f8d50b56e5552239018748998", "installer_util_unittests": "8d32c1b1c76ebf8bfc7d25b5ef7ed1a6aec2004f", "interactive_ui_tests": "8bffbc97c9fed2578f513b59b526de66b1d6d4da", "ipc_tests": "2003e742e1c9af5ef60ec022500e3eeb37657c20", "jingle_unittests": "061b743ef1a885c8d8da3864188fb1a5d93c7474", "latency_unittests": "d9d5ab625315e5486d27cf6eecf197e0578b9eec", "leveldb_service_unittests": "01205cdf59ace548862dda9e33be6ccd7fa43e21", "libjingle_xmpp_unittests": "4b7403cea54c2934aea719e6ad382c261cc5a904", "media_blink_unittests": "31126d432eff45bf205c3c1a462cd43f0d7fff10", "media_service_unittests": "dcd146b627ea098d077b8757ec7a17aa7372aba4", "media_unittests": "215eff82a4e22a69f56b05b3a64bc50ece6c54a7", "message_center_unittests": "b80693465720697d60d109f5709c091633971a12", "metrics_python_tests": "1e4dbd08fb182586547a54de9b83014a5bd3ba13", "midi_unittests": "43138313a1a63debfc175375874d71d813249bb0", "mojo_core_unittests": "a98a0188774395ac5b94bf7dd58950d959375538", "mojo_unittests": "1baaa33ae549613ff797c9aa180a92314f6a025d", "nacl_loader_unittests": "fd6a3ea911aa580ed00d600bfc69b6070379787b", "native_theme_unittests": "9ed8202ed9fe8636394579a29b6a68780ac6f734", "net_unittests": "cae4088844d56e7cf21b2f795dd3aa32b8f235cf", "pdf_unittests": "a78dee108aefe6113f59dd3db25d5373d950387f", "performance_test_suite": "c12c94723950328f703a01a6ee82e79f4e638c12", "ppapi_unittests": "4c883baa16722805dc95fa07a5f50dfa70e29296", "printing_unittests": "0d284014a626abf7b4bd437533b7861aeddb6901", "remoting_unittests": "cef4e25c12d631ea79fa54eb66552a75236bfe9e", "sbox_integration_tests": "d0bcc02631aabe723751cc23511575ce8a5c80e3", "sbox_unittests": "d747c4755674f1fb9257ed8221230ad509e88e09", "sbox_validation_tests": "b37fa1a5d6af74d287f09170e24017296affaf6c", "service_manager_unittests": "d8cc26bd037163c212165581c4e20cac6a80d75c", "services_unittests": "fce368017225491560008b3c5e5ec505e2844325", "setup_unittests": "78b7ef0fca9007aa2b1925703eb23a1a63c54dea", "shell_dialogs_unittests": "2711146927b882350da4064a8feb62452e4ab1b5", "skia_unittests": "7c1babbb367da516898800c69f496a439dc690d2", "snapshot_unittests": "2b3ac6fc87e701b68a002a174566d6eb453ce820", "sql_unittests": "f70250a3579368464a0847aa5bd8f2cd5faf446b", "storage_unittests": "13a2cac31b02372eeddd8f002417966c69233f0a", "sync_integration_tests": "aef2c1f0f9e159ca57f7698c0720d38d6a4784d2", "telemetry_gpu_unittests": "0d6e3977fceb659ce62f8539f312db5817abd8c3", "telemetry_perf_unittests": "fa574ea4d7945ffda379c3f1f8ab2459198fd5e8", "telemetry_unittests": "3446f80b573da32f5e3b921af34164892d223a56", "traffic_annotation_auditor_unittests": "9142faea4de2dc65a564ef3642917de85d2d525f", "ui_base_unittests": "3e13f8a5fc02a26f72222152f6a40bf70d66de3b", "ui_touch_selection_unittests": "b2044a88ccda4473b9aa083a1b1dce8ea819747e", "unit_tests": "40797c41394ce1ce3d8025a6138c0d40d977a221", "url_unittests": "e65137083584efcc78cd13ad8dd746e589fff1f1", "views_perftests": "0b2662449380fb7314273d3c3507a1d9e9f66cdd", "views_unittests": "4ffe8d616785a060d78242b0a75f0e9f487fe826", "viz_unittests": "0676f9c0ba0ea01db134f3fa58fd2eb04a8ae466", "vr_common_unittests": "c58dcf4a6c6530b1d8e97ce972798229ef91d62e", "vr_pixeltests": "f2f8c0a4fa2fe4af813715f3fe347d5fcc241405", "webkit_layout_tests_exparchive": "a55c5d17f880a845ecfd7f1a1b1fce11a2d68d64", "webkit_python_tests": "3274909eb7f05883ab1e84940640b4df6cd05e0d", "webkit_unit_tests": "e6e71851bd85e617fc3ba5e610aef60628b95ebe", "wm_unittests": "c146c6455eb602163fa3997bdd7a06b749f23766", "wtf_unittests": "42503dd54adfe78b41332c775426ecc2f6a0b6d2", "zucchini_unittests": "51a1a0403eb907a6012a92113375ee8b9507deec"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "c245af46fb47db066cbdc99a5f578e2b94b2ca2f" bot_update
got_revision_cp "refs/heads/master@{#599144}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  2. Florent Castelli (orphisohnoyoudont@chromium.org)
  3. Fergal Daly (fergalohnoyoudont@chromium.org)
  4. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  5. A Olsen (olsenohnoyoudont@chromium.org)
  6. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  7. Roman Sorokin (rsorokinohnoyoudont@chromium.org)
  8. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  9. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  10. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  11. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  12. Yuta Kitamura (yutakohnoyoudont@chromium.org)
  13. Eliot Courtney (edcourtneyohnoyoudont@google.com)
  14. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  15. Alexander Alekseev (alemateohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 08:48:49 UTC
Start Friday, 12-Oct-18 08:48:52 UTC
End Friday, 12-Oct-18 09:38:27 UTC
Pending 2 secs
Execution 49 mins 35 secs

All Changes:

  1. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  2. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  3. [css, dom] Support partmap="foo: bar" syntax.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:26:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda

    Comments

    [css, dom] Support partmap="foo: bar" syntax.
    
    This is the new syntax agreed for partmap.
    
    Bug: 805271
    Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1278566
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599142}

    Changed files

    • third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
    • third_party/blink/renderer/core/dom/element_test.cc
    • third_party/blink/renderer/core/dom/names_map.cc
    • third_party/blink/renderer/core/dom/names_map_test.cc
    • third_party/blink/renderer/core/html/parser/html_parser_idioms.h
  4. Chrome OS Powerwash screen: update icon and illustration.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:22:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afc97ac06f5d3677c1016d1530c1e196844e2432

    Comments

    Chrome OS Powerwash screen: update icon and illustration.
    
    
    Bug: 894280
    Change-Id: I0d478790d35323008a0622404ebde6983fea06ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1278211
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599141}

    Changed files

    • chrome/browser/resources/chromeos/login/images/1x/reset_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/images/2x/reset_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/images/reset_illustration_1x.png
    • chrome/browser/resources/chromeos/login/images/reset_illustration_2x.png
    • chrome/browser/resources/chromeos/login/oobe_reset.css
    • chrome/browser/resources/chromeos/login/oobe_reset.html
  5. Move InstallAttributes to chromeos/settings

    Changed by A Olsen - olsenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa6c62dce936e966e2db445045dd04414553642b

    Comments

    Move InstallAttributes to chromeos/settings
    
    Necessary for moving CrosSettings to chromeos/settings, so it
    can eventually be used by Mustash.
    
    The following changes were necessary:
    1. Move install_attributes{.h, .cc} and unit_test.cc
    2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    (destination)
    3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    which is included by install_attributes.h
    
    4. Unfortunately, that same dependency lead to a circular dependency.
    I was able to avoid that by separating out a "common_constants" rule in
    components/policy/core/common, so that chromeos/settings only depends on
    that, and not on all of components/policy. So I had to change
    components/policy/core/common/BUILD.gn
    and I removed an unnecessary include from
    components/policy/core/common/cloud/cloud_policy_constants.cc
    
    5. Update #include directives for install_attributes to point to new
    location. This is the other 22 files, all with diffs of +1 -1.
    
    Bug: 446937
    Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599140}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • chromeos/settings/install_attributes.cc
    • chromeos/settings/install_attributes.h
    • chromeos/settings/install_attributes_unittest.cc
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  6. Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:18:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112288aae86b2fcd3dde5b2a67872e292e54a8b0

    Comments

    Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf
    
    Using wpt-import in Chromium fb7986d88b0b8f174020916003d6939d2d928b83.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hongchan@chromium.org, rtoy@chromium.org:
      external/wpt/webaudio
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02
    Reviewed-on: https://chromium-review.googlesource.com/c/1278059
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599139}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse.html
  7. Override stub path before PreEarlyInitDBus

    Changed by Roman Sorokin - rsorokinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:10:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b80ea1c80ef7c8ec439c14def8120498fc35eda8

    Comments

    Override stub path before PreEarlyInitDBus
    
    Otherwise install attributes are not loaded on the linux Chrome OS
    build.
    
    TEST=manual
    
    Bug: 848615, 729596
    Change-Id: I445b2b337b707822459c076058610f49f02767ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1264643
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599138}

    Changed files

    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/metrics/chrome_feature_list_creator.cc
  8. Chrome OS: Integrate Discover PIN setup into First run UI.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:08:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a

    Comments

    Chrome OS: Integrate Discover PIN setup into First run UI.
    
    Bug: 852553
    Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
    Reviewed-on: https://chromium-review.googlesource.com/c/1250136
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599137}

    Changed files

    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
    • chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/chromeos/login/wizard_controller.cc
    • chrome/browser/chromeos/login/wizard_controller.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc
  9. Fix naming issue when renaming files inside My files

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:02:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40a6cb9be79a8d05395498a705e59d50cbb77f57

    Comments

    Fix naming issue when renaming files inside My files
    
    Change DirectoryModel to "unwrap" VolumeEntry when it's selected via
    file list. This fixes the issue where after selecting a VolumeEntry any
    operation in the private API would fail because it wouldn't be able to
    send a VolumeEntry to private API, because it requires a real Entry.
    
    This fixes the user issue of trying to rename and always getting "Use
    shorter name" error, even with a short name.
    
    Update FakeEntry to be an implementation of FilesAppDirEntry, since all
    users were using as directory, also update some functions to typing to
    use FilesAppDirEntry instead of FakeEntry which is more correct.
    
    Test: browser_tests --gtest_filter="*/myFilesFolderRename"
    Bug: 889636
    Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1276067
    Reviewed-by: Joel Hockey <joelhockey@chromium.org>
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599136}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • ui/file_manager/file_manager/background/js/volume_info_impl.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
    • ui/file_manager/file_manager/foreground/js/file_watcher.js
    • ui/file_manager/integration_tests/file_manager/my_files.js
  10. media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:54:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 029544dab67d79059b7610a92890091520ef7603

    Comments

    media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.
    
    libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make
    it return 0 planes for single-plane multiplanar formats. We obviously
    cannot have a multiplanar format with 0 planes, so add a workaround at
    the fake-ioctl level. Implement it as a case-switch for future-proofing
    against other workarounds we will likely have to add.
    
    Also add a few recommendations in v4l2_device.cc against the temptation
    to spare some memory by using an appropriately-sized array of
    v4l2_planes: it turns out libv4l2 also likes to write above the number
    of passed planes, and using anything shorter than VIDEO_MAX_PLANES will
    result in memory corruption DCHECKS being raised.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on both hana and nyan_big.
    
    Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225
    Reviewed-on: https://chromium-review.googlesource.com/c/1275727
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599135}

    Changed files

    • media/gpu/v4l2/tegra_v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.cc
  11. Add browser tests for when we show the cookie exception

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:53:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df554d02051d43d493d30cdf39fb1ee7566355bf

    Comments

    Add browser tests for when we show the cookie exception
    
    Depending on the sync / sign-in state.
    
    BUG=890925
    R=tangltom@chromium.org, msarda@chromium.org
    
    Change-Id: I784f13a4981250f851df770d111a13969a6892a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1273521
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599134}

    Changed files

    • chrome/browser/browsing_data/counters/browsing_data_counter_utils_browsertest.cc
    • chrome/test/BUILD.gn
  12. Move thread-related functionalities in Platform to Thread.

    Changed by Yuta Kitamura - yutakohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:47:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9deeac4682dc2c2a45fdf483c376c75011a09241

    Comments

    Move thread-related functionalities in Platform to Thread.
    
    This CL moves the most of implementation for Thread in Platform to
    Thread, so the Platform would contain less implementation (ideally,
    Platform should be a pure interface to embedders).
    
    Previously the global state of threads was stored in Platform, and
    this CL moves it to Thread. Now the thread-local storage for Blink
    threads and the main and compositor thread objects are stored as
    the global variable in thread.cc. This way, the threads state is
    completely separated from Platform. Old threading functions in
    Platform are deprecated now, and they will be migrated to Thread ones
    later.
    
    Due to those changes, some test utilities need to be updated. As the
    state of threads is not stored in Platform, the tests that need to
    override their main thread have to do that by themselves. To
    facilitate this, two new utility classes, ScopedMainThreadOverrider
    and ScopedSchedulerOverrider, are introduced, and TestingPlatform-
    SupportWithCustomScheduler is removed in favor of the new utilities.
    
    Bug: 826203
    Change-Id: Ieb702dc85b7ffd75991055038f1165c2bfd7d058
    Reviewed-on: https://chromium-review.googlesource.com/c/1273115
    Commit-Queue: Yuta Kitamura <yutak@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599133}

    Changed files

    • content/renderer/render_thread_impl.cc
    • third_party/blink/public/platform/platform.h
    • third_party/blink/renderer/core/dom/idle_deadline_test.cc
    • third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/exported/platform.cc
    • third_party/blink/renderer/platform/scheduler/common/thread.cc
    • third_party/blink/renderer/platform/scheduler/public/thread.h
    • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.cc
    • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.h
    • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.cc
    • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.h
    • third_party/blink/renderer/platform/testing/testing_platform_support.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
  13. Let ClientControlledState apply animation during bounds change.

    Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 07:45:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68084907a40caccccb72dd14c0ad3139b97747f7

    Comments

    Let ClientControlledState apply animation during bounds change.
    
    This CL introduces a new BoundsChangeAnimationType for
    ClientControlledState which will animate the window bounds for a
    specified duration.
    
    Bug: b/115291749
    Bug: 841886
    Test: Tested with local PIP prototype - applies animation.
    Change-Id: I8eda8b2131b8d3f679ade5cfbe64d7378efd6881
    Reviewed-on: https://chromium-review.googlesource.com/c/1218385
    Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599132}

    Changed files

    • ash/wm/client_controlled_state.cc
    • ash/wm/client_controlled_state.h
    • ash/wm/client_controlled_state_unittest.cc
    • ash/wm/default_state.cc
    • ash/wm/window_state.cc
    • ash/wm/window_state.h
    • ash/wm/wm_event.cc
    • ash/wm/wm_event.h
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc
  14. [iOS] Remove ReadingList empty view

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:44:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a53cbb1cdf96e0695e4d24cd408b52cc826d5088

    Comments

    [iOS] Remove ReadingList empty view
    
    This view was used in the old ReadingList implementation.
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Id4fa1df5a00f0dd572a2d4951764f422231e3874
    Reviewed-on: https://chromium-review.googlesource.com/c/1276966
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599131}

    Changed files

    • ios/chrome/browser/ui/reading_list/BUILD.gn
    • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.h
    • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.mm
    • ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
  15. Chrome OS: Integrate PIN setup into Discover UI

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:43:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f479db8f992be027ddc9b715919df65ad4e40bb6

    Comments

    Chrome OS: Integrate PIN setup into Discover UI
    
    Bug: 852553
    Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1249496
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599130}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_SUBTITLE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_TITLE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/resources/chromeos/login/discover/discover_app.html
    • chrome/browser/resources/chromeos/login/discover/discover_app.js
    • chrome/browser/resources/chromeos/login/discover/discover_components.html
    • chrome/browser/resources/chromeos/login/discover/discover_components.js
    • chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
    • chrome/browser/resources/chromeos/login/discover/discover_ui.html
    • chrome/browser/resources/chromeos/login/discover/discover_ui.js
    • chrome/browser/resources/chromeos/login/discover/discover_welcome.css
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js
    • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/screen_discover.html
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
    • chrome/common/extensions/api/_api_features.json