Home | Search | chromium - Builders
Login

Builder Win7 Tests (dbg)(1) Build 70814 Microsoft Windows

Results:

Failure network_service_browser_tests Failure webkit_layout_tests (experimental)

Trigger Info:

Projectchromium
Revision6df1590559bd965c71b181b4d948e0ea3318189a
Got Revision6df1590559bd965c71b181b4d948e0ea3318189a

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Peter Kasting (pkastingohnoyoudont@chromium.org)
  2. Yuwei Huang (yuweihohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 05:46:11 UTC
Start Saturday, 11-Aug-18 05:46:35 UTC
End Saturday, 11-Aug-18 06:49:39 UTC
Pending 24 secs
Execution 1 hrs 3 mins

All Changes:

  1. Revert "Remove unnecessary tab key press from Focus_AdvanceFocus test"

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 05:15:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6df1590559bd965c71b181b4d948e0ea3318189a

    Comments

    Revert "Remove unnecessary tab key press from Focus_AdvanceFocus test"
    
    This reverts commit 5eeadd143332f6fc6c26af924d8a38d5f49b06a2.
    
    Reason for revert: Seems to have caused failures on mac_cocoa_rel, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477439492256/+/steps/interactive_ui_tests/0/logs/WebViewFocusInteractiveTest.Focus_AdvanceFocus/0
    
    Original change's description:
    > Remove unnecessary tab key press from Focus_AdvanceFocus test
    > 
    > The associated bug which required this extra tab is fixed.
    > 
    > Bug: 147644
    > Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343
    > Reviewed-on: https://chromium-review.googlesource.com/1170986
    > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
    > Commit-Queue: Kevin McNee <mcnee@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582240}
    
    TBR=ekaramad@chromium.org,mcnee@chromium.org
    
    Change-Id: I6c84e6950d7f74ae5b15eec084a536115e635ceb
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 147644
    Reviewed-on: https://chromium-review.googlesource.com/1172002
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582429}

    Changed files

    • chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  2. [CRD iOS] Make ChromotingSession own the AudioStub

    Changed by Yuwei Huang - yuweihohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 04:59:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 206d44a2086dc771c898b5d3f9da0bcd95f6c0a7

    Comments

    [CRD iOS] Make ChromotingSession own the AudioStub
    
    Previously AudioStub is owned by the the (Remoting|Jni)Client class and
    being passed to ChromotingSession as a WeakPtr. The AudioStub is not
    used after it is passed to ChromotingSession and it is a burden for the
    *Client class to manage its lifetime.
    
    This CL fixes this by making ChromotingSession own the AudioStub.
    
    Bug: 868088
    Change-Id: I067f321b3aab7110df7bb85a8b8c519ea889865e
    Reviewed-on: https://chromium-review.googlesource.com/1171840
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582428}

    Changed files

    • remoting/client/audio/audio_playback_stream.cc
    • remoting/client/audio/audio_playback_stream.h
    • remoting/client/chromoting_session.cc
    • remoting/client/chromoting_session.h
    • remoting/client/jni/jni_client.cc
    • remoting/client/jni/jni_client.h
    • remoting/ios/session/remoting_client.mm