Builder Win7 FYI x64 Release (NVIDIA)
Build 3975
Results:
Success
Trigger Info:
Project | chromium |
Revision | 7d2d2b1e2b26ec1585384bbcd3dae15495a69a9f |
Got Revision | 7d2d2b1e2b26ec1585384bbcd3dae15495a69a9f |
Execution:
- Source: Task 426f3f88451b9610
- Bot: swarm765-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 251 ms ) report buildersrunning tester 'Win7 FYI x64 Release (NVIDIA)' on master 'chromium.gpu.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
-
( 461 ms ) lookup builder GN argsbuild_angle_gles1_conform_tests = truedcheck_always_on = trueffmpeg_branding = "Chrome"internal_gles2_conform_tests = trueis_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
-
- - no logs -
-
( 6 secs ) [trigger] angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
- - no logs -
-
( 4 secs ) angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Max shard duration: 0:02:22.389480 (shard #3)Min shard duration: 0:02:07.043222 (shard #1)
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] angle_gles1_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 1 secs ) angle_gles1_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 43s
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 3 secs ) angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 49s
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 1 secs ) angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 28s
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] tab_capture_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 2 mins 31 secs ) tab_capture_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:02:27.198923
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 984 ms ) gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 34s
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 1 secs ) gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 24s
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 967 ms ) gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 27s
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] gles2_conform_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 1 secs ) gles2_conform_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:01:37.993112
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 913 ms ) gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:01:23.763277
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 986 ms ) gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:01:14.263620
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] gpu_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 2 secs ) gpu_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 41s
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] swiftshader_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 808 ms ) swiftshader_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 25s
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] video_decode_accelerator_d3d11_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 1 secs ) video_decode_accelerator_d3d11_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 36s
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] video_decode_accelerator_d3d9_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 944 ms ) video_decode_accelerator_d3d9_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 34s
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] video_decode_accelerator_gl_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 1 secs ) video_decode_accelerator_gl_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 32s
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 3 mins 45 secs ) context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:03:34.408840Total tests: 10* Passed: 10 (10 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 2 mins 21 secs ) depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:02:11.012876Total tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 2 mins 52 secs ) gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:02:45.405714Total tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 2 mins 8 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:02:04.524921Total tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 1 mins 57 secs ) info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:01:52.440261Total tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 1 mins 57 secs ) maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:01:52.855157Total tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 5 mins 43 secs ) pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:05:34.118698Total tests: 58* Passed: 58 (58 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 2 mins 30 secs ) screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:02:23.663076Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 3 secs ) test_pre_run.[trigger] trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 4 mins 23 secs ) trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Shard duration: 0:04:16.387762Total tests: 48* Passed: 24 (24 expected, 0 unexpected)* Skipped: 24 (24 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 25 secs ) test_pre_run.[trigger] webgl2_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 21 mins 26 secs ) webgl2_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Max pending time: 0:11:24.903352 (shard #19)Max shard duration: 0:10:29.189488 (shard #18)Min shard duration: 0:08:04.780101 (shard #1)Total tests: 2803* Passed: 2740 (2740 expected, 0 unexpected)* Skipped: 63 (63 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (399.4 sec)
- shard #1 isolated out
- shard #1 (396.9 sec)
- shard #2 isolated out
- shard #2 (407.2 sec)
- shard #3 isolated out
- shard #3 (453.6 sec)
- shard #4 isolated out
- shard #4 (447.8 sec)
- shard #5 isolated out
- shard #5 (431.2 sec)
- shard #6 isolated out
- shard #6 (461.0 sec)
- shard #7 isolated out
- shard #7 (456.8 sec)
- shard #8 isolated out
- shard #8 (502.0 sec)
- shard #9 isolated out
- shard #9 (444.4 sec)
- shard #10 isolated out
- shard #10 (441.0 sec)
- shard #11 isolated out
- shard #11 (415.8 sec)
- shard #12 isolated out
- shard #12 (430.6 sec)
- shard #13 isolated out
- shard #13 (397.6 sec)
- shard #14 isolated out
- shard #14 (405.0 sec)
- shard #15 isolated out
- shard #15 (496.1 sec)
- shard #16 isolated out
- shard #16 (424.4 sec)
- shard #17 isolated out
- shard #17 (380.0 sec)
- shard #18 isolated out
- shard #18 (524.4 sec)
- shard #19 isolated out
- shard #19 (488.9 sec)
-
- - no logs -
-
( 4 secs ) test_pre_run.[trigger] webgl_conformance_d3d11_validating_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 8 mins 41 secs ) webgl_conformance_d3d11_validating_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Max shard duration: 0:08:36.811777 (shard #1)Min shard duration: 0:04:50.679464 (shard #0)Total tests: 938* Passed: 931 (931 expected, 0 unexpected)* Skipped: 7 (7 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 4 secs ) test_pre_run.[trigger] webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 26 mins ) webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Max pending time: 0:17:07.753950 (shard #1)Max shard duration: 0:08:49.233209 (shard #1)Min shard duration: 0:04:31.268700 (shard #0)Total tests: 938* Passed: 931 (931 expected, 0 unexpected)* Skipped: 7 (7 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 10 secs ) test_pre_run.[trigger] webgl_conformance_d3d9_validating_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 5 mins 17 secs ) webgl_conformance_d3d9_validating_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Max pending time: 28s (shard #5)Max shard duration: 0:05:12.993830 (shard #3)Min shard duration: 0:02:33.072344 (shard #2)Total tests: 938* Passed: 928 (928 expected, 0 unexpected)* Skipped: 10 (10 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (75.7 sec)
- shard #1 isolated out
- shard #1 (57.9 sec)
- shard #2 isolated out
- shard #2 (68.5 sec)
- shard #3 isolated out
- shard #3 (215.0 sec)
- shard #4 isolated out
- shard #4 (105.0 sec)
- shard #5 isolated out
- shard #5 (159.9 sec)
-
- - no logs -
-
( 5 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 9 mins 2 secs ) webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Max shard duration: 0:08:51.546621 (shard #1)Min shard duration: 0:03:51.936774 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 4 secs ) test_pre_run.[trigger] webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 9 mins 4 secs ) webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Max shard duration: 0:08:48.917223 (shard #1)Min shard duration: 0:04:30.858078 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 4 secs ) test_pre_run.[trigger] webgl_conformance_vulkan_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'
-
( 10 mins 20 secs ) webgl_conformance_vulkan_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1Run on OS: 'Windows-2008ServerR2-SP1'Max shard duration: 0:10:07.020622 (shard #1)Min shard duration: 0:03:21.914014 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm765-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547638275456029, "id": "8924177363633637920", "project": "chromium", "tags": ["builder:Win7 FYI x64 Release (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/7d2d2b1e2b26ec1585384bbcd3dae15495a69a9f", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win x64 Builder", "parent_buildnumber:26701", "scheduler_invocation_id:9089607425683604224", "scheduler_job_id:chromium/Win7 FYI x64 Release (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Win7 FYI x64 Release (NVIDIA)" | setup_build |
buildnumber | 3975 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
parent_buildername | "GPU FYI Win x64 Builder" | setup_build |
parent_got_angle_revision | "ab2bfa814ceefdcbe24483b3a12ba525345d486c" | setup_build |
parent_got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | setup_build |
parent_got_dawn_revision | "acd8b7d937cc4dcc81856377863f2d56af7037b5" | setup_build |
parent_got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | setup_build |
parent_got_revision | "7d2d2b1e2b26ec1585384bbcd3dae15495a69a9f" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#623193}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "871f913bad24b4ead79468f431a1ae8326d9d27b" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.412@{#1}" | setup_build |
parent_got_webrtc_revision | "ccc1b57e32bd99e4f220a3db0e540713f4349ad9" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26266}" | setup_build |
parent_mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "7d2d2b1e2b26ec1585384bbcd3dae15495a69a9f" | setup_build |
swarm_hashes | {"angle_end2end_tests": "72f89272884f39c9ba43f100b2c8c9f983b37459", "angle_gles1_conformance_tests": "aff96be092727133b69e5153216603ffd07d7561", "angle_unittests": "441450d46828a90a7c03cc373fc5d8577bf9c9a4", "angle_white_box_tests": "0c7d61a0e5d4035ac577f314e072c4b0f6b17cfc", "browser_tests": "3d28bb0d127f3f113d4a14d9292dcec804df0f73", "gl_tests": "daa0266517437632cfd8c5c8392afab8d013fd1f", "gl_unittests": "c9131034a7c9bf1ee8e921326752765fe04f1e7c", "gles2_conform_test": "4358f8c713091155896b3c355837b604da016fb1", "gpu_unittests": "d9218482e4d26a4984f5b4a9859410c0e443b460", "swiftshader_unittests": "9c680cd481c92c4ca85a4f0a4264ec7e9fb74948", "telemetry_gpu_integration_test": "b8fad0da403eef8785b86aa2ea339886b7ce8f1e", "video_decode_accelerator_unittest": "17ea7ea1d6cbbcfc364f9cf673e4aa5957464850"} | setup_build |
got_angle_revision | "ab2bfa814ceefdcbe24483b3a12ba525345d486c" | bot_update |
got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | bot_update |
got_dawn_revision | "acd8b7d937cc4dcc81856377863f2d56af7037b5" | bot_update |
got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | bot_update |
got_revision | "7d2d2b1e2b26ec1585384bbcd3dae15495a69a9f" | bot_update |
got_revision_cp | "refs/heads/master@{#623193}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "871f913bad24b4ead79468f431a1ae8326d9d27b" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.412@{#1}" | bot_update |
got_webrtc_revision | "ccc1b57e32bd99e4f220a3db0e540713f4349ad9" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26266}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Dominik Röttsches (drottohnoyoudont@chromium.org)
- Hans Wennborg (hansohnoyoudont@chromium.org)
- Henrique Ferreiro (hferreiroohnoyoudont@igalia.com)
- Marc Treib (treibohnoyoudont@chromium.org)
- Carlos Caballero (carlscabohnoyoudont@google.com)
- Lowell Manners (lowellohnoyoudont@chromium.org)
- Sergio Villar Senin (svillarohnoyoudont@igalia.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Mario Sanchez Prada (marioohnoyoudont@igalia.com)
- Jonas Olsson (jonasolssonohnoyoudont@chromium.org)
- Oleg Davydov (burundukohnoyoudont@google.com)
- Christos Froussios (cfroussiosohnoyoudont@chromium.org)
- Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
- Lowell Manners (lowellohnoyoudont@chromium.org)
- Laís Minchillo (laisminchilloohnoyoudont@chromium.org)
- Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
- Michael Lippautz (mlippautzohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Shakti Sahu (shaktisahuohnoyoudont@chromium.org)
- Ioana Pandele (ioanapohnoyoudont@chromium.org)
- Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
- Yi Su (mrsuyiohnoyoudont@chromium.org)
- Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
- Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Yi Su (mrsuyiohnoyoudont@chromium.org)
- Arthur Hemery (ahemeryohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 16-Jan-19 11:31:15 UTC |
Start | Wednesday, 16-Jan-19 11:31:17 UTC |
End | Wednesday, 16-Jan-19 13:38:58 UTC |
Pending | 1 secs |
Execution | 2 hrs 7 mins |
All Changes:
-
Make Font Table construction resilient to lack of font pathname
Changed by Dominik Röttsches - drottohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 11:14:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7d2d2b1e2b26ec1585384bbcd3dae15495a69a9f Comments
Make Font Table construction resilient to lack of font pathname If we were unable to retrieve a path for a font registered in the system font collection, continue with the next font in the system font collection, instead of hitting the assertion. Speculative fix for such cases seen in the wild, unable to reproduce locally as it probably is hit for corrupt fonts or an invalid font registration in the registry. Bug: 922183 Change-Id: Ic071cee9a16ef0cb3a6fe095474348e437d65459 Reviewed-on: https://chromium-review.googlesource.com/c/1414852 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#623193}
Changed files
- content/browser/renderer_host/dwrite_font_proxy_impl_win.cc
-
Clang: the tip-of-tree version is now 9
Changed by Hans Wennborg - hansohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 11:09:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 70d9d4df426e299d1f7d68d8d6215594afe21a6d Comments
Clang: the tip-of-tree version is now 9 TBR=thakis Bug: 922386 Change-Id: I14856f18ea5025fd9f1fd813e3fe87bdb787a656 Reviewed-on: https://chromium-review.googlesource.com/c/1412828 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#623192}
Changed files
- build/toolchain/toolchain.gni
- tools/clang/scripts/update.py
-
Port signin_ui_util.cc away from ListAccounts()
Changed by Henrique Ferreiro - hferreiroohnoyoudont@igalia.com Changed at Wednesday, 16-Jan-19 10:58:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6bc26cfa47ea4d893086e9839ce07297a54fc422 Comments
Port signin_ui_util.cc away from ListAccounts() The CL removes the dependency on GaiaCookieManagerService Bug: 921501 Change-Id: I948d868c437d99399050192f6efd4667cf0e12ac Reviewed-on: https://chromium-review.googlesource.com/c/1411922 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#623191}
Changed files
- chrome/browser/signin/signin_ui_util.cc
-
SyncService::GetActiveDataTypes: return "none" if there is a persistent auth error
Changed by Marc Treib - treibohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:54:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision afab2e5e80bd6db6d6723f08b6e3ab531948537e Comments
SyncService::GetActiveDataTypes: return "none" if there is a persistent auth error This seems like the safer (and more accurate) interpretation of "active". In particular, this will affect the "Sync paused" state, for which we previously claimed that all data types were active. Bug: 913984 Change-Id: Iea5b0fd113cfc2d12b7173205302abb8fa862cc7 Reviewed-on: https://chromium-review.googlesource.com/c/1402877 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#623190}
Changed files
- chrome/browser/sync/test/integration/profile_sync_service_harness.cc
- chrome/browser/sync/test/integration/profile_sync_service_harness.h
- chrome/browser/sync/test/integration/sync_auth_test.cc
- components/browser_sync/profile_sync_service.cc
-
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in drive_backend
Changed by Carlos Caballero - carlscabohnoyoudont@google.com Changed at Wednesday, 16-Jan-19 10:50:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4fcb3e56c3585e1d48d54a30e03eddd743a13113 Comments
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in drive_backend MessageLoop will go away, eventually. BUG=891670 Change-Id: Ia64f78ea238b99b0599cfec331ffaa764742399b Reviewed-on: https://chromium-review.googlesource.com/c/1377853 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#623189}
Changed files
- chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc
- chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
- chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc
-
Make secondary account sync tests share a single TestURLLoaderFactory.
Changed by Lowell Manners - lowellohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:49:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 49be60bf098342ba3242522312d02cdd2ed1e149 Comments
Make secondary account sync tests share a single TestURLLoaderFactory. Before this change, these tests had multiple TestURLLoaderFactory instances. One, which is declared in SyncTest, plus an additional instance each time BuildFakeGaiaCookieManagerServiceWithOptions was invoked. Eventually, FakeGCMS will be eliminated entirely in these tests. This change separates out one of the logical side effects of eliminating FakeGCMS, which that there will be a single TestURLLoaderFactory instance. We are splitting out this change to be able to verify whether the switch to a single shared factory was the cause of the flake in https://chromium-review.googlesource.com/c/chromium/src/+/1396148. Our suspicion is that the flake was rather caused by the fact that in that CL, the TestURLLoaderFactory was *not* used by the main profile, whereas prior to that CL FakeGCMS instances had been installed for all Profiles. Assuming that this change sticks, we will follow it up by hiding the usage of |test_url_loader_factory_| inside a new SecondarySyncTest class, thus eliminating the passing of the raw pointer. This is part of step 1a of the plan to eliminate FakeGCMS entirely: TBR=rkaplow@chromium.org https: //docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Change-Id: I86837090af84e94bdd9887ac9ee5e9c96bbef8da Bug: 907782 Reviewed-on: https://chromium-review.googlesource.com/c/1411877 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#623188}
Changed files
- chrome/browser/metrics/ukm_browsertest.cc
- chrome/browser/sync/test/integration/secondary_account_helper.cc
- chrome/browser/sync/test/integration/secondary_account_helper.h
- chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc
- chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
- chrome/browser/sync/test/integration/sync_test.h
-
Port AvatarToolbarButton away from GaiaCookieManagerService callbacks
Changed by Sergio Villar Senin - svillarohnoyoudont@igalia.com Changed at Wednesday, 16-Jan-19 10:48:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1fa3981d86535dfddfab2fc89ded02b5610b847f Comments
Port AvatarToolbarButton away from GaiaCookieManagerService callbacks It was observing the gaia cookie manager service to know whether the list of gaia accounts in the cookie jar has changed. That can be achieved observing IdentityManager as well. Bug: 921008 Change-Id: Icad5a14f1288346b97d4d8ccc1eb4c0a901eae3b Reviewed-on: https://chromium-review.googlesource.com/c/1408928 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#623187}
Changed files
- chrome/browser/ui/views/profiles/avatar_toolbar_button.cc
- chrome/browser/ui/views/profiles/avatar_toolbar_button.h
-
Roll src/third_party/perfetto 4a0ee4e0ef36..e2f79261ed5f (11 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 16-Jan-19 10:48:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9c3c23072d1b4db1b2b4c0f5eca7cc0f246063bd Comments
Roll src/third_party/perfetto 4a0ee4e0ef36..e2f79261ed5f (11 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/4a0ee4e0ef36..e2f79261ed5f git log 4a0ee4e0ef36..e2f79261ed5f --date=short --no-merges --format='%ad %ae %s' 2019-01-16 primiano@google.com Disable heap profiling e2e tests 2019-01-15 oysteine@google.com Fix integer sign mismatch error preventing Chrome autoroll 2019-01-15 rsavitski@google.com heapprofd: minimally-functioning fork mode 2019-01-15 treehugger-gerrit@google.com Merge "base: add missing PERFETTO_EXPORT to ThreadChecker" 2019-01-15 hjd@google.com Merge "perfetto-ui: Refactor high frequancy state" 2019-01-15 primiano@google.com Ftrace: fall back on set_event interface if /enable fails 2019-01-15 eseckler@google.com Merge "Add PERFETTO_EXPORT onto the ScatteredHeapBuffer and sub class SLICE" 2019-01-15 eseckler@google.com Merge "Add two additional stats (rewritten & out-of-order) related to writing chunks." 2019-01-15 eseckler@google.com Merge "gn: Make it more convenient for embedders to enable DLOG" 2019-01-15 ilkos@google.com Allow arbitrary config in tmux tool 2019-01-15 lalitm@google.com Merge "trace_processor: add userspace LMK events to the instants table" Created with: gclient setdep -r src/third_party/perfetto@e2f79261ed5f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:121352331,chromium:78791178,chromium:120185246,chromium:122609457 TBR=perfetto-bugs@google.com Change-Id: I1d8dae96d1532c2bdc1f5971d8a639fe1c0eaf08 Reviewed-on: https://chromium-review.googlesource.com/c/1414698 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623186}
Changed files
- DEPS
-
Migrate PeopleHandler to the IdentityManager
Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com Changed at Wednesday, 16-Jan-19 10:36:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cacfd35f4e09cbbd969a2c882f3db0eccc127bc0 Comments
Migrate PeopleHandler to the IdentityManager Use the APIs from IdentityManager and PrimaryAccountsMutator to migrate calls previously depending on SigninManager and ProfileOAuth2TokenService. Bug: 898810, 920236, 920237, 921445 Change-Id: I22b046bae82e2539d165d95573c27d47affa6a06 Reviewed-on: https://chromium-review.googlesource.com/c/1298994 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#623185}
Changed files
- chrome/browser/ui/webui/settings/people_handler.cc
- chrome/browser/ui/webui/settings/people_handler_unittest.cc
-
Keep the StreamBrokerDisconnectReason histograms a bit longer.
Changed by Jonas Olsson - jonasolssonohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:35:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision abca1d5ed36092b8877044587a89baed3b5a3941 Comments
Keep the StreamBrokerDisconnectReason histograms a bit longer. Bug: chromium:919650 chromium:919651 Change-Id: I15130a3f0e179532dc90fb7ae2ac8f142de1a641 Reviewed-on: https://chromium-review.googlesource.com/c/1412457 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Cr-Commit-Position: refs/heads/master@{#623184}
Changed files
- tools/metrics/histograms/histograms.xml
-
Remove check for client registration in StatusUploader ctor
Changed by Oleg Davydov - burundukohnoyoudont@google.com Changed at Wednesday, 16-Jan-19 10:35:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 43132ffeb2245cfc7996e11acfeffb163ab0a380 Comments
Remove check for client registration in StatusUploader ctor StatusUploader's work makes sence only if working on managed device with resitered client, but due to some missynchonizations we may not know if it's registered client when creating StatusUploader. That's why there is an extra registered check before submitting status. See more in: https://bugs.chromium.org/p/chromium/issues/detail?id=705607 Therefore check in StatusUploader constructor is redundant and causes only problems when dchecks are enabled: https://bugs.chromium.org/p/chromium/issues/detail?id=912770 Bug: 912770 Change-Id: Ib9c4001b87834286a36cbe3ca123f1c456844ad9 Reviewed-on: https://chromium-review.googlesource.com/c/1400664 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleg Davydov <burunduk@google.com> Cr-Commit-Position: refs/heads/master@{#623183}
Changed files
- chrome/browser/chromeos/policy/status_uploader.cc
-
[Password Manager] More precise errors for failure on LinuxPasswordsMigrationToEncryptionStatus
Changed by Christos Froussios - cfroussiosohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:32:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b965b53f7730d269c56675dd0fc2f39dea07a2ee Comments
[Password Manager] More precise errors for failure on LinuxPasswordsMigrationToEncryptionStatus When migrating away from the native backend, the most common cause of failure are operations on the temporary database. I've split the error code for further insight. Bug: 571003 Change-Id: I382e62ebeb9c85306526bcd6978a1aa41a5e79fc Reviewed-on: https://chromium-review.googlesource.com/c/1411609 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#623182}
Changed files
- chrome/browser/password_manager/password_store_x.cc
- chrome/browser/password_manager/password_store_x.h
- components/password_manager/core/browser/password_manager_metrics_util.h
- tools/metrics/histograms/enums.xml
-
[iOS][MF] Restore original keyboard for pickers
Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:31:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6897877855447b9e93eaa8a3c0e48ad5ac37ace9 Comments
[iOS][MF] Restore original keyboard for pickers When the keyboard changes to a picker restore it, so the user can select one of the options from the site. The user is still able to go back into the manual fallback menu for consultation, touching the options won't work though. Bug: 914766 Change-Id: I23b4d91bc2833705fe5cec8250e5eac27c5083d4 Reviewed-on: https://chromium-review.googlesource.com/c/1411931 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#623181}
Changed files
- ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
-
Add a factory method to create a FakeGCMS with a TestURLLoaderFactory.
Changed by Lowell Manners - lowellohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:31:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9b4e49741e91a48a3a3eccd25c100354de3c5f07 Comments
Add a factory method to create a FakeGCMS with a TestURLLoaderFactory. This new factory method is meant to replace BuildFakeGaiaCookieManagerServiceWithOptions in the cases where create_fake_url_loader_factory_for_cookie_requests is set to true. Callers of BuildFakeGaiaCookieManagerServiceWithOptions will be migrated to use this new factory method in a future CL. This is part of step 1a of the plan to eliminate FakeGCMS entirely: https: //docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Change-Id: Ia26dbe429743e30b86130106d3909a3320e4ba2d Bug: 907782 Reviewed-on: https://chromium-review.googlesource.com/c/1412456 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#623180}
Changed files
- chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
- chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
-
[aw] Add proxy override integration tests
Changed by Laís Minchillo - laisminchilloohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:23:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8c5b7240984937fe41ca7fa76bab6d8c8dd1c215 Comments
[aw] Add proxy override integration tests Bug: 902215 Change-Id: Ibac9527580253aa924ed8c553bb5f01f47e368aa Reviewed-on: https://chromium-review.googlesource.com/c/1391561 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#623179}
Changed files
- android_webview/javatests/src/org/chromium/android_webview/test/AwProxyControllerTest.java
- android_webview/test/BUILD.gn
- testing/buildbot/filters/mojo.fyi.network_webview_instrumentation_test_apk.filter
-
Convert from base::{LazyInstance,Singleton} to base::NoDestructor
Changed by Sylvain Defresne - sdefresneohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:22:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8b07207aff59d8d0a19e6af45e95e3431f998ffe Comments
Convert from base::{LazyInstance,Singleton} to base::NoDestructor The class base::NoDestructor is a simpler way to define a static global value (aka a singleton) than base::{LazyInstance,Singleton} and is the recommended pattern to use. The changes were automated using a custom one-shot script, then fine tuned by hand (to remove unnecessary classes, ...). This fixes usages in src/ios/chrome/browser/ui/webui. This CL was uploaded by git cl split. Bug: none Change-Id: I0f2864e73cf4e99a07384d29dfd0c5c705a9dc85 Reviewed-on: https://chromium-review.googlesource.com/c/1411785 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#623178}
Changed files
- ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h
- ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm
-
unified-heap: Provide names for internal classes in heap snapshot
Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:09:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 43ae85f867e407a557e0e7671cbcc07dd2688e16 Comments
unified-heap: Provide names for internal classes in heap snapshot Provide a name for internal nodes in non-production builds. This is very useful for manual debugging builds but may confuse people without providing better DevTools integration. Bug: 843903 Change-Id: Ifd7359575beb3c916a86fc6091abfc20c76e6b64 Reviewed-on: https://chromium-review.googlesource.com/c/1412472 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#623177}
Changed files
- third_party/blink/renderer/platform/heap/name_trait_test.cc
- third_party/blink/renderer/platform/heap/name_traits.h
- third_party/blink/web_tests/inspector-protocol/heap-profiler/heap-snapshot-merged-nodes.js
- third_party/blink/web_tests/inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.js
- third_party/blink/web_tests/inspector-protocol/heap-profiler/heap-snapshot-with-multiple-retainers.js
-
Roll src-internal 5631ed218f7e..f2c8fe4e24b3 (7 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 16-Jan-19 10:07:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ade728f52493877707ef97c941c06ab77d0addda Comments
Roll src-internal 5631ed218f7e..f2c8fe4e24b3 (7 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5631ed218f7e..f2c8fe4e24b3 Created with: gclient setdep -r src-internal@f2c8fe4e24b3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic38853d87d4b9222be558da9bb752c0703afa66b Reviewed-on: https://chromium-review.googlesource.com/c/1414697 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623176}
Changed files
- DEPS
-
Download Home : Fixed padding on empty view on Articles for You section
Changed by Shakti Sahu - shaktisahuohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:01:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d60c7ccbe2128008c62c2da9e23de664c39170a3 Comments
Download Home : Fixed padding on empty view on Articles for You section This CL improves the UI (attached screenshot) as per mocks : https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZa-WKS_VfBWp/files/MCHtA7U1iMGr6yF79JTTnBdi9vOmcRvRxmM Bug: 902403 Change-Id: I7fd6b64a70531f28e5ba6fc8428198bf5c771c58 Reviewed-on: https://chromium-review.googlesource.com/c/1412822 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#623175}
Changed files
- chrome/android/java/res_download/layout/downloads_empty_view.xml
-
Remove click handler for the link in the password generation popup
Changed by Ioana Pandele - ioanapohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 09:41:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 893c068d35a42afd462e3caebc35ef3814af99f8 Comments
Remove click handler for the link in the password generation popup The link has already been removed, both on desktop and Android, but the click handler was not. Note: On Android, the popup is now used only to display the help text. Bug: 862269 Change-Id: Ie6fbe83c45b029fccb4fd32d228a53bdd527d5f0 Reviewed-on: https://chromium-review.googlesource.com/c/1409451 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#623174}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java
- chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc
- chrome/browser/ui/android/autofill/password_generation_popup_view_android.h
- chrome/browser/ui/passwords/password_generation_popup_controller.h
- chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc
- chrome/browser/ui/passwords/password_generation_popup_controller_impl.h
- chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc
- chrome/browser/ui/views/passwords/password_generation_popup_view_views.h
-
s13n: Remove SigninManager-related includes from identity_apitest.cc
Changed by Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com Changed at Wednesday, 16-Jan-19 09:35:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 81cd63979e7fb20cbc42824992cde618a04941d8 Comments
s13n: Remove SigninManager-related includes from identity_apitest.cc This CL cleans up the unnecessary includes related to SigninManager. Bug: 920210 Change-Id: I67b9505ad35270ca50356dade8e02fb478557000 Reviewed-on: https://chromium-review.googlesource.com/c/1414730 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#623173}
Changed files
- chrome/browser/extensions/api/identity/identity_apitest.cc
-
Use bigger tab view under accessibility font size.
Changed by Yi Su - mrsuyiohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 09:27:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 845594fab3d16176e416a25a65b9b9d5490effef Comments
Use bigger tab view under accessibility font size. This CL adjusts the size of tab views and height of their titles in tab grid under accessibility font size. Title will be displayed in 2 lines when accessibility font size is chosen. Screen shots: iPhoneXR: https://drive.google.com/open?id=1anVBsA3cOBumUqt38OpM6FtprLBFfup5 iPad landscape: 50%: https://drive.google.com/open?id=1E9m9Viqhval_l9Est8U1-sQktI7c_38l 66%: https://drive.google.com/open?id=1GuXD-miJgBPL3FnhlSRLoDrKMFa9xv0w 100%: https://drive.google.com/open?id=1jiAutUdf-wcACcckxtFbJFmS_S-2f7t2 iPad Portrait: 40%: https://drive.google.com/open?id=1A9WsE-_vT0kdzuAhEDNQH-UQtVqLGF53 60%: https://drive.google.com/open?id=1CR-holR-9JcuvMBjadrzWjcoDFuaJU4i 100%: https://drive.google.com/open?id=1k8BCFtqKavozdpoihA7tYg3PT7ho7Eo7 Bug: 893540 Change-Id: I314d081439909cf6f3711d06df579c73a9685e99 Reviewed-on: https://chromium-review.googlesource.com/c/1409546 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#623172}
Changed files
- ios/chrome/browser/ui/tab_grid/grid/grid_cell.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_constants.h
- ios/chrome/browser/ui/tab_grid/grid/grid_constants.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_layout.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
-
Implement accessible SetValue action for contenteditable
Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 09:26:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d9240658ffb6a5f156fd516ee478ced90e174349 Comments
Implement accessible SetValue action for contenteditable Bug: 917817 Change-Id: Id1586493b47f74ca960fdf934fb099ec79225519 Reviewed-on: https://chromium-review.googlesource.com/c/1411292 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#623171}
Changed files
- content/browser/accessibility/accessibility_action_browsertest.cc
- content/browser/accessibility/browser_accessibility_position.h
- third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
-
Enable PreloadImageSrcSet feature by default
Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 09:25:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 084ccc3b338f0a7410e687b5f48c44f7b700c365 Comments
Enable PreloadImageSrcSet feature by default This enables imagesrcset and imagesizes attributes on <link>. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/07CbItWfA4M/CG1qF8IoEAAJ Bug: 813452 Change-Id: I9396fe35729069ef56b461aa99cf85e9b1e51302 Reviewed-on: https://chromium-review.googlesource.com/c/1414513 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#623170}
Changed files
- third_party/blink/renderer/platform/runtime_enabled_features.json5
- third_party/blink/web_tests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
-
Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 16-Jan-19 09:25:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 85993946df7a29a6cf91461728f4c3521fd3ebec Comments
Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits) https://skia.googlesource.com/skia.git/+log/47b7cd9a6baf..a8694cc150a1 git log 47b7cd9a6baf..a8694cc150a1 --date=short --no-merges --format='%ad %ae %s' 2019-01-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@a8694cc150a1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ifbb52591de504e87cbe0f3452022f2085f41d315 Reviewed-on: https://chromium-review.googlesource.com/c/1414692 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623169}
Changed files
- DEPS
-
Fix bug of black bottom toolbar in landscape mode.
Changed by Yi Su - mrsuyiohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 09:22:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2c857442fcadb84aef4a606dad44fb5050de478b Comments
Fix bug of black bottom toolbar in landscape mode. When tab grid is opened in landscape mode on iPhone, the bottom toolbar has a black background instead of a transparent background. This is caused by setting toolbar background to UIColor.blackColor in TabGridBottomToolbar.hide(). This CL fixes it and doesn't affect the tab grid transition animation. This CL also sets the background for remote pages of tab grid in TabGridBottomToolbar.updateLayout(), which solves another potential bug. Bug: 920739 Change-Id: I9d84650b3a4e68796bb763fe87cb750afcd296e3 Reviewed-on: https://chromium-review.googlesource.com/c/1406809 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#623168}
Changed files
- ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
-
Navigation: Refactoring SendNavigate* functions in TestRFH.
Changed by Arthur Hemery - ahemeryohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 09:19:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 80e0d9ff46fe7eb550fa2671cb55ca656d193472 Comments
Navigation: Refactoring SendNavigate* functions in TestRFH. Following the merging of "Interfaces required at commit time" into a single mojom::DidCommitProvisionalLoadInterfaceParams, we factor all the DidCommit*Params creation and passing done in TestRenderFrameHost, to use the modern structures and dedicated functions. Change-Id: I077c053c23e22d36affd6130da4b6a722269e959 Reviewed-on: https://chromium-review.googlesource.com/c/1406815 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#623167}
Changed files
- content/test/test_render_frame_host.cc
- content/test/test_render_frame_host.h